{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/mlibrary/nebula/pulls/32","id":203885897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODg1ODk3","html_url":"https://github.com/mlibrary/nebula/pull/32","diff_url":"https://github.com/mlibrary/nebula/pull/32.diff","patch_url":"https://github.com/mlibrary/nebula/pull/32.patch","issue_url":"https://api.github.com/repos/mlibrary/nebula/issues/32","number":32,"state":"open","locked":false,"title":"AEIM-1293: rewrite throttling & whitelisting","user":{"login":"aelkiss","id":3856018,"node_id":"MDQ6VXNlcjM4NTYwMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3856018?v=4","gravatar_id":"","url":"https://api.github.com/users/aelkiss","html_url":"https://github.com/aelkiss","followers_url":"https://api.github.com/users/aelkiss/followers","following_url":"https://api.github.com/users/aelkiss/following{/other_user}","gists_url":"https://api.github.com/users/aelkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/aelkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelkiss/subscriptions","organizations_url":"https://api.github.com/users/aelkiss/orgs","repos_url":"https://api.github.com/users/aelkiss/repos","events_url":"https://api.github.com/users/aelkiss/events{/privacy}","received_events_url":"https://api.github.com/users/aelkiss/received_events","type":"User","site_admin":false},"body":"This addresses a couple major issues with the behavior of whitelisted\r\npaths in the previous design that are counter to how throttling\r\nworks in the NetScaler implementation:\r\n\r\n- If you requested only whitelisted paths, they still incremented the\r\nrequst rate. So, if you limited most requests to for example 10 requests\r\nper second, and you did 20 requests to whitelisted paths in one second,\r\nthe next request to a non-whitelisted path would get throttled.\r\n\r\n- With the temporary ban list in the front end but the whitelists in the\r\nback end, once you had gone over the request rate ALL requests to the\r\nfront-end would be denied, even those for whitelisted paths.\r\n\r\nNow:\r\n\r\n- Throttling only checks the average request rate in the backend -\r\nthere's no longer any blocking in the front end (we could bring that\r\nback if desired later while still maintaining the whitelist)\r\n\r\n- The whitelist is checked in the front end; there are separate\r\nback-ends for exempted requests. Whitelisted requests don't count\r\nagainst the limit and will be satisfied even if you've gone over the\r\nrequest rate\r\n\r\n- There is a combined request rate check for http + https requests -\r\nthere are separate tracking tables, but the ACL adds the rates and\r\ncompares to the limit.","created_at":"2018-07-25T15:58:30Z","updated_at":"2018-07-25T15:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlibrary/nebula/pulls/32/commits","review_comments_url":"https://api.github.com/repos/mlibrary/nebula/pulls/32/comments","review_comment_url":"https://api.github.com/repos/mlibrary/nebula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlibrary/nebula/issues/32/comments","statuses_url":"https://api.github.com/repos/mlibrary/nebula/statuses/cbaf562140c9f5ca7f0b693d9ea4a82950a8ae20","head":{"label":"mlibrary:aeim-1293-totally-rewrite-throttling","ref":"aeim-1293-totally-rewrite-throttling","sha":"cbaf562140c9f5ca7f0b693d9ea4a82950a8ae20","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":125879069,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4NzkwNjk=","name":"nebula","full_name":"mlibrary/nebula","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/nebula","description":":stars: Central puppet module","fork":false,"url":"https://api.github.com/repos/mlibrary/nebula","forks_url":"https://api.github.com/repos/mlibrary/nebula/forks","keys_url":"https://api.github.com/repos/mlibrary/nebula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/nebula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/nebula/teams","hooks_url":"https://api.github.com/repos/mlibrary/nebula/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/nebula/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/nebula/events","assignees_url":"https://api.github.com/repos/mlibrary/nebula/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/nebula/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/nebula/tags","blobs_url":"https://api.github.com/repos/mlibrary/nebula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/nebula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/nebula/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/nebula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/nebula/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/nebula/languages","stargazers_url":"https://api.github.com/repos/mlibrary/nebula/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/nebula/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/nebula/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/nebula/subscription","commits_url":"https://api.github.com/repos/mlibrary/nebula/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/nebula/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/nebula/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/nebula/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/nebula/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/nebula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/nebula/merges","archive_url":"https://api.github.com/repos/mlibrary/nebula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/nebula/downloads","issues_url":"https://api.github.com/repos/mlibrary/nebula/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/nebula/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/nebula/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/nebula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/nebula/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/nebula/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/nebula/deployments","created_at":"2018-03-19T15:23:53Z","updated_at":"2018-07-24T19:27:35Z","pushed_at":"2018-07-25T15:58:15Z","git_url":"git://github.com/mlibrary/nebula.git","ssh_url":"git@github.com:mlibrary/nebula.git","clone_url":"https://github.com/mlibrary/nebula.git","svn_url":"https://github.com/mlibrary/nebula","homepage":null,"size":304,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mlibrary:master","ref":"master","sha":"64903e1c310dd8fe92979705ee720da42d9fc345","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":125879069,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4NzkwNjk=","name":"nebula","full_name":"mlibrary/nebula","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/nebula","description":":stars: Central puppet module","fork":false,"url":"https://api.github.com/repos/mlibrary/nebula","forks_url":"https://api.github.com/repos/mlibrary/nebula/forks","keys_url":"https://api.github.com/repos/mlibrary/nebula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/nebula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/nebula/teams","hooks_url":"https://api.github.com/repos/mlibrary/nebula/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/nebula/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/nebula/events","assignees_url":"https://api.github.com/repos/mlibrary/nebula/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/nebula/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/nebula/tags","blobs_url":"https://api.github.com/repos/mlibrary/nebula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/nebula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/nebula/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/nebula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/nebula/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/nebula/languages","stargazers_url":"https://api.github.com/repos/mlibrary/nebula/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/nebula/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/nebula/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/nebula/subscription","commits_url":"https://api.github.com/repos/mlibrary/nebula/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/nebula/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/nebula/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/nebula/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/nebula/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/nebula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/nebula/merges","archive_url":"https://api.github.com/repos/mlibrary/nebula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/nebula/downloads","issues_url":"https://api.github.com/repos/mlibrary/nebula/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/nebula/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/nebula/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/nebula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/nebula/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/nebula/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/nebula/deployments","created_at":"2018-03-19T15:23:53Z","updated_at":"2018-07-24T19:27:35Z","pushed_at":"2018-07-25T15:58:15Z","git_url":"git://github.com/mlibrary/nebula.git","ssh_url":"git@github.com:mlibrary/nebula.git","clone_url":"https://github.com/mlibrary/nebula.git","svn_url":"https://github.com/mlibrary/nebula","homepage":null,"size":304,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlibrary/nebula/pulls/32"},"html":{"href":"https://github.com/mlibrary/nebula/pull/32"},"issue":{"href":"https://api.github.com/repos/mlibrary/nebula/issues/32"},"comments":{"href":"https://api.github.com/repos/mlibrary/nebula/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/mlibrary/nebula/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/mlibrary/nebula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlibrary/nebula/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/mlibrary/nebula/statuses/cbaf562140c9f5ca7f0b693d9ea4a82950a8ae20"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":91,"deletions":47,"changed_files":3}}
{"actor":{"display_login":"aelkiss"}}