{"action":"created","issue":{"url":"https://api.github.com/repos/kylebarron/stataParquet/issues/3","repository_url":"https://api.github.com/repos/kylebarron/stataParquet","labels_url":"https://api.github.com/repos/kylebarron/stataParquet/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/kylebarron/stataParquet/issues/3/comments","events_url":"https://api.github.com/repos/kylebarron/stataParquet/issues/3/events","html_url":"https://github.com/kylebarron/stataParquet/issues/3","id":378080449,"node_id":"MDU6SXNzdWUzNzgwODA0NDk=","number":3,"title":"Check for valid variable names when reading data","user":{"login":"kylebarron","id":15164633,"node_id":"MDQ6VXNlcjE1MTY0NjMz","avatar_url":"https://avatars3.githubusercontent.com/u/15164633?v=4","gravatar_id":"","url":"https://api.github.com/users/kylebarron","html_url":"https://github.com/kylebarron","followers_url":"https://api.github.com/users/kylebarron/followers","following_url":"https://api.github.com/users/kylebarron/following{/other_user}","gists_url":"https://api.github.com/users/kylebarron/gists{/gist_id}","starred_url":"https://api.github.com/users/kylebarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylebarron/subscriptions","organizations_url":"https://api.github.com/users/kylebarron/orgs","repos_url":"https://api.github.com/users/kylebarron/repos","events_url":"https://api.github.com/users/kylebarron/events{/privacy}","received_events_url":"https://api.github.com/users/kylebarron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-06T23:37:46Z","updated_at":"2018-11-07T04:54:56Z","closed_at":null,"author_association":"OWNER","body":"I.e. you can't name a variable `float`"},"comment":{"url":"https://api.github.com/repos/kylebarron/stataParquet/issues/comments/436504642","html_url":"https://github.com/kylebarron/stataParquet/issues/3#issuecomment-436504642","issue_url":"https://api.github.com/repos/kylebarron/stataParquet/issues/3","id":436504642,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjUwNDY0Mg==","user":{"login":"mcaceresb","id":4219197,"node_id":"MDQ6VXNlcjQyMTkxOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4219197?v=4","gravatar_id":"","url":"https://api.github.com/users/mcaceresb","html_url":"https://github.com/mcaceresb","followers_url":"https://api.github.com/users/mcaceresb/followers","following_url":"https://api.github.com/users/mcaceresb/following{/other_user}","gists_url":"https://api.github.com/users/mcaceresb/gists{/gist_id}","starred_url":"https://api.github.com/users/mcaceresb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcaceresb/subscriptions","organizations_url":"https://api.github.com/users/mcaceresb/orgs","repos_url":"https://api.github.com/users/mcaceresb/repos","events_url":"https://api.github.com/users/mcaceresb/events{/privacy}","received_events_url":"https://api.github.com/users/mcaceresb/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T04:54:56Z","updated_at":"2018-11-07T04:54:56Z","author_association":"NONE","body":"I do this in two parts. First I loop through to make valid theoretical Stata names in mata [here](https://github.com/mcaceresb/stata-parquet/blob/master/src/ado/parquet.ado#L511-L536), but that doesn't check reserved names, which I do later on [here](https://github.com/mcaceresb/stata-parquet/blob/master/src/ado/parquet.ado#L432-L447).\r\n\r\nYou can just do this in one step, though, because `strtoname()` is also a regular Stata function. So you can run strtoname, check for conflicts, and rename appropriately. I just added a counter (1, 2, 3, etc.)."}}
{"actor":{"display_login":"mcaceresb"}}