{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/177734864","pull_request_review_id":107659409,"id":177734864,"diff_hunk":"@@ -246,19 +241,18 @@ private DateTimeException assertCannotParse( String text )\n         throw new AssertionError( text );\n     }\n \n-    private static NanoOfDayAndOffset write( TimeValue value )\n+    private static OffsetTime write( TimeValue value )\n     {\n-        NanoOfDayAndOffset result = new NanoOfDayAndOffset();\n+        AtomicReference<OffsetTime> result = new AtomicReference<>();\n         value.writeTo( new ThrowingValueWriter.AssertOnly()\n         {\n             @Override\n-            public void writeTime( long nanosOfDayUTC, int offsetSeconds )\n+            public void writeTime( OffsetTime offsetTime )\n             {\n-                result.nanosOfDay = nanosOfDayUTC;\n-                result.offsetSeconds = offsetSeconds;\n+                result.set( offsetTime );\n             }\n         } );\n-        return result;\n+        return result.get();\n     }\n \n     private static class NanoOfDayAndOffset","path":"community/values/src/test/java/org/neo4j/values/storable/TimeValueTest.java","position":null,"original_position":87,"commit_id":"4fbdb984dc0fe8d5bdf9e71744a75af47961b8d7","original_commit_id":"899dbf42436e2be6d8219099af68da96ed9a6acf","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"Addressed in https://github.com/neo4j/neo4j/commit/68ea67b3082b2fe3e070a13a7ec8cae6ae5e786d","created_at":"2018-03-28T12:42:09Z","updated_at":"2018-03-28T12:42:09Z","html_url":"https://github.com/neo4j/neo4j/pull/11403#discussion_r177734864","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11403","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/177734864"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11403#discussion_r177734864"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11403"}},"in_reply_to_id":177665943},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11403","id":177790701,"html_url":"https://github.com/neo4j/neo4j/pull/11403","diff_url":"https://github.com/neo4j/neo4j/pull/11403.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11403.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11403","number":11403,"state":"closed","locked":false,"title":"No conversion to UTC for DateTime type in Bolt server","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"PR includes following changes:\r\n * Fix for `TimeValue` to only memorize `nanosOfDayUTC` value in [-18h, +42h] range\r\n * `ValueWriter` now gets access to temporal types from `java.time` package instead of their numeric representation. This allows different `ValueWriter`s to use different formats without double conversion\r\n * `PrettyPrinter` now prints temporal types as ISO strings. It is a `ValueWriter` and now has access to actual temporal objects which have nice `#toString()`\r\n * Bolt server sends and receives local `epochSecond` for `DateTime` values. It used to send `epochSecond` adjusted to UTC which forced drivers to perform additional conversion (especially tricky for named timezones) ","created_at":"2018-03-27T16:08:30Z","updated_at":"2018-03-28T12:42:09Z","closed_at":"2018-03-28T12:34:45Z","merged_at":"2018-03-28T12:34:45Z","merge_commit_sha":"755fcc9c55f9ff08b8f785ecef1f24fe228b1a6b","assignee":{"login":"sherfert","id":22634484,"avatar_url":"https://avatars0.githubusercontent.com/u/22634484?v=4","gravatar_id":"","url":"https://api.github.com/users/sherfert","html_url":"https://github.com/sherfert","followers_url":"https://api.github.com/users/sherfert/followers","following_url":"https://api.github.com/users/sherfert/following{/other_user}","gists_url":"https://api.github.com/users/sherfert/gists{/gist_id}","starred_url":"https://api.github.com/users/sherfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherfert/subscriptions","organizations_url":"https://api.github.com/users/sherfert/orgs","repos_url":"https://api.github.com/users/sherfert/repos","events_url":"https://api.github.com/users/sherfert/events{/privacy}","received_events_url":"https://api.github.com/users/sherfert/received_events","type":"User","site_admin":false},"assignees":[{"login":"sherfert","id":22634484,"avatar_url":"https://avatars0.githubusercontent.com/u/22634484?v=4","gravatar_id":"","url":"https://api.github.com/users/sherfert","html_url":"https://github.com/sherfert","followers_url":"https://api.github.com/users/sherfert/followers","following_url":"https://api.github.com/users/sherfert/following{/other_user}","gists_url":"https://api.github.com/users/sherfert/gists{/gist_id}","starred_url":"https://api.github.com/users/sherfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherfert/subscriptions","organizations_url":"https://api.github.com/users/sherfert/orgs","repos_url":"https://api.github.com/users/sherfert/repos","events_url":"https://api.github.com/users/sherfert/events{/privacy}","received_events_url":"https://api.github.com/users/sherfert/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"thobe","id":104385,"avatar_url":"https://avatars3.githubusercontent.com/u/104385?v=4","gravatar_id":"","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":695463446,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.4","name":"3.4","color":"f9d0c4","default":false},{"id":207302707,"url":"https://api.github.com/repos/neo4j/neo4j/labels/bolt%20server","name":"bolt server","color":"d4c5f9","default":false},{"id":19073042,"url":"https://api.github.com/repos/neo4j/neo4j/labels/cypher","name":"cypher","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11403/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11403/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11403/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/4fbdb984dc0fe8d5bdf9e71744a75af47961b8d7","head":{"label":"lutovich:3.4-value-writer-temporal","ref":"3.4-value-writer-temporal","sha":"4fbdb984dc0fe8d5bdf9e71744a75af47961b8d7","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"repo":{"id":21854315,"name":"neo4j","full_name":"lutovich/neo4j","owner":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lutovich/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/lutovich/neo4j","forks_url":"https://api.github.com/repos/lutovich/neo4j/forks","keys_url":"https://api.github.com/repos/lutovich/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutovich/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutovich/neo4j/teams","hooks_url":"https://api.github.com/repos/lutovich/neo4j/hooks","issue_events_url":"https://api.github.com/repos/lutovich/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/lutovich/neo4j/events","assignees_url":"https://api.github.com/repos/lutovich/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/lutovich/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/lutovich/neo4j/tags","blobs_url":"https://api.github.com/repos/lutovich/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutovich/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutovich/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutovich/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutovich/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/lutovich/neo4j/languages","stargazers_url":"https://api.github.com/repos/lutovich/neo4j/stargazers","contributors_url":"https://api.github.com/repos/lutovich/neo4j/contributors","subscribers_url":"https://api.github.com/repos/lutovich/neo4j/subscribers","subscription_url":"https://api.github.com/repos/lutovich/neo4j/subscription","commits_url":"https://api.github.com/repos/lutovich/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutovich/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutovich/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutovich/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutovich/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/lutovich/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutovich/neo4j/merges","archive_url":"https://api.github.com/repos/lutovich/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutovich/neo4j/downloads","issues_url":"https://api.github.com/repos/lutovich/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/lutovich/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/lutovich/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/lutovich/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutovich/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/lutovich/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/lutovich/neo4j/deployments","created_at":"2014-07-15T09:38:04Z","updated_at":"2015-02-24T16:59:41Z","pushed_at":"2018-03-28T12:37:21Z","git_url":"git://github.com/lutovich/neo4j.git","ssh_url":"git@github.com:lutovich/neo4j.git","clone_url":"https://github.com/lutovich/neo4j.git","svn_url":"https://github.com/lutovich/neo4j","homepage":"http://neo4j.org","size":404740,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"d6f6bae6752a6f92e45b2f41272762f3b0ba1af4","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-28T12:41:42Z","pushed_at":"2018-03-28T12:41:34Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":396914,"stargazers_count":4873,"watchers_count":4873,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1310,"mirror_url":null,"archived":false,"open_issues_count":338,"license":null,"forks":1310,"open_issues":338,"watchers":4873,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11403"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11403"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11403"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11403/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11403/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11403/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/4fbdb984dc0fe8d5bdf9e71744a75af47961b8d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lutovich"}}