{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/194826632","pull_request_review_id":128071982,"id":194826632,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgyNjYzMg==","diff_hunk":"@@ -64,8 +68,10 @@ void LdsApiImpl::onConfigUpdate(const ResourceVector& resources, const std::stri\n         ENVOY_LOG(debug, \"lds: add/update listener '{}' skipped\", listener_name);\n       }\n     } catch (const EnvoyException& e) {\n-      throw EnvoyException(\n-          fmt::format(\"Error adding/updating listener {}: {}\", listener_name, e.what()));\n+      // retry after the remove opertions are performed to allow new listeners\n+      // with addresses used by other listeners that have to be removed.\n+      listeners_to_retry.push_back(listener);","path":"source/server/lds_api.cc","position":null,"original_position":19,"commit_id":"d471cbf3a8eec3e79095139e715252e1e676a672","original_commit_id":"3c00e692ffc87c71c21d98d160351cdd7f26b053","user":{"login":"mbanikazemi","id":6667940,"node_id":"MDQ6VXNlcjY2Njc5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6667940?v=4","gravatar_id":"","url":"https://api.github.com/users/mbanikazemi","html_url":"https://github.com/mbanikazemi","followers_url":"https://api.github.com/users/mbanikazemi/followers","following_url":"https://api.github.com/users/mbanikazemi/following{/other_user}","gists_url":"https://api.github.com/users/mbanikazemi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbanikazemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbanikazemi/subscriptions","organizations_url":"https://api.github.com/users/mbanikazemi/orgs","repos_url":"https://api.github.com/users/mbanikazemi/repos","events_url":"https://api.github.com/users/mbanikazemi/events{/privacy}","received_events_url":"https://api.github.com/users/mbanikazemi/received_events","type":"User","site_admin":false},"body":"Yes, that makes sense. ","created_at":"2018-06-12T17:34:25Z","updated_at":"2018-06-12T17:34:25Z","html_url":"https://github.com/envoyproxy/envoy/pull/3593#discussion_r194826632","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/194826632"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3593#discussion_r194826632"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593"}},"in_reply_to_id":194801638},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593","id":194142400,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTQyNDAw","html_url":"https://github.com/envoyproxy/envoy/pull/3593","diff_url":"https://github.com/envoyproxy/envoy/pull/3593.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3593.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3593","number":3593,"state":"open","locked":false,"title":"Allow replacing listener on the same address with different name","user":{"login":"mbanikazemi","id":6667940,"node_id":"MDQ6VXNlcjY2Njc5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6667940?v=4","gravatar_id":"","url":"https://api.github.com/users/mbanikazemi","html_url":"https://github.com/mbanikazemi","followers_url":"https://api.github.com/users/mbanikazemi/followers","following_url":"https://api.github.com/users/mbanikazemi/following{/other_user}","gists_url":"https://api.github.com/users/mbanikazemi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbanikazemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbanikazemi/subscriptions","organizations_url":"https://api.github.com/users/mbanikazemi/orgs","repos_url":"https://api.github.com/users/mbanikazemi/repos","events_url":"https://api.github.com/users/mbanikazemi/events{/privacy}","received_events_url":"https://api.github.com/users/mbanikazemi/received_events","type":"User","site_admin":false},"body":"This allows an update where a listener is to be removed and another\r\nlistener with a different name but with the same address is to be\r\ncreated. This is accomplished without requiring removal of all\r\nlisteners before adding the new ones.\r\n\r\nFixes: #2096\r\n\r\nSigned-off-by: Mohammad Banikazemi <MBanikazemi@gmail.com>\r\n","created_at":"2018-06-12T01:13:55Z","updated_at":"2018-06-12T17:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758e6d61ff5996d1591b05752f8ed14c09ce9e80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3593/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/d471cbf3a8eec3e79095139e715252e1e676a672","head":{"label":"mbanikazemi:2096","ref":"2096","sha":"d471cbf3a8eec3e79095139e715252e1e676a672","user":{"login":"mbanikazemi","id":6667940,"node_id":"MDQ6VXNlcjY2Njc5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6667940?v=4","gravatar_id":"","url":"https://api.github.com/users/mbanikazemi","html_url":"https://github.com/mbanikazemi","followers_url":"https://api.github.com/users/mbanikazemi/followers","following_url":"https://api.github.com/users/mbanikazemi/following{/other_user}","gists_url":"https://api.github.com/users/mbanikazemi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbanikazemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbanikazemi/subscriptions","organizations_url":"https://api.github.com/users/mbanikazemi/orgs","repos_url":"https://api.github.com/users/mbanikazemi/repos","events_url":"https://api.github.com/users/mbanikazemi/events{/privacy}","received_events_url":"https://api.github.com/users/mbanikazemi/received_events","type":"User","site_admin":false},"repo":{"id":129782717,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3ODI3MTc=","name":"envoy","full_name":"mbanikazemi/envoy","owner":{"login":"mbanikazemi","id":6667940,"node_id":"MDQ6VXNlcjY2Njc5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6667940?v=4","gravatar_id":"","url":"https://api.github.com/users/mbanikazemi","html_url":"https://github.com/mbanikazemi","followers_url":"https://api.github.com/users/mbanikazemi/followers","following_url":"https://api.github.com/users/mbanikazemi/following{/other_user}","gists_url":"https://api.github.com/users/mbanikazemi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbanikazemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbanikazemi/subscriptions","organizations_url":"https://api.github.com/users/mbanikazemi/orgs","repos_url":"https://api.github.com/users/mbanikazemi/repos","events_url":"https://api.github.com/users/mbanikazemi/events{/privacy}","received_events_url":"https://api.github.com/users/mbanikazemi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbanikazemi/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/mbanikazemi/envoy","forks_url":"https://api.github.com/repos/mbanikazemi/envoy/forks","keys_url":"https://api.github.com/repos/mbanikazemi/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbanikazemi/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbanikazemi/envoy/teams","hooks_url":"https://api.github.com/repos/mbanikazemi/envoy/hooks","issue_events_url":"https://api.github.com/repos/mbanikazemi/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/mbanikazemi/envoy/events","assignees_url":"https://api.github.com/repos/mbanikazemi/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/mbanikazemi/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/mbanikazemi/envoy/tags","blobs_url":"https://api.github.com/repos/mbanikazemi/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbanikazemi/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbanikazemi/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbanikazemi/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbanikazemi/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/mbanikazemi/envoy/languages","stargazers_url":"https://api.github.com/repos/mbanikazemi/envoy/stargazers","contributors_url":"https://api.github.com/repos/mbanikazemi/envoy/contributors","subscribers_url":"https://api.github.com/repos/mbanikazemi/envoy/subscribers","subscription_url":"https://api.github.com/repos/mbanikazemi/envoy/subscription","commits_url":"https://api.github.com/repos/mbanikazemi/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbanikazemi/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbanikazemi/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbanikazemi/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbanikazemi/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/mbanikazemi/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbanikazemi/envoy/merges","archive_url":"https://api.github.com/repos/mbanikazemi/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbanikazemi/envoy/downloads","issues_url":"https://api.github.com/repos/mbanikazemi/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/mbanikazemi/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/mbanikazemi/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/mbanikazemi/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbanikazemi/envoy/labels{/name}","releases_url":"https://api.github.com/repos/mbanikazemi/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/mbanikazemi/envoy/deployments","created_at":"2018-04-16T17:42:49Z","updated_at":"2018-06-12T00:52:50Z","pushed_at":"2018-06-12T17:34:01Z","git_url":"git://github.com/mbanikazemi/envoy.git","ssh_url":"git@github.com:mbanikazemi/envoy.git","clone_url":"https://github.com/mbanikazemi/envoy.git","svn_url":"https://github.com/mbanikazemi/envoy","homepage":"https://www.envoyproxy.io","size":16248,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"28cea916a2a23c25d9175373c0413610586f5a16","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-06-12T17:27:09Z","pushed_at":"2018-06-12T17:34:02Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":16242,"stargazers_count":5202,"watchers_count":5202,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":669,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":669,"open_issues":309,"watchers":5202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3593"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3593"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3593/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3593/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/d471cbf3a8eec3e79095139e715252e1e676a672"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mbanikazemi"}}