{"action":"created","comment":{"url":"https://api.github.com/repos/highcharts/highcharts/pulls/comments/205103494","pull_request_review_id":140305391,"id":205103494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTEwMzQ5NA==","diff_hunk":"@@ -4,12 +4,39 @@ import '../parts/Utilities.js';\n \n var pick = H.pick,\n     each = H.each,\n+    extend = H.extend,\n+    wrap = H.wrap,\n     error = H.error,\n     Series = H.Series,\n     isArray = H.isArray,\n     addEvent = H.addEvent,\n     seriesType = H.seriesType;\n \n+/*\n+ * Support for OHLC data with line type of series.\n+ */\n+wrap(H.Series.prototype, 'init', function (proceed, chart, options) {","path":"js/indicators/indicators.src.js","position":null,"original_position":15,"commit_id":"1173962ad348c07b576a0ed54398af64c62f2fc1","original_commit_id":"96b9cffe3166d5d109fd4e4a0792dca3366fa375","user":{"login":"pawelfus","id":1453926,"node_id":"MDQ6VXNlcjE0NTM5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1453926?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelfus","html_url":"https://github.com/pawelfus","followers_url":"https://api.github.com/users/pawelfus/followers","following_url":"https://api.github.com/users/pawelfus/following{/other_user}","gists_url":"https://api.github.com/users/pawelfus/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelfus/subscriptions","organizations_url":"https://api.github.com/users/pawelfus/orgs","repos_url":"https://api.github.com/users/pawelfus/repos","events_url":"https://api.github.com/users/pawelfus/events{/privacy}","received_events_url":"https://api.github.com/users/pawelfus/received_events","type":"User","site_admin":false},"body":"I mean add in the core `fireEvent(series, 'init')` then use `addEvent(H.Series, 'init', function () { .. });` instead of `wrap()`.","created_at":"2018-07-25T13:17:07Z","updated_at":"2018-07-25T13:17:07Z","html_url":"https://github.com/highcharts/highcharts/pull/8679#discussion_r205103494","pull_request_url":"https://api.github.com/repos/highcharts/highcharts/pulls/8679","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/comments/205103494"},"html":{"href":"https://github.com/highcharts/highcharts/pull/8679#discussion_r205103494"},"pull_request":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/8679"}},"in_reply_to_id":205051330},"pull_request":{"url":"https://api.github.com/repos/highcharts/highcharts/pulls/8679","id":203777086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzc3MDg2","html_url":"https://github.com/highcharts/highcharts/pull/8679","diff_url":"https://github.com/highcharts/highcharts/pull/8679.diff","patch_url":"https://github.com/highcharts/highcharts/pull/8679.patch","issue_url":"https://api.github.com/repos/highcharts/highcharts/issues/8679","number":8679,"state":"open","locked":false,"title":"Indicators: Support for OHLC data with line type of series.","user":{"login":"sebastianbochan","id":2115686,"node_id":"MDQ6VXNlcjIxMTU2ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/2115686?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastianbochan","html_url":"https://github.com/sebastianbochan","followers_url":"https://api.github.com/users/sebastianbochan/followers","following_url":"https://api.github.com/users/sebastianbochan/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbochan/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbochan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbochan/subscriptions","organizations_url":"https://api.github.com/users/sebastianbochan/orgs","repos_url":"https://api.github.com/users/sebastianbochan/repos","events_url":"https://api.github.com/users/sebastianbochan/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbochan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-25T09:35:09Z","updated_at":"2018-07-25T13:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbbbdd157d884742c7e1d3d2b9adc73bc31c100e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/highcharts/highcharts/pulls/8679/commits","review_comments_url":"https://api.github.com/repos/highcharts/highcharts/pulls/8679/comments","review_comment_url":"https://api.github.com/repos/highcharts/highcharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highcharts/highcharts/issues/8679/comments","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/1173962ad348c07b576a0ed54398af64c62f2fc1","head":{"label":"highcharts:hc7/line-series-ohlc-data","ref":"hc7/line-series-ohlc-data","sha":"1173962ad348c07b576a0ed54398af64c62f2fc1","user":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"repo":{"id":715547,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU1NDc=","name":"highcharts","full_name":"highcharts/highcharts","owner":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highcharts/highcharts","description":"Highcharts JS, the JavaScript charting framework","fork":false,"url":"https://api.github.com/repos/highcharts/highcharts","forks_url":"https://api.github.com/repos/highcharts/highcharts/forks","keys_url":"https://api.github.com/repos/highcharts/highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highcharts/highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highcharts/highcharts/teams","hooks_url":"https://api.github.com/repos/highcharts/highcharts/hooks","issue_events_url":"https://api.github.com/repos/highcharts/highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/highcharts/highcharts/events","assignees_url":"https://api.github.com/repos/highcharts/highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/highcharts/highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/highcharts/highcharts/tags","blobs_url":"https://api.github.com/repos/highcharts/highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highcharts/highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highcharts/highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/highcharts/highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/highcharts/highcharts/languages","stargazers_url":"https://api.github.com/repos/highcharts/highcharts/stargazers","contributors_url":"https://api.github.com/repos/highcharts/highcharts/contributors","subscribers_url":"https://api.github.com/repos/highcharts/highcharts/subscribers","subscription_url":"https://api.github.com/repos/highcharts/highcharts/subscription","commits_url":"https://api.github.com/repos/highcharts/highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/highcharts/highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/highcharts/highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/highcharts/highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/highcharts/highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/highcharts/highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highcharts/highcharts/merges","archive_url":"https://api.github.com/repos/highcharts/highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highcharts/highcharts/downloads","issues_url":"https://api.github.com/repos/highcharts/highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/highcharts/highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/highcharts/highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/highcharts/highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highcharts/highcharts/labels{/name}","releases_url":"https://api.github.com/repos/highcharts/highcharts/releases{/id}","deployments_url":"https://api.github.com/repos/highcharts/highcharts/deployments","created_at":"2010-06-11T12:23:53Z","updated_at":"2018-07-25T11:55:18Z","pushed_at":"2018-07-25T12:49:20Z","git_url":"git://github.com/highcharts/highcharts.git","ssh_url":"git@github.com:highcharts/highcharts.git","clone_url":"https://github.com/highcharts/highcharts.git","svn_url":"https://github.com/highcharts/highcharts","homepage":"www.highcharts.com","size":190730,"stargazers_count":7805,"watchers_count":7805,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2214,"mirror_url":null,"archived":false,"open_issues_count":1525,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2214,"open_issues":1525,"watchers":7805,"default_branch":"master"}},"base":{"label":"highcharts:hs7/stock-tools","ref":"hs7/stock-tools","sha":"ae5672d180e2bd13f4bb95606ad43f8c53968577","user":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"repo":{"id":715547,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU1NDc=","name":"highcharts","full_name":"highcharts/highcharts","owner":{"login":"highcharts","id":15981345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1OTgxMzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/15981345?v=4","gravatar_id":"","url":"https://api.github.com/users/highcharts","html_url":"https://github.com/highcharts","followers_url":"https://api.github.com/users/highcharts/followers","following_url":"https://api.github.com/users/highcharts/following{/other_user}","gists_url":"https://api.github.com/users/highcharts/gists{/gist_id}","starred_url":"https://api.github.com/users/highcharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highcharts/subscriptions","organizations_url":"https://api.github.com/users/highcharts/orgs","repos_url":"https://api.github.com/users/highcharts/repos","events_url":"https://api.github.com/users/highcharts/events{/privacy}","received_events_url":"https://api.github.com/users/highcharts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highcharts/highcharts","description":"Highcharts JS, the JavaScript charting framework","fork":false,"url":"https://api.github.com/repos/highcharts/highcharts","forks_url":"https://api.github.com/repos/highcharts/highcharts/forks","keys_url":"https://api.github.com/repos/highcharts/highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highcharts/highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highcharts/highcharts/teams","hooks_url":"https://api.github.com/repos/highcharts/highcharts/hooks","issue_events_url":"https://api.github.com/repos/highcharts/highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/highcharts/highcharts/events","assignees_url":"https://api.github.com/repos/highcharts/highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/highcharts/highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/highcharts/highcharts/tags","blobs_url":"https://api.github.com/repos/highcharts/highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highcharts/highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highcharts/highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/highcharts/highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highcharts/highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/highcharts/highcharts/languages","stargazers_url":"https://api.github.com/repos/highcharts/highcharts/stargazers","contributors_url":"https://api.github.com/repos/highcharts/highcharts/contributors","subscribers_url":"https://api.github.com/repos/highcharts/highcharts/subscribers","subscription_url":"https://api.github.com/repos/highcharts/highcharts/subscription","commits_url":"https://api.github.com/repos/highcharts/highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/highcharts/highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/highcharts/highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/highcharts/highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/highcharts/highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/highcharts/highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highcharts/highcharts/merges","archive_url":"https://api.github.com/repos/highcharts/highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highcharts/highcharts/downloads","issues_url":"https://api.github.com/repos/highcharts/highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/highcharts/highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/highcharts/highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/highcharts/highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highcharts/highcharts/labels{/name}","releases_url":"https://api.github.com/repos/highcharts/highcharts/releases{/id}","deployments_url":"https://api.github.com/repos/highcharts/highcharts/deployments","created_at":"2010-06-11T12:23:53Z","updated_at":"2018-07-25T11:55:18Z","pushed_at":"2018-07-25T12:49:20Z","git_url":"git://github.com/highcharts/highcharts.git","ssh_url":"git@github.com:highcharts/highcharts.git","clone_url":"https://github.com/highcharts/highcharts.git","svn_url":"https://github.com/highcharts/highcharts","homepage":"www.highcharts.com","size":190730,"stargazers_count":7805,"watchers_count":7805,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2214,"mirror_url":null,"archived":false,"open_issues_count":1525,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2214,"open_issues":1525,"watchers":7805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/8679"},"html":{"href":"https://github.com/highcharts/highcharts/pull/8679"},"issue":{"href":"https://api.github.com/repos/highcharts/highcharts/issues/8679"},"comments":{"href":"https://api.github.com/repos/highcharts/highcharts/issues/8679/comments"},"review_comments":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/8679/comments"},"review_comment":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highcharts/highcharts/pulls/8679/commits"},"statuses":{"href":"https://api.github.com/repos/highcharts/highcharts/statuses/1173962ad348c07b576a0ed54398af64c62f2fc1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pawelfus"}}