{"action":"created","issue":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/1615","repository_url":"https://api.github.com/repos/fable-compiler/Fable","labels_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1615/labels{/name}","comments_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1615/comments","events_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1615/events","html_url":"https://github.com/fable-compiler/Fable/pull/1615","id":372591720,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzM0NjI1","number":1615,"title":"[WIP] Adding Babel types","user":{"login":"ncave","id":777696,"node_id":"MDQ6VXNlcjc3NzY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/777696?v=4","gravatar_id":"","url":"https://api.github.com/users/ncave","html_url":"https://github.com/ncave","followers_url":"https://api.github.com/users/ncave/followers","following_url":"https://api.github.com/users/ncave/following{/other_user}","gists_url":"https://api.github.com/users/ncave/gists{/gist_id}","starred_url":"https://api.github.com/users/ncave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncave/subscriptions","organizations_url":"https://api.github.com/users/ncave/orgs","repos_url":"https://api.github.com/users/ncave/repos","events_url":"https://api.github.com/users/ncave/events{/privacy}","received_events_url":"https://api.github.com/users/ncave/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-22T16:21:55Z","updated_at":"2018-11-19T22:34:27Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fable-compiler/Fable/pulls/1615","html_url":"https://github.com/fable-compiler/Fable/pull/1615","diff_url":"https://github.com/fable-compiler/Fable/pull/1615.diff","patch_url":"https://github.com/fable-compiler/Fable/pull/1615.patch"},"body":"Please do not merge, this is an incomplete WIP.\r\nThis is trying to bring back some of the Babel types from Fable 1.x\r\n\r\n@alfonsogarciacaro A few questions, if you have the time to take a quick look:\r\n- Do we need to keep generic arg list in `AST.Fable.FunctionKind` and `AST.Fable.ObjectMemberKind`?\r\n- Obviously more types need to be properly extracted and set, e.g. for arrow func expressions, etc.\r\n- Anything else that catches your eye."},"comment":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/comments/440066625","html_url":"https://github.com/fable-compiler/Fable/pull/1615#issuecomment-440066625","issue_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1615","id":440066625,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDA2NjYyNQ==","user":{"login":"alfonsogarciacaro","id":8275461,"node_id":"MDQ6VXNlcjgyNzU0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/8275461?v=4","gravatar_id":"","url":"https://api.github.com/users/alfonsogarciacaro","html_url":"https://github.com/alfonsogarciacaro","followers_url":"https://api.github.com/users/alfonsogarciacaro/followers","following_url":"https://api.github.com/users/alfonsogarciacaro/following{/other_user}","gists_url":"https://api.github.com/users/alfonsogarciacaro/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsogarciacaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsogarciacaro/subscriptions","organizations_url":"https://api.github.com/users/alfonsogarciacaro/orgs","repos_url":"https://api.github.com/users/alfonsogarciacaro/repos","events_url":"https://api.github.com/users/alfonsogarciacaro/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsogarciacaro/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T22:34:27Z","updated_at":"2018-11-19T22:34:27Z","author_association":"MEMBER","body":"@ncave Probably you can use [entityRefMaybeImported](https://github.com/fable-compiler/Fable/blob/ff477c73ac29066a66334ca6dec7ff7db7c0451a/src/dotnet/Fable.Compiler/Transforms/Fable2Babel.fs#L195-L205) which is used to get the constructor function reference. But it doesn't work for the \"primitive\" types. We'll probably need a pattern matching [like this one](https://github.com/fable-compiler/Fable/blob/ff477c73ac29066a66334ca6dec7ff7db7c0451a/src/dotnet/Fable.Compiler/Transforms/Fable2Babel.fs#L590-L625) to cover all cases."}}
{"actor":{"display_login":"alfonsogarciacaro"}}