{"action":"created","issue":{"url":"https://api.github.com/repos/tixxit/delimited/issues/27","repository_url":"https://api.github.com/repos/tixxit/delimited","labels_url":"https://api.github.com/repos/tixxit/delimited/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/tixxit/delimited/issues/27/comments","events_url":"https://api.github.com/repos/tixxit/delimited/issues/27/events","html_url":"https://github.com/tixxit/delimited/pull/27","id":324213005,"number":27,"title":"Turn off -optimize","user":{"login":"travisbrown-stripe","id":28275810,"avatar_url":"https://avatars0.githubusercontent.com/u/28275810?v=4","gravatar_id":"","url":"https://api.github.com/users/travisbrown-stripe","html_url":"https://github.com/travisbrown-stripe","followers_url":"https://api.github.com/users/travisbrown-stripe/followers","following_url":"https://api.github.com/users/travisbrown-stripe/following{/other_user}","gists_url":"https://api.github.com/users/travisbrown-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbrown-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbrown-stripe/subscriptions","organizations_url":"https://api.github.com/users/travisbrown-stripe/orgs","repos_url":"https://api.github.com/users/travisbrown-stripe/repos","events_url":"https://api.github.com/users/travisbrown-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/travisbrown-stripe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-17T22:52:48Z","updated_at":"2018-05-17T23:00:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tixxit/delimited/pulls/27","html_url":"https://github.com/tixxit/delimited/pull/27","diff_url":"https://github.com/tixxit/delimited/pull/27.diff","patch_url":"https://github.com/tixxit/delimited/pull/27.patch"},"body":"We're running into issues trying to use delimited on later 2.12 versions while the library is built on 2.12.2, because inlining breaks compatibility between Scala patch versions. \r\n\r\nQuick benchmark run to show that removing the flag doesn't have a catastrophic impact on performance:\r\n\r\nBefore:\r\n```\r\nBenchmark                                 Mode  Cnt     Score     Error  Units\r\nDelimitedParserBenchmark.parseNarrowTSV  thrpt   25  1427.362 ± 110.572  ops/s\r\nDelimitedParserBenchmark.parseWideTSV    thrpt   25    44.284 ±  10.658  ops/s\r\n```\r\n\r\nAfter:\r\n```\r\nBenchmark                                 Mode  Cnt     Score     Error  Units\r\nDelimitedParserBenchmark.parseNarrowTSV  thrpt   25  1406.817 ± 199.414  ops/s\r\nDelimitedParserBenchmark.parseWideTSV    thrpt   25    50.875 ±   7.101  ops/s\r\n```\r\n\r\nI've also bumped a few patch versions."},"comment":{"url":"https://api.github.com/repos/tixxit/delimited/issues/comments/390039703","html_url":"https://github.com/tixxit/delimited/pull/27#issuecomment-390039703","issue_url":"https://api.github.com/repos/tixxit/delimited/issues/27","id":390039703,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T23:00:41Z","updated_at":"2018-05-17T23:00:41Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=h1) Report\n> Merging [#27](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=desc) into [master](https://codecov.io/gh/tixxit/delimited/commit/1dadf81bfd4c641498eec7c2bcbe84ac39c15719?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/tixxit/delimited/pull/27/graphs/tree.svg?token=61w2y6pea0&src=pr&width=650&height=150)](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=tree)\n\n```diff\n@@         Coverage Diff          @@\n##           master   #27   +/-   ##\n====================================\n  Coverage       0%    0%           \n====================================\n  Files          11    11           \n  Lines         401   401           \n  Branches       41    41           \n====================================\n  Misses        401   401\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=footer). Last update [1dadf81...95f0230](https://codecov.io/gh/tixxit/delimited/pull/27?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}