{"action":"created","issue":{"url":"https://api.github.com/repos/linode/manager/issues/3112","repository_url":"https://api.github.com/repos/linode/manager","labels_url":"https://api.github.com/repos/linode/manager/issues/3112/labels{/name}","comments_url":"https://api.github.com/repos/linode/manager/issues/3112/comments","events_url":"https://api.github.com/repos/linode/manager/issues/3112/events","html_url":"https://github.com/linode/manager/pull/3112","id":310115443,"number":3112,"title":"M3-207 - Checkbox Component UI Test","user":{"login":"patthiel","id":12736578,"avatar_url":"https://avatars3.githubusercontent.com/u/12736578?v=4","gravatar_id":"","url":"https://api.github.com/users/patthiel","html_url":"https://github.com/patthiel","followers_url":"https://api.github.com/users/patthiel/followers","following_url":"https://api.github.com/users/patthiel/following{/other_user}","gists_url":"https://api.github.com/users/patthiel/gists{/gist_id}","starred_url":"https://api.github.com/users/patthiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patthiel/subscriptions","organizations_url":"https://api.github.com/users/patthiel/orgs","repos_url":"https://api.github.com/users/patthiel/repos","events_url":"https://api.github.com/users/patthiel/events{/privacy}","received_events_url":"https://api.github.com/users/patthiel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-30T16:57:46Z","updated_at":"2018-04-02T16:40:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linode/manager/pulls/3112","html_url":"https://github.com/linode/manager/pull/3112","diff_url":"https://github.com/linode/manager/pull/3112.diff","patch_url":"https://github.com/linode/manager/pull/3112.patch"},"body":"* Added storybook webdriverIO configuration file (should be separate config from the standard wdio manager config since different spec folder paths, baseUrls, pre-test setup hooks, etc). Inherit everything from wdio.conf.js and override specific config values.\r\n* Added jsClick and jsClickAll browser custom commands, useful when attempting to click an element throws a selenium error like \"other element would receive click\"\r\n* Bumped chromedriver version to latest.\r\n* Added storybook homepage route to constants.js\r\n* Created test suite for Checkbox UI Component\r\n* Added `data-qa` attribute to checkbox component\r\n* Added `storybook:e2e` yarn script.\r\n* Updated docker scripts to remove containers after they exit, and to no longer hardcode the container names.\r\n\r\n**NOTE:**  i made the component ui test specs live inside each component folder. I think this sort of test (especially since they can be run very quickly) should live longside the component in the code base. Since it is not typescript though, it will not be linted via `yarn lint`. I can configure eslint in a branch to lint e2e tests contained in here though\r\n\r\n## To Test:\r\n1. Start storybook: `yarn docker:storybook`\r\n2. (New shell) Start selenium: `yarn selenium`\r\n3. (New shell) Run the tests: `yarn storybook:e2e`"},"comment":{"url":"https://api.github.com/repos/linode/manager/issues/comments/377973132","html_url":"https://github.com/linode/manager/pull/3112#issuecomment-377973132","issue_url":"https://api.github.com/repos/linode/manager/issues/3112","id":377973132,"user":{"login":"asauber","id":2046750,"avatar_url":"https://avatars0.githubusercontent.com/u/2046750?v=4","gravatar_id":"","url":"https://api.github.com/users/asauber","html_url":"https://github.com/asauber","followers_url":"https://api.github.com/users/asauber/followers","following_url":"https://api.github.com/users/asauber/following{/other_user}","gists_url":"https://api.github.com/users/asauber/gists{/gist_id}","starred_url":"https://api.github.com/users/asauber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asauber/subscriptions","organizations_url":"https://api.github.com/users/asauber/orgs","repos_url":"https://api.github.com/users/asauber/repos","events_url":"https://api.github.com/users/asauber/events{/privacy}","received_events_url":"https://api.github.com/users/asauber/received_events","type":"User","site_admin":false},"created_at":"2018-04-02T16:40:10Z","updated_at":"2018-04-02T16:40:10Z","author_association":"MEMBER","body":"Looks great, tests are easy to run. A few requested changes."}}
{"actor":{"display_login":"asauber"}}