{"action":"created","comment":{"url":"https://api.github.com/repos/garbear/xbmc/pulls/comments/194944148","pull_request_review_id":128213235,"id":194944148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDk0NDE0OA==","diff_hunk":"@@ -452,35 +485,37 @@ IRenderBuffer *CRPRenderManager::GetRenderBuffer(IRenderBufferPool *bufferPool)\n \n void CRPRenderManager::CreateRenderBuffer(IRenderBufferPool *bufferPool)\n {\n+  if (m_bFlush || m_state != RENDER_STATE::CONFIGURED)\n+    return;\n+\n   CSingleLock lock(m_bufferMutex);\n \n   if (!HasRenderBuffer(bufferPool) && m_bHasCachedFrame)\n   {\n     std::vector<uint8_t> cachedFrame = std::move(m_cachedFrame);\n-    if (!cachedFrame.empty())","path":"xbmc/cores/RetroPlayer/rendering/RPRenderManager.cpp","position":null,"original_position":151,"commit_id":"b65b16feb57c093777b740ce1325b87258eae0ed","original_commit_id":"c309cc4bd54336e53f998d0cd19e34d80a8f7aa1","user":{"login":"GTechAlpha","id":31323818,"node_id":"MDQ6VXNlcjMxMzIzODE4","avatar_url":"https://avatars1.githubusercontent.com/u/31323818?v=4","gravatar_id":"","url":"https://api.github.com/users/GTechAlpha","html_url":"https://github.com/GTechAlpha","followers_url":"https://api.github.com/users/GTechAlpha/followers","following_url":"https://api.github.com/users/GTechAlpha/following{/other_user}","gists_url":"https://api.github.com/users/GTechAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/GTechAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GTechAlpha/subscriptions","organizations_url":"https://api.github.com/users/GTechAlpha/orgs","repos_url":"https://api.github.com/users/GTechAlpha/repos","events_url":"https://api.github.com/users/GTechAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/GTechAlpha/received_events","type":"User","site_admin":false},"body":"Re-added","created_at":"2018-06-13T02:53:34Z","updated_at":"2018-06-13T02:53:34Z","html_url":"https://github.com/garbear/xbmc/pull/98#discussion_r194944148","pull_request_url":"https://api.github.com/repos/garbear/xbmc/pulls/98","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/comments/194944148"},"html":{"href":"https://github.com/garbear/xbmc/pull/98#discussion_r194944148"},"pull_request":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/98"}},"in_reply_to_id":194783637},"pull_request":{"url":"https://api.github.com/repos/garbear/xbmc/pulls/98","id":194151890,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTUxODkw","html_url":"https://github.com/garbear/xbmc/pull/98","diff_url":"https://github.com/garbear/xbmc/pull/98.diff","patch_url":"https://github.com/garbear/xbmc/pull/98.patch","issue_url":"https://api.github.com/repos/garbear/xbmc/issues/98","number":98,"state":"open","locked":false,"title":"[RetroPlayer] Add basic resolution changing","user":{"login":"GTechAlpha","id":31323818,"node_id":"MDQ6VXNlcjMxMzIzODE4","avatar_url":"https://avatars1.githubusercontent.com/u/31323818?v=4","gravatar_id":"","url":"https://api.github.com/users/GTechAlpha","html_url":"https://github.com/GTechAlpha","followers_url":"https://api.github.com/users/GTechAlpha/followers","following_url":"https://api.github.com/users/GTechAlpha/following{/other_user}","gists_url":"https://api.github.com/users/GTechAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/GTechAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GTechAlpha/subscriptions","organizations_url":"https://api.github.com/users/GTechAlpha/orgs","repos_url":"https://api.github.com/users/GTechAlpha/repos","events_url":"https://api.github.com/users/GTechAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/GTechAlpha/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\nAdd basic resolution changing.\r\n\r\n## Motivation and Context\r\nRetroPlayer does not render after resolution change.\r\n\r\n## How Has This Been Tested?\r\nPCSX, GenesisPlus, Nestopia. Example: FFVII on PCSX changes resolution every time the in-game menu is accessed.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n","created_at":"2018-06-12T02:40:12Z","updated_at":"2018-06-13T02:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fba74a1df2176380c37dc2133b227e9e9adda3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/garbear/xbmc/pulls/98/commits","review_comments_url":"https://api.github.com/repos/garbear/xbmc/pulls/98/comments","review_comment_url":"https://api.github.com/repos/garbear/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/garbear/xbmc/issues/98/comments","statuses_url":"https://api.github.com/repos/garbear/xbmc/statuses/b65b16feb57c093777b740ce1325b87258eae0ed","head":{"label":"GTechAlpha:gb_pr_video_resolution_18a2","ref":"gb_pr_video_resolution_18a2","sha":"b65b16feb57c093777b740ce1325b87258eae0ed","user":{"login":"GTechAlpha","id":31323818,"node_id":"MDQ6VXNlcjMxMzIzODE4","avatar_url":"https://avatars1.githubusercontent.com/u/31323818?v=4","gravatar_id":"","url":"https://api.github.com/users/GTechAlpha","html_url":"https://github.com/GTechAlpha","followers_url":"https://api.github.com/users/GTechAlpha/followers","following_url":"https://api.github.com/users/GTechAlpha/following{/other_user}","gists_url":"https://api.github.com/users/GTechAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/GTechAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GTechAlpha/subscriptions","organizations_url":"https://api.github.com/users/GTechAlpha/orgs","repos_url":"https://api.github.com/users/GTechAlpha/repos","events_url":"https://api.github.com/users/GTechAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/GTechAlpha/received_events","type":"User","site_admin":false},"repo":{"id":136907807,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MDc4MDc=","name":"xbmc","full_name":"GTechAlpha/xbmc","owner":{"login":"GTechAlpha","id":31323818,"node_id":"MDQ6VXNlcjMxMzIzODE4","avatar_url":"https://avatars1.githubusercontent.com/u/31323818?v=4","gravatar_id":"","url":"https://api.github.com/users/GTechAlpha","html_url":"https://github.com/GTechAlpha","followers_url":"https://api.github.com/users/GTechAlpha/followers","following_url":"https://api.github.com/users/GTechAlpha/following{/other_user}","gists_url":"https://api.github.com/users/GTechAlpha/gists{/gist_id}","starred_url":"https://api.github.com/users/GTechAlpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GTechAlpha/subscriptions","organizations_url":"https://api.github.com/users/GTechAlpha/orgs","repos_url":"https://api.github.com/users/GTechAlpha/repos","events_url":"https://api.github.com/users/GTechAlpha/events{/privacy}","received_events_url":"https://api.github.com/users/GTechAlpha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GTechAlpha/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/GTechAlpha/xbmc","forks_url":"https://api.github.com/repos/GTechAlpha/xbmc/forks","keys_url":"https://api.github.com/repos/GTechAlpha/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GTechAlpha/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GTechAlpha/xbmc/teams","hooks_url":"https://api.github.com/repos/GTechAlpha/xbmc/hooks","issue_events_url":"https://api.github.com/repos/GTechAlpha/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/GTechAlpha/xbmc/events","assignees_url":"https://api.github.com/repos/GTechAlpha/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/GTechAlpha/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/GTechAlpha/xbmc/tags","blobs_url":"https://api.github.com/repos/GTechAlpha/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GTechAlpha/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GTechAlpha/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/GTechAlpha/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GTechAlpha/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/GTechAlpha/xbmc/languages","stargazers_url":"https://api.github.com/repos/GTechAlpha/xbmc/stargazers","contributors_url":"https://api.github.com/repos/GTechAlpha/xbmc/contributors","subscribers_url":"https://api.github.com/repos/GTechAlpha/xbmc/subscribers","subscription_url":"https://api.github.com/repos/GTechAlpha/xbmc/subscription","commits_url":"https://api.github.com/repos/GTechAlpha/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/GTechAlpha/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/GTechAlpha/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/GTechAlpha/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/GTechAlpha/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/GTechAlpha/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GTechAlpha/xbmc/merges","archive_url":"https://api.github.com/repos/GTechAlpha/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GTechAlpha/xbmc/downloads","issues_url":"https://api.github.com/repos/GTechAlpha/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/GTechAlpha/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/GTechAlpha/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/GTechAlpha/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GTechAlpha/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/GTechAlpha/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/GTechAlpha/xbmc/deployments","created_at":"2018-06-11T09:58:58Z","updated_at":"2018-06-11T09:59:28Z","pushed_at":"2018-06-13T02:52:59Z","git_url":"git://github.com/GTechAlpha/xbmc.git","ssh_url":"git@github.com:GTechAlpha/xbmc.git","clone_url":"https://github.com/GTechAlpha/xbmc.git","svn_url":"https://github.com/GTechAlpha/xbmc","homepage":"http://xbmc.org","size":683258,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"retroplayer-18alpha2"}},"base":{"label":"garbear:retroplayer-18alpha2","ref":"retroplayer-18alpha2","sha":"feb75fffbfac17b6fd975f85e90144f82fd8f3c8","user":{"login":"garbear","id":531482,"node_id":"MDQ6VXNlcjUzMTQ4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/531482?v=4","gravatar_id":"","url":"https://api.github.com/users/garbear","html_url":"https://github.com/garbear","followers_url":"https://api.github.com/users/garbear/followers","following_url":"https://api.github.com/users/garbear/following{/other_user}","gists_url":"https://api.github.com/users/garbear/gists{/gist_id}","starred_url":"https://api.github.com/users/garbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbear/subscriptions","organizations_url":"https://api.github.com/users/garbear/orgs","repos_url":"https://api.github.com/users/garbear/repos","events_url":"https://api.github.com/users/garbear/events{/privacy}","received_events_url":"https://api.github.com/users/garbear/received_events","type":"User","site_admin":false},"repo":{"id":1593140,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzMTQw","name":"xbmc","full_name":"garbear/xbmc","owner":{"login":"garbear","id":531482,"node_id":"MDQ6VXNlcjUzMTQ4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/531482?v=4","gravatar_id":"","url":"https://api.github.com/users/garbear","html_url":"https://github.com/garbear","followers_url":"https://api.github.com/users/garbear/followers","following_url":"https://api.github.com/users/garbear/following{/other_user}","gists_url":"https://api.github.com/users/garbear/gists{/gist_id}","starred_url":"https://api.github.com/users/garbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbear/subscriptions","organizations_url":"https://api.github.com/users/garbear/orgs","repos_url":"https://api.github.com/users/garbear/repos","events_url":"https://api.github.com/users/garbear/events{/privacy}","received_events_url":"https://api.github.com/users/garbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garbear/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/garbear/xbmc","forks_url":"https://api.github.com/repos/garbear/xbmc/forks","keys_url":"https://api.github.com/repos/garbear/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garbear/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garbear/xbmc/teams","hooks_url":"https://api.github.com/repos/garbear/xbmc/hooks","issue_events_url":"https://api.github.com/repos/garbear/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/garbear/xbmc/events","assignees_url":"https://api.github.com/repos/garbear/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/garbear/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/garbear/xbmc/tags","blobs_url":"https://api.github.com/repos/garbear/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garbear/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garbear/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/garbear/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garbear/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/garbear/xbmc/languages","stargazers_url":"https://api.github.com/repos/garbear/xbmc/stargazers","contributors_url":"https://api.github.com/repos/garbear/xbmc/contributors","subscribers_url":"https://api.github.com/repos/garbear/xbmc/subscribers","subscription_url":"https://api.github.com/repos/garbear/xbmc/subscription","commits_url":"https://api.github.com/repos/garbear/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/garbear/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/garbear/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/garbear/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/garbear/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/garbear/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garbear/xbmc/merges","archive_url":"https://api.github.com/repos/garbear/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garbear/xbmc/downloads","issues_url":"https://api.github.com/repos/garbear/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/garbear/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/garbear/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/garbear/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garbear/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/garbear/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/garbear/xbmc/deployments","created_at":"2011-04-09T22:51:29Z","updated_at":"2018-06-13T01:20:51Z","pushed_at":"2018-06-13T02:53:25Z","git_url":"git://github.com/garbear/xbmc.git","ssh_url":"git@github.com:garbear/xbmc.git","clone_url":"https://github.com/garbear/xbmc.git","svn_url":"https://github.com/garbear/xbmc","homepage":"http://xbmc.org","size":683528,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":51,"open_issues":18,"watchers":103,"default_branch":"retroplayer-18alpha2"}},"_links":{"self":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/98"},"html":{"href":"https://github.com/garbear/xbmc/pull/98"},"issue":{"href":"https://api.github.com/repos/garbear/xbmc/issues/98"},"comments":{"href":"https://api.github.com/repos/garbear/xbmc/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/garbear/xbmc/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/garbear/xbmc/statuses/b65b16feb57c093777b740ce1325b87258eae0ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"GTechAlpha"}}