{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/245003324","pull_request_review_id":189014483,"id":245003324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAwMzMyNA==","diff_hunk":"@@ -54,6 +54,12 @@ int RecursorControlChannel::listen(const string& fname)\n   if(bind(d_fd, (sockaddr*)&d_local,sizeof(d_local))<0) \n     throw PDNSException(\"Unable to bind to controlsocket '\"+fname+\"': \"+stringerror());\n \n+  // receive buf should be size of max datagram plus address size\n+  int bufsz = 60*1024;\n+  setsockopt(d_fd, SOL_SOCKET, SO_SNDBUF, &bufsz, sizeof(bufsz));\n+  bufsz = 64*1024;\n+  setsockopt(d_fd, SOL_SOCKET, SO_RCVBUF, &bufsz, sizeof(bufsz));","path":"pdns/rec_channel.cc","position":8,"original_position":8,"commit_id":"d4777000b9c31ea6d42fa68c66f4caef37b3fe22","original_commit_id":"d4777000b9c31ea6d42fa68c66f4caef37b3fe22","user":{"login":"rgacogne","id":1086257,"node_id":"MDQ6VXNlcjEwODYyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1086257?v=4","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"body":"I'm a bit worried about the fact that this might actually _lower_ the buffer size, that's the case on several Linux boxes I tested, for example. Perhaps we could reuse the `setSocketReceiveBuffer()` and `setSocketSendBuffer()` functions from `pdns_recursor.cc` so that we only increase the size? We should probably lower the severity of the messages from `Error` to `Warning` if we do that, by the way.","created_at":"2019-01-03T13:45:30Z","updated_at":"2019-01-03T13:46:28Z","html_url":"https://github.com/PowerDNS/pdns/pull/7311#discussion_r245003324","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/245003324"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7311#discussion_r245003324"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311","id":241956843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTU2ODQz","html_url":"https://github.com/PowerDNS/pdns/pull/7311","diff_url":"https://github.com/PowerDNS/pdns/pull/7311.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/7311.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7311","number":7311,"state":"open","locked":false,"title":"Rec: Set socket buf size for control socket.","user":{"login":"omoerbeek","id":4435490,"node_id":"MDQ6VXNlcjQ0MzU0OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4435490?v=4","gravatar_id":"","url":"https://api.github.com/users/omoerbeek","html_url":"https://github.com/omoerbeek","followers_url":"https://api.github.com/users/omoerbeek/followers","following_url":"https://api.github.com/users/omoerbeek/following{/other_user}","gists_url":"https://api.github.com/users/omoerbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/omoerbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omoerbeek/subscriptions","organizations_url":"https://api.github.com/users/omoerbeek/orgs","repos_url":"https://api.github.com/users/omoerbeek/repos","events_url":"https://api.github.com/users/omoerbeek/events{/privacy}","received_events_url":"https://api.github.com/users/omoerbeek/received_events","type":"User","site_admin":false},"body":"Fixes #5745 without changing settings for all processes.\r\n\r\n### Short description\r\n<!-- Some systems have small buffer sizes for locall domain sockets.  This sets the buf sizes\r\nwithout need for local system config changes -->\r\n\r\n### Checklist\r\n<!-- please indicate if any of these things are done/included with this Pull Request. Not all boxes need to be checked for the Pull Request to be accepted -->\r\nI have:\r\n- [X] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [X] compiled this code\r\n- [X] tested this code\r\n- [ ] included documentation (including possible behaviour changes)\r\n- [X] documented the code\r\n- [ ] added or modified regression test(s)\r\n- [ ] added or modified unit test(s)\r\n- [ ] <!-- remove this line if your PR is against master --> checked that this code was merged to master\r\n","created_at":"2019-01-03T10:34:19Z","updated_at":"2019-01-03T13:46:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef577d85f49d803d8c5f239ba7d16b144abb8a19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37445984,"node_id":"MDU6TGFiZWwzNzQ0NTk4NA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/rec","name":"rec","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7311/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/d4777000b9c31ea6d42fa68c66f4caef37b3fe22","head":{"label":"omoerbeek:setbufsize","ref":"setbufsize","sha":"d4777000b9c31ea6d42fa68c66f4caef37b3fe22","user":{"login":"omoerbeek","id":4435490,"node_id":"MDQ6VXNlcjQ0MzU0OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4435490?v=4","gravatar_id":"","url":"https://api.github.com/users/omoerbeek","html_url":"https://github.com/omoerbeek","followers_url":"https://api.github.com/users/omoerbeek/followers","following_url":"https://api.github.com/users/omoerbeek/following{/other_user}","gists_url":"https://api.github.com/users/omoerbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/omoerbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omoerbeek/subscriptions","organizations_url":"https://api.github.com/users/omoerbeek/orgs","repos_url":"https://api.github.com/users/omoerbeek/repos","events_url":"https://api.github.com/users/omoerbeek/events{/privacy}","received_events_url":"https://api.github.com/users/omoerbeek/received_events","type":"User","site_admin":false},"repo":{"id":163859257,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4NTkyNTc=","name":"pdns","full_name":"omoerbeek/pdns","private":false,"owner":{"login":"omoerbeek","id":4435490,"node_id":"MDQ6VXNlcjQ0MzU0OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/4435490?v=4","gravatar_id":"","url":"https://api.github.com/users/omoerbeek","html_url":"https://github.com/omoerbeek","followers_url":"https://api.github.com/users/omoerbeek/followers","following_url":"https://api.github.com/users/omoerbeek/following{/other_user}","gists_url":"https://api.github.com/users/omoerbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/omoerbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omoerbeek/subscriptions","organizations_url":"https://api.github.com/users/omoerbeek/orgs","repos_url":"https://api.github.com/users/omoerbeek/repos","events_url":"https://api.github.com/users/omoerbeek/events{/privacy}","received_events_url":"https://api.github.com/users/omoerbeek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omoerbeek/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/omoerbeek/pdns","forks_url":"https://api.github.com/repos/omoerbeek/pdns/forks","keys_url":"https://api.github.com/repos/omoerbeek/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omoerbeek/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omoerbeek/pdns/teams","hooks_url":"https://api.github.com/repos/omoerbeek/pdns/hooks","issue_events_url":"https://api.github.com/repos/omoerbeek/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/omoerbeek/pdns/events","assignees_url":"https://api.github.com/repos/omoerbeek/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/omoerbeek/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/omoerbeek/pdns/tags","blobs_url":"https://api.github.com/repos/omoerbeek/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omoerbeek/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omoerbeek/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/omoerbeek/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omoerbeek/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/omoerbeek/pdns/languages","stargazers_url":"https://api.github.com/repos/omoerbeek/pdns/stargazers","contributors_url":"https://api.github.com/repos/omoerbeek/pdns/contributors","subscribers_url":"https://api.github.com/repos/omoerbeek/pdns/subscribers","subscription_url":"https://api.github.com/repos/omoerbeek/pdns/subscription","commits_url":"https://api.github.com/repos/omoerbeek/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/omoerbeek/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/omoerbeek/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/omoerbeek/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/omoerbeek/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/omoerbeek/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omoerbeek/pdns/merges","archive_url":"https://api.github.com/repos/omoerbeek/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omoerbeek/pdns/downloads","issues_url":"https://api.github.com/repos/omoerbeek/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/omoerbeek/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/omoerbeek/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/omoerbeek/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omoerbeek/pdns/labels{/name}","releases_url":"https://api.github.com/repos/omoerbeek/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/omoerbeek/pdns/deployments","created_at":"2019-01-02T15:39:50Z","updated_at":"2019-01-03T09:36:59Z","pushed_at":"2019-01-03T12:01:10Z","git_url":"git://github.com/omoerbeek/pdns.git","ssh_url":"git@github.com:omoerbeek/pdns.git","clone_url":"https://github.com/omoerbeek/pdns.git","svn_url":"https://github.com/omoerbeek/pdns","homepage":null,"size":46766,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"8e7a8e453ff7b4cede9c30643c59173f492e61ba","user":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkzNTM0","name":"pdns","full_name":"PowerDNS/pdns","private":false,"owner":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2019-01-03T13:00:46Z","pushed_at":"2019-01-03T13:00:36Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":46967,"stargazers_count":1450,"watchers_count":1450,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"archived":false,"open_issues_count":658,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":468,"open_issues":658,"watchers":1450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7311"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7311"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7311/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7311/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/d4777000b9c31ea6d42fa68c66f4caef37b3fe22"}},"author_association":"NONE"}}
{"actor":{"display_login":"rgacogne"}}