{"action":"created","comment":{"url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/comments/216173463","pull_request_review_id":153596337,"id":216173463,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE3MzQ2Mw==","diff_hunk":"@@ -73,7 +78,7 @@\n     \"dotenv\": \"5.0.0\",\n     \"dotenv-expand\": \"4.2.0\",\n     \"electron\": \"2.0.1\",\n-    \"electron-packager\": \"12.1.0\",\n+    \"electron-builder\": \"^20.28.4\",","path":"package.json","position":39,"original_position":39,"commit_id":"3b44b519a8dcdc27eb862d93040b9fb64270155d","original_commit_id":"3b44b519a8dcdc27eb862d93040b9fb64270155d","user":{"login":"AWolf81","id":3046542,"node_id":"MDQ6VXNlcjMwNDY1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3046542?v=4","gravatar_id":"","url":"https://api.github.com/users/AWolf81","html_url":"https://github.com/AWolf81","followers_url":"https://api.github.com/users/AWolf81/followers","following_url":"https://api.github.com/users/AWolf81/following{/other_user}","gists_url":"https://api.github.com/users/AWolf81/gists{/gist_id}","starred_url":"https://api.github.com/users/AWolf81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWolf81/subscriptions","organizations_url":"https://api.github.com/users/AWolf81/orgs","repos_url":"https://api.github.com/users/AWolf81/repos","events_url":"https://api.github.com/users/AWolf81/events{/privacy}","received_events_url":"https://api.github.com/users/AWolf81/received_events","type":"User","site_admin":false},"body":"Nit: We're pinning versions. Please remove the caret.","created_at":"2018-09-09T23:07:34Z","updated_at":"2018-09-09T23:16:07Z","html_url":"https://github.com/joshwcomeau/guppy/pull/236#discussion_r216173463","pull_request_url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/comments/216173463"},"html":{"href":"https://github.com/joshwcomeau/guppy/pull/236#discussion_r216173463"},"pull_request":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236","id":214167805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTY3ODA1","html_url":"https://github.com/joshwcomeau/guppy/pull/236","diff_url":"https://github.com/joshwcomeau/guppy/pull/236.diff","patch_url":"https://github.com/joshwcomeau/guppy/pull/236.patch","issue_url":"https://api.github.com/repos/joshwcomeau/guppy/issues/236","number":236,"state":"open","locked":false,"title":"WIP: #26 Move to electron-builder","user":{"login":"Jtfinlay","id":3934776,"node_id":"MDQ6VXNlcjM5MzQ3NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3934776?v=4","gravatar_id":"","url":"https://api.github.com/users/Jtfinlay","html_url":"https://github.com/Jtfinlay","followers_url":"https://api.github.com/users/Jtfinlay/followers","following_url":"https://api.github.com/users/Jtfinlay/following{/other_user}","gists_url":"https://api.github.com/users/Jtfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Jtfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jtfinlay/subscriptions","organizations_url":"https://api.github.com/users/Jtfinlay/orgs","repos_url":"https://api.github.com/users/Jtfinlay/repos","events_url":"https://api.github.com/users/Jtfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/Jtfinlay/received_events","type":"User","site_admin":false},"body":"\r\n\r\n**Related Issue:** #26 \r\n\r\n**Summary:**\r\n\r\nMoving from `electron-packager` to `electron-builder`.\r\n\r\n`electron-builder` is pulling the files needed from '/build'. The electron starter script (`main.js`, now renamed to `electron.js` to prevent confusion) has shared dependencies with the main app, like references to 'kill-process-id.service' and 'electron-store.service'. To solve this, made an 'electron' entry for webpack. This way, it pulls whatever dependencies are needed, keeps `build/electron.js` and `build/main.js` separate, but allows code to be shared between them in the source.\r\n\r\nSet `yarn` node_modules dependency to manually unpack from the 'app.asar' because node could not reference yarn to correctly spawn. This then needed some path correction.\r\n\r\n**Screenshots/GIFs:** N/A","created_at":"2018-09-09T22:12:23Z","updated_at":"2018-09-09T23:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0291a72c2bb24fcdd2e7e35036a46aec9f766ddc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236/commits","review_comments_url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236/comments","review_comment_url":"https://api.github.com/repos/joshwcomeau/guppy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joshwcomeau/guppy/issues/236/comments","statuses_url":"https://api.github.com/repos/joshwcomeau/guppy/statuses/3b44b519a8dcdc27eb862d93040b9fb64270155d","head":{"label":"Jtfinlay:buildermin","ref":"buildermin","sha":"3b44b519a8dcdc27eb862d93040b9fb64270155d","user":{"login":"Jtfinlay","id":3934776,"node_id":"MDQ6VXNlcjM5MzQ3NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3934776?v=4","gravatar_id":"","url":"https://api.github.com/users/Jtfinlay","html_url":"https://github.com/Jtfinlay","followers_url":"https://api.github.com/users/Jtfinlay/followers","following_url":"https://api.github.com/users/Jtfinlay/following{/other_user}","gists_url":"https://api.github.com/users/Jtfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Jtfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jtfinlay/subscriptions","organizations_url":"https://api.github.com/users/Jtfinlay/orgs","repos_url":"https://api.github.com/users/Jtfinlay/repos","events_url":"https://api.github.com/users/Jtfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/Jtfinlay/received_events","type":"User","site_admin":false},"repo":{"id":146959575,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NTk1NzU=","name":"guppy","full_name":"Jtfinlay/guppy","owner":{"login":"Jtfinlay","id":3934776,"node_id":"MDQ6VXNlcjM5MzQ3NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3934776?v=4","gravatar_id":"","url":"https://api.github.com/users/Jtfinlay","html_url":"https://github.com/Jtfinlay","followers_url":"https://api.github.com/users/Jtfinlay/followers","following_url":"https://api.github.com/users/Jtfinlay/following{/other_user}","gists_url":"https://api.github.com/users/Jtfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Jtfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jtfinlay/subscriptions","organizations_url":"https://api.github.com/users/Jtfinlay/orgs","repos_url":"https://api.github.com/users/Jtfinlay/repos","events_url":"https://api.github.com/users/Jtfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/Jtfinlay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jtfinlay/guppy","description":"🐠A friendly application manager and task runner for React.js","fork":true,"url":"https://api.github.com/repos/Jtfinlay/guppy","forks_url":"https://api.github.com/repos/Jtfinlay/guppy/forks","keys_url":"https://api.github.com/repos/Jtfinlay/guppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jtfinlay/guppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jtfinlay/guppy/teams","hooks_url":"https://api.github.com/repos/Jtfinlay/guppy/hooks","issue_events_url":"https://api.github.com/repos/Jtfinlay/guppy/issues/events{/number}","events_url":"https://api.github.com/repos/Jtfinlay/guppy/events","assignees_url":"https://api.github.com/repos/Jtfinlay/guppy/assignees{/user}","branches_url":"https://api.github.com/repos/Jtfinlay/guppy/branches{/branch}","tags_url":"https://api.github.com/repos/Jtfinlay/guppy/tags","blobs_url":"https://api.github.com/repos/Jtfinlay/guppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jtfinlay/guppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jtfinlay/guppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jtfinlay/guppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jtfinlay/guppy/statuses/{sha}","languages_url":"https://api.github.com/repos/Jtfinlay/guppy/languages","stargazers_url":"https://api.github.com/repos/Jtfinlay/guppy/stargazers","contributors_url":"https://api.github.com/repos/Jtfinlay/guppy/contributors","subscribers_url":"https://api.github.com/repos/Jtfinlay/guppy/subscribers","subscription_url":"https://api.github.com/repos/Jtfinlay/guppy/subscription","commits_url":"https://api.github.com/repos/Jtfinlay/guppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jtfinlay/guppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jtfinlay/guppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jtfinlay/guppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jtfinlay/guppy/contents/{+path}","compare_url":"https://api.github.com/repos/Jtfinlay/guppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jtfinlay/guppy/merges","archive_url":"https://api.github.com/repos/Jtfinlay/guppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jtfinlay/guppy/downloads","issues_url":"https://api.github.com/repos/Jtfinlay/guppy/issues{/number}","pulls_url":"https://api.github.com/repos/Jtfinlay/guppy/pulls{/number}","milestones_url":"https://api.github.com/repos/Jtfinlay/guppy/milestones{/number}","notifications_url":"https://api.github.com/repos/Jtfinlay/guppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jtfinlay/guppy/labels{/name}","releases_url":"https://api.github.com/repos/Jtfinlay/guppy/releases{/id}","deployments_url":"https://api.github.com/repos/Jtfinlay/guppy/deployments","created_at":"2018-09-01T02:10:07Z","updated_at":"2018-09-09T21:46:21Z","pushed_at":"2018-09-09T21:50:55Z","git_url":"git://github.com/Jtfinlay/guppy.git","ssh_url":"git@github.com:Jtfinlay/guppy.git","clone_url":"https://github.com/Jtfinlay/guppy.git","svn_url":"https://github.com/Jtfinlay/guppy","homepage":"","size":12393,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joshwcomeau:master","ref":"master","sha":"4593736202c3a0e8c7901d70cfe1aea8dbc31740","user":{"login":"joshwcomeau","id":6692932,"node_id":"MDQ6VXNlcjY2OTI5MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6692932?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwcomeau","html_url":"https://github.com/joshwcomeau","followers_url":"https://api.github.com/users/joshwcomeau/followers","following_url":"https://api.github.com/users/joshwcomeau/following{/other_user}","gists_url":"https://api.github.com/users/joshwcomeau/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwcomeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwcomeau/subscriptions","organizations_url":"https://api.github.com/users/joshwcomeau/orgs","repos_url":"https://api.github.com/users/joshwcomeau/repos","events_url":"https://api.github.com/users/joshwcomeau/events{/privacy}","received_events_url":"https://api.github.com/users/joshwcomeau/received_events","type":"User","site_admin":false},"repo":{"id":134185621,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQxODU2MjE=","name":"guppy","full_name":"joshwcomeau/guppy","owner":{"login":"joshwcomeau","id":6692932,"node_id":"MDQ6VXNlcjY2OTI5MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6692932?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwcomeau","html_url":"https://github.com/joshwcomeau","followers_url":"https://api.github.com/users/joshwcomeau/followers","following_url":"https://api.github.com/users/joshwcomeau/following{/other_user}","gists_url":"https://api.github.com/users/joshwcomeau/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwcomeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwcomeau/subscriptions","organizations_url":"https://api.github.com/users/joshwcomeau/orgs","repos_url":"https://api.github.com/users/joshwcomeau/repos","events_url":"https://api.github.com/users/joshwcomeau/events{/privacy}","received_events_url":"https://api.github.com/users/joshwcomeau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshwcomeau/guppy","description":"🐠A friendly application manager and task runner for React.js","fork":false,"url":"https://api.github.com/repos/joshwcomeau/guppy","forks_url":"https://api.github.com/repos/joshwcomeau/guppy/forks","keys_url":"https://api.github.com/repos/joshwcomeau/guppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshwcomeau/guppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshwcomeau/guppy/teams","hooks_url":"https://api.github.com/repos/joshwcomeau/guppy/hooks","issue_events_url":"https://api.github.com/repos/joshwcomeau/guppy/issues/events{/number}","events_url":"https://api.github.com/repos/joshwcomeau/guppy/events","assignees_url":"https://api.github.com/repos/joshwcomeau/guppy/assignees{/user}","branches_url":"https://api.github.com/repos/joshwcomeau/guppy/branches{/branch}","tags_url":"https://api.github.com/repos/joshwcomeau/guppy/tags","blobs_url":"https://api.github.com/repos/joshwcomeau/guppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshwcomeau/guppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshwcomeau/guppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshwcomeau/guppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshwcomeau/guppy/statuses/{sha}","languages_url":"https://api.github.com/repos/joshwcomeau/guppy/languages","stargazers_url":"https://api.github.com/repos/joshwcomeau/guppy/stargazers","contributors_url":"https://api.github.com/repos/joshwcomeau/guppy/contributors","subscribers_url":"https://api.github.com/repos/joshwcomeau/guppy/subscribers","subscription_url":"https://api.github.com/repos/joshwcomeau/guppy/subscription","commits_url":"https://api.github.com/repos/joshwcomeau/guppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshwcomeau/guppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshwcomeau/guppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshwcomeau/guppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshwcomeau/guppy/contents/{+path}","compare_url":"https://api.github.com/repos/joshwcomeau/guppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshwcomeau/guppy/merges","archive_url":"https://api.github.com/repos/joshwcomeau/guppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshwcomeau/guppy/downloads","issues_url":"https://api.github.com/repos/joshwcomeau/guppy/issues{/number}","pulls_url":"https://api.github.com/repos/joshwcomeau/guppy/pulls{/number}","milestones_url":"https://api.github.com/repos/joshwcomeau/guppy/milestones{/number}","notifications_url":"https://api.github.com/repos/joshwcomeau/guppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshwcomeau/guppy/labels{/name}","releases_url":"https://api.github.com/repos/joshwcomeau/guppy/releases{/id}","deployments_url":"https://api.github.com/repos/joshwcomeau/guppy/deployments","created_at":"2018-05-20T20:49:50Z","updated_at":"2018-09-09T19:19:08Z","pushed_at":"2018-09-09T22:12:24Z","git_url":"git://github.com/joshwcomeau/guppy.git","ssh_url":"git@github.com:joshwcomeau/guppy.git","clone_url":"https://github.com/joshwcomeau/guppy.git","svn_url":"https://github.com/joshwcomeau/guppy","homepage":"","size":12506,"stargazers_count":2353,"watchers_count":2353,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":111,"open_issues":57,"watchers":2353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236"},"html":{"href":"https://github.com/joshwcomeau/guppy/pull/236"},"issue":{"href":"https://api.github.com/repos/joshwcomeau/guppy/issues/236"},"comments":{"href":"https://api.github.com/repos/joshwcomeau/guppy/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joshwcomeau/guppy/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/joshwcomeau/guppy/statuses/3b44b519a8dcdc27eb862d93040b9fb64270155d"}},"author_association":"NONE"}}
{"actor":{"display_login":"AWolf81"}}