{"action":"opened","number":1838,"pull_request":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838","id":212174035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTc0MDM1","html_url":"https://github.com/coreos/prometheus-operator/pull/1838","diff_url":"https://github.com/coreos/prometheus-operator/pull/1838.diff","patch_url":"https://github.com/coreos/prometheus-operator/pull/1838.patch","issue_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/1838","number":1838,"state":"open","locked":false,"title":"kube-prometheus: add externalUrl support","user":{"login":"s-urbaniak","id":375856,"node_id":"MDQ6VXNlcjM3NTg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/375856?v=4","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"Currently, it is not possible to add an externalUrl setting for the\nPrometheus CRD.\n\nThis fixes it by allowing to set the following configuration:\n\n```\nlocal kp =\n  (import 'kube-prometheus/kube-prometheus.libsonnet') +\n  {\n    _config+:: {\n      namespace: 'monitoring',\n      prometheus+:: {\n        externalUrl: 'https://sur.host/prometheus',\n      },\n    },\n```\n\n/cc @brancz @mxinden\n\nI have no idea if this \"idiomatic\" but it solves adding externalUrl\nconfiguration to the Prometheus CRD :-)","created_at":"2018-08-30T18:41:56Z","updated_at":"2018-08-30T18:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838/commits","review_comments_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838/comments","review_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/1838/comments","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/e564106bc2ca39aa422ee75f9a62983b24ef9d15","head":{"label":"s-urbaniak:external-url","ref":"external-url","sha":"e564106bc2ca39aa422ee75f9a62983b24ef9d15","user":{"login":"s-urbaniak","id":375856,"node_id":"MDQ6VXNlcjM3NTg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/375856?v=4","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"repo":{"id":145098516,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTg1MTY=","name":"prometheus-operator","full_name":"s-urbaniak/prometheus-operator","owner":{"login":"s-urbaniak","id":375856,"node_id":"MDQ6VXNlcjM3NTg1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/375856?v=4","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-urbaniak/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":true,"url":"https://api.github.com/repos/s-urbaniak/prometheus-operator","forks_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/forks","keys_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/events","assignees_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/merges","archive_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/s-urbaniak/prometheus-operator/deployments","created_at":"2018-08-17T09:07:34Z","updated_at":"2018-08-17T09:07:37Z","pushed_at":"2018-08-30T18:39:55Z","git_url":"git://github.com/s-urbaniak/prometheus-operator.git","ssh_url":"git@github.com:s-urbaniak/prometheus-operator.git","clone_url":"https://github.com/s-urbaniak/prometheus-operator.git","svn_url":"https://github.com/s-urbaniak/prometheus-operator","homepage":"https://coreos.com/operators/prometheus","size":52559,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"71d5f73720031e91ea013920f2e5600fe46fadfe","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":68964263,"node_id":"MDEwOlJlcG9zaXRvcnk2ODk2NDI2Mw==","name":"prometheus-operator","full_name":"coreos/prometheus-operator","owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/prometheus-operator","forks_url":"https://api.github.com/repos/coreos/prometheus-operator/forks","keys_url":"https://api.github.com/repos/coreos/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/coreos/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/prometheus-operator/events","assignees_url":"https://api.github.com/repos/coreos/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/coreos/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/prometheus-operator/merges","archive_url":"https://api.github.com/repos/coreos/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/coreos/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/prometheus-operator/deployments","created_at":"2016-09-22T21:38:06Z","updated_at":"2018-08-30T17:21:08Z","pushed_at":"2018-08-30T16:46:48Z","git_url":"git://github.com/coreos/prometheus-operator.git","ssh_url":"git@github.com:coreos/prometheus-operator.git","clone_url":"https://github.com/coreos/prometheus-operator.git","svn_url":"https://github.com/coreos/prometheus-operator","homepage":"https://coreos.com/operators/prometheus","size":52610,"stargazers_count":1663,"watchers_count":1663,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":761,"open_issues":203,"watchers":1663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/1838"},"issue":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/1838"},"comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/1838/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/1838/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/prometheus-operator/statuses/e564106bc2ca39aa422ee75f9a62983b24ef9d15"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"s-urbaniak"}}