{"action":"created","comment":{"url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/comments/229238384","pull_request_review_id":169687163,"id":229238384,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTIzODM4NA==","diff_hunk":"@@ -300,3 +300,372 @@ gtkui_receive_fm_drop (DB_playItem_t *before, char *mem, int length) {\n     intptr_t tid = deadbeef->thread_start (fmdrop_worker, data);\n     deadbeef->thread_detach (tid);\n }\n+\n+#if defined __MINGW32__ && GTK_CHECK_VERSION(3,20,0)\n+#define USE_GTK_NATIVE_FILE_CHOOSER\n+#endif\n+\n+#ifdef USE_GTK_NATIVE_FILE_CHOOSER\n+#if !GTK_CHECK_VERSION(3,20,0)\n+#undef USE_GTK_NATIVE_FILE_CHOOSER","path":"plugins/gtkui/fileman.c","position":20,"original_position":20,"commit_id":"3e43e735d2a780a3a1fc9eac2e14da0e22682b64","original_commit_id":"f207424ebfa600a98d58758cac8b42a59a186fd5","user":{"login":"kuba160","id":6359901,"node_id":"MDQ6VXNlcjYzNTk5MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6359901?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba160","html_url":"https://github.com/kuba160","followers_url":"https://api.github.com/users/kuba160/followers","following_url":"https://api.github.com/users/kuba160/following{/other_user}","gists_url":"https://api.github.com/users/kuba160/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba160/subscriptions","organizations_url":"https://api.github.com/users/kuba160/orgs","repos_url":"https://api.github.com/users/kuba160/repos","events_url":"https://api.github.com/users/kuba160/events{/privacy}","received_events_url":"https://api.github.com/users/kuba160/received_events","type":"User","site_admin":false},"body":"The first enables native file chooser for windows build by default, second one ensures that it is enabled only if compiling for GTK3, this may happen if macro was set manually. I guess I'll remove first check and set `USE_GTK_NATIVE_FILE_CHOOSER` in premake.","created_at":"2018-10-30T09:52:15Z","updated_at":"2018-10-30T09:52:15Z","html_url":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058#discussion_r229238384","pull_request_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/comments/229238384"},"html":{"href":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058#discussion_r229238384"},"pull_request":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058"}},"in_reply_to_id":227528414},"pull_request":{"url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058","id":225144307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTQ0MzA3","html_url":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058","diff_url":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058.diff","patch_url":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058.patch","issue_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/2058","number":2058,"state":"open","locked":false,"title":"Add Windows support","user":{"login":"kuba160","id":6359901,"node_id":"MDQ6VXNlcjYzNTk5MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6359901?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba160","html_url":"https://github.com/kuba160","followers_url":"https://api.github.com/users/kuba160/followers","following_url":"https://api.github.com/users/kuba160/following{/other_user}","gists_url":"https://api.github.com/users/kuba160/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba160/subscriptions","organizations_url":"https://api.github.com/users/kuba160/orgs","repos_url":"https://api.github.com/users/kuba160/repos","events_url":"https://api.github.com/users/kuba160/events{/privacy}","received_events_url":"https://api.github.com/users/kuba160/received_events","type":"User","site_admin":false},"body":"This pull request adds possibility to compile DeaDBeeF under msys2 environment.\r\n\r\nChanges summed up:\r\n* platform-dependent directories are replaced with macros (common.h)\r\n* fopen files are opened in binary mode\r\n* windows icon (.ico) added\r\n* (WIP) ability to use INET sockets instead of unix sockets\r\n* gtkui can use native file chooser (GTK3 only)\r\n* portaudio output plugin added\r\n* shared/windows includes a compatibility layer and some headers needed for compilation which are not included in msys2\r\n\r\nChanges to be discussed:\r\n* premake5-tools and premake5-win\r\n* waveout output plugin","created_at":"2018-10-23T18:38:06Z","updated_at":"2018-10-30T09:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceca9923259cfc732706bd65a33dbad743c67748","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058/commits","review_comments_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058/comments","review_comment_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/2058/comments","statuses_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/statuses/3e43e735d2a780a3a1fc9eac2e14da0e22682b64","head":{"label":"DeaDBeeF-for-Windows:win","ref":"win","sha":"3e43e735d2a780a3a1fc9eac2e14da0e22682b64","user":{"login":"DeaDBeeF-for-Windows","id":37141028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQxMDI4","avatar_url":"https://avatars1.githubusercontent.com/u/37141028?v=4","gravatar_id":"","url":"https://api.github.com/users/DeaDBeeF-for-Windows","html_url":"https://github.com/DeaDBeeF-for-Windows","followers_url":"https://api.github.com/users/DeaDBeeF-for-Windows/followers","following_url":"https://api.github.com/users/DeaDBeeF-for-Windows/following{/other_user}","gists_url":"https://api.github.com/users/DeaDBeeF-for-Windows/gists{/gist_id}","starred_url":"https://api.github.com/users/DeaDBeeF-for-Windows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeaDBeeF-for-Windows/subscriptions","organizations_url":"https://api.github.com/users/DeaDBeeF-for-Windows/orgs","repos_url":"https://api.github.com/users/DeaDBeeF-for-Windows/repos","events_url":"https://api.github.com/users/DeaDBeeF-for-Windows/events{/privacy}","received_events_url":"https://api.github.com/users/DeaDBeeF-for-Windows/received_events","type":"Organization","site_admin":false},"repo":{"id":92599654,"node_id":"MDEwOlJlcG9zaXRvcnk5MjU5OTY1NA==","name":"deadbeef","full_name":"DeaDBeeF-for-Windows/deadbeef","private":false,"owner":{"login":"DeaDBeeF-for-Windows","id":37141028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQxMDI4","avatar_url":"https://avatars1.githubusercontent.com/u/37141028?v=4","gravatar_id":"","url":"https://api.github.com/users/DeaDBeeF-for-Windows","html_url":"https://github.com/DeaDBeeF-for-Windows","followers_url":"https://api.github.com/users/DeaDBeeF-for-Windows/followers","following_url":"https://api.github.com/users/DeaDBeeF-for-Windows/following{/other_user}","gists_url":"https://api.github.com/users/DeaDBeeF-for-Windows/gists{/gist_id}","starred_url":"https://api.github.com/users/DeaDBeeF-for-Windows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeaDBeeF-for-Windows/subscriptions","organizations_url":"https://api.github.com/users/DeaDBeeF-for-Windows/orgs","repos_url":"https://api.github.com/users/DeaDBeeF-for-Windows/repos","events_url":"https://api.github.com/users/DeaDBeeF-for-Windows/events{/privacy}","received_events_url":"https://api.github.com/users/DeaDBeeF-for-Windows/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DeaDBeeF-for-Windows/deadbeef","description":"DeaDBeeF Player","fork":true,"url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef","forks_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/forks","keys_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/teams","hooks_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/hooks","issue_events_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/issues/events{/number}","events_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/events","assignees_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/assignees{/user}","branches_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/branches{/branch}","tags_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/tags","blobs_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/statuses/{sha}","languages_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/languages","stargazers_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/stargazers","contributors_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/contributors","subscribers_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/subscribers","subscription_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/subscription","commits_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/contents/{+path}","compare_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/merges","archive_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/downloads","issues_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/issues{/number}","pulls_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/pulls{/number}","milestones_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/milestones{/number}","notifications_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/labels{/name}","releases_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/releases{/id}","deployments_url":"https://api.github.com/repos/DeaDBeeF-for-Windows/deadbeef/deployments","created_at":"2017-05-27T13:15:29Z","updated_at":"2018-10-27T19:20:28Z","pushed_at":"2018-10-27T19:20:25Z","git_url":"git://github.com/DeaDBeeF-for-Windows/deadbeef.git","ssh_url":"git@github.com:DeaDBeeF-for-Windows/deadbeef.git","clone_url":"https://github.com/DeaDBeeF-for-Windows/deadbeef.git","svn_url":"https://github.com/DeaDBeeF-for-Windows/deadbeef","homepage":"http://deadbeef.sf.net","size":67770,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":5,"default_branch":"win"}},"base":{"label":"DeaDBeeF-Player:master","ref":"master","sha":"6bd85409af6c613d4b4303fb2da66100ccc97783","user":{"login":"DeaDBeeF-Player","id":31016870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDE2ODcw","avatar_url":"https://avatars3.githubusercontent.com/u/31016870?v=4","gravatar_id":"","url":"https://api.github.com/users/DeaDBeeF-Player","html_url":"https://github.com/DeaDBeeF-Player","followers_url":"https://api.github.com/users/DeaDBeeF-Player/followers","following_url":"https://api.github.com/users/DeaDBeeF-Player/following{/other_user}","gists_url":"https://api.github.com/users/DeaDBeeF-Player/gists{/gist_id}","starred_url":"https://api.github.com/users/DeaDBeeF-Player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeaDBeeF-Player/subscriptions","organizations_url":"https://api.github.com/users/DeaDBeeF-Player/orgs","repos_url":"https://api.github.com/users/DeaDBeeF-Player/repos","events_url":"https://api.github.com/users/DeaDBeeF-Player/events{/privacy}","received_events_url":"https://api.github.com/users/DeaDBeeF-Player/received_events","type":"Organization","site_admin":false},"repo":{"id":15237541,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzNzU0MQ==","name":"deadbeef","full_name":"DeaDBeeF-Player/deadbeef","private":false,"owner":{"login":"DeaDBeeF-Player","id":31016870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDE2ODcw","avatar_url":"https://avatars3.githubusercontent.com/u/31016870?v=4","gravatar_id":"","url":"https://api.github.com/users/DeaDBeeF-Player","html_url":"https://github.com/DeaDBeeF-Player","followers_url":"https://api.github.com/users/DeaDBeeF-Player/followers","following_url":"https://api.github.com/users/DeaDBeeF-Player/following{/other_user}","gists_url":"https://api.github.com/users/DeaDBeeF-Player/gists{/gist_id}","starred_url":"https://api.github.com/users/DeaDBeeF-Player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeaDBeeF-Player/subscriptions","organizations_url":"https://api.github.com/users/DeaDBeeF-Player/orgs","repos_url":"https://api.github.com/users/DeaDBeeF-Player/repos","events_url":"https://api.github.com/users/DeaDBeeF-Player/events{/privacy}","received_events_url":"https://api.github.com/users/DeaDBeeF-Player/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DeaDBeeF-Player/deadbeef","description":"DeaDBeeF Player","fork":false,"url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef","forks_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/forks","keys_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/teams","hooks_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/hooks","issue_events_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/events{/number}","events_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/events","assignees_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/assignees{/user}","branches_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/branches{/branch}","tags_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/tags","blobs_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/statuses/{sha}","languages_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/languages","stargazers_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/stargazers","contributors_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/contributors","subscribers_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/subscribers","subscription_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/subscription","commits_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/contents/{+path}","compare_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/merges","archive_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/downloads","issues_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues{/number}","pulls_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls{/number}","milestones_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/milestones{/number}","notifications_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/labels{/name}","releases_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/releases{/id}","deployments_url":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/deployments","created_at":"2013-12-16T21:21:05Z","updated_at":"2018-10-29T14:56:51Z","pushed_at":"2018-10-29T15:32:17Z","git_url":"git://github.com/DeaDBeeF-Player/deadbeef.git","ssh_url":"git@github.com:DeaDBeeF-Player/deadbeef.git","clone_url":"https://github.com/DeaDBeeF-Player/deadbeef.git","svn_url":"https://github.com/DeaDBeeF-Player/deadbeef","homepage":"http://deadbeef.sf.net","size":61329,"stargazers_count":705,"watchers_count":705,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":102,"open_issues":290,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058"},"html":{"href":"https://github.com/DeaDBeeF-Player/deadbeef/pull/2058"},"issue":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/2058"},"comments":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/issues/2058/comments"},"review_comments":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058/comments"},"review_comment":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/pulls/2058/commits"},"statuses":{"href":"https://api.github.com/repos/DeaDBeeF-Player/deadbeef/statuses/3e43e735d2a780a3a1fc9eac2e14da0e22682b64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kuba160"}}