{"action":"created","comment":{"url":"https://api.github.com/repos/mirumee/saleor/pulls/comments/237849493","pull_request_review_id":180251234,"id":237849493,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg0OTQ5Mw==","diff_hunk":"@@ -136,7 +136,7 @@ def user_is_allowed(cls, user, input):\n     @classmethod\n     def clean_input(cls, info, instance, input, errors):\n         cleaned_input = super().clean_input(info, instance, input, errors)\n-        if 'slug' not in cleaned_input:\n+        if 'slug' not in cleaned_input and 'name' in cleaned_input:","path":"saleor/graphql/product/mutations/products.py","position":14,"original_position":14,"commit_id":"4589a504fe1d36ab0c654d31ff1eb242de51089f","original_commit_id":"4589a504fe1d36ab0c654d31ff1eb242de51089f","user":{"login":"Pacu2","id":21290461,"node_id":"MDQ6VXNlcjIxMjkwNDYx","avatar_url":"https://avatars3.githubusercontent.com/u/21290461?v=4","gravatar_id":"","url":"https://api.github.com/users/Pacu2","html_url":"https://github.com/Pacu2","followers_url":"https://api.github.com/users/Pacu2/followers","following_url":"https://api.github.com/users/Pacu2/following{/other_user}","gists_url":"https://api.github.com/users/Pacu2/gists{/gist_id}","starred_url":"https://api.github.com/users/Pacu2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pacu2/subscriptions","organizations_url":"https://api.github.com/users/Pacu2/orgs","repos_url":"https://api.github.com/users/Pacu2/repos","events_url":"https://api.github.com/users/Pacu2/events{/privacy}","received_events_url":"https://api.github.com/users/Pacu2/received_events","type":"User","site_admin":false},"body":"What if there's no name provided? What will be the slug?","created_at":"2018-11-30T12:50:18Z","updated_at":"2018-11-30T12:50:18Z","html_url":"https://github.com/mirumee/saleor/pull/3362#discussion_r237849493","pull_request_url":"https://api.github.com/repos/mirumee/saleor/pulls/3362","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/comments/237849493"},"html":{"href":"https://github.com/mirumee/saleor/pull/3362#discussion_r237849493"},"pull_request":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/3362"}}},"pull_request":{"url":"https://api.github.com/repos/mirumee/saleor/pulls/3362","id":234973188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTczMTg4","html_url":"https://github.com/mirumee/saleor/pull/3362","diff_url":"https://github.com/mirumee/saleor/pull/3362.diff","patch_url":"https://github.com/mirumee/saleor/pull/3362.patch","issue_url":"https://api.github.com/repos/mirumee/saleor/issues/3362","number":3362,"state":"open","locked":false,"title":"Fix update background_image of a Collection in GraphQL API","user":{"login":"fowczarek","id":43955230,"node_id":"MDQ6VXNlcjQzOTU1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/43955230?v=4","gravatar_id":"","url":"https://api.github.com/users/fowczarek","html_url":"https://github.com/fowczarek","followers_url":"https://api.github.com/users/fowczarek/followers","following_url":"https://api.github.com/users/fowczarek/following{/other_user}","gists_url":"https://api.github.com/users/fowczarek/gists{/gist_id}","starred_url":"https://api.github.com/users/fowczarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fowczarek/subscriptions","organizations_url":"https://api.github.com/users/fowczarek/orgs","repos_url":"https://api.github.com/users/fowczarek/repos","events_url":"https://api.github.com/users/fowczarek/events{/privacy}","received_events_url":"https://api.github.com/users/fowczarek/received_events","type":"User","site_admin":false},"body":"I want to merge this change because resolve #3269 \r\n\r\n<!-- Please mention all relevant issue numbers. -->\r\n\r\n### Screenshots\r\n\r\n<!-- If your changes affect the UI, providing \"before\" and \"after\" screenshots will\r\ngreatly reduce the amount of work needed to review your work. -->\r\n\r\n### Pull Request Checklist\r\n\r\n<!-- Please keep this section. It will make maintainer's life easier. -->\r\n\r\n1. [ ] Privileged views and APIs are guarded by proper permission checks.\r\n1. [ ] All visible strings are translated with proper context.\r\n1. [ ] All data-formatting is locale-aware (dates, numbers, and so on).\r\n1. [ ] Database queries are optimized and the number of queries is constant.\r\n1. [ ] The changes are tested.\r\n1. [ ] The code is documented (docstrings, project documentation).\r\n1. [ ] GraphQL schema and type definitions are up to date.\r\n","created_at":"2018-11-30T12:33:26Z","updated_at":"2018-11-30T12:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30cefaa99ce38e3bc58bfff3bf62af96907023c2","assignee":{"login":"fowczarek","id":43955230,"node_id":"MDQ6VXNlcjQzOTU1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/43955230?v=4","gravatar_id":"","url":"https://api.github.com/users/fowczarek","html_url":"https://github.com/fowczarek","followers_url":"https://api.github.com/users/fowczarek/followers","following_url":"https://api.github.com/users/fowczarek/following{/other_user}","gists_url":"https://api.github.com/users/fowczarek/gists{/gist_id}","starred_url":"https://api.github.com/users/fowczarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fowczarek/subscriptions","organizations_url":"https://api.github.com/users/fowczarek/orgs","repos_url":"https://api.github.com/users/fowczarek/repos","events_url":"https://api.github.com/users/fowczarek/events{/privacy}","received_events_url":"https://api.github.com/users/fowczarek/received_events","type":"User","site_admin":false},"assignees":[{"login":"fowczarek","id":43955230,"node_id":"MDQ6VXNlcjQzOTU1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/43955230?v=4","gravatar_id":"","url":"https://api.github.com/users/fowczarek","html_url":"https://github.com/fowczarek","followers_url":"https://api.github.com/users/fowczarek/followers","following_url":"https://api.github.com/users/fowczarek/following{/other_user}","gists_url":"https://api.github.com/users/fowczarek/gists{/gist_id}","starred_url":"https://api.github.com/users/fowczarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fowczarek/subscriptions","organizations_url":"https://api.github.com/users/fowczarek/orgs","repos_url":"https://api.github.com/users/fowczarek/repos","events_url":"https://api.github.com/users/fowczarek/events{/privacy}","received_events_url":"https://api.github.com/users/fowczarek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":85254421,"node_id":"MDU6TGFiZWw4NTI1NDQyMQ==","url":"https://api.github.com/repos/mirumee/saleor/labels/in%20progress","name":"in progress","color":"2980B9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mirumee/saleor/pulls/3362/commits","review_comments_url":"https://api.github.com/repos/mirumee/saleor/pulls/3362/comments","review_comment_url":"https://api.github.com/repos/mirumee/saleor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirumee/saleor/issues/3362/comments","statuses_url":"https://api.github.com/repos/mirumee/saleor/statuses/4589a504fe1d36ab0c654d31ff1eb242de51089f","head":{"label":"mirumee:3269/Fix_update_image_of_a_collection_GraphQL","ref":"3269/Fix_update_image_of_a_collection_GraphQL","sha":"4589a504fe1d36ab0c654d31ff1eb242de51089f","user":{"login":"mirumee","id":170574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDU3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"repo":{"id":8162715,"node_id":"MDEwOlJlcG9zaXRvcnk4MTYyNzE1","name":"saleor","full_name":"mirumee/saleor","private":false,"owner":{"login":"mirumee","id":170574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDU3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mirumee/saleor","description":"A modular, high performance e-commerce storefront built with Python, GraphQL, Django, and ReactJS.","fork":false,"url":"https://api.github.com/repos/mirumee/saleor","forks_url":"https://api.github.com/repos/mirumee/saleor/forks","keys_url":"https://api.github.com/repos/mirumee/saleor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirumee/saleor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirumee/saleor/teams","hooks_url":"https://api.github.com/repos/mirumee/saleor/hooks","issue_events_url":"https://api.github.com/repos/mirumee/saleor/issues/events{/number}","events_url":"https://api.github.com/repos/mirumee/saleor/events","assignees_url":"https://api.github.com/repos/mirumee/saleor/assignees{/user}","branches_url":"https://api.github.com/repos/mirumee/saleor/branches{/branch}","tags_url":"https://api.github.com/repos/mirumee/saleor/tags","blobs_url":"https://api.github.com/repos/mirumee/saleor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirumee/saleor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirumee/saleor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirumee/saleor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirumee/saleor/statuses/{sha}","languages_url":"https://api.github.com/repos/mirumee/saleor/languages","stargazers_url":"https://api.github.com/repos/mirumee/saleor/stargazers","contributors_url":"https://api.github.com/repos/mirumee/saleor/contributors","subscribers_url":"https://api.github.com/repos/mirumee/saleor/subscribers","subscription_url":"https://api.github.com/repos/mirumee/saleor/subscription","commits_url":"https://api.github.com/repos/mirumee/saleor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirumee/saleor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirumee/saleor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirumee/saleor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirumee/saleor/contents/{+path}","compare_url":"https://api.github.com/repos/mirumee/saleor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirumee/saleor/merges","archive_url":"https://api.github.com/repos/mirumee/saleor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirumee/saleor/downloads","issues_url":"https://api.github.com/repos/mirumee/saleor/issues{/number}","pulls_url":"https://api.github.com/repos/mirumee/saleor/pulls{/number}","milestones_url":"https://api.github.com/repos/mirumee/saleor/milestones{/number}","notifications_url":"https://api.github.com/repos/mirumee/saleor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirumee/saleor/labels{/name}","releases_url":"https://api.github.com/repos/mirumee/saleor/releases{/id}","deployments_url":"https://api.github.com/repos/mirumee/saleor/deployments","created_at":"2013-02-12T16:46:39Z","updated_at":"2018-11-30T11:35:58Z","pushed_at":"2018-11-30T12:33:27Z","git_url":"git://github.com/mirumee/saleor.git","ssh_url":"git@github.com:mirumee/saleor.git","clone_url":"https://github.com/mirumee/saleor.git","svn_url":"https://github.com/mirumee/saleor","homepage":"http://getsaleor.com","size":83105,"stargazers_count":3211,"watchers_count":3211,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1366,"mirror_url":null,"archived":false,"open_issues_count":346,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1366,"open_issues":346,"watchers":3211,"default_branch":"master"}},"base":{"label":"mirumee:master","ref":"master","sha":"b937bbb3b5f6bdf0f369d5c7bba7ec8553d8719d","user":{"login":"mirumee","id":170574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDU3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"repo":{"id":8162715,"node_id":"MDEwOlJlcG9zaXRvcnk4MTYyNzE1","name":"saleor","full_name":"mirumee/saleor","private":false,"owner":{"login":"mirumee","id":170574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDU3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mirumee/saleor","description":"A modular, high performance e-commerce storefront built with Python, GraphQL, Django, and ReactJS.","fork":false,"url":"https://api.github.com/repos/mirumee/saleor","forks_url":"https://api.github.com/repos/mirumee/saleor/forks","keys_url":"https://api.github.com/repos/mirumee/saleor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirumee/saleor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirumee/saleor/teams","hooks_url":"https://api.github.com/repos/mirumee/saleor/hooks","issue_events_url":"https://api.github.com/repos/mirumee/saleor/issues/events{/number}","events_url":"https://api.github.com/repos/mirumee/saleor/events","assignees_url":"https://api.github.com/repos/mirumee/saleor/assignees{/user}","branches_url":"https://api.github.com/repos/mirumee/saleor/branches{/branch}","tags_url":"https://api.github.com/repos/mirumee/saleor/tags","blobs_url":"https://api.github.com/repos/mirumee/saleor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirumee/saleor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirumee/saleor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirumee/saleor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirumee/saleor/statuses/{sha}","languages_url":"https://api.github.com/repos/mirumee/saleor/languages","stargazers_url":"https://api.github.com/repos/mirumee/saleor/stargazers","contributors_url":"https://api.github.com/repos/mirumee/saleor/contributors","subscribers_url":"https://api.github.com/repos/mirumee/saleor/subscribers","subscription_url":"https://api.github.com/repos/mirumee/saleor/subscription","commits_url":"https://api.github.com/repos/mirumee/saleor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirumee/saleor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirumee/saleor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirumee/saleor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirumee/saleor/contents/{+path}","compare_url":"https://api.github.com/repos/mirumee/saleor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirumee/saleor/merges","archive_url":"https://api.github.com/repos/mirumee/saleor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirumee/saleor/downloads","issues_url":"https://api.github.com/repos/mirumee/saleor/issues{/number}","pulls_url":"https://api.github.com/repos/mirumee/saleor/pulls{/number}","milestones_url":"https://api.github.com/repos/mirumee/saleor/milestones{/number}","notifications_url":"https://api.github.com/repos/mirumee/saleor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirumee/saleor/labels{/name}","releases_url":"https://api.github.com/repos/mirumee/saleor/releases{/id}","deployments_url":"https://api.github.com/repos/mirumee/saleor/deployments","created_at":"2013-02-12T16:46:39Z","updated_at":"2018-11-30T11:35:58Z","pushed_at":"2018-11-30T12:33:27Z","git_url":"git://github.com/mirumee/saleor.git","ssh_url":"git@github.com:mirumee/saleor.git","clone_url":"https://github.com/mirumee/saleor.git","svn_url":"https://github.com/mirumee/saleor","homepage":"http://getsaleor.com","size":83105,"stargazers_count":3211,"watchers_count":3211,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1366,"mirror_url":null,"archived":false,"open_issues_count":346,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1366,"open_issues":346,"watchers":3211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/3362"},"html":{"href":"https://github.com/mirumee/saleor/pull/3362"},"issue":{"href":"https://api.github.com/repos/mirumee/saleor/issues/3362"},"comments":{"href":"https://api.github.com/repos/mirumee/saleor/issues/3362/comments"},"review_comments":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/3362/comments"},"review_comment":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirumee/saleor/pulls/3362/commits"},"statuses":{"href":"https://api.github.com/repos/mirumee/saleor/statuses/4589a504fe1d36ab0c654d31ff1eb242de51089f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Pacu2"}}