{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/168191674","pull_request_review_id":96503986,"id":168191674,"diff_hunk":"@@ -141,6 +137,32 @@ struct spi_cs_control {\n \tu32_t\t\tdelay;\n };\n \n+/**\n+ * @brief Slave events\n+ */\n+enum spi_slave_event {\n+\t/** When slave chip is deselected */\n+\tSPI_SLAVE_EVENT_DESELECTED\t= 0,\n+\t/** When slave chip is selected */\n+\tSPI_SLAVE_EVENT_SELECTED,","path":"include/spi.h","position":49,"original_position":41,"commit_id":"3283eb6a226f92f34a2653a899889229083543d8","original_commit_id":"e6373e8d7da0cc4ae77e34b2a747f0e5593ea81f","user":{"login":"anangl","id":16913290,"avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false},"body":"If these two events are optional, it should be documented. So that no one expects an event that will never appear.","created_at":"2018-02-14T14:35:05Z","updated_at":"2018-02-14T14:50:13Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5921#discussion_r168191674","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/168191674"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5921#discussion_r168191674"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921"}},"in_reply_to_id":166264018},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921","id":166228154,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5921","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5921.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5921.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5921","number":5921,"state":"open","locked":false,"title":"SPI API cleanup and update","user":{"login":"tbursztyka","id":1608406,"avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false},"body":"Please review\r\n\r\nThe patch-set disables the legacy api by default, applies the feedback and then move most of the code using legacy API to the new API.\r\n\r\nSome other patch might come still, (esp ethernet stuff for instance) but it's worth reviewing the patches already.","created_at":"2018-01-31T11:03:47Z","updated_at":"2018-02-14T14:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e767e0496a4177e396f3ea7706b7306505ac12f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nzmichaelh","id":141541,"avatar_url":"https://avatars2.githubusercontent.com/u/141541?v=4","gravatar_id":"","url":"https://api.github.com/users/nzmichaelh","html_url":"https://github.com/nzmichaelh","followers_url":"https://api.github.com/users/nzmichaelh/followers","following_url":"https://api.github.com/users/nzmichaelh/following{/other_user}","gists_url":"https://api.github.com/users/nzmichaelh/gists{/gist_id}","starred_url":"https://api.github.com/users/nzmichaelh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzmichaelh/subscriptions","organizations_url":"https://api.github.com/users/nzmichaelh/orgs","repos_url":"https://api.github.com/users/nzmichaelh/repos","events_url":"https://api.github.com/users/nzmichaelh/events{/privacy}","received_events_url":"https://api.github.com/users/nzmichaelh/received_events","type":"User","site_admin":false},{"login":"nashif","id":180017,"avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},{"login":"MaureenHelm","id":6172539,"avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"erwango","id":18574308,"avatar_url":"https://avatars1.githubusercontent.com/u/18574308?v=4","gravatar_id":"","url":"https://api.github.com/users/erwango","html_url":"https://github.com/erwango","followers_url":"https://api.github.com/users/erwango/followers","following_url":"https://api.github.com/users/erwango/following{/other_user}","gists_url":"https://api.github.com/users/erwango/gists{/gist_id}","starred_url":"https://api.github.com/users/erwango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwango/subscriptions","organizations_url":"https://api.github.com/users/erwango/orgs","repos_url":"https://api.github.com/users/erwango/repos","events_url":"https://api.github.com/users/erwango/events{/privacy}","received_events_url":"https://api.github.com/users/erwango/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":796963297,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/API","name":"API","color":"d65e51","default":false},{"id":700751225,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20SPI","name":"area: SPI","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5921/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/3283eb6a226f92f34a2653a899889229083543d8","head":{"label":"tbursztyka:spi_api_rework","ref":"spi_api_rework","sha":"3283eb6a226f92f34a2653a899889229083543d8","user":{"login":"tbursztyka","id":1608406,"avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false},"repo":{"id":89999573,"name":"zephyr","full_name":"tbursztyka/zephyr","owner":{"login":"tbursztyka","id":1608406,"avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbursztyka/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/tbursztyka/zephyr","forks_url":"https://api.github.com/repos/tbursztyka/zephyr/forks","keys_url":"https://api.github.com/repos/tbursztyka/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbursztyka/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbursztyka/zephyr/teams","hooks_url":"https://api.github.com/repos/tbursztyka/zephyr/hooks","issue_events_url":"https://api.github.com/repos/tbursztyka/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/tbursztyka/zephyr/events","assignees_url":"https://api.github.com/repos/tbursztyka/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/tbursztyka/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/tbursztyka/zephyr/tags","blobs_url":"https://api.github.com/repos/tbursztyka/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbursztyka/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbursztyka/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbursztyka/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbursztyka/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/tbursztyka/zephyr/languages","stargazers_url":"https://api.github.com/repos/tbursztyka/zephyr/stargazers","contributors_url":"https://api.github.com/repos/tbursztyka/zephyr/contributors","subscribers_url":"https://api.github.com/repos/tbursztyka/zephyr/subscribers","subscription_url":"https://api.github.com/repos/tbursztyka/zephyr/subscription","commits_url":"https://api.github.com/repos/tbursztyka/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbursztyka/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbursztyka/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbursztyka/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbursztyka/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/tbursztyka/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbursztyka/zephyr/merges","archive_url":"https://api.github.com/repos/tbursztyka/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbursztyka/zephyr/downloads","issues_url":"https://api.github.com/repos/tbursztyka/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/tbursztyka/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/tbursztyka/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/tbursztyka/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbursztyka/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/tbursztyka/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/tbursztyka/zephyr/deployments","created_at":"2017-05-02T06:33:37Z","updated_at":"2017-05-02T06:34:14Z","pushed_at":"2018-02-14T14:50:13Z","git_url":"git://github.com/tbursztyka/zephyr.git","ssh_url":"git@github.com:tbursztyka/zephyr.git","clone_url":"https://github.com/tbursztyka/zephyr.git","svn_url":"https://github.com/tbursztyka/zephyr","homepage":"http://zephyrproject.org/doc","size":101223,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"6b3d2935f4309efd646e632bdcf2e0d57a0e1b1b","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-02-14T14:15:52Z","pushed_at":"2018-02-14T14:44:59Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":101306,"stargazers_count":635,"watchers_count":635,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":775,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":458,"open_issues":775,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5921"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5921"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5921/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5921/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/3283eb6a226f92f34a2653a899889229083543d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anangl"}}