{"action":"closed","issue":{"url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2186","repository_url":"https://api.github.com/repos/googleapis/gapic-generator","labels_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2186/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2186/comments","events_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2186/events","html_url":"https://github.com/googleapis/gapic-generator/issues/2186","id":347217547,"node_id":"MDU6SXNzdWUzNDcyMTc1NDc=","number":2186,"title":"[Ruby] Generated rubocop config should exclude ALL acceptance tests","user":{"login":"dazuma","id":8911,"node_id":"MDQ6VXNlcjg5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8911?v=4","gravatar_id":"","url":"https://api.github.com/users/dazuma","html_url":"https://github.com/dazuma","followers_url":"https://api.github.com/users/dazuma/followers","following_url":"https://api.github.com/users/dazuma/following{/other_user}","gists_url":"https://api.github.com/users/dazuma/gists{/gist_id}","starred_url":"https://api.github.com/users/dazuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazuma/subscriptions","organizations_url":"https://api.github.com/users/dazuma/orgs","repos_url":"https://api.github.com/users/dazuma/repos","events_url":"https://api.github.com/users/dazuma/events{/privacy}","received_events_url":"https://api.github.com/users/dazuma/received_events","type":"User","site_admin":false},"labels":[{"id":378711663,"node_id":"MDU6TGFiZWwzNzg3MTE2NjM=","url":"https://api.github.com/repos/googleapis/gapic-generator/labels/Lang:%20Ruby","name":"Lang: Ruby","color":"c0c0c0","default":false},{"id":417850523,"node_id":"MDU6TGFiZWw0MTc4NTA1MjM=","url":"https://api.github.com/repos/googleapis/gapic-generator/labels/Priority:%20P1","name":"Priority: P1","color":"ffa03e","default":false},{"id":360198959,"node_id":"MDU6TGFiZWwzNjAxOTg5NTk=","url":"https://api.github.com/repos/googleapis/gapic-generator/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"8bc34a","default":false},{"id":955711569,"node_id":"MDU6TGFiZWw5NTU3MTE1Njk=","url":"https://api.github.com/repos/googleapis/gapic-generator/labels/yoshi","name":"yoshi","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":{"login":"jbolinger","id":4023128,"node_id":"MDQ6VXNlcjQwMjMxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbolinger","id":4023128,"node_id":"MDQ6VXNlcjQwMjMxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-03T00:21:36Z","updated_at":"2018-08-06T19:54:16Z","closed_at":"2018-08-06T19:54:16Z","author_association":"NONE","body":"In the generated `.rubocop.yml` file, currently if there are acceptance tests, the exclusion rule lists only certain acceptance test files. For example, here is an excerpt from the generated file for speech:\r\n\r\n```yaml\r\nAllCops:\r\n  Exclude:\r\n    - \"google-cloud-speech.gemspec\"\r\n    - \"lib/google/**/*\"\r\n    - \"Rakefile\"\r\n    - \"test/**/*\"\r\n    - \"acceptance/**/*smoke_test.rb\"\r\n```\r\n\r\nPlease instead exclude ALL files under the acceptance directory, in the same way that all files are excluded under the test directory. e.g.\r\n\r\n```yaml\r\nAllCops:\r\n  Exclude:\r\n    - \"google-cloud-speech.gemspec\"\r\n    - \"lib/google/**/*\"\r\n    - \"Rakefile\"\r\n    - \"test/**/*\"\r\n    - \"acceptance/**/*\"\r\n```\r\n"}}
{"actor":{"display_login":"jbolinger"}}