{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/229251495","pull_request_review_id":169703377,"id":229251495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI1MTQ5NQ==","diff_hunk":"@@ -17,24 +17,12 @@\n \n import io.netty.buffer.ByteBuf;\n import io.netty.buffer.ByteBufHolder;\n-import io.netty.channel.AddressedEnvelope;\n-import io.netty.channel.ChannelFactory;\n-import io.netty.channel.ChannelFuture;\n-import io.netty.channel.EventLoop;\n-import io.netty.channel.EventLoopGroup;\n-import io.netty.channel.ReflectiveChannelFactory;\n+import io.netty.channel.*;\n import io.netty.channel.nio.NioEventLoopGroup;\n import io.netty.channel.socket.DatagramChannel;\n import io.netty.channel.socket.InternetProtocolFamily;\n import io.netty.channel.socket.nio.NioDatagramChannel;\n-import io.netty.handler.codec.dns.DefaultDnsQuestion;\n-import io.netty.handler.codec.dns.DnsQuestion;\n-import io.netty.handler.codec.dns.DnsRawRecord;\n-import io.netty.handler.codec.dns.DnsRecord;\n-import io.netty.handler.codec.dns.DnsRecordType;\n-import io.netty.handler.codec.dns.DnsResponse;\n-import io.netty.handler.codec.dns.DnsResponseCode;\n-import io.netty.handler.codec.dns.DnsSection;\n+import io.netty.handler.codec.dns.*;","path":"resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java","position":23,"original_position":23,"commit_id":"143012d112bfa824fd6e3493aeea4921f38888b6","original_commit_id":"143012d112bfa824fd6e3493aeea4921f38888b6","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"@slandelle can you please revert all the `wildcard import` changes ?","created_at":"2018-10-30T10:31:04Z","updated_at":"2018-10-30T10:31:24Z","html_url":"https://github.com/netty/netty/pull/8445#discussion_r229251495","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/8445","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/229251495"},"html":{"href":"https://github.com/netty/netty/pull/8445#discussion_r229251495"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/8445"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/8445","id":226861009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODYxMDA5","html_url":"https://github.com/netty/netty/pull/8445","diff_url":"https://github.com/netty/netty/pull/8445.diff","patch_url":"https://github.com/netty/netty/pull/8445.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/8445","number":8445,"state":"open","locked":false,"title":"Fix NPE when trying to build a DnsNameResolver with a null resolvedAddressTypes","user":{"login":"slandelle","id":849197,"node_id":"MDQ6VXNlcjg0OTE5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIt should be possible to build a DnsNameResolver with a null resolvedAddressTypes, defaulting then to DEFAULT_RESOLVE_ADDRESS_TYPES (see line 309).\r\n\r\nSadly, `preferredAddressType` is then called on line 377 with the original parameter instead of the instance attribute, causing an NPE when it's null.\r\n\r\nModification:\r\n\r\nCall preferredAddressType with instance attribuet instead of constructor parameter.\r\n\r\nResult:\r\n\r\nNo more NPE","created_at":"2018-10-30T10:13:19Z","updated_at":"2018-10-30T10:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fc35230ddb43285a61219fc71320fd2da72afbc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/8445/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/8445/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/8445/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/143012d112bfa824fd6e3493aeea4921f38888b6","head":{"label":"slandelle:4.1","ref":"4.1","sha":"143012d112bfa824fd6e3493aeea4921f38888b6","user":{"login":"slandelle","id":849197,"node_id":"MDQ6VXNlcjg0OTE5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"repo":{"id":33929023,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkyOTAyMw==","name":"netty","full_name":"slandelle/netty","private":false,"owner":{"login":"slandelle","id":849197,"node_id":"MDQ6VXNlcjg0OTE5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/slandelle/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/slandelle/netty","forks_url":"https://api.github.com/repos/slandelle/netty/forks","keys_url":"https://api.github.com/repos/slandelle/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slandelle/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slandelle/netty/teams","hooks_url":"https://api.github.com/repos/slandelle/netty/hooks","issue_events_url":"https://api.github.com/repos/slandelle/netty/issues/events{/number}","events_url":"https://api.github.com/repos/slandelle/netty/events","assignees_url":"https://api.github.com/repos/slandelle/netty/assignees{/user}","branches_url":"https://api.github.com/repos/slandelle/netty/branches{/branch}","tags_url":"https://api.github.com/repos/slandelle/netty/tags","blobs_url":"https://api.github.com/repos/slandelle/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slandelle/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slandelle/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/slandelle/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slandelle/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/slandelle/netty/languages","stargazers_url":"https://api.github.com/repos/slandelle/netty/stargazers","contributors_url":"https://api.github.com/repos/slandelle/netty/contributors","subscribers_url":"https://api.github.com/repos/slandelle/netty/subscribers","subscription_url":"https://api.github.com/repos/slandelle/netty/subscription","commits_url":"https://api.github.com/repos/slandelle/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/slandelle/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/slandelle/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/slandelle/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/slandelle/netty/contents/{+path}","compare_url":"https://api.github.com/repos/slandelle/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slandelle/netty/merges","archive_url":"https://api.github.com/repos/slandelle/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slandelle/netty/downloads","issues_url":"https://api.github.com/repos/slandelle/netty/issues{/number}","pulls_url":"https://api.github.com/repos/slandelle/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/slandelle/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/slandelle/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slandelle/netty/labels{/name}","releases_url":"https://api.github.com/repos/slandelle/netty/releases{/id}","deployments_url":"https://api.github.com/repos/slandelle/netty/deployments","created_at":"2015-04-14T11:58:26Z","updated_at":"2016-11-09T11:43:32Z","pushed_at":"2018-10-30T10:27:29Z","git_url":"git://github.com/slandelle/netty.git","ssh_url":"git@github.com:slandelle/netty.git","clone_url":"https://github.com/slandelle/netty.git","svn_url":"https://github.com/slandelle/netty","homepage":"http://netty.io/","size":48843,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"44c3b824ecabe5d4bf52d3a9a7a30c456ee391b8","user":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NTYz","name":"netty","full_name":"netty/netty","private":false,"owner":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2018-10-30T10:20:27Z","pushed_at":"2018-10-30T10:27:33Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":52683,"stargazers_count":16267,"watchers_count":16267,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7155,"mirror_url":null,"archived":false,"open_issues_count":405,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7155,"open_issues":405,"watchers":16267,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/8445"},"html":{"href":"https://github.com/netty/netty/pull/8445"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/8445"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/8445/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/8445/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/8445/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/143012d112bfa824fd6e3493aeea4921f38888b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"normanmaurer"}}