{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/226353668","pull_request_review_id":166156801,"id":226353668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjM1MzY2OA==","diff_hunk":"@@ -629,6 +637,10 @@ type AlertmanagerSpec struct {\n \t// object, which shall be mounted into the Alertmanager Pods.\n \t// The Secrets are mounted into /etc/alertmanager/secrets/<secret-name>.\n \tSecrets []string `json:\"secrets,omitempty\"`\n+\t// ConfigMaps is a list of ConfigMaps in the same namespace as the Alertmanager\n+\t// object, which shall be mounted into the Alertmanager Pods.\n+\t// The ConfigMaps are mounted into /etc/alertmanager/configmaps/<configmap-name>.","path":"pkg/client/monitoring/v1/types.go","position":21,"original_position":21,"commit_id":"9f717cdaeb54bf25545ef77e17cf902e060cb25b","original_commit_id":"9f717cdaeb54bf25545ef77e17cf902e060cb25b","user":{"login":"mxinden","id":7047859,"node_id":"MDQ6VXNlcjcwNDc4NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"body":"Missing some details mentioned in the `PrometheusSpec.ConfigMaps` comment:\r\n\r\n```\r\nConfigMap changes after initial creation of a Prometheus object are not reflected in the running Pods. To change the ConfigMaps mounted into the Prometheus Pods, the object must be deleted and recreated with the new list of ConfigMaps.\r\n```","created_at":"2018-10-18T15:29:12Z","updated_at":"2018-10-18T15:29:12Z","html_url":"https://github.com/coreos/prometheus-operator/pull/2028#discussion_r226353668","pull_request_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/226353668"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/2028#discussion_r226353668"},"pull_request":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028","id":223951857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTUxODU3","html_url":"https://github.com/coreos/prometheus-operator/pull/2028","diff_url":"https://github.com/coreos/prometheus-operator/pull/2028.diff","patch_url":"https://github.com/coreos/prometheus-operator/pull/2028.patch","issue_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2028","number":2028,"state":"open","locked":false,"title":"*: Add ability to mount custom ConfigMaps","user":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"body":"@squat @mxinden @s-urbaniak @metalmatze ","created_at":"2018-10-18T13:15:23Z","updated_at":"2018-10-18T15:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4faee542b52cded093109068081e6b1ce62004cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028/commits","review_comments_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028/comments","review_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2028/comments","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/9f717cdaeb54bf25545ef77e17cf902e060cb25b","head":{"label":"brancz:configmaps","ref":"configmaps","sha":"9f717cdaeb54bf25545ef77e17cf902e060cb25b","user":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"repo":{"id":72764023,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2NDAyMw==","name":"prometheus-operator","full_name":"brancz/prometheus-operator","private":false,"owner":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brancz/prometheus-operator","description":null,"fork":true,"url":"https://api.github.com/repos/brancz/prometheus-operator","forks_url":"https://api.github.com/repos/brancz/prometheus-operator/forks","keys_url":"https://api.github.com/repos/brancz/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brancz/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brancz/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/brancz/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/brancz/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/brancz/prometheus-operator/events","assignees_url":"https://api.github.com/repos/brancz/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/brancz/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/brancz/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/brancz/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brancz/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brancz/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/brancz/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brancz/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/brancz/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/brancz/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/brancz/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/brancz/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/brancz/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/brancz/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/brancz/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/brancz/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/brancz/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/brancz/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/brancz/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brancz/prometheus-operator/merges","archive_url":"https://api.github.com/repos/brancz/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brancz/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/brancz/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/brancz/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/brancz/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/brancz/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brancz/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/brancz/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/brancz/prometheus-operator/deployments","created_at":"2016-11-03T16:19:53Z","updated_at":"2018-08-03T04:14:50Z","pushed_at":"2018-10-18T14:25:57Z","git_url":"git://github.com/brancz/prometheus-operator.git","ssh_url":"git@github.com:brancz/prometheus-operator.git","clone_url":"https://github.com/brancz/prometheus-operator.git","svn_url":"https://github.com/brancz/prometheus-operator","homepage":null,"size":54355,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f6b7ad99a72e24a7979f7cf152d17d59821c75a1","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":68964263,"node_id":"MDEwOlJlcG9zaXRvcnk2ODk2NDI2Mw==","name":"prometheus-operator","full_name":"coreos/prometheus-operator","private":false,"owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coreos/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/prometheus-operator","forks_url":"https://api.github.com/repos/coreos/prometheus-operator/forks","keys_url":"https://api.github.com/repos/coreos/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/coreos/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/prometheus-operator/events","assignees_url":"https://api.github.com/repos/coreos/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/coreos/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/prometheus-operator/merges","archive_url":"https://api.github.com/repos/coreos/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/coreos/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/prometheus-operator/deployments","created_at":"2016-09-22T21:38:06Z","updated_at":"2018-10-18T14:32:30Z","pushed_at":"2018-10-18T14:32:22Z","git_url":"git://github.com/coreos/prometheus-operator.git","ssh_url":"git@github.com:coreos/prometheus-operator.git","clone_url":"https://github.com/coreos/prometheus-operator.git","svn_url":"https://github.com/coreos/prometheus-operator","homepage":"https://coreos.com/operators/prometheus","size":54359,"stargazers_count":1852,"watchers_count":1852,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":872,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":872,"open_issues":238,"watchers":1852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/2028"},"issue":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/2028"},"comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/2028/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/2028/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/prometheus-operator/statuses/9f717cdaeb54bf25545ef77e17cf902e060cb25b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mxinden"}}