{"push_id":2385130081,"size":10,"distinct_size":10,"ref":"refs/heads/adjust_timeouts","head":"98c11dceb115f1433df3122647efa5337e719fd1","before":"5ef287e0d20730d3f6058cc469a7c7d78ccbef94","commits":[{"sha":"9583581280e1927b847f1aab327e66e168d1b656","author":{"name":"W. Trevor King","email":"367c1f892d0f1e7136d95306567c75a61e9d6b88@tremily.us"},"message":"conmon: Distinguish pexit(s) from pexitf(fmt, ...) and similar\n\nAvoid:\n\n  $ make clean && make CFLAGS=-Wpedantic 2>&1 | head -n 5\n  rm -f conmon.o cmsg.o ../bin/conmon\n  cc -Wpedantic -std=c99 -Os -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -c -o conmon.o conmon.c\n  conmon.c: In function ‘write_k8s_log’:\n  conmon.c:342:33: warning: ISO C99 requires at least one argument for the \"...\" in a variadic macro\n      ninfo(\"Creating new log file\");\n                                   ^\n\nby distinguishing between calls with and without user-supplied\nformatting.\n\nAlso remove some user-supplied newlines from the following\n\n* nwarn for \"Could not find newline in entire buffer\"\n* ninfo for \"Got ctl message...\"\n* ninfo for \"container %d exited with status...\"\n* nexitf for \"Failed to write %s to exit file...\"\n\nbecause the macros add their own trailing newlines.\n\nAlso drop some redundant user-specified strerror() arguments from the\nfollowing:\n\n* pexit for \"Failed to open log file...\"\n* pexit for \"Runtime path %s is not valid...\"\n\nbecause the pexit* macros add strerror on their own.\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/9583581280e1927b847f1aab327e66e168d1b656"},{"sha":"f67d6ed25cc6860d5d9d8edf1698d458591db174","author":{"name":"W. Trevor King","email":"367c1f892d0f1e7136d95306567c75a61e9d6b88@tremily.us"},"message":"conmon: Use strerror(errno) instead of %m\n\nAvoid:\n\n  $ make clean && make CFLAGS=-Wpedantic 2>&1 | head -n5\n  rm -f conmon.o cmsg.o ../bin/conmon\n  cc -Wpedantic -std=c99 -Os -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -c -o conmon.o conmon.c\n  conmon.c: In function ‘write_k8s_log’:\n  conmon.c:32:19: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]\n     fprintf(stderr, \"[conmon:e]: %s %m\\n\", s);     \\\n                     ^\n\nfrom printf(3) [1]:\n\n  m (Glibc extension; supported by uClibc and musl.)  Print output of\n    strerror(errno).  No argument is required.\n\nstrerror, on the other hand, is in POSIX [2].\n\n[1]: http://man7.org/linux/man-pages/man3/printf.3.html\n[2]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strerror.html\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/f67d6ed25cc6860d5d9d8edf1698d458591db174"},{"sha":"9356aa9dd8db864518e024bbbe05bc1a56db8497","author":{"name":"W. Trevor King","email":"367c1f892d0f1e7136d95306567c75a61e9d6b88@tremily.us"},"message":"conmon/cmsg: Distinguish error(s) from errorf(fmt, ...) and replace %m\n\nThe same as the last two commits, except for cmsg.c instead of\nconmon.c.\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/9356aa9dd8db864518e024bbbe05bc1a56db8497"},{"sha":"f3c9a6c4abcd129e237638f20b4f38dbc09de8bc","author":{"name":"W. Trevor King","email":"367c1f892d0f1e7136d95306567c75a61e9d6b88@tremily.us"},"message":"cmsg: Use do/while for error and errorf\n\nAvoid:\n\n  $ make clean && make CFLAGS='-Wpedantic' cmsg.o 2>&1 | head -n5\n  rm -f conmon.o cmsg.o ../bin/conmon\n  cc -Wpedantic -std=c99 -Os -Wall -Wextra -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -c -o cmsg.o cmsg.c\n  cmsg.c: In function ‘recvfd’:\n  cmsg.c:30:2: warning: ISO C forbids braced-groups within expressions [-Wpedantic]\n    ({         \\\n    ^\n\nSigned-off-by: W. Trevor King <wking@tremily.us>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/f3c9a6c4abcd129e237638f20b4f38dbc09de8bc"},{"sha":"7036d1c0c2d735a1e1e29ac772cae5e3d7b9c111","author":{"name":"Giuseppe Scrivano","email":"73d394c77aa2d4f8ebf5e3eb45f6763ad909e7a3@redhat.com"},"message":"conmon: catch SIGTERM, SIGINT and SIQUIT\n\nand forward them to the watched process.  A side effect is that we can\ncorrectly invoke the exit command if conmon receives them.\n\nSigned-off-by: Giuseppe Scrivano <gscrivan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/7036d1c0c2d735a1e1e29ac772cae5e3d7b9c111"},{"sha":"986face946100bcfbde3aedc57d744633f4a0204","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Merge pull request #1368 from wking/conmon-Xf-variadic-macros\n\nconmon: Distinguish pexit(s) from pexitf(fmt, ...) and similar","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/986face946100bcfbde3aedc57d744633f4a0204"},{"sha":"c189b8d14750b08e6b092e5a4ef0ed990a206b39","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Merge pull request #1409 from giuseppe/conmon-catch-signals\n\nconmon: catch SIGTERM, SIGINT and SIGQUIT","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/c189b8d14750b08e6b092e5a4ef0ed990a206b39"},{"sha":"2bac4d8a47f0db4a684fbe2df837523126d9ac3b","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Setup LISTEN_PID to point to new child process\n\nIn order to get systemd socket passing to work properly\nthe listen PID needs to match the process ID of the OCI runtime.\nThis match modifies the LISTEN_PID if it is set to the new runtime.\n\nconmon will check that the LISTEN_PID the pid that conmon is running as and\nwill ignore it if they are different.  But, if the caller specifies the\n--replace-listen-pid flag, then the LISTEN_PID/LISTEN_FDS will always be used.\n\nSigned-off-by: Daniel J Walsh <dwalsh@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/2bac4d8a47f0db4a684fbe2df837523126d9ac3b"},{"sha":"e8c108d415d7de0fb890be95e17307b845a19c2c","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Merge pull request #1300 from rhatdan/listen_pid\n\nSetup LISTEN_PID to point to new child process","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/e8c108d415d7de0fb890be95e17307b845a19c2c"},{"sha":"98c11dceb115f1433df3122647efa5337e719fd1","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Tweak test timeouts to be readable + realistic\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/98c11dceb115f1433df3122647efa5337e719fd1"}]}
{"actor":{"display_login":"cevich"}}