{"action":"created","issue":{"url":"https://api.github.com/repos/transloadit/uppy/issues/845","repository_url":"https://api.github.com/repos/transloadit/uppy","labels_url":"https://api.github.com/repos/transloadit/uppy/issues/845/labels{/name}","comments_url":"https://api.github.com/repos/transloadit/uppy/issues/845/comments","events_url":"https://api.github.com/repos/transloadit/uppy/issues/845/events","html_url":"https://github.com/transloadit/uppy/pull/845","id":325211344,"number":845,"title":"Documentation improvements: individual React component pages, more plugin options","user":{"login":"goto-bus-stop","id":1006268,"avatar_url":"https://avatars1.githubusercontent.com/u/1006268?v=4","gravatar_id":"","url":"https://api.github.com/users/goto-bus-stop","html_url":"https://github.com/goto-bus-stop","followers_url":"https://api.github.com/users/goto-bus-stop/followers","following_url":"https://api.github.com/users/goto-bus-stop/following{/other_user}","gists_url":"https://api.github.com/users/goto-bus-stop/gists{/gist_id}","starred_url":"https://api.github.com/users/goto-bus-stop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goto-bus-stop/subscriptions","organizations_url":"https://api.github.com/users/goto-bus-stop/orgs","repos_url":"https://api.github.com/users/goto-bus-stop/repos","events_url":"https://api.github.com/users/goto-bus-stop/events{/privacy}","received_events_url":"https://api.github.com/users/goto-bus-stop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T09:28:57Z","updated_at":"2018-05-25T02:55:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/845","html_url":"https://github.com/transloadit/uppy/pull/845","diff_url":"https://github.com/transloadit/uppy/pull/845.diff","patch_url":"https://github.com/transloadit/uppy/pull/845.patch"},"body":"Most of the React component pages just link to the doc pages for the plugins they wrap.\r\n\r\nIt would be nice to list all the props descriptions on the component pages, but then we'd duplicate a bunch of stuff from the plugin pages and have to keep it in sync. If that could be automated tho…\r\n\r\nThis also changes some things about plugin documentation pages.\r\n\r\n - The `id` option is listed on each plugin's documentation page.\r\n - The `replaceTargetContent` option is listed on UI plugin documentation pages.\r\n - The `locale` option is described on each plugin documentation page, and includes a short description for each string. The default value is removed from the snippet at the top of the `## Options` section to save some space (since it's a very large object sometimes).\r\n\r\nAlso took this opportunity to change some of the strings that we were concatenating in Preact, now their interpolation is handled by the Translator instead. This is important for languages that have different word order than English. We can't do it in all situations yet because some parts of some strings need to be wrapped in Preact elements, which the Translator can't handle."},"comment":{"url":"https://api.github.com/repos/transloadit/uppy/issues/comments/391926325","html_url":"https://github.com/transloadit/uppy/pull/845#issuecomment-391926325","issue_url":"https://api.github.com/repos/transloadit/uppy/issues/845","id":391926325,"user":{"login":"arturi","id":1199054,"avatar_url":"https://avatars2.githubusercontent.com/u/1199054?v=4","gravatar_id":"","url":"https://api.github.com/users/arturi","html_url":"https://github.com/arturi","followers_url":"https://api.github.com/users/arturi/followers","following_url":"https://api.github.com/users/arturi/following{/other_user}","gists_url":"https://api.github.com/users/arturi/gists{/gist_id}","starred_url":"https://api.github.com/users/arturi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturi/subscriptions","organizations_url":"https://api.github.com/users/arturi/orgs","repos_url":"https://api.github.com/users/arturi/repos","events_url":"https://api.github.com/users/arturi/events{/privacy}","received_events_url":"https://api.github.com/users/arturi/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T02:55:22Z","updated_at":"2018-05-25T02:55:22Z","author_association":"COLLABORATOR","body":"Amazing work explaining all the locale strings, repeating options where necessary, like `id`s and `replaceTargetContent`, separate React components — just pure joy and awesomeness all around ❤️ 💯\r\n\r\n> Also took this opportunity to change some of the strings that we were concatenating in Preact, now their interpolation is handled by the Translator instead\r\n\r\nAwesome, great thinking!\r\n\r\nLeft minor remarks, but ready to merge 👍"}}
{"actor":{"display_login":"arturi"}}