{"action":"created","comment":{"url":"https://api.github.com/repos/IBM/carbon-components/pulls/comments/222841194","pull_request_review_id":161827742,"id":222841194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjg0MTE5NA==","diff_hunk":"@@ -54,6 +54,11 @@\n     box-shadow: 0 0 0 3px $color__blue-20;\n     outline: 1px solid transparent;\n   }\n+\n+  @if ($type == 'experimental') {","path":"src/globals/scss/_helper-mixins.scss","position":5,"original_position":5,"commit_id":"e3f60ef63af90f6cc4c6f6ecef4525d675167405","original_commit_id":"3b10994285aff0ecb12daff83637e585a0053bb6","user":{"login":"asudoh","id":1259051,"node_id":"MDQ6VXNlcjEyNTkwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1259051?v=4","gravatar_id":"","url":"https://api.github.com/users/asudoh","html_url":"https://github.com/asudoh","followers_url":"https://api.github.com/users/asudoh/followers","following_url":"https://api.github.com/users/asudoh/following{/other_user}","gists_url":"https://api.github.com/users/asudoh/gists{/gist_id}","starred_url":"https://api.github.com/users/asudoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asudoh/subscriptions","organizations_url":"https://api.github.com/users/asudoh/orgs","repos_url":"https://api.github.com/users/asudoh/repos","events_url":"https://api.github.com/users/asudoh/events{/privacy}","received_events_url":"https://api.github.com/users/asudoh/received_events","type":"User","site_admin":false},"body":"Thanks @alisonjoseph for the background! One option I can think of is adding an arg to `focus-outline`, which is an optional color. Another option I can think of is a different name - The new one seems to be a flavor of `blurred` one, though?","created_at":"2018-10-04T22:01:40Z","updated_at":"2018-10-04T22:01:40Z","html_url":"https://github.com/IBM/carbon-components/pull/1160#discussion_r222841194","pull_request_url":"https://api.github.com/repos/IBM/carbon-components/pulls/1160","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/comments/222841194"},"html":{"href":"https://github.com/IBM/carbon-components/pull/1160#discussion_r222841194"},"pull_request":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/1160"}},"in_reply_to_id":222486457},"pull_request":{"url":"https://api.github.com/repos/IBM/carbon-components/pulls/1160","id":220053854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDUzODU0","html_url":"https://github.com/IBM/carbon-components/pull/1160","diff_url":"https://github.com/IBM/carbon-components/pull/1160.diff","patch_url":"https://github.com/IBM/carbon-components/pull/1160.patch","issue_url":"https://api.github.com/repos/IBM/carbon-components/issues/1160","number":1160,"state":"open","locked":false,"title":"feat(radio-button): add experimental styles","user":{"login":"alisonjoseph","id":2753488,"node_id":"MDQ6VXNlcjI3NTM0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/2753488?v=4","gravatar_id":"","url":"https://api.github.com/users/alisonjoseph","html_url":"https://github.com/alisonjoseph","followers_url":"https://api.github.com/users/alisonjoseph/followers","following_url":"https://api.github.com/users/alisonjoseph/following{/other_user}","gists_url":"https://api.github.com/users/alisonjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonjoseph/subscriptions","organizations_url":"https://api.github.com/users/alisonjoseph/orgs","repos_url":"https://api.github.com/users/alisonjoseph/repos","events_url":"https://api.github.com/users/alisonjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/alisonjoseph/received_events","type":"User","site_admin":false},"body":"Closes #1121\r\n\r\nAdds experimental radio button styles. \r\n\r\nnote: The focus state in the sketch file is only 1px, so changed it to 3px to match checkboxes for accessibility. \r\n\r\nCircles are 20px x 20px and spacing to the right is 8px\r\n\r\nDoes 20px seem too big when next to the checkbox (which is 16x16)?\r\n\r\n<img width=\"191\" alt=\"screen shot 2018-10-03 at 9 19 47 am\" src=\"https://user-images.githubusercontent.com/2753488/46416602-870b1780-c6ed-11e8-9595-2b0798bdfc19.png\">\r\n\r\n\r\nBlack border is 1px, however in the sketch file its 1.5. @jeanservaas do we want 1px or 2px for the border? I made it 1px to match checkboxes but let me know if I should change it. \r\n\r\n#### Changelog\r\n\r\n**New**\r\n\r\nexperimental radio button styles\r\nadded new experimental focus state mixin (should we use this on the ex. components already created?)\r\n\r\n#### Testing / Reviewing\r\nhttp://carbon-dev-environment-optimistic-kangaroo.stage1.mybluemix.net/component/radio-button\r\n","created_at":"2018-10-03T14:15:23Z","updated_at":"2018-10-04T22:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74bc13f72eb15f4189101ecea9e85aaa4a120b75","assignee":{"login":"jeanservaas","id":43144260,"node_id":"MDQ6VXNlcjQzMTQ0MjYw","avatar_url":"https://avatars2.githubusercontent.com/u/43144260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanservaas","html_url":"https://github.com/jeanservaas","followers_url":"https://api.github.com/users/jeanservaas/followers","following_url":"https://api.github.com/users/jeanservaas/following{/other_user}","gists_url":"https://api.github.com/users/jeanservaas/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanservaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanservaas/subscriptions","organizations_url":"https://api.github.com/users/jeanservaas/orgs","repos_url":"https://api.github.com/users/jeanservaas/repos","events_url":"https://api.github.com/users/jeanservaas/events{/privacy}","received_events_url":"https://api.github.com/users/jeanservaas/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeanservaas","id":43144260,"node_id":"MDQ6VXNlcjQzMTQ0MjYw","avatar_url":"https://avatars2.githubusercontent.com/u/43144260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanservaas","html_url":"https://github.com/jeanservaas","followers_url":"https://api.github.com/users/jeanservaas/followers","following_url":"https://api.github.com/users/jeanservaas/following{/other_user}","gists_url":"https://api.github.com/users/jeanservaas/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanservaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanservaas/subscriptions","organizations_url":"https://api.github.com/users/jeanservaas/orgs","repos_url":"https://api.github.com/users/jeanservaas/repos","events_url":"https://api.github.com/users/jeanservaas/events{/privacy}","received_events_url":"https://api.github.com/users/jeanservaas/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jeanservaas","id":43144260,"node_id":"MDQ6VXNlcjQzMTQ0MjYw","avatar_url":"https://avatars2.githubusercontent.com/u/43144260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanservaas","html_url":"https://github.com/jeanservaas","followers_url":"https://api.github.com/users/jeanservaas/followers","following_url":"https://api.github.com/users/jeanservaas/following{/other_user}","gists_url":"https://api.github.com/users/jeanservaas/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanservaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanservaas/subscriptions","organizations_url":"https://api.github.com/users/jeanservaas/orgs","repos_url":"https://api.github.com/users/jeanservaas/repos","events_url":"https://api.github.com/users/jeanservaas/events{/privacy}","received_events_url":"https://api.github.com/users/jeanservaas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1056028590,"node_id":"MDU6TGFiZWwxMDU2MDI4NTkw","url":"https://api.github.com/repos/IBM/carbon-components/labels/status:%20ready%20for%20review%20%20:eyes:","name":"status: ready for review  :eyes:","color":"fbca04","default":false},{"id":1056028598,"node_id":"MDU6TGFiZWwxMDU2MDI4NTk4","url":"https://api.github.com/repos/IBM/carbon-components/labels/status:%20visual%20review%20:eyes:","name":"status: visual review :eyes:","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IBM/carbon-components/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/IBM/carbon-components/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/IBM/carbon-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBM/carbon-components/issues/1160/comments","statuses_url":"https://api.github.com/repos/IBM/carbon-components/statuses/e3f60ef63af90f6cc4c6f6ecef4525d675167405","head":{"label":"alisonjoseph:radio-x","ref":"radio-x","sha":"e3f60ef63af90f6cc4c6f6ecef4525d675167405","user":{"login":"alisonjoseph","id":2753488,"node_id":"MDQ6VXNlcjI3NTM0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/2753488?v=4","gravatar_id":"","url":"https://api.github.com/users/alisonjoseph","html_url":"https://github.com/alisonjoseph","followers_url":"https://api.github.com/users/alisonjoseph/followers","following_url":"https://api.github.com/users/alisonjoseph/following{/other_user}","gists_url":"https://api.github.com/users/alisonjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonjoseph/subscriptions","organizations_url":"https://api.github.com/users/alisonjoseph/orgs","repos_url":"https://api.github.com/users/alisonjoseph/repos","events_url":"https://api.github.com/users/alisonjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/alisonjoseph/received_events","type":"User","site_admin":false},"repo":{"id":140582342,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1ODIzNDI=","name":"carbon-components","full_name":"alisonjoseph/carbon-components","private":false,"owner":{"login":"alisonjoseph","id":2753488,"node_id":"MDQ6VXNlcjI3NTM0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/2753488?v=4","gravatar_id":"","url":"https://api.github.com/users/alisonjoseph","html_url":"https://github.com/alisonjoseph","followers_url":"https://api.github.com/users/alisonjoseph/followers","following_url":"https://api.github.com/users/alisonjoseph/following{/other_user}","gists_url":"https://api.github.com/users/alisonjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonjoseph/subscriptions","organizations_url":"https://api.github.com/users/alisonjoseph/orgs","repos_url":"https://api.github.com/users/alisonjoseph/repos","events_url":"https://api.github.com/users/alisonjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/alisonjoseph/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alisonjoseph/carbon-components","description":"The component library behind Carbon Design System","fork":true,"url":"https://api.github.com/repos/alisonjoseph/carbon-components","forks_url":"https://api.github.com/repos/alisonjoseph/carbon-components/forks","keys_url":"https://api.github.com/repos/alisonjoseph/carbon-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alisonjoseph/carbon-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alisonjoseph/carbon-components/teams","hooks_url":"https://api.github.com/repos/alisonjoseph/carbon-components/hooks","issue_events_url":"https://api.github.com/repos/alisonjoseph/carbon-components/issues/events{/number}","events_url":"https://api.github.com/repos/alisonjoseph/carbon-components/events","assignees_url":"https://api.github.com/repos/alisonjoseph/carbon-components/assignees{/user}","branches_url":"https://api.github.com/repos/alisonjoseph/carbon-components/branches{/branch}","tags_url":"https://api.github.com/repos/alisonjoseph/carbon-components/tags","blobs_url":"https://api.github.com/repos/alisonjoseph/carbon-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alisonjoseph/carbon-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alisonjoseph/carbon-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/alisonjoseph/carbon-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alisonjoseph/carbon-components/statuses/{sha}","languages_url":"https://api.github.com/repos/alisonjoseph/carbon-components/languages","stargazers_url":"https://api.github.com/repos/alisonjoseph/carbon-components/stargazers","contributors_url":"https://api.github.com/repos/alisonjoseph/carbon-components/contributors","subscribers_url":"https://api.github.com/repos/alisonjoseph/carbon-components/subscribers","subscription_url":"https://api.github.com/repos/alisonjoseph/carbon-components/subscription","commits_url":"https://api.github.com/repos/alisonjoseph/carbon-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/alisonjoseph/carbon-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/alisonjoseph/carbon-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/alisonjoseph/carbon-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/alisonjoseph/carbon-components/contents/{+path}","compare_url":"https://api.github.com/repos/alisonjoseph/carbon-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alisonjoseph/carbon-components/merges","archive_url":"https://api.github.com/repos/alisonjoseph/carbon-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alisonjoseph/carbon-components/downloads","issues_url":"https://api.github.com/repos/alisonjoseph/carbon-components/issues{/number}","pulls_url":"https://api.github.com/repos/alisonjoseph/carbon-components/pulls{/number}","milestones_url":"https://api.github.com/repos/alisonjoseph/carbon-components/milestones{/number}","notifications_url":"https://api.github.com/repos/alisonjoseph/carbon-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alisonjoseph/carbon-components/labels{/name}","releases_url":"https://api.github.com/repos/alisonjoseph/carbon-components/releases{/id}","deployments_url":"https://api.github.com/repos/alisonjoseph/carbon-components/deployments","created_at":"2018-07-11T13:54:34Z","updated_at":"2018-10-03T13:39:28Z","pushed_at":"2018-10-04T17:27:36Z","git_url":"git://github.com/alisonjoseph/carbon-components.git","ssh_url":"git@github.com:alisonjoseph/carbon-components.git","clone_url":"https://github.com/alisonjoseph/carbon-components.git","svn_url":"https://github.com/alisonjoseph/carbon-components","homepage":"http://www.carbondesignsystem.com","size":15699,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IBM:master","ref":"master","sha":"e72ea969c518ad6051ceffd0c007f579acbf407e","user":{"login":"IBM","id":1459110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1459110?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM","html_url":"https://github.com/IBM","followers_url":"https://api.github.com/users/IBM/followers","following_url":"https://api.github.com/users/IBM/following{/other_user}","gists_url":"https://api.github.com/users/IBM/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM/subscriptions","organizations_url":"https://api.github.com/users/IBM/orgs","repos_url":"https://api.github.com/users/IBM/repos","events_url":"https://api.github.com/users/IBM/events{/privacy}","received_events_url":"https://api.github.com/users/IBM/received_events","type":"Organization","site_admin":false},"repo":{"id":84835535,"node_id":"MDEwOlJlcG9zaXRvcnk4NDgzNTUzNQ==","name":"carbon-components","full_name":"IBM/carbon-components","private":false,"owner":{"login":"IBM","id":1459110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1459110?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM","html_url":"https://github.com/IBM","followers_url":"https://api.github.com/users/IBM/followers","following_url":"https://api.github.com/users/IBM/following{/other_user}","gists_url":"https://api.github.com/users/IBM/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM/subscriptions","organizations_url":"https://api.github.com/users/IBM/orgs","repos_url":"https://api.github.com/users/IBM/repos","events_url":"https://api.github.com/users/IBM/events{/privacy}","received_events_url":"https://api.github.com/users/IBM/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IBM/carbon-components","description":"The component library behind Carbon Design System","fork":false,"url":"https://api.github.com/repos/IBM/carbon-components","forks_url":"https://api.github.com/repos/IBM/carbon-components/forks","keys_url":"https://api.github.com/repos/IBM/carbon-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM/carbon-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM/carbon-components/teams","hooks_url":"https://api.github.com/repos/IBM/carbon-components/hooks","issue_events_url":"https://api.github.com/repos/IBM/carbon-components/issues/events{/number}","events_url":"https://api.github.com/repos/IBM/carbon-components/events","assignees_url":"https://api.github.com/repos/IBM/carbon-components/assignees{/user}","branches_url":"https://api.github.com/repos/IBM/carbon-components/branches{/branch}","tags_url":"https://api.github.com/repos/IBM/carbon-components/tags","blobs_url":"https://api.github.com/repos/IBM/carbon-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM/carbon-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM/carbon-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM/carbon-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM/carbon-components/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM/carbon-components/languages","stargazers_url":"https://api.github.com/repos/IBM/carbon-components/stargazers","contributors_url":"https://api.github.com/repos/IBM/carbon-components/contributors","subscribers_url":"https://api.github.com/repos/IBM/carbon-components/subscribers","subscription_url":"https://api.github.com/repos/IBM/carbon-components/subscription","commits_url":"https://api.github.com/repos/IBM/carbon-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM/carbon-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM/carbon-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM/carbon-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM/carbon-components/contents/{+path}","compare_url":"https://api.github.com/repos/IBM/carbon-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM/carbon-components/merges","archive_url":"https://api.github.com/repos/IBM/carbon-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM/carbon-components/downloads","issues_url":"https://api.github.com/repos/IBM/carbon-components/issues{/number}","pulls_url":"https://api.github.com/repos/IBM/carbon-components/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM/carbon-components/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM/carbon-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM/carbon-components/labels{/name}","releases_url":"https://api.github.com/repos/IBM/carbon-components/releases{/id}","deployments_url":"https://api.github.com/repos/IBM/carbon-components/deployments","created_at":"2017-03-13T14:23:59Z","updated_at":"2018-10-04T21:54:43Z","pushed_at":"2018-10-04T21:58:37Z","git_url":"git://github.com/IBM/carbon-components.git","ssh_url":"git@github.com:IBM/carbon-components.git","clone_url":"https://github.com/IBM/carbon-components.git","svn_url":"https://github.com/IBM/carbon-components","homepage":"http://www.carbondesignsystem.com","size":15692,"stargazers_count":970,"watchers_count":970,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":193,"open_issues":75,"watchers":970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/1160"},"html":{"href":"https://github.com/IBM/carbon-components/pull/1160"},"issue":{"href":"https://api.github.com/repos/IBM/carbon-components/issues/1160"},"comments":{"href":"https://api.github.com/repos/IBM/carbon-components/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBM/carbon-components/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/IBM/carbon-components/statuses/e3f60ef63af90f6cc4c6f6ecef4525d675167405"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"asudoh"}}