{"action":"created","issue":{"url":"https://api.github.com/repos/coveo/sfdx-js/issues/30","repository_url":"https://api.github.com/repos/coveo/sfdx-js","labels_url":"https://api.github.com/repos/coveo/sfdx-js/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/coveo/sfdx-js/issues/30/comments","events_url":"https://api.github.com/repos/coveo/sfdx-js/issues/30/events","html_url":"https://github.com/coveo/sfdx-js/pull/30","id":371170525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjc3MjY1","number":30,"title":"feat(errorhandling): don't fail if there's only warnings","user":{"login":"louis-bompart","id":12366410,"node_id":"MDQ6VXNlcjEyMzY2NDEw","avatar_url":"https://avatars2.githubusercontent.com/u/12366410?v=4","gravatar_id":"","url":"https://api.github.com/users/louis-bompart","html_url":"https://github.com/louis-bompart","followers_url":"https://api.github.com/users/louis-bompart/followers","following_url":"https://api.github.com/users/louis-bompart/following{/other_user}","gists_url":"https://api.github.com/users/louis-bompart/gists{/gist_id}","starred_url":"https://api.github.com/users/louis-bompart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louis-bompart/subscriptions","organizations_url":"https://api.github.com/users/louis-bompart/orgs","repos_url":"https://api.github.com/users/louis-bompart/repos","events_url":"https://api.github.com/users/louis-bompart/events{/privacy}","received_events_url":"https://api.github.com/users/louis-bompart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"benjamin-ross","id":9884900,"node_id":"MDQ6VXNlcjk4ODQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/9884900?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-ross","html_url":"https://github.com/benjamin-ross","followers_url":"https://api.github.com/users/benjamin-ross/followers","following_url":"https://api.github.com/users/benjamin-ross/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-ross/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-ross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-ross/subscriptions","organizations_url":"https://api.github.com/users/benjamin-ross/orgs","repos_url":"https://api.github.com/users/benjamin-ross/repos","events_url":"https://api.github.com/users/benjamin-ross/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-ross/received_events","type":"User","site_admin":false},"assignees":[{"login":"benjamin-ross","id":9884900,"node_id":"MDQ6VXNlcjk4ODQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/9884900?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-ross","html_url":"https://github.com/benjamin-ross","followers_url":"https://api.github.com/users/benjamin-ross/followers","following_url":"https://api.github.com/users/benjamin-ross/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-ross/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-ross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-ross/subscriptions","organizations_url":"https://api.github.com/users/benjamin-ross/orgs","repos_url":"https://api.github.com/users/benjamin-ross/repos","events_url":"https://api.github.com/users/benjamin-ross/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-ross/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-17T16:47:57Z","updated_at":"2018-10-17T17:09:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/coveo/sfdx-js/pulls/30","html_url":"https://github.com/coveo/sfdx-js/pull/30","diff_url":"https://github.com/coveo/sfdx-js/pull/30.diff","patch_url":"https://github.com/coveo/sfdx-js/pull/30.patch"},"body":"### What is the issue?\r\nBecause now SFDX will _throw_ a warning about data collection on its first run, making the first command executed by a CLI or a user consistently fail.\r\nBut also, generally, I don't think we should fail if there's only warnings.\r\n\r\n### What's the proposed fix?\r\nBefore rejecting the execution and sending an error, I proposed that we check in this order:\r\n1. If there's no error object;\r\n2. If the error stream, once parsed (we're always using `--json` so the output is always a JSON), contains only one key;\r\n3. That this key is `warning`.\r\n\r\nIf all these conditions are satisfied, then we do not throw an error, but still, warn the user that there were some warnings."},"comment":{"url":"https://api.github.com/repos/coveo/sfdx-js/issues/comments/430710983","html_url":"https://github.com/coveo/sfdx-js/pull/30#issuecomment-430710983","issue_url":"https://api.github.com/repos/coveo/sfdx-js/issues/30","id":430710983,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDcxMDk4Mw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T17:09:35Z","updated_at":"2018-10-17T17:09:35Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 166](https://coveralls.io/builds/19575129)\n\n* **0** of **3**   **(0.0%)**  changed or added relevant lines in **1** file are covered.\n* **1** unchanged line in **1** file lost coverage.\n* Overall coverage decreased (**-0.8%**) to **64.212%**\n\n---\n\n|  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |\n| :-----|--------------|--------|---: |\n| [src/core/commandRunner.ts](https://coveralls.io/builds/19575129/source?filename=src%2Fcore%2FcommandRunner.ts#L56) | 0 | 3 | 0.0%\n<!-- | **Total:** | **0** | **3** | **0.0%** | -->\n\n|  Files with Coverage Reduction | New Missed Lines | % |\n| :-----|--------------|--: |\n| [src/core/commandRunner.ts](https://coveralls.io/builds/19575129/source?filename=src%2Fcore%2FcommandRunner.ts#L67) | 1 | 73.77% |\n<!-- | **Total:** | **1** |  | -->\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/19575129/badge)](https://coveralls.io/builds/19575129) |\n| :-- | --: |\n| Change from base [Build 162](https://coveralls.io/builds/19534601): |  -0.8% |\n| Covered Lines: | 384 |\n| Relevant Lines: | 604 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}