{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/4797","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/4797/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4797/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/4797/events","html_url":"https://github.com/ethereum/solidity/pull/4797","id":349465976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTczODU1","number":4797,"title":"Fixes #4718: High CPU usage when using large variable names","user":{"login":"bakaoh","id":4920000,"node_id":"MDQ6VXNlcjQ5MjAwMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4920000?v=4","gravatar_id":"","url":"https://api.github.com/users/bakaoh","html_url":"https://github.com/bakaoh","followers_url":"https://api.github.com/users/bakaoh/followers","following_url":"https://api.github.com/users/bakaoh/following{/other_user}","gists_url":"https://api.github.com/users/bakaoh/gists{/gist_id}","starred_url":"https://api.github.com/users/bakaoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakaoh/subscriptions","organizations_url":"https://api.github.com/users/bakaoh/orgs","repos_url":"https://api.github.com/users/bakaoh/repos","events_url":"https://api.github.com/users/bakaoh/events{/privacy}","received_events_url":"https://api.github.com/users/bakaoh/received_events","type":"User","site_admin":false},"labels":[{"id":1018397771,"node_id":"MDU6TGFiZWwxMDE4Mzk3Nzcx","url":"https://api.github.com/repos/ethereum/solidity/labels/external%20contribution%20:star:","name":"external contribution :star:","color":"270870","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-10T10:41:10Z","updated_at":"2018-08-15T01:48:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4797","html_url":"https://github.com/ethereum/solidity/pull/4797","diff_url":"https://github.com/ethereum/solidity/pull/4797.diff","patch_url":"https://github.com/ethereum/solidity/pull/4797.patch"},"body":"Only report similar strings if their length is short. \r\n\r\n### Checklist\r\n- [x] Code compiles correctly\r\n- [x] All tests are passing\r\n- [x] Used meaningful commit messages\r\n\r\n### Description\r\nModify `stringWithinDistance` as @chriseth proposed https://github.com/ethereum/solidity/issues/4718#issuecomment-411022203 may make `StringUtils`  malfunction if it used at other contexts in the future. So i changed inside `DeclarationContainer::similarNames` which is the only place that used `stringWithinDistance` so far. \r\n\r\nFixes #4718."},"comment":{"url":"https://api.github.com/repos/ethereum/solidity/issues/comments/413069607","html_url":"https://github.com/ethereum/solidity/pull/4797#issuecomment-413069607","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4797","id":413069607,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzA2OTYwNw==","user":{"login":"bakaoh","id":4920000,"node_id":"MDQ6VXNlcjQ5MjAwMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4920000?v=4","gravatar_id":"","url":"https://api.github.com/users/bakaoh","html_url":"https://github.com/bakaoh","followers_url":"https://api.github.com/users/bakaoh/followers","following_url":"https://api.github.com/users/bakaoh/following{/other_user}","gists_url":"https://api.github.com/users/bakaoh/gists{/gist_id}","starred_url":"https://api.github.com/users/bakaoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakaoh/subscriptions","organizations_url":"https://api.github.com/users/bakaoh/orgs","repos_url":"https://api.github.com/users/bakaoh/repos","events_url":"https://api.github.com/users/bakaoh/events{/privacy}","received_events_url":"https://api.github.com/users/bakaoh/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T01:48:57Z","updated_at":"2018-08-15T01:48:57Z","author_association":"NONE","body":"@chriseth -- i've changed as your request"}}
{"actor":{"display_login":"bakaoh"}}