{"action":"closed","number":10921,"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921","id":195863983,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODYzOTgz","html_url":"https://github.com/syl20bnr/spacemacs/pull/10921","diff_url":"https://github.com/syl20bnr/spacemacs/pull/10921.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/10921.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10921","number":10921,"state":"closed","locked":false,"title":"diff-mode: define key bindings with leader key for vim editing style","user":{"login":"miyabinomuratic","id":305916,"node_id":"MDQ6VXNlcjMwNTkxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/305916?v=4","gravatar_id":"","url":"https://api.github.com/users/miyabinomuratic","html_url":"https://github.com/miyabinomuratic","followers_url":"https://api.github.com/users/miyabinomuratic/followers","following_url":"https://api.github.com/users/miyabinomuratic/following{/other_user}","gists_url":"https://api.github.com/users/miyabinomuratic/gists{/gist_id}","starred_url":"https://api.github.com/users/miyabinomuratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyabinomuratic/subscriptions","organizations_url":"https://api.github.com/users/miyabinomuratic/orgs","repos_url":"https://api.github.com/users/miyabinomuratic/repos","events_url":"https://api.github.com/users/miyabinomuratic/events{/privacy}","received_events_url":"https://api.github.com/users/miyabinomuratic/received_events","type":"User","site_admin":false},"body":"This patch defines key bindings with leader key instead of evilified state to\r\nmake it easier for people those who edit in vim style to use diff-mode for both\r\nof editing and reviewing files/buffers.\r\n\r\nThere are two use cases for diff-mode:\r\n\r\n(1) to manually edit diff in a patch file\r\n(2) to review diff that is generated by `vc-diff' or similar commands\r\n\r\nThe evilified state is useful for the case (2), but is confusing for the\r\ncase (1). Usually, users of vim editing style expect that they are in normal\r\nstate when a new buffer is created. However, when evilified state is used for\r\nthe case (1), some keys insert their character in a buffer, which let the users\r\nthink they are in insert state and keep hitting keys to edit the buffer, while\r\nother keys invoke commands or change contents of buffer, which let them think\r\nthey are in normal state, so finally the user get lost what state they are in if\r\nthey don't know evilified state is used for diff-mode.\r\n\r\nThe changeset 58d521af5 \"Unbreak diff-mode\", originally written on Apr 2 2017,\r\ntried to avoid the confusion by removing the evilified state configuration.\r\nHowever, it is overwritten by the other and older changeset 8009e1bf5 \"evilify\r\nvc-* buffers\", which is written on Feb 22 2016, for some reason.\r\n\r\nThis patch respects both of the use cases listed above, thus defines key\r\nbindings with leader key instead of just removing the evilified state\r\nconfiguration.","created_at":"2018-06-19T15:16:29Z","updated_at":"2018-06-24T06:55:53Z","closed_at":"2018-06-24T06:55:53Z","merged_at":null,"merge_commit_sha":"d1603509cf116c755a09063100526b401ceed844","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10921/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/96006bbd3f881113964bab3c586d95ff13e65f5c","head":{"label":"miyabinomuratic:develop","ref":"develop","sha":"96006bbd3f881113964bab3c586d95ff13e65f5c","user":{"login":"miyabinomuratic","id":305916,"node_id":"MDQ6VXNlcjMwNTkxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/305916?v=4","gravatar_id":"","url":"https://api.github.com/users/miyabinomuratic","html_url":"https://github.com/miyabinomuratic","followers_url":"https://api.github.com/users/miyabinomuratic/followers","following_url":"https://api.github.com/users/miyabinomuratic/following{/other_user}","gists_url":"https://api.github.com/users/miyabinomuratic/gists{/gist_id}","starred_url":"https://api.github.com/users/miyabinomuratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyabinomuratic/subscriptions","organizations_url":"https://api.github.com/users/miyabinomuratic/orgs","repos_url":"https://api.github.com/users/miyabinomuratic/repos","events_url":"https://api.github.com/users/miyabinomuratic/events{/privacy}","received_events_url":"https://api.github.com/users/miyabinomuratic/received_events","type":"User","site_admin":false},"repo":{"id":129050939,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwNTA5Mzk=","name":"spacemacs","full_name":"miyabinomuratic/spacemacs","owner":{"login":"miyabinomuratic","id":305916,"node_id":"MDQ6VXNlcjMwNTkxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/305916?v=4","gravatar_id":"","url":"https://api.github.com/users/miyabinomuratic","html_url":"https://github.com/miyabinomuratic","followers_url":"https://api.github.com/users/miyabinomuratic/followers","following_url":"https://api.github.com/users/miyabinomuratic/following{/other_user}","gists_url":"https://api.github.com/users/miyabinomuratic/gists{/gist_id}","starred_url":"https://api.github.com/users/miyabinomuratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyabinomuratic/subscriptions","organizations_url":"https://api.github.com/users/miyabinomuratic/orgs","repos_url":"https://api.github.com/users/miyabinomuratic/repos","events_url":"https://api.github.com/users/miyabinomuratic/events{/privacy}","received_events_url":"https://api.github.com/users/miyabinomuratic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miyabinomuratic/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/miyabinomuratic/spacemacs","forks_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/forks","keys_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/teams","hooks_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/events","assignees_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/tags","blobs_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/languages","stargazers_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/subscription","commits_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/merges","archive_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/downloads","issues_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/miyabinomuratic/spacemacs/deployments","created_at":"2018-04-11T07:13:51Z","updated_at":"2018-04-11T07:13:57Z","pushed_at":"2018-06-19T15:14:23Z","git_url":"git://github.com/miyabinomuratic/spacemacs.git","ssh_url":"git@github.com:miyabinomuratic/spacemacs.git","clone_url":"https://github.com/miyabinomuratic/spacemacs.git","svn_url":"https://github.com/miyabinomuratic/spacemacs","homepage":"http://spacemacs.org","size":39875,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"f1f8db002af108f58c9a78c5286e8beca59af6de","user":{"login":"syl20bnr","id":1243537,"node_id":"MDQ6VXNlcjEyNDM1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1243537?v=4","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"node_id":"MDEwOlJlcG9zaXRvcnk3MjEyNjQ1","name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"node_id":"MDQ6VXNlcjEyNDM1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1243537?v=4","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/syl20bnr/spacemacs/deployments","created_at":"2012-12-17T21:34:03Z","updated_at":"2018-06-24T06:43:26Z","pushed_at":"2018-06-24T06:54:14Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"http://spacemacs.org","size":39868,"stargazers_count":15259,"watchers_count":15259,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3855,"mirror_url":null,"archived":false,"open_issues_count":2039,"license":null,"forks":3855,"open_issues":2039,"watchers":15259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/10921"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10921"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10921/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10921/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/96006bbd3f881113964bab3c586d95ff13e65f5c"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":59,"deletions":30,"changed_files":2}}
{"actor":{"display_login":"syl20bnr"}}