{"action":"created","issue":{"url":"https://api.github.com/repos/lostromb/concentus/issues/20","repository_url":"https://api.github.com/repos/lostromb/concentus","labels_url":"https://api.github.com/repos/lostromb/concentus/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/lostromb/concentus/issues/20/comments","events_url":"https://api.github.com/repos/lostromb/concentus/issues/20/events","html_url":"https://github.com/lostromb/concentus/issues/20","id":283591351,"node_id":"MDU6SXNzdWUyODM1OTEzNTE=","number":20,"title":"Consider strong name signing Nuget packages","user":{"login":"steveellis","id":104455,"node_id":"MDQ6VXNlcjEwNDQ1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/104455?v=4","gravatar_id":"","url":"https://api.github.com/users/steveellis","html_url":"https://github.com/steveellis","followers_url":"https://api.github.com/users/steveellis/followers","following_url":"https://api.github.com/users/steveellis/following{/other_user}","gists_url":"https://api.github.com/users/steveellis/gists{/gist_id}","starred_url":"https://api.github.com/users/steveellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveellis/subscriptions","organizations_url":"https://api.github.com/users/steveellis/orgs","repos_url":"https://api.github.com/users/steveellis/repos","events_url":"https://api.github.com/users/steveellis/events{/privacy}","received_events_url":"https://api.github.com/users/steveellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-20T15:02:11Z","updated_at":"2018-12-26T19:02:28Z","closed_at":null,"author_association":"NONE","body":"Right now the Concentus.dll and Concentus.Oggfile.dll need to be signed together if you're using them in a deployment that is signed. Otherwise you get an error like:\r\n\r\n> Could not load file or assembly 'Concentus, Version=1.1.6.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044) \r\n\r\nIt's compounded by the fact that if you're using Concentus.dll and Concecntus.Oggfile.dll together, you have to sign them together to make the dependency work.\r\n\r\nHappy to update the ticket with more info about how I signed them in my deployment or provide links to strong name signing assemblies if that will help.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/lostromb/concentus/issues/comments/450009852","html_url":"https://github.com/lostromb/concentus/issues/20#issuecomment-450009852","issue_url":"https://api.github.com/repos/lostromb/concentus/issues/20","id":450009852,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDAwOTg1Mg==","user":{"login":"steveellis","id":104455,"node_id":"MDQ6VXNlcjEwNDQ1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/104455?v=4","gravatar_id":"","url":"https://api.github.com/users/steveellis","html_url":"https://github.com/steveellis","followers_url":"https://api.github.com/users/steveellis/followers","following_url":"https://api.github.com/users/steveellis/following{/other_user}","gists_url":"https://api.github.com/users/steveellis/gists{/gist_id}","starred_url":"https://api.github.com/users/steveellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveellis/subscriptions","organizations_url":"https://api.github.com/users/steveellis/orgs","repos_url":"https://api.github.com/users/steveellis/repos","events_url":"https://api.github.com/users/steveellis/events{/privacy}","received_events_url":"https://api.github.com/users/steveellis/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T19:02:28Z","updated_at":"2018-12-26T19:02:28Z","author_association":"NONE","body":"For other people encountering this, I've been able to sign the files and overcome the error mentioned above by signing the assemblies with this project:\r\n\r\nhttps://github.com/brutaldev/StrongNameSigner\r\n\r\nI have to include the signed versions in my project directly without nuget.\r\n\r\nI think it may be limited to using Concentus in a Windows EV signed project, which is how I'm deploying to windows clients. I've now deployed Concentus in Android, iOS and macOS, each of which is signed in their own special ways of course, without any problems."}}
{"actor":{"display_login":"steveellis"}}