{"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-browser/issues/1679","repository_url":"https://api.github.com/repos/brave/brave-browser","labels_url":"https://api.github.com/repos/brave/brave-browser/issues/1679/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-browser/issues/1679/comments","events_url":"https://api.github.com/repos/brave/brave-browser/issues/1679/events","html_url":"https://github.com/brave/brave-browser/issues/1679","id":371293676,"node_id":"MDU6SXNzdWUzNzEyOTM2NzY=","number":1679,"title":"Refactor: Make rewards notification service an observer","user":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"labels":[{"id":1027420792,"node_id":"MDU6TGFiZWwxMDI3NDIwNzky","url":"https://api.github.com/repos/brave/brave-browser/labels/QA/Yes","name":"QA/Yes","color":"35c914","default":false},{"id":965302091,"node_id":"MDU6TGFiZWw5NjUzMDIwOTE=","url":"https://api.github.com/repos/brave/brave-browser/labels/priority/P5","name":"priority/P5","color":"c2e0c6","default":false},{"id":1012820859,"node_id":"MDU6TGFiZWwxMDEyODIwODU5","url":"https://api.github.com/repos/brave/brave-browser/labels/refactoring","name":"refactoring","color":"b1e4ed","default":false},{"id":1027433536,"node_id":"MDU6TGFiZWwxMDI3NDMzNTM2","url":"https://api.github.com/repos/brave/brave-browser/labels/release-notes/exclude","name":"release-notes/exclude","color":"eeeeee","default":false}],"state":"closed","locked":false,"assignee":{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false},"assignees":[{"login":"emerick","id":5033691,"node_id":"MDQ6VXNlcjUwMzM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5033691?v=4","gravatar_id":"","url":"https://api.github.com/users/emerick","html_url":"https://github.com/emerick","followers_url":"https://api.github.com/users/emerick/followers","following_url":"https://api.github.com/users/emerick/following{/other_user}","gists_url":"https://api.github.com/users/emerick/gists{/gist_id}","starred_url":"https://api.github.com/users/emerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerick/subscriptions","organizations_url":"https://api.github.com/users/emerick/orgs","repos_url":"https://api.github.com/users/emerick/repos","events_url":"https://api.github.com/users/emerick/events{/privacy}","received_events_url":"https://api.github.com/users/emerick/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/brave-browser/milestones/11","html_url":"https://github.com/brave/brave-browser/milestone/11","labels_url":"https://api.github.com/repos/brave/brave-browser/milestones/11/labels","id":3743507,"node_id":"MDk6TWlsZXN0b25lMzc0MzUwNw==","number":11,"title":"0.58.x - Beta","description":"","creator":{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":74,"state":"open","created_at":"2018-10-16T14:59:13Z","updated_at":"2018-12-12T03:23:36Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-10-17T22:38:05Z","updated_at":"2018-12-12T05:21:22Z","closed_at":"2018-10-31T07:33:39Z","author_association":"CONTRIBUTOR","body":"@bridiver mentioned the following in regards to the `RewardsNotificationsService`:\r\n\r\n> [...] this really doesn't make sense as separate keyed service. I think this should be a RewardsServiceObserver that is owned by RewardsService and be access through RewardsServiceFactory::GetInstance()->GetForProfile(profile)->notification_service();\r\n\r\nSounds like a good plan and shouldn't be too hard to implement."},"comment":{"url":"https://api.github.com/repos/brave/brave-browser/issues/comments/446465768","html_url":"https://github.com/brave/brave-browser/issues/1679#issuecomment-446465768","issue_url":"https://api.github.com/repos/brave/brave-browser/issues/1679","id":446465768,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ2NTc2OA==","user":{"login":"kjozwiak","id":2602313,"node_id":"MDQ6VXNlcjI2MDIzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2602313?v=4","gravatar_id":"","url":"https://api.github.com/users/kjozwiak","html_url":"https://github.com/kjozwiak","followers_url":"https://api.github.com/users/kjozwiak/followers","following_url":"https://api.github.com/users/kjozwiak/following{/other_user}","gists_url":"https://api.github.com/users/kjozwiak/gists{/gist_id}","starred_url":"https://api.github.com/users/kjozwiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjozwiak/subscriptions","organizations_url":"https://api.github.com/users/kjozwiak/orgs","repos_url":"https://api.github.com/users/kjozwiak/repos","events_url":"https://api.github.com/users/kjozwiak/events{/privacy}","received_events_url":"https://api.github.com/users/kjozwiak/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T05:21:22Z","updated_at":"2018-12-12T05:21:22Z","author_association":"MEMBER","body":"@emerick is there a test case that QA can go through to verify this particular issue? This was labelled as `QA/Yes` but there's nothing QA can use either in the original comment or https://github.com/brave/brave-core/pull/739 in terms of STR/test cases."}}
{"actor":{"display_login":"kjozwiak"}}