{"action":"created","issue":{"url":"https://api.github.com/repos/bedita/bedita/issues/1435","repository_url":"https://api.github.com/repos/bedita/bedita","labels_url":"https://api.github.com/repos/bedita/bedita/issues/1435/labels{/name}","comments_url":"https://api.github.com/repos/bedita/bedita/issues/1435/comments","events_url":"https://api.github.com/repos/bedita/bedita/issues/1435/events","html_url":"https://github.com/bedita/bedita/pull/1435","id":307577837,"number":1435,"title":"Login authorization","user":{"login":"stefanorosanelli","id":2122280,"avatar_url":"https://avatars3.githubusercontent.com/u/2122280?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanorosanelli","html_url":"https://github.com/stefanorosanelli","followers_url":"https://api.github.com/users/stefanorosanelli/followers","following_url":"https://api.github.com/users/stefanorosanelli/following{/other_user}","gists_url":"https://api.github.com/users/stefanorosanelli/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanorosanelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanorosanelli/subscriptions","organizations_url":"https://api.github.com/users/stefanorosanelli/orgs","repos_url":"https://api.github.com/users/stefanorosanelli/repos","events_url":"https://api.github.com/users/stefanorosanelli/events{/privacy}","received_events_url":"https://api.github.com/users/stefanorosanelli/received_events","type":"User","site_admin":false},"labels":[{"id":13233320,"url":"https://api.github.com/repos/bedita/bedita/labels/Priority%20-%20High","name":"Priority - High","color":"ffee00","default":false},{"id":177585362,"url":"https://api.github.com/repos/bedita/bedita/labels/Topic%20-%20Security","name":"Topic - Security","color":"DDDDDD","default":false},{"id":13233296,"url":"https://api.github.com/repos/bedita/bedita/labels/Type%20-%20Bug","name":"Type - Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"batopa","id":1306319,"avatar_url":"https://avatars2.githubusercontent.com/u/1306319?v=4","gravatar_id":"","url":"https://api.github.com/users/batopa","html_url":"https://github.com/batopa","followers_url":"https://api.github.com/users/batopa/followers","following_url":"https://api.github.com/users/batopa/following{/other_user}","gists_url":"https://api.github.com/users/batopa/gists{/gist_id}","starred_url":"https://api.github.com/users/batopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batopa/subscriptions","organizations_url":"https://api.github.com/users/batopa/orgs","repos_url":"https://api.github.com/users/batopa/repos","events_url":"https://api.github.com/users/batopa/events{/privacy}","received_events_url":"https://api.github.com/users/batopa/received_events","type":"User","site_admin":false},"assignees":[{"login":"batopa","id":1306319,"avatar_url":"https://avatars2.githubusercontent.com/u/1306319?v=4","gravatar_id":"","url":"https://api.github.com/users/batopa","html_url":"https://github.com/batopa","followers_url":"https://api.github.com/users/batopa/followers","following_url":"https://api.github.com/users/batopa/following{/other_user}","gists_url":"https://api.github.com/users/batopa/gists{/gist_id}","starred_url":"https://api.github.com/users/batopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batopa/subscriptions","organizations_url":"https://api.github.com/users/batopa/orgs","repos_url":"https://api.github.com/users/batopa/repos","events_url":"https://api.github.com/users/batopa/events{/privacy}","received_events_url":"https://api.github.com/users/batopa/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/bedita/bedita/milestones/18","html_url":"https://github.com/bedita/bedita/milestone/18","labels_url":"https://api.github.com/repos/bedita/bedita/milestones/18/labels","id":3077220,"number":18,"title":"4.0.0-beta2","description":"","creator":{"login":"stefanorosanelli","id":2122280,"avatar_url":"https://avatars3.githubusercontent.com/u/2122280?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanorosanelli","html_url":"https://github.com/stefanorosanelli","followers_url":"https://api.github.com/users/stefanorosanelli/followers","following_url":"https://api.github.com/users/stefanorosanelli/following{/other_user}","gists_url":"https://api.github.com/users/stefanorosanelli/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanorosanelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanorosanelli/subscriptions","organizations_url":"https://api.github.com/users/stefanorosanelli/orgs","repos_url":"https://api.github.com/users/stefanorosanelli/repos","events_url":"https://api.github.com/users/stefanorosanelli/events{/privacy}","received_events_url":"https://api.github.com/users/stefanorosanelli/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":21,"state":"open","created_at":"2018-01-31T09:06:00Z","updated_at":"2018-03-22T10:09:34Z","due_on":"2018-03-30T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-03-22T10:09:34Z","updated_at":"2018-03-22T10:41:49Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/bedita/bedita/pulls/1435","html_url":"https://github.com/bedita/bedita/pull/1435","diff_url":"https://github.com/bedita/bedita/pull/1435.diff","patch_url":"https://github.com/bedita/bedita/pull/1435.patch"},"body":"This PR adds proper authorization check on `POST /auth` aka `login`operations.\r\n\r\nUpon `login` no authorization check is done via `AuthComponent` beacause user identification is done directly in LoginController and not via `Authorization` header.\r\nWe need to check authorization after identification.\r\n"},"comment":{"url":"https://api.github.com/repos/bedita/bedita/issues/comments/375258862","html_url":"https://github.com/bedita/bedita/pull/1435#issuecomment-375258862","issue_url":"https://api.github.com/repos/bedita/bedita/issues/1435","id":375258862,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T10:41:49Z","updated_at":"2018-03-22T10:41:49Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=h1) Report\n> Merging [#1435](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=desc) into [4-cactus](https://codecov.io/gh/bedita/bedita/commit/bf262c4df7ffd5a4c9ac6f551a18e97463b88813?src=pr&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/bedita/bedita/pull/1435/graphs/tree.svg?height=150&width=650&token=VEDC84dhzX&src=pr)](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=tree)\n\n```diff\n@@              Coverage Diff               @@\n##             4-cactus    #1435      +/-   ##\n==============================================\n+ Coverage       98.18%   98.25%   +0.07%     \n+ Complexity       1847     1810      -37     \n==============================================\n  Files             139      135       -4     \n  Lines            5281     5167     -114     \n==============================================\n- Hits             5185     5077     -108     \n+ Misses             96       90       -6\n```\n\n\n| [Impacted Files](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...gins/BEdita/API/src/Controller/LoginController.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQVBJL3NyYy9Db250cm9sbGVyL0xvZ2luQ29udHJvbGxlci5waHA=) | `100% <100%> (ø)` | `16 <0> (+1)` | :arrow_up: |\n| [...gins/BEdita/Core/src/Model/Entity/ObjectEntity.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvRW50aXR5L09iamVjdEVudGl0eS5waHA=) | `100% <0%> (ø)` | `24% <0%> (ø)` | :arrow_down: |\n| [...ugins/BEdita/Core/src/Model/Table/ObjectsTable.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvVGFibGUvT2JqZWN0c1RhYmxlLnBocA==) | `100% <0%> (ø)` | `22% <0%> (ø)` | :arrow_down: |\n| [...gins/BEdita/Core/src/ORM/Association/RelatedTo.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvT1JNL0Fzc29jaWF0aW9uL1JlbGF0ZWRUby5waHA=) | `100% <0%> (ø)` | `3% <0%> (-4%)` | :arrow_down: |\n| [...Core/src/ORM/Inheritance/AssociationCollection.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvT1JNL0luaGVyaXRhbmNlL0Fzc29jaWF0aW9uQ29sbGVjdGlvbi5waHA=) | `100% <0%> (ø)` | `16% <0%> (-6%)` | :arrow_down: |\n| [...s/BEdita/API/src/TestSuite/IntegrationTestCase.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQVBJL3NyYy9UZXN0U3VpdGUvSW50ZWdyYXRpb25UZXN0Q2FzZS5waHA=) | `100% <0%> (ø)` | `12% <0%> (ø)` | :arrow_down: |\n| [plugins/BEdita/Core/src/Model/Entity/Folder.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvRW50aXR5L0ZvbGRlci5waHA=) | | | |\n| [plugins/BEdita/Core/src/Model/Table/TreesTable.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvVGFibGUvVHJlZXNUYWJsZS5waHA=) | | | |\n| [...ugins/BEdita/Core/src/Model/Table/FoldersTable.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvVGFibGUvRm9sZGVyc1RhYmxlLnBocA==) | | | |\n| [plugins/BEdita/Core/src/Model/Entity/Tree.php](https://codecov.io/gh/bedita/bedita/pull/1435/diff?src=pr&el=tree#diff-cGx1Z2lucy9CRWRpdGEvQ29yZS9zcmMvTW9kZWwvRW50aXR5L1RyZWUucGhw) | | | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=footer). Last update [bf262c4...52bbebb](https://codecov.io/gh/bedita/bedita/pull/1435?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}