{"action":"created","issue":{"url":"https://api.github.com/repos/wp-media/wp-rocket/issues/906","repository_url":"https://api.github.com/repos/wp-media/wp-rocket","labels_url":"https://api.github.com/repos/wp-media/wp-rocket/issues/906/labels{/name}","comments_url":"https://api.github.com/repos/wp-media/wp-rocket/issues/906/comments","events_url":"https://api.github.com/repos/wp-media/wp-rocket/issues/906/events","html_url":"https://github.com/wp-media/wp-rocket/issues/906","id":308034677,"number":906,"title":"Untranslatable on/off sliding checkbox","user":{"login":"Tabrisrp","id":3465180,"avatar_url":"https://avatars3.githubusercontent.com/u/3465180?v=4","gravatar_id":"","url":"https://api.github.com/users/Tabrisrp","html_url":"https://github.com/Tabrisrp","followers_url":"https://api.github.com/users/Tabrisrp/followers","following_url":"https://api.github.com/users/Tabrisrp/following{/other_user}","gists_url":"https://api.github.com/users/Tabrisrp/gists{/gist_id}","starred_url":"https://api.github.com/users/Tabrisrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tabrisrp/subscriptions","organizations_url":"https://api.github.com/users/Tabrisrp/orgs","repos_url":"https://api.github.com/users/Tabrisrp/repos","events_url":"https://api.github.com/users/Tabrisrp/events{/privacy}","received_events_url":"https://api.github.com/users/Tabrisrp/received_events","type":"User","site_admin":false},"labels":[{"id":866770461,"url":"https://api.github.com/repos/wp-media/wp-rocket/labels/design","name":"design","color":"ef1569","default":false},{"id":634523064,"url":"https://api.github.com/repos/wp-media/wp-rocket/labels/i18n","name":"i18n","color":"c2e0c6","default":false},{"id":403842882,"url":"https://api.github.com/repos/wp-media/wp-rocket/labels/minor","name":"minor","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"glueckpress","id":308422,"avatar_url":"https://avatars1.githubusercontent.com/u/308422?v=4","gravatar_id":"","url":"https://api.github.com/users/glueckpress","html_url":"https://github.com/glueckpress","followers_url":"https://api.github.com/users/glueckpress/followers","following_url":"https://api.github.com/users/glueckpress/following{/other_user}","gists_url":"https://api.github.com/users/glueckpress/gists{/gist_id}","starred_url":"https://api.github.com/users/glueckpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glueckpress/subscriptions","organizations_url":"https://api.github.com/users/glueckpress/orgs","repos_url":"https://api.github.com/users/glueckpress/repos","events_url":"https://api.github.com/users/glueckpress/events{/privacy}","received_events_url":"https://api.github.com/users/glueckpress/received_events","type":"User","site_admin":false},"assignees":[{"login":"glueckpress","id":308422,"avatar_url":"https://avatars1.githubusercontent.com/u/308422?v=4","gravatar_id":"","url":"https://api.github.com/users/glueckpress","html_url":"https://github.com/glueckpress","followers_url":"https://api.github.com/users/glueckpress/followers","following_url":"https://api.github.com/users/glueckpress/following{/other_user}","gists_url":"https://api.github.com/users/glueckpress/gists{/gist_id}","starred_url":"https://api.github.com/users/glueckpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glueckpress/subscriptions","organizations_url":"https://api.github.com/users/glueckpress/orgs","repos_url":"https://api.github.com/users/glueckpress/repos","events_url":"https://api.github.com/users/glueckpress/events{/privacy}","received_events_url":"https://api.github.com/users/glueckpress/received_events","type":"User","site_admin":false},{"login":"edenpulse","id":433393,"avatar_url":"https://avatars2.githubusercontent.com/u/433393?v=4","gravatar_id":"","url":"https://api.github.com/users/edenpulse","html_url":"https://github.com/edenpulse","followers_url":"https://api.github.com/users/edenpulse/followers","following_url":"https://api.github.com/users/edenpulse/following{/other_user}","gists_url":"https://api.github.com/users/edenpulse/gists{/gist_id}","starred_url":"https://api.github.com/users/edenpulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenpulse/subscriptions","organizations_url":"https://api.github.com/users/edenpulse/orgs","repos_url":"https://api.github.com/users/edenpulse/repos","events_url":"https://api.github.com/users/edenpulse/events{/privacy}","received_events_url":"https://api.github.com/users/edenpulse/received_events","type":"User","site_admin":false},{"login":"GeekPress","id":1285409,"avatar_url":"https://avatars0.githubusercontent.com/u/1285409?v=4","gravatar_id":"","url":"https://api.github.com/users/GeekPress","html_url":"https://github.com/GeekPress","followers_url":"https://api.github.com/users/GeekPress/followers","following_url":"https://api.github.com/users/GeekPress/following{/other_user}","gists_url":"https://api.github.com/users/GeekPress/gists{/gist_id}","starred_url":"https://api.github.com/users/GeekPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeekPress/subscriptions","organizations_url":"https://api.github.com/users/GeekPress/orgs","repos_url":"https://api.github.com/users/GeekPress/repos","events_url":"https://api.github.com/users/GeekPress/events{/privacy}","received_events_url":"https://api.github.com/users/GeekPress/received_events","type":"User","site_admin":false},{"login":"Thomasgeisen","id":3072820,"avatar_url":"https://avatars2.githubusercontent.com/u/3072820?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomasgeisen","html_url":"https://github.com/Thomasgeisen","followers_url":"https://api.github.com/users/Thomasgeisen/followers","following_url":"https://api.github.com/users/Thomasgeisen/following{/other_user}","gists_url":"https://api.github.com/users/Thomasgeisen/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomasgeisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomasgeisen/subscriptions","organizations_url":"https://api.github.com/users/Thomasgeisen/orgs","repos_url":"https://api.github.com/users/Thomasgeisen/repos","events_url":"https://api.github.com/users/Thomasgeisen/events{/privacy}","received_events_url":"https://api.github.com/users/Thomasgeisen/received_events","type":"User","site_admin":false},{"login":"Tabrisrp","id":3465180,"avatar_url":"https://avatars3.githubusercontent.com/u/3465180?v=4","gravatar_id":"","url":"https://api.github.com/users/Tabrisrp","html_url":"https://github.com/Tabrisrp","followers_url":"https://api.github.com/users/Tabrisrp/followers","following_url":"https://api.github.com/users/Tabrisrp/following{/other_user}","gists_url":"https://api.github.com/users/Tabrisrp/gists{/gist_id}","starred_url":"https://api.github.com/users/Tabrisrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tabrisrp/subscriptions","organizations_url":"https://api.github.com/users/Tabrisrp/orgs","repos_url":"https://api.github.com/users/Tabrisrp/repos","events_url":"https://api.github.com/users/Tabrisrp/events{/privacy}","received_events_url":"https://api.github.com/users/Tabrisrp/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wp-media/wp-rocket/milestones/33","html_url":"https://github.com/wp-media/wp-rocket/milestone/33","labels_url":"https://api.github.com/repos/wp-media/wp-rocket/milestones/33/labels","id":3020906,"number":33,"title":"3.0","description":"","creator":{"login":"Tabrisrp","id":3465180,"avatar_url":"https://avatars3.githubusercontent.com/u/3465180?v=4","gravatar_id":"","url":"https://api.github.com/users/Tabrisrp","html_url":"https://github.com/Tabrisrp","followers_url":"https://api.github.com/users/Tabrisrp/followers","following_url":"https://api.github.com/users/Tabrisrp/following{/other_user}","gists_url":"https://api.github.com/users/Tabrisrp/gists{/gist_id}","starred_url":"https://api.github.com/users/Tabrisrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tabrisrp/subscriptions","organizations_url":"https://api.github.com/users/Tabrisrp/orgs","repos_url":"https://api.github.com/users/Tabrisrp/repos","events_url":"https://api.github.com/users/Tabrisrp/events{/privacy}","received_events_url":"https://api.github.com/users/Tabrisrp/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":86,"state":"open","created_at":"2018-01-08T20:02:51Z","updated_at":"2018-03-26T18:53:57Z","due_on":"2018-04-04T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-03-23T13:45:16Z","updated_at":"2018-03-28T10:26:21Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"With the current implementation, the on/off sliding checkboxes can't be translated, as the text is located in css pseudo-elements.\r\n\r\nThe question now is: should they be translatable? This could cause design issues depending on the language used.\r\n\r\nThe other question is: should we have text on those sliding checkboxes? Should we rely on button position and color only to indicate the state of the option?"},"comment":{"url":"https://api.github.com/repos/wp-media/wp-rocket/issues/comments/376838274","html_url":"https://github.com/wp-media/wp-rocket/issues/906#issuecomment-376838274","issue_url":"https://api.github.com/repos/wp-media/wp-rocket/issues/906","id":376838274,"user":{"login":"glueckpress","id":308422,"avatar_url":"https://avatars1.githubusercontent.com/u/308422?v=4","gravatar_id":"","url":"https://api.github.com/users/glueckpress","html_url":"https://github.com/glueckpress","followers_url":"https://api.github.com/users/glueckpress/followers","following_url":"https://api.github.com/users/glueckpress/following{/other_user}","gists_url":"https://api.github.com/users/glueckpress/gists{/gist_id}","starred_url":"https://api.github.com/users/glueckpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glueckpress/subscriptions","organizations_url":"https://api.github.com/users/glueckpress/orgs","repos_url":"https://api.github.com/users/glueckpress/repos","events_url":"https://api.github.com/users/glueckpress/events{/privacy}","received_events_url":"https://api.github.com/users/glueckpress/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T10:26:21Z","updated_at":"2018-03-28T10:26:21Z","author_association":"CONTRIBUTOR","body":"@GeekPress Thanks for clarifying! 🙂 \r\nFully agree that it’s safe to assume that these particular words (_on_ and _off_) will be understood by a large majority even when they’re not translated, as they can be found in all sorts of contexts were English is used as a _lingua fracta_, like your example with cars, or on other device interfaces.\r\n\r\nI believe the issue here was with an underlying principle rather than the concrete words at hand.\r\nWhile _on_ and _off_ might not pose a problem to be understood by most people, they can still disrupt an otherwise well translated user interface. That’s certainly not critical, but also not necessary. Why compromise our promise of excellence for our product for something that trivial?\r\nAlso—and this is the perspective of a translator, of course 😉—the decision whether those words should be translated or not would best be made by translators; they know what works best in their languages.\r\n\r\nFixing this should, of course, not delay a release date. If we hadn’t had a fix at hand, we could have shipped as is and fix it later. However, since there is an easy solution at hand, I’d agree with @Tabrisrp and suggest we ship the fix now."}}
{"actor":{"display_login":"glueckpress"}}