{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments/229642225","pull_request_review_id":170186523,"id":229642225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY0MjIyNQ==","diff_hunk":"@@ -14,7 +14,9 @@ def get_content\n     response = FindContent.call(content_params)\n     ContentItemsPresenter.new(\n       response[:results],\n-      DateRange.new(content_params[:date_range])\n+        DateRange.new(content_params[:date_range]),","path":"app/controllers/content_controller.rb","position":5,"original_position":5,"commit_id":"bb43f77ce646349adcc1e4030669b3cf3198ddb3","original_commit_id":"bb43f77ce646349adcc1e4030669b3cf3198ddb3","user":{"login":"pmanrubia","id":227328,"node_id":"MDQ6VXNlcjIyNzMyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/227328?v=4","gravatar_id":"","url":"https://api.github.com/users/pmanrubia","html_url":"https://github.com/pmanrubia","followers_url":"https://api.github.com/users/pmanrubia/followers","following_url":"https://api.github.com/users/pmanrubia/following{/other_user}","gists_url":"https://api.github.com/users/pmanrubia/gists{/gist_id}","starred_url":"https://api.github.com/users/pmanrubia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmanrubia/subscriptions","organizations_url":"https://api.github.com/users/pmanrubia/orgs","repos_url":"https://api.github.com/users/pmanrubia/repos","events_url":"https://api.github.com/users/pmanrubia/events{/privacy}","received_events_url":"https://api.github.com/users/pmanrubia/received_events","type":"User","site_admin":false},"body":"The indentation seems to be broken here.\r\nWe have increased the number of parameters that the Presenter is receiving. I am wondering about passing only two: `response` and `content_params`? Other can be inferred from these two parameters.","created_at":"2018-10-31T10:41:19Z","updated_at":"2018-10-31T10:42:25Z","html_url":"https://github.com/alphagov/content-data-admin/pull/169#discussion_r229642225","pull_request_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments/229642225"},"html":{"href":"https://github.com/alphagov/content-data-admin/pull/169#discussion_r229642225"},"pull_request":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169","id":226907489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTA3NDg5","html_url":"https://github.com/alphagov/content-data-admin/pull/169","diff_url":"https://github.com/alphagov/content-data-admin/pull/169.diff","patch_url":"https://github.com/alphagov/content-data-admin/pull/169.patch","issue_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/169","number":169,"state":"open","locked":false,"title":"Pagination","user":{"login":"peteglondon","id":511319,"node_id":"MDQ6VXNlcjUxMTMxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/511319?v=4","gravatar_id":"","url":"https://api.github.com/users/peteglondon","html_url":"https://github.com/peteglondon","followers_url":"https://api.github.com/users/peteglondon/followers","following_url":"https://api.github.com/users/peteglondon/following{/other_user}","gists_url":"https://api.github.com/users/peteglondon/gists{/gist_id}","starred_url":"https://api.github.com/users/peteglondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peteglondon/subscriptions","organizations_url":"https://api.github.com/users/peteglondon/orgs","repos_url":"https://api.github.com/users/peteglondon/repos","events_url":"https://api.github.com/users/peteglondon/events{/privacy}","received_events_url":"https://api.github.com/users/peteglondon/received_events","type":"User","site_admin":false},"body":"#### What\r\nAdd pagination to the index page\r\n\r\n#### Why\r\nSo the user can view more than the first page.\r\n\r\nThere is a related [PR in content-performance-manager](https://github.com/alphagov/content-performance-manager/pull/974)\r\n\r\n#### Screenshots\r\n\r\n##### Before\r\n<img width=\"1132\" alt=\"screen shot 2018-10-30 at 12 44 53\" src=\"https://user-images.githubusercontent.com/511319/47719010-c1f76100-dc41-11e8-9794-85424f2a0381.png\">\r\n\r\n##### After\r\n\r\n<img width=\"1160\" alt=\"screen shot 2018-10-30 at 12 45 20\" src=\"https://user-images.githubusercontent.com/511319/47719021-c7ed4200-dc41-11e8-8a7b-64b65334f8e2.png\">\r\n","created_at":"2018-10-30T12:47:13Z","updated_at":"2018-10-31T10:42:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3816229386bbef3f24ea02926d4ffc299f7e3b22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169/commits","review_comments_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169/comments","review_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/169/comments","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/bb43f77ce646349adcc1e4030669b3cf3198ddb3","head":{"label":"alphagov:pagination","ref":"pagination","sha":"bb43f77ce646349adcc1e4030669b3cf3198ddb3","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":142429907,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0Mjk5MDc=","name":"content-data-admin","full_name":"alphagov/content-data-admin","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/content-data-admin","description":"A front end for the data warehouse","fork":false,"url":"https://api.github.com/repos/alphagov/content-data-admin","forks_url":"https://api.github.com/repos/alphagov/content-data-admin/forks","keys_url":"https://api.github.com/repos/alphagov/content-data-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-data-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-data-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/content-data-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-data-admin/events","assignees_url":"https://api.github.com/repos/alphagov/content-data-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-data-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-data-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-data-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-data-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-data-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-data-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-data-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-data-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-data-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/content-data-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-data-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-data-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-data-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-data-admin/merges","archive_url":"https://api.github.com/repos/alphagov/content-data-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-data-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/content-data-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-data-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-data-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-data-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-data-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-data-admin/deployments","created_at":"2018-07-26T11:09:09Z","updated_at":"2018-10-30T17:09:55Z","pushed_at":"2018-10-30T17:12:22Z","git_url":"git://github.com/alphagov/content-data-admin.git","ssh_url":"git@github.com:alphagov/content-data-admin.git","clone_url":"https://github.com/alphagov/content-data-admin.git","svn_url":"https://github.com/alphagov/content-data-admin","homepage":"https://docs.publishing.service.gov.uk/apps/content-data-admin.html","size":599,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"6766c000d3de8a58159be63f589754c3f9508192","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":142429907,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0Mjk5MDc=","name":"content-data-admin","full_name":"alphagov/content-data-admin","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/content-data-admin","description":"A front end for the data warehouse","fork":false,"url":"https://api.github.com/repos/alphagov/content-data-admin","forks_url":"https://api.github.com/repos/alphagov/content-data-admin/forks","keys_url":"https://api.github.com/repos/alphagov/content-data-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-data-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-data-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/content-data-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-data-admin/events","assignees_url":"https://api.github.com/repos/alphagov/content-data-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-data-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-data-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-data-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-data-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-data-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-data-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-data-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-data-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-data-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/content-data-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-data-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-data-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-data-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-data-admin/merges","archive_url":"https://api.github.com/repos/alphagov/content-data-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-data-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/content-data-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-data-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-data-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-data-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-data-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-data-admin/deployments","created_at":"2018-07-26T11:09:09Z","updated_at":"2018-10-30T17:09:55Z","pushed_at":"2018-10-30T17:12:22Z","git_url":"git://github.com/alphagov/content-data-admin.git","ssh_url":"git@github.com:alphagov/content-data-admin.git","clone_url":"https://github.com/alphagov/content-data-admin.git","svn_url":"https://github.com/alphagov/content-data-admin","homepage":"https://docs.publishing.service.gov.uk/apps/content-data-admin.html","size":599,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169"},"html":{"href":"https://github.com/alphagov/content-data-admin/pull/169"},"issue":{"href":"https://api.github.com/repos/alphagov/content-data-admin/issues/169"},"comments":{"href":"https://api.github.com/repos/alphagov/content-data-admin/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/content-data-admin/statuses/bb43f77ce646349adcc1e4030669b3cf3198ddb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pmanrubia"}}