{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46736","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46736/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46736/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46736/events","html_url":"https://github.com/NixOS/nixpkgs/pull/46736","id":360629126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODE3MzY0","number":46736,"title":"mpack: Invoke /run/wrappers/bin/sendmail via execvp","user":{"login":"clefru","id":443728,"node_id":"MDQ6VXNlcjQ0MzcyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/443728?v=4","gravatar_id":"","url":"https://api.github.com/users/clefru","html_url":"https://github.com/clefru","followers_url":"https://api.github.com/users/clefru/followers","following_url":"https://api.github.com/users/clefru/following{/other_user}","gists_url":"https://api.github.com/users/clefru/gists{/gist_id}","starred_url":"https://api.github.com/users/clefru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clefru/subscriptions","organizations_url":"https://api.github.com/users/clefru/orgs","repos_url":"https://api.github.com/users/clefru/repos","events_url":"https://api.github.com/users/clefru/events{/privacy}","received_events_url":"https://api.github.com/users/clefru/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-16T11:14:00Z","updated_at":"2018-09-18T08:59:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/46736","html_url":"https://github.com/NixOS/nixpkgs/pull/46736","diff_url":"https://github.com/NixOS/nixpkgs/pull/46736.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/46736.patch"},"body":"Calling /run/current-sw/bin/sendmail fails under postfix because\r\nsetgid bits are not set. Switching the hardcoded path to an invocation\r\nvia execvp should cover both cases, when the sendmail binary is\r\nsetgid-wrapped and when it is not.\r\n\r\n###### Motivation for this change\r\nmpack can't send mails under a postfix installation, as the setgid bits are missing in postdrop.\r\n```\r\n$ strace -etrace=execve -f mpack -s ethereum-cc.pdf tmp.pdf clemens@endorphin.org                                                          execve(\"/home/clemens/.nix-profile/bin/mpack\", [\"mpack\", \"-s\", \"ethereum-cc.pdf\", \"tmp.pdf\", \"clemens@endorphin.org\"], 0x7ffeb53e6220 /* 82 vars */) = 0\r\nstrace: Process 36692 attached\r\n[pid 36692] execve(\"/usr/lib/sendmail\", [\"sendmail\", \"-oi\", \"clemens@endorphin.org\"], 0x7ffe0fc75808 /* 82 vars */) = -1 ENOENT (No such file or directory)\r\n[pid 36692] execve(\"/run/current-system/sw/bin/sendmail\", [\"sendmail\", \"-oi\", \"clemens@endorphin.org\"], 0x7ffe0fc75808 /* 82 vars */) = 0\r\nstrace: Process 36693 attached\r\n[pid 36693] execve(\"/nix/store/a9ck93r3rw8frqph73fhgr0mfvs6dzv8-postfix-3.3.1/bin/postdrop\", [\"/nix/store/a9ck93r3rw8frqph73fhg\"..., \"-r\"], 0x563f5b430220 /* 2 vars */) = 0\r\npostdrop: warning: mail_queue_enter: create file maildrop/528081.36693: Permission denied\r\npostdrop: warning: mail_queue_enter: create file maildrop/528270.36693: Permission denied\r\n```\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/422313673","html_url":"https://github.com/NixOS/nixpkgs/pull/46736#issuecomment-422313673","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/46736","id":422313673,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjMxMzY3Mw==","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T08:59:06Z","updated_at":"2018-09-18T08:59:06Z","author_association":"CONTRIBUTOR","body":"@GrahamcOfBorg build mpack"}}
{"actor":{"display_login":"Mic92"}}