{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43018","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43018/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43018/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43018/events","html_url":"https://github.com/NixOS/nixpkgs/pull/43018","id":338259164,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjM2NjM0","number":43018,"title":"bazel-deps: init at 2018-05-31","user":{"login":"uri-canva","id":33242106,"node_id":"MDQ6VXNlcjMzMjQyMTA2","avatar_url":"https://avatars1.githubusercontent.com/u/33242106?v=4","gravatar_id":"","url":"https://api.github.com/users/uri-canva","html_url":"https://github.com/uri-canva","followers_url":"https://api.github.com/users/uri-canva/followers","following_url":"https://api.github.com/users/uri-canva/following{/other_user}","gists_url":"https://api.github.com/users/uri-canva/gists{/gist_id}","starred_url":"https://api.github.com/users/uri-canva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uri-canva/subscriptions","organizations_url":"https://api.github.com/users/uri-canva/orgs","repos_url":"https://api.github.com/users/uri-canva/repos","events_url":"https://api.github.com/users/uri-canva/events{/privacy}","received_events_url":"https://api.github.com/users/uri-canva/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-07-04T12:36:40Z","updated_at":"2018-07-10T04:34:01Z","closed_at":"2018-07-09T22:38:46Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/43018","html_url":"https://github.com/NixOS/nixpkgs/pull/43018","diff_url":"https://github.com/NixOS/nixpkgs/pull/43018.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/43018.patch"},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] macOS\r\n   - [x] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/403697298","html_url":"https://github.com/NixOS/nixpkgs/pull/43018#issuecomment-403697298","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43018","id":403697298,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzY5NzI5OA==","user":{"login":"uri-canva","id":33242106,"node_id":"MDQ6VXNlcjMzMjQyMTA2","avatar_url":"https://avatars1.githubusercontent.com/u/33242106?v=4","gravatar_id":"","url":"https://api.github.com/users/uri-canva","html_url":"https://github.com/uri-canva","followers_url":"https://api.github.com/users/uri-canva/followers","following_url":"https://api.github.com/users/uri-canva/following{/other_user}","gists_url":"https://api.github.com/users/uri-canva/gists{/gist_id}","starred_url":"https://api.github.com/users/uri-canva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uri-canva/subscriptions","organizations_url":"https://api.github.com/users/uri-canva/orgs","repos_url":"https://api.github.com/users/uri-canva/repos","events_url":"https://api.github.com/users/uri-canva/events{/privacy}","received_events_url":"https://api.github.com/users/uri-canva/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T04:34:01Z","updated_at":"2018-07-10T04:34:01Z","author_association":"CONTRIBUTOR","body":"`enableNixHacks` does two things:\r\n\r\n1. Makes Bazel assume the external workspaces are up to date by disabling the marker check.\r\n2. Makes Bazel propagate environment variables by disabling environment sandboxing.\r\n\r\nIn this case neither was necessary, the external workspaces are up to date and pass the check, and the scala compilation does not use any environment variables from outside.\r\n\r\nBefore this PR the only derivation using `buildBazelPackage` was tensorflow, which is why the hacks weren't parametrised. It's possible once we build tensorflow from source without the wheel that derivation won't need the hacks at all."}}
{"actor":{"display_login":"uri-canva"}}