{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30","id":202056320,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDU2MzIw","html_url":"https://github.com/adunkman/dc311rn.com/pull/30","diff_url":"https://github.com/adunkman/dc311rn.com/pull/30.diff","patch_url":"https://github.com/adunkman/dc311rn.com/pull/30.patch","issue_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/30","number":30,"state":"closed","locked":false,"title":"Stability improvements in tests, handling DC311’s API outages.","user":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"body":"Today DC’s 311 service started resetting connections instead of responding to requests, and our service just rendered `Internal Server Error` pages. This is understandable (and as designed) — but let’s do better. \r\n\r\nThis PR introduces an error page to handle when we cannot reach DC311’s API. \r\n\r\nAdditionally, this PR adjusts the way we extend `Error` due to https://github.com/babel/babel/issues/3083 (the `instanceof` operator wasn’t working correctly before). \r\n\r\nAdditionally, this PR adjusts the tests for `DC311.getServiceRequests()` to not be dependent on today’s date, which enables the generated fixture files to fully handle the tests, preventing any network requests when running `npm test`. ","created_at":"2018-07-17T20:14:18Z","updated_at":"2018-07-17T20:16:58Z","closed_at":"2018-07-17T20:16:58Z","merged_at":"2018-07-17T20:16:58Z","merge_commit_sha":"0db470da2a637213b7bdf59515681d61b0807f64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30/commits","review_comments_url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30/comments","review_comment_url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/30/comments","statuses_url":"https://api.github.com/repos/adunkman/dc311rn.com/statuses/0db470da2a637213b7bdf59515681d61b0807f64","head":{"label":"adunkman:stability-improvements","ref":"stability-improvements","sha":"0db470da2a637213b7bdf59515681d61b0807f64","user":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"repo":{"id":128245565,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNDU1NjU=","name":"dc311rn.com","full_name":"adunkman/dc311rn.com","owner":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adunkman/dc311rn.com","description":"Quickly check the status of a DC 311 service request","fork":false,"url":"https://api.github.com/repos/adunkman/dc311rn.com","forks_url":"https://api.github.com/repos/adunkman/dc311rn.com/forks","keys_url":"https://api.github.com/repos/adunkman/dc311rn.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adunkman/dc311rn.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adunkman/dc311rn.com/teams","hooks_url":"https://api.github.com/repos/adunkman/dc311rn.com/hooks","issue_events_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/events{/number}","events_url":"https://api.github.com/repos/adunkman/dc311rn.com/events","assignees_url":"https://api.github.com/repos/adunkman/dc311rn.com/assignees{/user}","branches_url":"https://api.github.com/repos/adunkman/dc311rn.com/branches{/branch}","tags_url":"https://api.github.com/repos/adunkman/dc311rn.com/tags","blobs_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adunkman/dc311rn.com/statuses/{sha}","languages_url":"https://api.github.com/repos/adunkman/dc311rn.com/languages","stargazers_url":"https://api.github.com/repos/adunkman/dc311rn.com/stargazers","contributors_url":"https://api.github.com/repos/adunkman/dc311rn.com/contributors","subscribers_url":"https://api.github.com/repos/adunkman/dc311rn.com/subscribers","subscription_url":"https://api.github.com/repos/adunkman/dc311rn.com/subscription","commits_url":"https://api.github.com/repos/adunkman/dc311rn.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/adunkman/dc311rn.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/adunkman/dc311rn.com/contents/{+path}","compare_url":"https://api.github.com/repos/adunkman/dc311rn.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adunkman/dc311rn.com/merges","archive_url":"https://api.github.com/repos/adunkman/dc311rn.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adunkman/dc311rn.com/downloads","issues_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues{/number}","pulls_url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls{/number}","milestones_url":"https://api.github.com/repos/adunkman/dc311rn.com/milestones{/number}","notifications_url":"https://api.github.com/repos/adunkman/dc311rn.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adunkman/dc311rn.com/labels{/name}","releases_url":"https://api.github.com/repos/adunkman/dc311rn.com/releases{/id}","deployments_url":"https://api.github.com/repos/adunkman/dc311rn.com/deployments","created_at":"2018-04-05T18:10:17Z","updated_at":"2018-07-15T16:58:36Z","pushed_at":"2018-07-17T20:16:57Z","git_url":"git://github.com/adunkman/dc311rn.com.git","ssh_url":"git@github.com:adunkman/dc311rn.com.git","clone_url":"https://github.com/adunkman/dc311rn.com.git","svn_url":"https://github.com/adunkman/dc311rn.com","homepage":"https://www.dc311rn.com","size":516,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"adunkman:master","ref":"master","sha":"7c34cfd83f7acece2a1d5795064cf1dd2ff70140","user":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"repo":{"id":128245565,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyNDU1NjU=","name":"dc311rn.com","full_name":"adunkman/dc311rn.com","owner":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adunkman/dc311rn.com","description":"Quickly check the status of a DC 311 service request","fork":false,"url":"https://api.github.com/repos/adunkman/dc311rn.com","forks_url":"https://api.github.com/repos/adunkman/dc311rn.com/forks","keys_url":"https://api.github.com/repos/adunkman/dc311rn.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adunkman/dc311rn.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adunkman/dc311rn.com/teams","hooks_url":"https://api.github.com/repos/adunkman/dc311rn.com/hooks","issue_events_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/events{/number}","events_url":"https://api.github.com/repos/adunkman/dc311rn.com/events","assignees_url":"https://api.github.com/repos/adunkman/dc311rn.com/assignees{/user}","branches_url":"https://api.github.com/repos/adunkman/dc311rn.com/branches{/branch}","tags_url":"https://api.github.com/repos/adunkman/dc311rn.com/tags","blobs_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adunkman/dc311rn.com/statuses/{sha}","languages_url":"https://api.github.com/repos/adunkman/dc311rn.com/languages","stargazers_url":"https://api.github.com/repos/adunkman/dc311rn.com/stargazers","contributors_url":"https://api.github.com/repos/adunkman/dc311rn.com/contributors","subscribers_url":"https://api.github.com/repos/adunkman/dc311rn.com/subscribers","subscription_url":"https://api.github.com/repos/adunkman/dc311rn.com/subscription","commits_url":"https://api.github.com/repos/adunkman/dc311rn.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/adunkman/dc311rn.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/adunkman/dc311rn.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/adunkman/dc311rn.com/contents/{+path}","compare_url":"https://api.github.com/repos/adunkman/dc311rn.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adunkman/dc311rn.com/merges","archive_url":"https://api.github.com/repos/adunkman/dc311rn.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adunkman/dc311rn.com/downloads","issues_url":"https://api.github.com/repos/adunkman/dc311rn.com/issues{/number}","pulls_url":"https://api.github.com/repos/adunkman/dc311rn.com/pulls{/number}","milestones_url":"https://api.github.com/repos/adunkman/dc311rn.com/milestones{/number}","notifications_url":"https://api.github.com/repos/adunkman/dc311rn.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adunkman/dc311rn.com/labels{/name}","releases_url":"https://api.github.com/repos/adunkman/dc311rn.com/releases{/id}","deployments_url":"https://api.github.com/repos/adunkman/dc311rn.com/deployments","created_at":"2018-04-05T18:10:17Z","updated_at":"2018-07-15T16:58:36Z","pushed_at":"2018-07-17T20:16:57Z","git_url":"git://github.com/adunkman/dc311rn.com.git","ssh_url":"git@github.com:adunkman/dc311rn.com.git","clone_url":"https://github.com/adunkman/dc311rn.com.git","svn_url":"https://github.com/adunkman/dc311rn.com","homepage":"https://www.dc311rn.com","size":516,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30"},"html":{"href":"https://github.com/adunkman/dc311rn.com/pull/30"},"issue":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/issues/30"},"comments":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/adunkman/dc311rn.com/statuses/0db470da2a637213b7bdf59515681d61b0807f64"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adunkman","id":14930,"node_id":"MDQ6VXNlcjE0OTMw","avatar_url":"https://avatars2.githubusercontent.com/u/14930?v=4","gravatar_id":"","url":"https://api.github.com/users/adunkman","html_url":"https://github.com/adunkman","followers_url":"https://api.github.com/users/adunkman/followers","following_url":"https://api.github.com/users/adunkman/following{/other_user}","gists_url":"https://api.github.com/users/adunkman/gists{/gist_id}","starred_url":"https://api.github.com/users/adunkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunkman/subscriptions","organizations_url":"https://api.github.com/users/adunkman/orgs","repos_url":"https://api.github.com/users/adunkman/repos","events_url":"https://api.github.com/users/adunkman/events{/privacy}","received_events_url":"https://api.github.com/users/adunkman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":177,"deletions":30,"changed_files":12}}
{"actor":{"display_login":"adunkman"}}