{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/60192","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/60192/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/60192/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/60192/events","html_url":"https://github.com/Microsoft/vscode/issues/60192","id":367944611,"node_id":"MDU6SXNzdWUzNjc5NDQ2MTE=","number":60192,"title":"Allow to use --wait with Code.exe","user":{"login":"rebornix","id":876920,"node_id":"MDQ6VXNlcjg3NjkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/876920?v=4","gravatar_id":"","url":"https://api.github.com/users/rebornix","html_url":"https://github.com/rebornix","followers_url":"https://api.github.com/users/rebornix/followers","following_url":"https://api.github.com/users/rebornix/following{/other_user}","gists_url":"https://api.github.com/users/rebornix/gists{/gist_id}","starred_url":"https://api.github.com/users/rebornix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebornix/subscriptions","organizations_url":"https://api.github.com/users/rebornix/orgs","repos_url":"https://api.github.com/users/rebornix/repos","events_url":"https://api.github.com/users/rebornix/events{/privacy}","received_events_url":"https://api.github.com/users/rebornix/received_events","type":"User","site_admin":false},"labels":[{"id":779863534,"node_id":"MDU6TGFiZWw3Nzk4NjM1MzQ=","url":"https://api.github.com/repos/Microsoft/vscode/labels/cli","name":"cli","color":"1d76db","default":false},{"id":272689392,"node_id":"MDU6TGFiZWwyNzI2ODkzOTI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"dcdcdc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-08T20:39:16Z","updated_at":"2018-10-23T11:58:25Z","closed_at":null,"author_association":"MEMBER","body":"<!-- Please search existing issues to avoid creating duplicates. --> \r\n<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->\r\n\r\n<!-- Use Help > Report Issue to prefill these. -->\r\n- VSCode Version: 1.29 Insiders\r\n- OS Version: Windows 10\r\n\r\nSteps to Reproduce:\r\n\r\nGood path:\r\n\r\n1. Set VSCode Insiders as the editor for Git SCM\r\n2. Try commands which involve commit message update, for example, `git rebase` or `git cherry-pick` which contains conflicts.\r\n3. Run the command in an external terminal, after resolving the conflicts, close all VSCode windows.\r\n4. Run the command with `--continue` flag. \r\n5. A new window is open and an editor is created for you to update the commit message\r\n\r\n  ![image](https://user-images.githubusercontent.com/876920/46632359-389bb580-caff-11e8-9267-dc13dc7ded35.png)\r\n\r\n6. Close the window, the command is finished properly\r\n\r\nbad one:\r\n1. Run the command in the integrated terminal, so we are already in a VSCode window\r\n2. The commit message update editor is opened in the same window\r\n3. Close the editor, the command is still waiting for the file to be released.\r\n\r\n![image](https://user-images.githubusercontent.com/876920/46632440-87e1e600-caff-11e8-9ffb-806f822a24ac.png)\r\n\r\n<!-- Launch with `code --disable-extensions` to check. -->\r\nDoes this issue occur when all extensions are disabled?: Yes/No\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/432217063","html_url":"https://github.com/Microsoft/vscode/issues/60192#issuecomment-432217063","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/60192","id":432217063,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjIxNzA2Mw==","user":{"login":"bpasero","id":900690,"node_id":"MDQ6VXNlcjkwMDY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T11:58:25Z","updated_at":"2018-10-23T11:58:25Z","author_association":"MEMBER","body":"I fixed the NPE. I will convert this to be a feature request. I never intended this to fully work with Code.exe, but if someone has energy, feel free to jump in.\r\n\r\nOne thing that always annoyed me when using Code.exe directly is the fact that once the Electron process terminates, you are never put back to the Windows prompt. Here the launching process has terminated but the prompt is not showing up again:\r\n\r\n![image](https://user-images.githubusercontent.com/900690/47358981-b51bc000-d6cb-11e8-8159-7f20a580e15d.png)\r\n"}}
{"actor":{"display_login":"bpasero"}}