{"action":"created","comment":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments/227068124","pull_request_review_id":167025837,"id":227068124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA2ODEyNA==","diff_hunk":"@@ -39,8 +39,8 @@ public function preProcess()\n         if ($ID !== $conf['start'] && !$INPUT->has('q')) {\n             parse_str($INPUT->server->str('QUERY_STRING'), $urlParts);\n             $urlParts['q'] = $urlParts['id'];\n-            $urlParts['id'] = $conf['start'];\n-            $url = DOKU_URL . DOKU_SCRIPT . '?' . http_build_query($urlParts, null, '&');\n+            unset($urlParts['id']);\n+            $url = wl() . '?' . http_build_query($urlParts, null, '&');","path":"inc/Action/Search.php","position":7,"original_position":7,"commit_id":"918638dc28433db36dedaee97701ae4e4207c9ac","original_commit_id":"918638dc28433db36dedaee97701ae4e4207c9ac","user":{"login":"phy25","id":331403,"node_id":"MDQ6VXNlcjMzMTQwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/331403?v=4","gravatar_id":"","url":"https://api.github.com/users/phy25","html_url":"https://github.com/phy25","followers_url":"https://api.github.com/users/phy25/followers","following_url":"https://api.github.com/users/phy25/following{/other_user}","gists_url":"https://api.github.com/users/phy25/gists{/gist_id}","starred_url":"https://api.github.com/users/phy25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phy25/subscriptions","organizations_url":"https://api.github.com/users/phy25/orgs","repos_url":"https://api.github.com/users/phy25/repos","events_url":"https://api.github.com/users/phy25/events{/privacy}","received_events_url":"https://api.github.com/users/phy25/received_events","type":"User","site_admin":false},"body":"$ID should be preserved, try this:\r\n\r\n1. https://www.dokuwiki.org/non_exists\r\n2. Search on the top of this page\r\n3. Look at the URL: https://www.dokuwiki.org/start?do=search&id=non_exists&q=test\r\n4. Submit in the inline search form: https://www.dokuwiki.org/non_exists?do=search&id=non_exists&sf=1&q=test","created_at":"2018-10-22T17:41:39Z","updated_at":"2018-10-22T17:41:39Z","html_url":"https://github.com/splitbrain/dokuwiki/pull/2547#discussion_r227068124","pull_request_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments/227068124"},"html":{"href":"https://github.com/splitbrain/dokuwiki/pull/2547#discussion_r227068124"},"pull_request":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547"}},"in_reply_to_id":226904616},"pull_request":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547","id":224571739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTcxNzM5","html_url":"https://github.com/splitbrain/dokuwiki/pull/2547","diff_url":"https://github.com/splitbrain/dokuwiki/pull/2547.diff","patch_url":"https://github.com/splitbrain/dokuwiki/pull/2547.patch","issue_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2547","number":2547,"state":"open","locked":false,"title":"use wl() when redirecting old style search url","user":{"login":"schplurtz","id":1008292,"node_id":"MDQ6VXNlcjEwMDgyOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1008292?v=4","gravatar_id":"","url":"https://api.github.com/users/schplurtz","html_url":"https://github.com/schplurtz","followers_url":"https://api.github.com/users/schplurtz/followers","following_url":"https://api.github.com/users/schplurtz/following{/other_user}","gists_url":"https://api.github.com/users/schplurtz/gists{/gist_id}","starred_url":"https://api.github.com/users/schplurtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schplurtz/subscriptions","organizations_url":"https://api.github.com/users/schplurtz/orgs","repos_url":"https://api.github.com/users/schplurtz/repos","events_url":"https://api.github.com/users/schplurtz/events{/privacy}","received_events_url":"https://api.github.com/users/schplurtz/received_events","type":"User","site_admin":false},"body":"fixes #2546","created_at":"2018-10-21T21:55:12Z","updated_at":"2018-10-22T17:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fe5f95c39ce098594115601d797b8f0188496d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547/commits","review_comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547/comments","review_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2547/comments","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/918638dc28433db36dedaee97701ae4e4207c9ac","head":{"label":"schplurtz:preprocess-use-wl","ref":"preprocess-use-wl","sha":"918638dc28433db36dedaee97701ae4e4207c9ac","user":{"login":"schplurtz","id":1008292,"node_id":"MDQ6VXNlcjEwMDgyOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1008292?v=4","gravatar_id":"","url":"https://api.github.com/users/schplurtz","html_url":"https://github.com/schplurtz","followers_url":"https://api.github.com/users/schplurtz/followers","following_url":"https://api.github.com/users/schplurtz/following{/other_user}","gists_url":"https://api.github.com/users/schplurtz/gists{/gist_id}","starred_url":"https://api.github.com/users/schplurtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schplurtz/subscriptions","organizations_url":"https://api.github.com/users/schplurtz/orgs","repos_url":"https://api.github.com/users/schplurtz/repos","events_url":"https://api.github.com/users/schplurtz/events{/privacy}","received_events_url":"https://api.github.com/users/schplurtz/received_events","type":"User","site_admin":false},"repo":{"id":154051001,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwNTEwMDE=","name":"dokuwiki","full_name":"schplurtz/dokuwiki","private":false,"owner":{"login":"schplurtz","id":1008292,"node_id":"MDQ6VXNlcjEwMDgyOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1008292?v=4","gravatar_id":"","url":"https://api.github.com/users/schplurtz","html_url":"https://github.com/schplurtz","followers_url":"https://api.github.com/users/schplurtz/followers","following_url":"https://api.github.com/users/schplurtz/following{/other_user}","gists_url":"https://api.github.com/users/schplurtz/gists{/gist_id}","starred_url":"https://api.github.com/users/schplurtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schplurtz/subscriptions","organizations_url":"https://api.github.com/users/schplurtz/orgs","repos_url":"https://api.github.com/users/schplurtz/repos","events_url":"https://api.github.com/users/schplurtz/events{/privacy}","received_events_url":"https://api.github.com/users/schplurtz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/schplurtz/dokuwiki","description":"The DokuWiki Open Source Wiki Engine","fork":true,"url":"https://api.github.com/repos/schplurtz/dokuwiki","forks_url":"https://api.github.com/repos/schplurtz/dokuwiki/forks","keys_url":"https://api.github.com/repos/schplurtz/dokuwiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schplurtz/dokuwiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schplurtz/dokuwiki/teams","hooks_url":"https://api.github.com/repos/schplurtz/dokuwiki/hooks","issue_events_url":"https://api.github.com/repos/schplurtz/dokuwiki/issues/events{/number}","events_url":"https://api.github.com/repos/schplurtz/dokuwiki/events","assignees_url":"https://api.github.com/repos/schplurtz/dokuwiki/assignees{/user}","branches_url":"https://api.github.com/repos/schplurtz/dokuwiki/branches{/branch}","tags_url":"https://api.github.com/repos/schplurtz/dokuwiki/tags","blobs_url":"https://api.github.com/repos/schplurtz/dokuwiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schplurtz/dokuwiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schplurtz/dokuwiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/schplurtz/dokuwiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schplurtz/dokuwiki/statuses/{sha}","languages_url":"https://api.github.com/repos/schplurtz/dokuwiki/languages","stargazers_url":"https://api.github.com/repos/schplurtz/dokuwiki/stargazers","contributors_url":"https://api.github.com/repos/schplurtz/dokuwiki/contributors","subscribers_url":"https://api.github.com/repos/schplurtz/dokuwiki/subscribers","subscription_url":"https://api.github.com/repos/schplurtz/dokuwiki/subscription","commits_url":"https://api.github.com/repos/schplurtz/dokuwiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/schplurtz/dokuwiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/schplurtz/dokuwiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/schplurtz/dokuwiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/schplurtz/dokuwiki/contents/{+path}","compare_url":"https://api.github.com/repos/schplurtz/dokuwiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schplurtz/dokuwiki/merges","archive_url":"https://api.github.com/repos/schplurtz/dokuwiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schplurtz/dokuwiki/downloads","issues_url":"https://api.github.com/repos/schplurtz/dokuwiki/issues{/number}","pulls_url":"https://api.github.com/repos/schplurtz/dokuwiki/pulls{/number}","milestones_url":"https://api.github.com/repos/schplurtz/dokuwiki/milestones{/number}","notifications_url":"https://api.github.com/repos/schplurtz/dokuwiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schplurtz/dokuwiki/labels{/name}","releases_url":"https://api.github.com/repos/schplurtz/dokuwiki/releases{/id}","deployments_url":"https://api.github.com/repos/schplurtz/dokuwiki/deployments","created_at":"2018-10-21T20:50:07Z","updated_at":"2018-10-21T20:50:14Z","pushed_at":"2018-10-21T21:54:04Z","git_url":"git://github.com/schplurtz/dokuwiki.git","ssh_url":"git@github.com:schplurtz/dokuwiki.git","clone_url":"https://github.com/schplurtz/dokuwiki.git","svn_url":"https://github.com/schplurtz/dokuwiki","homepage":"http://www.dokuwiki.org","size":34867,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"splitbrain:master","ref":"master","sha":"bac90a60ff3796523f32cddcf2c15f69d665ff0b","user":{"login":"splitbrain","id":86426,"node_id":"MDQ6VXNlcjg2NDI2","avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"repo":{"id":456930,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY5MzA=","name":"dokuwiki","full_name":"splitbrain/dokuwiki","private":false,"owner":{"login":"splitbrain","id":86426,"node_id":"MDQ6VXNlcjg2NDI2","avatar_url":"https://avatars1.githubusercontent.com/u/86426?v=4","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"html_url":"https://github.com/splitbrain/dokuwiki","description":"The DokuWiki Open Source Wiki Engine","fork":false,"url":"https://api.github.com/repos/splitbrain/dokuwiki","forks_url":"https://api.github.com/repos/splitbrain/dokuwiki/forks","keys_url":"https://api.github.com/repos/splitbrain/dokuwiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splitbrain/dokuwiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splitbrain/dokuwiki/teams","hooks_url":"https://api.github.com/repos/splitbrain/dokuwiki/hooks","issue_events_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/events{/number}","events_url":"https://api.github.com/repos/splitbrain/dokuwiki/events","assignees_url":"https://api.github.com/repos/splitbrain/dokuwiki/assignees{/user}","branches_url":"https://api.github.com/repos/splitbrain/dokuwiki/branches{/branch}","tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/tags","blobs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/{sha}","languages_url":"https://api.github.com/repos/splitbrain/dokuwiki/languages","stargazers_url":"https://api.github.com/repos/splitbrain/dokuwiki/stargazers","contributors_url":"https://api.github.com/repos/splitbrain/dokuwiki/contributors","subscribers_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscribers","subscription_url":"https://api.github.com/repos/splitbrain/dokuwiki/subscription","commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/splitbrain/dokuwiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/splitbrain/dokuwiki/contents/{+path}","compare_url":"https://api.github.com/repos/splitbrain/dokuwiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splitbrain/dokuwiki/merges","archive_url":"https://api.github.com/repos/splitbrain/dokuwiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splitbrain/dokuwiki/downloads","issues_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues{/number}","pulls_url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls{/number}","milestones_url":"https://api.github.com/repos/splitbrain/dokuwiki/milestones{/number}","notifications_url":"https://api.github.com/repos/splitbrain/dokuwiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/labels{/name}","releases_url":"https://api.github.com/repos/splitbrain/dokuwiki/releases{/id}","deployments_url":"https://api.github.com/repos/splitbrain/dokuwiki/deployments","created_at":"2010-01-03T13:47:20Z","updated_at":"2018-10-22T13:00:14Z","pushed_at":"2018-10-22T16:03:13Z","git_url":"git://github.com/splitbrain/dokuwiki.git","ssh_url":"git@github.com:splitbrain/dokuwiki.git","clone_url":"https://github.com/splitbrain/dokuwiki.git","svn_url":"https://github.com/splitbrain/dokuwiki","homepage":"http://www.dokuwiki.org","size":34868,"stargazers_count":2283,"watchers_count":2283,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":604,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":604,"open_issues":313,"watchers":2283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547"},"html":{"href":"https://github.com/splitbrain/dokuwiki/pull/2547"},"issue":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2547"},"comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/issues/2547/comments"},"review_comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547/comments"},"review_comment":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/2547/commits"},"statuses":{"href":"https://api.github.com/repos/splitbrain/dokuwiki/statuses/918638dc28433db36dedaee97701ae4e4207c9ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"phy25"}}