{"action":"created","comment":{"url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/224715673","pull_request_review_id":164152640,"id":224715673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDcxNTY3Mw==","diff_hunk":"@@ -231,37 +242,55 @@ def handle_close(self):\n \n \n class Socks5BMConnection(Socks5Connection, TCPConnection):\n+    \"\"\"TBC\"\"\"\n+\n     def __init__(self, address):\n         Socks5Connection.__init__(self, address=address)\n         TCPConnection.__init__(self, address=address, sock=self.socket)\n         self.set_state(\"init\")\n \n     def state_proxy_handshake_done(self):\n+        \"\"\"TBC\"\"\"","path":"src/network/tcp.py","position":248,"original_position":248,"commit_id":"afd7603727272e8d2fd6637e9ab0249eba49fc84","original_commit_id":"afd7603727272e8d2fd6637e9ab0249eba49fc84","user":{"login":"PeterSurda","id":3815204,"node_id":"MDQ6VXNlcjM4MTUyMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3815204?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterSurda","html_url":"https://github.com/PeterSurda","followers_url":"https://api.github.com/users/PeterSurda/followers","following_url":"https://api.github.com/users/PeterSurda/following{/other_user}","gists_url":"https://api.github.com/users/PeterSurda/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterSurda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterSurda/subscriptions","organizations_url":"https://api.github.com/users/PeterSurda/orgs","repos_url":"https://api.github.com/users/PeterSurda/repos","events_url":"https://api.github.com/users/PeterSurda/events{/privacy}","received_events_url":"https://api.github.com/users/PeterSurda/received_events","type":"User","site_admin":false},"body":"State when SOCKS5 connection succeeds, we need to send a Bitmessage handshake to peer.","created_at":"2018-10-12T08:55:00Z","updated_at":"2018-10-12T08:55:00Z","html_url":"https://github.com/Bitmessage/PyBitmessage/pull/1363#discussion_r224715673","pull_request_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/224715673"},"html":{"href":"https://github.com/Bitmessage/PyBitmessage/pull/1363#discussion_r224715673"},"pull_request":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363"}}},"pull_request":{"url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363","id":221735536,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzM1NTM2","html_url":"https://github.com/Bitmessage/PyBitmessage/pull/1363","diff_url":"https://github.com/Bitmessage/PyBitmessage/pull/1363.diff","patch_url":"https://github.com/Bitmessage/PyBitmessage/pull/1363.patch","issue_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1363","number":1363,"state":"open","locked":false,"title":"Changes based on style and lint checks. (final_code_quality_5)","user":{"login":"coffeedogs","id":38851325,"node_id":"MDQ6VXNlcjM4ODUxMzI1","avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"body":"## Repository contributions to the PyBitmessage project\r\n\r\n- You can get paid for merged commits if you register at [Tip4Commit](https://tip4commit.com/github/Bitmessage/PyBitmessage)\r\n\r\n### Code\r\n\r\n- Try to refer to github issue tracker or other permanent sources of discussion about the issue.\r\n- It is clear from the diff *what* you have done, it may be less clear *why* you have done it so explain why this change is necessary rather than what it does\r\n\r\n### Documentation\r\n\r\n- If there has been a change to the code, there's a good possibility there should be a corresponding change to the documentation \r\n- If you can't run `fab build_docs` successfully, ask for someone to run it against your branch\r\n\r\n### Tests\r\n\r\n- If there has been a change to the code, there's a good possibility there should be a corresponding change to the tests\r\n- If you can't run `fab tests` successfully, ask for someone to run it against your branch\r\n\r\n## Translations\r\n\r\n- For helping with translations, please use [Transifex](https://www.transifex.com/bitmessage-project/pybitmessage/).\r\n- There is no need to submit pull requests for translations.\r\n- For translating technical terms it is recommended to consult the [Microsoft Language Portal](https://www.microsoft.com/Language/en-US/Default.aspx).\r\n\r\n### Gitiquette\r\n\r\n- Make the pull request against the [\"v0.6\" branch](https://github.com/Bitmessage/PyBitmessage/tree/v0.6)\r\n- PGP-sign the commits included in the pull request\r\n- Use references to tickets, e.g. `addresses #123` or `fixes #234` in your commit messages\r\n- Try to use a good editor that removes trailing whitespace, highlights potential python issues and uses unix line endings\r\n- If for some reason you don't want to use github, you can submit the patch using Bitmessage to the \"bitmessage\" chan, or to one of the developers.\r\n\r\n","created_at":"2018-10-10T10:25:05Z","updated_at":"2018-10-12T08:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c0c73ecabef4d2cc8f5910e52da096639c87db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1363/comments","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/afd7603727272e8d2fd6637e9ab0249eba49fc84","head":{"label":"coffeedogs:final_code_quality_5","ref":"final_code_quality_5","sha":"afd7603727272e8d2fd6637e9ab0249eba49fc84","user":{"login":"coffeedogs","id":38851325,"node_id":"MDQ6VXNlcjM4ODUxMzI1","avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"repo":{"id":131573331,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1NzMzMzE=","name":"PyBitmessage","full_name":"coffeedogs/PyBitmessage","private":false,"owner":{"login":"coffeedogs","id":38851325,"node_id":"MDQ6VXNlcjM4ODUxMzI1","avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coffeedogs/PyBitmessage","description":"Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:","fork":true,"url":"https://api.github.com/repos/coffeedogs/PyBitmessage","forks_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/forks","keys_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/events","assignees_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues/comments{/number}","contents_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/merges","archive_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/releases{/id}","deployments_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/deployments","created_at":"2018-04-30T08:41:37Z","updated_at":"2018-04-30T08:41:40Z","pushed_at":"2018-10-11T13:10:10Z","git_url":"git://github.com/coffeedogs/PyBitmessage.git","ssh_url":"git@github.com:coffeedogs/PyBitmessage.git","clone_url":"https://github.com/coffeedogs/PyBitmessage.git","svn_url":"https://github.com/coffeedogs/PyBitmessage","homepage":"https://bitmessage.org/wiki/Main_Page","size":11528,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bitmessage:v0.6","ref":"v0.6","sha":"6969ec0ec92049501bbbaf1751f1ea24f39ff862","user":{"login":"Bitmessage","id":2625379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjUzNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625379?v=4","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"repo":{"id":6648028,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ4MDI4","name":"PyBitmessage","full_name":"Bitmessage/PyBitmessage","private":false,"owner":{"login":"Bitmessage","id":2625379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjUzNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625379?v=4","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Bitmessage/PyBitmessage","description":"Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:","fork":false,"url":"https://api.github.com/repos/Bitmessage/PyBitmessage","forks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/forks","keys_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/events","assignees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/merges","archive_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/releases{/id}","deployments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/deployments","created_at":"2012-11-12T03:36:43Z","updated_at":"2018-10-12T08:49:21Z","pushed_at":"2018-10-12T08:49:34Z","git_url":"git://github.com/Bitmessage/PyBitmessage.git","ssh_url":"git@github.com:Bitmessage/PyBitmessage.git","clone_url":"https://github.com/Bitmessage/PyBitmessage.git","svn_url":"https://github.com/Bitmessage/PyBitmessage","homepage":"https://bitmessage.org/wiki/Main_Page","size":11409,"stargazers_count":2309,"watchers_count":2309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":517,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":517,"open_issues":180,"watchers":2309,"default_branch":"v0.6"}},"_links":{"self":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363"},"html":{"href":"https://github.com/Bitmessage/PyBitmessage/pull/1363"},"issue":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1363"},"comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/afd7603727272e8d2fd6637e9ab0249eba49fc84"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"PeterSurda"}}