{"action":"created","issue":{"url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/1","repository_url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager","labels_url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/1/comments","events_url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/1/events","html_url":"https://github.com/onechiporenko/ember-bootstrap-modals-manager/issues/1","id":293439377,"number":1,"title":"Nice! :) / Some suggestions","user":{"login":"simonihmig","id":1325249,"avatar_url":"https://avatars0.githubusercontent.com/u/1325249?v=4","gravatar_id":"","url":"https://api.github.com/users/simonihmig","html_url":"https://github.com/simonihmig","followers_url":"https://api.github.com/users/simonihmig/followers","following_url":"https://api.github.com/users/simonihmig/following{/other_user}","gists_url":"https://api.github.com/users/simonihmig/gists{/gist_id}","starred_url":"https://api.github.com/users/simonihmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonihmig/subscriptions","organizations_url":"https://api.github.com/users/simonihmig/orgs","repos_url":"https://api.github.com/users/simonihmig/repos","events_url":"https://api.github.com/users/simonihmig/events{/privacy}","received_events_url":"https://api.github.com/users/simonihmig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-01T08:14:15Z","updated_at":"2018-02-01T10:24:31Z","closed_at":null,"author_association":"NONE","body":"Hi @onechiporenko,\r\n\r\njust saw your addon listed in EmberWeekly, and just want quickly drop a note that I like this! :)\r\n\r\nWe used a similar approach in an app we built, but that was more limited to what we needed there (mainly `confirm`). I always thought that something like this would be useful, but also that `ember-bootstrap` should not be concerned with that, rather stay focused on the basic UI components, and other addons can build something on top of it. Nice that you found the time for this! :) \r\n\r\nSome little suggestions:\r\n\r\n* it seems to me when you `ember install ember-bootstrap-modals-manager`, it will not install `ember-bootstrap` along with it, right? You can either add it to `dependencies` (rather than `devdependencies`), or maybe better add a default blueprint that calls `this.addAddonToProject('ember-bootstrap')` (so users can control their e-b version in their app's `package.json`). I use the latter approach here for example: https://github.com/kaliber5/ember-bootstrap/blob/master/blueprints/ember-bootstrap/index.js#L144\r\n* maybe apply `type=\"primary\"` to the \"main\" button in the footer?"},"comment":{"url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/comments/362222929","html_url":"https://github.com/onechiporenko/ember-bootstrap-modals-manager/issues/1#issuecomment-362222929","issue_url":"https://api.github.com/repos/onechiporenko/ember-bootstrap-modals-manager/issues/1","id":362222929,"user":{"login":"onechiporenko","id":2485873,"avatar_url":"https://avatars3.githubusercontent.com/u/2485873?v=4","gravatar_id":"","url":"https://api.github.com/users/onechiporenko","html_url":"https://github.com/onechiporenko","followers_url":"https://api.github.com/users/onechiporenko/followers","following_url":"https://api.github.com/users/onechiporenko/following{/other_user}","gists_url":"https://api.github.com/users/onechiporenko/gists{/gist_id}","starred_url":"https://api.github.com/users/onechiporenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onechiporenko/subscriptions","organizations_url":"https://api.github.com/users/onechiporenko/orgs","repos_url":"https://api.github.com/users/onechiporenko/repos","events_url":"https://api.github.com/users/onechiporenko/events{/privacy}","received_events_url":"https://api.github.com/users/onechiporenko/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T10:24:31Z","updated_at":"2018-02-01T10:24:31Z","author_association":"OWNER","body":"Hi, @simonihmig. Thanks for your feedback and suggestions!\r\nI'll add `type=\"primary\"` and I'll do something with `ember-bootstrap` dependency. Idea with blueprint looks very good for me."}}
{"actor":{"display_login":"onechiporenko"}}