{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-go/issues/705","repository_url":"https://api.github.com/repos/status-im/status-go","labels_url":"https://api.github.com/repos/status-im/status-go/issues/705/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/705/comments","events_url":"https://api.github.com/repos/status-im/status-go/issues/705/events","html_url":"https://github.com/status-im/status-go/issues/705","id":300229409,"node_id":"MDU6SXNzdWUzMDAyMjk0MDk=","number":705,"title":"Whisper v6: Leverage new light mode in geth master","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"labels":[{"id":654260678,"node_id":"MDU6TGFiZWw2NTQyNjA2Nzg=","url":"https://api.github.com/repos/status-im/status-go/labels/proposal","name":"proposal","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-26T13:00:13Z","updated_at":"2018-06-05T07:51:58Z","closed_at":"2018-06-05T07:51:58Z","author_association":"MEMBER","body":"# Problem\r\n\r\nCurrently light nodes forward messages from other nodes. We want to leverage the new `shh.lightclient` `WhisperConfig` flag to enable Whisper light mode to reduce resource consumption.\r\n\r\n# Implementation\r\n\r\nUpgrade vendored geth to include https://github.com/ethereum/go-ethereum/pull/16172/.\r\nCall `MakeLightClient` if `WhisperConfig.LightClient` is true.\r\n\r\n# Acceptance Criteria\r\n\r\nTBD\r\n\r\n# Notes\r\n\r\nRandom notes to keep in mind while implementing it. Mostly about related issues and future plans and thoughts.\r\n\r\n# Future Steps\r\n\r\nSteps which should be taken after this issue has been resolved.\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-go/issues/comments/394615864","html_url":"https://github.com/status-im/status-go/issues/705#issuecomment-394615864","issue_url":"https://api.github.com/repos/status-im/status-go/issues/705","id":394615864,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDYxNTg2NA==","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T07:51:58Z","updated_at":"2018-06-05T07:51:58Z","author_association":"MEMBER","body":"@sebastiandelgado we have a `make update-geth` that normally handles updating geth from the official repo. I think this GHI is not needed and we can close it though (I don't think I understood the changes at the official go-ethereum repo at the time I created this), since if we enable `lightClient` (which we do for the mobile app), `isP2P` will already be true and the messages will not be forwarded. "}}
{"actor":{"display_login":"PombeirP"}}