{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/comments/176875582","pull_request_review_id":106662313,"id":176875582,"diff_hunk":"@@ -232,7 +232,7 @@ export class Serializer {\n         }\n         value = this.dateToUnixTime(value);\n       } else if (typeName.match(/^TimeSpan$/ig) !== null) {\n-        if (!isDuration(value)) {\n+        if (!(isDuration(value) || (value.constructor && value.constructor.name === \"Duration\" && (value as any).isValid && (value as any).isValid()))) {","path":"lib/serializer.ts","position":null,"original_position":5,"commit_id":"5b2aaf9992dea3c87e0bfb4e0a823a5b46fd37bc","original_commit_id":"e19931f74419490a53f68f1e8bc16d74c427b629","user":{"login":"RikkiGibson","id":5833655,"avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"Done @daschult ","created_at":"2018-03-23T22:07:16Z","updated_at":"2018-03-23T22:07:16Z","html_url":"https://github.com/Azure/ms-rest-js/pull/18#discussion_r176875582","pull_request_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/comments/176875582"},"html":{"href":"https://github.com/Azure/ms-rest-js/pull/18#discussion_r176875582"},"pull_request":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18"}},"in_reply_to_id":176874405},"pull_request":{"url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18","id":177193123,"html_url":"https://github.com/Azure/ms-rest-js/pull/18","diff_url":"https://github.com/Azure/ms-rest-js/pull/18.diff","patch_url":"https://github.com/Azure/ms-rest-js/pull/18.patch","issue_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/18","number":18,"state":"open","locked":false,"title":"Duration fix","user":{"login":"RikkiGibson","id":5833655,"avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"This allows us to tolerate usage of multiple moment versions simultaneously. Dupes work already done in Azure/azure-sdk-for-node#2453. Suggest particularly looking at the first two commits--the third is more \"noise\" (sourcemaps, js files)","created_at":"2018-03-23T21:57:40Z","updated_at":"2018-03-23T22:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05755a186d291761327dfc357b405ea3c89ab160","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":877696560,"url":"https://api.github.com/repos/Azure/ms-rest-js/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18/commits","review_comments_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18/comments","review_comment_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/18/comments","statuses_url":"https://api.github.com/repos/Azure/ms-rest-js/statuses/5b2aaf9992dea3c87e0bfb4e0a823a5b46fd37bc","head":{"label":"Azure:DurationFix","ref":"DurationFix","sha":"5b2aaf9992dea3c87e0bfb4e0a823a5b46fd37bc","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101935764,"name":"ms-rest-js","full_name":"Azure/ms-rest-js","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/ms-rest-js","description":"Runtime for isomorphic javascript libraries generated by Autorest","fork":false,"url":"https://api.github.com/repos/Azure/ms-rest-js","forks_url":"https://api.github.com/repos/Azure/ms-rest-js/forks","keys_url":"https://api.github.com/repos/Azure/ms-rest-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/ms-rest-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/ms-rest-js/teams","hooks_url":"https://api.github.com/repos/Azure/ms-rest-js/hooks","issue_events_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/ms-rest-js/events","assignees_url":"https://api.github.com/repos/Azure/ms-rest-js/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/ms-rest-js/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/ms-rest-js/tags","blobs_url":"https://api.github.com/repos/Azure/ms-rest-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/ms-rest-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/ms-rest-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/ms-rest-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/ms-rest-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/ms-rest-js/languages","stargazers_url":"https://api.github.com/repos/Azure/ms-rest-js/stargazers","contributors_url":"https://api.github.com/repos/Azure/ms-rest-js/contributors","subscribers_url":"https://api.github.com/repos/Azure/ms-rest-js/subscribers","subscription_url":"https://api.github.com/repos/Azure/ms-rest-js/subscription","commits_url":"https://api.github.com/repos/Azure/ms-rest-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/ms-rest-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/ms-rest-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/ms-rest-js/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/ms-rest-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/ms-rest-js/merges","archive_url":"https://api.github.com/repos/Azure/ms-rest-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/ms-rest-js/downloads","issues_url":"https://api.github.com/repos/Azure/ms-rest-js/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/ms-rest-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/ms-rest-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/ms-rest-js/labels{/name}","releases_url":"https://api.github.com/repos/Azure/ms-rest-js/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/ms-rest-js/deployments","created_at":"2017-08-30T22:48:23Z","updated_at":"2018-03-23T09:13:18Z","pushed_at":"2018-03-23T22:06:44Z","git_url":"git://github.com/Azure/ms-rest-js.git","ssh_url":"git@github.com:Azure/ms-rest-js.git","clone_url":"https://github.com/Azure/ms-rest-js.git","svn_url":"https://github.com/Azure/ms-rest-js","homepage":"","size":792,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"18c9155e1ae7d6d93846fe62f2c6153d6ce516b3","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101935764,"name":"ms-rest-js","full_name":"Azure/ms-rest-js","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/ms-rest-js","description":"Runtime for isomorphic javascript libraries generated by Autorest","fork":false,"url":"https://api.github.com/repos/Azure/ms-rest-js","forks_url":"https://api.github.com/repos/Azure/ms-rest-js/forks","keys_url":"https://api.github.com/repos/Azure/ms-rest-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/ms-rest-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/ms-rest-js/teams","hooks_url":"https://api.github.com/repos/Azure/ms-rest-js/hooks","issue_events_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/ms-rest-js/events","assignees_url":"https://api.github.com/repos/Azure/ms-rest-js/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/ms-rest-js/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/ms-rest-js/tags","blobs_url":"https://api.github.com/repos/Azure/ms-rest-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/ms-rest-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/ms-rest-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/ms-rest-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/ms-rest-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/ms-rest-js/languages","stargazers_url":"https://api.github.com/repos/Azure/ms-rest-js/stargazers","contributors_url":"https://api.github.com/repos/Azure/ms-rest-js/contributors","subscribers_url":"https://api.github.com/repos/Azure/ms-rest-js/subscribers","subscription_url":"https://api.github.com/repos/Azure/ms-rest-js/subscription","commits_url":"https://api.github.com/repos/Azure/ms-rest-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/ms-rest-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/ms-rest-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/ms-rest-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/ms-rest-js/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/ms-rest-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/ms-rest-js/merges","archive_url":"https://api.github.com/repos/Azure/ms-rest-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/ms-rest-js/downloads","issues_url":"https://api.github.com/repos/Azure/ms-rest-js/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/ms-rest-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/ms-rest-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/ms-rest-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/ms-rest-js/labels{/name}","releases_url":"https://api.github.com/repos/Azure/ms-rest-js/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/ms-rest-js/deployments","created_at":"2017-08-30T22:48:23Z","updated_at":"2018-03-23T09:13:18Z","pushed_at":"2018-03-23T22:06:44Z","git_url":"git://github.com/Azure/ms-rest-js.git","ssh_url":"git@github.com:Azure/ms-rest-js.git","clone_url":"https://github.com/Azure/ms-rest-js.git","svn_url":"https://github.com/Azure/ms-rest-js","homepage":"","size":792,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18"},"html":{"href":"https://github.com/Azure/ms-rest-js/pull/18"},"issue":{"href":"https://api.github.com/repos/Azure/ms-rest-js/issues/18"},"comments":{"href":"https://api.github.com/repos/Azure/ms-rest-js/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/ms-rest-js/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/ms-rest-js/statuses/5b2aaf9992dea3c87e0bfb4e0a823a5b46fd37bc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RikkiGibson"}}