{"action":"created","comment":{"url":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments/235647608","pull_request_review_id":177559339,"id":235647608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY0NzYwOA==","diff_hunk":"@@ -15,32 +15,24 @@\n  */\n package io.syndesis.server.runtime;\n \n-import java.util.ArrayList;\n-import java.util.List;\n-\n-import static java.util.concurrent.TimeUnit.SECONDS;\n-\n import com.fasterxml.jackson.databind.annotation.JsonDeserialize;\n-\n import io.syndesis.common.model.ListResult;\n import io.syndesis.common.model.connection.ConfigurationProperty;\n import io.syndesis.common.model.connection.Connection;\n import io.syndesis.common.model.connection.Connector;\n-import io.syndesis.server.credential.CredentialFlowState;\n-import io.syndesis.server.credential.CredentialProvider;\n-import io.syndesis.server.credential.CredentialProviderLocator;\n-import io.syndesis.server.credential.Credentials;\n-import io.syndesis.server.credential.OAuth1CredentialFlowState;\n-import io.syndesis.server.credential.OAuth1CredentialProvider;\n+import io.syndesis.server.credential.*;","path":"app/server/runtime/src/test/java/io/syndesis/server/runtime/SetupITCase.java","position":21,"original_position":21,"commit_id":"2c59777d19b24c3e2970e992486ad515e16aac56","original_commit_id":"2c59777d19b24c3e2970e992486ad515e16aac56","user":{"login":"lburgazzoli","id":1868933,"node_id":"MDQ6VXNlcjE4Njg5MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1868933?v=4","gravatar_id":"","url":"https://api.github.com/users/lburgazzoli","html_url":"https://github.com/lburgazzoli","followers_url":"https://api.github.com/users/lburgazzoli/followers","following_url":"https://api.github.com/users/lburgazzoli/following{/other_user}","gists_url":"https://api.github.com/users/lburgazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/lburgazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lburgazzoli/subscriptions","organizations_url":"https://api.github.com/users/lburgazzoli/orgs","repos_url":"https://api.github.com/users/lburgazzoli/repos","events_url":"https://api.github.com/users/lburgazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/lburgazzoli/received_events","type":"User","site_admin":false},"body":"I think in general we do always use full qualified imports.","created_at":"2018-11-22T09:10:47Z","updated_at":"2018-11-22T09:33:45Z","html_url":"https://github.com/syndesisio/syndesis/pull/4129#discussion_r235647608","pull_request_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments/235647608"},"html":{"href":"https://github.com/syndesisio/syndesis/pull/4129#discussion_r235647608"},"pull_request":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129"}}},"pull_request":{"url":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129","id":232789689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzg5Njg5","html_url":"https://github.com/syndesisio/syndesis/pull/4129","diff_url":"https://github.com/syndesisio/syndesis/pull/4129.diff","patch_url":"https://github.com/syndesisio/syndesis/pull/4129.patch","issue_url":"https://api.github.com/repos/syndesisio/syndesis/issues/4129","number":4129,"state":"open","locked":false,"title":"Google sheets connector basics","user":{"login":"christophd","id":195264,"node_id":"MDQ6VXNlcjE5NTI2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/195264?v=4","gravatar_id":"","url":"https://api.github.com/users/christophd","html_url":"https://github.com/christophd","followers_url":"https://api.github.com/users/christophd/followers","following_url":"https://api.github.com/users/christophd/following{/other_user}","gists_url":"https://api.github.com/users/christophd/gists{/gist_id}","starred_url":"https://api.github.com/users/christophd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophd/subscriptions","organizations_url":"https://api.github.com/users/christophd/orgs","repos_url":"https://api.github.com/users/christophd/repos","events_url":"https://api.github.com/users/christophd/events{/privacy}","received_events_url":"https://api.github.com/users/christophd/received_events","type":"User","site_admin":false},"body":"This PR contains the basic implementation of the google-sheets connector.\r\n\r\nIncluded and ready to use:\r\n- google-sheets & google-sheets-stream Camel component (directly added to connector for convenience reasons, needs to be removed once component is available in camel-fuse and/or upstream project) \r\n- Create Spreadsheets connection\r\n- Update/append Sheet values connection\r\n- Periodic get Spreadsheet connection\r\n- Periodic get Sheet values connection\r\n\r\nWork in progress:\r\n- Optimize sheet values input/output data structure for Atlasmap data mapping (currently `List<List<Object>>` serialized/deserialized from/to `String` values)\r\n\r\nToDo:\r\n- Get cell changed events (missing watch operation in Google Sheets API)\r\n- Pivot table operations\r\n- Charts","created_at":"2018-11-21T20:26:56Z","updated_at":"2018-11-22T09:33:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e44493370176b3cfac3fa99e8b5460dff73f4675","assignee":{"login":"lburgazzoli","id":1868933,"node_id":"MDQ6VXNlcjE4Njg5MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1868933?v=4","gravatar_id":"","url":"https://api.github.com/users/lburgazzoli","html_url":"https://github.com/lburgazzoli","followers_url":"https://api.github.com/users/lburgazzoli/followers","following_url":"https://api.github.com/users/lburgazzoli/following{/other_user}","gists_url":"https://api.github.com/users/lburgazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/lburgazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lburgazzoli/subscriptions","organizations_url":"https://api.github.com/users/lburgazzoli/orgs","repos_url":"https://api.github.com/users/lburgazzoli/repos","events_url":"https://api.github.com/users/lburgazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/lburgazzoli/received_events","type":"User","site_admin":false},"assignees":[{"login":"lburgazzoli","id":1868933,"node_id":"MDQ6VXNlcjE4Njg5MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1868933?v=4","gravatar_id":"","url":"https://api.github.com/users/lburgazzoli","html_url":"https://github.com/lburgazzoli","followers_url":"https://api.github.com/users/lburgazzoli/followers","following_url":"https://api.github.com/users/lburgazzoli/following{/other_user}","gists_url":"https://api.github.com/users/lburgazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/lburgazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lburgazzoli/subscriptions","organizations_url":"https://api.github.com/users/lburgazzoli/orgs","repos_url":"https://api.github.com/users/lburgazzoli/repos","events_url":"https://api.github.com/users/lburgazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/lburgazzoli/received_events","type":"User","site_admin":false},{"login":"oscerd","id":5106647,"node_id":"MDQ6VXNlcjUxMDY2NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5106647?v=4","gravatar_id":"","url":"https://api.github.com/users/oscerd","html_url":"https://github.com/oscerd","followers_url":"https://api.github.com/users/oscerd/followers","following_url":"https://api.github.com/users/oscerd/following{/other_user}","gists_url":"https://api.github.com/users/oscerd/gists{/gist_id}","starred_url":"https://api.github.com/users/oscerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscerd/subscriptions","organizations_url":"https://api.github.com/users/oscerd/orgs","repos_url":"https://api.github.com/users/oscerd/repos","events_url":"https://api.github.com/users/oscerd/events{/privacy}","received_events_url":"https://api.github.com/users/oscerd/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"oscerd","id":5106647,"node_id":"MDQ6VXNlcjUxMDY2NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5106647?v=4","gravatar_id":"","url":"https://api.github.com/users/oscerd","html_url":"https://github.com/oscerd","followers_url":"https://api.github.com/users/oscerd/followers","following_url":"https://api.github.com/users/oscerd/following{/other_user}","gists_url":"https://api.github.com/users/oscerd/gists{/gist_id}","starred_url":"https://api.github.com/users/oscerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscerd/subscriptions","organizations_url":"https://api.github.com/users/oscerd/orgs","repos_url":"https://api.github.com/users/oscerd/repos","events_url":"https://api.github.com/users/oscerd/events{/privacy}","received_events_url":"https://api.github.com/users/oscerd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":751428707,"node_id":"MDU6TGFiZWw3NTE0Mjg3MDc=","url":"https://api.github.com/repos/syndesisio/syndesis/labels/group/connector","name":"group/connector","color":"BCE8F5","default":false},{"id":875913439,"node_id":"MDU6TGFiZWw4NzU5MTM0Mzk=","url":"https://api.github.com/repos/syndesisio/syndesis/labels/pr/review-requested","name":"pr/review-requested","color":"F5B041","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129/commits","review_comments_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129/comments","review_comment_url":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/issues/4129/comments","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/2c59777d19b24c3e2970e992486ad515e16aac56","head":{"label":"christophd:issue/3620/google-sheets-connector","ref":"issue/3620/google-sheets-connector","sha":"2c59777d19b24c3e2970e992486ad515e16aac56","user":{"login":"christophd","id":195264,"node_id":"MDQ6VXNlcjE5NTI2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/195264?v=4","gravatar_id":"","url":"https://api.github.com/users/christophd","html_url":"https://github.com/christophd","followers_url":"https://api.github.com/users/christophd/followers","following_url":"https://api.github.com/users/christophd/following{/other_user}","gists_url":"https://api.github.com/users/christophd/gists{/gist_id}","starred_url":"https://api.github.com/users/christophd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophd/subscriptions","organizations_url":"https://api.github.com/users/christophd/orgs","repos_url":"https://api.github.com/users/christophd/repos","events_url":"https://api.github.com/users/christophd/events{/privacy}","received_events_url":"https://api.github.com/users/christophd/received_events","type":"User","site_admin":false},"repo":{"id":155892138,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4OTIxMzg=","name":"syndesis","full_name":"christophd/syndesis","private":false,"owner":{"login":"christophd","id":195264,"node_id":"MDQ6VXNlcjE5NTI2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/195264?v=4","gravatar_id":"","url":"https://api.github.com/users/christophd","html_url":"https://github.com/christophd","followers_url":"https://api.github.com/users/christophd/followers","following_url":"https://api.github.com/users/christophd/following{/other_user}","gists_url":"https://api.github.com/users/christophd/gists{/gist_id}","starred_url":"https://api.github.com/users/christophd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophd/subscriptions","organizations_url":"https://api.github.com/users/christophd/orgs","repos_url":"https://api.github.com/users/christophd/repos","events_url":"https://api.github.com/users/christophd/events{/privacy}","received_events_url":"https://api.github.com/users/christophd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/christophd/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":true,"url":"https://api.github.com/repos/christophd/syndesis","forks_url":"https://api.github.com/repos/christophd/syndesis/forks","keys_url":"https://api.github.com/repos/christophd/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christophd/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christophd/syndesis/teams","hooks_url":"https://api.github.com/repos/christophd/syndesis/hooks","issue_events_url":"https://api.github.com/repos/christophd/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/christophd/syndesis/events","assignees_url":"https://api.github.com/repos/christophd/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/christophd/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/christophd/syndesis/tags","blobs_url":"https://api.github.com/repos/christophd/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christophd/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christophd/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/christophd/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christophd/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/christophd/syndesis/languages","stargazers_url":"https://api.github.com/repos/christophd/syndesis/stargazers","contributors_url":"https://api.github.com/repos/christophd/syndesis/contributors","subscribers_url":"https://api.github.com/repos/christophd/syndesis/subscribers","subscription_url":"https://api.github.com/repos/christophd/syndesis/subscription","commits_url":"https://api.github.com/repos/christophd/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/christophd/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/christophd/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/christophd/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/christophd/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/christophd/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christophd/syndesis/merges","archive_url":"https://api.github.com/repos/christophd/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christophd/syndesis/downloads","issues_url":"https://api.github.com/repos/christophd/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/christophd/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/christophd/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/christophd/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christophd/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/christophd/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/christophd/syndesis/deployments","created_at":"2018-11-02T16:21:20Z","updated_at":"2018-11-21T16:37:34Z","pushed_at":"2018-11-21T20:11:25Z","git_url":"git://github.com/christophd/syndesis.git","ssh_url":"git@github.com:christophd/syndesis.git","clone_url":"https://github.com/christophd/syndesis.git","svn_url":"https://github.com/christophd/syndesis","homepage":null,"size":75436,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syndesisio:master","ref":"master","sha":"d885dc5b2dd00171183885c3fdf5e3b29b640a22","user":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"repo":{"id":105563335,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1NjMzMzU=","name":"syndesis","full_name":"syndesisio/syndesis","private":false,"owner":{"login":"syndesisio","id":23079786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDc5Nzg2","avatar_url":"https://avatars3.githubusercontent.com/u/23079786?v=4","gravatar_id":"","url":"https://api.github.com/users/syndesisio","html_url":"https://github.com/syndesisio","followers_url":"https://api.github.com/users/syndesisio/followers","following_url":"https://api.github.com/users/syndesisio/following{/other_user}","gists_url":"https://api.github.com/users/syndesisio/gists{/gist_id}","starred_url":"https://api.github.com/users/syndesisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndesisio/subscriptions","organizations_url":"https://api.github.com/users/syndesisio/orgs","repos_url":"https://api.github.com/users/syndesisio/repos","events_url":"https://api.github.com/users/syndesisio/events{/privacy}","received_events_url":"https://api.github.com/users/syndesisio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/syndesisio/syndesis","description":"A flexible, customizable, open source platform that provides core integration capabilities as a service.","fork":false,"url":"https://api.github.com/repos/syndesisio/syndesis","forks_url":"https://api.github.com/repos/syndesisio/syndesis/forks","keys_url":"https://api.github.com/repos/syndesisio/syndesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syndesisio/syndesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syndesisio/syndesis/teams","hooks_url":"https://api.github.com/repos/syndesisio/syndesis/hooks","issue_events_url":"https://api.github.com/repos/syndesisio/syndesis/issues/events{/number}","events_url":"https://api.github.com/repos/syndesisio/syndesis/events","assignees_url":"https://api.github.com/repos/syndesisio/syndesis/assignees{/user}","branches_url":"https://api.github.com/repos/syndesisio/syndesis/branches{/branch}","tags_url":"https://api.github.com/repos/syndesisio/syndesis/tags","blobs_url":"https://api.github.com/repos/syndesisio/syndesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syndesisio/syndesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syndesisio/syndesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/syndesisio/syndesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syndesisio/syndesis/statuses/{sha}","languages_url":"https://api.github.com/repos/syndesisio/syndesis/languages","stargazers_url":"https://api.github.com/repos/syndesisio/syndesis/stargazers","contributors_url":"https://api.github.com/repos/syndesisio/syndesis/contributors","subscribers_url":"https://api.github.com/repos/syndesisio/syndesis/subscribers","subscription_url":"https://api.github.com/repos/syndesisio/syndesis/subscription","commits_url":"https://api.github.com/repos/syndesisio/syndesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/syndesisio/syndesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/syndesisio/syndesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/syndesisio/syndesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/syndesisio/syndesis/contents/{+path}","compare_url":"https://api.github.com/repos/syndesisio/syndesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syndesisio/syndesis/merges","archive_url":"https://api.github.com/repos/syndesisio/syndesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syndesisio/syndesis/downloads","issues_url":"https://api.github.com/repos/syndesisio/syndesis/issues{/number}","pulls_url":"https://api.github.com/repos/syndesisio/syndesis/pulls{/number}","milestones_url":"https://api.github.com/repos/syndesisio/syndesis/milestones{/number}","notifications_url":"https://api.github.com/repos/syndesisio/syndesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syndesisio/syndesis/labels{/name}","releases_url":"https://api.github.com/repos/syndesisio/syndesis/releases{/id}","deployments_url":"https://api.github.com/repos/syndesisio/syndesis/deployments","created_at":"2017-10-02T17:26:55Z","updated_at":"2018-11-22T09:18:11Z","pushed_at":"2018-11-22T09:18:59Z","git_url":"git://github.com/syndesisio/syndesis.git","ssh_url":"git@github.com:syndesisio/syndesis.git","clone_url":"https://github.com/syndesisio/syndesis.git","svn_url":"https://github.com/syndesisio/syndesis","homepage":null,"size":75828,"stargazers_count":104,"watchers_count":104,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":394,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":92,"open_issues":394,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129"},"html":{"href":"https://github.com/syndesisio/syndesis/pull/4129"},"issue":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/4129"},"comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/issues/4129/comments"},"review_comments":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129/comments"},"review_comment":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syndesisio/syndesis/pulls/4129/commits"},"statuses":{"href":"https://api.github.com/repos/syndesisio/syndesis/statuses/2c59777d19b24c3e2970e992486ad515e16aac56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lburgazzoli"}}