{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/comments/215000916","pull_request_review_id":152172022,"id":215000916,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTAwMDkxNg==","diff_hunk":"@@ -0,0 +1,427 @@\n+import React from 'react';","path":"app/javascript/react/screens/App/Overview/screens/PlanWizard/components/PlanWizardInstancePropertiesStep/components/PlanWizardInstancePropertiesStepTable.js","position":1,"original_position":1,"commit_id":"fd6a3aa5573821ab1f148bd93ad7e1f08ae03395","original_commit_id":"fd6a3aa5573821ab1f148bd93ad7e1f08ae03395","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"File `PlanWizardInstancePropertiesStepTable.js` has 391 lines of code (exceeds 250 allowed). Consider refactoring.","created_at":"2018-09-04T17:27:49Z","updated_at":"2018-09-04T17:27:49Z","html_url":"https://github.com/ManageIQ/manageiq-v2v/pull/562#discussion_r215000916","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/comments/215000916"},"html":{"href":"https://github.com/ManageIQ/manageiq-v2v/pull/562#discussion_r215000916"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562","id":207407047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDA3MDQ3","html_url":"https://github.com/ManageIQ/manageiq-v2v/pull/562","diff_url":"https://github.com/ManageIQ/manageiq-v2v/pull/562.diff","patch_url":"https://github.com/ManageIQ/manageiq-v2v/pull/562.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/562","number":562,"state":"open","locked":false,"title":"[#546][2 of (3)?] OSP Support: Add editable Instance Properties table to Plan Wizard","user":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"body":"Requires https://github.com/ManageIQ/manageiq-api/pull/455 to be merged.\r\n\r\nThis PR picks up where https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547 left off.\r\n\r\nThis adds UI pieces for #546, as much as we can with the current state of the API.\r\n\r\n- [x] Copy and trim down the boilerplate from one of the other tables to create the new table.\r\n- [x] Add selected VMs to the table\r\n- [x] Add action creators for security group and flavor\r\n- [x] Add reducer for security group and flavor\r\n- [x] Add new columns to the table for group and flavor\r\n- [x] Make columns editable, add dropdowns in edit mode\r\n- [x] CSS fix: the confirm buttons are not positioned properly... pf-react CSS not loaded??\r\n- [x] CSS fix: the Instance Properties and Advanced Options step titles look bad when they render on 2 lines\r\n\r\nThis PR does not connect the new table to redux-form, since we're not sure what the API will require for these properties when we POST them. The actions are intentionally left as stubs, so edits will not actually save on confirmation until that is implemented in a follow-up PR.\r\n\r\n**Note:** This PR also pulls in the patternfly-react `TabhleInlineEditRow` and associated components, in order to locally fix a bug with the confirm buttons positioning when used inside a Modal (https://github.com/patternfly/patternfly-react/issues/535). Those files need not be reviewed. \r\n\r\n![screenshot 2018-08-17 15 33 27](https://user-images.githubusercontent.com/811963/44285818-db892f00-a234-11e8-8e31-47ec344615d9.png)\r\n","created_at":"2018-08-09T18:40:41Z","updated_at":"2018-09-04T17:27:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54d22b008c68052e20e60761545a644ea43e2ea2","assignee":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"assignees":[{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1037033936,"node_id":"MDU6TGFiZWwxMDM3MDMzOTM2","url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/labels/Sprint%2013","name":"Sprint 13","color":"c69437","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/562/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/statuses/fd6a3aa5573821ab1f148bd93ad7e1f08ae03395","head":{"label":"mturley:osp-instance-properties-table","ref":"osp-instance-properties-table","sha":"fd6a3aa5573821ab1f148bd93ad7e1f08ae03395","user":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"repo":{"id":120580525,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA1ODA1MjU=","name":"manageiq-v2v","full_name":"mturley/manageiq-v2v","owner":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mturley/manageiq-v2v","description":"v2v React UI plugin for mIQ","fork":true,"url":"https://api.github.com/repos/mturley/manageiq-v2v","forks_url":"https://api.github.com/repos/mturley/manageiq-v2v/forks","keys_url":"https://api.github.com/repos/mturley/manageiq-v2v/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mturley/manageiq-v2v/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mturley/manageiq-v2v/teams","hooks_url":"https://api.github.com/repos/mturley/manageiq-v2v/hooks","issue_events_url":"https://api.github.com/repos/mturley/manageiq-v2v/issues/events{/number}","events_url":"https://api.github.com/repos/mturley/manageiq-v2v/events","assignees_url":"https://api.github.com/repos/mturley/manageiq-v2v/assignees{/user}","branches_url":"https://api.github.com/repos/mturley/manageiq-v2v/branches{/branch}","tags_url":"https://api.github.com/repos/mturley/manageiq-v2v/tags","blobs_url":"https://api.github.com/repos/mturley/manageiq-v2v/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mturley/manageiq-v2v/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mturley/manageiq-v2v/git/refs{/sha}","trees_url":"https://api.github.com/repos/mturley/manageiq-v2v/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mturley/manageiq-v2v/statuses/{sha}","languages_url":"https://api.github.com/repos/mturley/manageiq-v2v/languages","stargazers_url":"https://api.github.com/repos/mturley/manageiq-v2v/stargazers","contributors_url":"https://api.github.com/repos/mturley/manageiq-v2v/contributors","subscribers_url":"https://api.github.com/repos/mturley/manageiq-v2v/subscribers","subscription_url":"https://api.github.com/repos/mturley/manageiq-v2v/subscription","commits_url":"https://api.github.com/repos/mturley/manageiq-v2v/commits{/sha}","git_commits_url":"https://api.github.com/repos/mturley/manageiq-v2v/git/commits{/sha}","comments_url":"https://api.github.com/repos/mturley/manageiq-v2v/comments{/number}","issue_comment_url":"https://api.github.com/repos/mturley/manageiq-v2v/issues/comments{/number}","contents_url":"https://api.github.com/repos/mturley/manageiq-v2v/contents/{+path}","compare_url":"https://api.github.com/repos/mturley/manageiq-v2v/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mturley/manageiq-v2v/merges","archive_url":"https://api.github.com/repos/mturley/manageiq-v2v/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mturley/manageiq-v2v/downloads","issues_url":"https://api.github.com/repos/mturley/manageiq-v2v/issues{/number}","pulls_url":"https://api.github.com/repos/mturley/manageiq-v2v/pulls{/number}","milestones_url":"https://api.github.com/repos/mturley/manageiq-v2v/milestones{/number}","notifications_url":"https://api.github.com/repos/mturley/manageiq-v2v/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mturley/manageiq-v2v/labels{/name}","releases_url":"https://api.github.com/repos/mturley/manageiq-v2v/releases{/id}","deployments_url":"https://api.github.com/repos/mturley/manageiq-v2v/deployments","created_at":"2018-02-07T07:39:04Z","updated_at":"2018-08-13T14:26:26Z","pushed_at":"2018-09-04T17:27:19Z","git_url":"git://github.com/mturley/manageiq-v2v.git","ssh_url":"git@github.com:mturley/manageiq-v2v.git","clone_url":"https://github.com/mturley/manageiq-v2v.git","svn_url":"https://github.com/mturley/manageiq-v2v","homepage":null,"size":18397,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"ee94bdd8df248d1da54d8283cd9ec09ec87a73f2","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":118279623,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyNzk2MjM=","name":"manageiq-v2v","full_name":"ManageIQ/manageiq-v2v","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-v2v","description":"ManageIQ plugin for v2v transformations","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-v2v","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-v2v/deployments","created_at":"2018-01-20T20:50:31Z","updated_at":"2018-08-31T13:26:03Z","pushed_at":"2018-09-04T17:27:21Z","git_url":"git://github.com/ManageIQ/manageiq-v2v.git","ssh_url":"git@github.com:ManageIQ/manageiq-v2v.git","clone_url":"https://github.com/ManageIQ/manageiq-v2v.git","svn_url":"https://github.com/ManageIQ/manageiq-v2v","homepage":"","size":18440,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":62,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562"},"html":{"href":"https://github.com/ManageIQ/manageiq-v2v/pull/562"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/562"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-v2v/statuses/fd6a3aa5573821ab1f148bd93ad7e1f08ae03395"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codeclimate"}}