{"action":"opened","number":1722,"pull_request":{"url":"https://api.github.com/repos/ocaml/dune/pulls/1722","id":241564975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTY0OTc1","html_url":"https://github.com/ocaml/dune/pull/1722","diff_url":"https://github.com/ocaml/dune/pull/1722.diff","patch_url":"https://github.com/ocaml/dune/pull/1722.patch","issue_url":"https://api.github.com/repos/ocaml/dune/issues/1722","number":1722,"state":"open","locked":false,"title":"Run `dune build @install` before `dune install` in Makefile","user":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shon Feder <shon.feder@gmail.com>\r\n\r\nWithout this change, I am getting the following on `HEAD`:\r\n\r\n```\r\n$ make install\r\n./_build_bootstrap/default/bin/main_dune.exe install   dune\r\nThe following <package>.install are missing:\r\n- _build/default/dune.install\r\nYou need to run: dune build @install\r\nmake: *** [install] Error 1\r\n```\r\n\r\nwhen trying to install following the instructions in [HACKING.md](https://github.com/ocaml/dune/blob/master/HACKING.md).","created_at":"2018-12-31T13:37:05Z","updated_at":"2018-12-31T13:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/dune/pulls/1722/commits","review_comments_url":"https://api.github.com/repos/ocaml/dune/pulls/1722/comments","review_comment_url":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/dune/issues/1722/comments","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/061ccfeecb568d791a185ec17df152abbe42e4f8","head":{"label":"shonfeder:makefile-run-dune-build-install-before-dune-install","ref":"makefile-run-dune-build-install-before-dune-install","sha":"061ccfeecb568d791a185ec17df152abbe42e4f8","user":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"repo":{"id":96554353,"node_id":"MDEwOlJlcG9zaXRvcnk5NjU1NDM1Mw==","name":"dune","full_name":"shonfeder/dune","private":false,"owner":{"login":"shonfeder","id":19820422,"node_id":"MDQ6VXNlcjE5ODIwNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/19820422?v=4","gravatar_id":"","url":"https://api.github.com/users/shonfeder","html_url":"https://github.com/shonfeder","followers_url":"https://api.github.com/users/shonfeder/followers","following_url":"https://api.github.com/users/shonfeder/following{/other_user}","gists_url":"https://api.github.com/users/shonfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/shonfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shonfeder/subscriptions","organizations_url":"https://api.github.com/users/shonfeder/orgs","repos_url":"https://api.github.com/users/shonfeder/repos","events_url":"https://api.github.com/users/shonfeder/events{/privacy}","received_events_url":"https://api.github.com/users/shonfeder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shonfeder/dune","description":"A composable build system for OCaml","fork":true,"url":"https://api.github.com/repos/shonfeder/dune","forks_url":"https://api.github.com/repos/shonfeder/dune/forks","keys_url":"https://api.github.com/repos/shonfeder/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shonfeder/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shonfeder/dune/teams","hooks_url":"https://api.github.com/repos/shonfeder/dune/hooks","issue_events_url":"https://api.github.com/repos/shonfeder/dune/issues/events{/number}","events_url":"https://api.github.com/repos/shonfeder/dune/events","assignees_url":"https://api.github.com/repos/shonfeder/dune/assignees{/user}","branches_url":"https://api.github.com/repos/shonfeder/dune/branches{/branch}","tags_url":"https://api.github.com/repos/shonfeder/dune/tags","blobs_url":"https://api.github.com/repos/shonfeder/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shonfeder/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shonfeder/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/shonfeder/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shonfeder/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/shonfeder/dune/languages","stargazers_url":"https://api.github.com/repos/shonfeder/dune/stargazers","contributors_url":"https://api.github.com/repos/shonfeder/dune/contributors","subscribers_url":"https://api.github.com/repos/shonfeder/dune/subscribers","subscription_url":"https://api.github.com/repos/shonfeder/dune/subscription","commits_url":"https://api.github.com/repos/shonfeder/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/shonfeder/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/shonfeder/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/shonfeder/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/shonfeder/dune/contents/{+path}","compare_url":"https://api.github.com/repos/shonfeder/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shonfeder/dune/merges","archive_url":"https://api.github.com/repos/shonfeder/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shonfeder/dune/downloads","issues_url":"https://api.github.com/repos/shonfeder/dune/issues{/number}","pulls_url":"https://api.github.com/repos/shonfeder/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/shonfeder/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/shonfeder/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shonfeder/dune/labels{/name}","releases_url":"https://api.github.com/repos/shonfeder/dune/releases{/id}","deployments_url":"https://api.github.com/repos/shonfeder/dune/deployments","created_at":"2017-07-07T15:57:51Z","updated_at":"2018-09-15T12:18:22Z","pushed_at":"2018-12-31T13:34:36Z","git_url":"git://github.com/shonfeder/dune.git","ssh_url":"git@github.com:shonfeder/dune.git","clone_url":"https://github.com/shonfeder/dune.git","svn_url":"https://github.com/shonfeder/dune","homepage":"","size":6977,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"da3f9d0cdcf835c3cb00986cd0c832a5b31198b9","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":72368050,"node_id":"MDEwOlJlcG9zaXRvcnk3MjM2ODA1MA==","name":"dune","full_name":"ocaml/dune","private":false,"owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ocaml/dune","description":"A composable build system for OCaml.","fork":false,"url":"https://api.github.com/repos/ocaml/dune","forks_url":"https://api.github.com/repos/ocaml/dune/forks","keys_url":"https://api.github.com/repos/ocaml/dune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/dune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/dune/teams","hooks_url":"https://api.github.com/repos/ocaml/dune/hooks","issue_events_url":"https://api.github.com/repos/ocaml/dune/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/dune/events","assignees_url":"https://api.github.com/repos/ocaml/dune/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/dune/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/dune/tags","blobs_url":"https://api.github.com/repos/ocaml/dune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/dune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/dune/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/dune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/dune/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/dune/languages","stargazers_url":"https://api.github.com/repos/ocaml/dune/stargazers","contributors_url":"https://api.github.com/repos/ocaml/dune/contributors","subscribers_url":"https://api.github.com/repos/ocaml/dune/subscribers","subscription_url":"https://api.github.com/repos/ocaml/dune/subscription","commits_url":"https://api.github.com/repos/ocaml/dune/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/dune/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/dune/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/dune/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/dune/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/dune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/dune/merges","archive_url":"https://api.github.com/repos/ocaml/dune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/dune/downloads","issues_url":"https://api.github.com/repos/ocaml/dune/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/dune/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/dune/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/dune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/dune/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/dune/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/dune/deployments","created_at":"2016-10-30T18:42:23Z","updated_at":"2018-12-30T19:42:21Z","pushed_at":"2018-12-31T12:39:45Z","git_url":"git://github.com/ocaml/dune.git","ssh_url":"git@github.com:ocaml/dune.git","clone_url":"https://github.com/ocaml/dune.git","svn_url":"https://github.com/ocaml/dune","homepage":"https://dune.build/","size":8286,"stargazers_count":574,"watchers_count":574,"language":"OCaml","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":239,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":123,"open_issues":239,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/dune/pulls/1722"},"html":{"href":"https://github.com/ocaml/dune/pull/1722"},"issue":{"href":"https://api.github.com/repos/ocaml/dune/issues/1722"},"comments":{"href":"https://api.github.com/repos/ocaml/dune/issues/1722/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/dune/pulls/1722/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/dune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/dune/pulls/1722/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/dune/statuses/061ccfeecb568d791a185ec17df152abbe42e4f8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"shonfeder"}}