{"action":"created","comment":{"url":"https://api.github.com/repos/gocd/gocd/pulls/comments/195970978","pull_request_review_id":129434667,"id":195970978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk3MDk3OA==","diff_hunk":"@@ -75,9 +77,13 @@ public void initialize() throws DuplicateMetricReporting, DuplicateDataSharingSe\n         }\n \n         if (existingUsageStatisticsReporting == null) {\n-            UsageStatisticsReporting usageStatisticsReporting = new UsageStatisticsReporting(UUID.randomUUID().toString(), new Date());\n+            UsageStatisticsReporting usageStatisticsReporting = new UsageStatisticsReporting(UUID.randomUUID().toString(), dataSharingServerUrl, new Date());\n             updateUsageStatisticsReporting(usageStatisticsReporting, new HttpLocalizedOperationResult());\n+        } else if (!dataSharingServerUrl.equals(existingUsageStatisticsReporting.getDataSharingServerUrl())) {","path":"server/src/main/java/com/thoughtworks/go/server/service/DataSharingService.java","position":16,"original_position":16,"commit_id":"27b0e4a29b8c4b6e8530855395f8e3211bbcd8ed","original_commit_id":"27b0e4a29b8c4b6e8530855395f8e3211bbcd8ed","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"body":"Why store the url in db? What benefit does it bring? Its just a config. If the `GO_DATA_SHARING_SERVER_URL ` is changed to something else, we should start reporting to that instead","created_at":"2018-06-18T06:02:54Z","updated_at":"2018-06-18T06:02:55Z","html_url":"https://github.com/gocd/gocd/pull/4847#discussion_r195970978","pull_request_url":"https://api.github.com/repos/gocd/gocd/pulls/4847","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/195970978"},"html":{"href":"https://github.com/gocd/gocd/pull/4847#discussion_r195970978"},"pull_request":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4847"}},"in_reply_to_id":195395559},"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/4847","id":194868373,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODY4Mzcz","html_url":"https://github.com/gocd/gocd/pull/4847","diff_url":"https://github.com/gocd/gocd/pull/4847.diff","patch_url":"https://github.com/gocd/gocd/pull/4847.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/4847","number":4847,"state":"open","locked":false,"title":"Add data_sharing_server_url field in usage data reporting API","user":{"login":"GaneshSPatil","id":15275847,"node_id":"MDQ6VXNlcjE1Mjc1ODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/15275847?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshSPatil","html_url":"https://github.com/GaneshSPatil","followers_url":"https://api.github.com/users/GaneshSPatil/followers","following_url":"https://api.github.com/users/GaneshSPatil/following{/other_user}","gists_url":"https://api.github.com/users/GaneshSPatil/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshSPatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshSPatil/subscriptions","organizations_url":"https://api.github.com/users/GaneshSPatil/orgs","repos_url":"https://api.github.com/users/GaneshSPatil/repos","events_url":"https://api.github.com/users/GaneshSPatil/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshSPatil/received_events","type":"User","site_admin":false},"body":"* data_sharing_server_url is required by the browser clients to send the server usage information\r\n* Pass along data_sharing_server_url along with the last_reported_time in data reporting API\r\n\r\n","created_at":"2018-06-14T11:55:20Z","updated_at":"2018-06-18T06:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa8fba362256fa8b8146659734802e2ea6f6235a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/4847/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/4847/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/4847/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/27b0e4a29b8c4b6e8530855395f8e3211bbcd8ed","head":{"label":"GaneshSPatil:add-data-sharing-server-url","ref":"add-data-sharing-server-url","sha":"27b0e4a29b8c4b6e8530855395f8e3211bbcd8ed","user":{"login":"GaneshSPatil","id":15275847,"node_id":"MDQ6VXNlcjE1Mjc1ODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/15275847?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshSPatil","html_url":"https://github.com/GaneshSPatil","followers_url":"https://api.github.com/users/GaneshSPatil/followers","following_url":"https://api.github.com/users/GaneshSPatil/following{/other_user}","gists_url":"https://api.github.com/users/GaneshSPatil/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshSPatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshSPatil/subscriptions","organizations_url":"https://api.github.com/users/GaneshSPatil/orgs","repos_url":"https://api.github.com/users/GaneshSPatil/repos","events_url":"https://api.github.com/users/GaneshSPatil/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshSPatil/received_events","type":"User","site_admin":false},"repo":{"id":55779858,"node_id":"MDEwOlJlcG9zaXRvcnk1NTc3OTg1OA==","name":"gocd","full_name":"GaneshSPatil/gocd","owner":{"login":"GaneshSPatil","id":15275847,"node_id":"MDQ6VXNlcjE1Mjc1ODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/15275847?v=4","gravatar_id":"","url":"https://api.github.com/users/GaneshSPatil","html_url":"https://github.com/GaneshSPatil","followers_url":"https://api.github.com/users/GaneshSPatil/followers","following_url":"https://api.github.com/users/GaneshSPatil/following{/other_user}","gists_url":"https://api.github.com/users/GaneshSPatil/gists{/gist_id}","starred_url":"https://api.github.com/users/GaneshSPatil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaneshSPatil/subscriptions","organizations_url":"https://api.github.com/users/GaneshSPatil/orgs","repos_url":"https://api.github.com/users/GaneshSPatil/repos","events_url":"https://api.github.com/users/GaneshSPatil/events{/privacy}","received_events_url":"https://api.github.com/users/GaneshSPatil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaneshSPatil/gocd","description":"Main repository for Go Continuous Delivery","fork":true,"url":"https://api.github.com/repos/GaneshSPatil/gocd","forks_url":"https://api.github.com/repos/GaneshSPatil/gocd/forks","keys_url":"https://api.github.com/repos/GaneshSPatil/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaneshSPatil/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaneshSPatil/gocd/teams","hooks_url":"https://api.github.com/repos/GaneshSPatil/gocd/hooks","issue_events_url":"https://api.github.com/repos/GaneshSPatil/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/GaneshSPatil/gocd/events","assignees_url":"https://api.github.com/repos/GaneshSPatil/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/GaneshSPatil/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/GaneshSPatil/gocd/tags","blobs_url":"https://api.github.com/repos/GaneshSPatil/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaneshSPatil/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaneshSPatil/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaneshSPatil/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaneshSPatil/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/GaneshSPatil/gocd/languages","stargazers_url":"https://api.github.com/repos/GaneshSPatil/gocd/stargazers","contributors_url":"https://api.github.com/repos/GaneshSPatil/gocd/contributors","subscribers_url":"https://api.github.com/repos/GaneshSPatil/gocd/subscribers","subscription_url":"https://api.github.com/repos/GaneshSPatil/gocd/subscription","commits_url":"https://api.github.com/repos/GaneshSPatil/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaneshSPatil/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaneshSPatil/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaneshSPatil/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaneshSPatil/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/GaneshSPatil/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaneshSPatil/gocd/merges","archive_url":"https://api.github.com/repos/GaneshSPatil/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaneshSPatil/gocd/downloads","issues_url":"https://api.github.com/repos/GaneshSPatil/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/GaneshSPatil/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/GaneshSPatil/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/GaneshSPatil/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaneshSPatil/gocd/labels{/name}","releases_url":"https://api.github.com/repos/GaneshSPatil/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/GaneshSPatil/gocd/deployments","created_at":"2016-04-08T13:09:45Z","updated_at":"2018-06-15T06:43:19Z","pushed_at":"2018-06-15T06:43:17Z","git_url":"git://github.com/GaneshSPatil/gocd.git","ssh_url":"git@github.com:GaneshSPatil/gocd.git","clone_url":"https://github.com/GaneshSPatil/gocd.git","svn_url":"https://github.com/GaneshSPatil/gocd","homepage":"https://go.cd","size":265084,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"3b1fdb9d50a2dd27d830514fab9f3952fa13a3bf","user":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NTUzNA==","name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for GoCD - Continuous Delivery server","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/gocd/gocd/deployments","created_at":"2013-12-13T05:26:16Z","updated_at":"2018-06-17T14:40:14Z","pushed_at":"2018-06-18T05:13:47Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":"https://www.gocd.org","size":264607,"stargazers_count":4200,"watchers_count":4200,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":712,"mirror_url":null,"archived":false,"open_issues_count":829,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":712,"open_issues":829,"watchers":4200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4847"},"html":{"href":"https://github.com/gocd/gocd/pull/4847"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/4847"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/4847/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4847/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4847/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/27b0e4a29b8c4b6e8530855395f8e3211bbcd8ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jyotisingh"}}