{"action":"created","issue":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1474","repository_url":"https://api.github.com/repos/postmarketOS/pmbootstrap","labels_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1474/labels{/name}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1474/comments","events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1474/events","html_url":"https://github.com/postmarketOS/pmbootstrap/pull/1474","id":320994572,"number":1474,"title":"Install the \"device-aaa-bbb-kernel-XXX\" package instead of the \"linux-postmarketos-XXX\" to also install the related depends","user":{"login":"drebrez","id":1611547,"avatar_url":"https://avatars0.githubusercontent.com/u/1611547?v=4","gravatar_id":"","url":"https://api.github.com/users/drebrez","html_url":"https://github.com/drebrez","followers_url":"https://api.github.com/users/drebrez/followers","following_url":"https://api.github.com/users/drebrez/following{/other_user}","gists_url":"https://api.github.com/users/drebrez/gists{/gist_id}","starred_url":"https://api.github.com/users/drebrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebrez/subscriptions","organizations_url":"https://api.github.com/users/drebrez/orgs","repos_url":"https://api.github.com/users/drebrez/repos","events_url":"https://api.github.com/users/drebrez/events{/privacy}","received_events_url":"https://api.github.com/users/drebrez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-07T23:37:38Z","updated_at":"2018-05-08T00:35:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1474","html_url":"https://github.com/postmarketOS/pmbootstrap/pull/1474","diff_url":"https://github.com/postmarketOS/pmbootstrap/pull/1474.diff","patch_url":"https://github.com/postmarketOS/pmbootstrap/pull/1474.patch"},"body":"This PR will install the proper device subpackage, depending on the kernel selection during init, instead of installing directly the \"linux-postmarketos-XXX\" using the subpackage name.\r\nIn both the current devices with the kernel selection, they have the `depends` variable with the correct kernel package to install, and possibly also other packages.\r\nIn theory we can even remove also the lines:\r\n```\r\n     if args.kernel == \"downstream\":\r\n         return [\"linux-\" + device]\r\n```\r\nand just install the `device-aaa-bbb-kernel-downstream` package which will have in the `depends` the `linux-aaa-bbb` package.\r\nOr it is by design to not install the device kernel subpackage?\r\n\r\nPs: I noticed that they weren't installed because I had extra stuff in the device kernel mainline subpackage and it was missing.\r\n\r\n---\r\n[x] Merge on GitHub (see <https://postmarketos.org/merge>)\r\n"},"comment":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/comments/387247836","html_url":"https://github.com/postmarketOS/pmbootstrap/pull/1474#issuecomment-387247836","issue_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1474","id":387247836,"user":{"login":"ollieparanoid","id":6033024,"avatar_url":"https://avatars1.githubusercontent.com/u/6033024?v=4","gravatar_id":"","url":"https://api.github.com/users/ollieparanoid","html_url":"https://github.com/ollieparanoid","followers_url":"https://api.github.com/users/ollieparanoid/followers","following_url":"https://api.github.com/users/ollieparanoid/following{/other_user}","gists_url":"https://api.github.com/users/ollieparanoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ollieparanoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollieparanoid/subscriptions","organizations_url":"https://api.github.com/users/ollieparanoid/orgs","repos_url":"https://api.github.com/users/ollieparanoid/repos","events_url":"https://api.github.com/users/ollieparanoid/events{/privacy}","received_events_url":"https://api.github.com/users/ollieparanoid/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T00:35:22Z","updated_at":"2018-05-08T00:35:22Z","author_association":"OWNER","body":"Thanks for making the change, doing it that way makes much more sense indeed! I'll try to get a review done tomorrow :smiley: "}}
{"actor":{"display_login":"ollieparanoid"}}