{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/223216764","pull_request_review_id":162293436,"id":223216764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIxNjc2NA==","diff_hunk":"@@ -28,13 +28,30 @@ namespace NUnit.Framework.Constraints\n     /// </summary>\n     public class GreaterThanOrEqualConstraint : ComparisonConstraint\n     {\n+        /// <summary>\n+        /// The Description of what this constraint tests, for\n+        /// use in messages and in the ConstraintResult.\n+        /// </summary>\n+        private string _description;\n+        \n         /// <summary>\n         /// Initializes a new instance of the <see cref=\"GreaterThanOrEqualConstraint\"/> class.\n         /// </summary>\n         /// <param name=\"expected\">The expected value.</param>\n-        public GreaterThanOrEqualConstraint(object expected) : base(expected)\n+        public GreaterThanOrEqualConstraint(object expected) : base(expected) {}\n+\n+        /// <summary>\n+        /// The Description of what this constraint tests, for\n+        /// use in messages and in the ConstraintResult.\n+        /// </summary>\n+        public override string Description\n         {\n-            Description = \"greater than or equal to \" + MsgUtils.FormatValue(expected);\n+            get\n+            {\n+                if (System.String.IsNullOrEmpty(_description))\n+                    _description = DefaultDescription(\"greater than or equal to \");\n+                return _description;","path":"src/NUnitFramework/framework/Constraints/GreaterThanOrEqualConstraint.cs","position":28,"original_position":28,"commit_id":"9ed4bd10d2fdae03cf7693bc009e52902183d9c7","original_commit_id":"9ed4bd10d2fdae03cf7693bc009e52902183d9c7","user":{"login":"madetara","id":31938575,"node_id":"MDQ6VXNlcjMxOTM4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/31938575?v=4","gravatar_id":"","url":"https://api.github.com/users/madetara","html_url":"https://github.com/madetara","followers_url":"https://api.github.com/users/madetara/followers","following_url":"https://api.github.com/users/madetara/following{/other_user}","gists_url":"https://api.github.com/users/madetara/gists{/gist_id}","starred_url":"https://api.github.com/users/madetara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madetara/subscriptions","organizations_url":"https://api.github.com/users/madetara/orgs","repos_url":"https://api.github.com/users/madetara/repos","events_url":"https://api.github.com/users/madetara/events{/privacy}","received_events_url":"https://api.github.com/users/madetara/received_events","type":"User","site_admin":false},"body":"Since the base concept here is overriding the `Description`, it seems, in my opinion, more clear to have corresponding field into the inheritor, rather than the base class, even though it has a smell of code duplication.","created_at":"2018-10-07T15:03:05Z","updated_at":"2018-10-07T15:03:05Z","html_url":"https://github.com/nunit/nunit/pull/3044#discussion_r223216764","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/3044","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/223216764"},"html":{"href":"https://github.com/nunit/nunit/pull/3044#discussion_r223216764"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3044"}},"in_reply_to_id":223212389},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/3044","id":220862135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODYyMTM1","html_url":"https://github.com/nunit/nunit/pull/3044","diff_url":"https://github.com/nunit/nunit/pull/3044.diff","patch_url":"https://github.com/nunit/nunit/pull/3044.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/3044","number":3044,"state":"open","locked":false,"title":"Lazy description creation in ComparisonConstraints","user":{"login":"madetara","id":31938575,"node_id":"MDQ6VXNlcjMxOTM4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/31938575?v=4","gravatar_id":"","url":"https://api.github.com/users/madetara","html_url":"https://github.com/madetara","followers_url":"https://api.github.com/users/madetara/followers","following_url":"https://api.github.com/users/madetara/following{/other_user}","gists_url":"https://api.github.com/users/madetara/gists{/gist_id}","starred_url":"https://api.github.com/users/madetara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madetara/subscriptions","organizations_url":"https://api.github.com/users/madetara/orgs","repos_url":"https://api.github.com/users/madetara/repos","events_url":"https://api.github.com/users/madetara/events{/privacy}","received_events_url":"https://api.github.com/users/madetara/received_events","type":"User","site_admin":false},"body":"Fixes #2975 \r\nMoved description creation to a base class.","created_at":"2018-10-06T03:32:55Z","updated_at":"2018-10-07T15:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05395e5c4b8918af3f39fd9e76782f4d0b217f03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":805813973,"node_id":"MDU6TGFiZWw4MDU4MTM5NzM=","url":"https://api.github.com/repos/nunit/nunit/labels/awaiting:contributor","name":"awaiting:contributor","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/3044/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/3044/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/3044/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/9ed4bd10d2fdae03cf7693bc009e52902183d9c7","head":{"label":"madetara:lazy_description_cmp","ref":"lazy_description_cmp","sha":"9ed4bd10d2fdae03cf7693bc009e52902183d9c7","user":{"login":"madetara","id":31938575,"node_id":"MDQ6VXNlcjMxOTM4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/31938575?v=4","gravatar_id":"","url":"https://api.github.com/users/madetara","html_url":"https://github.com/madetara","followers_url":"https://api.github.com/users/madetara/followers","following_url":"https://api.github.com/users/madetara/following{/other_user}","gists_url":"https://api.github.com/users/madetara/gists{/gist_id}","starred_url":"https://api.github.com/users/madetara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madetara/subscriptions","organizations_url":"https://api.github.com/users/madetara/orgs","repos_url":"https://api.github.com/users/madetara/repos","events_url":"https://api.github.com/users/madetara/events{/privacy}","received_events_url":"https://api.github.com/users/madetara/received_events","type":"User","site_admin":false},"repo":{"id":151281342,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyODEzNDI=","name":"nunit","full_name":"madetara/nunit","private":false,"owner":{"login":"madetara","id":31938575,"node_id":"MDQ6VXNlcjMxOTM4NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/31938575?v=4","gravatar_id":"","url":"https://api.github.com/users/madetara","html_url":"https://github.com/madetara","followers_url":"https://api.github.com/users/madetara/followers","following_url":"https://api.github.com/users/madetara/following{/other_user}","gists_url":"https://api.github.com/users/madetara/gists{/gist_id}","starred_url":"https://api.github.com/users/madetara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madetara/subscriptions","organizations_url":"https://api.github.com/users/madetara/orgs","repos_url":"https://api.github.com/users/madetara/repos","events_url":"https://api.github.com/users/madetara/events{/privacy}","received_events_url":"https://api.github.com/users/madetara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/madetara/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/madetara/nunit","forks_url":"https://api.github.com/repos/madetara/nunit/forks","keys_url":"https://api.github.com/repos/madetara/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madetara/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madetara/nunit/teams","hooks_url":"https://api.github.com/repos/madetara/nunit/hooks","issue_events_url":"https://api.github.com/repos/madetara/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/madetara/nunit/events","assignees_url":"https://api.github.com/repos/madetara/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/madetara/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/madetara/nunit/tags","blobs_url":"https://api.github.com/repos/madetara/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madetara/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madetara/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/madetara/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madetara/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/madetara/nunit/languages","stargazers_url":"https://api.github.com/repos/madetara/nunit/stargazers","contributors_url":"https://api.github.com/repos/madetara/nunit/contributors","subscribers_url":"https://api.github.com/repos/madetara/nunit/subscribers","subscription_url":"https://api.github.com/repos/madetara/nunit/subscription","commits_url":"https://api.github.com/repos/madetara/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/madetara/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/madetara/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/madetara/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/madetara/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/madetara/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madetara/nunit/merges","archive_url":"https://api.github.com/repos/madetara/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madetara/nunit/downloads","issues_url":"https://api.github.com/repos/madetara/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/madetara/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/madetara/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/madetara/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madetara/nunit/labels{/name}","releases_url":"https://api.github.com/repos/madetara/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/madetara/nunit/deployments","created_at":"2018-10-02T15:51:13Z","updated_at":"2018-10-02T15:51:18Z","pushed_at":"2018-10-06T19:30:14Z","git_url":"git://github.com/madetara/nunit.git","ssh_url":"git@github.com:madetara/nunit.git","clone_url":"https://github.com/madetara/nunit.git","svn_url":"https://github.com/madetara/nunit","homepage":"http://www.nunit.org/","size":34964,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"cbeffad907943d4219a2f0cdcea55830d267225e","user":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MjE4Mw==","name":"nunit","full_name":"nunit/nunit","private":false,"owner":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2018-10-07T12:48:43Z","pushed_at":"2018-10-07T14:57:22Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":34935,"stargazers_count":1446,"watchers_count":1446,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":514,"open_issues":324,"watchers":1446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3044"},"html":{"href":"https://github.com/nunit/nunit/pull/3044"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/3044"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/3044/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3044/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3044/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/9ed4bd10d2fdae03cf7693bc009e52902183d9c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"madetara"}}