{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/175855750","pull_request_review_id":105455878,"id":175855750,"diff_hunk":"@@ -871,7 +871,7 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {\n                                                          obligation.param_env,\n                                                          new_trait_ref.to_predicate());\n \n-                    if selcx.evaluate_obligation(&new_obligation) {\n+                    if selcx.evaluate_obligation(&new_obligation).must_apply() {","path":"src/librustc/traits/error_reporting.rs","position":20,"original_position":5,"commit_id":"611954e07c8b8a92a676b9022e1858a8884dce7e","original_commit_id":"611954e07c8b8a92a676b9022e1858a8884dce7e","user":{"login":"aravind-pg","id":6913107,"avatar_url":"https://avatars2.githubusercontent.com/u/6913107?v=4","gravatar_id":"","url":"https://api.github.com/users/aravind-pg","html_url":"https://github.com/aravind-pg","followers_url":"https://api.github.com/users/aravind-pg/followers","following_url":"https://api.github.com/users/aravind-pg/following{/other_user}","gists_url":"https://api.github.com/users/aravind-pg/gists{/gist_id}","starred_url":"https://api.github.com/users/aravind-pg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravind-pg/subscriptions","organizations_url":"https://api.github.com/users/aravind-pg/orgs","repos_url":"https://api.github.com/users/aravind-pg/repos","events_url":"https://api.github.com/users/aravind-pg/events{/privacy}","received_events_url":"https://api.github.com/users/aravind-pg/received_events","type":"User","site_admin":false},"body":"Any reason this you didn't do `self.predicate_may_hold`, or was it just a quick fix? Does this also need intercrate mode by any chance?","created_at":"2018-03-20T17:26:48Z","updated_at":"2018-03-20T17:26:48Z","html_url":"https://github.com/rust-lang/rust/pull/48995#discussion_r175855750","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/48995","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/175855750"},"html":{"href":"https://github.com/rust-lang/rust/pull/48995#discussion_r175855750"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48995"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48995","id":174798691,"html_url":"https://github.com/rust-lang/rust/pull/48995","diff_url":"https://github.com/rust-lang/rust/pull/48995.diff","patch_url":"https://github.com/rust-lang/rust/pull/48995.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48995","number":48995,"state":"open","locked":false,"title":"[WIP] Create a canonical trait query for `evaluate_obligation`","user":{"login":"aravind-pg","id":6913107,"avatar_url":"https://avatars2.githubusercontent.com/u/6913107?v=4","gravatar_id":"","url":"https://api.github.com/users/aravind-pg","html_url":"https://github.com/aravind-pg","followers_url":"https://api.github.com/users/aravind-pg/followers","following_url":"https://api.github.com/users/aravind-pg/following{/other_user}","gists_url":"https://api.github.com/users/aravind-pg/gists{/gist_id}","starred_url":"https://api.github.com/users/aravind-pg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravind-pg/subscriptions","organizations_url":"https://api.github.com/users/aravind-pg/orgs","repos_url":"https://api.github.com/users/aravind-pg/repos","events_url":"https://api.github.com/users/aravind-pg/events{/privacy}","received_events_url":"https://api.github.com/users/aravind-pg/received_events","type":"User","site_admin":false},"body":"This builds on the canonical query machinery introduced in #48411 to introduce a new canonical trait query for `evaluate_obligation` in the trait selector. Also ports most callers of the original `evaluate_obligation` to the new system (except in coherence, which requires support for intercrate mode). Closes #48537.\r\n\r\nr? @nikomatsakis ","created_at":"2018-03-13T21:44:45Z","updated_at":"2018-03-20T17:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fadfe26fe9c026b7c088a082c964e840eec5e7b","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583436937,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-author","name":"S-waiting-on-author","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/48995/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/48995/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48995/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/611954e07c8b8a92a676b9022e1858a8884dce7e","head":{"label":"aravind-pg:canonical-query","ref":"canonical-query","sha":"611954e07c8b8a92a676b9022e1858a8884dce7e","user":{"login":"aravind-pg","id":6913107,"avatar_url":"https://avatars2.githubusercontent.com/u/6913107?v=4","gravatar_id":"","url":"https://api.github.com/users/aravind-pg","html_url":"https://github.com/aravind-pg","followers_url":"https://api.github.com/users/aravind-pg/followers","following_url":"https://api.github.com/users/aravind-pg/following{/other_user}","gists_url":"https://api.github.com/users/aravind-pg/gists{/gist_id}","starred_url":"https://api.github.com/users/aravind-pg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravind-pg/subscriptions","organizations_url":"https://api.github.com/users/aravind-pg/orgs","repos_url":"https://api.github.com/users/aravind-pg/repos","events_url":"https://api.github.com/users/aravind-pg/events{/privacy}","received_events_url":"https://api.github.com/users/aravind-pg/received_events","type":"User","site_admin":false},"repo":{"id":62596721,"name":"rust","full_name":"aravind-pg/rust","owner":{"login":"aravind-pg","id":6913107,"avatar_url":"https://avatars2.githubusercontent.com/u/6913107?v=4","gravatar_id":"","url":"https://api.github.com/users/aravind-pg","html_url":"https://github.com/aravind-pg","followers_url":"https://api.github.com/users/aravind-pg/followers","following_url":"https://api.github.com/users/aravind-pg/following{/other_user}","gists_url":"https://api.github.com/users/aravind-pg/gists{/gist_id}","starred_url":"https://api.github.com/users/aravind-pg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravind-pg/subscriptions","organizations_url":"https://api.github.com/users/aravind-pg/orgs","repos_url":"https://api.github.com/users/aravind-pg/repos","events_url":"https://api.github.com/users/aravind-pg/events{/privacy}","received_events_url":"https://api.github.com/users/aravind-pg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aravind-pg/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/aravind-pg/rust","forks_url":"https://api.github.com/repos/aravind-pg/rust/forks","keys_url":"https://api.github.com/repos/aravind-pg/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aravind-pg/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aravind-pg/rust/teams","hooks_url":"https://api.github.com/repos/aravind-pg/rust/hooks","issue_events_url":"https://api.github.com/repos/aravind-pg/rust/issues/events{/number}","events_url":"https://api.github.com/repos/aravind-pg/rust/events","assignees_url":"https://api.github.com/repos/aravind-pg/rust/assignees{/user}","branches_url":"https://api.github.com/repos/aravind-pg/rust/branches{/branch}","tags_url":"https://api.github.com/repos/aravind-pg/rust/tags","blobs_url":"https://api.github.com/repos/aravind-pg/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aravind-pg/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aravind-pg/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/aravind-pg/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aravind-pg/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/aravind-pg/rust/languages","stargazers_url":"https://api.github.com/repos/aravind-pg/rust/stargazers","contributors_url":"https://api.github.com/repos/aravind-pg/rust/contributors","subscribers_url":"https://api.github.com/repos/aravind-pg/rust/subscribers","subscription_url":"https://api.github.com/repos/aravind-pg/rust/subscription","commits_url":"https://api.github.com/repos/aravind-pg/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/aravind-pg/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/aravind-pg/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/aravind-pg/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/aravind-pg/rust/contents/{+path}","compare_url":"https://api.github.com/repos/aravind-pg/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aravind-pg/rust/merges","archive_url":"https://api.github.com/repos/aravind-pg/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aravind-pg/rust/downloads","issues_url":"https://api.github.com/repos/aravind-pg/rust/issues{/number}","pulls_url":"https://api.github.com/repos/aravind-pg/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/aravind-pg/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/aravind-pg/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aravind-pg/rust/labels{/name}","releases_url":"https://api.github.com/repos/aravind-pg/rust/releases{/id}","deployments_url":"https://api.github.com/repos/aravind-pg/rust/deployments","created_at":"2016-07-05T01:25:18Z","updated_at":"2016-07-05T01:25:37Z","pushed_at":"2018-03-20T15:50:33Z","git_url":"git://github.com/aravind-pg/rust.git","ssh_url":"git@github.com:aravind-pg/rust.git","clone_url":"https://github.com/aravind-pg/rust.git","svn_url":"https://github.com/aravind-pg/rust","homepage":"https://www.rust-lang.org","size":349790,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"75af15ee6ca0c12b699a17984b033363cd25e9c3","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-03-20T16:44:42Z","pushed_at":"2018-03-20T17:18:54Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":351930,"stargazers_count":27138,"watchers_count":27138,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4783,"mirror_url":null,"archived":false,"open_issues_count":3542,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4783,"open_issues":3542,"watchers":27138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48995"},"html":{"href":"https://github.com/rust-lang/rust/pull/48995"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48995"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48995/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48995/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48995/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/611954e07c8b8a92a676b9022e1858a8884dce7e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aravind-pg"}}