{"push_id":3034666115,"size":14,"distinct_size":3,"ref":"refs/heads/shipperctl-admin-join-clusters","head":"6bd2d00ef13430995a42bf99cb6c6503c5756307","before":"3393b3c5d5436c1e66923cbe51f15c1d1f0903de","commits":[{"sha":"59978b05dfa4a34c0c6ec089ce69e27cd9641cf2","author":{"name":"Oleg Sidorov","email":"12dd6aa5256102c3a4d92f48e3aefe2f16f7bcbc@booking.com"},"message":"Fixed some test failures caused by the scheduler behavior change.\n\nThis commit fixes some failing tests. We changed the way the scheduler\ncontroller reacts to the existsing duplicate traffic / capacity /\ninstallation targets: it checks if the duplicate belongs to the release\nobject for real (by inspecting the target owner references) and if it\ndoes, proceed normally. If it's not, it's an error and we bail out right\naway. This behavior lets us secure ourselves from a situation where we\nhave an orphan object which would be garbage-collected soon but has\nnothing to do with the current release.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/59978b05dfa4a34c0c6ec089ce69e27cd9641cf2"},{"sha":"5650e9fbeecd2b690f819d351e5581068ed27f63","author":{"name":"Oleg Sidorov","email":"12dd6aa5256102c3a4d92f48e3aefe2f16f7bcbc@booking.com"},"message":"Fixes in scheduler: direct client calls substituted by lister fetches\n\nThis commit is a followup on @kanatohodets comments regarding the direct\ninstallation, capacity and traffic targets fetch. This commit replaces\nthese calls with lister API fetches.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/5650e9fbeecd2b690f819d351e5581068ed27f63"},{"sha":"1db584e7362e02c524c4fcc880ec8ab3d04454f9","author":{"name":"Parham Doustdar","email":"affa6f12aa1ea942077c6978053a4ebb3b42b1de@gmail.com"},"message":"Merge pull request #36 from bookingcom/olegs/e2e_aborts_fixing_tests\n\nFixed some test failures caused by the scheduler behavior change","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/1db584e7362e02c524c4fcc880ec8ab3d04454f9"},{"sha":"a62dd9a9dad8d55a6227605f3e58b3d2c872d0e0","author":{"name":"Igor Sutton","email":"b2e3084588684a0c7d3456342ec15bf3be7b372f@me.com"},"message":"RFC: Introduce shipperctl command line utility (#29)\n\n* rfcs: add shipperctl admin rfc\r\n\r\n* Changed the RFC to follow our latest discussions.\r\n\r\n* Made tiny fixes.\r\n\r\n* shipperctl admin rfc: add k8s envelope to cluster manifest","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/a62dd9a9dad8d55a6227605f3e58b3d2c872d0e0"},{"sha":"d78196233e30593f5036ccd6276f2d56fb46531f","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"driveby: fix vet failures\n\nGo 1.11 runs 'go vet' by default when you run 'go test'. Not yet sure why\nour normal pipeline didn't catch these.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/d78196233e30593f5036ccd6276f2d56fb46531f"},{"sha":"3d24e21ef2ccdd5753e8f0da4c6f24fbeda27f3f","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"driveby: goimports auto-ordering","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/3d24e21ef2ccdd5753e8f0da4c6f24fbeda27f3f"},{"sha":"c7d66b42ea6ef97e124e619581f439b840978788","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"apis: move 'Release.Meta.Environment' to 'Release.Spec.Environment'\n\nKubernetes 1.11 introduces a large set of improvements for CRDs.\nHowever, one of them is stricter validation of the 'metadata' field of\nCRD instances: it will drop any unknown keys from the 'metadata' object\nbefore storage.\n\nAs a result, Release objects land in the cluster without any\nEnvironment. This Release is useless for the Schedule and Strategy\ncontrollers, and because it does not match the Application template,\nShipper creates a new Release; ultimately this turns into a tight loop\nof creating bogus Releases. Suboptimal.\n\nThis patch moves the 'environment' portion of Release objects to the\n'spec'. We originally did not put 'Environment' into the spec because it\nwas meant to be immutable, and not part of the user-facing command\nlanguage -- we appreciated a 'spec' section that consisted of nothing but\nthe user control 'targetStep'.\n\nWhile well-intentioned, this was likely a bad call, since it makes it\nawkward to consider Releases generated by hand, without the control of\nan Application object. We can solve the immutability by introducing an\nadmission controller, and trust our users to be smart about which fields\nare run-time-editable.\n\nNote: this requires a migration script to run against the management\nclusters between shutting down the previous version of Shipper and\nstarting this one: the script should copy '.metadata.environment' to\n'.spec.environment' for all existing Releases.\n\nI decided to do this as a migration script rather than building\na conversion into Shipper itself because there's currently no location\nin Shipper which regularly processes and updates all existing Releases.\nI expect this to change as we look towards merging the Schedule and\nStrategy controllers into the Release controller.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/c7d66b42ea6ef97e124e619581f439b840978788"},{"sha":"30c380bbdb34d9f5e4aa19e6ce64fd9af16cac84","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"strategy controller: don't crash on empty release envs","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/30c380bbdb34d9f5e4aa19e6ce64fd9af16cac84"},{"sha":"ef222a3e99b33af0067e1c6085daba937941e892","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"hack: add migration script for releases\n\nThis script just _copies_ the .metadata.environment to .spec. Once the\nclusters are running 1.11, the metadata section will be naturally\ndeleted.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/ef222a3e99b33af0067e1c6085daba937941e892"},{"sha":"f9d460455c000a14c2ca5cb38ea2ae3c61fe6a6a","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"driveby: remove old \"sanity\" cmd\n\nCaused a build failure; these days I think we're confident enough in the\ncodegen process to not need this.","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/f9d460455c000a14c2ca5cb38ea2ae3c61fe6a6a"},{"sha":"13333ef81b6bc2f398377b863546c4dfa1aba04c","author":{"name":"Ben Tyler","email":"e90525cbbfdb90020ea72de38b1f0fc3bbbc4cbb@booking.com"},"message":"strategy: fix log message for empty env check","distinct":false,"url":"https://api.github.com/repos/bookingcom/shipper/commits/13333ef81b6bc2f398377b863546c4dfa1aba04c"},{"sha":"9c9890b9fde0463fbb4db0ea85064b40a695711d","author":{"name":"Parham Doustdar","email":"65f7bfacee180c39ec1e4a4925c217b6df966da8@booking.com"},"message":"Initial proof of concept for shipperctl. This is still incomplete.","distinct":true,"url":"https://api.github.com/repos/bookingcom/shipper/commits/9c9890b9fde0463fbb4db0ea85064b40a695711d"},{"sha":"bb20b1a526384f81fd2de94f52929b1de422f4e0","author":{"name":"Parham Doustdar","email":"65f7bfacee180c39ec1e4a4925c217b6df966da8@booking.com"},"message":"Implemented a proof-of-concept to load a particular Kubernetes configuration context.","distinct":true,"url":"https://api.github.com/repos/bookingcom/shipper/commits/bb20b1a526384f81fd2de94f52929b1de422f4e0"},{"sha":"6bd2d00ef13430995a42bf99cb6c6503c5756307","author":{"name":"Parham Doustdar","email":"65f7bfacee180c39ec1e4a4925c217b6df966da8@booking.com"},"message":"This is a massive commit, almost delivering the whole functionality of\n`shipperctl admin clusters apply` in one go.\n\nThe only functionality left is the creation of the Cluster object on\nevery management cluster, which will follow in the next commit.","distinct":true,"url":"https://api.github.com/repos/bookingcom/shipper/commits/6bd2d00ef13430995a42bf99cb6c6503c5756307"}]}
{"actor":{"display_login":"parhamdoustdar"}}