{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph-csi/issues/29","repository_url":"https://api.github.com/repos/ceph/ceph-csi","labels_url":"https://api.github.com/repos/ceph/ceph-csi/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph-csi/issues/29/comments","events_url":"https://api.github.com/repos/ceph/ceph-csi/issues/29/events","html_url":"https://github.com/ceph/ceph-csi/pull/29","id":298986896,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcwNDgyMDM5","number":29,"title":"fixed a race condition in NodePublishVolume/NodeUnpublishVolume","user":{"login":"gman0","id":1104680,"node_id":"MDQ6VXNlcjExMDQ2ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1104680?v=4","gravatar_id":"","url":"https://api.github.com/users/gman0","html_url":"https://github.com/gman0","followers_url":"https://api.github.com/users/gman0/followers","following_url":"https://api.github.com/users/gman0/following{/other_user}","gists_url":"https://api.github.com/users/gman0/gists{/gist_id}","starred_url":"https://api.github.com/users/gman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gman0/subscriptions","organizations_url":"https://api.github.com/users/gman0/orgs","repos_url":"https://api.github.com/users/gman0/repos","events_url":"https://api.github.com/users/gman0/events{/privacy}","received_events_url":"https://api.github.com/users/gman0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-21T14:17:17Z","updated_at":"2018-10-29T11:46:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph-csi/pulls/29","html_url":"https://github.com/ceph/ceph-csi/pull/29","diff_url":"https://github.com/ceph/ceph-csi/pull/29.diff","patch_url":"https://github.com/ceph/ceph-csi/pull/29.patch"},"body":"Adds a mutex and a map with VolumeId as a key. Permits NodePublishVolume\r\nand NodeUnpublishVolume functions to continue only when the map doesn't\r\ncontain that VolumeId, otherwise returns an error.\r\n\r\nRationale:\r\n\r\nNodePublishVolume's SafeFormatAndMount may take quite a long time. This would\r\nin turn trigger CO's timeout which would re-run NodePublishVolume again.\r\n\r\nOn a Linux system, SafeFormatAndMount calls fsck, mkfs.ext4 and mount.\r\nRunning those commands repeatedly and simultaneously on the same volume\r\nmay well break it.\r\n\r\nAs a follow-up question, is rbdplugin even supposed to format and mount the volume? It's a block device after all."},"comment":{"url":"https://api.github.com/repos/ceph/ceph-csi/issues/comments/433881009","html_url":"https://github.com/ceph/ceph-csi/pull/29#issuecomment-433881009","issue_url":"https://api.github.com/repos/ceph/ceph-csi/issues/29","id":433881009,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzg4MTAwOQ==","user":{"login":"pohly","id":22076,"node_id":"MDQ6VXNlcjIyMDc2","avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T11:46:11Z","updated_at":"2018-10-29T11:46:11Z","author_association":"CONTRIBUTOR","body":"I think a more complete version of this was merged in PR #92 and this one can be closed now?\r\n"}}
{"actor":{"display_login":"pohly"}}