{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/185616102","pull_request_review_id":117041389,"id":185616102,"diff_hunk":"@@ -107,15 +107,37 @@ def setup_mva(val_pset,cat_pset,prod_name,mva_name):\n     ecalRecHitsEE = cms.InputTag(\"reducedEgamma\",\"reducedEERecHits\"),\n )\n \n+#############################################################\n+# 8X legacy needs an extra Et scale systematic\n+# due to an inflection around 45 GeV which is handled as a\n+# patch on top of the standard scale and smearing systematics\n+#############################################################\n+from RecoEgamma.EgammaTools.calibratedEgammas_cff import ecalTrkCombinationRegression\n+egamma8XLegacyEtScaleSysModifier = cms.PSet(\n+    modifierName = cms.string('EGEtScaleSysModifier'),\n+    epCombConfig = ecalTrkCombinationRegression,\n+    uncertFunc = cms.PSet(\n+        name = cms.string(\"UncertFuncV1\"),\n+        lowEt = cms.double(43.5),\n+        highEt = cms.double(46.5),\n+        lowEtUncert = cms.double(0.002),\n+        highEtUncert = cms.double(-0.002)\n+        )\n+    )\n+\n def appendReducedEgammaEnergyScaleAndSmearingModifier(modifiers):\n     modifiers.append(reducedEgammaEnergyScaleAndSmearingModifier)\n \n def prependEgamma8XObjectUpdateModifier(modifiers):\n     modifiers.insert(0,egamma8XObjectUpdateModifier)\n \n+def appendReducedEgammaEnergyScaleAndSmearingModifierWith8XLegacyEtSys(modifiers):\n+    modifiers.append(reducedEgammaEnergyScaleAndSmearingModifier)","path":"RecoEgamma/EgammaTools/python/egammaObjectModificationsInMiniAOD_cff.py","position":null,"original_position":29,"commit_id":"912df1243c293950c92e09b896385d2c2e67d990","original_commit_id":"912df1243c293950c92e09b896385d2c2e67d990","user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"body":"agreed","created_at":"2018-05-02T19:43:42Z","updated_at":"2018-05-02T19:43:42Z","html_url":"https://github.com/cms-sw/cmssw/pull/22975#discussion_r185616102","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/185616102"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22975#discussion_r185616102"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975"}},"in_reply_to_id":185601660},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975","id":181872856,"html_url":"https://github.com/cms-sw/cmssw/pull/22975","diff_url":"https://github.com/cms-sw/cmssw/pull/22975.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22975.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22975","number":22975,"state":"open","locked":false,"title":"Adapting E/gamma miniAOD for the 80X re-miniAOD V2: 10_2_X","user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"body":"Dear All,\r\n\r\nThis PR introduces a few changes necessary to run the legacy re-miniAOD. \r\n\r\nSpecifically, it enables scale & smearing in 80X re-miniAOD.  This is mostly python except that due to a format change in the scale & smearing file, we need a small (backwards compatible) code change. \r\n\r\nAdditionally, we realised there are variables in the electron/photon which were introduced in 9X which are not filled in the 8X electrons/photons, we added a modifier to do make those variables and run in the 80X miniAOD sequence.  It would be nice to have this. \r\n\r\nNote, this is not final, there was a last minute problem with the legacy scale & smearing corrections which mean they are currently unavailible. As such for testing purposes we have the file set incorrectly to the 2017 values right now.  But we wanted to get the process moving here. \r\n\r\nDo we make the 94X PR to the MINIAOD branch or the normal branch?\r\n\r\n","created_at":"2018-04-16T14:08:12Z","updated_at":"2018-05-02T19:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d815246edb8909e84352eea34ea3d7b48dd158f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":541952670,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/requires-external","name":"requires-external","color":"0000ff","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":233,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-02T19:05:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22975/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/912df1243c293950c92e09b896385d2c2e67d990","head":{"label":"Sam-Harper:Egamma80XMiniAODV2_102X","ref":"Egamma80XMiniAODV2_102X","sha":"912df1243c293950c92e09b896385d2c2e67d990","user":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"repo":{"id":15676551,"name":"cmssw","full_name":"Sam-Harper/cmssw","owner":{"login":"Sam-Harper","id":5021403,"avatar_url":"https://avatars2.githubusercontent.com/u/5021403?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam-Harper","html_url":"https://github.com/Sam-Harper","followers_url":"https://api.github.com/users/Sam-Harper/followers","following_url":"https://api.github.com/users/Sam-Harper/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Harper/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Harper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Harper/subscriptions","organizations_url":"https://api.github.com/users/Sam-Harper/orgs","repos_url":"https://api.github.com/users/Sam-Harper/repos","events_url":"https://api.github.com/users/Sam-Harper/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Harper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sam-Harper/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Sam-Harper/cmssw","forks_url":"https://api.github.com/repos/Sam-Harper/cmssw/forks","keys_url":"https://api.github.com/repos/Sam-Harper/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sam-Harper/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sam-Harper/cmssw/teams","hooks_url":"https://api.github.com/repos/Sam-Harper/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Sam-Harper/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Sam-Harper/cmssw/events","assignees_url":"https://api.github.com/repos/Sam-Harper/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Sam-Harper/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Sam-Harper/cmssw/tags","blobs_url":"https://api.github.com/repos/Sam-Harper/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sam-Harper/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sam-Harper/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sam-Harper/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sam-Harper/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Sam-Harper/cmssw/languages","stargazers_url":"https://api.github.com/repos/Sam-Harper/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Sam-Harper/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Sam-Harper/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Sam-Harper/cmssw/subscription","commits_url":"https://api.github.com/repos/Sam-Harper/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sam-Harper/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sam-Harper/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sam-Harper/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sam-Harper/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Sam-Harper/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sam-Harper/cmssw/merges","archive_url":"https://api.github.com/repos/Sam-Harper/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sam-Harper/cmssw/downloads","issues_url":"https://api.github.com/repos/Sam-Harper/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Sam-Harper/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Sam-Harper/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Sam-Harper/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sam-Harper/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Sam-Harper/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/Sam-Harper/cmssw/deployments","created_at":"2014-01-06T14:56:25Z","updated_at":"2014-06-10T09:57:00Z","pushed_at":"2018-04-30T21:11:51Z","git_url":"git://github.com/Sam-Harper/cmssw.git","ssh_url":"git@github.com:Sam-Harper/cmssw.git","clone_url":"https://github.com/Sam-Harper/cmssw.git","svn_url":"https://github.com/Sam-Harper/cmssw","homepage":"cms-sw.github.io/cmssw","size":913249,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6_1_2_SLHC2_L1EGIsol_SLHCUpgradeSim"}},"base":{"label":"cms-sw:master","ref":"master","sha":"e0488ede0af25af19bcdd5bfc01c90172abfa695","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-02T16:10:02Z","pushed_at":"2018-05-02T19:07:50Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":999379,"stargazers_count":545,"watchers_count":545,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2551,"mirror_url":null,"archived":false,"open_issues_count":452,"license":null,"forks":2551,"open_issues":452,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22975"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22975"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22975/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22975/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/912df1243c293950c92e09b896385d2c2e67d990"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Sam-Harper"}}