{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/228593970","pull_request_review_id":168908340,"id":228593970,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODU5Mzk3MA==","diff_hunk":"@@ -493,6 +493,7 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, OnDestroy {\n         switchMap(() => {\n           this._resetActiveItem();\n           this.autocomplete._setVisibility();\n+          this._changeDetectorRef.detectChanges();","path":"src/lib/autocomplete/autocomplete-trigger.ts","position":4,"original_position":4,"commit_id":"91d90dfffa8702007efcff58af988cf6a255c770","original_commit_id":"91d90dfffa8702007efcff58af988cf6a255c770","user":{"login":"jelbourn","id":838736,"node_id":"MDQ6VXNlcjgzODczNg==","avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"I see that it's already set up this way, but I just noticed that it's weird for this `switchMap` to have side effects. No action necessary here, but something to keep in mind.","created_at":"2018-10-26T16:43:29Z","updated_at":"2018-10-26T16:43:41Z","html_url":"https://github.com/angular/material2/pull/13774#discussion_r228593970","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/13774","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/228593970"},"html":{"href":"https://github.com/angular/material2/pull/13774#discussion_r228593970"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/13774"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/13774","id":225157028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTU3MDI4","html_url":"https://github.com/angular/material2/pull/13774","diff_url":"https://github.com/angular/material2/pull/13774.diff","patch_url":"https://github.com/angular/material2/pull/13774.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/13774","number":13774,"state":"open","locked":false,"title":"fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled","user":{"login":"crisbeto","id":4450522,"node_id":"MDQ6VXNlcjQ0NTA1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"Fixes the first option not appearing as highlighted if the consumer has set `floatLabel=\"never\"` and `autoActiveFirstOption`. It looks like we were depending on the `transitioned` event from the label to kick off the change detection that shows the highlight.\r\n\r\nFixes #13734.","created_at":"2018-10-23T19:21:18Z","updated_at":"2018-10-26T16:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85e2ff0d073883d47ae17a3ee4330c364900931","assignee":{"login":"jelbourn","id":838736,"node_id":"MDQ6VXNlcjgzODczNg==","avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"node_id":"MDQ6VXNlcjgzODczNg==","avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308798701,"node_id":"MDU6TGFiZWwzMDg3OTg3MDE=","url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":770558890,"node_id":"MDU6TGFiZWw3NzA1NTg4OTA=","url":"https://api.github.com/repos/angular/material2/labels/target:%20patch","name":"target: patch","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/13774/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/13774/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/13774/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/91d90dfffa8702007efcff58af988cf6a255c770","head":{"label":"crisbeto:13734/autocomplete-auto-active-float-label","ref":"13734/autocomplete-auto-active-float-label","sha":"91d90dfffa8702007efcff58af988cf6a255c770","user":{"login":"crisbeto","id":4450522,"node_id":"MDQ6VXNlcjQ0NTA1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"repo":{"id":60285287,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NTI4Nw==","name":"material2","full_name":"crisbeto/material2","private":false,"owner":{"login":"crisbeto","id":4450522,"node_id":"MDQ6VXNlcjQ0NTA1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/crisbeto/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/crisbeto/material2","forks_url":"https://api.github.com/repos/crisbeto/material2/forks","keys_url":"https://api.github.com/repos/crisbeto/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crisbeto/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crisbeto/material2/teams","hooks_url":"https://api.github.com/repos/crisbeto/material2/hooks","issue_events_url":"https://api.github.com/repos/crisbeto/material2/issues/events{/number}","events_url":"https://api.github.com/repos/crisbeto/material2/events","assignees_url":"https://api.github.com/repos/crisbeto/material2/assignees{/user}","branches_url":"https://api.github.com/repos/crisbeto/material2/branches{/branch}","tags_url":"https://api.github.com/repos/crisbeto/material2/tags","blobs_url":"https://api.github.com/repos/crisbeto/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crisbeto/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crisbeto/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/crisbeto/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crisbeto/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/crisbeto/material2/languages","stargazers_url":"https://api.github.com/repos/crisbeto/material2/stargazers","contributors_url":"https://api.github.com/repos/crisbeto/material2/contributors","subscribers_url":"https://api.github.com/repos/crisbeto/material2/subscribers","subscription_url":"https://api.github.com/repos/crisbeto/material2/subscription","commits_url":"https://api.github.com/repos/crisbeto/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/crisbeto/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/crisbeto/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/crisbeto/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/crisbeto/material2/contents/{+path}","compare_url":"https://api.github.com/repos/crisbeto/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crisbeto/material2/merges","archive_url":"https://api.github.com/repos/crisbeto/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crisbeto/material2/downloads","issues_url":"https://api.github.com/repos/crisbeto/material2/issues{/number}","pulls_url":"https://api.github.com/repos/crisbeto/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/crisbeto/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/crisbeto/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crisbeto/material2/labels{/name}","releases_url":"https://api.github.com/repos/crisbeto/material2/releases{/id}","deployments_url":"https://api.github.com/repos/crisbeto/material2/deployments","created_at":"2016-06-02T17:50:34Z","updated_at":"2018-10-25T20:59:46Z","pushed_at":"2018-10-26T11:35:19Z","git_url":"git://github.com/crisbeto/material2.git","ssh_url":"git@github.com:crisbeto/material2.git","clone_url":"https://github.com/crisbeto/material2.git","svn_url":"https://github.com/crisbeto/material2","homepage":"https://material.angular.io/","size":22129,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"3ca3e39d5939850c21a266b73e29c0233de29c2f","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"node_id":"MDEwOlJlcG9zaXRvcnk0OTAxNjMyMg==","name":"material2","full_name":"angular/material2","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2018-10-26T15:19:01Z","pushed_at":"2018-10-26T15:09:48Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":20942,"stargazers_count":16237,"watchers_count":16237,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4114,"mirror_url":null,"archived":false,"open_issues_count":1325,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4114,"open_issues":1325,"watchers":16237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/13774"},"html":{"href":"https://github.com/angular/material2/pull/13774"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/13774"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/13774/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/13774/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/13774/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/91d90dfffa8702007efcff58af988cf6a255c770"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jelbourn"}}