{"action":"created","comment":{"url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/comments/188463144","pull_request_review_id":120446940,"id":188463144,"diff_hunk":"@@ -1247,6 +1247,11 @@ VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceProperties(VkPhysicalDevice physical\n \n VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceProperties2KHR(VkPhysicalDevice physicalDevice,","path":"layersvt/device_simulation.cpp","position":2,"original_position":2,"commit_id":"5e52da8c7f2457946b076876a50ffd4b78697b62","original_commit_id":"5e52da8c7f2457946b076876a50ffd4b78697b62","user":{"login":"mikew-lunarg","id":22177952,"avatar_url":"https://avatars0.githubusercontent.com/u/22177952?v=4","gravatar_id":"","url":"https://api.github.com/users/mikew-lunarg","html_url":"https://github.com/mikew-lunarg","followers_url":"https://api.github.com/users/mikew-lunarg/followers","following_url":"https://api.github.com/users/mikew-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/mikew-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mikew-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikew-lunarg/subscriptions","organizations_url":"https://api.github.com/users/mikew-lunarg/orgs","repos_url":"https://api.github.com/users/mikew-lunarg/repos","events_url":"https://api.github.com/users/mikew-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/mikew-lunarg/received_events","type":"User","site_admin":false},"body":"This commit seems incomplete compared to the GetPhysicalDeviceFeatures2KHR replacement in the previous commit.  There is not a GetPhysicalDeviceProperties2 entry point, that would also be added to getprocaddress.\r\n","created_at":"2018-05-15T23:11:19Z","updated_at":"2018-05-15T23:12:56Z","html_url":"https://github.com/LunarG/VulkanTools/pull/499#discussion_r188463144","pull_request_url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/comments/188463144"},"html":{"href":"https://github.com/LunarG/VulkanTools/pull/499#discussion_r188463144"},"pull_request":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499","id":188227031,"html_url":"https://github.com/LunarG/VulkanTools/pull/499","diff_url":"https://github.com/LunarG/VulkanTools/pull/499.diff","patch_url":"https://github.com/LunarG/VulkanTools/pull/499.patch","issue_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/499","number":499,"state":"open","locked":false,"title":"layersvt: Enable GetPhysicalDeviceFeatures2","user":{"login":"Whenning42","id":8920171,"avatar_url":"https://avatars2.githubusercontent.com/u/8920171?v=4","gravatar_id":"","url":"https://api.github.com/users/Whenning42","html_url":"https://github.com/Whenning42","followers_url":"https://api.github.com/users/Whenning42/followers","following_url":"https://api.github.com/users/Whenning42/following{/other_user}","gists_url":"https://api.github.com/users/Whenning42/gists{/gist_id}","starred_url":"https://api.github.com/users/Whenning42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Whenning42/subscriptions","organizations_url":"https://api.github.com/users/Whenning42/orgs","repos_url":"https://api.github.com/users/Whenning42/repos","events_url":"https://api.github.com/users/Whenning42/events{/privacy}","received_events_url":"https://api.github.com/users/Whenning42/received_events","type":"User","site_admin":false},"body":"Set up GetPhysicalDeviceFeatures2(KHR) to make calls to the\r\ncorresponding vulkan function instead of simply calling the non-extended\r\nvkGetPhysicalDeviceFeatures.","created_at":"2018-05-15T19:11:21Z","updated_at":"2018-05-15T23:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f7e1fe2250422b6ec12b7379daabb342af44e9e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tobine","id":7526739,"avatar_url":"https://avatars0.githubusercontent.com/u/7526739?v=4","gravatar_id":"","url":"https://api.github.com/users/tobine","html_url":"https://github.com/tobine","followers_url":"https://api.github.com/users/tobine/followers","following_url":"https://api.github.com/users/tobine/following{/other_user}","gists_url":"https://api.github.com/users/tobine/gists{/gist_id}","starred_url":"https://api.github.com/users/tobine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobine/subscriptions","organizations_url":"https://api.github.com/users/tobine/orgs","repos_url":"https://api.github.com/users/tobine/repos","events_url":"https://api.github.com/users/tobine/events{/privacy}","received_events_url":"https://api.github.com/users/tobine/received_events","type":"User","site_admin":false},{"login":"mikes-lunarg","id":23323159,"avatar_url":"https://avatars2.githubusercontent.com/u/23323159?v=4","gravatar_id":"","url":"https://api.github.com/users/mikes-lunarg","html_url":"https://github.com/mikes-lunarg","followers_url":"https://api.github.com/users/mikes-lunarg/followers","following_url":"https://api.github.com/users/mikes-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/mikes-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mikes-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikes-lunarg/subscriptions","organizations_url":"https://api.github.com/users/mikes-lunarg/orgs","repos_url":"https://api.github.com/users/mikes-lunarg/repos","events_url":"https://api.github.com/users/mikes-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/mikes-lunarg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499/commits","review_comments_url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499/comments","review_comment_url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/499/comments","statuses_url":"https://api.github.com/repos/LunarG/VulkanTools/statuses/5e52da8c7f2457946b076876a50ffd4b78697b62","head":{"label":"Whenning42:master","ref":"master","sha":"5e52da8c7f2457946b076876a50ffd4b78697b62","user":{"login":"Whenning42","id":8920171,"avatar_url":"https://avatars2.githubusercontent.com/u/8920171?v=4","gravatar_id":"","url":"https://api.github.com/users/Whenning42","html_url":"https://github.com/Whenning42","followers_url":"https://api.github.com/users/Whenning42/followers","following_url":"https://api.github.com/users/Whenning42/following{/other_user}","gists_url":"https://api.github.com/users/Whenning42/gists{/gist_id}","starred_url":"https://api.github.com/users/Whenning42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Whenning42/subscriptions","organizations_url":"https://api.github.com/users/Whenning42/orgs","repos_url":"https://api.github.com/users/Whenning42/repos","events_url":"https://api.github.com/users/Whenning42/events{/privacy}","received_events_url":"https://api.github.com/users/Whenning42/received_events","type":"User","site_admin":false},"repo":{"id":133560190,"name":"VulkanTools","full_name":"Whenning42/VulkanTools","owner":{"login":"Whenning42","id":8920171,"avatar_url":"https://avatars2.githubusercontent.com/u/8920171?v=4","gravatar_id":"","url":"https://api.github.com/users/Whenning42","html_url":"https://github.com/Whenning42","followers_url":"https://api.github.com/users/Whenning42/followers","following_url":"https://api.github.com/users/Whenning42/following{/other_user}","gists_url":"https://api.github.com/users/Whenning42/gists{/gist_id}","starred_url":"https://api.github.com/users/Whenning42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Whenning42/subscriptions","organizations_url":"https://api.github.com/users/Whenning42/orgs","repos_url":"https://api.github.com/users/Whenning42/repos","events_url":"https://api.github.com/users/Whenning42/events{/privacy}","received_events_url":"https://api.github.com/users/Whenning42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Whenning42/VulkanTools","description":"Tools to aid in Vulkan development including useful layers, trace and replay, and tests","fork":true,"url":"https://api.github.com/repos/Whenning42/VulkanTools","forks_url":"https://api.github.com/repos/Whenning42/VulkanTools/forks","keys_url":"https://api.github.com/repos/Whenning42/VulkanTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Whenning42/VulkanTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Whenning42/VulkanTools/teams","hooks_url":"https://api.github.com/repos/Whenning42/VulkanTools/hooks","issue_events_url":"https://api.github.com/repos/Whenning42/VulkanTools/issues/events{/number}","events_url":"https://api.github.com/repos/Whenning42/VulkanTools/events","assignees_url":"https://api.github.com/repos/Whenning42/VulkanTools/assignees{/user}","branches_url":"https://api.github.com/repos/Whenning42/VulkanTools/branches{/branch}","tags_url":"https://api.github.com/repos/Whenning42/VulkanTools/tags","blobs_url":"https://api.github.com/repos/Whenning42/VulkanTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Whenning42/VulkanTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Whenning42/VulkanTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Whenning42/VulkanTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Whenning42/VulkanTools/statuses/{sha}","languages_url":"https://api.github.com/repos/Whenning42/VulkanTools/languages","stargazers_url":"https://api.github.com/repos/Whenning42/VulkanTools/stargazers","contributors_url":"https://api.github.com/repos/Whenning42/VulkanTools/contributors","subscribers_url":"https://api.github.com/repos/Whenning42/VulkanTools/subscribers","subscription_url":"https://api.github.com/repos/Whenning42/VulkanTools/subscription","commits_url":"https://api.github.com/repos/Whenning42/VulkanTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Whenning42/VulkanTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Whenning42/VulkanTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Whenning42/VulkanTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Whenning42/VulkanTools/contents/{+path}","compare_url":"https://api.github.com/repos/Whenning42/VulkanTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Whenning42/VulkanTools/merges","archive_url":"https://api.github.com/repos/Whenning42/VulkanTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Whenning42/VulkanTools/downloads","issues_url":"https://api.github.com/repos/Whenning42/VulkanTools/issues{/number}","pulls_url":"https://api.github.com/repos/Whenning42/VulkanTools/pulls{/number}","milestones_url":"https://api.github.com/repos/Whenning42/VulkanTools/milestones{/number}","notifications_url":"https://api.github.com/repos/Whenning42/VulkanTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Whenning42/VulkanTools/labels{/name}","releases_url":"https://api.github.com/repos/Whenning42/VulkanTools/releases{/id}","deployments_url":"https://api.github.com/repos/Whenning42/VulkanTools/deployments","created_at":"2018-05-15T18:56:37Z","updated_at":"2018-05-15T20:39:07Z","pushed_at":"2018-05-15T20:39:05Z","git_url":"git://github.com/Whenning42/VulkanTools.git","ssh_url":"git@github.com:Whenning42/VulkanTools.git","clone_url":"https://github.com/Whenning42/VulkanTools.git","svn_url":"https://github.com/Whenning42/VulkanTools","homepage":"","size":69183,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LunarG:master","ref":"master","sha":"814a7c50635b4333ecaa898804abfa048755f2f4","user":{"login":"LunarG","id":6932052,"avatar_url":"https://avatars1.githubusercontent.com/u/6932052?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarG","html_url":"https://github.com/LunarG","followers_url":"https://api.github.com/users/LunarG/followers","following_url":"https://api.github.com/users/LunarG/following{/other_user}","gists_url":"https://api.github.com/users/LunarG/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarG/subscriptions","organizations_url":"https://api.github.com/users/LunarG/orgs","repos_url":"https://api.github.com/users/LunarG/repos","events_url":"https://api.github.com/users/LunarG/events{/privacy}","received_events_url":"https://api.github.com/users/LunarG/received_events","type":"Organization","site_admin":false},"repo":{"id":50691713,"name":"VulkanTools","full_name":"LunarG/VulkanTools","owner":{"login":"LunarG","id":6932052,"avatar_url":"https://avatars1.githubusercontent.com/u/6932052?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarG","html_url":"https://github.com/LunarG","followers_url":"https://api.github.com/users/LunarG/followers","following_url":"https://api.github.com/users/LunarG/following{/other_user}","gists_url":"https://api.github.com/users/LunarG/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarG/subscriptions","organizations_url":"https://api.github.com/users/LunarG/orgs","repos_url":"https://api.github.com/users/LunarG/repos","events_url":"https://api.github.com/users/LunarG/events{/privacy}","received_events_url":"https://api.github.com/users/LunarG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LunarG/VulkanTools","description":"Tools to aid in Vulkan development including useful layers, trace and replay, and tests","fork":false,"url":"https://api.github.com/repos/LunarG/VulkanTools","forks_url":"https://api.github.com/repos/LunarG/VulkanTools/forks","keys_url":"https://api.github.com/repos/LunarG/VulkanTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LunarG/VulkanTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LunarG/VulkanTools/teams","hooks_url":"https://api.github.com/repos/LunarG/VulkanTools/hooks","issue_events_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/events{/number}","events_url":"https://api.github.com/repos/LunarG/VulkanTools/events","assignees_url":"https://api.github.com/repos/LunarG/VulkanTools/assignees{/user}","branches_url":"https://api.github.com/repos/LunarG/VulkanTools/branches{/branch}","tags_url":"https://api.github.com/repos/LunarG/VulkanTools/tags","blobs_url":"https://api.github.com/repos/LunarG/VulkanTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LunarG/VulkanTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LunarG/VulkanTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/LunarG/VulkanTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LunarG/VulkanTools/statuses/{sha}","languages_url":"https://api.github.com/repos/LunarG/VulkanTools/languages","stargazers_url":"https://api.github.com/repos/LunarG/VulkanTools/stargazers","contributors_url":"https://api.github.com/repos/LunarG/VulkanTools/contributors","subscribers_url":"https://api.github.com/repos/LunarG/VulkanTools/subscribers","subscription_url":"https://api.github.com/repos/LunarG/VulkanTools/subscription","commits_url":"https://api.github.com/repos/LunarG/VulkanTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/LunarG/VulkanTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/LunarG/VulkanTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/LunarG/VulkanTools/contents/{+path}","compare_url":"https://api.github.com/repos/LunarG/VulkanTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LunarG/VulkanTools/merges","archive_url":"https://api.github.com/repos/LunarG/VulkanTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LunarG/VulkanTools/downloads","issues_url":"https://api.github.com/repos/LunarG/VulkanTools/issues{/number}","pulls_url":"https://api.github.com/repos/LunarG/VulkanTools/pulls{/number}","milestones_url":"https://api.github.com/repos/LunarG/VulkanTools/milestones{/number}","notifications_url":"https://api.github.com/repos/LunarG/VulkanTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LunarG/VulkanTools/labels{/name}","releases_url":"https://api.github.com/repos/LunarG/VulkanTools/releases{/id}","deployments_url":"https://api.github.com/repos/LunarG/VulkanTools/deployments","created_at":"2016-01-29T21:13:46Z","updated_at":"2018-05-15T20:08:16Z","pushed_at":"2018-05-15T21:30:05Z","git_url":"git://github.com/LunarG/VulkanTools.git","ssh_url":"git@github.com:LunarG/VulkanTools.git","clone_url":"https://github.com/LunarG/VulkanTools.git","svn_url":"https://github.com/LunarG/VulkanTools","homepage":"","size":69168,"stargazers_count":242,"watchers_count":242,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":77,"open_issues":56,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499"},"html":{"href":"https://github.com/LunarG/VulkanTools/pull/499"},"issue":{"href":"https://api.github.com/repos/LunarG/VulkanTools/issues/499"},"comments":{"href":"https://api.github.com/repos/LunarG/VulkanTools/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LunarG/VulkanTools/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/LunarG/VulkanTools/statuses/5e52da8c7f2457946b076876a50ffd4b78697b62"}},"author_association":"NONE"}}
{"actor":{"display_login":"mikew-lunarg"}}