{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/204850837","pull_request_review_id":139984263,"id":204850837,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg1MDgzNw==","diff_hunk":"@@ -201,8 +229,27 @@ public long getStartTime() {\n     public void shutdown() {\n         running.set(false);\n         backendChannel.close();\n+        ModelManager manager = ModelManager.getInstance();\n         if (currentThread != null) {\n             currentThread.interrupt();\n+            try {\n+                if (parentThreads.size() < model.getMinWorkers()) {\n+                    // minWorkers is the numWorkers configured for this model. If parent thread group\n+                    // has less threads than expected minWorkers, we should restart the workers.\n+                    manager.updateModel(","path":"frontend/server/src/main/java/com/amazonaws/ml/mms/wlm/WorkerThread.java","position":119,"original_position":119,"commit_id":"fa28630688dd1e3b7107c915a1c408193ecdd18a","original_commit_id":"fa28630688dd1e3b7107c915a1c408193ecdd18a","user":{"login":"frankfliu","id":24425551,"node_id":"MDQ6VXNlcjI0NDI1NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/24425551?v=4","gravatar_id":"","url":"https://api.github.com/users/frankfliu","html_url":"https://github.com/frankfliu","followers_url":"https://api.github.com/users/frankfliu/followers","following_url":"https://api.github.com/users/frankfliu/following{/other_user}","gists_url":"https://api.github.com/users/frankfliu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankfliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankfliu/subscriptions","organizations_url":"https://api.github.com/users/frankfliu/orgs","repos_url":"https://api.github.com/users/frankfliu/repos","events_url":"https://api.github.com/users/frankfliu/events{/privacy}","received_events_url":"https://api.github.com/users/frankfliu/received_events","type":"User","site_admin":false},"body":"Better add backoff on retry","created_at":"2018-07-24T17:48:33Z","updated_at":"2018-07-24T18:01:05Z","html_url":"https://github.com/awslabs/mxnet-model-server/pull/451#discussion_r204850837","pull_request_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/204850837"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/451#discussion_r204850837"},"pull_request":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451","id":201515688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTE1Njg4","html_url":"https://github.com/awslabs/mxnet-model-server/pull/451","diff_url":"https://github.com/awslabs/mxnet-model-server/pull/451.diff","patch_url":"https://github.com/awslabs/mxnet-model-server/pull/451.patch","issue_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/451","number":451,"state":"open","locked":false,"title":"1. Added a per thread queue for Jobs.","user":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n\r\n*Description of changes:*\r\n1. Monitor synchronous messages to the backend worker.\r\n1. Restart the backend worker if there is no response in 2 mins.\r\n1. Added a thread based queue to send control messages to specific backend workers.\r\n1. Refactored code a little.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-07-15T21:05:15Z","updated_at":"2018-07-24T18:01:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18d93f52ba565dab2abc0594d4822c1791b644f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451/commits","review_comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451/comments","review_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/451/comments","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/fa28630688dd1e3b7107c915a1c408193ecdd18a","head":{"label":"vdantu:backend_worker_monitoring","ref":"backend_worker_monitoring","sha":"fa28630688dd1e3b7107c915a1c408193ecdd18a","user":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"repo":{"id":120691512,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2OTE1MTI=","name":"mxnet-model-server","full_name":"vdantu/mxnet-model-server","owner":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdantu/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for deploying neural net models for inference","fork":true,"url":"https://api.github.com/repos/vdantu/mxnet-model-server","forks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/vdantu/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdantu/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdantu/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/vdantu/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdantu/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vdantu/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/vdantu/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdantu/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/vdantu/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdantu/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/vdantu/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vdantu/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vdantu/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdantu/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/vdantu/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/deployments","created_at":"2018-02-08T00:55:11Z","updated_at":"2018-05-28T03:48:59Z","pushed_at":"2018-07-24T01:17:39Z","git_url":"git://github.com/vdantu/mxnet-model-server.git","ssh_url":"git@github.com:vdantu/mxnet-model-server.git","clone_url":"https://github.com/vdantu/mxnet-model-server.git","svn_url":"https://github.com/vdantu/mxnet-model-server","homepage":"","size":36177,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"awslabs:netty","ref":"netty","sha":"898acf5e38a3fec4dfee8233e232db7d95659941","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105830539,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MzA1Mzk=","name":"mxnet-model-server","full_name":"awslabs/mxnet-model-server","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for serving neural net models for inference","fork":false,"url":"https://api.github.com/repos/awslabs/mxnet-model-server","forks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/awslabs/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/awslabs/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/deployments","created_at":"2017-10-04T23:41:07Z","updated_at":"2018-07-22T10:25:54Z","pushed_at":"2018-07-24T16:37:32Z","git_url":"git://github.com/awslabs/mxnet-model-server.git","ssh_url":"git@github.com:awslabs/mxnet-model-server.git","clone_url":"https://github.com/awslabs/mxnet-model-server.git","svn_url":"https://github.com/awslabs/mxnet-model-server","homepage":"","size":36153,"stargazers_count":274,"watchers_count":274,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":49,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/451"},"issue":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/451"},"comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/fa28630688dd1e3b7107c915a1c408193ecdd18a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"frankfliu"}}