{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/176278408","pull_request_review_id":105952902,"id":176278408,"diff_hunk":"@@ -38,18 +38,32 @@\n from kubeflow.testing import test_util\n from kubeflow.testing import util\n \n+# We should test all files which end in .jsonnet or .libsonnet\n+# except ksonnet prototype definitions - they require additional","path":"testing/test_jsonnet.py","position":5,"original_position":5,"commit_id":"9816b37e47caa69d0dfd86e56b13f47a3257e326","original_commit_id":"9fe40293130d333f7aa33c5965a1f40a352ee995","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"body":"Yes. We shouldn't test any .jsonnet under .../prototypes/ since they are ksonnet prototypes.","created_at":"2018-03-22T00:16:06Z","updated_at":"2018-03-22T00:16:06Z","html_url":"https://github.com/kubeflow/kubeflow/pull/480#discussion_r176278408","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/176278408"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/480#discussion_r176278408"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480"}},"in_reply_to_id":176276411},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480","id":176607406,"html_url":"https://github.com/kubeflow/kubeflow/pull/480","diff_url":"https://github.com/kubeflow/kubeflow/pull/480.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/480.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/480","number":480,"state":"open","locked":false,"title":"Update jsonnet tests so that it tests all files under kubeflow","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"body":"* This will catch any syntax errors in *sonnet files.\n* Skip all ksonnet prototypes since they need additional deps\n\n/cc @lluunn\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/480)\n<!-- Reviewable:end -->\n","created_at":"2018-03-21T20:56:23Z","updated_at":"2018-03-22T00:16:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d727684db1b447f24aab20785ae109e87e5cc95d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":796371353,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/480/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/9816b37e47caa69d0dfd86e56b13f47a3257e326","head":{"label":"ankushagarwal:jsonnet-test-all","ref":"jsonnet-test-all","sha":"9816b37e47caa69d0dfd86e56b13f47a3257e326","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"repo":{"id":121576093,"name":"kubeflow","full_name":"ankushagarwal/kubeflow","owner":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankushagarwal/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/ankushagarwal/kubeflow","forks_url":"https://api.github.com/repos/ankushagarwal/kubeflow/forks","keys_url":"https://api.github.com/repos/ankushagarwal/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankushagarwal/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankushagarwal/kubeflow/teams","hooks_url":"https://api.github.com/repos/ankushagarwal/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/ankushagarwal/kubeflow/events","assignees_url":"https://api.github.com/repos/ankushagarwal/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/ankushagarwal/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/ankushagarwal/kubeflow/tags","blobs_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankushagarwal/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ankushagarwal/kubeflow/languages","stargazers_url":"https://api.github.com/repos/ankushagarwal/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/ankushagarwal/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/ankushagarwal/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/ankushagarwal/kubeflow/subscription","commits_url":"https://api.github.com/repos/ankushagarwal/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankushagarwal/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ankushagarwal/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/ankushagarwal/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankushagarwal/kubeflow/merges","archive_url":"https://api.github.com/repos/ankushagarwal/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankushagarwal/kubeflow/downloads","issues_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/ankushagarwal/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ankushagarwal/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ankushagarwal/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankushagarwal/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/ankushagarwal/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/ankushagarwal/kubeflow/deployments","created_at":"2018-02-15T00:09:47Z","updated_at":"2018-03-21T19:07:02Z","pushed_at":"2018-03-22T00:10:16Z","git_url":"git://github.com/ankushagarwal/kubeflow.git","ssh_url":"git@github.com:ankushagarwal/kubeflow.git","clone_url":"https://github.com/ankushagarwal/kubeflow.git","svn_url":"https://github.com/ankushagarwal/kubeflow","homepage":"","size":100235,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"bdecba16628e3fcf1940e4aa37be3bed05c8e42a","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-03-21T23:30:07Z","pushed_at":"2018-03-22T00:10:21Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":100861,"stargazers_count":2817,"watchers_count":2817,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":315,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":315,"open_issues":159,"watchers":2817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/480"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/480"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/9816b37e47caa69d0dfd86e56b13f47a3257e326"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ankushagarwal"}}