{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/93","repository_url":"https://api.github.com/repos/KhronosGroup/glTF-Validator","labels_url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/93/comments","events_url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/93/events","html_url":"https://github.com/KhronosGroup/glTF-Validator/issues/93","id":342569288,"node_id":"MDU6SXNzdWUzNDI1NjkyODg=","number":93,"title":"Consider warning on duplicate node names.","user":{"login":"donmccurdy","id":1848368,"node_id":"MDQ6VXNlcjE4NDgzNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1848368?v=4","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"labels":[{"id":408842316,"node_id":"MDU6TGFiZWw0MDg4NDIzMTY=","url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-19T03:49:20Z","updated_at":"2018-07-19T15:42:53Z","closed_at":null,"author_association":"MEMBER","body":"While the glTF spec does not require unique names, multiple tools — three.js and Blender, that I'm aware of — require or strongly encourage it. For example, without unique names:\r\n\r\n- animation can fail, or be assigned to the wrong nodes, in three.js\r\n- import to Blender _may_ automatically rename duplicate nodes\r\n- or, if names are shared between different types like Bones and Meshes, import to Blender may not rename nodes, in which case export may fail because of similar assumptions\r\n\r\nI have not compared in other engines, but I think it would be worthwhile to consider a warning or hint when nodes contain names and those names are duplicated."},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/comments/406322396","html_url":"https://github.com/KhronosGroup/glTF-Validator/issues/93#issuecomment-406322396","issue_url":"https://api.github.com/repos/KhronosGroup/glTF-Validator/issues/93","id":406322396,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjMyMjM5Ng==","user":{"login":"emackey","id":1235080,"node_id":"MDQ6VXNlcjEyMzUwODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1235080?v=4","gravatar_id":"","url":"https://api.github.com/users/emackey","html_url":"https://github.com/emackey","followers_url":"https://api.github.com/users/emackey/followers","following_url":"https://api.github.com/users/emackey/following{/other_user}","gists_url":"https://api.github.com/users/emackey/gists{/gist_id}","starred_url":"https://api.github.com/users/emackey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emackey/subscriptions","organizations_url":"https://api.github.com/users/emackey/orgs","repos_url":"https://api.github.com/users/emackey/repos","events_url":"https://api.github.com/users/emackey/events{/privacy}","received_events_url":"https://api.github.com/users/emackey/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T15:42:53Z","updated_at":"2018-07-19T15:42:53Z","author_association":"MEMBER","body":"For reference, Blender names are unique per-type.  The default scene contains a node named `Cube` that contains a mesh also named `Cube`.  But if you try to add or rename another node or mesh with the same name as an existing one of the same type, you will get `Cube.001`, `Cube.002` etc showing up.\r\n\r\nGiven the rename behavior, I don't think the Blender Importer will need to do anything special to ensure uniqueness, as Blender seems happy to forcibly apply that at a lower level.  I expect imported models to show up with the `.001` pattern on duplicate names even without our coding it.\r\n"}}
{"actor":{"display_login":"emackey"}}