{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments/194400859","pull_request_review_id":127564300,"id":194400859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQwMDg1OQ==","diff_hunk":"@@ -98,20 +98,20 @@ def check(uid, name, variant, exp_logdir):\n \n     def test_data_dir(self):\n         \"\"\"\n-        Tests that a valid datadir exists following the test filename\n+        Tests that a valid data dir exists following the test filename\n         \"\"\"\n         max_length_name = os.path.join(self.tmpdir, \"a\" * 250)\n         tst = self._get_fake_filename_test(max_length_name)\n         self.assertEqual(os.path.join(self.tmpdir, max_length_name + \".data\"),\n-                         tst.datadir)\n+                         tst.get_data('', 'file', False))\n \n     def test_no_data_dir(self):\n         \"\"\"\n         Tests that with a filename too long, no datadir is possible\n         \"\"\"\n         above_limit_name = os.path.join(self.tmpdir, \"a\" * 251)\n         tst = self._get_fake_filename_test(above_limit_name)\n-        self.assertFalse(tst.datadir)","path":"selftests/unit/test_test.py","position":19,"original_position":19,"commit_id":"4551f31a0ef979ccb3d3b485954570e875455bad","original_commit_id":"4551f31a0ef979ccb3d3b485954570e875455bad","user":{"login":"ldoktor","id":1074021,"node_id":"MDQ6VXNlcjEwNzQwMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"And here the docstring might by synced to say `Checks \"get_data\" won't report fs-unfriendly data dir name.`","created_at":"2018-06-11T13:21:12Z","updated_at":"2018-06-11T13:21:12Z","html_url":"https://github.com/avocado-framework/avocado/pull/2653#discussion_r194400859","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments/194400859"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/2653#discussion_r194400859"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653","id":193468748,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDY4NzQ4","html_url":"https://github.com/avocado-framework/avocado/pull/2653","diff_url":"https://github.com/avocado-framework/avocado/pull/2653.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/2653.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/2653","number":2653,"state":"open","locked":false,"title":"Remove the deprecated Test.srcdir and Test.datadir attributes","user":{"login":"clebergnu","id":447178,"node_id":"MDQ6VXNlcjQ0NzE3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/447178?v=4","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"body":"These have been deprecated for a while, and are now past due their removal, so let's do it now.","created_at":"2018-06-07T22:53:27Z","updated_at":"2018-06-11T13:21:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecd3de68059572f669c0143ae42f74df8757db99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/2653/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/4551f31a0ef979ccb3d3b485954570e875455bad","head":{"label":"clebergnu:remove_srcdir_datadir","ref":"remove_srcdir_datadir","sha":"4551f31a0ef979ccb3d3b485954570e875455bad","user":{"login":"clebergnu","id":447178,"node_id":"MDQ6VXNlcjQ0NzE3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/447178?v=4","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"repo":{"id":17944017,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk0NDAxNw==","name":"avocado","full_name":"clebergnu/avocado","owner":{"login":"clebergnu","id":447178,"node_id":"MDQ6VXNlcjQ0NzE3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/447178?v=4","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clebergnu/avocado","description":"Avocado Test Runner","fork":true,"url":"https://api.github.com/repos/clebergnu/avocado","forks_url":"https://api.github.com/repos/clebergnu/avocado/forks","keys_url":"https://api.github.com/repos/clebergnu/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clebergnu/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clebergnu/avocado/teams","hooks_url":"https://api.github.com/repos/clebergnu/avocado/hooks","issue_events_url":"https://api.github.com/repos/clebergnu/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/clebergnu/avocado/events","assignees_url":"https://api.github.com/repos/clebergnu/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/clebergnu/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/clebergnu/avocado/tags","blobs_url":"https://api.github.com/repos/clebergnu/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clebergnu/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clebergnu/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/clebergnu/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clebergnu/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/clebergnu/avocado/languages","stargazers_url":"https://api.github.com/repos/clebergnu/avocado/stargazers","contributors_url":"https://api.github.com/repos/clebergnu/avocado/contributors","subscribers_url":"https://api.github.com/repos/clebergnu/avocado/subscribers","subscription_url":"https://api.github.com/repos/clebergnu/avocado/subscription","commits_url":"https://api.github.com/repos/clebergnu/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/clebergnu/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/clebergnu/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/clebergnu/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/clebergnu/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/clebergnu/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clebergnu/avocado/merges","archive_url":"https://api.github.com/repos/clebergnu/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clebergnu/avocado/downloads","issues_url":"https://api.github.com/repos/clebergnu/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/clebergnu/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/clebergnu/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/clebergnu/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clebergnu/avocado/labels{/name}","releases_url":"https://api.github.com/repos/clebergnu/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/clebergnu/avocado/deployments","created_at":"2014-03-20T13:42:05Z","updated_at":"2017-03-14T20:16:34Z","pushed_at":"2018-06-11T12:48:12Z","git_url":"git://github.com/clebergnu/avocado.git","ssh_url":"git@github.com:clebergnu/avocado.git","clone_url":"https://github.com/clebergnu/avocado.git","svn_url":"https://github.com/clebergnu/avocado","homepage":"","size":12593,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"d449155f9b8af0cee769b4f74cf6aff2c2712d3b","user":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17449498,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ0OTQ5OA==","name":"avocado","full_name":"avocado-framework/avocado","owner":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado","description":"Avocado Test Framework","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado","forks_url":"https://api.github.com/repos/avocado-framework/avocado/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado/deployments","created_at":"2014-03-05T17:52:27Z","updated_at":"2018-06-11T11:24:48Z","pushed_at":"2018-06-11T13:20:25Z","git_url":"git://github.com/avocado-framework/avocado.git","ssh_url":"git@github.com:avocado-framework/avocado.git","clone_url":"https://github.com/avocado-framework/avocado.git","svn_url":"https://github.com/avocado-framework/avocado","homepage":"http://avocado-framework.github.io/","size":12299,"stargazers_count":155,"watchers_count":155,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":166,"open_issues":42,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/2653"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/2653"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/2653/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/2653/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado/statuses/4551f31a0ef979ccb3d3b485954570e875455bad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ldoktor"}}