{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/navi/pulls/comments/195252521","pull_request_review_id":128584630,"id":195252521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI1MjUyMQ==","diff_hunk":"@@ -201,12 +203,20 @@ export default Component.extend({\n    */\n   columns: computed('options.columns', 'request.sort', function() {\n     let sorts = this._mapAlias(get(this, 'request')),\n-        columns = $.extend(true, [], get(this, 'options.columns'));\n+        columns = cloneDeep(get(this, 'options.columns') || []),\n+        columnIndex = get(this, 'columnIndex');\n \n-    return columns.map( column => {\n+    if (!columnIndex) {\n+      columnIndex = indexColumnById(columns);\n+      set(this, 'columnIndex', columnIndex);\n+    }\n+\n+    return columns.map(column => {\n       let {field, type} = column,\n           fieldName = type === 'dateTime' ? type : canonicalizeMetric(field),\n           sort =  arr(sorts).findBy('metric', fieldName) || {},\n+          oldColumn = columnIndex[column.field[column.type === 'threshold' ? 'metric' : column.type]],\n+          isEdited = !isEqual(column, oldColumn),","path":"packages/visualizations/addon/components/navi-visualizations/table.js","position":39,"original_position":39,"commit_id":"0823f94a6a15dd28a28077d198a764ccf2a9c5cd","original_commit_id":"0823f94a6a15dd28a28077d198a764ccf2a9c5cd","user":{"login":"Xuefeng-Zhu","id":5875315,"node_id":"MDQ6VXNlcjU4NzUzMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5875315?v=4","gravatar_id":"","url":"https://api.github.com/users/Xuefeng-Zhu","html_url":"https://github.com/Xuefeng-Zhu","followers_url":"https://api.github.com/users/Xuefeng-Zhu/followers","following_url":"https://api.github.com/users/Xuefeng-Zhu/following{/other_user}","gists_url":"https://api.github.com/users/Xuefeng-Zhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Xuefeng-Zhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xuefeng-Zhu/subscriptions","organizations_url":"https://api.github.com/users/Xuefeng-Zhu/orgs","repos_url":"https://api.github.com/users/Xuefeng-Zhu/repos","events_url":"https://api.github.com/users/Xuefeng-Zhu/events{/privacy}","received_events_url":"https://api.github.com/users/Xuefeng-Zhu/received_events","type":"User","site_admin":false},"body":"I think it should be compared to the initial display name","created_at":"2018-06-13T22:14:25Z","updated_at":"2018-06-13T22:14:26Z","html_url":"https://github.com/yahoo/navi/pull/113#discussion_r195252521","pull_request_url":"https://api.github.com/repos/yahoo/navi/pulls/113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments/195252521"},"html":{"href":"https://github.com/yahoo/navi/pull/113#discussion_r195252521"},"pull_request":{"href":"https://api.github.com/repos/yahoo/navi/pulls/113"}},"in_reply_to_id":195250990},"pull_request":{"url":"https://api.github.com/repos/yahoo/navi/pulls/113","id":194096823,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDk2ODIz","html_url":"https://github.com/yahoo/navi/pull/113","diff_url":"https://github.com/yahoo/navi/pull/113.diff","patch_url":"https://github.com/yahoo/navi/pull/113.patch","issue_url":"https://api.github.com/repos/yahoo/navi/issues/113","number":113,"state":"open","locked":false,"title":"Update: Add edited column state to table","user":{"login":"Xuefeng-Zhu","id":5875315,"node_id":"MDQ6VXNlcjU4NzUzMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5875315?v=4","gravatar_id":"","url":"https://api.github.com/users/Xuefeng-Zhu","html_url":"https://github.com/Xuefeng-Zhu","followers_url":"https://api.github.com/users/Xuefeng-Zhu/followers","following_url":"https://api.github.com/users/Xuefeng-Zhu/following{/other_user}","gists_url":"https://api.github.com/users/Xuefeng-Zhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Xuefeng-Zhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xuefeng-Zhu/subscriptions","organizations_url":"https://api.github.com/users/Xuefeng-Zhu/orgs","repos_url":"https://api.github.com/users/Xuefeng-Zhu/repos","events_url":"https://api.github.com/users/Xuefeng-Zhu/events{/privacy}","received_events_url":"https://api.github.com/users/Xuefeng-Zhu/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/5875315/41255894-b068a6ce-6d8d-11e8-8e9c-5baa87533b9e.png)\r\n\r\n![image](https://user-images.githubusercontent.com/5875315/41312512-d9bca13c-6e4c-11e8-91eb-7018886702ed.png)\r\n","created_at":"2018-06-11T20:40:21Z","updated_at":"2018-06-13T22:14:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"092c2b4e4c4a3c9f532ddd2aba365dcdb50fb540","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/navi/pulls/113/commits","review_comments_url":"https://api.github.com/repos/yahoo/navi/pulls/113/comments","review_comment_url":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/navi/issues/113/comments","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/0823f94a6a15dd28a28077d198a764ccf2a9c5cd","head":{"label":"yahoo:edited_column_state","ref":"edited_column_state","sha":"0823f94a6a15dd28a28077d198a764ccf2a9c5cd","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNDQ5NjE=","name":"navi","full_name":"yahoo/navi","owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-06-13T18:24:18Z","pushed_at":"2018-06-13T21:51:49Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"git@github.com:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"https://yahoo.github.io/navi","size":2821,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":47,"watchers":16,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"56ad62352d0c34737dcfb8b08eec21dafe6a39f7","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNDQ5NjE=","name":"navi","full_name":"yahoo/navi","owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-06-13T18:24:18Z","pushed_at":"2018-06-13T21:51:49Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"git@github.com:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"https://yahoo.github.io/navi","size":2821,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":47,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/113"},"html":{"href":"https://github.com/yahoo/navi/pull/113"},"issue":{"href":"https://api.github.com/repos/yahoo/navi/issues/113"},"comments":{"href":"https://api.github.com/repos/yahoo/navi/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/navi/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/navi/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/navi/statuses/0823f94a6a15dd28a28077d198a764ccf2a9c5cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Xuefeng-Zhu"}}