{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/172730313","pull_request_review_id":101796209,"id":172730313,"diff_hunk":"@@ -137,11 +137,16 @@ describe('Spawn options', () => {\n           }\n \n           f.spawn(options, (err, _ipfsd) => {\n+            ipfsd = _ipfsd","path":"test/spawn-options.spec.js","position":13,"original_position":13,"commit_id":"a2426e2bdc400b0833eedc43d2018ebb950b4e62","original_commit_id":"9edcb4ba3073febee7e0dc4e475ea9de141347e5","user":{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false},"body":"I have and do not see any failures. Were you expecting it to fail because it's assigning a global? ipfsd is defined above, on line 124 so here we are just setting it.\r\n\r\nI moved this assignment from below because if any of the below `expect`s failed, it would inadvertently cause the next `it`s to fail.","created_at":"2018-03-07T03:06:49Z","updated_at":"2018-03-07T03:06:49Z","html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/212#discussion_r172730313","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/172730313"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/212#discussion_r172730313"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212"}},"in_reply_to_id":172697521},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212","id":171825906,"html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/212","diff_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/212.diff","patch_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/212.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/212","number":212,"state":"open","locked":false,"title":"fix: daemon should recognize previously created repos.","user":{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false},"body":"While working on some go/js interop tests I noticed that a daemon spawned on an already-initialized repo doesn't report itself as initialized.\r\n\r\nIt turned out to be just a typo so I fixed that and added a test.","created_at":"2018-02-28T00:39:08Z","updated_at":"2018-03-07T03:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d16008f3255beb432f61c806663bb8a722ed25da","assignee":{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false},"assignees":[{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":419602045,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/212/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/a2426e2bdc400b0833eedc43d2018ebb950b4e62","head":{"label":"JonKrone:fix/initialized","ref":"fix/initialized","sha":"a2426e2bdc400b0833eedc43d2018ebb950b4e62","user":{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false},"repo":{"id":123196455,"name":"js-ipfsd-ctl","full_name":"JonKrone/js-ipfsd-ctl","owner":{"login":"JonKrone","id":2660142,"avatar_url":"https://avatars1.githubusercontent.com/u/2660142?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKrone","html_url":"https://github.com/JonKrone","followers_url":"https://api.github.com/users/JonKrone/followers","following_url":"https://api.github.com/users/JonKrone/following{/other_user}","gists_url":"https://api.github.com/users/JonKrone/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKrone/subscriptions","organizations_url":"https://api.github.com/users/JonKrone/orgs","repos_url":"https://api.github.com/users/JonKrone/repos","events_url":"https://api.github.com/users/JonKrone/events{/privacy}","received_events_url":"https://api.github.com/users/JonKrone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonKrone/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":true,"url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/JonKrone/js-ipfsd-ctl/deployments","created_at":"2018-02-27T22:27:56Z","updated_at":"2018-02-27T22:27:58Z","pushed_at":"2018-03-07T03:02:53Z","git_url":"git://github.com/JonKrone/js-ipfsd-ctl.git","ssh_url":"git@github.com:JonKrone/js-ipfsd-ctl.git","clone_url":"https://github.com/JonKrone/js-ipfsd-ctl.git","svn_url":"https://github.com/JonKrone/js-ipfsd-ctl","homepage":"","size":293,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"4cc69a00f45c42831bdafe9ed948a922858f6d86","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":34555538,"name":"js-ipfsd-ctl","full_name":"ipfs/js-ipfsd-ctl","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/deployments","created_at":"2015-04-25T04:40:11Z","updated_at":"2018-03-05T12:28:35Z","pushed_at":"2018-03-07T03:02:55Z","git_url":"git://github.com/ipfs/js-ipfsd-ctl.git","ssh_url":"git@github.com:ipfs/js-ipfsd-ctl.git","clone_url":"https://github.com/ipfs/js-ipfsd-ctl.git","svn_url":"https://github.com/ipfs/js-ipfsd-ctl","homepage":"","size":282,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":12,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/212"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/212"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/a2426e2bdc400b0833eedc43d2018ebb950b4e62"}},"author_association":"NONE"}}
{"actor":{"display_login":"JonKrone"}}