{"action":"closed","number":9311,"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/9311","id":221303882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzAzODgy","html_url":"https://github.com/librenms/librenms/pull/9311","diff_url":"https://github.com/librenms/librenms/pull/9311.diff","patch_url":"https://github.com/librenms/librenms/pull/9311.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/9311","number":9311,"state":"closed","locked":false,"title":"Fix bug of alerting by ping.php","user":{"login":"DR3EVR8u8c","id":23585646,"node_id":"MDQ6VXNlcjIzNTg1NjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/23585646?v=4","gravatar_id":"","url":"https://api.github.com/users/DR3EVR8u8c","html_url":"https://github.com/DR3EVR8u8c","followers_url":"https://api.github.com/users/DR3EVR8u8c/followers","following_url":"https://api.github.com/users/DR3EVR8u8c/following{/other_user}","gists_url":"https://api.github.com/users/DR3EVR8u8c/gists{/gist_id}","starred_url":"https://api.github.com/users/DR3EVR8u8c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DR3EVR8u8c/subscriptions","organizations_url":"https://api.github.com/users/DR3EVR8u8c/orgs","repos_url":"https://api.github.com/users/DR3EVR8u8c/repos","events_url":"https://api.github.com/users/DR3EVR8u8c/events{/privacy}","received_events_url":"https://api.github.com/users/DR3EVR8u8c/received_events","type":"User","site_admin":false},"body":"DO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\nAfter you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.\r\n\r\n\r\n## please refer the Help ticket for more information:\r\nhttps://community.librenms.org/t/please-help-with-for-fast-ping-checks-problems/5586\r\n\r\n**Bug description:**\r\nthe PingCheck.php saves the device status after it run rules. Therefore, the rules cannot be detected correctly as the devices table hasn’t been updated. While Poller.php update the devices status in db before it run the rules detection.","created_at":"2018-10-09T04:17:20Z","updated_at":"2018-10-11T22:15:31Z","closed_at":"2018-10-11T22:15:31Z","merged_at":null,"merge_commit_sha":"38329c1ec55b476ef571808eb42f019c46248deb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":210071360,"node_id":"MDU6TGFiZWwyMTAwNzEzNjA=","url":"https://api.github.com/repos/librenms/librenms/labels/Alerting%20:bell:","name":"Alerting :bell:","color":"ff99ff","default":false},{"id":62946216,"node_id":"MDU6TGFiZWw2Mjk0NjIxNg==","url":"https://api.github.com/repos/librenms/librenms/labels/Bug%20:beetle:","name":"Bug :beetle:","color":"e11d21","default":false}],"milestone":{"url":"https://api.github.com/repos/librenms/librenms/milestones/18","html_url":"https://github.com/librenms/librenms/milestone/18","labels_url":"https://api.github.com/repos/librenms/librenms/milestones/18/labels","id":3346605,"node_id":"MDk6TWlsZXN0b25lMzM0NjYwNQ==","number":18,"title":"1.44","description":"","creator":{"login":"laf","id":3941142,"node_id":"MDQ6VXNlcjM5NDExNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":31,"state":"open","created_at":"2018-05-14T20:25:56Z","updated_at":"2018-10-11T22:15:32Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/9311/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/9311/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/9311/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/9e03cbd2fe67e232b690e582a6e5819bbae2e47a","head":{"label":"DR3EVR8u8c:master","ref":"master","sha":"9e03cbd2fe67e232b690e582a6e5819bbae2e47a","user":{"login":"DR3EVR8u8c","id":23585646,"node_id":"MDQ6VXNlcjIzNTg1NjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/23585646?v=4","gravatar_id":"","url":"https://api.github.com/users/DR3EVR8u8c","html_url":"https://github.com/DR3EVR8u8c","followers_url":"https://api.github.com/users/DR3EVR8u8c/followers","following_url":"https://api.github.com/users/DR3EVR8u8c/following{/other_user}","gists_url":"https://api.github.com/users/DR3EVR8u8c/gists{/gist_id}","starred_url":"https://api.github.com/users/DR3EVR8u8c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DR3EVR8u8c/subscriptions","organizations_url":"https://api.github.com/users/DR3EVR8u8c/orgs","repos_url":"https://api.github.com/users/DR3EVR8u8c/repos","events_url":"https://api.github.com/users/DR3EVR8u8c/events{/privacy}","received_events_url":"https://api.github.com/users/DR3EVR8u8c/received_events","type":"User","site_admin":false},"repo":{"id":133118211,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMTgyMTE=","name":"librenms","full_name":"DR3EVR8u8c/librenms","private":false,"owner":{"login":"DR3EVR8u8c","id":23585646,"node_id":"MDQ6VXNlcjIzNTg1NjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/23585646?v=4","gravatar_id":"","url":"https://api.github.com/users/DR3EVR8u8c","html_url":"https://github.com/DR3EVR8u8c","followers_url":"https://api.github.com/users/DR3EVR8u8c/followers","following_url":"https://api.github.com/users/DR3EVR8u8c/following{/other_user}","gists_url":"https://api.github.com/users/DR3EVR8u8c/gists{/gist_id}","starred_url":"https://api.github.com/users/DR3EVR8u8c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DR3EVR8u8c/subscriptions","organizations_url":"https://api.github.com/users/DR3EVR8u8c/orgs","repos_url":"https://api.github.com/users/DR3EVR8u8c/repos","events_url":"https://api.github.com/users/DR3EVR8u8c/events{/privacy}","received_events_url":"https://api.github.com/users/DR3EVR8u8c/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DR3EVR8u8c/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/DR3EVR8u8c/librenms","forks_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/forks","keys_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/teams","hooks_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/hooks","issue_events_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/events","assignees_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/tags","blobs_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/languages","stargazers_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/stargazers","contributors_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/contributors","subscribers_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/subscribers","subscription_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/subscription","commits_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/merges","archive_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/downloads","issues_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/labels{/name}","releases_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/DR3EVR8u8c/librenms/deployments","created_at":"2018-05-12T05:51:10Z","updated_at":"2018-10-11T20:17:11Z","pushed_at":"2018-10-11T20:17:09Z","git_url":"git://github.com/DR3EVR8u8c/librenms.git","ssh_url":"git@github.com:DR3EVR8u8c/librenms.git","clone_url":"https://github.com/DR3EVR8u8c/librenms.git","svn_url":"https://github.com/DR3EVR8u8c/librenms","homepage":"http://www.librenms.org/","size":135608,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"df90881be1576cb260a79cdfc539fe4f012d1b3b","user":{"login":"librenms","id":5791783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTE3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNDExNg==","name":"librenms","full_name":"librenms/librenms","private":false,"owner":{"login":"librenms","id":5791783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTE3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2018-10-11T19:30:13Z","pushed_at":"2018-10-11T20:29:02Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":136480,"stargazers_count":1182,"watchers_count":1182,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":893,"open_issues":122,"watchers":1182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9311"},"html":{"href":"https://github.com/librenms/librenms/pull/9311"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/9311"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/9311/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9311/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9311/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/9e03cbd2fe67e232b690e582a6e5819bbae2e47a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":7,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"DR3EVR8u8c"}}