{"action":"created","comment":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/comments/181050089","pull_request_review_id":111582307,"id":181050089,"diff_hunk":"@@ -0,0 +1,526 @@\n+{","path":"odl/contrib/shearlab/examples/Benchmarks.ipynb","position":1,"original_position":1,"commit_id":"cd1f80140373224ea28e7e3e17b6217fc53ace94","original_commit_id":"cd1f80140373224ea28e7e3e17b6217fc53ace94","user":{"login":"kohr-h","id":5030250,"avatar_url":"https://avatars2.githubusercontent.com/u/5030250?v=4","gravatar_id":"","url":"https://api.github.com/users/kohr-h","html_url":"https://github.com/kohr-h","followers_url":"https://api.github.com/users/kohr-h/followers","following_url":"https://api.github.com/users/kohr-h/following{/other_user}","gists_url":"https://api.github.com/users/kohr-h/gists{/gist_id}","starred_url":"https://api.github.com/users/kohr-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohr-h/subscriptions","organizations_url":"https://api.github.com/users/kohr-h/orgs","repos_url":"https://api.github.com/users/kohr-h/repos","events_url":"https://api.github.com/users/kohr-h/events{/privacy}","received_events_url":"https://api.github.com/users/kohr-h/received_events","type":"User","site_admin":false},"body":"Great to have benchmarks!\r\n\r\nJust two remarks on this:\r\n- Please import the functions from the module instead of copying the code into the notebook:\r\n   ```python\r\n   from odl.contrib.shearlab.shearlab_operator import (\r\n       <function names go here>)\r\n   ```\r\n- If you like, use `odl.util.Timer` instead of `tic` and `toc`, the output will be a bit more informative:\r\n   ```python\r\n   >>> with odl.util.Timer('Time for sleep(1.5)'):\r\n   ...     sleep(1.5)\r\n   Time for sleep(1.5) :      1.513\r\n   ```","created_at":"2018-04-12T11:36:45Z","updated_at":"2018-04-12T11:36:45Z","html_url":"https://github.com/odlgroup/odl/pull/1322#discussion_r181050089","pull_request_url":"https://api.github.com/repos/odlgroup/odl/pulls/1322","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments/181050089"},"html":{"href":"https://github.com/odlgroup/odl/pull/1322#discussion_r181050089"},"pull_request":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1322"}}},"pull_request":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/1322","id":180265077,"html_url":"https://github.com/odlgroup/odl/pull/1322","diff_url":"https://github.com/odlgroup/odl/pull/1322.diff","patch_url":"https://github.com/odlgroup/odl/pull/1322.patch","issue_url":"https://api.github.com/repos/odlgroup/odl/issues/1322","number":1322,"state":"open","locked":false,"title":"Adding shearlab.jl submodule","user":{"login":"arsenal9971","id":9786736,"avatar_url":"https://avatars0.githubusercontent.com/u/9786736?v=4","gravatar_id":"","url":"https://api.github.com/users/arsenal9971","html_url":"https://github.com/arsenal9971","followers_url":"https://api.github.com/users/arsenal9971/followers","following_url":"https://api.github.com/users/arsenal9971/following{/other_user}","gists_url":"https://api.github.com/users/arsenal9971/gists{/gist_id}","starred_url":"https://api.github.com/users/arsenal9971/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsenal9971/subscriptions","organizations_url":"https://api.github.com/users/arsenal9971/orgs","repos_url":"https://api.github.com/users/arsenal9971/repos","events_url":"https://api.github.com/users/arsenal9971/events{/privacy}","received_events_url":"https://api.github.com/users/arsenal9971/received_events","type":"User","site_admin":false},"body":"Adding shearlab.jl backend submodule on odl","created_at":"2018-04-09T10:06:36Z","updated_at":"2018-04-12T11:36:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ca562f4fb88db3e59354e51eec2e8bd5763b5f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/odlgroup/odl/pulls/1322/commits","review_comments_url":"https://api.github.com/repos/odlgroup/odl/pulls/1322/comments","review_comment_url":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odlgroup/odl/issues/1322/comments","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/cd1f80140373224ea28e7e3e17b6217fc53ace94","head":{"label":"arsenal9971:master","ref":"master","sha":"cd1f80140373224ea28e7e3e17b6217fc53ace94","user":{"login":"arsenal9971","id":9786736,"avatar_url":"https://avatars0.githubusercontent.com/u/9786736?v=4","gravatar_id":"","url":"https://api.github.com/users/arsenal9971","html_url":"https://github.com/arsenal9971","followers_url":"https://api.github.com/users/arsenal9971/followers","following_url":"https://api.github.com/users/arsenal9971/following{/other_user}","gists_url":"https://api.github.com/users/arsenal9971/gists{/gist_id}","starred_url":"https://api.github.com/users/arsenal9971/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsenal9971/subscriptions","organizations_url":"https://api.github.com/users/arsenal9971/orgs","repos_url":"https://api.github.com/users/arsenal9971/repos","events_url":"https://api.github.com/users/arsenal9971/events{/privacy}","received_events_url":"https://api.github.com/users/arsenal9971/received_events","type":"User","site_admin":false},"repo":{"id":128623865,"name":"odl","full_name":"arsenal9971/odl","owner":{"login":"arsenal9971","id":9786736,"avatar_url":"https://avatars0.githubusercontent.com/u/9786736?v=4","gravatar_id":"","url":"https://api.github.com/users/arsenal9971","html_url":"https://github.com/arsenal9971","followers_url":"https://api.github.com/users/arsenal9971/followers","following_url":"https://api.github.com/users/arsenal9971/following{/other_user}","gists_url":"https://api.github.com/users/arsenal9971/gists{/gist_id}","starred_url":"https://api.github.com/users/arsenal9971/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsenal9971/subscriptions","organizations_url":"https://api.github.com/users/arsenal9971/orgs","repos_url":"https://api.github.com/users/arsenal9971/repos","events_url":"https://api.github.com/users/arsenal9971/events{/privacy}","received_events_url":"https://api.github.com/users/arsenal9971/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arsenal9971/odl","description":"Operator Discretization Library  https://odlgroup.github.io/odl/","fork":true,"url":"https://api.github.com/repos/arsenal9971/odl","forks_url":"https://api.github.com/repos/arsenal9971/odl/forks","keys_url":"https://api.github.com/repos/arsenal9971/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arsenal9971/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arsenal9971/odl/teams","hooks_url":"https://api.github.com/repos/arsenal9971/odl/hooks","issue_events_url":"https://api.github.com/repos/arsenal9971/odl/issues/events{/number}","events_url":"https://api.github.com/repos/arsenal9971/odl/events","assignees_url":"https://api.github.com/repos/arsenal9971/odl/assignees{/user}","branches_url":"https://api.github.com/repos/arsenal9971/odl/branches{/branch}","tags_url":"https://api.github.com/repos/arsenal9971/odl/tags","blobs_url":"https://api.github.com/repos/arsenal9971/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arsenal9971/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arsenal9971/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/arsenal9971/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arsenal9971/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/arsenal9971/odl/languages","stargazers_url":"https://api.github.com/repos/arsenal9971/odl/stargazers","contributors_url":"https://api.github.com/repos/arsenal9971/odl/contributors","subscribers_url":"https://api.github.com/repos/arsenal9971/odl/subscribers","subscription_url":"https://api.github.com/repos/arsenal9971/odl/subscription","commits_url":"https://api.github.com/repos/arsenal9971/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/arsenal9971/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/arsenal9971/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/arsenal9971/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/arsenal9971/odl/contents/{+path}","compare_url":"https://api.github.com/repos/arsenal9971/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arsenal9971/odl/merges","archive_url":"https://api.github.com/repos/arsenal9971/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arsenal9971/odl/downloads","issues_url":"https://api.github.com/repos/arsenal9971/odl/issues{/number}","pulls_url":"https://api.github.com/repos/arsenal9971/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/arsenal9971/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/arsenal9971/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arsenal9971/odl/labels{/name}","releases_url":"https://api.github.com/repos/arsenal9971/odl/releases{/id}","deployments_url":"https://api.github.com/repos/arsenal9971/odl/deployments","created_at":"2018-04-08T09:26:18Z","updated_at":"2018-04-12T09:56:54Z","pushed_at":"2018-04-12T09:56:52Z","git_url":"git://github.com/arsenal9971/odl.git","ssh_url":"git@github.com:arsenal9971/odl.git","clone_url":"https://github.com/arsenal9971/odl.git","svn_url":"https://github.com/arsenal9971/odl","homepage":"","size":33556,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odlgroup:master","ref":"master","sha":"80e2676f206b300987e30134b35c855d9b7bba35","user":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45596393,"name":"odl","full_name":"odlgroup/odl","owner":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars1.githubusercontent.com/u/15667171?v=4","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odlgroup/odl","description":"Operator Discretization Library  https://odlgroup.github.io/odl/","fork":false,"url":"https://api.github.com/repos/odlgroup/odl","forks_url":"https://api.github.com/repos/odlgroup/odl/forks","keys_url":"https://api.github.com/repos/odlgroup/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odlgroup/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odlgroup/odl/teams","hooks_url":"https://api.github.com/repos/odlgroup/odl/hooks","issue_events_url":"https://api.github.com/repos/odlgroup/odl/issues/events{/number}","events_url":"https://api.github.com/repos/odlgroup/odl/events","assignees_url":"https://api.github.com/repos/odlgroup/odl/assignees{/user}","branches_url":"https://api.github.com/repos/odlgroup/odl/branches{/branch}","tags_url":"https://api.github.com/repos/odlgroup/odl/tags","blobs_url":"https://api.github.com/repos/odlgroup/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odlgroup/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odlgroup/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/odlgroup/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/odlgroup/odl/languages","stargazers_url":"https://api.github.com/repos/odlgroup/odl/stargazers","contributors_url":"https://api.github.com/repos/odlgroup/odl/contributors","subscribers_url":"https://api.github.com/repos/odlgroup/odl/subscribers","subscription_url":"https://api.github.com/repos/odlgroup/odl/subscription","commits_url":"https://api.github.com/repos/odlgroup/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/odlgroup/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/odlgroup/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/odlgroup/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/odlgroup/odl/contents/{+path}","compare_url":"https://api.github.com/repos/odlgroup/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odlgroup/odl/merges","archive_url":"https://api.github.com/repos/odlgroup/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odlgroup/odl/downloads","issues_url":"https://api.github.com/repos/odlgroup/odl/issues{/number}","pulls_url":"https://api.github.com/repos/odlgroup/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/odlgroup/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/odlgroup/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odlgroup/odl/labels{/name}","releases_url":"https://api.github.com/repos/odlgroup/odl/releases{/id}","deployments_url":"https://api.github.com/repos/odlgroup/odl/deployments","created_at":"2015-11-05T07:57:55Z","updated_at":"2018-04-12T10:14:01Z","pushed_at":"2018-04-12T09:56:54Z","git_url":"git://github.com/odlgroup/odl.git","ssh_url":"git@github.com:odlgroup/odl.git","clone_url":"https://github.com/odlgroup/odl.git","svn_url":"https://github.com/odlgroup/odl","homepage":"","size":34210,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":35,"open_issues":187,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1322"},"html":{"href":"https://github.com/odlgroup/odl/pull/1322"},"issue":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1322"},"comments":{"href":"https://api.github.com/repos/odlgroup/odl/issues/1322/comments"},"review_comments":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1322/comments"},"review_comment":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/1322/commits"},"statuses":{"href":"https://api.github.com/repos/odlgroup/odl/statuses/cd1f80140373224ea28e7e3e17b6217fc53ace94"}},"author_association":"NONE"}}
{"actor":{"display_login":"kohr-h"}}