{"action":"opened","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2528","repository_url":"https://api.github.com/repos/Microsoft/vscode-cpptools","labels_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2528/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2528/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/2528/events","html_url":"https://github.com/Microsoft/vscode-cpptools/issues/2528","id":361270601,"node_id":"MDU6SXNzdWUzNjEyNzA2MDE=","number":2528,"title":"\"Go to Definition/Declaration\" in file with UNC path opens new tab","user":{"login":"Niko-O","id":4943909,"node_id":"MDQ6VXNlcjQ5NDM5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4943909?v=4","gravatar_id":"","url":"https://api.github.com/users/Niko-O","html_url":"https://github.com/Niko-O","followers_url":"https://api.github.com/users/Niko-O/followers","following_url":"https://api.github.com/users/Niko-O/following{/other_user}","gists_url":"https://api.github.com/users/Niko-O/gists{/gist_id}","starred_url":"https://api.github.com/users/Niko-O/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niko-O/subscriptions","organizations_url":"https://api.github.com/users/Niko-O/orgs","repos_url":"https://api.github.com/users/Niko-O/repos","events_url":"https://api.github.com/users/Niko-O/events{/privacy}","received_events_url":"https://api.github.com/users/Niko-O/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-18T12:03:09Z","updated_at":"2018-09-18T12:03:09Z","closed_at":null,"author_association":"NONE","body":"**Type: LanguageService**\r\n\r\n**Describe the bug**\r\n- OS and Version: Windows 10 (10.0.17134.285) 64 bit\r\n- VS Code Version:\r\n```\r\n\tVersion 1.14.2\r\n\tCommit cb82febafda0c8c199b9201ad274e25d9a76874e\r\n\tDatum 2017-07-19T23:34:09.706Z\r\n\tShell 1.6.6\r\n\tRenderer 56.0.2924.87\r\n\tNode 7.4.0\r\n```\r\n- C/C++ Extension Version: 0.14.0\r\n- Other extensions you installed (and if the issue persists after disabling them):\r\n  - hexdump for VSCode\r\n  - Intel HEX format\r\n  - macros\r\n  - Yes, the issue persists after disabling all extensions (except for `C/C++`, of course).\r\n- A clear and concise description of what the bug is:\r\nWhen using the \"Go to Definition\" or \"Go to Declaration\" commands in a `.h`, `.c` or `.cpp` file, if the file where the declaration/definition resides is opened with a UNC path (e.g. something like `\\\\A\\B\\C\\D.E`), then the first part of the path to that file (`\\\\A\\B`) is converted to lower case before opening. For example: If the target file is `\\\\Bar\\Foo\\Baz\\Test.c`, then the file `\\\\bar\\foo\\Baz\\Test.c\\ will be opened instead.\r\nThis causes a new tab to appear in most cases, even though both file paths, in practice, point to the same file.\r\n\r\n**To Reproduce**\r\n1. In Windows Explorer, create a new folder called `Foo` anywhere you have access to (e.g. on your Desktop).\r\n2. Right click on the folder, select \"Properties\".\r\n3. In the tab \"Sharing\" click on \"Advanced Sharing\".\r\n4. Enable \"Share this folder\" and click \"OK\".\r\n5. Note the path shown below \"Network path\" in the properties dialog and click OK.\r\n6. Create a new folder called `Baz` in `Foo`.\r\n7. Create a new file called `Test.c` in `Baz` and insert this code:\r\n```\r\nint x = 0;\r\nvoid y()\r\n{\r\n    x = 1;\r\n}\r\n```\r\n8. Open a new instance of Visual Studio Code.\r\n9. In the menu \"File\" click on \"Open Folder\".\r\n10. In the address bar of the dialog, type the UNC path to `Foo` as noted above, hit Enter and click \"Select Folder\".\r\n11. In the explorer panel, expand `Baz` and double click on `Test.c`.\r\n12. Right click on `x` in line 4 and click on \"Go to Declaration\".\r\n13. Observe that, even though the declaration is in the currently opened file, a new tab is opened.\r\n14. Hover over the tab headers to see the full paths. The already open file reads `\\\\Bar\\Foo\\Baz\\Test.c` while the newly opened file reads `\\\\bar\\foo\\Baz\\Test.c`.\r\n\r\n**Expected behavior**\r\nAfter executing step 12, the editor should have simply scrolled to line 1 in the same file. It should not have opened a separate tab.\r\n\r\n**Screenshots**\r\n![share](https://user-images.githubusercontent.com/4943909/45685184-d3305680-bb48-11e8-8844-ed5ecab42665.png)\r\n<!-- If applicable, add screenshots to help explain your problem. -->\r\n![Paths](https://user-images.githubusercontent.com/4943909/45684812-bb0c0780-bb47-11e8-84c3-72c5e330e0d8.png)\r\n\r\n**Additional context**\r\nIt appears that, according to the change log, there is a newer version of the extension available (0.18.1), but Visual Studio Code does not show a button which would allow me to update.\r\n![update](https://user-images.githubusercontent.com/4943909/45686005-7c784c00-bb4b-11e8-9cc2-b64adcd8663e.png)\r\n"}}
{"actor":{"display_login":"Niko-O"}}