{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/coreos-assembler/issues/150","repository_url":"https://api.github.com/repos/coreos/coreos-assembler","labels_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/150/comments","events_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/150/events","html_url":"https://github.com/coreos/coreos-assembler/pull/150","id":367452724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODgzNTI1","number":150,"title":"cmd-build: Add --no-resume","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-06T12:27:37Z","updated_at":"2018-10-09T14:32:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coreos/coreos-assembler/pulls/150","html_url":"https://github.com/coreos/coreos-assembler/pull/150","diff_url":"https://github.com/coreos/coreos-assembler/pull/150.diff","patch_url":"https://github.com/coreos/coreos-assembler/pull/150.patch"},"body":"For automation in Jenkins, I think we generally don't want the\r\nmagic bits to handle the case where treecompose succeeded but\r\nimage build fails.\r\n\r\nOr rather, what we'll do in that case is not sync out the ostree\r\nrepo at all."},"comment":{"url":"https://api.github.com/repos/coreos/coreos-assembler/issues/comments/428216007","html_url":"https://github.com/coreos/coreos-assembler/pull/150#issuecomment-428216007","issue_url":"https://api.github.com/repos/coreos/coreos-assembler/issues/150","id":428216007,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODIxNjAwNw==","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T14:32:41Z","updated_at":"2018-10-09T14:32:41Z","author_association":"MEMBER","body":"Can you expand on what we're trying to solve here? If the treecompose passes but the image generation fails, then we don't sync. Depending on whether we e.g. re-pull the OSTree repo before each run, or wipe the workspace, then there's no need to worry about this right? (I.e. the build script won't even know that the previous build failed). Even if we leave the workdir around so that resuming is possible, then we're resuming only if the treecompose didn't change but still pushing both OSTree and images out at the same time, right?\r\n\r\nIOW, isn't this just a matter of making sure the pipeline job only rsyncs out if `coreos-assembler build` finishes successfully?"}}
{"actor":{"display_login":"jlebon"}}