{"action":"created","comment":{"url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/comments/240005878","pull_request_review_id":182945243,"id":240005878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAwNTg3OA==","diff_hunk":"@@ -459,6 +465,17 @@ static PHP_METHOD(amqp_connection_class, __construct)\n \t\t}\n \t}\n \n+\tzend_update_property_double(this_ce, getThis(), ZEND_STRL(\"rpc_timeout\"), INI_FLT(\"amqp.rpc_timeout\") TSRMLS_CC);\n+\n+\tif (ini_arr && PHP5to7_ZEND_HASH_FIND(HASH_OF(ini_arr), \"rpc_timeout\", sizeof(\"rpc_timeout\"), zdata)) {","path":"amqp_connection.c","position":28,"original_position":28,"commit_id":"ba9e93cc25a8bf05b63774897e41a6ccd2aa9859","original_commit_id":"ba9e93cc25a8bf05b63774897e41a6ccd2aa9859","user":{"login":"lstrojny","id":79707,"node_id":"MDQ6VXNlcjc5NzA3","avatar_url":"https://avatars2.githubusercontent.com/u/79707?v=4","gravatar_id":"","url":"https://api.github.com/users/lstrojny","html_url":"https://github.com/lstrojny","followers_url":"https://api.github.com/users/lstrojny/followers","following_url":"https://api.github.com/users/lstrojny/following{/other_user}","gists_url":"https://api.github.com/users/lstrojny/gists{/gist_id}","starred_url":"https://api.github.com/users/lstrojny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lstrojny/subscriptions","organizations_url":"https://api.github.com/users/lstrojny/orgs","repos_url":"https://api.github.com/users/lstrojny/repos","events_url":"https://api.github.com/users/lstrojny/events{/privacy}","received_events_url":"https://api.github.com/users/lstrojny/received_events","type":"User","site_admin":false},"body":"Sounds good, let’s go with \"0\" instead","created_at":"2018-12-08T14:07:19Z","updated_at":"2018-12-08T14:07:19Z","html_url":"https://github.com/pdezwart/php-amqp/pull/334#discussion_r240005878","pull_request_url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/comments/240005878"},"html":{"href":"https://github.com/pdezwart/php-amqp/pull/334#discussion_r240005878"},"pull_request":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334"}},"in_reply_to_id":228706837},"pull_request":{"url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334","id":225548424,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTQ4NDI0","html_url":"https://github.com/pdezwart/php-amqp/pull/334","diff_url":"https://github.com/pdezwart/php-amqp/pull/334.diff","patch_url":"https://github.com/pdezwart/php-amqp/pull/334.patch","issue_url":"https://api.github.com/repos/pdezwart/php-amqp/issues/334","number":334,"state":"open","locked":false,"title":"Make use of rpc_timeout in newer librabbitmq by introducing new constructor hash parameter","user":{"login":"modulatix","id":3957830,"node_id":"MDQ6VXNlcjM5NTc4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3957830?v=4","gravatar_id":"","url":"https://api.github.com/users/modulatix","html_url":"https://github.com/modulatix","followers_url":"https://api.github.com/users/modulatix/followers","following_url":"https://api.github.com/users/modulatix/following{/other_user}","gists_url":"https://api.github.com/users/modulatix/gists{/gist_id}","starred_url":"https://api.github.com/users/modulatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modulatix/subscriptions","organizations_url":"https://api.github.com/users/modulatix/orgs","repos_url":"https://api.github.com/users/modulatix/repos","events_url":"https://api.github.com/users/modulatix/events{/privacy}","received_events_url":"https://api.github.com/users/modulatix/received_events","type":"User","site_admin":false},"body":"This allows timeout to work while libbabbitmq is in poll() which may happen when connection is in blocked state caused by low resources on rabbitmq server.\r\n\r\nCloses #333 ","created_at":"2018-10-24T20:57:56Z","updated_at":"2018-12-08T14:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7defda8ef83c567f91592b173cf9b78927cc2fd1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334/commits","review_comments_url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334/comments","review_comment_url":"https://api.github.com/repos/pdezwart/php-amqp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pdezwart/php-amqp/issues/334/comments","statuses_url":"https://api.github.com/repos/pdezwart/php-amqp/statuses/ba9e93cc25a8bf05b63774897e41a6ccd2aa9859","head":{"label":"modulatix:master","ref":"master","sha":"ba9e93cc25a8bf05b63774897e41a6ccd2aa9859","user":{"login":"modulatix","id":3957830,"node_id":"MDQ6VXNlcjM5NTc4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3957830?v=4","gravatar_id":"","url":"https://api.github.com/users/modulatix","html_url":"https://github.com/modulatix","followers_url":"https://api.github.com/users/modulatix/followers","following_url":"https://api.github.com/users/modulatix/following{/other_user}","gists_url":"https://api.github.com/users/modulatix/gists{/gist_id}","starred_url":"https://api.github.com/users/modulatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modulatix/subscriptions","organizations_url":"https://api.github.com/users/modulatix/orgs","repos_url":"https://api.github.com/users/modulatix/repos","events_url":"https://api.github.com/users/modulatix/events{/privacy}","received_events_url":"https://api.github.com/users/modulatix/received_events","type":"User","site_admin":false},"repo":{"id":154561990,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NjE5OTA=","name":"php-amqp","full_name":"modulatix/php-amqp","private":false,"owner":{"login":"modulatix","id":3957830,"node_id":"MDQ6VXNlcjM5NTc4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3957830?v=4","gravatar_id":"","url":"https://api.github.com/users/modulatix","html_url":"https://github.com/modulatix","followers_url":"https://api.github.com/users/modulatix/followers","following_url":"https://api.github.com/users/modulatix/following{/other_user}","gists_url":"https://api.github.com/users/modulatix/gists{/gist_id}","starred_url":"https://api.github.com/users/modulatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modulatix/subscriptions","organizations_url":"https://api.github.com/users/modulatix/orgs","repos_url":"https://api.github.com/users/modulatix/repos","events_url":"https://api.github.com/users/modulatix/events{/privacy}","received_events_url":"https://api.github.com/users/modulatix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/modulatix/php-amqp","description":"PHP AMQP Binding Library","fork":true,"url":"https://api.github.com/repos/modulatix/php-amqp","forks_url":"https://api.github.com/repos/modulatix/php-amqp/forks","keys_url":"https://api.github.com/repos/modulatix/php-amqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modulatix/php-amqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modulatix/php-amqp/teams","hooks_url":"https://api.github.com/repos/modulatix/php-amqp/hooks","issue_events_url":"https://api.github.com/repos/modulatix/php-amqp/issues/events{/number}","events_url":"https://api.github.com/repos/modulatix/php-amqp/events","assignees_url":"https://api.github.com/repos/modulatix/php-amqp/assignees{/user}","branches_url":"https://api.github.com/repos/modulatix/php-amqp/branches{/branch}","tags_url":"https://api.github.com/repos/modulatix/php-amqp/tags","blobs_url":"https://api.github.com/repos/modulatix/php-amqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modulatix/php-amqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modulatix/php-amqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/modulatix/php-amqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modulatix/php-amqp/statuses/{sha}","languages_url":"https://api.github.com/repos/modulatix/php-amqp/languages","stargazers_url":"https://api.github.com/repos/modulatix/php-amqp/stargazers","contributors_url":"https://api.github.com/repos/modulatix/php-amqp/contributors","subscribers_url":"https://api.github.com/repos/modulatix/php-amqp/subscribers","subscription_url":"https://api.github.com/repos/modulatix/php-amqp/subscription","commits_url":"https://api.github.com/repos/modulatix/php-amqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/modulatix/php-amqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/modulatix/php-amqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/modulatix/php-amqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/modulatix/php-amqp/contents/{+path}","compare_url":"https://api.github.com/repos/modulatix/php-amqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modulatix/php-amqp/merges","archive_url":"https://api.github.com/repos/modulatix/php-amqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modulatix/php-amqp/downloads","issues_url":"https://api.github.com/repos/modulatix/php-amqp/issues{/number}","pulls_url":"https://api.github.com/repos/modulatix/php-amqp/pulls{/number}","milestones_url":"https://api.github.com/repos/modulatix/php-amqp/milestones{/number}","notifications_url":"https://api.github.com/repos/modulatix/php-amqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modulatix/php-amqp/labels{/name}","releases_url":"https://api.github.com/repos/modulatix/php-amqp/releases{/id}","deployments_url":"https://api.github.com/repos/modulatix/php-amqp/deployments","created_at":"2018-10-24T20:03:11Z","updated_at":"2018-10-25T12:28:40Z","pushed_at":"2018-10-25T12:28:37Z","git_url":"git://github.com/modulatix/php-amqp.git","ssh_url":"git@github.com:modulatix/php-amqp.git","clone_url":"https://github.com/modulatix/php-amqp.git","svn_url":"https://github.com/modulatix/php-amqp","homepage":null,"size":1036,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pdezwart:master","ref":"master","sha":"a910f7e1d7f61f5c62604c97997e8bb41e00c44f","user":{"login":"pdezwart","id":959860,"node_id":"MDQ6VXNlcjk1OTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/959860?v=4","gravatar_id":"","url":"https://api.github.com/users/pdezwart","html_url":"https://github.com/pdezwart","followers_url":"https://api.github.com/users/pdezwart/followers","following_url":"https://api.github.com/users/pdezwart/following{/other_user}","gists_url":"https://api.github.com/users/pdezwart/gists{/gist_id}","starred_url":"https://api.github.com/users/pdezwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdezwart/subscriptions","organizations_url":"https://api.github.com/users/pdezwart/orgs","repos_url":"https://api.github.com/users/pdezwart/repos","events_url":"https://api.github.com/users/pdezwart/events{/privacy}","received_events_url":"https://api.github.com/users/pdezwart/received_events","type":"User","site_admin":false},"repo":{"id":5734668,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM0NjY4","name":"php-amqp","full_name":"pdezwart/php-amqp","private":false,"owner":{"login":"pdezwart","id":959860,"node_id":"MDQ6VXNlcjk1OTg2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/959860?v=4","gravatar_id":"","url":"https://api.github.com/users/pdezwart","html_url":"https://github.com/pdezwart","followers_url":"https://api.github.com/users/pdezwart/followers","following_url":"https://api.github.com/users/pdezwart/following{/other_user}","gists_url":"https://api.github.com/users/pdezwart/gists{/gist_id}","starred_url":"https://api.github.com/users/pdezwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdezwart/subscriptions","organizations_url":"https://api.github.com/users/pdezwart/orgs","repos_url":"https://api.github.com/users/pdezwart/repos","events_url":"https://api.github.com/users/pdezwart/events{/privacy}","received_events_url":"https://api.github.com/users/pdezwart/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pdezwart/php-amqp","description":"PHP AMQP Binding Library","fork":false,"url":"https://api.github.com/repos/pdezwart/php-amqp","forks_url":"https://api.github.com/repos/pdezwart/php-amqp/forks","keys_url":"https://api.github.com/repos/pdezwart/php-amqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdezwart/php-amqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdezwart/php-amqp/teams","hooks_url":"https://api.github.com/repos/pdezwart/php-amqp/hooks","issue_events_url":"https://api.github.com/repos/pdezwart/php-amqp/issues/events{/number}","events_url":"https://api.github.com/repos/pdezwart/php-amqp/events","assignees_url":"https://api.github.com/repos/pdezwart/php-amqp/assignees{/user}","branches_url":"https://api.github.com/repos/pdezwart/php-amqp/branches{/branch}","tags_url":"https://api.github.com/repos/pdezwart/php-amqp/tags","blobs_url":"https://api.github.com/repos/pdezwart/php-amqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdezwart/php-amqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdezwart/php-amqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdezwart/php-amqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdezwart/php-amqp/statuses/{sha}","languages_url":"https://api.github.com/repos/pdezwart/php-amqp/languages","stargazers_url":"https://api.github.com/repos/pdezwart/php-amqp/stargazers","contributors_url":"https://api.github.com/repos/pdezwart/php-amqp/contributors","subscribers_url":"https://api.github.com/repos/pdezwart/php-amqp/subscribers","subscription_url":"https://api.github.com/repos/pdezwart/php-amqp/subscription","commits_url":"https://api.github.com/repos/pdezwart/php-amqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdezwart/php-amqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdezwart/php-amqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdezwart/php-amqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdezwart/php-amqp/contents/{+path}","compare_url":"https://api.github.com/repos/pdezwart/php-amqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdezwart/php-amqp/merges","archive_url":"https://api.github.com/repos/pdezwart/php-amqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdezwart/php-amqp/downloads","issues_url":"https://api.github.com/repos/pdezwart/php-amqp/issues{/number}","pulls_url":"https://api.github.com/repos/pdezwart/php-amqp/pulls{/number}","milestones_url":"https://api.github.com/repos/pdezwart/php-amqp/milestones{/number}","notifications_url":"https://api.github.com/repos/pdezwart/php-amqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdezwart/php-amqp/labels{/name}","releases_url":"https://api.github.com/repos/pdezwart/php-amqp/releases{/id}","deployments_url":"https://api.github.com/repos/pdezwart/php-amqp/deployments","created_at":"2012-09-09T03:43:19Z","updated_at":"2018-12-06T18:45:58Z","pushed_at":"2018-10-25T12:28:39Z","git_url":"git://github.com/pdezwart/php-amqp.git","ssh_url":"git@github.com:pdezwart/php-amqp.git","clone_url":"https://github.com/pdezwart/php-amqp.git","svn_url":"https://github.com/pdezwart/php-amqp","homepage":null,"size":1028,"stargazers_count":357,"watchers_count":357,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":33,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334"},"html":{"href":"https://github.com/pdezwart/php-amqp/pull/334"},"issue":{"href":"https://api.github.com/repos/pdezwart/php-amqp/issues/334"},"comments":{"href":"https://api.github.com/repos/pdezwart/php-amqp/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pdezwart/php-amqp/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/pdezwart/php-amqp/statuses/ba9e93cc25a8bf05b63774897e41a6ccd2aa9859"}},"author_association":"NONE"}}
{"actor":{"display_login":"lstrojny"}}