{"action":"created","comment":{"url":"https://api.github.com/repos/istio/proxy/pulls/comments/176616842","pull_request_review_id":106353226,"id":176616842,"diff_hunk":"@@ -53,14 +54,19 @@ MixerClientImpl::~MixerClientImpl() {}\n CancelFunc MixerClientImpl::Check(\n     const Attributes &attributes,\n     const std::vector<::istio::quota_config::Requirement> &quotas,\n-    TransportCheckFunc transport, DoneFunc on_done) {\n+    TransportCheckFunc transport, CheckDoneFunc on_done) {\n   ++total_check_calls_;\n \n   std::unique_ptr<CheckCache::CheckResult> check_result(\n       new CheckCache::CheckResult);\n   check_cache_->Check(attributes, check_result.get());\n+\n+  std::unique_ptr<CheckResponseInfo> check_response_info(new CheckResponseInfo);","path":"src/istio/mixerclient/client_impl.cc","position":20,"original_position":20,"commit_id":"dcb67c03718cae9c4735ec6560538178425a58ce","original_commit_id":"dcb67c03718cae9c4735ec6560538178425a58ce","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"not need to new,  just allocate it from stack","created_at":"2018-03-23T01:13:36Z","updated_at":"2018-03-23T01:16:31Z","html_url":"https://github.com/istio/proxy/pull/1242#discussion_r176616842","pull_request_url":"https://api.github.com/repos/istio/proxy/pulls/1242","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments/176616842"},"html":{"href":"https://github.com/istio/proxy/pull/1242#discussion_r176616842"},"pull_request":{"href":"https://api.github.com/repos/istio/proxy/pulls/1242"}}},"pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/1242","id":176947611,"html_url":"https://github.com/istio/proxy/pull/1242","diff_url":"https://github.com/istio/proxy/pull/1242.diff","patch_url":"https://github.com/istio/proxy/pull/1242.patch","issue_url":"https://api.github.com/repos/istio/proxy/issues/1242","number":1242,"state":"open","locked":false,"title":"Check quota cache hit","user":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #1181 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-03-23T00:52:52Z","updated_at":"2018-03-23T01:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b0cc79abcffc4beb02fea5ebee428d849a2c2d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":712050392,"url":"https://api.github.com/repos/istio/proxy/labels/cla:%20yes","name":"cla: yes","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/proxy/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/istio/proxy/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/proxy/issues/1242/comments","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/dcb67c03718cae9c4735ec6560538178425a58ce","head":{"label":"JimmyCYJ:check-quota-cache-hit","ref":"check-quota-cache-hit","sha":"dcb67c03718cae9c4735ec6560538178425a58ce","user":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"repo":{"id":112794018,"name":"proxy","full_name":"JimmyCYJ/proxy","owner":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JimmyCYJ/proxy","description":"The Istio proxy components.","fork":true,"url":"https://api.github.com/repos/JimmyCYJ/proxy","forks_url":"https://api.github.com/repos/JimmyCYJ/proxy/forks","keys_url":"https://api.github.com/repos/JimmyCYJ/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JimmyCYJ/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JimmyCYJ/proxy/teams","hooks_url":"https://api.github.com/repos/JimmyCYJ/proxy/hooks","issue_events_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/JimmyCYJ/proxy/events","assignees_url":"https://api.github.com/repos/JimmyCYJ/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/JimmyCYJ/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/JimmyCYJ/proxy/tags","blobs_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JimmyCYJ/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/JimmyCYJ/proxy/languages","stargazers_url":"https://api.github.com/repos/JimmyCYJ/proxy/stargazers","contributors_url":"https://api.github.com/repos/JimmyCYJ/proxy/contributors","subscribers_url":"https://api.github.com/repos/JimmyCYJ/proxy/subscribers","subscription_url":"https://api.github.com/repos/JimmyCYJ/proxy/subscription","commits_url":"https://api.github.com/repos/JimmyCYJ/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/JimmyCYJ/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/JimmyCYJ/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/JimmyCYJ/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JimmyCYJ/proxy/merges","archive_url":"https://api.github.com/repos/JimmyCYJ/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JimmyCYJ/proxy/downloads","issues_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/JimmyCYJ/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/JimmyCYJ/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/JimmyCYJ/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JimmyCYJ/proxy/labels{/name}","releases_url":"https://api.github.com/repos/JimmyCYJ/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/JimmyCYJ/proxy/deployments","created_at":"2017-12-01T22:42:44Z","updated_at":"2017-12-01T22:42:46Z","pushed_at":"2018-03-23T00:53:03Z","git_url":"git://github.com/JimmyCYJ/proxy.git","ssh_url":"git@github.com:JimmyCYJ/proxy.git","clone_url":"https://github.com/JimmyCYJ/proxy.git","svn_url":"https://github.com/JimmyCYJ/proxy","homepage":"","size":2088,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"d7b9e1ad5f349cf5d2e660e6275d32ef07a49705","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75322405,"name":"proxy","full_name":"istio/proxy","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/proxy","description":"The Istio proxy components.","fork":false,"url":"https://api.github.com/repos/istio/proxy","forks_url":"https://api.github.com/repos/istio/proxy/forks","keys_url":"https://api.github.com/repos/istio/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/proxy/teams","hooks_url":"https://api.github.com/repos/istio/proxy/hooks","issue_events_url":"https://api.github.com/repos/istio/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/proxy/events","assignees_url":"https://api.github.com/repos/istio/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/proxy/tags","blobs_url":"https://api.github.com/repos/istio/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/proxy/languages","stargazers_url":"https://api.github.com/repos/istio/proxy/stargazers","contributors_url":"https://api.github.com/repos/istio/proxy/contributors","subscribers_url":"https://api.github.com/repos/istio/proxy/subscribers","subscription_url":"https://api.github.com/repos/istio/proxy/subscription","commits_url":"https://api.github.com/repos/istio/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/proxy/merges","archive_url":"https://api.github.com/repos/istio/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/proxy/downloads","issues_url":"https://api.github.com/repos/istio/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/proxy/labels{/name}","releases_url":"https://api.github.com/repos/istio/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/proxy/deployments","created_at":"2016-12-01T18:51:04Z","updated_at":"2018-03-23T00:02:53Z","pushed_at":"2018-03-23T00:53:05Z","git_url":"git://github.com/istio/proxy.git","ssh_url":"git@github.com:istio/proxy.git","clone_url":"https://github.com/istio/proxy.git","svn_url":"https://github.com/istio/proxy","homepage":"","size":2274,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":81,"open_issues":38,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/1242"},"html":{"href":"https://github.com/istio/proxy/pull/1242"},"issue":{"href":"https://api.github.com/repos/istio/proxy/issues/1242"},"comments":{"href":"https://api.github.com/repos/istio/proxy/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/proxy/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/proxy/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/istio/proxy/statuses/dcb67c03718cae9c4735ec6560538178425a58ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qiwzhang"}}