{"action":"created","comment":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/244983289","pull_request_review_id":188990114,"id":244983289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk4MzI4OQ==","diff_hunk":"@@ -1356,7 +1356,14 @@ function show_actions_done($conf, $langs, $db, $filterobj, $objcon='', $noprint=\n         elseif (is_object($filterobj) && get_class($filterobj) == 'Ticket') $sql.= \", \".MAIN_DB_PREFIX.\"ticket as o\";\n \n         $sql.= \" WHERE a.entity IN (\".getEntity('agenda').\")\";\n-        if (is_object($filterobj) && in_array(get_class($filterobj), array('Societe', 'Client', 'Fournisseur')) && $filterobj->id) $sql.= \" AND a.fk_soc = \".$filterobj->id;\n+\n+\t    // Work with new table actioncomm_resources and multiple contact affectation.\n+\t    if (is_object($objcon) && $objcon->id)","path":"htdocs/core/lib/company.lib.php","position":7,"original_position":7,"commit_id":"b7574b5487adaf567cd9616e116c0253cc099b72","original_commit_id":"b7574b5487adaf567cd9616e116c0253cc099b72","user":{"login":"eldy","id":883887,"node_id":"MDQ6VXNlcjg4Mzg4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/883887?v=4","gravatar_id":"","url":"https://api.github.com/users/eldy","html_url":"https://github.com/eldy","followers_url":"https://api.github.com/users/eldy/followers","following_url":"https://api.github.com/users/eldy/following{/other_user}","gists_url":"https://api.github.com/users/eldy/gists{/gist_id}","starred_url":"https://api.github.com/users/eldy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldy/subscriptions","organizations_url":"https://api.github.com/users/eldy/orgs","repos_url":"https://api.github.com/users/eldy/repos","events_url":"https://api.github.com/users/eldy/events{/privacy}","received_events_url":"https://api.github.com/users/eldy/received_events","type":"User","site_admin":false},"body":"If you introduce a if here before the elseif, all conditions after, on $filterobj (for example filter on project), will not be added.","created_at":"2019-01-03T12:21:13Z","updated_at":"2019-01-03T12:21:13Z","html_url":"https://github.com/Dolibarr/dolibarr/pull/10297#discussion_r244983289","pull_request_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/244983289"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/10297#discussion_r244983289"},"pull_request":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297"}}},"pull_request":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297","id":241939520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTM5NTIw","html_url":"https://github.com/Dolibarr/dolibarr/pull/10297","diff_url":"https://github.com/Dolibarr/dolibarr/pull/10297.diff","patch_url":"https://github.com/Dolibarr/dolibarr/pull/10297.patch","issue_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/10297","number":10297,"state":"open","locked":false,"title":"FIX PR #9972 Correctly display multiple contacts events when contact has company","user":{"login":"francois-opendsi","id":32769270,"node_id":"MDQ6VXNlcjMyNzY5Mjcw","avatar_url":"https://avatars0.githubusercontent.com/u/32769270?v=4","gravatar_id":"","url":"https://api.github.com/users/francois-opendsi","html_url":"https://github.com/francois-opendsi","followers_url":"https://api.github.com/users/francois-opendsi/followers","following_url":"https://api.github.com/users/francois-opendsi/following{/other_user}","gists_url":"https://api.github.com/users/francois-opendsi/gists{/gist_id}","starred_url":"https://api.github.com/users/francois-opendsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francois-opendsi/subscriptions","organizations_url":"https://api.github.com/users/francois-opendsi/orgs","repos_url":"https://api.github.com/users/francois-opendsi/repos","events_url":"https://api.github.com/users/francois-opendsi/events{/privacy}","received_events_url":"https://api.github.com/users/francois-opendsi/received_events","type":"User","site_admin":false},"body":"# Fix PR #9972\r\nFix regression introduced by Pull Request #9972 that was already merged into the `develop` branch.\r\n\r\nCorrectly display multiple contacts events when contact is linked to a company: fix SQL query.","created_at":"2019-01-03T09:18:17Z","updated_at":"2019-01-03T12:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38238f483bdb14a2791f0ecba275df84f3436d12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297/commits","review_comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297/comments","review_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/10297/comments","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/b7574b5487adaf567cd9616e116c0253cc099b72","head":{"label":"OPEN-DSI:fix-contact-agenda-multiple-resources","ref":"fix-contact-agenda-multiple-resources","sha":"b7574b5487adaf567cd9616e116c0253cc099b72","user":{"login":"OPEN-DSI","id":17143993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQzOTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17143993?v=4","gravatar_id":"","url":"https://api.github.com/users/OPEN-DSI","html_url":"https://github.com/OPEN-DSI","followers_url":"https://api.github.com/users/OPEN-DSI/followers","following_url":"https://api.github.com/users/OPEN-DSI/following{/other_user}","gists_url":"https://api.github.com/users/OPEN-DSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OPEN-DSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPEN-DSI/subscriptions","organizations_url":"https://api.github.com/users/OPEN-DSI/orgs","repos_url":"https://api.github.com/users/OPEN-DSI/repos","events_url":"https://api.github.com/users/OPEN-DSI/events{/privacy}","received_events_url":"https://api.github.com/users/OPEN-DSI/received_events","type":"Organization","site_admin":false},"repo":{"id":87967689,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzk2NzY4OQ==","name":"dolibarr","full_name":"OPEN-DSI/dolibarr","private":false,"owner":{"login":"OPEN-DSI","id":17143993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQzOTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17143993?v=4","gravatar_id":"","url":"https://api.github.com/users/OPEN-DSI","html_url":"https://github.com/OPEN-DSI","followers_url":"https://api.github.com/users/OPEN-DSI/followers","following_url":"https://api.github.com/users/OPEN-DSI/following{/other_user}","gists_url":"https://api.github.com/users/OPEN-DSI/gists{/gist_id}","starred_url":"https://api.github.com/users/OPEN-DSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPEN-DSI/subscriptions","organizations_url":"https://api.github.com/users/OPEN-DSI/orgs","repos_url":"https://api.github.com/users/OPEN-DSI/repos","events_url":"https://api.github.com/users/OPEN-DSI/events{/privacy}","received_events_url":"https://api.github.com/users/OPEN-DSI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OPEN-DSI/dolibarr","description":"Dolibarr ERP CRM is a modern software package to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":true,"url":"https://api.github.com/repos/OPEN-DSI/dolibarr","forks_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/forks","keys_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/teams","hooks_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/events","assignees_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/tags","blobs_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/languages","stargazers_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/subscription","commits_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/merges","archive_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/downloads","issues_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/OPEN-DSI/dolibarr/deployments","created_at":"2017-04-11T18:42:07Z","updated_at":"2018-12-12T13:22:03Z","pushed_at":"2019-01-03T09:11:20Z","git_url":"git://github.com/OPEN-DSI/dolibarr.git","ssh_url":"git@github.com:OPEN-DSI/dolibarr.git","clone_url":"https://github.com/OPEN-DSI/dolibarr.git","svn_url":"https://github.com/OPEN-DSI/dolibarr","homepage":"https://www.dolibarr.org","size":518889,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Dolibarr:develop","ref":"develop","sha":"5ebada065fca8db8474ff85239ca6b97a1d068c5","user":{"login":"Dolibarr","id":877491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NzQ5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"repo":{"id":1957456,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3NDU2","name":"dolibarr","full_name":"Dolibarr/dolibarr","private":false,"owner":{"login":"Dolibarr","id":877491,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NzQ5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Dolibarr/dolibarr","description":"Dolibarr ERP CRM is a modern software package to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":false,"url":"https://api.github.com/repos/Dolibarr/dolibarr","forks_url":"https://api.github.com/repos/Dolibarr/dolibarr/forks","keys_url":"https://api.github.com/repos/Dolibarr/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolibarr/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolibarr/dolibarr/teams","hooks_url":"https://api.github.com/repos/Dolibarr/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/Dolibarr/dolibarr/events","assignees_url":"https://api.github.com/repos/Dolibarr/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/Dolibarr/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/tags","blobs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolibarr/dolibarr/languages","stargazers_url":"https://api.github.com/repos/Dolibarr/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/Dolibarr/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscription","commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dolibarr/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/Dolibarr/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolibarr/dolibarr/merges","archive_url":"https://api.github.com/repos/Dolibarr/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolibarr/dolibarr/downloads","issues_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolibarr/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolibarr/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolibarr/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/Dolibarr/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/Dolibarr/dolibarr/deployments","created_at":"2011-06-26T21:55:03Z","updated_at":"2019-01-03T11:58:29Z","pushed_at":"2019-01-03T12:00:17Z","git_url":"git://github.com/Dolibarr/dolibarr.git","ssh_url":"git@github.com:Dolibarr/dolibarr.git","clone_url":"https://github.com/Dolibarr/dolibarr.git","svn_url":"https://github.com/Dolibarr/dolibarr","homepage":"https://www.dolibarr.org","size":516898,"stargazers_count":1232,"watchers_count":1232,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":935,"mirror_url":null,"archived":false,"open_issues_count":959,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":935,"open_issues":959,"watchers":1232,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/10297"},"issue":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/10297"},"comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/10297/comments"},"review_comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297/comments"},"review_comment":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/10297/commits"},"statuses":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/b7574b5487adaf567cd9616e116c0253cc099b72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eldy"}}