{"action":"created","comment":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/comments/199223719","pull_request_review_id":133306014,"id":199223719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTIyMzcxOQ==","diff_hunk":"@@ -789,7 +789,7 @@ func (scw *SplitCloneWorker) waitForTablets(ctx context.Context, shardInfos []*t\n \t\t\t// We wait for --min_healthy_rdonly_tablets because we will use several\n \t\t\t// tablets per shard to spread reading the chunks of rows across as many\n \t\t\t// tablets as possible.\n-\t\t\tif _, err := waitForHealthyRdonlyTablets(ctx, scw.wr, scw.tsc, scw.cell, keyspace, shard, scw.minHealthyRdonlyTablets, timeout); err != nil {\n+\t\t\tif _, err := waitForHealthyTablets(ctx, scw.wr, scw.tsc, scw.cell, keyspace, shard, scw.minHealthyRdonlyTablets, timeout, topodatapb.TabletType_RDONLY); err != nil {","path":"go/vt/worker/split_clone.go","position":14,"original_position":14,"commit_id":"3529a75c6a4ae01c445916db29df6527c2022df3","original_commit_id":"3529a75c6a4ae01c445916db29df6527c2022df3","user":{"login":"rafael","id":24160,"node_id":"MDQ6VXNlcjI0MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/24160?v=4","gravatar_id":"","url":"https://api.github.com/users/rafael","html_url":"https://github.com/rafael","followers_url":"https://api.github.com/users/rafael/followers","following_url":"https://api.github.com/users/rafael/following{/other_user}","gists_url":"https://api.github.com/users/rafael/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael/subscriptions","organizations_url":"https://api.github.com/users/rafael/orgs","repos_url":"https://api.github.com/users/rafael/repos","events_url":"https://api.github.com/users/rafael/events{/privacy}","received_events_url":"https://api.github.com/users/rafael/received_events","type":"User","site_admin":false},"body":"I think it should be ok. We will have to be careful in this case to make sure we don't pass `min` as 1. That we way we will make sure there are enough `RDONLY` tablets that are still serving. ","created_at":"2018-06-29T17:07:13Z","updated_at":"2018-06-29T17:07:13Z","html_url":"https://github.com/vitessio/vitess/pull/4049#discussion_r199223719","pull_request_url":"https://api.github.com/repos/vitessio/vitess/pulls/4049","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments/199223719"},"html":{"href":"https://github.com/vitessio/vitess/pull/4049#discussion_r199223719"},"pull_request":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4049"}},"in_reply_to_id":198989476},"pull_request":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/4049","id":196859271,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODU5Mjcx","html_url":"https://github.com/vitessio/vitess/pull/4049","diff_url":"https://github.com/vitessio/vitess/pull/4049.diff","patch_url":"https://github.com/vitessio/vitess/pull/4049.patch","issue_url":"https://api.github.com/repos/vitessio/vitess/issues/4049","number":4049,"state":"open","locked":false,"title":"Do not require rdonly for split diff","user":{"login":"rafael","id":24160,"node_id":"MDQ6VXNlcjI0MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/24160?v=4","gravatar_id":"","url":"https://api.github.com/users/rafael","html_url":"https://github.com/rafael","followers_url":"https://api.github.com/users/rafael/followers","following_url":"https://api.github.com/users/rafael/following{/other_user}","gists_url":"https://api.github.com/users/rafael/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael/subscriptions","organizations_url":"https://api.github.com/users/rafael/orgs","repos_url":"https://api.github.com/users/rafael/repos","events_url":"https://api.github.com/users/rafael/events{/privacy}","received_events_url":"https://api.github.com/users/rafael/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nIn general we are not using RDONLY replicas. The `SplitDiff` process requires that you have some `RDONLY` provisioned in the destination shards. This creates some extra overhead when we are provisioning shards to perform an horizontal reshard. We would like to avoid this overhead.\r\n\r\nThis PR allows SplitDiff callers to specify the tabletType they want to use in the destination shards. \r\n\r\nIt also updates workflow UI to allow to set this parameter when creating a workflow.\r\n\r\nThe UI now looks like this: \r\n\r\n![image](https://user-images.githubusercontent.com/24160/41801779-5cb16140-7631-11e8-9956-3840b42c8568.png)\r\n\r\n###  Tests\r\n\r\n* Added unit test for this use case.\r\n* Tested workflow multiple time in our dev environment. \r\n \r\n","created_at":"2018-06-22T22:32:24Z","updated_at":"2018-06-29T17:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c8d055c1cbd53cb87151c638b6e0545be715eb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitessio/vitess/pulls/4049/commits","review_comments_url":"https://api.github.com/repos/vitessio/vitess/pulls/4049/comments","review_comment_url":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitessio/vitess/issues/4049/comments","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/3529a75c6a4ae01c445916db29df6527c2022df3","head":{"label":"tinyspeck:do-not-require-rdonly-for-split-diff","ref":"do-not-require-rdonly-for-split-diff","sha":"3529a75c6a4ae01c445916db29df6527c2022df3","user":{"login":"tinyspeck","id":371467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQ2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/371467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyspeck","html_url":"https://github.com/tinyspeck","followers_url":"https://api.github.com/users/tinyspeck/followers","following_url":"https://api.github.com/users/tinyspeck/following{/other_user}","gists_url":"https://api.github.com/users/tinyspeck/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyspeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyspeck/subscriptions","organizations_url":"https://api.github.com/users/tinyspeck/orgs","repos_url":"https://api.github.com/users/tinyspeck/repos","events_url":"https://api.github.com/users/tinyspeck/events{/privacy}","received_events_url":"https://api.github.com/users/tinyspeck/received_events","type":"Organization","site_admin":false},"repo":{"id":79269846,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTg0Ng==","name":"vitess","full_name":"tinyspeck/vitess","owner":{"login":"tinyspeck","id":371467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQ2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/371467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyspeck","html_url":"https://github.com/tinyspeck","followers_url":"https://api.github.com/users/tinyspeck/followers","following_url":"https://api.github.com/users/tinyspeck/following{/other_user}","gists_url":"https://api.github.com/users/tinyspeck/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyspeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyspeck/subscriptions","organizations_url":"https://api.github.com/users/tinyspeck/orgs","repos_url":"https://api.github.com/users/tinyspeck/repos","events_url":"https://api.github.com/users/tinyspeck/events{/privacy}","received_events_url":"https://api.github.com/users/tinyspeck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tinyspeck/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":true,"url":"https://api.github.com/repos/tinyspeck/vitess","forks_url":"https://api.github.com/repos/tinyspeck/vitess/forks","keys_url":"https://api.github.com/repos/tinyspeck/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinyspeck/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinyspeck/vitess/teams","hooks_url":"https://api.github.com/repos/tinyspeck/vitess/hooks","issue_events_url":"https://api.github.com/repos/tinyspeck/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/tinyspeck/vitess/events","assignees_url":"https://api.github.com/repos/tinyspeck/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/tinyspeck/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/tinyspeck/vitess/tags","blobs_url":"https://api.github.com/repos/tinyspeck/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinyspeck/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinyspeck/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinyspeck/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinyspeck/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/tinyspeck/vitess/languages","stargazers_url":"https://api.github.com/repos/tinyspeck/vitess/stargazers","contributors_url":"https://api.github.com/repos/tinyspeck/vitess/contributors","subscribers_url":"https://api.github.com/repos/tinyspeck/vitess/subscribers","subscription_url":"https://api.github.com/repos/tinyspeck/vitess/subscription","commits_url":"https://api.github.com/repos/tinyspeck/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinyspeck/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinyspeck/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinyspeck/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinyspeck/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/tinyspeck/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinyspeck/vitess/merges","archive_url":"https://api.github.com/repos/tinyspeck/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinyspeck/vitess/downloads","issues_url":"https://api.github.com/repos/tinyspeck/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/tinyspeck/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/tinyspeck/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/tinyspeck/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinyspeck/vitess/labels{/name}","releases_url":"https://api.github.com/repos/tinyspeck/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/tinyspeck/vitess/deployments","created_at":"2017-01-17T20:41:49Z","updated_at":"2018-06-27T00:03:43Z","pushed_at":"2018-06-29T00:20:43Z","git_url":"git://github.com/tinyspeck/vitess.git","ssh_url":"git@github.com:tinyspeck/vitess.git","clone_url":"https://github.com/tinyspeck/vitess.git","svn_url":"https://github.com/tinyspeck/vitess","homepage":"http://vitess.io","size":98031,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"vitessio:master","ref":"master","sha":"d3483d3232e4e16831bc782c06d402cf1de0e097","user":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwODIwNw==","name":"vitess","full_name":"vitessio/vitess","owner":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vitessio/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":false,"url":"https://api.github.com/repos/vitessio/vitess","forks_url":"https://api.github.com/repos/vitessio/vitess/forks","keys_url":"https://api.github.com/repos/vitessio/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitessio/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitessio/vitess/teams","hooks_url":"https://api.github.com/repos/vitessio/vitess/hooks","issue_events_url":"https://api.github.com/repos/vitessio/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/vitessio/vitess/events","assignees_url":"https://api.github.com/repos/vitessio/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/vitessio/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/vitessio/vitess/tags","blobs_url":"https://api.github.com/repos/vitessio/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitessio/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitessio/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitessio/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/vitessio/vitess/languages","stargazers_url":"https://api.github.com/repos/vitessio/vitess/stargazers","contributors_url":"https://api.github.com/repos/vitessio/vitess/contributors","subscribers_url":"https://api.github.com/repos/vitessio/vitess/subscribers","subscription_url":"https://api.github.com/repos/vitessio/vitess/subscription","commits_url":"https://api.github.com/repos/vitessio/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitessio/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitessio/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitessio/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitessio/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/vitessio/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitessio/vitess/merges","archive_url":"https://api.github.com/repos/vitessio/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitessio/vitess/downloads","issues_url":"https://api.github.com/repos/vitessio/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/vitessio/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/vitessio/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/vitessio/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitessio/vitess/labels{/name}","releases_url":"https://api.github.com/repos/vitessio/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/vitessio/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2018-06-29T15:49:36Z","pushed_at":"2018-06-29T16:24:05Z","git_url":"git://github.com/vitessio/vitess.git","ssh_url":"git@github.com:vitessio/vitess.git","clone_url":"https://github.com/vitessio/vitess.git","svn_url":"https://github.com/vitessio/vitess","homepage":"http://vitess.io","size":97949,"stargazers_count":6190,"watchers_count":6190,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":803,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":803,"open_issues":209,"watchers":6190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4049"},"html":{"href":"https://github.com/vitessio/vitess/pull/4049"},"issue":{"href":"https://api.github.com/repos/vitessio/vitess/issues/4049"},"comments":{"href":"https://api.github.com/repos/vitessio/vitess/issues/4049/comments"},"review_comments":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4049/comments"},"review_comment":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4049/commits"},"statuses":{"href":"https://api.github.com/repos/vitessio/vitess/statuses/3529a75c6a4ae01c445916db29df6527c2022df3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rafael"}}