{"action":"created","issue":{"url":"https://api.github.com/repos/Polymer/tools/issues/727","repository_url":"https://api.github.com/repos/Polymer/tools","labels_url":"https://api.github.com/repos/Polymer/tools/issues/727/labels{/name}","comments_url":"https://api.github.com/repos/Polymer/tools/issues/727/comments","events_url":"https://api.github.com/repos/Polymer/tools/issues/727/events","html_url":"https://github.com/Polymer/tools/pull/727","id":364420885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjEwNzM4","number":727,"title":"Fix injected WCT hack to prevent dynamic modules run Mocha multiple times","user":{"login":"bashmish","id":137844,"node_id":"MDQ6VXNlcjEzNzg0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/137844?v=4","gravatar_id":"","url":"https://api.github.com/users/bashmish","html_url":"https://github.com/bashmish","followers_url":"https://api.github.com/users/bashmish/followers","following_url":"https://api.github.com/users/bashmish/following{/other_user}","gists_url":"https://api.github.com/users/bashmish/gists{/gist_id}","starred_url":"https://api.github.com/users/bashmish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashmish/subscriptions","organizations_url":"https://api.github.com/users/bashmish/orgs","repos_url":"https://api.github.com/users/bashmish/repos","events_url":"https://api.github.com/users/bashmish/events{/privacy}","received_events_url":"https://api.github.com/users/bashmish/received_events","type":"User","site_admin":false},"labels":[{"id":85405100,"node_id":"MDU6TGFiZWw4NTQwNTEwMA==","url":"https://api.github.com/repos/Polymer/tools/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-27T11:03:58Z","updated_at":"2018-09-27T11:18:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Polymer/tools/pulls/727","html_url":"https://github.com/Polymer/tools/pull/727","diff_url":"https://github.com/Polymer/tools/pull/727.diff","patch_url":"https://github.com/Polymer/tools/pull/727.patch"},"body":"Fixes https://github.com/Polymer/tools/issues/726\r\n\r\nAs far as I understand the intention of the injected code it should be safe to assume that all static modules will be loaded by the time the callback is run for the first time. This is why I just disable it for future calls so that dynamic imports do not cause the issues.\r\n\r\nI tested this fix on our code containing multiple suites all using components which use dynamic imports. Works well."},"comment":{"url":"https://api.github.com/repos/Polymer/tools/issues/comments/425053527","html_url":"https://github.com/Polymer/tools/pull/727#issuecomment-425053527","issue_url":"https://api.github.com/repos/Polymer/tools/issues/727","id":425053527,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTA1MzUyNw==","user":{"login":"TimvdLippe","id":5948271,"node_id":"MDQ6VXNlcjU5NDgyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T11:18:50Z","updated_at":"2018-09-27T11:18:50Z","author_association":"CONTRIBUTOR","body":"Hm, I think @aomarks knows more about that. Al, do you mind helping out with testing these features?"}}
{"actor":{"display_login":"TimvdLippe"}}