{"action":"created","comment":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/171344912","pull_request_review_id":100171930,"id":171344912,"diff_hunk":"@@ -206,6 +211,9 @@ def MTAThreadFunc(self):\n \t\t\tself.clientObject.AddPropertyChangedEventHandler(self.rootElement,TreeScope_Subtree,self.baseCacheRequest,self,UIAPropertyIdsToNVDAEventNames.keys())\r\n \t\t\tfor x in UIAEventIdsToNVDAEventNames.iterkeys():  \r\n \t\t\t\tself.clientObject.addAutomationEventHandler(x,self.rootElement,TreeScope_Subtree,self.baseCacheRequest,self)\r\n+\t\t\t# #7984: add support for notification event (IUIAutomation5, part of Windows 10 build 16299 and later).\r\n+\t\t\tif IUIAVersion >= \"IUIAutomation5\":\r","path":"source/_UIAHandler.py","position":44,"original_position":44,"commit_id":"e8b300e7062fc2a801206bae71cdcc9c46161125","original_commit_id":"e8b300e7062fc2a801206bae71cdcc9c46161125","user":{"login":"leonardder","id":3049216,"avatar_url":"https://avatars1.githubusercontent.com/u/3049216?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardder","html_url":"https://github.com/leonardder","followers_url":"https://api.github.com/users/leonardder/followers","following_url":"https://api.github.com/users/leonardder/following{/other_user}","gists_url":"https://api.github.com/users/leonardder/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardder/subscriptions","organizations_url":"https://api.github.com/users/leonardder/orgs","repos_url":"https://api.github.com/users/leonardder/repos","events_url":"https://api.github.com/users/leonardder/events{/privacy}","received_events_url":"https://api.github.com/users/leonardder/received_events","type":"User","site_admin":false},"body":"Hmm, even though Python uses lexicographical comparison for strings and therefore this is code that does the write thing, I'd feel safer if you'd avoid this. As @michaeldcurran pointed out in https://github.com/nvaccess/nvda/pull/8045#issuecomment-369188217, all UIA interfaces inherit from the one before, so you could do an instance check on the client object for IUIAutomation5.","created_at":"2018-02-28T18:44:42Z","updated_at":"2018-02-28T18:46:38Z","html_url":"https://github.com/nvaccess/nvda/pull/8045#discussion_r171344912","pull_request_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8045","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/171344912"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8045#discussion_r171344912"},"pull_request":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8045"}}},"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/8045","id":171831241,"html_url":"https://github.com/nvaccess/nvda/pull/8045","diff_url":"https://github.com/nvaccess/nvda/pull/8045.diff","patch_url":"https://github.com/nvaccess/nvda/pull/8045.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/8045","number":8045,"state":"open","locked":false,"title":"Introduce IUIAutomation5 interface and ability to announce notifications in Windows 10 Fall Creators Update and later","user":{"login":"josephsl","id":7867280,"avatar_url":"https://avatars3.githubusercontent.com/u/7867280?v=4","gravatar_id":"","url":"https://api.github.com/users/josephsl","html_url":"https://github.com/josephsl","followers_url":"https://api.github.com/users/josephsl/followers","following_url":"https://api.github.com/users/josephsl/following{/other_user}","gists_url":"https://api.github.com/users/josephsl/gists{/gist_id}","starred_url":"https://api.github.com/users/josephsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephsl/subscriptions","organizations_url":"https://api.github.com/users/josephsl/orgs","repos_url":"https://api.github.com/users/josephsl/repos","events_url":"https://api.github.com/users/josephsl/events{/privacy}","received_events_url":"https://api.github.com/users/josephsl/received_events","type":"User","site_admin":false},"body":"### Link to issue number:\r\n#7984, #8009 \r\n\r\n### Summary of the issue:\r\nIntroduce IUIAutomation5 interface and ability to announce notifications in Windows 10 Fall Creators Update an later\r\n\r\n### Description of how this pull request fixes the issue:\r\nIn Windows 10 Fall Creators Update and later, apps can inform screen readers to announce specific notification text. This is done via IUIAutomationNotificationEventHandler::HandleNotificationEvent, which is part of IUIAutomation5 interface. Since NVDA only uses IUIAutomation3, update UIA subsystem to use IUIAutomation5. Also, introduce ability to use more recent IUIAutomation interfaces on various Windows 10 releases (such as IUIAutomation4 in Anniversary Update/build 14393).\r\n\r\n### Testing performed:\r\nTesting done via Windows 10 App Essentials add-on: using recent versions of various app (such as Calculator, Microsoft Store and others) that uses this new event to announce texts.\r\n\r\n### Known issues with pull request:\r\nNone so far.\r\n\r\n### Change log entry:\r\nNew feature: In Windows 10 Fall Creators Update and later, NVDA can announce notifications from apps such as Calculator and Windows Store.\r\n","created_at":"2018-02-28T01:18:11Z","updated_at":"2018-02-28T18:46:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df32ab31a312ca6567d93d6db2f1b4f403f7dabf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars0.githubusercontent.com/u/14154141?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8045/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8045/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/8045/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/e8b300e7062fc2a801206bae71cdcc9c46161125","head":{"label":"josephsl:iuiautomation5","ref":"iuiautomation5","sha":"e8b300e7062fc2a801206bae71cdcc9c46161125","user":{"login":"josephsl","id":7867280,"avatar_url":"https://avatars3.githubusercontent.com/u/7867280?v=4","gravatar_id":"","url":"https://api.github.com/users/josephsl","html_url":"https://github.com/josephsl","followers_url":"https://api.github.com/users/josephsl/followers","following_url":"https://api.github.com/users/josephsl/following{/other_user}","gists_url":"https://api.github.com/users/josephsl/gists{/gist_id}","starred_url":"https://api.github.com/users/josephsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephsl/subscriptions","organizations_url":"https://api.github.com/users/josephsl/orgs","repos_url":"https://api.github.com/users/josephsl/repos","events_url":"https://api.github.com/users/josephsl/events{/privacy}","received_events_url":"https://api.github.com/users/josephsl/received_events","type":"User","site_admin":false},"repo":{"id":60886961,"name":"nvda","full_name":"josephsl/nvda","owner":{"login":"josephsl","id":7867280,"avatar_url":"https://avatars3.githubusercontent.com/u/7867280?v=4","gravatar_id":"","url":"https://api.github.com/users/josephsl","html_url":"https://github.com/josephsl","followers_url":"https://api.github.com/users/josephsl/followers","following_url":"https://api.github.com/users/josephsl/following{/other_user}","gists_url":"https://api.github.com/users/josephsl/gists{/gist_id}","starred_url":"https://api.github.com/users/josephsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephsl/subscriptions","organizations_url":"https://api.github.com/users/josephsl/orgs","repos_url":"https://api.github.com/users/josephsl/repos","events_url":"https://api.github.com/users/josephsl/events{/privacy}","received_events_url":"https://api.github.com/users/josephsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephsl/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":true,"url":"https://api.github.com/repos/josephsl/nvda","forks_url":"https://api.github.com/repos/josephsl/nvda/forks","keys_url":"https://api.github.com/repos/josephsl/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephsl/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephsl/nvda/teams","hooks_url":"https://api.github.com/repos/josephsl/nvda/hooks","issue_events_url":"https://api.github.com/repos/josephsl/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/josephsl/nvda/events","assignees_url":"https://api.github.com/repos/josephsl/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/josephsl/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/josephsl/nvda/tags","blobs_url":"https://api.github.com/repos/josephsl/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephsl/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephsl/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephsl/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephsl/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/josephsl/nvda/languages","stargazers_url":"https://api.github.com/repos/josephsl/nvda/stargazers","contributors_url":"https://api.github.com/repos/josephsl/nvda/contributors","subscribers_url":"https://api.github.com/repos/josephsl/nvda/subscribers","subscription_url":"https://api.github.com/repos/josephsl/nvda/subscription","commits_url":"https://api.github.com/repos/josephsl/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephsl/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephsl/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephsl/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephsl/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/josephsl/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephsl/nvda/merges","archive_url":"https://api.github.com/repos/josephsl/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephsl/nvda/downloads","issues_url":"https://api.github.com/repos/josephsl/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/josephsl/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/josephsl/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/josephsl/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephsl/nvda/labels{/name}","releases_url":"https://api.github.com/repos/josephsl/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/josephsl/nvda/deployments","created_at":"2016-06-11T02:14:57Z","updated_at":"2017-08-07T10:20:11Z","pushed_at":"2018-02-28T12:17:40Z","git_url":"git://github.com/josephsl/nvda.git","ssh_url":"git@github.com:josephsl/nvda.git","clone_url":"https://github.com/josephsl/nvda.git","svn_url":"https://github.com/josephsl/nvda","homepage":null,"size":131332,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"c83231ec6e31bb19e5a25d9b0442f019a7a13e73","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2018-02-28T04:29:28Z","pushed_at":"2018-02-28T14:11:53Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":134564,"stargazers_count":419,"watchers_count":419,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":2110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":178,"open_issues":2110,"watchers":419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8045"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8045"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8045"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8045/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8045/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8045/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/e8b300e7062fc2a801206bae71cdcc9c46161125"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"leonardder"}}