{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/171920267","pull_request_review_id":100862295,"id":171920267,"diff_hunk":"@@ -439,6 +440,11 @@ Ember.TextField = TextField;\n Ember.TextArea = TextArea;\n Ember.LinkComponent = LinkComponent;\n \n+Object.defineProperty(Ember, 'setComponentManager', {","path":"packages/ember/lib/index.js","position":33,"original_position":33,"commit_id":"7b0c9feaa5134df0e300a9d2a2b802409c6d6403","original_commit_id":"7b0c9feaa5134df0e300a9d2a2b802409c6d6403","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars0.githubusercontent.com/u/12637?v=4","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"darn, I'm sorry for the run around here (I know you implemented exactly what I said in the last comment), I think this still needs to be underscored\r\n\r\nCan you change it to be `_setComponentManager`?","created_at":"2018-03-02T18:08:37Z","updated_at":"2018-03-02T18:09:12Z","html_url":"https://github.com/emberjs/ember.js/pull/16308#discussion_r171920267","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16308","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/171920267"},"html":{"href":"https://github.com/emberjs/ember.js/pull/16308#discussion_r171920267"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16308"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/16308","id":172349692,"html_url":"https://github.com/emberjs/ember.js/pull/16308","diff_url":"https://github.com/emberjs/ember.js/pull/16308.diff","patch_url":"https://github.com/emberjs/ember.js/pull/16308.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/16308","number":16308,"state":"open","locked":false,"title":"Custom component manager","user":{"login":"smfoote","id":452458,"avatar_url":"https://avatars2.githubusercontent.com/u/452458?v=4","gravatar_id":"","url":"https://api.github.com/users/smfoote","html_url":"https://github.com/smfoote","followers_url":"https://api.github.com/users/smfoote/followers","following_url":"https://api.github.com/users/smfoote/following{/other_user}","gists_url":"https://api.github.com/users/smfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/smfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smfoote/subscriptions","organizations_url":"https://api.github.com/users/smfoote/orgs","repos_url":"https://api.github.com/users/smfoote/repos","events_url":"https://api.github.com/users/smfoote/events{/privacy}","received_events_url":"https://api.github.com/users/smfoote/received_events","type":"User","site_admin":false},"body":"Add custom component manager and tests. See #16301 and ember-cli/ember-rfc176-data#43.","created_at":"2018-03-01T20:49:15Z","updated_at":"2018-03-02T18:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2471e1e6326613a0a9af4095fc01a483d4c55fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16308/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16308/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/16308/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/7b0c9feaa5134df0e300a9d2a2b802409c6d6403","head":{"label":"smfoote:custom-component-manager","ref":"custom-component-manager","sha":"7b0c9feaa5134df0e300a9d2a2b802409c6d6403","user":{"login":"smfoote","id":452458,"avatar_url":"https://avatars2.githubusercontent.com/u/452458?v=4","gravatar_id":"","url":"https://api.github.com/users/smfoote","html_url":"https://github.com/smfoote","followers_url":"https://api.github.com/users/smfoote/followers","following_url":"https://api.github.com/users/smfoote/following{/other_user}","gists_url":"https://api.github.com/users/smfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/smfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smfoote/subscriptions","organizations_url":"https://api.github.com/users/smfoote/orgs","repos_url":"https://api.github.com/users/smfoote/repos","events_url":"https://api.github.com/users/smfoote/events{/privacy}","received_events_url":"https://api.github.com/users/smfoote/received_events","type":"User","site_admin":false},"repo":{"id":107187558,"name":"ember.js","full_name":"smfoote/ember.js","owner":{"login":"smfoote","id":452458,"avatar_url":"https://avatars2.githubusercontent.com/u/452458?v=4","gravatar_id":"","url":"https://api.github.com/users/smfoote","html_url":"https://github.com/smfoote","followers_url":"https://api.github.com/users/smfoote/followers","following_url":"https://api.github.com/users/smfoote/following{/other_user}","gists_url":"https://api.github.com/users/smfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/smfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smfoote/subscriptions","organizations_url":"https://api.github.com/users/smfoote/orgs","repos_url":"https://api.github.com/users/smfoote/repos","events_url":"https://api.github.com/users/smfoote/events{/privacy}","received_events_url":"https://api.github.com/users/smfoote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smfoote/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/smfoote/ember.js","forks_url":"https://api.github.com/repos/smfoote/ember.js/forks","keys_url":"https://api.github.com/repos/smfoote/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smfoote/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smfoote/ember.js/teams","hooks_url":"https://api.github.com/repos/smfoote/ember.js/hooks","issue_events_url":"https://api.github.com/repos/smfoote/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/smfoote/ember.js/events","assignees_url":"https://api.github.com/repos/smfoote/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/smfoote/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/smfoote/ember.js/tags","blobs_url":"https://api.github.com/repos/smfoote/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smfoote/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smfoote/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/smfoote/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smfoote/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/smfoote/ember.js/languages","stargazers_url":"https://api.github.com/repos/smfoote/ember.js/stargazers","contributors_url":"https://api.github.com/repos/smfoote/ember.js/contributors","subscribers_url":"https://api.github.com/repos/smfoote/ember.js/subscribers","subscription_url":"https://api.github.com/repos/smfoote/ember.js/subscription","commits_url":"https://api.github.com/repos/smfoote/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/smfoote/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/smfoote/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/smfoote/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/smfoote/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/smfoote/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smfoote/ember.js/merges","archive_url":"https://api.github.com/repos/smfoote/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smfoote/ember.js/downloads","issues_url":"https://api.github.com/repos/smfoote/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/smfoote/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/smfoote/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/smfoote/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smfoote/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/smfoote/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/smfoote/ember.js/deployments","created_at":"2017-10-16T21:59:24Z","updated_at":"2017-10-16T21:59:33Z","pushed_at":"2018-03-02T17:58:18Z","git_url":"git://github.com/smfoote/ember.js.git","ssh_url":"git@github.com:smfoote/ember.js.git","clone_url":"https://github.com/smfoote/ember.js.git","svn_url":"https://github.com/smfoote/ember.js","homepage":"http://www.emberjs.com","size":42715,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"d652f47b9c63178d8c4ed941b12e052f9467f263","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2018-03-02T17:33:38Z","pushed_at":"2018-03-02T17:58:20Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":42753,"stargazers_count":18774,"watchers_count":18774,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3849,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3849,"open_issues":324,"watchers":18774,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16308"},"html":{"href":"https://github.com/emberjs/ember.js/pull/16308"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16308"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16308/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16308/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16308/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/7b0c9feaa5134df0e300a9d2a2b802409c6d6403"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwjblue"}}