{"action":"created","comment":{"url":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments/189996286","pull_request_review_id":122283737,"id":189996286,"diff_hunk":"@@ -22,22 +22,22 @@ def fit_decay(data, tes, mask, masksum, start_echo):\n     masksum : (S, ) array_like\n         Valued array indicating number of echos that have sufficient signal in\n         given sample\n-    start_echo : int\n-        First echo to consider\n+    start_echo : int, optional\n+        First echo to consider. Default is 1 (first echo).\n \n     Returns\n     -------\n-    t2sa : (S x E) :obj:`numpy.ndarray`\n+    t2sa : (S) :obj:`numpy.ndarray`\n         Limited T2* map\n-    s0va : (S x E) :obj:`numpy.ndarray`\n+    s0va : (S) :obj:`numpy.ndarray`\n         Limited S0 map\n-    t2ss : (S x E) :obj:`numpy.ndarray`\n+    t2ss : (S, ?) :obj:`numpy.ndarray`","path":"tedana/model/monoexponential.py","position":27,"original_position":27,"commit_id":"5af046ecfe4d6135bdc69b9648375e1f6b3a5f92","original_commit_id":"5af046ecfe4d6135bdc69b9648375e1f6b3a5f92","user":{"login":"emdupre","id":15017191,"avatar_url":"https://avatars3.githubusercontent.com/u/15017191?v=4","gravatar_id":"","url":"https://api.github.com/users/emdupre","html_url":"https://github.com/emdupre","followers_url":"https://api.github.com/users/emdupre/followers","following_url":"https://api.github.com/users/emdupre/following{/other_user}","gists_url":"https://api.github.com/users/emdupre/gists{/gist_id}","starred_url":"https://api.github.com/users/emdupre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emdupre/subscriptions","organizations_url":"https://api.github.com/users/emdupre/orgs","repos_url":"https://api.github.com/users/emdupre/repos","events_url":"https://api.github.com/users/emdupre/events{/privacy}","received_events_url":"https://api.github.com/users/emdupre/received_events","type":"User","site_admin":false},"body":"Is it unclear what the returned dimensions are, here ?","created_at":"2018-05-22T17:56:12Z","updated_at":"2018-05-22T17:56:13Z","html_url":"https://github.com/ME-ICA/tedana/pull/61#discussion_r189996286","pull_request_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments/189996286"},"html":{"href":"https://github.com/ME-ICA/tedana/pull/61#discussion_r189996286"},"pull_request":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/ME-ICA/tedana/pulls/61","id":189190002,"html_url":"https://github.com/ME-ICA/tedana/pull/61","diff_url":"https://github.com/ME-ICA/tedana/pull/61.diff","patch_url":"https://github.com/ME-ICA/tedana/pull/61.patch","issue_url":"https://api.github.com/repos/ME-ICA/tedana/issues/61","number":61,"state":"open","locked":false,"title":"[TST] Add tests for tedana.model.monoexponential","user":{"login":"tsalo","id":8228902,"avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"body":"<!---\r\nThis is a suggested pull request template for tedana.\r\nIt's designed to capture information we've found to be useful\r\nin reviewing pull requests.\r\n\r\nIf there is other information that would be helpful to include,\r\nplease don't hesitate to add it!\r\n-->\r\n\r\nChanges proposed in this pull request:\r\n\r\n- Add test for tedana.model.monoexponential.fit_decay that compares results to results used for integration test of full workflow.\r\n- Add smoke test for tedana.model.monoexponential.fit_decay_ts that just runs the function and checks that the resulting numpy arrays are in the right shape.","created_at":"2018-05-19T14:16:40Z","updated_at":"2018-05-22T17:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"984a832597294c6b11ad798a871b9b9c8158ad1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/61/commits","review_comments_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/61/comments","review_comment_url":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ME-ICA/tedana/issues/61/comments","statuses_url":"https://api.github.com/repos/ME-ICA/tedana/statuses/5af046ecfe4d6135bdc69b9648375e1f6b3a5f92","head":{"label":"tsalo:tests","ref":"tests","sha":"5af046ecfe4d6135bdc69b9648375e1f6b3a5f92","user":{"login":"tsalo","id":8228902,"avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"repo":{"id":131185627,"name":"tedana","full_name":"tsalo/tedana","owner":{"login":"tsalo","id":8228902,"avatar_url":"https://avatars3.githubusercontent.com/u/8228902?v=4","gravatar_id":"","url":"https://api.github.com/users/tsalo","html_url":"https://github.com/tsalo","followers_url":"https://api.github.com/users/tsalo/followers","following_url":"https://api.github.com/users/tsalo/following{/other_user}","gists_url":"https://api.github.com/users/tsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsalo/subscriptions","organizations_url":"https://api.github.com/users/tsalo/orgs","repos_url":"https://api.github.com/users/tsalo/repos","events_url":"https://api.github.com/users/tsalo/events{/privacy}","received_events_url":"https://api.github.com/users/tsalo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsalo/tedana","description":"TE-dependent analysis of multi-echo fMRI","fork":true,"url":"https://api.github.com/repos/tsalo/tedana","forks_url":"https://api.github.com/repos/tsalo/tedana/forks","keys_url":"https://api.github.com/repos/tsalo/tedana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsalo/tedana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsalo/tedana/teams","hooks_url":"https://api.github.com/repos/tsalo/tedana/hooks","issue_events_url":"https://api.github.com/repos/tsalo/tedana/issues/events{/number}","events_url":"https://api.github.com/repos/tsalo/tedana/events","assignees_url":"https://api.github.com/repos/tsalo/tedana/assignees{/user}","branches_url":"https://api.github.com/repos/tsalo/tedana/branches{/branch}","tags_url":"https://api.github.com/repos/tsalo/tedana/tags","blobs_url":"https://api.github.com/repos/tsalo/tedana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsalo/tedana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsalo/tedana/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsalo/tedana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsalo/tedana/statuses/{sha}","languages_url":"https://api.github.com/repos/tsalo/tedana/languages","stargazers_url":"https://api.github.com/repos/tsalo/tedana/stargazers","contributors_url":"https://api.github.com/repos/tsalo/tedana/contributors","subscribers_url":"https://api.github.com/repos/tsalo/tedana/subscribers","subscription_url":"https://api.github.com/repos/tsalo/tedana/subscription","commits_url":"https://api.github.com/repos/tsalo/tedana/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsalo/tedana/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsalo/tedana/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsalo/tedana/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsalo/tedana/contents/{+path}","compare_url":"https://api.github.com/repos/tsalo/tedana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsalo/tedana/merges","archive_url":"https://api.github.com/repos/tsalo/tedana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsalo/tedana/downloads","issues_url":"https://api.github.com/repos/tsalo/tedana/issues{/number}","pulls_url":"https://api.github.com/repos/tsalo/tedana/pulls{/number}","milestones_url":"https://api.github.com/repos/tsalo/tedana/milestones{/number}","notifications_url":"https://api.github.com/repos/tsalo/tedana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsalo/tedana/labels{/name}","releases_url":"https://api.github.com/repos/tsalo/tedana/releases{/id}","deployments_url":"https://api.github.com/repos/tsalo/tedana/deployments","created_at":"2018-04-26T16:54:42Z","updated_at":"2018-05-21T21:23:42Z","pushed_at":"2018-05-22T15:40:17Z","git_url":"git://github.com/tsalo/tedana.git","ssh_url":"git@github.com:tsalo/tedana.git","clone_url":"https://github.com/tsalo/tedana.git","svn_url":"https://github.com/tsalo/tedana","homepage":"https://tedana.readthedocs.io/","size":1789,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ME-ICA:master","ref":"master","sha":"279082b73532f994967c668c60463ce56c7ff4aa","user":{"login":"ME-ICA","id":30531571,"avatar_url":"https://avatars0.githubusercontent.com/u/30531571?v=4","gravatar_id":"","url":"https://api.github.com/users/ME-ICA","html_url":"https://github.com/ME-ICA","followers_url":"https://api.github.com/users/ME-ICA/followers","following_url":"https://api.github.com/users/ME-ICA/following{/other_user}","gists_url":"https://api.github.com/users/ME-ICA/gists{/gist_id}","starred_url":"https://api.github.com/users/ME-ICA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ME-ICA/subscriptions","organizations_url":"https://api.github.com/users/ME-ICA/orgs","repos_url":"https://api.github.com/users/ME-ICA/repos","events_url":"https://api.github.com/users/ME-ICA/events{/privacy}","received_events_url":"https://api.github.com/users/ME-ICA/received_events","type":"Organization","site_admin":false},"repo":{"id":110845855,"name":"tedana","full_name":"ME-ICA/tedana","owner":{"login":"ME-ICA","id":30531571,"avatar_url":"https://avatars0.githubusercontent.com/u/30531571?v=4","gravatar_id":"","url":"https://api.github.com/users/ME-ICA","html_url":"https://github.com/ME-ICA","followers_url":"https://api.github.com/users/ME-ICA/followers","following_url":"https://api.github.com/users/ME-ICA/following{/other_user}","gists_url":"https://api.github.com/users/ME-ICA/gists{/gist_id}","starred_url":"https://api.github.com/users/ME-ICA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ME-ICA/subscriptions","organizations_url":"https://api.github.com/users/ME-ICA/orgs","repos_url":"https://api.github.com/users/ME-ICA/repos","events_url":"https://api.github.com/users/ME-ICA/events{/privacy}","received_events_url":"https://api.github.com/users/ME-ICA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ME-ICA/tedana","description":"TE-dependent analysis of multi-echo fMRI","fork":false,"url":"https://api.github.com/repos/ME-ICA/tedana","forks_url":"https://api.github.com/repos/ME-ICA/tedana/forks","keys_url":"https://api.github.com/repos/ME-ICA/tedana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ME-ICA/tedana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ME-ICA/tedana/teams","hooks_url":"https://api.github.com/repos/ME-ICA/tedana/hooks","issue_events_url":"https://api.github.com/repos/ME-ICA/tedana/issues/events{/number}","events_url":"https://api.github.com/repos/ME-ICA/tedana/events","assignees_url":"https://api.github.com/repos/ME-ICA/tedana/assignees{/user}","branches_url":"https://api.github.com/repos/ME-ICA/tedana/branches{/branch}","tags_url":"https://api.github.com/repos/ME-ICA/tedana/tags","blobs_url":"https://api.github.com/repos/ME-ICA/tedana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ME-ICA/tedana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ME-ICA/tedana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ME-ICA/tedana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ME-ICA/tedana/statuses/{sha}","languages_url":"https://api.github.com/repos/ME-ICA/tedana/languages","stargazers_url":"https://api.github.com/repos/ME-ICA/tedana/stargazers","contributors_url":"https://api.github.com/repos/ME-ICA/tedana/contributors","subscribers_url":"https://api.github.com/repos/ME-ICA/tedana/subscribers","subscription_url":"https://api.github.com/repos/ME-ICA/tedana/subscription","commits_url":"https://api.github.com/repos/ME-ICA/tedana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ME-ICA/tedana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ME-ICA/tedana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ME-ICA/tedana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ME-ICA/tedana/contents/{+path}","compare_url":"https://api.github.com/repos/ME-ICA/tedana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ME-ICA/tedana/merges","archive_url":"https://api.github.com/repos/ME-ICA/tedana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ME-ICA/tedana/downloads","issues_url":"https://api.github.com/repos/ME-ICA/tedana/issues{/number}","pulls_url":"https://api.github.com/repos/ME-ICA/tedana/pulls{/number}","milestones_url":"https://api.github.com/repos/ME-ICA/tedana/milestones{/number}","notifications_url":"https://api.github.com/repos/ME-ICA/tedana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ME-ICA/tedana/labels{/name}","releases_url":"https://api.github.com/repos/ME-ICA/tedana/releases{/id}","deployments_url":"https://api.github.com/repos/ME-ICA/tedana/deployments","created_at":"2017-11-15T14:45:02Z","updated_at":"2018-05-22T02:27:07Z","pushed_at":"2018-05-22T15:40:18Z","git_url":"git://github.com/ME-ICA/tedana.git","ssh_url":"git@github.com:ME-ICA/tedana.git","clone_url":"https://github.com/ME-ICA/tedana.git","svn_url":"https://github.com/ME-ICA/tedana","homepage":"https://tedana.readthedocs.io/","size":1787,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":12,"open_issues":22,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/61"},"html":{"href":"https://github.com/ME-ICA/tedana/pull/61"},"issue":{"href":"https://api.github.com/repos/ME-ICA/tedana/issues/61"},"comments":{"href":"https://api.github.com/repos/ME-ICA/tedana/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ME-ICA/tedana/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/ME-ICA/tedana/statuses/5af046ecfe4d6135bdc69b9648375e1f6b3a5f92"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"emdupre"}}