{"action":"created","comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/209944304","pull_request_review_id":146054639,"id":209944304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTk0NDMwNA==","diff_hunk":"@@ -251,14 +299,33 @@ Because QUIC does not guarantee order between data on different streams, a\n header block might reference an entry in the dynamic table that has not yet been\n received.\n \n-Each header block contains a Largest Reference which identifies the table state\n-necessary for decoding. If the greatest absolute index in the dynamic table is\n-less than the value of the Largest Reference, the stream is considered\n-\"blocked.\"  While blocked, header field data should remain in the blocked\n-stream's flow control window.  When the Largest Reference is zero, the frame\n-contains no references to the dynamic table and can always be processed\n-immediately. A stream becomes unblocked when the greatest absolute index in the\n-dynamic table becomes greater than or equal to the Largest Reference for all\n+Each header block contains a Largest Reference field which identifies the\n+table state necessary for decoding.\n+\n+When the Largest Reference value is not specified, the frame contains no\n+references to the dynamic table and can always be processed immediately.\n+\n+When it is specified, the Largest Reference value is compared with\n+the absolute index value of the next entry to be inserted into the\n+dynamic table.  That entry's absolute index value divides the absolute","path":"draft-ietf-quic-qpack.md","position":98,"original_position":98,"commit_id":"48d2e09fe925c19fcf519eeee570ccd95d8967cf","original_commit_id":"48d2e09fe925c19fcf519eeee570ccd95d8967cf","user":{"login":"dtikhonov","id":4528576,"node_id":"MDQ6VXNlcjQ1Mjg1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4528576?v=4","gravatar_id":"","url":"https://api.github.com/users/dtikhonov","html_url":"https://github.com/dtikhonov","followers_url":"https://api.github.com/users/dtikhonov/followers","following_url":"https://api.github.com/users/dtikhonov/following{/other_user}","gists_url":"https://api.github.com/users/dtikhonov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtikhonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtikhonov/subscriptions","organizations_url":"https://api.github.com/users/dtikhonov/orgs","repos_url":"https://api.github.com/users/dtikhonov/repos","events_url":"https://api.github.com/users/dtikhonov/events{/privacy}","received_events_url":"https://api.github.com/users/dtikhonov/received_events","type":"User","site_admin":false},"body":"I used the \"next entry to be inserted\" because I see no other way to describe the initial state, when there is no \"last inserted entry.\"  Perhaps we could add the concept of \"cursor?\"\r\n\r\nThe \"total number of inserts\" concept eludes me.  The diagram is confusing, as it combines both encoder instructions (`Insert`) and header block instructions (`Post-Base`).\r\n\r\n1. If the \"total number of inserts\" is the number of inserts performed while encoding a given header block, how does the decoder know where to start?\r\n1. If this number is added to the current absolute index, then it is the same as _Largest Reference_.\r\n1. ?","created_at":"2018-08-14T13:11:20Z","updated_at":"2018-08-14T13:11:20Z","html_url":"https://github.com/quicwg/base-drafts/pull/1657#discussion_r209944304","pull_request_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/209944304"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1657#discussion_r209944304"},"pull_request":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657"}},"in_reply_to_id":209815235},"pull_request":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657","id":208091415,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDkxNDE1","html_url":"https://github.com/quicwg/base-drafts/pull/1657","diff_url":"https://github.com/quicwg/base-drafts/pull/1657.diff","patch_url":"https://github.com/quicwg/base-drafts/pull/1657.patch","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1657","number":1657,"state":"open","locked":false,"title":"QPACK: wrap absolute index values","user":{"login":"dtikhonov","id":4528576,"node_id":"MDQ6VXNlcjQ1Mjg1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4528576?v=4","gravatar_id":"","url":"https://api.github.com/users/dtikhonov","html_url":"https://github.com/dtikhonov","followers_url":"https://api.github.com/users/dtikhonov/followers","following_url":"https://api.github.com/users/dtikhonov/following{/other_user}","gists_url":"https://api.github.com/users/dtikhonov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtikhonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtikhonov/subscriptions","organizations_url":"https://api.github.com/users/dtikhonov/orgs","repos_url":"https://api.github.com/users/dtikhonov/repos","events_url":"https://api.github.com/users/dtikhonov/events{/privacy}","received_events_url":"https://api.github.com/users/dtikhonov/received_events","type":"User","site_admin":false},"body":"Resolves #1644.\r\n\r\nIncludes #1650 and #1642.","created_at":"2018-08-13T20:18:20Z","updated_at":"2018-08-14T13:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"569de0fc1d2d506080b366c39d52982d2bc66cf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1657/comments","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/48d2e09fe925c19fcf519eeee570ccd95d8967cf","head":{"label":"dtikhonov:201808131347-wrap-absolute-index","ref":"201808131347-wrap-absolute-index","sha":"48d2e09fe925c19fcf519eeee570ccd95d8967cf","user":{"login":"dtikhonov","id":4528576,"node_id":"MDQ6VXNlcjQ1Mjg1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4528576?v=4","gravatar_id":"","url":"https://api.github.com/users/dtikhonov","html_url":"https://github.com/dtikhonov","followers_url":"https://api.github.com/users/dtikhonov/followers","following_url":"https://api.github.com/users/dtikhonov/following{/other_user}","gists_url":"https://api.github.com/users/dtikhonov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtikhonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtikhonov/subscriptions","organizations_url":"https://api.github.com/users/dtikhonov/orgs","repos_url":"https://api.github.com/users/dtikhonov/repos","events_url":"https://api.github.com/users/dtikhonov/events{/privacy}","received_events_url":"https://api.github.com/users/dtikhonov/received_events","type":"User","site_admin":false},"repo":{"id":128972330,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5NzIzMzA=","name":"base-drafts","full_name":"dtikhonov/base-drafts","owner":{"login":"dtikhonov","id":4528576,"node_id":"MDQ6VXNlcjQ1Mjg1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4528576?v=4","gravatar_id":"","url":"https://api.github.com/users/dtikhonov","html_url":"https://github.com/dtikhonov","followers_url":"https://api.github.com/users/dtikhonov/followers","following_url":"https://api.github.com/users/dtikhonov/following{/other_user}","gists_url":"https://api.github.com/users/dtikhonov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtikhonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtikhonov/subscriptions","organizations_url":"https://api.github.com/users/dtikhonov/orgs","repos_url":"https://api.github.com/users/dtikhonov/repos","events_url":"https://api.github.com/users/dtikhonov/events{/privacy}","received_events_url":"https://api.github.com/users/dtikhonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtikhonov/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":true,"url":"https://api.github.com/repos/dtikhonov/base-drafts","forks_url":"https://api.github.com/repos/dtikhonov/base-drafts/forks","keys_url":"https://api.github.com/repos/dtikhonov/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtikhonov/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtikhonov/base-drafts/teams","hooks_url":"https://api.github.com/repos/dtikhonov/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/dtikhonov/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/dtikhonov/base-drafts/events","assignees_url":"https://api.github.com/repos/dtikhonov/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/dtikhonov/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/dtikhonov/base-drafts/tags","blobs_url":"https://api.github.com/repos/dtikhonov/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtikhonov/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtikhonov/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtikhonov/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtikhonov/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/dtikhonov/base-drafts/languages","stargazers_url":"https://api.github.com/repos/dtikhonov/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/dtikhonov/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/dtikhonov/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/dtikhonov/base-drafts/subscription","commits_url":"https://api.github.com/repos/dtikhonov/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtikhonov/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtikhonov/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtikhonov/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtikhonov/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/dtikhonov/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtikhonov/base-drafts/merges","archive_url":"https://api.github.com/repos/dtikhonov/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtikhonov/base-drafts/downloads","issues_url":"https://api.github.com/repos/dtikhonov/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/dtikhonov/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/dtikhonov/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/dtikhonov/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtikhonov/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/dtikhonov/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/dtikhonov/base-drafts/deployments","created_at":"2018-04-10T17:38:32Z","updated_at":"2018-08-13T17:45:50Z","pushed_at":"2018-08-13T20:15:42Z","git_url":"git://github.com/dtikhonov/base-drafts.git","ssh_url":"git@github.com:dtikhonov/base-drafts.git","clone_url":"https://github.com/dtikhonov/base-drafts.git","svn_url":"https://github.com/dtikhonov/base-drafts","homepage":"https://quicwg.github.io/","size":45653,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quicwg:master","ref":"master","sha":"a4605469463977bd99e565385acb12071e8512ae","user":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzc3OTU5OQ==","name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjMxMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-08-14T12:37:40Z","pushed_at":"2018-08-14T12:39:50Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":50001,"stargazers_count":290,"watchers_count":290,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":112,"license":null,"forks":68,"open_issues":112,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1657"},"issue":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1657"},"comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/quicwg/base-drafts/statuses/48d2e09fe925c19fcf519eeee570ccd95d8967cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dtikhonov"}}