{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5427","repository_url":"https://api.github.com/repos/RPCS3/rpcs3","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5427/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5427/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5427/events","html_url":"https://github.com/RPCS3/rpcs3/pull/5427","id":391460851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTYyMjEw","number":5427,"title":"rsx: Fbo fixes","user":{"login":"kd-11","id":15904127,"node_id":"MDQ6VXNlcjE1OTA0MTI3","avatar_url":"https://avatars2.githubusercontent.com/u/15904127?v=4","gravatar_id":"","url":"https://api.github.com/users/kd-11","html_url":"https://github.com/kd-11","followers_url":"https://api.github.com/users/kd-11/followers","following_url":"https://api.github.com/users/kd-11/following{/other_user}","gists_url":"https://api.github.com/users/kd-11/gists{/gist_id}","starred_url":"https://api.github.com/users/kd-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kd-11/subscriptions","organizations_url":"https://api.github.com/users/kd-11/orgs","repos_url":"https://api.github.com/users/kd-11/repos","events_url":"https://api.github.com/users/kd-11/events{/privacy}","received_events_url":"https://api.github.com/users/kd-11/received_events","type":"User","site_admin":false},"labels":[{"id":287007392,"node_id":"MDU6TGFiZWwyODcwMDczOTI=","url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Bugfix","name":"Bugfix","color":"80ff80","default":false},{"id":18270162,"node_id":"MDU6TGFiZWwxODI3MDE2Mg==","url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":91080410,"node_id":"MDU6TGFiZWw5MTA4MDQxMA==","url":"https://api.github.com/repos/RPCS3/rpcs3/labels/RSX","name":"RSX","color":"eb6420","default":false},{"id":335044271,"node_id":"MDU6TGFiZWwzMzUwNDQyNzE=","url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Render:%20OpenGL","name":"Render: OpenGL","color":"5586a4","default":false},{"id":301003471,"node_id":"MDU6TGFiZWwzMDEwMDM0NzE=","url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Render:%20Vulkan","name":"Render: Vulkan","color":"a41e22","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":200,"created_at":"2018-12-16T12:06:11Z","updated_at":"2019-01-05T17:48:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/5427","html_url":"https://github.com/RPCS3/rpcs3/pull/5427","diff_url":"https://github.com/RPCS3/rpcs3/pull/5427.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/5427.patch"},"body":"Reimplements some parts of framebuffer management including:\r\n- Avoiding generating framebuffer attachments for attachments that are likely unused. This prevents memory corruption when WCB/WDB is not in use since we rely on attachment memory tags to watch for events. Fixes https://github.com/RPCS3/rpcs3/issues/5406.\r\n- Rewrites memory inheritance to implicity guarantee correct results even when strict mode is not enabled. This both simplifies the design and potentially moves some more games from strict mode requirement.\r\n- Fix a texture cache deadlock due to incorrect internal size computations\r\n- Bump max number of compute invocations on vulkan to 8 times the old value. Real-world testing has shown that it is completely possible to trigger a very high number of readback operations in loading screens. Fixes https://github.com/RPCS3/rpcs3/issues/5193 and other similar issues.\r\n\r\nThis is the first in a series of pull requests, so gt_fixes will be made available after this one is merged as they touch some of the same common code."},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/451676043","html_url":"https://github.com/RPCS3/rpcs3/pull/5427#issuecomment-451676043","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/5427","id":451676043,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY3NjA0Mw==","user":{"login":"stride21","id":37915864,"node_id":"MDQ6VXNlcjM3OTE1ODY0","avatar_url":"https://avatars0.githubusercontent.com/u/37915864?v=4","gravatar_id":"","url":"https://api.github.com/users/stride21","html_url":"https://github.com/stride21","followers_url":"https://api.github.com/users/stride21/followers","following_url":"https://api.github.com/users/stride21/following{/other_user}","gists_url":"https://api.github.com/users/stride21/gists{/gist_id}","starred_url":"https://api.github.com/users/stride21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stride21/subscriptions","organizations_url":"https://api.github.com/users/stride21/orgs","repos_url":"https://api.github.com/users/stride21/repos","events_url":"https://api.github.com/users/stride21/events{/privacy}","received_events_url":"https://api.github.com/users/stride21/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T17:48:11Z","updated_at":"2019-01-05T17:48:11Z","author_association":"NONE","body":"@kd-11 Yes, and strict rendering mode but it seems to happen without strict rendering too. I thought it was just similar to TLOU thats why I posted it but I've been testing it more and it seems some what similar to how Uncharted 2 acts where it just randomly looks \"normal\" on some tests but on others it has the glowing.\r\n\r\nWCB without SRM\r\n![pr testing](https://user-images.githubusercontent.com/37915864/50727336-2837ae80-10df-11e9-89f9-da501999ca58.JPG)\r\n[rpcs3 log.zip](https://github.com/RPCS3/rpcs3/files/2729716/rpcs3.log.zip)\r\n"}}
{"actor":{"display_login":"stride21"}}