{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback.io/pulls/comments/168696955","pull_request_review_id":97106524,"id":168696955,"diff_hunk":"@@ -86,18 +86,16 @@ class MySequence extends DefaultSequence {\n }\n ```\n \n-In order for LoopBack to use your custom sequence, you must register it on any\n-applicable `Server` instances before starting your `Application`:\n+In order for LoopBack to use your custom sequence, you must register it\n+before starting your `Application`:\n \n ```js\n import {RestApplication, RestServer} from '@loopback/rest';\n \n const app = new RestApplication();\n \n-// or\n (async function start() {\n-  const server = await app.getServer(RestServer);\n-  server.sequence(MySequence);\n+  app.sequence(MySequence);","path":"pages/en/lb4/Sequence.md","position":18,"original_position":18,"commit_id":"30cdc4c91b2c0edbcca814e8364a0c0fa55fdede","original_commit_id":"30cdc4c91b2c0edbcca814e8364a0c0fa55fdede","user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars1.githubusercontent.com/u/1140553?v=4","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"body":"Ditto, please move this line out of async `start()` function and consider removing the start function completely.","created_at":"2018-02-16T08:33:14Z","updated_at":"2018-02-16T08:33:54Z","html_url":"https://github.com/strongloop/loopback.io/pull/621#discussion_r168696955","pull_request_url":"https://api.github.com/repos/strongloop/loopback.io/pulls/621","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/comments/168696955"},"html":{"href":"https://github.com/strongloop/loopback.io/pull/621#discussion_r168696955"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/621"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback.io/pulls/621","id":169495172,"html_url":"https://github.com/strongloop/loopback.io/pull/621","diff_url":"https://github.com/strongloop/loopback.io/pull/621.diff","patch_url":"https://github.com/strongloop/loopback.io/pull/621.patch","issue_url":"https://api.github.com/repos/strongloop/loopback.io/issues/621","number":621,"state":"open","locked":false,"title":"[WIP] move RestServer config out of `async start`","user":{"login":"shimks","id":18518689,"avatar_url":"https://avatars2.githubusercontent.com/u/18518689?v=4","gravatar_id":"","url":"https://api.github.com/users/shimks","html_url":"https://github.com/shimks","followers_url":"https://api.github.com/users/shimks/followers","following_url":"https://api.github.com/users/shimks/following{/other_user}","gists_url":"https://api.github.com/users/shimks/gists{/gist_id}","starred_url":"https://api.github.com/users/shimks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shimks/subscriptions","organizations_url":"https://api.github.com/users/shimks/orgs","repos_url":"https://api.github.com/users/shimks/repos","events_url":"https://api.github.com/users/shimks/events{/privacy}","received_events_url":"https://api.github.com/users/shimks/received_events","type":"User","site_admin":false},"body":"This PR would utilize the new changes made in https://github.com/strongloop/loopback-next/pull/994 so that `async start` is not overridden if it can be overridden.\r\n\r\nI left a couple of decisions undecided because I wasn't sure whether i should be changing some of these or not. Here are my main concerns:\r\n- In the `WidgetApplication` example under `Application.md`, `server.api(WidgetApi)` is used in start. The function call can't be moved into the constructor since the app is only extending from `Application` and not `RestApplication`; `api()` function can't be called because it doesn't exist for the application. Should the example be left as it is?\r\n- In `Context.md`, we configure multiple servers inside the start function. I think this should be left as is, but does anybody think otherwise?","created_at":"2018-02-15T21:52:35Z","updated_at":"2018-02-16T08:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bced7f078069c00ef8d27b2246dd81397c256d12","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bschrammIBM","id":27782410,"avatar_url":"https://avatars2.githubusercontent.com/u/27782410?v=4","gravatar_id":"","url":"https://api.github.com/users/bschrammIBM","html_url":"https://github.com/bschrammIBM","followers_url":"https://api.github.com/users/bschrammIBM/followers","following_url":"https://api.github.com/users/bschrammIBM/following{/other_user}","gists_url":"https://api.github.com/users/bschrammIBM/gists{/gist_id}","starred_url":"https://api.github.com/users/bschrammIBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschrammIBM/subscriptions","organizations_url":"https://api.github.com/users/bschrammIBM/orgs","repos_url":"https://api.github.com/users/bschrammIBM/repos","events_url":"https://api.github.com/users/bschrammIBM/events{/privacy}","received_events_url":"https://api.github.com/users/bschrammIBM/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":552736696,"url":"https://api.github.com/repos/strongloop/loopback.io/labels/needs-priority","name":"needs-priority","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback.io/pulls/621/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback.io/pulls/621/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback.io/issues/621/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback.io/statuses/30cdc4c91b2c0edbcca814e8364a0c0fa55fdede","head":{"label":"strongloop:rest-config-out-of-start","ref":"rest-config-out-of-start","sha":"30cdc4c91b2c0edbcca814e8364a0c0fa55fdede","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":16320387,"name":"loopback.io","full_name":"strongloop/loopback.io","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback.io","description":"LoopBack project site - now with documentation!","fork":false,"url":"https://api.github.com/repos/strongloop/loopback.io","forks_url":"https://api.github.com/repos/strongloop/loopback.io/forks","keys_url":"https://api.github.com/repos/strongloop/loopback.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback.io/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback.io/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback.io/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback.io/events","assignees_url":"https://api.github.com/repos/strongloop/loopback.io/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback.io/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback.io/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback.io/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback.io/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback.io/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback.io/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback.io/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback.io/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback.io/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback.io/merges","archive_url":"https://api.github.com/repos/strongloop/loopback.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback.io/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback.io/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback.io/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback.io/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback.io/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback.io/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback.io/deployments","created_at":"2014-01-28T18:00:00Z","updated_at":"2018-02-09T15:43:14Z","pushed_at":"2018-02-15T21:53:48Z","git_url":"git://github.com/strongloop/loopback.io.git","ssh_url":"git@github.com:strongloop/loopback.io.git","clone_url":"https://github.com/strongloop/loopback.io.git","svn_url":"https://github.com/strongloop/loopback.io","homepage":"http://loopback.io","size":29250,"stargazers_count":128,"watchers_count":128,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":240,"open_issues":31,"watchers":128,"default_branch":"gh-pages"}},"base":{"label":"strongloop:gh-pages","ref":"gh-pages","sha":"9f8c4c624b0c69d4c62be9293c75a5fc0dd774e7","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":16320387,"name":"loopback.io","full_name":"strongloop/loopback.io","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback.io","description":"LoopBack project site - now with documentation!","fork":false,"url":"https://api.github.com/repos/strongloop/loopback.io","forks_url":"https://api.github.com/repos/strongloop/loopback.io/forks","keys_url":"https://api.github.com/repos/strongloop/loopback.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback.io/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback.io/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback.io/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback.io/events","assignees_url":"https://api.github.com/repos/strongloop/loopback.io/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback.io/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback.io/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback.io/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback.io/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback.io/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback.io/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback.io/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback.io/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback.io/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback.io/merges","archive_url":"https://api.github.com/repos/strongloop/loopback.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback.io/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback.io/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback.io/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback.io/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback.io/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback.io/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback.io/deployments","created_at":"2014-01-28T18:00:00Z","updated_at":"2018-02-09T15:43:14Z","pushed_at":"2018-02-15T21:53:48Z","git_url":"git://github.com/strongloop/loopback.io.git","ssh_url":"git@github.com:strongloop/loopback.io.git","clone_url":"https://github.com/strongloop/loopback.io.git","svn_url":"https://github.com/strongloop/loopback.io","homepage":"http://loopback.io","size":29250,"stargazers_count":128,"watchers_count":128,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":240,"open_issues":31,"watchers":128,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/621"},"html":{"href":"https://github.com/strongloop/loopback.io/pull/621"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback.io/issues/621"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback.io/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback.io/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback.io/statuses/30cdc4c91b2c0edbcca814e8364a0c0fa55fdede"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bajtos"}}