{"action":"created","issue":{"url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/15","repository_url":"https://api.github.com/repos/rocky/libcdio-paranoia","labels_url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/15/comments","events_url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/15/events","html_url":"https://github.com/rocky/libcdio-paranoia/issues/15","id":345437178,"node_id":"MDU6SXNzdWUzNDU0MzcxNzg=","number":15,"title":"Inconsistent handling of NULL callback in cdio_paranoia_read_limited","user":{"login":"mskamp","id":14326293,"node_id":"MDQ6VXNlcjE0MzI2Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/14326293?v=4","gravatar_id":"","url":"https://api.github.com/users/mskamp","html_url":"https://github.com/mskamp","followers_url":"https://api.github.com/users/mskamp/followers","following_url":"https://api.github.com/users/mskamp/following{/other_user}","gists_url":"https://api.github.com/users/mskamp/gists{/gist_id}","starred_url":"https://api.github.com/users/mskamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskamp/subscriptions","organizations_url":"https://api.github.com/users/mskamp/orgs","repos_url":"https://api.github.com/users/mskamp/repos","events_url":"https://api.github.com/users/mskamp/events{/privacy}","received_events_url":"https://api.github.com/users/mskamp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-28T10:09:21Z","updated_at":"2018-07-28T10:43:06Z","closed_at":null,"author_association":"NONE","body":"I wanted to find out whether cdio_paranoia_read_limited accepts a NULL argument for the callback parameter. The check in this line...\r\nhttps://github.com/rocky/libcdio-paranoia/blob/da12cf5e76ba5dcf8b5b525dd90662af97f1bac3/lib/paranoia/paranoia.c#L3122\r\n... made me believe that NULL arguments are dealt with correctly. However, the following call is not protected by a NULL check, which made my application crash:\r\nhttps://github.com/rocky/libcdio-paranoia/blob/6591cb89c7dec1b5e9a16eb0c2fa33bb2e5b9084/lib/paranoia/paranoia.c#L2618\r\nI think the handling of a NULL argument should be consistent here. If you do not want to support NULL arguments for the callback parameter, I'd advise to remove the first check and/or add the non-NULL requirement to the documentation."},"comment":{"url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/comments/408598698","html_url":"https://github.com/rocky/libcdio-paranoia/issues/15#issuecomment-408598698","issue_url":"https://api.github.com/repos/rocky/libcdio-paranoia/issues/15","id":408598698,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODU5ODY5OA==","user":{"login":"rocky","id":8851,"node_id":"MDQ6VXNlcjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/8851?v=4","gravatar_id":"","url":"https://api.github.com/users/rocky","html_url":"https://github.com/rocky","followers_url":"https://api.github.com/users/rocky/followers","following_url":"https://api.github.com/users/rocky/following{/other_user}","gists_url":"https://api.github.com/users/rocky/gists{/gist_id}","starred_url":"https://api.github.com/users/rocky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocky/subscriptions","organizations_url":"https://api.github.com/users/rocky/orgs","repos_url":"https://api.github.com/users/rocky/repos","events_url":"https://api.github.com/users/rocky/events{/privacy}","received_events_url":"https://api.github.com/users/rocky/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T10:43:06Z","updated_at":"2018-07-28T10:43:06Z","author_association":"OWNER","body":"Thanks for the observation and report. If you are up for putting in a pull request, things will probably get resolved faster.\r\n\r\nOtherwise, I'll look at this in more detail and fix in due time."}}
{"actor":{"display_login":"rocky"}}