{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/2835","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/2835/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2835/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/2835/events","html_url":"https://github.com/solidusio/solidus/pull/2835","id":354557997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjkxNjky","number":2835,"title":"Change FactoryGirl to FactoryBot in Solidus v2.3","user":{"login":"fastjames","id":260739,"node_id":"MDQ6VXNlcjI2MDczOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260739?v=4","gravatar_id":"","url":"https://api.github.com/users/fastjames","html_url":"https://github.com/fastjames","followers_url":"https://api.github.com/users/fastjames/followers","following_url":"https://api.github.com/users/fastjames/following{/other_user}","gists_url":"https://api.github.com/users/fastjames/gists{/gist_id}","starred_url":"https://api.github.com/users/fastjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastjames/subscriptions","organizations_url":"https://api.github.com/users/fastjames/orgs","repos_url":"https://api.github.com/users/fastjames/repos","events_url":"https://api.github.com/users/fastjames/events{/privacy}","received_events_url":"https://api.github.com/users/fastjames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2018-08-28T03:34:47Z","updated_at":"2018-10-03T12:29:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2835","html_url":"https://github.com/solidusio/solidus/pull/2835","diff_url":"https://github.com/solidusio/solidus/pull/2835.diff","patch_url":"https://github.com/solidusio/solidus/pull/2835.patch"},"body":"Change FactoryGirl to FactoryBot\r\n\r\nWe need to backport this change to maintain the branch, since `factory_girl` is no longer available as a gem.\r\n\r\nI don't know how much interest there is in backporting changes like this, but I figured it would be useful since this branch is still under maintenance until November or so.\r\n"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/426619577","html_url":"https://github.com/solidusio/solidus/pull/2835#issuecomment-426619577","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2835","id":426619577,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjYxOTU3Nw==","user":{"login":"kennyadsl","id":167946,"node_id":"MDQ6VXNlcjE2Nzk0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/167946?v=4","gravatar_id":"","url":"https://api.github.com/users/kennyadsl","html_url":"https://github.com/kennyadsl","followers_url":"https://api.github.com/users/kennyadsl/followers","following_url":"https://api.github.com/users/kennyadsl/following{/other_user}","gists_url":"https://api.github.com/users/kennyadsl/gists{/gist_id}","starred_url":"https://api.github.com/users/kennyadsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennyadsl/subscriptions","organizations_url":"https://api.github.com/users/kennyadsl/orgs","repos_url":"https://api.github.com/users/kennyadsl/repos","events_url":"https://api.github.com/users/kennyadsl/events{/privacy}","received_events_url":"https://api.github.com/users/kennyadsl/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T12:29:50Z","updated_at":"2018-10-03T12:29:50Z","author_association":"MEMBER","body":"Oh right, I keep forgetting that the Solidus dev dependencies are not reflected into extensions. 👍 \r\n\r\nRE \"the plan\":\r\n\r\nRight now:\r\n\r\n- update all extensions with something similar to https://github.com/solidusio/solidus_auth_devise/pull/130/commits/d902b8ea46883f51f31df6fd59cda7b805ab0849\r\n- merge this PR\r\n- update template on  and documentation to explain why this is needed (I'm working on this)\r\n\r\nOnce the EOL of 2.4 is reached (2019-05-07):\r\n\r\n- just revert https://github.com/solidusio/solidus_auth_devise/pull/130/commits/d902b8ea46883f51f31df6fd59cda7b805ab0849 on all extensions\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"kennyadsl"}}