{"action":"created","comment":{"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments/187318092","pull_request_review_id":119072115,"id":187318092,"diff_hunk":"@@ -2560,21 +2589,14 @@\n \t\t * Reference to the pause application button\n \t\t * @property {HTMLElement} pauseButton\n \t\t */\n-\t\tthis.pauseButton = document.querySelectorAll(this.options.pauseButton);\n+\t\tthis.pauseButton = document.querySelector(this.options.pauseButton);","path":"dist/container.js","position":122,"original_position":122,"commit_id":"2990cde406c57f95cf53ffc3f2e0ad9ec3630277","original_commit_id":"2990cde406c57f95cf53ffc3f2e0ad9ec3630277","user":{"login":"chipbell4","id":2642329,"avatar_url":"https://avatars3.githubusercontent.com/u/2642329?v=4","gravatar_id":"","url":"https://api.github.com/users/chipbell4","html_url":"https://github.com/chipbell4","followers_url":"https://api.github.com/users/chipbell4/followers","following_url":"https://api.github.com/users/chipbell4/following{/other_user}","gists_url":"https://api.github.com/users/chipbell4/gists{/gist_id}","starred_url":"https://api.github.com/users/chipbell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipbell4/subscriptions","organizations_url":"https://api.github.com/users/chipbell4/orgs","repos_url":"https://api.github.com/users/chipbell4/repos","events_url":"https://api.github.com/users/chipbell4/events{/privacy}","received_events_url":"https://api.github.com/users/chipbell4/received_events","type":"User","site_admin":false},"body":"Ah, nice catch! I'll go fix that.","created_at":"2018-05-10T12:41:45Z","updated_at":"2018-05-10T12:41:46Z","html_url":"https://github.com/SpringRoll/SpringRollContainer/pull/11#discussion_r187318092","pull_request_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments/187318092"},"html":{"href":"https://github.com/SpringRoll/SpringRollContainer/pull/11#discussion_r187318092"},"pull_request":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11"}},"in_reply_to_id":187315311},"pull_request":{"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11","id":186993966,"html_url":"https://github.com/SpringRoll/SpringRollContainer/pull/11","diff_url":"https://github.com/SpringRoll/SpringRollContainer/pull/11.diff","patch_url":"https://github.com/SpringRoll/SpringRollContainer/pull/11.patch","issue_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/11","number":11,"state":"open","locked":false,"title":"Feature/remove jquery","user":{"login":"chipbell4","id":2642329,"avatar_url":"https://avatars3.githubusercontent.com/u/2642329?v=4","gravatar_id":"","url":"https://api.github.com/users/chipbell4","html_url":"https://github.com/chipbell4","followers_url":"https://api.github.com/users/chipbell4/followers","following_url":"https://api.github.com/users/chipbell4/following{/other_user}","gists_url":"https://api.github.com/users/chipbell4/gists{/gist_id}","starred_url":"https://api.github.com/users/chipbell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipbell4/subscriptions","organizations_url":"https://api.github.com/users/chipbell4/orgs","repos_url":"https://api.github.com/users/chipbell4/repos","events_url":"https://api.github.com/users/chipbell4/events{/privacy}","received_events_url":"https://api.github.com/users/chipbell4/received_events","type":"User","site_admin":false},"body":"A couple more tweaks to the jQuery removal to get the examples working. Also refactored some behavior:\r\n\r\nWe originally discussed making the selectors err if they didn't find anything:\r\n\r\n```\r\nvar element = document.querySelector(this.options.pauseSelector);\r\nif(element === null) {\r\n  throw new Error('some message');\r\n}\r\n```\r\n\r\nHowever, upon some more reading it looks like [these are _optional_ fields](https://github.com/SpringRoll/SpringRollContainer/blob/master/src/container/Container.js#L17) and the behavior should be that the plugins should be no-ops if no selector is provided to them. I'm pretty sure I told you the direct opposite, so I went and did it so you wouldn't have to undo your hard work 👍 \r\n\r\nFeel free to push back if you disagree about this direction.","created_at":"2018-05-09T17:51:18Z","updated_at":"2018-05-10T12:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16ceaf1f5f6dc07028623a028a6cc9175535de93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Connor93","id":1617275,"avatar_url":"https://avatars3.githubusercontent.com/u/1617275?v=4","gravatar_id":"","url":"https://api.github.com/users/Connor93","html_url":"https://github.com/Connor93","followers_url":"https://api.github.com/users/Connor93/followers","following_url":"https://api.github.com/users/Connor93/following{/other_user}","gists_url":"https://api.github.com/users/Connor93/gists{/gist_id}","starred_url":"https://api.github.com/users/Connor93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connor93/subscriptions","organizations_url":"https://api.github.com/users/Connor93/orgs","repos_url":"https://api.github.com/users/Connor93/repos","events_url":"https://api.github.com/users/Connor93/events{/privacy}","received_events_url":"https://api.github.com/users/Connor93/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11/commits","review_comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11/comments","review_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/11/comments","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/2990cde406c57f95cf53ffc3f2e0ad9ec3630277","head":{"label":"SpringRoll:feature/remove-jquery","ref":"feature/remove-jquery","sha":"2990cde406c57f95cf53ffc3f2e0ad9ec3630277","user":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"repo":{"id":47125363,"name":"SpringRollContainer","full_name":"SpringRoll/SpringRollContainer","owner":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpringRoll/SpringRollContainer","description":"The iframe controller for interacting with SpringRoll applications","fork":false,"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer","forks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/forks","keys_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/teams","hooks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/hooks","issue_events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/events{/number}","events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/events","assignees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/assignees{/user}","branches_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/branches{/branch}","tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/tags","blobs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/{sha}","languages_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/languages","stargazers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/stargazers","contributors_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contributors","subscribers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscribers","subscription_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscription","commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contents/{+path}","compare_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/merges","archive_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/downloads","issues_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues{/number}","pulls_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls{/number}","milestones_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/milestones{/number}","notifications_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/labels{/name}","releases_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/releases{/id}","deployments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/deployments","created_at":"2015-11-30T14:48:40Z","updated_at":"2018-05-10T12:40:17Z","pushed_at":"2018-05-10T12:40:20Z","git_url":"git://github.com/SpringRoll/SpringRollContainer.git","ssh_url":"git@github.com:SpringRoll/SpringRollContainer.git","clone_url":"https://github.com/SpringRoll/SpringRollContainer.git","svn_url":"https://github.com/SpringRoll/SpringRollContainer","homepage":null,"size":373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"SpringRoll:master","ref":"master","sha":"f9f91397c1330569a9d190e38f93d007ee1bbfd7","user":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"repo":{"id":47125363,"name":"SpringRollContainer","full_name":"SpringRoll/SpringRollContainer","owner":{"login":"SpringRoll","id":9436157,"avatar_url":"https://avatars1.githubusercontent.com/u/9436157?v=4","gravatar_id":"","url":"https://api.github.com/users/SpringRoll","html_url":"https://github.com/SpringRoll","followers_url":"https://api.github.com/users/SpringRoll/followers","following_url":"https://api.github.com/users/SpringRoll/following{/other_user}","gists_url":"https://api.github.com/users/SpringRoll/gists{/gist_id}","starred_url":"https://api.github.com/users/SpringRoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpringRoll/subscriptions","organizations_url":"https://api.github.com/users/SpringRoll/orgs","repos_url":"https://api.github.com/users/SpringRoll/repos","events_url":"https://api.github.com/users/SpringRoll/events{/privacy}","received_events_url":"https://api.github.com/users/SpringRoll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpringRoll/SpringRollContainer","description":"The iframe controller for interacting with SpringRoll applications","fork":false,"url":"https://api.github.com/repos/SpringRoll/SpringRollContainer","forks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/forks","keys_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/teams","hooks_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/hooks","issue_events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/events{/number}","events_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/events","assignees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/assignees{/user}","branches_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/branches{/branch}","tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/tags","blobs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/{sha}","languages_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/languages","stargazers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/stargazers","contributors_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contributors","subscribers_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscribers","subscription_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/subscription","commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/contents/{+path}","compare_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/merges","archive_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/downloads","issues_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues{/number}","pulls_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls{/number}","milestones_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/milestones{/number}","notifications_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/labels{/name}","releases_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/releases{/id}","deployments_url":"https://api.github.com/repos/SpringRoll/SpringRollContainer/deployments","created_at":"2015-11-30T14:48:40Z","updated_at":"2018-05-10T12:40:17Z","pushed_at":"2018-05-10T12:40:20Z","git_url":"git://github.com/SpringRoll/SpringRollContainer.git","ssh_url":"git@github.com:SpringRoll/SpringRollContainer.git","clone_url":"https://github.com/SpringRoll/SpringRollContainer.git","svn_url":"https://github.com/SpringRoll/SpringRollContainer","homepage":null,"size":373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11"},"html":{"href":"https://github.com/SpringRoll/SpringRollContainer/pull/11"},"issue":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/11"},"comments":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/SpringRoll/SpringRollContainer/statuses/2990cde406c57f95cf53ffc3f2e0ad9ec3630277"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chipbell4"}}