{"action":"created","issue":{"url":"https://api.github.com/repos/opendatakit/collect/issues/2458","repository_url":"https://api.github.com/repos/opendatakit/collect","labels_url":"https://api.github.com/repos/opendatakit/collect/issues/2458/labels{/name}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/2458/comments","events_url":"https://api.github.com/repos/opendatakit/collect/issues/2458/events","html_url":"https://github.com/opendatakit/collect/pull/2458","id":348259909,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjUwMzAx","number":2458,"title":"Fixed regression in GeopointWidget with placement-map appearance","user":{"login":"grzesiek2010","id":3276264,"node_id":"MDQ6VXNlcjMyNzYyNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"labels":[{"id":807015281,"node_id":"MDU6TGFiZWw4MDcwMTUyODE=","url":"https://api.github.com/repos/opendatakit/collect/labels/behavior%20verified","name":"behavior verified","color":"ededed","default":false},{"id":485736553,"node_id":"MDU6TGFiZWw0ODU3MzY1NTM=","url":"https://api.github.com/repos/opendatakit/collect/labels/high%20priority","name":"high priority","color":"b60205","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-07T10:24:28Z","updated_at":"2018-08-14T08:38:54Z","closed_at":"2018-08-08T12:36:38Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/2458","html_url":"https://github.com/opendatakit/collect/pull/2458","diff_url":"https://github.com/opendatakit/collect/pull/2458.diff","patch_url":"https://github.com/opendatakit/collect/pull/2458.patch"},"body":"Closes #2457 \r\n\r\n#### What has been done to verify that this works as intended?\r\nI tested GeopointWidget with `placement-map` appearance and confirmed that everything works well like in v1.15.0.\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nIt's just a fix of regression. The problem has been introduced in https://github.com/opendatakit/collect/issues/2291\r\nGeopointWIdget didn't work because `locationClient.start();` was called before `locationClient.setListener(this);` - race condition.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nNo.\r\n\r\n#### Do we need any specific form for testing your changes? If so, please attach one.\r\nNo.\r\n\r\n#### Does this change require updates to documentation? If so, please file an issue [here]( https://github.com/opendatakit/docs/issues/new) and include the link below.\r\nNo.\r\n\r\n#### Before submitting this PR, please make sure you have:\r\n- [x] run `./gradlew pmd checkstyle lintDebug spotbugsDebug` and confirmed all checks still pass.\r\n- [x] verified that any code or assets from external sources are properly credited in comments and/or in the [about file](https://github.com/opendatakit/collect/blob/master/collect_app/src/main/assets/open_source_licenses.html).\r\n- [x] verified that any new UI elements use theme colors. [UI Components Style guidelines](https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md#ui-components-style-guidelines)"},"comment":{"url":"https://api.github.com/repos/opendatakit/collect/issues/comments/412798016","html_url":"https://github.com/opendatakit/collect/pull/2458#issuecomment-412798016","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/2458","id":412798016,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc5ODAxNg==","user":{"login":"mmarciniak90","id":3907554,"node_id":"MDQ6VXNlcjM5MDc1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3907554?v=4","gravatar_id":"","url":"https://api.github.com/users/mmarciniak90","html_url":"https://github.com/mmarciniak90","followers_url":"https://api.github.com/users/mmarciniak90/followers","following_url":"https://api.github.com/users/mmarciniak90/following{/other_user}","gists_url":"https://api.github.com/users/mmarciniak90/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarciniak90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarciniak90/subscriptions","organizations_url":"https://api.github.com/users/mmarciniak90/orgs","repos_url":"https://api.github.com/users/mmarciniak90/repos","events_url":"https://api.github.com/users/mmarciniak90/events{/privacy}","received_events_url":"https://api.github.com/users/mmarciniak90/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T08:38:54Z","updated_at":"2018-08-14T08:38:54Z","author_association":"CONTRIBUTOR","body":"@lognaturel yes, now we have a separate test case for Geopoint Widget with the placement-map appearance"}}
{"actor":{"display_login":"mmarciniak90"}}