{"action":"created","comment":{"url":"https://api.github.com/repos/wrf-model/WRF/pulls/comments/224259622","pull_request_review_id":163584031,"id":224259622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI1OTYyMg==","diff_hunk":"@@ -977,6 +977,7 @@ SUBROUTINE lsm(DZ8W,QV3D,P8W3D,T3D,TSK,                      &\n #endif\n \n           IF (rdlai2d) THEN\n+             if(lai(i,j).eq.0.0) lai(i,j) = 0.01 ","path":"phys/module_sf_noahdrv.F","position":4,"original_position":4,"commit_id":"00b9475799dd12bcafec714ddeeef7eca310301f","original_commit_id":"00b9475799dd12bcafec714ddeeef7eca310301f","user":{"login":"barlage","id":13241529,"node_id":"MDQ6VXNlcjEzMjQxNTI5","avatar_url":"https://avatars0.githubusercontent.com/u/13241529?v=4","gravatar_id":"","url":"https://api.github.com/users/barlage","html_url":"https://github.com/barlage","followers_url":"https://api.github.com/users/barlage/followers","following_url":"https://api.github.com/users/barlage/following{/other_user}","gists_url":"https://api.github.com/users/barlage/gists{/gist_id}","starred_url":"https://api.github.com/users/barlage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barlage/subscriptions","organizations_url":"https://api.github.com/users/barlage/orgs","repos_url":"https://api.github.com/users/barlage/repos","events_url":"https://api.github.com/users/barlage/events{/privacy}","received_events_url":"https://api.github.com/users/barlage/received_events","type":"User","site_admin":false},"body":"This is essentially a consistency check on input datasets and could be made more general:\r\n\r\n`if(lai(i,j).eq.0.0) lai(i,j) = 0.01`\r\n\r\nreplaced with\r\n\r\n`\r\nif(shdfac == 0.0) lai(i,j) = 0.0\r\nif(shdfac > 0.0 .and. lai(i,j) == 0.0) lai(i,j) = 0.01\r\n`","created_at":"2018-10-10T22:16:39Z","updated_at":"2018-10-10T22:16:39Z","html_url":"https://github.com/wrf-model/WRF/pull/657#discussion_r224259622","pull_request_url":"https://api.github.com/repos/wrf-model/WRF/pulls/657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/comments/224259622"},"html":{"href":"https://github.com/wrf-model/WRF/pull/657#discussion_r224259622"},"pull_request":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/657"}}},"pull_request":{"url":"https://api.github.com/repos/wrf-model/WRF/pulls/657","id":221925992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTI1OTky","html_url":"https://github.com/wrf-model/WRF/pull/657","diff_url":"https://github.com/wrf-model/WRF/pull/657.diff","patch_url":"https://github.com/wrf-model/WRF/pull/657.patch","issue_url":"https://api.github.com/repos/wrf-model/WRF/issues/657","number":657,"state":"open","locked":false,"title":"Bug fix in Noah LSM","user":{"login":"smileMchen","id":17932265,"node_id":"MDQ6VXNlcjE3OTMyMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/17932265?v=4","gravatar_id":"","url":"https://api.github.com/users/smileMchen","html_url":"https://github.com/smileMchen","followers_url":"https://api.github.com/users/smileMchen/followers","following_url":"https://api.github.com/users/smileMchen/following{/other_user}","gists_url":"https://api.github.com/users/smileMchen/gists{/gist_id}","starred_url":"https://api.github.com/users/smileMchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smileMchen/subscriptions","organizations_url":"https://api.github.com/users/smileMchen/orgs","repos_url":"https://api.github.com/users/smileMchen/repos","events_url":"https://api.github.com/users/smileMchen/events{/privacy}","received_events_url":"https://api.github.com/users/smileMchen/received_events","type":"User","site_admin":false},"body":"\r\nTYPE: bug fix\r\n\r\nKEYWORDS: NOAH LSM, divided by zero\r\n\r\nSOURCE: internal\r\n\r\nDESCRIPTION OF CHANGES: when the leaf area index is derived from static input data (rdlai2d=true), the value could be zero at certain areas. This will lead to some variables being divided by zero in Noah LSM scheme. \r\n\r\nLIST OF MODIFIED FILES: \r\nM       phys/module_sf_noahdrv.F\r\n\r\nTESTS CONDUCTED: \r\nOne case has been tested. The case crashed immediately without the fix. The same case can be done successfully  with the fix. \r\nNo regression test has been done. ","created_at":"2018-10-10T20:41:00Z","updated_at":"2018-10-10T22:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5280699eb0fd712714c82422849251c3faa4179d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wrf-model/WRF/pulls/657/commits","review_comments_url":"https://api.github.com/repos/wrf-model/WRF/pulls/657/comments","review_comment_url":"https://api.github.com/repos/wrf-model/WRF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wrf-model/WRF/issues/657/comments","statuses_url":"https://api.github.com/repos/wrf-model/WRF/statuses/00b9475799dd12bcafec714ddeeef7eca310301f","head":{"label":"smileMchen:noah","ref":"noah","sha":"00b9475799dd12bcafec714ddeeef7eca310301f","user":{"login":"smileMchen","id":17932265,"node_id":"MDQ6VXNlcjE3OTMyMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/17932265?v=4","gravatar_id":"","url":"https://api.github.com/users/smileMchen","html_url":"https://github.com/smileMchen","followers_url":"https://api.github.com/users/smileMchen/followers","following_url":"https://api.github.com/users/smileMchen/following{/other_user}","gists_url":"https://api.github.com/users/smileMchen/gists{/gist_id}","starred_url":"https://api.github.com/users/smileMchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smileMchen/subscriptions","organizations_url":"https://api.github.com/users/smileMchen/orgs","repos_url":"https://api.github.com/users/smileMchen/repos","events_url":"https://api.github.com/users/smileMchen/events{/privacy}","received_events_url":"https://api.github.com/users/smileMchen/received_events","type":"User","site_admin":false},"repo":{"id":147883094,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4ODMwOTQ=","name":"WRF","full_name":"smileMchen/WRF","private":false,"owner":{"login":"smileMchen","id":17932265,"node_id":"MDQ6VXNlcjE3OTMyMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/17932265?v=4","gravatar_id":"","url":"https://api.github.com/users/smileMchen","html_url":"https://github.com/smileMchen","followers_url":"https://api.github.com/users/smileMchen/followers","following_url":"https://api.github.com/users/smileMchen/following{/other_user}","gists_url":"https://api.github.com/users/smileMchen/gists{/gist_id}","starred_url":"https://api.github.com/users/smileMchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smileMchen/subscriptions","organizations_url":"https://api.github.com/users/smileMchen/orgs","repos_url":"https://api.github.com/users/smileMchen/repos","events_url":"https://api.github.com/users/smileMchen/events{/privacy}","received_events_url":"https://api.github.com/users/smileMchen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smileMchen/WRF","description":"The official repository for the Weather Research and Forecasting (WRF) model","fork":true,"url":"https://api.github.com/repos/smileMchen/WRF","forks_url":"https://api.github.com/repos/smileMchen/WRF/forks","keys_url":"https://api.github.com/repos/smileMchen/WRF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smileMchen/WRF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smileMchen/WRF/teams","hooks_url":"https://api.github.com/repos/smileMchen/WRF/hooks","issue_events_url":"https://api.github.com/repos/smileMchen/WRF/issues/events{/number}","events_url":"https://api.github.com/repos/smileMchen/WRF/events","assignees_url":"https://api.github.com/repos/smileMchen/WRF/assignees{/user}","branches_url":"https://api.github.com/repos/smileMchen/WRF/branches{/branch}","tags_url":"https://api.github.com/repos/smileMchen/WRF/tags","blobs_url":"https://api.github.com/repos/smileMchen/WRF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smileMchen/WRF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smileMchen/WRF/git/refs{/sha}","trees_url":"https://api.github.com/repos/smileMchen/WRF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smileMchen/WRF/statuses/{sha}","languages_url":"https://api.github.com/repos/smileMchen/WRF/languages","stargazers_url":"https://api.github.com/repos/smileMchen/WRF/stargazers","contributors_url":"https://api.github.com/repos/smileMchen/WRF/contributors","subscribers_url":"https://api.github.com/repos/smileMchen/WRF/subscribers","subscription_url":"https://api.github.com/repos/smileMchen/WRF/subscription","commits_url":"https://api.github.com/repos/smileMchen/WRF/commits{/sha}","git_commits_url":"https://api.github.com/repos/smileMchen/WRF/git/commits{/sha}","comments_url":"https://api.github.com/repos/smileMchen/WRF/comments{/number}","issue_comment_url":"https://api.github.com/repos/smileMchen/WRF/issues/comments{/number}","contents_url":"https://api.github.com/repos/smileMchen/WRF/contents/{+path}","compare_url":"https://api.github.com/repos/smileMchen/WRF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smileMchen/WRF/merges","archive_url":"https://api.github.com/repos/smileMchen/WRF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smileMchen/WRF/downloads","issues_url":"https://api.github.com/repos/smileMchen/WRF/issues{/number}","pulls_url":"https://api.github.com/repos/smileMchen/WRF/pulls{/number}","milestones_url":"https://api.github.com/repos/smileMchen/WRF/milestones{/number}","notifications_url":"https://api.github.com/repos/smileMchen/WRF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smileMchen/WRF/labels{/name}","releases_url":"https://api.github.com/repos/smileMchen/WRF/releases{/id}","deployments_url":"https://api.github.com/repos/smileMchen/WRF/deployments","created_at":"2018-09-07T23:12:31Z","updated_at":"2018-10-10T15:25:24Z","pushed_at":"2018-10-10T18:31:55Z","git_url":"git://github.com/smileMchen/WRF.git","ssh_url":"git@github.com:smileMchen/WRF.git","clone_url":"https://github.com/smileMchen/WRF.git","svn_url":"https://github.com/smileMchen/WRF","homepage":null,"size":219762,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wrf-model:release-v4.0.2","ref":"release-v4.0.2","sha":"f729619f0dac9312d4853b8cc56817c75ad49eba","user":{"login":"wrf-model","id":12666893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjY2ODkz","avatar_url":"https://avatars3.githubusercontent.com/u/12666893?v=4","gravatar_id":"","url":"https://api.github.com/users/wrf-model","html_url":"https://github.com/wrf-model","followers_url":"https://api.github.com/users/wrf-model/followers","following_url":"https://api.github.com/users/wrf-model/following{/other_user}","gists_url":"https://api.github.com/users/wrf-model/gists{/gist_id}","starred_url":"https://api.github.com/users/wrf-model/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrf-model/subscriptions","organizations_url":"https://api.github.com/users/wrf-model/orgs","repos_url":"https://api.github.com/users/wrf-model/repos","events_url":"https://api.github.com/users/wrf-model/events{/privacy}","received_events_url":"https://api.github.com/users/wrf-model/received_events","type":"Organization","site_admin":false},"repo":{"id":65852069,"node_id":"MDEwOlJlcG9zaXRvcnk2NTg1MjA2OQ==","name":"WRF","full_name":"wrf-model/WRF","private":false,"owner":{"login":"wrf-model","id":12666893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjY2ODkz","avatar_url":"https://avatars3.githubusercontent.com/u/12666893?v=4","gravatar_id":"","url":"https://api.github.com/users/wrf-model","html_url":"https://github.com/wrf-model","followers_url":"https://api.github.com/users/wrf-model/followers","following_url":"https://api.github.com/users/wrf-model/following{/other_user}","gists_url":"https://api.github.com/users/wrf-model/gists{/gist_id}","starred_url":"https://api.github.com/users/wrf-model/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrf-model/subscriptions","organizations_url":"https://api.github.com/users/wrf-model/orgs","repos_url":"https://api.github.com/users/wrf-model/repos","events_url":"https://api.github.com/users/wrf-model/events{/privacy}","received_events_url":"https://api.github.com/users/wrf-model/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wrf-model/WRF","description":"The official repository for the Weather Research and Forecasting (WRF) model","fork":false,"url":"https://api.github.com/repos/wrf-model/WRF","forks_url":"https://api.github.com/repos/wrf-model/WRF/forks","keys_url":"https://api.github.com/repos/wrf-model/WRF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wrf-model/WRF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wrf-model/WRF/teams","hooks_url":"https://api.github.com/repos/wrf-model/WRF/hooks","issue_events_url":"https://api.github.com/repos/wrf-model/WRF/issues/events{/number}","events_url":"https://api.github.com/repos/wrf-model/WRF/events","assignees_url":"https://api.github.com/repos/wrf-model/WRF/assignees{/user}","branches_url":"https://api.github.com/repos/wrf-model/WRF/branches{/branch}","tags_url":"https://api.github.com/repos/wrf-model/WRF/tags","blobs_url":"https://api.github.com/repos/wrf-model/WRF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wrf-model/WRF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wrf-model/WRF/git/refs{/sha}","trees_url":"https://api.github.com/repos/wrf-model/WRF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wrf-model/WRF/statuses/{sha}","languages_url":"https://api.github.com/repos/wrf-model/WRF/languages","stargazers_url":"https://api.github.com/repos/wrf-model/WRF/stargazers","contributors_url":"https://api.github.com/repos/wrf-model/WRF/contributors","subscribers_url":"https://api.github.com/repos/wrf-model/WRF/subscribers","subscription_url":"https://api.github.com/repos/wrf-model/WRF/subscription","commits_url":"https://api.github.com/repos/wrf-model/WRF/commits{/sha}","git_commits_url":"https://api.github.com/repos/wrf-model/WRF/git/commits{/sha}","comments_url":"https://api.github.com/repos/wrf-model/WRF/comments{/number}","issue_comment_url":"https://api.github.com/repos/wrf-model/WRF/issues/comments{/number}","contents_url":"https://api.github.com/repos/wrf-model/WRF/contents/{+path}","compare_url":"https://api.github.com/repos/wrf-model/WRF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wrf-model/WRF/merges","archive_url":"https://api.github.com/repos/wrf-model/WRF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wrf-model/WRF/downloads","issues_url":"https://api.github.com/repos/wrf-model/WRF/issues{/number}","pulls_url":"https://api.github.com/repos/wrf-model/WRF/pulls{/number}","milestones_url":"https://api.github.com/repos/wrf-model/WRF/milestones{/number}","notifications_url":"https://api.github.com/repos/wrf-model/WRF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wrf-model/WRF/labels{/name}","releases_url":"https://api.github.com/repos/wrf-model/WRF/releases{/id}","deployments_url":"https://api.github.com/repos/wrf-model/WRF/deployments","created_at":"2016-08-16T20:39:14Z","updated_at":"2018-10-10T07:53:47Z","pushed_at":"2018-10-10T20:41:01Z","git_url":"git://github.com/wrf-model/WRF.git","ssh_url":"git@github.com:wrf-model/WRF.git","clone_url":"https://github.com/wrf-model/WRF.git","svn_url":"https://github.com/wrf-model/WRF","homepage":null,"size":220206,"stargazers_count":33,"watchers_count":33,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":25,"open_issues":37,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/657"},"html":{"href":"https://github.com/wrf-model/WRF/pull/657"},"issue":{"href":"https://api.github.com/repos/wrf-model/WRF/issues/657"},"comments":{"href":"https://api.github.com/repos/wrf-model/WRF/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wrf-model/WRF/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/wrf-model/WRF/statuses/00b9475799dd12bcafec714ddeeef7eca310301f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"barlage"}}