{"action":"created","issue":{"url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/449","repository_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC","labels_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/449/comments","events_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/449/events","html_url":"https://github.com/TheLevelUp/ZXingObjC/issues/449","id":367523121,"node_id":"MDU6SXNzdWUzNjc1MjMxMjE=","number":449,"title":"Scaling calculation might wrong","user":{"login":"neacao","id":16370568,"node_id":"MDQ6VXNlcjE2MzcwNTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16370568?v=4","gravatar_id":"","url":"https://api.github.com/users/neacao","html_url":"https://github.com/neacao","followers_url":"https://api.github.com/users/neacao/followers","following_url":"https://api.github.com/users/neacao/following{/other_user}","gists_url":"https://api.github.com/users/neacao/gists{/gist_id}","starred_url":"https://api.github.com/users/neacao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neacao/subscriptions","organizations_url":"https://api.github.com/users/neacao/orgs","repos_url":"https://api.github.com/users/neacao/repos","events_url":"https://api.github.com/users/neacao/events{/privacy}","received_events_url":"https://api.github.com/users/neacao/received_events","type":"User","site_admin":false},"labels":[{"id":1457786,"node_id":"MDU6TGFiZWwxNDU3Nzg2","url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/milestones/4","html_url":"https://github.com/TheLevelUp/ZXingObjC/milestone/4","labels_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/milestones/4/labels","id":3677724,"node_id":"MDk6TWlsZXN0b25lMzY3NzcyNA==","number":4,"title":"3.6.0","description":"Streamline the project regarding Carthage, Swift. Mostly organising stuff, thinking about potential Swift APIs.","creator":{"login":"benjohnde","id":5439810,"node_id":"MDQ6VXNlcjU0Mzk4MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5439810?v=4","gravatar_id":"","url":"https://api.github.com/users/benjohnde","html_url":"https://github.com/benjohnde","followers_url":"https://api.github.com/users/benjohnde/followers","following_url":"https://api.github.com/users/benjohnde/following{/other_user}","gists_url":"https://api.github.com/users/benjohnde/gists{/gist_id}","starred_url":"https://api.github.com/users/benjohnde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjohnde/subscriptions","organizations_url":"https://api.github.com/users/benjohnde/orgs","repos_url":"https://api.github.com/users/benjohnde/repos","events_url":"https://api.github.com/users/benjohnde/events{/privacy}","received_events_url":"https://api.github.com/users/benjohnde/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2018-09-21T12:44:16Z","updated_at":"2018-10-09T10:31:45Z","due_on":"2018-11-01T07:00:00Z","closed_at":null},"comments":6,"created_at":"2018-10-07T05:31:28Z","updated_at":"2018-10-09T10:31:45Z","closed_at":"2018-10-09T10:31:45Z","author_association":"CONTRIBUTOR","body":"**BarcodeScanner.m**\r\nThe problem is when I change the `scanRectView` to another subview instead of `self.view`, the `scanRect` get wrong position to crop.\r\n\r\nCurrently there are:\r\n```\r\n...\r\nvideoSizeX = 1080;\r\nvideoSizeY = 1920;\r\n...\r\nscaleVideoX = self.view.frame.size.width / videoSizeX;\r\nscaleVideoY = self.view.frame.size.height / videoSizeY;\r\n```\r\n\r\nAs the code above, we calculate `scaleVideoX` & `scaleVideoY` based on `self.view.frame`. I think the `self.view.frame` should be `[UIScreen mainScreen].bounds` instead, cuz the scale have to be calculate on the screen instead of a view.\r\n"},"comment":{"url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/comments/428142663","html_url":"https://github.com/TheLevelUp/ZXingObjC/issues/449#issuecomment-428142663","issue_url":"https://api.github.com/repos/TheLevelUp/ZXingObjC/issues/449","id":428142663,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODE0MjY2Mw==","user":{"login":"benjohnde","id":5439810,"node_id":"MDQ6VXNlcjU0Mzk4MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5439810?v=4","gravatar_id":"","url":"https://api.github.com/users/benjohnde","html_url":"https://github.com/benjohnde","followers_url":"https://api.github.com/users/benjohnde/followers","following_url":"https://api.github.com/users/benjohnde/following{/other_user}","gists_url":"https://api.github.com/users/benjohnde/gists{/gist_id}","starred_url":"https://api.github.com/users/benjohnde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjohnde/subscriptions","organizations_url":"https://api.github.com/users/benjohnde/orgs","repos_url":"https://api.github.com/users/benjohnde/repos","events_url":"https://api.github.com/users/benjohnde/events{/privacy}","received_events_url":"https://api.github.com/users/benjohnde/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T10:31:45Z","updated_at":"2018-10-09T10:31:45Z","author_association":"COLLABORATOR","body":"Thanks again for your contribution!"}}
{"actor":{"display_login":"benjohnde"}}