{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/173152488","pull_request_review_id":102292094,"id":173152488,"diff_hunk":"@@ -101,4 +101,34 @@ def save_config_to_databag(old_role, role)\n     instance = Crowbar::DataBagConfig.instance_from_role(old_role, role)\n     Crowbar::DataBagConfig.save(\"core\", instance, @bc_name, config)\n   end\n+\n+  # try to know if we can skip a node from running chef-client\n+  def skip_unchanged_node?(node_name, old_role, new_role)","path":"crowbar_framework/app/models/ntp_service.rb","position":6,"original_position":6,"commit_id":"71a0333cb301496eeae13601da96982673f3701f","original_commit_id":"71a0333cb301496eeae13601da96982673f3701f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/CyclomaticComplexity: Cyclomatic complexity for skip_unchanged_node? is too high. [7/6]","created_at":"2018-03-08T13:10:56Z","updated_at":"2018-03-08T13:10:58Z","html_url":"https://github.com/crowbar/crowbar-core/pull/1511#discussion_r173152488","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/173152488"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1511#discussion_r173152488"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511","id":173731193,"html_url":"https://github.com/crowbar/crowbar-core/pull/1511","diff_url":"https://github.com/crowbar/crowbar-core/pull/1511.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1511.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1511","number":1511,"state":"closed","locked":false,"title":"[4.0] Crowbar services restart all services and restart by category backport","user":{"login":"ilausuch","id":11134265,"avatar_url":"https://avatars2.githubusercontent.com/u/11134265?v=4","gravatar_id":"","url":"https://api.github.com/users/ilausuch","html_url":"https://github.com/ilausuch","followers_url":"https://api.github.com/users/ilausuch/followers","following_url":"https://api.github.com/users/ilausuch/following{/other_user}","gists_url":"https://api.github.com/users/ilausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/ilausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilausuch/subscriptions","organizations_url":"https://api.github.com/users/ilausuch/orgs","repos_url":"https://api.github.com/users/ilausuch/repos","events_url":"https://api.github.com/users/ilausuch/events{/privacy}","received_events_url":"https://api.github.com/users/ilausuch/received_events","type":"User","site_admin":false},"body":"This commit extends the functionality of #1307 and #164. These commits allow to the final user to disable the restart of services when the chef client runs. If it is active for any cookbook and one of its services need to clean the flag is raised. To clean this flag there is the command \"clear_restart\" that the user will run when after the manual restart. In this command the service name have to be specified. However is interesting to restart all services of the one cookbook or restart all services in a node.\r\n\r\nThis commit allows to specify the name of the cookbook, cleaning all the service of this cookbook, also allows to don't specify any cookbook that will clean all flags in all cookbooks.\r\n\r\nBackport from #1509","created_at":"2018-03-08T13:08:12Z","updated_at":"2018-03-08T13:10:58Z","closed_at":"2018-03-08T13:08:35Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"Itxaka","id":1447686,"avatar_url":"https://avatars3.githubusercontent.com/u/1447686?v=4","gravatar_id":"","url":"https://api.github.com/users/Itxaka","html_url":"https://github.com/Itxaka","followers_url":"https://api.github.com/users/Itxaka/followers","following_url":"https://api.github.com/users/Itxaka/following{/other_user}","gists_url":"https://api.github.com/users/Itxaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Itxaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itxaka/subscriptions","organizations_url":"https://api.github.com/users/Itxaka/orgs","repos_url":"https://api.github.com/users/Itxaka/repos","events_url":"https://api.github.com/users/Itxaka/events{/privacy}","received_events_url":"https://api.github.com/users/Itxaka/received_events","type":"User","site_admin":false},{"login":"vuntz","id":1758783,"avatar_url":"https://avatars3.githubusercontent.com/u/1758783?v=4","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":627890011,"url":"https://api.github.com/repos/crowbar/crowbar-core/labels/backport%20from%20SOC8","name":"backport from SOC8","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1511/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/71a0333cb301496eeae13601da96982673f3701f","head":{"label":"ilausuch:crowbar_services_restart_all_services_and_restart_by_category_backport","ref":"crowbar_services_restart_all_services_and_restart_by_category_backport","sha":"71a0333cb301496eeae13601da96982673f3701f","user":{"login":"ilausuch","id":11134265,"avatar_url":"https://avatars2.githubusercontent.com/u/11134265?v=4","gravatar_id":"","url":"https://api.github.com/users/ilausuch","html_url":"https://github.com/ilausuch","followers_url":"https://api.github.com/users/ilausuch/followers","following_url":"https://api.github.com/users/ilausuch/following{/other_user}","gists_url":"https://api.github.com/users/ilausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/ilausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilausuch/subscriptions","organizations_url":"https://api.github.com/users/ilausuch/orgs","repos_url":"https://api.github.com/users/ilausuch/repos","events_url":"https://api.github.com/users/ilausuch/events{/privacy}","received_events_url":"https://api.github.com/users/ilausuch/received_events","type":"User","site_admin":false},"repo":{"id":107687392,"name":"crowbar-core","full_name":"ilausuch/crowbar-core","owner":{"login":"ilausuch","id":11134265,"avatar_url":"https://avatars2.githubusercontent.com/u/11134265?v=4","gravatar_id":"","url":"https://api.github.com/users/ilausuch","html_url":"https://github.com/ilausuch","followers_url":"https://api.github.com/users/ilausuch/followers","following_url":"https://api.github.com/users/ilausuch/following{/other_user}","gists_url":"https://api.github.com/users/ilausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/ilausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilausuch/subscriptions","organizations_url":"https://api.github.com/users/ilausuch/orgs","repos_url":"https://api.github.com/users/ilausuch/repos","events_url":"https://api.github.com/users/ilausuch/events{/privacy}","received_events_url":"https://api.github.com/users/ilausuch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilausuch/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/ilausuch/crowbar-core","forks_url":"https://api.github.com/repos/ilausuch/crowbar-core/forks","keys_url":"https://api.github.com/repos/ilausuch/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilausuch/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilausuch/crowbar-core/teams","hooks_url":"https://api.github.com/repos/ilausuch/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/ilausuch/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/ilausuch/crowbar-core/events","assignees_url":"https://api.github.com/repos/ilausuch/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/ilausuch/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/ilausuch/crowbar-core/tags","blobs_url":"https://api.github.com/repos/ilausuch/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilausuch/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilausuch/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilausuch/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilausuch/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ilausuch/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/ilausuch/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/ilausuch/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/ilausuch/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/ilausuch/crowbar-core/subscription","commits_url":"https://api.github.com/repos/ilausuch/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilausuch/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilausuch/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilausuch/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilausuch/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/ilausuch/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilausuch/crowbar-core/merges","archive_url":"https://api.github.com/repos/ilausuch/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilausuch/crowbar-core/downloads","issues_url":"https://api.github.com/repos/ilausuch/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/ilausuch/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ilausuch/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ilausuch/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilausuch/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/ilausuch/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/ilausuch/crowbar-core/deployments","created_at":"2017-10-20T14:23:10Z","updated_at":"2017-11-03T10:20:44Z","pushed_at":"2018-03-08T13:09:11Z","git_url":"git://github.com/ilausuch/crowbar-core.git","ssh_url":"git@github.com:ilausuch/crowbar-core.git","clone_url":"https://github.com/ilausuch/crowbar-core.git","svn_url":"https://github.com/ilausuch/crowbar-core","homepage":null,"size":108990,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"5b0579086d351a951a80782899326b47cdf5c4ab","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2018-01-12T10:07:02Z","pushed_at":"2018-03-08T13:08:12Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":108988,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":46,"license":null,"forks":55,"open_issues":46,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1511"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1511"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1511/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1511/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/71a0333cb301496eeae13601da96982673f3701f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}