{"action":"created","comment":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/233140492","pull_request_review_id":174485662,"id":233140492,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE0MDQ5Mg==","diff_hunk":"@@ -317,7 +317,9 @@ public with sharing class BDI_ContactService {\n             List<String> listDiKey = listDIKeyCx(di, strCx);\n             Contact con = ContactFromDiKeys(listDiKey);\n             if (con != null) {\n-                if (con.Id != null && con.AccountId != null && con.Account.npe01__SYSTEM_AccountType__c != CAO_Constants.HH_ACCOUNT_TYPE) {\n+                Boolean contactAccountIsNotHousehold = con.Id != null && con.AccountId != null ","path":"src/classes/BDI_ContactService.cls","position":5,"original_position":5,"commit_id":"65bb051dd3026de870636aaa4dce86dccd26274a","original_commit_id":"65bb051dd3026de870636aaa4dce86dccd26274a","user":{"login":"kevinswiggum","id":30477616,"node_id":"MDQ6VXNlcjMwNDc3NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/30477616?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinswiggum","html_url":"https://github.com/kevinswiggum","followers_url":"https://api.github.com/users/kevinswiggum/followers","following_url":"https://api.github.com/users/kevinswiggum/following{/other_user}","gists_url":"https://api.github.com/users/kevinswiggum/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinswiggum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinswiggum/subscriptions","organizations_url":"https://api.github.com/users/kevinswiggum/orgs","repos_url":"https://api.github.com/users/kevinswiggum/repos","events_url":"https://api.github.com/users/kevinswiggum/events{/privacy}","received_events_url":"https://api.github.com/users/kevinswiggum/received_events","type":"User","site_admin":false},"body":"@lparrott  Regarding the faculty member scenario...we'll probably need to be a bit more prescriptive in how they link contacts to accounts when Advancement is installed. Otherwise you'll start having personal donations rolling up to Department accounts. I think it's fair to steer customers in a direction where faculty either have Administrative or Household accounts and associate them to their Department account with Affiliations. ","created_at":"2018-11-13T17:14:49Z","updated_at":"2018-11-13T17:14:50Z","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3786#discussion_r233140492","pull_request_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/233140492"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3786#discussion_r233140492"},"pull_request":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786"}},"in_reply_to_id":232763197},"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786","id":228777923,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Nzc3OTIz","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3786","diff_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3786.diff","patch_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3786.patch","issue_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3786","number":3786,"state":"open","locked":false,"title":"Allow HEDA + Advancement orgs to use Data Import and CRLP without the Household Account Model","user":{"login":"lparrott","id":36972889,"node_id":"MDQ6VXNlcjM2OTcyODg5","avatar_url":"https://avatars2.githubusercontent.com/u/36972889?v=4","gravatar_id":"","url":"https://api.github.com/users/lparrott","html_url":"https://github.com/lparrott","followers_url":"https://api.github.com/users/lparrott/followers","following_url":"https://api.github.com/users/lparrott/following{/other_user}","gists_url":"https://api.github.com/users/lparrott/gists{/gist_id}","starred_url":"https://api.github.com/users/lparrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lparrott/subscriptions","organizations_url":"https://api.github.com/users/lparrott/orgs","repos_url":"https://api.github.com/users/lparrott/repos","events_url":"https://api.github.com/users/lparrott/events{/privacy}","received_events_url":"https://api.github.com/users/lparrott/received_events","type":"User","site_admin":false},"body":"- Allow HEDA + Advancement orgs to use Data Import and CRLP without the Household Account Model.\r\n- Skipping automatic Account naming during Data Import if HEDA + Advancement is installed, to instead rely on HEDA TDTM triggers.\r\n\r\n# Critical Changes\r\n\r\n# Changes\r\n\r\n# Issues Closed\r\n\r\n# New Metadata\r\n\r\n# Deleted Metadata\r\n","created_at":"2018-11-06T17:42:28Z","updated_at":"2018-11-13T17:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"488b6ea7305a6173b7dd93685cb670004da003d8","assignee":{"login":"annejackson","id":35311289,"node_id":"MDQ6VXNlcjM1MzExMjg5","avatar_url":"https://avatars1.githubusercontent.com/u/35311289?v=4","gravatar_id":"","url":"https://api.github.com/users/annejackson","html_url":"https://github.com/annejackson","followers_url":"https://api.github.com/users/annejackson/followers","following_url":"https://api.github.com/users/annejackson/following{/other_user}","gists_url":"https://api.github.com/users/annejackson/gists{/gist_id}","starred_url":"https://api.github.com/users/annejackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annejackson/subscriptions","organizations_url":"https://api.github.com/users/annejackson/orgs","repos_url":"https://api.github.com/users/annejackson/repos","events_url":"https://api.github.com/users/annejackson/events{/privacy}","received_events_url":"https://api.github.com/users/annejackson/received_events","type":"User","site_admin":false},"assignees":[{"login":"annejackson","id":35311289,"node_id":"MDQ6VXNlcjM1MzExMjg5","avatar_url":"https://avatars1.githubusercontent.com/u/35311289?v=4","gravatar_id":"","url":"https://api.github.com/users/annejackson","html_url":"https://github.com/annejackson","followers_url":"https://api.github.com/users/annejackson/followers","following_url":"https://api.github.com/users/annejackson/following{/other_user}","gists_url":"https://api.github.com/users/annejackson/gists{/gist_id}","starred_url":"https://api.github.com/users/annejackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annejackson/subscriptions","organizations_url":"https://api.github.com/users/annejackson/orgs","repos_url":"https://api.github.com/users/annejackson/repos","events_url":"https://api.github.com/users/annejackson/events{/privacy}","received_events_url":"https://api.github.com/users/annejackson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786/commits","review_comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786/comments","review_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3786/comments","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/65bb051dd3026de870636aaa4dce86dccd26274a","head":{"label":"SalesforceFoundation:feature/lparrott/bdi-allow-non-hh","ref":"feature/lparrott/bdi-allow-non-hh","sha":"65bb051dd3026de870636aaa4dce86dccd26274a","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-11-09T19:54:52Z","pushed_at":"2018-11-13T17:05:49Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":93999,"stargazers_count":278,"watchers_count":278,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":207,"open_issues":331,"watchers":278,"default_branch":"master"}},"base":{"label":"SalesforceFoundation:master","ref":"master","sha":"ad1e9e855c1aac965e497316902a7295a9d74f40","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","private":false,"owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-11-09T19:54:52Z","pushed_at":"2018-11-13T17:05:49Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":93999,"stargazers_count":278,"watchers_count":278,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":207,"open_issues":331,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3786"},"issue":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3786"},"comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3786/comments"},"review_comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786/comments"},"review_comment":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3786/commits"},"statuses":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/65bb051dd3026de870636aaa4dce86dccd26274a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kevinswiggum"}}