{"action":"created","issue":{"url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/34","repository_url":"https://api.github.com/repos/SofaPirate/Plaquette","labels_url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/34/comments","events_url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/34/events","html_url":"https://github.com/SofaPirate/Plaquette/issues/34","id":331167345,"node_id":"MDU6SXNzdWUzMzExNjczNDU=","number":34,"title":"Rename AnalogOut","user":{"login":"thomasfredericks","id":2685516,"node_id":"MDQ6VXNlcjI2ODU1MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2685516?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasfredericks","html_url":"https://github.com/thomasfredericks","followers_url":"https://api.github.com/users/thomasfredericks/followers","following_url":"https://api.github.com/users/thomasfredericks/following{/other_user}","gists_url":"https://api.github.com/users/thomasfredericks/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfredericks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfredericks/subscriptions","organizations_url":"https://api.github.com/users/thomasfredericks/orgs","repos_url":"https://api.github.com/users/thomasfredericks/repos","events_url":"https://api.github.com/users/thomasfredericks/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfredericks/received_events","type":"User","site_admin":false},"labels":[{"id":220108060,"node_id":"MDU6TGFiZWwyMjAxMDgwNjA=","url":"https://api.github.com/repos/SofaPirate/Plaquette/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-06-11T12:25:44Z","updated_at":"2018-06-11T18:09:42Z","closed_at":null,"author_association":"COLLABORATOR","body":"`AnalogOut` is a misnomer. It should be `PWMOut` or `PwmOut`. The `Pq_05_AnalogOut` example even states the misnomer in its comments:\r\n\r\n>  * Demonstrates analog (PWM) output by sending a ramping value into a LED output\r\n>  * connected to PWM pin 9.\r\n\r\nThis misnomer has been carried from Wiring to Arduino and is confusing, counter intuitive, does not help beginners and conflicts with futur developments. For example, the same pins can do PWM and DAC (real analog out) on the ESP32. See pins 14 and 15: https://hackadaycom.files.wordpress.com/2016/09/pinout_wroom_pinout.png"},"comment":{"url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/comments/396334559","html_url":"https://github.com/SofaPirate/Plaquette/issues/34#issuecomment-396334559","issue_url":"https://api.github.com/repos/SofaPirate/Plaquette/issues/34","id":396334559,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjMzNDU1OQ==","user":{"login":"sofian","id":791244,"node_id":"MDQ6VXNlcjc5MTI0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/791244?v=4","gravatar_id":"","url":"https://api.github.com/users/sofian","html_url":"https://github.com/sofian","followers_url":"https://api.github.com/users/sofian/followers","following_url":"https://api.github.com/users/sofian/following{/other_user}","gists_url":"https://api.github.com/users/sofian/gists{/gist_id}","starred_url":"https://api.github.com/users/sofian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofian/subscriptions","organizations_url":"https://api.github.com/users/sofian/orgs","repos_url":"https://api.github.com/users/sofian/repos","events_url":"https://api.github.com/users/sofian/events{/privacy}","received_events_url":"https://api.github.com/users/sofian/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T18:09:42Z","updated_at":"2018-06-11T18:09:42Z","author_association":"COLLABORATOR","body":"Well currently on ESP32 AnalogOut compiles and it does the right thing (ie. it calls dacWrite, cause analogWrite does not exist on the ESP32 anyway). So we do not need to change anything for now. However we should introduce a new class called PwmOut."}}
{"actor":{"display_login":"sofian"}}