{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/199872270","pull_request_review_id":134076895,"id":199872270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg3MjI3MA==","diff_hunk":"@@ -0,0 +1,23 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<Project ToolsVersion=\"14.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+\n+  <Import Project=\"dir.props\" />\n+  <Import Project=\"..\\dir.targets\" />\n+\n+  <Target Name=\"Build\"\n+          Condition=\"'$(SkipSigning)' != 'true' and '$(SignType)' != 'public'\">\n+\n+    <ItemGroup>\n+      <SignBuildArgs Include=\"/p:ArchGroup=$(ArchGroup)\" />","path":"src/sign.proj","position":11,"original_position":11,"commit_id":"09f6d5461adccf612ee16c48b7a4048f0825616b","original_commit_id":"09f6d5461adccf612ee16c48b7a4048f0825616b","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"What did you do to figure out the set of properties to pass?","created_at":"2018-07-03T16:29:24Z","updated_at":"2018-07-03T16:29:25Z","html_url":"https://github.com/dotnet/corefx/pull/30797#discussion_r199872270","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/30797","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/199872270"},"html":{"href":"https://github.com/dotnet/corefx/pull/30797#discussion_r199872270"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30797"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30797","id":198814357,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODE0MzU3","html_url":"https://github.com/dotnet/corefx/pull/30797","diff_url":"https://github.com/dotnet/corefx/pull/30797.diff","patch_url":"https://github.com/dotnet/corefx/pull/30797.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30797","number":30797,"state":"open","locked":false,"title":"Moving sign.builds to run on full .NET Framework.","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"MicroBuild signing doesn't work when MSBuild is running on .NET Core. So move the signing piece to use MSBuild on full framework.","created_at":"2018-07-02T23:32:52Z","updated_at":"2018-07-03T16:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ba445d32c72009f182149813e4ec55abd0181b2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wtgodbe","id":14283640,"node_id":"MDQ6VXNlcjE0MjgzNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/14283640?v=4","gravatar_id":"","url":"https://api.github.com/users/wtgodbe","html_url":"https://github.com/wtgodbe","followers_url":"https://api.github.com/users/wtgodbe/followers","following_url":"https://api.github.com/users/wtgodbe/following{/other_user}","gists_url":"https://api.github.com/users/wtgodbe/gists{/gist_id}","starred_url":"https://api.github.com/users/wtgodbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtgodbe/subscriptions","organizations_url":"https://api.github.com/users/wtgodbe/orgs","repos_url":"https://api.github.com/users/wtgodbe/repos","events_url":"https://api.github.com/users/wtgodbe/events{/privacy}","received_events_url":"https://api.github.com/users/wtgodbe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/30797/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/30797/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30797/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/09f6d5461adccf612ee16c48b7a4048f0825616b","head":{"label":"eerhardt:SigningOnNetFx","ref":"SigningOnNetFx","sha":"09f6d5461adccf612ee16c48b7a4048f0825616b","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":38781378,"node_id":"MDEwOlJlcG9zaXRvcnkzODc4MTM3OA==","name":"corefx","full_name":"eerhardt/corefx","owner":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/eerhardt/corefx","forks_url":"https://api.github.com/repos/eerhardt/corefx/forks","keys_url":"https://api.github.com/repos/eerhardt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/corefx/teams","hooks_url":"https://api.github.com/repos/eerhardt/corefx/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/corefx/events","assignees_url":"https://api.github.com/repos/eerhardt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/corefx/tags","blobs_url":"https://api.github.com/repos/eerhardt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/corefx/languages","stargazers_url":"https://api.github.com/repos/eerhardt/corefx/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/corefx/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/corefx/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/corefx/subscription","commits_url":"https://api.github.com/repos/eerhardt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/corefx/merges","archive_url":"https://api.github.com/repos/eerhardt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/corefx/downloads","issues_url":"https://api.github.com/repos/eerhardt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/eerhardt/corefx/deployments","created_at":"2015-07-08T21:38:15Z","updated_at":"2016-01-20T21:29:59Z","pushed_at":"2018-07-02T23:31:02Z","git_url":"git://github.com/eerhardt/corefx.git","ssh_url":"git@github.com:eerhardt/corefx.git","clone_url":"https://github.com/eerhardt/corefx.git","svn_url":"https://github.com/eerhardt/corefx","homepage":"http://dotnet.github.io/core/","size":178325,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2e6994336ba7eddb326646d43f1456e753caf47d","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-07-03T15:27:48Z","pushed_at":"2018-07-03T16:11:22Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":182445,"stargazers_count":14276,"watchers_count":14276,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4135,"mirror_url":null,"archived":false,"open_issues_count":2363,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4135,"open_issues":2363,"watchers":14276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30797"},"html":{"href":"https://github.com/dotnet/corefx/pull/30797"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30797"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30797/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30797/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30797/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/09f6d5461adccf612ee16c48b7a4048f0825616b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"weshaggard"}}