{"action":"created","comment":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/comments/221558323","pull_request_review_id":160232806,"id":221558323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU1ODMyMw==","diff_hunk":"@@ -28,9 +28,13 @@\n public class SourceFragmentCreator extends ChangeCollector {\n \t@Override\n \tprotected void onChange(CtElement currentElement, CtRole role) {\n+\t\tif (!currentElement.isParentInitialized()) {\n+\t\t\t//parent is not initialized. It is just creation of an temporary element","path":"src/main/java/spoon/support/modelobs/SourceFragmentCreator.java","position":null,"original_position":5,"commit_id":"5d6f8f967538f0d3cf0d83c04ed6746bf3ef8d18","original_commit_id":"f229c682171da8745262d926048d67f24d9b407a","user":{"login":"pvojtechovsky","id":23107345,"node_id":"MDQ6VXNlcjIzMTA3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"body":"Thanks. I speak java better then English ;-)","created_at":"2018-10-01T10:18:19Z","updated_at":"2018-10-01T10:18:19Z","html_url":"https://github.com/INRIA/spoon/pull/2592#discussion_r221558323","pull_request_url":"https://api.github.com/repos/INRIA/spoon/pulls/2592","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments/221558323"},"html":{"href":"https://github.com/INRIA/spoon/pull/2592#discussion_r221558323"},"pull_request":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2592"}},"in_reply_to_id":221555548},"pull_request":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/2592","id":219224692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjI0Njky","html_url":"https://github.com/INRIA/spoon/pull/2592","diff_url":"https://github.com/INRIA/spoon/pull/2592.diff","patch_url":"https://github.com/INRIA/spoon/pull/2592.patch","issue_url":"https://api.github.com/repos/INRIA/spoon/issues/2592","number":2592,"state":"open","locked":false,"title":"fix: ignore changes on elements without parent","user":{"login":"pvojtechovsky","id":23107345,"node_id":"MDQ6VXNlcjIzMTA3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"body":"SniperPrinter change collector listens on changes ... but spoon produces many ... many change events during normal analyzing tasks (no real changing of model). For example just creation of type references or adapting generic types creates many temporary AST node instances, which are not really connected to the AST... but they produce change requests.\r\n\r\nThis PR tries to filter out at least those events whose element has no parent.\r\n\r\n... but there are still other temporary elements which has set parent, but has no connection from parent to temporary element. This check is more expensive ... so it is better to run analyzing code using `ChangeCollector.runWithoutChangeListener`... without that change collector soon eats many GB of memory and fails.","created_at":"2018-09-30T20:10:38Z","updated_at":"2018-10-01T10:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ebed020eafc0ac10ddfdc42d929ff3c8db894e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/INRIA/spoon/pulls/2592/commits","review_comments_url":"https://api.github.com/repos/INRIA/spoon/pulls/2592/comments","review_comment_url":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INRIA/spoon/issues/2592/comments","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/5d6f8f967538f0d3cf0d83c04ed6746bf3ef8d18","head":{"label":"pvojtechovsky:fixIgnoreChange","ref":"fixIgnoreChange","sha":"5d6f8f967538f0d3cf0d83c04ed6746bf3ef8d18","user":{"login":"pvojtechovsky","id":23107345,"node_id":"MDQ6VXNlcjIzMTA3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"repo":{"id":72202535,"node_id":"MDEwOlJlcG9zaXRvcnk3MjIwMjUzNQ==","name":"spoon","full_name":"pvojtechovsky/spoon","private":false,"owner":{"login":"pvojtechovsky","id":23107345,"node_id":"MDQ6VXNlcjIzMTA3MzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pvojtechovsky/spoon","description":"Spoon is a library for analyzing, rewriting, transforming, transpiling Java source code. It parses source files to build a well-designed AST with powerful analysis and transformation API. It fully supports Java 8.  :beers: :sparkles:","fork":true,"url":"https://api.github.com/repos/pvojtechovsky/spoon","forks_url":"https://api.github.com/repos/pvojtechovsky/spoon/forks","keys_url":"https://api.github.com/repos/pvojtechovsky/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvojtechovsky/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvojtechovsky/spoon/teams","hooks_url":"https://api.github.com/repos/pvojtechovsky/spoon/hooks","issue_events_url":"https://api.github.com/repos/pvojtechovsky/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/pvojtechovsky/spoon/events","assignees_url":"https://api.github.com/repos/pvojtechovsky/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/pvojtechovsky/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/pvojtechovsky/spoon/tags","blobs_url":"https://api.github.com/repos/pvojtechovsky/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvojtechovsky/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvojtechovsky/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvojtechovsky/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvojtechovsky/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/pvojtechovsky/spoon/languages","stargazers_url":"https://api.github.com/repos/pvojtechovsky/spoon/stargazers","contributors_url":"https://api.github.com/repos/pvojtechovsky/spoon/contributors","subscribers_url":"https://api.github.com/repos/pvojtechovsky/spoon/subscribers","subscription_url":"https://api.github.com/repos/pvojtechovsky/spoon/subscription","commits_url":"https://api.github.com/repos/pvojtechovsky/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvojtechovsky/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvojtechovsky/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvojtechovsky/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvojtechovsky/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/pvojtechovsky/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvojtechovsky/spoon/merges","archive_url":"https://api.github.com/repos/pvojtechovsky/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvojtechovsky/spoon/downloads","issues_url":"https://api.github.com/repos/pvojtechovsky/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/pvojtechovsky/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/pvojtechovsky/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/pvojtechovsky/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvojtechovsky/spoon/labels{/name}","releases_url":"https://api.github.com/repos/pvojtechovsky/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/pvojtechovsky/spoon/deployments","created_at":"2016-10-28T11:39:17Z","updated_at":"2018-07-18T09:05:47Z","pushed_at":"2018-10-01T10:17:44Z","git_url":"git://github.com/pvojtechovsky/spoon.git","ssh_url":"git@github.com:pvojtechovsky/spoon.git","clone_url":"https://github.com/pvojtechovsky/spoon.git","svn_url":"https://github.com/pvojtechovsky/spoon","homepage":"http://spoon.gforge.inria.fr/","size":22533,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"INRIA:master","ref":"master","sha":"f8669235d3a517e364eda154869039d00fef353e","user":{"login":"INRIA","id":2951919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTE5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2951919?v=4","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"repo":{"id":14176513,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NjUxMw==","name":"spoon","full_name":"INRIA/spoon","private":false,"owner":{"login":"INRIA","id":2951919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTE5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2951919?v=4","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/INRIA/spoon","description":"Spoon is a library to analyze, transform, rewrite, transpile Java source code (incl Java 9 & Java 10). It parses source files to build a well-designed AST with powerful analysis and transformation API. Made at Inria with :heart:, :beers: and :sparkles:.","fork":false,"url":"https://api.github.com/repos/INRIA/spoon","forks_url":"https://api.github.com/repos/INRIA/spoon/forks","keys_url":"https://api.github.com/repos/INRIA/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INRIA/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INRIA/spoon/teams","hooks_url":"https://api.github.com/repos/INRIA/spoon/hooks","issue_events_url":"https://api.github.com/repos/INRIA/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/INRIA/spoon/events","assignees_url":"https://api.github.com/repos/INRIA/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/INRIA/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/INRIA/spoon/tags","blobs_url":"https://api.github.com/repos/INRIA/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INRIA/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INRIA/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/INRIA/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/INRIA/spoon/languages","stargazers_url":"https://api.github.com/repos/INRIA/spoon/stargazers","contributors_url":"https://api.github.com/repos/INRIA/spoon/contributors","subscribers_url":"https://api.github.com/repos/INRIA/spoon/subscribers","subscription_url":"https://api.github.com/repos/INRIA/spoon/subscription","commits_url":"https://api.github.com/repos/INRIA/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/INRIA/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/INRIA/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/INRIA/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/INRIA/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/INRIA/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INRIA/spoon/merges","archive_url":"https://api.github.com/repos/INRIA/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INRIA/spoon/downloads","issues_url":"https://api.github.com/repos/INRIA/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/INRIA/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/INRIA/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/INRIA/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INRIA/spoon/labels{/name}","releases_url":"https://api.github.com/repos/INRIA/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/INRIA/spoon/deployments","created_at":"2013-11-06T15:29:59Z","updated_at":"2018-09-30T15:15:00Z","pushed_at":"2018-10-01T10:17:46Z","git_url":"git://github.com/INRIA/spoon.git","ssh_url":"git@github.com:INRIA/spoon.git","clone_url":"https://github.com/INRIA/spoon.git","svn_url":"https://github.com/INRIA/spoon","homepage":"http://spoon.gforge.inria.fr/","size":22410,"stargazers_count":623,"watchers_count":623,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":122,"open_issues":92,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2592"},"html":{"href":"https://github.com/INRIA/spoon/pull/2592"},"issue":{"href":"https://api.github.com/repos/INRIA/spoon/issues/2592"},"comments":{"href":"https://api.github.com/repos/INRIA/spoon/issues/2592/comments"},"review_comments":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2592/comments"},"review_comment":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/2592/commits"},"statuses":{"href":"https://api.github.com/repos/INRIA/spoon/statuses/5d6f8f967538f0d3cf0d83c04ed6746bf3ef8d18"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pvojtechovsky"}}