{"action":"created","comment":{"url":"https://api.github.com/repos/d3/d3-collection/pulls/comments/183210599","pull_request_review_id":114173736,"id":183210599,"diff_hunk":"@@ -41,7 +43,12 @@ export default function() {\n     if (++depth > keys.length) return map;\n     var array, sortKey = sortKeys[depth - 1];\n     if (rollup != null && depth >= keys.length) array = map.entries();\n-    else array = [], map.each(function(v, k) { array.push({key: k, values: entries(v, depth)}); });\n+    else {\n+      array = [];\n+      map.each(function (v, k) {\n+        array.push({ [keyField]: k, [valuesField]: entries(v, depth) });","path":"src/nest.js","position":null,"original_position":17,"commit_id":"83d8399f12ccd2c1173adf456019d24dda984faa","original_commit_id":"4aef047ef605f875a3f79efdfd31e006abd23bc6","user":{"login":"nyurik","id":1641515,"avatar_url":"https://avatars0.githubusercontent.com/u/1641515?v=4","gravatar_id":"","url":"https://api.github.com/users/nyurik","html_url":"https://github.com/nyurik","followers_url":"https://api.github.com/users/nyurik/followers","following_url":"https://api.github.com/users/nyurik/following{/other_user}","gists_url":"https://api.github.com/users/nyurik/gists{/gist_id}","starred_url":"https://api.github.com/users/nyurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyurik/subscriptions","organizations_url":"https://api.github.com/users/nyurik/orgs","repos_url":"https://api.github.com/users/nyurik/repos","events_url":"https://api.github.com/users/nyurik/events{/privacy}","received_events_url":"https://api.github.com/users/nyurik/received_events","type":"User","site_admin":false},"body":"@curran ugh :(   I think there should either be a test for that, or it might be time to switch to ES6+, and use babel.  In any case, fixed, thx for spotting.","created_at":"2018-04-21T14:08:16Z","updated_at":"2018-04-21T14:08:16Z","html_url":"https://github.com/d3/d3-collection/pull/26#discussion_r183210599","pull_request_url":"https://api.github.com/repos/d3/d3-collection/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/comments/183210599"},"html":{"href":"https://github.com/d3/d3-collection/pull/26#discussion_r183210599"},"pull_request":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/26"}},"in_reply_to_id":183204681},"pull_request":{"url":"https://api.github.com/repos/d3/d3-collection/pulls/26","id":183201580,"html_url":"https://github.com/d3/d3-collection/pull/26","diff_url":"https://github.com/d3/d3-collection/pull/26.diff","patch_url":"https://github.com/d3/d3-collection/pull/26.patch","issue_url":"https://api.github.com/repos/d3/d3-collection/issues/26","number":26,"state":"open","locked":false,"title":"add support for nest.keyField and nest.valuesField","user":{"login":"nyurik","id":1641515,"avatar_url":"https://avatars0.githubusercontent.com/u/1641515?v=4","gravatar_id":"","url":"https://api.github.com/users/nyurik","html_url":"https://github.com/nyurik","followers_url":"https://api.github.com/users/nyurik/followers","following_url":"https://api.github.com/users/nyurik/following{/other_user}","gists_url":"https://api.github.com/users/nyurik/gists{/gist_id}","starred_url":"https://api.github.com/users/nyurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyurik/subscriptions","organizations_url":"https://api.github.com/users/nyurik/orgs","repos_url":"https://api.github.com/users/nyurik/repos","events_url":"https://api.github.com/users/nyurik/events{/privacy}","received_events_url":"https://api.github.com/users/nyurik/received_events","type":"User","site_admin":false},"body":"see https://github.com/d3/d3-collection/issues/25","created_at":"2018-04-21T02:37:47Z","updated_at":"2018-04-21T14:08:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6ee7e5c50108fa8c4d6c2d6f0b0616d8eb344f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3/d3-collection/pulls/26/commits","review_comments_url":"https://api.github.com/repos/d3/d3-collection/pulls/26/comments","review_comment_url":"https://api.github.com/repos/d3/d3-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3/d3-collection/issues/26/comments","statuses_url":"https://api.github.com/repos/d3/d3-collection/statuses/83d8399f12ccd2c1173adf456019d24dda984faa","head":{"label":"nyurik:master","ref":"master","sha":"83d8399f12ccd2c1173adf456019d24dda984faa","user":{"login":"nyurik","id":1641515,"avatar_url":"https://avatars0.githubusercontent.com/u/1641515?v=4","gravatar_id":"","url":"https://api.github.com/users/nyurik","html_url":"https://github.com/nyurik","followers_url":"https://api.github.com/users/nyurik/followers","following_url":"https://api.github.com/users/nyurik/following{/other_user}","gists_url":"https://api.github.com/users/nyurik/gists{/gist_id}","starred_url":"https://api.github.com/users/nyurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyurik/subscriptions","organizations_url":"https://api.github.com/users/nyurik/orgs","repos_url":"https://api.github.com/users/nyurik/repos","events_url":"https://api.github.com/users/nyurik/events{/privacy}","received_events_url":"https://api.github.com/users/nyurik/received_events","type":"User","site_admin":false},"repo":{"id":130431449,"name":"d3-collection","full_name":"nyurik/d3-collection","owner":{"login":"nyurik","id":1641515,"avatar_url":"https://avatars0.githubusercontent.com/u/1641515?v=4","gravatar_id":"","url":"https://api.github.com/users/nyurik","html_url":"https://github.com/nyurik","followers_url":"https://api.github.com/users/nyurik/followers","following_url":"https://api.github.com/users/nyurik/following{/other_user}","gists_url":"https://api.github.com/users/nyurik/gists{/gist_id}","starred_url":"https://api.github.com/users/nyurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyurik/subscriptions","organizations_url":"https://api.github.com/users/nyurik/orgs","repos_url":"https://api.github.com/users/nyurik/repos","events_url":"https://api.github.com/users/nyurik/events{/privacy}","received_events_url":"https://api.github.com/users/nyurik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyurik/d3-collection","description":"Handy data structures for elements keyed by string.","fork":true,"url":"https://api.github.com/repos/nyurik/d3-collection","forks_url":"https://api.github.com/repos/nyurik/d3-collection/forks","keys_url":"https://api.github.com/repos/nyurik/d3-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyurik/d3-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyurik/d3-collection/teams","hooks_url":"https://api.github.com/repos/nyurik/d3-collection/hooks","issue_events_url":"https://api.github.com/repos/nyurik/d3-collection/issues/events{/number}","events_url":"https://api.github.com/repos/nyurik/d3-collection/events","assignees_url":"https://api.github.com/repos/nyurik/d3-collection/assignees{/user}","branches_url":"https://api.github.com/repos/nyurik/d3-collection/branches{/branch}","tags_url":"https://api.github.com/repos/nyurik/d3-collection/tags","blobs_url":"https://api.github.com/repos/nyurik/d3-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyurik/d3-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyurik/d3-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyurik/d3-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyurik/d3-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/nyurik/d3-collection/languages","stargazers_url":"https://api.github.com/repos/nyurik/d3-collection/stargazers","contributors_url":"https://api.github.com/repos/nyurik/d3-collection/contributors","subscribers_url":"https://api.github.com/repos/nyurik/d3-collection/subscribers","subscription_url":"https://api.github.com/repos/nyurik/d3-collection/subscription","commits_url":"https://api.github.com/repos/nyurik/d3-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyurik/d3-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyurik/d3-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyurik/d3-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyurik/d3-collection/contents/{+path}","compare_url":"https://api.github.com/repos/nyurik/d3-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyurik/d3-collection/merges","archive_url":"https://api.github.com/repos/nyurik/d3-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyurik/d3-collection/downloads","issues_url":"https://api.github.com/repos/nyurik/d3-collection/issues{/number}","pulls_url":"https://api.github.com/repos/nyurik/d3-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/nyurik/d3-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/nyurik/d3-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyurik/d3-collection/labels{/name}","releases_url":"https://api.github.com/repos/nyurik/d3-collection/releases{/id}","deployments_url":"https://api.github.com/repos/nyurik/d3-collection/deployments","created_at":"2018-04-21T02:10:54Z","updated_at":"2018-04-21T14:07:26Z","pushed_at":"2018-04-21T14:07:24Z","git_url":"git://github.com/nyurik/d3-collection.git","ssh_url":"git@github.com:nyurik/d3-collection.git","clone_url":"https://github.com/nyurik/d3-collection.git","svn_url":"https://github.com/nyurik/d3-collection","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d3:master","ref":"master","sha":"1eff7233bac174045331d275e7e0cb793dfdaa0d","user":{"login":"d3","id":1562726,"avatar_url":"https://avatars1.githubusercontent.com/u/1562726?v=4","gravatar_id":"","url":"https://api.github.com/users/d3","html_url":"https://github.com/d3","followers_url":"https://api.github.com/users/d3/followers","following_url":"https://api.github.com/users/d3/following{/other_user}","gists_url":"https://api.github.com/users/d3/gists{/gist_id}","starred_url":"https://api.github.com/users/d3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3/subscriptions","organizations_url":"https://api.github.com/users/d3/orgs","repos_url":"https://api.github.com/users/d3/repos","events_url":"https://api.github.com/users/d3/events{/privacy}","received_events_url":"https://api.github.com/users/d3/received_events","type":"Organization","site_admin":false},"repo":{"id":49227570,"name":"d3-collection","full_name":"d3/d3-collection","owner":{"login":"d3","id":1562726,"avatar_url":"https://avatars1.githubusercontent.com/u/1562726?v=4","gravatar_id":"","url":"https://api.github.com/users/d3","html_url":"https://github.com/d3","followers_url":"https://api.github.com/users/d3/followers","following_url":"https://api.github.com/users/d3/following{/other_user}","gists_url":"https://api.github.com/users/d3/gists{/gist_id}","starred_url":"https://api.github.com/users/d3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3/subscriptions","organizations_url":"https://api.github.com/users/d3/orgs","repos_url":"https://api.github.com/users/d3/repos","events_url":"https://api.github.com/users/d3/events{/privacy}","received_events_url":"https://api.github.com/users/d3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d3/d3-collection","description":"Handy data structures for elements keyed by string.","fork":false,"url":"https://api.github.com/repos/d3/d3-collection","forks_url":"https://api.github.com/repos/d3/d3-collection/forks","keys_url":"https://api.github.com/repos/d3/d3-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3/d3-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3/d3-collection/teams","hooks_url":"https://api.github.com/repos/d3/d3-collection/hooks","issue_events_url":"https://api.github.com/repos/d3/d3-collection/issues/events{/number}","events_url":"https://api.github.com/repos/d3/d3-collection/events","assignees_url":"https://api.github.com/repos/d3/d3-collection/assignees{/user}","branches_url":"https://api.github.com/repos/d3/d3-collection/branches{/branch}","tags_url":"https://api.github.com/repos/d3/d3-collection/tags","blobs_url":"https://api.github.com/repos/d3/d3-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3/d3-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3/d3-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3/d3-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3/d3-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/d3/d3-collection/languages","stargazers_url":"https://api.github.com/repos/d3/d3-collection/stargazers","contributors_url":"https://api.github.com/repos/d3/d3-collection/contributors","subscribers_url":"https://api.github.com/repos/d3/d3-collection/subscribers","subscription_url":"https://api.github.com/repos/d3/d3-collection/subscription","commits_url":"https://api.github.com/repos/d3/d3-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3/d3-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3/d3-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3/d3-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3/d3-collection/contents/{+path}","compare_url":"https://api.github.com/repos/d3/d3-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3/d3-collection/merges","archive_url":"https://api.github.com/repos/d3/d3-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3/d3-collection/downloads","issues_url":"https://api.github.com/repos/d3/d3-collection/issues{/number}","pulls_url":"https://api.github.com/repos/d3/d3-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/d3/d3-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/d3/d3-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3/d3-collection/labels{/name}","releases_url":"https://api.github.com/repos/d3/d3-collection/releases{/id}","deployments_url":"https://api.github.com/repos/d3/d3-collection/deployments","created_at":"2016-01-07T20:01:39Z","updated_at":"2018-04-19T06:53:47Z","pushed_at":"2018-04-21T14:07:25Z","git_url":"git://github.com/d3/d3-collection.git","ssh_url":"git@github.com:d3/d3-collection.git","clone_url":"https://github.com/d3/d3-collection.git","svn_url":"https://github.com/d3/d3-collection","homepage":null,"size":35,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":25,"open_issues":12,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/26"},"html":{"href":"https://github.com/d3/d3-collection/pull/26"},"issue":{"href":"https://api.github.com/repos/d3/d3-collection/issues/26"},"comments":{"href":"https://api.github.com/repos/d3/d3-collection/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3/d3-collection/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/d3/d3-collection/statuses/83d8399f12ccd2c1173adf456019d24dda984faa"}},"author_association":"NONE"}}
{"actor":{"display_login":"nyurik"}}