{"action":"closed","number":1745,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745","id":205126525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTI2NTI1","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1745","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1745.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1745.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1745","number":1745,"state":"closed","locked":false,"title":"Wrap entire timer.cpp in SPIRV_TIMER_ENABLED.","user":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"body":"This CL moves the SPIRV_TIMER_ENABLED preprocesser guard to encompass\r\nthe includes along with the source. Currently we will try to pull in\r\nsys/resource.h on machines which may not have the file available and the\r\nbuild will fail. If we don't need timers, then we don't need the\r\nincludes as well.","created_at":"2018-07-31T14:11:07Z","updated_at":"2018-07-31T14:39:51Z","closed_at":"2018-07-31T14:39:51Z","merged_at":null,"merge_commit_sha":"aece136c10318d0bfb098f2cf4203ae4ab0c92e4","assignee":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"assignees":[{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"alan-baker","id":33432579,"node_id":"MDQ6VXNlcjMzNDMyNTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33432579?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-baker","html_url":"https://github.com/alan-baker","followers_url":"https://api.github.com/users/alan-baker/followers","following_url":"https://api.github.com/users/alan-baker/following{/other_user}","gists_url":"https://api.github.com/users/alan-baker/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-baker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-baker/subscriptions","organizations_url":"https://api.github.com/users/alan-baker/orgs","repos_url":"https://api.github.com/users/alan-baker/repos","events_url":"https://api.github.com/users/alan-baker/events{/privacy}","received_events_url":"https://api.github.com/users/alan-baker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1745/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/20043bc838d12c394ac5c775977e4ec6c3cb5a31","head":{"label":"dj2:guard","ref":"guard","sha":"20043bc838d12c394ac5c775977e4ec6c3cb5a31","user":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"repo":{"id":134433504,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MzM1MDQ=","name":"SPIRV-Tools","full_name":"dj2/SPIRV-Tools","owner":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dj2/SPIRV-Tools","description":null,"fork":true,"url":"https://api.github.com/repos/dj2/SPIRV-Tools","forks_url":"https://api.github.com/repos/dj2/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/dj2/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dj2/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dj2/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/dj2/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/dj2/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/dj2/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/dj2/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/dj2/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/dj2/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/dj2/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dj2/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dj2/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dj2/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dj2/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/dj2/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/dj2/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/dj2/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/dj2/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/dj2/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/dj2/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dj2/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dj2/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dj2/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dj2/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/dj2/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dj2/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/dj2/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dj2/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/dj2/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/dj2/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/dj2/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/dj2/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dj2/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/dj2/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/dj2/SPIRV-Tools/deployments","created_at":"2018-05-22T15:10:15Z","updated_at":"2018-07-31T13:55:59Z","pushed_at":"2018-07-31T14:37:02Z","git_url":"git://github.com/dj2/SPIRV-Tools.git","ssh_url":"git@github.com:dj2/SPIRV-Tools.git","clone_url":"https://github.com/dj2/SPIRV-Tools.git","svn_url":"https://github.com/dj2/SPIRV-Tools","homepage":null,"size":8395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"dcea11fa03cc0df7101c9c433ab7791e0d84179a","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"node_id":"MDEwOlJlcG9zaXRvcnk0NTk4MTgwMQ==","name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":null,"fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2018-07-31T14:39:30Z","pushed_at":"2018-07-31T14:39:27Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":8349,"stargazers_count":304,"watchers_count":304,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":120,"open_issues":199,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1745"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1745"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1745/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1745/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/20043bc838d12c394ac5c775977e4ec6c3cb5a31"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"dneto0"}}