{"action":"created","comment":{"url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments/233726075","pull_request_review_id":175207387,"id":233726075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzcyNjA3NQ==","diff_hunk":"@@ -45,98 +45,6 @@ def get_duplicate_node_uuids(self):\n             \"\"\"\n         return self.raw(query)\n \n-    # This is an example of a query that could be overriden by a better implementation,\n-    # for performance reasons:\n-    def query_jobcalculations_by_computer_user_state(","path":"aiida/backends/general/abstractqueries.py","position":6,"original_position":6,"commit_id":"f67bcdfe091de63beea5ba37ed0235a0a0d62650","original_commit_id":"f67bcdfe091de63beea5ba37ed0235a0a0d62650","user":{"login":"giovannipizzi","id":16132028,"node_id":"MDQ6VXNlcjE2MTMyMDI4","avatar_url":"https://avatars0.githubusercontent.com/u/16132028?v=4","gravatar_id":"","url":"https://api.github.com/users/giovannipizzi","html_url":"https://github.com/giovannipizzi","followers_url":"https://api.github.com/users/giovannipizzi/followers","following_url":"https://api.github.com/users/giovannipizzi/following{/other_user}","gists_url":"https://api.github.com/users/giovannipizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/giovannipizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giovannipizzi/subscriptions","organizations_url":"https://api.github.com/users/giovannipizzi/orgs","repos_url":"https://api.github.com/users/giovannipizzi/repos","events_url":"https://api.github.com/users/giovannipizzi/events{/privacy}","received_events_url":"https://api.github.com/users/giovannipizzi/received_events","type":"User","site_admin":false},"body":"Are these just renamed or completely removed? These were here because they could be made faster by custom implementations of the query (how does now `verdi calculation list` get the list of non-finished calculations, and is this fast?","created_at":"2018-11-15T06:36:53Z","updated_at":"2018-11-15T06:53:31Z","html_url":"https://github.com/aiidateam/aiida_core/pull/2201#discussion_r233726075","pull_request_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments/233726075"},"html":{"href":"https://github.com/aiidateam/aiida_core/pull/2201#discussion_r233726075"},"pull_request":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201"}}},"pull_request":{"url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201","id":230935496,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTM1NDk2","html_url":"https://github.com/aiidateam/aiida_core/pull/2201","diff_url":"https://github.com/aiidateam/aiida_core/pull/2201.diff","patch_url":"https://github.com/aiidateam/aiida_core/pull/2201.patch","issue_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2201","number":2201,"state":"open","locked":false,"title":"Rename node class for `JobCalculation`","user":{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false},"body":"Fixes #2199 \r\n\r\nThe node class changed from `JobCalculation` to `CalcJobNode`.\r\n\r\nSince the `JobCalculation` class is heavily used by users, as it is the\r\nclass that is sub classed to define a job calculation, we cannot quite get\r\nrid of it. Instead we moved all the logic from the old `Calculation` and\r\n`JobCalculation` classes to their new equivalents `ProcessNode` and `CalcJobNode`,\r\nand put an alias to `CalcJobNode` for `JobCalculation`.\r\n\r\nThis last class can now still be imported from `aiida.orm.calculation` and\r\n`aiida.orm.calculation.job`. Note that the paths that import directly from the\r\n`implementation.general` sub module have been removed, because the job calculation\r\nclasses are now fully concrete.\r\n\r\nFurthermore, the old entry points for the base calculation classes `inline`, `job`\r\n`work` and `function` have been removed as they have been replaced with the entry\r\npoints in the `aiida.node` group for the new node classes.","created_at":"2018-11-14T18:24:02Z","updated_at":"2018-11-15T06:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db0f4654256a68a7656f52b161c8127bbb1220be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"muhrin","id":1628907,"node_id":"MDQ6VXNlcjE2Mjg5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1628907?v=4","gravatar_id":"","url":"https://api.github.com/users/muhrin","html_url":"https://github.com/muhrin","followers_url":"https://api.github.com/users/muhrin/followers","following_url":"https://api.github.com/users/muhrin/following{/other_user}","gists_url":"https://api.github.com/users/muhrin/gists{/gist_id}","starred_url":"https://api.github.com/users/muhrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhrin/subscriptions","organizations_url":"https://api.github.com/users/muhrin/orgs","repos_url":"https://api.github.com/users/muhrin/repos","events_url":"https://api.github.com/users/muhrin/events{/privacy}","received_events_url":"https://api.github.com/users/muhrin/received_events","type":"User","site_admin":false},{"login":"szoupanos","id":24694976,"node_id":"MDQ6VXNlcjI0Njk0OTc2","avatar_url":"https://avatars0.githubusercontent.com/u/24694976?v=4","gravatar_id":"","url":"https://api.github.com/users/szoupanos","html_url":"https://github.com/szoupanos","followers_url":"https://api.github.com/users/szoupanos/followers","following_url":"https://api.github.com/users/szoupanos/following{/other_user}","gists_url":"https://api.github.com/users/szoupanos/gists{/gist_id}","starred_url":"https://api.github.com/users/szoupanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szoupanos/subscriptions","organizations_url":"https://api.github.com/users/szoupanos/orgs","repos_url":"https://api.github.com/users/szoupanos/repos","events_url":"https://api.github.com/users/szoupanos/events{/privacy}","received_events_url":"https://api.github.com/users/szoupanos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201/commits","review_comments_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201/comments","review_comment_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2201/comments","statuses_url":"https://api.github.com/repos/aiidateam/aiida_core/statuses/f67bcdfe091de63beea5ba37ed0235a0a0d62650","head":{"label":"sphuber:fix_2199_rename_job_calculation","ref":"fix_2199_rename_job_calculation","sha":"f67bcdfe091de63beea5ba37ed0235a0a0d62650","user":{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false},"repo":{"id":78537725,"node_id":"MDEwOlJlcG9zaXRvcnk3ODUzNzcyNQ==","name":"aiida_core","full_name":"sphuber/aiida_core","private":false,"owner":{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sphuber/aiida_core","description":"The official repository for the AiiDA code","fork":true,"url":"https://api.github.com/repos/sphuber/aiida_core","forks_url":"https://api.github.com/repos/sphuber/aiida_core/forks","keys_url":"https://api.github.com/repos/sphuber/aiida_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphuber/aiida_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphuber/aiida_core/teams","hooks_url":"https://api.github.com/repos/sphuber/aiida_core/hooks","issue_events_url":"https://api.github.com/repos/sphuber/aiida_core/issues/events{/number}","events_url":"https://api.github.com/repos/sphuber/aiida_core/events","assignees_url":"https://api.github.com/repos/sphuber/aiida_core/assignees{/user}","branches_url":"https://api.github.com/repos/sphuber/aiida_core/branches{/branch}","tags_url":"https://api.github.com/repos/sphuber/aiida_core/tags","blobs_url":"https://api.github.com/repos/sphuber/aiida_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphuber/aiida_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphuber/aiida_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphuber/aiida_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphuber/aiida_core/statuses/{sha}","languages_url":"https://api.github.com/repos/sphuber/aiida_core/languages","stargazers_url":"https://api.github.com/repos/sphuber/aiida_core/stargazers","contributors_url":"https://api.github.com/repos/sphuber/aiida_core/contributors","subscribers_url":"https://api.github.com/repos/sphuber/aiida_core/subscribers","subscription_url":"https://api.github.com/repos/sphuber/aiida_core/subscription","commits_url":"https://api.github.com/repos/sphuber/aiida_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphuber/aiida_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphuber/aiida_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphuber/aiida_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphuber/aiida_core/contents/{+path}","compare_url":"https://api.github.com/repos/sphuber/aiida_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphuber/aiida_core/merges","archive_url":"https://api.github.com/repos/sphuber/aiida_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphuber/aiida_core/downloads","issues_url":"https://api.github.com/repos/sphuber/aiida_core/issues{/number}","pulls_url":"https://api.github.com/repos/sphuber/aiida_core/pulls{/number}","milestones_url":"https://api.github.com/repos/sphuber/aiida_core/milestones{/number}","notifications_url":"https://api.github.com/repos/sphuber/aiida_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphuber/aiida_core/labels{/name}","releases_url":"https://api.github.com/repos/sphuber/aiida_core/releases{/id}","deployments_url":"https://api.github.com/repos/sphuber/aiida_core/deployments","created_at":"2017-01-10T13:50:47Z","updated_at":"2018-08-15T07:54:59Z","pushed_at":"2018-11-14T18:07:31Z","git_url":"git://github.com/sphuber/aiida_core.git","ssh_url":"git@github.com:sphuber/aiida_core.git","clone_url":"https://github.com/sphuber/aiida_core.git","svn_url":"https://github.com/sphuber/aiida_core","homepage":null,"size":47603,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"aiidateam:provenance_redesign","ref":"provenance_redesign","sha":"0b38fd5221ec5654d4d8be911d00be6d21cfba5c","user":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"repo":{"id":77234579,"node_id":"MDEwOlJlcG9zaXRvcnk3NzIzNDU3OQ==","name":"aiida_core","full_name":"aiidateam/aiida_core","private":false,"owner":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aiidateam/aiida_core","description":"The official repository for the AiiDA code","fork":false,"url":"https://api.github.com/repos/aiidateam/aiida_core","forks_url":"https://api.github.com/repos/aiidateam/aiida_core/forks","keys_url":"https://api.github.com/repos/aiidateam/aiida_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiidateam/aiida_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiidateam/aiida_core/teams","hooks_url":"https://api.github.com/repos/aiidateam/aiida_core/hooks","issue_events_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/events{/number}","events_url":"https://api.github.com/repos/aiidateam/aiida_core/events","assignees_url":"https://api.github.com/repos/aiidateam/aiida_core/assignees{/user}","branches_url":"https://api.github.com/repos/aiidateam/aiida_core/branches{/branch}","tags_url":"https://api.github.com/repos/aiidateam/aiida_core/tags","blobs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiidateam/aiida_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiidateam/aiida_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiidateam/aiida_core/statuses/{sha}","languages_url":"https://api.github.com/repos/aiidateam/aiida_core/languages","stargazers_url":"https://api.github.com/repos/aiidateam/aiida_core/stargazers","contributors_url":"https://api.github.com/repos/aiidateam/aiida_core/contributors","subscribers_url":"https://api.github.com/repos/aiidateam/aiida_core/subscribers","subscription_url":"https://api.github.com/repos/aiidateam/aiida_core/subscription","commits_url":"https://api.github.com/repos/aiidateam/aiida_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiidateam/aiida_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiidateam/aiida_core/contents/{+path}","compare_url":"https://api.github.com/repos/aiidateam/aiida_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiidateam/aiida_core/merges","archive_url":"https://api.github.com/repos/aiidateam/aiida_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiidateam/aiida_core/downloads","issues_url":"https://api.github.com/repos/aiidateam/aiida_core/issues{/number}","pulls_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls{/number}","milestones_url":"https://api.github.com/repos/aiidateam/aiida_core/milestones{/number}","notifications_url":"https://api.github.com/repos/aiidateam/aiida_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/labels{/name}","releases_url":"https://api.github.com/repos/aiidateam/aiida_core/releases{/id}","deployments_url":"https://api.github.com/repos/aiidateam/aiida_core/deployments","created_at":"2016-12-23T15:38:21Z","updated_at":"2018-11-12T18:16:28Z","pushed_at":"2018-11-14T18:24:03Z","git_url":"git://github.com/aiidateam/aiida_core.git","ssh_url":"git@github.com:aiidateam/aiida_core.git","clone_url":"https://github.com/aiidateam/aiida_core.git","svn_url":"https://github.com/aiidateam/aiida_core","homepage":null,"size":47999,"stargazers_count":131,"watchers_count":131,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":61,"open_issues":250,"watchers":131,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201"},"html":{"href":"https://github.com/aiidateam/aiida_core/pull/2201"},"issue":{"href":"https://api.github.com/repos/aiidateam/aiida_core/issues/2201"},"comments":{"href":"https://api.github.com/repos/aiidateam/aiida_core/issues/2201/comments"},"review_comments":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201/comments"},"review_comment":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2201/commits"},"statuses":{"href":"https://api.github.com/repos/aiidateam/aiida_core/statuses/f67bcdfe091de63beea5ba37ed0235a0a0d62650"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giovannipizzi"}}