{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/177078112","pull_request_review_id":106887734,"id":177078112,"diff_hunk":"@@ -36,5 +36,9 @@\n     \"lint:spaces\": \"lintspaces -n -t -d spaces -l 1 -. \\\"src/**/*.jsp\\\" \\\"src/**/*.tag\\\" \\\"src/main/**/*.html\\\" \\\"src/**/*.xml\\\" \\\"src/**/*.json\\\" \\\"src/**/*.css\\\" \\\"src/**/*.java\\\" \\\"src/main/webapp/dev/**/*.js\\\" \\\"src/**/*.properties\\\" \\\"*.js\\\" \\\"*.yml\\\" \\\"*.gradle\\\" \\\"static-analysis/*.*ml\\\"\",\n     \"lint\": \"npm run lint:js && npm run lint:json && npm run lint:css && npm run lint:spaces\"\n   },\n-  \"private\": true\n+  \"private\": true,\n+  \"dependencies\": {\n+    \"lintspaces\": \"^0.6.0\",\n+    \"npm\": \"^5.8.0\"\n+  }","path":"package.json","position":null,"original_position":9,"commit_id":"1b89081620047589894c936bdf2aaeb182371edf","original_commit_id":"2636a50cff627ecf12b783587c9d94eb936d02fa","user":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"body":"1. You only need to run the `npm` static analysis when you modify javascript, i.e. `*.js` files, which is not the case here.\r\n2. You should update your npm globally i.e. with `-g` instead of `npm -i npm`\r\n3. You shouldn't need to install `lintspaces` again, since it is listed as a development dependency. Did you run `npm install` during [setting up the environment](https://github.com/TEAMMATES/teammates/blob/master/docs/setting-up.md)?","created_at":"2018-03-26T12:53:59Z","updated_at":"2018-03-26T12:53:59Z","html_url":"https://github.com/TEAMMATES/teammates/pull/8706#discussion_r177078112","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/177078112"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8706#discussion_r177078112"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706"}},"in_reply_to_id":176977927},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706","id":177261597,"html_url":"https://github.com/TEAMMATES/teammates/pull/8706","diff_url":"https://github.com/TEAMMATES/teammates/pull/8706.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8706.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8706","number":8706,"state":"open","locked":false,"title":"AdminActivityLogPage: incorrect log message for change of course time zone #8695","user":{"login":"mg14777","id":11634699,"avatar_url":"https://avatars0.githubusercontent.com/u/11634699?v=4","gravatar_id":"","url":"https://api.github.com/users/mg14777","html_url":"https://github.com/mg14777","followers_url":"https://api.github.com/users/mg14777/followers","following_url":"https://api.github.com/users/mg14777/following{/other_user}","gists_url":"https://api.github.com/users/mg14777/gists{/gist_id}","starred_url":"https://api.github.com/users/mg14777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg14777/subscriptions","organizations_url":"https://api.github.com/users/mg14777/orgs","repos_url":"https://api.github.com/users/mg14777/repos","events_url":"https://api.github.com/users/mg14777/events{/privacy}","received_events_url":"https://api.github.com/users/mg14777/received_events","type":"User","site_admin":false},"body":"Fixes #8695 \r\n\r\n**Outline of Solution**\r\n\r\n<!-- Tell us how you solved the issue. -->\r\n<!-- If there are things you want the reviewers to focus on, include them here as well. -->\r\n<!-- This portion can be skipped if the fix is trivial. -->\r\n\r\n- Corrected AdminActivityLogPage to display the correct edited information when course details are edited\r\n\r\n- If only the course name is edited the following is displayed:\r\n![course_name_edited](https://user-images.githubusercontent.com/11634699/37869458-c81a6e18-2faf-11e8-9183-cf033128d365.PNG)\r\n\r\n- If only the time zone is edited the following is displayed:\r\n![time_zone_edit](https://user-images.githubusercontent.com/11634699/37869474-17f89342-2fb0-11e8-855b-b625838b12bc.PNG)\r\n\r\n- If both course name and time zone are edited the following is displayed:\r\n![both_edited](https://user-images.githubusercontent.com/11634699/37869489-4f1e04ba-2fb0-11e8-8606-3135bbe019d9.PNG)\r\n\r\n- If nothing is touched the following is displayed:\r\n![nothin_edited](https://user-images.githubusercontent.com/11634699/37869501-742004ac-2fb0-11e8-8ba7-0b6e5527d360.PNG)\r\n\r\n\r\n\r\n\r\n","created_at":"2018-03-24T22:14:03Z","updated_at":"2018-03-26T12:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96ba59129ba395a9290c4465034bcd85c1238251","assignee":{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false},"assignees":[{"login":"tran-tien-dat","id":8559368,"avatar_url":"https://avatars3.githubusercontent.com/u/8559368?v=4","gravatar_id":"","url":"https://api.github.com/users/tran-tien-dat","html_url":"https://github.com/tran-tien-dat","followers_url":"https://api.github.com/users/tran-tien-dat/followers","following_url":"https://api.github.com/users/tran-tien-dat/following{/other_user}","gists_url":"https://api.github.com/users/tran-tien-dat/gists{/gist_id}","starred_url":"https://api.github.com/users/tran-tien-dat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tran-tien-dat/subscriptions","organizations_url":"https://api.github.com/users/tran-tien-dat/orgs","repos_url":"https://api.github.com/users/tran-tien-dat/repos","events_url":"https://api.github.com/users/tran-tien-dat/events{/privacy}","received_events_url":"https://api.github.com/users/tran-tien-dat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98049507,"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.Ongoing","name":"s.Ongoing","color":"6BC471","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8706/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/1b89081620047589894c936bdf2aaeb182371edf","head":{"label":"mg14777:8695-incorrect-log-message-admin","ref":"8695-incorrect-log-message-admin","sha":"1b89081620047589894c936bdf2aaeb182371edf","user":{"login":"mg14777","id":11634699,"avatar_url":"https://avatars0.githubusercontent.com/u/11634699?v=4","gravatar_id":"","url":"https://api.github.com/users/mg14777","html_url":"https://github.com/mg14777","followers_url":"https://api.github.com/users/mg14777/followers","following_url":"https://api.github.com/users/mg14777/following{/other_user}","gists_url":"https://api.github.com/users/mg14777/gists{/gist_id}","starred_url":"https://api.github.com/users/mg14777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg14777/subscriptions","organizations_url":"https://api.github.com/users/mg14777/orgs","repos_url":"https://api.github.com/users/mg14777/repos","events_url":"https://api.github.com/users/mg14777/events{/privacy}","received_events_url":"https://api.github.com/users/mg14777/received_events","type":"User","site_admin":false},"repo":{"id":125040663,"name":"teammates","full_name":"mg14777/teammates","owner":{"login":"mg14777","id":11634699,"avatar_url":"https://avatars0.githubusercontent.com/u/11634699?v=4","gravatar_id":"","url":"https://api.github.com/users/mg14777","html_url":"https://github.com/mg14777","followers_url":"https://api.github.com/users/mg14777/followers","following_url":"https://api.github.com/users/mg14777/following{/other_user}","gists_url":"https://api.github.com/users/mg14777/gists{/gist_id}","starred_url":"https://api.github.com/users/mg14777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg14777/subscriptions","organizations_url":"https://api.github.com/users/mg14777/orgs","repos_url":"https://api.github.com/users/mg14777/repos","events_url":"https://api.github.com/users/mg14777/events{/privacy}","received_events_url":"https://api.github.com/users/mg14777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mg14777/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/mg14777/teammates","forks_url":"https://api.github.com/repos/mg14777/teammates/forks","keys_url":"https://api.github.com/repos/mg14777/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mg14777/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mg14777/teammates/teams","hooks_url":"https://api.github.com/repos/mg14777/teammates/hooks","issue_events_url":"https://api.github.com/repos/mg14777/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/mg14777/teammates/events","assignees_url":"https://api.github.com/repos/mg14777/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/mg14777/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/mg14777/teammates/tags","blobs_url":"https://api.github.com/repos/mg14777/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mg14777/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mg14777/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/mg14777/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mg14777/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/mg14777/teammates/languages","stargazers_url":"https://api.github.com/repos/mg14777/teammates/stargazers","contributors_url":"https://api.github.com/repos/mg14777/teammates/contributors","subscribers_url":"https://api.github.com/repos/mg14777/teammates/subscribers","subscription_url":"https://api.github.com/repos/mg14777/teammates/subscription","commits_url":"https://api.github.com/repos/mg14777/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/mg14777/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/mg14777/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/mg14777/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/mg14777/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/mg14777/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mg14777/teammates/merges","archive_url":"https://api.github.com/repos/mg14777/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mg14777/teammates/downloads","issues_url":"https://api.github.com/repos/mg14777/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/mg14777/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/mg14777/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/mg14777/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mg14777/teammates/labels{/name}","releases_url":"https://api.github.com/repos/mg14777/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/mg14777/teammates/deployments","created_at":"2018-03-13T11:26:55Z","updated_at":"2018-03-13T11:27:03Z","pushed_at":"2018-03-26T08:08:45Z","git_url":"git://github.com/mg14777/teammates.git","ssh_url":"git@github.com:mg14777/teammates.git","clone_url":"https://github.com/mg14777/teammates.git","svn_url":"https://github.com/mg14777/teammates","homepage":"https://teammatesv4.appspot.com/","size":195429,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"cd9a5365cfed580bae5d1bf15f2994a921e31f03","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2018-03-26T09:22:36Z","pushed_at":"2018-03-26T12:29:37Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":196822,"stargazers_count":576,"watchers_count":576,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1342,"mirror_url":null,"archived":false,"open_issues_count":305,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1342,"open_issues":305,"watchers":576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8706"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8706"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8706/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8706/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/1b89081620047589894c936bdf2aaeb182371edf"}},"author_association":"NONE"}}
{"actor":{"display_login":"tran-tien-dat"}}