{"action":"created","comment":{"url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/comments/199658024","pull_request_review_id":133819654,"id":199658024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY1ODAyNA==","diff_hunk":"@@ -682,7 +682,25 @@ void SearchWorker::ExtendNode(Node* node) {\n       return;\n     }\n   }\n-\n+  \n+  //WDL probing\n+  if(board.our + board.their <= SyzygyTablebase::max_cardinality && board.GetNoCapturePly == 0","path":"src/mcts/search.cc","position":7,"original_position":7,"commit_id":"aff743b741969139b4b0500af100a4cddcb57c70","original_commit_id":"aff743b741969139b4b0500af100a4cddcb57c70","user":{"login":"DanielUranga","id":1651950,"node_id":"MDQ6VXNlcjE2NTE5NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1651950?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielUranga","html_url":"https://github.com/DanielUranga","followers_url":"https://api.github.com/users/DanielUranga/followers","following_url":"https://api.github.com/users/DanielUranga/following{/other_user}","gists_url":"https://api.github.com/users/DanielUranga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielUranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielUranga/subscriptions","organizations_url":"https://api.github.com/users/DanielUranga/orgs","repos_url":"https://api.github.com/users/DanielUranga/repos","events_url":"https://api.github.com/users/DanielUranga/events{/privacy}","received_events_url":"https://api.github.com/users/DanielUranga/received_events","type":"User","site_admin":false},"body":"I see, but look at where those variables come from:\r\n```\r\n#ifdef _MSC_VER\r\n  int our = _mm_popcnt_u64(our_pieces_.as_int());\r\n  int their = _mm_popcnt_u64(their_pieces_.as_int());\r\n#else\r\n  int our = __builtin_popcountll(our_pieces_.as_int());\r\n  int their = __builtin_popcountll(their_pieces_.as_int());\r\n#endif\r\n```\r\nI think it would be good to refactor that code: move it to the Bitboard class, inside a `popcount` method.\r\nThat code would look like:\r\n```\r\nint our = our_pieces_.popcount();\r\nint their = their_pieces_.popcount();\r\n```\r\nAnd the code here would be:\r\n```\r\nint our = board.ours().popcount();\r\nint their = board.theirs().popcount();\r\n```","created_at":"2018-07-03T00:48:52Z","updated_at":"2018-07-03T00:48:52Z","html_url":"https://github.com/LeelaChessZero/lc0/pull/131#discussion_r199658024","pull_request_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/comments/199658024"},"html":{"href":"https://github.com/LeelaChessZero/lc0/pull/131#discussion_r199658024"},"pull_request":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131"}},"in_reply_to_id":199625249},"pull_request":{"url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131","id":198769304,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzY5MzA0","html_url":"https://github.com/LeelaChessZero/lc0/pull/131","diff_url":"https://github.com/LeelaChessZero/lc0/pull/131.diff","patch_url":"https://github.com/LeelaChessZero/lc0/pull/131.patch","issue_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/131","number":131,"state":"open","locked":false,"title":"WIP use wdl in search","user":{"login":"Epanek","id":37742991,"node_id":"MDQ6VXNlcjM3NzQyOTkx","avatar_url":"https://avatars0.githubusercontent.com/u/37742991?v=4","gravatar_id":"","url":"https://api.github.com/users/Epanek","html_url":"https://github.com/Epanek","followers_url":"https://api.github.com/users/Epanek/followers","following_url":"https://api.github.com/users/Epanek/following{/other_user}","gists_url":"https://api.github.com/users/Epanek/gists{/gist_id}","starred_url":"https://api.github.com/users/Epanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Epanek/subscriptions","organizations_url":"https://api.github.com/users/Epanek/orgs","repos_url":"https://api.github.com/users/Epanek/repos","events_url":"https://api.github.com/users/Epanek/events{/privacy}","received_events_url":"https://api.github.com/users/Epanek/received_events","type":"User","site_admin":false},"body":"right idea i think","created_at":"2018-07-02T19:30:53Z","updated_at":"2018-07-03T00:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17a767ccd1371b9c195a9394442019968206546d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131/commits","review_comments_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131/comments","review_comment_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/131/comments","statuses_url":"https://api.github.com/repos/LeelaChessZero/lc0/statuses/aff743b741969139b4b0500af100a4cddcb57c70","head":{"label":"LeelaChessZero:tb-wdl","ref":"tb-wdl","sha":"aff743b741969139b4b0500af100a4cddcb57c70","user":{"login":"LeelaChessZero","id":39777295,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc3Mjk1","avatar_url":"https://avatars1.githubusercontent.com/u/39777295?v=4","gravatar_id":"","url":"https://api.github.com/users/LeelaChessZero","html_url":"https://github.com/LeelaChessZero","followers_url":"https://api.github.com/users/LeelaChessZero/followers","following_url":"https://api.github.com/users/LeelaChessZero/following{/other_user}","gists_url":"https://api.github.com/users/LeelaChessZero/gists{/gist_id}","starred_url":"https://api.github.com/users/LeelaChessZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeelaChessZero/subscriptions","organizations_url":"https://api.github.com/users/LeelaChessZero/orgs","repos_url":"https://api.github.com/users/LeelaChessZero/repos","events_url":"https://api.github.com/users/LeelaChessZero/events{/privacy}","received_events_url":"https://api.github.com/users/LeelaChessZero/received_events","type":"Organization","site_admin":false},"repo":{"id":135489692,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0ODk2OTI=","name":"lc0","full_name":"LeelaChessZero/lc0","owner":{"login":"LeelaChessZero","id":39777295,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc3Mjk1","avatar_url":"https://avatars1.githubusercontent.com/u/39777295?v=4","gravatar_id":"","url":"https://api.github.com/users/LeelaChessZero","html_url":"https://github.com/LeelaChessZero","followers_url":"https://api.github.com/users/LeelaChessZero/followers","following_url":"https://api.github.com/users/LeelaChessZero/following{/other_user}","gists_url":"https://api.github.com/users/LeelaChessZero/gists{/gist_id}","starred_url":"https://api.github.com/users/LeelaChessZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeelaChessZero/subscriptions","organizations_url":"https://api.github.com/users/LeelaChessZero/orgs","repos_url":"https://api.github.com/users/LeelaChessZero/repos","events_url":"https://api.github.com/users/LeelaChessZero/events{/privacy}","received_events_url":"https://api.github.com/users/LeelaChessZero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeelaChessZero/lc0","description":"The rewritten engine, originally for tensorflow. Now all other backends have been ported here.","fork":false,"url":"https://api.github.com/repos/LeelaChessZero/lc0","forks_url":"https://api.github.com/repos/LeelaChessZero/lc0/forks","keys_url":"https://api.github.com/repos/LeelaChessZero/lc0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeelaChessZero/lc0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeelaChessZero/lc0/teams","hooks_url":"https://api.github.com/repos/LeelaChessZero/lc0/hooks","issue_events_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/events{/number}","events_url":"https://api.github.com/repos/LeelaChessZero/lc0/events","assignees_url":"https://api.github.com/repos/LeelaChessZero/lc0/assignees{/user}","branches_url":"https://api.github.com/repos/LeelaChessZero/lc0/branches{/branch}","tags_url":"https://api.github.com/repos/LeelaChessZero/lc0/tags","blobs_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeelaChessZero/lc0/statuses/{sha}","languages_url":"https://api.github.com/repos/LeelaChessZero/lc0/languages","stargazers_url":"https://api.github.com/repos/LeelaChessZero/lc0/stargazers","contributors_url":"https://api.github.com/repos/LeelaChessZero/lc0/contributors","subscribers_url":"https://api.github.com/repos/LeelaChessZero/lc0/subscribers","subscription_url":"https://api.github.com/repos/LeelaChessZero/lc0/subscription","commits_url":"https://api.github.com/repos/LeelaChessZero/lc0/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeelaChessZero/lc0/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeelaChessZero/lc0/contents/{+path}","compare_url":"https://api.github.com/repos/LeelaChessZero/lc0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeelaChessZero/lc0/merges","archive_url":"https://api.github.com/repos/LeelaChessZero/lc0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeelaChessZero/lc0/downloads","issues_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues{/number}","pulls_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls{/number}","milestones_url":"https://api.github.com/repos/LeelaChessZero/lc0/milestones{/number}","notifications_url":"https://api.github.com/repos/LeelaChessZero/lc0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeelaChessZero/lc0/labels{/name}","releases_url":"https://api.github.com/repos/LeelaChessZero/lc0/releases{/id}","deployments_url":"https://api.github.com/repos/LeelaChessZero/lc0/deployments","created_at":"2018-05-30T19:41:42Z","updated_at":"2018-07-02T18:27:41Z","pushed_at":"2018-07-02T21:32:51Z","git_url":"git://github.com/LeelaChessZero/lc0.git","ssh_url":"git@github.com:LeelaChessZero/lc0.git","clone_url":"https://github.com/LeelaChessZero/lc0.git","svn_url":"https://github.com/LeelaChessZero/lc0","homepage":"","size":34846,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":50,"watchers":24,"default_branch":"master"}},"base":{"label":"LeelaChessZero:master","ref":"master","sha":"d64854d00edc1c90e16b0d2d1918c2647c350748","user":{"login":"LeelaChessZero","id":39777295,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc3Mjk1","avatar_url":"https://avatars1.githubusercontent.com/u/39777295?v=4","gravatar_id":"","url":"https://api.github.com/users/LeelaChessZero","html_url":"https://github.com/LeelaChessZero","followers_url":"https://api.github.com/users/LeelaChessZero/followers","following_url":"https://api.github.com/users/LeelaChessZero/following{/other_user}","gists_url":"https://api.github.com/users/LeelaChessZero/gists{/gist_id}","starred_url":"https://api.github.com/users/LeelaChessZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeelaChessZero/subscriptions","organizations_url":"https://api.github.com/users/LeelaChessZero/orgs","repos_url":"https://api.github.com/users/LeelaChessZero/repos","events_url":"https://api.github.com/users/LeelaChessZero/events{/privacy}","received_events_url":"https://api.github.com/users/LeelaChessZero/received_events","type":"Organization","site_admin":false},"repo":{"id":135489692,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0ODk2OTI=","name":"lc0","full_name":"LeelaChessZero/lc0","owner":{"login":"LeelaChessZero","id":39777295,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc3Mjk1","avatar_url":"https://avatars1.githubusercontent.com/u/39777295?v=4","gravatar_id":"","url":"https://api.github.com/users/LeelaChessZero","html_url":"https://github.com/LeelaChessZero","followers_url":"https://api.github.com/users/LeelaChessZero/followers","following_url":"https://api.github.com/users/LeelaChessZero/following{/other_user}","gists_url":"https://api.github.com/users/LeelaChessZero/gists{/gist_id}","starred_url":"https://api.github.com/users/LeelaChessZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeelaChessZero/subscriptions","organizations_url":"https://api.github.com/users/LeelaChessZero/orgs","repos_url":"https://api.github.com/users/LeelaChessZero/repos","events_url":"https://api.github.com/users/LeelaChessZero/events{/privacy}","received_events_url":"https://api.github.com/users/LeelaChessZero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeelaChessZero/lc0","description":"The rewritten engine, originally for tensorflow. Now all other backends have been ported here.","fork":false,"url":"https://api.github.com/repos/LeelaChessZero/lc0","forks_url":"https://api.github.com/repos/LeelaChessZero/lc0/forks","keys_url":"https://api.github.com/repos/LeelaChessZero/lc0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeelaChessZero/lc0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeelaChessZero/lc0/teams","hooks_url":"https://api.github.com/repos/LeelaChessZero/lc0/hooks","issue_events_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/events{/number}","events_url":"https://api.github.com/repos/LeelaChessZero/lc0/events","assignees_url":"https://api.github.com/repos/LeelaChessZero/lc0/assignees{/user}","branches_url":"https://api.github.com/repos/LeelaChessZero/lc0/branches{/branch}","tags_url":"https://api.github.com/repos/LeelaChessZero/lc0/tags","blobs_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeelaChessZero/lc0/statuses/{sha}","languages_url":"https://api.github.com/repos/LeelaChessZero/lc0/languages","stargazers_url":"https://api.github.com/repos/LeelaChessZero/lc0/stargazers","contributors_url":"https://api.github.com/repos/LeelaChessZero/lc0/contributors","subscribers_url":"https://api.github.com/repos/LeelaChessZero/lc0/subscribers","subscription_url":"https://api.github.com/repos/LeelaChessZero/lc0/subscription","commits_url":"https://api.github.com/repos/LeelaChessZero/lc0/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeelaChessZero/lc0/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeelaChessZero/lc0/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeelaChessZero/lc0/contents/{+path}","compare_url":"https://api.github.com/repos/LeelaChessZero/lc0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeelaChessZero/lc0/merges","archive_url":"https://api.github.com/repos/LeelaChessZero/lc0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeelaChessZero/lc0/downloads","issues_url":"https://api.github.com/repos/LeelaChessZero/lc0/issues{/number}","pulls_url":"https://api.github.com/repos/LeelaChessZero/lc0/pulls{/number}","milestones_url":"https://api.github.com/repos/LeelaChessZero/lc0/milestones{/number}","notifications_url":"https://api.github.com/repos/LeelaChessZero/lc0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeelaChessZero/lc0/labels{/name}","releases_url":"https://api.github.com/repos/LeelaChessZero/lc0/releases{/id}","deployments_url":"https://api.github.com/repos/LeelaChessZero/lc0/deployments","created_at":"2018-05-30T19:41:42Z","updated_at":"2018-07-02T18:27:41Z","pushed_at":"2018-07-02T21:32:51Z","git_url":"git://github.com/LeelaChessZero/lc0.git","ssh_url":"git@github.com:LeelaChessZero/lc0.git","clone_url":"https://github.com/LeelaChessZero/lc0.git","svn_url":"https://github.com/LeelaChessZero/lc0","homepage":"","size":34846,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":50,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131"},"html":{"href":"https://github.com/LeelaChessZero/lc0/pull/131"},"issue":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/issues/131"},"comments":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/LeelaChessZero/lc0/statuses/aff743b741969139b4b0500af100a4cddcb57c70"}},"author_association":"NONE"}}
{"actor":{"display_login":"DanielUranga"}}