{"action":"opened","number":1721,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1721","id":200494502,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDk0NTAy","html_url":"https://github.com/puppetlabs/facter/pull/1721","diff_url":"https://github.com/puppetlabs/facter/pull/1721.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1721.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1721","number":1721,"state":"open","locked":false,"title":"(FACT-1865) Determine OS release on Amazon Linux 2","user":{"login":"caseywilliams","id":1278223,"node_id":"MDQ6VXNlcjEyNzgyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1278223?v=4","gravatar_id":"","url":"https://api.github.com/users/caseywilliams","html_url":"https://github.com/caseywilliams","followers_url":"https://api.github.com/users/caseywilliams/followers","following_url":"https://api.github.com/users/caseywilliams/following{/other_user}","gists_url":"https://api.github.com/users/caseywilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywilliams/subscriptions","organizations_url":"https://api.github.com/users/caseywilliams/orgs","repos_url":"https://api.github.com/users/caseywilliams/repos","events_url":"https://api.github.com/users/caseywilliams/events{/privacy}","received_events_url":"https://api.github.com/users/caseywilliams/received_events","type":"User","site_admin":false},"body":"The format of /etc/system-release changed in Amazon Linux 2; This adds a\r\nspecial case to check for the new format before allowing the os release\r\nvalue to fall back to the kernel version.\r\n\r\nI've built this on an Amazon Linux 2 container and gotten the following:\r\n```\r\nbash-4.2# ./bin/facter os\r\n{\r\n  architecture => \"x86_64\",\r\n  family => \"RedHat\",\r\n  hardware => \"x86_64\",\r\n  name => \"Amazon\",\r\n  release => {\r\n    full => \"2\",\r\n    major => \"2\"\r\n  },\r\n  selinux => {\r\n    enabled => false\r\n  }\r\n}\r\n```\r\n\r\nThe 2018.03 image still reports its previous values, too:\r\n```\r\nbash-4.2# ./bin/facter os\r\n{\r\n  architecture => \"x86_64\",\r\n  family => \"RedHat\",\r\n  hardware => \"x86_64\",\r\n  name => \"Amazon\",\r\n  release => {\r\n    full => \"2018.03\",\r\n    major => \"2018\",\r\n    minor => \"03\"\r\n  },\r\n  selinux => {\r\n    enabled => false\r\n  }\r\n}\r\n```\r\n\r\nI'll install and test the built agent packages on some actual ec2 instances once PR tests finish.","created_at":"2018-07-10T19:05:12Z","updated_at":"2018-07-10T19:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1721/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1721/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1721/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/45ad56e8555e8c12de5001920711f5a153808b01","head":{"label":"caseywilliams:FACT-1865/amazon2","ref":"FACT-1865/amazon2","sha":"45ad56e8555e8c12de5001920711f5a153808b01","user":{"login":"caseywilliams","id":1278223,"node_id":"MDQ6VXNlcjEyNzgyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1278223?v=4","gravatar_id":"","url":"https://api.github.com/users/caseywilliams","html_url":"https://github.com/caseywilliams","followers_url":"https://api.github.com/users/caseywilliams/followers","following_url":"https://api.github.com/users/caseywilliams/following{/other_user}","gists_url":"https://api.github.com/users/caseywilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywilliams/subscriptions","organizations_url":"https://api.github.com/users/caseywilliams/orgs","repos_url":"https://api.github.com/users/caseywilliams/repos","events_url":"https://api.github.com/users/caseywilliams/events{/privacy}","received_events_url":"https://api.github.com/users/caseywilliams/received_events","type":"User","site_admin":false},"repo":{"id":101803847,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDM4NDc=","name":"facter","full_name":"caseywilliams/facter","owner":{"login":"caseywilliams","id":1278223,"node_id":"MDQ6VXNlcjEyNzgyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1278223?v=4","gravatar_id":"","url":"https://api.github.com/users/caseywilliams","html_url":"https://github.com/caseywilliams","followers_url":"https://api.github.com/users/caseywilliams/followers","following_url":"https://api.github.com/users/caseywilliams/following{/other_user}","gists_url":"https://api.github.com/users/caseywilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywilliams/subscriptions","organizations_url":"https://api.github.com/users/caseywilliams/orgs","repos_url":"https://api.github.com/users/caseywilliams/repos","events_url":"https://api.github.com/users/caseywilliams/events{/privacy}","received_events_url":"https://api.github.com/users/caseywilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseywilliams/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/caseywilliams/facter","forks_url":"https://api.github.com/repos/caseywilliams/facter/forks","keys_url":"https://api.github.com/repos/caseywilliams/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseywilliams/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseywilliams/facter/teams","hooks_url":"https://api.github.com/repos/caseywilliams/facter/hooks","issue_events_url":"https://api.github.com/repos/caseywilliams/facter/issues/events{/number}","events_url":"https://api.github.com/repos/caseywilliams/facter/events","assignees_url":"https://api.github.com/repos/caseywilliams/facter/assignees{/user}","branches_url":"https://api.github.com/repos/caseywilliams/facter/branches{/branch}","tags_url":"https://api.github.com/repos/caseywilliams/facter/tags","blobs_url":"https://api.github.com/repos/caseywilliams/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseywilliams/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseywilliams/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseywilliams/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseywilliams/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/caseywilliams/facter/languages","stargazers_url":"https://api.github.com/repos/caseywilliams/facter/stargazers","contributors_url":"https://api.github.com/repos/caseywilliams/facter/contributors","subscribers_url":"https://api.github.com/repos/caseywilliams/facter/subscribers","subscription_url":"https://api.github.com/repos/caseywilliams/facter/subscription","commits_url":"https://api.github.com/repos/caseywilliams/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseywilliams/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseywilliams/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseywilliams/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseywilliams/facter/contents/{+path}","compare_url":"https://api.github.com/repos/caseywilliams/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseywilliams/facter/merges","archive_url":"https://api.github.com/repos/caseywilliams/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseywilliams/facter/downloads","issues_url":"https://api.github.com/repos/caseywilliams/facter/issues{/number}","pulls_url":"https://api.github.com/repos/caseywilliams/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/caseywilliams/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/caseywilliams/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseywilliams/facter/labels{/name}","releases_url":"https://api.github.com/repos/caseywilliams/facter/releases{/id}","deployments_url":"https://api.github.com/repos/caseywilliams/facter/deployments","created_at":"2017-08-29T20:26:31Z","updated_at":"2017-08-29T20:26:34Z","pushed_at":"2018-07-10T19:02:57Z","git_url":"git://github.com/caseywilliams/facter.git","ssh_url":"git@github.com:caseywilliams/facter.git","clone_url":"https://github.com/caseywilliams/facter.git","svn_url":"https://github.com/caseywilliams/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13912,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:3.11.x","ref":"3.11.x","sha":"00ec7a9daa444de4ff0f65aa5552a64d7b1c602b","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NTc=","name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2018-07-08T04:25:53Z","pushed_at":"2018-07-10T18:53:13Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13930,"stargazers_count":509,"watchers_count":509,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":432,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":432,"open_issues":10,"watchers":509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1721"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1721"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1721"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1721/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1721/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1721/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/45ad56e8555e8c12de5001920711f5a153808b01"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"caseywilliams"}}