{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/comments/205411766","pull_request_review_id":140673750,"id":205411766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQxMTc2Ng==","diff_hunk":"@@ -226,14 +226,14 @@ <h2>The <dfn>WoT</dfn> object</h2>\n       // [SecureContext]\n       // [NamespaceObject]\n       interface WoT {\n-        Observable&lt;ThingDescription&gt; discover(optional ThingFilter filter);\n+        Observable discover(optional ThingFilter filter);\n         Promise&lt;ThingDescription&gt; fetch(USVString url);\n         ConsumedThing consume(ThingDescription td);\n         ExposedThing produce(ThingModel model);\n         Promise&lt;void&gt; register(USVString directory, ExposedThing thing);\n         Promise&lt;void&gt; unregister(USVString directory, ExposedThing thing);\n       };\n-      typedef dictionary ThingTemplate;\n+      typedef object ThingTemplate;","path":"index.html","position":13,"original_position":13,"commit_id":"d47801a218df87741b10b18660d89fb3c652b8c0","original_commit_id":"d47801a218df87741b10b18660d89fb3c652b8c0","user":{"login":"zolkis","id":996058,"node_id":"MDQ6VXNlcjk5NjA1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/996058?v=4","gravatar_id":"","url":"https://api.github.com/users/zolkis","html_url":"https://github.com/zolkis","followers_url":"https://api.github.com/users/zolkis/followers","following_url":"https://api.github.com/users/zolkis/following{/other_user}","gists_url":"https://api.github.com/users/zolkis/gists{/gist_id}","starred_url":"https://api.github.com/users/zolkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolkis/subscriptions","organizations_url":"https://api.github.com/users/zolkis/orgs","repos_url":"https://api.github.com/users/zolkis/repos","events_url":"https://api.github.com/users/zolkis/events{/privacy}","received_events_url":"https://api.github.com/users/zolkis/received_events","type":"User","site_admin":false},"body":"I wasn't able to figure out the single line typedefs either. \r\nThingModel could be a ConsumedThing object, i.e. you consume a thing for some reason and reuse the object (rather than fetching again the TD) to create an ExposedThing based on that. ","created_at":"2018-07-26T10:47:36Z","updated_at":"2018-07-26T10:47:36Z","html_url":"https://github.com/w3c/wot-scripting-api/pull/128#discussion_r205411766","pull_request_url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/comments/205411766"},"html":{"href":"https://github.com/w3c/wot-scripting-api/pull/128#discussion_r205411766"},"pull_request":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128"}},"in_reply_to_id":205372599},"pull_request":{"url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128","id":198621883,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjIxODgz","html_url":"https://github.com/w3c/wot-scripting-api/pull/128","diff_url":"https://github.com/w3c/wot-scripting-api/pull/128.diff","patch_url":"https://github.com/w3c/wot-scripting-api/pull/128.patch","issue_url":"https://api.github.com/repos/w3c/wot-scripting-api/issues/128","number":128,"state":"open","locked":false,"title":"WiP: Korea F2F changes","user":{"login":"zolkis","id":996058,"node_id":"MDQ6VXNlcjk5NjA1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/996058?v=4","gravatar_id":"","url":"https://api.github.com/users/zolkis","html_url":"https://github.com/zolkis","followers_url":"https://api.github.com/users/zolkis/followers","following_url":"https://api.github.com/users/zolkis/following{/other_user}","gists_url":"https://api.github.com/users/zolkis/gists{/gist_id}","starred_url":"https://api.github.com/users/zolkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolkis/subscriptions","organizations_url":"https://api.github.com/users/zolkis/orgs","repos_url":"https://api.github.com/users/zolkis/repos","events_url":"https://api.github.com/users/zolkis/events{/privacy}","received_events_url":"https://api.github.com/users/zolkis/received_events","type":"User","site_admin":false},"body":"Fix #127: align names from get/set/run to read/write/invoke\r\n\r\nSigned-off-by: Zoltan Kis <zoltan.kis@intel.com>","created_at":"2018-07-02T09:32:36Z","updated_at":"2018-07-26T10:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"136d786daccdeef3017a37efc62538cdc43e8b21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128/commits","review_comments_url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128/comments","review_comment_url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/wot-scripting-api/issues/128/comments","statuses_url":"https://api.github.com/repos/w3c/wot-scripting-api/statuses/d47801a218df87741b10b18660d89fb3c652b8c0","head":{"label":"zolkis:master","ref":"master","sha":"d47801a218df87741b10b18660d89fb3c652b8c0","user":{"login":"zolkis","id":996058,"node_id":"MDQ6VXNlcjk5NjA1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/996058?v=4","gravatar_id":"","url":"https://api.github.com/users/zolkis","html_url":"https://github.com/zolkis","followers_url":"https://api.github.com/users/zolkis/followers","following_url":"https://api.github.com/users/zolkis/following{/other_user}","gists_url":"https://api.github.com/users/zolkis/gists{/gist_id}","starred_url":"https://api.github.com/users/zolkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolkis/subscriptions","organizations_url":"https://api.github.com/users/zolkis/orgs","repos_url":"https://api.github.com/users/zolkis/repos","events_url":"https://api.github.com/users/zolkis/events{/privacy}","received_events_url":"https://api.github.com/users/zolkis/received_events","type":"User","site_admin":false},"repo":{"id":82074734,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA3NDczNA==","name":"wot-scripting-api","full_name":"zolkis/wot-scripting-api","owner":{"login":"zolkis","id":996058,"node_id":"MDQ6VXNlcjk5NjA1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/996058?v=4","gravatar_id":"","url":"https://api.github.com/users/zolkis","html_url":"https://github.com/zolkis","followers_url":"https://api.github.com/users/zolkis/followers","following_url":"https://api.github.com/users/zolkis/following{/other_user}","gists_url":"https://api.github.com/users/zolkis/gists{/gist_id}","starred_url":"https://api.github.com/users/zolkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolkis/subscriptions","organizations_url":"https://api.github.com/users/zolkis/orgs","repos_url":"https://api.github.com/users/zolkis/repos","events_url":"https://api.github.com/users/zolkis/events{/privacy}","received_events_url":"https://api.github.com/users/zolkis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zolkis/wot-scripting-api","description":null,"fork":true,"url":"https://api.github.com/repos/zolkis/wot-scripting-api","forks_url":"https://api.github.com/repos/zolkis/wot-scripting-api/forks","keys_url":"https://api.github.com/repos/zolkis/wot-scripting-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zolkis/wot-scripting-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zolkis/wot-scripting-api/teams","hooks_url":"https://api.github.com/repos/zolkis/wot-scripting-api/hooks","issue_events_url":"https://api.github.com/repos/zolkis/wot-scripting-api/issues/events{/number}","events_url":"https://api.github.com/repos/zolkis/wot-scripting-api/events","assignees_url":"https://api.github.com/repos/zolkis/wot-scripting-api/assignees{/user}","branches_url":"https://api.github.com/repos/zolkis/wot-scripting-api/branches{/branch}","tags_url":"https://api.github.com/repos/zolkis/wot-scripting-api/tags","blobs_url":"https://api.github.com/repos/zolkis/wot-scripting-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zolkis/wot-scripting-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zolkis/wot-scripting-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/zolkis/wot-scripting-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zolkis/wot-scripting-api/statuses/{sha}","languages_url":"https://api.github.com/repos/zolkis/wot-scripting-api/languages","stargazers_url":"https://api.github.com/repos/zolkis/wot-scripting-api/stargazers","contributors_url":"https://api.github.com/repos/zolkis/wot-scripting-api/contributors","subscribers_url":"https://api.github.com/repos/zolkis/wot-scripting-api/subscribers","subscription_url":"https://api.github.com/repos/zolkis/wot-scripting-api/subscription","commits_url":"https://api.github.com/repos/zolkis/wot-scripting-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/zolkis/wot-scripting-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/zolkis/wot-scripting-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/zolkis/wot-scripting-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/zolkis/wot-scripting-api/contents/{+path}","compare_url":"https://api.github.com/repos/zolkis/wot-scripting-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zolkis/wot-scripting-api/merges","archive_url":"https://api.github.com/repos/zolkis/wot-scripting-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zolkis/wot-scripting-api/downloads","issues_url":"https://api.github.com/repos/zolkis/wot-scripting-api/issues{/number}","pulls_url":"https://api.github.com/repos/zolkis/wot-scripting-api/pulls{/number}","milestones_url":"https://api.github.com/repos/zolkis/wot-scripting-api/milestones{/number}","notifications_url":"https://api.github.com/repos/zolkis/wot-scripting-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zolkis/wot-scripting-api/labels{/name}","releases_url":"https://api.github.com/repos/zolkis/wot-scripting-api/releases{/id}","deployments_url":"https://api.github.com/repos/zolkis/wot-scripting-api/deployments","created_at":"2017-02-15T15:22:44Z","updated_at":"2018-07-23T12:29:14Z","pushed_at":"2018-07-23T12:29:12Z","git_url":"git://github.com/zolkis/wot-scripting-api.git","ssh_url":"git@github.com:zolkis/wot-scripting-api.git","clone_url":"https://github.com/zolkis/wot-scripting-api.git","svn_url":"https://github.com/zolkis/wot-scripting-api","homepage":null,"size":3201,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"5d70249d8fc126e5dcd268b7df42f51eb2117d5c","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":81894985,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg5NDk4NQ==","name":"wot-scripting-api","full_name":"w3c/wot-scripting-api","owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/wot-scripting-api","description":null,"fork":false,"url":"https://api.github.com/repos/w3c/wot-scripting-api","forks_url":"https://api.github.com/repos/w3c/wot-scripting-api/forks","keys_url":"https://api.github.com/repos/w3c/wot-scripting-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/wot-scripting-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/wot-scripting-api/teams","hooks_url":"https://api.github.com/repos/w3c/wot-scripting-api/hooks","issue_events_url":"https://api.github.com/repos/w3c/wot-scripting-api/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/wot-scripting-api/events","assignees_url":"https://api.github.com/repos/w3c/wot-scripting-api/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/wot-scripting-api/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/wot-scripting-api/tags","blobs_url":"https://api.github.com/repos/w3c/wot-scripting-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/wot-scripting-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/wot-scripting-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/wot-scripting-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/wot-scripting-api/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/wot-scripting-api/languages","stargazers_url":"https://api.github.com/repos/w3c/wot-scripting-api/stargazers","contributors_url":"https://api.github.com/repos/w3c/wot-scripting-api/contributors","subscribers_url":"https://api.github.com/repos/w3c/wot-scripting-api/subscribers","subscription_url":"https://api.github.com/repos/w3c/wot-scripting-api/subscription","commits_url":"https://api.github.com/repos/w3c/wot-scripting-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/wot-scripting-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/wot-scripting-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/wot-scripting-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/wot-scripting-api/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/wot-scripting-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/wot-scripting-api/merges","archive_url":"https://api.github.com/repos/w3c/wot-scripting-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/wot-scripting-api/downloads","issues_url":"https://api.github.com/repos/w3c/wot-scripting-api/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/wot-scripting-api/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/wot-scripting-api/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/wot-scripting-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/wot-scripting-api/labels{/name}","releases_url":"https://api.github.com/repos/w3c/wot-scripting-api/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/wot-scripting-api/deployments","created_at":"2017-02-14T02:24:37Z","updated_at":"2018-06-14T13:38:11Z","pushed_at":"2018-07-23T12:29:14Z","git_url":"git://github.com/w3c/wot-scripting-api.git","ssh_url":"git@github.com:w3c/wot-scripting-api.git","clone_url":"https://github.com/w3c/wot-scripting-api.git","svn_url":"https://github.com/w3c/wot-scripting-api","homepage":null,"size":3083,"stargazers_count":10,"watchers_count":10,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":33,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128"},"html":{"href":"https://github.com/w3c/wot-scripting-api/pull/128"},"issue":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/issues/128"},"comments":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/wot-scripting-api/statuses/d47801a218df87741b10b18660d89fb3c652b8c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zolkis"}}