{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/224986040","pull_request_review_id":164491678,"id":224986040,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk4NjA0MA==","diff_hunk":"@@ -8,11 +8,11 @@ namespace Debug\n {\n     enum Level\n     {\n-        NoLevel = 0,\n         Error = 1,\n         Warning = 2,\n         Info = 3,\n         Verbose = 4,\n+        NoLevel = 5,\n         Marker = Verbose","path":"components/debug/debuglog.hpp","position":null,"original_position":10,"commit_id":"b5df385111241e14fcee20795b8c0a88431ffdbb","original_commit_id":"1156d1c2b58afbe0713015938dcfcdb1ad52e0bd","user":{"login":"Mingun","id":450131,"node_id":"MDQ6VXNlcjQ1MDEzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/450131?v=4","gravatar_id":"","url":"https://api.github.com/users/Mingun","html_url":"https://github.com/Mingun","followers_url":"https://api.github.com/users/Mingun/followers","following_url":"https://api.github.com/users/Mingun/following{/other_user}","gists_url":"https://api.github.com/users/Mingun/gists{/gist_id}","starred_url":"https://api.github.com/users/Mingun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mingun/subscriptions","organizations_url":"https://api.github.com/users/Mingun/orgs","repos_url":"https://api.github.com/users/Mingun/repos","events_url":"https://api.github.com/users/Mingun/events{/privacy}","received_events_url":"https://api.github.com/users/Mingun/received_events","type":"User","site_admin":false},"body":"Nevertheless it seems to me, the code is still insufficiently clear. The idiom with a marker is often used for a mark of the maximum count of elements in enumaration, looking at a code, the same case is supposed here and it is unclear why there is an element which has value greater, than a `Marker`. As a result it seemed to me that there can be a mistake. I suggest to add the comment (preferred in Doxygen style) describing purpose of a `Marker` and why `NoLevel` has greater value than it","created_at":"2018-10-14T09:32:45Z","updated_at":"2018-10-14T09:32:45Z","html_url":"https://github.com/OpenMW/openmw/pull/1966#discussion_r224986040","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1966","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/224986040"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1966#discussion_r224986040"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1966"}},"in_reply_to_id":224786118},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1966","id":222419109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDE5MTA5","html_url":"https://github.com/OpenMW/openmw/pull/1966","diff_url":"https://github.com/OpenMW/openmw/pull/1966.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1966.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1966","number":1966,"state":"closed","locked":false,"title":"Allow apps without logging system to display log messages","user":{"login":"akortunov","id":26434804,"node_id":"MDQ6VXNlcjI2NDM0ODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"body":"Just a small addition to my new logging system.\r\nFor now if the app has no logging system setup (currently we use it only for editor and game itself), it can not display messages via Log() function because of failing \"if\" statement.\r\n\r\nThis change assumes that if CurrentDebugLevel == Debug::NoLevel, the app uses just a simple cout and does not filter messages.\r\nFor example, esmtool now can display messages from ESM reader.","created_at":"2018-10-12T10:19:41Z","updated_at":"2018-10-14T09:32:45Z","closed_at":"2018-10-14T09:20:37Z","merged_at":"2018-10-14T09:20:36Z","merge_commit_sha":"53ccce18675719cb222fb8973c9e34e85e6473ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1966/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1966/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1966/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/b5df385111241e14fcee20795b8c0a88431ffdbb","head":{"label":"akortunov:logfix","ref":"logfix","sha":"b5df385111241e14fcee20795b8c0a88431ffdbb","user":{"login":"akortunov","id":26434804,"node_id":"MDQ6VXNlcjI2NDM0ODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"repo":{"id":85070122,"node_id":"MDEwOlJlcG9zaXRvcnk4NTA3MDEyMg==","name":"openmw","full_name":"akortunov/openmw","private":false,"owner":{"login":"akortunov","id":26434804,"node_id":"MDQ6VXNlcjI2NDM0ODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akortunov/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/akortunov/openmw","forks_url":"https://api.github.com/repos/akortunov/openmw/forks","keys_url":"https://api.github.com/repos/akortunov/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akortunov/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akortunov/openmw/teams","hooks_url":"https://api.github.com/repos/akortunov/openmw/hooks","issue_events_url":"https://api.github.com/repos/akortunov/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/akortunov/openmw/events","assignees_url":"https://api.github.com/repos/akortunov/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/akortunov/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/akortunov/openmw/tags","blobs_url":"https://api.github.com/repos/akortunov/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akortunov/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akortunov/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/akortunov/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akortunov/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/akortunov/openmw/languages","stargazers_url":"https://api.github.com/repos/akortunov/openmw/stargazers","contributors_url":"https://api.github.com/repos/akortunov/openmw/contributors","subscribers_url":"https://api.github.com/repos/akortunov/openmw/subscribers","subscription_url":"https://api.github.com/repos/akortunov/openmw/subscription","commits_url":"https://api.github.com/repos/akortunov/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/akortunov/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/akortunov/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/akortunov/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/akortunov/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/akortunov/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akortunov/openmw/merges","archive_url":"https://api.github.com/repos/akortunov/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akortunov/openmw/downloads","issues_url":"https://api.github.com/repos/akortunov/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/akortunov/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/akortunov/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/akortunov/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akortunov/openmw/labels{/name}","releases_url":"https://api.github.com/repos/akortunov/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/akortunov/openmw/deployments","created_at":"2017-03-15T12:32:34Z","updated_at":"2018-10-12T15:00:55Z","pushed_at":"2018-10-14T08:08:18Z","git_url":"git://github.com/akortunov/openmw.git","ssh_url":"git@github.com:akortunov/openmw.git","clone_url":"https://github.com/akortunov/openmw.git","svn_url":"https://github.com/akortunov/openmw","homepage":"http://www.openmw.org/","size":54653,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"60241431ab72c2ce57f2239fcf1d3c19cf9899cd","user":{"login":"OpenMW","id":6727417,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3Mjc0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"node_id":"MDEwOlJlcG9zaXRvcnkyODU3MjI=","name":"openmw","full_name":"OpenMW/openmw","private":false,"owner":{"login":"OpenMW","id":6727417,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3Mjc0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2018-10-14T09:20:44Z","pushed_at":"2018-10-14T09:20:37Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":54239,"stargazers_count":2322,"watchers_count":2322,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":668,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":668,"open_issues":25,"watchers":2322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1966"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1966"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1966"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1966/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1966/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1966/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/b5df385111241e14fcee20795b8c0a88431ffdbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mingun"}}