{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/comments/172438585","pull_request_review_id":101451603,"id":172438585,"diff_hunk":"@@ -13,18 +13,20 @@ import (\n )\n \n const (\n-\tDefaultLoggingLevel              string        = \"info\"\n-\tDefaultPolicyPollerInterval      time.Duration = 40 * time.Second\n-\tDefaultAggregatorExecuteInterval time.Duration = 40 * time.Second\n-\tDefaultMetricPollerCount         int           = 20\n-\tDefaultAppMonitorChannelSize     int           = 200\n-\tDefaultEvaluationExecuteInterval time.Duration = 40 * time.Second\n-\tDefaultEvaluatorCount            int           = 20\n-\tDefaultTriggerArrayChannelSize   int           = 200\n-\tDefaultLockTTL                   time.Duration = locket.DefaultSessionTTL\n-\tDefaultRetryInterval             time.Duration = locket.RetryInterval\n-\tDefaultDBLockRetryInterval       time.Duration = 5 * time.Second\n-\tDefaultDBLockTTL                 time.Duration = 15 * time.Second\n+\tDefaultLoggingLevel                   string        = \"info\"\n+\tDefaultPolicyPollerInterval           time.Duration = 40 * time.Second\n+\tDefaultAggregatorExecuteInterval      time.Duration = 40 * time.Second\n+\tDefaultMetricPollerCount              int           = 20\n+\tDefaultAppMonitorChannelSize          int           = 200\n+\tDefaultEvaluationExecuteInterval      time.Duration = 40 * time.Second\n+\tDefaultEvaluatorCount                 int           = 20\n+\tDefaultTriggerArrayChannelSize        int           = 200\n+\tDefaultLockTTL                        time.Duration = locket.DefaultSessionTTL\n+\tDefaultRetryInterval                  time.Duration = locket.RetryInterval\n+\tDefaultDBLockRetryInterval            time.Duration = 5 * time.Second\n+\tDefaultDBLockTTL                      time.Duration = 15 * time.Second\n+\tDefaultBreakerTimeout                 time.Duration = 10 * time.Minute","path":"src/autoscaler/eventgenerator/config/config.go","position":28,"original_position":28,"commit_id":"e9dac4ca217ca5b0295525f271721daf5cab29ff","original_commit_id":"e9dac4ca217ca5b0295525f271721daf5cab29ff","user":{"login":"qibobo","id":11609014,"avatar_url":"https://avatars2.githubusercontent.com/u/11609014?v=4","gravatar_id":"","url":"https://api.github.com/users/qibobo","html_url":"https://github.com/qibobo","followers_url":"https://api.github.com/users/qibobo/followers","following_url":"https://api.github.com/users/qibobo/following{/other_user}","gists_url":"https://api.github.com/users/qibobo/gists{/gist_id}","starred_url":"https://api.github.com/users/qibobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qibobo/subscriptions","organizations_url":"https://api.github.com/users/qibobo/orgs","repos_url":"https://api.github.com/users/qibobo/repos","events_url":"https://api.github.com/users/qibobo/events{/privacy}","received_events_url":"https://api.github.com/users/qibobo/received_events","type":"User","site_admin":false},"body":"10 minutes as default is too long?","created_at":"2018-03-06T08:20:38Z","updated_at":"2018-03-06T08:23:00Z","html_url":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310#discussion_r172438585","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/comments/172438585"},"html":{"href":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310#discussion_r172438585"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310","id":172701214,"html_url":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310","diff_url":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310.diff","patch_url":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/310","number":310,"state":"open","locked":false,"title":"circuit breaker for event generator","user":{"login":"boyang9527","id":5013402,"avatar_url":"https://avatars2.githubusercontent.com/u/5013402?v=4","gravatar_id":"","url":"https://api.github.com/users/boyang9527","html_url":"https://github.com/boyang9527","followers_url":"https://api.github.com/users/boyang9527/followers","following_url":"https://api.github.com/users/boyang9527/following{/other_user}","gists_url":"https://api.github.com/users/boyang9527/gists{/gist_id}","starred_url":"https://api.github.com/users/boyang9527/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyang9527/subscriptions","organizations_url":"https://api.github.com/users/boyang9527/orgs","repos_url":"https://api.github.com/users/boyang9527/repos","events_url":"https://api.github.com/users/boyang9527/events{/privacy}","received_events_url":"https://api.github.com/users/boyang9527/received_events","type":"User","site_admin":false},"body":"[#151039644]\r\n\r\n- add circuit breaker config\r\n- use goboker when invoking scaling engine\r\n- test cases for evaluator manager and evaluator\r\n- corresponding changes in main and mian test","created_at":"2018-03-04T03:59:23Z","updated_at":"2018-03-06T08:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee30afd72d2062f8dc916adfe0021b2e8de64bb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390161000,"url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/310/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/statuses/e9dac4ca217ca5b0295525f271721daf5cab29ff","head":{"label":"boyang9527:cb","ref":"cb","sha":"e9dac4ca217ca5b0295525f271721daf5cab29ff","user":{"login":"boyang9527","id":5013402,"avatar_url":"https://avatars2.githubusercontent.com/u/5013402?v=4","gravatar_id":"","url":"https://api.github.com/users/boyang9527","html_url":"https://github.com/boyang9527","followers_url":"https://api.github.com/users/boyang9527/followers","following_url":"https://api.github.com/users/boyang9527/following{/other_user}","gists_url":"https://api.github.com/users/boyang9527/gists{/gist_id}","starred_url":"https://api.github.com/users/boyang9527/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyang9527/subscriptions","organizations_url":"https://api.github.com/users/boyang9527/orgs","repos_url":"https://api.github.com/users/boyang9527/repos","events_url":"https://api.github.com/users/boyang9527/events{/privacy}","received_events_url":"https://api.github.com/users/boyang9527/received_events","type":"User","site_admin":false},"repo":{"id":56274020,"name":"app-autoscaler","full_name":"boyang9527/app-autoscaler","owner":{"login":"boyang9527","id":5013402,"avatar_url":"https://avatars2.githubusercontent.com/u/5013402?v=4","gravatar_id":"","url":"https://api.github.com/users/boyang9527","html_url":"https://github.com/boyang9527","followers_url":"https://api.github.com/users/boyang9527/followers","following_url":"https://api.github.com/users/boyang9527/following{/other_user}","gists_url":"https://api.github.com/users/boyang9527/gists{/gist_id}","starred_url":"https://api.github.com/users/boyang9527/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyang9527/subscriptions","organizations_url":"https://api.github.com/users/boyang9527/orgs","repos_url":"https://api.github.com/users/boyang9527/repos","events_url":"https://api.github.com/users/boyang9527/events{/privacy}","received_events_url":"https://api.github.com/users/boyang9527/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boyang9527/app-autoscaler","description":"Auto Scaling for CF Applications","fork":true,"url":"https://api.github.com/repos/boyang9527/app-autoscaler","forks_url":"https://api.github.com/repos/boyang9527/app-autoscaler/forks","keys_url":"https://api.github.com/repos/boyang9527/app-autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boyang9527/app-autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boyang9527/app-autoscaler/teams","hooks_url":"https://api.github.com/repos/boyang9527/app-autoscaler/hooks","issue_events_url":"https://api.github.com/repos/boyang9527/app-autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/boyang9527/app-autoscaler/events","assignees_url":"https://api.github.com/repos/boyang9527/app-autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/boyang9527/app-autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/boyang9527/app-autoscaler/tags","blobs_url":"https://api.github.com/repos/boyang9527/app-autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boyang9527/app-autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boyang9527/app-autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/boyang9527/app-autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boyang9527/app-autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/boyang9527/app-autoscaler/languages","stargazers_url":"https://api.github.com/repos/boyang9527/app-autoscaler/stargazers","contributors_url":"https://api.github.com/repos/boyang9527/app-autoscaler/contributors","subscribers_url":"https://api.github.com/repos/boyang9527/app-autoscaler/subscribers","subscription_url":"https://api.github.com/repos/boyang9527/app-autoscaler/subscription","commits_url":"https://api.github.com/repos/boyang9527/app-autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/boyang9527/app-autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/boyang9527/app-autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/boyang9527/app-autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/boyang9527/app-autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/boyang9527/app-autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boyang9527/app-autoscaler/merges","archive_url":"https://api.github.com/repos/boyang9527/app-autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boyang9527/app-autoscaler/downloads","issues_url":"https://api.github.com/repos/boyang9527/app-autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/boyang9527/app-autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/boyang9527/app-autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/boyang9527/app-autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boyang9527/app-autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/boyang9527/app-autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/boyang9527/app-autoscaler/deployments","created_at":"2016-04-14T22:31:10Z","updated_at":"2016-04-14T22:31:12Z","pushed_at":"2018-03-04T03:56:17Z","git_url":"git://github.com/boyang9527/app-autoscaler.git","ssh_url":"git@github.com:boyang9527/app-autoscaler.git","clone_url":"https://github.com/boyang9527/app-autoscaler.git","svn_url":"https://github.com/boyang9527/app-autoscaler","homepage":"","size":6062,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cloudfoundry-incubator:develop","ref":"develop","sha":"7b745dfd73064d8745d9f19c24af058f36ddfd1a","user":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":55270767,"name":"app-autoscaler","full_name":"cloudfoundry-incubator/app-autoscaler","owner":{"login":"cloudfoundry-incubator","id":5680605,"avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry-incubator/app-autoscaler","description":"Auto Scaling for CF Applications","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/deployments","created_at":"2016-04-02T00:47:11Z","updated_at":"2018-02-28T16:13:15Z","pushed_at":"2018-03-06T02:37:43Z","git_url":"git://github.com/cloudfoundry-incubator/app-autoscaler.git","ssh_url":"git@github.com:cloudfoundry-incubator/app-autoscaler.git","clone_url":"https://github.com/cloudfoundry-incubator/app-autoscaler.git","svn_url":"https://github.com/cloudfoundry-incubator/app-autoscaler","homepage":"","size":5561,"stargazers_count":39,"watchers_count":39,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":3,"watchers":39,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310"},"html":{"href":"https://github.com/cloudfoundry-incubator/app-autoscaler/pull/310"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/310"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/app-autoscaler/statuses/e9dac4ca217ca5b0295525f271721daf5cab29ff"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"qibobo"}}