{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/232493695","pull_request_review_id":173703713,"id":232493695,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ5MzY5NQ==","diff_hunk":"@@ -835,6 +835,11 @@ def join(self, other, how='left', level=None, return_indexers=False,\n         \"\"\"\n         self._assert_can_do_setop(other)\n \n+        if not isinstance(other, PeriodIndex):","path":"pandas/core/indexes/period.py","position":4,"original_position":4,"commit_id":"ab329a916e586ee1c2466bd37e678f9c4b4eab34","original_commit_id":"ab329a916e586ee1c2466bd37e678f9c4b4eab34","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"what is this needed?","created_at":"2018-11-11T16:06:58Z","updated_at":"2018-11-11T16:11:25Z","html_url":"https://github.com/pandas-dev/pandas/pull/23538#discussion_r232493695","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/232493695"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23538#discussion_r232493695"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538","id":228911925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTExOTI1","html_url":"https://github.com/pandas-dev/pandas/pull/23538","diff_url":"https://github.com/pandas-dev/pandas/pull/23538.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23538.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23538","number":23538,"state":"open","locked":false,"title":"ENH - Index set operation modifications to address issue #23525","user":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"body":"This is a first pass at addressing the associated issue. Needs plenty of discussion, feedback and testing.\r\n\r\n- [ ] closes #23525\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2018-11-07T04:05:23Z","updated_at":"2018-11-11T16:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cfb03523df95d9ce0ef3a4259d94fc9da652c75","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TomAugspurger","id":1312546,"node_id":"MDQ6VXNlcjEzMTI1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":35818298,"node_id":"MDU6TGFiZWwzNTgxODI5OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false},{"id":31404521,"node_id":"MDU6TGFiZWwzMTQwNDUyMQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Dtypes","name":"Dtypes","color":"e102d8","default":false},{"id":2822098,"node_id":"MDU6TGFiZWwyODIyMDk4","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Indexing","name":"Indexing","color":"0b02e1","default":false},{"id":60635328,"node_id":"MDU6TGFiZWw2MDYzNTMyOA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Period","name":"Period","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23538/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/ab329a916e586ee1c2466bd37e678f9c4b4eab34","head":{"label":"ArtinSarraf:enh/index_setops","ref":"enh/index_setops","sha":"ab329a916e586ee1c2466bd37e678f9c4b4eab34","user":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"repo":{"id":152918136,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5MTgxMzY=","name":"pandas","full_name":"ArtinSarraf/pandas","private":false,"owner":{"login":"ArtinSarraf","id":13501084,"node_id":"MDQ6VXNlcjEzNTAxMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13501084?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtinSarraf","html_url":"https://github.com/ArtinSarraf","followers_url":"https://api.github.com/users/ArtinSarraf/followers","following_url":"https://api.github.com/users/ArtinSarraf/following{/other_user}","gists_url":"https://api.github.com/users/ArtinSarraf/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtinSarraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtinSarraf/subscriptions","organizations_url":"https://api.github.com/users/ArtinSarraf/orgs","repos_url":"https://api.github.com/users/ArtinSarraf/repos","events_url":"https://api.github.com/users/ArtinSarraf/events{/privacy}","received_events_url":"https://api.github.com/users/ArtinSarraf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ArtinSarraf/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/ArtinSarraf/pandas","forks_url":"https://api.github.com/repos/ArtinSarraf/pandas/forks","keys_url":"https://api.github.com/repos/ArtinSarraf/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtinSarraf/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtinSarraf/pandas/teams","hooks_url":"https://api.github.com/repos/ArtinSarraf/pandas/hooks","issue_events_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/ArtinSarraf/pandas/events","assignees_url":"https://api.github.com/repos/ArtinSarraf/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/ArtinSarraf/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/ArtinSarraf/pandas/tags","blobs_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtinSarraf/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtinSarraf/pandas/languages","stargazers_url":"https://api.github.com/repos/ArtinSarraf/pandas/stargazers","contributors_url":"https://api.github.com/repos/ArtinSarraf/pandas/contributors","subscribers_url":"https://api.github.com/repos/ArtinSarraf/pandas/subscribers","subscription_url":"https://api.github.com/repos/ArtinSarraf/pandas/subscription","commits_url":"https://api.github.com/repos/ArtinSarraf/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtinSarraf/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtinSarraf/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtinSarraf/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/ArtinSarraf/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtinSarraf/pandas/merges","archive_url":"https://api.github.com/repos/ArtinSarraf/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtinSarraf/pandas/downloads","issues_url":"https://api.github.com/repos/ArtinSarraf/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/ArtinSarraf/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtinSarraf/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtinSarraf/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtinSarraf/pandas/labels{/name}","releases_url":"https://api.github.com/repos/ArtinSarraf/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/ArtinSarraf/pandas/deployments","created_at":"2018-10-13T22:02:09Z","updated_at":"2018-10-13T22:02:16Z","pushed_at":"2018-11-11T06:18:49Z","git_url":"git://github.com/ArtinSarraf/pandas.git","ssh_url":"git@github.com:ArtinSarraf/pandas.git","clone_url":"https://github.com/ArtinSarraf/pandas.git","svn_url":"https://github.com/ArtinSarraf/pandas","homepage":"https://pandas.pydata.org","size":134270,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"82120016e6af85afb052d95710e498a6dc58c1ce","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-11-11T16:11:13Z","pushed_at":"2018-11-11T15:40:44Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":134913,"stargazers_count":16822,"watchers_count":16822,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6787,"mirror_url":null,"archived":false,"open_issues_count":2863,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6787,"open_issues":2863,"watchers":16822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23538"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23538"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23538/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23538/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/ab329a916e586ee1c2466bd37e678f9c4b4eab34"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}