{"action":"opened","issue":{"url":"https://api.github.com/repos/android-ndk/ndk/issues/771","repository_url":"https://api.github.com/repos/android-ndk/ndk","labels_url":"https://api.github.com/repos/android-ndk/ndk/issues/771/labels{/name}","comments_url":"https://api.github.com/repos/android-ndk/ndk/issues/771/comments","events_url":"https://api.github.com/repos/android-ndk/ndk/issues/771/events","html_url":"https://github.com/android-ndk/ndk/issues/771","id":350220143,"node_id":"MDU6SXNzdWUzNTAyMjAxNDM=","number":771,"title":"gtest-printers_test PrintToStringTest.ContainsNonLatin and IsValidUTF8Test.IllFormedUTF8 fail on old devices","user":{"login":"DanAlbert","id":315852,"node_id":"MDQ6VXNlcjMxNTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/315852?v=4","gravatar_id":"","url":"https://api.github.com/users/DanAlbert","html_url":"https://github.com/DanAlbert","followers_url":"https://api.github.com/users/DanAlbert/followers","following_url":"https://api.github.com/users/DanAlbert/following{/other_user}","gists_url":"https://api.github.com/users/DanAlbert/gists{/gist_id}","starred_url":"https://api.github.com/users/DanAlbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanAlbert/subscriptions","organizations_url":"https://api.github.com/users/DanAlbert/orgs","repos_url":"https://api.github.com/users/DanAlbert/repos","events_url":"https://api.github.com/users/DanAlbert/events{/privacy}","received_events_url":"https://api.github.com/users/DanAlbert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-13T22:45:05Z","updated_at":"2018-08-13T22:45:05Z","closed_at":null,"author_association":"MEMBER","body":"When running on android-16 (not sure when this was fixed, it works on android-26 and fails on 16, but I don't have anything in between on hand to test) some of the tests that were added in last week's gtest updates fail:\r\n\r\n```\r\n[ RUN      ] PrintToStringTest.ContainsNonLatin                                      \r\n/work/src/ndk/out/android-ndk-r19-canary/sources/third_party/googletest/test/gtest-printers_test.cc:1516: Failure\r\nValue of: PrintToString(non_ascii_str) == (\"\\\"\\\\xEC\\\\x98\\\\xA4\\\\xEC\\\\xA0\\\\x84 4:30\\\"\\n\" \"    As Text: \\\"오전 4:30\\\"\")\r\n  Actual: false\r\nExpected: true\r\n where non_ascii_str prints as \"\\xEC\\x98\\xA4\\xEC\\xA0\\x84 4:30\"\r\n/work/src/ndk/out/android-ndk-r19-canary/sources/third_party/googletest/test/gtest-printers_test.cc:1520: Failure\r\nValue of: PrintToString(non_ascii_str) == (\"\\\"From \\\\xC3\\\\xA4 \\\\xE2\\\\x80\\\\x94 \\\\xE1\\\\xBA\\\\x91\\\"\" \"\\n    As Text: \\\"From ä — ẑ\\\"\")\r\n  Actual: false\r\nExpected: true\r\n where non_ascii_str prints as \"From \\xC3\\xA4 \\xE2\\x80\\x94 \\xE1\\xBA\\x91\"\r\n[  FAILED  ] PrintToStringTest.ContainsNonLatin (1 ms)\r\n[----------] 9 tests from PrintToStringTest (2 ms total)\r\n\r\n[----------] 1 test from IsValidUTF8Test\r\n[ RUN      ] IsValidUTF8Test.IllFormedUTF8\r\n/work/src/ndk/out/android-ndk-r19-canary/sources/third_party/googletest/test/gtest-printers_test.cc:1579: Failure\r\nValue of: PrintToString(kTestdata[i][0]) == (kTestdata[i][1])\r\n  Actual: false\r\nExpected: true\r\n where kTestdata[i][0] prints as \"\\xED\\x9F\\xBF\"\r\n/work/src/ndk/out/android-ndk-r19-canary/sources/third_party/googletest/test/gtest-printers_test.cc:1579: Failure\r\nValue of: PrintToString(kTestdata[i][0]) == (kTestdata[i][1])\r\n  Actual: false\r\nExpected: true\r\n where kTestdata[i][0] prints as \"\\xEE\\x80\\x80\"\r\n[  FAILED  ] IsValidUTF8Test.IllFormedUTF8 (1 ms)\r\n```\r\n\r\nThis actually causes: \"UnicodeEncodeError: 'ascii' codec can't encode characters in position 14625-14626: ordinal not in range(128)\" in our test runner as well. Interestingly this happens with `.format()` but not with the logging module (which is how I got the output above)."}}
{"actor":{"display_login":"DanAlbert"}}