{"action":"closed","number":36307,"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/36307","id":168993499,"html_url":"https://github.com/moby/moby/pull/36307","diff_url":"https://github.com/moby/moby/pull/36307.diff","patch_url":"https://github.com/moby/moby/pull/36307.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/36307","number":36307,"state":"closed","locked":false,"title":"devmapper cleanup improvements","user":{"login":"kolyshkin","id":4522509,"avatar_url":"https://avatars0.githubusercontent.com/u/4522509?v=4","gravatar_id":"","url":"https://api.github.com/users/kolyshkin","html_url":"https://github.com/kolyshkin","followers_url":"https://api.github.com/users/kolyshkin/followers","following_url":"https://api.github.com/users/kolyshkin/following{/other_user}","gists_url":"https://api.github.com/users/kolyshkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kolyshkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolyshkin/subscriptions","organizations_url":"https://api.github.com/users/kolyshkin/orgs","repos_url":"https://api.github.com/users/kolyshkin/repos","events_url":"https://api.github.com/users/kolyshkin/events{/privacy}","received_events_url":"https://api.github.com/users/kolyshkin/received_events","type":"User","site_admin":false},"body":"## devmapper.shutdown: optimize\r\n    \r\nMove the \"unmount and deactivate\" code into a separate method, and optimize it a bit:\r\n    \r\n1. Do not use `filepath.Walk()` as there's no requirement to recursively go into every directory under home/mnt; a list of directories in mnt is sufficient. With `filepath.Walk()`, in case some container will to unmount, it'll go through the whole container filesystem which is excessive and useless.\r\n    \r\n2. Do not use `GetMounts()` and check if a directory is mounted; just unmount it and ignore \"not mounted\" error. Note the same error is returned in case of wrong flags set, but as flags are hardcoded we can safely ignore such case.\r\n    \r\nWhile at it, promote \"can't unmount\" message log level from debug to warning.\r\n\r\n## devmapper cleanup: improve error msg\r\n    \r\n1. Make sure it's clear the error is from unmount.\r\n    \r\n2. Simplify the code a bit to make it more readable.","created_at":"2018-02-14T00:27:22Z","updated_at":"2018-03-07T20:57:22Z","closed_at":"2018-03-07T20:57:22Z","merged_at":"2018-03-07T20:57:21Z","merge_commit_sha":"bc7424b4434443b036604277bfcdee3fa34a268a","assignee":{"login":"runcom","id":849915,"avatar_url":"https://avatars2.githubusercontent.com/u/849915?v=4","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"assignees":[{"login":"runcom","id":849915,"avatar_url":"https://avatars2.githubusercontent.com/u/849915?v=4","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":77260064,"url":"https://api.github.com/repos/moby/moby/labels/area/storage/devicemapper","name":"area/storage/devicemapper","color":"FBCA04","default":false},{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/36307/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/36307/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/36307/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/f1a459229724f5e8e440b49f058167c2eeeb2dc6","head":{"label":"kolyshkin:dm-misc","ref":"dm-misc","sha":"f1a459229724f5e8e440b49f058167c2eeeb2dc6","user":{"login":"kolyshkin","id":4522509,"avatar_url":"https://avatars0.githubusercontent.com/u/4522509?v=4","gravatar_id":"","url":"https://api.github.com/users/kolyshkin","html_url":"https://github.com/kolyshkin","followers_url":"https://api.github.com/users/kolyshkin/followers","following_url":"https://api.github.com/users/kolyshkin/following{/other_user}","gists_url":"https://api.github.com/users/kolyshkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kolyshkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolyshkin/subscriptions","organizations_url":"https://api.github.com/users/kolyshkin/orgs","repos_url":"https://api.github.com/users/kolyshkin/repos","events_url":"https://api.github.com/users/kolyshkin/events{/privacy}","received_events_url":"https://api.github.com/users/kolyshkin/received_events","type":"User","site_admin":false},"repo":{"id":38019281,"name":"moby","full_name":"kolyshkin/moby","owner":{"login":"kolyshkin","id":4522509,"avatar_url":"https://avatars0.githubusercontent.com/u/4522509?v=4","gravatar_id":"","url":"https://api.github.com/users/kolyshkin","html_url":"https://github.com/kolyshkin","followers_url":"https://api.github.com/users/kolyshkin/followers","following_url":"https://api.github.com/users/kolyshkin/following{/other_user}","gists_url":"https://api.github.com/users/kolyshkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kolyshkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolyshkin/subscriptions","organizations_url":"https://api.github.com/users/kolyshkin/orgs","repos_url":"https://api.github.com/users/kolyshkin/repos","events_url":"https://api.github.com/users/kolyshkin/events{/privacy}","received_events_url":"https://api.github.com/users/kolyshkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kolyshkin/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/kolyshkin/moby","forks_url":"https://api.github.com/repos/kolyshkin/moby/forks","keys_url":"https://api.github.com/repos/kolyshkin/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kolyshkin/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kolyshkin/moby/teams","hooks_url":"https://api.github.com/repos/kolyshkin/moby/hooks","issue_events_url":"https://api.github.com/repos/kolyshkin/moby/issues/events{/number}","events_url":"https://api.github.com/repos/kolyshkin/moby/events","assignees_url":"https://api.github.com/repos/kolyshkin/moby/assignees{/user}","branches_url":"https://api.github.com/repos/kolyshkin/moby/branches{/branch}","tags_url":"https://api.github.com/repos/kolyshkin/moby/tags","blobs_url":"https://api.github.com/repos/kolyshkin/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kolyshkin/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kolyshkin/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/kolyshkin/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kolyshkin/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/kolyshkin/moby/languages","stargazers_url":"https://api.github.com/repos/kolyshkin/moby/stargazers","contributors_url":"https://api.github.com/repos/kolyshkin/moby/contributors","subscribers_url":"https://api.github.com/repos/kolyshkin/moby/subscribers","subscription_url":"https://api.github.com/repos/kolyshkin/moby/subscription","commits_url":"https://api.github.com/repos/kolyshkin/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/kolyshkin/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/kolyshkin/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/kolyshkin/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/kolyshkin/moby/contents/{+path}","compare_url":"https://api.github.com/repos/kolyshkin/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kolyshkin/moby/merges","archive_url":"https://api.github.com/repos/kolyshkin/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kolyshkin/moby/downloads","issues_url":"https://api.github.com/repos/kolyshkin/moby/issues{/number}","pulls_url":"https://api.github.com/repos/kolyshkin/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/kolyshkin/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/kolyshkin/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kolyshkin/moby/labels{/name}","releases_url":"https://api.github.com/repos/kolyshkin/moby/releases{/id}","deployments_url":"https://api.github.com/repos/kolyshkin/moby/deployments","created_at":"2015-06-25T00:51:53Z","updated_at":"2017-06-20T21:10:05Z","pushed_at":"2018-03-07T01:16:14Z","git_url":"git://github.com/kolyshkin/moby.git","ssh_url":"git@github.com:kolyshkin/moby.git","clone_url":"https://github.com/kolyshkin/moby.git","svn_url":"https://github.com/kolyshkin/moby","homepage":"https://mobyproject.org/","size":127425,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"8830ef804fec52f3087d9c24a8583ca9954e0967","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-03-07T20:07:24Z","pushed_at":"2018-03-07T20:57:21Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":131945,"stargazers_count":47911,"watchers_count":47911,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14127,"mirror_url":null,"archived":false,"open_issues_count":3084,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14127,"open_issues":3084,"watchers":47911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/36307"},"html":{"href":"https://github.com/moby/moby/pull/36307"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/36307"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/36307/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/36307/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/36307/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/f1a459229724f5e8e440b49f058167c2eeeb2dc6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"comments":5,"review_comments":13,"maintainer_can_modify":false,"commits":2,"additions":43,"deletions":42,"changed_files":2}}
{"actor":{"display_login":"tonistiigi"}}