{"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/236265291","pull_request_review_id":178301999,"id":236265291,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI2NTI5MQ==","diff_hunk":"@@ -37,12 +37,12 @@ const hardcodedLabware = {\n     ['opentrons-aluminum-block-PCR-strips-200ul', 'Aluminum Block - 0.2mL PCR Strips'],\n   ],\n   'Tube Rack': [\n-    ['opentrons-tuberack-1.5ml-eppendorf', '1.5mL Tube Rack (4-in-1 Rack)'],","path":"protocol-designer/src/components/LabwareSelectionModal/LabwareSelectionModal.js","position":4,"original_position":4,"commit_id":"bc1fd488bb249b077d5e10ebd33fd478bb94a85f","original_commit_id":"bc1fd488bb249b077d5e10ebd33fd478bb94a85f","user":{"login":"Laura-Danielle","id":31892318,"node_id":"MDQ6VXNlcjMxODkyMzE4","avatar_url":"https://avatars3.githubusercontent.com/u/31892318?v=4","gravatar_id":"","url":"https://api.github.com/users/Laura-Danielle","html_url":"https://github.com/Laura-Danielle","followers_url":"https://api.github.com/users/Laura-Danielle/followers","following_url":"https://api.github.com/users/Laura-Danielle/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Danielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Danielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Danielle/subscriptions","organizations_url":"https://api.github.com/users/Laura-Danielle/orgs","repos_url":"https://api.github.com/users/Laura-Danielle/repos","events_url":"https://api.github.com/users/Laura-Danielle/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Danielle/received_events","type":"User","site_admin":false},"body":"That sounds fine to me, Ben had wanted to maybe change the names to make transitioning easier. But it seems like that might cause us to have to do more upfront work and thus defeat the purpose of attempting to change the names earlier","created_at":"2018-11-26T14:02:53Z","updated_at":"2018-11-26T14:02:54Z","html_url":"https://github.com/Opentrons/opentrons/pull/2703#discussion_r236265291","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/236265291"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2703#discussion_r236265291"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703"}},"in_reply_to_id":236250316},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703","id":232445306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDQ1MzA2","html_url":"https://github.com/Opentrons/opentrons/pull/2703","diff_url":"https://github.com/Opentrons/opentrons/pull/2703.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/2703.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2703","number":2703,"state":"open","locked":false,"title":"feat(shared-data): Add more new labware definitions to shared-data","user":{"login":"Laura-Danielle","id":31892318,"node_id":"MDQ6VXNlcjMxODkyMzE4","avatar_url":"https://avatars3.githubusercontent.com/u/31892318?v=4","gravatar_id":"","url":"https://api.github.com/users/Laura-Danielle","html_url":"https://github.com/Laura-Danielle","followers_url":"https://api.github.com/users/Laura-Danielle/followers","following_url":"https://api.github.com/users/Laura-Danielle/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Danielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Danielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Danielle/subscriptions","organizations_url":"https://api.github.com/users/Laura-Danielle/orgs","repos_url":"https://api.github.com/users/Laura-Danielle/repos","events_url":"https://api.github.com/users/Laura-Danielle/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Danielle/received_events","type":"User","site_admin":false},"body":"## overview\r\n\r\nUsing the new generator functions, create and test more labware definitions according to issue #2614 \r\n\r\n## changelog\r\n- Add: all modular tuberack defs, all fixed trash defs\r\n- Change definition names in shared-data/definitions to match with shared-data/definitions2 names for easier transition (change corresponding occurrence in PD)\r\n\r\n## review requests\r\n\r\nPls test on a robot if you can by the following:\r\n\r\n1. Kill main server\r\n```\r\nfrom opentrons import protocol_api, hardware_control, types\r\nimport asyncio\r\nctx = protocol_api.ProtocolContext()\r\nl = asyncio.get_event_loop()\r\napi = l.run_until_complete(hardware_control.API.build_hardware_controller(force=True))\r\nad = hardware_control.adapters.SynchronousAdapter(api)\r\nctx.connect(ad)\r\nlabware = ctx.load_labware_by_name(LABWARE NAME, SLOT)\r\npip = ctx.load_instrument(’p300_single’, types.Mount.LEFT (or right) )\r\npip.move_to(labware.wells()[0].top())\r\n```","created_at":"2018-11-20T20:12:33Z","updated_at":"2018-11-26T14:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5953a48a278c479013c92eeff1a721e27c8f589","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcous","id":2963448,"node_id":"MDQ6VXNlcjI5NjM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":829296994,"node_id":"MDU6TGFiZWw4MjkyOTY5OTQ=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/labware","name":"labware","color":"6312a5","default":false},{"id":762619415,"node_id":"MDU6TGFiZWw3NjI2MTk0MTU=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/ready%20for%20review","name":"ready for review","color":"6ed32a","default":false},{"id":955491895,"node_id":"MDU6TGFiZWw5NTU0OTE4OTU=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/shared%20data","name":"shared data","color":"e85ad9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2703/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/bc1fd488bb249b077d5e10ebd33fd478bb94a85f","head":{"label":"Opentrons:shared-data_add-tuberacks-trash","ref":"shared-data_add-tuberacks-trash","sha":"bc1fd488bb249b077d5e10ebd33fd478bb94a85f","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-11-23T21:40:02Z","pushed_at":"2018-11-23T22:23:48Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":32997,"stargazers_count":88,"watchers_count":88,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":254,"watchers":88,"default_branch":"edge"}},"base":{"label":"Opentrons:edge","ref":"edge","sha":"cd875e2c7976ae7d015c38b4b8fca9e077b72200","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-11-23T21:40:02Z","pushed_at":"2018-11-23T22:23:48Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":32997,"stargazers_count":88,"watchers_count":88,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":254,"watchers":88,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2703"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2703"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2703/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2703/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/bc1fd488bb249b077d5e10ebd33fd478bb94a85f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Laura-Danielle"}}