{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4604","repository_url":"https://api.github.com/repos/xamarin/xamarin-macios","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4604/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4604/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4604/events","html_url":"https://github.com/xamarin/xamarin-macios/pull/4604","id":349095050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjkwNjYx","number":4604,"title":"[Generator] Ensure the correct error is raised when an Export is missing on a Property.","user":{"login":"mandel-macaque","id":2190086,"node_id":"MDQ6VXNlcjIxOTAwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/2190086?v=4","gravatar_id":"","url":"https://api.github.com/users/mandel-macaque","html_url":"https://github.com/mandel-macaque","followers_url":"https://api.github.com/users/mandel-macaque/followers","following_url":"https://api.github.com/users/mandel-macaque/following{/other_user}","gists_url":"https://api.github.com/users/mandel-macaque/gists{/gist_id}","starred_url":"https://api.github.com/users/mandel-macaque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandel-macaque/subscriptions","organizations_url":"https://api.github.com/users/mandel-macaque/orgs","repos_url":"https://api.github.com/users/mandel-macaque/repos","events_url":"https://api.github.com/users/mandel-macaque/events{/privacy}","received_events_url":"https://api.github.com/users/mandel-macaque/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T11:53:43Z","updated_at":"2018-08-10T07:28:33Z","closed_at":"2018-08-09T20:06:15Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4604","html_url":"https://github.com/xamarin/xamarin-macios/pull/4604","diff_url":"https://github.com/xamarin/xamarin-macios/pull/4604.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/4604.patch"},"body":"The generator had a small bug in which we would get a NRE when a\r\nproperty missed a Export attribute and had no WrapAttr. The issue is due\r\nto the fact that an || is being used and does not shortcut when the\r\nattribute is missing. In that case, the first Get check would pass and a\r\nsecond attempt would happen with the set. In the case the set is missing,\r\nwe would get a NRE. The correct way is to ensure that we do have the get\r\nand the set BEFORE the attr is checked.\r\n\r\nThe added test shows an exaple of the issue."},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments/412000151","html_url":"https://github.com/xamarin/xamarin-macios/pull/4604#issuecomment-412000151","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4604","id":412000151,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAwMDE1MQ==","user":{"login":"xamarin-release-manager","id":1002812,"node_id":"MDQ6VXNlcjEwMDI4MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1002812?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin-release-manager","html_url":"https://github.com/xamarin-release-manager","followers_url":"https://api.github.com/users/xamarin-release-manager/followers","following_url":"https://api.github.com/users/xamarin-release-manager/following{/other_user}","gists_url":"https://api.github.com/users/xamarin-release-manager/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin-release-manager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin-release-manager/subscriptions","organizations_url":"https://api.github.com/users/xamarin-release-manager/orgs","repos_url":"https://api.github.com/users/xamarin-release-manager/repos","events_url":"https://api.github.com/users/xamarin-release-manager/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin-release-manager/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T07:28:33Z","updated_at":"2018-08-10T07:28:33Z","author_association":"COLLABORATOR","body":"❌ [Build was (probably) aborted](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4604/2/display/redirect)\n\n🔥 [Jenkins job](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4604/2/display/redirect) (on internal Jenkins) failed in stage 'Checkout' 🔥 : hudson.AbortException: script returned exit code 128"}}
{"actor":{"display_login":"xamarin-release-manager"}}