{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/191747354","pull_request_review_id":124355525,"id":191747354,"diff_hunk":"@@ -0,0 +1,115 @@\n+# Kconfig - nrfx I2C support\n+#\n+# Copyright (c) 2017 - 2018, Nordic Semiconductor ASA\n+#\n+# SPDX-License-Identifier: Apache-2.0\n+#\n+\n+menuconfig I2C_NRFX\n+\tbool \"nRF TWI nrfx drivers\"\n+\tdepends on SOC_FAMILY_NRF\n+\thelp\n+\t  Enable support for nrfx TWI drivers for nRF MCU series.\n+\t  Peripherals with the same instance ID cannot be used together,\n+\t  e.g. I2C_0 and SPI_0. You may need to disable SPI_0 or SPI_1.\n+\n+if I2C_NRFX\n+\n+config I2C_NRFX_PINS_OVERRIDE_DTS","path":"drivers/i2c/Kconfig.nrfx","position":18,"original_position":18,"commit_id":"9361f5af6a0010ad30d001ea15a034d8a684bcc4","original_commit_id":"9361f5af6a0010ad30d001ea15a034d8a684bcc4","user":{"login":"anangl","id":16913290,"avatar_url":"https://avatars3.githubusercontent.com/u/16913290?v=4","gravatar_id":"","url":"https://api.github.com/users/anangl","html_url":"https://github.com/anangl","followers_url":"https://api.github.com/users/anangl/followers","following_url":"https://api.github.com/users/anangl/following{/other_user}","gists_url":"https://api.github.com/users/anangl/gists{/gist_id}","starred_url":"https://api.github.com/users/anangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anangl/subscriptions","organizations_url":"https://api.github.com/users/anangl/orgs","repos_url":"https://api.github.com/users/anangl/repos","events_url":"https://api.github.com/users/anangl/events{/privacy}","received_events_url":"https://api.github.com/users/anangl/received_events","type":"User","site_admin":false},"body":"Wouldn't `I2C_NRF_OVERRIDE_DTS_PINS` be more adequate (NRF, because this entry, like pins settings, is not nrfx related but generic for nRF chips)?","created_at":"2018-05-30T12:31:02Z","updated_at":"2018-05-30T12:32:20Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7788#discussion_r191747354","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/191747354"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/7788#discussion_r191747354"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788","id":189939035,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7788","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7788.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7788.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7788","number":7788,"state":"open","locked":false,"title":"drivers: i2c: I2C shim for nrfx TWI and TWIM drivers","user":{"login":"Mierunski","id":19541298,"avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"body":"I prepared shim implementation for TWI and TWIM nrfx drivers. Changed board definitions to point to the new shim and removed old implementation.\r\nTested with HTS221 example on nrf52_pca20020 board.","created_at":"2018-05-23T11:14:23Z","updated_at":"2018-05-30T12:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9035a674ab4ae473c8b49da1c4bef4db7db800a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MaureenHelm","id":6172539,"avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"carlescufi","id":12450381,"avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7788/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/9361f5af6a0010ad30d001ea15a034d8a684bcc4","head":{"label":"Mierunski:nrfx_shim_twi","ref":"nrfx_shim_twi","sha":"9361f5af6a0010ad30d001ea15a034d8a684bcc4","user":{"login":"Mierunski","id":19541298,"avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"repo":{"id":134420444,"name":"zephyr","full_name":"Mierunski/zephyr","owner":{"login":"Mierunski","id":19541298,"avatar_url":"https://avatars0.githubusercontent.com/u/19541298?v=4","gravatar_id":"","url":"https://api.github.com/users/Mierunski","html_url":"https://github.com/Mierunski","followers_url":"https://api.github.com/users/Mierunski/followers","following_url":"https://api.github.com/users/Mierunski/following{/other_user}","gists_url":"https://api.github.com/users/Mierunski/gists{/gist_id}","starred_url":"https://api.github.com/users/Mierunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mierunski/subscriptions","organizations_url":"https://api.github.com/users/Mierunski/orgs","repos_url":"https://api.github.com/users/Mierunski/repos","events_url":"https://api.github.com/users/Mierunski/events{/privacy}","received_events_url":"https://api.github.com/users/Mierunski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mierunski/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/Mierunski/zephyr","forks_url":"https://api.github.com/repos/Mierunski/zephyr/forks","keys_url":"https://api.github.com/repos/Mierunski/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mierunski/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mierunski/zephyr/teams","hooks_url":"https://api.github.com/repos/Mierunski/zephyr/hooks","issue_events_url":"https://api.github.com/repos/Mierunski/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/Mierunski/zephyr/events","assignees_url":"https://api.github.com/repos/Mierunski/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/Mierunski/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/Mierunski/zephyr/tags","blobs_url":"https://api.github.com/repos/Mierunski/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mierunski/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mierunski/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mierunski/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mierunski/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/Mierunski/zephyr/languages","stargazers_url":"https://api.github.com/repos/Mierunski/zephyr/stargazers","contributors_url":"https://api.github.com/repos/Mierunski/zephyr/contributors","subscribers_url":"https://api.github.com/repos/Mierunski/zephyr/subscribers","subscription_url":"https://api.github.com/repos/Mierunski/zephyr/subscription","commits_url":"https://api.github.com/repos/Mierunski/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mierunski/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mierunski/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mierunski/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mierunski/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/Mierunski/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mierunski/zephyr/merges","archive_url":"https://api.github.com/repos/Mierunski/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mierunski/zephyr/downloads","issues_url":"https://api.github.com/repos/Mierunski/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/Mierunski/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/Mierunski/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/Mierunski/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mierunski/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/Mierunski/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/Mierunski/zephyr/deployments","created_at":"2018-05-22T13:36:49Z","updated_at":"2018-05-22T13:37:30Z","pushed_at":"2018-05-29T07:10:27Z","git_url":"git://github.com/Mierunski/zephyr.git","ssh_url":"git@github.com:Mierunski/zephyr.git","clone_url":"https://github.com/Mierunski/zephyr.git","svn_url":"https://github.com/Mierunski/zephyr","homepage":"https://docs.zephyrproject.org","size":112044,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"5405f6887802803292737b9be65d5da6392ea23a","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-05-30T12:30:59Z","pushed_at":"2018-05-30T12:30:19Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":112186,"stargazers_count":872,"watchers_count":872,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":632,"mirror_url":null,"archived":false,"open_issues_count":908,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":632,"open_issues":908,"watchers":872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/7788"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7788"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7788/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7788/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/9361f5af6a0010ad30d001ea15a034d8a684bcc4"}},"author_association":"NONE"}}
{"actor":{"display_login":"anangl"}}