{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/13313","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/13313/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/13313/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/13313/events","html_url":"https://github.com/fastlane/fastlane/issues/13313","id":357784805,"node_id":"MDU6SXNzdWUzNTc3ODQ4MDU=","number":13313,"title":"Supply seems to incorrectly deactivate lower tracks during rollout","user":{"login":"tmtrademarked","id":16063079,"node_id":"MDQ6VXNlcjE2MDYzMDc5","avatar_url":"https://avatars0.githubusercontent.com/u/16063079?v=4","gravatar_id":"","url":"https://api.github.com/users/tmtrademarked","html_url":"https://github.com/tmtrademarked","followers_url":"https://api.github.com/users/tmtrademarked/followers","following_url":"https://api.github.com/users/tmtrademarked/following{/other_user}","gists_url":"https://api.github.com/users/tmtrademarked/gists{/gist_id}","starred_url":"https://api.github.com/users/tmtrademarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmtrademarked/subscriptions","organizations_url":"https://api.github.com/users/tmtrademarked/orgs","repos_url":"https://api.github.com/users/tmtrademarked/repos","events_url":"https://api.github.com/users/tmtrademarked/events{/privacy}","received_events_url":"https://api.github.com/users/tmtrademarked/received_events","type":"User","site_admin":false},"labels":[{"id":315718186,"node_id":"MDU6TGFiZWwzMTU3MTgxODY=","url":"https://api.github.com/repos/fastlane/fastlane/labels/tool:%20supply","name":"tool: supply","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-06T19:02:39Z","updated_at":"2018-09-17T16:05:40Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### New Issue Checklist\r\n\r\n- [x] Updated fastlane to the latest version\r\n- [x] I read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I read [docs.fastlane.tools](https://docs.fastlane.tools)\r\n- [x] I searched for [existing GitHub issues](https://github.com/fastlane/fastlane/issues)\r\n\r\n### Issue Description\r\nSupply appears to deactivate lower tracks when promoting to a new track. From what I can tell, this seems to result in APKs being unavailable to users who are whitelisted for the lower tracks.\r\n\r\nLet's take an example here, where user A is whitelisted for the alpha track, but not the beta track. When an APK is promoted via supply from alpha to beta, we'd expect user A to be able to continue to receive the build. This doesn't appear to be the case - when looking at my Play Store console, it appears that the APK was removed from the alpha track during the promotion process.\r\n\r\nI'm reasonably confident that this line (https://github.com/fastlane/fastlane/blob/master/supply/lib/supply/uploader.rb#L67) is the source of this bug. It appears that Supply is *deliberately* clearing the original track when promoting, which appears to be causing unintentional behavior. Note that it doesn't matter if the user passes the `check_superseded_tracks` option or not - this happens *outside* of that block of logic.\r\n\r\nIt's possible that the behavior of the Google APIs have changed since this was authored two years ago - maybe it was necessary at one point? But it certainly seems like this is no longer needed.\r\n\r\nI'd be happy to roll a PR adding a flag to bypass this line if we believe that's a reasonable fix. But I figured I would check with the experts here to see if my understanding is at all reasonable before attempting to fix.\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/422074990","html_url":"https://github.com/fastlane/fastlane/issues/13313#issuecomment-422074990","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/13313","id":422074990,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjA3NDk5MA==","user":{"login":"tmtrademarked","id":16063079,"node_id":"MDQ6VXNlcjE2MDYzMDc5","avatar_url":"https://avatars0.githubusercontent.com/u/16063079?v=4","gravatar_id":"","url":"https://api.github.com/users/tmtrademarked","html_url":"https://github.com/tmtrademarked","followers_url":"https://api.github.com/users/tmtrademarked/followers","following_url":"https://api.github.com/users/tmtrademarked/following{/other_user}","gists_url":"https://api.github.com/users/tmtrademarked/gists{/gist_id}","starred_url":"https://api.github.com/users/tmtrademarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmtrademarked/subscriptions","organizations_url":"https://api.github.com/users/tmtrademarked/orgs","repos_url":"https://api.github.com/users/tmtrademarked/repos","events_url":"https://api.github.com/users/tmtrademarked/events{/privacy}","received_events_url":"https://api.github.com/users/tmtrademarked/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T16:05:40Z","updated_at":"2018-09-17T16:05:40Z","author_association":"CONTRIBUTOR","body":"I've been running this locally for promoting my builds so far with the new option applied. (Effectively the same as just removing that line) So far, it seems to work just fine, and it matches my understanding of how this *should* work from the Play perspective.\r\n\r\nMy only concern here would be that removing that line *technically* results in a slight change in behavior. It's possible this breaks some workflow out there, although I'm hard pressed to imagine what could possibly be relying on this. \r\n\r\nSo yeah - TLDR, I'm good with removing the line entirely and not adding the option if we think that's more correct. Just give me a thumbs up here if that's the approach we think makes the most sense, and I can update the PR."}}
{"actor":{"display_login":"tmtrademarked"}}