{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/204155881","pull_request_review_id":139194074,"id":204155881,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE1NTg4MQ==","diff_hunk":"@@ -101,8 +106,7 @@ export class AmpAnim extends AMP.BaseElement {\n   /** @override */\n   unlayoutCallback() {\n     // Release memory held by the image - animations are typically large.\n-    this.img_.src = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///' +\n-        'yH5BAEAAAAALAAAAAABAAEAAAIBRAA7';\n+    this.img_.src = SRC_PLACEHOLDER;","path":"extensions/amp-anim/0.1/amp-anim.js","position":59,"original_position":62,"commit_id":"c4e73748720e09b15d5a26bed9b6fbf7b9581e7f","original_commit_id":"53b20170758ff8799861000daf6484aa12c337b1","user":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"I updated this so that we update the `srcset` as well. But empirically (Chrome/Firefox/Safari Desktop MacOS), this override will actually update the actual image src when we scroll outside the viewport, even if srcset attribute is present. I'm not quite sure why. ","created_at":"2018-07-20T20:05:46Z","updated_at":"2018-07-20T20:05:46Z","html_url":"https://github.com/ampproject/amphtml/pull/16655#discussion_r204155881","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16655","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/204155881"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16655#discussion_r204155881"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16655"}},"in_reply_to_id":203481290},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/16655","id":200469344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDY5MzQ0","html_url":"https://github.com/ampproject/amphtml/pull/16655","diff_url":"https://github.com/ampproject/amphtml/pull/16655.diff","patch_url":"https://github.com/ampproject/amphtml/pull/16655.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/16655","number":16655,"state":"open","locked":false,"title":"Remove srcset polyfill from <amp-anim>","user":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/ampproject/amphtml/issues/11372\r\nThis PR removes our native `srcset` polyfill from `<amp-anim>` and propagates the `srcset` attribute instead. Adds automated and manual tests to verify that: \r\n1. `srcset` and `src` attributes are correctly propagated. \r\n2. Freeing memory on `unlayoutCallback` and bringing back the gif on `layoutCallback` still works. \r\n3. No regressions in placeholder and fallback behavior. \r\n\r\n- [x] Cross browser and device testing\r\n- [x] Verify what's happening with the fallback image in this case (amp-anim does not seem to handle it out of the box)","created_at":"2018-07-10T17:25:05Z","updated_at":"2018-07-20T20:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732fc5a5737b48563c48e676831a82ff838b24c8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"erwinmombay","id":354746,"node_id":"MDQ6VXNlcjM1NDc0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/354746?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16655/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16655/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/16655/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/c4e73748720e09b15d5a26bed9b6fbf7b9581e7f","head":{"label":"cathyxz:feature/anim-srcset","ref":"feature/anim-srcset","sha":"c4e73748720e09b15d5a26bed9b6fbf7b9581e7f","user":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"repo":{"id":108910422,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg5MTA0MjI=","name":"amphtml","full_name":"cathyxz/amphtml","owner":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cathyxz/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cathyxz/amphtml","forks_url":"https://api.github.com/repos/cathyxz/amphtml/forks","keys_url":"https://api.github.com/repos/cathyxz/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cathyxz/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cathyxz/amphtml/teams","hooks_url":"https://api.github.com/repos/cathyxz/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cathyxz/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cathyxz/amphtml/events","assignees_url":"https://api.github.com/repos/cathyxz/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cathyxz/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cathyxz/amphtml/tags","blobs_url":"https://api.github.com/repos/cathyxz/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cathyxz/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cathyxz/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cathyxz/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cathyxz/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cathyxz/amphtml/languages","stargazers_url":"https://api.github.com/repos/cathyxz/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cathyxz/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cathyxz/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cathyxz/amphtml/subscription","commits_url":"https://api.github.com/repos/cathyxz/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cathyxz/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cathyxz/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cathyxz/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cathyxz/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cathyxz/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cathyxz/amphtml/merges","archive_url":"https://api.github.com/repos/cathyxz/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cathyxz/amphtml/downloads","issues_url":"https://api.github.com/repos/cathyxz/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cathyxz/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cathyxz/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cathyxz/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cathyxz/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cathyxz/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cathyxz/amphtml/deployments","created_at":"2017-10-30T21:27:41Z","updated_at":"2018-07-17T23:12:33Z","pushed_at":"2018-07-20T19:44:12Z","git_url":"git://github.com/cathyxz/amphtml.git","ssh_url":"git@github.com:cathyxz/amphtml.git","clone_url":"https://github.com/cathyxz/amphtml.git","svn_url":"https://github.com/cathyxz/amphtml","homepage":"https://www.ampproject.org","size":485538,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"435b2dabd5a65e912e0918bbf6a3f563595a5d05","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-07-20T19:55:06Z","pushed_at":"2018-07-20T20:01:08Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":485904,"stargazers_count":11779,"watchers_count":11779,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2500,"mirror_url":null,"archived":false,"open_issues_count":1320,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2500,"open_issues":1320,"watchers":11779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16655"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16655"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16655"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16655/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16655/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16655/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/c4e73748720e09b15d5a26bed9b6fbf7b9581e7f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cathyxz"}}