{"action":"created","issue":{"url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/70","repository_url":"https://api.github.com/repos/DAVFoundation/dav-js","labels_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/70/comments","events_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/70/events","html_url":"https://github.com/DAVFoundation/dav-js/pull/70","id":365537332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDM0NjE2","number":70,"title":"Update test for src/ride-hailing/NeedFilterParams.test.ts ","user":{"login":"sark01","id":17831726,"node_id":"MDQ6VXNlcjE3ODMxNzI2","avatar_url":"https://avatars2.githubusercontent.com/u/17831726?v=4","gravatar_id":"","url":"https://api.github.com/users/sark01","html_url":"https://github.com/sark01","followers_url":"https://api.github.com/users/sark01/followers","following_url":"https://api.github.com/users/sark01/following{/other_user}","gists_url":"https://api.github.com/users/sark01/gists{/gist_id}","starred_url":"https://api.github.com/users/sark01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sark01/subscriptions","organizations_url":"https://api.github.com/users/sark01/orgs","repos_url":"https://api.github.com/users/sark01/repos","events_url":"https://api.github.com/users/sark01/events{/privacy}","received_events_url":"https://api.github.com/users/sark01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-01T16:17:37Z","updated_at":"2018-10-02T01:14:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DAVFoundation/dav-js/pulls/70","html_url":"https://github.com/DAVFoundation/dav-js/pull/70","diff_url":"https://github.com/DAVFoundation/dav-js/pull/70.diff","patch_url":"https://github.com/DAVFoundation/dav-js/pull/70.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nUpdated test for src/ride-hailing/NeedFilterParams.test.ts #55 \r\n## Description\r\n<!--- Describe your changes in detail -->\r\nI made changes to the file NeedFilterParams.test.ts to accommodate more unit tests by updating the parameters to be dynamic by making them mutable.\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n#52 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nFirst Timer, interested in contributing more to this repository.\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nThis has been tested by running command `npm run jest`\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/comments/426114352","html_url":"https://github.com/DAVFoundation/dav-js/pull/70#issuecomment-426114352","issue_url":"https://api.github.com/repos/DAVFoundation/dav-js/issues/70","id":426114352,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjExNDM1Mg==","user":{"login":"mariolo1985","id":17772508,"node_id":"MDQ6VXNlcjE3NzcyNTA4","avatar_url":"https://avatars3.githubusercontent.com/u/17772508?v=4","gravatar_id":"","url":"https://api.github.com/users/mariolo1985","html_url":"https://github.com/mariolo1985","followers_url":"https://api.github.com/users/mariolo1985/followers","following_url":"https://api.github.com/users/mariolo1985/following{/other_user}","gists_url":"https://api.github.com/users/mariolo1985/gists{/gist_id}","starred_url":"https://api.github.com/users/mariolo1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariolo1985/subscriptions","organizations_url":"https://api.github.com/users/mariolo1985/orgs","repos_url":"https://api.github.com/users/mariolo1985/repos","events_url":"https://api.github.com/users/mariolo1985/events{/privacy}","received_events_url":"https://api.github.com/users/mariolo1985/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T01:14:37Z","updated_at":"2018-10-02T01:14:37Z","author_association":"CONTRIBUTOR","body":"Thanks for contributing @sark01. This is very helpful 😀 "}}
{"actor":{"display_login":"mariolo1985"}}