{"action":"created","comment":{"url":"https://api.github.com/repos/istio/fortio/pulls/comments/165802273","pull_request_review_id":93804266,"id":165802273,"diff_hunk":"@@ -0,0 +1,77 @@\n+// Copyright 2017 Istio Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package util // import \"istio.io/fortio/util\"\n+\n+import (\n+\t\"fmt\"\n+\t\"net\"\n+\t\"strconv\"\n+)\n+\n+const (\n+\t// MinTCPPort is the minimum TCP port number that can be used by Fortio http server.\n+\tMinTCPPort int = 1024\n+\t// MaxTCPPort is the maximum TCP port number that can be used by Fortio http server.\n+\tMaxTCPPort int = 65535","path":"util/network.go","position":27,"original_position":27,"commit_id":"030bc7422816886a5635a00264ae78c19005bc2f","original_commit_id":"030bc7422816886a5635a00264ae78c19005bc2f","user":{"login":"ldemailly","id":3664595,"avatar_url":"https://avatars2.githubusercontent.com/u/3664595?v=4","gravatar_id":"","url":"https://api.github.com/users/ldemailly","html_url":"https://github.com/ldemailly","followers_url":"https://api.github.com/users/ldemailly/followers","following_url":"https://api.github.com/users/ldemailly/following{/other_user}","gists_url":"https://api.github.com/users/ldemailly/gists{/gist_id}","starred_url":"https://api.github.com/users/ldemailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldemailly/subscriptions","organizations_url":"https://api.github.com/users/ldemailly/orgs","repos_url":"https://api.github.com/users/ldemailly/repos","events_url":"https://api.github.com/users/ldemailly/events{/privacy}","received_events_url":"https://api.github.com/users/ldemailly/received_events","type":"User","site_admin":false},"body":"there must be such constant somewhere already in go ? but... more importantly:\r\n\r\nalso one can in theory use :svcname (from /etc/services) it doesn't have to be a number to work (current fortio uses a number for simplification but if we are support string it should just be passed to the listener as is)\r\n\r\n","created_at":"2018-02-03T02:44:35Z","updated_at":"2018-02-03T02:52:45Z","html_url":"https://github.com/istio/fortio/pull/109#discussion_r165802273","pull_request_url":"https://api.github.com/repos/istio/fortio/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/fortio/pulls/comments/165802273"},"html":{"href":"https://github.com/istio/fortio/pull/109#discussion_r165802273"},"pull_request":{"href":"https://api.github.com/repos/istio/fortio/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/istio/fortio/pulls/109","id":166153714,"html_url":"https://github.com/istio/fortio/pull/109","diff_url":"https://github.com/istio/fortio/pull/109.diff","patch_url":"https://github.com/istio/fortio/pull/109.patch","issue_url":"https://api.github.com/repos/istio/fortio/issues/109","number":109,"state":"open","locked":false,"title":"Adds support for specifying an IP to bind http-port","user":{"login":"danehans","id":1878195,"avatar_url":"https://avatars3.githubusercontent.com/u/1878195?v=4","gravatar_id":"","url":"https://api.github.com/users/danehans","html_url":"https://github.com/danehans","followers_url":"https://api.github.com/users/danehans/followers","following_url":"https://api.github.com/users/danehans/following{/other_user}","gists_url":"https://api.github.com/users/danehans/gists{/gist_id}","starred_url":"https://api.github.com/users/danehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danehans/subscriptions","organizations_url":"https://api.github.com/users/danehans/orgs","repos_url":"https://api.github.com/users/danehans/repos","events_url":"https://api.github.com/users/danehans/events{/privacy}","received_events_url":"https://api.github.com/users/danehans/received_events","type":"User","site_admin":false},"body":"This PR allows Fortio to provide a flag for binding`http-port` to a specific IP address. `http-port` type was changed from an int to a string.\r\n\r\nFixes https://github.com/istio/fortio/issues/91 and https://github.com/istio/fortio/issues/110","created_at":"2018-01-31T02:51:31Z","updated_at":"2018-02-03T02:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ee21d8cea286ea41218db25186e82277d097aa4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/fortio/pulls/109/commits","review_comments_url":"https://api.github.com/repos/istio/fortio/pulls/109/comments","review_comment_url":"https://api.github.com/repos/istio/fortio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/fortio/issues/109/comments","statuses_url":"https://api.github.com/repos/istio/fortio/statuses/030bc7422816886a5635a00264ae78c19005bc2f","head":{"label":"danehans:listen_addr","ref":"listen_addr","sha":"030bc7422816886a5635a00264ae78c19005bc2f","user":{"login":"danehans","id":1878195,"avatar_url":"https://avatars3.githubusercontent.com/u/1878195?v=4","gravatar_id":"","url":"https://api.github.com/users/danehans","html_url":"https://github.com/danehans","followers_url":"https://api.github.com/users/danehans/followers","following_url":"https://api.github.com/users/danehans/following{/other_user}","gists_url":"https://api.github.com/users/danehans/gists{/gist_id}","starred_url":"https://api.github.com/users/danehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danehans/subscriptions","organizations_url":"https://api.github.com/users/danehans/orgs","repos_url":"https://api.github.com/users/danehans/repos","events_url":"https://api.github.com/users/danehans/events{/privacy}","received_events_url":"https://api.github.com/users/danehans/received_events","type":"User","site_admin":false},"repo":{"id":119093158,"name":"fortio","full_name":"danehans/fortio","owner":{"login":"danehans","id":1878195,"avatar_url":"https://avatars3.githubusercontent.com/u/1878195?v=4","gravatar_id":"","url":"https://api.github.com/users/danehans","html_url":"https://github.com/danehans","followers_url":"https://api.github.com/users/danehans/followers","following_url":"https://api.github.com/users/danehans/following{/other_user}","gists_url":"https://api.github.com/users/danehans/gists{/gist_id}","starred_url":"https://api.github.com/users/danehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danehans/subscriptions","organizations_url":"https://api.github.com/users/danehans/orgs","repos_url":"https://api.github.com/users/danehans/repos","events_url":"https://api.github.com/users/danehans/events{/privacy}","received_events_url":"https://api.github.com/users/danehans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danehans/fortio","description":"Fortio load testing library and command line tool and web UI in go (golang). Allows to specify a set query-per-second load and record latency histograms and other useful stats.","fork":true,"url":"https://api.github.com/repos/danehans/fortio","forks_url":"https://api.github.com/repos/danehans/fortio/forks","keys_url":"https://api.github.com/repos/danehans/fortio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danehans/fortio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danehans/fortio/teams","hooks_url":"https://api.github.com/repos/danehans/fortio/hooks","issue_events_url":"https://api.github.com/repos/danehans/fortio/issues/events{/number}","events_url":"https://api.github.com/repos/danehans/fortio/events","assignees_url":"https://api.github.com/repos/danehans/fortio/assignees{/user}","branches_url":"https://api.github.com/repos/danehans/fortio/branches{/branch}","tags_url":"https://api.github.com/repos/danehans/fortio/tags","blobs_url":"https://api.github.com/repos/danehans/fortio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danehans/fortio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danehans/fortio/git/refs{/sha}","trees_url":"https://api.github.com/repos/danehans/fortio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danehans/fortio/statuses/{sha}","languages_url":"https://api.github.com/repos/danehans/fortio/languages","stargazers_url":"https://api.github.com/repos/danehans/fortio/stargazers","contributors_url":"https://api.github.com/repos/danehans/fortio/contributors","subscribers_url":"https://api.github.com/repos/danehans/fortio/subscribers","subscription_url":"https://api.github.com/repos/danehans/fortio/subscription","commits_url":"https://api.github.com/repos/danehans/fortio/commits{/sha}","git_commits_url":"https://api.github.com/repos/danehans/fortio/git/commits{/sha}","comments_url":"https://api.github.com/repos/danehans/fortio/comments{/number}","issue_comment_url":"https://api.github.com/repos/danehans/fortio/issues/comments{/number}","contents_url":"https://api.github.com/repos/danehans/fortio/contents/{+path}","compare_url":"https://api.github.com/repos/danehans/fortio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danehans/fortio/merges","archive_url":"https://api.github.com/repos/danehans/fortio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danehans/fortio/downloads","issues_url":"https://api.github.com/repos/danehans/fortio/issues{/number}","pulls_url":"https://api.github.com/repos/danehans/fortio/pulls{/number}","milestones_url":"https://api.github.com/repos/danehans/fortio/milestones{/number}","notifications_url":"https://api.github.com/repos/danehans/fortio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danehans/fortio/labels{/name}","releases_url":"https://api.github.com/repos/danehans/fortio/releases{/id}","deployments_url":"https://api.github.com/repos/danehans/fortio/deployments","created_at":"2018-01-26T19:19:48Z","updated_at":"2018-01-26T19:19:49Z","pushed_at":"2018-02-02T20:59:22Z","git_url":"git://github.com/danehans/fortio.git","ssh_url":"git@github.com:danehans/fortio.git","clone_url":"https://github.com/danehans/fortio.git","svn_url":"https://github.com/danehans/fortio","homepage":"","size":622,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"1e920066195db0de6cd57b6dce058a4b1e080f13","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":106351459,"name":"fortio","full_name":"istio/fortio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/fortio","description":"Fortio load testing library and command line tool and web UI in go (golang). Allows to specify a set query-per-second load and record latency histograms and other useful stats.","fork":false,"url":"https://api.github.com/repos/istio/fortio","forks_url":"https://api.github.com/repos/istio/fortio/forks","keys_url":"https://api.github.com/repos/istio/fortio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/fortio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/fortio/teams","hooks_url":"https://api.github.com/repos/istio/fortio/hooks","issue_events_url":"https://api.github.com/repos/istio/fortio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/fortio/events","assignees_url":"https://api.github.com/repos/istio/fortio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/fortio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/fortio/tags","blobs_url":"https://api.github.com/repos/istio/fortio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/fortio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/fortio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/fortio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/fortio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/fortio/languages","stargazers_url":"https://api.github.com/repos/istio/fortio/stargazers","contributors_url":"https://api.github.com/repos/istio/fortio/contributors","subscribers_url":"https://api.github.com/repos/istio/fortio/subscribers","subscription_url":"https://api.github.com/repos/istio/fortio/subscription","commits_url":"https://api.github.com/repos/istio/fortio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/fortio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/fortio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/fortio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/fortio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/fortio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/fortio/merges","archive_url":"https://api.github.com/repos/istio/fortio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/fortio/downloads","issues_url":"https://api.github.com/repos/istio/fortio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/fortio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/fortio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/fortio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/fortio/labels{/name}","releases_url":"https://api.github.com/repos/istio/fortio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/fortio/deployments","created_at":"2017-10-10T01:01:39Z","updated_at":"2018-02-02T19:10:25Z","pushed_at":"2018-02-02T20:59:22Z","git_url":"git://github.com/istio/fortio.git","ssh_url":"git@github.com:istio/fortio.git","clone_url":"https://github.com/istio/fortio.git","svn_url":"https://github.com/istio/fortio","homepage":"","size":608,"stargazers_count":219,"watchers_count":219,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":20,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/fortio/pulls/109"},"html":{"href":"https://github.com/istio/fortio/pull/109"},"issue":{"href":"https://api.github.com/repos/istio/fortio/issues/109"},"comments":{"href":"https://api.github.com/repos/istio/fortio/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/fortio/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/fortio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/fortio/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/istio/fortio/statuses/030bc7422816886a5635a00264ae78c19005bc2f"}},"author_association":"NONE"}}
{"actor":{"display_login":"ldemailly"}}