{"action":"created","comment":{"url":"https://api.github.com/repos/mcb30/dw1000/pulls/comments/195402265","pull_request_review_id":128763740,"id":195402265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQwMjI2NQ==","diff_hunk":"@@ -2946,19 +3000,32 @@ static int dw1000_load_eui64(struct dw1000 *dw)\n  */\n static int dw1000_load_delays(struct dw1000 *dw)\n {\n+\tuint32_t array[2];\n \tint delays;\n \tint rc;\n \n \t/* Read delays from OTP */\n \tif ((rc = regmap_read(dw->otp, DW1000_OTP_DELAYS, &delays)) != 0)\n \t\treturn rc;\n-\tdw->antd[DW1000_PRF_16M] = DW1000_OTP_DELAYS_16M(delays);\n-\tdw->antd[DW1000_PRF_64M] = DW1000_OTP_DELAYS_64M(delays);\n+\tif (delays != ~0) {\n+\t\tdw->antd[DW1000_PRF_16M] = DW1000_OTP_DELAYS_16M(delays);\n+\t\tdw->antd[DW1000_PRF_64M] = DW1000_OTP_DELAYS_64M(delays);\n+\t}\n \n \t/* Read delays from devicetree */\n-\tof_property_read_u16_array(dw->dev->of_node, \"decawave,antd\",\n-\t\t\t\t   dw->antd, ARRAY_SIZE(dw->antd));\n+\tif (of_property_read_u32_array(dw->dev->of_node, \"decawave,antd\",\n+\t\t\t\t       array, ARRAY_SIZE(array)) == 0) {\n+\t\tif ((array[0] & ~DW1000_ANTD_MASK) || (array[1] & ~DW1000_ANTD_MASK)) {\n+\t\t\tdev_err(dw->dev, \"invalid decawave,antd value <%d,%d>\\n\",\n+\t\t\t\tarray[0], array[1]);\n+\t\t\treturn 0;\n+\t\t}\n+\t\tdw->antd[DW1000_PRF_16M] = array[0];\n+\t\tdw->antd[DW1000_PRF_64M] = array[1];\n+\t}","path":"kernel/dw1000.c","position":318,"original_position":142,"commit_id":"9710918ef798c6ac67324848c01fd18630819a90","original_commit_id":"2852f0494be5b098f55dc42092dca13d4a2b80bc","user":{"login":"mcb30","id":692245,"node_id":"MDQ6VXNlcjY5MjI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/692245?v=4","gravatar_id":"","url":"https://api.github.com/users/mcb30","html_url":"https://github.com/mcb30","followers_url":"https://api.github.com/users/mcb30/followers","following_url":"https://api.github.com/users/mcb30/following{/other_user}","gists_url":"https://api.github.com/users/mcb30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcb30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcb30/subscriptions","organizations_url":"https://api.github.com/users/mcb30/orgs","repos_url":"https://api.github.com/users/mcb30/repos","events_url":"https://api.github.com/users/mcb30/events{/privacy}","received_events_url":"https://api.github.com/users/mcb30/received_events","type":"User","site_admin":false},"body":"This commit should include the EEPROM generation update to match the new layout.","created_at":"2018-06-14T12:27:32Z","updated_at":"2018-06-14T12:27:32Z","html_url":"https://github.com/mcb30/dw1000/pull/12#discussion_r195402265","pull_request_url":"https://api.github.com/repos/mcb30/dw1000/pulls/12","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/comments/195402265"},"html":{"href":"https://github.com/mcb30/dw1000/pull/12#discussion_r195402265"},"pull_request":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/mcb30/dw1000/pulls/12","id":194872957,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODcyOTU3","html_url":"https://github.com/mcb30/dw1000/pull/12","diff_url":"https://github.com/mcb30/dw1000/pull/12.diff","patch_url":"https://github.com/mcb30/dw1000/pull/12.patch","issue_url":"https://api.github.com/repos/mcb30/dw1000/issues/12","number":12,"state":"open","locked":false,"title":"Pma/next","user":{"login":"pmattila","id":37797916,"node_id":"MDQ6VXNlcjM3Nzk3OTE2","avatar_url":"https://avatars2.githubusercontent.com/u/37797916?v=4","gravatar_id":"","url":"https://api.github.com/users/pmattila","html_url":"https://github.com/pmattila","followers_url":"https://api.github.com/users/pmattila/followers","following_url":"https://api.github.com/users/pmattila/following{/other_user}","gists_url":"https://api.github.com/users/pmattila/gists{/gist_id}","starred_url":"https://api.github.com/users/pmattila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmattila/subscriptions","organizations_url":"https://api.github.com/users/pmattila/orgs","repos_url":"https://api.github.com/users/pmattila/repos","events_url":"https://api.github.com/users/pmattila/events{/privacy}","received_events_url":"https://api.github.com/users/pmattila/received_events","type":"User","site_admin":false},"body":"Can you have. a look and comment please","created_at":"2018-06-14T12:14:31Z","updated_at":"2018-06-14T12:27:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"959622b7f3393547302384a77ee5904e82bb8a4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mcb30/dw1000/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mcb30/dw1000/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mcb30/dw1000/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mcb30/dw1000/issues/12/comments","statuses_url":"https://api.github.com/repos/mcb30/dw1000/statuses/9710918ef798c6ac67324848c01fd18630819a90","head":{"label":"mcb30:pma/next","ref":"pma/next","sha":"9710918ef798c6ac67324848c01fd18630819a90","user":{"login":"mcb30","id":692245,"node_id":"MDQ6VXNlcjY5MjI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/692245?v=4","gravatar_id":"","url":"https://api.github.com/users/mcb30","html_url":"https://github.com/mcb30","followers_url":"https://api.github.com/users/mcb30/followers","following_url":"https://api.github.com/users/mcb30/following{/other_user}","gists_url":"https://api.github.com/users/mcb30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcb30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcb30/subscriptions","organizations_url":"https://api.github.com/users/mcb30/orgs","repos_url":"https://api.github.com/users/mcb30/repos","events_url":"https://api.github.com/users/mcb30/events{/privacy}","received_events_url":"https://api.github.com/users/mcb30/received_events","type":"User","site_admin":false},"repo":{"id":124967819,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5Njc4MTk=","name":"dw1000","full_name":"mcb30/dw1000","owner":{"login":"mcb30","id":692245,"node_id":"MDQ6VXNlcjY5MjI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/692245?v=4","gravatar_id":"","url":"https://api.github.com/users/mcb30","html_url":"https://github.com/mcb30","followers_url":"https://api.github.com/users/mcb30/followers","following_url":"https://api.github.com/users/mcb30/following{/other_user}","gists_url":"https://api.github.com/users/mcb30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcb30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcb30/subscriptions","organizations_url":"https://api.github.com/users/mcb30/orgs","repos_url":"https://api.github.com/users/mcb30/repos","events_url":"https://api.github.com/users/mcb30/events{/privacy}","received_events_url":"https://api.github.com/users/mcb30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcb30/dw1000","description":"DecaWave DW1000 Linux kernel driver","fork":false,"url":"https://api.github.com/repos/mcb30/dw1000","forks_url":"https://api.github.com/repos/mcb30/dw1000/forks","keys_url":"https://api.github.com/repos/mcb30/dw1000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcb30/dw1000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcb30/dw1000/teams","hooks_url":"https://api.github.com/repos/mcb30/dw1000/hooks","issue_events_url":"https://api.github.com/repos/mcb30/dw1000/issues/events{/number}","events_url":"https://api.github.com/repos/mcb30/dw1000/events","assignees_url":"https://api.github.com/repos/mcb30/dw1000/assignees{/user}","branches_url":"https://api.github.com/repos/mcb30/dw1000/branches{/branch}","tags_url":"https://api.github.com/repos/mcb30/dw1000/tags","blobs_url":"https://api.github.com/repos/mcb30/dw1000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcb30/dw1000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcb30/dw1000/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcb30/dw1000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcb30/dw1000/statuses/{sha}","languages_url":"https://api.github.com/repos/mcb30/dw1000/languages","stargazers_url":"https://api.github.com/repos/mcb30/dw1000/stargazers","contributors_url":"https://api.github.com/repos/mcb30/dw1000/contributors","subscribers_url":"https://api.github.com/repos/mcb30/dw1000/subscribers","subscription_url":"https://api.github.com/repos/mcb30/dw1000/subscription","commits_url":"https://api.github.com/repos/mcb30/dw1000/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcb30/dw1000/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcb30/dw1000/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcb30/dw1000/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcb30/dw1000/contents/{+path}","compare_url":"https://api.github.com/repos/mcb30/dw1000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcb30/dw1000/merges","archive_url":"https://api.github.com/repos/mcb30/dw1000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcb30/dw1000/downloads","issues_url":"https://api.github.com/repos/mcb30/dw1000/issues{/number}","pulls_url":"https://api.github.com/repos/mcb30/dw1000/pulls{/number}","milestones_url":"https://api.github.com/repos/mcb30/dw1000/milestones{/number}","notifications_url":"https://api.github.com/repos/mcb30/dw1000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcb30/dw1000/labels{/name}","releases_url":"https://api.github.com/repos/mcb30/dw1000/releases{/id}","deployments_url":"https://api.github.com/repos/mcb30/dw1000/deployments","created_at":"2018-03-13T00:16:20Z","updated_at":"2018-05-21T16:12:25Z","pushed_at":"2018-06-14T12:14:32Z","git_url":"git://github.com/mcb30/dw1000.git","ssh_url":"git@github.com:mcb30/dw1000.git","clone_url":"https://github.com/mcb30/dw1000.git","svn_url":"https://github.com/mcb30/dw1000","homepage":null,"size":251,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mcb30:master","ref":"master","sha":"05c9a75912c59768a4925e0ec508873acd7c457e","user":{"login":"mcb30","id":692245,"node_id":"MDQ6VXNlcjY5MjI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/692245?v=4","gravatar_id":"","url":"https://api.github.com/users/mcb30","html_url":"https://github.com/mcb30","followers_url":"https://api.github.com/users/mcb30/followers","following_url":"https://api.github.com/users/mcb30/following{/other_user}","gists_url":"https://api.github.com/users/mcb30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcb30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcb30/subscriptions","organizations_url":"https://api.github.com/users/mcb30/orgs","repos_url":"https://api.github.com/users/mcb30/repos","events_url":"https://api.github.com/users/mcb30/events{/privacy}","received_events_url":"https://api.github.com/users/mcb30/received_events","type":"User","site_admin":false},"repo":{"id":124967819,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5Njc4MTk=","name":"dw1000","full_name":"mcb30/dw1000","owner":{"login":"mcb30","id":692245,"node_id":"MDQ6VXNlcjY5MjI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/692245?v=4","gravatar_id":"","url":"https://api.github.com/users/mcb30","html_url":"https://github.com/mcb30","followers_url":"https://api.github.com/users/mcb30/followers","following_url":"https://api.github.com/users/mcb30/following{/other_user}","gists_url":"https://api.github.com/users/mcb30/gists{/gist_id}","starred_url":"https://api.github.com/users/mcb30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcb30/subscriptions","organizations_url":"https://api.github.com/users/mcb30/orgs","repos_url":"https://api.github.com/users/mcb30/repos","events_url":"https://api.github.com/users/mcb30/events{/privacy}","received_events_url":"https://api.github.com/users/mcb30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcb30/dw1000","description":"DecaWave DW1000 Linux kernel driver","fork":false,"url":"https://api.github.com/repos/mcb30/dw1000","forks_url":"https://api.github.com/repos/mcb30/dw1000/forks","keys_url":"https://api.github.com/repos/mcb30/dw1000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcb30/dw1000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcb30/dw1000/teams","hooks_url":"https://api.github.com/repos/mcb30/dw1000/hooks","issue_events_url":"https://api.github.com/repos/mcb30/dw1000/issues/events{/number}","events_url":"https://api.github.com/repos/mcb30/dw1000/events","assignees_url":"https://api.github.com/repos/mcb30/dw1000/assignees{/user}","branches_url":"https://api.github.com/repos/mcb30/dw1000/branches{/branch}","tags_url":"https://api.github.com/repos/mcb30/dw1000/tags","blobs_url":"https://api.github.com/repos/mcb30/dw1000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcb30/dw1000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcb30/dw1000/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcb30/dw1000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcb30/dw1000/statuses/{sha}","languages_url":"https://api.github.com/repos/mcb30/dw1000/languages","stargazers_url":"https://api.github.com/repos/mcb30/dw1000/stargazers","contributors_url":"https://api.github.com/repos/mcb30/dw1000/contributors","subscribers_url":"https://api.github.com/repos/mcb30/dw1000/subscribers","subscription_url":"https://api.github.com/repos/mcb30/dw1000/subscription","commits_url":"https://api.github.com/repos/mcb30/dw1000/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcb30/dw1000/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcb30/dw1000/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcb30/dw1000/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcb30/dw1000/contents/{+path}","compare_url":"https://api.github.com/repos/mcb30/dw1000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcb30/dw1000/merges","archive_url":"https://api.github.com/repos/mcb30/dw1000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcb30/dw1000/downloads","issues_url":"https://api.github.com/repos/mcb30/dw1000/issues{/number}","pulls_url":"https://api.github.com/repos/mcb30/dw1000/pulls{/number}","milestones_url":"https://api.github.com/repos/mcb30/dw1000/milestones{/number}","notifications_url":"https://api.github.com/repos/mcb30/dw1000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcb30/dw1000/labels{/name}","releases_url":"https://api.github.com/repos/mcb30/dw1000/releases{/id}","deployments_url":"https://api.github.com/repos/mcb30/dw1000/deployments","created_at":"2018-03-13T00:16:20Z","updated_at":"2018-05-21T16:12:25Z","pushed_at":"2018-06-14T12:14:32Z","git_url":"git://github.com/mcb30/dw1000.git","ssh_url":"git@github.com:mcb30/dw1000.git","clone_url":"https://github.com/mcb30/dw1000.git","svn_url":"https://github.com/mcb30/dw1000","homepage":null,"size":251,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/12"},"html":{"href":"https://github.com/mcb30/dw1000/pull/12"},"issue":{"href":"https://api.github.com/repos/mcb30/dw1000/issues/12"},"comments":{"href":"https://api.github.com/repos/mcb30/dw1000/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mcb30/dw1000/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mcb30/dw1000/statuses/9710918ef798c6ac67324848c01fd18630819a90"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mcb30"}}