{"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/225455566","pull_request_review_id":165055599,"id":225455566,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ1NTU2Ng==","diff_hunk":"@@ -0,0 +1,33 @@\n+//\n+//  MyRect.swift\n+//  CoordinateCalculator\n+//\n+//  Created by 윤지영 on 16/10/2018.\n+//  Copyright © 2018 Codesquad Inc. All rights reserved.\n+//\n+\n+import Foundation\n+\n+struct MyRect: CalculableShape {\n+    private var leftTop = MyPoint(x: 0, y: 0)\n+    private var rightBottom = MyPoint(x: 0, y: 0)\n+    \n+    init(origin: MyPoint, size: CGSize) {\n+        self.leftTop = origin\n+        self.rightBottom = MyPoint(x: leftTop.x + Int(size.width), y: leftTop.y - Int(size.height))\n+    }","path":"CoordinateCalculator/CoordinateCalculator/MyRect.swift","position":18,"original_position":18,"commit_id":"6af27326d9599efba055bacb28f7ffe57914f0a7","original_commit_id":"3ccbfee370e258c8ad14a53009f1082fabd7ff0c","user":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"body":"- 다른 도형 구조체와 마찬가지로 `MyPoint` 배열로 생성할 수 있도록 추가 생성자를 만들었습니다.\r\n- `ShapeGenerator.generateShape()` 에서 추가로 만든 `init(points: [MyPoint])` 로 `MyRect` 를 리턴하도록 수정했습니다. 메소드는 추가하지 않고, 기존 생성자 `CGSize` 를 넘겨주기 위해 처리하던 부분을 `MyRect` 구조체 내부로 옮겨 적용했습니다. 사실 상 처리하는 로직은 동일하다고 볼 수 있지만, 다른 도형들과 동일하게 생성자를 두는 것이 편리할 것이라 생각해 이렇게 수정했습니다. \r\n- 현재 프로그램 흐름에서 기존 `init(origin: MyPoint, size: CGSize)` 생성자는 사용되지 않지만, 두 생성초기화 메소드가 다른 의미를 가지고 있다고 생각하여 삭제하지 않았습니다. ","created_at":"2018-10-16T09:05:14Z","updated_at":"2018-10-16T09:05:14Z","html_url":"https://github.com/code-squad/swift-coordinate/pull/125#discussion_r225455566","pull_request_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments/225455566"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/125#discussion_r225455566"},"pull_request":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125"}},"in_reply_to_id":225442121},"pull_request":{"url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125","id":223153053,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTUzMDUz","html_url":"https://github.com/code-squad/swift-coordinate/pull/125","diff_url":"https://github.com/code-squad/swift-coordinate/pull/125.diff","patch_url":"https://github.com/code-squad/swift-coordinate/pull/125.patch","issue_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/125","number":125,"state":"open","locked":false,"title":"좌표계산기 5단계 - 사각형 입력과 출력","user":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"body":"- `MyRect` 구조체를 추가했습니다.\r\n- `ShapeGenerator.generateShape()` 메소드에 `MyRect` 을 리턴하는 경우를 추가했습니다.\r\n- `ShapeGenerator` 구조체에서 검사하는 기능을 가진 메소드를 따로 분리하여 `ShapeValidator` 구조체를 생성했습니다.  \r\n- 추가된 내용에 대한 단위테스트를 생성했습니다.","created_at":"2018-10-16T08:11:36Z","updated_at":"2018-10-16T09:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d69db05e0a277087331ce4994dfb70e67f1fda8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125/commits","review_comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125/comments","review_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/125/comments","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/6af27326d9599efba055bacb28f7ffe57914f0a7","head":{"label":"popsmile:coordinate-step5","ref":"coordinate-step5","sha":"6af27326d9599efba055bacb28f7ffe57914f0a7","user":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"repo":{"id":151522806,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MjI4MDY=","name":"swift-coordinate","full_name":"popsmile/swift-coordinate","private":false,"owner":{"login":"popsmile","id":29696471,"node_id":"MDQ6VXNlcjI5Njk2NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/29696471?v=4","gravatar_id":"","url":"https://api.github.com/users/popsmile","html_url":"https://github.com/popsmile","followers_url":"https://api.github.com/users/popsmile/followers","following_url":"https://api.github.com/users/popsmile/following{/other_user}","gists_url":"https://api.github.com/users/popsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/popsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popsmile/subscriptions","organizations_url":"https://api.github.com/users/popsmile/orgs","repos_url":"https://api.github.com/users/popsmile/repos","events_url":"https://api.github.com/users/popsmile/events{/privacy}","received_events_url":"https://api.github.com/users/popsmile/received_events","type":"User","site_admin":false},"html_url":"https://github.com/popsmile/swift-coordinate","description":"좌표계산기_저장소","fork":true,"url":"https://api.github.com/repos/popsmile/swift-coordinate","forks_url":"https://api.github.com/repos/popsmile/swift-coordinate/forks","keys_url":"https://api.github.com/repos/popsmile/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popsmile/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popsmile/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/popsmile/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/popsmile/swift-coordinate/events","assignees_url":"https://api.github.com/repos/popsmile/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/popsmile/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/popsmile/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popsmile/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/popsmile/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/popsmile/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/popsmile/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/popsmile/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/popsmile/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/popsmile/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/popsmile/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/popsmile/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/popsmile/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/popsmile/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popsmile/swift-coordinate/merges","archive_url":"https://api.github.com/repos/popsmile/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popsmile/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/popsmile/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/popsmile/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/popsmile/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/popsmile/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popsmile/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/popsmile/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/popsmile/swift-coordinate/deployments","created_at":"2018-10-04T05:27:39Z","updated_at":"2018-10-04T05:27:41Z","pushed_at":"2018-10-16T08:57:38Z","git_url":"git://github.com/popsmile/swift-coordinate.git","ssh_url":"git@github.com:popsmile/swift-coordinate.git","clone_url":"https://github.com/popsmile/swift-coordinate.git","svn_url":"https://github.com/popsmile/swift-coordinate","homepage":null,"size":3638,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:popsmile","ref":"popsmile","sha":"1e263c9ad85884c1cd352b963f1fe936afa945ca","user":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":106258411,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyNTg0MTE=","name":"swift-coordinate","full_name":"code-squad/swift-coordinate","private":false,"owner":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-squad/swift-coordinate","description":"좌표계산기_저장소","fork":false,"url":"https://api.github.com/repos/code-squad/swift-coordinate","forks_url":"https://api.github.com/repos/code-squad/swift-coordinate/forks","keys_url":"https://api.github.com/repos/code-squad/swift-coordinate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/swift-coordinate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/swift-coordinate/teams","hooks_url":"https://api.github.com/repos/code-squad/swift-coordinate/hooks","issue_events_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/swift-coordinate/events","assignees_url":"https://api.github.com/repos/code-squad/swift-coordinate/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/swift-coordinate/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/tags","blobs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/swift-coordinate/languages","stargazers_url":"https://api.github.com/repos/code-squad/swift-coordinate/stargazers","contributors_url":"https://api.github.com/repos/code-squad/swift-coordinate/contributors","subscribers_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscribers","subscription_url":"https://api.github.com/repos/code-squad/swift-coordinate/subscription","commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/swift-coordinate/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/swift-coordinate/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/swift-coordinate/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/swift-coordinate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/swift-coordinate/merges","archive_url":"https://api.github.com/repos/code-squad/swift-coordinate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/swift-coordinate/downloads","issues_url":"https://api.github.com/repos/code-squad/swift-coordinate/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/swift-coordinate/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/swift-coordinate/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/swift-coordinate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/swift-coordinate/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/swift-coordinate/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/swift-coordinate/deployments","created_at":"2017-10-09T08:45:05Z","updated_at":"2018-07-12T09:09:19Z","pushed_at":"2018-10-16T08:57:39Z","git_url":"git://github.com/code-squad/swift-coordinate.git","ssh_url":"git@github.com:code-squad/swift-coordinate.git","clone_url":"https://github.com/code-squad/swift-coordinate.git","svn_url":"https://github.com/code-squad/swift-coordinate","homepage":null,"size":3623,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":25,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125"},"html":{"href":"https://github.com/code-squad/swift-coordinate/pull/125"},"issue":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/125"},"comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/swift-coordinate/statuses/6af27326d9599efba055bacb28f7ffe57914f0a7"}},"author_association":"NONE"}}
{"actor":{"display_login":"popsmile"}}