{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/170712475","pull_request_review_id":99440256,"id":170712475,"diff_hunk":"@@ -901,6 +902,7 @@\n \t\t459311FB1D75C948008DD4F0 /* OWSDeviceTableViewCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OWSDeviceTableViewCell.m; sourceTree = \"<group>\"; };\n \t\t4597E94E1D8313C100040CDE /* sq */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sq; path = translations/sq.lproj/Localizable.strings; sourceTree = \"<group>\"; };\n \t\t4597E94F1D8313CB00040CDE /* bg */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = bg; path = translations/bg.lproj/Localizable.strings; sourceTree = \"<group>\"; };\n+\t\t45A2F004204473A3002E978A /* NewMessage.aifc */ = {isa = PBXFileReference; lastKnownFileType = file; name = NewMessage.aifc; path = Signal/AudioFiles/NewMessage.aifc; sourceTree = SOURCE_ROOT; };","path":"Signal.xcodeproj/project.pbxproj","position":193,"original_position":12,"commit_id":"ccc08bbe9d7ba48bbf67b44c3f8faa3e82464999","original_commit_id":"ccc08bbe9d7ba48bbf67b44c3f8faa3e82464999","user":{"login":"charlesmchen","id":625803,"avatar_url":"https://avatars1.githubusercontent.com/u/625803?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen","html_url":"https://github.com/charlesmchen","followers_url":"https://api.github.com/users/charlesmchen/followers","following_url":"https://api.github.com/users/charlesmchen/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen/orgs","repos_url":"https://api.github.com/users/charlesmchen/repos","events_url":"https://api.github.com/users/charlesmchen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen/received_events","type":"User","site_admin":false},"body":"It's weird you had to add this - I thought I already had this file in the project.  Or is this an additional copy?","created_at":"2018-02-26T19:45:05Z","updated_at":"2018-02-26T19:45:05Z","html_url":"https://github.com/signalapp/Signal-iOS/pull/3064#discussion_r170712475","pull_request_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/170712475"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3064#discussion_r170712475"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064"}}},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064","id":171465389,"html_url":"https://github.com/signalapp/Signal-iOS/pull/3064","diff_url":"https://github.com/signalapp/Signal-iOS/pull/3064.diff","patch_url":"https://github.com/signalapp/Signal-iOS/pull/3064.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3064","number":3064,"state":"open","locked":false,"title":"fall back push notifications respect the configured notification sound ","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars3.githubusercontent.com/u/217057?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/signalapp/Signal-iOS/pull/3054 so merge that first.","created_at":"2018-02-26T19:14:20Z","updated_at":"2018-02-26T19:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10c926f5c2107c159d5da4da9a61c7c37fdd0382","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3064/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/ccc08bbe9d7ba48bbf67b44c3f8faa3e82464999","head":{"label":"signalapp:mkirk/default-audio-fallback-push","ref":"mkirk/default-audio-fallback-push","sha":"ccc08bbe9d7ba48bbf67b44c3f8faa3e82464999","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-02-26T16:44:51Z","pushed_at":"2018-02-26T19:14:57Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":453622,"stargazers_count":3173,"watchers_count":3173,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":757,"mirror_url":null,"archived":false,"open_issues_count":356,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":757,"open_issues":356,"watchers":3173,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"f0e1cea27c447ebced0109de23235447d8e5ea99","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-02-26T16:44:51Z","pushed_at":"2018-02-26T19:14:57Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":453622,"stargazers_count":3173,"watchers_count":3173,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":757,"mirror_url":null,"archived":false,"open_issues_count":356,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":757,"open_issues":356,"watchers":3173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3064"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3064"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3064/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3064/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/ccc08bbe9d7ba48bbf67b44c3f8faa3e82464999"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"charlesmchen"}}