{"action":"created","comment":{"url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/comments/215167607","pull_request_review_id":152372583,"id":215167607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTE2NzYwNw==","diff_hunk":"@@ -595,7 +608,12 @@ public AttributeEntry(JpaProvider jpaProvider, ManagedType<X> ownerType, Attribu\n             JpaProvider.ConstraintType[] requiresTreatFilter = new JpaProvider.ConstraintType[joinTypes.length];\n             if (ownerType instanceof EntityType<?>) {\n                 EntityType<?> entityType = (EntityType<?>) ownerType;\n-                this.isForeignJoinColumn = jpaProvider.isForeignJoinColumn(entityType, attributeName);\n+                try {\n+                    this.isForeignJoinColumn = jpaProvider.isForeignJoinColumn(entityType, attributeName);\n+                }\n+                catch (Exception e) {","path":"core/impl/src/main/java/com/blazebit/persistence/impl/EntityMetamodelImpl.java","position":53,"original_position":53,"commit_id":"007a05ba58dc9f4cab5c4156d326e3fc7e2f4877","original_commit_id":"007a05ba58dc9f4cab5c4156d326e3fc7e2f4877","user":{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"body":"I suppose you will remove this later and this is just for testing?","created_at":"2018-09-05T07:52:03Z","updated_at":"2018-09-05T07:52:03Z","html_url":"https://github.com/Blazebit/blaze-persistence/pull/655#discussion_r215167607","pull_request_url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/comments/215167607"},"html":{"href":"https://github.com/Blazebit/blaze-persistence/pull/655#discussion_r215167607"},"pull_request":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655"}}},"pull_request":{"url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655","id":213043879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDQzODc5","html_url":"https://github.com/Blazebit/blaze-persistence/pull/655","diff_url":"https://github.com/Blazebit/blaze-persistence/pull/655.diff","patch_url":"https://github.com/Blazebit/blaze-persistence/pull/655.patch","issue_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/655","number":655,"state":"open","locked":false,"title":"[Work in progress ] Various fixes for binding associations in CTE's, fixes #571","user":{"login":"JWGmeligMeyling","id":3469492,"node_id":"MDQ6VXNlcjM0Njk0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3469492?v=4","gravatar_id":"","url":"https://api.github.com/users/JWGmeligMeyling","html_url":"https://github.com/JWGmeligMeyling","followers_url":"https://api.github.com/users/JWGmeligMeyling/followers","following_url":"https://api.github.com/users/JWGmeligMeyling/following{/other_user}","gists_url":"https://api.github.com/users/JWGmeligMeyling/gists{/gist_id}","starred_url":"https://api.github.com/users/JWGmeligMeyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JWGmeligMeyling/subscriptions","organizations_url":"https://api.github.com/users/JWGmeligMeyling/orgs","repos_url":"https://api.github.com/users/JWGmeligMeyling/repos","events_url":"https://api.github.com/users/JWGmeligMeyling/events{/privacy}","received_events_url":"https://api.github.com/users/JWGmeligMeyling/received_events","type":"User","site_admin":false},"body":"* Support for binding associations that are (part of) the entity id\r\n* Support for binding nested id class attributes (i.e. multiple referenced id attributes in the referenced entity)\r\n* Support for binding associations by foreign key\r\n* Support for binding multi column associations (this had issues as cte's columns and attributes got confused before)\r\n\r\nSide note:\r\n\r\nBecause I now use the CTE's column names  as actual column names, rather than the attribute names (which won't work for multi column associations, as they reference the same attribute and would have the same name ), some older tests that expect the attribute as column name now fail. Please review my approach and I will alter these tests accordingly.\r\n\r\n<!--- This template is for code related PRs. Remove it for e.g. documentation PRs. -->\r\n\r\n<!--- Prefix the title with the issue number like \"[#123] Some title\" and try to summarize the changes in the title -->\r\n\r\n<!--- Before submitting the PR, please make sure it satisfies the following guidelines -->\r\n<!---  * Tests for issues should have one commit that has the form \"Test for #123\" where \"#123\" is the issue number -->\r\n<!---  * Fixes for issues should have one commit that has the form \"Fix for #123\" where \"#123\" is the issue number -->\r\n<!---  * Commits for the test and the fix should be separate -->\r\n\r\n## Description\r\n<!--- Give an overview of what you changed -->\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue(s) here: -->\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n","created_at":"2018-09-04T17:03:45Z","updated_at":"2018-09-05T07:52:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"379bd14bb37f48b3758ebf7543ea0b1235332bd4","assignee":{"login":"JWGmeligMeyling","id":3469492,"node_id":"MDQ6VXNlcjM0Njk0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3469492?v=4","gravatar_id":"","url":"https://api.github.com/users/JWGmeligMeyling","html_url":"https://github.com/JWGmeligMeyling","followers_url":"https://api.github.com/users/JWGmeligMeyling/followers","following_url":"https://api.github.com/users/JWGmeligMeyling/following{/other_user}","gists_url":"https://api.github.com/users/JWGmeligMeyling/gists{/gist_id}","starred_url":"https://api.github.com/users/JWGmeligMeyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JWGmeligMeyling/subscriptions","organizations_url":"https://api.github.com/users/JWGmeligMeyling/orgs","repos_url":"https://api.github.com/users/JWGmeligMeyling/repos","events_url":"https://api.github.com/users/JWGmeligMeyling/events{/privacy}","received_events_url":"https://api.github.com/users/JWGmeligMeyling/received_events","type":"User","site_admin":false},"assignees":[{"login":"JWGmeligMeyling","id":3469492,"node_id":"MDQ6VXNlcjM0Njk0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3469492?v=4","gravatar_id":"","url":"https://api.github.com/users/JWGmeligMeyling","html_url":"https://github.com/JWGmeligMeyling","followers_url":"https://api.github.com/users/JWGmeligMeyling/followers","following_url":"https://api.github.com/users/JWGmeligMeyling/following{/other_user}","gists_url":"https://api.github.com/users/JWGmeligMeyling/gists{/gist_id}","starred_url":"https://api.github.com/users/JWGmeligMeyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JWGmeligMeyling/subscriptions","organizations_url":"https://api.github.com/users/JWGmeligMeyling/orgs","repos_url":"https://api.github.com/users/JWGmeligMeyling/repos","events_url":"https://api.github.com/users/JWGmeligMeyling/events{/privacy}","received_events_url":"https://api.github.com/users/JWGmeligMeyling/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655/commits","review_comments_url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655/comments","review_comment_url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/655/comments","statuses_url":"https://api.github.com/repos/Blazebit/blaze-persistence/statuses/007a05ba58dc9f4cab5c4156d326e3fc7e2f4877","head":{"label":"JWGmeligMeyling:issue-571","ref":"issue-571","sha":"007a05ba58dc9f4cab5c4156d326e3fc7e2f4877","user":{"login":"JWGmeligMeyling","id":3469492,"node_id":"MDQ6VXNlcjM0Njk0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3469492?v=4","gravatar_id":"","url":"https://api.github.com/users/JWGmeligMeyling","html_url":"https://github.com/JWGmeligMeyling","followers_url":"https://api.github.com/users/JWGmeligMeyling/followers","following_url":"https://api.github.com/users/JWGmeligMeyling/following{/other_user}","gists_url":"https://api.github.com/users/JWGmeligMeyling/gists{/gist_id}","starred_url":"https://api.github.com/users/JWGmeligMeyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JWGmeligMeyling/subscriptions","organizations_url":"https://api.github.com/users/JWGmeligMeyling/orgs","repos_url":"https://api.github.com/users/JWGmeligMeyling/repos","events_url":"https://api.github.com/users/JWGmeligMeyling/events{/privacy}","received_events_url":"https://api.github.com/users/JWGmeligMeyling/received_events","type":"User","site_admin":false},"repo":{"id":67874346,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzg3NDM0Ng==","name":"blaze-persistence","full_name":"JWGmeligMeyling/blaze-persistence","owner":{"login":"JWGmeligMeyling","id":3469492,"node_id":"MDQ6VXNlcjM0Njk0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3469492?v=4","gravatar_id":"","url":"https://api.github.com/users/JWGmeligMeyling","html_url":"https://github.com/JWGmeligMeyling","followers_url":"https://api.github.com/users/JWGmeligMeyling/followers","following_url":"https://api.github.com/users/JWGmeligMeyling/following{/other_user}","gists_url":"https://api.github.com/users/JWGmeligMeyling/gists{/gist_id}","starred_url":"https://api.github.com/users/JWGmeligMeyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JWGmeligMeyling/subscriptions","organizations_url":"https://api.github.com/users/JWGmeligMeyling/orgs","repos_url":"https://api.github.com/users/JWGmeligMeyling/repos","events_url":"https://api.github.com/users/JWGmeligMeyling/events{/privacy}","received_events_url":"https://api.github.com/users/JWGmeligMeyling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JWGmeligMeyling/blaze-persistence","description":null,"fork":true,"url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence","forks_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/forks","keys_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/teams","hooks_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/hooks","issue_events_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/issues/events{/number}","events_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/events","assignees_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/assignees{/user}","branches_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/branches{/branch}","tags_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/tags","blobs_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/git/refs{/sha}","trees_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/statuses/{sha}","languages_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/languages","stargazers_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/stargazers","contributors_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/contributors","subscribers_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/subscribers","subscription_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/subscription","commits_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/commits{/sha}","git_commits_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/git/commits{/sha}","comments_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/comments{/number}","issue_comment_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/issues/comments{/number}","contents_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/contents/{+path}","compare_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/merges","archive_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/downloads","issues_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/issues{/number}","pulls_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/pulls{/number}","milestones_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/milestones{/number}","notifications_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/labels{/name}","releases_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/releases{/id}","deployments_url":"https://api.github.com/repos/JWGmeligMeyling/blaze-persistence/deployments","created_at":"2016-09-10T14:05:42Z","updated_at":"2018-08-06T09:35:27Z","pushed_at":"2018-09-04T22:05:59Z","git_url":"git://github.com/JWGmeligMeyling/blaze-persistence.git","ssh_url":"git@github.com:JWGmeligMeyling/blaze-persistence.git","clone_url":"https://github.com/JWGmeligMeyling/blaze-persistence.git","svn_url":"https://github.com/JWGmeligMeyling/blaze-persistence","homepage":null,"size":14989,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Blazebit:master","ref":"master","sha":"a03c25ff9619e8e364ac03d60ca31bb9c1d2befb","user":{"login":"Blazebit","id":647764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0Nzc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/647764?v=4","gravatar_id":"","url":"https://api.github.com/users/Blazebit","html_url":"https://github.com/Blazebit","followers_url":"https://api.github.com/users/Blazebit/followers","following_url":"https://api.github.com/users/Blazebit/following{/other_user}","gists_url":"https://api.github.com/users/Blazebit/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazebit/subscriptions","organizations_url":"https://api.github.com/users/Blazebit/orgs","repos_url":"https://api.github.com/users/Blazebit/repos","events_url":"https://api.github.com/users/Blazebit/events{/privacy}","received_events_url":"https://api.github.com/users/Blazebit/received_events","type":"Organization","site_admin":false},"repo":{"id":21765334,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2NTMzNA==","name":"blaze-persistence","full_name":"Blazebit/blaze-persistence","owner":{"login":"Blazebit","id":647764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0Nzc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/647764?v=4","gravatar_id":"","url":"https://api.github.com/users/Blazebit","html_url":"https://github.com/Blazebit","followers_url":"https://api.github.com/users/Blazebit/followers","following_url":"https://api.github.com/users/Blazebit/following{/other_user}","gists_url":"https://api.github.com/users/Blazebit/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazebit/subscriptions","organizations_url":"https://api.github.com/users/Blazebit/orgs","repos_url":"https://api.github.com/users/Blazebit/repos","events_url":"https://api.github.com/users/Blazebit/events{/privacy}","received_events_url":"https://api.github.com/users/Blazebit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazebit/blaze-persistence","description":"Rich Criteria API for JPA providers","fork":false,"url":"https://api.github.com/repos/Blazebit/blaze-persistence","forks_url":"https://api.github.com/repos/Blazebit/blaze-persistence/forks","keys_url":"https://api.github.com/repos/Blazebit/blaze-persistence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazebit/blaze-persistence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazebit/blaze-persistence/teams","hooks_url":"https://api.github.com/repos/Blazebit/blaze-persistence/hooks","issue_events_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/events{/number}","events_url":"https://api.github.com/repos/Blazebit/blaze-persistence/events","assignees_url":"https://api.github.com/repos/Blazebit/blaze-persistence/assignees{/user}","branches_url":"https://api.github.com/repos/Blazebit/blaze-persistence/branches{/branch}","tags_url":"https://api.github.com/repos/Blazebit/blaze-persistence/tags","blobs_url":"https://api.github.com/repos/Blazebit/blaze-persistence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazebit/blaze-persistence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazebit/blaze-persistence/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazebit/blaze-persistence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazebit/blaze-persistence/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazebit/blaze-persistence/languages","stargazers_url":"https://api.github.com/repos/Blazebit/blaze-persistence/stargazers","contributors_url":"https://api.github.com/repos/Blazebit/blaze-persistence/contributors","subscribers_url":"https://api.github.com/repos/Blazebit/blaze-persistence/subscribers","subscription_url":"https://api.github.com/repos/Blazebit/blaze-persistence/subscription","commits_url":"https://api.github.com/repos/Blazebit/blaze-persistence/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazebit/blaze-persistence/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazebit/blaze-persistence/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazebit/blaze-persistence/contents/{+path}","compare_url":"https://api.github.com/repos/Blazebit/blaze-persistence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazebit/blaze-persistence/merges","archive_url":"https://api.github.com/repos/Blazebit/blaze-persistence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazebit/blaze-persistence/downloads","issues_url":"https://api.github.com/repos/Blazebit/blaze-persistence/issues{/number}","pulls_url":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazebit/blaze-persistence/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazebit/blaze-persistence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazebit/blaze-persistence/labels{/name}","releases_url":"https://api.github.com/repos/Blazebit/blaze-persistence/releases{/id}","deployments_url":"https://api.github.com/repos/Blazebit/blaze-persistence/deployments","created_at":"2014-07-12T11:08:47Z","updated_at":"2018-09-03T09:16:04Z","pushed_at":"2018-09-04T22:06:00Z","git_url":"git://github.com/Blazebit/blaze-persistence.git","ssh_url":"git@github.com:Blazebit/blaze-persistence.git","clone_url":"https://github.com/Blazebit/blaze-persistence.git","svn_url":"https://github.com/Blazebit/blaze-persistence","homepage":"https://persistence.blazebit.com","size":14882,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":141,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655"},"html":{"href":"https://github.com/Blazebit/blaze-persistence/pull/655"},"issue":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/655"},"comments":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/Blazebit/blaze-persistence/statuses/007a05ba58dc9f4cab5c4156d326e3fc7e2f4877"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"beikov"}}