{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/198798044","pull_request_review_id":132790272,"id":198798044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODc5ODA0NA==","diff_hunk":"@@ -130,12 +131,15 @@ public static VersionStatus compute(Controller controller) {\n         ListMap<Version, HostName> versions = new ListMap<>();\n         for (ZoneId zone : zones) {\n             for (SystemApplication application : SystemApplication.all()) {\n-                if (!application.configConvergedIn(zone, controller)) {\n-                    throw new IllegalStateException(\"Config for \" + application.id() + \" in \" + zone + \" has not converged\");\n+                boolean configConverged = application.configConvergedIn(zone, controller);\n+                if (!configConverged) {\n+                    log.log(LogLevel.WARNING, \"Config for \" + application.id() + \" in \" + zone + \" has not converged\");","path":"controller-server/src/main/java/com/yahoo/vespa/hosted/controller/versions/VersionStatus.java","position":16,"original_position":16,"commit_id":"29e336c54dc390a6eee28daad7abe3ff23696f58","original_commit_id":"29e336c54dc390a6eee28daad7abe3ff23696f58","user":{"login":"jonmv","id":7009557,"node_id":"MDQ6VXNlcjcwMDk1NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7009557?v=4","gravatar_id":"","url":"https://api.github.com/users/jonmv","html_url":"https://github.com/jonmv","followers_url":"https://api.github.com/users/jonmv/followers","following_url":"https://api.github.com/users/jonmv/following{/other_user}","gists_url":"https://api.github.com/users/jonmv/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmv/subscriptions","organizations_url":"https://api.github.com/users/jonmv/orgs","repos_url":"https://api.github.com/users/jonmv/repos","events_url":"https://api.github.com/users/jonmv/events{/privacy}","received_events_url":"https://api.github.com/users/jonmv/received_events","type":"User","site_admin":false},"body":"Are you sure this is really a WARNING? ","created_at":"2018-06-28T10:49:00Z","updated_at":"2018-06-28T10:49:00Z","html_url":"https://github.com/vespa-engine/vespa/pull/6306#discussion_r198798044","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/198798044"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6306#discussion_r198798044"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306"}}},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306","id":197970930,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTcwOTMw","html_url":"https://github.com/vespa-engine/vespa/pull/6306","diff_url":"https://github.com/vespa-engine/vespa/pull/6306.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/6306.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6306","number":6306,"state":"open","locked":false,"title":"Use current system version for non-converging system applications","user":{"login":"mpolden","id":174496,"node_id":"MDQ6VXNlcjE3NDQ5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/174496?v=4","gravatar_id":"","url":"https://api.github.com/users/mpolden","html_url":"https://github.com/mpolden","followers_url":"https://api.github.com/users/mpolden/followers","following_url":"https://api.github.com/users/mpolden/following{/other_user}","gists_url":"https://api.github.com/users/mpolden/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolden/subscriptions","organizations_url":"https://api.github.com/users/mpolden/orgs","repos_url":"https://api.github.com/users/mpolden/repos","events_url":"https://api.github.com/users/mpolden/events{/privacy}","received_events_url":"https://api.github.com/users/mpolden/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-06-28T09:34:39Z","updated_at":"2018-06-28T10:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42f52a2d8119921879fdcdbf2e056f8476ccdf76","assignee":{"login":"mpolden","id":174496,"node_id":"MDQ6VXNlcjE3NDQ5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/174496?v=4","gravatar_id":"","url":"https://api.github.com/users/mpolden","html_url":"https://github.com/mpolden","followers_url":"https://api.github.com/users/mpolden/followers","following_url":"https://api.github.com/users/mpolden/following{/other_user}","gists_url":"https://api.github.com/users/mpolden/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolden/subscriptions","organizations_url":"https://api.github.com/users/mpolden/orgs","repos_url":"https://api.github.com/users/mpolden/repos","events_url":"https://api.github.com/users/mpolden/events{/privacy}","received_events_url":"https://api.github.com/users/mpolden/received_events","type":"User","site_admin":false},"assignees":[{"login":"mpolden","id":174496,"node_id":"MDQ6VXNlcjE3NDQ5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/174496?v=4","gravatar_id":"","url":"https://api.github.com/users/mpolden","html_url":"https://github.com/mpolden","followers_url":"https://api.github.com/users/mpolden/followers","following_url":"https://api.github.com/users/mpolden/following{/other_user}","gists_url":"https://api.github.com/users/mpolden/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolden/subscriptions","organizations_url":"https://api.github.com/users/mpolden/orgs","repos_url":"https://api.github.com/users/mpolden/repos","events_url":"https://api.github.com/users/mpolden/events{/privacy}","received_events_url":"https://api.github.com/users/mpolden/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6306/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/29e336c54dc390a6eee28daad7abe3ff23696f58","head":{"label":"vespa-engine:mpolden/keep-version-for-non-converging-system-app","ref":"mpolden/keep-version-for-non-converging-system-app","sha":"29e336c54dc390a6eee28daad7abe3ff23696f58","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-06-27T17:41:07Z","pushed_at":"2018-06-28T09:34:40Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":70491,"stargazers_count":2529,"watchers_count":2529,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":295,"open_issues":49,"watchers":2529,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"25d20ee1cdf3b28f867ad55a5436e1aac65ccc84","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-06-27T17:41:07Z","pushed_at":"2018-06-28T09:34:40Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":70491,"stargazers_count":2529,"watchers_count":2529,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":295,"open_issues":49,"watchers":2529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6306"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6306"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6306/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6306/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/29e336c54dc390a6eee28daad7abe3ff23696f58"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jonmv"}}