{"action":"opened","number":133,"pull_request":{"url":"https://api.github.com/repos/johnynek/bosatsu/pulls/133","id":237100274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTAwMjc0","html_url":"https://github.com/johnynek/bosatsu/pull/133","diff_url":"https://github.com/johnynek/bosatsu/pull/133.diff","patch_url":"https://github.com/johnynek/bosatsu/pull/133.patch","issue_url":"https://api.github.com/repos/johnynek/bosatsu/issues/133","number":133,"state":"open","locked":false,"title":"Track regions when doing type inference","user":{"login":"johnynek","id":67958,"node_id":"MDQ6VXNlcjY3OTU4","avatar_url":"https://avatars0.githubusercontent.com/u/67958?v=4","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"When we moved to the rankn type inference, we lost the tracking of regions where types are inferred.\r\n\r\nHere is an example now with an error added to euler4.bosatsu\r\n```\r\nin file: test_workspace/euler4.bosatsu, package Euler/Four, type Bosatsu/Predef#String does not unify with type Bosatsu/Predef#Int\r\n54|  res\r\n55|\r\n56|fail = 1.add(\"2\")\r\n                ^^^\r\n```\r\n\r\nThis is far from perfect. We need to solve #132 to improve some error messages.\r\n\r\nAlso, and open issue is how to test this best. I think the scala compiler just uses golden data tests where they commit what they expect the output to be.","created_at":"2018-12-09T00:41:10Z","updated_at":"2018-12-09T00:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/johnynek/bosatsu/pulls/133/commits","review_comments_url":"https://api.github.com/repos/johnynek/bosatsu/pulls/133/comments","review_comment_url":"https://api.github.com/repos/johnynek/bosatsu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnynek/bosatsu/issues/133/comments","statuses_url":"https://api.github.com/repos/johnynek/bosatsu/statuses/22a072ac7f182d1c68a8ce6875479950192ef5a9","head":{"label":"johnynek:oscar/infer_region","ref":"oscar/infer_region","sha":"22a072ac7f182d1c68a8ce6875479950192ef5a9","user":{"login":"johnynek","id":67958,"node_id":"MDQ6VXNlcjY3OTU4","avatar_url":"https://avatars0.githubusercontent.com/u/67958?v=4","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"repo":{"id":107490085,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0OTAwODU=","name":"bosatsu","full_name":"johnynek/bosatsu","private":false,"owner":{"login":"johnynek","id":67958,"node_id":"MDQ6VXNlcjY3OTU4","avatar_url":"https://avatars0.githubusercontent.com/u/67958?v=4","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnynek/bosatsu","description":"A python-ish pure and total functional programming language","fork":false,"url":"https://api.github.com/repos/johnynek/bosatsu","forks_url":"https://api.github.com/repos/johnynek/bosatsu/forks","keys_url":"https://api.github.com/repos/johnynek/bosatsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnynek/bosatsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnynek/bosatsu/teams","hooks_url":"https://api.github.com/repos/johnynek/bosatsu/hooks","issue_events_url":"https://api.github.com/repos/johnynek/bosatsu/issues/events{/number}","events_url":"https://api.github.com/repos/johnynek/bosatsu/events","assignees_url":"https://api.github.com/repos/johnynek/bosatsu/assignees{/user}","branches_url":"https://api.github.com/repos/johnynek/bosatsu/branches{/branch}","tags_url":"https://api.github.com/repos/johnynek/bosatsu/tags","blobs_url":"https://api.github.com/repos/johnynek/bosatsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnynek/bosatsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnynek/bosatsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnynek/bosatsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnynek/bosatsu/statuses/{sha}","languages_url":"https://api.github.com/repos/johnynek/bosatsu/languages","stargazers_url":"https://api.github.com/repos/johnynek/bosatsu/stargazers","contributors_url":"https://api.github.com/repos/johnynek/bosatsu/contributors","subscribers_url":"https://api.github.com/repos/johnynek/bosatsu/subscribers","subscription_url":"https://api.github.com/repos/johnynek/bosatsu/subscription","commits_url":"https://api.github.com/repos/johnynek/bosatsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnynek/bosatsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnynek/bosatsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnynek/bosatsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnynek/bosatsu/contents/{+path}","compare_url":"https://api.github.com/repos/johnynek/bosatsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnynek/bosatsu/merges","archive_url":"https://api.github.com/repos/johnynek/bosatsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnynek/bosatsu/downloads","issues_url":"https://api.github.com/repos/johnynek/bosatsu/issues{/number}","pulls_url":"https://api.github.com/repos/johnynek/bosatsu/pulls{/number}","milestones_url":"https://api.github.com/repos/johnynek/bosatsu/milestones{/number}","notifications_url":"https://api.github.com/repos/johnynek/bosatsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnynek/bosatsu/labels{/name}","releases_url":"https://api.github.com/repos/johnynek/bosatsu/releases{/id}","deployments_url":"https://api.github.com/repos/johnynek/bosatsu/deployments","created_at":"2017-10-19T02:48:28Z","updated_at":"2018-12-06T02:07:19Z","pushed_at":"2018-12-09T00:36:31Z","git_url":"git://github.com/johnynek/bosatsu.git","ssh_url":"git@github.com:johnynek/bosatsu.git","clone_url":"https://github.com/johnynek/bosatsu.git","svn_url":"https://github.com/johnynek/bosatsu","homepage":"","size":734,"stargazers_count":69,"watchers_count":69,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":37,"watchers":69,"default_branch":"master"}},"base":{"label":"johnynek:master","ref":"master","sha":"2eaa079dfc7b5e53e732615c4c92188eddb4ad39","user":{"login":"johnynek","id":67958,"node_id":"MDQ6VXNlcjY3OTU4","avatar_url":"https://avatars0.githubusercontent.com/u/67958?v=4","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"repo":{"id":107490085,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0OTAwODU=","name":"bosatsu","full_name":"johnynek/bosatsu","private":false,"owner":{"login":"johnynek","id":67958,"node_id":"MDQ6VXNlcjY3OTU4","avatar_url":"https://avatars0.githubusercontent.com/u/67958?v=4","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnynek/bosatsu","description":"A python-ish pure and total functional programming language","fork":false,"url":"https://api.github.com/repos/johnynek/bosatsu","forks_url":"https://api.github.com/repos/johnynek/bosatsu/forks","keys_url":"https://api.github.com/repos/johnynek/bosatsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnynek/bosatsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnynek/bosatsu/teams","hooks_url":"https://api.github.com/repos/johnynek/bosatsu/hooks","issue_events_url":"https://api.github.com/repos/johnynek/bosatsu/issues/events{/number}","events_url":"https://api.github.com/repos/johnynek/bosatsu/events","assignees_url":"https://api.github.com/repos/johnynek/bosatsu/assignees{/user}","branches_url":"https://api.github.com/repos/johnynek/bosatsu/branches{/branch}","tags_url":"https://api.github.com/repos/johnynek/bosatsu/tags","blobs_url":"https://api.github.com/repos/johnynek/bosatsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnynek/bosatsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnynek/bosatsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnynek/bosatsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnynek/bosatsu/statuses/{sha}","languages_url":"https://api.github.com/repos/johnynek/bosatsu/languages","stargazers_url":"https://api.github.com/repos/johnynek/bosatsu/stargazers","contributors_url":"https://api.github.com/repos/johnynek/bosatsu/contributors","subscribers_url":"https://api.github.com/repos/johnynek/bosatsu/subscribers","subscription_url":"https://api.github.com/repos/johnynek/bosatsu/subscription","commits_url":"https://api.github.com/repos/johnynek/bosatsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnynek/bosatsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnynek/bosatsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnynek/bosatsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnynek/bosatsu/contents/{+path}","compare_url":"https://api.github.com/repos/johnynek/bosatsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnynek/bosatsu/merges","archive_url":"https://api.github.com/repos/johnynek/bosatsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnynek/bosatsu/downloads","issues_url":"https://api.github.com/repos/johnynek/bosatsu/issues{/number}","pulls_url":"https://api.github.com/repos/johnynek/bosatsu/pulls{/number}","milestones_url":"https://api.github.com/repos/johnynek/bosatsu/milestones{/number}","notifications_url":"https://api.github.com/repos/johnynek/bosatsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnynek/bosatsu/labels{/name}","releases_url":"https://api.github.com/repos/johnynek/bosatsu/releases{/id}","deployments_url":"https://api.github.com/repos/johnynek/bosatsu/deployments","created_at":"2017-10-19T02:48:28Z","updated_at":"2018-12-06T02:07:19Z","pushed_at":"2018-12-09T00:36:31Z","git_url":"git://github.com/johnynek/bosatsu.git","ssh_url":"git@github.com:johnynek/bosatsu.git","clone_url":"https://github.com/johnynek/bosatsu.git","svn_url":"https://github.com/johnynek/bosatsu","homepage":"","size":734,"stargazers_count":69,"watchers_count":69,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":37,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnynek/bosatsu/pulls/133"},"html":{"href":"https://github.com/johnynek/bosatsu/pull/133"},"issue":{"href":"https://api.github.com/repos/johnynek/bosatsu/issues/133"},"comments":{"href":"https://api.github.com/repos/johnynek/bosatsu/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/johnynek/bosatsu/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/johnynek/bosatsu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnynek/bosatsu/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/johnynek/bosatsu/statuses/22a072ac7f182d1c68a8ce6875479950192ef5a9"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":191,"deletions":118,"changed_files":4}}
{"actor":{"display_login":"johnynek"}}