{"action":"created","issue":{"url":"https://api.github.com/repos/davehorton/drachtio-server/issues/45","repository_url":"https://api.github.com/repos/davehorton/drachtio-server","labels_url":"https://api.github.com/repos/davehorton/drachtio-server/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/davehorton/drachtio-server/issues/45/comments","events_url":"https://api.github.com/repos/davehorton/drachtio-server/issues/45/events","html_url":"https://github.com/davehorton/drachtio-server/issues/45","id":354909868,"node_id":"MDU6SXNzdWUzNTQ5MDk4Njg=","number":45,"title":"Feature Request: add options to specify admin port, IP and secret on command line","user":{"login":"busseyl","id":6764970,"node_id":"MDQ6VXNlcjY3NjQ5NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6764970?v=4","gravatar_id":"","url":"https://api.github.com/users/busseyl","html_url":"https://github.com/busseyl","followers_url":"https://api.github.com/users/busseyl/followers","following_url":"https://api.github.com/users/busseyl/following{/other_user}","gists_url":"https://api.github.com/users/busseyl/gists{/gist_id}","starred_url":"https://api.github.com/users/busseyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busseyl/subscriptions","organizations_url":"https://api.github.com/users/busseyl/orgs","repos_url":"https://api.github.com/users/busseyl/repos","events_url":"https://api.github.com/users/busseyl/events{/privacy}","received_events_url":"https://api.github.com/users/busseyl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-28T21:24:31Z","updated_at":"2018-08-28T23:02:25Z","closed_at":null,"author_association":"NONE","body":"Reviewing the code I only see the config class referencing the admin IP, port and secret values in the XML config file:\r\n\r\n```<admin port=\"9022\" secret=\"cymru\">127.0.0.1</admin>```\r\n\r\nWhen running a Docker container it is less desirable to hard-code these types of properties in a configuration file that requires complex configuration (file) management. This is especially true when setting these types of properties in a very dynamic environment with service discovery.\r\n\r\nIdeally, these values would be referenced/passed via environment variables or the command line parameters. This concept is similar to the way that we can pass --contact and --external-ip config parameters.\r\n\r\nPerhaps (very likely!) I'm overlooking something in the code but I don't see any way to perform this type of configuration.\r\n\r\nThanks for releasing such a great project to the open source world!\r\n\r\nRegards,\r\nLucas"},"comment":{"url":"https://api.github.com/repos/davehorton/drachtio-server/issues/comments/416768225","html_url":"https://github.com/davehorton/drachtio-server/issues/45#issuecomment-416768225","issue_url":"https://api.github.com/repos/davehorton/drachtio-server/issues/45","id":416768225,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjc2ODIyNQ==","user":{"login":"davehorton","id":1884973,"node_id":"MDQ6VXNlcjE4ODQ5NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1884973?v=4","gravatar_id":"","url":"https://api.github.com/users/davehorton","html_url":"https://github.com/davehorton","followers_url":"https://api.github.com/users/davehorton/followers","following_url":"https://api.github.com/users/davehorton/following{/other_user}","gists_url":"https://api.github.com/users/davehorton/gists{/gist_id}","starred_url":"https://api.github.com/users/davehorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehorton/subscriptions","organizations_url":"https://api.github.com/users/davehorton/orgs","repos_url":"https://api.github.com/users/davehorton/repos","events_url":"https://api.github.com/users/davehorton/events{/privacy}","received_events_url":"https://api.github.com/users/davehorton/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T23:02:25Z","updated_at":"2018-08-28T23:02:25Z","author_association":"OWNER","body":"here is the best documentation on command line arg FYI\r\n\r\nhttps://drachtio.org/docs/drachtio-server#command-line-arguments"}}
{"actor":{"display_login":"davehorton"}}