{"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/packages/issues/7567","repository_url":"https://api.github.com/repos/openwrt/packages","labels_url":"https://api.github.com/repos/openwrt/packages/issues/7567/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/packages/issues/7567/comments","events_url":"https://api.github.com/repos/openwrt/packages/issues/7567/events","html_url":"https://github.com/openwrt/packages/pull/7567","id":386632895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzA3ODY3","number":7567,"title":"perl-xml-parser: Fix DEPENDS","user":{"login":"neheb","id":2918873,"node_id":"MDQ6VXNlcjI5MTg4NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2918873?v=4","gravatar_id":"","url":"https://api.github.com/users/neheb","html_url":"https://github.com/neheb","followers_url":"https://api.github.com/users/neheb/followers","following_url":"https://api.github.com/users/neheb/following{/other_user}","gists_url":"https://api.github.com/users/neheb/gists{/gist_id}","starred_url":"https://api.github.com/users/neheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neheb/subscriptions","organizations_url":"https://api.github.com/users/neheb/orgs","repos_url":"https://api.github.com/users/neheb/repos","events_url":"https://api.github.com/users/neheb/events{/privacy}","received_events_url":"https://api.github.com/users/neheb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T02:14:10Z","updated_at":"2018-12-05T06:16:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openwrt/packages/pulls/7567","html_url":"https://github.com/openwrt/packages/pull/7567","diff_url":"https://github.com/openwrt/packages/pull/7567.diff","patch_url":"https://github.com/openwrt/packages/pull/7567.patch"},"body":"A depends of perl does not work. It does not select perl, does not get\r\nselected by PKG_BUILD_DEPENDS, and overall does not work automatically.\r\n\r\nSigned-off-by: Rosen Penev <rosenp@gmail.com>\r\n\r\nMaintainer: @Naoir \r\nCompile tested: ar71xx"},"comment":{"url":"https://api.github.com/repos/openwrt/packages/issues/comments/444371939","html_url":"https://github.com/openwrt/packages/pull/7567#issuecomment-444371939","issue_url":"https://api.github.com/repos/openwrt/packages/issues/7567","id":444371939,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDM3MTkzOQ==","user":{"login":"cshoredaniel","id":20735818,"node_id":"MDQ6VXNlcjIwNzM1ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/20735818?v=4","gravatar_id":"","url":"https://api.github.com/users/cshoredaniel","html_url":"https://github.com/cshoredaniel","followers_url":"https://api.github.com/users/cshoredaniel/followers","following_url":"https://api.github.com/users/cshoredaniel/following{/other_user}","gists_url":"https://api.github.com/users/cshoredaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/cshoredaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshoredaniel/subscriptions","organizations_url":"https://api.github.com/users/cshoredaniel/orgs","repos_url":"https://api.github.com/users/cshoredaniel/repos","events_url":"https://api.github.com/users/cshoredaniel/events{/privacy}","received_events_url":"https://api.github.com/users/cshoredaniel/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T06:16:17Z","updated_at":"2018-12-05T06:16:17Z","author_association":"CONTRIBUTOR","body":"On 2018-12-04 5:34 p.m., Philip Prindeville wrote:\n>\n> *@pprindeville* commented on this pull request.\n>\n> ------------------------------------------------------------------------\n>\n> In lang/perl-xml-parser/Makefile \n> <https://github.com/openwrt/packages/pull/7567#discussion_r238866354>:\n>\n> > @@ -38,7 +38,7 @@ define Package/perl-xml-parser\n>     CATEGORY:=Languages\n>     TITLE:=Perl XML Parser\n>     URL:=http://search.cpan.org/dist/XML-Parser/\n> -  DEPENDS:=perl +libexpat +perlbase-dynaloader +perlbase-essential\n> +  DEPENDS:=+perl +libexpat +perlbase-dynaloader +perlbase-essential\n>\n> I think we need a better understanding of how to fix this properly and \n> completely.\n>\nWithout + a DEPENDS requires that Perl be selected (``depends on perl``) \nbut does not ``select perl`` (in KConfig terms).\n\nThis is usually used to avoid circular/recursive dependencies. If \nperl-xml-parser selects perl then because it also selects \nperlbase-essential, and perl is the parent of perlbase-essential.\n\nThere is no clean solution for this type of situation that avoids having \nto ensure perl is selected first, in order to allow one to select \nperl-xml-base.\n\nThere are a number of packages in the same boat, and this will cause a \ncircular dependency, so I'd say it's wrong from an OpenWrt perspective.\n\nUltimately the limitation is present in any package manager that doesn't \nallow circular dependencies.\n\n"}}
{"actor":{"display_login":"cshoredaniel"}}