{"push_id":2797491624,"size":10,"distinct_size":10,"ref":"refs/heads/fwu_data_block_hash_index_block_level","head":"572269906c440a2b144042a10e93de25b0463e1d","before":"22dadc40d8278e9c15fd6212979954faef922c43","commits":[{"sha":"058026a88564c8c8d6eb732de0e13e21cc82952d","author":{"name":"Maysam Yabandeh","email":"fa70f0b1475558525c9225c8214c3747e6db43ca@fb.com"},"message":"Fix unity compile error (#4257)\n\nSummary:\nFix the compile error in \"make unity_test\" caused by #3983.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4257\n\nDifferential Revision: D9271740\n\nPulled By: maysamyabandeh\n\nfbshipit-source-id: 94e56d1675bf8bdc0e94439467eb4f40dd107517","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/058026a88564c8c8d6eb732de0e13e21cc82952d"},{"sha":"d511f35ea76fa98f731eda2ea23f1125a74782e6","author":{"name":"Maysam Yabandeh","email":"fa70f0b1475558525c9225c8214c3747e6db43ca@fb.com"},"message":"Fix wrong partitioned index size recorded in properties block (#4259)\n\nSummary:\nAfter refactoring in https://github.com/facebook/rocksdb/pull/4158 the properties block is written after the index block. This breaks the existing logic in estimating the index size in partitioned indexes. The patch fixes that by using the accurate index block size, which is available since by the time we write the properties block, the index block is already written.\nThe patch also fixes an issue in estimating the partition size with format_version=3 which was resulting into partitions smaller than the configured metadata_block_size.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4259\n\nDifferential Revision: D9274454\n\nPulled By: maysamyabandeh\n\nfbshipit-source-id: c82d045505cca3e7ed1a44ee1eaa26e4f25a4272","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/d511f35ea76fa98f731eda2ea23f1125a74782e6"},{"sha":"76d77205dacf6299b8345b11df375fbeafbfa5d3","author":{"name":"Zhichao Cao","email":"6398b150134f46ba53646086342531efab9325fb@fb.com"},"message":"Remove the redundant condition inclusion to avoid confusion (#4254)\n\nSummary:\nThe pair of ROCKSDB_LITE condition inclusion is redundant, it is already inside the #ifndef ROCKSDB_LITE. Remove them to void confusion.\n\nTested by make asan_check.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4254\n\nDifferential Revision: D9281652\n\nPulled By: zhichao-cao\n\nfbshipit-source-id: 06bf7641ede71391f21f6a3fe37fbd13f0e2a43a","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/76d77205dacf6299b8345b11df375fbeafbfa5d3"},{"sha":"6d75319d95d10a6f27dbef85d515ca04b349bde2","author":{"name":"Zhichao Cao","email":"6398b150134f46ba53646086342531efab9325fb@fb.com"},"message":"Add tracing function of Seek() and SeekForPrev() to trace_replay (#4228)\n\nSummary:\nIn the current trace_and replay, Get an WriteBatch are traced. This pull request track down the Seek() and SeekForPrev() to the trace file. <target_key, timestamp, column_family_id> are write to the file.\n\nReplay of Iterator is not supported in the current implementation.\n\nTested with trace_analyzer.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4228\n\nDifferential Revision: D9201381\n\nPulled By: zhichao-cao\n\nfbshipit-source-id: 6f9cc9cb3c20260af741bee065ec35c5c96354ab","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/6d75319d95d10a6f27dbef85d515ca04b349bde2"},{"sha":"4ea56b1bd00b5f8751e5e9733d01ceb33ebd09e3","author":{"name":"Anand Ananthabhotla","email":"146164b5d5754c7fbb081cfc748860edc03ee6fa@devvm1373.frc2.facebook.com"},"message":"Revert changes in PR #4003 (#4263)\n\nSummary:\nRevert this change. Not generating the OnTableFileCreated() notification for a 0 byte SST on flush breaks the assumption that every OnTableFileCreationStarted() notification is followed by a corresponding OnTableFileCreated().\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4263\n\nDifferential Revision: D9285623\n\nPulled By: anand1976\n\nfbshipit-source-id: 808c3dcd498b4b4f4ed4be947a29a24b2296aa8d","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/4ea56b1bd00b5f8751e5e9733d01ceb33ebd09e3"},{"sha":"1b1d26434238ad53bb5191b70a38ddb07d292577","author":{"name":"Yanqin Jin","email":"c238530decc239d4bf11aaf1a7c1c1cd8e3d0095@fb.com"},"message":"Remove an assersion about file size (#4268)\n\nSummary:\nDue to 4ea56b1bd00b5f8751e5e9733d01ceb33ebd09e3, we should also remove the\nassersion in stress test. This removal can be temporary, and we can add it back\nonce we figure out the reason for the 0-byte SSTs.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4268\n\nDifferential Revision: D9297186\n\nPulled By: riversand963\n\nfbshipit-source-id: cebba9a68f42e815f8cf24471176d2cfdf962f63","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/1b1d26434238ad53bb5191b70a38ddb07d292577"},{"sha":"999d955e4fc62f2fad8fde47d6b961f50c25861b","author":{"name":"Zhichao Cao","email":"6398b150134f46ba53646086342531efab9325fb@fb.com"},"message":"RocksDB Trace Analyzer (#4091)\n\nSummary:\nA framework of trace analyzing for RocksDB\n\nAfter collecting the trace by using the tool of [PR #3837](https://github.com/facebook/rocksdb/pull/3837). User can use the Trace Analyzer to interpret, analyze, and characterize the collected workload.\n**Input:**\n1. trace file\n2. Whole keys space file\n\n**Statistics:**\n1. Access count of each operation (Get, Put, Delete, SingleDelete, DeleteRange, Merge) in each column family.\n2. Key hotness (access count) of each one\n3. Key space separation based on given prefix\n4. Key size distribution\n5. Value size distribution if appliable\n6. Top K accessed keys\n7. QPS statistics including the average QPS and peak QPS\n8. Top K accessed prefix\n9. The query correlation analyzing, output the number of X after Y and the corresponding average time\n    intervals\n\n**Output:**\n1. key access heat map (either in the accessed key space or whole key space)\n2. trace sequence file (interpret the raw trace file to line base text file for future use)\n3. Time serial (The key space ID and its access time)\n4. Key access count distritbution\n5. Key size distribution\n6. Value size distribution (in each intervals)\n7. whole key space separation by the prefix\n8. Accessed key space separation by the prefix\n9. QPS of each operation and each column family\n10. Top K QPS and their accessed prefix range\n\n**Test:**\n1. Added the unit test of analyzing Get, Put, Delete, SingleDelete, DeleteRange, Merge\n2. Generated the trace and analyze the trace\n\n**Implemented but not tested (due to the limitation of trace_replay):**\n1. Analyzing Iterator, supporting Seek() and SeekForPrev() analyzing\n2. Analyzing the number of Key found by Get\n\n**Future Work:**\n1.  Support execution time analyzing of each requests\n2.  Support cache hit situation and block read situation of Get\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4091\n\nDifferential Revision: D9256157\n\nPulled By: zhichao-cao\n\nfbshipit-source-id: f0ceacb7eedbc43a3eee6e85b76087d7832a8fe6","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/999d955e4fc62f2fad8fde47d6b961f50c25861b"},{"sha":"f3d91a0b574d8b262d410d265ca264dc19565e66","author":{"name":"Siying Dong","email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com"},"message":"Add a unit test to verify iterators release data blocks after using them (#4170)\n\nSummary:\nAdd a unit test to check that iterators release data blocks after it has moved away from it. Verify the same for compaction input iterators.\nPull Request resolved: https://github.com/facebook/rocksdb/pull/4170\n\nDifferential Revision: D8962513\n\nPulled By: siying\n\nfbshipit-source-id: 05a5b604d7d29887fb488f2cda7286f554a14407","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/f3d91a0b574d8b262d410d265ca264dc19565e66"},{"sha":"d916a1105aabd0358f802ad198520f595c4f90d3","author":{"name":"Huachao Huang","email":"f173607aa831848a3ee0de3a5ae0c89c11a68b51@gmail.com"},"message":"c-api: add some missing options\n\nSummary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/4267\n\nDifferential Revision: D9309505\n\nPulled By: anand1976\n\nfbshipit-source-id: eb9fee8037f4ff24dc1cdd5cc5ef41c231a03e1f","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/d916a1105aabd0358f802ad198520f595c4f90d3"},{"sha":"572269906c440a2b144042a10e93de25b0463e1d","author":{"name":"Fenggang Wu","email":"127e1b5a5d5f4b1cdca089991876a4b75674b751@fb.com"},"message":"Merge remote-tracking branch 'upstream/master' into fwu_data_block_hash_index_block_level","distinct":true,"url":"https://api.github.com/repos/fgwu/rocksdb/commits/572269906c440a2b144042a10e93de25b0463e1d"}]}
{"actor":{"display_login":"fgwu"}}