{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/14901","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/14901/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14901/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/14901/events","html_url":"https://github.com/nodejs/node/pull/14901","id":251042364,"number":14901,"title":"src, test: node internals' postmortem metadata ","user":{"login":"mmarchini","id":4048656,"avatar_url":"https://avatars1.githubusercontent.com/u/4048656?v=4","gravatar_id":"","url":"https://api.github.com/users/mmarchini","html_url":"https://github.com/mmarchini","followers_url":"https://api.github.com/users/mmarchini/followers","following_url":"https://api.github.com/users/mmarchini/following{/other_user}","gists_url":"https://api.github.com/users/mmarchini/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarchini/subscriptions","organizations_url":"https://api.github.com/users/mmarchini/orgs","repos_url":"https://api.github.com/users/mmarchini/repos","events_url":"https://api.github.com/users/mmarchini/events{/privacy}","received_events_url":"https://api.github.com/users/mmarchini/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":575600232,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v8.x","name":"dont-land-on-v8.x","color":"1d76db","default":false},{"id":744829308,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v9.x","name":"dont-land-on-v9.x","color":"0e8a16","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"assignees":[{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false}],"milestone":null,"comments":107,"created_at":"2017-08-17T19:08:36Z","updated_at":"2018-02-08T19:43:17Z","closed_at":"2018-01-26T00:56:50Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14901","html_url":"https://github.com/nodejs/node/pull/14901","diff_url":"https://github.com/nodejs/node/pull/14901.diff","patch_url":"https://github.com/nodejs/node/pull/14901.patch"},"body":"Those changes are the first steps towards allowing debug tools to\r\nnavigate some of Node's internals strucutres, giving more possibilities\r\nto developers doing post-mortem debugging. One example of what can be\r\nachieved with the symbols added is a new command being developed for\r\nllnode, which prints information about handles and requests on the\r\nqueue for a core dump file.\r\n\r\nRef: https://github.com/nodejs/post-mortem/issues/46\r\n\r\nObs.: To add good tests for those changes, something like nodejs/build#777 is needed.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n* Building system\r\n* Tools"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/364225972","html_url":"https://github.com/nodejs/node/pull/14901#issuecomment-364225972","issue_url":"https://api.github.com/repos/nodejs/node/issues/14901","id":364225972,"user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T19:43:17Z","updated_at":"2018-02-08T19:43:17Z","author_association":"CONTRIBUTOR","body":"@bnoordhuis Just curious, is that a convention? There is `class StringSearch : private StringSearchBase` and `class Reference : private Finalizer` in our codebase. If that needs to be enforced, we should put that in the C++ style guide."}}
{"actor":{"display_login":"joyeecheung"}}