{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/215486836","pull_request_review_id":152761893,"id":215486836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ4NjgzNg==","diff_hunk":"@@ -558,9 +558,10 @@ def _libs_with_msvc_and_fortran(self, fcompiler, c_libraries,\n             # correct path when compiling in Cygwin but with normal Win\n             # Python\n             if dir.startswith('/usr/lib'):\n-                s, o = exec_command(['cygpath', '-w', dir], use_tee=False)\n-                if not s:\n-                    dir = o\n+                try:\n+                    dir = subprocess.check_output(['cygpath', '-w', dir])\n+                except subprocess.CalledProcessError:","path":"numpy/distutils/command/build_ext.py","position":25,"original_position":25,"commit_id":"3f48206919135ee7f7105d7a88b470c41600c3cf","original_commit_id":"3f48206919135ee7f7105d7a88b470c41600c3cf","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"And probably other things too:\r\n```Python\r\nimport subprocess\r\nret = subprocess.check_output(['garbage', 'not', 'a', 'command'])\r\n```\r\n\r\n`FileNotFoundError: [Errno 2] No such file or directory: 'garbage': 'garbage'`\r\n\r\nWould be much better if this was all well-tested, obviously.","created_at":"2018-09-06T03:37:31Z","updated_at":"2018-09-06T03:37:31Z","html_url":"https://github.com/numpy/numpy/pull/11891#discussion_r215486836","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/11891","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/215486836"},"html":{"href":"https://github.com/numpy/numpy/pull/11891#discussion_r215486836"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11891"}},"in_reply_to_id":215480373},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11891","id":213464386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDY0Mzg2","html_url":"https://github.com/numpy/numpy/pull/11891","diff_url":"https://github.com/numpy/numpy/pull/11891.diff","patch_url":"https://github.com/numpy/numpy/pull/11891.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11891","number":11891,"state":"open","locked":false,"title":"MAINT: remove exec_command() from build_ext","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"Replace a single usage of `exec_command()` with a standard library `subprocess` usage--eventual goal is to completely remove `exec_command()` in favor of the standard library, but working in small / manageable chunks.\r\n\r\nI'm slightly concerned to see that codecov shows the affected code block here as not covered--perhaps this is because we don't run / aggregate coverage results form Appveyor, but we certainly could (*should I do that?*)--I suspect this may cause the coverage diff to fail here even if everything else is green.\r\n\r\nOr that code block may genuinely not be covered by tests I suppose.","created_at":"2018-09-06T00:31:58Z","updated_at":"2018-09-06T03:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4910c7af45a43a4fbb1f789a731040eeef555a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":36825825,"node_id":"MDU6TGFiZWwzNjgyNTgyNQ==","url":"https://api.github.com/repos/numpy/numpy/labels/03%20-%20Maintenance","name":"03 - Maintenance","color":"fef2c0","default":false},{"id":16917063,"node_id":"MDU6TGFiZWwxNjkxNzA2Mw==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.distutils","name":"component: numpy.distutils","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/11891/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/11891/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11891/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/3f48206919135ee7f7105d7a88b470c41600c3cf","head":{"label":"tylerjereddy:rm_exec_command_1","ref":"rm_exec_command_1","sha":"3f48206919135ee7f7105d7a88b470c41600c3cf","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"repo":{"id":116427166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY0MjcxNjY=","name":"numpy","full_name":"tylerjereddy/numpy","owner":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylerjereddy/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/tylerjereddy/numpy","forks_url":"https://api.github.com/repos/tylerjereddy/numpy/forks","keys_url":"https://api.github.com/repos/tylerjereddy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerjereddy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerjereddy/numpy/teams","hooks_url":"https://api.github.com/repos/tylerjereddy/numpy/hooks","issue_events_url":"https://api.github.com/repos/tylerjereddy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/tylerjereddy/numpy/events","assignees_url":"https://api.github.com/repos/tylerjereddy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/tylerjereddy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/tylerjereddy/numpy/tags","blobs_url":"https://api.github.com/repos/tylerjereddy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerjereddy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerjereddy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerjereddy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerjereddy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerjereddy/numpy/languages","stargazers_url":"https://api.github.com/repos/tylerjereddy/numpy/stargazers","contributors_url":"https://api.github.com/repos/tylerjereddy/numpy/contributors","subscribers_url":"https://api.github.com/repos/tylerjereddy/numpy/subscribers","subscription_url":"https://api.github.com/repos/tylerjereddy/numpy/subscription","commits_url":"https://api.github.com/repos/tylerjereddy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerjereddy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerjereddy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerjereddy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerjereddy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/tylerjereddy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerjereddy/numpy/merges","archive_url":"https://api.github.com/repos/tylerjereddy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerjereddy/numpy/downloads","issues_url":"https://api.github.com/repos/tylerjereddy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/tylerjereddy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerjereddy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerjereddy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerjereddy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/tylerjereddy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/tylerjereddy/numpy/deployments","created_at":"2018-01-05T21:11:17Z","updated_at":"2018-09-05T03:15:03Z","pushed_at":"2018-09-06T00:56:02Z","git_url":"git://github.com/tylerjereddy/numpy.git","ssh_url":"git@github.com:tylerjereddy/numpy.git","clone_url":"https://github.com/tylerjereddy/numpy.git","svn_url":"https://github.com/tylerjereddy/numpy","homepage":"http://www.numpy.org/","size":58852,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"340405dbdd79786fdfa469ec356e78d2cd0a7d67","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-09-06T00:55:25Z","pushed_at":"2018-09-06T00:54:32Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":60223,"stargazers_count":8093,"watchers_count":8093,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2970,"mirror_url":null,"archived":false,"open_issues_count":1952,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2970,"open_issues":1952,"watchers":8093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11891"},"html":{"href":"https://github.com/numpy/numpy/pull/11891"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/11891"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/11891/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11891/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11891/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/3f48206919135ee7f7105d7a88b470c41600c3cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tylerjereddy"}}