{"action":"opened","number":24380,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380","id":178655416,"html_url":"https://github.com/cockroachdb/cockroach/pull/24380","diff_url":"https://github.com/cockroachdb/cockroach/pull/24380.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/24380.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24380","number":24380,"state":"open","locked":false,"title":"[wip] roachtest: add teamcity output markers; upload artifacts","user":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"body":"Example build: https://teamcity.cockroachdb.com/viewLog.html?buildId=588169&buildTypeId=Cockroach_Nightlies_WorkloadNightly&tab=buildResultsDiv\r\n\r\n### Build log:\r\nWith this PR, roachtest prints out a `##teamCity` marker when a test starts, fails, and finishes (success is represented as a finish without a fail). This allows TC to show:\r\n- how long each test has been running (and record this for the \"Test History\" screens)\r\n- which tests have succeeded and failed, including while the job is still running (this is also recorded in the \"Test History\" screens)\r\n\r\nThe status of each running test is still printed out interleaved every minute. TC has a `buildProgress` directive with a `flowId` argument which possibly could be used to group test output under each test (so it'd no longer be interleaved), but leaving that part be for now.\r\n![image](https://user-images.githubusercontent.com/7341/38157383-717615d6-3454-11e8-8fac-5a67febad596.png)\r\n\r\n### Artifacts grouped by test name, uploaded while build is still in progress:\r\nNote: TC interprets commas in artifact paths in `publishArtifacts` directives as delimiting multiple paths, so I replaced `,`s with `_`s in log paths to avoid this. (Couldn't find any way of escaping commas). Hopefully that doesn't cause problems.\r\n![image](https://user-images.githubusercontent.com/7341/38157385-7a9b50f4-3454-11e8-95a9-ebea4c15c21a.png)\r\n\r\n### \"Tests\" tab of build screen, while build still in progress:\r\nI think tests only show up here once they've finished.\r\n![image](https://user-images.githubusercontent.com/7341/38157392-84a72d20-3454-11e8-8e31-d6e875258564.png)\r\n\r\nFixes #24313","created_at":"2018-03-31T00:07:10Z","updated_at":"2018-03-31T00:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24380/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a84cbae29fb4cc70067392d6d185c06cf6c685d2","head":{"label":"vilterp:roachtest-teamcity-output","ref":"roachtest-teamcity-output","sha":"a84cbae29fb4cc70067392d6d185c06cf6c685d2","user":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"repo":{"id":102527042,"name":"cockroach","full_name":"vilterp/cockroach","owner":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilterp/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/vilterp/cockroach","forks_url":"https://api.github.com/repos/vilterp/cockroach/forks","keys_url":"https://api.github.com/repos/vilterp/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilterp/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilterp/cockroach/teams","hooks_url":"https://api.github.com/repos/vilterp/cockroach/hooks","issue_events_url":"https://api.github.com/repos/vilterp/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/vilterp/cockroach/events","assignees_url":"https://api.github.com/repos/vilterp/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/vilterp/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/vilterp/cockroach/tags","blobs_url":"https://api.github.com/repos/vilterp/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilterp/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilterp/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilterp/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilterp/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/vilterp/cockroach/languages","stargazers_url":"https://api.github.com/repos/vilterp/cockroach/stargazers","contributors_url":"https://api.github.com/repos/vilterp/cockroach/contributors","subscribers_url":"https://api.github.com/repos/vilterp/cockroach/subscribers","subscription_url":"https://api.github.com/repos/vilterp/cockroach/subscription","commits_url":"https://api.github.com/repos/vilterp/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilterp/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilterp/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilterp/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/vilterp/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/vilterp/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilterp/cockroach/merges","archive_url":"https://api.github.com/repos/vilterp/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilterp/cockroach/downloads","issues_url":"https://api.github.com/repos/vilterp/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/vilterp/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/vilterp/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/vilterp/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilterp/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/vilterp/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/vilterp/cockroach/deployments","created_at":"2017-09-05T20:31:48Z","updated_at":"2017-09-05T20:31:58Z","pushed_at":"2018-03-30T23:57:57Z","git_url":"git://github.com/vilterp/cockroach.git","ssh_url":"git@github.com:vilterp/cockroach.git","clone_url":"https://github.com/vilterp/cockroach.git","svn_url":"https://github.com/vilterp/cockroach","homepage":"https://www.cockroachlabs.com","size":509018,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"2d1b662fe46172aa46de9d2e021773518532df4d","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-03-30T23:18:16Z","pushed_at":"2018-03-31T00:02:31Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":977892,"stargazers_count":12960,"watchers_count":12960,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1325,"mirror_url":null,"archived":false,"open_issues_count":1639,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1325,"open_issues":1639,"watchers":12960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/24380"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/24380"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/24380/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24380/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a84cbae29fb4cc70067392d6d185c06cf6c685d2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":45,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"vilterp"}}