{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6432","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6432/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6432/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6432/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6432","id":287563483,"number":6432,"title":"Hybrid Air Conditioner","user":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"labels":[{"id":429517840,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/IDDChange","name":"IDDChange","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7","html_url":"https://github.com/NREL/EnergyPlus/milestone/7","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7/labels","id":2668648,"number":7,"title":"EnergyPlus 8.9.0","description":"Tentative on the naming.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":22,"state":"open","created_at":"2017-07-29T02:49:31Z","updated_at":"2018-02-14T11:10:57Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":10,"created_at":"2018-01-10T20:16:30Z","updated_at":"2018-02-14T12:09:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6432","html_url":"https://github.com/NREL/EnergyPlus/pull/6432","diff_url":"https://github.com/NREL/EnergyPlus/pull/6432.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6432.patch"},"body":"@spencerdutton I made this branch from the current state of the prior Hybrid branch but with all the commits squashed down.  This will remove a bunch of history but it will make it load on Github again so that we can review it.  Could you please verify this looks like your current state?\r\n\r\nIf you had additional changes local on your machine, here is what I would advise:\r\n- Copy the files you have modified locally to a temp folder\r\n- Do a Git Pull to pull the latest code including this new branch\r\n- Check out this new branch locally\r\n- Paste in your changed files\r\n- Commit and push back up, and work from this new branch from now on\r\n\r\nPull request overview\r\n---------------------\r\n@spencerdutton If this works out, can you update this paragraph with a description of the model again since the original PR won't load for me?\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/365588431","html_url":"https://github.com/NREL/EnergyPlus/pull/6432#issuecomment-365588431","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6432","id":365588431,"user":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T12:09:17Z","updated_at":"2018-02-14T12:09:17Z","author_association":"MEMBER","body":"Alright I just pushed up a collection of fixes.  This *should* clean up the compiler warnings, of which there were several.  I also moved the IDF to the testfiles/ folder.  I also cleaned up an initialization bug (please see dacaf7a and verify).  At this point, the IDF is at least starting to run, but very slow.  The slow model is amplified by my debug version of the build.  I'm building a release optimized version so that maybe it will get through it quicker.\r\n\r\nMake sure you pull these changes down if you make any more changes.  I'll keep testing now that things are cleaned up further."}}
{"actor":{"display_login":"Myoldmopar"}}