{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/187681643","pull_request_review_id":119517259,"id":187681643,"diff_hunk":"@@ -83,6 +84,34 @@ def which(binary):\n     return None\n \n \n+def register_providers(cli_ctx):\n+    \"\"\"Registers the required Azure resource providers for AKS, if necessary.\"\"\"","path":"src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/custom.py","position":13,"original_position":13,"commit_id":"fdea2d16a14883632ab56a0c62d9cfad93266f0c","original_commit_id":"fdea2d16a14883632ab56a0c62d9cfad93266f0c","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars1.githubusercontent.com/u/6014209?v=4","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"@mboersma, sounds good. Feel free to let me know if you have any questions when update the service error response. It is possible the `target` field might become a list (say comma separate) for you case. If yes, I can align our logics through the [work item](https://github.com/Azure/msrestazure-for-python/issues/53) at our end.","created_at":"2018-05-11T17:32:45Z","updated_at":"2018-05-11T17:32:45Z","html_url":"https://github.com/Azure/azure-cli/pull/6327#discussion_r187681643","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6327","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/187681643"},"html":{"href":"https://github.com/Azure/azure-cli/pull/6327#discussion_r187681643"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6327"}},"in_reply_to_id":187660684},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/6327","id":187246008,"html_url":"https://github.com/Azure/azure-cli/pull/6327","diff_url":"https://github.com/Azure/azure-cli/pull/6327.diff","patch_url":"https://github.com/Azure/azure-cli/pull/6327.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/6327","number":6327,"state":"open","locked":false,"title":"[ACS] register supporting providers before creating a cluster ","user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars0.githubusercontent.com/u/73019?v=4","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"body":"Several users who tried out AKS after the //build conference were surprised with errors about \"provider not registered\" after `az aks create`. This adds code to automatically register the required Azure resource providers just-in-time.\r\n\r\n@troydai this also updates and fixes the tests. They should be more reliable when run in `--live` mode now, and any remaining scenario test issues after this I will pounce on and fix.\r\n\r\n---\r\n\r\n- [X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n- [X] I adhere to the [Command Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/command_guidelines.md).\r\n","created_at":"2018-05-10T16:48:58Z","updated_at":"2018-05-11T17:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea1c80e357a4bc1a065fed3fa16cabc7812bd947","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6327/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6327/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/6327/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/fdea2d16a14883632ab56a0c62d9cfad93266f0c","head":{"label":"mboersma:register-providers-for-aks","ref":"register-providers-for-aks","sha":"fdea2d16a14883632ab56a0c62d9cfad93266f0c","user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars0.githubusercontent.com/u/73019?v=4","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"repo":{"id":89601990,"name":"azure-cli","full_name":"mboersma/azure-cli","owner":{"login":"mboersma","id":73019,"avatar_url":"https://avatars0.githubusercontent.com/u/73019?v=4","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mboersma/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/mboersma/azure-cli","forks_url":"https://api.github.com/repos/mboersma/azure-cli/forks","keys_url":"https://api.github.com/repos/mboersma/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mboersma/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mboersma/azure-cli/teams","hooks_url":"https://api.github.com/repos/mboersma/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/mboersma/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/mboersma/azure-cli/events","assignees_url":"https://api.github.com/repos/mboersma/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/mboersma/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/mboersma/azure-cli/tags","blobs_url":"https://api.github.com/repos/mboersma/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mboersma/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mboersma/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/mboersma/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mboersma/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/mboersma/azure-cli/languages","stargazers_url":"https://api.github.com/repos/mboersma/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/mboersma/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/mboersma/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/mboersma/azure-cli/subscription","commits_url":"https://api.github.com/repos/mboersma/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/mboersma/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/mboersma/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/mboersma/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/mboersma/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/mboersma/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mboersma/azure-cli/merges","archive_url":"https://api.github.com/repos/mboersma/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mboersma/azure-cli/downloads","issues_url":"https://api.github.com/repos/mboersma/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/mboersma/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/mboersma/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/mboersma/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mboersma/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/mboersma/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/mboersma/azure-cli/deployments","created_at":"2017-04-27T13:43:03Z","updated_at":"2017-04-27T13:43:08Z","pushed_at":"2018-05-10T16:47:48Z","git_url":"git://github.com/mboersma/azure-cli.git","ssh_url":"git@github.com:mboersma/azure-cli.git","clone_url":"https://github.com/mboersma/azure-cli.git","svn_url":"https://github.com/mboersma/azure-cli","homepage":null,"size":41666,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"3a30c525aa44984ad319ab1c9214dfa300851126","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2018-05-11T17:21:13Z","pushed_at":"2018-05-11T17:21:10Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":41869,"stargazers_count":736,"watchers_count":736,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":456,"mirror_url":null,"archived":false,"open_issues_count":698,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":456,"open_issues":698,"watchers":736,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6327"},"html":{"href":"https://github.com/Azure/azure-cli/pull/6327"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/6327"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/6327/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6327/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6327/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/fdea2d16a14883632ab56a0c62d9cfad93266f0c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yugangw-msft"}}