{"action":"created","issue":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/640","repository_url":"https://api.github.com/repos/thepracticaldev/dev.to","labels_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/640/labels{/name}","comments_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/640/comments","events_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/640/events","html_url":"https://github.com/thepracticaldev/dev.to/issues/640","id":359569205,"node_id":"MDU6SXNzdWUzNTk1NjkyMDU=","number":640,"title":"Medium RSS feed articles are not pulled in if they have Giphy embeds","user":{"login":"Zhao-Andy","id":17884966,"node_id":"MDQ6VXNlcjE3ODg0OTY2","avatar_url":"https://avatars0.githubusercontent.com/u/17884966?v=4","gravatar_id":"","url":"https://api.github.com/users/Zhao-Andy","html_url":"https://github.com/Zhao-Andy","followers_url":"https://api.github.com/users/Zhao-Andy/followers","following_url":"https://api.github.com/users/Zhao-Andy/following{/other_user}","gists_url":"https://api.github.com/users/Zhao-Andy/gists{/gist_id}","starred_url":"https://api.github.com/users/Zhao-Andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zhao-Andy/subscriptions","organizations_url":"https://api.github.com/users/Zhao-Andy/orgs","repos_url":"https://api.github.com/users/Zhao-Andy/repos","events_url":"https://api.github.com/users/Zhao-Andy/events{/privacy}","received_events_url":"https://api.github.com/users/Zhao-Andy/received_events","type":"User","site_admin":false},"labels":[{"id":480869965,"node_id":"MDU6TGFiZWw0ODA4Njk5NjU=","url":"https://api.github.com/repos/thepracticaldev/dev.to/labels/bug","name":"bug","color":"ff050d","default":true},{"id":1093430195,"node_id":"MDU6TGFiZWwxMDkzNDMwMTk1","url":"https://api.github.com/repos/thepracticaldev/dev.to/labels/stale","name":"stale","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-12T16:56:22Z","updated_at":"2018-12-12T09:18:13Z","closed_at":null,"author_association":"COLLABORATOR","body":"## Bug Report\r\n### Current Behavior\r\nWhen pulling articles via RSS feed and from Medium specifically, the posts with Giphy embeds are not created because they run into an error here:\r\nhttps://github.com/thepracticaldev/dev.to/blob/9e35b25ac1471fad4497d3c25c974acf590de256/app/labor/rss_reader.rb#L126-L143\r\n\r\nIn line 133, `open` fails:\r\n```ruby\r\n# possible_link is https://medium.com/some-long-link-that-redirects-to-the-proper-place/href\r\nopen(possible_link)\r\n#=> RunTimeError: redirection forbidden:\r\n#=> \"gph.is/short-code-url\" -> \"http://giphy.com/gif-link\"\r\n```\r\n\r\nBasically, the short link redirects to regular HTTP, and that isn't allowed with `open`.\r\n\r\n### Proposed Solutions\r\nFrom easiest to hardest, we can:\r\n1. have better link checking,\r\n2. maybe try something else instead `open`,\r\n3. support Giphy embeds. \r\n\r\n### Additional Notes\r\nThis is not a critical issue that affects many people since I don't imagine Giphy embeds are used all that much. Also, only the articles that do have Giphy embeds are affected; the RssReader will still attempt to pull in the rest of the articles."},"comment":{"url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/comments/446517268","html_url":"https://github.com/thepracticaldev/dev.to/issues/640#issuecomment-446517268","issue_url":"https://api.github.com/repos/thepracticaldev/dev.to/issues/640","id":446517268,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjUxNzI2OA==","user":{"login":"rhymes","id":146201,"node_id":"MDQ6VXNlcjE0NjIwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/146201?v=4","gravatar_id":"","url":"https://api.github.com/users/rhymes","html_url":"https://github.com/rhymes","followers_url":"https://api.github.com/users/rhymes/followers","following_url":"https://api.github.com/users/rhymes/following{/other_user}","gists_url":"https://api.github.com/users/rhymes/gists{/gist_id}","starred_url":"https://api.github.com/users/rhymes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhymes/subscriptions","organizations_url":"https://api.github.com/users/rhymes/orgs","repos_url":"https://api.github.com/users/rhymes/repos","events_url":"https://api.github.com/users/rhymes/events{/privacy}","received_events_url":"https://api.github.com/users/rhymes/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T09:18:13Z","updated_at":"2018-12-12T09:18:13Z","author_association":"CONTRIBUTOR","body":"unstale :D "}}
{"actor":{"display_login":"rhymes"}}