{"action":"created","comment":{"url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments/231268316","pull_request_review_id":172202793,"id":231268316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI2ODMxNg==","diff_hunk":"@@ -55,6 +60,12 @@ const RisePlayerConfiguration = {\n   isPreview: function() {\n     return RisePlayerConfiguration.getDisplayId() === \"preview\";\n   },\n+  sendComponentsReadyEvent() {\n+    Promise.resolve()\n+      .then(() => {","path":"src/rise-player-configuration.js","position":20,"original_position":20,"commit_id":"12c738bcf7a926dc3444e9311fe907412d7e2b1a","original_commit_id":"12c738bcf7a926dc3444e9311fe907412d7e2b1a","user":{"login":"stulees","id":7407007,"node_id":"MDQ6VXNlcjc0MDcwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7407007?v=4","gravatar_id":"","url":"https://api.github.com/users/stulees","html_url":"https://github.com/stulees","followers_url":"https://api.github.com/users/stulees/followers","following_url":"https://api.github.com/users/stulees/following{/other_user}","gists_url":"https://api.github.com/users/stulees/gists{/gist_id}","starred_url":"https://api.github.com/users/stulees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stulees/subscriptions","organizations_url":"https://api.github.com/users/stulees/orgs","repos_url":"https://api.github.com/users/stulees/repos","events_url":"https://api.github.com/users/stulees/events{/privacy}","received_events_url":"https://api.github.com/users/stulees/received_events","type":"User","site_admin":false},"body":"@santiagonoguez Can you clarify the necessity of a Promise here?","created_at":"2018-11-06T19:51:39Z","updated_at":"2018-11-06T19:51:40Z","html_url":"https://github.com/Rise-Vision/common-template/pull/23#discussion_r231268316","pull_request_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments/231268316"},"html":{"href":"https://github.com/Rise-Vision/common-template/pull/23#discussion_r231268316"},"pull_request":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23","id":228808311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODA4MzEx","html_url":"https://github.com/Rise-Vision/common-template/pull/23","diff_url":"https://github.com/Rise-Vision/common-template/pull/23.diff","patch_url":"https://github.com/Rise-Vision/common-template/pull/23.patch","issue_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/23","number":23,"state":"open","locked":false,"title":"Feature/send components ready event on preview","user":{"login":"santiagonoguez","id":33162690,"node_id":"MDQ6VXNlcjMzMTYyNjkw","avatar_url":"https://avatars2.githubusercontent.com/u/33162690?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagonoguez","html_url":"https://github.com/santiagonoguez","followers_url":"https://api.github.com/users/santiagonoguez/followers","following_url":"https://api.github.com/users/santiagonoguez/following{/other_user}","gists_url":"https://api.github.com/users/santiagonoguez/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagonoguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagonoguez/subscriptions","organizations_url":"https://api.github.com/users/santiagonoguez/orgs","repos_url":"https://api.github.com/users/santiagonoguez/repos","events_url":"https://api.github.com/users/santiagonoguez/events{/privacy}","received_events_url":"https://api.github.com/users/santiagonoguez/received_events","type":"User","site_admin":false},"body":"When on preview, the RisePlayerConfiguration now sends a rise-components-ready event, so all components will start working.\r\n\r\nI moved the function that sends the event from RiseComponentLoader to RisePlayerConfiguration, so it could be reused.\r\n","created_at":"2018-11-06T19:29:36Z","updated_at":"2018-11-06T19:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda31b666402e1784e355b86f78f52366afd0682","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/23/comments","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/12c738bcf7a926dc3444e9311fe907412d7e2b1a","head":{"label":"Rise-Vision:feature/send_components_ready_event_on_preview","ref":"feature/send_components_ready_event_on_preview","sha":"12c738bcf7a926dc3444e9311fe907412d7e2b1a","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":150109433,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDk0MzM=","name":"common-template","full_name":"Rise-Vision/common-template","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/common-template","description":"Common scripts for Rise Templates","fork":false,"url":"https://api.github.com/repos/Rise-Vision/common-template","forks_url":"https://api.github.com/repos/Rise-Vision/common-template/forks","keys_url":"https://api.github.com/repos/Rise-Vision/common-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/common-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/common-template/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/common-template/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/common-template/events","assignees_url":"https://api.github.com/repos/Rise-Vision/common-template/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/common-template/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/common-template/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/common-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/common-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/common-template/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/common-template/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/common-template/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/common-template/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/common-template/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/common-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/common-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/common-template/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/common-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/common-template/merges","archive_url":"https://api.github.com/repos/Rise-Vision/common-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/common-template/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/common-template/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/common-template/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/common-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/common-template/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/common-template/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/common-template/deployments","created_at":"2018-09-24T13:47:01Z","updated_at":"2018-11-06T18:22:58Z","pushed_at":"2018-11-06T19:29:37Z","git_url":"git://github.com/Rise-Vision/common-template.git","ssh_url":"git@github.com:Rise-Vision/common-template.git","clone_url":"https://github.com/Rise-Vision/common-template.git","svn_url":"https://github.com/Rise-Vision/common-template","homepage":null,"size":237,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Rise-Vision:master","ref":"master","sha":"87b1972073c2a3ce4dd76d4c7364e9115b7d2b91","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":150109433,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDk0MzM=","name":"common-template","full_name":"Rise-Vision/common-template","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/common-template","description":"Common scripts for Rise Templates","fork":false,"url":"https://api.github.com/repos/Rise-Vision/common-template","forks_url":"https://api.github.com/repos/Rise-Vision/common-template/forks","keys_url":"https://api.github.com/repos/Rise-Vision/common-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/common-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/common-template/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/common-template/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/common-template/events","assignees_url":"https://api.github.com/repos/Rise-Vision/common-template/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/common-template/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/common-template/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/common-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/common-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/common-template/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/common-template/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/common-template/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/common-template/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/common-template/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/common-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/common-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/common-template/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/common-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/common-template/merges","archive_url":"https://api.github.com/repos/Rise-Vision/common-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/common-template/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/common-template/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/common-template/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/common-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/common-template/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/common-template/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/common-template/deployments","created_at":"2018-09-24T13:47:01Z","updated_at":"2018-11-06T18:22:58Z","pushed_at":"2018-11-06T19:29:37Z","git_url":"git://github.com/Rise-Vision/common-template.git","ssh_url":"git@github.com:Rise-Vision/common-template.git","clone_url":"https://github.com/Rise-Vision/common-template.git","svn_url":"https://github.com/Rise-Vision/common-template","homepage":null,"size":237,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23"},"html":{"href":"https://github.com/Rise-Vision/common-template/pull/23"},"issue":{"href":"https://api.github.com/repos/Rise-Vision/common-template/issues/23"},"comments":{"href":"https://api.github.com/repos/Rise-Vision/common-template/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Rise-Vision/common-template/statuses/12c738bcf7a926dc3444e9311fe907412d7e2b1a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stulees"}}