{"action":"created","comment":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/173637697","pull_request_review_id":102865651,"id":173637697,"diff_hunk":"@@ -238,51 +239,52 @@ public void testModifyMetadataV2() throws Exception {\n     checkFooAndBarMeta(aliasName, zkStateReader);\n   }\n \n-  public void testModifyMetadataV1() throws Exception {\n+  @Test\n+  public void testModifyPropertiesV1() throws Exception {\n     // note we don't use TZ in this test, thus it's UTC\n     final String aliasName = getTestName();\n     ZkStateReader zkStateReader = createColectionsAndAlias(aliasName);\n     final String baseUrl = cluster.getRandomJetty(random()).getBaseUrl().toString();\n-    HttpGet get = new HttpGet(baseUrl + \"/admin/collections?action=MODIFYALIAS\" +\n+    HttpGet get = new HttpGet(baseUrl + \"/admin/collections?action=ALIASPROP\" +\n         \"&wt=xml\" +\n         \"&name=\" + aliasName +\n-        \"&metadata.foo=baz\" +\n-        \"&metadata.bar=bam\");\n+        \"&properties.foo=baz\" +","path":"solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java","position":147,"original_position":147,"commit_id":"609e13514cf489e5cb955b3b7745ce2b243bdc20","original_commit_id":"609e13514cf489e5cb955b3b7745ce2b243bdc20","user":{"login":"dsmiley","id":377295,"avatar_url":"https://avatars1.githubusercontent.com/u/377295?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmiley","html_url":"https://github.com/dsmiley","followers_url":"https://api.github.com/users/dsmiley/followers","following_url":"https://api.github.com/users/dsmiley/following{/other_user}","gists_url":"https://api.github.com/users/dsmiley/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmiley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmiley/subscriptions","organizations_url":"https://api.github.com/users/dsmiley/orgs","repos_url":"https://api.github.com/users/dsmiley/repos","events_url":"https://api.github.com/users/dsmiley/events{/privacy}","received_events_url":"https://api.github.com/users/dsmiley/received_events","type":"User","site_admin":false},"body":"I think we want the V1 API prefix for this to be \"property\" since each param occurrence is one property by itself.  This is consistent with various other V1 APIs (See CollectionApiMapping.java search for \"property\").  (My comment here applies to many spots in the diff, not just here of course).","created_at":"2018-03-10T23:00:52Z","updated_at":"2018-03-10T23:00:52Z","html_url":"https://github.com/apache/lucene-solr/pull/335#discussion_r173637697","pull_request_url":"https://api.github.com/repos/apache/lucene-solr/pulls/335","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/173637697"},"html":{"href":"https://github.com/apache/lucene-solr/pull/335#discussion_r173637697"},"pull_request":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/335","id":174188622,"html_url":"https://github.com/apache/lucene-solr/pull/335","diff_url":"https://github.com/apache/lucene-solr/pull/335.diff","patch_url":"https://github.com/apache/lucene-solr/pull/335.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/335","number":335,"state":"open","locked":false,"title":"SOLR-11617 rename alias metadata as alias properties","user":{"login":"nsoft","id":3340874,"avatar_url":"https://avatars2.githubusercontent.com/u/3340874?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoft","html_url":"https://github.com/nsoft","followers_url":"https://api.github.com/users/nsoft/followers","following_url":"https://api.github.com/users/nsoft/following{/other_user}","gists_url":"https://api.github.com/users/nsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoft/subscriptions","organizations_url":"https://api.github.com/users/nsoft/orgs","repos_url":"https://api.github.com/users/nsoft/repos","events_url":"https://api.github.com/users/nsoft/events{/privacy}","received_events_url":"https://api.github.com/users/nsoft/received_events","type":"User","site_admin":false},"body":"Renamed the usage in the API and made the code match where I could to avoid confusion in the future.","created_at":"2018-03-10T20:42:24Z","updated_at":"2018-03-10T23:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"561142d63986fe14de8fdc9af78a9d008bfd7280","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/335/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/335/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/335/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/609e13514cf489e5cb955b3b7745ce2b243bdc20","head":{"label":"nsoft:SOLR-11617-renames","ref":"SOLR-11617-renames","sha":"609e13514cf489e5cb955b3b7745ce2b243bdc20","user":{"login":"nsoft","id":3340874,"avatar_url":"https://avatars2.githubusercontent.com/u/3340874?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoft","html_url":"https://github.com/nsoft","followers_url":"https://api.github.com/users/nsoft/followers","following_url":"https://api.github.com/users/nsoft/following{/other_user}","gists_url":"https://api.github.com/users/nsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoft/subscriptions","organizations_url":"https://api.github.com/users/nsoft/orgs","repos_url":"https://api.github.com/users/nsoft/repos","events_url":"https://api.github.com/users/nsoft/events{/privacy}","received_events_url":"https://api.github.com/users/nsoft/received_events","type":"User","site_admin":false},"repo":{"id":117144032,"name":"lucene-solr","full_name":"nsoft/lucene-solr","owner":{"login":"nsoft","id":3340874,"avatar_url":"https://avatars2.githubusercontent.com/u/3340874?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoft","html_url":"https://github.com/nsoft","followers_url":"https://api.github.com/users/nsoft/followers","following_url":"https://api.github.com/users/nsoft/following{/other_user}","gists_url":"https://api.github.com/users/nsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoft/subscriptions","organizations_url":"https://api.github.com/users/nsoft/orgs","repos_url":"https://api.github.com/users/nsoft/repos","events_url":"https://api.github.com/users/nsoft/events{/privacy}","received_events_url":"https://api.github.com/users/nsoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsoft/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/nsoft/lucene-solr","forks_url":"https://api.github.com/repos/nsoft/lucene-solr/forks","keys_url":"https://api.github.com/repos/nsoft/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsoft/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsoft/lucene-solr/teams","hooks_url":"https://api.github.com/repos/nsoft/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/nsoft/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/nsoft/lucene-solr/events","assignees_url":"https://api.github.com/repos/nsoft/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/nsoft/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/nsoft/lucene-solr/tags","blobs_url":"https://api.github.com/repos/nsoft/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsoft/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsoft/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsoft/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsoft/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/nsoft/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/nsoft/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/nsoft/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/nsoft/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/nsoft/lucene-solr/subscription","commits_url":"https://api.github.com/repos/nsoft/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsoft/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsoft/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsoft/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsoft/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/nsoft/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsoft/lucene-solr/merges","archive_url":"https://api.github.com/repos/nsoft/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsoft/lucene-solr/downloads","issues_url":"https://api.github.com/repos/nsoft/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/nsoft/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/nsoft/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/nsoft/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsoft/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/nsoft/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/nsoft/lucene-solr/deployments","created_at":"2018-01-11T19:32:09Z","updated_at":"2018-01-11T19:32:45Z","pushed_at":"2018-03-10T17:55:25Z","git_url":"git://github.com/nsoft/lucene-solr.git","ssh_url":"git@github.com:nsoft/lucene-solr.git","clone_url":"https://github.com/nsoft/lucene-solr.git","svn_url":"https://github.com/nsoft/lucene-solr","homepage":null,"size":334559,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f1f929b15a4bc0876e8c241bbc184fa870662939","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"name":"lucene-solr","full_name":"apache/lucene-solr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2018-03-09T14:01:56Z","pushed_at":"2018-03-10T20:42:25Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":null,"size":336141,"stargazers_count":1461,"watchers_count":1461,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1233,"mirror_url":null,"archived":false,"open_issues_count":173,"license":null,"forks":1233,"open_issues":173,"watchers":1461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/335"},"html":{"href":"https://github.com/apache/lucene-solr/pull/335"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/335"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/609e13514cf489e5cb955b3b7745ce2b243bdc20"}},"author_association":"NONE"}}
{"actor":{"display_login":"dsmiley"}}