{"action":"created","issue":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/662","repository_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/662/labels{/name}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/662/comments","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/662/events","html_url":"https://github.com/ComputationalRadiationPhysics/alpaka/pull/662","id":364107135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Mzc0NzM0","number":662,"title":"Replace assert with ALPAKA_ASSERT","user":{"login":"tdd11235813","id":16594217,"node_id":"MDQ6VXNlcjE2NTk0MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/16594217?v=4","gravatar_id":"","url":"https://api.github.com/users/tdd11235813","html_url":"https://github.com/tdd11235813","followers_url":"https://api.github.com/users/tdd11235813/followers","following_url":"https://api.github.com/users/tdd11235813/following{/other_user}","gists_url":"https://api.github.com/users/tdd11235813/gists{/gist_id}","starred_url":"https://api.github.com/users/tdd11235813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdd11235813/subscriptions","organizations_url":"https://api.github.com/users/tdd11235813/orgs","repos_url":"https://api.github.com/users/tdd11235813/repos","events_url":"https://api.github.com/users/tdd11235813/events{/privacy}","received_events_url":"https://api.github.com/users/tdd11235813/received_events","type":"User","site_admin":false},"labels":[{"id":278166918,"node_id":"MDU6TGFiZWwyNzgxNjY5MTg=","url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/labels/refactoring","name":"refactoring","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"BenjaminW3","id":8956583,"node_id":"MDQ6VXNlcjg5NTY1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8956583?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminW3","html_url":"https://github.com/BenjaminW3","followers_url":"https://api.github.com/users/BenjaminW3/followers","following_url":"https://api.github.com/users/BenjaminW3/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminW3/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminW3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminW3/subscriptions","organizations_url":"https://api.github.com/users/BenjaminW3/orgs","repos_url":"https://api.github.com/users/BenjaminW3/repos","events_url":"https://api.github.com/users/BenjaminW3/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminW3/received_events","type":"User","site_admin":false},"assignees":[{"login":"BenjaminW3","id":8956583,"node_id":"MDQ6VXNlcjg5NTY1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8956583?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminW3","html_url":"https://github.com/BenjaminW3","followers_url":"https://api.github.com/users/BenjaminW3/followers","following_url":"https://api.github.com/users/BenjaminW3/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminW3/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminW3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminW3/subscriptions","organizations_url":"https://api.github.com/users/BenjaminW3/orgs","repos_url":"https://api.github.com/users/BenjaminW3/repos","events_url":"https://api.github.com/users/BenjaminW3/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminW3/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/milestones/5","html_url":"https://github.com/ComputationalRadiationPhysics/alpaka/milestone/5","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/milestones/5/labels","id":3061847,"node_id":"MDk6TWlsZXN0b25lMzA2MTg0Nw==","number":5,"title":"Version 0.4.0","description":"","creator":{"login":"BenjaminW3","id":8956583,"node_id":"MDQ6VXNlcjg5NTY1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8956583?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminW3","html_url":"https://github.com/BenjaminW3","followers_url":"https://api.github.com/users/BenjaminW3/followers","following_url":"https://api.github.com/users/BenjaminW3/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminW3/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminW3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminW3/subscriptions","organizations_url":"https://api.github.com/users/BenjaminW3/orgs","repos_url":"https://api.github.com/users/BenjaminW3/repos","events_url":"https://api.github.com/users/BenjaminW3/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminW3/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":83,"state":"open","created_at":"2018-01-24T18:44:08Z","updated_at":"2018-09-27T07:45:40Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-09-26T16:10:19Z","updated_at":"2018-09-27T11:15:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/pulls/662","html_url":"https://github.com/ComputationalRadiationPhysics/alpaka/pull/662","diff_url":"https://github.com/ComputationalRadiationPhysics/alpaka/pull/662.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/alpaka/pull/662.patch"},"body":"- these changes came from HIP(HCC) testing branch\r\n- there, an error occurred, when `__assert_fail` does not have the\r\nright host-device signature, which is included with cassert\r\n- in general, we rely on `core/Assert.hpp` anyways\r\n- there, specific assert handling can be done safely for e.g. HIP,\r\nand does not get interfered afterwards by a cassert\r\n\r\nEdit after first review process:\r\n**Replaces assert() with ALPAKA_ASSERT().**\r\n\r\n- use ALPAKA_ASSERT() macro instead of assert()\r\n- now, specific assert handling can be done in core/Assert.hpp\r\n- it is disallowed to include cassert somewhere else,\r\nbecause it can interfere the specified behavior\r\n- at the moment this is only required by the future HIP(HCC) back-end"},"comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/comments/425052765","html_url":"https://github.com/ComputationalRadiationPhysics/alpaka/pull/662#issuecomment-425052765","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/alpaka/issues/662","id":425052765,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTA1Mjc2NQ==","user":{"login":"tdd11235813","id":16594217,"node_id":"MDQ6VXNlcjE2NTk0MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/16594217?v=4","gravatar_id":"","url":"https://api.github.com/users/tdd11235813","html_url":"https://github.com/tdd11235813","followers_url":"https://api.github.com/users/tdd11235813/followers","following_url":"https://api.github.com/users/tdd11235813/following{/other_user}","gists_url":"https://api.github.com/users/tdd11235813/gists{/gist_id}","starred_url":"https://api.github.com/users/tdd11235813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdd11235813/subscriptions","organizations_url":"https://api.github.com/users/tdd11235813/orgs","repos_url":"https://api.github.com/users/tdd11235813/repos","events_url":"https://api.github.com/users/tdd11235813/events{/privacy}","received_events_url":"https://api.github.com/users/tdd11235813/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T11:15:41Z","updated_at":"2018-09-27T11:15:41Z","author_association":"CONTRIBUTOR","body":"k, so it can be merged, when the checks have succeeded."}}
{"actor":{"display_login":"tdd11235813"}}