{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23769","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23769/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23769/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23769/events","html_url":"https://github.com/cockroachdb/cockroach/pull/23769","id":304591604,"number":23769,"title":"roachtest: decommissioning test","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-03-13T00:56:15Z","updated_at":"2018-03-16T11:18:19Z","closed_at":"2018-03-16T01:27:55Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23769","html_url":"https://github.com/cockroachdb/cockroach/pull/23769","diff_url":"https://github.com/cockroachdb/cockroach/pull/23769.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23769.patch"},"body":"Add a test that decommissions and wipes the first node in a cluster\nrepeatedly, alternating between the node being shut down gracefully\nbefore and after the decommissioning operation, while some light load\nis running against the cluster (to manually verify that the qps don't\ndip too much).\n\na TODO is to verify that the logs don't contain the messages that would\nspam the log before https://github.com/cockroachdb/cockroach/pull/23605.\nI wonder if we should really start grepping the logs. An alternative is\nto introduce a metric that would have signaled this and check that\ninstead.\n\nanother TODO is to actually make this work against remote clusters; it's\ncurrently blocked on not being able to look up the internal IP. I think\nwe need to expose the `expander` functionality in `roachprod` to avoid\nhaving to plug these random holes in every PR, though I want\n@petermattis to comment on that suggestion first. (Note that I could\nalso manually execute `roachprod pgurl` and then parse the address\nout, but that's just beating around the bush).\n\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/373683943","html_url":"https://github.com/cockroachdb/cockroach/pull/23769#issuecomment-373683943","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23769","id":373683943,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T11:18:19Z","updated_at":"2018-03-16T11:18:19Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.\n\n---\n\n*[pkg/cmd/roachtest/decommission.go, line 167 at r2](https://beta.reviewable.io/reviews/cockroachdb/cockroach/23769#-L7er9mD2roMJedEuwbO:-L7iWofy6fOunO2RHCH-:b-koekeg) ([raw file](https://github.com/cockroachdb/cockroach/blob/f68b34aa1eb12eee17b8f9123cef5745ceba97fd/pkg/cmd/roachtest/decommission.go#L167)):*\n<details><summary><i>Previously, tschottdorf (Tobias Schottdorf) wrote…</i></summary><blockquote>\n\nBut wouldn't that *require* one at rack zero? I.e. when decommissioning, it wouldn't place that replica elsewhere and so it would hang forever.\n</blockquote></details>\n\nI can't recall for sure. You're probably right.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/cockroachdb/cockroach/23769)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}