{"action":"created","issue":{"url":"https://api.github.com/repos/BobBuildTool/bob/issues/212","repository_url":"https://api.github.com/repos/BobBuildTool/bob","labels_url":"https://api.github.com/repos/BobBuildTool/bob/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/BobBuildTool/bob/issues/212/comments","events_url":"https://api.github.com/repos/BobBuildTool/bob/issues/212/events","html_url":"https://github.com/BobBuildTool/bob/pull/212","id":338690025,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTU5NTMx","number":212,"title":"input: fix missing / duplicated indirectPackages","user":{"login":"rhubert","id":937126,"node_id":"MDQ6VXNlcjkzNzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/937126?v=4","gravatar_id":"","url":"https://api.github.com/users/rhubert","html_url":"https://github.com/rhubert","followers_url":"https://api.github.com/users/rhubert/followers","following_url":"https://api.github.com/users/rhubert/following{/other_user}","gists_url":"https://api.github.com/users/rhubert/gists{/gist_id}","starred_url":"https://api.github.com/users/rhubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhubert/subscriptions","organizations_url":"https://api.github.com/users/rhubert/orgs","repos_url":"https://api.github.com/users/rhubert/repos","events_url":"https://api.github.com/users/rhubert/events{/privacy}","received_events_url":"https://api.github.com/users/rhubert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/BobBuildTool/bob/milestones/1","html_url":"https://github.com/BobBuildTool/bob/milestone/1","labels_url":"https://api.github.com/repos/BobBuildTool/bob/milestones/1/labels","id":2921808,"node_id":"MDk6TWlsZXN0b25lMjkyMTgwOA==","number":1,"title":"0.14","description":"","creator":{"login":"jkloetzke","id":234300,"node_id":"MDQ6VXNlcjIzNDMwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/234300?v=4","gravatar_id":"","url":"https://api.github.com/users/jkloetzke","html_url":"https://github.com/jkloetzke","followers_url":"https://api.github.com/users/jkloetzke/followers","following_url":"https://api.github.com/users/jkloetzke/following{/other_user}","gists_url":"https://api.github.com/users/jkloetzke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkloetzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkloetzke/subscriptions","organizations_url":"https://api.github.com/users/jkloetzke/orgs","repos_url":"https://api.github.com/users/jkloetzke/repos","events_url":"https://api.github.com/users/jkloetzke/events{/privacy}","received_events_url":"https://api.github.com/users/jkloetzke/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2017-11-18T20:36:42Z","updated_at":"2018-07-12T09:58:37Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-07-05T19:00:07Z","updated_at":"2018-07-13T13:16:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BobBuildTool/bob/pulls/212","html_url":"https://github.com/BobBuildTool/bob/pull/212","diff_url":"https://github.com/BobBuildTool/bob/pull/212.diff","patch_url":"https://github.com/BobBuildTool/bob/pull/212.patch"},"body":"With 38bc5df1 the behavior of the indirectPackages filter has been\r\nchanged. This restores the old behavior avoiding duplicate/missing\r\ndependencies.\r\n\r\nI added a small repocase for the 'missing' dependencies. Maybe it was\r\nnot correct before 38bc5df1 and this is not a bug? (Although it looks\r\nstrange to have a dependency twice in the audit trail..)\r\n\r\n[test.tar.gz](https://github.com/BobBuildTool/bob/files/2167846/test.tar.gz)\r\n\r\nThe main difference is, that in \r\n\r\n```\r\n            \"package\" : \"a-foo\",\r\n            \"step\" : \"build\",\r\n```\r\n\r\nthe dependency for `b` is missing:\r\n\r\nBob 0.14:\r\n``` \r\n         \"dependencies\" : {\r\n            \"args\" : [\r\n               \"4cf372d74153954ce130c0f5407baf00841a18dd\", a-bar dist\r\n               \"8715f688fe40af6bc2d1bdd8651afac46c366cd9\"  c dist\r\n            ]\r\n         },\r\n```\r\n\r\nBob 0.13:\r\n```  \r\n         \"dependencies\" : {\r\n            \"args\" : [\r\n               \"9025a0841f1100f142dd1e3a62de9c35d7ac259e\", a-bar dist\r\n               \"094ec0234f473af316d230332ed2d4ff073f4e76\", b dist\r\n               \"e825a6f131bee1adff00890205ed68b6bc1fc8e6\"  c dist\r\n            ]\r\n         },\r\n```"},"comment":{"url":"https://api.github.com/repos/BobBuildTool/bob/issues/comments/404830393","html_url":"https://github.com/BobBuildTool/bob/pull/212#issuecomment-404830393","issue_url":"https://api.github.com/repos/BobBuildTool/bob/issues/212","id":404830393,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgzMDM5Mw==","user":{"login":"rhubert","id":937126,"node_id":"MDQ6VXNlcjkzNzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/937126?v=4","gravatar_id":"","url":"https://api.github.com/users/rhubert","html_url":"https://github.com/rhubert","followers_url":"https://api.github.com/users/rhubert/followers","following_url":"https://api.github.com/users/rhubert/following{/other_user}","gists_url":"https://api.github.com/users/rhubert/gists{/gist_id}","starred_url":"https://api.github.com/users/rhubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhubert/subscriptions","organizations_url":"https://api.github.com/users/rhubert/orgs","repos_url":"https://api.github.com/users/rhubert/repos","events_url":"https://api.github.com/users/rhubert/events{/privacy}","received_events_url":"https://api.github.com/users/rhubert/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T13:16:19Z","updated_at":"2018-07-13T13:16:19Z","author_association":"CONTRIBUTOR","body":":ok_hand: As predicted with this fix the only difference between 0.14 and 0.13 are duplicated dependencies in 0.13. :+1: \r\n\r\nPlease change the author of the 1st commit before merging. "}}
{"actor":{"display_login":"rhubert"}}