{"action":"opened","number":33307,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33307","id":199806587,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODA2NTg3","html_url":"https://github.com/rails/rails/pull/33307","diff_url":"https://github.com/rails/rails/pull/33307.diff","patch_url":"https://github.com/rails/rails/pull/33307.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/33307","number":33307,"state":"open","locked":false,"title":"Improve docs test of has secure password","user":{"login":"bogdanvlviv","id":6443532,"node_id":"MDQ6VXNlcjY0NDM1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6443532?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"body":"- Update `has_secure_password` info in the guide\r\n`has_secure_password` allows configuring name of attribute since #26764.\r\nThis commit adds a mention about it in the Active Model Basics Guide.\r\n\r\n- Improve `SecurePasswordTest#test_authenticate`\r\n  - Ensure that execution of `authenticate`/`authenticate_XXX` returns\r\n`self` if password is correct, otherwise `false` (as mentioned in the documentation).\r\n  - Test `authenticate_password`.","created_at":"2018-07-06T17:31:25Z","updated_at":"2018-07-06T17:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/33307/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/33307/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/33307/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/382b5ca7dda7ee6e4c0adebfda767db6acc407d2","head":{"label":"bogdanvlviv:improve-docs-test-of-has_secure_password","ref":"improve-docs-test-of-has_secure_password","sha":"382b5ca7dda7ee6e4c0adebfda767db6acc407d2","user":{"login":"bogdanvlviv","id":6443532,"node_id":"MDQ6VXNlcjY0NDM1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6443532?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"repo":{"id":54744114,"node_id":"MDEwOlJlcG9zaXRvcnk1NDc0NDExNA==","name":"rails","full_name":"bogdanvlviv/rails","owner":{"login":"bogdanvlviv","id":6443532,"node_id":"MDQ6VXNlcjY0NDM1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6443532?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdanvlviv/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/bogdanvlviv/rails","forks_url":"https://api.github.com/repos/bogdanvlviv/rails/forks","keys_url":"https://api.github.com/repos/bogdanvlviv/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdanvlviv/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdanvlviv/rails/teams","hooks_url":"https://api.github.com/repos/bogdanvlviv/rails/hooks","issue_events_url":"https://api.github.com/repos/bogdanvlviv/rails/issues/events{/number}","events_url":"https://api.github.com/repos/bogdanvlviv/rails/events","assignees_url":"https://api.github.com/repos/bogdanvlviv/rails/assignees{/user}","branches_url":"https://api.github.com/repos/bogdanvlviv/rails/branches{/branch}","tags_url":"https://api.github.com/repos/bogdanvlviv/rails/tags","blobs_url":"https://api.github.com/repos/bogdanvlviv/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdanvlviv/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdanvlviv/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdanvlviv/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdanvlviv/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdanvlviv/rails/languages","stargazers_url":"https://api.github.com/repos/bogdanvlviv/rails/stargazers","contributors_url":"https://api.github.com/repos/bogdanvlviv/rails/contributors","subscribers_url":"https://api.github.com/repos/bogdanvlviv/rails/subscribers","subscription_url":"https://api.github.com/repos/bogdanvlviv/rails/subscription","commits_url":"https://api.github.com/repos/bogdanvlviv/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdanvlviv/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdanvlviv/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdanvlviv/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdanvlviv/rails/contents/{+path}","compare_url":"https://api.github.com/repos/bogdanvlviv/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdanvlviv/rails/merges","archive_url":"https://api.github.com/repos/bogdanvlviv/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdanvlviv/rails/downloads","issues_url":"https://api.github.com/repos/bogdanvlviv/rails/issues{/number}","pulls_url":"https://api.github.com/repos/bogdanvlviv/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdanvlviv/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdanvlviv/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdanvlviv/rails/labels{/name}","releases_url":"https://api.github.com/repos/bogdanvlviv/rails/releases{/id}","deployments_url":"https://api.github.com/repos/bogdanvlviv/rails/deployments","created_at":"2016-03-25T19:54:02Z","updated_at":"2018-06-02T18:47:32Z","pushed_at":"2018-07-06T17:28:32Z","git_url":"git://github.com/bogdanvlviv/rails.git","ssh_url":"git@github.com:bogdanvlviv/rails.git","clone_url":"https://github.com/bogdanvlviv/rails.git","svn_url":"https://github.com/bogdanvlviv/rails","homepage":"http://rubyonrails.org","size":163598,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"a0061d2389a178b093f0d3f64f58236ffbe088e0","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-07-06T16:55:09Z","pushed_at":"2018-07-06T14:05:22Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":164318,"stargazers_count":40114,"watchers_count":40114,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16185,"mirror_url":null,"archived":false,"open_issues_count":1132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16185,"open_issues":1132,"watchers":40114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/33307"},"html":{"href":"https://github.com/rails/rails/pull/33307"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/33307"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/33307/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/33307/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/33307/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/382b5ca7dda7ee6e4c0adebfda767db6acc407d2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":28,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"bogdanvlviv"}}