{"action":"closed","number":328,"pull_request":{"url":"https://api.github.com/repos/serokell/ariadne/pulls/328","id":218970522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTcwNTIy","html_url":"https://github.com/serokell/ariadne/pull/328","diff_url":"https://github.com/serokell/ariadne/pull/328.diff","patch_url":"https://github.com/serokell/ariadne/pull/328.patch","issue_url":"https://api.github.com/repos/serokell/ariadne/issues/328","number":328,"state":"closed","locked":false,"title":"[AD-369] Call newPending in sendTx","user":{"login":"Pastafarianist","id":1315874,"node_id":"MDQ6VXNlcjEzMTU4NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1315874?v=4","gravatar_id":"","url":"https://api.github.com/users/Pastafarianist","html_url":"https://github.com/Pastafarianist","followers_url":"https://api.github.com/users/Pastafarianist/followers","following_url":"https://api.github.com/users/Pastafarianist/following{/other_user}","gists_url":"https://api.github.com/users/Pastafarianist/gists{/gist_id}","starred_url":"https://api.github.com/users/Pastafarianist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pastafarianist/subscriptions","organizations_url":"https://api.github.com/users/Pastafarianist/orgs","repos_url":"https://api.github.com/users/Pastafarianist/repos","events_url":"https://api.github.com/users/Pastafarianist/events{/privacy}","received_events_url":"https://api.github.com/users/Pastafarianist/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\nThis PR reintroduces the `ActiveWallet` & `ActiveWalletLayer` and adds a call to `newPending` to `sendTx`. Design-wise, this goes the opposite way compared to the original implementation (the intent was to add a transaction to the submission layer after a successful call to `newPending`), but this is OK since semantics-wise we do the same thing: we first create a new transaction, then try calling `newPending`, and if the call fails, we propagate the exception without submitting the transaction.\r\n\r\nThe tests now also call `newPending`. This helped fix one of the two failing tests left after AD-167.\r\n\r\nPlease note that this PR is to the AD-167 branch and will have to be rebased on `master` before merging.\r\n\r\n**YT issue:** https://issues.serokell.io/issue/AD-369\r\n\r\n**Checklist:**\r\n\r\n- [x] Updated docs if necessary (not necessary)\r\n- [x] My code complies with the [style guide](docs/code-style.md)\r\n- [x] Tested my changes if they modify code\r\n","created_at":"2018-09-28T13:36:10Z","updated_at":"2018-10-07T19:52:03Z","closed_at":"2018-10-07T19:52:03Z","merged_at":null,"merge_commit_sha":"b1ffda4974236c247de71b49ef2cd1e3337c67fc","assignee":{"login":"Pastafarianist","id":1315874,"node_id":"MDQ6VXNlcjEzMTU4NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1315874?v=4","gravatar_id":"","url":"https://api.github.com/users/Pastafarianist","html_url":"https://github.com/Pastafarianist","followers_url":"https://api.github.com/users/Pastafarianist/followers","following_url":"https://api.github.com/users/Pastafarianist/following{/other_user}","gists_url":"https://api.github.com/users/Pastafarianist/gists{/gist_id}","starred_url":"https://api.github.com/users/Pastafarianist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pastafarianist/subscriptions","organizations_url":"https://api.github.com/users/Pastafarianist/orgs","repos_url":"https://api.github.com/users/Pastafarianist/repos","events_url":"https://api.github.com/users/Pastafarianist/events{/privacy}","received_events_url":"https://api.github.com/users/Pastafarianist/received_events","type":"User","site_admin":false},"assignees":[{"login":"Pastafarianist","id":1315874,"node_id":"MDQ6VXNlcjEzMTU4NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1315874?v=4","gravatar_id":"","url":"https://api.github.com/users/Pastafarianist","html_url":"https://github.com/Pastafarianist","followers_url":"https://api.github.com/users/Pastafarianist/followers","following_url":"https://api.github.com/users/Pastafarianist/following{/other_user}","gists_url":"https://api.github.com/users/Pastafarianist/gists{/gist_id}","starred_url":"https://api.github.com/users/Pastafarianist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pastafarianist/subscriptions","organizations_url":"https://api.github.com/users/Pastafarianist/orgs","repos_url":"https://api.github.com/users/Pastafarianist/repos","events_url":"https://api.github.com/users/Pastafarianist/events{/privacy}","received_events_url":"https://api.github.com/users/Pastafarianist/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"maksbotan","id":275614,"node_id":"MDQ6VXNlcjI3NTYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/275614?v=4","gravatar_id":"","url":"https://api.github.com/users/maksbotan","html_url":"https://github.com/maksbotan","followers_url":"https://api.github.com/users/maksbotan/followers","following_url":"https://api.github.com/users/maksbotan/following{/other_user}","gists_url":"https://api.github.com/users/maksbotan/gists{/gist_id}","starred_url":"https://api.github.com/users/maksbotan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksbotan/subscriptions","organizations_url":"https://api.github.com/users/maksbotan/orgs","repos_url":"https://api.github.com/users/maksbotan/repos","events_url":"https://api.github.com/users/maksbotan/events{/privacy}","received_events_url":"https://api.github.com/users/maksbotan/received_events","type":"User","site_admin":false},{"login":"gromakovsky","id":2556409,"node_id":"MDQ6VXNlcjI1NTY0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2556409?v=4","gravatar_id":"","url":"https://api.github.com/users/gromakovsky","html_url":"https://github.com/gromakovsky","followers_url":"https://api.github.com/users/gromakovsky/followers","following_url":"https://api.github.com/users/gromakovsky/following{/other_user}","gists_url":"https://api.github.com/users/gromakovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/gromakovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gromakovsky/subscriptions","organizations_url":"https://api.github.com/users/gromakovsky/orgs","repos_url":"https://api.github.com/users/gromakovsky/repos","events_url":"https://api.github.com/users/gromakovsky/events{/privacy}","received_events_url":"https://api.github.com/users/gromakovsky/received_events","type":"User","site_admin":false},{"login":"goodsoft","id":2828228,"node_id":"MDQ6VXNlcjI4MjgyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2828228?v=4","gravatar_id":"","url":"https://api.github.com/users/goodsoft","html_url":"https://github.com/goodsoft","followers_url":"https://api.github.com/users/goodsoft/followers","following_url":"https://api.github.com/users/goodsoft/following{/other_user}","gists_url":"https://api.github.com/users/goodsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/goodsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodsoft/subscriptions","organizations_url":"https://api.github.com/users/goodsoft/orgs","repos_url":"https://api.github.com/users/goodsoft/repos","events_url":"https://api.github.com/users/goodsoft/events{/privacy}","received_events_url":"https://api.github.com/users/goodsoft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/serokell/ariadne/pulls/328/commits","review_comments_url":"https://api.github.com/repos/serokell/ariadne/pulls/328/comments","review_comment_url":"https://api.github.com/repos/serokell/ariadne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serokell/ariadne/issues/328/comments","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/9989e27de58a43337814ade9427d48ee754ae404","head":{"label":"serokell:thatguy/ad369-call-newpending-in-sendtx","ref":"thatguy/ad369-call-newpending-in-sendtx","sha":"9989e27de58a43337814ade9427d48ee754ae404","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":122662740,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjI3NDA=","name":"ariadne","full_name":"serokell/ariadne","private":false,"owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serokell/ariadne","description":"An open source Ada wallet for users who need more","fork":false,"url":"https://api.github.com/repos/serokell/ariadne","forks_url":"https://api.github.com/repos/serokell/ariadne/forks","keys_url":"https://api.github.com/repos/serokell/ariadne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/ariadne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/ariadne/teams","hooks_url":"https://api.github.com/repos/serokell/ariadne/hooks","issue_events_url":"https://api.github.com/repos/serokell/ariadne/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/ariadne/events","assignees_url":"https://api.github.com/repos/serokell/ariadne/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/ariadne/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/ariadne/tags","blobs_url":"https://api.github.com/repos/serokell/ariadne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/ariadne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/ariadne/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/ariadne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/ariadne/languages","stargazers_url":"https://api.github.com/repos/serokell/ariadne/stargazers","contributors_url":"https://api.github.com/repos/serokell/ariadne/contributors","subscribers_url":"https://api.github.com/repos/serokell/ariadne/subscribers","subscription_url":"https://api.github.com/repos/serokell/ariadne/subscription","commits_url":"https://api.github.com/repos/serokell/ariadne/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/ariadne/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/ariadne/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/ariadne/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/ariadne/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/ariadne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/ariadne/merges","archive_url":"https://api.github.com/repos/serokell/ariadne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/ariadne/downloads","issues_url":"https://api.github.com/repos/serokell/ariadne/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/ariadne/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/ariadne/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/ariadne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/ariadne/labels{/name}","releases_url":"https://api.github.com/repos/serokell/ariadne/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/ariadne/deployments","created_at":"2018-02-23T19:17:07Z","updated_at":"2018-10-06T16:18:02Z","pushed_at":"2018-10-07T19:52:02Z","git_url":"git://github.com/serokell/ariadne.git","ssh_url":"git@github.com:serokell/ariadne.git","clone_url":"https://github.com/serokell/ariadne.git","svn_url":"https://github.com/serokell/ariadne","homepage":"https://serokell.io/ariadne","size":2955,"stargazers_count":30,"watchers_count":30,"language":"Haskell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":9,"watchers":30,"default_branch":"master"}},"base":{"label":"serokell:thatguy/ad167-port-iohk-tests-0fa0ce6","ref":"thatguy/ad167-port-iohk-tests-0fa0ce6","sha":"713604df7d0211fcea41f40960f1aa24ebcd1f9a","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":122662740,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjI3NDA=","name":"ariadne","full_name":"serokell/ariadne","private":false,"owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serokell/ariadne","description":"An open source Ada wallet for users who need more","fork":false,"url":"https://api.github.com/repos/serokell/ariadne","forks_url":"https://api.github.com/repos/serokell/ariadne/forks","keys_url":"https://api.github.com/repos/serokell/ariadne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/ariadne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/ariadne/teams","hooks_url":"https://api.github.com/repos/serokell/ariadne/hooks","issue_events_url":"https://api.github.com/repos/serokell/ariadne/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/ariadne/events","assignees_url":"https://api.github.com/repos/serokell/ariadne/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/ariadne/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/ariadne/tags","blobs_url":"https://api.github.com/repos/serokell/ariadne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/ariadne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/ariadne/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/ariadne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/ariadne/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/ariadne/languages","stargazers_url":"https://api.github.com/repos/serokell/ariadne/stargazers","contributors_url":"https://api.github.com/repos/serokell/ariadne/contributors","subscribers_url":"https://api.github.com/repos/serokell/ariadne/subscribers","subscription_url":"https://api.github.com/repos/serokell/ariadne/subscription","commits_url":"https://api.github.com/repos/serokell/ariadne/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/ariadne/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/ariadne/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/ariadne/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/ariadne/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/ariadne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/ariadne/merges","archive_url":"https://api.github.com/repos/serokell/ariadne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/ariadne/downloads","issues_url":"https://api.github.com/repos/serokell/ariadne/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/ariadne/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/ariadne/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/ariadne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/ariadne/labels{/name}","releases_url":"https://api.github.com/repos/serokell/ariadne/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/ariadne/deployments","created_at":"2018-02-23T19:17:07Z","updated_at":"2018-10-06T16:18:02Z","pushed_at":"2018-10-07T19:52:02Z","git_url":"git://github.com/serokell/ariadne.git","ssh_url":"git@github.com:serokell/ariadne.git","clone_url":"https://github.com/serokell/ariadne.git","svn_url":"https://github.com/serokell/ariadne","homepage":"https://serokell.io/ariadne","size":2955,"stargazers_count":30,"watchers_count":30,"language":"Haskell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":9,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/328"},"html":{"href":"https://github.com/serokell/ariadne/pull/328"},"issue":{"href":"https://api.github.com/repos/serokell/ariadne/issues/328"},"comments":{"href":"https://api.github.com/repos/serokell/ariadne/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serokell/ariadne/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/serokell/ariadne/statuses/9989e27de58a43337814ade9427d48ee754ae404"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":16,"additions":9571,"deletions":156,"changed_files":69}}
{"actor":{"display_login":"serokell-bot"}}