{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/client_python/issues/358","repository_url":"https://api.github.com/repos/prometheus/client_python","labels_url":"https://api.github.com/repos/prometheus/client_python/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/client_python/issues/358/comments","events_url":"https://api.github.com/repos/prometheus/client_python/issues/358/events","html_url":"https://github.com/prometheus/client_python/pull/358","id":390147922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTc1MzY2","number":358,"title":"parser: ensure samples are of type Sample","user":{"login":"crepererum","id":1529400,"node_id":"MDQ6VXNlcjE1Mjk0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1529400?v=4","gravatar_id":"","url":"https://api.github.com/users/crepererum","html_url":"https://github.com/crepererum","followers_url":"https://api.github.com/users/crepererum/followers","following_url":"https://api.github.com/users/crepererum/following{/other_user}","gists_url":"https://api.github.com/users/crepererum/gists{/gist_id}","starred_url":"https://api.github.com/users/crepererum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crepererum/subscriptions","organizations_url":"https://api.github.com/users/crepererum/orgs","repos_url":"https://api.github.com/users/crepererum/repos","events_url":"https://api.github.com/users/crepererum/events{/privacy}","received_events_url":"https://api.github.com/users/crepererum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-12T09:58:44Z","updated_at":"2018-12-12T16:20:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prometheus/client_python/pulls/358","html_url":"https://github.com/prometheus/client_python/pull/358","diff_url":"https://github.com/prometheus/client_python/pull/358.diff","patch_url":"https://github.com/prometheus/client_python/pull/358.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/prometheus/client_python/issues/comments/446647797","html_url":"https://github.com/prometheus/client_python/pull/358#issuecomment-446647797","issue_url":"https://api.github.com/repos/prometheus/client_python/issues/358","id":446647797,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjY0Nzc5Nw==","user":{"login":"crepererum","id":1529400,"node_id":"MDQ6VXNlcjE1Mjk0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1529400?v=4","gravatar_id":"","url":"https://api.github.com/users/crepererum","html_url":"https://github.com/crepererum","followers_url":"https://api.github.com/users/crepererum/followers","following_url":"https://api.github.com/users/crepererum/following{/other_user}","gists_url":"https://api.github.com/users/crepererum/gists{/gist_id}","starred_url":"https://api.github.com/users/crepererum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crepererum/subscriptions","organizations_url":"https://api.github.com/users/crepererum/orgs","repos_url":"https://api.github.com/users/crepererum/repos","events_url":"https://api.github.com/users/crepererum/events{/privacy}","received_events_url":"https://api.github.com/users/crepererum/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T16:20:39Z","updated_at":"2018-12-12T16:20:39Z","author_association":"NONE","body":"@brian-brazil because [`Sample` is a subtype of `tuple`](https://github.com/prometheus/client_python/blob/master/prometheus_client/samples.py#L39) and therefore the equality treats them as equal. But named attributes (like `sample.value`) do not work for tuples so I think it's important to be consistent here."}}
{"actor":{"display_login":"crepererum"}}