{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/209416519","pull_request_review_id":145436422,"id":209416519,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQxNjUxOQ==","diff_hunk":"@@ -5197,8 +5198,10 @@ void OSDMap::get_random_up_osds_by_subtree(int n,     // whoami\n   if (subtree_type < 1)\n     return;\n   vector<int> subtrees;\n+  std::random_device seed;\n+  std::mt19937 rng(seed());  // Start the randomgenerator","path":"src/osd/OSDMap.cc","position":13,"original_position":13,"commit_id":"552319a943e6f5f8de66951d50eccad15d1bc38e","original_commit_id":"552319a943e6f5f8de66951d50eccad15d1bc38e","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"could you consider using `std::default_random_engine` to be explicit that an acceptable RNG is good enough here.","created_at":"2018-08-11T04:52:58Z","updated_at":"2018-08-11T04:57:13Z","html_url":"https://github.com/ceph/ceph/pull/23533#discussion_r209416519","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/23533","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/209416519"},"html":{"href":"https://github.com/ceph/ceph/pull/23533#discussion_r209416519"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23533"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/23533","id":207591204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTkxMjA0","html_url":"https://github.com/ceph/ceph/pull/23533","diff_url":"https://github.com/ceph/ceph/pull/23533.diff","patch_url":"https://github.com/ceph/ceph/pull/23533.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/23533","number":23533,"state":"open","locked":false,"title":"osd: make random shuffle comply with C++17","user":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"random_shuffle is depriacted in C++14 and removed in C++17 on FreeBSD\n(As per the standard)\n\nSo this code does not compile on FreeBSD with Clang 6\n\nSigned-off-by: Willem Jan Withagen <wjw@digiware.nl>","created_at":"2018-08-10T12:01:08Z","updated_at":"2018-08-11T04:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19cdda0adc6ec26f86fea2a357ae5625b25558c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":1020510748,"node_id":"MDU6TGFiZWwxMDIwNTEwNzQ4","url":"https://api.github.com/repos/ceph/ceph/labels/osd","name":"osd","color":"354391","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/23533/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/23533/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/23533/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/552319a943e6f5f8de66951d50eccad15d1bc38e","head":{"label":"wjwithagen:wjw-fix-random_shuffle","ref":"wjw-fix-random_shuffle","sha":"552319a943e6f5f8de66951d50eccad15d1bc38e","user":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"repo":{"id":50789401,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc4OTQwMQ==","name":"ceph","full_name":"wjwithagen/ceph","owner":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjwithagen/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/wjwithagen/ceph","forks_url":"https://api.github.com/repos/wjwithagen/ceph/forks","keys_url":"https://api.github.com/repos/wjwithagen/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjwithagen/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjwithagen/ceph/teams","hooks_url":"https://api.github.com/repos/wjwithagen/ceph/hooks","issue_events_url":"https://api.github.com/repos/wjwithagen/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/wjwithagen/ceph/events","assignees_url":"https://api.github.com/repos/wjwithagen/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/wjwithagen/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/wjwithagen/ceph/tags","blobs_url":"https://api.github.com/repos/wjwithagen/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjwithagen/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjwithagen/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjwithagen/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjwithagen/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/wjwithagen/ceph/languages","stargazers_url":"https://api.github.com/repos/wjwithagen/ceph/stargazers","contributors_url":"https://api.github.com/repos/wjwithagen/ceph/contributors","subscribers_url":"https://api.github.com/repos/wjwithagen/ceph/subscribers","subscription_url":"https://api.github.com/repos/wjwithagen/ceph/subscription","commits_url":"https://api.github.com/repos/wjwithagen/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjwithagen/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjwithagen/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjwithagen/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjwithagen/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/wjwithagen/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjwithagen/ceph/merges","archive_url":"https://api.github.com/repos/wjwithagen/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjwithagen/ceph/downloads","issues_url":"https://api.github.com/repos/wjwithagen/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/wjwithagen/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/wjwithagen/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/wjwithagen/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjwithagen/ceph/labels{/name}","releases_url":"https://api.github.com/repos/wjwithagen/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/wjwithagen/ceph/deployments","created_at":"2016-01-31T18:48:17Z","updated_at":"2018-08-10T11:55:44Z","pushed_at":"2018-08-10T18:45:35Z","git_url":"git://github.com/wjwithagen/ceph.git","ssh_url":"git@github.com:wjwithagen/ceph.git","clone_url":"https://github.com/wjwithagen/ceph.git","svn_url":"https://github.com/wjwithagen/ceph","homepage":"http://ceph.com","size":287336,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"50f7f7e32eca98820d4541e3b5f8d60625296b0a","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-08-10T21:34:54Z","pushed_at":"2018-08-11T03:46:04Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":303445,"stargazers_count":4912,"watchers_count":4912,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2576,"mirror_url":null,"archived":false,"open_issues_count":719,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2576,"open_issues":719,"watchers":4912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23533"},"html":{"href":"https://github.com/ceph/ceph/pull/23533"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/23533"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/23533/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23533/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23533/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/552319a943e6f5f8de66951d50eccad15d1bc38e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tchaikov"}}