{"action":"created","issue":{"url":"https://api.github.com/repos/noctuid/general.el/issues/140","repository_url":"https://api.github.com/repos/noctuid/general.el","labels_url":"https://api.github.com/repos/noctuid/general.el/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/noctuid/general.el/issues/140/comments","events_url":"https://api.github.com/repos/noctuid/general.el/issues/140/events","html_url":"https://github.com/noctuid/general.el/issues/140","id":391225884,"node_id":"MDU6SXNzdWUzOTEyMjU4ODQ=","number":140,"title":":definer :minor-mode with :genal keyword not working as expected with macrostep mode","user":{"login":"ACEMerlin","id":5625319,"node_id":"MDQ6VXNlcjU2MjUzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5625319?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEMerlin","html_url":"https://github.com/ACEMerlin","followers_url":"https://api.github.com/users/ACEMerlin/followers","following_url":"https://api.github.com/users/ACEMerlin/following{/other_user}","gists_url":"https://api.github.com/users/ACEMerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEMerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEMerlin/subscriptions","organizations_url":"https://api.github.com/users/ACEMerlin/orgs","repos_url":"https://api.github.com/users/ACEMerlin/repos","events_url":"https://api.github.com/users/ACEMerlin/events{/privacy}","received_events_url":"https://api.github.com/users/ACEMerlin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-14T18:53:10Z","updated_at":"2018-12-17T14:49:25Z","closed_at":"2018-12-15T07:21:25Z","author_association":"NONE","body":"Me code:\r\n```lisp\r\n(use-package general)\r\n(use-package evil)\r\n\r\n(use-package macrostep\r\n  :general\r\n  (\"C-c e\" 'macrostep-expand)\r\n  (:definer 'minor-mode\r\n   :states 'normal\r\n   :keymaps 'macrostep-mode\r\n   \"e\"   'macrostep-expand))\r\n```\r\n1. Start emacs and type `C-c e`.\r\n2. Then `C-h k e`, it shows that it's `evil-forward-word-end`.\r\n2. Press `ESC` then `C-h k e`, now it's `macrostep-expand`.\r\n\r\nHowever, if I write this it works fine: \r\n```lisp\r\n(use-package macrostep\r\n  :general\r\n  (\"C-c e\" 'macrostep-expand)\r\n  (:states 'normal\r\n   :keymaps 'macrostep-keymap\r\n   \"e\"   'macrostep-expand)\r\n  :config\r\n  (add-hook 'macrostep-mode-hook #'evil-normalize-keymaps))\r\n```\r\nMy guess is that it has something to do with the name `macrostep-keymap` not being `macrostep-mode-map`, but I don't know how to fix this."},"comment":{"url":"https://api.github.com/repos/noctuid/general.el/issues/comments/447871232","html_url":"https://github.com/noctuid/general.el/issues/140#issuecomment-447871232","issue_url":"https://api.github.com/repos/noctuid/general.el/issues/140","id":447871232,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg3MTIzMg==","user":{"login":"justbur","id":2208382,"node_id":"MDQ6VXNlcjIyMDgzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2208382?v=4","gravatar_id":"","url":"https://api.github.com/users/justbur","html_url":"https://github.com/justbur","followers_url":"https://api.github.com/users/justbur/followers","following_url":"https://api.github.com/users/justbur/following{/other_user}","gists_url":"https://api.github.com/users/justbur/gists{/gist_id}","starred_url":"https://api.github.com/users/justbur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justbur/subscriptions","organizations_url":"https://api.github.com/users/justbur/orgs","repos_url":"https://api.github.com/users/justbur/repos","events_url":"https://api.github.com/users/justbur/events{/privacy}","received_events_url":"https://api.github.com/users/justbur/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T14:49:25Z","updated_at":"2018-12-17T14:49:25Z","author_association":"CONTRIBUTOR","body":"This by itself works for me, so it's not an underlying issue with `evil-define-minor-mode-key` on my machine at least. \r\n\r\n```elisp\r\n(evil-define-minor-mode-key 'normal 'macrostep-mode\r\n    \"e\" 'macrostep-expand)\r\n```"}}
{"actor":{"display_login":"justbur"}}