{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/evmc/pulls/comments/215639361","pull_request_review_id":152948160,"id":215639361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYzOTM2MQ==","diff_hunk":"@@ -75,11 +75,26 @@ TEST_F(evmc_vm_test, set_option_empty_value)\n {\n     if (vm->set_option)\n     {\n-        enum evmc_set_option_result r = vm->set_option(vm, \"unknown_option_csk9twq\", nullptr);\n+        evmc_set_option_result r = vm->set_option(vm, \"unknown_option_csk9twq\", nullptr);\n         EXPECT_EQ(r, EVMC_SET_OPTION_INVALID_NAME);\n     }\n }\n \n+TEST_F(evmc_vm_test, set_option_unknown_value)\n+{\n+    auto r = evmc_set_option(vm, \"verbose\", \"1\");\n+    if (r == EVMC_SET_OPTION_SUCCESS || r == EVMC_SET_OPTION_INVALID_VALUE)","path":"test/vmtester/tests.cpp","position":27,"original_position":27,"commit_id":"60b6759dd3ea273b1412de7631b0740258a11ad7","original_commit_id":"60b6759dd3ea273b1412de7631b0740258a11ad7","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"Perhaps add a comment here so that is clear: execute more tests if the `verbose` as an option name is valid.\r\n\r\nThat being said you may just want to to invert the condition to: `r != EVMC_SET_OPTION_INVALID_NAME`","created_at":"2018-09-06T14:08:19Z","updated_at":"2018-09-06T14:08:19Z","html_url":"https://github.com/ethereum/evmc/pull/149#discussion_r215639361","pull_request_url":"https://api.github.com/repos/ethereum/evmc/pulls/149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/comments/215639361"},"html":{"href":"https://github.com/ethereum/evmc/pull/149#discussion_r215639361"},"pull_request":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/evmc/pulls/149","id":213623839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjIzODM5","html_url":"https://github.com/ethereum/evmc/pull/149","diff_url":"https://github.com/ethereum/evmc/pull/149.diff","patch_url":"https://github.com/ethereum/evmc/pull/149.patch","issue_url":"https://api.github.com/repos/ethereum/evmc/issues/149","number":149,"state":"open","locked":false,"title":"Add test for EVMC_SET_OPTION_INVALID_VALUE","user":{"login":"chfast","id":573380,"node_id":"MDQ6VXNlcjU3MzM4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-06T13:45:27Z","updated_at":"2018-09-06T14:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c90e76c4b8f554e03a84c9dad43bec00e5090e87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/evmc/pulls/149/commits","review_comments_url":"https://api.github.com/repos/ethereum/evmc/pulls/149/comments","review_comment_url":"https://api.github.com/repos/ethereum/evmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/evmc/issues/149/comments","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/60b6759dd3ea273b1412de7631b0740258a11ad7","head":{"label":"ethereum:set-option-test","ref":"set-option-test","sha":"60b6759dd3ea273b1412de7631b0740258a11ad7","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":66214407,"node_id":"MDEwOlJlcG9zaXRvcnk2NjIxNDQwNw==","name":"evmc","full_name":"ethereum/evmc","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/evmc","description":"EVMC – Ethereum Client-VM Connector API","fork":false,"url":"https://api.github.com/repos/ethereum/evmc","forks_url":"https://api.github.com/repos/ethereum/evmc/forks","keys_url":"https://api.github.com/repos/ethereum/evmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmc/teams","hooks_url":"https://api.github.com/repos/ethereum/evmc/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmc/events","assignees_url":"https://api.github.com/repos/ethereum/evmc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmc/tags","blobs_url":"https://api.github.com/repos/ethereum/evmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmc/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmc/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmc/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmc/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmc/subscription","commits_url":"https://api.github.com/repos/ethereum/evmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmc/merges","archive_url":"https://api.github.com/repos/ethereum/evmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmc/downloads","issues_url":"https://api.github.com/repos/ethereum/evmc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmc/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmc/deployments","created_at":"2016-08-21T18:35:02Z","updated_at":"2018-09-06T13:18:36Z","pushed_at":"2018-09-06T13:45:27Z","git_url":"git://github.com/ethereum/evmc.git","ssh_url":"git@github.com:ethereum/evmc.git","clone_url":"https://github.com/ethereum/evmc.git","svn_url":"https://github.com/ethereum/evmc","homepage":"https://ethereum.github.io/evmc","size":753,"stargazers_count":30,"watchers_count":30,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":21,"watchers":30,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"75bcc02ab79150ea208b1d8c7e97f9567d2fd710","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":66214407,"node_id":"MDEwOlJlcG9zaXRvcnk2NjIxNDQwNw==","name":"evmc","full_name":"ethereum/evmc","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/evmc","description":"EVMC – Ethereum Client-VM Connector API","fork":false,"url":"https://api.github.com/repos/ethereum/evmc","forks_url":"https://api.github.com/repos/ethereum/evmc/forks","keys_url":"https://api.github.com/repos/ethereum/evmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmc/teams","hooks_url":"https://api.github.com/repos/ethereum/evmc/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmc/events","assignees_url":"https://api.github.com/repos/ethereum/evmc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmc/tags","blobs_url":"https://api.github.com/repos/ethereum/evmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmc/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmc/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmc/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmc/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmc/subscription","commits_url":"https://api.github.com/repos/ethereum/evmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmc/merges","archive_url":"https://api.github.com/repos/ethereum/evmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmc/downloads","issues_url":"https://api.github.com/repos/ethereum/evmc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmc/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmc/deployments","created_at":"2016-08-21T18:35:02Z","updated_at":"2018-09-06T13:18:36Z","pushed_at":"2018-09-06T13:45:27Z","git_url":"git://github.com/ethereum/evmc.git","ssh_url":"git@github.com:ethereum/evmc.git","clone_url":"https://github.com/ethereum/evmc.git","svn_url":"https://github.com/ethereum/evmc","homepage":"https://ethereum.github.io/evmc","size":753,"stargazers_count":30,"watchers_count":30,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":21,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/149"},"html":{"href":"https://github.com/ethereum/evmc/pull/149"},"issue":{"href":"https://api.github.com/repos/ethereum/evmc/issues/149"},"comments":{"href":"https://api.github.com/repos/ethereum/evmc/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/evmc/statuses/60b6759dd3ea273b1412de7631b0740258a11ad7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"axic"}}