{"action":"created","comment":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/241030655","pull_request_review_id":184198526,"id":241030655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAzMDY1NQ==","diff_hunk":"@@ -0,0 +1,49 @@\n+import {\n+  AppInstanceInfo,\n+  AssetType,\n+  INodeProvider,\n+  Node\n+} from \"@counterfactual/common-types\";\n+import { BigNumber } from \"ethers/utils\";\n+import EventEmitter from \"eventemitter3\";\n+\n+export class TestNodeProvider implements INodeProvider {\n+  public postedMessages: Node.Message[] = [];\n+  readonly callbacks: ((message: Node.Message) => void)[] = [];\n+  readonly messageEmitter: EventEmitter = new EventEmitter();","path":"packages/cf.js/test/fixture.ts","position":null,"original_position":13,"commit_id":"6eae6aa4415bb994dfa373f6591cbf023ae6372d","original_commit_id":"e17d59bd1f988d75caa49a6fe470e56794f1d72d","user":{"login":"joelalejandro","id":118913,"node_id":"MDQ6VXNlcjExODkxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/118913?v=4","gravatar_id":"","url":"https://api.github.com/users/joelalejandro","html_url":"https://github.com/joelalejandro","followers_url":"https://api.github.com/users/joelalejandro/followers","following_url":"https://api.github.com/users/joelalejandro/following{/other_user}","gists_url":"https://api.github.com/users/joelalejandro/gists{/gist_id}","starred_url":"https://api.github.com/users/joelalejandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelalejandro/subscriptions","organizations_url":"https://api.github.com/users/joelalejandro/orgs","repos_url":"https://api.github.com/users/joelalejandro/repos","events_url":"https://api.github.com/users/joelalejandro/events{/privacy}","received_events_url":"https://api.github.com/users/joelalejandro/received_events","type":"User","site_admin":false},"body":"The purpose of a test is to break when we're changing stuff like that, I believe. It makes us be conscious of API changes. Test concerns aren't supposed to affect class architecture.","created_at":"2018-12-12T14:19:07Z","updated_at":"2018-12-12T14:19:07Z","html_url":"https://github.com/counterfactual/monorepo/pull/325#discussion_r241030655","pull_request_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/325","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/241030655"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/325#discussion_r241030655"},"pull_request":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/325"}},"in_reply_to_id":240485645},"pull_request":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/325","id":237464683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDY0Njgz","html_url":"https://github.com/counterfactual/monorepo/pull/325","diff_url":"https://github.com/counterfactual/monorepo/pull/325.diff","patch_url":"https://github.com/counterfactual/monorepo/pull/325.patch","issue_url":"https://api.github.com/repos/counterfactual/monorepo/issues/325","number":325,"state":"open","locked":false,"title":"[CFjs] Add install() and rejectInstall() methods on Provider","user":{"login":"mvanderh","id":8631205,"node_id":"MDQ6VXNlcjg2MzEyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8631205?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanderh","html_url":"https://github.com/mvanderh","followers_url":"https://api.github.com/users/mvanderh/followers","following_url":"https://api.github.com/users/mvanderh/following{/other_user}","gists_url":"https://api.github.com/users/mvanderh/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanderh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanderh/subscriptions","organizations_url":"https://api.github.com/users/mvanderh/orgs","repos_url":"https://api.github.com/users/mvanderh/repos","events_url":"https://api.github.com/users/mvanderh/events{/privacy}","received_events_url":"https://api.github.com/users/mvanderh/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nImplementation of install() and rejectInstall()\r\n\r\nRelies on #324 ","created_at":"2018-12-10T21:01:03Z","updated_at":"2018-12-12T14:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9d377d36fa18806cf11565eb997c36647479e81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/325/commits","review_comments_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/325/comments","review_comment_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/issues/325/comments","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/6eae6aa4415bb994dfa373f6591cbf023ae6372d","head":{"label":"counterfactual:mitch/install-and-reject","ref":"mitch/install-and-reject","sha":"6eae6aa4415bb994dfa373f6591cbf023ae6372d","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-12-12T05:07:31Z","pushed_at":"2018-12-12T13:31:56Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":5627,"stargazers_count":125,"watchers_count":125,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":27,"watchers":125,"default_branch":"master"}},"base":{"label":"counterfactual:master","ref":"master","sha":"d48610d14e4e51a44d5fc74ff759e572e58c6c8a","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-12-12T05:07:31Z","pushed_at":"2018-12-12T13:31:56Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":5627,"stargazers_count":125,"watchers_count":125,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":27,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/325"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/325"},"issue":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/325"},"comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/counterfactual/monorepo/statuses/6eae6aa4415bb994dfa373f6591cbf023ae6372d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joelalejandro"}}