{"action":"created","issue":{"url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/187","repository_url":"https://api.github.com/repos/flowtype/flow-for-vscode","labels_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/187/comments","events_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/187/events","html_url":"https://github.com/flowtype/flow-for-vscode/issues/187","id":276480308,"node_id":"MDU6SXNzdWUyNzY0ODAzMDg=","number":187,"title":"Feature request: Custom language","user":{"login":"ericm546","id":18220990,"node_id":"MDQ6VXNlcjE4MjIwOTkw","avatar_url":"https://avatars2.githubusercontent.com/u/18220990?v=4","gravatar_id":"","url":"https://api.github.com/users/ericm546","html_url":"https://github.com/ericm546","followers_url":"https://api.github.com/users/ericm546/followers","following_url":"https://api.github.com/users/ericm546/following{/other_user}","gists_url":"https://api.github.com/users/ericm546/gists{/gist_id}","starred_url":"https://api.github.com/users/ericm546/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericm546/subscriptions","organizations_url":"https://api.github.com/users/ericm546/orgs","repos_url":"https://api.github.com/users/ericm546/repos","events_url":"https://api.github.com/users/ericm546/events{/privacy}","received_events_url":"https://api.github.com/users/ericm546/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-23T22:31:51Z","updated_at":"2018-10-16T07:38:18Z","closed_at":null,"author_association":"NONE","body":"I'm wondering if it would make sense for this extension to register itself as a new language in vs code. \r\n\r\nIt could include the babel grammar from https://github.com/gandm/language-babel and support all the flow syntax.\r\n\r\nI've been working for a couple of month with an extension that define it as a new language and it's a trade off, but I like it better.\r\n\r\n**Plus**\r\n- It's faster as the javascript vscode engine is not running in the background.\r\n- the completion is not polluted with vscode fuzzy completion\r\n- there is no popup showing 2 times the same definition when doing a go to definition\r\n- you don't have to disable the javascript.validate.enable option\r\n\r\n**Minus**\r\n- Other extensions binded on the javascript language have to know about the new language or offer an option to specify a custom language \r\n  - eslint has the option \"eslint.validate\"\r\n  - prettier had \"prettier.javascriptEnable\", but they remove it in the last version https://github.com/prettier/prettier-vscode/issues/270\r\n- Some builtin vscode javascript features are helpful like the import file completion, but they could always be re-implemented in the extension.\r\n\r\n\r\nAnother option could be to create an second extension that define a language javascriptflow and have this extension support \"javascript\", \"javascriptreact\" and \"javascriptflow\"\r\n\r\nWhat do you think?\r\n\r\nI modified this extension to add a new language here, if anybody want to test: https://github.com/ericm546/flow-for-vscode/blob/master/flow-for-vscode-new-language-0.0.1.vsix"},"comment":{"url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/comments/430133463","html_url":"https://github.com/flowtype/flow-for-vscode/issues/187#issuecomment-430133463","issue_url":"https://api.github.com/repos/flowtype/flow-for-vscode/issues/187","id":430133463,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDEzMzQ2Mw==","user":{"login":"kumarharsh","id":760112,"node_id":"MDQ6VXNlcjc2MDExMg==","avatar_url":"https://avatars1.githubusercontent.com/u/760112?v=4","gravatar_id":"","url":"https://api.github.com/users/kumarharsh","html_url":"https://github.com/kumarharsh","followers_url":"https://api.github.com/users/kumarharsh/followers","following_url":"https://api.github.com/users/kumarharsh/following{/other_user}","gists_url":"https://api.github.com/users/kumarharsh/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarharsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarharsh/subscriptions","organizations_url":"https://api.github.com/users/kumarharsh/orgs","repos_url":"https://api.github.com/users/kumarharsh/repos","events_url":"https://api.github.com/users/kumarharsh/events{/privacy}","received_events_url":"https://api.github.com/users/kumarharsh/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T07:38:18Z","updated_at":"2018-10-16T07:38:18Z","author_association":"NONE","body":"@paul-russo You should use the `Babel-Javascript` by Michael McDermott for the syntax highlighter and grammar. It's far far better than vscode's default. I get the correct syntax highlighting while using that plugin (in fact, the first one is wrong in that case 😉):\r\n\r\n![image](https://user-images.githubusercontent.com/760112/46999842-71add880-d144-11e8-9419-8bda28d61a85.png)\r\n"}}
{"actor":{"display_login":"kumarharsh"}}