{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/241337663","pull_request_review_id":184563631,"id":241337663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTMzNzY2Mw==","diff_hunk":"@@ -97,8 +97,11 @@ def convert_distance_into_number_of_grid_cells(\n             which equates to the requested distance in the x and y direction.\n         distance (Float):\n             Distance in metres.\n-        max_distance_in_grid_cells (int):\n-            Maximum distance in grid cells.\n+\n+    Kwargs:\n+        max_distance_in_grid_cells (int or None):\n+            Maximum distance in grid cells.  Defaults to None, which bypasses\n+            the check.","path":"lib/improver/utilities/spatial.py","position":19,"original_position":19,"commit_id":"55aaf199e1ab92cafeec11a0524b700ee35b9dea","original_commit_id":"55aaf199e1ab92cafeec11a0524b700ee35b9dea","user":{"login":"gavinevans","id":26933341,"node_id":"MDQ6VXNlcjI2OTMzMzQx","avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false},"body":"Thanks for making the changes to this function. Just to complete this, it would be good to add a `Raises` section to the docstring, particularly, as this function raises a lot of different exceptions.","created_at":"2018-12-13T10:01:43Z","updated_at":"2018-12-13T10:02:20Z","html_url":"https://github.com/metoppv/improver/pull/764#discussion_r241337663","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/764","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/241337663"},"html":{"href":"https://github.com/metoppv/improver/pull/764#discussion_r241337663"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/764","id":237985623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTg1NjIz","html_url":"https://github.com/metoppv/improver/pull/764","diff_url":"https://github.com/metoppv/improver/pull/764.diff","patch_url":"https://github.com/metoppv/improver/pull/764.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/764","number":764,"state":"open","locked":false,"title":"CLI to generate target grid with halo for regridding global data","user":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"body":"CLI to create an ancillary file defining the target grid for regridding global data, with a halo for neighbourhood processing.  Includes minor update to spatial utility function.\r\n\r\nTesting:\r\n - [x] Ran tests and they passed OK\r\n - [x] Added new tests for the new feature(s)\r\n","created_at":"2018-12-12T10:30:37Z","updated_at":"2018-12-13T10:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9761351d987657334aa1a9aad419639802868c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/764/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/764/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/764/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/55aaf199e1ab92cafeec11a0524b700ee35b9dea","head":{"label":"cgsandford:IMPRO1028_uk_halo_ancillary","ref":"IMPRO1028_uk_halo_ancillary","sha":"55aaf199e1ab92cafeec11a0524b700ee35b9dea","user":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"repo":{"id":116007441,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwMDc0NDE=","name":"improver","full_name":"cgsandford/improver","private":false,"owner":{"login":"cgsandford","id":35029690,"node_id":"MDQ6VXNlcjM1MDI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/35029690?v=4","gravatar_id":"","url":"https://api.github.com/users/cgsandford","html_url":"https://github.com/cgsandford","followers_url":"https://api.github.com/users/cgsandford/followers","following_url":"https://api.github.com/users/cgsandford/following{/other_user}","gists_url":"https://api.github.com/users/cgsandford/gists{/gist_id}","starred_url":"https://api.github.com/users/cgsandford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgsandford/subscriptions","organizations_url":"https://api.github.com/users/cgsandford/orgs","repos_url":"https://api.github.com/users/cgsandford/repos","events_url":"https://api.github.com/users/cgsandford/events{/privacy}","received_events_url":"https://api.github.com/users/cgsandford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cgsandford/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":true,"url":"https://api.github.com/repos/cgsandford/improver","forks_url":"https://api.github.com/repos/cgsandford/improver/forks","keys_url":"https://api.github.com/repos/cgsandford/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgsandford/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgsandford/improver/teams","hooks_url":"https://api.github.com/repos/cgsandford/improver/hooks","issue_events_url":"https://api.github.com/repos/cgsandford/improver/issues/events{/number}","events_url":"https://api.github.com/repos/cgsandford/improver/events","assignees_url":"https://api.github.com/repos/cgsandford/improver/assignees{/user}","branches_url":"https://api.github.com/repos/cgsandford/improver/branches{/branch}","tags_url":"https://api.github.com/repos/cgsandford/improver/tags","blobs_url":"https://api.github.com/repos/cgsandford/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgsandford/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgsandford/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgsandford/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgsandford/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/cgsandford/improver/languages","stargazers_url":"https://api.github.com/repos/cgsandford/improver/stargazers","contributors_url":"https://api.github.com/repos/cgsandford/improver/contributors","subscribers_url":"https://api.github.com/repos/cgsandford/improver/subscribers","subscription_url":"https://api.github.com/repos/cgsandford/improver/subscription","commits_url":"https://api.github.com/repos/cgsandford/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgsandford/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgsandford/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgsandford/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgsandford/improver/contents/{+path}","compare_url":"https://api.github.com/repos/cgsandford/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgsandford/improver/merges","archive_url":"https://api.github.com/repos/cgsandford/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgsandford/improver/downloads","issues_url":"https://api.github.com/repos/cgsandford/improver/issues{/number}","pulls_url":"https://api.github.com/repos/cgsandford/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/cgsandford/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/cgsandford/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgsandford/improver/labels{/name}","releases_url":"https://api.github.com/repos/cgsandford/improver/releases{/id}","deployments_url":"https://api.github.com/repos/cgsandford/improver/deployments","created_at":"2018-01-02T11:18:00Z","updated_at":"2018-12-10T16:37:38Z","pushed_at":"2018-12-13T08:44:43Z","git_url":"git://github.com/cgsandford/improver.git","ssh_url":"git@github.com:cgsandford/improver.git","clone_url":"https://github.com/cgsandford/improver.git","svn_url":"https://github.com/cgsandford/improver","homepage":"","size":4257,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"59ce20917a848fce90cb91f69b777a9b02d81d88","user":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDc2MQ==","name":"improver","full_name":"metoppv/improver","private":false,"owner":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-12-13T07:50:49Z","pushed_at":"2018-12-13T08:44:44Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":4239,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":82,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/764"},"html":{"href":"https://github.com/metoppv/improver/pull/764"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/764"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/55aaf199e1ab92cafeec11a0524b700ee35b9dea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gavinevans"}}