{"action":"created","issue":{"url":"https://api.github.com/repos/containers/libpod/issues/1830","repository_url":"https://api.github.com/repos/containers/libpod","labels_url":"https://api.github.com/repos/containers/libpod/issues/1830/labels{/name}","comments_url":"https://api.github.com/repos/containers/libpod/issues/1830/comments","events_url":"https://api.github.com/repos/containers/libpod/issues/1830/events","html_url":"https://github.com/containers/libpod/pull/1830","id":382386284,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTA2NTY5","number":1830,"title":"hooks: Add pre-create hooks for runtime-config manipulation","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"id":1070348377,"node_id":"MDU6TGFiZWwxMDcwMzQ4Mzc3","url":"https://api.github.com/repos/containers/libpod/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1069153503,"node_id":"MDU6TGFiZWwxMDY5MTUzNTAz","url":"https://api.github.com/repos/containers/libpod/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-11-19T20:46:43Z","updated_at":"2019-01-02T19:05:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/containers/libpod/pulls/1830","html_url":"https://github.com/containers/libpod/pull/1830","diff_url":"https://github.com/containers/libpod/pull/1830.diff","patch_url":"https://github.com/containers/libpod/pull/1830.patch"},"body":"There's been a lot of discussion over in opencontainers/runc#1811 about how to support the NVIDIA folks and others who want to be able to create devices (possibly after having loaded kernel modules) and bind userspace libraries into the container.  Currently that's happening in the middle of `runc`'s create-time mount handling before the container pivots to its new root directory with `runc`'s incorrectly-timed `prestart` hook trigger (opencontainers/runc#1710).  With this pull request, I extend hooks with a `precreate` stage to allow trusted parties to manipulate the config JSON before calling the runtime's `create`.\n\nI'm recycling the existing `Hook` schema from `pkg/hooks` for this, because we'll want `Timeout` for reliability and `When` to [avoid the expense of fork/exec when a given hook does not need to make config changes][3].\n\nFixes #1828.\n\n[3]: https://github.com/containers/libpod/issues/1828#issuecomment-439888059"},"comment":{"url":"https://api.github.com/repos/containers/libpod/issues/comments/450953358","html_url":"https://github.com/containers/libpod/pull/1830#issuecomment-450953358","issue_url":"https://api.github.com/repos/containers/libpod/issues/1830","id":450953358,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDk1MzM1OA==","user":{"login":"mheon","id":7735048,"node_id":"MDQ6VXNlcjc3MzUwNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T19:05:11Z","updated_at":"2019-01-02T19:05:11Z","author_association":"COLLABORATOR","body":"(I'm sort of doubtful they'll become that common, so I don't think we'll encounter that many issues with them)"}}
{"actor":{"display_login":"mheon"}}