{"action":"created","issue":{"url":"https://api.github.com/repos/apache/thrift/issues/1617","repository_url":"https://api.github.com/repos/apache/thrift","labels_url":"https://api.github.com/repos/apache/thrift/issues/1617/labels{/name}","comments_url":"https://api.github.com/repos/apache/thrift/issues/1617/comments","events_url":"https://api.github.com/repos/apache/thrift/issues/1617/events","html_url":"https://github.com/apache/thrift/pull/1617","id":371968533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mjk1NzA0","number":1617,"title":"THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible)","user":{"login":"robbecker-wf","id":6053699,"node_id":"MDQ6VXNlcjYwNTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6053699?v=4","gravatar_id":"","url":"https://api.github.com/users/robbecker-wf","html_url":"https://github.com/robbecker-wf","followers_url":"https://api.github.com/users/robbecker-wf/followers","following_url":"https://api.github.com/users/robbecker-wf/following{/other_user}","gists_url":"https://api.github.com/users/robbecker-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/robbecker-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbecker-wf/subscriptions","organizations_url":"https://api.github.com/users/robbecker-wf/orgs","repos_url":"https://api.github.com/users/robbecker-wf/repos","events_url":"https://api.github.com/users/robbecker-wf/events{/privacy}","received_events_url":"https://api.github.com/users/robbecker-wf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-19T13:55:39Z","updated_at":"2018-10-22T03:43:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/1617","html_url":"https://github.com/apache/thrift/pull/1617","diff_url":"https://github.com/apache/thrift/pull/1617.diff","patch_url":"https://github.com/apache/thrift/pull/1617.patch"},"body":"# Overview\r\nMake the minimal changes needed to make the dart code compatible with Dart 2 while being backwards compatible with Dart 1. This fixes https://issues.apache.org/jira/browse/THRIFT-4654\r\n\r\n# Changes\r\n - Specify the Dart SDK range in the pubspec.yaml file to allow Dart 1 & 2. NOTE: This does up the minimum from 1.13.0 to 1.24.3 but I don't believe anyone is using that old of a Dart.\r\n - Use the dart2_constant package to adjust constant usage from all caps constant names to camel case constant names. \r\n\r\n# Testing\r\n - [ ] Install dependencies under Dart 1 and Dart 2 by running `pub get`\r\n - [ ] Verify the tests pass by running `pub run test` under Dart 1 and 2 (I did this locally)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/thrift/issues/comments/431735159","html_url":"https://github.com/apache/thrift/pull/1617#issuecomment-431735159","issue_url":"https://api.github.com/repos/apache/thrift/issues/1617","id":431735159,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTczNTE1OQ==","user":{"login":"robbecker-wf","id":6053699,"node_id":"MDQ6VXNlcjYwNTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6053699?v=4","gravatar_id":"","url":"https://api.github.com/users/robbecker-wf","html_url":"https://github.com/robbecker-wf","followers_url":"https://api.github.com/users/robbecker-wf/followers","following_url":"https://api.github.com/users/robbecker-wf/following{/other_user}","gists_url":"https://api.github.com/users/robbecker-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/robbecker-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbecker-wf/subscriptions","organizations_url":"https://api.github.com/users/robbecker-wf/orgs","repos_url":"https://api.github.com/users/robbecker-wf/repos","events_url":"https://api.github.com/users/robbecker-wf/events{/privacy}","received_events_url":"https://api.github.com/users/robbecker-wf/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T03:43:39Z","updated_at":"2018-10-22T03:43:39Z","author_association":"NONE","body":"Thanks for updating the dockerfiles @jeking3 !"}}
{"actor":{"display_login":"robbecker-wf"}}