{"action":"opened","number":1474,"pull_request":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/1474","id":231569417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTY5NDE3","html_url":"https://github.com/ethereum/py-evm/pull/1474","diff_url":"https://github.com/ethereum/py-evm/pull/1474.diff","patch_url":"https://github.com/ethereum/py-evm/pull/1474.patch","issue_url":"https://api.github.com/repos/ethereum/py-evm/issues/1474","number":1474,"state":"open","locked":false,"title":"plugins/ethstats: send 'uptime' to prevent \"NaN%\" display on dashboard.","user":{"login":"veox","id":3036030,"node_id":"MDQ6VXNlcjMwMzYwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3036030?v=4","gravatar_id":"","url":"https://api.github.com/users/veox","html_url":"https://github.com/veox","followers_url":"https://api.github.com/users/veox/followers","following_url":"https://api.github.com/users/veox/following{/other_user}","gists_url":"https://api.github.com/users/veox/gists{/gist_id}","starred_url":"https://api.github.com/users/veox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veox/subscriptions","organizations_url":"https://api.github.com/users/veox/orgs","repos_url":"https://api.github.com/users/veox/repos","events_url":"https://api.github.com/users/veox/events{/privacy}","received_events_url":"https://api.github.com/users/veox/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\n\r\nIf an `uptime` is not submitted, the dashboard displays `NaN%` for the node; and also `NaN%` for the averaged tracked node uptime.\r\n\r\n### How was it fixed?\r\n\r\nHard-coded to \"100%\".\r\n\r\nOriginal JS `ethstats` client keeps count of failed/total data collection/submission events, so that it can showcase downtime. We're not doing this, and perhaps shouldn't (yet); it might be a useful indicator for something like Parity-Ethereum's \"passive\" mode.\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses](https://pbs.twimg.com/media/B1CeupHIAAA2yjv.jpg:small)\r\n\r\nSource: [BuzzFeed's Adorably](https://mobile.twitter.com/Adorably/status/527095681430069248); author unknown","created_at":"2018-11-16T15:38:11Z","updated_at":"2018-11-16T15:38:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1474/commits","review_comments_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1474/comments","review_comment_url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/py-evm/issues/1474/comments","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/27b2e2ff68e4ac8917a96fb439b801f806cfc516","head":{"label":"veox:fix-ethstats-uptime","ref":"fix-ethstats-uptime","sha":"27b2e2ff68e4ac8917a96fb439b801f806cfc516","user":{"login":"veox","id":3036030,"node_id":"MDQ6VXNlcjMwMzYwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3036030?v=4","gravatar_id":"","url":"https://api.github.com/users/veox","html_url":"https://github.com/veox","followers_url":"https://api.github.com/users/veox/followers","following_url":"https://api.github.com/users/veox/following{/other_user}","gists_url":"https://api.github.com/users/veox/gists{/gist_id}","starred_url":"https://api.github.com/users/veox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veox/subscriptions","organizations_url":"https://api.github.com/users/veox/orgs","repos_url":"https://api.github.com/users/veox/repos","events_url":"https://api.github.com/users/veox/events{/privacy}","received_events_url":"https://api.github.com/users/veox/received_events","type":"User","site_admin":false},"repo":{"id":87534221,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUzNDIyMQ==","name":"py-evm","full_name":"veox/py-evm","private":false,"owner":{"login":"veox","id":3036030,"node_id":"MDQ6VXNlcjMwMzYwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3036030?v=4","gravatar_id":"","url":"https://api.github.com/users/veox","html_url":"https://github.com/veox","followers_url":"https://api.github.com/users/veox/followers","following_url":"https://api.github.com/users/veox/following{/other_user}","gists_url":"https://api.github.com/users/veox/gists{/gist_id}","starred_url":"https://api.github.com/users/veox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veox/subscriptions","organizations_url":"https://api.github.com/users/veox/orgs","repos_url":"https://api.github.com/users/veox/repos","events_url":"https://api.github.com/users/veox/events{/privacy}","received_events_url":"https://api.github.com/users/veox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/veox/py-evm","description":"An Ethereum Virtual Machine implementation separate from but inspired by PyEthereum","fork":true,"url":"https://api.github.com/repos/veox/py-evm","forks_url":"https://api.github.com/repos/veox/py-evm/forks","keys_url":"https://api.github.com/repos/veox/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/veox/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/veox/py-evm/teams","hooks_url":"https://api.github.com/repos/veox/py-evm/hooks","issue_events_url":"https://api.github.com/repos/veox/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/veox/py-evm/events","assignees_url":"https://api.github.com/repos/veox/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/veox/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/veox/py-evm/tags","blobs_url":"https://api.github.com/repos/veox/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/veox/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/veox/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/veox/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/veox/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/veox/py-evm/languages","stargazers_url":"https://api.github.com/repos/veox/py-evm/stargazers","contributors_url":"https://api.github.com/repos/veox/py-evm/contributors","subscribers_url":"https://api.github.com/repos/veox/py-evm/subscribers","subscription_url":"https://api.github.com/repos/veox/py-evm/subscription","commits_url":"https://api.github.com/repos/veox/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/veox/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/veox/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/veox/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/veox/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/veox/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/veox/py-evm/merges","archive_url":"https://api.github.com/repos/veox/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/veox/py-evm/downloads","issues_url":"https://api.github.com/repos/veox/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/veox/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/veox/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/veox/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/veox/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/veox/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/veox/py-evm/deployments","created_at":"2017-04-07T10:22:56Z","updated_at":"2018-11-12T20:34:25Z","pushed_at":"2018-11-16T15:31:06Z","git_url":"git://github.com/veox/py-evm.git","ssh_url":"git@github.com:veox/py-evm.git","clone_url":"https://github.com/veox/py-evm.git","svn_url":"https://github.com/veox/py-evm","homepage":null,"size":6024,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"b4ca90b84c775dc1c47c216a12b0e4474f1ab373","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":77478378,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ3ODM3OA==","name":"py-evm","full_name":"ethereum/py-evm","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":false,"url":"https://api.github.com/repos/ethereum/py-evm","forks_url":"https://api.github.com/repos/ethereum/py-evm/forks","keys_url":"https://api.github.com/repos/ethereum/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/py-evm/teams","hooks_url":"https://api.github.com/repos/ethereum/py-evm/hooks","issue_events_url":"https://api.github.com/repos/ethereum/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/py-evm/events","assignees_url":"https://api.github.com/repos/ethereum/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/py-evm/tags","blobs_url":"https://api.github.com/repos/ethereum/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/py-evm/languages","stargazers_url":"https://api.github.com/repos/ethereum/py-evm/stargazers","contributors_url":"https://api.github.com/repos/ethereum/py-evm/contributors","subscribers_url":"https://api.github.com/repos/ethereum/py-evm/subscribers","subscription_url":"https://api.github.com/repos/ethereum/py-evm/subscription","commits_url":"https://api.github.com/repos/ethereum/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/py-evm/merges","archive_url":"https://api.github.com/repos/ethereum/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/py-evm/downloads","issues_url":"https://api.github.com/repos/ethereum/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/py-evm/deployments","created_at":"2016-12-27T19:36:00Z","updated_at":"2018-11-16T09:25:23Z","pushed_at":"2018-11-16T11:55:31Z","git_url":"git://github.com/ethereum/py-evm.git","ssh_url":"git@github.com:ethereum/py-evm.git","clone_url":"https://github.com/ethereum/py-evm.git","svn_url":"https://github.com/ethereum/py-evm","homepage":"https://trinity.ethereum.org/","size":6011,"stargazers_count":726,"watchers_count":726,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":320,"open_issues":129,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1474"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1474"},"issue":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1474"},"comments":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1474/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1474/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1474/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/py-evm/statuses/27b2e2ff68e4ac8917a96fb439b801f806cfc516"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"veox"}}