{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/skipper/pulls/comments/244507394","pull_request_review_id":188420382,"id":244507394,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUwNzM5NA==","diff_hunk":"@@ -122,12 +125,16 @@ func jsonPost(u *url.URL, auth string, doc *tokenIntrospectionInfo, client *http\n \n // doClonedGet requests url with the same headers and query as the\n // incoming request and returns with http statusCode and error.\n-func doClonedGet(u *url.URL, client *http.Client, incoming *http.Request) (int, error) {\n+func doClonedGet(u *url.URL, client *http.Client, incoming *http.Request, tracer opentracing.Tracer,\n+\tparentSpan opentracing.Span, childSpanName string) (int, error) {\n+\tspan := tracer.StartSpan(childSpanName, opentracing.ChildOf(parentSpan.Context()))\n+\tdefer span.Finish()","path":"filters/auth/authclient.go","position":29,"original_position":29,"commit_id":"9e4ddbe723932a336afb1ecfbf8e84ec14757f1f","original_commit_id":"9e4ddbe723932a336afb1ecfbf8e84ec14757f1f","user":{"login":"szuecs","id":50872,"node_id":"MDQ6VXNlcjUwODcy","avatar_url":"https://avatars2.githubusercontent.com/u/50872?v=4","gravatar_id":"","url":"https://api.github.com/users/szuecs","html_url":"https://github.com/szuecs","followers_url":"https://api.github.com/users/szuecs/followers","following_url":"https://api.github.com/users/szuecs/following{/other_user}","gists_url":"https://api.github.com/users/szuecs/gists{/gist_id}","starred_url":"https://api.github.com/users/szuecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szuecs/subscriptions","organizations_url":"https://api.github.com/users/szuecs/orgs","repos_url":"https://api.github.com/users/szuecs/repos","events_url":"https://api.github.com/users/szuecs/events{/privacy}","received_events_url":"https://api.github.com/users/szuecs/received_events","type":"User","site_admin":false},"body":"I think it would be nicer to pass 'span` and move the 3 lines of code to `getWebhook`. ","created_at":"2018-12-29T19:58:38Z","updated_at":"2018-12-29T19:58:38Z","html_url":"https://github.com/zalando/skipper/pull/890#discussion_r244507394","pull_request_url":"https://api.github.com/repos/zalando/skipper/pulls/890","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments/244507394"},"html":{"href":"https://github.com/zalando/skipper/pull/890#discussion_r244507394"},"pull_request":{"href":"https://api.github.com/repos/zalando/skipper/pulls/890"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/skipper/pulls/890","id":240698690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjk4Njkw","html_url":"https://github.com/zalando/skipper/pull/890","diff_url":"https://github.com/zalando/skipper/pull/890.diff","patch_url":"https://github.com/zalando/skipper/pull/890.patch","issue_url":"https://api.github.com/repos/zalando/skipper/issues/890","number":890,"state":"open","locked":false,"title":"Added parent span to context so that it can be used in filters","user":{"login":"arjunrn","id":626536,"node_id":"MDQ6VXNlcjYyNjUzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/626536?v=4","gravatar_id":"","url":"https://api.github.com/users/arjunrn","html_url":"https://github.com/arjunrn","followers_url":"https://api.github.com/users/arjunrn/followers","following_url":"https://api.github.com/users/arjunrn/following{/other_user}","gists_url":"https://api.github.com/users/arjunrn/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunrn/subscriptions","organizations_url":"https://api.github.com/users/arjunrn/orgs","repos_url":"https://api.github.com/users/arjunrn/repos","events_url":"https://api.github.com/users/arjunrn/events{/privacy}","received_events_url":"https://api.github.com/users/arjunrn/received_events","type":"User","site_admin":false},"body":"Added the filter span to filter context so that it can used in the filters. Also implemented opentracing for webhook authentication so that a span is created and propagated forward to the downstream.\r\n\r\nThe result trace looks like as show below:\r\n\r\n![filter-span](https://user-images.githubusercontent.com/626536/50387174-6fdd3400-06f6-11e9-9f4b-95821a88c33b.png)\r\n","created_at":"2018-12-23T20:05:32Z","updated_at":"2018-12-29T19:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6815fd309d36591a8db27431b14e304723c3d99","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vetinari","id":53407,"node_id":"MDQ6VXNlcjUzNDA3","avatar_url":"https://avatars1.githubusercontent.com/u/53407?v=4","gravatar_id":"","url":"https://api.github.com/users/vetinari","html_url":"https://github.com/vetinari","followers_url":"https://api.github.com/users/vetinari/followers","following_url":"https://api.github.com/users/vetinari/following{/other_user}","gists_url":"https://api.github.com/users/vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vetinari/subscriptions","organizations_url":"https://api.github.com/users/vetinari/orgs","repos_url":"https://api.github.com/users/vetinari/repos","events_url":"https://api.github.com/users/vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/vetinari/received_events","type":"User","site_admin":false},{"login":"aryszka","id":733217,"node_id":"MDQ6VXNlcjczMzIxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/733217?v=4","gravatar_id":"","url":"https://api.github.com/users/aryszka","html_url":"https://github.com/aryszka","followers_url":"https://api.github.com/users/aryszka/followers","following_url":"https://api.github.com/users/aryszka/following{/other_user}","gists_url":"https://api.github.com/users/aryszka/gists{/gist_id}","starred_url":"https://api.github.com/users/aryszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aryszka/subscriptions","organizations_url":"https://api.github.com/users/aryszka/orgs","repos_url":"https://api.github.com/users/aryszka/repos","events_url":"https://api.github.com/users/aryszka/events{/privacy}","received_events_url":"https://api.github.com/users/aryszka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/skipper/pulls/890/commits","review_comments_url":"https://api.github.com/repos/zalando/skipper/pulls/890/comments","review_comment_url":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/skipper/issues/890/comments","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/9e4ddbe723932a336afb1ecfbf8e84ec14757f1f","head":{"label":"zalando:global-tracer","ref":"global-tracer","sha":"9e4ddbe723932a336afb1ecfbf8e84ec14757f1f","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38812664,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxMjY2NA==","name":"skipper","full_name":"zalando/skipper","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":false,"url":"https://api.github.com/repos/zalando/skipper","forks_url":"https://api.github.com/repos/zalando/skipper/forks","keys_url":"https://api.github.com/repos/zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/skipper/teams","hooks_url":"https://api.github.com/repos/zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/skipper/events","assignees_url":"https://api.github.com/repos/zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/skipper/tags","blobs_url":"https://api.github.com/repos/zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/zalando/skipper/subscription","commits_url":"https://api.github.com/repos/zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/skipper/merges","archive_url":"https://api.github.com/repos/zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/skipper/downloads","issues_url":"https://api.github.com/repos/zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/skipper/deployments","created_at":"2015-07-09T09:54:40Z","updated_at":"2018-12-29T04:52:48Z","pushed_at":"2018-12-29T00:18:30Z","git_url":"git://github.com/zalando/skipper.git","ssh_url":"git@github.com:zalando/skipper.git","clone_url":"https://github.com/zalando/skipper.git","svn_url":"https://github.com/zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":9212,"stargazers_count":1324,"watchers_count":1324,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":127,"open_issues":109,"watchers":1324,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"4dc10c74ab3b41afc6b681b99fac286912e89852","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38812664,"node_id":"MDEwOlJlcG9zaXRvcnkzODgxMjY2NA==","name":"skipper","full_name":"zalando/skipper","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/skipper","description":"An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress","fork":false,"url":"https://api.github.com/repos/zalando/skipper","forks_url":"https://api.github.com/repos/zalando/skipper/forks","keys_url":"https://api.github.com/repos/zalando/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/skipper/teams","hooks_url":"https://api.github.com/repos/zalando/skipper/hooks","issue_events_url":"https://api.github.com/repos/zalando/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/skipper/events","assignees_url":"https://api.github.com/repos/zalando/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/skipper/tags","blobs_url":"https://api.github.com/repos/zalando/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/skipper/languages","stargazers_url":"https://api.github.com/repos/zalando/skipper/stargazers","contributors_url":"https://api.github.com/repos/zalando/skipper/contributors","subscribers_url":"https://api.github.com/repos/zalando/skipper/subscribers","subscription_url":"https://api.github.com/repos/zalando/skipper/subscription","commits_url":"https://api.github.com/repos/zalando/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/skipper/merges","archive_url":"https://api.github.com/repos/zalando/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/skipper/downloads","issues_url":"https://api.github.com/repos/zalando/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/skipper/labels{/name}","releases_url":"https://api.github.com/repos/zalando/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/skipper/deployments","created_at":"2015-07-09T09:54:40Z","updated_at":"2018-12-29T04:52:48Z","pushed_at":"2018-12-29T00:18:30Z","git_url":"git://github.com/zalando/skipper.git","ssh_url":"git@github.com:zalando/skipper.git","clone_url":"https://github.com/zalando/skipper.git","svn_url":"https://github.com/zalando/skipper","homepage":"https://opensource.zalando.com/skipper/","size":9212,"stargazers_count":1324,"watchers_count":1324,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":127,"open_issues":109,"watchers":1324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/skipper/pulls/890"},"html":{"href":"https://github.com/zalando/skipper/pull/890"},"issue":{"href":"https://api.github.com/repos/zalando/skipper/issues/890"},"comments":{"href":"https://api.github.com/repos/zalando/skipper/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/skipper/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/skipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/skipper/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/skipper/statuses/9e4ddbe723932a336afb1ecfbf8e84ec14757f1f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"szuecs"}}