{"action":"opened","number":6073,"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/6073","id":194226048,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjI2MDQ4","html_url":"https://github.com/kubernetes/charts/pull/6073","diff_url":"https://github.com/kubernetes/charts/pull/6073.diff","patch_url":"https://github.com/kubernetes/charts/pull/6073.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/6073","number":6073,"state":"open","locked":false,"title":"[stable/coredns] Make CoreDNS chart more configurable","user":{"login":"andor44","id":496456,"node_id":"MDQ6VXNlcjQ5NjQ1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/496456?v=4","gravatar_id":"","url":"https://api.github.com/users/andor44","html_url":"https://github.com/andor44","followers_url":"https://api.github.com/users/andor44/followers","following_url":"https://api.github.com/users/andor44/following{/other_user}","gists_url":"https://api.github.com/users/andor44/gists{/gist_id}","starred_url":"https://api.github.com/users/andor44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andor44/subscriptions","organizations_url":"https://api.github.com/users/andor44/orgs","repos_url":"https://api.github.com/users/andor44/repos","events_url":"https://api.github.com/users/andor44/events{/privacy}","received_events_url":"https://api.github.com/users/andor44/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nMakes CoreDNS more configurable. Currently, the chart defines a single server block with a fixed zone, and a fixed set of plugins. Now you can define as many server zones as you want, with any number of zones and plugins.\r\n\r\n**Special notes for your reviewer**:\r\nThis flexibility of course comes at a tradeoff. The chart is not as hands-off anymore, as the plugins aren't known beforehand. That being said, the supplied `values.yaml` produces an almost-identical default `Corefile`, the only difference being that I didn't hardcode the reverse zone for the k8s plugin.\r\nAdditionally, I made the chart \"smart\" by making it automatically derive the ports for the service and the containers based on the server blocks and zones defined. The caveat is that I tried passing an extra argument to my template helpers to determine whether it's templating the service (use key `port`) or the container (use key `containerPort`), but this did not work for reasons described on Slack, to which I didn't receive any answers. Therefore the template helper is essentially repeated twice, with the only difference being a single line.","created_at":"2018-06-12T09:55:31Z","updated_at":"2018-06-12T09:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/6073/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/6073/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/6073/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/958d13e1321331ebeb504ead41cf3bd9a64dbcef","head":{"label":"andor44:master","ref":"master","sha":"958d13e1321331ebeb504ead41cf3bd9a64dbcef","user":{"login":"andor44","id":496456,"node_id":"MDQ6VXNlcjQ5NjQ1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/496456?v=4","gravatar_id":"","url":"https://api.github.com/users/andor44","html_url":"https://github.com/andor44","followers_url":"https://api.github.com/users/andor44/followers","following_url":"https://api.github.com/users/andor44/following{/other_user}","gists_url":"https://api.github.com/users/andor44/gists{/gist_id}","starred_url":"https://api.github.com/users/andor44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andor44/subscriptions","organizations_url":"https://api.github.com/users/andor44/orgs","repos_url":"https://api.github.com/users/andor44/repos","events_url":"https://api.github.com/users/andor44/events{/privacy}","received_events_url":"https://api.github.com/users/andor44/received_events","type":"User","site_admin":false},"repo":{"id":137049513,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwNDk1MTM=","name":"charts","full_name":"andor44/charts","owner":{"login":"andor44","id":496456,"node_id":"MDQ6VXNlcjQ5NjQ1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/496456?v=4","gravatar_id":"","url":"https://api.github.com/users/andor44","html_url":"https://github.com/andor44","followers_url":"https://api.github.com/users/andor44/followers","following_url":"https://api.github.com/users/andor44/following{/other_user}","gists_url":"https://api.github.com/users/andor44/gists{/gist_id}","starred_url":"https://api.github.com/users/andor44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andor44/subscriptions","organizations_url":"https://api.github.com/users/andor44/orgs","repos_url":"https://api.github.com/users/andor44/repos","events_url":"https://api.github.com/users/andor44/events{/privacy}","received_events_url":"https://api.github.com/users/andor44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andor44/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/andor44/charts","forks_url":"https://api.github.com/repos/andor44/charts/forks","keys_url":"https://api.github.com/repos/andor44/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andor44/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andor44/charts/teams","hooks_url":"https://api.github.com/repos/andor44/charts/hooks","issue_events_url":"https://api.github.com/repos/andor44/charts/issues/events{/number}","events_url":"https://api.github.com/repos/andor44/charts/events","assignees_url":"https://api.github.com/repos/andor44/charts/assignees{/user}","branches_url":"https://api.github.com/repos/andor44/charts/branches{/branch}","tags_url":"https://api.github.com/repos/andor44/charts/tags","blobs_url":"https://api.github.com/repos/andor44/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andor44/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andor44/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/andor44/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andor44/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/andor44/charts/languages","stargazers_url":"https://api.github.com/repos/andor44/charts/stargazers","contributors_url":"https://api.github.com/repos/andor44/charts/contributors","subscribers_url":"https://api.github.com/repos/andor44/charts/subscribers","subscription_url":"https://api.github.com/repos/andor44/charts/subscription","commits_url":"https://api.github.com/repos/andor44/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/andor44/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/andor44/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/andor44/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/andor44/charts/contents/{+path}","compare_url":"https://api.github.com/repos/andor44/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andor44/charts/merges","archive_url":"https://api.github.com/repos/andor44/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andor44/charts/downloads","issues_url":"https://api.github.com/repos/andor44/charts/issues{/number}","pulls_url":"https://api.github.com/repos/andor44/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/andor44/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/andor44/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andor44/charts/labels{/name}","releases_url":"https://api.github.com/repos/andor44/charts/releases{/id}","deployments_url":"https://api.github.com/repos/andor44/charts/deployments","created_at":"2018-06-12T09:33:42Z","updated_at":"2018-06-12T09:48:54Z","pushed_at":"2018-06-12T09:48:52Z","git_url":"git://github.com/andor44/charts.git","ssh_url":"git@github.com:andor44/charts.git","clone_url":"https://github.com/andor44/charts.git","svn_url":"https://github.com/andor44/charts","homepage":"","size":8311,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7c2403ad60ce7d68b26a9b4b5f84f5c11a251b92","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-06-12T09:53:27Z","pushed_at":"2018-06-12T09:52:29Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":8319,"stargazers_count":3450,"watchers_count":3450,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2953,"mirror_url":null,"archived":false,"open_issues_count":692,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2953,"open_issues":692,"watchers":3450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6073"},"html":{"href":"https://github.com/kubernetes/charts/pull/6073"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/6073"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/6073/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6073/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6073/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/958d13e1321331ebeb504ead41cf3bd9a64dbcef"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":172,"deletions":135,"changed_files":8}}
{"actor":{"display_login":"andor44"}}