{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/5422","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5422/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5422/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5422/events","html_url":"https://github.com/WordPress/gutenberg/pull/5422","id":302471017,"number":5422,"title":"UI: Refactor PostTitle for easier select, deselect","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"labels":[{"id":596964332,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Chrome","name":"Chrome","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-05T21:31:52Z","updated_at":"2018-03-06T19:53:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/5422","html_url":"https://github.com/WordPress/gutenberg/pull/5422","diff_url":"https://github.com/WordPress/gutenberg/pull/5422.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/5422.patch"},"body":"This pull request seeks to refactor the `PostTitle` component. Initially I started this changeset as merely moving padding from the container element to the textarea to allow it to be more clickable by a few pixels, but quickly discovered this is a complex component and, as far as I can tell until directed otherwise, needlessly so.\r\n\r\nThe user-impacting results of these changes are:\r\n\r\n- Clicking anywhere within the hovered border of the title field selects it (in master, there's `14px` of dead zone padding)\r\n- Clicking anywhere immediately outside the border of the title field unselects it\r\n   - While still preserving clickability of permalink element†\r\n      - †With slight difference in that if clickable target is not inherently focusable, it will be dismissed (e.g. clicking link or \"Copy\" works fine, but clicking \"Permalink:\" text will dismiss)\r\n\r\nThe technical results of these changes are:\r\n\r\n- Removing an unnecessary `div` wrapper\r\n- Reusing [`withFocusOutside`](https://github.com/WordPress/gutenberg/tree/master/components/higher-order/with-focus-outside) to simplify focus outside behaviors and normalize across browsers\r\n\r\nThis should have been multiple separate commits, but it unintentionally turned into a rabbit hole of changes 😬 \r\n\r\n__Testing instructions:__\r\n\r\nVerify that you can easily select and unselect the title field.\r\n\r\nVerify that you can still click the permalink options for a saved post upon selecting the title.\r\n\r\nVerify that the permalink options are dismissed after typing within the field after selected."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/370906642","html_url":"https://github.com/WordPress/gutenberg/pull/5422#issuecomment-370906642","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5422","id":370906642,"user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T19:53:12Z","updated_at":"2018-03-06T19:53:12Z","author_association":"MEMBER","body":"Hmm, another Firefox-specific focus issue 😞 It works in Chrome, I had tested it. Will debug Firefox now..."}}
{"actor":{"display_login":"aduth"}}