{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/169086090","pull_request_review_id":97554899,"id":169086090,"diff_hunk":"@@ -1313,131 +1313,168 @@ object functions {\n   //////////////////////////////////////////////////////////////////////////////////////////////\n \n   /**\n-   * Computes the cosine inverse of the given value; the returned angle is in the range\n-   * 0.0 through pi.\n+   * @return angle in radians whose cosine is `e`, as if computed by [[java.lang.Math#acos]]\n    *\n    * @group math_funcs\n    * @since 1.4.0\n    */\n   def acos(e: Column): Column = withExpr { Acos(e.expr) }\n \n+  // scalastyle:off line.size.limit","path":"sql/core/src/main/scala/org/apache/spark/sql/functions.scala","position":13,"original_position":13,"commit_id":"0a0c4aede61a89465b474d292baf9aef773f7a80","original_commit_id":"0a0c4aede61a89465b474d292baf9aef773f7a80","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars0.githubusercontent.com/u/822522?v=4","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"You should be able to just wrap comments rather than disable this?","created_at":"2018-02-19T14:11:58Z","updated_at":"2018-02-19T14:14:01Z","html_url":"https://github.com/apache/spark/pull/20618#discussion_r169086090","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/20618","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/169086090"},"html":{"href":"https://github.com/apache/spark/pull/20618#discussion_r169086090"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/20618"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20618","id":169315284,"html_url":"https://github.com/apache/spark/pull/20618","diff_url":"https://github.com/apache/spark/pull/20618.diff","patch_url":"https://github.com/apache/spark/pull/20618.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/20618","number":20618,"state":"open","locked":false,"title":"[SPARK-23329][SQL] Fix documentation of trigonometric functions","user":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nProvide more details in trigonometric function documentations. Referenced `java.lang.Math` for further details in the descriptions. \r\n## How was this patch tested?\r\n\r\nRan full build, checked generated documentation manually","created_at":"2018-02-15T09:04:38Z","updated_at":"2018-02-19T14:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6c692886cc334ee78d4b90a569d4d00f6ea606f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/20618/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/20618/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/20618/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0a0c4aede61a89465b474d292baf9aef773f7a80","head":{"label":"misutoth:trigonometric-doc","ref":"trigonometric-doc","sha":"0a0c4aede61a89465b474d292baf9aef773f7a80","user":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"repo":{"id":119835914,"name":"spark","full_name":"misutoth/spark","owner":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misutoth/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/misutoth/spark","forks_url":"https://api.github.com/repos/misutoth/spark/forks","keys_url":"https://api.github.com/repos/misutoth/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misutoth/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misutoth/spark/teams","hooks_url":"https://api.github.com/repos/misutoth/spark/hooks","issue_events_url":"https://api.github.com/repos/misutoth/spark/issues/events{/number}","events_url":"https://api.github.com/repos/misutoth/spark/events","assignees_url":"https://api.github.com/repos/misutoth/spark/assignees{/user}","branches_url":"https://api.github.com/repos/misutoth/spark/branches{/branch}","tags_url":"https://api.github.com/repos/misutoth/spark/tags","blobs_url":"https://api.github.com/repos/misutoth/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misutoth/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misutoth/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/misutoth/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misutoth/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/misutoth/spark/languages","stargazers_url":"https://api.github.com/repos/misutoth/spark/stargazers","contributors_url":"https://api.github.com/repos/misutoth/spark/contributors","subscribers_url":"https://api.github.com/repos/misutoth/spark/subscribers","subscription_url":"https://api.github.com/repos/misutoth/spark/subscription","commits_url":"https://api.github.com/repos/misutoth/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/misutoth/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/misutoth/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/misutoth/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/misutoth/spark/contents/{+path}","compare_url":"https://api.github.com/repos/misutoth/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misutoth/spark/merges","archive_url":"https://api.github.com/repos/misutoth/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misutoth/spark/downloads","issues_url":"https://api.github.com/repos/misutoth/spark/issues{/number}","pulls_url":"https://api.github.com/repos/misutoth/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/misutoth/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/misutoth/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misutoth/spark/labels{/name}","releases_url":"https://api.github.com/repos/misutoth/spark/releases{/id}","deployments_url":"https://api.github.com/repos/misutoth/spark/deployments","created_at":"2018-02-01T12:57:08Z","updated_at":"2018-02-01T12:57:36Z","pushed_at":"2018-02-16T15:47:53Z","git_url":"git://github.com/misutoth/spark.git","ssh_url":"git@github.com:misutoth/spark.git","clone_url":"https://github.com/misutoth/spark.git","svn_url":"https://github.com/misutoth/spark","homepage":null,"size":267646,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1dc2c1d5e85c5f404f470aeb44c1f3c22786bdea","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-02-19T11:17:42Z","pushed_at":"2018-02-19T09:47:26Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":267976,"stargazers_count":16197,"watchers_count":16197,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14981,"mirror_url":null,"archived":false,"open_issues_count":429,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14981,"open_issues":429,"watchers":16197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/20618"},"html":{"href":"https://github.com/apache/spark/pull/20618"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/20618"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/20618/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/20618/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/20618/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0a0c4aede61a89465b474d292baf9aef773f7a80"}},"author_association":"NONE"}}
{"actor":{"display_login":"srowen"}}