{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/182975277","pull_request_review_id":113884370,"id":182975277,"diff_hunk":"@@ -25,9 +25,11 @@\n #include \"rtos/Thread.h\"\n #endif\n #include \"Kernel.h\"\n+#include \"CellularUtil.h\"\n \n using namespace mbed;\n using namespace events;\n+using namespace mbed_cellular_util;","path":"features/cellular/framework/AT/ATHandler.cpp","position":8,"original_position":8,"commit_id":"af5516aa9f9b7570f5d65a765c0bf897f43fc40a","original_commit_id":"af5516aa9f9b7570f5d65a765c0bf897f43fc40a","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"where is this coming from? Why is it not mbed::cellular_util rather?","created_at":"2018-04-20T08:09:37Z","updated_at":"2018-04-20T08:10:20Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6691#discussion_r182975277","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/182975277"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6691#discussion_r182975277"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691","id":182976351,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6691","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6691.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6691.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6691","number":6691,"state":"open","locked":false,"title":"Cellular fixes","user":{"login":"mirelachirica","id":30689715,"avatar_url":"https://avatars3.githubusercontent.com/u/30689715?v=4","gravatar_id":"","url":"https://api.github.com/users/mirelachirica","html_url":"https://github.com/mirelachirica","followers_url":"https://api.github.com/users/mirelachirica/followers","following_url":"https://api.github.com/users/mirelachirica/following{/other_user}","gists_url":"https://api.github.com/users/mirelachirica/gists{/gist_id}","starred_url":"https://api.github.com/users/mirelachirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirelachirica/subscriptions","organizations_url":"https://api.github.com/users/mirelachirica/orgs","repos_url":"https://api.github.com/users/mirelachirica/repos","events_url":"https://api.github.com/users/mirelachirica/events{/privacy}","received_events_url":"https://api.github.com/users/mirelachirica/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nAdded hex string format reading support to AT handler to prevent hex buffer allocations in upper layers. Other minor fixes self explained by commit comments.\r\n\r\n### Pull request type\r\n    \r\n    [X] Fix\r\n    [ ] Refactor\r\n    [ ] New target\r\n    [ ] Feature\r\n    [ ] Breaking change\r\n","created_at":"2018-04-20T07:05:06Z","updated_at":"2018-04-20T08:10:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b077cf4670b25e19a20c0f9fe4cf704ae17cfada","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6691/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/af5516aa9f9b7570f5d65a765c0bf897f43fc40a","head":{"label":"mirelachirica:cellular_fixes","ref":"cellular_fixes","sha":"af5516aa9f9b7570f5d65a765c0bf897f43fc40a","user":{"login":"mirelachirica","id":30689715,"avatar_url":"https://avatars3.githubusercontent.com/u/30689715?v=4","gravatar_id":"","url":"https://api.github.com/users/mirelachirica","html_url":"https://github.com/mirelachirica","followers_url":"https://api.github.com/users/mirelachirica/followers","following_url":"https://api.github.com/users/mirelachirica/following{/other_user}","gists_url":"https://api.github.com/users/mirelachirica/gists{/gist_id}","starred_url":"https://api.github.com/users/mirelachirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirelachirica/subscriptions","organizations_url":"https://api.github.com/users/mirelachirica/orgs","repos_url":"https://api.github.com/users/mirelachirica/repos","events_url":"https://api.github.com/users/mirelachirica/events{/privacy}","received_events_url":"https://api.github.com/users/mirelachirica/received_events","type":"User","site_admin":false},"repo":{"id":124064846,"name":"mbed-os","full_name":"mirelachirica/mbed-os","owner":{"login":"mirelachirica","id":30689715,"avatar_url":"https://avatars3.githubusercontent.com/u/30689715?v=4","gravatar_id":"","url":"https://api.github.com/users/mirelachirica","html_url":"https://github.com/mirelachirica","followers_url":"https://api.github.com/users/mirelachirica/followers","following_url":"https://api.github.com/users/mirelachirica/following{/other_user}","gists_url":"https://api.github.com/users/mirelachirica/gists{/gist_id}","starred_url":"https://api.github.com/users/mirelachirica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirelachirica/subscriptions","organizations_url":"https://api.github.com/users/mirelachirica/orgs","repos_url":"https://api.github.com/users/mirelachirica/repos","events_url":"https://api.github.com/users/mirelachirica/events{/privacy}","received_events_url":"https://api.github.com/users/mirelachirica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mirelachirica/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/mirelachirica/mbed-os","forks_url":"https://api.github.com/repos/mirelachirica/mbed-os/forks","keys_url":"https://api.github.com/repos/mirelachirica/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirelachirica/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirelachirica/mbed-os/teams","hooks_url":"https://api.github.com/repos/mirelachirica/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/mirelachirica/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/mirelachirica/mbed-os/events","assignees_url":"https://api.github.com/repos/mirelachirica/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/mirelachirica/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/mirelachirica/mbed-os/tags","blobs_url":"https://api.github.com/repos/mirelachirica/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirelachirica/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirelachirica/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirelachirica/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirelachirica/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/mirelachirica/mbed-os/languages","stargazers_url":"https://api.github.com/repos/mirelachirica/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/mirelachirica/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/mirelachirica/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/mirelachirica/mbed-os/subscription","commits_url":"https://api.github.com/repos/mirelachirica/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirelachirica/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirelachirica/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirelachirica/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirelachirica/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/mirelachirica/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirelachirica/mbed-os/merges","archive_url":"https://api.github.com/repos/mirelachirica/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirelachirica/mbed-os/downloads","issues_url":"https://api.github.com/repos/mirelachirica/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/mirelachirica/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/mirelachirica/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/mirelachirica/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirelachirica/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/mirelachirica/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/mirelachirica/mbed-os/deployments","created_at":"2018-03-06T10:55:03Z","updated_at":"2018-04-19T12:12:11Z","pushed_at":"2018-04-19T13:25:48Z","git_url":"git://github.com/mirelachirica/mbed-os.git","ssh_url":"git@github.com:mirelachirica/mbed-os.git","clone_url":"https://github.com/mirelachirica/mbed-os.git","svn_url":"https://github.com/mirelachirica/mbed-os","homepage":"https://mbed.com","size":203208,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"42d77ecd134acae07d9e99f87b0606c454bea00e","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-04-20T02:43:23Z","pushed_at":"2018-04-20T07:59:59Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":205233,"stargazers_count":1612,"watchers_count":1612,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1418,"mirror_url":null,"archived":false,"open_issues_count":454,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1418,"open_issues":454,"watchers":1612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6691"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6691"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6691/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6691/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/af5516aa9f9b7570f5d65a765c0bf897f43fc40a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"0xc0170"}}