{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/8255","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/8255/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/8255/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/8255/events","html_url":"https://github.com/nextcloud/server/pull/8255","id":295430015,"number":8255,"title":"Full implement group display names","user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars3.githubusercontent.com/u/213943?v=4","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"labels":[{"id":389003640,"url":"https://api.github.com/repos/nextcloud/server/labels/2.%20developing","name":"2. developing","color":"0052cc","default":false},{"id":386379233,"url":"https://api.github.com/repos/nextcloud/server/labels/enhancement","name":"enhancement","color":"0e8a16","default":true},{"id":386379234,"url":"https://api.github.com/repos/nextcloud/server/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"assignees":[{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/31","html_url":"https://github.com/nextcloud/server/milestone/31","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/31/labels","id":2759863,"number":31,"title":"Nextcloud 14","description":"","creator":{"login":"jancborchardt","id":925062,"avatar_url":"https://avatars2.githubusercontent.com/u/925062?v=4","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":158,"closed_issues":301,"state":"open","created_at":"2017-09-12T11:43:02Z","updated_at":"2018-03-02T15:50:45Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-02-08T08:54:04Z","updated_at":"2018-03-02T16:19:11Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/8255","html_url":"https://github.com/nextcloud/server/pull/8255","diff_url":"https://github.com/nextcloud/server/pull/8255.diff","patch_url":"https://github.com/nextcloud/server/pull/8255.patch"},"body":"- [x] Personal settings show group id instead of display names in list\r\n- [x] Activities use group id instead of display names\r\n- [ ] Select2 in the WorkflowEngine shows the id on load, dropdown and selecting new values works\r\n- [ ] Select2 in the OC.Settings.setupGroupsSelect shows the id on load, dropdown and selecting new values works\r\n- [ ] User management: user group and subadmin selection is messed up\r\n\r\nNeed someone with better JS/select2 skills to solve this.\r\n\r\n### Good patch for testing\r\n```diff\r\ndiff --git a/lib/private/Group/Group.php b/lib/private/Group/Group.php\r\nindex 6795f0e2f5..24e8a7ad00 100644\r\n--- a/lib/private/Group/Group.php\r\n+++ b/lib/private/Group/Group.php\r\n@@ -87,9 +87,9 @@ class Group implements IGroup {\r\n \r\n        public function getDisplayName() {\r\n                if (is_null($this->displayName)) {\r\n-                       return $this->gid;\r\n+                       return 'DisplayName{' . $this->gid . '}';\r\n                }\r\n-               return $this->displayName;\r\n+               return 'DisplayName{' . $this->displayName . '}';\r\n        }\r\n \r\n        /**\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/369970113","html_url":"https://github.com/nextcloud/server/pull/8255#issuecomment-369970113","issue_url":"https://api.github.com/repos/nextcloud/server/issues/8255","id":369970113,"user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T16:19:11Z","updated_at":"2018-03-02T16:19:11Z","author_association":"MEMBER","body":"Select2 issue is a big one!\r\nBasically, since we store only the value of the select (aka groupid) and considering the fact that we only retrieve the groups data onclick on the select, the default text can't be anything else than the group id.\r\nOne solution would be to create the select as html with all of its options and apply select2 directly on it. I didn't test it, but it should work"}}
{"actor":{"display_login":"skjnldsv"}}