{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/5633","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5633/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5633/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5633/events","html_url":"https://github.com/mne-tools/mne-python/pull/5633","id":371955271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mjg1MzY0","number":5633,"title":"[WIP] Expose original units","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-19T13:21:59Z","updated_at":"2018-10-19T14:05:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5633","html_url":"https://github.com/mne-tools/mne-python/pull/5633","diff_url":"https://github.com/mne-tools/mne-python/pull/5633.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5633.patch"},"body":"fixes #5607 \r\n\r\n@agramfort see here: This is how I would imagine it ... for now I only did it for BrainVision ... but this scheme could be repeated for the others as well I think.\r\n\r\nOpinions?"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/431374517","html_url":"https://github.com/mne-tools/mne-python/pull/5633#issuecomment-431374517","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5633","id":431374517,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTM3NDUxNw==","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T14:05:10Z","updated_at":"2018-10-19T14:05:10Z","author_association":"CONTRIBUTOR","body":"> original PR and the sanity-checking one\r\n\r\nI don't follow you there, please help me along:\r\n\r\nWith this PR, all I want to do is exposing the units as they are in the data files in a private attribute, so that MNE-BIDS can use it for downstream processing.\r\n\r\nApart from that, I agree that in the future, it'd be good if the units handled by MNE-Python would be the same that BIDS allows.\r\n\r\nThese are two separate issues for me. What do you want to sanity-check?\r\n"}}
{"actor":{"display_login":"sappelhoff"}}