{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/194043538","pull_request_review_id":127144008,"id":194043538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA0MzUzOA==","diff_hunk":"@@ -559,6 +559,26 @@ std::string CPVRClients::GetBackendHostnameByClientId(int iClientId) const\n   return name;\n }\n \n+int64_t CPVRClients::GetStreamReadChunkSize(const CFileItem &item)\n+{\n+  int64_t iChunkSize = 0;\n+  int iClientID = PVR_INVALID_CLIENT_ID;\n+\n+  if (item.HasPVRChannelInfoTag())\n+    iClientID = item.GetPVRChannelInfoTag()->ClientID();\n+  else if (item.HasPVRRecordingInfoTag())\n+    iClientID = item.GetPVRRecordingInfoTag()->m_iClientId;\n+\n+  if (iClientID != PVR_INVALID_CLIENT_ID)\n+  {\n+    ForCreatedClient(__FUNCTION__, iClientID, [&iChunkSize](const CPVRClientPtr &client) {\n+      return client->GetStreamReadChunkSize(iChunkSize);","path":"xbmc/pvr/addons/PVRClients.cpp","position":17,"original_position":17,"commit_id":"677075626a8d87a27cef9169b5bd281f3dc04c92","original_commit_id":"677075626a8d87a27cef9169b5bd281f3dc04c92","user":{"login":"FernetMenta","id":576009,"node_id":"MDQ6VXNlcjU3NjAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/576009?v=4","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"disregard :)\r\n","created_at":"2018-06-08T12:38:08Z","updated_at":"2018-06-08T12:38:08Z","html_url":"https://github.com/xbmc/xbmc/pull/14002#discussion_r194043538","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14002","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/194043538"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14002#discussion_r194043538"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14002"}},"in_reply_to_id":194042553},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14002","id":193597275,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTk3Mjc1","html_url":"https://github.com/xbmc/xbmc/pull/14002","diff_url":"https://github.com/xbmc/xbmc/pull/14002.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14002.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14002","number":14002,"state":"open","locked":false,"title":"[PVR] Addon API 5.10.0: New API function GetStreamReadChunkSize.","user":{"login":"ksooo","id":3226626,"node_id":"MDQ6VXNlcjMyMjY2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3226626?v=4","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"@FernetMenta as discussed.\r\n\r\nI already adapted pvr.hts and setting chunk size to 64K solved all my buffering problems when playing recordings. ;-)","created_at":"2018-06-08T12:20:53Z","updated_at":"2018-06-08T12:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47c82a7364362836962eb1c1ce3ba9f3185a3851","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":13087449,"node_id":"MDU6TGFiZWwxMzA4NzQ0OQ==","url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1","default":false},{"id":15146247,"node_id":"MDU6TGFiZWwxNTE0NjI0Nw==","url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"009800","default":false},{"id":278206009,"node_id":"MDU6TGFiZWwyNzgyMDYwMDk=","url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR%20API%20Change","name":"PVR API Change","color":"e11d21","default":false},{"id":400751192,"node_id":"MDU6TGFiZWw0MDA3NTExOTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/108","html_url":"https://github.com/xbmc/xbmc/milestone/108","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/108/labels","id":3158033,"node_id":"MDk6TWlsZXN0b25lMzE1ODAzMw==","number":108,"title":"Leia 18.0-alpha2","description":"","creator":{"login":"MartijnKaijser","id":907436,"node_id":"MDQ6VXNlcjkwNzQzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/907436?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":349,"state":"open","created_at":"2018-03-03T07:09:50Z","updated_at":"2018-06-08T12:20:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14002/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14002/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14002/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/677075626a8d87a27cef9169b5bd281f3dc04c92","head":{"label":"ksooo:pvr-api-5-10-0","ref":"pvr-api-5-10-0","sha":"677075626a8d87a27cef9169b5bd281f3dc04c92","user":{"login":"ksooo","id":3226626,"node_id":"MDQ6VXNlcjMyMjY2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3226626?v=4","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"repo":{"id":17368872,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM2ODg3Mg==","name":"xbmc","full_name":"ksooo/xbmc","owner":{"login":"ksooo","id":3226626,"node_id":"MDQ6VXNlcjMyMjY2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3226626?v=4","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksooo/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/ksooo/xbmc","forks_url":"https://api.github.com/repos/ksooo/xbmc/forks","keys_url":"https://api.github.com/repos/ksooo/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksooo/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksooo/xbmc/teams","hooks_url":"https://api.github.com/repos/ksooo/xbmc/hooks","issue_events_url":"https://api.github.com/repos/ksooo/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/ksooo/xbmc/events","assignees_url":"https://api.github.com/repos/ksooo/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/ksooo/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/ksooo/xbmc/tags","blobs_url":"https://api.github.com/repos/ksooo/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksooo/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksooo/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksooo/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksooo/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ksooo/xbmc/languages","stargazers_url":"https://api.github.com/repos/ksooo/xbmc/stargazers","contributors_url":"https://api.github.com/repos/ksooo/xbmc/contributors","subscribers_url":"https://api.github.com/repos/ksooo/xbmc/subscribers","subscription_url":"https://api.github.com/repos/ksooo/xbmc/subscription","commits_url":"https://api.github.com/repos/ksooo/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksooo/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksooo/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksooo/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ksooo/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/ksooo/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksooo/xbmc/merges","archive_url":"https://api.github.com/repos/ksooo/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksooo/xbmc/downloads","issues_url":"https://api.github.com/repos/ksooo/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/ksooo/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ksooo/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ksooo/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksooo/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/ksooo/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/ksooo/xbmc/deployments","created_at":"2014-03-03T14:45:39Z","updated_at":"2018-06-04T18:01:12Z","pushed_at":"2018-06-08T11:53:54Z","git_url":"git://github.com/ksooo/xbmc.git","ssh_url":"git@github.com:ksooo/xbmc.git","clone_url":"https://github.com/ksooo/xbmc.git","svn_url":"https://github.com/ksooo/xbmc","homepage":"http://xbmc.org","size":618711,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"e8625303fb4184a50afe89a1533c9bd8f2bfd087","user":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NjE0","name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2018-06-08T11:52:04Z","pushed_at":"2018-06-08T12:20:54Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1447564,"stargazers_count":7080,"watchers_count":7080,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4638,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4638,"open_issues":140,"watchers":7080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14002"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14002"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14002"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14002/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14002/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14002/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/677075626a8d87a27cef9169b5bd281f3dc04c92"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"FernetMenta"}}