{"action":"created","issue":{"url":"https://api.github.com/repos/dylanaraps/neofetch/issues/904","repository_url":"https://api.github.com/repos/dylanaraps/neofetch","labels_url":"https://api.github.com/repos/dylanaraps/neofetch/issues/904/labels{/name}","comments_url":"https://api.github.com/repos/dylanaraps/neofetch/issues/904/comments","events_url":"https://api.github.com/repos/dylanaraps/neofetch/issues/904/events","html_url":"https://github.com/dylanaraps/neofetch/pull/904","id":293759707,"number":904,"title":"macOS fixes & improvements","user":{"login":"JadeMatrix","id":1753533,"avatar_url":"https://avatars3.githubusercontent.com/u/1753533?v=4","gravatar_id":"","url":"https://api.github.com/users/JadeMatrix","html_url":"https://github.com/JadeMatrix","followers_url":"https://api.github.com/users/JadeMatrix/followers","following_url":"https://api.github.com/users/JadeMatrix/following{/other_user}","gists_url":"https://api.github.com/users/JadeMatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/JadeMatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JadeMatrix/subscriptions","organizations_url":"https://api.github.com/users/JadeMatrix/orgs","repos_url":"https://api.github.com/users/JadeMatrix/repos","events_url":"https://api.github.com/users/JadeMatrix/events{/privacy}","received_events_url":"https://api.github.com/users/JadeMatrix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-02T03:14:04Z","updated_at":"2018-02-02T22:08:54Z","closed_at":"2018-02-02T22:07:10Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dylanaraps/neofetch/pulls/904","html_url":"https://github.com/dylanaraps/neofetch/pull/904","diff_url":"https://github.com/dylanaraps/neofetch/pull/904.diff","patch_url":"https://github.com/dylanaraps/neofetch/pull/904.patch"},"body":"## Description\r\n\r\nFixes #902 as well as makes a few fixes/tweaks for macOS; tested on 10.12.6\r\n\r\n## Features\r\n\r\n* Feature detection on macOS that relies on AppleScript snippets works again (#902)\r\n* Music player detection on macOS is now more reliable at detecting iTunes vs. Spotify — no guarantees made if both are running (looks like it prefers iTunes on my machine)\r\n* Now detects Light vs. Dark theme in addition to Blue vs. Graphite, outputting `WM Theme: Blue (Light)` (for example)\r\n* neofetch's `uppercase()` function no longer prevents feature detection under `bash` < v4\r\n\r\n## Issues\r\n\r\n* Music player detection is still not perfect — ideally it would use fancier regex to ignore the iTunes Helper and Spotify daemons, but then the `grep` would match itself, so that would have to be handled as a failure to match any player.  This shouldn't be too much of a problem, because even if a user doesn't have Spotify installed or iTunes running, iTunes Helper will be running, so `grep` will match something.  The app-is-running checks in the AppleScript segments then keep neofetch from opening iTunes/Spotify simply to check if they're playing music.\r\n\r\n## TODO\r\n\r\n- [ ] Test if this works on non-macOS systems"},"comment":{"url":"https://api.github.com/repos/dylanaraps/neofetch/issues/comments/362722126","html_url":"https://github.com/dylanaraps/neofetch/pull/904#issuecomment-362722126","issue_url":"https://api.github.com/repos/dylanaraps/neofetch/issues/904","id":362722126,"user":{"login":"JadeMatrix","id":1753533,"avatar_url":"https://avatars3.githubusercontent.com/u/1753533?v=4","gravatar_id":"","url":"https://api.github.com/users/JadeMatrix","html_url":"https://github.com/JadeMatrix","followers_url":"https://api.github.com/users/JadeMatrix/followers","following_url":"https://api.github.com/users/JadeMatrix/following{/other_user}","gists_url":"https://api.github.com/users/JadeMatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/JadeMatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JadeMatrix/subscriptions","organizations_url":"https://api.github.com/users/JadeMatrix/orgs","repos_url":"https://api.github.com/users/JadeMatrix/repos","events_url":"https://api.github.com/users/JadeMatrix/events{/privacy}","received_events_url":"https://api.github.com/users/JadeMatrix/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T22:08:54Z","updated_at":"2018-02-02T22:08:54Z","author_association":"CONTRIBUTOR","body":"Cool, I'll keep an eye on the issues to see if anything comes up 👍"}}
{"actor":{"display_login":"JadeMatrix"}}