{"action":"created","comment":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/232438351","pull_request_review_id":173646598,"id":232438351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQzODM1MQ==","diff_hunk":"@@ -213,10 +214,9 @@ func (m *MigrationController) migrateVolumes(migration *storkv1.Migration) error\n \t\t// Now check if there is any failure or success\n \t\t// TODO: On failure of one volume cancel other migrations?\n \t\tfor _, vInfo := range volumeInfos {\n-\t\t\t// Return if we have any volume migrations still in progress\n \t\t\tif vInfo.Status == storkv1.MigrationStatusInProgress {\n \t\t\t\tlogrus.Infof(\"Volume Migration still in progress: %v\", migration.Name)","path":"pkg/migration/controllers/migration.go","position":87,"original_position":14,"commit_id":"e201ae91fe9e73abe051a7ee3fc1a37b2f82b328","original_commit_id":"e201ae91fe9e73abe051a7ee3fc1a37b2f82b328","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t\t\tlogrus.Infof(\"Volume %v migration still in progress\", vInfo.Volume)\r\n```","created_at":"2018-11-10T02:31:14Z","updated_at":"2018-11-10T02:31:26Z","html_url":"https://github.com/libopenstorage/stork/pull/189#discussion_r232438351","pull_request_url":"https://api.github.com/repos/libopenstorage/stork/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/232438351"},"html":{"href":"https://github.com/libopenstorage/stork/pull/189#discussion_r232438351"},"pull_request":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/189","id":229570137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTcwMTM3","html_url":"https://github.com/libopenstorage/stork/pull/189","diff_url":"https://github.com/libopenstorage/stork/pull/189.diff","patch_url":"https://github.com/libopenstorage/stork/pull/189.patch","issue_url":"https://api.github.com/repos/libopenstorage/stork/issues/189","number":189,"state":"open","locked":false,"title":"Make sure namespaces exists before starting migration","user":{"login":"disrani-px","id":25230810,"node_id":"MDQ6VXNlcjI1MjMwODEw","avatar_url":"https://avatars3.githubusercontent.com/u/25230810?v=4","gravatar_id":"","url":"https://api.github.com/users/disrani-px","html_url":"https://github.com/disrani-px","followers_url":"https://api.github.com/users/disrani-px/followers","following_url":"https://api.github.com/users/disrani-px/following{/other_user}","gists_url":"https://api.github.com/users/disrani-px/gists{/gist_id}","starred_url":"https://api.github.com/users/disrani-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disrani-px/subscriptions","organizations_url":"https://api.github.com/users/disrani-px/orgs","repos_url":"https://api.github.com/users/disrani-px/repos","events_url":"https://api.github.com/users/disrani-px/events{/privacy}","received_events_url":"https://api.github.com/users/disrani-px/received_events","type":"User","site_admin":false},"body":"Also don't check for volume migration status if none are being migrated","created_at":"2018-11-09T02:30:45Z","updated_at":"2018-11-10T02:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ac865d13071062ba5e6fb8dd3f2e1aebcd08f24","assignee":null,"assignees":[],"requested_reviewers":[{"login":"piyush-nimbalkar","id":313758,"node_id":"MDQ6VXNlcjMxMzc1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/313758?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush-nimbalkar","html_url":"https://github.com/piyush-nimbalkar","followers_url":"https://api.github.com/users/piyush-nimbalkar/followers","following_url":"https://api.github.com/users/piyush-nimbalkar/following{/other_user}","gists_url":"https://api.github.com/users/piyush-nimbalkar/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush-nimbalkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush-nimbalkar/subscriptions","organizations_url":"https://api.github.com/users/piyush-nimbalkar/orgs","repos_url":"https://api.github.com/users/piyush-nimbalkar/repos","events_url":"https://api.github.com/users/piyush-nimbalkar/events{/privacy}","received_events_url":"https://api.github.com/users/piyush-nimbalkar/received_events","type":"User","site_admin":false},{"login":"talakad","id":13106822,"node_id":"MDQ6VXNlcjEzMTA2ODIy","avatar_url":"https://avatars3.githubusercontent.com/u/13106822?v=4","gravatar_id":"","url":"https://api.github.com/users/talakad","html_url":"https://github.com/talakad","followers_url":"https://api.github.com/users/talakad/followers","following_url":"https://api.github.com/users/talakad/following{/other_user}","gists_url":"https://api.github.com/users/talakad/gists{/gist_id}","starred_url":"https://api.github.com/users/talakad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talakad/subscriptions","organizations_url":"https://api.github.com/users/talakad/orgs","repos_url":"https://api.github.com/users/talakad/repos","events_url":"https://api.github.com/users/talakad/events{/privacy}","received_events_url":"https://api.github.com/users/talakad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/stork/pulls/189/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/stork/pulls/189/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/stork/issues/189/comments","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/e201ae91fe9e73abe051a7ee3fc1a37b2f82b328","head":{"label":"libopenstorage:migration","ref":"migration","sha":"e201ae91fe9e73abe051a7ee3fc1a37b2f82b328","user":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":102562155,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NjIxNTU=","name":"stork","full_name":"libopenstorage/stork","private":false,"owner":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libopenstorage/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":false,"url":"https://api.github.com/repos/libopenstorage/stork","forks_url":"https://api.github.com/repos/libopenstorage/stork/forks","keys_url":"https://api.github.com/repos/libopenstorage/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/stork/teams","hooks_url":"https://api.github.com/repos/libopenstorage/stork/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/stork/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/stork/events","assignees_url":"https://api.github.com/repos/libopenstorage/stork/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/stork/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/stork/tags","blobs_url":"https://api.github.com/repos/libopenstorage/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/stork/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/stork/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/stork/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/stork/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/stork/subscription","commits_url":"https://api.github.com/repos/libopenstorage/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/stork/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/stork/merges","archive_url":"https://api.github.com/repos/libopenstorage/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/stork/downloads","issues_url":"https://api.github.com/repos/libopenstorage/stork/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/stork/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/stork/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/stork/deployments","created_at":"2017-09-06T04:20:51Z","updated_at":"2018-11-09T22:59:09Z","pushed_at":"2018-11-10T02:21:35Z","git_url":"git://github.com/libopenstorage/stork.git","ssh_url":"git@github.com:libopenstorage/stork.git","clone_url":"https://github.com/libopenstorage/stork.git","svn_url":"https://github.com/libopenstorage/stork","homepage":"","size":13875,"stargazers_count":97,"watchers_count":97,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":12,"watchers":97,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"59cd317e89dfe11c002e05efe8ef395e02ec7876","user":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":102562155,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NjIxNTU=","name":"stork","full_name":"libopenstorage/stork","private":false,"owner":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libopenstorage/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":false,"url":"https://api.github.com/repos/libopenstorage/stork","forks_url":"https://api.github.com/repos/libopenstorage/stork/forks","keys_url":"https://api.github.com/repos/libopenstorage/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/stork/teams","hooks_url":"https://api.github.com/repos/libopenstorage/stork/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/stork/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/stork/events","assignees_url":"https://api.github.com/repos/libopenstorage/stork/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/stork/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/stork/tags","blobs_url":"https://api.github.com/repos/libopenstorage/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/stork/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/stork/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/stork/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/stork/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/stork/subscription","commits_url":"https://api.github.com/repos/libopenstorage/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/stork/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/stork/merges","archive_url":"https://api.github.com/repos/libopenstorage/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/stork/downloads","issues_url":"https://api.github.com/repos/libopenstorage/stork/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/stork/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/stork/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/stork/deployments","created_at":"2017-09-06T04:20:51Z","updated_at":"2018-11-09T22:59:09Z","pushed_at":"2018-11-10T02:21:35Z","git_url":"git://github.com/libopenstorage/stork.git","ssh_url":"git@github.com:libopenstorage/stork.git","clone_url":"https://github.com/libopenstorage/stork.git","svn_url":"https://github.com/libopenstorage/stork","homepage":"","size":13875,"stargazers_count":97,"watchers_count":97,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":12,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/189"},"html":{"href":"https://github.com/libopenstorage/stork/pull/189"},"issue":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/189"},"comments":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/stork/statuses/e201ae91fe9e73abe051a7ee3fc1a37b2f82b328"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"harsh-px"}}