{"action":"created","issue":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1039","repository_url":"https://api.github.com/repos/gaearon/react-hot-loader","labels_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1039/labels{/name}","comments_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1039/comments","events_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1039/events","html_url":"https://github.com/gaearon/react-hot-loader/issues/1039","id":346584535,"node_id":"MDU6SXNzdWUzNDY1ODQ1MzU=","number":1039,"title":"Restore Webpack loader (and use it for TS)","user":{"login":"theKashey","id":582410,"node_id":"MDQ6VXNlcjU4MjQxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/582410?v=4","gravatar_id":"","url":"https://api.github.com/users/theKashey","html_url":"https://github.com/theKashey","followers_url":"https://api.github.com/users/theKashey/followers","following_url":"https://api.github.com/users/theKashey/following{/other_user}","gists_url":"https://api.github.com/users/theKashey/gists{/gist_id}","starred_url":"https://api.github.com/users/theKashey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theKashey/subscriptions","organizations_url":"https://api.github.com/users/theKashey/orgs","repos_url":"https://api.github.com/users/theKashey/repos","events_url":"https://api.github.com/users/theKashey/events{/privacy}","received_events_url":"https://api.github.com/users/theKashey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"theKashey","id":582410,"node_id":"MDQ6VXNlcjU4MjQxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/582410?v=4","gravatar_id":"","url":"https://api.github.com/users/theKashey","html_url":"https://github.com/theKashey","followers_url":"https://api.github.com/users/theKashey/followers","following_url":"https://api.github.com/users/theKashey/following{/other_user}","gists_url":"https://api.github.com/users/theKashey/gists{/gist_id}","starred_url":"https://api.github.com/users/theKashey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theKashey/subscriptions","organizations_url":"https://api.github.com/users/theKashey/orgs","repos_url":"https://api.github.com/users/theKashey/repos","events_url":"https://api.github.com/users/theKashey/events{/privacy}","received_events_url":"https://api.github.com/users/theKashey/received_events","type":"User","site_admin":false},"assignees":[{"login":"theKashey","id":582410,"node_id":"MDQ6VXNlcjU4MjQxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/582410?v=4","gravatar_id":"","url":"https://api.github.com/users/theKashey","html_url":"https://github.com/theKashey","followers_url":"https://api.github.com/users/theKashey/followers","following_url":"https://api.github.com/users/theKashey/following{/other_user}","gists_url":"https://api.github.com/users/theKashey/gists{/gist_id}","starred_url":"https://api.github.com/users/theKashey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theKashey/subscriptions","organizations_url":"https://api.github.com/users/theKashey/orgs","repos_url":"https://api.github.com/users/theKashey/repos","events_url":"https://api.github.com/users/theKashey/events{/privacy}","received_events_url":"https://api.github.com/users/theKashey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-08-01T12:46:39Z","updated_at":"2018-12-21T03:02:48Z","closed_at":"2018-12-21T03:02:48Z","author_association":"COLLABORATOR","body":"- React-Hot-Loader v1 uses webpack loader\r\n- React-Hot-Loader v3 uses webpack loader\r\n- But React-Hot-Loader v4 removes it, as long, from one point of view it was not needed anymore, and from another - we need babel plugin to properly work in the new ES6 world.\r\n\r\nThen we have invented \"cold API\", and got reasons to get webpack loader back - just to register variables in node_modules as fast as possible.\r\n\r\nThen we started thinking about better TypeScript support, and it's too many variants, and all are not \"better\" - as long they are about replacing TS by babel 7 or running babel before or after TS.\r\n\r\nAll those variants are or slow, or unacceptable by \"hey, it's babel free zone here!\" reasons.\r\n\r\nIdea: \r\n - restore webpack loader. To power up cold API.\r\n - inside webpack loader perform just a simple string search - check for `class` keyword used. If it will be found - inject RHL methods\r\n - injecting could be done or via simple string insertion, or we could call babel for a single file.\r\n\r\nResult:\r\n - webpack loader, we can use on node_modules without speed penalties\r\n - webpack loader, we can use with TS, without speed penalties and complex configuration.\r\n - probably that should be different loaders, as long one of them will bring(or not) babel with it."},"comment":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/comments/449225646","html_url":"https://github.com/gaearon/react-hot-loader/issues/1039#issuecomment-449225646","issue_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1039","id":449225646,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTIyNTY0Ng==","user":{"login":"theKashey","id":582410,"node_id":"MDQ6VXNlcjU4MjQxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/582410?v=4","gravatar_id":"","url":"https://api.github.com/users/theKashey","html_url":"https://github.com/theKashey","followers_url":"https://api.github.com/users/theKashey/followers","following_url":"https://api.github.com/users/theKashey/following{/other_user}","gists_url":"https://api.github.com/users/theKashey/gists{/gist_id}","starred_url":"https://api.github.com/users/theKashey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theKashey/subscriptions","organizations_url":"https://api.github.com/users/theKashey/orgs","repos_url":"https://api.github.com/users/theKashey/repos","events_url":"https://api.github.com/users/theKashey/events{/privacy}","received_events_url":"https://api.github.com/users/theKashey/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T03:02:48Z","updated_at":"2018-12-21T03:02:48Z","author_association":"COLLABORATOR","body":"Webpack-loader is restored."}}
{"actor":{"display_login":"theKashey"}}