{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments/234112341","pull_request_review_id":175684659,"id":234112341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDExMjM0MQ==","diff_hunk":"@@ -75,12 +76,14 @@ public static void premain(String agentArgs, Instrumentation instrumentation) th\n \n         new AgentBuilder.Default(byteBuddy)\n             .ignore(nameStartsWith(\"net.bytebuddy.\"))\n-            .ignore(nameStartsWith(\"org.slf4j.\"))\n-            .ignore(nameStartsWith(\"org.apache.logging.\"))\n-            .ignore(nameStartsWith(\"org.groovy.\"))\n-            .ignore(nameContains(\"javassist\"))\n-            .ignore(nameContains(\".asm.\"))\n-            .ignore(allSkyWalkingAgentExcludeToolkit())\n+                .or(nameStartsWith(\"org.slf4j.\"))","path":"apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java","position":18,"original_position":18,"commit_id":"c64f5eb9341f7fdd3b03efb3ecd89c2ae839e2c6","original_commit_id":"c64f5eb9341f7fdd3b03efb3ecd89c2ae839e2c6","user":{"login":"wu-sheng","id":5441976,"node_id":"MDQ6VXNlcjU0NDE5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5441976?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-sheng","html_url":"https://github.com/wu-sheng","followers_url":"https://api.github.com/users/wu-sheng/followers","following_url":"https://api.github.com/users/wu-sheng/following{/other_user}","gists_url":"https://api.github.com/users/wu-sheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-sheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-sheng/subscriptions","organizations_url":"https://api.github.com/users/wu-sheng/orgs","repos_url":"https://api.github.com/users/wu-sheng/repos","events_url":"https://api.github.com/users/wu-sheng/events{/privacy}","received_events_url":"https://api.github.com/users/wu-sheng/received_events","type":"User","site_admin":false},"body":"I think this `or` should be inside `ignore` method, is that right? Right now, the codes look like `ignore`.`or`.`or`.\r\n\r\nWe don't expect for this, right?","created_at":"2018-11-16T07:39:04Z","updated_at":"2018-11-16T07:39:04Z","html_url":"https://github.com/apache/incubator-skywalking/pull/1913#discussion_r234112341","pull_request_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments/234112341"},"html":{"href":"https://github.com/apache/incubator-skywalking/pull/1913#discussion_r234112341"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913","id":231145128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTQ1MTI4","html_url":"https://github.com/apache/incubator-skywalking/pull/1913","diff_url":"https://github.com/apache/incubator-skywalking/pull/1913.diff","patch_url":"https://github.com/apache/incubator-skywalking/pull/1913.patch","issue_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/1913","number":1913,"state":"open","locked":false,"title":"fix bug #1912, the usage of ignore() problem","user":{"login":"honganan","id":4892550,"node_id":"MDQ6VXNlcjQ4OTI1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4892550?v=4","gravatar_id":"","url":"https://api.github.com/users/honganan","html_url":"https://github.com/honganan","followers_url":"https://api.github.com/users/honganan/followers","following_url":"https://api.github.com/users/honganan/following{/other_user}","gists_url":"https://api.github.com/users/honganan/gists{/gist_id}","starred_url":"https://api.github.com/users/honganan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honganan/subscriptions","organizations_url":"https://api.github.com/users/honganan/orgs","repos_url":"https://api.github.com/users/honganan/repos","events_url":"https://api.github.com/users/honganan/events{/privacy}","received_events_url":"https://api.github.com/users/honganan/received_events","type":"User","site_admin":false},"body":"Fix bug #1912 , like the butebuddy default logic does","created_at":"2018-11-15T10:36:28Z","updated_at":"2018-11-16T07:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef6494d33c38ff967a8c4b2bd9c1b6b15b1cdc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":830850387,"node_id":"MDU6TGFiZWw4MzA4NTAzODc=","url":"https://api.github.com/repos/apache/incubator-skywalking/labels/agent","name":"agent","color":"c2e0c6","default":false},{"id":283421094,"node_id":"MDU6TGFiZWwyODM0MjEwOTQ=","url":"https://api.github.com/repos/apache/incubator-skywalking/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-skywalking/milestones/31","html_url":"https://github.com/apache/incubator-skywalking/milestone/31","labels_url":"https://api.github.com/repos/apache/incubator-skywalking/milestones/31/labels","id":3695964,"node_id":"MDk6TWlsZXN0b25lMzY5NTk2NA==","number":31,"title":"6.0.0-beta","description":"","creator":{"login":"wu-sheng","id":5441976,"node_id":"MDQ6VXNlcjU0NDE5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5441976?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-sheng","html_url":"https://github.com/wu-sheng","followers_url":"https://api.github.com/users/wu-sheng/followers","following_url":"https://api.github.com/users/wu-sheng/following{/other_user}","gists_url":"https://api.github.com/users/wu-sheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-sheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-sheng/subscriptions","organizations_url":"https://api.github.com/users/wu-sheng/orgs","repos_url":"https://api.github.com/users/wu-sheng/repos","events_url":"https://api.github.com/users/wu-sheng/events{/privacy}","received_events_url":"https://api.github.com/users/wu-sheng/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":33,"state":"open","created_at":"2018-09-28T07:58:28Z","updated_at":"2018-11-16T06:13:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/1913/comments","statuses_url":"https://api.github.com/repos/apache/incubator-skywalking/statuses/c64f5eb9341f7fdd3b03efb3ecd89c2ae839e2c6","head":{"label":"honganan:ignoreUsageFix","ref":"ignoreUsageFix","sha":"c64f5eb9341f7fdd3b03efb3ecd89c2ae839e2c6","user":{"login":"honganan","id":4892550,"node_id":"MDQ6VXNlcjQ4OTI1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4892550?v=4","gravatar_id":"","url":"https://api.github.com/users/honganan","html_url":"https://github.com/honganan","followers_url":"https://api.github.com/users/honganan/followers","following_url":"https://api.github.com/users/honganan/following{/other_user}","gists_url":"https://api.github.com/users/honganan/gists{/gist_id}","starred_url":"https://api.github.com/users/honganan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honganan/subscriptions","organizations_url":"https://api.github.com/users/honganan/orgs","repos_url":"https://api.github.com/users/honganan/repos","events_url":"https://api.github.com/users/honganan/events{/privacy}","received_events_url":"https://api.github.com/users/honganan/received_events","type":"User","site_admin":false},"repo":{"id":157657581,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2NTc1ODE=","name":"incubator-skywalking","full_name":"honganan/incubator-skywalking","private":false,"owner":{"login":"honganan","id":4892550,"node_id":"MDQ6VXNlcjQ4OTI1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4892550?v=4","gravatar_id":"","url":"https://api.github.com/users/honganan","html_url":"https://github.com/honganan","followers_url":"https://api.github.com/users/honganan/followers","following_url":"https://api.github.com/users/honganan/following{/other_user}","gists_url":"https://api.github.com/users/honganan/gists{/gist_id}","starred_url":"https://api.github.com/users/honganan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honganan/subscriptions","organizations_url":"https://api.github.com/users/honganan/orgs","repos_url":"https://api.github.com/users/honganan/repos","events_url":"https://api.github.com/users/honganan/events{/privacy}","received_events_url":"https://api.github.com/users/honganan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/honganan/incubator-skywalking","description":"A distributed tracing system, and APM ( Application Performance Monitoring )","fork":true,"url":"https://api.github.com/repos/honganan/incubator-skywalking","forks_url":"https://api.github.com/repos/honganan/incubator-skywalking/forks","keys_url":"https://api.github.com/repos/honganan/incubator-skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honganan/incubator-skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honganan/incubator-skywalking/teams","hooks_url":"https://api.github.com/repos/honganan/incubator-skywalking/hooks","issue_events_url":"https://api.github.com/repos/honganan/incubator-skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/honganan/incubator-skywalking/events","assignees_url":"https://api.github.com/repos/honganan/incubator-skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/honganan/incubator-skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/honganan/incubator-skywalking/tags","blobs_url":"https://api.github.com/repos/honganan/incubator-skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honganan/incubator-skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honganan/incubator-skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/honganan/incubator-skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honganan/incubator-skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/honganan/incubator-skywalking/languages","stargazers_url":"https://api.github.com/repos/honganan/incubator-skywalking/stargazers","contributors_url":"https://api.github.com/repos/honganan/incubator-skywalking/contributors","subscribers_url":"https://api.github.com/repos/honganan/incubator-skywalking/subscribers","subscription_url":"https://api.github.com/repos/honganan/incubator-skywalking/subscription","commits_url":"https://api.github.com/repos/honganan/incubator-skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/honganan/incubator-skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/honganan/incubator-skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/honganan/incubator-skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/honganan/incubator-skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/honganan/incubator-skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honganan/incubator-skywalking/merges","archive_url":"https://api.github.com/repos/honganan/incubator-skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honganan/incubator-skywalking/downloads","issues_url":"https://api.github.com/repos/honganan/incubator-skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/honganan/incubator-skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/honganan/incubator-skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/honganan/incubator-skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honganan/incubator-skywalking/labels{/name}","releases_url":"https://api.github.com/repos/honganan/incubator-skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/honganan/incubator-skywalking/deployments","created_at":"2018-11-15T05:37:01Z","updated_at":"2018-11-15T05:37:07Z","pushed_at":"2018-11-15T14:00:29Z","git_url":"git://github.com/honganan/incubator-skywalking.git","ssh_url":"git@github.com:honganan/incubator-skywalking.git","clone_url":"https://github.com/honganan/incubator-skywalking.git","svn_url":"https://github.com/honganan/incubator-skywalking","homepage":"https://skywalking.incubator.apache.org/","size":141303,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7188c9c776dadc5599047e8fc10829fafe3b9f8d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45721011,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcyMTAxMQ==","name":"incubator-skywalking","full_name":"apache/incubator-skywalking","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-skywalking","description":"A distributed tracing system, and APM ( Application Performance Monitoring )","fork":false,"url":"https://api.github.com/repos/apache/incubator-skywalking","forks_url":"https://api.github.com/repos/apache/incubator-skywalking/forks","keys_url":"https://api.github.com/repos/apache/incubator-skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-skywalking/teams","hooks_url":"https://api.github.com/repos/apache/incubator-skywalking/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-skywalking/events","assignees_url":"https://api.github.com/repos/apache/incubator-skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-skywalking/tags","blobs_url":"https://api.github.com/repos/apache/incubator-skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-skywalking/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-skywalking/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-skywalking/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-skywalking/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-skywalking/subscription","commits_url":"https://api.github.com/repos/apache/incubator-skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-skywalking/merges","archive_url":"https://api.github.com/repos/apache/incubator-skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-skywalking/downloads","issues_url":"https://api.github.com/repos/apache/incubator-skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-skywalking/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-skywalking/deployments","created_at":"2015-11-07T03:30:36Z","updated_at":"2018-11-16T07:32:36Z","pushed_at":"2018-11-16T07:29:15Z","git_url":"git://github.com/apache/incubator-skywalking.git","ssh_url":"git@github.com:apache/incubator-skywalking.git","clone_url":"https://github.com/apache/incubator-skywalking.git","svn_url":"https://github.com/apache/incubator-skywalking","homepage":"https://skywalking.incubator.apache.org/","size":141299,"stargazers_count":4902,"watchers_count":4902,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1518,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1518,"open_issues":103,"watchers":4902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913"},"html":{"href":"https://github.com/apache/incubator-skywalking/pull/1913"},"issue":{"href":"https://api.github.com/repos/apache/incubator-skywalking/issues/1913"},"comments":{"href":"https://api.github.com/repos/apache/incubator-skywalking/issues/1913/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-skywalking/pulls/1913/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-skywalking/statuses/c64f5eb9341f7fdd3b03efb3ecd89c2ae839e2c6"}},"author_association":"NONE"}}
{"actor":{"display_login":"wu-sheng"}}