{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/227165477","pull_request_review_id":167142768,"id":227165477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE2NTQ3Nw==","diff_hunk":"@@ -190,90 +281,104 @@ private static VersionInfo GetVersionInfo()\n         {\n             return new VersionInfo(\n                 modelSignature: \"PCA FUNC\",\n-                verWrittenCur: 0x00010001, // Initial\n+                //verWrittenCur: 0x00010001, // Initial\n+                verWrittenCur: 0x00010002, // Get rid of writing float size in model context\n                 verReadableCur: 0x00010001,","path":"src/Microsoft.ML.PCA/PcaTransform.cs","position":257,"original_position":217,"commit_id":"bb2ad55cbead2df0a2c6023862805a310697e27c","original_commit_id":"f985de325a4616a82803eb701a9a69aca1f7a88a","user":{"login":"shmoradims","id":15950225,"node_id":"MDQ6VXNlcjE1OTUwMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/15950225?v=4","gravatar_id":"","url":"https://api.github.com/users/shmoradims","html_url":"https://github.com/shmoradims","followers_url":"https://api.github.com/users/shmoradims/followers","following_url":"https://api.github.com/users/shmoradims/following{/other_user}","gists_url":"https://api.github.com/users/shmoradims/gists{/gist_id}","starred_url":"https://api.github.com/users/shmoradims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmoradims/subscriptions","organizations_url":"https://api.github.com/users/shmoradims/orgs","repos_url":"https://api.github.com/users/shmoradims/repos","events_url":"https://api.github.com/users/shmoradims/events{/privacy}","received_events_url":"https://api.github.com/users/shmoradims/received_events","type":"User","site_admin":false},"body":"@ivmatan@microsoft.com does verReadableCur need to be bumped up too? RffTransform didn't do it, so wanted to double check.\r\n\r\n---\r\nIn reply to: [227069005](https://github.com/dotnet/machinelearning/pull/1333#discussion_r227069005) [](ancestors = 227069005)","created_at":"2018-10-22T22:53:24Z","updated_at":"2018-10-22T22:53:24Z","html_url":"https://github.com/dotnet/machinelearning/pull/1333#discussion_r227165477","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/227165477"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1333#discussion_r227165477"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333"}},"in_reply_to_id":227069005},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333","id":224561791,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTYxNzkx","html_url":"https://github.com/dotnet/machinelearning/pull/1333","diff_url":"https://github.com/dotnet/machinelearning/pull/1333.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1333.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1333","number":1333,"state":"open","locked":false,"title":"Convert PcaTransform to Estimator API","user":{"login":"shmoradims","id":15950225,"node_id":"MDQ6VXNlcjE1OTUwMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/15950225?v=4","gravatar_id":"","url":"https://api.github.com/users/shmoradims","html_url":"https://github.com/shmoradims","followers_url":"https://api.github.com/users/shmoradims/followers","following_url":"https://api.github.com/users/shmoradims/following{/other_user}","gists_url":"https://api.github.com/users/shmoradims/gists{/gist_id}","starred_url":"https://api.github.com/users/shmoradims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmoradims/subscriptions","organizations_url":"https://api.github.com/users/shmoradims/orgs","repos_url":"https://api.github.com/users/shmoradims/repos","events_url":"https://api.github.com/users/shmoradims/events{/privacy}","received_events_url":"https://api.github.com/users/shmoradims/received_events","type":"User","site_admin":false},"body":"This PR is proper conversion of PcaTransform to estimator API (a work item related to #754):\r\n* Overhauled PcaTransfrom to be OneToOneTransformerBase\r\n* Deleted the Wrapped versions\r\n* Extended the unit tests\r\n* Lots of code cleanup/simplifications\r\n","created_at":"2018-10-21T19:03:23Z","updated_at":"2018-10-22T22:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02bb7ff9e6774e8138778eaca89917b008b8f51","assignee":null,"assignees":[],"requested_reviewers":[{"login":"singlis","id":17055319,"node_id":"MDQ6VXNlcjE3MDU1MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/17055319?v=4","gravatar_id":"","url":"https://api.github.com/users/singlis","html_url":"https://github.com/singlis","followers_url":"https://api.github.com/users/singlis/followers","following_url":"https://api.github.com/users/singlis/following{/other_user}","gists_url":"https://api.github.com/users/singlis/gists{/gist_id}","starred_url":"https://api.github.com/users/singlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singlis/subscriptions","organizations_url":"https://api.github.com/users/singlis/orgs","repos_url":"https://api.github.com/users/singlis/repos","events_url":"https://api.github.com/users/singlis/events{/privacy}","received_events_url":"https://api.github.com/users/singlis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1333/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/bb2ad55cbead2df0a2c6023862805a310697e27c","head":{"label":"shmoradims:PCA_api_conversion","ref":"PCA_api_conversion","sha":"bb2ad55cbead2df0a2c6023862805a310697e27c","user":{"login":"shmoradims","id":15950225,"node_id":"MDQ6VXNlcjE1OTUwMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/15950225?v=4","gravatar_id":"","url":"https://api.github.com/users/shmoradims","html_url":"https://github.com/shmoradims","followers_url":"https://api.github.com/users/shmoradims/followers","following_url":"https://api.github.com/users/shmoradims/following{/other_user}","gists_url":"https://api.github.com/users/shmoradims/gists{/gist_id}","starred_url":"https://api.github.com/users/shmoradims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmoradims/subscriptions","organizations_url":"https://api.github.com/users/shmoradims/orgs","repos_url":"https://api.github.com/users/shmoradims/repos","events_url":"https://api.github.com/users/shmoradims/events{/privacy}","received_events_url":"https://api.github.com/users/shmoradims/received_events","type":"User","site_admin":false},"repo":{"id":144628303,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MjgzMDM=","name":"machinelearning","full_name":"shmoradims/machinelearning","private":false,"owner":{"login":"shmoradims","id":15950225,"node_id":"MDQ6VXNlcjE1OTUwMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/15950225?v=4","gravatar_id":"","url":"https://api.github.com/users/shmoradims","html_url":"https://github.com/shmoradims","followers_url":"https://api.github.com/users/shmoradims/followers","following_url":"https://api.github.com/users/shmoradims/following{/other_user}","gists_url":"https://api.github.com/users/shmoradims/gists{/gist_id}","starred_url":"https://api.github.com/users/shmoradims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmoradims/subscriptions","organizations_url":"https://api.github.com/users/shmoradims/orgs","repos_url":"https://api.github.com/users/shmoradims/repos","events_url":"https://api.github.com/users/shmoradims/events{/privacy}","received_events_url":"https://api.github.com/users/shmoradims/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shmoradims/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/shmoradims/machinelearning","forks_url":"https://api.github.com/repos/shmoradims/machinelearning/forks","keys_url":"https://api.github.com/repos/shmoradims/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shmoradims/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shmoradims/machinelearning/teams","hooks_url":"https://api.github.com/repos/shmoradims/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/shmoradims/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/shmoradims/machinelearning/events","assignees_url":"https://api.github.com/repos/shmoradims/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/shmoradims/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/shmoradims/machinelearning/tags","blobs_url":"https://api.github.com/repos/shmoradims/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shmoradims/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shmoradims/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/shmoradims/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shmoradims/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/shmoradims/machinelearning/languages","stargazers_url":"https://api.github.com/repos/shmoradims/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/shmoradims/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/shmoradims/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/shmoradims/machinelearning/subscription","commits_url":"https://api.github.com/repos/shmoradims/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/shmoradims/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/shmoradims/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/shmoradims/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/shmoradims/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/shmoradims/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shmoradims/machinelearning/merges","archive_url":"https://api.github.com/repos/shmoradims/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shmoradims/machinelearning/downloads","issues_url":"https://api.github.com/repos/shmoradims/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/shmoradims/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/shmoradims/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/shmoradims/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shmoradims/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/shmoradims/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/shmoradims/machinelearning/deployments","created_at":"2018-08-13T20:07:17Z","updated_at":"2018-09-18T21:40:59Z","pushed_at":"2018-10-22T22:07:54Z","git_url":"git://github.com/shmoradims/machinelearning.git","ssh_url":"git@github.com:shmoradims/machinelearning.git","clone_url":"https://github.com/shmoradims/machinelearning.git","svn_url":"https://github.com/shmoradims/machinelearning","homepage":"https://dot.net/ml","size":27076,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b29e52425dc4997c535bd42b20e5dd1ad4def613","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-10-22T19:38:00Z","pushed_at":"2018-10-22T22:19:46Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":25311,"stargazers_count":3965,"watchers_count":3965,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":711,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":711,"open_issues":344,"watchers":3965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1333"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1333"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1333/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1333/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/bb2ad55cbead2df0a2c6023862805a310697e27c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shmoradims"}}