{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/7210","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/7210/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/7210/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/7210/events","html_url":"https://github.com/webpack/webpack/pull/7210","id":320575942,"number":7210,"title":"fix: ReferenceError: onScriptComplete is not defined when using HMR o…","user":{"login":"chris-czopp","id":22557930,"avatar_url":"https://avatars1.githubusercontent.com/u/22557930?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-czopp","html_url":"https://github.com/chris-czopp","followers_url":"https://api.github.com/users/chris-czopp/followers","following_url":"https://api.github.com/users/chris-czopp/following{/other_user}","gists_url":"https://api.github.com/users/chris-czopp/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-czopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-czopp/subscriptions","organizations_url":"https://api.github.com/users/chris-czopp/orgs","repos_url":"https://api.github.com/users/chris-czopp/repos","events_url":"https://api.github.com/users/chris-czopp/events{/privacy}","received_events_url":"https://api.github.com/users/chris-czopp/received_events","type":"User","site_admin":false},"labels":[{"id":572709861,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-not-ok","name":"PR: CI-not-ok","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-06T09:11:13Z","updated_at":"2018-05-11T14:58:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/7210","html_url":"https://github.com/webpack/webpack/pull/7210","diff_url":"https://github.com/webpack/webpack/pull/7210.diff","patch_url":"https://github.com/webpack/webpack/pull/7210.patch"},"body":"…n Firefox 45\r\n\r\n<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\nbugfix for Firefox 45 and code improvement\r\n\r\n**Did you add tests for your changes?**\r\n\r\nno, it's an enhancement covered by existing tests\r\n\r\n**If relevant, link to documentation update:**\r\n\r\nN/A\r\n\r\n**Summary**\r\n\r\nI've been testing my app on out-dated Firefox (45) and realised the template relies on hoisting (`onScriptComplete` assigned before its declaration) which is not only a bad practice but it was crashing the bundling.\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nno, this is just enhancement"},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/388389318","html_url":"https://github.com/webpack/webpack/pull/7210#issuecomment-388389318","issue_url":"https://api.github.com/repos/webpack/webpack/issues/7210","id":388389318,"user":{"login":"evilebottnawi","id":4567934,"avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T14:58:39Z","updated_at":"2018-05-11T14:58:39Z","author_association":"MEMBER","body":"@chris-czopp Please accept CLA"}}
{"actor":{"display_login":"evilebottnawi"}}