{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/squad/pulls/comments/236618375","pull_request_review_id":178726507,"id":236618375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjYxODM3NQ==","diff_hunk":"@@ -0,0 +1,69 @@\n+<h2>\n+    Threshold settings\n+</h2>\n+\n+<div class='row'>\n+    <div class='col-md-4'>\n+        <a href=\"#\" data-toggle=\"modal\" data-target=\"#threshold_modal\">\n+            <button id=\"threshold_button\" type=\"submit\" class=\"btn btn-primary\">Add threshold</button>\n+        </a>\n+    </div>\n+</div>\n+\n+{% raw %}\n+<div class='row row-bordered' ng-repeat=\"threshold in thresholds\">\n+    <div class='col-md-1'>\n+        <i class='fa fa-line-chart'></i>\n+    </div>\n+    <div class='col-md-7'>\n+        {{ threshold.name }}\n+    </div>\n+    <div class='col-md-2'>\n+        {{ threshold.value }}\n+    </div>\n+    <div class='col-md-2'>\n+        <a href=\"#\" data-toggle=\"modal\" data-target=\"#threshold_modal\" ng-click=\"setThreshold(threshold)\" style=\"color: inherit; text-decoration: none;\">\n+            <i class='fa fa-pencil'></i>\n+        </a>\n+        <a href=\"#\" ng-click=\"removeThreshold(threshold)\" style=\"color: inherit; text-decoration: none;\">\n+            <i class='fa fa-trash'></i>\n+        </a>\n+    </div>\n+</div>\n+{% endraw %}\n+\n+<!-- Modal HTML -->\n+<div id=\"threshold_modal\" class=\"modal fade\">\n+  <div class=\"modal-dialog\">\n+    <div class=\"modal-content\">\n+      <div class=\"modal-header\">\n+        <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button>\n+        <h4 class=\"modal-title\">Metric threshold</h4>\n+      </div>\n+      <form class=\"well\" id=\"threshold_form\" ng-submit=\"updateMetricThreshold()\">\n+        <div class=\"modal-body\">\n+          {% raw %}\n+          <p ng-repeat=\"(name, errs) in errors\" class=\"alert alert-danger\"><strong>{{ name }}</strong>: {{ errs.join(', ') }}</p>\n+          {% endraw %}\n+\n+          <div class=\"row form-group\">\n+            <label for=\"name\" class=\"col-md-3 control-label\">Metric name:</label>\n+            <div class=\"col-md-10\">\n+              <input name=\"name\" ng-model=\"currentThreshold.name\" />\n+            </div>\n+          </div>\n+          <div class=\"row form-group\">\n+            <label for=\"value\" class=\"col-md-3 control-label\">Value:</label>\n+            <div class=\"col-md-10\">\n+              <input name=\"value\" ng-model=\"currentThreshold.value\" />\n+            </div>\n+          </div>","path":"squad/frontend/templates/squad/_threshold_table.jinja2","position":80,"original_position":60,"commit_id":"1979eb394bbd7455bc4b76f7ca4bc76cc5e865d2","original_commit_id":"f30fcb8029365016e0aa01e13d9176ade473e054","user":{"login":"stevanradakovic","id":2445956,"node_id":"MDQ6VXNlcjI0NDU5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2445956?v=4","gravatar_id":"","url":"https://api.github.com/users/stevanradakovic","html_url":"https://github.com/stevanradakovic","followers_url":"https://api.github.com/users/stevanradakovic/followers","following_url":"https://api.github.com/users/stevanradakovic/following{/other_user}","gists_url":"https://api.github.com/users/stevanradakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stevanradakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevanradakovic/subscriptions","organizations_url":"https://api.github.com/users/stevanradakovic/orgs","repos_url":"https://api.github.com/users/stevanradakovic/repos","events_url":"https://api.github.com/users/stevanradakovic/events{/privacy}","received_events_url":"https://api.github.com/users/stevanradakovic/received_events","type":"User","site_admin":false},"body":"We search through both test runs and suites to check for metrics which are exceeding thresholds. There's no need to specify anything in the thresholds themselved.\r\nFixed the higher is better issue.","created_at":"2018-11-27T11:14:53Z","updated_at":"2018-11-27T11:14:53Z","html_url":"https://github.com/Linaro/squad/pull/404#discussion_r236618375","pull_request_url":"https://api.github.com/repos/Linaro/squad/pulls/404","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Linaro/squad/pulls/comments/236618375"},"html":{"href":"https://github.com/Linaro/squad/pull/404#discussion_r236618375"},"pull_request":{"href":"https://api.github.com/repos/Linaro/squad/pulls/404"}},"in_reply_to_id":235810197},"pull_request":{"url":"https://api.github.com/repos/Linaro/squad/pulls/404","id":232373156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzczMTU2","html_url":"https://github.com/Linaro/squad/pull/404","diff_url":"https://github.com/Linaro/squad/pull/404.diff","patch_url":"https://github.com/Linaro/squad/pull/404.patch","issue_url":"https://api.github.com/repos/Linaro/squad/issues/404","number":404,"state":"open","locked":false,"title":"Metric threshold support.","user":{"login":"stevanradakovic","id":2445956,"node_id":"MDQ6VXNlcjI0NDU5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2445956?v=4","gravatar_id":"","url":"https://api.github.com/users/stevanradakovic","html_url":"https://github.com/stevanradakovic","followers_url":"https://api.github.com/users/stevanradakovic/followers","following_url":"https://api.github.com/users/stevanradakovic/following{/other_user}","gists_url":"https://api.github.com/users/stevanradakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stevanradakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevanradakovic/subscriptions","organizations_url":"https://api.github.com/users/stevanradakovic/orgs","repos_url":"https://api.github.com/users/stevanradakovic/repos","events_url":"https://api.github.com/users/stevanradakovic/events{/privacy}","received_events_url":"https://api.github.com/users/stevanradakovic/received_events","type":"User","site_admin":false},"body":"Add threshold support in frontend and charts.\r\nImplement notification support depending on the thresholds.\r\n\r\nFixes #296.","created_at":"2018-11-20T16:07:22Z","updated_at":"2018-11-27T11:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a7efb33537fba043ed8fce7bd12b2572a10a1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chaws","id":2254825,"node_id":"MDQ6VXNlcjIyNTQ4MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2254825?v=4","gravatar_id":"","url":"https://api.github.com/users/chaws","html_url":"https://github.com/chaws","followers_url":"https://api.github.com/users/chaws/followers","following_url":"https://api.github.com/users/chaws/following{/other_user}","gists_url":"https://api.github.com/users/chaws/gists{/gist_id}","starred_url":"https://api.github.com/users/chaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaws/subscriptions","organizations_url":"https://api.github.com/users/chaws/orgs","repos_url":"https://api.github.com/users/chaws/repos","events_url":"https://api.github.com/users/chaws/events{/privacy}","received_events_url":"https://api.github.com/users/chaws/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/squad/pulls/404/commits","review_comments_url":"https://api.github.com/repos/Linaro/squad/pulls/404/comments","review_comment_url":"https://api.github.com/repos/Linaro/squad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/squad/issues/404/comments","statuses_url":"https://api.github.com/repos/Linaro/squad/statuses/1979eb394bbd7455bc4b76f7ca4bc76cc5e865d2","head":{"label":"stevanradakovic:issue-296","ref":"issue-296","sha":"1979eb394bbd7455bc4b76f7ca4bc76cc5e865d2","user":{"login":"stevanradakovic","id":2445956,"node_id":"MDQ6VXNlcjI0NDU5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2445956?v=4","gravatar_id":"","url":"https://api.github.com/users/stevanradakovic","html_url":"https://github.com/stevanradakovic","followers_url":"https://api.github.com/users/stevanradakovic/followers","following_url":"https://api.github.com/users/stevanradakovic/following{/other_user}","gists_url":"https://api.github.com/users/stevanradakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stevanradakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevanradakovic/subscriptions","organizations_url":"https://api.github.com/users/stevanradakovic/orgs","repos_url":"https://api.github.com/users/stevanradakovic/repos","events_url":"https://api.github.com/users/stevanradakovic/events{/privacy}","received_events_url":"https://api.github.com/users/stevanradakovic/received_events","type":"User","site_admin":false},"repo":{"id":143041956,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDE5NTY=","name":"squad","full_name":"stevanradakovic/squad","private":false,"owner":{"login":"stevanradakovic","id":2445956,"node_id":"MDQ6VXNlcjI0NDU5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/2445956?v=4","gravatar_id":"","url":"https://api.github.com/users/stevanradakovic","html_url":"https://github.com/stevanradakovic","followers_url":"https://api.github.com/users/stevanradakovic/followers","following_url":"https://api.github.com/users/stevanradakovic/following{/other_user}","gists_url":"https://api.github.com/users/stevanradakovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stevanradakovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevanradakovic/subscriptions","organizations_url":"https://api.github.com/users/stevanradakovic/orgs","repos_url":"https://api.github.com/users/stevanradakovic/repos","events_url":"https://api.github.com/users/stevanradakovic/events{/privacy}","received_events_url":"https://api.github.com/users/stevanradakovic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stevanradakovic/squad","description":"Software Quality Dashboard","fork":true,"url":"https://api.github.com/repos/stevanradakovic/squad","forks_url":"https://api.github.com/repos/stevanradakovic/squad/forks","keys_url":"https://api.github.com/repos/stevanradakovic/squad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevanradakovic/squad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevanradakovic/squad/teams","hooks_url":"https://api.github.com/repos/stevanradakovic/squad/hooks","issue_events_url":"https://api.github.com/repos/stevanradakovic/squad/issues/events{/number}","events_url":"https://api.github.com/repos/stevanradakovic/squad/events","assignees_url":"https://api.github.com/repos/stevanradakovic/squad/assignees{/user}","branches_url":"https://api.github.com/repos/stevanradakovic/squad/branches{/branch}","tags_url":"https://api.github.com/repos/stevanradakovic/squad/tags","blobs_url":"https://api.github.com/repos/stevanradakovic/squad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevanradakovic/squad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevanradakovic/squad/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevanradakovic/squad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevanradakovic/squad/statuses/{sha}","languages_url":"https://api.github.com/repos/stevanradakovic/squad/languages","stargazers_url":"https://api.github.com/repos/stevanradakovic/squad/stargazers","contributors_url":"https://api.github.com/repos/stevanradakovic/squad/contributors","subscribers_url":"https://api.github.com/repos/stevanradakovic/squad/subscribers","subscription_url":"https://api.github.com/repos/stevanradakovic/squad/subscription","commits_url":"https://api.github.com/repos/stevanradakovic/squad/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevanradakovic/squad/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevanradakovic/squad/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevanradakovic/squad/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevanradakovic/squad/contents/{+path}","compare_url":"https://api.github.com/repos/stevanradakovic/squad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevanradakovic/squad/merges","archive_url":"https://api.github.com/repos/stevanradakovic/squad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevanradakovic/squad/downloads","issues_url":"https://api.github.com/repos/stevanradakovic/squad/issues{/number}","pulls_url":"https://api.github.com/repos/stevanradakovic/squad/pulls{/number}","milestones_url":"https://api.github.com/repos/stevanradakovic/squad/milestones{/number}","notifications_url":"https://api.github.com/repos/stevanradakovic/squad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevanradakovic/squad/labels{/name}","releases_url":"https://api.github.com/repos/stevanradakovic/squad/releases{/id}","deployments_url":"https://api.github.com/repos/stevanradakovic/squad/deployments","created_at":"2018-07-31T16:50:44Z","updated_at":"2018-11-22T07:46:26Z","pushed_at":"2018-11-27T11:12:39Z","git_url":"git://github.com/stevanradakovic/squad.git","ssh_url":"git@github.com:stevanradakovic/squad.git","clone_url":"https://github.com/stevanradakovic/squad.git","svn_url":"https://github.com/stevanradakovic/squad","homepage":null,"size":1765,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"3e251c3fd218205b8b96b605beb75a886a67bd1a","user":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":62325478,"node_id":"MDEwOlJlcG9zaXRvcnk2MjMyNTQ3OA==","name":"squad","full_name":"Linaro/squad","private":false,"owner":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Linaro/squad","description":"Software Quality Dashboard","fork":false,"url":"https://api.github.com/repos/Linaro/squad","forks_url":"https://api.github.com/repos/Linaro/squad/forks","keys_url":"https://api.github.com/repos/Linaro/squad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/squad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/squad/teams","hooks_url":"https://api.github.com/repos/Linaro/squad/hooks","issue_events_url":"https://api.github.com/repos/Linaro/squad/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/squad/events","assignees_url":"https://api.github.com/repos/Linaro/squad/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/squad/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/squad/tags","blobs_url":"https://api.github.com/repos/Linaro/squad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/squad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/squad/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/squad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/squad/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/squad/languages","stargazers_url":"https://api.github.com/repos/Linaro/squad/stargazers","contributors_url":"https://api.github.com/repos/Linaro/squad/contributors","subscribers_url":"https://api.github.com/repos/Linaro/squad/subscribers","subscription_url":"https://api.github.com/repos/Linaro/squad/subscription","commits_url":"https://api.github.com/repos/Linaro/squad/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/squad/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/squad/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/squad/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/squad/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/squad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/squad/merges","archive_url":"https://api.github.com/repos/Linaro/squad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/squad/downloads","issues_url":"https://api.github.com/repos/Linaro/squad/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/squad/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/squad/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/squad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/squad/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/squad/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/squad/deployments","created_at":"2016-06-30T16:16:04Z","updated_at":"2018-11-26T20:26:14Z","pushed_at":"2018-11-27T11:12:41Z","git_url":"git://github.com/Linaro/squad.git","ssh_url":"git@github.com:Linaro/squad.git","clone_url":"https://github.com/Linaro/squad.git","svn_url":"https://github.com/Linaro/squad","homepage":null,"size":1775,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":21,"open_issues":42,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/squad/pulls/404"},"html":{"href":"https://github.com/Linaro/squad/pull/404"},"issue":{"href":"https://api.github.com/repos/Linaro/squad/issues/404"},"comments":{"href":"https://api.github.com/repos/Linaro/squad/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/squad/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/squad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/squad/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/squad/statuses/1979eb394bbd7455bc4b76f7ca4bc76cc5e865d2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stevanradakovic"}}