{"action":"created","comment":{"url":"https://api.github.com/repos/anmonteiro/lumo/pulls/comments/182900342","pull_request_review_id":113796133,"id":182900342,"diff_hunk":"@@ -405,11 +410,25 @@ async function initSocketRepl(\n   const [, host, port] = socketReplArgs.match(hostAndPortRegex) || [];\n \n   try {\n-    const replOpts = /^{/.test(socketReplArgs)\n+    const parsedOpts = /^{/.test(socketReplArgs)\n       ? JSON.parse(socketReplArgs)\n       : { host, port };\n \n-    replOpts.port = parseInt(replOpts.port, 10);\n+    const replOpts: ReplOptsType = {\n+      port: parseInt(parsedOpts.port, 10),\n+      host: parsedOpts.host,\n+    };\n+\n+    // This tweak is required because the thrown error varies in different node\n+    // versions and jest does not allow yet to specify the snapshot name at runtime.\n+    // It's been worked on though, see:\n+    //   https://github.com/facebook/jest/pull/5838#issuecomment-382476612\n+    const errorMsg = `Port should be > 0 and < 65536. Received ${replOpts.port}.`;","path":"src/js/cljs.js","position":31,"original_position":31,"commit_id":"7d7bc627489867622b1e29d55145e4fc257ac08a","original_commit_id":"7d7bc627489867622b1e29d55145e4fc257ac08a","user":{"login":"anmonteiro","id":661909,"avatar_url":"https://avatars2.githubusercontent.com/u/661909?v=4","gravatar_id":"","url":"https://api.github.com/users/anmonteiro","html_url":"https://github.com/anmonteiro","followers_url":"https://api.github.com/users/anmonteiro/followers","following_url":"https://api.github.com/users/anmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/anmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/anmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmonteiro/subscriptions","organizations_url":"https://api.github.com/users/anmonteiro/orgs","repos_url":"https://api.github.com/users/anmonteiro/repos","events_url":"https://api.github.com/users/anmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/anmonteiro/received_events","type":"User","site_admin":false},"body":"I think you want `parsedOpts.port` here","created_at":"2018-04-19T22:16:13Z","updated_at":"2018-04-19T22:16:13Z","html_url":"https://github.com/anmonteiro/lumo/pull/384#discussion_r182900342","pull_request_url":"https://api.github.com/repos/anmonteiro/lumo/pulls/384","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/comments/182900342"},"html":{"href":"https://github.com/anmonteiro/lumo/pull/384#discussion_r182900342"},"pull_request":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/anmonteiro/lumo/pulls/384","id":180124354,"html_url":"https://github.com/anmonteiro/lumo/pull/384","diff_url":"https://github.com/anmonteiro/lumo/pull/384.diff","patch_url":"https://github.com/anmonteiro/lumo/pull/384.patch","issue_url":"https://api.github.com/repos/anmonteiro/lumo/issues/384","number":384,"state":"open","locked":false,"title":"Build lumo against latest node lts","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars0.githubusercontent.com/u/1724788?v=4","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"body":"This patch adds the necessary configuration to build `lumo` against the latest\r\nnode lts (`8.11.1`) and node for AWS Lamdba (`8.10.0`). Against any version for that matter.\r\n\r\nThe executable generated is `lumo-$architecture-v$nodeVersion.zip`, but also the old `lumo.zip` is still going to be produced.","created_at":"2018-04-07T20:48:28Z","updated_at":"2018-04-19T22:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b7c5c6ed352e67f755672887ef762378be72d7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/anmonteiro/lumo/pulls/384/commits","review_comments_url":"https://api.github.com/repos/anmonteiro/lumo/pulls/384/comments","review_comment_url":"https://api.github.com/repos/anmonteiro/lumo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anmonteiro/lumo/issues/384/comments","statuses_url":"https://api.github.com/repos/anmonteiro/lumo/statuses/7d7bc627489867622b1e29d55145e4fc257ac08a","head":{"label":"anmonteiro:travis-node-matrix","ref":"travis-node-matrix","sha":"7d7bc627489867622b1e29d55145e4fc257ac08a","user":{"login":"anmonteiro","id":661909,"avatar_url":"https://avatars2.githubusercontent.com/u/661909?v=4","gravatar_id":"","url":"https://api.github.com/users/anmonteiro","html_url":"https://github.com/anmonteiro","followers_url":"https://api.github.com/users/anmonteiro/followers","following_url":"https://api.github.com/users/anmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/anmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/anmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmonteiro/subscriptions","organizations_url":"https://api.github.com/users/anmonteiro/orgs","repos_url":"https://api.github.com/users/anmonteiro/repos","events_url":"https://api.github.com/users/anmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/anmonteiro/received_events","type":"User","site_admin":false},"repo":{"id":69415002,"name":"lumo","full_name":"anmonteiro/lumo","owner":{"login":"anmonteiro","id":661909,"avatar_url":"https://avatars2.githubusercontent.com/u/661909?v=4","gravatar_id":"","url":"https://api.github.com/users/anmonteiro","html_url":"https://github.com/anmonteiro","followers_url":"https://api.github.com/users/anmonteiro/followers","following_url":"https://api.github.com/users/anmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/anmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/anmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmonteiro/subscriptions","organizations_url":"https://api.github.com/users/anmonteiro/orgs","repos_url":"https://api.github.com/users/anmonteiro/repos","events_url":"https://api.github.com/users/anmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/anmonteiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anmonteiro/lumo","description":"Fast, cross-platform, standalone ClojureScript environment","fork":false,"url":"https://api.github.com/repos/anmonteiro/lumo","forks_url":"https://api.github.com/repos/anmonteiro/lumo/forks","keys_url":"https://api.github.com/repos/anmonteiro/lumo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anmonteiro/lumo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anmonteiro/lumo/teams","hooks_url":"https://api.github.com/repos/anmonteiro/lumo/hooks","issue_events_url":"https://api.github.com/repos/anmonteiro/lumo/issues/events{/number}","events_url":"https://api.github.com/repos/anmonteiro/lumo/events","assignees_url":"https://api.github.com/repos/anmonteiro/lumo/assignees{/user}","branches_url":"https://api.github.com/repos/anmonteiro/lumo/branches{/branch}","tags_url":"https://api.github.com/repos/anmonteiro/lumo/tags","blobs_url":"https://api.github.com/repos/anmonteiro/lumo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anmonteiro/lumo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anmonteiro/lumo/git/refs{/sha}","trees_url":"https://api.github.com/repos/anmonteiro/lumo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anmonteiro/lumo/statuses/{sha}","languages_url":"https://api.github.com/repos/anmonteiro/lumo/languages","stargazers_url":"https://api.github.com/repos/anmonteiro/lumo/stargazers","contributors_url":"https://api.github.com/repos/anmonteiro/lumo/contributors","subscribers_url":"https://api.github.com/repos/anmonteiro/lumo/subscribers","subscription_url":"https://api.github.com/repos/anmonteiro/lumo/subscription","commits_url":"https://api.github.com/repos/anmonteiro/lumo/commits{/sha}","git_commits_url":"https://api.github.com/repos/anmonteiro/lumo/git/commits{/sha}","comments_url":"https://api.github.com/repos/anmonteiro/lumo/comments{/number}","issue_comment_url":"https://api.github.com/repos/anmonteiro/lumo/issues/comments{/number}","contents_url":"https://api.github.com/repos/anmonteiro/lumo/contents/{+path}","compare_url":"https://api.github.com/repos/anmonteiro/lumo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anmonteiro/lumo/merges","archive_url":"https://api.github.com/repos/anmonteiro/lumo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anmonteiro/lumo/downloads","issues_url":"https://api.github.com/repos/anmonteiro/lumo/issues{/number}","pulls_url":"https://api.github.com/repos/anmonteiro/lumo/pulls{/number}","milestones_url":"https://api.github.com/repos/anmonteiro/lumo/milestones{/number}","notifications_url":"https://api.github.com/repos/anmonteiro/lumo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anmonteiro/lumo/labels{/name}","releases_url":"https://api.github.com/repos/anmonteiro/lumo/releases{/id}","deployments_url":"https://api.github.com/repos/anmonteiro/lumo/deployments","created_at":"2016-09-28T01:52:55Z","updated_at":"2018-04-19T19:26:27Z","pushed_at":"2018-04-19T16:47:25Z","git_url":"git://github.com/anmonteiro/lumo.git","ssh_url":"git@github.com:anmonteiro/lumo.git","clone_url":"https://github.com/anmonteiro/lumo.git","svn_url":"https://github.com/anmonteiro/lumo","homepage":"","size":19290,"stargazers_count":1344,"watchers_count":1344,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":59,"open_issues":79,"watchers":1344,"default_branch":"master"}},"base":{"label":"anmonteiro:master","ref":"master","sha":"dd7c03e6ec49a883fed1877b8683bcd8350e59b0","user":{"login":"anmonteiro","id":661909,"avatar_url":"https://avatars2.githubusercontent.com/u/661909?v=4","gravatar_id":"","url":"https://api.github.com/users/anmonteiro","html_url":"https://github.com/anmonteiro","followers_url":"https://api.github.com/users/anmonteiro/followers","following_url":"https://api.github.com/users/anmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/anmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/anmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmonteiro/subscriptions","organizations_url":"https://api.github.com/users/anmonteiro/orgs","repos_url":"https://api.github.com/users/anmonteiro/repos","events_url":"https://api.github.com/users/anmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/anmonteiro/received_events","type":"User","site_admin":false},"repo":{"id":69415002,"name":"lumo","full_name":"anmonteiro/lumo","owner":{"login":"anmonteiro","id":661909,"avatar_url":"https://avatars2.githubusercontent.com/u/661909?v=4","gravatar_id":"","url":"https://api.github.com/users/anmonteiro","html_url":"https://github.com/anmonteiro","followers_url":"https://api.github.com/users/anmonteiro/followers","following_url":"https://api.github.com/users/anmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/anmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/anmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmonteiro/subscriptions","organizations_url":"https://api.github.com/users/anmonteiro/orgs","repos_url":"https://api.github.com/users/anmonteiro/repos","events_url":"https://api.github.com/users/anmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/anmonteiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anmonteiro/lumo","description":"Fast, cross-platform, standalone ClojureScript environment","fork":false,"url":"https://api.github.com/repos/anmonteiro/lumo","forks_url":"https://api.github.com/repos/anmonteiro/lumo/forks","keys_url":"https://api.github.com/repos/anmonteiro/lumo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anmonteiro/lumo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anmonteiro/lumo/teams","hooks_url":"https://api.github.com/repos/anmonteiro/lumo/hooks","issue_events_url":"https://api.github.com/repos/anmonteiro/lumo/issues/events{/number}","events_url":"https://api.github.com/repos/anmonteiro/lumo/events","assignees_url":"https://api.github.com/repos/anmonteiro/lumo/assignees{/user}","branches_url":"https://api.github.com/repos/anmonteiro/lumo/branches{/branch}","tags_url":"https://api.github.com/repos/anmonteiro/lumo/tags","blobs_url":"https://api.github.com/repos/anmonteiro/lumo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anmonteiro/lumo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anmonteiro/lumo/git/refs{/sha}","trees_url":"https://api.github.com/repos/anmonteiro/lumo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anmonteiro/lumo/statuses/{sha}","languages_url":"https://api.github.com/repos/anmonteiro/lumo/languages","stargazers_url":"https://api.github.com/repos/anmonteiro/lumo/stargazers","contributors_url":"https://api.github.com/repos/anmonteiro/lumo/contributors","subscribers_url":"https://api.github.com/repos/anmonteiro/lumo/subscribers","subscription_url":"https://api.github.com/repos/anmonteiro/lumo/subscription","commits_url":"https://api.github.com/repos/anmonteiro/lumo/commits{/sha}","git_commits_url":"https://api.github.com/repos/anmonteiro/lumo/git/commits{/sha}","comments_url":"https://api.github.com/repos/anmonteiro/lumo/comments{/number}","issue_comment_url":"https://api.github.com/repos/anmonteiro/lumo/issues/comments{/number}","contents_url":"https://api.github.com/repos/anmonteiro/lumo/contents/{+path}","compare_url":"https://api.github.com/repos/anmonteiro/lumo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anmonteiro/lumo/merges","archive_url":"https://api.github.com/repos/anmonteiro/lumo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anmonteiro/lumo/downloads","issues_url":"https://api.github.com/repos/anmonteiro/lumo/issues{/number}","pulls_url":"https://api.github.com/repos/anmonteiro/lumo/pulls{/number}","milestones_url":"https://api.github.com/repos/anmonteiro/lumo/milestones{/number}","notifications_url":"https://api.github.com/repos/anmonteiro/lumo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anmonteiro/lumo/labels{/name}","releases_url":"https://api.github.com/repos/anmonteiro/lumo/releases{/id}","deployments_url":"https://api.github.com/repos/anmonteiro/lumo/deployments","created_at":"2016-09-28T01:52:55Z","updated_at":"2018-04-19T19:26:27Z","pushed_at":"2018-04-19T16:47:25Z","git_url":"git://github.com/anmonteiro/lumo.git","ssh_url":"git@github.com:anmonteiro/lumo.git","clone_url":"https://github.com/anmonteiro/lumo.git","svn_url":"https://github.com/anmonteiro/lumo","homepage":"","size":19290,"stargazers_count":1344,"watchers_count":1344,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":59,"open_issues":79,"watchers":1344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/384"},"html":{"href":"https://github.com/anmonteiro/lumo/pull/384"},"issue":{"href":"https://api.github.com/repos/anmonteiro/lumo/issues/384"},"comments":{"href":"https://api.github.com/repos/anmonteiro/lumo/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anmonteiro/lumo/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/anmonteiro/lumo/statuses/7d7bc627489867622b1e29d55145e4fc257ac08a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anmonteiro"}}