{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/15196","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/15196/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15196/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/15196/events","html_url":"https://github.com/grpc/grpc/pull/15196","id":318141552,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NDIyNTY2","number":15196,"title":"Add load reporter for server load reporting","user":{"login":"AspirinSJL","id":3314176,"node_id":"MDQ6VXNlcjMzMTQxNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3314176?v=4","gravatar_id":"","url":"https://api.github.com/users/AspirinSJL","html_url":"https://github.com/AspirinSJL","followers_url":"https://api.github.com/users/AspirinSJL/followers","following_url":"https://api.github.com/users/AspirinSJL/following{/other_user}","gists_url":"https://api.github.com/users/AspirinSJL/gists{/gist_id}","starred_url":"https://api.github.com/users/AspirinSJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AspirinSJL/subscriptions","organizations_url":"https://api.github.com/users/AspirinSJL/orgs","repos_url":"https://api.github.com/users/AspirinSJL/repos","events_url":"https://api.github.com/users/AspirinSJL/events{/privacy}","received_events_url":"https://api.github.com/users/AspirinSJL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":87,"created_at":"2018-04-26T18:14:13Z","updated_at":"2018-06-20T15:47:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15196","html_url":"https://github.com/grpc/grpc/pull/15196","diff_url":"https://github.com/grpc/grpc/pull/15196.diff","patch_url":"https://github.com/grpc/grpc/pull/15196.patch"},"body":"This is a continuation of #14793 ~and currently based on that PR~.\r\n\r\n~This is not yet ready for review. I hope to see some quick feedback from @isturdy on my usage of the opencensus APIs.~\r\n\r\nThis is ready for review except for the `get_cpu_stats()` implementation on the platforms other than Linux.\r\n\r\nI skipped some low-risk but detailed tests for now.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/grpc/grpc/15196)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/398799396","html_url":"https://github.com/grpc/grpc/pull/15196#issuecomment-398799396","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15196","id":398799396,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODc5OTM5Ng==","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T15:47:41Z","updated_at":"2018-06-20T15:47:41Z","author_association":"CONTRIBUTOR","body":"Other than the outstanding question for Nico about build/test integration, this looks good!\n\n---\n\nReviewed 2 of 6 files at r10, 3 of 4 files at r11, 3 of 10 files at r12, 7 of 7 files at r13, 6 of 6 files at r14.\nReview status: all files reviewed, 4 unresolved discussions (waiting on @markdroth, @yetianx, @summerxyt, and @nicolasnoble)\n\n---\n\n*[build.yaml, line 1894 at r1](https://reviewable.io/reviews/grpc/grpc/15196#-LDgQNLw6L8duT3SQji1:-LFSs3lt9Jbr22vTKYVn:b4wbugo) ([raw file](https://github.com/grpc/grpc/blob/68342ca6d74da6c3b10427fb7b1f32dcad3830f3/build.yaml#L1894)):*\n<details><summary><i>Previously, AspirinSJL (Juanli Shen) wrote…</i></summary><blockquote>\n\nI keep this for now because it seems that we still need some discussion about this? See https://github.com/grpc/grpc/pull/15349#discussion_r188754176\n</blockquote></details>\n\nStill need feedback from @nicolasnoble about this.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/grpc/grpc/15196#-:-LFSsEdw1H9IXiRF1Bz-:b13fgzv)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"markdroth"}}