{"push_id":2827990747,"size":14,"distinct_size":14,"ref":"refs/heads/1808-opreturn-refactor","head":"4c2022f81200e2ed01366059136ff8f919adcbfc","before":"6f7d5b8b148bc7a77cc337ca51a925e961f08615","commits":[{"sha":"2e83397a26ac643a16cb6df609b0b98e8cde2980","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Merged master","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/2e83397a26ac643a16cb6df609b0b98e8cde2980"},{"sha":"bff2f077c3b1749fc67747358d6e421ae6c9b749","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Small refactorings, add todos from review","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/bff2f077c3b1749fc67747358d6e421ae6c9b749"},{"sha":"7f5f818379ef8259e93867439d1ff88afa97b0c5","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Merged master","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/7f5f818379ef8259e93867439d1ff88afa97b0c5"},{"sha":"356b3bb65ec550f5a7e18b878d37331575211cc7","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Merge remote-tracking branch 'ManfredKarrer/mk_master' into mk_master","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/356b3bb65ec550f5a7e18b878d37331575211cc7"},{"sha":"c752871840bc296e1c336c727b62ad1e2606424c","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Merged master","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/c752871840bc296e1c336c727b62ad1e2606424c"},{"sha":"5aa3bca4b5964b1964559d59491f9061996c05e7","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Merged master","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/5aa3bca4b5964b1964559d59491f9061996c05e7"},{"sha":"87deb2385d6214141fe8f80f81cfc026dc934371","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Refactor OpReturnParser for Proposal\n\nWe try to get rid of the sub parser classes for opReturn and remove the\nchecks which are not directly related to the OpReturn data like the fee\nand the phase checks. We set the verifiedOpReturnType in the\nTxOutputParser and do the check for fee and phase in the TxParser.","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/87deb2385d6214141fe8f80f81cfc026dc934371"},{"sha":"8596212c360fe3e5d4421b91122a439feebea836","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Refactor OpReturnParser for CompRequest\n\nAdd checkFeeAndPhase method.\n\nWe try to get rid of the sub parser classes for opReturn and remove the\nchecks which are not directly related to the OpReturn data like the fee\nand the phase checks. We set the verifiedOpReturnType in the\nTxOutputParser and do the check for fee and phase in the TxParser.","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/8596212c360fe3e5d4421b91122a439feebea836"},{"sha":"bf98696601c4301ca59b98087be119902a9aa2e9","author":{"name":"Chi Nul","email":"ebcd90ad4087fbf94d9557b399ebbc1292f508fc@disroot.org"},"message":"Make TxOutputParser.isUnlockBondTx() take output value\n\nThis is exactly what the method needs, so let's not pass it the entire\nTempTxOutput.\n\nAlso make the method static.\n\nAlso add docstring.","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/bf98696601c4301ca59b98087be119902a9aa2e9"},{"sha":"4f9d78bf8b7f62421233be346359b408a39aa793","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Refactor OpReturnParser for BlindVote\n\nAdd params to checkFeeAndPhase method.\n\nWe try to get rid of the sub parser classes for opReturn and remove the\nchecks which are not directly related to the OpReturn data like the fee\nand the phase checks. We set the verifiedOpReturnType in the\nTxOutputParser and do the check for fee and phase in the TxParser.","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/4f9d78bf8b7f62421233be346359b408a39aa793"},{"sha":"f57d66a40dde6d12e916dea6702cec5e2f630bd1","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Refactor OpReturnParser for VoteReveal\n\nAdd isPhaseValid method.\n\nWe try to get rid of the sub parser classes for opReturn and remove the\nchecks which are not directly related to the OpReturn data like the fee\nand the phase checks. We set the verifiedOpReturnType in the\nTxOutputParser and do the check for fee and phase in the TxParser.","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/f57d66a40dde6d12e916dea6702cec5e2f630bd1"},{"sha":"83bf2cac203f9cde4995214c4b5e235ea514c232","author":{"name":"Manfred Karrer","email":"a91dcbb4df49d8bfe0a9930d7ff911a4292ca1f5@nucleo.io"},"message":"Handle failure states better in TxParser","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/83bf2cac203f9cde4995214c4b5e235ea514c232"},{"sha":"dd324645069eda6758817c446ebefd9b3072cbad","author":{"name":"Chi Nul","email":"ebcd90ad4087fbf94d9557b399ebbc1292f508fc@disroot.org"},"message":"Refactor OpReturnParser and TxOutputParser methods\n\nOpReturnParser.parseAndValidate() now takes TempTxOutput as argument,\nand no longer needs TempTx or index. It takes a boolean lastOutput\ninstead of nonZeroOutput, as the latter can be deduced from the\nTempTxOutput.\n\nThe OpReturnParser.validate() method now takes blockHeight, and\nno longer needs the TempTx, which was only used for logging an\nerror case.\n\nFor TxOutputParser.processTxOutput(), it now takes a boolean lastOutput\nargument, which is passed on to OpReturnParser.parseAndValidate() as\nmentioned above. It no longer needs the TempTx either.\n\nAlso add docstring for TxOutputParser.processTxOutput().","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/dd324645069eda6758817c446ebefd9b3072cbad"},{"sha":"4c2022f81200e2ed01366059136ff8f919adcbfc","author":{"name":"Chi Nul","email":"ebcd90ad4087fbf94d9557b399ebbc1292f508fc@disroot.org"},"message":"Drop commented-out line from TxParser","distinct":true,"url":"https://api.github.com/repos/chirhonul/bisq-core/commits/4c2022f81200e2ed01366059136ff8f919adcbfc"}]}
{"actor":{"display_login":"chirhonul"}}