{"action":"created","comment":{"url":"https://api.github.com/repos/sussol/mobile/pulls/comments/173995839","pull_request_review_id":103274912,"id":173995839,"diff_hunk":"@@ -101,6 +101,7 @@ export class StocktakeEditPage extends React.Component {\n         sortDataType = 'string';\n         break;\n       case 'snapshotTotalQuantity':\n+      case 'countedTotalQuantity':","path":"src/pages/StocktakeEditPage.js","position":4,"original_position":4,"commit_id":"12b1cf727dabe6a725a742f4585c006a08da7f91","original_commit_id":"12b1cf727dabe6a725a742f4585c006a08da7f91","user":{"login":"Chris-Petty","id":7684221,"avatar_url":"https://avatars3.githubusercontent.com/u/7684221?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Petty","html_url":"https://github.com/Chris-Petty","followers_url":"https://api.github.com/users/Chris-Petty/followers","following_url":"https://api.github.com/users/Chris-Petty/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Petty/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Petty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Petty/subscriptions","organizations_url":"https://api.github.com/users/Chris-Petty/orgs","repos_url":"https://api.github.com/users/Chris-Petty/repos","events_url":"https://api.github.com/users/Chris-Petty/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Petty/received_events","type":"User","site_admin":false},"body":"Fixes crash on sorting. Realm can't sort by getters.","created_at":"2018-03-13T01:41:25Z","updated_at":"2018-03-13T01:41:25Z","html_url":"https://github.com/sussol/mobile/pull/627#discussion_r173995839","pull_request_url":"https://api.github.com/repos/sussol/mobile/pulls/627","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sussol/mobile/pulls/comments/173995839"},"html":{"href":"https://github.com/sussol/mobile/pull/627#discussion_r173995839"},"pull_request":{"href":"https://api.github.com/repos/sussol/mobile/pulls/627"}}},"pull_request":{"url":"https://api.github.com/repos/sussol/mobile/pulls/627","id":174537443,"html_url":"https://github.com/sussol/mobile/pull/627","diff_url":"https://github.com/sussol/mobile/pull/627.diff","patch_url":"https://github.com/sussol/mobile/pull/627.patch","issue_url":"https://api.github.com/repos/sussol/mobile/issues/627","number":627,"state":"open","locked":false,"title":"#617 #626 fix stocktake actual quantity","user":{"login":"Chris-Petty","id":7684221,"avatar_url":"https://avatars3.githubusercontent.com/u/7684221?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Petty","html_url":"https://github.com/Chris-Petty","followers_url":"https://api.github.com/users/Chris-Petty/followers","following_url":"https://api.github.com/users/Chris-Petty/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Petty/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Petty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Petty/subscriptions","organizations_url":"https://api.github.com/users/Chris-Petty/orgs","repos_url":"https://api.github.com/users/Chris-Petty/repos","events_url":"https://api.github.com/users/Chris-Petty/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Petty/received_events","type":"User","site_admin":false},"body":"fixes #617 \r\nfixes #626 \r\n\r\nFix not #412, tried to fix it using vscode but just totally messed up my commits as below...\r\n\r\nSo:\r\n\r\n- Sorting by actual quantity no longer crashes\r\n- Editing a actual quantity and setting it to previous actual quantity value doesn't set the countedTotalQuantity to snapshotQuantity\r\n- Finalised stocktakes that have 0 for countedTotalQuantity show 0 rather than blank.","created_at":"2018-03-13T01:38:56Z","updated_at":"2018-03-13T01:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a94818f639e1acbe263df2088f6e2f099286892","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sussol/mobile/pulls/627/commits","review_comments_url":"https://api.github.com/repos/sussol/mobile/pulls/627/comments","review_comment_url":"https://api.github.com/repos/sussol/mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sussol/mobile/issues/627/comments","statuses_url":"https://api.github.com/repos/sussol/mobile/statuses/12b1cf727dabe6a725a742f4585c006a08da7f91","head":{"label":"sussol:#617-#626-fix-stocktake-actual-quantity","ref":"#617-#626-fix-stocktake-actual-quantity","sha":"12b1cf727dabe6a725a742f4585c006a08da7f91","user":{"login":"sussol","id":11516369,"avatar_url":"https://avatars2.githubusercontent.com/u/11516369?v=4","gravatar_id":"","url":"https://api.github.com/users/sussol","html_url":"https://github.com/sussol","followers_url":"https://api.github.com/users/sussol/followers","following_url":"https://api.github.com/users/sussol/following{/other_user}","gists_url":"https://api.github.com/users/sussol/gists{/gist_id}","starred_url":"https://api.github.com/users/sussol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sussol/subscriptions","organizations_url":"https://api.github.com/users/sussol/orgs","repos_url":"https://api.github.com/users/sussol/repos","events_url":"https://api.github.com/users/sussol/events{/privacy}","received_events_url":"https://api.github.com/users/sussol/received_events","type":"Organization","site_admin":false},"repo":{"id":54153644,"name":"mobile","full_name":"sussol/mobile","owner":{"login":"sussol","id":11516369,"avatar_url":"https://avatars2.githubusercontent.com/u/11516369?v=4","gravatar_id":"","url":"https://api.github.com/users/sussol","html_url":"https://github.com/sussol","followers_url":"https://api.github.com/users/sussol/followers","following_url":"https://api.github.com/users/sussol/following{/other_user}","gists_url":"https://api.github.com/users/sussol/gists{/gist_id}","starred_url":"https://api.github.com/users/sussol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sussol/subscriptions","organizations_url":"https://api.github.com/users/sussol/orgs","repos_url":"https://api.github.com/users/sussol/repos","events_url":"https://api.github.com/users/sussol/events{/privacy}","received_events_url":"https://api.github.com/users/sussol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sussol/mobile","description":"Open source mobile app for medical inventory control","fork":false,"url":"https://api.github.com/repos/sussol/mobile","forks_url":"https://api.github.com/repos/sussol/mobile/forks","keys_url":"https://api.github.com/repos/sussol/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sussol/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sussol/mobile/teams","hooks_url":"https://api.github.com/repos/sussol/mobile/hooks","issue_events_url":"https://api.github.com/repos/sussol/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/sussol/mobile/events","assignees_url":"https://api.github.com/repos/sussol/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/sussol/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/sussol/mobile/tags","blobs_url":"https://api.github.com/repos/sussol/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sussol/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sussol/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/sussol/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sussol/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/sussol/mobile/languages","stargazers_url":"https://api.github.com/repos/sussol/mobile/stargazers","contributors_url":"https://api.github.com/repos/sussol/mobile/contributors","subscribers_url":"https://api.github.com/repos/sussol/mobile/subscribers","subscription_url":"https://api.github.com/repos/sussol/mobile/subscription","commits_url":"https://api.github.com/repos/sussol/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/sussol/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/sussol/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/sussol/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/sussol/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/sussol/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sussol/mobile/merges","archive_url":"https://api.github.com/repos/sussol/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sussol/mobile/downloads","issues_url":"https://api.github.com/repos/sussol/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/sussol/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/sussol/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/sussol/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sussol/mobile/labels{/name}","releases_url":"https://api.github.com/repos/sussol/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/sussol/mobile/deployments","created_at":"2016-03-17T21:46:35Z","updated_at":"2018-03-12T23:19:22Z","pushed_at":"2018-03-13T01:38:56Z","git_url":"git://github.com/sussol/mobile.git","ssh_url":"git@github.com:sussol/mobile.git","clone_url":"https://github.com/sussol/mobile.git","svn_url":"https://github.com/sussol/mobile","homepage":"http://msupply.org.nz/mobile","size":3551,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":87,"watchers":6,"default_branch":"master"}},"base":{"label":"sussol:master","ref":"master","sha":"809639070f8ef752e625196e27e45a31bf581b23","user":{"login":"sussol","id":11516369,"avatar_url":"https://avatars2.githubusercontent.com/u/11516369?v=4","gravatar_id":"","url":"https://api.github.com/users/sussol","html_url":"https://github.com/sussol","followers_url":"https://api.github.com/users/sussol/followers","following_url":"https://api.github.com/users/sussol/following{/other_user}","gists_url":"https://api.github.com/users/sussol/gists{/gist_id}","starred_url":"https://api.github.com/users/sussol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sussol/subscriptions","organizations_url":"https://api.github.com/users/sussol/orgs","repos_url":"https://api.github.com/users/sussol/repos","events_url":"https://api.github.com/users/sussol/events{/privacy}","received_events_url":"https://api.github.com/users/sussol/received_events","type":"Organization","site_admin":false},"repo":{"id":54153644,"name":"mobile","full_name":"sussol/mobile","owner":{"login":"sussol","id":11516369,"avatar_url":"https://avatars2.githubusercontent.com/u/11516369?v=4","gravatar_id":"","url":"https://api.github.com/users/sussol","html_url":"https://github.com/sussol","followers_url":"https://api.github.com/users/sussol/followers","following_url":"https://api.github.com/users/sussol/following{/other_user}","gists_url":"https://api.github.com/users/sussol/gists{/gist_id}","starred_url":"https://api.github.com/users/sussol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sussol/subscriptions","organizations_url":"https://api.github.com/users/sussol/orgs","repos_url":"https://api.github.com/users/sussol/repos","events_url":"https://api.github.com/users/sussol/events{/privacy}","received_events_url":"https://api.github.com/users/sussol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sussol/mobile","description":"Open source mobile app for medical inventory control","fork":false,"url":"https://api.github.com/repos/sussol/mobile","forks_url":"https://api.github.com/repos/sussol/mobile/forks","keys_url":"https://api.github.com/repos/sussol/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sussol/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sussol/mobile/teams","hooks_url":"https://api.github.com/repos/sussol/mobile/hooks","issue_events_url":"https://api.github.com/repos/sussol/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/sussol/mobile/events","assignees_url":"https://api.github.com/repos/sussol/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/sussol/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/sussol/mobile/tags","blobs_url":"https://api.github.com/repos/sussol/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sussol/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sussol/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/sussol/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sussol/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/sussol/mobile/languages","stargazers_url":"https://api.github.com/repos/sussol/mobile/stargazers","contributors_url":"https://api.github.com/repos/sussol/mobile/contributors","subscribers_url":"https://api.github.com/repos/sussol/mobile/subscribers","subscription_url":"https://api.github.com/repos/sussol/mobile/subscription","commits_url":"https://api.github.com/repos/sussol/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/sussol/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/sussol/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/sussol/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/sussol/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/sussol/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sussol/mobile/merges","archive_url":"https://api.github.com/repos/sussol/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sussol/mobile/downloads","issues_url":"https://api.github.com/repos/sussol/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/sussol/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/sussol/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/sussol/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sussol/mobile/labels{/name}","releases_url":"https://api.github.com/repos/sussol/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/sussol/mobile/deployments","created_at":"2016-03-17T21:46:35Z","updated_at":"2018-03-12T23:19:22Z","pushed_at":"2018-03-13T01:38:56Z","git_url":"git://github.com/sussol/mobile.git","ssh_url":"git@github.com:sussol/mobile.git","clone_url":"https://github.com/sussol/mobile.git","svn_url":"https://github.com/sussol/mobile","homepage":"http://msupply.org.nz/mobile","size":3551,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":87,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sussol/mobile/pulls/627"},"html":{"href":"https://github.com/sussol/mobile/pull/627"},"issue":{"href":"https://api.github.com/repos/sussol/mobile/issues/627"},"comments":{"href":"https://api.github.com/repos/sussol/mobile/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/sussol/mobile/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/sussol/mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sussol/mobile/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/sussol/mobile/statuses/12b1cf727dabe6a725a742f4585c006a08da7f91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Chris-Petty"}}