{"action":"created","issue":{"url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/41","repository_url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla","labels_url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/41/comments","events_url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/41/events","html_url":"https://github.com/Ko0z/UnitFramesImproved_Vanilla/issues/41","id":361668634,"node_id":"MDU6SXNzdWUzNjE2Njg2MzQ=","number":41,"title":"Few suggestions","user":{"login":"Stef-2","id":43405302,"node_id":"MDQ6VXNlcjQzNDA1MzAy","avatar_url":"https://avatars1.githubusercontent.com/u/43405302?v=4","gravatar_id":"","url":"https://api.github.com/users/Stef-2","html_url":"https://github.com/Stef-2","followers_url":"https://api.github.com/users/Stef-2/followers","following_url":"https://api.github.com/users/Stef-2/following{/other_user}","gists_url":"https://api.github.com/users/Stef-2/gists{/gist_id}","starred_url":"https://api.github.com/users/Stef-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stef-2/subscriptions","organizations_url":"https://api.github.com/users/Stef-2/orgs","repos_url":"https://api.github.com/users/Stef-2/repos","events_url":"https://api.github.com/users/Stef-2/events{/privacy}","received_events_url":"https://api.github.com/users/Stef-2/received_events","type":"User","site_admin":false},"labels":[{"id":482139754,"node_id":"MDU6TGFiZWw0ODIxMzk3NTQ=","url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-19T09:54:54Z","updated_at":"2018-10-22T19:12:56Z","closed_at":null,"author_association":"NONE","body":"Thank you for a very nice addon, I have a few issues and suggestions:\r\n\r\n- user preferences should be saved as SavedVariables instead of CVars.\r\n\r\n- an option to revert to standard looking player frames would be nice.\r\n\r\n- the debuff icons underneath the enemy frame appear to be stuck in a \"dark theme\" regardless of the \"dark mode\" option choice."},"comment":{"url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/comments/431943440","html_url":"https://github.com/Ko0z/UnitFramesImproved_Vanilla/issues/41#issuecomment-431943440","issue_url":"https://api.github.com/repos/Ko0z/UnitFramesImproved_Vanilla/issues/41","id":431943440,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTk0MzQ0MA==","user":{"login":"Stef-2","id":43405302,"node_id":"MDQ6VXNlcjQzNDA1MzAy","avatar_url":"https://avatars1.githubusercontent.com/u/43405302?v=4","gravatar_id":"","url":"https://api.github.com/users/Stef-2","html_url":"https://github.com/Stef-2","followers_url":"https://api.github.com/users/Stef-2/followers","following_url":"https://api.github.com/users/Stef-2/following{/other_user}","gists_url":"https://api.github.com/users/Stef-2/gists{/gist_id}","starred_url":"https://api.github.com/users/Stef-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stef-2/subscriptions","organizations_url":"https://api.github.com/users/Stef-2/orgs","repos_url":"https://api.github.com/users/Stef-2/repos","events_url":"https://api.github.com/users/Stef-2/events{/privacy}","received_events_url":"https://api.github.com/users/Stef-2/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T19:12:56Z","updated_at":"2018-10-22T19:12:56Z","author_association":"NONE","body":"@Ko0z Sorry for taking this long to respond, I'm fairly new to GitHub,\r\n\r\nto elaborate on my second point - I quite like the vanilla look of the player and target frames in the sense that the player name area is separate from the player health one and has a different color to it. This may sound picky but removing the bar which separates them and making the entire thing green or class color messes with that, along with clashing with certain other addons which still only use one of those areas as bars for casting, received healing and such. I'll provide a picture which better explains my points. Again, I very much like your addon for the class icons, ease of moving the frames, dark mode, and customizable text / values in the frames. The option to keep name and health bars separate like in vanilla was just a suggestion.\r\n![ufi_compare](https://user-images.githubusercontent.com/43405302/47313208-a20ede80-d63e-11e8-9344-d0abb6e098f4.png)\r\nIn the target bar on the right you can see how the integrated cast bar provided by enemyframes addon kinda clashes with the look of your frames since the name and health bars are put together."}}
{"actor":{"display_login":"Stef-2"}}