{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/241095697","pull_request_review_id":184281630,"id":241095697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA5NTY5Nw==","diff_hunk":"@@ -0,0 +1,166 @@\n+# Fork Selection\n+ This RFC defines Solana's *Nakomoto Fork Selection* algorithm based on time locks. It satisfies the following properties:\n+\n+\n+* A voter can eventually recover from voting on a fork that doesn't become the fork with the desired finality.\n+* If the voters share a common ancestor then they will converge to a fork containing that ancestor no matter how they are partitioned. Although it may not be the latest possible ancestor at the start of the fork.","path":"rfcs/0005-fork-selection.md","position":6,"original_position":6,"commit_id":"862a66b48b90066caccaf32ada1aa7227ea0a997","original_commit_id":"862a66b48b90066caccaf32ada1aa7227ea0a997","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"body":"The second sentence is not a sentence.","created_at":"2018-12-12T16:48:49Z","updated_at":"2018-12-12T16:56:47Z","html_url":"https://github.com/solana-labs/solana/pull/2061#discussion_r241095697","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/2061","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/241095697"},"html":{"href":"https://github.com/solana-labs/solana/pull/2061#discussion_r241095697"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2061"}}},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/2061","id":237025614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDI1NjE0","html_url":"https://github.com/solana-labs/solana/pull/2061","diff_url":"https://github.com/solana-labs/solana/pull/2061.diff","patch_url":"https://github.com/solana-labs/solana/pull/2061.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/2061","number":2061,"state":"open","locked":false,"title":"Add fork selection RFC","user":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"body":"#### Problem\r\n\r\nLack of RFC on fork selection.\r\n\r\n#### Summary of Changes\r\n\r\nRFC on fork selection and simulation.\r\n\r\nFixes # #1983 (choice based on maximizing finality should be censorship resistant)\r\n","created_at":"2018-12-08T00:00:17Z","updated_at":"2018-12-12T16:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1141aebd18215f74dcf3a2dcd40e8f6eea8fa53d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carllin","id":3374799,"node_id":"MDQ6VXNlcjMzNzQ3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3374799?v=4","gravatar_id":"","url":"https://api.github.com/users/carllin","html_url":"https://github.com/carllin","followers_url":"https://api.github.com/users/carllin/followers","following_url":"https://api.github.com/users/carllin/following{/other_user}","gists_url":"https://api.github.com/users/carllin/gists{/gist_id}","starred_url":"https://api.github.com/users/carllin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllin/subscriptions","organizations_url":"https://api.github.com/users/carllin/orgs","repos_url":"https://api.github.com/users/carllin/repos","events_url":"https://api.github.com/users/carllin/events{/privacy}","received_events_url":"https://api.github.com/users/carllin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/2061/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/2061/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/2061/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/862a66b48b90066caccaf32ada1aa7227ea0a997","head":{"label":"aeyakovenko:branch_generation_rfc_with_locktower","ref":"branch_generation_rfc_with_locktower","sha":"862a66b48b90066caccaf32ada1aa7227ea0a997","user":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"repo":{"id":124140461,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxNDA0NjE=","name":"solana","full_name":"aeyakovenko/solana","private":false,"owner":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aeyakovenko/solana","description":"a high performance blockchain","fork":true,"url":"https://api.github.com/repos/aeyakovenko/solana","forks_url":"https://api.github.com/repos/aeyakovenko/solana/forks","keys_url":"https://api.github.com/repos/aeyakovenko/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeyakovenko/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeyakovenko/solana/teams","hooks_url":"https://api.github.com/repos/aeyakovenko/solana/hooks","issue_events_url":"https://api.github.com/repos/aeyakovenko/solana/issues/events{/number}","events_url":"https://api.github.com/repos/aeyakovenko/solana/events","assignees_url":"https://api.github.com/repos/aeyakovenko/solana/assignees{/user}","branches_url":"https://api.github.com/repos/aeyakovenko/solana/branches{/branch}","tags_url":"https://api.github.com/repos/aeyakovenko/solana/tags","blobs_url":"https://api.github.com/repos/aeyakovenko/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeyakovenko/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeyakovenko/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeyakovenko/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeyakovenko/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/aeyakovenko/solana/languages","stargazers_url":"https://api.github.com/repos/aeyakovenko/solana/stargazers","contributors_url":"https://api.github.com/repos/aeyakovenko/solana/contributors","subscribers_url":"https://api.github.com/repos/aeyakovenko/solana/subscribers","subscription_url":"https://api.github.com/repos/aeyakovenko/solana/subscription","commits_url":"https://api.github.com/repos/aeyakovenko/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeyakovenko/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeyakovenko/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeyakovenko/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeyakovenko/solana/contents/{+path}","compare_url":"https://api.github.com/repos/aeyakovenko/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeyakovenko/solana/merges","archive_url":"https://api.github.com/repos/aeyakovenko/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeyakovenko/solana/downloads","issues_url":"https://api.github.com/repos/aeyakovenko/solana/issues{/number}","pulls_url":"https://api.github.com/repos/aeyakovenko/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/aeyakovenko/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/aeyakovenko/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeyakovenko/solana/labels{/name}","releases_url":"https://api.github.com/repos/aeyakovenko/solana/releases{/id}","deployments_url":"https://api.github.com/repos/aeyakovenko/solana/deployments","created_at":"2018-03-06T21:24:10Z","updated_at":"2018-11-16T17:52:45Z","pushed_at":"2018-12-12T15:08:56Z","git_url":"git://github.com/aeyakovenko/solana.git","ssh_url":"git@github.com:aeyakovenko/solana.git","clone_url":"https://github.com/aeyakovenko/solana.git","svn_url":"https://github.com/aeyakovenko/solana","homepage":"https://solana.com","size":14408,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"ad05f64b136dc71f0d88f59164c2d4d70d543ded","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","private":false,"owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/solana-labs/solana","description":"Blockchain Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-12-12T16:41:51Z","pushed_at":"2018-12-12T16:41:47Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":14677,"stargazers_count":398,"watchers_count":398,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":69,"open_issues":177,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2061"},"html":{"href":"https://github.com/solana-labs/solana/pull/2061"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/2061"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/2061/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2061/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2061/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/862a66b48b90066caccaf32ada1aa7227ea0a997"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"garious"}}