{"action":"created","issue":{"url":"https://api.github.com/repos/gerbera/gerbera/issues/267","repository_url":"https://api.github.com/repos/gerbera/gerbera","labels_url":"https://api.github.com/repos/gerbera/gerbera/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/gerbera/gerbera/issues/267/comments","events_url":"https://api.github.com/repos/gerbera/gerbera/issues/267/events","html_url":"https://github.com/gerbera/gerbera/pull/267","id":306665785,"number":267,"title":"Basic implementation of upnp search","user":{"login":"astylos","id":16252944,"avatar_url":"https://avatars2.githubusercontent.com/u/16252944?v=4","gravatar_id":"","url":"https://api.github.com/users/astylos","html_url":"https://github.com/astylos","followers_url":"https://api.github.com/users/astylos/followers","following_url":"https://api.github.com/users/astylos/following{/other_user}","gists_url":"https://api.github.com/users/astylos/gists{/gist_id}","starred_url":"https://api.github.com/users/astylos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astylos/subscriptions","organizations_url":"https://api.github.com/users/astylos/orgs","repos_url":"https://api.github.com/users/astylos/repos","events_url":"https://api.github.com/users/astylos/events{/privacy}","received_events_url":"https://api.github.com/users/astylos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-19T22:47:15Z","updated_at":"2018-03-21T13:45:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gerbera/gerbera/pulls/267","html_url":"https://github.com/gerbera/gerbera/pull/267","diff_url":"https://github.com/gerbera/gerbera/pull/267.diff","patch_url":"https://github.com/gerbera/gerbera/pull/267.patch"},"body":"Implements some of the functionality defined in standardizeddcps\\MediaServer_4 and MediaRenderer_3\\UPnP-av-ContentDirectory-v4-Service-20150630.pdf\r\nDocument available in upnpresources.zip, download from here:\r\nhttps://openconnectivity.org/developer/specifications/upnp-resources/upnp\r\n\r\nExample search sent by a client such as foobar2000 or BubbleUPNP:\r\n```\r\nupnp:class derivedfrom \"object.item.audioItem\" and (upnp:album contains \"Midnight\")\r\n```\r\nMain changes to existing codebase:\r\n1. New mt_metadata table\r\n2. Schema upgrade on gerbera startup includes migration of existing metadata from mt_cds_object to mt_metadata (but it **does not** remove metadata from mt_cds_object)\r\n3. All new metadata stored in mt_metadata\r\n\r\nSee #249 for more background/issues that came up when working on this.\r\n\r\nMost obvious functional issue is albums cannot be found since no album metadata stored - see #255 Album metadata not persisted.\r\n\r\nRegarding the code itself, I tried to use modern C++ and avoid zmm in new classes. At times I did wonder whether that was a good idea given how unique_ptr/shared_ptr work so differently to zmm::Ref."},"comment":{"url":"https://api.github.com/repos/gerbera/gerbera/issues/comments/374941532","html_url":"https://github.com/gerbera/gerbera/pull/267#issuecomment-374941532","issue_url":"https://api.github.com/repos/gerbera/gerbera/issues/267","id":374941532,"user":{"login":"v00d00","id":345034,"avatar_url":"https://avatars2.githubusercontent.com/u/345034?v=4","gravatar_id":"","url":"https://api.github.com/users/v00d00","html_url":"https://github.com/v00d00","followers_url":"https://api.github.com/users/v00d00/followers","following_url":"https://api.github.com/users/v00d00/following{/other_user}","gists_url":"https://api.github.com/users/v00d00/gists{/gist_id}","starred_url":"https://api.github.com/users/v00d00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v00d00/subscriptions","organizations_url":"https://api.github.com/users/v00d00/orgs","repos_url":"https://api.github.com/users/v00d00/repos","events_url":"https://api.github.com/users/v00d00/events{/privacy}","received_events_url":"https://api.github.com/users/v00d00/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T13:45:48Z","updated_at":"2018-03-21T13:45:48Z","author_association":"COLLABORATOR","body":"@astylos Are you happy for me to squash merge this, or would you rather tidy the history up yourself?"}}
{"actor":{"display_login":"v00d00"}}