{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/5219","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/5219/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/5219/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/5219/events","html_url":"https://github.com/fish-shell/fish-shell/pull/5219","id":365172570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTcyOTcx","number":5219,"title":"Overhaul process reaping and terminal control","user":{"login":"mqudsi","id":606923,"node_id":"MDQ6VXNlcjYwNjkyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/606923?v=4","gravatar_id":"","url":"https://api.github.com/users/mqudsi","html_url":"https://github.com/mqudsi","followers_url":"https://api.github.com/users/mqudsi/followers","following_url":"https://api.github.com/users/mqudsi/following{/other_user}","gists_url":"https://api.github.com/users/mqudsi/gists{/gist_id}","starred_url":"https://api.github.com/users/mqudsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqudsi/subscriptions","organizations_url":"https://api.github.com/users/mqudsi/orgs","repos_url":"https://api.github.com/users/mqudsi/repos","events_url":"https://api.github.com/users/mqudsi/events{/privacy}","received_events_url":"https://api.github.com/users/mqudsi/received_events","type":"User","site_admin":false},"labels":[{"id":4724776,"node_id":"MDU6TGFiZWw0NzI0Nzc2","url":"https://api.github.com/repos/fish-shell/fish-shell/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4","html_url":"https://github.com/fish-shell/fish-shell/milestone/4","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/4/labels","id":130257,"node_id":"MDk6TWlsZXN0b25lMTMwMjU3","number":4,"title":"fish-future","description":"These are issues that are not targeted for an upcoming minor or major release. After a release, we will re-examine these issues and pull any in that we think are good targets; that is retarget them to the next minor (or major) release.\r\n\r\nIf you can provide a fix for an issue in this milestone, we'll generally accept it for the next release even if the issue is not targeted for the release.","creator":{"login":"ridiculousfish","id":920838,"node_id":"MDQ6VXNlcjkyMDgzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/920838?v=4","gravatar_id":"","url":"https://api.github.com/users/ridiculousfish","html_url":"https://github.com/ridiculousfish","followers_url":"https://api.github.com/users/ridiculousfish/followers","following_url":"https://api.github.com/users/ridiculousfish/following{/other_user}","gists_url":"https://api.github.com/users/ridiculousfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ridiculousfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridiculousfish/subscriptions","organizations_url":"https://api.github.com/users/ridiculousfish/orgs","repos_url":"https://api.github.com/users/ridiculousfish/repos","events_url":"https://api.github.com/users/ridiculousfish/events{/privacy}","received_events_url":"https://api.github.com/users/ridiculousfish/received_events","type":"User","site_admin":false},"open_issues":409,"closed_issues":10,"state":"open","created_at":"2012-06-11T02:25:13Z","updated_at":"2018-10-10T03:57:26Z","due_on":null,"closed_at":null},"comments":42,"created_at":"2018-09-29T22:36:00Z","updated_at":"2018-10-13T07:01:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/5219","html_url":"https://github.com/fish-shell/fish-shell/pull/5219","diff_url":"https://github.com/fish-shell/fish-shell/pull/5219.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/5219.patch"},"body":"I _believe_ this finally safely does away with the keepalive process. I think the problem is that we were waiting on all child processes in `process_mark_finished_children` which caused premature reaping of terminated processes before their process group could be joined by new processes in the same job.\r\n\r\nAdditionally, there was a deadlock in `try_select` that didn't show up until that change was made.\r\n\r\nThis should fix #4178 (which manifests in two *entirely* different ways depending on whether connected over SSH and FreeBSD vs Linux) and quite likely some other issues as well.\r\n\r\n~~This branch should likely be squash-merged.~~"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/429517269","html_url":"https://github.com/fish-shell/fish-shell/pull/5219#issuecomment-429517269","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/5219","id":429517269,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTUxNzI2OQ==","user":{"login":"faho","id":5185367,"node_id":"MDQ6VXNlcjUxODUzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5185367?v=4","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T07:01:15Z","updated_at":"2018-10-13T07:01:15Z","author_association":"MEMBER","body":"However, this is missing a `#include <functional>` in common.h for me (gcc 8.2.1). You might want to add that!"}}
{"actor":{"display_login":"faho"}}