{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/179849183","pull_request_review_id":110175628,"id":179849183,"diff_hunk":"@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final Set<String> labels) {\n         while (true) {\n             if (this.first) {\n                 this.first = false;\n-                this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);\n+                this.initializeMatchAlgorithm(true);","path":"gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java","position":null,"original_position":41,"commit_id":"11519d56b72d666d8fe06580bac0018971088a71","original_commit_id":"38e74727f3d9e3fc14c52bddf354a8936b1731b5","user":{"login":"spmallette","id":384249,"avatar_url":"https://avatars0.githubusercontent.com/u/384249?v=4","gravatar_id":"","url":"https://api.github.com/users/spmallette","html_url":"https://github.com/spmallette","followers_url":"https://api.github.com/users/spmallette/followers","following_url":"https://api.github.com/users/spmallette/following{/other_user}","gists_url":"https://api.github.com/users/spmallette/gists{/gist_id}","starred_url":"https://api.github.com/users/spmallette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spmallette/subscriptions","organizations_url":"https://api.github.com/users/spmallette/orgs","repos_url":"https://api.github.com/users/spmallette/repos","events_url":"https://api.github.com/users/spmallette/events{/privacy}","received_events_url":"https://api.github.com/users/spmallette/received_events","type":"User","site_admin":false},"body":"that makes sense - fixed and pushed","created_at":"2018-04-06T19:04:15Z","updated_at":"2018-04-06T19:04:16Z","html_url":"https://github.com/apache/tinkerpop/pull/830#discussion_r179849183","pull_request_url":"https://api.github.com/repos/apache/tinkerpop/pulls/830","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/179849183"},"html":{"href":"https://github.com/apache/tinkerpop/pull/830#discussion_r179849183"},"pull_request":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/830"}},"in_reply_to_id":179829888},"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/830","id":179641993,"html_url":"https://github.com/apache/tinkerpop/pull/830","diff_url":"https://github.com/apache/tinkerpop/pull/830.diff","patch_url":"https://github.com/apache/tinkerpop/pull/830.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/830","number":830,"state":"open","locked":false,"title":"TINKERPOP-1143 Moved TraversalEngine to gremlin-test","user":{"login":"spmallette","id":384249,"avatar_url":"https://avatars0.githubusercontent.com/u/384249?v=4","gravatar_id":"","url":"https://api.github.com/users/spmallette","html_url":"https://github.com/spmallette","followers_url":"https://api.github.com/users/spmallette/followers","following_url":"https://api.github.com/users/spmallette/following{/other_user}","gists_url":"https://api.github.com/users/spmallette/gists{/gist_id}","starred_url":"https://api.github.com/users/spmallette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spmallette/subscriptions","organizations_url":"https://api.github.com/users/spmallette/orgs","repos_url":"https://api.github.com/users/spmallette/repos","events_url":"https://api.github.com/users/spmallette/events{/privacy}","received_events_url":"https://api.github.com/users/spmallette/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TINKERPOP-1143\r\n\r\n`TraversalEngine` and related infrastructure was deprecated way back on 3.2.0 but it was kept around because it was used in some infrastructure for testing. Graph providers should in no way still be using this interface and should have long ago gone to `Computer` as the `gremlin-core` infrastructure long ago quit using `TraversalEngine` in any capacity.\r\n\r\nThe only weird part was that `MatchStep` used `TraversalEngine` as a switch - I just converted that to use a boolean for checks that determine if the step is being executed `onComputer` or not.\r\n\r\nAll tests pass with `docker/build.sh -t -n -i`\r\n\r\nVOTE +1","created_at":"2018-04-05T11:04:02Z","updated_at":"2018-04-06T19:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5834b1b4600b8d4dc98eafaf5cd600f4842775d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/830/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/830/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/830/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/11519d56b72d666d8fe06580bac0018971088a71","head":{"label":"apache:TINKERPOP-1143","ref":"TINKERPOP-1143","sha":"11519d56b72d666d8fe06580bac0018971088a71","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2018-04-06T14:32:55Z","pushed_at":"2018-04-06T19:03:50Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":145150,"stargazers_count":512,"watchers_count":512,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":294,"open_issues":13,"watchers":512,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c14aa30fbaae5971bfb3a2bb24acb964c98e882f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2018-04-06T14:32:55Z","pushed_at":"2018-04-06T19:03:50Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":145150,"stargazers_count":512,"watchers_count":512,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":294,"open_issues":13,"watchers":512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/830"},"html":{"href":"https://github.com/apache/tinkerpop/pull/830"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/830"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/11519d56b72d666d8fe06580bac0018971088a71"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spmallette"}}