{"action":"created","comment":{"url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments/187947841","pull_request_review_id":119827167,"id":187947841,"diff_hunk":"@@ -168,5 +128,48 @@ RUN if [ \"$TOMCAT_EXTRAS\" = false ]; then \\\n     rm -rf $CATALINA_HOME/webapps/manager; \\\n   fi;\n \n+# Add unlimited crypto support\n+ENV JRE_HOME $JAVA_HOME/jre\n+COPY ./UnlimitedJCEPolicyJDK8/*.jar $JRE_HOME/lib/security/\n+\n+#RUN export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib:/usr/lib/x86_64-linux-gnu:/opt/libjpeg-turbo/lib64\n+\n+#webxml update for environment\n+RUN rm /usr/local/tomcat/webapps/geoserver/WEB-INF/web.xml\n+COPY ./web.xml /usr/local/tomcat/webapps/geoserver/WEB-INF/","path":"Dockerfile","position":238,"original_position":238,"commit_id":"5ef41216b17db5f511ce3189dfa79d15e501678f","original_commit_id":"5ef41216b17db5f511ce3189dfa79d15e501678f","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"body":"This is generally not a good method for using the web.xml. If we change the version of Geoserver we are building then we might break Geoserver by having a different web.xml. And what changes are being introduced into the container from web.xml","created_at":"2018-05-14T13:15:16Z","updated_at":"2018-05-14T13:15:17Z","html_url":"https://github.com/kartoza/docker-geoserver/pull/33#discussion_r187947841","pull_request_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments/187947841"},"html":{"href":"https://github.com/kartoza/docker-geoserver/pull/33#discussion_r187947841"},"pull_request":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33","id":187818458,"html_url":"https://github.com/kartoza/docker-geoserver/pull/33","diff_url":"https://github.com/kartoza/docker-geoserver/pull/33.diff","patch_url":"https://github.com/kartoza/docker-geoserver/pull/33.patch","issue_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/33","number":33,"state":"open","locked":false,"title":"Security","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"body":"Security Review","created_at":"2018-05-14T12:57:38Z","updated_at":"2018-05-14T13:15:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"gubuntu","id":496911,"avatar_url":"https://avatars3.githubusercontent.com/u/496911?v=4","gravatar_id":"","url":"https://api.github.com/users/gubuntu","html_url":"https://github.com/gubuntu","followers_url":"https://api.github.com/users/gubuntu/followers","following_url":"https://api.github.com/users/gubuntu/following{/other_user}","gists_url":"https://api.github.com/users/gubuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/gubuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gubuntu/subscriptions","organizations_url":"https://api.github.com/users/gubuntu/orgs","repos_url":"https://api.github.com/users/gubuntu/repos","events_url":"https://api.github.com/users/gubuntu/events{/privacy}","received_events_url":"https://api.github.com/users/gubuntu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33/commits","review_comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33/comments","review_comment_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/33/comments","statuses_url":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/5ef41216b17db5f511ce3189dfa79d15e501678f","head":{"label":"NyakudyaA:security","ref":"security","sha":"5ef41216b17db5f511ce3189dfa79d15e501678f","user":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"repo":{"id":122829232,"name":"docker-geoserver","full_name":"NyakudyaA/docker-geoserver","owner":{"login":"NyakudyaA","id":2510900,"avatar_url":"https://avatars2.githubusercontent.com/u/2510900?v=4","gravatar_id":"","url":"https://api.github.com/users/NyakudyaA","html_url":"https://github.com/NyakudyaA","followers_url":"https://api.github.com/users/NyakudyaA/followers","following_url":"https://api.github.com/users/NyakudyaA/following{/other_user}","gists_url":"https://api.github.com/users/NyakudyaA/gists{/gist_id}","starred_url":"https://api.github.com/users/NyakudyaA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NyakudyaA/subscriptions","organizations_url":"https://api.github.com/users/NyakudyaA/orgs","repos_url":"https://api.github.com/users/NyakudyaA/repos","events_url":"https://api.github.com/users/NyakudyaA/events{/privacy}","received_events_url":"https://api.github.com/users/NyakudyaA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NyakudyaA/docker-geoserver","description":"A docker recipe for GeoServer","fork":true,"url":"https://api.github.com/repos/NyakudyaA/docker-geoserver","forks_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/forks","keys_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/teams","hooks_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/hooks","issue_events_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/events","assignees_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/tags","blobs_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/languages","stargazers_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/stargazers","contributors_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/contributors","subscribers_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/subscribers","subscription_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/subscription","commits_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/merges","archive_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/downloads","issues_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/labels{/name}","releases_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/NyakudyaA/docker-geoserver/deployments","created_at":"2018-02-25T11:18:19Z","updated_at":"2018-05-14T12:54:32Z","pushed_at":"2018-05-14T12:56:32Z","git_url":"git://github.com/NyakudyaA/docker-geoserver.git","ssh_url":"git@github.com:NyakudyaA/docker-geoserver.git","clone_url":"https://github.com/NyakudyaA/docker-geoserver.git","svn_url":"https://github.com/NyakudyaA/docker-geoserver","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kartoza:master","ref":"master","sha":"6889e78a664cd321202226a00fec4ae1a571b1e6","user":{"login":"kartoza","id":7395888,"avatar_url":"https://avatars3.githubusercontent.com/u/7395888?v=4","gravatar_id":"","url":"https://api.github.com/users/kartoza","html_url":"https://github.com/kartoza","followers_url":"https://api.github.com/users/kartoza/followers","following_url":"https://api.github.com/users/kartoza/following{/other_user}","gists_url":"https://api.github.com/users/kartoza/gists{/gist_id}","starred_url":"https://api.github.com/users/kartoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartoza/subscriptions","organizations_url":"https://api.github.com/users/kartoza/orgs","repos_url":"https://api.github.com/users/kartoza/repos","events_url":"https://api.github.com/users/kartoza/events{/privacy}","received_events_url":"https://api.github.com/users/kartoza/received_events","type":"Organization","site_admin":false},"repo":{"id":21318833,"name":"docker-geoserver","full_name":"kartoza/docker-geoserver","owner":{"login":"kartoza","id":7395888,"avatar_url":"https://avatars3.githubusercontent.com/u/7395888?v=4","gravatar_id":"","url":"https://api.github.com/users/kartoza","html_url":"https://github.com/kartoza","followers_url":"https://api.github.com/users/kartoza/followers","following_url":"https://api.github.com/users/kartoza/following{/other_user}","gists_url":"https://api.github.com/users/kartoza/gists{/gist_id}","starred_url":"https://api.github.com/users/kartoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartoza/subscriptions","organizations_url":"https://api.github.com/users/kartoza/orgs","repos_url":"https://api.github.com/users/kartoza/repos","events_url":"https://api.github.com/users/kartoza/events{/privacy}","received_events_url":"https://api.github.com/users/kartoza/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kartoza/docker-geoserver","description":"A docker recipe for GeoServer","fork":false,"url":"https://api.github.com/repos/kartoza/docker-geoserver","forks_url":"https://api.github.com/repos/kartoza/docker-geoserver/forks","keys_url":"https://api.github.com/repos/kartoza/docker-geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kartoza/docker-geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kartoza/docker-geoserver/teams","hooks_url":"https://api.github.com/repos/kartoza/docker-geoserver/hooks","issue_events_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/kartoza/docker-geoserver/events","assignees_url":"https://api.github.com/repos/kartoza/docker-geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/kartoza/docker-geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/kartoza/docker-geoserver/tags","blobs_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/kartoza/docker-geoserver/languages","stargazers_url":"https://api.github.com/repos/kartoza/docker-geoserver/stargazers","contributors_url":"https://api.github.com/repos/kartoza/docker-geoserver/contributors","subscribers_url":"https://api.github.com/repos/kartoza/docker-geoserver/subscribers","subscription_url":"https://api.github.com/repos/kartoza/docker-geoserver/subscription","commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/kartoza/docker-geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/kartoza/docker-geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/kartoza/docker-geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/kartoza/docker-geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kartoza/docker-geoserver/merges","archive_url":"https://api.github.com/repos/kartoza/docker-geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kartoza/docker-geoserver/downloads","issues_url":"https://api.github.com/repos/kartoza/docker-geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/kartoza/docker-geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/kartoza/docker-geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/kartoza/docker-geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kartoza/docker-geoserver/labels{/name}","releases_url":"https://api.github.com/repos/kartoza/docker-geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/kartoza/docker-geoserver/deployments","created_at":"2014-06-29T07:37:20Z","updated_at":"2018-05-08T12:35:07Z","pushed_at":"2018-05-14T12:57:39Z","git_url":"git://github.com/kartoza/docker-geoserver.git","ssh_url":"git@github.com:kartoza/docker-geoserver.git","clone_url":"https://github.com/kartoza/docker-geoserver.git","svn_url":"https://github.com/kartoza/docker-geoserver","homepage":null,"size":78,"stargazers_count":90,"watchers_count":90,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":71,"open_issues":4,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33"},"html":{"href":"https://github.com/kartoza/docker-geoserver/pull/33"},"issue":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/issues/33"},"comments":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/kartoza/docker-geoserver/statuses/5ef41216b17db5f511ce3189dfa79d15e501678f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NyakudyaA"}}