{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/219941706","pull_request_review_id":158236328,"id":219941706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk0MTcwNg==","diff_hunk":"@@ -95,22 +95,22 @@ impl BankingStage {\n         while chunk_start != transactions.len() {\n             let chunk_end = chunk_start + Entry::num_will_fit(transactions[chunk_start..].to_vec());\n \n-            let results = bank.process_transactions(transactions[chunk_start..chunk_end].to_vec());\n-\n+            let results = bank.process_transactions(&transactions[chunk_start..chunk_end]);\n             debug!(\"results: {}\", results.len());\n \n             chunk_start = chunk_end;\n \n             let mut hasher = Hasher::default();\n \n-            let processed_transactions: Vec<_> = results\n+            let processed_transactions: Vec<_> = transactions[chunk_start..chunk_end]","path":"src/banking_stage.rs","position":14,"original_position":14,"commit_id":"df134e08c1ac0a73a41897321422945ae54692b2","original_commit_id":"df134e08c1ac0a73a41897321422945ae54692b2","user":{"login":"rob-solana","id":40183961,"node_id":"MDQ6VXNlcjQwMTgzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/40183961?v=4","gravatar_id":"","url":"https://api.github.com/users/rob-solana","html_url":"https://github.com/rob-solana","followers_url":"https://api.github.com/users/rob-solana/followers","following_url":"https://api.github.com/users/rob-solana/following{/other_user}","gists_url":"https://api.github.com/users/rob-solana/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-solana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-solana/subscriptions","organizations_url":"https://api.github.com/users/rob-solana/orgs","repos_url":"https://api.github.com/users/rob-solana/repos","events_url":"https://api.github.com/users/rob-solana/events{/privacy}","received_events_url":"https://api.github.com/users/rob-solana/received_events","type":"User","site_admin":false},"body":"move line 101 past this and you'll be golden","created_at":"2018-09-24T18:29:29Z","updated_at":"2018-09-24T18:29:29Z","html_url":"https://github.com/solana-labs/solana/pull/1319#discussion_r219941706","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/1319","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/219941706"},"html":{"href":"https://github.com/solana-labs/solana/pull/1319#discussion_r219941706"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1319"}}},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/1319","id":217714651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzE0NjUx","html_url":"https://github.com/solana-labs/solana/pull/1319","diff_url":"https://github.com/solana-labs/solana/pull/1319.diff","patch_url":"https://github.com/solana-labs/solana/pull/1319.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/1319","number":1319,"state":"open","locked":false,"title":"Pass Bank::process_transactions() a reference instead of moving","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"body":"When we move the transaction from input to `Result<Transaction>`, we lose the ability to reference the original transaction in the error case. Our choices are to populate the error structures with more data (specifically, the Signature) or change these functions to borrow the transaction. This PR chooses the latter. Not certain that's the right choice. Thoughts?\r\n\r\nThis PR is a WIP because it breaks the integration tests. Need to debug...","created_at":"2018-09-24T16:26:58Z","updated_at":"2018-09-24T18:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebc1f5ba5a008295906b7ff012986390e1228e9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":934588962,"node_id":"MDU6TGFiZWw5MzQ1ODg5NjI=","url":"https://api.github.com/repos/solana-labs/solana/labels/work%20in%20progress","name":"work in progress","color":"bf722a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/1319/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/1319/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/1319/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/df134e08c1ac0a73a41897321422945ae54692b2","head":{"label":"garious:dont-move-txs","ref":"dont-move-txs","sha":"df134e08c1ac0a73a41897321422945ae54692b2","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"repo":{"id":121788525,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3ODg1MjU=","name":"solana","full_name":"garious/solana","private":false,"owner":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"html_url":"https://github.com/garious/solana","description":"Blockchain, Rebuilt for Scale","fork":true,"url":"https://api.github.com/repos/garious/solana","forks_url":"https://api.github.com/repos/garious/solana/forks","keys_url":"https://api.github.com/repos/garious/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garious/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garious/solana/teams","hooks_url":"https://api.github.com/repos/garious/solana/hooks","issue_events_url":"https://api.github.com/repos/garious/solana/issues/events{/number}","events_url":"https://api.github.com/repos/garious/solana/events","assignees_url":"https://api.github.com/repos/garious/solana/assignees{/user}","branches_url":"https://api.github.com/repos/garious/solana/branches{/branch}","tags_url":"https://api.github.com/repos/garious/solana/tags","blobs_url":"https://api.github.com/repos/garious/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garious/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garious/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/garious/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garious/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/garious/solana/languages","stargazers_url":"https://api.github.com/repos/garious/solana/stargazers","contributors_url":"https://api.github.com/repos/garious/solana/contributors","subscribers_url":"https://api.github.com/repos/garious/solana/subscribers","subscription_url":"https://api.github.com/repos/garious/solana/subscription","commits_url":"https://api.github.com/repos/garious/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/garious/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/garious/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/garious/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/garious/solana/contents/{+path}","compare_url":"https://api.github.com/repos/garious/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garious/solana/merges","archive_url":"https://api.github.com/repos/garious/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garious/solana/downloads","issues_url":"https://api.github.com/repos/garious/solana/issues{/number}","pulls_url":"https://api.github.com/repos/garious/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/garious/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/garious/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garious/solana/labels{/name}","releases_url":"https://api.github.com/repos/garious/solana/releases{/id}","deployments_url":"https://api.github.com/repos/garious/solana/deployments","created_at":"2018-02-16T18:56:42Z","updated_at":"2018-07-17T20:22:57Z","pushed_at":"2018-09-24T16:22:43Z","git_url":"git://github.com/garious/solana.git","ssh_url":"git@github.com:garious/solana.git","clone_url":"https://github.com/garious/solana.git","svn_url":"https://github.com/garious/solana","homepage":"http://solana.com/","size":11375,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"f5a30615c12c511f8705e5f375b50e75e7fa6efc","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","private":false,"owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/solana-labs/solana","description":"Blockchain, Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-09-24T17:40:46Z","pushed_at":"2018-09-24T18:28:01Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":11223,"stargazers_count":341,"watchers_count":341,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":130,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1319"},"html":{"href":"https://github.com/solana-labs/solana/pull/1319"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/1319"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/1319/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1319/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1319/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/df134e08c1ac0a73a41897321422945ae54692b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rob-solana"}}