{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/179594854","pull_request_review_id":109870293,"id":179594854,"diff_hunk":"@@ -276,7 +281,38 @@ public ReadOnlySequence<T> Slice(long start)\n         }\n \n         /// <inheritdoc />\n-        public override string ToString() => string.Format(\"System.Buffers.ReadOnlySequence<{0}>[{1}]\", typeof(T).Name, Length);\n+        public override string ToString()\n+        {\n+            if (typeof(T) == typeof(char) )\n+            {\n+                ReadOnlySequence<T> localThis = this;\n+                ReadOnlySequence<char> charSequence = Unsafe.As<ReadOnlySequence<T>, ReadOnlySequence<char>>(ref localThis);\n+\n+                if (SequenceMarshal.TryGetString(charSequence, out var text, out var start, out var length))\n+                {\n+                    return text.Substring(start, length);\n+                }\n+\n+                if (Length < int.MaxValue)","path":"src/System.Memory/src/System/Buffers/ReadOnlySequence.cs","position":44,"original_position":44,"commit_id":"69e81b127053cd25a4b157e040758b521be8347f","original_commit_id":"69e81b127053cd25a4b157e040758b521be8347f","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"ellipsis it much much shorter? 32bit VS really won't be happy with a 4GB tooltip...","created_at":"2018-04-05T20:43:23Z","updated_at":"2018-04-05T20:43:23Z","html_url":"https://github.com/dotnet/corefx/pull/28857#discussion_r179594854","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/28857","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/179594854"},"html":{"href":"https://github.com/dotnet/corefx/pull/28857#discussion_r179594854"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28857"}},"in_reply_to_id":179592757},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/28857","id":179738149,"html_url":"https://github.com/dotnet/corefx/pull/28857","diff_url":"https://github.com/dotnet/corefx/pull/28857.diff","patch_url":"https://github.com/dotnet/corefx/pull/28857.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/28857","number":28857,"state":"open","locked":false,"title":"ReadOnlySequence.ToString() and debug view","user":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"body":"https://github.com/dotnet/corefx/issues/27434\r\n\r\n![image](https://user-images.githubusercontent.com/1697911/38380271-156085de-38b8-11e8-998c-b390dfec47ed.png)\r\n\r\nAlso cleanup duplicated code in sequence factory and add another variation for tests.","created_at":"2018-04-05T17:00:46Z","updated_at":"2018-04-05T20:43:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5c173a648fcd9960d0dccbcc24dd1e44fd6ecd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidfowl","id":95136,"avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/28857/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/28857/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/28857/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/69e81b127053cd25a4b157e040758b521be8347f","head":{"label":"pakrym:pakrym/ROS-tostring","ref":"pakrym/ROS-tostring","sha":"69e81b127053cd25a4b157e040758b521be8347f","user":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"repo":{"id":119602347,"name":"corefx","full_name":"pakrym/corefx","owner":{"login":"pakrym","id":1697911,"avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pakrym/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/pakrym/corefx","forks_url":"https://api.github.com/repos/pakrym/corefx/forks","keys_url":"https://api.github.com/repos/pakrym/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pakrym/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pakrym/corefx/teams","hooks_url":"https://api.github.com/repos/pakrym/corefx/hooks","issue_events_url":"https://api.github.com/repos/pakrym/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/pakrym/corefx/events","assignees_url":"https://api.github.com/repos/pakrym/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/pakrym/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/pakrym/corefx/tags","blobs_url":"https://api.github.com/repos/pakrym/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pakrym/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pakrym/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pakrym/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pakrym/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/pakrym/corefx/languages","stargazers_url":"https://api.github.com/repos/pakrym/corefx/stargazers","contributors_url":"https://api.github.com/repos/pakrym/corefx/contributors","subscribers_url":"https://api.github.com/repos/pakrym/corefx/subscribers","subscription_url":"https://api.github.com/repos/pakrym/corefx/subscription","commits_url":"https://api.github.com/repos/pakrym/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pakrym/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pakrym/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pakrym/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pakrym/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/pakrym/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pakrym/corefx/merges","archive_url":"https://api.github.com/repos/pakrym/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pakrym/corefx/downloads","issues_url":"https://api.github.com/repos/pakrym/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/pakrym/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/pakrym/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/pakrym/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pakrym/corefx/labels{/name}","releases_url":"https://api.github.com/repos/pakrym/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/pakrym/corefx/deployments","created_at":"2018-01-30T22:25:57Z","updated_at":"2018-04-04T22:46:39Z","pushed_at":"2018-04-05T19:56:39Z","git_url":"git://github.com/pakrym/corefx.git","ssh_url":"git@github.com:pakrym/corefx.git","clone_url":"https://github.com/pakrym/corefx.git","svn_url":"https://github.com/pakrym/corefx","homepage":"https://github.com/dotnet/core","size":177466,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ffb16981972bf88ba73e21f890b215fa98487f8b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-04-05T18:24:41Z","pushed_at":"2018-04-05T20:38:17Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":176660,"stargazers_count":13706,"watchers_count":13706,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3923,"mirror_url":null,"archived":false,"open_issues_count":2213,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3923,"open_issues":2213,"watchers":13706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28857"},"html":{"href":"https://github.com/dotnet/corefx/pull/28857"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/28857"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/28857/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28857/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/28857/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/69e81b127053cd25a4b157e040758b521be8347f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benaadams"}}