{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/teuthology/issues/1090","repository_url":"https://api.github.com/repos/ceph/teuthology","labels_url":"https://api.github.com/repos/ceph/teuthology/issues/1090/labels{/name}","comments_url":"https://api.github.com/repos/ceph/teuthology/issues/1090/comments","events_url":"https://api.github.com/repos/ceph/teuthology/issues/1090/events","html_url":"https://github.com/ceph/teuthology/pull/1090","id":240269178,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI4Njk3MTA1","number":1090,"title":"upgrade check: upgrade to same version is a noop","user":{"login":"smithfarm","id":3974844,"node_id":"MDQ6VXNlcjM5NzQ4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3974844?v=4","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-07-03T21:37:57Z","updated_at":"2018-07-24T04:39:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/teuthology/pulls/1090","html_url":"https://github.com/ceph/teuthology/pull/1090","diff_url":"https://github.com/ceph/teuthology/pull/1090.diff","patch_url":"https://github.com/ceph/teuthology/pull/1090.patch"},"body":"We actually had a test that was \"upgrading\" from one version to the very same\r\nversion. This commit adds a check for that case.\r\n\r\nSigned-off-by: Nathan Cutler <ncutler@suse.com>"},"comment":{"url":"https://api.github.com/repos/ceph/teuthology/issues/comments/407278727","html_url":"https://github.com/ceph/teuthology/pull/1090#issuecomment-407278727","issue_url":"https://api.github.com/repos/ceph/teuthology/issues/1090","id":407278727,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzI3ODcyNw==","user":{"login":"smithfarm","id":3974844,"node_id":"MDQ6VXNlcjM5NzQ4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3974844?v=4","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T04:39:02Z","updated_at":"2018-07-24T04:39:02Z","author_association":"CONTRIBUTOR","body":"@gregsfortytwo This fix is based on two hypotheses:\r\n\r\nHypothesis #1: The code in `upgrade_common` only runs when the `install.upgrade` task is specified in the test yaml. \r\n\r\nHypothesis #2: `install.upgrade` is currently used only to upgrade packages from the Ceph monolith.\r\n\r\nNow, if someone constructs test yaml that ends up instructing `install.upgrade` to either (a) downgrade Ceph packages or (b) keep them at the same version, then that would indicate the test is not doing what was intended.\r\n\r\nThe idea here is to help discover semantic issues in the upgrade tests - i.e. cases when `install.upgrade` was intended to upgrade Ceph, but in reality that's not happening.\r\n\r\nI already landed a patch that fails the test if `install.upgrade` ends up **downgrading**, but I would like (and maintain that it makes sense) to fail the test if it ends up installing the same version on top of the existing packages, as well.\r\n\r\nCan you think of a case when `install.upgrade` would be intentionally used to just reinstall the same version of the Ceph packages?"}}
{"actor":{"display_login":"smithfarm"}}