{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/230902035","pull_request_review_id":171747169,"id":230902035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkwMjAzNQ==","diff_hunk":"@@ -231,16 +233,25 @@ func (c *Reconciler) reconcileConfiguration(ctx context.Context, service *v1alph\n \t// TODO(#642): Remove this (needed to avoid continuous updates)\n \tdesiredConfig.Spec.Generation = config.Spec.Generation\n \n-\tif equality.Semantic.DeepEqual(desiredConfig.Spec, config.Spec) {\n-\t\t// No differences to reconcile.\n+\tdiff := false\n+\tif !equality.Semantic.DeepEqual(desiredConfig.Spec, config.Spec) {\n+\t\tdiff = true\n+\t\tlogger.Infof(\"Reconciling configuration spec diff (-desired, +observed): %v\", cmp.Diff(desiredConfig.Spec, config.Spec))\n+\t}\n+\tif !config.IsInheritedAnnotationsEqual(desiredConfig.GetObjectMeta()) {\n+\t\tdiff = true\n+\t\tlogger.Infof(\"Reconciling configuration inherited annotation diff (-desired, +observed): %v\", cmp.Diff(desiredConfig.Annotations, config.Annotations))\n+\t}\n+\tif diff == false {\n+\t\tlogger.Debugf(\"No configuration differences to reconcile.\")\n \t\treturn config, nil\n \t}\n-\tlogger.Infof(\"Reconciling configuration diff (-desired, +observed): %v\", cmp.Diff(desiredConfig.Spec, config.Spec))\n \n \t// Don't modify the informers copy\n \texisting := config.DeepCopy()\n \t// Preserve the rest of the object (e.g. ObjectMeta)\n \texisting.Spec = desiredConfig.Spec\n+\texisting.InheritAnnotations(desiredConfig.GetObjectMeta())","path":"pkg/reconciler/v1alpha1/service/service.go","position":67,"original_position":67,"commit_id":"5b40572a5a13b8a3879c103a205432157e0fc805","original_commit_id":"5b40572a5a13b8a3879c103a205432157e0fc805","user":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"body":"Summary of conversation with @mattmoor \r\n- We need to think more about how to do inheritance in general.  Table it for now.\r\n- We also need to think more about Namespace inheritance.\r\n- Set autoscaling annotations on the Configuration.Spec.RevisionTemplate so it stamps out a new Revision.\r\n\r\nThis unblocks the core functionality of this extension and we can come back to Service and Namespace inheritance.","created_at":"2018-11-05T20:35:20Z","updated_at":"2018-11-05T20:35:20Z","html_url":"https://github.com/knative/serving/pull/2369#discussion_r230902035","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/2369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/230902035"},"html":{"href":"https://github.com/knative/serving/pull/2369#discussion_r230902035"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/2369"}},"in_reply_to_id":229941542},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2369","id":227418871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDE4ODcx","html_url":"https://github.com/knative/serving/pull/2369","diff_url":"https://github.com/knative/serving/pull/2369.diff","patch_url":"https://github.com/knative/serving/pull/2369.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2369","number":2369,"state":"open","locked":false,"title":"Inherit autoscaling annotations","user":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\n\r\n  * Autoscaler class is inherited from Service to Configuration to Revision.\r\n  * Autoscaler class is reconciled from Service to Configuration. But not from Configuration to Revision (by design).\r\n\r\nSee https://github.com/knative/serving/pull/2355 for usage.\r\n\r\n**Release Note**\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-10-31T19:45:03Z","updated_at":"2018-11-05T20:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8952c25b78d6c2e09b592c2794a04814705880d1","assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},{"login":"mdemirhan","id":4033879,"node_id":"MDQ6VXNlcjQwMzM4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4033879?v=4","gravatar_id":"","url":"https://api.github.com/users/mdemirhan","html_url":"https://github.com/mdemirhan","followers_url":"https://api.github.com/users/mdemirhan/followers","following_url":"https://api.github.com/users/mdemirhan/following{/other_user}","gists_url":"https://api.github.com/users/mdemirhan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdemirhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdemirhan/subscriptions","organizations_url":"https://api.github.com/users/mdemirhan/orgs","repos_url":"https://api.github.com/users/mdemirhan/repos","events_url":"https://api.github.com/users/mdemirhan/events{/privacy}","received_events_url":"https://api.github.com/users/mdemirhan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":868661645,"node_id":"MDU6TGFiZWw4Njg2NjE2NDU=","url":"https://api.github.com/repos/knative/serving/labels/area/autoscale","name":"area/autoscale","color":"0e8a16","default":false},{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/knative/serving/milestones/14","html_url":"https://github.com/knative/serving/milestone/14","labels_url":"https://api.github.com/repos/knative/serving/milestones/14/labels","id":3725806,"node_id":"MDk6TWlsZXN0b25lMzcyNTgwNg==","number":14,"title":"Scaling: Pluggability and HPA","description":"RATIONALE: The value proposition of Knative is extensibility and pluggability.  That includes the ability to plug in different autoscaling implementations.  Right now the KPA is the only implementation supported.\r\n\r\nGOAL: The goal of this milestone is to put in place the extension points necessary to plug in other autoscaling implementation.  As a starting point, support for the vanilla Kubernetes HPA will be added so that Revisions can be autoscaled on CPU or memory.","creator":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2018-10-09T21:18:18Z","updated_at":"2018-10-31T19:45:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/knative/serving/pulls/2369/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2369/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2369/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/5b40572a5a13b8a3879c103a205432157e0fc805","head":{"label":"josephburnett:annotations","ref":"annotations","sha":"5b40572a5a13b8a3879c103a205432157e0fc805","user":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"repo":{"id":142226478,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyMjY0Nzg=","name":"knative-serving","full_name":"josephburnett/knative-serving","private":false,"owner":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josephburnett/knative-serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/josephburnett/knative-serving","forks_url":"https://api.github.com/repos/josephburnett/knative-serving/forks","keys_url":"https://api.github.com/repos/josephburnett/knative-serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephburnett/knative-serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephburnett/knative-serving/teams","hooks_url":"https://api.github.com/repos/josephburnett/knative-serving/hooks","issue_events_url":"https://api.github.com/repos/josephburnett/knative-serving/issues/events{/number}","events_url":"https://api.github.com/repos/josephburnett/knative-serving/events","assignees_url":"https://api.github.com/repos/josephburnett/knative-serving/assignees{/user}","branches_url":"https://api.github.com/repos/josephburnett/knative-serving/branches{/branch}","tags_url":"https://api.github.com/repos/josephburnett/knative-serving/tags","blobs_url":"https://api.github.com/repos/josephburnett/knative-serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephburnett/knative-serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephburnett/knative-serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephburnett/knative-serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephburnett/knative-serving/statuses/{sha}","languages_url":"https://api.github.com/repos/josephburnett/knative-serving/languages","stargazers_url":"https://api.github.com/repos/josephburnett/knative-serving/stargazers","contributors_url":"https://api.github.com/repos/josephburnett/knative-serving/contributors","subscribers_url":"https://api.github.com/repos/josephburnett/knative-serving/subscribers","subscription_url":"https://api.github.com/repos/josephburnett/knative-serving/subscription","commits_url":"https://api.github.com/repos/josephburnett/knative-serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephburnett/knative-serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephburnett/knative-serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephburnett/knative-serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephburnett/knative-serving/contents/{+path}","compare_url":"https://api.github.com/repos/josephburnett/knative-serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephburnett/knative-serving/merges","archive_url":"https://api.github.com/repos/josephburnett/knative-serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephburnett/knative-serving/downloads","issues_url":"https://api.github.com/repos/josephburnett/knative-serving/issues{/number}","pulls_url":"https://api.github.com/repos/josephburnett/knative-serving/pulls{/number}","milestones_url":"https://api.github.com/repos/josephburnett/knative-serving/milestones{/number}","notifications_url":"https://api.github.com/repos/josephburnett/knative-serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephburnett/knative-serving/labels{/name}","releases_url":"https://api.github.com/repos/josephburnett/knative-serving/releases{/id}","deployments_url":"https://api.github.com/repos/josephburnett/knative-serving/deployments","created_at":"2018-07-25T00:28:03Z","updated_at":"2018-11-02T17:59:02Z","pushed_at":"2018-11-05T12:23:15Z","git_url":"git://github.com/josephburnett/knative-serving.git","ssh_url":"git@github.com:josephburnett/knative-serving.git","clone_url":"https://github.com/josephburnett/knative-serving.git","svn_url":"https://github.com/josephburnett/knative-serving","homepage":"","size":23706,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"44ef00b827fb7658a7049f884789fd54d1a5a59b","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-11-05T19:53:44Z","pushed_at":"2018-11-05T20:29:13Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":23484,"stargazers_count":823,"watchers_count":823,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":322,"watchers":823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2369"},"html":{"href":"https://github.com/knative/serving/pull/2369"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2369"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2369/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2369/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2369/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/5b40572a5a13b8a3879c103a205432157e0fc805"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"josephburnett"}}