{"action":"created","comment":{"url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/comments/197064497","pull_request_review_id":130731406,"id":197064497,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzA2NDQ5Nw==","diff_hunk":"@@ -67,6 +73,21 @@ def iou(boxes1, boxes2, coords='centroids'):\n \n     return intersection / union\n \n+\n+if NUMBA_INSTALLED:\n+    @numba.jit(nopython=True)\n+    def iou_specialized(boxes1, boxes2):\n+        boxes2b = np.expand_dims(boxes2, axis=0)\n+\n+        intersection = np.maximum(0, np.minimum(boxes1[:,1], boxes2b[:,1]) - np.maximum(boxes1[:,0], boxes2b[:,0])) * np.maximum(0, np.minimum(boxes1[:,3], boxes2b[:,3]) - np.maximum(boxes1[:,2], boxes2b[:,2]))\n+        union = (boxes1[:,1] - boxes1[:,0]) * (boxes1[:,3] - boxes1[:,2]) + (boxes2b[:,1] - boxes2b[:,0]) * (boxes2b[:,3] - boxes2b[:,2]) - intersection\n+\n+        return intersection / union","path":"ssd_keras/ssd_box_encode_decode_utils.py","position":35,"original_position":35,"commit_id":"f5e9c5968fd59939ae18bbe48b5c27c3b308c894","original_commit_id":"f5e9c5968fd59939ae18bbe48b5c27c3b308c894","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"Here I didn't change anything compared to original `iou` except for removal of some unneeded checks (to allow `nopython=True`).","created_at":"2018-06-21T09:16:57Z","updated_at":"2018-06-21T09:20:10Z","html_url":"https://github.com/paris-saclay-cds/ssd_keras/pull/1#discussion_r197064497","pull_request_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/comments/197064497"},"html":{"href":"https://github.com/paris-saclay-cds/ssd_keras/pull/1#discussion_r197064497"},"pull_request":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1","id":196385032,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Mzg1MDMy","html_url":"https://github.com/paris-saclay-cds/ssd_keras/pull/1","diff_url":"https://github.com/paris-saclay-cds/ssd_keras/pull/1.diff","patch_url":"https://github.com/paris-saclay-cds/ssd_keras/pull/1.patch","issue_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/1","number":1,"state":"open","locked":false,"title":" Use numba to speed-up greedy non-maximum suppression ","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-21T09:13:22Z","updated_at":"2018-06-21T09:20:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b638b01d7ae224a4409a83f6410ac8dea6ddb3e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1/commits","review_comments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1/comments","review_comment_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/1/comments","statuses_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/statuses/f5e9c5968fd59939ae18bbe48b5c27c3b308c894","head":{"label":"paris-saclay-cds:decoding-numba","ref":"decoding-numba","sha":"f5e9c5968fd59939ae18bbe48b5c27c3b308c894","user":{"login":"paris-saclay-cds","id":7426290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjYyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7426290?v=4","gravatar_id":"","url":"https://api.github.com/users/paris-saclay-cds","html_url":"https://github.com/paris-saclay-cds","followers_url":"https://api.github.com/users/paris-saclay-cds/followers","following_url":"https://api.github.com/users/paris-saclay-cds/following{/other_user}","gists_url":"https://api.github.com/users/paris-saclay-cds/gists{/gist_id}","starred_url":"https://api.github.com/users/paris-saclay-cds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paris-saclay-cds/subscriptions","organizations_url":"https://api.github.com/users/paris-saclay-cds/orgs","repos_url":"https://api.github.com/users/paris-saclay-cds/repos","events_url":"https://api.github.com/users/paris-saclay-cds/events{/privacy}","received_events_url":"https://api.github.com/users/paris-saclay-cds/received_events","type":"Organization","site_admin":false},"repo":{"id":106337245,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMzcyNDU=","name":"ssd_keras","full_name":"paris-saclay-cds/ssd_keras","owner":{"login":"paris-saclay-cds","id":7426290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjYyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7426290?v=4","gravatar_id":"","url":"https://api.github.com/users/paris-saclay-cds","html_url":"https://github.com/paris-saclay-cds","followers_url":"https://api.github.com/users/paris-saclay-cds/followers","following_url":"https://api.github.com/users/paris-saclay-cds/following{/other_user}","gists_url":"https://api.github.com/users/paris-saclay-cds/gists{/gist_id}","starred_url":"https://api.github.com/users/paris-saclay-cds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paris-saclay-cds/subscriptions","organizations_url":"https://api.github.com/users/paris-saclay-cds/orgs","repos_url":"https://api.github.com/users/paris-saclay-cds/repos","events_url":"https://api.github.com/users/paris-saclay-cds/events{/privacy}","received_events_url":"https://api.github.com/users/paris-saclay-cds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paris-saclay-cds/ssd_keras","description":"A Keras implementation of SSD","fork":true,"url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras","forks_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/forks","keys_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/teams","hooks_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/hooks","issue_events_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/events{/number}","events_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/events","assignees_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/assignees{/user}","branches_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/branches{/branch}","tags_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/tags","blobs_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/statuses/{sha}","languages_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/languages","stargazers_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/stargazers","contributors_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/contributors","subscribers_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/subscribers","subscription_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/subscription","commits_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/contents/{+path}","compare_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/merges","archive_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/downloads","issues_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues{/number}","pulls_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls{/number}","milestones_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/milestones{/number}","notifications_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/labels{/name}","releases_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/releases{/id}","deployments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/deployments","created_at":"2017-10-09T21:28:20Z","updated_at":"2017-10-09T21:28:22Z","pushed_at":"2018-06-21T09:13:22Z","git_url":"git://github.com/paris-saclay-cds/ssd_keras.git","ssh_url":"git@github.com:paris-saclay-cds/ssd_keras.git","clone_url":"https://github.com/paris-saclay-cds/ssd_keras.git","svn_url":"https://github.com/paris-saclay-cds/ssd_keras","homepage":"","size":7435,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"paris-saclay-cds:master","ref":"master","sha":"e81c3ce13845284b10c9652fe8dddace90744bd2","user":{"login":"paris-saclay-cds","id":7426290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjYyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7426290?v=4","gravatar_id":"","url":"https://api.github.com/users/paris-saclay-cds","html_url":"https://github.com/paris-saclay-cds","followers_url":"https://api.github.com/users/paris-saclay-cds/followers","following_url":"https://api.github.com/users/paris-saclay-cds/following{/other_user}","gists_url":"https://api.github.com/users/paris-saclay-cds/gists{/gist_id}","starred_url":"https://api.github.com/users/paris-saclay-cds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paris-saclay-cds/subscriptions","organizations_url":"https://api.github.com/users/paris-saclay-cds/orgs","repos_url":"https://api.github.com/users/paris-saclay-cds/repos","events_url":"https://api.github.com/users/paris-saclay-cds/events{/privacy}","received_events_url":"https://api.github.com/users/paris-saclay-cds/received_events","type":"Organization","site_admin":false},"repo":{"id":106337245,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMzcyNDU=","name":"ssd_keras","full_name":"paris-saclay-cds/ssd_keras","owner":{"login":"paris-saclay-cds","id":7426290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MjYyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7426290?v=4","gravatar_id":"","url":"https://api.github.com/users/paris-saclay-cds","html_url":"https://github.com/paris-saclay-cds","followers_url":"https://api.github.com/users/paris-saclay-cds/followers","following_url":"https://api.github.com/users/paris-saclay-cds/following{/other_user}","gists_url":"https://api.github.com/users/paris-saclay-cds/gists{/gist_id}","starred_url":"https://api.github.com/users/paris-saclay-cds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paris-saclay-cds/subscriptions","organizations_url":"https://api.github.com/users/paris-saclay-cds/orgs","repos_url":"https://api.github.com/users/paris-saclay-cds/repos","events_url":"https://api.github.com/users/paris-saclay-cds/events{/privacy}","received_events_url":"https://api.github.com/users/paris-saclay-cds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paris-saclay-cds/ssd_keras","description":"A Keras implementation of SSD","fork":true,"url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras","forks_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/forks","keys_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/teams","hooks_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/hooks","issue_events_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/events{/number}","events_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/events","assignees_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/assignees{/user}","branches_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/branches{/branch}","tags_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/tags","blobs_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/statuses/{sha}","languages_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/languages","stargazers_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/stargazers","contributors_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/contributors","subscribers_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/subscribers","subscription_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/subscription","commits_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/contents/{+path}","compare_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/merges","archive_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/downloads","issues_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues{/number}","pulls_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls{/number}","milestones_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/milestones{/number}","notifications_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/labels{/name}","releases_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/releases{/id}","deployments_url":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/deployments","created_at":"2017-10-09T21:28:20Z","updated_at":"2017-10-09T21:28:22Z","pushed_at":"2018-06-21T09:13:22Z","git_url":"git://github.com/paris-saclay-cds/ssd_keras.git","ssh_url":"git@github.com:paris-saclay-cds/ssd_keras.git","clone_url":"https://github.com/paris-saclay-cds/ssd_keras.git","svn_url":"https://github.com/paris-saclay-cds/ssd_keras","homepage":"","size":7435,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1"},"html":{"href":"https://github.com/paris-saclay-cds/ssd_keras/pull/1"},"issue":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/1"},"comments":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/paris-saclay-cds/ssd_keras/statuses/f5e9c5968fd59939ae18bbe48b5c27c3b308c894"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jorisvandenbossche"}}