{"action":"created","issue":{"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/405","repository_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/405/labels{/name}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/405/comments","events_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/405/events","html_url":"https://github.com/smartdevicelink/sdl_evolution/issues/405","id":297187851,"number":405,"title":"[In Review] SDL 0141 - Supporting simultaneous multiple transports","user":{"login":"theresalech","id":22600496,"avatar_url":"https://avatars2.githubusercontent.com/u/22600496?v=4","gravatar_id":"","url":"https://api.github.com/users/theresalech","html_url":"https://github.com/theresalech","followers_url":"https://api.github.com/users/theresalech/followers","following_url":"https://api.github.com/users/theresalech/following{/other_user}","gists_url":"https://api.github.com/users/theresalech/gists{/gist_id}","starred_url":"https://api.github.com/users/theresalech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theresalech/subscriptions","organizations_url":"https://api.github.com/users/theresalech/orgs","repos_url":"https://api.github.com/users/theresalech/repos","events_url":"https://api.github.com/users/theresalech/events{/privacy}","received_events_url":"https://api.github.com/users/theresalech/received_events","type":"User","site_admin":false},"labels":[{"id":418843381,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/android","name":"android","color":"4ea57f","default":false},{"id":418843516,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/core","name":"core","color":"ef5e69","default":false},{"id":422605984,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/in%20review","name":"in review","color":"39609a","default":false},{"id":418843501,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/ios","name":"ios","color":"39609a","default":false},{"id":418843545,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/protocol","name":"protocol","color":"fb9050","default":false},{"id":418843609,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels/rpc","name":"rpc","color":"c691c5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-02-14T17:50:43Z","updated_at":"2018-03-12T23:59:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hello SDL community,\r\n\r\nThe review of the revised proposal \"SDL 0141 - Supporting simultaneous multiple transports\" begins now and runs through March 13, 2018. The original review of \"Supporting simultaneous multiple transports\" occurred February 13 through February 20, 2018. The proposal is available here:\r\n\r\nhttps://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0141-multiple-transports.md\r\n\r\n**Please be aware that this proposal is contingent upon others, as noted within the proposal file.**\r\n\r\nReviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:\r\n\r\nhttps://github.com/smartdevicelink/sdl_evolution/issues/405\r\n\r\nWhat goes into a review?\r\n\r\nThe goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:\r\n\r\n* Is the problem being addressed significant enough to warrant a change to SDL?\r\n* Does this proposal fit well with the feel and direction of SDL?\r\n* If you have used competitors with a similar feature, how do you feel that this proposal compares to those?\r\n* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?\r\nPlease state explicitly whether you believe that the proposal should be accepted into SDL.\r\n\r\nMore information about the SDL evolution process is available at\r\n\r\nhttps://github.com/smartdevicelink/sdl_evolution/blob/master/process.md\r\n\r\nThank you,\r\nTheresa Lech\r\n\r\nProgram Manager - Livio\r\ntheresa@livio.io"},"comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/comments/372501557","html_url":"https://github.com/smartdevicelink/sdl_evolution/issues/405#issuecomment-372501557","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/405","id":372501557,"user":{"login":"shoamano83","id":26382896,"avatar_url":"https://avatars1.githubusercontent.com/u/26382896?v=4","gravatar_id":"","url":"https://api.github.com/users/shoamano83","html_url":"https://github.com/shoamano83","followers_url":"https://api.github.com/users/shoamano83/followers","following_url":"https://api.github.com/users/shoamano83/following{/other_user}","gists_url":"https://api.github.com/users/shoamano83/gists{/gist_id}","starred_url":"https://api.github.com/users/shoamano83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoamano83/subscriptions","organizations_url":"https://api.github.com/users/shoamano83/orgs","repos_url":"https://api.github.com/users/shoamano83/repos","events_url":"https://api.github.com/users/shoamano83/events{/privacy}","received_events_url":"https://api.github.com/users/shoamano83/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T23:59:41Z","updated_at":"2018-03-12T23:59:41Z","author_association":"CONTRIBUTOR","body":"Hi @joeygrover, @joeljfischer, thanks for your comments. First, let me reply to the comments regarding Start Service procedure on Secondary Transport.\r\n\r\n> I don't agree with this. It seems like a hack rather than a proper solution. I believe it is fine to create a new control message to handle this situation if needed, but Core should be able to handle a StartService message of any service as long as the session id matches the previously established session ID of the RPC service.\r\n\r\nYes, even if we don't run Start Service / Start Service ACK sequence of RPC service on Secondary Transport, Core can handle Start Service message of any services using the previous Session ID.\r\n\r\nThe reason that I would like to have Start Service / Start Service ACK sequence of RPC service on Secondary Transport is that Core has to notify HMI of Secondary Transport's connection through `BC.UpdateAppList`. The event should be notified before a service (like video service) is started on Secondary Transport. Unfortunately, Core cannot recognize which transport is used by which app until a service is started on that transport. That is why I would like to start a service after Secondary Transport is established, and I thought RPC service is suitable.\r\n\r\nWe may be able to add a control frame for the event, but from Core's implementation point of view handling the control frame will likely to be similar to handling Start Service frame. That didn't sound like a good idea.\r\n\r\n> For what reason can this not be a start service of a transport the proxy actually wishes to start (using the same session id)? If that will not work, I would recommend a different protocol message.\r\n\r\nCore's implementation isolates transports and services. They are associated when a service is started on a transport (using Start Service / Start Service ACK). So, my understanding is that Core requires a service is started on the Secondary Transport to recognize that an app has created a Secondary Transport.\r\n\r\nSorry I didn't get your comment completely, but if we just run Start Service / Start Service ACK again on the Primary Transport, Core will not recognize Secondary Transport.\r\n\r\nI agree that the idea sounds odd since we are not actually running a RPC service on Secondary Transport. An alternative can be to add a \"Null\" or \"Transport Management\" service in the protocol spec which actually does nothing. Proxy starts the service once Secondary Transport is established."}}
{"actor":{"display_login":"shoamano83"}}