{"action":"created","comment":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/216605874","pull_request_review_id":154120298,"id":216605874,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjYwNTg3NA==","diff_hunk":"@@ -643,11 +647,25 @@ put_T_values <- function(yr, nc_var, out, lat, lon, begins, ends, ...){\n   \n   \n   # ----- define ncdf dimensions\n-  \n+  # setup output time and time bounds\n+  sub_date_range <- seq(begins, by = \"day\", length.out = length(lubridate::yday(begins):ends))\n+  sub_jdates <- lubridate::yday(lubridate::floor_date(seq(sub_date_range[1], sub_date_range[length(sub_date_range)],length.out= length(out[[1]]))))\n+  iter_per_day <- length(sub_jdates[sub_jdates==lubridate::yday(sub_date_range[2])])  # look at day 2 to determine iterations per day (i.e. model timestep)\n+  #iter_per_day <- length(out[[1]])/ends    ### does not work for part of a year!!\n+  rm(sub_jdates)\n+  step <- seq(0, 0.99, 1/iter_per_day)","path":"models/ed/R/model2netcdf.ED2.R","position":67,"original_position":67,"commit_id":"2f7b319a58b802b7ac648c5c430d4e1af6416ec2","original_commit_id":"2f7b319a58b802b7ac648c5c430d4e1af6416ec2","user":{"login":"mdietze","id":3081466,"node_id":"MDQ6VXNlcjMwODE0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3081466?v=4","gravatar_id":"","url":"https://api.github.com/users/mdietze","html_url":"https://github.com/mdietze","followers_url":"https://api.github.com/users/mdietze/followers","following_url":"https://api.github.com/users/mdietze/following{/other_user}","gists_url":"https://api.github.com/users/mdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietze/subscriptions","organizations_url":"https://api.github.com/users/mdietze/orgs","repos_url":"https://api.github.com/users/mdietze/repos","events_url":"https://api.github.com/users/mdietze/events{/privacy}","received_events_url":"https://api.github.com/users/mdietze/received_events","type":"User","site_admin":false},"body":"I don't understand the roll of 0.99 in this sequence","created_at":"2018-09-11T09:36:55Z","updated_at":"2018-09-11T09:48:39Z","html_url":"https://github.com/PecanProject/pecan/pull/2098#discussion_r216605874","pull_request_url":"https://api.github.com/repos/PecanProject/pecan/pulls/2098","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/216605874"},"html":{"href":"https://github.com/PecanProject/pecan/pull/2098#discussion_r216605874"},"pull_request":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/2098"}}},"pull_request":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/2098","id":214442869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDQyODY5","html_url":"https://github.com/PecanProject/pecan/pull/2098","diff_url":"https://github.com/PecanProject/pecan/pull/2098.diff","patch_url":"https://github.com/PecanProject/pecan/pull/2098.patch","issue_url":"https://api.github.com/repos/PecanProject/pecan/issues/2098","number":2098,"state":"open","locked":false,"title":"ED2 time fix","user":{"login":"serbinsh","id":3067369,"node_id":"MDQ6VXNlcjMwNjczNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/3067369?v=4","gravatar_id":"","url":"https://api.github.com/users/serbinsh","html_url":"https://github.com/serbinsh","followers_url":"https://api.github.com/users/serbinsh/followers","following_url":"https://api.github.com/users/serbinsh/following{/other_user}","gists_url":"https://api.github.com/users/serbinsh/gists{/gist_id}","starred_url":"https://api.github.com/users/serbinsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbinsh/subscriptions","organizations_url":"https://api.github.com/users/serbinsh/orgs","repos_url":"https://api.github.com/users/serbinsh/repos","events_url":"https://api.github.com/users/serbinsh/events{/privacy}","received_events_url":"https://api.github.com/users/serbinsh/received_events","type":"User","site_admin":false},"body":"\r\n## Description\r\nUpdated model2netCDF.ED2 to provide output time variable in 0 index format (i.e. 0 to x) for both -T- and -E- outputs.  Also added time_bounds and dtime_bounds variables which are the fast time and monthly time output bounds, respectively. \r\n\r\nAddresses #2094 \r\n\r\n## Motivation and Context\r\nAddresses #2094 \r\n\r\n## Review Time Estimate\r\n<!---When do you want your code reviewed by?-->\r\n- [ ] Immediately\r\n- [ ] Within one week\r\n- [ X] When possible\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ X] Bug fix (non-breaking change which fixes an issue) <!-- please add issue number -->\r\n- [ X] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change requires a change to the documentation.\r\n- [X ] I have updated the CHANGELOG.md.\r\n- [ ] I have updated the documentation accordingly.\r\n- [X ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n<!--this template is from https://www.talater.com/open-source-templates/#/page/99--> \r\n","created_at":"2018-09-10T21:00:58Z","updated_at":"2018-09-11T09:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f934e3265f93a6bf52aece4dad34798536db81a8","assignee":{"login":"serbinsh","id":3067369,"node_id":"MDQ6VXNlcjMwNjczNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/3067369?v=4","gravatar_id":"","url":"https://api.github.com/users/serbinsh","html_url":"https://github.com/serbinsh","followers_url":"https://api.github.com/users/serbinsh/followers","following_url":"https://api.github.com/users/serbinsh/following{/other_user}","gists_url":"https://api.github.com/users/serbinsh/gists{/gist_id}","starred_url":"https://api.github.com/users/serbinsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbinsh/subscriptions","organizations_url":"https://api.github.com/users/serbinsh/orgs","repos_url":"https://api.github.com/users/serbinsh/repos","events_url":"https://api.github.com/users/serbinsh/events{/privacy}","received_events_url":"https://api.github.com/users/serbinsh/received_events","type":"User","site_admin":false},"assignees":[{"login":"serbinsh","id":3067369,"node_id":"MDQ6VXNlcjMwNjczNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/3067369?v=4","gravatar_id":"","url":"https://api.github.com/users/serbinsh","html_url":"https://github.com/serbinsh","followers_url":"https://api.github.com/users/serbinsh/followers","following_url":"https://api.github.com/users/serbinsh/following{/other_user}","gists_url":"https://api.github.com/users/serbinsh/gists{/gist_id}","starred_url":"https://api.github.com/users/serbinsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbinsh/subscriptions","organizations_url":"https://api.github.com/users/serbinsh/orgs","repos_url":"https://api.github.com/users/serbinsh/repos","events_url":"https://api.github.com/users/serbinsh/events{/privacy}","received_events_url":"https://api.github.com/users/serbinsh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"istfer","id":13728388,"node_id":"MDQ6VXNlcjEzNzI4Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/13728388?v=4","gravatar_id":"","url":"https://api.github.com/users/istfer","html_url":"https://github.com/istfer","followers_url":"https://api.github.com/users/istfer/followers","following_url":"https://api.github.com/users/istfer/following{/other_user}","gists_url":"https://api.github.com/users/istfer/gists{/gist_id}","starred_url":"https://api.github.com/users/istfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istfer/subscriptions","organizations_url":"https://api.github.com/users/istfer/orgs","repos_url":"https://api.github.com/users/istfer/repos","events_url":"https://api.github.com/users/istfer/events{/privacy}","received_events_url":"https://api.github.com/users/istfer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":245005133,"node_id":"MDU6TGFiZWwyNDUwMDUxMzM=","url":"https://api.github.com/repos/PecanProject/pecan/labels/Priority:%2002%20-%20Normal","name":"Priority: 02 - Normal","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PecanProject/pecan/pulls/2098/commits","review_comments_url":"https://api.github.com/repos/PecanProject/pecan/pulls/2098/comments","review_comment_url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PecanProject/pecan/issues/2098/comments","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/2f7b319a58b802b7ac648c5c430d4e1af6416ec2","head":{"label":"serbinsh:ed2_time_fix","ref":"ed2_time_fix","sha":"2f7b319a58b802b7ac648c5c430d4e1af6416ec2","user":{"login":"serbinsh","id":3067369,"node_id":"MDQ6VXNlcjMwNjczNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/3067369?v=4","gravatar_id":"","url":"https://api.github.com/users/serbinsh","html_url":"https://github.com/serbinsh","followers_url":"https://api.github.com/users/serbinsh/followers","following_url":"https://api.github.com/users/serbinsh/following{/other_user}","gists_url":"https://api.github.com/users/serbinsh/gists{/gist_id}","starred_url":"https://api.github.com/users/serbinsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbinsh/subscriptions","organizations_url":"https://api.github.com/users/serbinsh/orgs","repos_url":"https://api.github.com/users/serbinsh/repos","events_url":"https://api.github.com/users/serbinsh/events{/privacy}","received_events_url":"https://api.github.com/users/serbinsh/received_events","type":"User","site_admin":false},"repo":{"id":19829867,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgyOTg2Nw==","name":"pecan","full_name":"serbinsh/pecan","owner":{"login":"serbinsh","id":3067369,"node_id":"MDQ6VXNlcjMwNjczNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/3067369?v=4","gravatar_id":"","url":"https://api.github.com/users/serbinsh","html_url":"https://github.com/serbinsh","followers_url":"https://api.github.com/users/serbinsh/followers","following_url":"https://api.github.com/users/serbinsh/following{/other_user}","gists_url":"https://api.github.com/users/serbinsh/gists{/gist_id}","starred_url":"https://api.github.com/users/serbinsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serbinsh/subscriptions","organizations_url":"https://api.github.com/users/serbinsh/orgs","repos_url":"https://api.github.com/users/serbinsh/repos","events_url":"https://api.github.com/users/serbinsh/events{/privacy}","received_events_url":"https://api.github.com/users/serbinsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serbinsh/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":true,"url":"https://api.github.com/repos/serbinsh/pecan","forks_url":"https://api.github.com/repos/serbinsh/pecan/forks","keys_url":"https://api.github.com/repos/serbinsh/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serbinsh/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serbinsh/pecan/teams","hooks_url":"https://api.github.com/repos/serbinsh/pecan/hooks","issue_events_url":"https://api.github.com/repos/serbinsh/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/serbinsh/pecan/events","assignees_url":"https://api.github.com/repos/serbinsh/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/serbinsh/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/serbinsh/pecan/tags","blobs_url":"https://api.github.com/repos/serbinsh/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serbinsh/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serbinsh/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/serbinsh/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serbinsh/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/serbinsh/pecan/languages","stargazers_url":"https://api.github.com/repos/serbinsh/pecan/stargazers","contributors_url":"https://api.github.com/repos/serbinsh/pecan/contributors","subscribers_url":"https://api.github.com/repos/serbinsh/pecan/subscribers","subscription_url":"https://api.github.com/repos/serbinsh/pecan/subscription","commits_url":"https://api.github.com/repos/serbinsh/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/serbinsh/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/serbinsh/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/serbinsh/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/serbinsh/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/serbinsh/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serbinsh/pecan/merges","archive_url":"https://api.github.com/repos/serbinsh/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serbinsh/pecan/downloads","issues_url":"https://api.github.com/repos/serbinsh/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/serbinsh/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/serbinsh/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/serbinsh/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serbinsh/pecan/labels{/name}","releases_url":"https://api.github.com/repos/serbinsh/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/serbinsh/pecan/deployments","created_at":"2014-05-15T18:07:25Z","updated_at":"2018-09-05T15:30:03Z","pushed_at":"2018-09-10T21:01:59Z","git_url":"git://github.com/serbinsh/pecan.git","ssh_url":"git@github.com:serbinsh/pecan.git","clone_url":"https://github.com/serbinsh/pecan.git","svn_url":"https://github.com/serbinsh/pecan","homepage":"www.pecanproject.org","size":271211,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PecanProject:develop","ref":"develop","sha":"8694adc7bc2c7f32ace9d7fc5336fe7873cfc10d","user":{"login":"PecanProject","id":2879854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2879854?v=4","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6857384,"node_id":"MDEwOlJlcG9zaXRvcnk2ODU3Mzg0","name":"pecan","full_name":"PecanProject/pecan","owner":{"login":"PecanProject","id":2879854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2879854?v=4","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":false,"url":"https://api.github.com/repos/PecanProject/pecan","forks_url":"https://api.github.com/repos/PecanProject/pecan/forks","keys_url":"https://api.github.com/repos/PecanProject/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/pecan/teams","hooks_url":"https://api.github.com/repos/PecanProject/pecan/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/pecan/events","assignees_url":"https://api.github.com/repos/PecanProject/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/pecan/tags","blobs_url":"https://api.github.com/repos/PecanProject/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/pecan/languages","stargazers_url":"https://api.github.com/repos/PecanProject/pecan/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/pecan/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/pecan/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/pecan/subscription","commits_url":"https://api.github.com/repos/PecanProject/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/PecanProject/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/pecan/merges","archive_url":"https://api.github.com/repos/PecanProject/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/pecan/downloads","issues_url":"https://api.github.com/repos/PecanProject/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/pecan/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/PecanProject/pecan/deployments","created_at":"2012-11-25T23:48:26Z","updated_at":"2018-09-05T09:31:41Z","pushed_at":"2018-09-10T21:02:01Z","git_url":"git://github.com/PecanProject/pecan.git","ssh_url":"git@github.com:PecanProject/pecan.git","clone_url":"https://github.com/PecanProject/pecan.git","svn_url":"https://github.com/PecanProject/pecan","homepage":"www.pecanproject.org","size":271619,"stargazers_count":77,"watchers_count":77,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":365,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":114,"open_issues":365,"watchers":77,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/2098"},"html":{"href":"https://github.com/PecanProject/pecan/pull/2098"},"issue":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/2098"},"comments":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/2098/comments"},"review_comments":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/2098/comments"},"review_comment":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/2098/commits"},"statuses":{"href":"https://api.github.com/repos/PecanProject/pecan/statuses/2f7b319a58b802b7ac648c5c430d4e1af6416ec2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mdietze"}}