{"action":"created","comment":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/235932467","pull_request_review_id":177915817,"id":235932467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkzMjQ2Nw==","diff_hunk":"@@ -0,0 +1,525 @@\n+pragma solidity ^0.4.24;\n+\n+import \"openzeppelin-solidity/contracts/ownership/Ownable.sol\";\n+import \"openzeppelin-solidity/contracts/math/SafeMath.sol\";\n+import \"openzeppelin-solidity/contracts/token/ERC20/ERC20.sol\";\n+import \"openzeppelin-solidity/contracts/token/ERC20/SafeERC20.sol\";\n+import \"./IWallet.sol\";\n+\n+/**\n+ * @title Wallet for core vesting escrow functionality\n+ */\n+contract VestingEscrowWallet is IWallet {\n+    using SafeMath for uint256;\n+    using SafeERC20 for ERC20;\n+\n+    bytes32 public constant ADMIN = \"ADMIN\";\n+\n+    struct Schedule {\n+        uint256 numberOfTokens;\n+        uint256 lockedTokens;\n+        uint256 duration;\n+        uint256 frequency;\n+        uint256 startTime;\n+        uint256 nextTime;\n+        State state;\n+    }\n+\n+    struct Data {\n+        uint256 index;\n+        Schedule[] schedules;\n+        uint256 availableTokens;\n+        uint256 claimedTokens;\n+    }","path":"contracts/modules/Wallet/VestingEscrowWallet.sol","position":24,"original_position":33,"commit_id":"210fbb92bd6446c024cf4178115af5b3f2ab2f67","original_commit_id":"b26f12a652205bd714f1bd109976b74907dddad6","user":{"login":"kostind","id":10598098,"node_id":"MDQ6VXNlcjEwNTk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/10598098?v=4","gravatar_id":"","url":"https://api.github.com/users/kostind","html_url":"https://github.com/kostind","followers_url":"https://api.github.com/users/kostind/followers","following_url":"https://api.github.com/users/kostind/following{/other_user}","gists_url":"https://api.github.com/users/kostind/gists{/gist_id}","starred_url":"https://api.github.com/users/kostind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostind/subscriptions","organizations_url":"https://api.github.com/users/kostind/orgs","repos_url":"https://api.github.com/users/kostind/repos","events_url":"https://api.github.com/users/kostind/events{/privacy}","received_events_url":"https://api.github.com/users/kostind/received_events","type":"User","site_admin":false},"body":"All changes have been made.\r\nOne difference: we need 3 variables with token numbers instead of 2.\r\n    struct Schedule {\r\n        uint256 numberOfTokens;\r\n        uint256 releasedTokens;\r\n        uint256 availableTokens;\r\n        uint256 duration;\r\n        uint256 frequency;\r\n        uint256 startTime;\r\n    }\r\nnumberOfTokens - number of tokens in creation time\r\nreleasedTokens - already released amount of tokens by schedule\r\navailableTokens - available for withdrawing tokens\r\n","created_at":"2018-11-23T12:53:32Z","updated_at":"2018-11-23T12:53:33Z","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/422#discussion_r235932467","pull_request_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/235932467"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/422#discussion_r235932467"},"pull_request":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422"}},"in_reply_to_id":235369271},"pull_request":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422","id":232305588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzA1NTg4","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/422","diff_url":"https://github.com/PolymathNetwork/polymath-core/pull/422.diff","patch_url":"https://github.com/PolymathNetwork/polymath-core/pull/422.patch","issue_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/422","number":422,"state":"open","locked":false,"title":"Vesting escrow wallet","user":{"login":"kostind","id":10598098,"node_id":"MDQ6VXNlcjEwNTk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/10598098?v=4","gravatar_id":"","url":"https://api.github.com/users/kostind","html_url":"https://github.com/kostind","followers_url":"https://api.github.com/users/kostind/followers","following_url":"https://api.github.com/users/kostind/following{/other_user}","gists_url":"https://api.github.com/users/kostind/gists{/gist_id}","starred_url":"https://api.github.com/users/kostind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostind/subscriptions","organizations_url":"https://api.github.com/users/kostind/orgs","repos_url":"https://api.github.com/users/kostind/repos","events_url":"https://api.github.com/users/kostind/events{/privacy}","received_events_url":"https://api.github.com/users/kostind/received_events","type":"User","site_admin":false},"body":"### Please check if the PR fulfills these requirements\r\n- [ ] The commit message follows our Submission guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n### What kind of change does this PR introduce? \r\nAdded VestingEscrowWallet module.\r\n\r\n\r\n### What is the current behavior? \r\n(You can also link to an open issue here)\r\n\r\n\r\n### What is the new behavior?\r\n(Define and describe any new functionality. Clarify if this is a feature change)\r\n\r\n\r\n### Does this PR introduce a breaking change?\r\nNo\r\n\r\n\r\n\r\n### Any Other information:\r\nShouldn't be merged before all tests will be fixed","created_at":"2018-11-20T12:50:19Z","updated_at":"2018-11-23T12:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ae84b822e524d2b805acec2b9b64855c5fdc8c0","assignee":{"login":"satyamakgec","id":14581509,"node_id":"MDQ6VXNlcjE0NTgxNTA5","avatar_url":"https://avatars1.githubusercontent.com/u/14581509?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamakgec","html_url":"https://github.com/satyamakgec","followers_url":"https://api.github.com/users/satyamakgec/followers","following_url":"https://api.github.com/users/satyamakgec/following{/other_user}","gists_url":"https://api.github.com/users/satyamakgec/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamakgec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamakgec/subscriptions","organizations_url":"https://api.github.com/users/satyamakgec/orgs","repos_url":"https://api.github.com/users/satyamakgec/repos","events_url":"https://api.github.com/users/satyamakgec/events{/privacy}","received_events_url":"https://api.github.com/users/satyamakgec/received_events","type":"User","site_admin":false},"assignees":[{"login":"satyamakgec","id":14581509,"node_id":"MDQ6VXNlcjE0NTgxNTA5","avatar_url":"https://avatars1.githubusercontent.com/u/14581509?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamakgec","html_url":"https://github.com/satyamakgec","followers_url":"https://api.github.com/users/satyamakgec/followers","following_url":"https://api.github.com/users/satyamakgec/following{/other_user}","gists_url":"https://api.github.com/users/satyamakgec/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamakgec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamakgec/subscriptions","organizations_url":"https://api.github.com/users/satyamakgec/orgs","repos_url":"https://api.github.com/users/satyamakgec/repos","events_url":"https://api.github.com/users/satyamakgec/events{/privacy}","received_events_url":"https://api.github.com/users/satyamakgec/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422/commits","review_comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422/comments","review_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/422/comments","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/210fbb92bd6446c024cf4178115af5b3f2ab2f67","head":{"label":"PolymathNetwork:Vesting-Escrow-Wallet","ref":"Vesting-Escrow-Wallet","sha":"210fbb92bd6446c024cf4178115af5b3f2ab2f67","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-11-22T21:32:36Z","pushed_at":"2018-11-23T12:41:37Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":7152,"stargazers_count":171,"watchers_count":171,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":66,"open_issues":30,"watchers":171,"default_branch":"master"}},"base":{"label":"PolymathNetwork:dev-2.1.0","ref":"dev-2.1.0","sha":"eb8787c889b0f53b1f8bfde417ea86004aadf83b","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-11-22T21:32:36Z","pushed_at":"2018-11-23T12:41:37Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":7152,"stargazers_count":171,"watchers_count":171,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":66,"open_issues":30,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/422"},"issue":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/422"},"comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/210fbb92bd6446c024cf4178115af5b3f2ab2f67"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kostind"}}