{"action":"closed","number":24381,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381","id":202701661,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzAxNjYx","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24381","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24381.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24381.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24381","number":24381,"state":"closed","locked":false,"title":"Rescaled skill dependent ranged dispersion","user":{"login":"Firestorm01X2","id":17512620,"node_id":"MDQ6VXNlcjE3NTEyNjIw","avatar_url":"https://avatars3.githubusercontent.com/u/17512620?v=4","gravatar_id":"","url":"https://api.github.com/users/Firestorm01X2","html_url":"https://github.com/Firestorm01X2","followers_url":"https://api.github.com/users/Firestorm01X2/followers","following_url":"https://api.github.com/users/Firestorm01X2/following{/other_user}","gists_url":"https://api.github.com/users/Firestorm01X2/gists{/gist_id}","starred_url":"https://api.github.com/users/Firestorm01X2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firestorm01X2/subscriptions","organizations_url":"https://api.github.com/users/Firestorm01X2/orgs","repos_url":"https://api.github.com/users/Firestorm01X2/repos","events_url":"https://api.github.com/users/Firestorm01X2/events{/privacy}","received_events_url":"https://api.github.com/users/Firestorm01X2/received_events","type":"User","site_admin":false},"body":"Rescaled ranged balance using new External options. Character with zero skills now get X6 weapon dispersion instead of X5.\r\nChanged 1 unit test.\r\n\r\nAlso it should give better scaling of accuracy with skill.\r\n# Range table:\r\nCharacters definition: https://github.com/CleverRaven/Cataclysm-DDA/issues/21244#issuecomment-310013403\r\n\r\nCharacter | >50% good | <10% good\r\n-- | -- | --\r\nNovice pistol | 5 | 15\r\nNovice shotgun | 6 | 16\r\nNovice SMG | **6 (Changed from 7)**  | **18 (Changed from 20)**\r\nNovice rifle | 9 | 25\r\nCompetent pistol | 13 | 35\r\nCompetent shotgun | 15 | 37\r\nCompetent SMG | 20 | 55\r\nCompetent rifle | 30 | 90\r\nGod pistol | 20 | 120\r\nGod shotgun | 24 | 124\r\nGod SMG | 30 | 190\r\nGod rifle | 60 | 800\r\n\r\nI have reposts that currently accuracy for non trained charter bit to high. It attempt to smoothly correct that. It is as far as I can go without massively correcting ranged tables.\r\n\r\nIn result it should reduce effective range for zero low character on 1-2 tiles. It is almost as low as most tests may pass.","created_at":"2018-07-19T22:33:20Z","updated_at":"2018-07-21T10:10:40Z","closed_at":"2018-07-21T10:10:40Z","merged_at":"2018-07-21T10:10:40Z","merge_commit_sha":"e72359c75de13b26824b7cceb1b02f0429b79f21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24381/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/fade80be35e603bb90bfc2c101420ad9d467feb8","head":{"label":"Firestorm01X2:rescale-ranged","ref":"rescale-ranged","sha":"fade80be35e603bb90bfc2c101420ad9d467feb8","user":{"login":"Firestorm01X2","id":17512620,"node_id":"MDQ6VXNlcjE3NTEyNjIw","avatar_url":"https://avatars3.githubusercontent.com/u/17512620?v=4","gravatar_id":"","url":"https://api.github.com/users/Firestorm01X2","html_url":"https://github.com/Firestorm01X2","followers_url":"https://api.github.com/users/Firestorm01X2/followers","following_url":"https://api.github.com/users/Firestorm01X2/following{/other_user}","gists_url":"https://api.github.com/users/Firestorm01X2/gists{/gist_id}","starred_url":"https://api.github.com/users/Firestorm01X2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firestorm01X2/subscriptions","organizations_url":"https://api.github.com/users/Firestorm01X2/orgs","repos_url":"https://api.github.com/users/Firestorm01X2/repos","events_url":"https://api.github.com/users/Firestorm01X2/events{/privacy}","received_events_url":"https://api.github.com/users/Firestorm01X2/received_events","type":"User","site_admin":false},"repo":{"id":116777626,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3Nzc2MjY=","name":"Cataclysm-DDA","full_name":"Firestorm01X2/Cataclysm-DDA","owner":{"login":"Firestorm01X2","id":17512620,"node_id":"MDQ6VXNlcjE3NTEyNjIw","avatar_url":"https://avatars3.githubusercontent.com/u/17512620?v=4","gravatar_id":"","url":"https://api.github.com/users/Firestorm01X2","html_url":"https://github.com/Firestorm01X2","followers_url":"https://api.github.com/users/Firestorm01X2/followers","following_url":"https://api.github.com/users/Firestorm01X2/following{/other_user}","gists_url":"https://api.github.com/users/Firestorm01X2/gists{/gist_id}","starred_url":"https://api.github.com/users/Firestorm01X2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firestorm01X2/subscriptions","organizations_url":"https://api.github.com/users/Firestorm01X2/orgs","repos_url":"https://api.github.com/users/Firestorm01X2/repos","events_url":"https://api.github.com/users/Firestorm01X2/events{/privacy}","received_events_url":"https://api.github.com/users/Firestorm01X2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Firestorm01X2/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/Firestorm01X2/Cataclysm-DDA/deployments","created_at":"2018-01-09T06:49:39Z","updated_at":"2018-07-20T11:50:27Z","pushed_at":"2018-07-20T13:26:48Z","git_url":"git://github.com/Firestorm01X2/Cataclysm-DDA.git","ssh_url":"git@github.com:Firestorm01X2/Cataclysm-DDA.git","clone_url":"https://github.com/Firestorm01X2/Cataclysm-DDA.git","svn_url":"https://github.com/Firestorm01X2/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1247213,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"8e1ea3d5af342353ceafb6742b56a01a80af86f5","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-07-21T08:30:52Z","pushed_at":"2018-07-21T10:10:40Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1246964,"stargazers_count":1959,"watchers_count":1959,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1339,"mirror_url":null,"archived":false,"open_issues_count":860,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1339,"open_issues":860,"watchers":1959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24381"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24381"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24381/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24381/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/fade80be35e603bb90bfc2c101420ad9d467feb8"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"ZhilkinSerg"}}