{"action":"created","issue":{"url":"https://api.github.com/repos/Harvey-OS/harvey/issues/698","repository_url":"https://api.github.com/repos/Harvey-OS/harvey","labels_url":"https://api.github.com/repos/Harvey-OS/harvey/issues/698/labels{/name}","comments_url":"https://api.github.com/repos/Harvey-OS/harvey/issues/698/comments","events_url":"https://api.github.com/repos/Harvey-OS/harvey/issues/698/events","html_url":"https://github.com/Harvey-OS/harvey/issues/698","id":285552339,"number":698,"title":"Fix Copyrights","user":{"login":"Shamar","id":299880,"avatar_url":"https://avatars0.githubusercontent.com/u/299880?v=4","gravatar_id":"","url":"https://api.github.com/users/Shamar","html_url":"https://github.com/Shamar","followers_url":"https://api.github.com/users/Shamar/followers","following_url":"https://api.github.com/users/Shamar/following{/other_user}","gists_url":"https://api.github.com/users/Shamar/gists{/gist_id}","starred_url":"https://api.github.com/users/Shamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shamar/subscriptions","organizations_url":"https://api.github.com/users/Shamar/orgs","repos_url":"https://api.github.com/users/Shamar/repos","events_url":"https://api.github.com/users/Shamar/events{/privacy}","received_events_url":"https://api.github.com/users/Shamar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-01-02T22:17:33Z","updated_at":"2018-02-13T01:29:29Z","closed_at":"2018-02-12T16:36:37Z","author_association":"CONTRIBUTOR","body":"After the recent reintroduction of the missing 9front's copyright statements to the libsec's code at 81d25a4063b3ae76e993fbab3a06661a2ca68e00, it has been jokingly pointed to me that \"I'm not worthy\", since [none of my 6 months of commits](https://github.com/Harvey-OS/harvey/commits?author=Shamar) have left a sign in Harvey. :-)\r\n\r\nAfter a grep confirming the fact, I've noticed that my port of zlib has been removed and the console has been put back in kernel (removing the user-space filesystem that I wrote in 2015). Also I know that my contributions to the continuous integration and the Coverity integration cannot be evident into the sources.\r\n\r\nHowever looking around I've noticed that at 066eb48ac5025570bf5a63a8ef24da4b35f4cbc2 **my name and copyright has been removed from two new files** that, despite simple in itself, were part of two non trivial contributions at cf801d01f503fc340efd6d0ca97a4921b24b447c and 5616a46061a3a6ea84375e0c34dc8c9dfe9ee87c that moved read(2) and write(2) to user-space while cleaning up the kernel. I realize now that I should have probably amended the copyright of all the files touched by the change, to avoid filling this issue now.\r\n\r\nSince I can't find the AUTHORS file referenced by @rminnich in the commit message at 066eb48ac5025570bf5a63a8ef24da4b35f4cbc2 it's clear that, actually, an AUTHORS file cannot replace proper copyright statements in the code (as [wisely predicted by Ron himself in the mailing list](https://groups.google.com/d/msg/harvey/aG4f6ABDJAw/T3AprBwHDQAJ)).\r\n\r\nI do not remember if I have contributed other non trivial changes to Harvey (that have not been reverted or removed). For example I do not know if the changes at 401284bef0d6ae6d240e1d27dece8a5165011316 or at 4392ad33cbf6ab719c02c535158b01014d17ec69 were trivial or I had to add my copyright to the files modified. I was pretty naive back then, but I guess that if the change is not trivial, the copyright holds even if not noticed in the license's header, so it would probably be better to make it explicit.\r\n\r\nNevertheless, since my name has gone in libc, **it's possible that it happened to other contributors too** and while I'm not a lawyer, I guess this should be fixed. Unfortunately I have no time to check them all.\r\n\r\nAs for me I prefer the copyright to be put in the files I contributed to, [as suggested by the Ron back in 2015](https://groups.google.com/d/msg/harvey/aG4f6ABDJAw/T3AprBwHDQAJ).  \r\nPlease do not use an AUTHORS file for me, since it has proven to break. I'd like my humble contributions to be noticed in source code [just like the others](https://github.com/Harvey-OS/harvey/search?l=C&q=Copyright&type=&utf8=%E2%9C%93).\r\n\r\n\r\n#### Expected behavior\r\nContributors' names and copyrights are preserved in the code base.\r\n\r\n#### Actual behavior\r\nMy name and copyright have been removed from the code, without removing the code or reverting the changes. This might have happened to others.\r\n\r\n#### Steps to reproduce\r\n- clone the repository\r\n- cd to the repository\r\n- grep giacomo@tesio.it -wnr sys/src/libc/\r\n- find | grep AUTHORS"},"comment":{"url":"https://api.github.com/repos/Harvey-OS/harvey/issues/comments/365121223","html_url":"https://github.com/Harvey-OS/harvey/issues/698#issuecomment-365121223","issue_url":"https://api.github.com/repos/Harvey-OS/harvey/issues/698","id":365121223,"user":{"login":"dancrossnyc","id":1592064,"avatar_url":"https://avatars0.githubusercontent.com/u/1592064?v=4","gravatar_id":"","url":"https://api.github.com/users/dancrossnyc","html_url":"https://github.com/dancrossnyc","followers_url":"https://api.github.com/users/dancrossnyc/followers","following_url":"https://api.github.com/users/dancrossnyc/following{/other_user}","gists_url":"https://api.github.com/users/dancrossnyc/gists{/gist_id}","starred_url":"https://api.github.com/users/dancrossnyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dancrossnyc/subscriptions","organizations_url":"https://api.github.com/users/dancrossnyc/orgs","repos_url":"https://api.github.com/users/dancrossnyc/repos","events_url":"https://api.github.com/users/dancrossnyc/events{/privacy}","received_events_url":"https://api.github.com/users/dancrossnyc/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T01:29:29Z","updated_at":"2018-02-13T01:29:29Z","author_association":"CONTRIBUTOR","body":"Yes, in some cases types were widened or code was added or changed for const-correctness. Those are changes that can only be written one way; there is nothing original or significant in their authorship and they cannot reasonably be credited to a single author. Would you seriously suggest that we cannot add a 'const' qualifier to a pointer argument of a function because you did it at some point? That would be rather absurd, don't you think?\r\n\r\nYour commits were removed, as you requested. If the effect of those commits were replicated elsewhere, then given that that is the only way to replicate them, there's nothing anyone can do about that.\r\n\r\nYou are no longer listed as a contributor to Harvey on the main page; whether the effect of trivial changes persists is independent of whether you ever authored similar code."}}
{"actor":{"display_login":"dancrossnyc"}}