{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments/217217045","pull_request_review_id":154877727,"id":217217045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzIxNzA0NQ==","diff_hunk":"@@ -1,74 +1,76 @@\n-import { Component, Input, Injector, OnDestroy, ComponentFactory, ComponentRef, ViewContainerRef, ViewChild, ComponentFactoryResolver } from '@angular/core';\n+import { LogService } from './../../shared/services/log.service';\n+import { ScenarioService } from './../../shared/services/scenario/scenario.service';\n+import { HostTypes, ScenarioIds, LogCategories } from './../../shared/models/constants';","path":"client/src/app/site/log-stream/log-stream.component.ts","position":4,"original_position":4,"commit_id":"42c85cd6334bebbce3a395986a35bac607d71e91","original_commit_id":"42c85cd6334bebbce3a395986a35bac607d71e91","user":{"login":"andimarc","id":5387224,"node_id":"MDQ6VXNlcjUzODcyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5387224?v=4","gravatar_id":"","url":"https://api.github.com/users/andimarc","html_url":"https://github.com/andimarc","followers_url":"https://api.github.com/users/andimarc/followers","following_url":"https://api.github.com/users/andimarc/following{/other_user}","gists_url":"https://api.github.com/users/andimarc/gists{/gist_id}","starred_url":"https://api.github.com/users/andimarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andimarc/subscriptions","organizations_url":"https://api.github.com/users/andimarc/orgs","repos_url":"https://api.github.com/users/andimarc/repos","events_url":"https://api.github.com/users/andimarc/events{/privacy}","received_events_url":"https://api.github.com/users/andimarc/received_events","type":"User","site_admin":false},"body":"Combine the two import statements that both import from './../../shared/models/constants'.","created_at":"2018-09-12T23:08:23Z","updated_at":"2018-09-12T23:08:23Z","html_url":"https://github.com/Azure/azure-functions-ux/pull/3113#discussion_r217217045","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments/217217045"},"html":{"href":"https://github.com/Azure/azure-functions-ux/pull/3113#discussion_r217217045"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113","id":214452470,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDUyNDcw","html_url":"https://github.com/Azure/azure-functions-ux/pull/3113","diff_url":"https://github.com/Azure/azure-functions-ux/pull/3113.diff","patch_url":"https://github.com/Azure/azure-functions-ux/pull/3113.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/3113","number":3113,"state":"open","locked":false,"title":"Fix issues with log streaming and enable for linux apps","user":{"login":"ehamai","id":5695405,"node_id":"MDQ6VXNlcjU2OTU0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/5695405?v=4","gravatar_id":"","url":"https://api.github.com/users/ehamai","html_url":"https://github.com/ehamai","followers_url":"https://api.github.com/users/ehamai/followers","following_url":"https://api.github.com/users/ehamai/following{/other_user}","gists_url":"https://api.github.com/users/ehamai/gists{/gist_id}","starred_url":"https://api.github.com/users/ehamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehamai/subscriptions","organizations_url":"https://api.github.com/users/ehamai/orgs","repos_url":"https://api.github.com/users/ehamai/repos","events_url":"https://api.github.com/users/ehamai/events{/privacy}","received_events_url":"https://api.github.com/users/ehamai/received_events","type":"User","site_admin":false},"body":"I made a few changes to the existing app-level log streaming in order to start showing this for Linux apps as well.  \r\n\r\n1. Got rid of the unnecessary dynamic creation of components in the log-stream.ts component.\r\n2. Added a maximum buffer of 1000 lines so that we don't just keep allocating memory\r\n3. Added a shell component so that it can be loaded for Ibiza\r\n4. Updated styles to match Ibiza patterns\r\n5. Removed the Application log / Webserver selector for Linux until we actually have web server logs.\r\n\r\n![image](https://user-images.githubusercontent.com/5695405/45325933-21b97180-b507-11e8-8ccc-af21d2c7c03c.png)\r\n","created_at":"2018-09-10T21:41:01Z","updated_at":"2018-09-12T23:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f207c4b574c7b7526c509f77313ea384d7e623a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nertim","id":493476,"node_id":"MDQ6VXNlcjQ5MzQ3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/493476?v=4","gravatar_id":"","url":"https://api.github.com/users/nertim","html_url":"https://github.com/nertim","followers_url":"https://api.github.com/users/nertim/followers","following_url":"https://api.github.com/users/nertim/following{/other_user}","gists_url":"https://api.github.com/users/nertim/gists{/gist_id}","starred_url":"https://api.github.com/users/nertim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nertim/subscriptions","organizations_url":"https://api.github.com/users/nertim/orgs","repos_url":"https://api.github.com/users/nertim/repos","events_url":"https://api.github.com/users/nertim/events{/privacy}","received_events_url":"https://api.github.com/users/nertim/received_events","type":"User","site_admin":false},{"login":"agruning","id":8560637,"node_id":"MDQ6VXNlcjg1NjA2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8560637?v=4","gravatar_id":"","url":"https://api.github.com/users/agruning","html_url":"https://github.com/agruning","followers_url":"https://api.github.com/users/agruning/followers","following_url":"https://api.github.com/users/agruning/following{/other_user}","gists_url":"https://api.github.com/users/agruning/gists{/gist_id}","starred_url":"https://api.github.com/users/agruning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agruning/subscriptions","organizations_url":"https://api.github.com/users/agruning/orgs","repos_url":"https://api.github.com/users/agruning/repos","events_url":"https://api.github.com/users/agruning/events{/privacy}","received_events_url":"https://api.github.com/users/agruning/received_events","type":"User","site_admin":false},{"login":"hartra344","id":13208452,"node_id":"MDQ6VXNlcjEzMjA4NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/13208452?v=4","gravatar_id":"","url":"https://api.github.com/users/hartra344","html_url":"https://github.com/hartra344","followers_url":"https://api.github.com/users/hartra344/followers","following_url":"https://api.github.com/users/hartra344/following{/other_user}","gists_url":"https://api.github.com/users/hartra344/gists{/gist_id}","starred_url":"https://api.github.com/users/hartra344/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartra344/subscriptions","organizations_url":"https://api.github.com/users/hartra344/orgs","repos_url":"https://api.github.com/users/hartra344/repos","events_url":"https://api.github.com/users/hartra344/events{/privacy}","received_events_url":"https://api.github.com/users/hartra344/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/3113/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/42c85cd6334bebbce3a395986a35bac607d71e91","head":{"label":"Azure:ehamai-logstream","ref":"ehamai-logstream","sha":"42c85cd6334bebbce3a395986a35bac607d71e91","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":50877831,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3NzgzMQ==","name":"azure-functions-ux","full_name":"Azure/azure-functions-ux","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-ux","description":"Azure Functions UX","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-ux","forks_url":"https://api.github.com/repos/Azure/azure-functions-ux/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-ux/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-ux/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-ux/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-ux/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-ux/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-ux/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-ux/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-ux/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-ux/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-ux/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-ux/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-ux/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-ux/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-ux/deployments","created_at":"2016-02-01T23:01:22Z","updated_at":"2018-09-12T20:29:24Z","pushed_at":"2018-09-12T20:29:30Z","git_url":"git://github.com/Azure/azure-functions-ux.git","ssh_url":"git@github.com:Azure/azure-functions-ux.git","clone_url":"https://github.com/Azure/azure-functions-ux.git","svn_url":"https://github.com/Azure/azure-functions-ux","homepage":"https://functions.azure.com","size":22766,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":281,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":281,"watchers":160,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"829864bc0fa35bf50f6ca45e1112ac3545756c42","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":50877831,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3NzgzMQ==","name":"azure-functions-ux","full_name":"Azure/azure-functions-ux","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-ux","description":"Azure Functions UX","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-ux","forks_url":"https://api.github.com/repos/Azure/azure-functions-ux/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-ux/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-ux/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-ux/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-ux/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-ux/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-ux/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-ux/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-ux/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-ux/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-ux/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-ux/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-ux/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-ux/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-ux/deployments","created_at":"2016-02-01T23:01:22Z","updated_at":"2018-09-12T20:29:24Z","pushed_at":"2018-09-12T20:29:30Z","git_url":"git://github.com/Azure/azure-functions-ux.git","ssh_url":"git@github.com:Azure/azure-functions-ux.git","clone_url":"https://github.com/Azure/azure-functions-ux.git","svn_url":"https://github.com/Azure/azure-functions-ux","homepage":"https://functions.azure.com","size":22766,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":281,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":281,"watchers":160,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113"},"html":{"href":"https://github.com/Azure/azure-functions-ux/pull/3113"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/issues/3113"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/issues/3113/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/3113/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/42c85cd6334bebbce3a395986a35bac607d71e91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andimarc"}}