{"action":"created","comment":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/232928418","pull_request_review_id":174230002,"id":232928418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjkyODQxOA==","diff_hunk":"@@ -0,0 +1,72 @@\n+// Copyright (c) 2017-2018, NVIDIA CORPORATION. All rights reserved.\r\n+//\r\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\r\n+// you may not use this file except in compliance with the License.\r\n+// You may obtain a copy of the License at\r\n+//\r\n+//     http://www.apache.org/licenses/LICENSE-2.0\r\n+//\r\n+// Unless required by applicable law or agreed to in writing, software\r\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\r\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r\n+// See the License for the specific language governing permissions and\r\n+// limitations under the License.\r\n+\r\n+#include \"dali/pipeline/operators/crop/slice.h\"\r\n+\r\n+namespace dali {\r\n+\r\n+template <>\r\n+void Slice<GPUBackend>::DataDependentSetup(DeviceWorkspace *ws,\r\n+                                           unsigned int idx) {\r\n+  // Assumes xywh\r\n+  const auto &input = ws->Input<GPUBackend>(idx);\r\n+\r\n+  // Need to copy to CPU as these values are required to perform other\r\n+  // calculations. Far from ideal, and should be done properly once Crop op\r\n+  // is cleaned up\r\n+  TensorList<CPUBackend> begin;\r\n+  begin.Copy(ws->Input<GPUBackend>(idx + 1), ws->stream());\r\n+\r\n+  TensorList<CPUBackend> size;\r\n+  size.Copy(ws->Input<GPUBackend>(idx + 2), ws->stream());\r","path":"dali/pipeline/operators/crop/slice.cu","position":null,"original_position":32,"commit_id":"bde0fb1acfedae51b610928b5cbec1ce4b616b95","original_commit_id":"75aa909f81e14ec27ccd70465fc9fff8699b7841","user":{"login":"pribalta","id":35964727,"node_id":"MDQ6VXNlcjM1OTY0NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/35964727?v=4","gravatar_id":"","url":"https://api.github.com/users/pribalta","html_url":"https://github.com/pribalta","followers_url":"https://api.github.com/users/pribalta/followers","following_url":"https://api.github.com/users/pribalta/following{/other_user}","gists_url":"https://api.github.com/users/pribalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pribalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pribalta/subscriptions","organizations_url":"https://api.github.com/users/pribalta/orgs","repos_url":"https://api.github.com/users/pribalta/repos","events_url":"https://api.github.com/users/pribalta/events{/privacy}","received_events_url":"https://api.github.com/users/pribalta/received_events","type":"User","site_admin":false},"body":"not necessary as these inputs are now cpu always","created_at":"2018-11-13T08:00:22Z","updated_at":"2018-11-13T08:00:23Z","html_url":"https://github.com/NVIDIA/DALI/pull/269#discussion_r232928418","pull_request_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/232928418"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/269#discussion_r232928418"},"pull_request":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/269"}},"in_reply_to_id":232228496},"pull_request":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/269","id":228367157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzY3MTU3","html_url":"https://github.com/NVIDIA/DALI/pull/269","diff_url":"https://github.com/NVIDIA/DALI/pull/269.diff","patch_url":"https://github.com/NVIDIA/DALI/pull/269.patch","issue_url":"https://api.github.com/repos/NVIDIA/DALI/issues/269","number":269,"state":"open","locked":false,"title":"GPU version of RandomBBoxCrop and Slice","user":{"login":"pribalta","id":35964727,"node_id":"MDQ6VXNlcjM1OTY0NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/35964727?v=4","gravatar_id":"","url":"https://api.github.com/users/pribalta","html_url":"https://github.com/pribalta","followers_url":"https://api.github.com/users/pribalta/followers","following_url":"https://api.github.com/users/pribalta/following{/other_user}","gists_url":"https://api.github.com/users/pribalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pribalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pribalta/subscriptions","organizations_url":"https://api.github.com/users/pribalta/orgs","repos_url":"https://api.github.com/users/pribalta/repos","events_url":"https://api.github.com/users/pribalta/events{/privacy}","received_events_url":"https://api.github.com/users/pribalta/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-05T14:18:02Z","updated_at":"2018-11-13T08:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2525aaf6e471b1d74f604518115f803627f9c704","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/269/commits","review_comments_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/269/comments","review_comment_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/issues/269/comments","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/bde0fb1acfedae51b610928b5cbec1ce4b616b95","head":{"label":"pribalta:slice_gpu","ref":"slice_gpu","sha":"bde0fb1acfedae51b610928b5cbec1ce4b616b95","user":{"login":"pribalta","id":35964727,"node_id":"MDQ6VXNlcjM1OTY0NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/35964727?v=4","gravatar_id":"","url":"https://api.github.com/users/pribalta","html_url":"https://github.com/pribalta","followers_url":"https://api.github.com/users/pribalta/followers","following_url":"https://api.github.com/users/pribalta/following{/other_user}","gists_url":"https://api.github.com/users/pribalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pribalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pribalta/subscriptions","organizations_url":"https://api.github.com/users/pribalta/orgs","repos_url":"https://api.github.com/users/pribalta/repos","events_url":"https://api.github.com/users/pribalta/events{/privacy}","received_events_url":"https://api.github.com/users/pribalta/received_events","type":"User","site_admin":false},"repo":{"id":149611854,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2MTE4NTQ=","name":"DALI","full_name":"pribalta/DALI","private":false,"owner":{"login":"pribalta","id":35964727,"node_id":"MDQ6VXNlcjM1OTY0NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/35964727?v=4","gravatar_id":"","url":"https://api.github.com/users/pribalta","html_url":"https://github.com/pribalta","followers_url":"https://api.github.com/users/pribalta/followers","following_url":"https://api.github.com/users/pribalta/following{/other_user}","gists_url":"https://api.github.com/users/pribalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pribalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pribalta/subscriptions","organizations_url":"https://api.github.com/users/pribalta/orgs","repos_url":"https://api.github.com/users/pribalta/repos","events_url":"https://api.github.com/users/pribalta/events{/privacy}","received_events_url":"https://api.github.com/users/pribalta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pribalta/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":true,"url":"https://api.github.com/repos/pribalta/DALI","forks_url":"https://api.github.com/repos/pribalta/DALI/forks","keys_url":"https://api.github.com/repos/pribalta/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pribalta/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pribalta/DALI/teams","hooks_url":"https://api.github.com/repos/pribalta/DALI/hooks","issue_events_url":"https://api.github.com/repos/pribalta/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/pribalta/DALI/events","assignees_url":"https://api.github.com/repos/pribalta/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/pribalta/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/pribalta/DALI/tags","blobs_url":"https://api.github.com/repos/pribalta/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pribalta/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pribalta/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/pribalta/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pribalta/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/pribalta/DALI/languages","stargazers_url":"https://api.github.com/repos/pribalta/DALI/stargazers","contributors_url":"https://api.github.com/repos/pribalta/DALI/contributors","subscribers_url":"https://api.github.com/repos/pribalta/DALI/subscribers","subscription_url":"https://api.github.com/repos/pribalta/DALI/subscription","commits_url":"https://api.github.com/repos/pribalta/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/pribalta/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/pribalta/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/pribalta/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/pribalta/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/pribalta/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pribalta/DALI/merges","archive_url":"https://api.github.com/repos/pribalta/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pribalta/DALI/downloads","issues_url":"https://api.github.com/repos/pribalta/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/pribalta/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/pribalta/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/pribalta/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pribalta/DALI/labels{/name}","releases_url":"https://api.github.com/repos/pribalta/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/pribalta/DALI/deployments","created_at":"2018-09-20T13:15:13Z","updated_at":"2018-10-31T14:04:49Z","pushed_at":"2018-11-13T07:53:51Z","git_url":"git://github.com/pribalta/DALI.git","ssh_url":"git@github.com:pribalta/DALI.git","clone_url":"https://github.com/pribalta/DALI.git","svn_url":"https://github.com/pribalta/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":39458,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NVIDIA:master","ref":"master","sha":"cc1580b48ec5944b62e6e79fc30af2bd2f5e11be","user":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":135768037,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjgwMzc=","name":"DALI","full_name":"NVIDIA/DALI","private":false,"owner":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NVIDIA/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":false,"url":"https://api.github.com/repos/NVIDIA/DALI","forks_url":"https://api.github.com/repos/NVIDIA/DALI/forks","keys_url":"https://api.github.com/repos/NVIDIA/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/DALI/teams","hooks_url":"https://api.github.com/repos/NVIDIA/DALI/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/DALI/events","assignees_url":"https://api.github.com/repos/NVIDIA/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/DALI/tags","blobs_url":"https://api.github.com/repos/NVIDIA/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/DALI/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/DALI/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/DALI/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/DALI/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/DALI/subscription","commits_url":"https://api.github.com/repos/NVIDIA/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/DALI/merges","archive_url":"https://api.github.com/repos/NVIDIA/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/DALI/downloads","issues_url":"https://api.github.com/repos/NVIDIA/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/DALI/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/DALI/deployments","created_at":"2018-06-01T22:18:01Z","updated_at":"2018-11-13T07:29:08Z","pushed_at":"2018-11-13T07:53:53Z","git_url":"git://github.com/NVIDIA/DALI.git","ssh_url":"git@github.com:NVIDIA/DALI.git","clone_url":"https://github.com/NVIDIA/DALI.git","svn_url":"https://github.com/NVIDIA/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":39231,"stargazers_count":805,"watchers_count":805,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":87,"open_issues":40,"watchers":805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/269"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/269"},"issue":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/269"},"comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/NVIDIA/DALI/statuses/bde0fb1acfedae51b610928b5cbec1ce4b616b95"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pribalta"}}