{"action":"created","comment":{"url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/comments/228394897","pull_request_review_id":168658835,"id":228394897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODM5NDg5Nw==","diff_hunk":"@@ -0,0 +1,45 @@\n+module Cryptoexchange::Exchanges\n+  module Bitexbook\n+    module Services\n+      class Market < Cryptoexchange::Services::Market\n+        class << self\n+          def supports_individual_ticker_query?\n+            false\n+          end\n+        end\n+\n+        def fetch\n+          output = super ticker_url\n+          adapt_all(output)\n+        end\n+\n+        def ticker_url\n+          \"#{Cryptoexchange::Exchanges::Bitexbook::Market::API_URL}/symbols/statistic?last_day=true\"","path":"lib/cryptoexchange/exchanges/bitexbook/services/market.rb","position":17,"original_position":17,"commit_id":"9e31574c80958eb5584d8afb4d1730ac6ff3b448","original_commit_id":"9e31574c80958eb5584d8afb4d1730ac6ff3b448","user":{"login":"wongy91","id":8153462,"node_id":"MDQ6VXNlcjgxNTM0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8153462?v=4","gravatar_id":"","url":"https://api.github.com/users/wongy91","html_url":"https://github.com/wongy91","followers_url":"https://api.github.com/users/wongy91/followers","following_url":"https://api.github.com/users/wongy91/following{/other_user}","gists_url":"https://api.github.com/users/wongy91/gists{/gist_id}","starred_url":"https://api.github.com/users/wongy91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongy91/subscriptions","organizations_url":"https://api.github.com/users/wongy91/orgs","repos_url":"https://api.github.com/users/wongy91/repos","events_url":"https://api.github.com/users/wongy91/events{/privacy}","received_events_url":"https://api.github.com/users/wongy91/received_events","type":"User","site_admin":false},"body":"that is one way but that's 2 calls for 1 ticker. Wondering if they have better endpoint that we can use.","created_at":"2018-10-26T03:12:36Z","updated_at":"2018-10-26T03:12:36Z","html_url":"https://github.com/coingecko/cryptoexchange/pull/1103#discussion_r228394897","pull_request_url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/comments/228394897"},"html":{"href":"https://github.com/coingecko/cryptoexchange/pull/1103#discussion_r228394897"},"pull_request":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103"}},"in_reply_to_id":228065374},"pull_request":{"url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103","id":225611612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjExNjEy","html_url":"https://github.com/coingecko/cryptoexchange/pull/1103","diff_url":"https://github.com/coingecko/cryptoexchange/pull/1103.diff","patch_url":"https://github.com/coingecko/cryptoexchange/pull/1103.patch","issue_url":"https://api.github.com/repos/coingecko/cryptoexchange/issues/1103","number":1103,"state":"open","locked":false,"title":"✨ Implement Bitexbook ticker","user":{"login":"Swingcloud","id":3960142,"node_id":"MDQ6VXNlcjM5NjAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3960142?v=4","gravatar_id":"","url":"https://api.github.com/users/Swingcloud","html_url":"https://github.com/Swingcloud","followers_url":"https://api.github.com/users/Swingcloud/followers","following_url":"https://api.github.com/users/Swingcloud/following{/other_user}","gists_url":"https://api.github.com/users/Swingcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Swingcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swingcloud/subscriptions","organizations_url":"https://api.github.com/users/Swingcloud/orgs","repos_url":"https://api.github.com/users/Swingcloud/repos","events_url":"https://api.github.com/users/Swingcloud/events{/privacy}","received_events_url":"https://api.github.com/users/Swingcloud/received_events","type":"User","site_admin":false},"body":"- What is the purpose of this Pull Request? as title\r\n- What is the related issue for this Pull Request (if this PR fixes issue, prepend with \"Fixes\" or \"Closes\")? resolve #439\r\n- [x] I have added Specs\r\n- [x] (If implementing Market Ticker) I have verified that the `volume` refers to BASE\r\n- [x] (If implementing Market Ticker) I have verified that the `base` and `target` is assigned correctly\r\n\r\nticker about `btc_usd`\r\n```ruby\r\n{\r\n \"symbol\": \"btcusd\",\r\n \"alias\": \"BTC/USD\",\r\n \"currency_base\": \"btc\",\r\n \"currency_base_name\": \"Bitcoin\",\r\n \"currency_quoted\": \"usd\",\r\n \"currency_quoted_name\": \"US Dollar\",\r\n \"statistic\": [\r\n  {\r\n   \"period\": \"last_24_hours\",\r\n   \"price_open\": 7119.7211,\r\n   \"price_close\": 7039.0203,\r\n   \"price_low\": 6710.6366,\r\n   \"price_high\": 7494.6588,\r\n   \"price_bid\": 7000,\r\n   \"price_ask\": 7499.999,\r\n   \"volume_quoted\": 748.4065118094067,\r\n   \"volume_base\": 0.10544345000000004,\r\n   \"orders_buy\": 45,\r\n   \"orders_sell\": 35\r\n  }\r\n ]\r\n}\r\n```\r\nuse `volume_base` as volume \r\nuse server time as timestamp \r\n```ruby\r\n\"meta\": {\r\n \"from\": \"2018-10-24T03:14:29.863472757Z\",\r\n \"to\": \"2018-10-25T03:14:29.863473275Z\",\r\n \"server_time\": \"2018-10-25T03:14:29.863473507Z\"\r\n}\r\n```\r\n\r\n","created_at":"2018-10-25T03:19:02Z","updated_at":"2018-10-26T03:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4aa3dbbc7324267d092dd543c65e44cda406e76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coingecko/cryptoexchange/issues/1103/comments","statuses_url":"https://api.github.com/repos/coingecko/cryptoexchange/statuses/9e31574c80958eb5584d8afb4d1730ac6ff3b448","head":{"label":"Swingcloud:feature/bitexbook","ref":"feature/bitexbook","sha":"9e31574c80958eb5584d8afb4d1730ac6ff3b448","user":{"login":"Swingcloud","id":3960142,"node_id":"MDQ6VXNlcjM5NjAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3960142?v=4","gravatar_id":"","url":"https://api.github.com/users/Swingcloud","html_url":"https://github.com/Swingcloud","followers_url":"https://api.github.com/users/Swingcloud/followers","following_url":"https://api.github.com/users/Swingcloud/following{/other_user}","gists_url":"https://api.github.com/users/Swingcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Swingcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swingcloud/subscriptions","organizations_url":"https://api.github.com/users/Swingcloud/orgs","repos_url":"https://api.github.com/users/Swingcloud/repos","events_url":"https://api.github.com/users/Swingcloud/events{/privacy}","received_events_url":"https://api.github.com/users/Swingcloud/received_events","type":"User","site_admin":false},"repo":{"id":96488113,"node_id":"MDEwOlJlcG9zaXRvcnk5NjQ4ODExMw==","name":"cryptoexchange","full_name":"Swingcloud/cryptoexchange","private":false,"owner":{"login":"Swingcloud","id":3960142,"node_id":"MDQ6VXNlcjM5NjAxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3960142?v=4","gravatar_id":"","url":"https://api.github.com/users/Swingcloud","html_url":"https://github.com/Swingcloud","followers_url":"https://api.github.com/users/Swingcloud/followers","following_url":"https://api.github.com/users/Swingcloud/following{/other_user}","gists_url":"https://api.github.com/users/Swingcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Swingcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swingcloud/subscriptions","organizations_url":"https://api.github.com/users/Swingcloud/orgs","repos_url":"https://api.github.com/users/Swingcloud/repos","events_url":"https://api.github.com/users/Swingcloud/events{/privacy}","received_events_url":"https://api.github.com/users/Swingcloud/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Swingcloud/cryptoexchange","description":"Ruby library to query market data from cryptocurrency exchanges","fork":true,"url":"https://api.github.com/repos/Swingcloud/cryptoexchange","forks_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/forks","keys_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/teams","hooks_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/hooks","issue_events_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/issues/events{/number}","events_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/events","assignees_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/assignees{/user}","branches_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/branches{/branch}","tags_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/tags","blobs_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/statuses/{sha}","languages_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/languages","stargazers_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/stargazers","contributors_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/contributors","subscribers_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/subscribers","subscription_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/subscription","commits_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/contents/{+path}","compare_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/merges","archive_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/downloads","issues_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/issues{/number}","pulls_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/pulls{/number}","milestones_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/milestones{/number}","notifications_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/labels{/name}","releases_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/releases{/id}","deployments_url":"https://api.github.com/repos/Swingcloud/cryptoexchange/deployments","created_at":"2017-07-07T01:52:08Z","updated_at":"2018-10-26T02:38:24Z","pushed_at":"2018-10-26T02:38:22Z","git_url":"git://github.com/Swingcloud/cryptoexchange.git","ssh_url":"git@github.com:Swingcloud/cryptoexchange.git","clone_url":"https://github.com/Swingcloud/cryptoexchange.git","svn_url":"https://github.com/Swingcloud/cryptoexchange","homepage":null,"size":7425,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coingecko:master","ref":"master","sha":"f0d55a5b8136699ab91bd634f7781c0d01a06c2e","user":{"login":"coingecko","id":7111837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMTE4Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/7111837?v=4","gravatar_id":"","url":"https://api.github.com/users/coingecko","html_url":"https://github.com/coingecko","followers_url":"https://api.github.com/users/coingecko/followers","following_url":"https://api.github.com/users/coingecko/following{/other_user}","gists_url":"https://api.github.com/users/coingecko/gists{/gist_id}","starred_url":"https://api.github.com/users/coingecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coingecko/subscriptions","organizations_url":"https://api.github.com/users/coingecko/orgs","repos_url":"https://api.github.com/users/coingecko/repos","events_url":"https://api.github.com/users/coingecko/events{/privacy}","received_events_url":"https://api.github.com/users/coingecko/received_events","type":"Organization","site_admin":false},"repo":{"id":96099146,"node_id":"MDEwOlJlcG9zaXRvcnk5NjA5OTE0Ng==","name":"cryptoexchange","full_name":"coingecko/cryptoexchange","private":false,"owner":{"login":"coingecko","id":7111837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMTE4Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/7111837?v=4","gravatar_id":"","url":"https://api.github.com/users/coingecko","html_url":"https://github.com/coingecko","followers_url":"https://api.github.com/users/coingecko/followers","following_url":"https://api.github.com/users/coingecko/following{/other_user}","gists_url":"https://api.github.com/users/coingecko/gists{/gist_id}","starred_url":"https://api.github.com/users/coingecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coingecko/subscriptions","organizations_url":"https://api.github.com/users/coingecko/orgs","repos_url":"https://api.github.com/users/coingecko/repos","events_url":"https://api.github.com/users/coingecko/events{/privacy}","received_events_url":"https://api.github.com/users/coingecko/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coingecko/cryptoexchange","description":"Ruby library to query market data from cryptocurrency exchanges (https://www.coingecko.com)","fork":false,"url":"https://api.github.com/repos/coingecko/cryptoexchange","forks_url":"https://api.github.com/repos/coingecko/cryptoexchange/forks","keys_url":"https://api.github.com/repos/coingecko/cryptoexchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coingecko/cryptoexchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coingecko/cryptoexchange/teams","hooks_url":"https://api.github.com/repos/coingecko/cryptoexchange/hooks","issue_events_url":"https://api.github.com/repos/coingecko/cryptoexchange/issues/events{/number}","events_url":"https://api.github.com/repos/coingecko/cryptoexchange/events","assignees_url":"https://api.github.com/repos/coingecko/cryptoexchange/assignees{/user}","branches_url":"https://api.github.com/repos/coingecko/cryptoexchange/branches{/branch}","tags_url":"https://api.github.com/repos/coingecko/cryptoexchange/tags","blobs_url":"https://api.github.com/repos/coingecko/cryptoexchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coingecko/cryptoexchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coingecko/cryptoexchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/coingecko/cryptoexchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coingecko/cryptoexchange/statuses/{sha}","languages_url":"https://api.github.com/repos/coingecko/cryptoexchange/languages","stargazers_url":"https://api.github.com/repos/coingecko/cryptoexchange/stargazers","contributors_url":"https://api.github.com/repos/coingecko/cryptoexchange/contributors","subscribers_url":"https://api.github.com/repos/coingecko/cryptoexchange/subscribers","subscription_url":"https://api.github.com/repos/coingecko/cryptoexchange/subscription","commits_url":"https://api.github.com/repos/coingecko/cryptoexchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/coingecko/cryptoexchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/coingecko/cryptoexchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/coingecko/cryptoexchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/coingecko/cryptoexchange/contents/{+path}","compare_url":"https://api.github.com/repos/coingecko/cryptoexchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coingecko/cryptoexchange/merges","archive_url":"https://api.github.com/repos/coingecko/cryptoexchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coingecko/cryptoexchange/downloads","issues_url":"https://api.github.com/repos/coingecko/cryptoexchange/issues{/number}","pulls_url":"https://api.github.com/repos/coingecko/cryptoexchange/pulls{/number}","milestones_url":"https://api.github.com/repos/coingecko/cryptoexchange/milestones{/number}","notifications_url":"https://api.github.com/repos/coingecko/cryptoexchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coingecko/cryptoexchange/labels{/name}","releases_url":"https://api.github.com/repos/coingecko/cryptoexchange/releases{/id}","deployments_url":"https://api.github.com/repos/coingecko/cryptoexchange/deployments","created_at":"2017-07-03T10:25:10Z","updated_at":"2018-10-26T03:10:18Z","pushed_at":"2018-10-26T03:10:08Z","git_url":"git://github.com/coingecko/cryptoexchange.git","ssh_url":"git@github.com:coingecko/cryptoexchange.git","clone_url":"https://github.com/coingecko/cryptoexchange.git","svn_url":"https://github.com/coingecko/cryptoexchange","homepage":"https://www.coingecko.com","size":7246,"stargazers_count":147,"watchers_count":147,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":119,"open_issues":254,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103"},"html":{"href":"https://github.com/coingecko/cryptoexchange/pull/1103"},"issue":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/issues/1103"},"comments":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/coingecko/cryptoexchange/statuses/9e31574c80958eb5584d8afb4d1730ac6ff3b448"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wongy91"}}