{"action":"created","comment":{"url":"https://api.github.com/repos/php-censor/php-censor/pulls/comments/243291393","pull_request_review_id":187021463,"id":243291393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI5MTM5Mw==","diff_hunk":"@@ -12,13 +12,24 @@\n  */\n class PhpSpec extends Plugin\n {\n+  protected $executable;\n     /**\n      * @return string\n      */\n     public static function pluginName()\n     {\n         return 'php_spec';\n     }\n+        public function __construct(Builder $builder, Build $build, array $options = [])\n+    {","path":"src/Plugin/PhpSpec.php","position":13,"original_position":13,"commit_id":"7bbe512179dac49842b9030e3274f8ba9f2f07c8","original_commit_id":"7bbe512179dac49842b9030e3274f8ba9f2f07c8","user":{"login":"php-censor-bot","id":34411061,"node_id":"MDQ6VXNlcjM0NDExMDYx","avatar_url":"https://avatars0.githubusercontent.com/u/34411061?v=4","gravatar_id":"","url":"https://api.github.com/users/php-censor-bot","html_url":"https://github.com/php-censor-bot","followers_url":"https://api.github.com/users/php-censor-bot/followers","following_url":"https://api.github.com/users/php-censor-bot/following{/other_user}","gists_url":"https://api.github.com/users/php-censor-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/php-censor-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-censor-bot/subscriptions","organizations_url":"https://api.github.com/users/php-censor-bot/orgs","repos_url":"https://api.github.com/users/php-censor-bot/repos","events_url":"https://api.github.com/users/php-censor-bot/events{/privacy}","received_events_url":"https://api.github.com/users/php-censor-bot/received_events","type":"User","site_admin":false},"body":"PHPCS: Opening brace indented incorrectly; expected 8 spaces, found 4","created_at":"2018-12-20T14:32:23Z","updated_at":"2018-12-20T14:32:23Z","html_url":"https://github.com/php-censor/php-censor/pull/240#discussion_r243291393","pull_request_url":"https://api.github.com/repos/php-censor/php-censor/pulls/240","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/comments/243291393"},"html":{"href":"https://github.com/php-censor/php-censor/pull/240#discussion_r243291393"},"pull_request":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/php-censor/php-censor/pulls/240","id":239516629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTE2NjI5","html_url":"https://github.com/php-censor/php-censor/pull/240","diff_url":"https://github.com/php-censor/php-censor/pull/240.diff","patch_url":"https://github.com/php-censor/php-censor/pull/240.patch","issue_url":"https://api.github.com/repos/php-censor/php-censor/issues/240","number":240,"state":"open","locked":false,"title":"standardization in plugin","user":{"login":"vinpel","id":1699839,"node_id":"MDQ6VXNlcjE2OTk4Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1699839?v=4","gravatar_id":"","url":"https://api.github.com/users/vinpel","html_url":"https://github.com/vinpel","followers_url":"https://api.github.com/users/vinpel/followers","following_url":"https://api.github.com/users/vinpel/following{/other_user}","gists_url":"https://api.github.com/users/vinpel/gists{/gist_id}","starred_url":"https://api.github.com/users/vinpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinpel/subscriptions","organizations_url":"https://api.github.com/users/vinpel/orgs","repos_url":"https://api.github.com/users/vinpel/repos","events_url":"https://api.github.com/users/vinpel/events{/privacy}","received_events_url":"https://api.github.com/users/vinpel/received_events","type":"User","site_admin":false},"body":"## Contribution type\r\nBugfix, feature : a lot of modification, need to be tested and reviewed\r\n\r\n## Description of change\r\n- added **\"executable\"** (string) argument to specify the relative or absolute path of executable\r\n- added **\"directory\"** (string) argument who set the base run of directory, overwrite the global \"directory\"\r\n- renamed arguments for clarification (tried to keep compatibility)\r\n- added a per plugin (and fixed some plugins) **\"ignore\"** (array) argument who is merged with global ignore\r\n- fixed somes directory management (./ or not ..), somes plugins need path relative to their launch, other to root: \r\n\r\n```yaml\r\ntest:\r\n  php_cpd:\r\n    directory: \"src/agents/\"\r\n    allow_failures: true\r\n    ignore:\r\n      - src/components/method/\r\n      - src/agents/config/models\r\n      - tests/\r\n```\r\nIn our exemple, only  \"src/agents/config/models\" is inside directory \"src/agents\" and we pass only the subdirectory :\r\n```shell\r\nArgs: [\"\\/app\\/php-censor\\/vendor\\/bin\\/phpcpd --log-pmd \\\"%s\\\" %s \\\"%s\\\"\",\"\\/tmp\\/php_cpd_KrEPQo\",\" --exclude config\\/models\",\"\\/app\\/php-censor\\/runtime\\/builds\\/1\\/115_fc99faf0\\/src\\/agents\\/\"]\r\nCommand: /app/php-censor/vendor/bin/phpcpd --log-pmd \"/tmp/php_cpd_KrEPQo\"  --exclude config/models \"/app/php-censor/runtime/builds/1/115_fc99faf0/src/agents/\"\r\n```\r\nit allow plugin to correctly ignore directory\r\n\r\n__Need review :__\r\n added %DATABASE_TEST_HOST% keywork, now write of database, in my  case host can be different, used like this :\r\n\r\n```yaml\r\nshell:\r\n- \"sed -i -e 's,mysql:host=db;dbname=database_test,mysql:host=%DATABASE_TEST_HOST%;dbname=TEST_DB_BUILD_%BUILD%,g' %BUILD_PATH%src/config/db_mysql_test.php\"\r\n```\r\n\r\n","created_at":"2018-12-18T14:51:48Z","updated_at":"2018-12-20T14:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3404ab257fdb68ba7ef6376059851a3fd0877f2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":945407413,"node_id":"MDU6TGFiZWw5NDU0MDc0MTM=","url":"https://api.github.com/repos/php-censor/php-censor/labels/component:plugin","name":"component:plugin","color":"1a5c7a","default":false},{"id":945401430,"node_id":"MDU6TGFiZWw5NDU0MDE0MzA=","url":"https://api.github.com/repos/php-censor/php-censor/labels/priority:normal","name":"priority:normal","color":"8fe2f7","default":false},{"id":945402822,"node_id":"MDU6TGFiZWw5NDU0MDI4MjI=","url":"https://api.github.com/repos/php-censor/php-censor/labels/type:enhancement","name":"type:enhancement","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/php-censor/php-censor/milestones/1","html_url":"https://github.com/php-censor/php-censor/milestone/1","labels_url":"https://api.github.com/repos/php-censor/php-censor/milestones/1/labels","id":2797953,"node_id":"MDk6TWlsZXN0b25lMjc5Nzk1Mw==","number":1,"title":"Version 1.0","description":"","creator":{"login":"corpsee","id":1416706,"node_id":"MDQ6VXNlcjE0MTY3MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1416706?v=4","gravatar_id":"","url":"https://api.github.com/users/corpsee","html_url":"https://github.com/corpsee","followers_url":"https://api.github.com/users/corpsee/followers","following_url":"https://api.github.com/users/corpsee/following{/other_user}","gists_url":"https://api.github.com/users/corpsee/gists{/gist_id}","starred_url":"https://api.github.com/users/corpsee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corpsee/subscriptions","organizations_url":"https://api.github.com/users/corpsee/orgs","repos_url":"https://api.github.com/users/corpsee/repos","events_url":"https://api.github.com/users/corpsee/events{/privacy}","received_events_url":"https://api.github.com/users/corpsee/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":65,"state":"open","created_at":"2017-09-27T15:37:18Z","updated_at":"2018-12-19T01:16:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/php-censor/php-censor/pulls/240/commits","review_comments_url":"https://api.github.com/repos/php-censor/php-censor/pulls/240/comments","review_comment_url":"https://api.github.com/repos/php-censor/php-censor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-censor/php-censor/issues/240/comments","statuses_url":"https://api.github.com/repos/php-censor/php-censor/statuses/7bbe512179dac49842b9030e3274f8ba9f2f07c8","head":{"label":"vinpel:path-in-plugin","ref":"path-in-plugin","sha":"7bbe512179dac49842b9030e3274f8ba9f2f07c8","user":{"login":"vinpel","id":1699839,"node_id":"MDQ6VXNlcjE2OTk4Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1699839?v=4","gravatar_id":"","url":"https://api.github.com/users/vinpel","html_url":"https://github.com/vinpel","followers_url":"https://api.github.com/users/vinpel/followers","following_url":"https://api.github.com/users/vinpel/following{/other_user}","gists_url":"https://api.github.com/users/vinpel/gists{/gist_id}","starred_url":"https://api.github.com/users/vinpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinpel/subscriptions","organizations_url":"https://api.github.com/users/vinpel/orgs","repos_url":"https://api.github.com/users/vinpel/repos","events_url":"https://api.github.com/users/vinpel/events{/privacy}","received_events_url":"https://api.github.com/users/vinpel/received_events","type":"User","site_admin":false},"repo":{"id":161613301,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2MTMzMDE=","name":"php-censor","full_name":"vinpel/php-censor","private":false,"owner":{"login":"vinpel","id":1699839,"node_id":"MDQ6VXNlcjE2OTk4Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1699839?v=4","gravatar_id":"","url":"https://api.github.com/users/vinpel","html_url":"https://github.com/vinpel","followers_url":"https://api.github.com/users/vinpel/followers","following_url":"https://api.github.com/users/vinpel/following{/other_user}","gists_url":"https://api.github.com/users/vinpel/gists{/gist_id}","starred_url":"https://api.github.com/users/vinpel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinpel/subscriptions","organizations_url":"https://api.github.com/users/vinpel/orgs","repos_url":"https://api.github.com/users/vinpel/repos","events_url":"https://api.github.com/users/vinpel/events{/privacy}","received_events_url":"https://api.github.com/users/vinpel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vinpel/php-censor","description":"PHP Censor is an open source self-hosted continuous integration server for PHP projects.","fork":true,"url":"https://api.github.com/repos/vinpel/php-censor","forks_url":"https://api.github.com/repos/vinpel/php-censor/forks","keys_url":"https://api.github.com/repos/vinpel/php-censor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinpel/php-censor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinpel/php-censor/teams","hooks_url":"https://api.github.com/repos/vinpel/php-censor/hooks","issue_events_url":"https://api.github.com/repos/vinpel/php-censor/issues/events{/number}","events_url":"https://api.github.com/repos/vinpel/php-censor/events","assignees_url":"https://api.github.com/repos/vinpel/php-censor/assignees{/user}","branches_url":"https://api.github.com/repos/vinpel/php-censor/branches{/branch}","tags_url":"https://api.github.com/repos/vinpel/php-censor/tags","blobs_url":"https://api.github.com/repos/vinpel/php-censor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinpel/php-censor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinpel/php-censor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinpel/php-censor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinpel/php-censor/statuses/{sha}","languages_url":"https://api.github.com/repos/vinpel/php-censor/languages","stargazers_url":"https://api.github.com/repos/vinpel/php-censor/stargazers","contributors_url":"https://api.github.com/repos/vinpel/php-censor/contributors","subscribers_url":"https://api.github.com/repos/vinpel/php-censor/subscribers","subscription_url":"https://api.github.com/repos/vinpel/php-censor/subscription","commits_url":"https://api.github.com/repos/vinpel/php-censor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinpel/php-censor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinpel/php-censor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinpel/php-censor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinpel/php-censor/contents/{+path}","compare_url":"https://api.github.com/repos/vinpel/php-censor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinpel/php-censor/merges","archive_url":"https://api.github.com/repos/vinpel/php-censor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinpel/php-censor/downloads","issues_url":"https://api.github.com/repos/vinpel/php-censor/issues{/number}","pulls_url":"https://api.github.com/repos/vinpel/php-censor/pulls{/number}","milestones_url":"https://api.github.com/repos/vinpel/php-censor/milestones{/number}","notifications_url":"https://api.github.com/repos/vinpel/php-censor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinpel/php-censor/labels{/name}","releases_url":"https://api.github.com/repos/vinpel/php-censor/releases{/id}","deployments_url":"https://api.github.com/repos/vinpel/php-censor/deployments","created_at":"2018-12-13T09:14:16Z","updated_at":"2018-12-13T12:33:57Z","pushed_at":"2018-12-20T14:31:16Z","git_url":"git://github.com/vinpel/php-censor.git","ssh_url":"git@github.com:vinpel/php-censor.git","clone_url":"https://github.com/vinpel/php-censor.git","svn_url":"https://github.com/vinpel/php-censor","homepage":"http://php-censor.info","size":12017,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-censor:master","ref":"master","sha":"dbd2dedd2de3f198ee134ecec15c6e31fe7d9f3e","user":{"login":"php-censor","id":31279111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc5MTEx","avatar_url":"https://avatars2.githubusercontent.com/u/31279111?v=4","gravatar_id":"","url":"https://api.github.com/users/php-censor","html_url":"https://github.com/php-censor","followers_url":"https://api.github.com/users/php-censor/followers","following_url":"https://api.github.com/users/php-censor/following{/other_user}","gists_url":"https://api.github.com/users/php-censor/gists{/gist_id}","starred_url":"https://api.github.com/users/php-censor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-censor/subscriptions","organizations_url":"https://api.github.com/users/php-censor/orgs","repos_url":"https://api.github.com/users/php-censor/repos","events_url":"https://api.github.com/users/php-censor/events{/privacy}","received_events_url":"https://api.github.com/users/php-censor/received_events","type":"Organization","site_admin":false},"repo":{"id":78023529,"node_id":"MDEwOlJlcG9zaXRvcnk3ODAyMzUyOQ==","name":"php-censor","full_name":"php-censor/php-censor","private":false,"owner":{"login":"php-censor","id":31279111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc5MTEx","avatar_url":"https://avatars2.githubusercontent.com/u/31279111?v=4","gravatar_id":"","url":"https://api.github.com/users/php-censor","html_url":"https://github.com/php-censor","followers_url":"https://api.github.com/users/php-censor/followers","following_url":"https://api.github.com/users/php-censor/following{/other_user}","gists_url":"https://api.github.com/users/php-censor/gists{/gist_id}","starred_url":"https://api.github.com/users/php-censor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-censor/subscriptions","organizations_url":"https://api.github.com/users/php-censor/orgs","repos_url":"https://api.github.com/users/php-censor/repos","events_url":"https://api.github.com/users/php-censor/events{/privacy}","received_events_url":"https://api.github.com/users/php-censor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php-censor/php-censor","description":"PHP Censor is an open source self-hosted continuous integration server for PHP projects.","fork":false,"url":"https://api.github.com/repos/php-censor/php-censor","forks_url":"https://api.github.com/repos/php-censor/php-censor/forks","keys_url":"https://api.github.com/repos/php-censor/php-censor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-censor/php-censor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-censor/php-censor/teams","hooks_url":"https://api.github.com/repos/php-censor/php-censor/hooks","issue_events_url":"https://api.github.com/repos/php-censor/php-censor/issues/events{/number}","events_url":"https://api.github.com/repos/php-censor/php-censor/events","assignees_url":"https://api.github.com/repos/php-censor/php-censor/assignees{/user}","branches_url":"https://api.github.com/repos/php-censor/php-censor/branches{/branch}","tags_url":"https://api.github.com/repos/php-censor/php-censor/tags","blobs_url":"https://api.github.com/repos/php-censor/php-censor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-censor/php-censor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-censor/php-censor/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-censor/php-censor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-censor/php-censor/statuses/{sha}","languages_url":"https://api.github.com/repos/php-censor/php-censor/languages","stargazers_url":"https://api.github.com/repos/php-censor/php-censor/stargazers","contributors_url":"https://api.github.com/repos/php-censor/php-censor/contributors","subscribers_url":"https://api.github.com/repos/php-censor/php-censor/subscribers","subscription_url":"https://api.github.com/repos/php-censor/php-censor/subscription","commits_url":"https://api.github.com/repos/php-censor/php-censor/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-censor/php-censor/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-censor/php-censor/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-censor/php-censor/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-censor/php-censor/contents/{+path}","compare_url":"https://api.github.com/repos/php-censor/php-censor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-censor/php-censor/merges","archive_url":"https://api.github.com/repos/php-censor/php-censor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-censor/php-censor/downloads","issues_url":"https://api.github.com/repos/php-censor/php-censor/issues{/number}","pulls_url":"https://api.github.com/repos/php-censor/php-censor/pulls{/number}","milestones_url":"https://api.github.com/repos/php-censor/php-censor/milestones{/number}","notifications_url":"https://api.github.com/repos/php-censor/php-censor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-censor/php-censor/labels{/name}","releases_url":"https://api.github.com/repos/php-censor/php-censor/releases{/id}","deployments_url":"https://api.github.com/repos/php-censor/php-censor/deployments","created_at":"2017-01-04T14:39:00Z","updated_at":"2018-12-20T13:35:46Z","pushed_at":"2018-12-20T14:31:19Z","git_url":"git://github.com/php-censor/php-censor.git","ssh_url":"git@github.com:php-censor/php-censor.git","clone_url":"https://github.com/php-censor/php-censor.git","svn_url":"https://github.com/php-censor/php-censor","homepage":"http://php-censor.info","size":12006,"stargazers_count":394,"watchers_count":394,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":65,"open_issues":28,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/240"},"html":{"href":"https://github.com/php-censor/php-censor/pull/240"},"issue":{"href":"https://api.github.com/repos/php-censor/php-censor/issues/240"},"comments":{"href":"https://api.github.com/repos/php-censor/php-censor/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-censor/php-censor/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/php-censor/php-censor/statuses/7bbe512179dac49842b9030e3274f8ba9f2f07c8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"php-censor-bot"}}