{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/1082","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/1082/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/1082/comments","events_url":"https://api.github.com/repos/coq/coq/issues/1082/events","html_url":"https://github.com/coq/coq/pull/1082","id":260000829,"number":1082,"title":"Fixing Print for inductive types with let-in in parameters","user":{"login":"herbelin","id":460771,"avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"labels":[{"id":485985650,"url":"https://api.github.com/repos/coq/coq/labels/kind:%20fix","name":"kind: fix","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/11","html_url":"https://github.com/coq/coq/milestone/11","labels_url":"https://api.github.com/repos/coq/coq/milestones/11/labels","id":2974954,"number":11,"title":"8.7.2","description":"","creator":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":53,"state":"open","created_at":"2017-12-12T16:52:07Z","updated_at":"2018-02-12T06:49:35Z","due_on":"2018-02-15T08:00:00Z","closed_at":null},"comments":15,"created_at":"2017-09-23T11:11:45Z","updated_at":"2018-02-12T09:15:36Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/1082","html_url":"https://github.com/coq/coq/pull/1082","diff_url":"https://github.com/coq/coq/pull/1082.diff","patch_url":"https://github.com/coq/coq/pull/1082.patch"},"body":"@ppedrot mentioned the following printing bug:\r\n```coq\r\nInductive foo (A : Type) (x : A) (y := x) := Foo.\r\nPrint foo.\r\n(* Inductive foo (A : Type) (x : A) (y:=x) : let y := x in Prop := Foo : let y := x in foo A x *)\r\n```\r\nThe first commit of this PR fixes this printing bug as well as a similar printing bug for records with trailing let-ins in parameters. The bug was caused by using `hnf_prod_applist` (on-the-fly substitution of products) which is not let-in aware.\r\n\r\nIn a second commit, I protectively changed a suspicious use of `hnf_prod_applist` in computing the type of a vm_computed `match` (if I understand correctly). I was not able to say at once if the function `Vnorm.nf_predicate` was doing the expected job w.r.t. let-ins (isn't a `LetIn` case missing? and what is this `crazy_type`?). I let it to the specialists.\r\n\r\nThe checker (and the kernel) are also using `hnf_prod_applist` but in situations where already only a subset of the signature of parameters is considered (the signature of recursively uniform parameters). So, it does not seem to be a problem to me. After all, it is equivalent to have trailing let-in parameters and to uniformly distribute these let-in parameters on the constructors and on the arities."},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/364865861","html_url":"https://github.com/coq/coq/pull/1082#issuecomment-364865861","issue_url":"https://api.github.com/repos/coq/coq/issues/1082","id":364865861,"user":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T09:15:36Z","updated_at":"2018-02-12T09:15:36Z","author_association":"OWNER","body":"Will review today, as soon as I have a minute."}}
{"actor":{"display_login":"maximedenes"}}