{"action":"created","comment":{"url":"https://api.github.com/repos/ContinuumIO/intake/pulls/comments/211618432","pull_request_review_id":148076046,"id":211618432,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTYxODQzMg==","diff_hunk":"@@ -139,13 +141,20 @@ def load(self, urlpath):\n                 logger.debug(\"Cached at: {}\".format(cache_path))\n                 self._log_metadata(urlpath, file_in.path, cache_path)\n \n-                with file_in as f1:\n-                    with file_out as f2:\n-                        data = True\n-                        while data:\n-                            #TODO: print out progress\n-                            data = f1.read(self.blocksize)\n-                            f2.write(data)\n+                file_size = file_in.fs.size(file_in.path)","path":"intake/source/cache.py","position":19,"original_position":20,"commit_id":"8b0e703b0bba9f9184f7a5030ab14affbdd95970","original_commit_id":"f2a74297040c2474086056bfe5e2cc82425e075c","user":{"login":"mmccarty","id":625946,"node_id":"MDQ6VXNlcjYyNTk0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/625946?v=4","gravatar_id":"","url":"https://api.github.com/users/mmccarty","html_url":"https://github.com/mmccarty","followers_url":"https://api.github.com/users/mmccarty/followers","following_url":"https://api.github.com/users/mmccarty/following{/other_user}","gists_url":"https://api.github.com/users/mmccarty/gists{/gist_id}","starred_url":"https://api.github.com/users/mmccarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmccarty/subscriptions","organizations_url":"https://api.github.com/users/mmccarty/orgs","repos_url":"https://api.github.com/users/mmccarty/repos","events_url":"https://api.github.com/users/mmccarty/events{/privacy}","received_events_url":"https://api.github.com/users/mmccarty/received_events","type":"User","site_admin":false},"body":"No, HTTP implements `.size()`","created_at":"2018-08-21T14:06:01Z","updated_at":"2018-08-21T14:06:01Z","html_url":"https://github.com/ContinuumIO/intake/pull/138#discussion_r211618432","pull_request_url":"https://api.github.com/repos/ContinuumIO/intake/pulls/138","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/comments/211618432"},"html":{"href":"https://github.com/ContinuumIO/intake/pull/138#discussion_r211618432"},"pull_request":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/138"}},"in_reply_to_id":211617387},"pull_request":{"url":"https://api.github.com/repos/ContinuumIO/intake/pulls/138","id":209832551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODMyNTUx","html_url":"https://github.com/ContinuumIO/intake/pull/138","diff_url":"https://github.com/ContinuumIO/intake/pull/138.diff","patch_url":"https://github.com/ContinuumIO/intake/pull/138.patch","issue_url":"https://api.github.com/repos/ContinuumIO/intake/issues/138","number":138,"state":"open","locked":false,"title":"Added progress bar for cache downloads.","user":{"login":"mmccarty","id":625946,"node_id":"MDQ6VXNlcjYyNTk0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/625946?v=4","gravatar_id":"","url":"https://api.github.com/users/mmccarty","html_url":"https://github.com/mmccarty","followers_url":"https://api.github.com/users/mmccarty/followers","following_url":"https://api.github.com/users/mmccarty/following{/other_user}","gists_url":"https://api.github.com/users/mmccarty/gists{/gist_id}","starred_url":"https://api.github.com/users/mmccarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmccarty/subscriptions","organizations_url":"https://api.github.com/users/mmccarty/orgs","repos_url":"https://api.github.com/users/mmccarty/repos","events_url":"https://api.github.com/users/mmccarty/events{/privacy}","received_events_url":"https://api.github.com/users/mmccarty/received_events","type":"User","site_admin":false},"body":"![progress_bar](https://user-images.githubusercontent.com/625946/44405574-952f1b00-a527-11e8-9c4a-6538dc251558.gif)\r\n\r\nSince making this gif, I've added clearing the output after each file has downloaded.","created_at":"2018-08-21T13:49:10Z","updated_at":"2018-08-21T14:06:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"953f832be3259cdf3b00e2e0a98ff1bc0cb36927","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ContinuumIO/intake/pulls/138/commits","review_comments_url":"https://api.github.com/repos/ContinuumIO/intake/pulls/138/comments","review_comment_url":"https://api.github.com/repos/ContinuumIO/intake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ContinuumIO/intake/issues/138/comments","statuses_url":"https://api.github.com/repos/ContinuumIO/intake/statuses/8b0e703b0bba9f9184f7a5030ab14affbdd95970","head":{"label":"ContinuumIO:caching_progress_bar","ref":"caching_progress_bar","sha":"8b0e703b0bba9f9184f7a5030ab14affbdd95970","user":{"login":"ContinuumIO","id":1158637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1158637?v=4","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"repo":{"id":100307970,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAzMDc5NzA=","name":"intake","full_name":"ContinuumIO/intake","owner":{"login":"ContinuumIO","id":1158637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1158637?v=4","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ContinuumIO/intake","description":"A plugin system for loading your data and making data catalogs.","fork":false,"url":"https://api.github.com/repos/ContinuumIO/intake","forks_url":"https://api.github.com/repos/ContinuumIO/intake/forks","keys_url":"https://api.github.com/repos/ContinuumIO/intake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ContinuumIO/intake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ContinuumIO/intake/teams","hooks_url":"https://api.github.com/repos/ContinuumIO/intake/hooks","issue_events_url":"https://api.github.com/repos/ContinuumIO/intake/issues/events{/number}","events_url":"https://api.github.com/repos/ContinuumIO/intake/events","assignees_url":"https://api.github.com/repos/ContinuumIO/intake/assignees{/user}","branches_url":"https://api.github.com/repos/ContinuumIO/intake/branches{/branch}","tags_url":"https://api.github.com/repos/ContinuumIO/intake/tags","blobs_url":"https://api.github.com/repos/ContinuumIO/intake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ContinuumIO/intake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ContinuumIO/intake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ContinuumIO/intake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ContinuumIO/intake/statuses/{sha}","languages_url":"https://api.github.com/repos/ContinuumIO/intake/languages","stargazers_url":"https://api.github.com/repos/ContinuumIO/intake/stargazers","contributors_url":"https://api.github.com/repos/ContinuumIO/intake/contributors","subscribers_url":"https://api.github.com/repos/ContinuumIO/intake/subscribers","subscription_url":"https://api.github.com/repos/ContinuumIO/intake/subscription","commits_url":"https://api.github.com/repos/ContinuumIO/intake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ContinuumIO/intake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ContinuumIO/intake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ContinuumIO/intake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ContinuumIO/intake/contents/{+path}","compare_url":"https://api.github.com/repos/ContinuumIO/intake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ContinuumIO/intake/merges","archive_url":"https://api.github.com/repos/ContinuumIO/intake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ContinuumIO/intake/downloads","issues_url":"https://api.github.com/repos/ContinuumIO/intake/issues{/number}","pulls_url":"https://api.github.com/repos/ContinuumIO/intake/pulls{/number}","milestones_url":"https://api.github.com/repos/ContinuumIO/intake/milestones{/number}","notifications_url":"https://api.github.com/repos/ContinuumIO/intake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ContinuumIO/intake/labels{/name}","releases_url":"https://api.github.com/repos/ContinuumIO/intake/releases{/id}","deployments_url":"https://api.github.com/repos/ContinuumIO/intake/deployments","created_at":"2017-08-14T20:44:22Z","updated_at":"2018-08-21T06:34:18Z","pushed_at":"2018-08-21T14:05:32Z","git_url":"git://github.com/ContinuumIO/intake.git","ssh_url":"git@github.com:ContinuumIO/intake.git","clone_url":"https://github.com/ContinuumIO/intake.git","svn_url":"https://github.com/ContinuumIO/intake","homepage":"https://intake.readthedocs.io/en/latest/quickstart.html","size":2109,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":8,"open_issues":19,"watchers":47,"default_branch":"master"}},"base":{"label":"ContinuumIO:master","ref":"master","sha":"9c63336dc15b807b979b3c68d45ba03cc7bd46ed","user":{"login":"ContinuumIO","id":1158637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1158637?v=4","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"repo":{"id":100307970,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAzMDc5NzA=","name":"intake","full_name":"ContinuumIO/intake","owner":{"login":"ContinuumIO","id":1158637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1158637?v=4","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ContinuumIO/intake","description":"A plugin system for loading your data and making data catalogs.","fork":false,"url":"https://api.github.com/repos/ContinuumIO/intake","forks_url":"https://api.github.com/repos/ContinuumIO/intake/forks","keys_url":"https://api.github.com/repos/ContinuumIO/intake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ContinuumIO/intake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ContinuumIO/intake/teams","hooks_url":"https://api.github.com/repos/ContinuumIO/intake/hooks","issue_events_url":"https://api.github.com/repos/ContinuumIO/intake/issues/events{/number}","events_url":"https://api.github.com/repos/ContinuumIO/intake/events","assignees_url":"https://api.github.com/repos/ContinuumIO/intake/assignees{/user}","branches_url":"https://api.github.com/repos/ContinuumIO/intake/branches{/branch}","tags_url":"https://api.github.com/repos/ContinuumIO/intake/tags","blobs_url":"https://api.github.com/repos/ContinuumIO/intake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ContinuumIO/intake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ContinuumIO/intake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ContinuumIO/intake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ContinuumIO/intake/statuses/{sha}","languages_url":"https://api.github.com/repos/ContinuumIO/intake/languages","stargazers_url":"https://api.github.com/repos/ContinuumIO/intake/stargazers","contributors_url":"https://api.github.com/repos/ContinuumIO/intake/contributors","subscribers_url":"https://api.github.com/repos/ContinuumIO/intake/subscribers","subscription_url":"https://api.github.com/repos/ContinuumIO/intake/subscription","commits_url":"https://api.github.com/repos/ContinuumIO/intake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ContinuumIO/intake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ContinuumIO/intake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ContinuumIO/intake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ContinuumIO/intake/contents/{+path}","compare_url":"https://api.github.com/repos/ContinuumIO/intake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ContinuumIO/intake/merges","archive_url":"https://api.github.com/repos/ContinuumIO/intake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ContinuumIO/intake/downloads","issues_url":"https://api.github.com/repos/ContinuumIO/intake/issues{/number}","pulls_url":"https://api.github.com/repos/ContinuumIO/intake/pulls{/number}","milestones_url":"https://api.github.com/repos/ContinuumIO/intake/milestones{/number}","notifications_url":"https://api.github.com/repos/ContinuumIO/intake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ContinuumIO/intake/labels{/name}","releases_url":"https://api.github.com/repos/ContinuumIO/intake/releases{/id}","deployments_url":"https://api.github.com/repos/ContinuumIO/intake/deployments","created_at":"2017-08-14T20:44:22Z","updated_at":"2018-08-21T06:34:18Z","pushed_at":"2018-08-21T14:05:32Z","git_url":"git://github.com/ContinuumIO/intake.git","ssh_url":"git@github.com:ContinuumIO/intake.git","clone_url":"https://github.com/ContinuumIO/intake.git","svn_url":"https://github.com/ContinuumIO/intake","homepage":"https://intake.readthedocs.io/en/latest/quickstart.html","size":2109,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":8,"open_issues":19,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/138"},"html":{"href":"https://github.com/ContinuumIO/intake/pull/138"},"issue":{"href":"https://api.github.com/repos/ContinuumIO/intake/issues/138"},"comments":{"href":"https://api.github.com/repos/ContinuumIO/intake/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ContinuumIO/intake/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/ContinuumIO/intake/statuses/8b0e703b0bba9f9184f7a5030ab14affbdd95970"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mmccarty"}}