{"action":"created","issue":{"url":"https://api.github.com/repos/robotology/yarp/issues/1921","repository_url":"https://api.github.com/repos/robotology/yarp","labels_url":"https://api.github.com/repos/robotology/yarp/issues/1921/labels{/name}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1921/comments","events_url":"https://api.github.com/repos/robotology/yarp/issues/1921/events","html_url":"https://github.com/robotology/yarp/issues/1921","id":382185218,"node_id":"MDU6SXNzdWUzODIxODUyMTg=","number":1921,"title":"PontCloudTypes: Possible error in DataRGBA","user":{"login":"drdanz","id":1100056,"node_id":"MDQ6VXNlcjExMDAwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"labels":[{"id":90673453,"node_id":"MDU6TGFiZWw5MDY3MzQ1Mw==","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Library%20-%20YARP_sig","name":"Component: Library - YARP_sig","color":"207de5","default":false},{"id":36381544,"node_id":"MDU6TGFiZWwzNjM4MTU0NA==","url":"https://api.github.com/repos/robotology/yarp/labels/Issue%20Type:%20Bug","name":"Issue Type: Bug","color":"9830d1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-19T12:05:55Z","updated_at":"2018-11-20T08:02:20Z","closed_at":null,"author_association":"MEMBER","body":"The order of the bytes in `DataRGBA` seems wrong (`b`, `g`, `r`, `a`).\r\n\r\nhttps://github.com/robotology/yarp/blob/ff713f369ff3a00aafd64d8105597e203f58b65a/src/libYARP_sig/include/yarp/sig/PointCloudTypes.h#L483-L490\r\n\r\nIs this a typo? If it is not, please add a comment to explain..."},"comment":{"url":"https://api.github.com/repos/robotology/yarp/issues/comments/440179052","html_url":"https://github.com/robotology/yarp/issues/1921#issuecomment-440179052","issue_url":"https://api.github.com/repos/robotology/yarp/issues/1921","id":440179052,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDE3OTA1Mg==","user":{"login":"claudiofantacci","id":14168673,"node_id":"MDQ6VXNlcjE0MTY4Njcz","avatar_url":"https://avatars2.githubusercontent.com/u/14168673?v=4","gravatar_id":"","url":"https://api.github.com/users/claudiofantacci","html_url":"https://github.com/claudiofantacci","followers_url":"https://api.github.com/users/claudiofantacci/followers","following_url":"https://api.github.com/users/claudiofantacci/following{/other_user}","gists_url":"https://api.github.com/users/claudiofantacci/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiofantacci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiofantacci/subscriptions","organizations_url":"https://api.github.com/users/claudiofantacci/orgs","repos_url":"https://api.github.com/users/claudiofantacci/repos","events_url":"https://api.github.com/users/claudiofantacci/events{/privacy}","received_events_url":"https://api.github.com/users/claudiofantacci/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T08:02:20Z","updated_at":"2018-11-20T08:02:20Z","author_association":"CONTRIBUTOR","body":"Interesting observation. PCL defines\r\n[PCL_ADD_UNION_RGB](https://github.com/PointCloudLibrary/pcl/blob/c26faa2a696432cb629b7fe012de03f71db0762a/common/include/pcl/impl/point_types.hpp#L224-L239) as a **BGR** union, then it defines [RGB vectors](https://github.com/PointCloudLibrary/pcl/blob/c26faa2a696432cb629b7fe012de03f71db0762a/common/include/pcl/impl/point_types.hpp#L242-L247) reordering the data in the union. I guess that `PCL_ADD_UNION_RGB` could be simply renamed `PCL_ADD_UNION_BGR`. As long as there is an agreement on data alignment, our structure is good to go, isn't it?"}}
{"actor":{"display_login":"claudiofantacci"}}