{"action":"created","comment":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments/192055651","pull_request_review_id":124751505,"id":192055651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjA1NTY1MQ==","diff_hunk":"@@ -285,10 +281,11 @@ function runElmTest() {\n   checkNodeVersion();\n \n   if (args._[0] == \"init\") {\n-    var cmdArgs = Init.init();\n-    var cmd = [pathToElmPackage, \"install\", \"--yes\"].concat(cmdArgs).join(\" \");\n-\n-    child_process.execSync(cmd, { stdio: \"inherit\", cwd: Init.elmPackageDir });\n+    var packagesToInstall = Init.init();\n+    if (packagesToInstall.length > 0) {\n+      var cmd = [pathToElm, \"install\"].concat(packagesToInstall).join(\" \");\n+      child_process.execSync(cmd, { stdio: \"inherit\", cwd: Init.elmPackageDir });\n+    }\n \n     process.exit(0);","path":"lib/elm-test.js","position":125,"original_position":125,"commit_id":"47a355795900b47765a88a2d670949bfe0519b8b","original_commit_id":"47a355795900b47765a88a2d670949bfe0519b8b","user":{"login":"eeue56","id":1139198,"node_id":"MDQ6VXNlcjExMzkxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1139198?v=4","gravatar_id":"","url":"https://api.github.com/users/eeue56","html_url":"https://github.com/eeue56","followers_url":"https://api.github.com/users/eeue56/followers","following_url":"https://api.github.com/users/eeue56/following{/other_user}","gists_url":"https://api.github.com/users/eeue56/gists{/gist_id}","starred_url":"https://api.github.com/users/eeue56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeue56/subscriptions","organizations_url":"https://api.github.com/users/eeue56/orgs","repos_url":"https://api.github.com/users/eeue56/repos","events_url":"https://api.github.com/users/eeue56/events{/privacy}","received_events_url":"https://api.github.com/users/eeue56/received_events","type":"User","site_admin":false},"body":"Should there be some feedback in this case?","created_at":"2018-05-31T10:30:07Z","updated_at":"2018-05-31T10:30:07Z","html_url":"https://github.com/rtfeldman/node-test-runner/pull/257#discussion_r192055651","pull_request_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments/192055651"},"html":{"href":"https://github.com/rtfeldman/node-test-runner/pull/257#discussion_r192055651"},"pull_request":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257","id":189536079,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NTM2MDc5","html_url":"https://github.com/rtfeldman/node-test-runner/pull/257","diff_url":"https://github.com/rtfeldman/node-test-runner/pull/257.diff","patch_url":"https://github.com/rtfeldman/node-test-runner/pull/257.patch","issue_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/257","number":257,"state":"open","locked":false,"title":"WIP Elm 0.19","user":{"login":"avh4","id":1222,"node_id":"MDQ6VXNlcjEyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false},"body":"TODO: before merging this, someone needs to read through the entire test run output and make sure there's nothing unexpected happening.  Test output can be seen via the Travis-CI build.","created_at":"2018-05-22T03:02:40Z","updated_at":"2018-05-31T10:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"506742a4045eb9e88ec65d99eec926b923f17416","assignee":{"login":"avh4","id":1222,"node_id":"MDQ6VXNlcjEyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false},"assignees":[{"login":"avh4","id":1222,"node_id":"MDQ6VXNlcjEyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257/commits","review_comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257/comments","review_comment_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/257/comments","statuses_url":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/47a355795900b47765a88a2d670949bfe0519b8b","head":{"label":"rtfeldman:av-0.19","ref":"av-0.19","sha":"47a355795900b47765a88a2d670949bfe0519b8b","user":{"login":"rtfeldman","id":1094080,"node_id":"MDQ6VXNlcjEwOTQwODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1094080?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"repo":{"id":37029814,"node_id":"MDEwOlJlcG9zaXRvcnkzNzAyOTgxNA==","name":"node-test-runner","full_name":"rtfeldman/node-test-runner","owner":{"login":"rtfeldman","id":1094080,"node_id":"MDQ6VXNlcjEwOTQwODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1094080?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtfeldman/node-test-runner","description":"Runs elm-test suites from Node.js. Get it with npm install -g elm-test","fork":false,"url":"https://api.github.com/repos/rtfeldman/node-test-runner","forks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/forks","keys_url":"https://api.github.com/repos/rtfeldman/node-test-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfeldman/node-test-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfeldman/node-test-runner/teams","hooks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/hooks","issue_events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/events{/number}","events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/events","assignees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/assignees{/user}","branches_url":"https://api.github.com/repos/rtfeldman/node-test-runner/branches{/branch}","tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/tags","blobs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfeldman/node-test-runner/languages","stargazers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/stargazers","contributors_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contributors","subscribers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscribers","subscription_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscription","commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contents/{+path}","compare_url":"https://api.github.com/repos/rtfeldman/node-test-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfeldman/node-test-runner/merges","archive_url":"https://api.github.com/repos/rtfeldman/node-test-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfeldman/node-test-runner/downloads","issues_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues{/number}","pulls_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfeldman/node-test-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfeldman/node-test-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfeldman/node-test-runner/labels{/name}","releases_url":"https://api.github.com/repos/rtfeldman/node-test-runner/releases{/id}","deployments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/deployments","created_at":"2015-06-07T19:48:23Z","updated_at":"2018-04-30T11:07:41Z","pushed_at":"2018-05-31T05:07:26Z","git_url":"git://github.com/rtfeldman/node-test-runner.git","ssh_url":"git@github.com:rtfeldman/node-test-runner.git","clone_url":"https://github.com/rtfeldman/node-test-runner.git","svn_url":"https://github.com/rtfeldman/node-test-runner","homepage":"","size":5455,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":47,"open_issues":35,"watchers":97,"default_branch":"master"}},"base":{"label":"rtfeldman:master","ref":"master","sha":"4f9147f687e5636e0c2fd0b661ab5262c9e90faf","user":{"login":"rtfeldman","id":1094080,"node_id":"MDQ6VXNlcjEwOTQwODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1094080?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"repo":{"id":37029814,"node_id":"MDEwOlJlcG9zaXRvcnkzNzAyOTgxNA==","name":"node-test-runner","full_name":"rtfeldman/node-test-runner","owner":{"login":"rtfeldman","id":1094080,"node_id":"MDQ6VXNlcjEwOTQwODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1094080?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtfeldman/node-test-runner","description":"Runs elm-test suites from Node.js. Get it with npm install -g elm-test","fork":false,"url":"https://api.github.com/repos/rtfeldman/node-test-runner","forks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/forks","keys_url":"https://api.github.com/repos/rtfeldman/node-test-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfeldman/node-test-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfeldman/node-test-runner/teams","hooks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/hooks","issue_events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/events{/number}","events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/events","assignees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/assignees{/user}","branches_url":"https://api.github.com/repos/rtfeldman/node-test-runner/branches{/branch}","tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/tags","blobs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfeldman/node-test-runner/languages","stargazers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/stargazers","contributors_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contributors","subscribers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscribers","subscription_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscription","commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contents/{+path}","compare_url":"https://api.github.com/repos/rtfeldman/node-test-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfeldman/node-test-runner/merges","archive_url":"https://api.github.com/repos/rtfeldman/node-test-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfeldman/node-test-runner/downloads","issues_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues{/number}","pulls_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfeldman/node-test-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfeldman/node-test-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfeldman/node-test-runner/labels{/name}","releases_url":"https://api.github.com/repos/rtfeldman/node-test-runner/releases{/id}","deployments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/deployments","created_at":"2015-06-07T19:48:23Z","updated_at":"2018-04-30T11:07:41Z","pushed_at":"2018-05-31T05:07:26Z","git_url":"git://github.com/rtfeldman/node-test-runner.git","ssh_url":"git@github.com:rtfeldman/node-test-runner.git","clone_url":"https://github.com/rtfeldman/node-test-runner.git","svn_url":"https://github.com/rtfeldman/node-test-runner","homepage":"","size":5455,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":47,"open_issues":35,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257"},"html":{"href":"https://github.com/rtfeldman/node-test-runner/pull/257"},"issue":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/257"},"comments":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/47a355795900b47765a88a2d670949bfe0519b8b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"eeue56"}}