{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/237190083","pull_request_review_id":179428652,"id":237190083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE5MDA4Mw==","diff_hunk":"@@ -46,7 +46,7 @@ using gprecoverseg.\n Segment recovery using gprecoverseg requires that you have an active \n mirror to recover from. For systems that do not have mirroring enabled, \n or in the event of a double fault (a primary and mirror pair both down \n-at the same time) � do a system restart to bring the segments back \n+at the same time) - a system restart to bring the segments back ","path":"gpMgmt/doc/gprecoverseg_help","position":5,"original_position":5,"commit_id":"8f631653c79954e06cd0e535195e56081cfa76a3","original_commit_id":"8f631653c79954e06cd0e535195e56081cfa76a3","user":{"login":"dkrieger-pvtl","id":42985115,"node_id":"MDQ6VXNlcjQyOTg1MTE1","avatar_url":"https://avatars1.githubusercontent.com/u/42985115?v=4","gravatar_id":"","url":"https://api.github.com/users/dkrieger-pvtl","html_url":"https://github.com/dkrieger-pvtl","followers_url":"https://api.github.com/users/dkrieger-pvtl/followers","following_url":"https://api.github.com/users/dkrieger-pvtl/following{/other_user}","gists_url":"https://api.github.com/users/dkrieger-pvtl/gists{/gist_id}","starred_url":"https://api.github.com/users/dkrieger-pvtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkrieger-pvtl/subscriptions","organizations_url":"https://api.github.com/users/dkrieger-pvtl/orgs","repos_url":"https://api.github.com/users/dkrieger-pvtl/repos","events_url":"https://api.github.com/users/dkrieger-pvtl/events{/privacy}","received_events_url":"https://api.github.com/users/dkrieger-pvtl/received_events","type":"User","site_admin":false},"body":"Agreed...in Chrome, the ```?``` character shows up as a ```-``` and if you run ```od -t a -h gprecoverseg_help``` it is encoded as 0x97.  Not sure in what encoding that is a ```-``` but seems simpler to just convert to a UTF-8 ```-```.","created_at":"2018-11-28T17:40:45Z","updated_at":"2018-11-28T17:43:34Z","html_url":"https://github.com/greenplum-db/gpdb/pull/6328#discussion_r237190083","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/237190083"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6328#discussion_r237190083"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328"}},"in_reply_to_id":237149677},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328","id":233665436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjY1NDM2","html_url":"https://github.com/greenplum-db/gpdb/pull/6328","diff_url":"https://github.com/greenplum-db/gpdb/pull/6328.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/6328.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6328","number":6328,"state":"open","locked":false,"title":"docs: update gprecoverseg_help","user":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"body":"Update documentation to match the default setting when adding the option in `gpMgmt/bin/gppylib/programs/clsRecoverSegment.py`\r\n\r\nThis follows up on https://github.com/greenplum-db/gpdb/pull/6262, where we were OK with the content, but wanted to put the change in master, and then back to `5X_STABLE`\r\n\r\n[ci skip]","created_at":"2018-11-26T19:10:31Z","updated_at":"2018-11-28T17:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb669bd0054b678a8c8bce367fe84b9f292d21d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielgustafsson","id":321790,"node_id":"MDQ6VXNlcjMyMTc5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/321790?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},{"login":"brendanstephens","id":18556336,"node_id":"MDQ6VXNlcjE4NTU2MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/18556336?v=4","gravatar_id":"","url":"https://api.github.com/users/brendanstephens","html_url":"https://github.com/brendanstephens","followers_url":"https://api.github.com/users/brendanstephens/followers","following_url":"https://api.github.com/users/brendanstephens/following{/other_user}","gists_url":"https://api.github.com/users/brendanstephens/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanstephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanstephens/subscriptions","organizations_url":"https://api.github.com/users/brendanstephens/orgs","repos_url":"https://api.github.com/users/brendanstephens/repos","events_url":"https://api.github.com/users/brendanstephens/events{/privacy}","received_events_url":"https://api.github.com/users/brendanstephens/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6328/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8f631653c79954e06cd0e535195e56081cfa76a3","head":{"label":"doty-pivotal:dev/doc_gprecoverseg","ref":"dev/doc_gprecoverseg","sha":"8f631653c79954e06cd0e535195e56081cfa76a3","user":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"repo":{"id":116710926,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3MTA5MjY=","name":"gpdb","full_name":"doty-pivotal/gpdb","private":false,"owner":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/doty-pivotal/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/doty-pivotal/gpdb","forks_url":"https://api.github.com/repos/doty-pivotal/gpdb/forks","keys_url":"https://api.github.com/repos/doty-pivotal/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doty-pivotal/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doty-pivotal/gpdb/teams","hooks_url":"https://api.github.com/repos/doty-pivotal/gpdb/hooks","issue_events_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/doty-pivotal/gpdb/events","assignees_url":"https://api.github.com/repos/doty-pivotal/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/doty-pivotal/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/doty-pivotal/gpdb/tags","blobs_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doty-pivotal/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/doty-pivotal/gpdb/languages","stargazers_url":"https://api.github.com/repos/doty-pivotal/gpdb/stargazers","contributors_url":"https://api.github.com/repos/doty-pivotal/gpdb/contributors","subscribers_url":"https://api.github.com/repos/doty-pivotal/gpdb/subscribers","subscription_url":"https://api.github.com/repos/doty-pivotal/gpdb/subscription","commits_url":"https://api.github.com/repos/doty-pivotal/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/doty-pivotal/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/doty-pivotal/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/doty-pivotal/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doty-pivotal/gpdb/merges","archive_url":"https://api.github.com/repos/doty-pivotal/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doty-pivotal/gpdb/downloads","issues_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/doty-pivotal/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/doty-pivotal/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/doty-pivotal/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doty-pivotal/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/doty-pivotal/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/doty-pivotal/gpdb/deployments","created_at":"2018-01-08T18:08:55Z","updated_at":"2018-11-07T00:52:39Z","pushed_at":"2018-11-27T23:25:40Z","git_url":"git://github.com/doty-pivotal/gpdb.git","ssh_url":"git@github.com:doty-pivotal/gpdb.git","clone_url":"https://github.com/doty-pivotal/gpdb.git","svn_url":"https://github.com/doty-pivotal/gpdb","homepage":"http://greenplum.org","size":328303,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"e90a3bdd55817478e2026063c0240890ccc1e97c","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-11-28T17:33:55Z","pushed_at":"2018-11-28T17:34:44Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":332306,"stargazers_count":2810,"watchers_count":2810,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":270,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":857,"open_issues":270,"watchers":2810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6328"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6328"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6328/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6328/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8f631653c79954e06cd0e535195e56081cfa76a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dkrieger-pvtl"}}