{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/104","repository_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator","labels_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/104/comments","events_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/104/events","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/104","id":305347178,"number":104,"title":"Constant time comparison for codes","user":{"login":"lstrojny","id":79707,"avatar_url":"https://avatars2.githubusercontent.com/u/79707?v=4","gravatar_id":"","url":"https://api.github.com/users/lstrojny","html_url":"https://github.com/lstrojny","followers_url":"https://api.github.com/users/lstrojny/followers","following_url":"https://api.github.com/users/lstrojny/following{/other_user}","gists_url":"https://api.github.com/users/lstrojny/gists{/gist_id}","starred_url":"https://api.github.com/users/lstrojny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lstrojny/subscriptions","organizations_url":"https://api.github.com/users/lstrojny/orgs","repos_url":"https://api.github.com/users/lstrojny/repos","events_url":"https://api.github.com/users/lstrojny/events{/privacy}","received_events_url":"https://api.github.com/users/lstrojny/received_events","type":"User","site_admin":false},"labels":[{"id":369793197,"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/labels/patch","name":"patch","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-14T22:10:20Z","updated_at":"2018-03-15T09:21:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/pulls/104","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/104","diff_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/104.diff","patch_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/104.patch"},"body":"`hash_equals` is used for constant time comparison in code validation. That’s cool. Because the code terminates early if it matches, there is a theoretical possibility for guessing the clock skew from the response time.\r\n\r\nI am targeting this branch, because kind of a bugfix.\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Security\r\n* Constant time comparison when checking TOTP codes\r\n```"},"comment":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/comments/373311378","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/104#issuecomment-373311378","issue_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/104","id":373311378,"user":{"login":"lstrojny","id":79707,"avatar_url":"https://avatars2.githubusercontent.com/u/79707?v=4","gravatar_id":"","url":"https://api.github.com/users/lstrojny","html_url":"https://github.com/lstrojny","followers_url":"https://api.github.com/users/lstrojny/followers","following_url":"https://api.github.com/users/lstrojny/following{/other_user}","gists_url":"https://api.github.com/users/lstrojny/gists{/gist_id}","starred_url":"https://api.github.com/users/lstrojny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lstrojny/subscriptions","organizations_url":"https://api.github.com/users/lstrojny/orgs","repos_url":"https://api.github.com/users/lstrojny/repos","events_url":"https://api.github.com/users/lstrojny/events{/privacy}","received_events_url":"https://api.github.com/users/lstrojny/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T09:21:41Z","updated_at":"2018-03-15T09:21:41Z","author_association":"NONE","body":"@greg0ire added a comment explaining the implementation details"}}
{"actor":{"display_login":"lstrojny"}}