{"action":"created","comment":{"url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/comments/191452769","pull_request_review_id":124026449,"id":191452769,"diff_hunk":"@@ -440,4 +443,8 @@ export class WalletService {\n     this.intervalTime = (hasPendingTxs ? 20 : 60) * 1000;\n     this.refreshBalancesTimeInSec = hasPendingTxs ? 20 : 300;\n   }\n+\n+  private getCleanSeed(seed: string): string {\n+    return seed.replace(/\\r?\\n|\\r/g, ' ').replace(/ +/g, ' ').trim();","path":"src/app/services/wallet.service.ts","position":23,"original_position":23,"commit_id":"3ebe80805f86beaa5118afa7122486fdbcf8458b","original_commit_id":"3ebe80805f86beaa5118afa7122486fdbcf8458b","user":{"login":"Senyoret1","id":34079003,"avatar_url":"https://avatars0.githubusercontent.com/u/34079003?v=4","gravatar_id":"","url":"https://api.github.com/users/Senyoret1","html_url":"https://github.com/Senyoret1","followers_url":"https://api.github.com/users/Senyoret1/followers","following_url":"https://api.github.com/users/Senyoret1/following{/other_user}","gists_url":"https://api.github.com/users/Senyoret1/gists{/gist_id}","starred_url":"https://api.github.com/users/Senyoret1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senyoret1/subscriptions","organizations_url":"https://api.github.com/users/Senyoret1/orgs","repos_url":"https://api.github.com/users/Senyoret1/repos","events_url":"https://api.github.com/users/Senyoret1/events{/privacy}","received_events_url":"https://api.github.com/users/Senyoret1/received_events","type":"User","site_admin":false},"body":"Please change to `seed.replace(/(\\n|\\r\\n)$/, '');`, as in the desktop wallet (https://github.com/skycoin/skycoin/blob/develop/src/gui/static/src/app/services/wallet.service.ts#L52). The goal is to only erase up to one new line character at the end of the string.","created_at":"2018-05-29T14:45:19Z","updated_at":"2018-05-29T14:45:26Z","html_url":"https://github.com/skycoin/skycoin-web/pull/180#discussion_r191452769","pull_request_url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/comments/191452769"},"html":{"href":"https://github.com/skycoin/skycoin-web/pull/180#discussion_r191452769"},"pull_request":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180","id":191076812,"html_url":"https://github.com/skycoin/skycoin-web/pull/180","diff_url":"https://github.com/skycoin/skycoin-web/pull/180.diff","patch_url":"https://github.com/skycoin/skycoin-web/pull/180.patch","issue_url":"https://api.github.com/repos/skycoin/skycoin-web/issues/180","number":180,"state":"open","locked":false,"title":"#99: (Updated) The texts of the seeds must be cleaned","user":{"login":"AndreiIarovoi","id":38654909,"avatar_url":"https://avatars1.githubusercontent.com/u/38654909?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreiIarovoi","html_url":"https://github.com/AndreiIarovoi","followers_url":"https://api.github.com/users/AndreiIarovoi/followers","following_url":"https://api.github.com/users/AndreiIarovoi/following{/other_user}","gists_url":"https://api.github.com/users/AndreiIarovoi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiIarovoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiIarovoi/subscriptions","organizations_url":"https://api.github.com/users/AndreiIarovoi/orgs","repos_url":"https://api.github.com/users/AndreiIarovoi/repos","events_url":"https://api.github.com/users/AndreiIarovoi/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiIarovoi/received_events","type":"User","site_admin":false},"body":"Fixes #99 \r\n\r\nChanges:\r\n- Seed is cleaned before create and unlockWallet\r\n","created_at":"2018-05-29T09:02:03Z","updated_at":"2018-05-29T14:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4058ddef07398d4c91f87ce781710b2bd9cf8f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180/commits","review_comments_url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180/comments","review_comment_url":"https://api.github.com/repos/skycoin/skycoin-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skycoin/skycoin-web/issues/180/comments","statuses_url":"https://api.github.com/repos/skycoin/skycoin-web/statuses/3ebe80805f86beaa5118afa7122486fdbcf8458b","head":{"label":"AndreiIarovoi:SKY#99","ref":"SKY#99","sha":"3ebe80805f86beaa5118afa7122486fdbcf8458b","user":{"login":"AndreiIarovoi","id":38654909,"avatar_url":"https://avatars1.githubusercontent.com/u/38654909?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreiIarovoi","html_url":"https://github.com/AndreiIarovoi","followers_url":"https://api.github.com/users/AndreiIarovoi/followers","following_url":"https://api.github.com/users/AndreiIarovoi/following{/other_user}","gists_url":"https://api.github.com/users/AndreiIarovoi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiIarovoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiIarovoi/subscriptions","organizations_url":"https://api.github.com/users/AndreiIarovoi/orgs","repos_url":"https://api.github.com/users/AndreiIarovoi/repos","events_url":"https://api.github.com/users/AndreiIarovoi/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiIarovoi/received_events","type":"User","site_admin":false},"repo":{"id":131024741,"name":"skycoin-web","full_name":"AndreiIarovoi/skycoin-web","owner":{"login":"AndreiIarovoi","id":38654909,"avatar_url":"https://avatars1.githubusercontent.com/u/38654909?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreiIarovoi","html_url":"https://github.com/AndreiIarovoi","followers_url":"https://api.github.com/users/AndreiIarovoi/followers","following_url":"https://api.github.com/users/AndreiIarovoi/following{/other_user}","gists_url":"https://api.github.com/users/AndreiIarovoi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiIarovoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiIarovoi/subscriptions","organizations_url":"https://api.github.com/users/AndreiIarovoi/orgs","repos_url":"https://api.github.com/users/AndreiIarovoi/repos","events_url":"https://api.github.com/users/AndreiIarovoi/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiIarovoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreiIarovoi/skycoin-web","description":"Webclient for Skycoin","fork":true,"url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web","forks_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/forks","keys_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/teams","hooks_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/hooks","issue_events_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/issues/events{/number}","events_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/events","assignees_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/assignees{/user}","branches_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/branches{/branch}","tags_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/tags","blobs_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/languages","stargazers_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/stargazers","contributors_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/contributors","subscribers_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/subscribers","subscription_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/subscription","commits_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/contents/{+path}","compare_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/merges","archive_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/downloads","issues_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/issues{/number}","pulls_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/labels{/name}","releases_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/releases{/id}","deployments_url":"https://api.github.com/repos/AndreiIarovoi/skycoin-web/deployments","created_at":"2018-04-25T15:11:43Z","updated_at":"2018-05-29T08:46:49Z","pushed_at":"2018-05-29T12:19:51Z","git_url":"git://github.com/AndreiIarovoi/skycoin-web.git","ssh_url":"git@github.com:AndreiIarovoi/skycoin-web.git","clone_url":"https://github.com/AndreiIarovoi/skycoin-web.git","svn_url":"https://github.com/AndreiIarovoi/skycoin-web","homepage":"https://wallet.skycoin.net","size":4578,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skycoin:master","ref":"master","sha":"49cf777f36fe96407ef9c90eca5a464030f279a1","user":{"login":"skycoin","id":29321691,"avatar_url":"https://avatars3.githubusercontent.com/u/29321691?v=4","gravatar_id":"","url":"https://api.github.com/users/skycoin","html_url":"https://github.com/skycoin","followers_url":"https://api.github.com/users/skycoin/followers","following_url":"https://api.github.com/users/skycoin/following{/other_user}","gists_url":"https://api.github.com/users/skycoin/gists{/gist_id}","starred_url":"https://api.github.com/users/skycoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skycoin/subscriptions","organizations_url":"https://api.github.com/users/skycoin/orgs","repos_url":"https://api.github.com/users/skycoin/repos","events_url":"https://api.github.com/users/skycoin/events{/privacy}","received_events_url":"https://api.github.com/users/skycoin/received_events","type":"Organization","site_admin":false},"repo":{"id":111329005,"name":"skycoin-web","full_name":"skycoin/skycoin-web","owner":{"login":"skycoin","id":29321691,"avatar_url":"https://avatars3.githubusercontent.com/u/29321691?v=4","gravatar_id":"","url":"https://api.github.com/users/skycoin","html_url":"https://github.com/skycoin","followers_url":"https://api.github.com/users/skycoin/followers","following_url":"https://api.github.com/users/skycoin/following{/other_user}","gists_url":"https://api.github.com/users/skycoin/gists{/gist_id}","starred_url":"https://api.github.com/users/skycoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skycoin/subscriptions","organizations_url":"https://api.github.com/users/skycoin/orgs","repos_url":"https://api.github.com/users/skycoin/repos","events_url":"https://api.github.com/users/skycoin/events{/privacy}","received_events_url":"https://api.github.com/users/skycoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skycoin/skycoin-web","description":"Webclient for Skycoin","fork":false,"url":"https://api.github.com/repos/skycoin/skycoin-web","forks_url":"https://api.github.com/repos/skycoin/skycoin-web/forks","keys_url":"https://api.github.com/repos/skycoin/skycoin-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skycoin/skycoin-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skycoin/skycoin-web/teams","hooks_url":"https://api.github.com/repos/skycoin/skycoin-web/hooks","issue_events_url":"https://api.github.com/repos/skycoin/skycoin-web/issues/events{/number}","events_url":"https://api.github.com/repos/skycoin/skycoin-web/events","assignees_url":"https://api.github.com/repos/skycoin/skycoin-web/assignees{/user}","branches_url":"https://api.github.com/repos/skycoin/skycoin-web/branches{/branch}","tags_url":"https://api.github.com/repos/skycoin/skycoin-web/tags","blobs_url":"https://api.github.com/repos/skycoin/skycoin-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skycoin/skycoin-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skycoin/skycoin-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/skycoin/skycoin-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skycoin/skycoin-web/statuses/{sha}","languages_url":"https://api.github.com/repos/skycoin/skycoin-web/languages","stargazers_url":"https://api.github.com/repos/skycoin/skycoin-web/stargazers","contributors_url":"https://api.github.com/repos/skycoin/skycoin-web/contributors","subscribers_url":"https://api.github.com/repos/skycoin/skycoin-web/subscribers","subscription_url":"https://api.github.com/repos/skycoin/skycoin-web/subscription","commits_url":"https://api.github.com/repos/skycoin/skycoin-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/skycoin/skycoin-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/skycoin/skycoin-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/skycoin/skycoin-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/skycoin/skycoin-web/contents/{+path}","compare_url":"https://api.github.com/repos/skycoin/skycoin-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skycoin/skycoin-web/merges","archive_url":"https://api.github.com/repos/skycoin/skycoin-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skycoin/skycoin-web/downloads","issues_url":"https://api.github.com/repos/skycoin/skycoin-web/issues{/number}","pulls_url":"https://api.github.com/repos/skycoin/skycoin-web/pulls{/number}","milestones_url":"https://api.github.com/repos/skycoin/skycoin-web/milestones{/number}","notifications_url":"https://api.github.com/repos/skycoin/skycoin-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skycoin/skycoin-web/labels{/name}","releases_url":"https://api.github.com/repos/skycoin/skycoin-web/releases{/id}","deployments_url":"https://api.github.com/repos/skycoin/skycoin-web/deployments","created_at":"2017-11-19T20:21:12Z","updated_at":"2018-05-29T02:36:52Z","pushed_at":"2018-05-29T13:24:15Z","git_url":"git://github.com/skycoin/skycoin-web.git","ssh_url":"git@github.com:skycoin/skycoin-web.git","clone_url":"https://github.com/skycoin/skycoin-web.git","svn_url":"https://github.com/skycoin/skycoin-web","homepage":"https://wallet.skycoin.net","size":4545,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":21,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180"},"html":{"href":"https://github.com/skycoin/skycoin-web/pull/180"},"issue":{"href":"https://api.github.com/repos/skycoin/skycoin-web/issues/180"},"comments":{"href":"https://api.github.com/repos/skycoin/skycoin-web/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skycoin/skycoin-web/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/skycoin/skycoin-web/statuses/3ebe80805f86beaa5118afa7122486fdbcf8458b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Senyoret1"}}