{"action":"created","issue":{"url":"https://api.github.com/repos/docker/cli/issues/1355","repository_url":"https://api.github.com/repos/docker/cli","labels_url":"https://api.github.com/repos/docker/cli/issues/1355/labels{/name}","comments_url":"https://api.github.com/repos/docker/cli/issues/1355/comments","events_url":"https://api.github.com/repos/docker/cli/issues/1355/events","html_url":"https://github.com/docker/cli/pull/1355","id":358252981,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDcwNDkz","number":1355,"title":"Drop experimental tag for manifest commands","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"labels":[{"id":585916070,"node_id":"MDU6TGFiZWw1ODU5MTYwNzA=","url":"https://api.github.com/repos/docker/cli/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-08T01:38:11Z","updated_at":"2018-09-11T15:34:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/1355","html_url":"https://github.com/docker/cli/pull/1355","diff_url":"https://github.com/docker/cli/pull/1355.diff","patch_url":"https://github.com/docker/cli/pull/1355.patch"},"body":"Signed-off-by: Davanum Srinivas davanum@gmail.com\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/cli/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\nSome of us working on Kubernetes have been using the docker manifest\r\nexperimental commands to build images for some time now. The last\r\nproblem we had was fixed by one of the commits a few months ago:\r\nhttps://github.com/docker/cli/commit/69e1743e3d05e487ad8fc6d665b75f5b5d28b76c\r\n\r\nCould we please promote these commands from experimental to GA\r\n\r\n**- How I did it**\r\n\r\nDelete the annotation for the command that sets it to experimental\r\n\r\n**- How to verify it**\r\n\r\nJust run `docker manifest` commands without the config.json or environment flag for experimental mode\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\ndocker manifest commands are now no longer considered experimental and available for general use\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n![2282173](https://user-images.githubusercontent.com/23304/45248973-47b3fb80-b2e6-11e8-8fe0-f68dbdf842fd.jpg)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/cli/issues/comments/420317215","html_url":"https://github.com/docker/cli/pull/1355#issuecomment-420317215","issue_url":"https://api.github.com/repos/docker/cli/issues/1355","id":420317215,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDMxNzIxNQ==","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T15:34:37Z","updated_at":"2018-09-11T15:34:37Z","author_association":"NONE","body":"@ijc \r\n- for #910 - this PR does not ask to promote the trust sign, just the manifest create/annotate/push/... So we can leave the trust one as experimental until #910 gets fixed.\r\n- for #1358 - i believe it is the same that we faced in https://github.com/docker/for-linux/issues/396 and i have a patch up in https://github.com/moby/moby/pull/37619\r\n"}}
{"actor":{"display_login":"dims"}}