{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2","id":215983049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTgzMDQ5","html_url":"https://github.com/mirrorweb/pywb-2/pull/2","diff_url":"https://github.com/mirrorweb/pywb-2/pull/2.diff","patch_url":"https://github.com/mirrorweb/pywb-2/pull/2.patch","issue_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/2","number":2,"state":"closed","locked":false,"title":"Fixed revisits bug where preexisting cdx revisit fields overwritten with blanks","user":{"login":"KarlXerri","id":4490726,"node_id":"MDQ6VXNlcjQ0OTA3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4490726?v=4","gravatar_id":"","url":"https://api.github.com/users/KarlXerri","html_url":"https://github.com/KarlXerri","followers_url":"https://api.github.com/users/KarlXerri/followers","following_url":"https://api.github.com/users/KarlXerri/following{/other_user}","gists_url":"https://api.github.com/users/KarlXerri/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlXerri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlXerri/subscriptions","organizations_url":"https://api.github.com/users/KarlXerri/orgs","repos_url":"https://api.github.com/users/KarlXerri/repos","events_url":"https://api.github.com/users/KarlXerri/events{/privacy}","received_events_url":"https://api.github.com/users/KarlXerri/received_events","type":"User","site_admin":false},"body":"## Description\r\nIf you use CDX11+3 format (which includes the three revisit resolved fields), the values are overwritten with 3 dashes if the revisit can't be resolved in the context of the current query.  This hot fix checks for the presence of the 3 revisit fields before attempting to resolve.  If they already exist, we yield the row unaltered.\r\n\r\n## Motivation and Context\r\nCDX11+3 format orig fields don't need to be resolved.  We can return these rows as-is to avoid two possible side affects: 1. Unnecessary overhead in trying to resolve the originals on-the-fly. 2. Unmatched CDX resolutions (for any reason out of the context of the current CDX query set) result in the values being stripped.\r\n\r\n## Types of changes\r\n- [x] Replay fix (fixes a replay specific issue)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)","created_at":"2018-09-17T13:32:33Z","updated_at":"2018-09-25T16:54:11Z","closed_at":"2018-09-25T16:54:11Z","merged_at":"2018-09-25T16:54:11Z","merge_commit_sha":"09fa21d213f11acd17b69cecfa6e5811cc69e9e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/2/comments","statuses_url":"https://api.github.com/repos/mirrorweb/pywb-2/statuses/4ad007c2777651cb9cfde0406e1bd627cb1a0710","head":{"label":"mirrorweb:hotfix/cdx_revisits","ref":"hotfix/cdx_revisits","sha":"4ad007c2777651cb9cfde0406e1bd627cb1a0710","user":{"login":"mirrorweb","id":27081769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDgxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/27081769?v=4","gravatar_id":"","url":"https://api.github.com/users/mirrorweb","html_url":"https://github.com/mirrorweb","followers_url":"https://api.github.com/users/mirrorweb/followers","following_url":"https://api.github.com/users/mirrorweb/following{/other_user}","gists_url":"https://api.github.com/users/mirrorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mirrorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirrorweb/subscriptions","organizations_url":"https://api.github.com/users/mirrorweb/orgs","repos_url":"https://api.github.com/users/mirrorweb/repos","events_url":"https://api.github.com/users/mirrorweb/events{/privacy}","received_events_url":"https://api.github.com/users/mirrorweb/received_events","type":"Organization","site_admin":false},"repo":{"id":137864958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4NjQ5NTg=","name":"pywb-2","full_name":"mirrorweb/pywb-2","private":false,"owner":{"login":"mirrorweb","id":27081769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDgxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/27081769?v=4","gravatar_id":"","url":"https://api.github.com/users/mirrorweb","html_url":"https://github.com/mirrorweb","followers_url":"https://api.github.com/users/mirrorweb/followers","following_url":"https://api.github.com/users/mirrorweb/following{/other_user}","gists_url":"https://api.github.com/users/mirrorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mirrorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirrorweb/subscriptions","organizations_url":"https://api.github.com/users/mirrorweb/orgs","repos_url":"https://api.github.com/users/mirrorweb/repos","events_url":"https://api.github.com/users/mirrorweb/events{/privacy}","received_events_url":"https://api.github.com/users/mirrorweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mirrorweb/pywb-2","description":"Core Python Web Archiving Toolkit for replay and recording of web archives","fork":true,"url":"https://api.github.com/repos/mirrorweb/pywb-2","forks_url":"https://api.github.com/repos/mirrorweb/pywb-2/forks","keys_url":"https://api.github.com/repos/mirrorweb/pywb-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirrorweb/pywb-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirrorweb/pywb-2/teams","hooks_url":"https://api.github.com/repos/mirrorweb/pywb-2/hooks","issue_events_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/events{/number}","events_url":"https://api.github.com/repos/mirrorweb/pywb-2/events","assignees_url":"https://api.github.com/repos/mirrorweb/pywb-2/assignees{/user}","branches_url":"https://api.github.com/repos/mirrorweb/pywb-2/branches{/branch}","tags_url":"https://api.github.com/repos/mirrorweb/pywb-2/tags","blobs_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirrorweb/pywb-2/statuses/{sha}","languages_url":"https://api.github.com/repos/mirrorweb/pywb-2/languages","stargazers_url":"https://api.github.com/repos/mirrorweb/pywb-2/stargazers","contributors_url":"https://api.github.com/repos/mirrorweb/pywb-2/contributors","subscribers_url":"https://api.github.com/repos/mirrorweb/pywb-2/subscribers","subscription_url":"https://api.github.com/repos/mirrorweb/pywb-2/subscription","commits_url":"https://api.github.com/repos/mirrorweb/pywb-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirrorweb/pywb-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirrorweb/pywb-2/contents/{+path}","compare_url":"https://api.github.com/repos/mirrorweb/pywb-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirrorweb/pywb-2/merges","archive_url":"https://api.github.com/repos/mirrorweb/pywb-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirrorweb/pywb-2/downloads","issues_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues{/number}","pulls_url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls{/number}","milestones_url":"https://api.github.com/repos/mirrorweb/pywb-2/milestones{/number}","notifications_url":"https://api.github.com/repos/mirrorweb/pywb-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirrorweb/pywb-2/labels{/name}","releases_url":"https://api.github.com/repos/mirrorweb/pywb-2/releases{/id}","deployments_url":"https://api.github.com/repos/mirrorweb/pywb-2/deployments","created_at":"2018-06-19T08:48:52Z","updated_at":"2018-07-30T12:01:10Z","pushed_at":"2018-09-25T16:54:12Z","git_url":"git://github.com/mirrorweb/pywb-2.git","ssh_url":"git@github.com:mirrorweb/pywb-2.git","clone_url":"https://github.com/mirrorweb/pywb-2.git","svn_url":"https://github.com/mirrorweb/pywb-2","homepage":"https://pypi.python.org/pypi/pywb","size":6258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirrorweb:master","ref":"master","sha":"7bcc731d0e1ac82bf8170bf7a1f6541b0a515f4e","user":{"login":"mirrorweb","id":27081769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDgxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/27081769?v=4","gravatar_id":"","url":"https://api.github.com/users/mirrorweb","html_url":"https://github.com/mirrorweb","followers_url":"https://api.github.com/users/mirrorweb/followers","following_url":"https://api.github.com/users/mirrorweb/following{/other_user}","gists_url":"https://api.github.com/users/mirrorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mirrorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirrorweb/subscriptions","organizations_url":"https://api.github.com/users/mirrorweb/orgs","repos_url":"https://api.github.com/users/mirrorweb/repos","events_url":"https://api.github.com/users/mirrorweb/events{/privacy}","received_events_url":"https://api.github.com/users/mirrorweb/received_events","type":"Organization","site_admin":false},"repo":{"id":137864958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4NjQ5NTg=","name":"pywb-2","full_name":"mirrorweb/pywb-2","private":false,"owner":{"login":"mirrorweb","id":27081769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDgxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/27081769?v=4","gravatar_id":"","url":"https://api.github.com/users/mirrorweb","html_url":"https://github.com/mirrorweb","followers_url":"https://api.github.com/users/mirrorweb/followers","following_url":"https://api.github.com/users/mirrorweb/following{/other_user}","gists_url":"https://api.github.com/users/mirrorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mirrorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirrorweb/subscriptions","organizations_url":"https://api.github.com/users/mirrorweb/orgs","repos_url":"https://api.github.com/users/mirrorweb/repos","events_url":"https://api.github.com/users/mirrorweb/events{/privacy}","received_events_url":"https://api.github.com/users/mirrorweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mirrorweb/pywb-2","description":"Core Python Web Archiving Toolkit for replay and recording of web archives","fork":true,"url":"https://api.github.com/repos/mirrorweb/pywb-2","forks_url":"https://api.github.com/repos/mirrorweb/pywb-2/forks","keys_url":"https://api.github.com/repos/mirrorweb/pywb-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirrorweb/pywb-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirrorweb/pywb-2/teams","hooks_url":"https://api.github.com/repos/mirrorweb/pywb-2/hooks","issue_events_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/events{/number}","events_url":"https://api.github.com/repos/mirrorweb/pywb-2/events","assignees_url":"https://api.github.com/repos/mirrorweb/pywb-2/assignees{/user}","branches_url":"https://api.github.com/repos/mirrorweb/pywb-2/branches{/branch}","tags_url":"https://api.github.com/repos/mirrorweb/pywb-2/tags","blobs_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirrorweb/pywb-2/statuses/{sha}","languages_url":"https://api.github.com/repos/mirrorweb/pywb-2/languages","stargazers_url":"https://api.github.com/repos/mirrorweb/pywb-2/stargazers","contributors_url":"https://api.github.com/repos/mirrorweb/pywb-2/contributors","subscribers_url":"https://api.github.com/repos/mirrorweb/pywb-2/subscribers","subscription_url":"https://api.github.com/repos/mirrorweb/pywb-2/subscription","commits_url":"https://api.github.com/repos/mirrorweb/pywb-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirrorweb/pywb-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirrorweb/pywb-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirrorweb/pywb-2/contents/{+path}","compare_url":"https://api.github.com/repos/mirrorweb/pywb-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirrorweb/pywb-2/merges","archive_url":"https://api.github.com/repos/mirrorweb/pywb-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirrorweb/pywb-2/downloads","issues_url":"https://api.github.com/repos/mirrorweb/pywb-2/issues{/number}","pulls_url":"https://api.github.com/repos/mirrorweb/pywb-2/pulls{/number}","milestones_url":"https://api.github.com/repos/mirrorweb/pywb-2/milestones{/number}","notifications_url":"https://api.github.com/repos/mirrorweb/pywb-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirrorweb/pywb-2/labels{/name}","releases_url":"https://api.github.com/repos/mirrorweb/pywb-2/releases{/id}","deployments_url":"https://api.github.com/repos/mirrorweb/pywb-2/deployments","created_at":"2018-06-19T08:48:52Z","updated_at":"2018-07-30T12:01:10Z","pushed_at":"2018-09-25T16:54:12Z","git_url":"git://github.com/mirrorweb/pywb-2.git","ssh_url":"git@github.com:mirrorweb/pywb-2.git","clone_url":"https://github.com/mirrorweb/pywb-2.git","svn_url":"https://github.com/mirrorweb/pywb-2","homepage":"https://pypi.python.org/pypi/pywb","size":6258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2"},"html":{"href":"https://github.com/mirrorweb/pywb-2/pull/2"},"issue":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/issues/2"},"comments":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mirrorweb/pywb-2/statuses/4ad007c2777651cb9cfde0406e1bd627cb1a0710"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"KarlXerri","id":4490726,"node_id":"MDQ6VXNlcjQ0OTA3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4490726?v=4","gravatar_id":"","url":"https://api.github.com/users/KarlXerri","html_url":"https://github.com/KarlXerri","followers_url":"https://api.github.com/users/KarlXerri/followers","following_url":"https://api.github.com/users/KarlXerri/following{/other_user}","gists_url":"https://api.github.com/users/KarlXerri/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlXerri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlXerri/subscriptions","organizations_url":"https://api.github.com/users/KarlXerri/orgs","repos_url":"https://api.github.com/users/KarlXerri/repos","events_url":"https://api.github.com/users/KarlXerri/events{/privacy}","received_events_url":"https://api.github.com/users/KarlXerri/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"KarlXerri"}}