{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44302","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44302/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44302/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44302/events","html_url":"https://github.com/NixOS/nixpkgs/pull/44302","id":346566844,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mzk5NTIz","number":44302,"title":"plasma-nm: fix path to mobile broadband provider file","user":{"login":"Yarny0","id":41838844,"node_id":"MDQ6VXNlcjQxODM4ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/41838844?v=4","gravatar_id":"","url":"https://api.github.com/users/Yarny0","html_url":"https://github.com/Yarny0","followers_url":"https://api.github.com/users/Yarny0/followers","following_url":"https://api.github.com/users/Yarny0/following{/other_user}","gists_url":"https://api.github.com/users/Yarny0/gists{/gist_id}","starred_url":"https://api.github.com/users/Yarny0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yarny0/subscriptions","organizations_url":"https://api.github.com/users/Yarny0/orgs","repos_url":"https://api.github.com/users/Yarny0/repos","events_url":"https://api.github.com/users/Yarny0/events{/privacy}","received_events_url":"https://api.github.com/users/Yarny0/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":137715073,"node_id":"MDU6TGFiZWwxMzc3MTUwNzM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20qt/kde","name":"6.topic: qt/kde","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-01T11:52:00Z","updated_at":"2018-08-01T12:52:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44302","html_url":"https://github.com/NixOS/nixpkgs/pull/44302","diff_url":"https://github.com/NixOS/nixpkgs/pull/44302.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44302.patch"},"body":"When creating a new mobile broadband connection\r\nwith the plasma network manager connection editor,\r\nit tries to find a file containing provider\r\ninformation somewhere in /usr/share/... .\r\nThe build recipe contains a patch to fix the lookup path\r\nsuch that it finds the file in the corresponding package,\r\nprobably added due to\r\nhttps://github.com/NixOS/nixpkgs/issues/9389 .\r\nThe actual lookup path is injected into\r\nthe patch file with substituteAll.\r\n\r\nWith commit a31d98f3120e0f676303b7fc3e84424e6b325290 ,\r\nthe variable name used in subsituteAll changed from\r\nmobile_broadband_provider_info to mobile-broadband-provider-info\r\n(underscores in package names turned into dashes).\r\nApparently, substituteAll can't handle dashes in variable names.\r\nConsequently, the variable name was no longer resolved.\r\nplasma-nm failed to create new mobile broadband connections;\r\nthe connection creator silently exited and logged the error\r\n> plasma-nm: Error opening providers file \"@mobile-broadband-provider-info@/share/mobile-broadband-provider-info/serviceproviders.xml\"\r\n\r\nThis commit keeps the dashes in package names, but it\r\nrestores the underscores in the variable used by substituteAll,\r\nthereby ensuring the variable gets resolved properly.\r\n\r\n###### Motivation for this change\r\n\r\nRestore ability to create mobile broadband connections with the plasma network manager frontend.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS: on 18.03\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`): there are none\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\ncc @ttuegel (sorry, you are the last one who touched this according to git log ... there is no maintainer given in the build recipe)"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/409563914","html_url":"https://github.com/NixOS/nixpkgs/pull/44302#issuecomment-409563914","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44302","id":409563914,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTU2MzkxNA==","user":{"login":"xeji","id":36407913,"node_id":"MDQ6VXNlcjM2NDA3OTEz","avatar_url":"https://avatars2.githubusercontent.com/u/36407913?v=4","gravatar_id":"","url":"https://api.github.com/users/xeji","html_url":"https://github.com/xeji","followers_url":"https://api.github.com/users/xeji/followers","following_url":"https://api.github.com/users/xeji/following{/other_user}","gists_url":"https://api.github.com/users/xeji/gists{/gist_id}","starred_url":"https://api.github.com/users/xeji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeji/subscriptions","organizations_url":"https://api.github.com/users/xeji/orgs","repos_url":"https://api.github.com/users/xeji/repos","events_url":"https://api.github.com/users/xeji/events{/privacy}","received_events_url":"https://api.github.com/users/xeji/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T12:52:26Z","updated_at":"2018-08-01T12:52:26Z","author_association":"CONTRIBUTOR","body":"@GrahamcOfBorg build plasma-nm"}}
{"actor":{"display_login":"xeji"}}