{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/213943986","pull_request_review_id":150886765,"id":213943986,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk0Mzk4Ng==","diff_hunk":"@@ -3603,6 +3616,11 @@ else if ( getPluralAttributeSource().getElementSource() instanceof PluralAttribu\n \n \t\t\t\t);\n \t\t\t\tgetCollectionBinding().setElement( elementBinding );\n+\t\t\t\t// Collection#setWhere is used to set the \"where\" clause that applies to the collection table\n+\t\t\t\t// (which is the join table for a many-to-any association).\n+\t\t\t\t// This \"where\" clause comes from the collection mapping; e.g., <set name=\"...\" ... where=\"...\" .../>\n+\t\t\t\tgetCollectionBinding().setWhere( getPluralAttributeSource().getWhere() );\n+\t\t\t\tgetCollectionBinding().setWhere( getPluralAttributeSource().getWhere() );","path":"hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/ModelBinder.java","position":42,"original_position":42,"commit_id":"482cfd8c95c12ff3ae0a0c5012c183e3d6823ef5","original_commit_id":"482cfd8c95c12ff3ae0a0c5012c183e3d6823ef5","user":{"login":"gsmet","id":1279749,"node_id":"MDQ6VXNlcjEyNzk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"This line is duplicated.","created_at":"2018-08-30T08:27:56Z","updated_at":"2018-08-30T08:28:33Z","html_url":"https://github.com/hibernate/hibernate-orm/pull/2510#discussion_r213943986","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/213943986"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2510#discussion_r213943986"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510","id":211972011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTcyMDEx","html_url":"https://github.com/hibernate/hibernate-orm/pull/2510","diff_url":"https://github.com/hibernate/hibernate-orm/pull/2510.diff","patch_url":"https://github.com/hibernate/hibernate-orm/pull/2510.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2510","number":2510,"state":"open","locked":false,"title":"HHH-12937 : Where clause for collections of basic, embeddable and \"any\" elements is ignored when mapped using hbm.xml","user":{"login":"gbadner","id":431309,"node_id":"MDQ6VXNlcjQzMTMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/431309?v=4","gravatar_id":"","url":"https://api.github.com/users/gbadner","html_url":"https://github.com/gbadner","followers_url":"https://api.github.com/users/gbadner/followers","following_url":"https://api.github.com/users/gbadner/following{/other_user}","gists_url":"https://api.github.com/users/gbadner/gists{/gist_id}","starred_url":"https://api.github.com/users/gbadner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbadner/subscriptions","organizations_url":"https://api.github.com/users/gbadner/orgs","repos_url":"https://api.github.com/users/gbadner/repos","events_url":"https://api.github.com/users/gbadner/events{/privacy}","received_events_url":"https://api.github.com/users/gbadner/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/HHH-12937","created_at":"2018-08-30T06:46:21Z","updated_at":"2018-08-30T08:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146d949903c091ed92e2738f0068a3e18e060b36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2510/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/482cfd8c95c12ff3ae0a0c5012c183e3d6823ef5","head":{"label":"gbadner:HHH-12937","ref":"HHH-12937","sha":"482cfd8c95c12ff3ae0a0c5012c183e3d6823ef5","user":{"login":"gbadner","id":431309,"node_id":"MDQ6VXNlcjQzMTMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/431309?v=4","gravatar_id":"","url":"https://api.github.com/users/gbadner","html_url":"https://github.com/gbadner","followers_url":"https://api.github.com/users/gbadner/followers","following_url":"https://api.github.com/users/gbadner/following{/other_user}","gists_url":"https://api.github.com/users/gbadner/gists{/gist_id}","starred_url":"https://api.github.com/users/gbadner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbadner/subscriptions","organizations_url":"https://api.github.com/users/gbadner/orgs","repos_url":"https://api.github.com/users/gbadner/repos","events_url":"https://api.github.com/users/gbadner/events{/privacy}","received_events_url":"https://api.github.com/users/gbadner/received_events","type":"User","site_admin":false},"repo":{"id":970048,"node_id":"MDEwOlJlcG9zaXRvcnk5NzAwNDg=","name":"hibernate-core","full_name":"gbadner/hibernate-core","owner":{"login":"gbadner","id":431309,"node_id":"MDQ6VXNlcjQzMTMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/431309?v=4","gravatar_id":"","url":"https://api.github.com/users/gbadner","html_url":"https://github.com/gbadner","followers_url":"https://api.github.com/users/gbadner/followers","following_url":"https://api.github.com/users/gbadner/following{/other_user}","gists_url":"https://api.github.com/users/gbadner/gists{/gist_id}","starred_url":"https://api.github.com/users/gbadner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbadner/subscriptions","organizations_url":"https://api.github.com/users/gbadner/orgs","repos_url":"https://api.github.com/users/gbadner/repos","events_url":"https://api.github.com/users/gbadner/events{/privacy}","received_events_url":"https://api.github.com/users/gbadner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbadner/hibernate-core","description":"Hibernate Core: Object Relational Mapper (ORM). Source code starting from 3.6 and upwards","fork":true,"url":"https://api.github.com/repos/gbadner/hibernate-core","forks_url":"https://api.github.com/repos/gbadner/hibernate-core/forks","keys_url":"https://api.github.com/repos/gbadner/hibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbadner/hibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbadner/hibernate-core/teams","hooks_url":"https://api.github.com/repos/gbadner/hibernate-core/hooks","issue_events_url":"https://api.github.com/repos/gbadner/hibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/gbadner/hibernate-core/events","assignees_url":"https://api.github.com/repos/gbadner/hibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/gbadner/hibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/gbadner/hibernate-core/tags","blobs_url":"https://api.github.com/repos/gbadner/hibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbadner/hibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbadner/hibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbadner/hibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbadner/hibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gbadner/hibernate-core/languages","stargazers_url":"https://api.github.com/repos/gbadner/hibernate-core/stargazers","contributors_url":"https://api.github.com/repos/gbadner/hibernate-core/contributors","subscribers_url":"https://api.github.com/repos/gbadner/hibernate-core/subscribers","subscription_url":"https://api.github.com/repos/gbadner/hibernate-core/subscription","commits_url":"https://api.github.com/repos/gbadner/hibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbadner/hibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbadner/hibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbadner/hibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbadner/hibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/gbadner/hibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbadner/hibernate-core/merges","archive_url":"https://api.github.com/repos/gbadner/hibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbadner/hibernate-core/downloads","issues_url":"https://api.github.com/repos/gbadner/hibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/gbadner/hibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gbadner/hibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gbadner/hibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbadner/hibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/gbadner/hibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/gbadner/hibernate-core/deployments","created_at":"2010-10-07T18:06:15Z","updated_at":"2014-06-25T07:18:57Z","pushed_at":"2018-08-30T06:44:21Z","git_url":"git://github.com/gbadner/hibernate-core.git","ssh_url":"git@github.com:gbadner/hibernate-core.git","clone_url":"https://github.com/gbadner/hibernate-core.git","svn_url":"https://github.com/gbadner/hibernate-core","homepage":"http://hibernate.org","size":151627,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.6"}},"base":{"label":"hibernate:master","ref":"master","sha":"4c5ab83756112a68d7b0089b0875d55877179a5c","user":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":961036,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEwMzY=","name":"hibernate-orm","full_name":"hibernate/hibernate-orm","owner":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-orm","forks_url":"https://api.github.com/repos/hibernate/hibernate-orm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-orm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-orm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-orm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-orm/deployments","created_at":"2010-10-04T16:15:52Z","updated_at":"2018-08-30T07:15:23Z","pushed_at":"2018-08-30T06:46:22Z","git_url":"git://github.com/hibernate/hibernate-orm.git","ssh_url":"git@github.com:hibernate/hibernate-orm.git","clone_url":"https://github.com/hibernate/hibernate-orm.git","svn_url":"https://github.com/hibernate/hibernate-orm","homepage":"http://hibernate.org","size":160000,"stargazers_count":3349,"watchers_count":3349,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2277,"mirror_url":null,"archived":false,"open_issues_count":102,"license":null,"forks":2277,"open_issues":102,"watchers":3349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2510"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2510"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2510/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2510/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/482cfd8c95c12ff3ae0a0c5012c183e3d6823ef5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gsmet"}}