{"push_id":2834531053,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"33c1db4b683603dd7e7392b62a516ed8265bda23","before":"2ee29f38ce955aff07a5025fde296b5fea1a967f","commits":[{"sha":"33c1db4b683603dd7e7392b62a516ed8265bda23","author":{"name":"Rolf Bjarne Kvinge","email":"77aa1026e89be0ca81722a3920e4a32c7960775f@xamarin.com"},"message":"Store the minimum mono version for Xamarin.Mac in one place only (Make.config) and bump it to 5.14. Fixes #4120. (#4695)\n\n* Store the minimum mono version for Xamarin.Mac in one place only (Make.config) and bump it to 5.14. Fixes #4120.\r\n\r\nI've verified that we fail at launch of running on 5.12, while 5.14 works fine\r\n(to launch at least), so the minimum system mono version is _at least_ 5.14.\r\n\r\nFixes https://github.com/xamarin/xamarin-macios/issues/4120.\r\n\r\n* [mmp] Load mono's version file instead of using pkg-config to get mono's version.\r\n\r\npkg-config will only get three parts of the version, while the version file\r\nhas all four parts.\r\n\r\nThis is important, since we're now verifying the four parts of the version\r\nfile, and without loading those four from the system, we'll fail builds like\r\nthis:\r\n\r\n    error MM0001: This version of Xamarin.Mac requires Mono 5.14.0.136 (the current Mono version is 5.14.0).\r\n\r\nbecause the three part version's fourth number is assumed to be 0.\r\n\r\n* Only verify mono runtime version when running with system/dynamic mono.\r\n\r\nThere should be no need to verify the mono runtime version when embedding mono:\r\n\r\n* If it's a mono we're shipping, something very bad happened in our\r\n  build/package for it to be an invalid mono.\r\n* If it's a system mono that's being embedded, then we verify in mmp at build\r\n  time.\r\n\r\nIn the first scenario (a mono we're shipping), the problem is that the mono\r\nwe've built does not report back the full version number (with four parts) [1],\r\nwhich means we'll fail any check whose requirements are identical for the\r\nfirst three parts, and non-zero for the last.\r\n\r\n[1] The fourth part of the version number is created/calculated when packaging\r\nmono, and we're not packaging it.","distinct":true,"url":"https://api.github.com/repos/xamarin/xamarin-macios/commits/33c1db4b683603dd7e7392b62a516ed8265bda23"}]}
{"actor":{"display_login":"rolfbjarne"}}