{"action":"opened","number":671,"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/671","id":204192153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTkyMTUz","html_url":"https://github.com/openzfs/openzfs/pull/671","diff_url":"https://github.com/openzfs/openzfs/pull/671.diff","patch_url":"https://github.com/openzfs/openzfs/pull/671.patch","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/671","number":671,"state":"open","locked":false,"title":"9677 panic from zio_write_gang_block() when creating dump device on f…","user":{"login":"brad-lewis","id":23324684,"node_id":"MDQ6VXNlcjIzMzI0Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/23324684?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-lewis","html_url":"https://github.com/brad-lewis","followers_url":"https://api.github.com/users/brad-lewis/followers","following_url":"https://api.github.com/users/brad-lewis/following{/other_user}","gists_url":"https://api.github.com/users/brad-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-lewis/subscriptions","organizations_url":"https://api.github.com/users/brad-lewis/orgs","repos_url":"https://api.github.com/users/brad-lewis/repos","events_url":"https://api.github.com/users/brad-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/brad-lewis/received_events","type":"User","site_admin":false},"body":"…ragmented rpool\r\n\r\nReviewed by: Matt Ahrens <matt@delphix.com>\r\nReviewed by: George Wilson <george.wilson@delphix.com>\r\nReviewed by: Prashanth Sreenivasa <pks@delphix.com>\r\n\r\nWhen the amount of memory in the system changes, we automatically increase the size of the dump device.\r\nThe dump device is allocated with ZIO_FLAG_NODATA, so that we just allocate the space and don't write\r\nto it (yet - we'll write when the system dumps). If the rpool is fragmented, then we may end up trying\r\nto create gang blocks for the dump device. What should happen is that we allocate the gang blocks, and\r\nthen the zvol_dumpify() code will notice that there are gang blocks in the dump device, and fail to\r\nactivate it for dump (since we don't have code to support this).\r\n\r\nHowever, when we create the gang block for the dump device (with ZIO_FLAG_NODATA), we get a panic from\r\nzio_write_gang_block(), because pio->io_abd is NULL. It should be fine for this to be NULL, since we have\r\nZIO_FLAG_NODATA we should not be touching it. However, with the ABD changes we are now doing\r\n\"abd_get_offset(pio->io_abd, ...)\" which will panic since the io_abd is NULL.\r\n\r\nThe solution is for zio_write_gang_block() to pass a NULL abd to zio_write() instead of calling\r\nabd_get_offset(pio->io_abd == NULL), when ZIO_FLAG_NODATA is set.\r\n\r\nUpstream bug: DLPX-57429","created_at":"2018-07-26T16:05:41Z","updated_at":"2018-07-26T16:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfs/openzfs/pulls/671/commits","review_comments_url":"https://api.github.com/repos/openzfs/openzfs/pulls/671/comments","review_comment_url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/671/comments","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/267a44da3e5be825db5d0ecb977fe812ce136dbc","head":{"label":"brad-lewis:openzfs-DLPX-57429","ref":"openzfs-DLPX-57429","sha":"267a44da3e5be825db5d0ecb977fe812ce136dbc","user":{"login":"brad-lewis","id":23324684,"node_id":"MDQ6VXNlcjIzMzI0Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/23324684?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-lewis","html_url":"https://github.com/brad-lewis","followers_url":"https://api.github.com/users/brad-lewis/followers","following_url":"https://api.github.com/users/brad-lewis/following{/other_user}","gists_url":"https://api.github.com/users/brad-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-lewis/subscriptions","organizations_url":"https://api.github.com/users/brad-lewis/orgs","repos_url":"https://api.github.com/users/brad-lewis/repos","events_url":"https://api.github.com/users/brad-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/brad-lewis/received_events","type":"User","site_admin":false},"repo":{"id":120807917,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4MDc5MTc=","name":"openzfs","full_name":"brad-lewis/openzfs","owner":{"login":"brad-lewis","id":23324684,"node_id":"MDQ6VXNlcjIzMzI0Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/23324684?v=4","gravatar_id":"","url":"https://api.github.com/users/brad-lewis","html_url":"https://github.com/brad-lewis","followers_url":"https://api.github.com/users/brad-lewis/followers","following_url":"https://api.github.com/users/brad-lewis/following{/other_user}","gists_url":"https://api.github.com/users/brad-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-lewis/subscriptions","organizations_url":"https://api.github.com/users/brad-lewis/orgs","repos_url":"https://api.github.com/users/brad-lewis/repos","events_url":"https://api.github.com/users/brad-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/brad-lewis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brad-lewis/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/brad-lewis/openzfs","forks_url":"https://api.github.com/repos/brad-lewis/openzfs/forks","keys_url":"https://api.github.com/repos/brad-lewis/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brad-lewis/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brad-lewis/openzfs/teams","hooks_url":"https://api.github.com/repos/brad-lewis/openzfs/hooks","issue_events_url":"https://api.github.com/repos/brad-lewis/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/brad-lewis/openzfs/events","assignees_url":"https://api.github.com/repos/brad-lewis/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/brad-lewis/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/brad-lewis/openzfs/tags","blobs_url":"https://api.github.com/repos/brad-lewis/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brad-lewis/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brad-lewis/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/brad-lewis/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brad-lewis/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/brad-lewis/openzfs/languages","stargazers_url":"https://api.github.com/repos/brad-lewis/openzfs/stargazers","contributors_url":"https://api.github.com/repos/brad-lewis/openzfs/contributors","subscribers_url":"https://api.github.com/repos/brad-lewis/openzfs/subscribers","subscription_url":"https://api.github.com/repos/brad-lewis/openzfs/subscription","commits_url":"https://api.github.com/repos/brad-lewis/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/brad-lewis/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/brad-lewis/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/brad-lewis/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/brad-lewis/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/brad-lewis/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brad-lewis/openzfs/merges","archive_url":"https://api.github.com/repos/brad-lewis/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brad-lewis/openzfs/downloads","issues_url":"https://api.github.com/repos/brad-lewis/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/brad-lewis/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/brad-lewis/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/brad-lewis/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brad-lewis/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/brad-lewis/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/brad-lewis/openzfs/deployments","created_at":"2018-02-08T19:34:19Z","updated_at":"2018-03-19T22:25:39Z","pushed_at":"2018-07-26T16:04:59Z","git_url":"git://github.com/brad-lewis/openzfs.git","ssh_url":"git@github.com:brad-lewis/openzfs.git","clone_url":"https://github.com/brad-lewis/openzfs.git","svn_url":"https://github.com/brad-lewis/openzfs","homepage":"http://open-zfs.org","size":303433,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfs:master","ref":"master","sha":"ed81aacb0d0fcbf7e0c0745ea4556655050c26bf","user":{"login":"openzfs","id":4510897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTA4OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4510897?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"repo":{"id":44220580,"node_id":"MDEwOlJlcG9zaXRvcnk0NDIyMDU4MA==","name":"openzfs","full_name":"openzfs/openzfs","owner":{"login":"openzfs","id":4510897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTA4OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4510897?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfs/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/openzfs/openzfs","forks_url":"https://api.github.com/repos/openzfs/openzfs/forks","keys_url":"https://api.github.com/repos/openzfs/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfs/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfs/openzfs/teams","hooks_url":"https://api.github.com/repos/openzfs/openzfs/hooks","issue_events_url":"https://api.github.com/repos/openzfs/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfs/openzfs/events","assignees_url":"https://api.github.com/repos/openzfs/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfs/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfs/openzfs/tags","blobs_url":"https://api.github.com/repos/openzfs/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfs/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfs/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfs/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfs/openzfs/languages","stargazers_url":"https://api.github.com/repos/openzfs/openzfs/stargazers","contributors_url":"https://api.github.com/repos/openzfs/openzfs/contributors","subscribers_url":"https://api.github.com/repos/openzfs/openzfs/subscribers","subscription_url":"https://api.github.com/repos/openzfs/openzfs/subscription","commits_url":"https://api.github.com/repos/openzfs/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfs/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfs/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfs/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfs/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfs/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfs/openzfs/merges","archive_url":"https://api.github.com/repos/openzfs/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfs/openzfs/downloads","issues_url":"https://api.github.com/repos/openzfs/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfs/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfs/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfs/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfs/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfs/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/openzfs/openzfs/deployments","created_at":"2015-10-14T03:03:50Z","updated_at":"2018-07-24T22:51:46Z","pushed_at":"2018-07-26T15:53:48Z","git_url":"git://github.com/openzfs/openzfs.git","ssh_url":"git@github.com:openzfs/openzfs.git","clone_url":"https://github.com/openzfs/openzfs.git","svn_url":"https://github.com/openzfs/openzfs","homepage":"http://open-zfs.org","size":303271,"stargazers_count":222,"watchers_count":222,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":65,"open_issues":34,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/671"},"html":{"href":"https://github.com/openzfs/openzfs/pull/671"},"issue":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/671"},"comments":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/openzfs/openzfs/statuses/267a44da3e5be825db5d0ecb977fe812ce136dbc"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":14,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"brad-lewis"}}