{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/213754420","pull_request_review_id":150656068,"id":213754420,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzc1NDQyMA==","diff_hunk":"@@ -95,6 +95,23 @@ func NewTestServer(t testing.TB, opts *ChannelOpts) *TestServer {\n \treturn ts\n }\n \n+// runSubTest runs the specified function as a sub-test of a testing.T or\n+// testing.B if the types match.\n+func runSubTest(t testing.TB, name string, f func(t testing.TB)) {","path":"testutils/test_server.go","position":null,"original_position":6,"commit_id":"bb7ab70af18704da2ca37bd1781b2ce39d611102","original_commit_id":"3cf95221e7ab1454e734b248bfd94fe58cec49e4","user":{"login":"witriew","id":201352,"node_id":"MDQ6VXNlcjIwMTM1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/201352?v=4","gravatar_id":"","url":"https://api.github.com/users/witriew","html_url":"https://github.com/witriew","followers_url":"https://api.github.com/users/witriew/followers","following_url":"https://api.github.com/users/witriew/following{/other_user}","gists_url":"https://api.github.com/users/witriew/gists{/gist_id}","starred_url":"https://api.github.com/users/witriew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witriew/subscriptions","organizations_url":"https://api.github.com/users/witriew/orgs","repos_url":"https://api.github.com/users/witriew/repos","events_url":"https://api.github.com/users/witriew/events{/privacy}","received_events_url":"https://api.github.com/users/witriew/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2018-08-29T16:48:15Z","updated_at":"2018-08-29T16:48:16Z","html_url":"https://github.com/uber/tchannel-go/pull/715#discussion_r213754420","pull_request_url":"https://api.github.com/repos/uber/tchannel-go/pulls/715","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/213754420"},"html":{"href":"https://github.com/uber/tchannel-go/pull/715#discussion_r213754420"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/715"}},"in_reply_to_id":213525663},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/715","id":211577551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTc3NTUx","html_url":"https://github.com/uber/tchannel-go/pull/715","diff_url":"https://github.com/uber/tchannel-go/pull/715.diff","patch_url":"https://github.com/uber/tchannel-go/pull/715.patch","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/715","number":715,"state":"open","locked":false,"title":"Use sub-tests when running test multiple times","user":{"login":"prashantv","id":140159,"node_id":"MDQ6VXNlcjE0MDE1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/140159?v=4","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":"Most tests are run a couple of times, once where clients connect directly to a server, and once where clients connect to servers through a relay.\r\n\r\nUse sub-tests so it's clearer which failed without digging through logs.","created_at":"2018-08-28T22:31:35Z","updated_at":"2018-08-29T16:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8d9982e3d4dcd58b52c939dc8c1a4021ab0973e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-go/pulls/715/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-go/pulls/715/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/715/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/bb7ab70af18704da2ca37bd1781b2ce39d611102","head":{"label":"uber:subtests","ref":"subtests","sha":"bb7ab70af18704da2ca37bd1781b2ce39d611102","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc0MDE0MQ==","name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"Go implementation of a multiplexing and framing protocol for RPC calls","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/tchannel-go/deployments","created_at":"2015-09-18T18:28:15Z","updated_at":"2018-08-23T17:39:35Z","pushed_at":"2018-08-29T16:20:09Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":"http://uber.github.io/tchannel/","size":3017,"stargazers_count":305,"watchers_count":305,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":41,"open_issues":43,"watchers":305,"default_branch":"dev"}},"base":{"label":"uber:dev","ref":"dev","sha":"a11c1247f91077cf0fe76eb425a8a25bf4af50d4","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc0MDE0MQ==","name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"Go implementation of a multiplexing and framing protocol for RPC calls","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/tchannel-go/deployments","created_at":"2015-09-18T18:28:15Z","updated_at":"2018-08-23T17:39:35Z","pushed_at":"2018-08-29T16:20:09Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":"http://uber.github.io/tchannel/","size":3017,"stargazers_count":305,"watchers_count":305,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":41,"open_issues":43,"watchers":305,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/715"},"html":{"href":"https://github.com/uber/tchannel-go/pull/715"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/715"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-go/statuses/bb7ab70af18704da2ca37bd1781b2ce39d611102"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"witriew"}}