{"action":"created","issue":{"url":"https://api.github.com/repos/apache/carbondata/issues/2362","repository_url":"https://api.github.com/repos/apache/carbondata","labels_url":"https://api.github.com/repos/apache/carbondata/issues/2362/labels{/name}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2362/comments","events_url":"https://api.github.com/repos/apache/carbondata/issues/2362/events","html_url":"https://github.com/apache/carbondata/pull/2362","id":329342055,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjE5ODg3","number":2362,"title":"[CARBONDATA-2578] fixed memory leak inside CarbonReader and handled failure case for creation of multi reader for non-transactional table ","user":{"login":"rahulforallp","id":14244942,"node_id":"MDQ6VXNlcjE0MjQ0OTQy","avatar_url":"https://avatars3.githubusercontent.com/u/14244942?v=4","gravatar_id":"","url":"https://api.github.com/users/rahulforallp","html_url":"https://github.com/rahulforallp","followers_url":"https://api.github.com/users/rahulforallp/followers","following_url":"https://api.github.com/users/rahulforallp/following{/other_user}","gists_url":"https://api.github.com/users/rahulforallp/gists{/gist_id}","starred_url":"https://api.github.com/users/rahulforallp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahulforallp/subscriptions","organizations_url":"https://api.github.com/users/rahulforallp/orgs","repos_url":"https://api.github.com/users/rahulforallp/repos","events_url":"https://api.github.com/users/rahulforallp/events{/privacy}","received_events_url":"https://api.github.com/users/rahulforallp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-06-05T07:58:45Z","updated_at":"2018-06-11T16:20:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2362","html_url":"https://github.com/apache/carbondata/pull/2362","diff_url":"https://github.com/apache/carbondata/pull/2362.diff","patch_url":"https://github.com/apache/carbondata/pull/2362.patch"},"body":"**Issue :** \r\n1. CarbonIterator inside CarbonRecordReader was keeping reference of RowBatch and it is not being closed inside CarbonRecordReader.\r\n2. sort_column with measure was considering all the dimension column along with given column.\r\n3. if creation of one CarbonReader for non transactional table is failed then we are not able to create another CarbonReader.\r\n\r\n**Solution :** \r\n1. close() called inside hasNext() to clear the previous iterator before iterating over the next CarbonReader..\r\n2. if sortcolumn is not empty and sortcolumnsList contains the fields check is added to finally in sortcolumn props.\r\n3. Clear the datamap in catch block, if creation of CarbonReader is failed.\r\n\r\n - [x] Any interfaces changed? No\r\n \r\n - [x] Any backward compatibility impacted? No\r\n \r\n - [x] Document update required? No\r\n\r\n - [x] Testing done Yes\r\nTest Step : \r\n1. After closing the carbonReader object took heapDump\r\n2. Observed count of RowBatch object is zero now.\r\n\r\n - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/carbondata/issues/comments/396301092","html_url":"https://github.com/apache/carbondata/pull/2362#issuecomment-396301092","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2362","id":396301092,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjMwMTA5Mg==","user":{"login":"ravipesala","id":8134086,"node_id":"MDQ6VXNlcjgxMzQwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T16:20:02Z","updated_at":"2018-06-11T16:20:02Z","author_association":"CONTRIBUTOR","body":"SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5260/\n"}}
{"actor":{"display_login":"ravipesala"}}