{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/333","repository_url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl","labels_url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/333/labels{/name}","comments_url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/333/comments","events_url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/333/events","html_url":"https://github.com/JuliaDiff/ForwardDiff.jl/pull/333","id":342956717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzM0NDkz","number":333,"title":"Finishing up Project.toml configuration","user":{"login":"tkf","id":29282,"node_id":"MDQ6VXNlcjI5Mjgy","avatar_url":"https://avatars3.githubusercontent.com/u/29282?v=4","gravatar_id":"","url":"https://api.github.com/users/tkf","html_url":"https://github.com/tkf","followers_url":"https://api.github.com/users/tkf/followers","following_url":"https://api.github.com/users/tkf/following{/other_user}","gists_url":"https://api.github.com/users/tkf/gists{/gist_id}","starred_url":"https://api.github.com/users/tkf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkf/subscriptions","organizations_url":"https://api.github.com/users/tkf/orgs","repos_url":"https://api.github.com/users/tkf/repos","events_url":"https://api.github.com/users/tkf/events{/privacy}","received_events_url":"https://api.github.com/users/tkf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-20T03:03:21Z","updated_at":"2018-07-23T17:57:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/pulls/333","html_url":"https://github.com/JuliaDiff/ForwardDiff.jl/pull/333","diff_url":"https://github.com/JuliaDiff/ForwardDiff.jl/pull/333.diff","patch_url":"https://github.com/JuliaDiff/ForwardDiff.jl/pull/333.patch"},"body":"For SIMD tests in https://github.com/JuliaDiff/ForwardDiff.jl/pull/332#issuecomment-406475117 to work, I thought the easiest solution would be to just add `Project.toml` now that `ForwardDiff.jl` dropped 0.6 support in #329.  There are a few things to do finalize Pkg3 support.  I want to keep #332 simple so I thought to make a new PR on top of it.\r\n\r\nHere are a few TODOs:\r\n\r\n* [x] Add compatibility version numbers in `[compat]` section.\r\n* [ ] Decide what to put in `version`. I go ahead and put `version = \"0.8.0\"`.  Is that OK?\r\n* [ ] Add `authors` in `Project.toml`.  I'm totally new to this project so I don't want to be the one to add it :smile:  Please feel free to edit/extend this PR and finishing it.\r\n- [x] Maybe stop using `Pkg.clone` in AppVeyor too?  <strike>But I've got this error and I don't know what happened https://ci.appveyor.com/project/jrevels/forwarddiff-jl/build/1.0.226 (https://github.com/tkf/ForwardDiff.jl/commit/a415049bf8da6293d0cd8a5ae8039ed798ae79c1)</strike> (Edited: the solution was to set `JULIA_PROJECT=\"@.\"`)\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/comments/407146493","html_url":"https://github.com/JuliaDiff/ForwardDiff.jl/pull/333#issuecomment-407146493","issue_url":"https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/issues/333","id":407146493,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzE0NjQ5Mw==","user":{"login":"tkf","id":29282,"node_id":"MDQ6VXNlcjI5Mjgy","avatar_url":"https://avatars3.githubusercontent.com/u/29282?v=4","gravatar_id":"","url":"https://api.github.com/users/tkf","html_url":"https://github.com/tkf","followers_url":"https://api.github.com/users/tkf/followers","following_url":"https://api.github.com/users/tkf/following{/other_user}","gists_url":"https://api.github.com/users/tkf/gists{/gist_id}","starred_url":"https://api.github.com/users/tkf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkf/subscriptions","organizations_url":"https://api.github.com/users/tkf/orgs","repos_url":"https://api.github.com/users/tkf/repos","events_url":"https://api.github.com/users/tkf/events{/privacy}","received_events_url":"https://api.github.com/users/tkf/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T17:57:30Z","updated_at":"2018-07-23T17:57:30Z","author_association":"CONTRIBUTOR","body":"> it seems like this PR just replaces #332 entirely. Is that correct?\r\n\r\nYes.  This PR extends the branch of #332.  I was thinking to rebase this branch on top of master once #332 was merged but merging this PR directly is also fine.  I can (fast-forward) merge this to #332 if you want to do the review there.\r\n\r\n> Alternatively, you could base this PR against the branch for #332 (tkf:literal_pow) instead of master\r\n\r\nI thought I can do that but it looks like PR goes to my repository instead of here: https://github.com/tkf/ForwardDiff.jl/pull/1\r\n\r\nMy intention was to simplify the review of #332 to include `Project.toml` just enough to make SIMD tests pass.  Also, at first it wasn't clear how to make tests work in AppVeyor (which is resolved now) so I thought it may take sometime to finish up this PR.  I opened a separate PR just for your convenience (not to confuse you :wink:) so please choose whichever you like to review/merge.\r\n\r\nFYI these are the addition in this PR to #332:\r\nhttps://github.com/tkf/ForwardDiff.jl/compare/literal_pow...pkg3\r\n"}}
{"actor":{"display_login":"tkf"}}