{"action":"created","comment":{"url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/comments/207484071","pull_request_review_id":143104890,"id":207484071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ4NDA3MQ==","diff_hunk":"@@ -297,22 +329,27 @@ class ChluIPFS {\n      */\n     async importDID(did, publish, waitForReplication) {\n         await this.waitUntilReady()\n-        return await this.did.import(did, publish, waitForReplication)\n+        return await this.didIpfsHelper.import(did, publish, waitForReplication)\n+    }\n+\n+    async getReviewsWrittenByDID(didId, offset, limit) {\n+        await this.waitUntilReady()\n+        return await this.orbitDb.getReviewsWrittenByDID(didId, offset, limit)","path":"src/ChluIPFS.js","position":101,"original_position":101,"commit_id":"60fb9eae97b95a7bf4afe3cc06b700283e8040dd","original_commit_id":"60fb9eae97b95a7bf4afe3cc06b700283e8040dd","user":{"login":"fazo96","id":2546805,"node_id":"MDQ6VXNlcjI1NDY4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2546805?v=4","gravatar_id":"","url":"https://api.github.com/users/fazo96","html_url":"https://github.com/fazo96","followers_url":"https://api.github.com/users/fazo96/followers","following_url":"https://api.github.com/users/fazo96/following{/other_user}","gists_url":"https://api.github.com/users/fazo96/gists{/gist_id}","starred_url":"https://api.github.com/users/fazo96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fazo96/subscriptions","organizations_url":"https://api.github.com/users/fazo96/orgs","repos_url":"https://api.github.com/users/fazo96/repos","events_url":"https://api.github.com/users/fazo96/events{/privacy}","received_events_url":"https://api.github.com/users/fazo96/received_events","type":"User","site_admin":false},"body":"I think the proper solve here is that the implementation of getReviewsWrittenByDID in the Index will throw saying that this index does not implement it.\r\n\r\nThen, from the wallet or whatever other frontend, we use the api client for this call.","created_at":"2018-08-03T09:01:32Z","updated_at":"2018-08-03T09:01:32Z","html_url":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107#discussion_r207484071","pull_request_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/comments/207484071"},"html":{"href":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107#discussion_r207484071"},"pull_request":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107"}},"in_reply_to_id":207479896},"pull_request":{"url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107","id":205060350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDYwMzUw","html_url":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107","diff_url":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107.diff","patch_url":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107.patch","issue_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/107","number":107,"state":"open","locked":false,"title":"Changes for API Servers, API Client and Collector","user":{"login":"fazo96","id":2546805,"node_id":"MDQ6VXNlcjI1NDY4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2546805?v=4","gravatar_id":"","url":"https://api.github.com/users/fazo96","html_url":"https://github.com/fazo96","followers_url":"https://api.github.com/users/fazo96/followers","following_url":"https://api.github.com/users/fazo96/following{/other_user}","gists_url":"https://api.github.com/users/fazo96/gists{/gist_id}","starred_url":"https://api.github.com/users/fazo96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fazo96/subscriptions","organizations_url":"https://api.github.com/users/fazo96/orgs","repos_url":"https://api.github.com/users/fazo96/repos","events_url":"https://api.github.com/users/fazo96/events{/privacy}","received_events_url":"https://api.github.com/users/fazo96/received_events","type":"User","site_admin":false},"body":"The PR contains mostly changes required for the API Servers and Client to work, also replaces the service node with the Chlu Collector\r\n\r\nWhat's missing:\r\n\r\n- [x] move Integration Tests to proper repository (chlu-infrastructure ? discuss this with @kulpreet)\r\n- [ ] do a pass over Docs and README\r\n- [ ] update or remove browser build, tests and examples (decide with @kulpreet since we are probably going to break browser compatibility when we work on the DB)\r\n- [ ] (slightly unrelated) browser build, tests and examples should be available in chlu-api-client","created_at":"2018-07-31T10:06:52Z","updated_at":"2018-08-03T09:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d616e8884b2b4f9a53e8a86f961c26d829db839b","assignee":{"login":"fazo96","id":2546805,"node_id":"MDQ6VXNlcjI1NDY4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2546805?v=4","gravatar_id":"","url":"https://api.github.com/users/fazo96","html_url":"https://github.com/fazo96","followers_url":"https://api.github.com/users/fazo96/followers","following_url":"https://api.github.com/users/fazo96/following{/other_user}","gists_url":"https://api.github.com/users/fazo96/gists{/gist_id}","starred_url":"https://api.github.com/users/fazo96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fazo96/subscriptions","organizations_url":"https://api.github.com/users/fazo96/orgs","repos_url":"https://api.github.com/users/fazo96/repos","events_url":"https://api.github.com/users/fazo96/events{/privacy}","received_events_url":"https://api.github.com/users/fazo96/received_events","type":"User","site_admin":false},"assignees":[{"login":"fazo96","id":2546805,"node_id":"MDQ6VXNlcjI1NDY4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2546805?v=4","gravatar_id":"","url":"https://api.github.com/users/fazo96","html_url":"https://github.com/fazo96","followers_url":"https://api.github.com/users/fazo96/followers","following_url":"https://api.github.com/users/fazo96/following{/other_user}","gists_url":"https://api.github.com/users/fazo96/gists{/gist_id}","starred_url":"https://api.github.com/users/fazo96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fazo96/subscriptions","organizations_url":"https://api.github.com/users/fazo96/orgs","repos_url":"https://api.github.com/users/fazo96/repos","events_url":"https://api.github.com/users/fazo96/events{/privacy}","received_events_url":"https://api.github.com/users/fazo96/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107/commits","review_comments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107/comments","review_comment_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/107/comments","statuses_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/statuses/60fb9eae97b95a7bf4afe3cc06b700283e8040dd","head":{"label":"ChluNetwork:misc-features","ref":"misc-features","sha":"60fb9eae97b95a7bf4afe3cc06b700283e8040dd","user":{"login":"ChluNetwork","id":32159078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTU5MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/32159078?v=4","gravatar_id":"","url":"https://api.github.com/users/ChluNetwork","html_url":"https://github.com/ChluNetwork","followers_url":"https://api.github.com/users/ChluNetwork/followers","following_url":"https://api.github.com/users/ChluNetwork/following{/other_user}","gists_url":"https://api.github.com/users/ChluNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/ChluNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChluNetwork/subscriptions","organizations_url":"https://api.github.com/users/ChluNetwork/orgs","repos_url":"https://api.github.com/users/ChluNetwork/repos","events_url":"https://api.github.com/users/ChluNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/ChluNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":112463803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0NjM4MDM=","name":"chlu-ipfs-support","full_name":"ChluNetwork/chlu-ipfs-support","owner":{"login":"ChluNetwork","id":32159078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTU5MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/32159078?v=4","gravatar_id":"","url":"https://api.github.com/users/ChluNetwork","html_url":"https://github.com/ChluNetwork","followers_url":"https://api.github.com/users/ChluNetwork/followers","following_url":"https://api.github.com/users/ChluNetwork/following{/other_user}","gists_url":"https://api.github.com/users/ChluNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/ChluNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChluNetwork/subscriptions","organizations_url":"https://api.github.com/users/ChluNetwork/orgs","repos_url":"https://api.github.com/users/ChluNetwork/repos","events_url":"https://api.github.com/users/ChluNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/ChluNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChluNetwork/chlu-ipfs-support","description":"Support libs to talk to IPFS","fork":false,"url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support","forks_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/forks","keys_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/teams","hooks_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/hooks","issue_events_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/events{/number}","events_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/events","assignees_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/assignees{/user}","branches_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/branches{/branch}","tags_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/tags","blobs_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/statuses/{sha}","languages_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/languages","stargazers_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/stargazers","contributors_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/contributors","subscribers_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/subscribers","subscription_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/subscription","commits_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/contents/{+path}","compare_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/merges","archive_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/downloads","issues_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues{/number}","pulls_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls{/number}","milestones_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/milestones{/number}","notifications_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/labels{/name}","releases_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/releases{/id}","deployments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/deployments","created_at":"2017-11-29T10:53:21Z","updated_at":"2018-07-31T09:39:43Z","pushed_at":"2018-08-02T11:50:30Z","git_url":"git://github.com/ChluNetwork/chlu-ipfs-support.git","ssh_url":"git@github.com:ChluNetwork/chlu-ipfs-support.git","clone_url":"https://github.com/ChluNetwork/chlu-ipfs-support.git","svn_url":"https://github.com/ChluNetwork/chlu-ipfs-support","homepage":null,"size":2505,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":33,"watchers":1,"default_branch":"master"}},"base":{"label":"ChluNetwork:master","ref":"master","sha":"5a8c072c7bbe5972bfecdf6c35382d7847fca1e3","user":{"login":"ChluNetwork","id":32159078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTU5MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/32159078?v=4","gravatar_id":"","url":"https://api.github.com/users/ChluNetwork","html_url":"https://github.com/ChluNetwork","followers_url":"https://api.github.com/users/ChluNetwork/followers","following_url":"https://api.github.com/users/ChluNetwork/following{/other_user}","gists_url":"https://api.github.com/users/ChluNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/ChluNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChluNetwork/subscriptions","organizations_url":"https://api.github.com/users/ChluNetwork/orgs","repos_url":"https://api.github.com/users/ChluNetwork/repos","events_url":"https://api.github.com/users/ChluNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/ChluNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":112463803,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0NjM4MDM=","name":"chlu-ipfs-support","full_name":"ChluNetwork/chlu-ipfs-support","owner":{"login":"ChluNetwork","id":32159078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTU5MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/32159078?v=4","gravatar_id":"","url":"https://api.github.com/users/ChluNetwork","html_url":"https://github.com/ChluNetwork","followers_url":"https://api.github.com/users/ChluNetwork/followers","following_url":"https://api.github.com/users/ChluNetwork/following{/other_user}","gists_url":"https://api.github.com/users/ChluNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/ChluNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChluNetwork/subscriptions","organizations_url":"https://api.github.com/users/ChluNetwork/orgs","repos_url":"https://api.github.com/users/ChluNetwork/repos","events_url":"https://api.github.com/users/ChluNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/ChluNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChluNetwork/chlu-ipfs-support","description":"Support libs to talk to IPFS","fork":false,"url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support","forks_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/forks","keys_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/teams","hooks_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/hooks","issue_events_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/events{/number}","events_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/events","assignees_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/assignees{/user}","branches_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/branches{/branch}","tags_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/tags","blobs_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/statuses/{sha}","languages_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/languages","stargazers_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/stargazers","contributors_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/contributors","subscribers_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/subscribers","subscription_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/subscription","commits_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/contents/{+path}","compare_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/merges","archive_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/downloads","issues_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues{/number}","pulls_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls{/number}","milestones_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/milestones{/number}","notifications_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/labels{/name}","releases_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/releases{/id}","deployments_url":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/deployments","created_at":"2017-11-29T10:53:21Z","updated_at":"2018-07-31T09:39:43Z","pushed_at":"2018-08-02T11:50:30Z","git_url":"git://github.com/ChluNetwork/chlu-ipfs-support.git","ssh_url":"git@github.com:ChluNetwork/chlu-ipfs-support.git","clone_url":"https://github.com/ChluNetwork/chlu-ipfs-support.git","svn_url":"https://github.com/ChluNetwork/chlu-ipfs-support","homepage":null,"size":2505,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":33,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107"},"html":{"href":"https://github.com/ChluNetwork/chlu-ipfs-support/pull/107"},"issue":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/107"},"comments":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/ChluNetwork/chlu-ipfs-support/statuses/60fb9eae97b95a7bf4afe3cc06b700283e8040dd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fazo96"}}