{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/194385817","pull_request_review_id":127546326,"id":194385817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDM4NTgxNw==","diff_hunk":"@@ -179,4 +179,25 @@ describe('site App', function() {\n       expect(results).toContain('Router');\n     });\n   });\n+\n+  describe('suggest edit link', () => {\n+    it('should be present on all docs pages', () => {\n+      page.navigateTo('tutorial/toh-pt1');\n+      expect(page.ghLinks.count()).toEqual(1);\n+      /* tslint:disable:max-line-length */\n+      expect(page.ghLinks.get(0).getAttribute('href'))\n+        .toMatch(/https:\\/\\/github\\.com\\/angular\\/angular\\/edit\\/master\\/aio\\/content\\/tutorial\\/toh-pt1\\.md\\?message=docs%3A%20describe%20your%20change\\.\\.\\./);","path":"aio/tests/e2e/app.e2e-spec.ts","position":11,"original_position":11,"commit_id":"3d093b25bf1182e77867f2a1f79543c54c302afa","original_commit_id":"3d093b25bf1182e77867f2a1f79543c54c302afa","user":{"login":"lacolaco","id":1529180,"node_id":"MDQ6VXNlcjE1MjkxODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1529180?v=4","gravatar_id":"","url":"https://api.github.com/users/lacolaco","html_url":"https://github.com/lacolaco","followers_url":"https://api.github.com/users/lacolaco/followers","following_url":"https://api.github.com/users/lacolaco/following{/other_user}","gists_url":"https://api.github.com/users/lacolaco/gists{/gist_id}","starred_url":"https://api.github.com/users/lacolaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacolaco/subscriptions","organizations_url":"https://api.github.com/users/lacolaco/orgs","repos_url":"https://api.github.com/users/lacolaco/repos","events_url":"https://api.github.com/users/lacolaco/events{/privacy}","received_events_url":"https://api.github.com/users/lacolaco/received_events","type":"User","site_admin":false},"body":"Exactly. After I've send the above comment, I found it's e2e testing so it doesn't affect to build aio. Sorry, and thank you. 🙌 ","created_at":"2018-06-11T12:29:30Z","updated_at":"2018-06-11T12:29:30Z","html_url":"https://github.com/angular/angular/pull/24378#discussion_r194385817","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/24378","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/194385817"},"html":{"href":"https://github.com/angular/angular/pull/24378#discussion_r194385817"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/24378"}},"in_reply_to_id":194282785},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/24378","id":193661528,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjYxNTI4","html_url":"https://github.com/angular/angular/pull/24378","diff_url":"https://github.com/angular/angular/pull/24378.diff","patch_url":"https://github.com/angular/angular/pull/24378.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/24378","number":24378,"state":"open","locked":false,"title":"feat(aio): add \"suggest edits\" feature to all docs","user":{"login":"martinsik","id":238765,"node_id":"MDQ6VXNlcjIzODc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/238765?v=4","gravatar_id":"","url":"https://api.github.com/users/martinsik","html_url":"https://github.com/martinsik","followers_url":"https://api.github.com/users/martinsik/followers","following_url":"https://api.github.com/users/martinsik/following{/other_user}","gists_url":"https://api.github.com/users/martinsik/gists{/gist_id}","starred_url":"https://api.github.com/users/martinsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinsik/subscriptions","organizations_url":"https://api.github.com/users/martinsik/orgs","repos_url":"https://api.github.com/users/martinsik/repos","events_url":"https://api.github.com/users/martinsik/events{/privacy}","received_events_url":"https://api.github.com/users/martinsik/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[X] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nThe \"Suggest Edits\" pencil icon is only in the API subsection.\r\n\r\nIssue Number: #23981\r\n\r\n## What is the new behavior?\r\n\r\nThe \"Suggest Edits\" pencil icon is on all pages under `/docs`.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[X] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n","created_at":"2018-06-08T16:15:25Z","updated_at":"2018-06-11T12:29:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34406ca8af3dddcc8065fa8337dabf8c03767cf1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"petebacondarwin","id":15655,"node_id":"MDQ6VXNlcjE1NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15655?v=4","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":217969169,"node_id":"MDU6TGFiZWwyMTc5NjkxNjk=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":633027559,"node_id":"MDU6TGFiZWw2MzMwMjc1NTk=","url":"https://api.github.com/repos/angular/angular/labels/aio:%20preview","name":"aio: preview","color":"1d76db","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":533874619,"node_id":"MDU6TGFiZWw1MzM4NzQ2MTk=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20docs-infra","name":"comp: docs-infra","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/24378/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/24378/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/24378/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/3d093b25bf1182e77867f2a1f79543c54c302afa","head":{"label":"martinsik:issue-23981","ref":"issue-23981","sha":"3d093b25bf1182e77867f2a1f79543c54c302afa","user":{"login":"martinsik","id":238765,"node_id":"MDQ6VXNlcjIzODc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/238765?v=4","gravatar_id":"","url":"https://api.github.com/users/martinsik","html_url":"https://github.com/martinsik","followers_url":"https://api.github.com/users/martinsik/followers","following_url":"https://api.github.com/users/martinsik/following{/other_user}","gists_url":"https://api.github.com/users/martinsik/gists{/gist_id}","starred_url":"https://api.github.com/users/martinsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinsik/subscriptions","organizations_url":"https://api.github.com/users/martinsik/orgs","repos_url":"https://api.github.com/users/martinsik/repos","events_url":"https://api.github.com/users/martinsik/events{/privacy}","received_events_url":"https://api.github.com/users/martinsik/received_events","type":"User","site_admin":false},"repo":{"id":120123426,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxMjM0MjY=","name":"angular","full_name":"martinsik/angular","owner":{"login":"martinsik","id":238765,"node_id":"MDQ6VXNlcjIzODc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/238765?v=4","gravatar_id":"","url":"https://api.github.com/users/martinsik","html_url":"https://github.com/martinsik","followers_url":"https://api.github.com/users/martinsik/followers","following_url":"https://api.github.com/users/martinsik/following{/other_user}","gists_url":"https://api.github.com/users/martinsik/gists{/gist_id}","starred_url":"https://api.github.com/users/martinsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinsik/subscriptions","organizations_url":"https://api.github.com/users/martinsik/orgs","repos_url":"https://api.github.com/users/martinsik/repos","events_url":"https://api.github.com/users/martinsik/events{/privacy}","received_events_url":"https://api.github.com/users/martinsik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinsik/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/martinsik/angular","forks_url":"https://api.github.com/repos/martinsik/angular/forks","keys_url":"https://api.github.com/repos/martinsik/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinsik/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinsik/angular/teams","hooks_url":"https://api.github.com/repos/martinsik/angular/hooks","issue_events_url":"https://api.github.com/repos/martinsik/angular/issues/events{/number}","events_url":"https://api.github.com/repos/martinsik/angular/events","assignees_url":"https://api.github.com/repos/martinsik/angular/assignees{/user}","branches_url":"https://api.github.com/repos/martinsik/angular/branches{/branch}","tags_url":"https://api.github.com/repos/martinsik/angular/tags","blobs_url":"https://api.github.com/repos/martinsik/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinsik/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinsik/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinsik/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinsik/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/martinsik/angular/languages","stargazers_url":"https://api.github.com/repos/martinsik/angular/stargazers","contributors_url":"https://api.github.com/repos/martinsik/angular/contributors","subscribers_url":"https://api.github.com/repos/martinsik/angular/subscribers","subscription_url":"https://api.github.com/repos/martinsik/angular/subscription","commits_url":"https://api.github.com/repos/martinsik/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinsik/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinsik/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinsik/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinsik/angular/contents/{+path}","compare_url":"https://api.github.com/repos/martinsik/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinsik/angular/merges","archive_url":"https://api.github.com/repos/martinsik/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinsik/angular/downloads","issues_url":"https://api.github.com/repos/martinsik/angular/issues{/number}","pulls_url":"https://api.github.com/repos/martinsik/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/martinsik/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/martinsik/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinsik/angular/labels{/name}","releases_url":"https://api.github.com/repos/martinsik/angular/releases{/id}","deployments_url":"https://api.github.com/repos/martinsik/angular/deployments","created_at":"2018-02-03T19:40:43Z","updated_at":"2018-06-06T12:37:24Z","pushed_at":"2018-06-11T12:01:48Z","git_url":"git://github.com/martinsik/angular.git","ssh_url":"git@github.com:martinsik/angular.git","clone_url":"https://github.com/martinsik/angular.git","svn_url":"https://github.com/martinsik/angular","homepage":"https://angular.io","size":79696,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"29eb24b142b29a84491f92fe1a4c48290a207db8","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-06-11T11:56:12Z","pushed_at":"2018-06-11T12:29:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":80600,"stargazers_count":37027,"watchers_count":37027,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8968,"mirror_url":null,"archived":false,"open_issues_count":2394,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8968,"open_issues":2394,"watchers":37027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/24378"},"html":{"href":"https://github.com/angular/angular/pull/24378"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/24378"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/24378/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/24378/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/24378/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/3d093b25bf1182e77867f2a1f79543c54c302afa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lacolaco"}}