{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/189239469","pull_request_review_id":121381881,"id":189239469,"diff_hunk":"@@ -96,8 +96,39 @@ void GUIConfirmRegistration::regenerateGui(v2u32 screensize)\n \t\t\t\t\"Join to confirm account creation or click Cancel to \"\n \t\t\t\t\"abort.\");\n \t\tchar info_text_buf[1024];\n+\n+#ifdef _MSC_VER","path":"src/gui/guiConfirmRegistration.cpp","position":5,"original_position":5,"commit_id":"fd9fce2df1c9c3fc67c9c373f0837f237e600040","original_commit_id":"fd9fce2df1c9c3fc67c9c373f0837f237e600040","user":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars3.githubusercontent.com/u/3883583?v=4","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"body":"same","created_at":"2018-05-18T11:27:20Z","updated_at":"2018-05-18T11:27:20Z","html_url":"https://github.com/minetest/minetest/pull/7339#discussion_r189239469","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7339","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/189239469"},"html":{"href":"https://github.com/minetest/minetest/pull/7339#discussion_r189239469"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7339"}},"in_reply_to_id":189108876},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7339","id":188207947,"html_url":"https://github.com/minetest/minetest/pull/7339","diff_url":"https://github.com/minetest/minetest/pull/7339.diff","patch_url":"https://github.com/minetest/minetest/pull/7339.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7339","number":7339,"state":"open","locked":false,"title":"[WIP] Add discord rich presence","user":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars3.githubusercontent.com/u/3883583?v=4","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"body":"I re-open my PR #7303 . I invite you to read the comments of the previous one to understand the problem. The idea is to add the rich presence of discord on Minetest. But it seems that some core developer Minetest refuse. **I invite you to express your point of view.**\r\n\r\nBut please, can we evolve and stop falling in the \"Discord is owner, it's evil\"","created_at":"2018-05-15T17:55:26Z","updated_at":"2018-05-18T11:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598bc6409dae16befd429a0eda58add92b9f68bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":343608774,"url":"https://api.github.com/repos/minetest/minetest/labels/Controversial","name":"Controversial","color":"d93f0b","default":false},{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"0052cc","default":false},{"id":110411003,"url":"https://api.github.com/repos/minetest/minetest/labels/WIP","name":"WIP","color":"aa3000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7339/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7339/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7339/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/fd9fce2df1c9c3fc67c9c373f0837f237e600040","head":{"label":"Dumbeldor:add_discord_rich_presence_necessary_merge_pliz","ref":"add_discord_rich_presence_necessary_merge_pliz","sha":"fd9fce2df1c9c3fc67c9c373f0837f237e600040","user":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars3.githubusercontent.com/u/3883583?v=4","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"repo":{"id":80767214,"name":"minetest","full_name":"Dumbeldor/minetest","owner":{"login":"Dumbeldor","id":3883583,"avatar_url":"https://avatars3.githubusercontent.com/u/3883583?v=4","gravatar_id":"","url":"https://api.github.com/users/Dumbeldor","html_url":"https://github.com/Dumbeldor","followers_url":"https://api.github.com/users/Dumbeldor/followers","following_url":"https://api.github.com/users/Dumbeldor/following{/other_user}","gists_url":"https://api.github.com/users/Dumbeldor/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumbeldor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumbeldor/subscriptions","organizations_url":"https://api.github.com/users/Dumbeldor/orgs","repos_url":"https://api.github.com/users/Dumbeldor/repos","events_url":"https://api.github.com/users/Dumbeldor/events{/privacy}","received_events_url":"https://api.github.com/users/Dumbeldor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dumbeldor/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/Dumbeldor/minetest","forks_url":"https://api.github.com/repos/Dumbeldor/minetest/forks","keys_url":"https://api.github.com/repos/Dumbeldor/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dumbeldor/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dumbeldor/minetest/teams","hooks_url":"https://api.github.com/repos/Dumbeldor/minetest/hooks","issue_events_url":"https://api.github.com/repos/Dumbeldor/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/Dumbeldor/minetest/events","assignees_url":"https://api.github.com/repos/Dumbeldor/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/Dumbeldor/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/Dumbeldor/minetest/tags","blobs_url":"https://api.github.com/repos/Dumbeldor/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dumbeldor/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dumbeldor/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dumbeldor/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dumbeldor/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/Dumbeldor/minetest/languages","stargazers_url":"https://api.github.com/repos/Dumbeldor/minetest/stargazers","contributors_url":"https://api.github.com/repos/Dumbeldor/minetest/contributors","subscribers_url":"https://api.github.com/repos/Dumbeldor/minetest/subscribers","subscription_url":"https://api.github.com/repos/Dumbeldor/minetest/subscription","commits_url":"https://api.github.com/repos/Dumbeldor/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dumbeldor/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dumbeldor/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dumbeldor/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dumbeldor/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/Dumbeldor/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dumbeldor/minetest/merges","archive_url":"https://api.github.com/repos/Dumbeldor/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dumbeldor/minetest/downloads","issues_url":"https://api.github.com/repos/Dumbeldor/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/Dumbeldor/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/Dumbeldor/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/Dumbeldor/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dumbeldor/minetest/labels{/name}","releases_url":"https://api.github.com/repos/Dumbeldor/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/Dumbeldor/minetest/deployments","created_at":"2017-02-02T20:47:08Z","updated_at":"2018-05-10T13:28:20Z","pushed_at":"2018-05-15T17:49:50Z","git_url":"git://github.com/Dumbeldor/minetest.git","ssh_url":"git@github.com:Dumbeldor/minetest.git","clone_url":"https://github.com/Dumbeldor/minetest.git","svn_url":"https://github.com/Dumbeldor/minetest","homepage":"http://minetest.net/","size":56940,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"2f34797c5c1530e7b165a0ce26818eb291a38414","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine with support for survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-05-18T08:49:57Z","pushed_at":"2018-05-18T11:00:38Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":57415,"stargazers_count":3275,"watchers_count":3275,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":871,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":901,"open_issues":871,"watchers":3275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7339"},"html":{"href":"https://github.com/minetest/minetest/pull/7339"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7339"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7339/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7339/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7339/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/fd9fce2df1c9c3fc67c9c373f0837f237e600040"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dumbeldor"}}