{"action":"opened","number":557,"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/557","id":199582096,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTgyMDk2","html_url":"https://github.com/solana-labs/solana/pull/557","diff_url":"https://github.com/solana-labs/solana/pull/557.diff","patch_url":"https://github.com/solana-labs/solana/pull/557.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/557","number":557,"state":"open","locked":false,"title":"Error handling cleanup","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"body":"Error handling is still clumsy. We should switch to something like\r\n`error-chain` or `Result<T, Box<Error>>`, but until then, we can\r\nat least be consistent across modules.","created_at":"2018-07-05T20:42:09Z","updated_at":"2018-07-05T20:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/557/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/557/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/557/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/cee34f7631a70bff2791f1a964b81c50558486e8","head":{"label":"garious:cleanup","ref":"cleanup","sha":"cee34f7631a70bff2791f1a964b81c50558486e8","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"repo":{"id":121788525,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3ODg1MjU=","name":"solana","full_name":"garious/solana","owner":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garious/solana","description":"Blockchain, Rebuilt for Scale","fork":true,"url":"https://api.github.com/repos/garious/solana","forks_url":"https://api.github.com/repos/garious/solana/forks","keys_url":"https://api.github.com/repos/garious/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garious/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garious/solana/teams","hooks_url":"https://api.github.com/repos/garious/solana/hooks","issue_events_url":"https://api.github.com/repos/garious/solana/issues/events{/number}","events_url":"https://api.github.com/repos/garious/solana/events","assignees_url":"https://api.github.com/repos/garious/solana/assignees{/user}","branches_url":"https://api.github.com/repos/garious/solana/branches{/branch}","tags_url":"https://api.github.com/repos/garious/solana/tags","blobs_url":"https://api.github.com/repos/garious/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garious/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garious/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/garious/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garious/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/garious/solana/languages","stargazers_url":"https://api.github.com/repos/garious/solana/stargazers","contributors_url":"https://api.github.com/repos/garious/solana/contributors","subscribers_url":"https://api.github.com/repos/garious/solana/subscribers","subscription_url":"https://api.github.com/repos/garious/solana/subscription","commits_url":"https://api.github.com/repos/garious/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/garious/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/garious/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/garious/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/garious/solana/contents/{+path}","compare_url":"https://api.github.com/repos/garious/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garious/solana/merges","archive_url":"https://api.github.com/repos/garious/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garious/solana/downloads","issues_url":"https://api.github.com/repos/garious/solana/issues{/number}","pulls_url":"https://api.github.com/repos/garious/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/garious/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/garious/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garious/solana/labels{/name}","releases_url":"https://api.github.com/repos/garious/solana/releases{/id}","deployments_url":"https://api.github.com/repos/garious/solana/deployments","created_at":"2018-02-16T18:56:42Z","updated_at":"2018-07-03T01:42:42Z","pushed_at":"2018-07-05T20:40:31Z","git_url":"git://github.com/garious/solana.git","ssh_url":"git@github.com:garious/solana.git","clone_url":"https://github.com/garious/solana.git","svn_url":"https://github.com/garious/solana","homepage":"http://solana.com/","size":9459,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"f54615b4e3fbc2c918af2a2c352cc67c1b8a5028","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solana-labs/solana","description":"Blockchain, Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-07-05T16:17:39Z","pushed_at":"2018-07-05T18:57:44Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":9399,"stargazers_count":269,"watchers_count":269,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":50,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/557"},"html":{"href":"https://github.com/solana-labs/solana/pull/557"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/557"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/cee34f7631a70bff2791f1a964b81c50558486e8"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":64,"deletions":41,"changed_files":6}}
{"actor":{"display_login":"garious"}}