{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments/194251814","pull_request_review_id":127391471,"id":194251814,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI1MTgxNA==","diff_hunk":"@@ -24,6 +24,15 @@ bundle install --without=development --jobs=5 --retry=5\n # we need to install node modules for integration tests (which only run on postgresql)\n if [ ${database} = postgresql -a -e \"$APP_ROOT/package.json\" ]; then\n   npm install npm@'<6.0.0' # first upgrade to newer npm\n+\n+  # Test asset precompile\n+  NODE_ENV=production $APP_ROOT/node_modules/.bin/npm install\n+  bundle exec rake assets:precompile RAILS_ENV=production\n+  bundle exec rake webpack:compile RAILS_ENV=production","path":"puppet/modules/jenkins_job_builder/files/theforeman.org/scripts/test/test_develop.sh","position":8,"original_position":8,"commit_id":"d43fe4c99128be92658cf61c233d0a9e05d6f3d5","original_commit_id":"d43fe4c99128be92658cf61c233d0a9e05d6f3d5","user":{"login":"tbrisker","id":1540531,"node_id":"MDQ6VXNlcjE1NDA1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1540531?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"body":"We already run this step without the production option in the jenkins:integration task, would it make sense to remove it from there and just run once, having jenkins run the tests on the production version of the bundle?","created_at":"2018-06-10T10:00:48Z","updated_at":"2018-06-10T10:00:52Z","html_url":"https://github.com/theforeman/foreman-infra/pull/684#discussion_r194251814","pull_request_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments/194251814"},"html":{"href":"https://github.com/theforeman/foreman-infra/pull/684#discussion_r194251814"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684","id":193664785,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjY0Nzg1","html_url":"https://github.com/theforeman/foreman-infra/pull/684","diff_url":"https://github.com/theforeman/foreman-infra/pull/684.diff","patch_url":"https://github.com/theforeman/foreman-infra/pull/684.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/684","number":684,"state":"open","locked":false,"title":"Test asset precompile for Foreman core","user":{"login":"ehelms","id":293363,"node_id":"MDQ6VXNlcjI5MzM2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-08T16:30:04Z","updated_at":"2018-06-10T10:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9da7ac174603d50fff8a8ab25901024d3f0af4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/684/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-infra/statuses/d43fe4c99128be92658cf61c233d0a9e05d6f3d5","head":{"label":"ehelms:npm-install-prod","ref":"npm-install-prod","sha":"d43fe4c99128be92658cf61c233d0a9e05d6f3d5","user":{"login":"ehelms","id":293363,"node_id":"MDQ6VXNlcjI5MzM2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":16315467,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMxNTQ2Nw==","name":"foreman-infra","full_name":"ehelms/foreman-infra","owner":{"login":"ehelms","id":293363,"node_id":"MDQ6VXNlcjI5MzM2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/foreman-infra","description":"Puppet modules and scripts to manage Foreman project infrastructure","fork":true,"url":"https://api.github.com/repos/ehelms/foreman-infra","forks_url":"https://api.github.com/repos/ehelms/foreman-infra/forks","keys_url":"https://api.github.com/repos/ehelms/foreman-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/foreman-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/foreman-infra/teams","hooks_url":"https://api.github.com/repos/ehelms/foreman-infra/hooks","issue_events_url":"https://api.github.com/repos/ehelms/foreman-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/foreman-infra/events","assignees_url":"https://api.github.com/repos/ehelms/foreman-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/foreman-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/foreman-infra/tags","blobs_url":"https://api.github.com/repos/ehelms/foreman-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/foreman-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/foreman-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/foreman-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/foreman-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/foreman-infra/languages","stargazers_url":"https://api.github.com/repos/ehelms/foreman-infra/stargazers","contributors_url":"https://api.github.com/repos/ehelms/foreman-infra/contributors","subscribers_url":"https://api.github.com/repos/ehelms/foreman-infra/subscribers","subscription_url":"https://api.github.com/repos/ehelms/foreman-infra/subscription","commits_url":"https://api.github.com/repos/ehelms/foreman-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/foreman-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/foreman-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/foreman-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/foreman-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/foreman-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/foreman-infra/merges","archive_url":"https://api.github.com/repos/ehelms/foreman-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/foreman-infra/downloads","issues_url":"https://api.github.com/repos/ehelms/foreman-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/foreman-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/foreman-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/foreman-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/foreman-infra/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/foreman-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/foreman-infra/deployments","created_at":"2014-01-28T15:20:30Z","updated_at":"2014-05-04T17:09:42Z","pushed_at":"2018-06-08T23:42:54Z","git_url":"git://github.com/ehelms/foreman-infra.git","ssh_url":"git@github.com:ehelms/foreman-infra.git","clone_url":"https://github.com/ehelms/foreman-infra.git","svn_url":"https://github.com/ehelms/foreman-infra","homepage":"","size":1891,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"ce9bcbaeb042fdc2c5b99dd69bf7cbca7192f789","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":5750224,"node_id":"MDEwOlJlcG9zaXRvcnk1NzUwMjI0","name":"foreman-infra","full_name":"theforeman/foreman-infra","owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-infra","description":"Puppet modules and scripts to manage Foreman project infrastructure","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-infra","forks_url":"https://api.github.com/repos/theforeman/foreman-infra/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-infra/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-infra/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-infra/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-infra/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-infra/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-infra/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-infra/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-infra/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-infra/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-infra/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-infra/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman-infra/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-infra/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-infra/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-infra/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-infra/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-infra/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman-infra/deployments","created_at":"2012-09-10T13:51:02Z","updated_at":"2018-06-08T15:25:30Z","pushed_at":"2018-06-08T23:42:55Z","git_url":"git://github.com/theforeman/foreman-infra.git","ssh_url":"git@github.com:theforeman/foreman-infra.git","clone_url":"https://github.com/theforeman/foreman-infra.git","svn_url":"https://github.com/theforeman/foreman-infra","homepage":"","size":1854,"stargazers_count":14,"watchers_count":14,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":37,"open_issues":30,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684"},"html":{"href":"https://github.com/theforeman/foreman-infra/pull/684"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-infra/issues/684"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-infra/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-infra/statuses/d43fe4c99128be92658cf61c233d0a9e05d6f3d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tbrisker"}}