{"action":"opened","number":15072,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/15072","id":186706391,"html_url":"https://github.com/magento/magento2/pull/15072","diff_url":"https://github.com/magento/magento2/pull/15072.diff","patch_url":"https://github.com/magento/magento2/pull/15072.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/15072","number":15072,"state":"open","locked":false,"title":"[Forwardport] Fix infinite checkout loader when some script wasn't loaded correctly because of network error","user":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"body":"### Original Pull Request \n https://github.com/magento/magento2/pull/14874\n### Description\r\nInfinite checkout loader may appear when some module makes a `require` call but the dependency wasn't returned (Network error).\r\n\r\nThe patch changes how Magento treats `isPending` modules. If all dependencies are errored - treat it as loaded.\r\n\r\n### Manual testing scenarios\r\n1. Open `Magento/Checkout/view/frontend/web/js/model/quote.js`\r\n2. Insert the following code: \r\n\r\n```js\r\nrequire([\r\n    'jquery',\r\n    'https://some-site/tracking/api/js'\r\n], function ($) {}, function () {});\r\n``` \r\n\r\nright after\r\n\r\n```js\r\ndefine([\r\n    'ko',\r\n    'underscore'\r\n], function (ko, _) {\r\n    'use strict';\r\n\r\n    // add code here\r\n```\r\n\r\n3. Navigate to checkout.\r\n4. You can't purchase the product because the page is blocked by loader.\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-05-08T17:42:18Z","updated_at":"2018-05-08T17:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/15072/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/15072/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/15072/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/7ca617b2aab0d85f91e28ef9b05b56e1c20f2bf0","head":{"label":"adrian-martinez-interactiv4:2.3-develop-PR-port-14874","ref":"2.3-develop-PR-port-14874","sha":"7ca617b2aab0d85f91e28ef9b05b56e1c20f2bf0","user":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"repo":{"id":89414464,"name":"magento2","full_name":"adrian-martinez-interactiv4/magento2","owner":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-martinez-interactiv4/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2","forks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/forks","keys_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/teams","hooks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/hooks","issue_events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/events","assignees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/tags","blobs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/languages","stargazers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/stargazers","contributors_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contributors","subscribers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscribers","subscription_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscription","commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/merges","archive_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/downloads","issues_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/labels{/name}","releases_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/deployments","created_at":"2017-04-25T23:01:10Z","updated_at":"2018-02-06T01:27:06Z","pushed_at":"2018-05-08T17:42:18Z","git_url":"git://github.com/adrian-martinez-interactiv4/magento2.git","ssh_url":"git@github.com:adrian-martinez-interactiv4/magento2.git","clone_url":"https://github.com/adrian-martinez-interactiv4/magento2.git","svn_url":"https://github.com/adrian-martinez-interactiv4/magento2","homepage":"http://www.magento.com","size":436200,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":15,"watchers":1,"default_branch":"develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"a53347eb1e1b35a9ab0b72073d5fc4d2b148fa7a","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-05-08T16:05:46Z","pushed_at":"2018-05-08T17:41:19Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":440754,"stargazers_count":5588,"watchers_count":5588,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4625,"mirror_url":null,"archived":false,"open_issues_count":1355,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4625,"open_issues":1355,"watchers":5588,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/15072"},"html":{"href":"https://github.com/magento/magento2/pull/15072"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/15072"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/15072/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/15072/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/15072/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/7ca617b2aab0d85f91e28ef9b05b56e1c20f2bf0"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":15,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"adrian-martinez-interactiv4"}}