{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29","id":176522108,"html_url":"https://github.com/TypescriptID/angularfire2/pull/29","diff_url":"https://github.com/TypescriptID/angularfire2/pull/29.diff","patch_url":"https://github.com/TypescriptID/angularfire2/pull/29.patch","issue_url":"https://api.github.com/repos/TypescriptID/angularfire2/issues/29","number":29,"state":"closed","locked":false,"title":"Update upstream","user":{"login":"GulajavaMinistudio","id":11639412,"avatar_url":"https://avatars0.githubusercontent.com/u/11639412?v=4","gravatar_id":"","url":"https://api.github.com/users/GulajavaMinistudio","html_url":"https://github.com/GulajavaMinistudio","followers_url":"https://api.github.com/users/GulajavaMinistudio/followers","following_url":"https://api.github.com/users/GulajavaMinistudio/following{/other_user}","gists_url":"https://api.github.com/users/GulajavaMinistudio/gists{/gist_id}","starred_url":"https://api.github.com/users/GulajavaMinistudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GulajavaMinistudio/subscriptions","organizations_url":"https://api.github.com/users/GulajavaMinistudio/orgs","repos_url":"https://api.github.com/users/GulajavaMinistudio/repos","events_url":"https://api.github.com/users/GulajavaMinistudio/events{/privacy}","received_events_url":"https://api.github.com/users/GulajavaMinistudio/received_events","type":"User","site_admin":false},"body":"…iguration with DI (#1454)\r\n\r\n* First.\r\n\r\n* SSR work\r\n\r\n* StorageBucket is a string...\r\n\r\n* Add AngularFireModule back in\r\n\r\n* Fix up storage and the tests\r\n\r\n* Adding StorageBucket and DatabaseURL DI tests\r\n\r\n* Adding specs for DI in auth + firestore\r\n\r\n* More complete tests + fixed the storage test config\r\n\r\n* Adding app.module back in and writing tests for app injection\r\n\r\n* Export RealtimeDatabaseURL from database-deprecated\r\n\r\n* Export FirebaseApp\r\n\r\n* Working, needs wrapper\r\n\r\n* More\r\n\r\n* State changes and auditlog\r\n\r\n* Wrap auth\r\n\r\n* Reverted database-depricated a bit\r\n\r\n* More cleanup\r\n\r\n* Cleanup unused imports\r\n\r\n<!--\r\n\r\nThank you for contributing to the Firebase community! Please fill out the pull request form below\r\nand make note of the following:\r\n\r\nRun the linter and test suite\r\n==============================\r\nMake sure your changes pass our linter and the tests all pass on your local machine. We've hooked\r\nup this repo with continuous integration to double check those things for you.\r\n\r\nAdd tests (if applicable)\r\n==============================\r\nMost non-trivial changes should include some extra test coverage. If you aren't sure how to add\r\ntests, feel free to submit regardless and ask us for some advice.\r\n\r\nSign our CLA\r\n==============================\r\nPlease sign our Contributor License Agreement (https://cla.developers.google.com/about/google-individual)\r\nbefore sending PRs. We cannot accept code without this.\r\n\r\n-->\r\n\r\n### Checklist\r\n\r\n   - Issue number for this PR: #nnn (required)\r\n   - Docs included?: (yes/no; required for all API/functional changes) \r\n   - Test units included?: (yes/no; required) \r\n   - In a clean directory, `yarn install`, `yarn test` run successfully? (yes/no; required)\r\n\r\n### Description\r\n\r\n<!-- Are you fixing a bug? Updating our documentation? Implementing a new feature? Make sure we\r\nhave the context around your change. Link to other relevant issues or pull requests. -->\r\n\r\n### Code sample\r\n\r\n<!-- Proposing an API change? Provide code samples showing how the API will be used. -->\r\n\r\n","created_at":"2018-03-21T15:52:25Z","updated_at":"2018-03-21T15:56:34Z","closed_at":"2018-03-21T15:56:34Z","merged_at":"2018-03-21T15:56:34Z","merge_commit_sha":"f4dc9aa8077b41a73345bb4fed63e8d5239bc31a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29/commits","review_comments_url":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29/comments","review_comment_url":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TypescriptID/angularfire2/issues/29/comments","statuses_url":"https://api.github.com/repos/TypescriptID/angularfire2/statuses/e343f137bd0ca9a1d958253b58104c64acbe3944","head":{"label":"angular:master","ref":"master","sha":"e343f137bd0ca9a1d958253b58104c64acbe3944","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49453413,"name":"angularfire2","full_name":"angular/angularfire2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angularfire2","description":"The official Angular library for Firebase.","fork":false,"url":"https://api.github.com/repos/angular/angularfire2","forks_url":"https://api.github.com/repos/angular/angularfire2/forks","keys_url":"https://api.github.com/repos/angular/angularfire2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angularfire2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angularfire2/teams","hooks_url":"https://api.github.com/repos/angular/angularfire2/hooks","issue_events_url":"https://api.github.com/repos/angular/angularfire2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angularfire2/events","assignees_url":"https://api.github.com/repos/angular/angularfire2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angularfire2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angularfire2/tags","blobs_url":"https://api.github.com/repos/angular/angularfire2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angularfire2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angularfire2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angularfire2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angularfire2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angularfire2/languages","stargazers_url":"https://api.github.com/repos/angular/angularfire2/stargazers","contributors_url":"https://api.github.com/repos/angular/angularfire2/contributors","subscribers_url":"https://api.github.com/repos/angular/angularfire2/subscribers","subscription_url":"https://api.github.com/repos/angular/angularfire2/subscription","commits_url":"https://api.github.com/repos/angular/angularfire2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angularfire2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angularfire2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angularfire2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angularfire2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angularfire2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angularfire2/merges","archive_url":"https://api.github.com/repos/angular/angularfire2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angularfire2/downloads","issues_url":"https://api.github.com/repos/angular/angularfire2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angularfire2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angularfire2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angularfire2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angularfire2/labels{/name}","releases_url":"https://api.github.com/repos/angular/angularfire2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angularfire2/deployments","created_at":"2016-01-11T20:47:23Z","updated_at":"2018-03-21T11:29:38Z","pushed_at":"2018-03-20T16:47:53Z","git_url":"git://github.com/angular/angularfire2.git","ssh_url":"git@github.com:angular/angularfire2.git","clone_url":"https://github.com/angular/angularfire2.git","svn_url":"https://github.com/angular/angularfire2","homepage":"https://github.com/angular/angularfire2","size":1175,"stargazers_count":3361,"watchers_count":3361,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":980,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":980,"open_issues":44,"watchers":3361,"default_branch":"master"}},"base":{"label":"TypescriptID:master","ref":"master","sha":"ad1df5400cded142b9b8a6392b1dce07c67a0b8a","user":{"login":"TypescriptID","id":28706002,"avatar_url":"https://avatars0.githubusercontent.com/u/28706002?v=4","gravatar_id":"","url":"https://api.github.com/users/TypescriptID","html_url":"https://github.com/TypescriptID","followers_url":"https://api.github.com/users/TypescriptID/followers","following_url":"https://api.github.com/users/TypescriptID/following{/other_user}","gists_url":"https://api.github.com/users/TypescriptID/gists{/gist_id}","starred_url":"https://api.github.com/users/TypescriptID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypescriptID/subscriptions","organizations_url":"https://api.github.com/users/TypescriptID/orgs","repos_url":"https://api.github.com/users/TypescriptID/repos","events_url":"https://api.github.com/users/TypescriptID/events{/privacy}","received_events_url":"https://api.github.com/users/TypescriptID/received_events","type":"Organization","site_admin":false},"repo":{"id":105749404,"name":"angularfire2","full_name":"TypescriptID/angularfire2","owner":{"login":"TypescriptID","id":28706002,"avatar_url":"https://avatars0.githubusercontent.com/u/28706002?v=4","gravatar_id":"","url":"https://api.github.com/users/TypescriptID","html_url":"https://github.com/TypescriptID","followers_url":"https://api.github.com/users/TypescriptID/followers","following_url":"https://api.github.com/users/TypescriptID/following{/other_user}","gists_url":"https://api.github.com/users/TypescriptID/gists{/gist_id}","starred_url":"https://api.github.com/users/TypescriptID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypescriptID/subscriptions","organizations_url":"https://api.github.com/users/TypescriptID/orgs","repos_url":"https://api.github.com/users/TypescriptID/repos","events_url":"https://api.github.com/users/TypescriptID/events{/privacy}","received_events_url":"https://api.github.com/users/TypescriptID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TypescriptID/angularfire2","description":"The official Angular library for Firebase.","fork":true,"url":"https://api.github.com/repos/TypescriptID/angularfire2","forks_url":"https://api.github.com/repos/TypescriptID/angularfire2/forks","keys_url":"https://api.github.com/repos/TypescriptID/angularfire2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypescriptID/angularfire2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypescriptID/angularfire2/teams","hooks_url":"https://api.github.com/repos/TypescriptID/angularfire2/hooks","issue_events_url":"https://api.github.com/repos/TypescriptID/angularfire2/issues/events{/number}","events_url":"https://api.github.com/repos/TypescriptID/angularfire2/events","assignees_url":"https://api.github.com/repos/TypescriptID/angularfire2/assignees{/user}","branches_url":"https://api.github.com/repos/TypescriptID/angularfire2/branches{/branch}","tags_url":"https://api.github.com/repos/TypescriptID/angularfire2/tags","blobs_url":"https://api.github.com/repos/TypescriptID/angularfire2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypescriptID/angularfire2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypescriptID/angularfire2/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypescriptID/angularfire2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypescriptID/angularfire2/statuses/{sha}","languages_url":"https://api.github.com/repos/TypescriptID/angularfire2/languages","stargazers_url":"https://api.github.com/repos/TypescriptID/angularfire2/stargazers","contributors_url":"https://api.github.com/repos/TypescriptID/angularfire2/contributors","subscribers_url":"https://api.github.com/repos/TypescriptID/angularfire2/subscribers","subscription_url":"https://api.github.com/repos/TypescriptID/angularfire2/subscription","commits_url":"https://api.github.com/repos/TypescriptID/angularfire2/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypescriptID/angularfire2/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypescriptID/angularfire2/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypescriptID/angularfire2/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypescriptID/angularfire2/contents/{+path}","compare_url":"https://api.github.com/repos/TypescriptID/angularfire2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypescriptID/angularfire2/merges","archive_url":"https://api.github.com/repos/TypescriptID/angularfire2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypescriptID/angularfire2/downloads","issues_url":"https://api.github.com/repos/TypescriptID/angularfire2/issues{/number}","pulls_url":"https://api.github.com/repos/TypescriptID/angularfire2/pulls{/number}","milestones_url":"https://api.github.com/repos/TypescriptID/angularfire2/milestones{/number}","notifications_url":"https://api.github.com/repos/TypescriptID/angularfire2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypescriptID/angularfire2/labels{/name}","releases_url":"https://api.github.com/repos/TypescriptID/angularfire2/releases{/id}","deployments_url":"https://api.github.com/repos/TypescriptID/angularfire2/deployments","created_at":"2017-10-04T09:04:52Z","updated_at":"2018-03-18T11:04:12Z","pushed_at":"2018-03-21T15:56:34Z","git_url":"git://github.com/TypescriptID/angularfire2.git","ssh_url":"git@github.com:TypescriptID/angularfire2.git","clone_url":"https://github.com/TypescriptID/angularfire2.git","svn_url":"https://github.com/TypescriptID/angularfire2","homepage":"https://github.com/angular/angularfire2","size":1134,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29"},"html":{"href":"https://github.com/TypescriptID/angularfire2/pull/29"},"issue":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/issues/29"},"comments":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/TypescriptID/angularfire2/statuses/e343f137bd0ca9a1d958253b58104c64acbe3944"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"GulajavaMinistudio","id":11639412,"avatar_url":"https://avatars0.githubusercontent.com/u/11639412?v=4","gravatar_id":"","url":"https://api.github.com/users/GulajavaMinistudio","html_url":"https://github.com/GulajavaMinistudio","followers_url":"https://api.github.com/users/GulajavaMinistudio/followers","following_url":"https://api.github.com/users/GulajavaMinistudio/following{/other_user}","gists_url":"https://api.github.com/users/GulajavaMinistudio/gists{/gist_id}","starred_url":"https://api.github.com/users/GulajavaMinistudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GulajavaMinistudio/subscriptions","organizations_url":"https://api.github.com/users/GulajavaMinistudio/orgs","repos_url":"https://api.github.com/users/GulajavaMinistudio/repos","events_url":"https://api.github.com/users/GulajavaMinistudio/events{/privacy}","received_events_url":"https://api.github.com/users/GulajavaMinistudio/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1878,"deletions":1414,"changed_files":38}}
{"actor":{"display_login":"GulajavaMinistudio"}}