{"action":"created","comment":{"url":"https://api.github.com/repos/tapjs/node-tap/pulls/comments/236858108","pull_request_review_id":179023200,"id":236858108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjg1ODEwOA==","diff_hunk":"@@ -507,6 +513,11 @@ const runCoverageReportOnly = (options, code, signal) => {\n \n   const args = [nycBin, 'report', '--reporter', options.coverageReport]\n \n+  if (options.typescript) {\n+    args.push('--reporter');\n+    args.push('text');\n+  }","path":"bin/run.js","position":27,"original_position":27,"commit_id":"78e0927afa4fb0d26dacd48c5068599fc5b3e8cc","original_commit_id":"78e0927afa4fb0d26dacd48c5068599fc5b3e8cc","user":{"login":"isaacs","id":9287,"node_id":"MDQ6VXNlcjkyODc=","avatar_url":"https://avatars2.githubusercontent.com/u/9287?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"body":"I don't understand this.  Why are you forcing coverage with a text reporter when `--type-script` is enabled?","created_at":"2018-11-27T21:42:49Z","updated_at":"2018-11-27T21:45:32Z","html_url":"https://github.com/tapjs/node-tap/pull/481#discussion_r236858108","pull_request_url":"https://api.github.com/repos/tapjs/node-tap/pulls/481","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/comments/236858108"},"html":{"href":"https://github.com/tapjs/node-tap/pull/481#discussion_r236858108"},"pull_request":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/tapjs/node-tap/pulls/481","id":233291529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjkxNTI5","html_url":"https://github.com/tapjs/node-tap/pull/481","diff_url":"https://github.com/tapjs/node-tap/pull/481.diff","patch_url":"https://github.com/tapjs/node-tap/pull/481.patch","issue_url":"https://api.github.com/repos/tapjs/node-tap/issues/481","number":481,"state":"open","locked":false,"title":"Add easy and straightforward ts-node support","user":{"login":"ilyadoroshin","id":3414279,"node_id":"MDQ6VXNlcjM0MTQyNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3414279?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyadoroshin","html_url":"https://github.com/ilyadoroshin","followers_url":"https://api.github.com/users/ilyadoroshin/followers","following_url":"https://api.github.com/users/ilyadoroshin/following{/other_user}","gists_url":"https://api.github.com/users/ilyadoroshin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyadoroshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyadoroshin/subscriptions","organizations_url":"https://api.github.com/users/ilyadoroshin/orgs","repos_url":"https://api.github.com/users/ilyadoroshin/repos","events_url":"https://api.github.com/users/ilyadoroshin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyadoroshin/received_events","type":"User","site_admin":false},"body":"Long story short, it was really upsetting trying to setup tap to work with typescript. \r\n\r\nI've had a lot of difficulties running standalone test files with VSCode launch.json due to the fact that all my .test.ts needed shebang. It was a terrible mess.\r\n\r\nPlease find PR for new option --ts, --typescript that would run `node -r ts-node/register` on all your .ts files. \r\n\r\nExample of usage:\r\n```\r\nTS_NODE_PROJECT=./tsconfig.test.json ./node_modules/.bin/tap --reporter=spec --ts tests/**/*.test.ts\r\n```\r\n\r\nWorks like charm! And I can debug my test files with the following launch.json:\r\n```\r\n{\r\n  \"version\": \"0.2.0\",\r\n  \"configurations\": [\r\n    {\r\n      \"name\": \"Current TS Tests File\",\r\n      \"type\": \"node\",\r\n      \"request\": \"launch\",\r\n      \"protocol\": \"inspector\",\r\n      \"env\": {\r\n        \"TS_NODE_PROJECT\": \"tsconfig.test.json\"\r\n      },\r\n      \"args\": [\"${relativeFile}\"],\r\n      \"runtimeArgs\": [\"-r\", \"ts-node/register\"],\r\n      \"sourceMaps\": true,\r\n      \"cwd\": \"${workspaceRoot}\"\r\n    }\r\n  ]\r\n}\r\n```","created_at":"2018-11-24T00:09:08Z","updated_at":"2018-11-27T21:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e564a4c1fdc7420a5571fa864261485b835e4968","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tapjs/node-tap/pulls/481/commits","review_comments_url":"https://api.github.com/repos/tapjs/node-tap/pulls/481/comments","review_comment_url":"https://api.github.com/repos/tapjs/node-tap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tapjs/node-tap/issues/481/comments","statuses_url":"https://api.github.com/repos/tapjs/node-tap/statuses/78e0927afa4fb0d26dacd48c5068599fc5b3e8cc","head":{"label":"ilyadoroshin:master","ref":"master","sha":"78e0927afa4fb0d26dacd48c5068599fc5b3e8cc","user":{"login":"ilyadoroshin","id":3414279,"node_id":"MDQ6VXNlcjM0MTQyNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3414279?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyadoroshin","html_url":"https://github.com/ilyadoroshin","followers_url":"https://api.github.com/users/ilyadoroshin/followers","following_url":"https://api.github.com/users/ilyadoroshin/following{/other_user}","gists_url":"https://api.github.com/users/ilyadoroshin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyadoroshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyadoroshin/subscriptions","organizations_url":"https://api.github.com/users/ilyadoroshin/orgs","repos_url":"https://api.github.com/users/ilyadoroshin/repos","events_url":"https://api.github.com/users/ilyadoroshin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyadoroshin/received_events","type":"User","site_admin":false},"repo":{"id":158883905,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4ODM5MDU=","name":"node-tap","full_name":"ilyadoroshin/node-tap","private":false,"owner":{"login":"ilyadoroshin","id":3414279,"node_id":"MDQ6VXNlcjM0MTQyNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3414279?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyadoroshin","html_url":"https://github.com/ilyadoroshin","followers_url":"https://api.github.com/users/ilyadoroshin/followers","following_url":"https://api.github.com/users/ilyadoroshin/following{/other_user}","gists_url":"https://api.github.com/users/ilyadoroshin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyadoroshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyadoroshin/subscriptions","organizations_url":"https://api.github.com/users/ilyadoroshin/orgs","repos_url":"https://api.github.com/users/ilyadoroshin/repos","events_url":"https://api.github.com/users/ilyadoroshin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyadoroshin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ilyadoroshin/node-tap","description":"Test Anything Protocol tools for node","fork":true,"url":"https://api.github.com/repos/ilyadoroshin/node-tap","forks_url":"https://api.github.com/repos/ilyadoroshin/node-tap/forks","keys_url":"https://api.github.com/repos/ilyadoroshin/node-tap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilyadoroshin/node-tap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilyadoroshin/node-tap/teams","hooks_url":"https://api.github.com/repos/ilyadoroshin/node-tap/hooks","issue_events_url":"https://api.github.com/repos/ilyadoroshin/node-tap/issues/events{/number}","events_url":"https://api.github.com/repos/ilyadoroshin/node-tap/events","assignees_url":"https://api.github.com/repos/ilyadoroshin/node-tap/assignees{/user}","branches_url":"https://api.github.com/repos/ilyadoroshin/node-tap/branches{/branch}","tags_url":"https://api.github.com/repos/ilyadoroshin/node-tap/tags","blobs_url":"https://api.github.com/repos/ilyadoroshin/node-tap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilyadoroshin/node-tap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilyadoroshin/node-tap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilyadoroshin/node-tap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilyadoroshin/node-tap/statuses/{sha}","languages_url":"https://api.github.com/repos/ilyadoroshin/node-tap/languages","stargazers_url":"https://api.github.com/repos/ilyadoroshin/node-tap/stargazers","contributors_url":"https://api.github.com/repos/ilyadoroshin/node-tap/contributors","subscribers_url":"https://api.github.com/repos/ilyadoroshin/node-tap/subscribers","subscription_url":"https://api.github.com/repos/ilyadoroshin/node-tap/subscription","commits_url":"https://api.github.com/repos/ilyadoroshin/node-tap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilyadoroshin/node-tap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilyadoroshin/node-tap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilyadoroshin/node-tap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilyadoroshin/node-tap/contents/{+path}","compare_url":"https://api.github.com/repos/ilyadoroshin/node-tap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilyadoroshin/node-tap/merges","archive_url":"https://api.github.com/repos/ilyadoroshin/node-tap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilyadoroshin/node-tap/downloads","issues_url":"https://api.github.com/repos/ilyadoroshin/node-tap/issues{/number}","pulls_url":"https://api.github.com/repos/ilyadoroshin/node-tap/pulls{/number}","milestones_url":"https://api.github.com/repos/ilyadoroshin/node-tap/milestones{/number}","notifications_url":"https://api.github.com/repos/ilyadoroshin/node-tap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilyadoroshin/node-tap/labels{/name}","releases_url":"https://api.github.com/repos/ilyadoroshin/node-tap/releases{/id}","deployments_url":"https://api.github.com/repos/ilyadoroshin/node-tap/deployments","created_at":"2018-11-23T22:43:10Z","updated_at":"2018-11-24T12:17:38Z","pushed_at":"2018-11-24T12:17:36Z","git_url":"git://github.com/ilyadoroshin/node-tap.git","ssh_url":"git@github.com:ilyadoroshin/node-tap.git","clone_url":"https://github.com/ilyadoroshin/node-tap.git","svn_url":"https://github.com/ilyadoroshin/node-tap","homepage":"https://www.node-tap.org/","size":2393,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tapjs:master","ref":"master","sha":"0f9e31cf139e1de5171be1b4ad2fc6132db9b4df","user":{"login":"tapjs","id":16528145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTI4MTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/16528145?v=4","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1507818,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3ODE4","name":"node-tap","full_name":"tapjs/node-tap","private":false,"owner":{"login":"tapjs","id":16528145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTI4MTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/16528145?v=4","gravatar_id":"","url":"https://api.github.com/users/tapjs","html_url":"https://github.com/tapjs","followers_url":"https://api.github.com/users/tapjs/followers","following_url":"https://api.github.com/users/tapjs/following{/other_user}","gists_url":"https://api.github.com/users/tapjs/gists{/gist_id}","starred_url":"https://api.github.com/users/tapjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tapjs/subscriptions","organizations_url":"https://api.github.com/users/tapjs/orgs","repos_url":"https://api.github.com/users/tapjs/repos","events_url":"https://api.github.com/users/tapjs/events{/privacy}","received_events_url":"https://api.github.com/users/tapjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tapjs/node-tap","description":"Test Anything Protocol tools for node","fork":false,"url":"https://api.github.com/repos/tapjs/node-tap","forks_url":"https://api.github.com/repos/tapjs/node-tap/forks","keys_url":"https://api.github.com/repos/tapjs/node-tap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tapjs/node-tap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tapjs/node-tap/teams","hooks_url":"https://api.github.com/repos/tapjs/node-tap/hooks","issue_events_url":"https://api.github.com/repos/tapjs/node-tap/issues/events{/number}","events_url":"https://api.github.com/repos/tapjs/node-tap/events","assignees_url":"https://api.github.com/repos/tapjs/node-tap/assignees{/user}","branches_url":"https://api.github.com/repos/tapjs/node-tap/branches{/branch}","tags_url":"https://api.github.com/repos/tapjs/node-tap/tags","blobs_url":"https://api.github.com/repos/tapjs/node-tap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tapjs/node-tap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tapjs/node-tap/git/refs{/sha}","trees_url":"https://api.github.com/repos/tapjs/node-tap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tapjs/node-tap/statuses/{sha}","languages_url":"https://api.github.com/repos/tapjs/node-tap/languages","stargazers_url":"https://api.github.com/repos/tapjs/node-tap/stargazers","contributors_url":"https://api.github.com/repos/tapjs/node-tap/contributors","subscribers_url":"https://api.github.com/repos/tapjs/node-tap/subscribers","subscription_url":"https://api.github.com/repos/tapjs/node-tap/subscription","commits_url":"https://api.github.com/repos/tapjs/node-tap/commits{/sha}","git_commits_url":"https://api.github.com/repos/tapjs/node-tap/git/commits{/sha}","comments_url":"https://api.github.com/repos/tapjs/node-tap/comments{/number}","issue_comment_url":"https://api.github.com/repos/tapjs/node-tap/issues/comments{/number}","contents_url":"https://api.github.com/repos/tapjs/node-tap/contents/{+path}","compare_url":"https://api.github.com/repos/tapjs/node-tap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tapjs/node-tap/merges","archive_url":"https://api.github.com/repos/tapjs/node-tap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tapjs/node-tap/downloads","issues_url":"https://api.github.com/repos/tapjs/node-tap/issues{/number}","pulls_url":"https://api.github.com/repos/tapjs/node-tap/pulls{/number}","milestones_url":"https://api.github.com/repos/tapjs/node-tap/milestones{/number}","notifications_url":"https://api.github.com/repos/tapjs/node-tap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tapjs/node-tap/labels{/name}","releases_url":"https://api.github.com/repos/tapjs/node-tap/releases{/id}","deployments_url":"https://api.github.com/repos/tapjs/node-tap/deployments","created_at":"2011-03-21T18:02:54Z","updated_at":"2018-11-26T10:14:04Z","pushed_at":"2018-11-24T12:17:37Z","git_url":"git://github.com/tapjs/node-tap.git","ssh_url":"git@github.com:tapjs/node-tap.git","clone_url":"https://github.com/tapjs/node-tap.git","svn_url":"https://github.com/tapjs/node-tap","homepage":"https://www.node-tap.org/","size":2363,"stargazers_count":1277,"watchers_count":1277,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":179,"open_issues":68,"watchers":1277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/481"},"html":{"href":"https://github.com/tapjs/node-tap/pull/481"},"issue":{"href":"https://api.github.com/repos/tapjs/node-tap/issues/481"},"comments":{"href":"https://api.github.com/repos/tapjs/node-tap/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tapjs/node-tap/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/tapjs/node-tap/statuses/78e0927afa4fb0d26dacd48c5068599fc5b3e8cc"}},"author_association":"NONE"}}
{"actor":{"display_login":"isaacs"}}