{"action":"opened","issue":{"url":"https://api.github.com/repos/unbit/uwsgi/issues/1933","repository_url":"https://api.github.com/repos/unbit/uwsgi","labels_url":"https://api.github.com/repos/unbit/uwsgi/issues/1933/labels{/name}","comments_url":"https://api.github.com/repos/unbit/uwsgi/issues/1933/comments","events_url":"https://api.github.com/repos/unbit/uwsgi/issues/1933/events","html_url":"https://github.com/unbit/uwsgi/issues/1933","id":381718281,"node_id":"MDU6SXNzdWUzODE3MTgyODE=","number":1933,"title":"Commit cecfe60b1a8b099cea76e05082adbd933341bf14 breaks Solaris build","user":{"login":"sjthomason","id":18688453,"node_id":"MDQ6VXNlcjE4Njg4NDUz","avatar_url":"https://avatars0.githubusercontent.com/u/18688453?v=4","gravatar_id":"","url":"https://api.github.com/users/sjthomason","html_url":"https://github.com/sjthomason","followers_url":"https://api.github.com/users/sjthomason/followers","following_url":"https://api.github.com/users/sjthomason/following{/other_user}","gists_url":"https://api.github.com/users/sjthomason/gists{/gist_id}","starred_url":"https://api.github.com/users/sjthomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjthomason/subscriptions","organizations_url":"https://api.github.com/users/sjthomason/orgs","repos_url":"https://api.github.com/users/sjthomason/repos","events_url":"https://api.github.com/users/sjthomason/events{/privacy}","received_events_url":"https://api.github.com/users/sjthomason/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-16T18:49:58Z","updated_at":"2018-11-16T18:49:58Z","closed_at":null,"author_association":"NONE","body":"Solaris defines `sun` to 1 which results in a compilation error:\r\n`./uwsgi.h:1646:22: error: expected identifier or ‘(’ before numeric constant\r\n   struct sockaddr_un sun;\r\n`\r\nThe offending change is below:\r\n```diff --git a/uwsgi.h b/uwsgi.h\r\nindex 37b1e0f4..2df7e5c4 100755\r\n--- a/uwsgi.h\r\n+++ b/uwsgi.h\r\n@@ -1375,8 +1375,11 @@ struct wsgi_request {\r\n        char *appid;\r\n        uint16_t appid_len;\r\n \r\n-       //this is big enough to contain sockaddr_in\r\n-       struct sockaddr_un c_addr;\r\n+       union address {\r\n+               struct sockaddr_in sin;\r\n+               struct sockaddr_in6 sin6;\r\n+               struct sockaddr_un sun;\r\n+       } c_addr;```\r\n"}}
{"actor":{"display_login":"sjthomason"}}