{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/8292","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/8292/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/8292/comments","events_url":"https://api.github.com/repos/netty/netty/issues/8292/events","html_url":"https://github.com/netty/netty/pull/8292","id":360585746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzk0Njkz","number":8292,"title":"Fix incorrectly encoded empty SOCKS5 address","user":{"login":"Vampire","id":325196,"node_id":"MDQ6VXNlcjMyNTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/325196?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampire","html_url":"https://github.com/Vampire","followers_url":"https://api.github.com/users/Vampire/followers","following_url":"https://api.github.com/users/Vampire/following{/other_user}","gists_url":"https://api.github.com/users/Vampire/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampire/subscriptions","organizations_url":"https://api.github.com/users/Vampire/orgs","repos_url":"https://api.github.com/users/Vampire/repos","events_url":"https://api.github.com/users/Vampire/events{/privacy}","received_events_url":"https://api.github.com/users/Vampire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-15T23:39:43Z","updated_at":"2018-09-17T17:01:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/8292","html_url":"https://github.com/netty/netty/pull/8292","diff_url":"https://github.com/netty/netty/pull/8292.diff","patch_url":"https://github.com/netty/netty/pull/8292.patch"},"body":"Motivation:\n\nIf you encode a SOCKS5 message like `new DefaultSocks5CommandResponse(FAILURE, DOMAIN, \"\", 0)`\nyou correctly get a result of `05010003000000`.\nBut if the `bndAddr` is `null`, for example like `new DefaultSocks5CommandResponse(FAILURE, DOMAIN)`\nthe encoded result is `0501000301000000` which means the domain name has a length of one and consists of a 0-byte.\n\nModification:\n\nWith this commit it is also correctly encoded as a string of 0 length."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/422093033","html_url":"https://github.com/netty/netty/pull/8292#issuecomment-422093033","issue_url":"https://api.github.com/repos/netty/netty/issues/8292","id":422093033,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjA5MzAzMw==","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T17:01:10Z","updated_at":"2018-09-17T17:01:10Z","author_association":"MEMBER","body":"@Vampire can you please sign our ICLA and let me know once done ?\r\n\r\nhttps://netty.io/s/icla"}}
{"actor":{"display_login":"normanmaurer"}}