{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/232659052","pull_request_review_id":173901657,"id":232659052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjY1OTA1Mg==","diff_hunk":"@@ -1155,6 +1155,24 @@\n  */\n #define MBEDTLS_PKCS1_V21\n \n+/**\n+ * \\def MBEDTLS_PSA_CRYPTO_SPM\n+ *\n+ * When MBEDTLS_PSA_CRYPTO_SPM is defined, the code is built for SPM (Secure\n+ * Partition Manager) integration which separates the code into two parts: a\n+ * NSPE (Non-Secure Process Environment) and an SPE (Secure Process\n+ * Environment).\n+ *\n+ * \\warning This feature is experimental and available for evaluation only. It\n+ * is disabled by default. PSA APIs are subject to change. The implementation","path":"include/mbedtls/config.h","position":16,"original_position":13,"commit_id":"0d8221bda361bc3ce90d35810809aa256166a584","original_commit_id":"aed8ea82f13ed2e8cb4f5dca3a49f8fe9634f882","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"body":"Revised in a fixup commit","created_at":"2018-11-12T13:37:33Z","updated_at":"2018-11-12T13:37:34Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/2146#discussion_r232659052","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/232659052"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/2146#discussion_r232659052"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146"}},"in_reply_to_id":232618474},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146","id":226673460,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjczNDYw","html_url":"https://github.com/ARMmbed/mbedtls/pull/2146","diff_url":"https://github.com/ARMmbed/mbedtls/pull/2146.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/2146.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2146","number":2146,"state":"open","locked":false,"title":"Use Mbed Crypto as a submodule","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"body":"## Description\r\nUpdate Makefile and CMake build systems to support building and using libmbedcrypto as built from a submodule when `USE_CRYPTO_SUBMODULE` is defined.\r\n\r\nThis is intended to be merged after the next LTS release.\r\n\r\n### Design principles\r\n- Minimize changes to the existing Mbed TLS repository\r\n- New build option only changes behavior of build system when used (USE_CRYPTO_SUBMODULE)\r\n- Crypto still maintained in mbedtls for now, and only not used when USE_CRYPTO_SUBMODULE is defined\r\n- Why not use crypto from mbedtls-psa yet? We don't want to cause build system issues.\r\n\r\n### How to use\r\n- `make USE_CRYPTO_SUBMODULE:=1 test` -> Build and test both Mbed TLS and Mbed Crypto, using libmbedcrypto from the \"crypto\" submodule\r\n- `cmake -DUSE_CRYPTO_SUBMODULE=1 ..` -> Create build files that build libmbedcrypto in the \"crypto\" submodule and use it\r\n\r\n### Funny things\r\n- version.c is only included in libmbedcrypto\r\n- oid.c is in libmbedcrypto\r\n- error.c is in libmbedcrypto, and must know about SSL errors\r\n- A run of all.sh with `USE_CRYPTO_SUBMODULE:=1` may not work yet\r\n\r\n## Status\r\n**IN DEVELOPMENT**\r\n\r\nDon't merge. This is waiting for the Mbed Crypto repo to be ready and go public.\r\n\r\n## Requires Backporting\r\nNO\r\n\r\n## Migrations\r\nThere are no intended API or ABI changes when the default configuration is used. When `USE_CRYPTO_SUBMODULE` is used, the only intended API change is for adding PSA APIs. These intentions have not yet been tested.\r\n\r\n## Todos\r\n- [x] Tests\r\n- [x] Documentation\r\n- [x] Changelog updated\r\n\r\n","created_at":"2018-10-29T18:47:27Z","updated_at":"2018-11-12T13:37:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2adebc4498e35b2b32459bd92a86218070cf1f65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andresag01","id":3746901,"node_id":"MDQ6VXNlcjM3NDY5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},{"login":"hanno-arm","id":26892988,"node_id":"MDQ6VXNlcjI2ODkyOTg4","avatar_url":"https://avatars1.githubusercontent.com/u/26892988?v=4","gravatar_id":"","url":"https://api.github.com/users/hanno-arm","html_url":"https://github.com/hanno-arm","followers_url":"https://api.github.com/users/hanno-arm/followers","following_url":"https://api.github.com/users/hanno-arm/following{/other_user}","gists_url":"https://api.github.com/users/hanno-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/hanno-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanno-arm/subscriptions","organizations_url":"https://api.github.com/users/hanno-arm/orgs","repos_url":"https://api.github.com/users/hanno-arm/repos","events_url":"https://api.github.com/users/hanno-arm/events{/privacy}","received_events_url":"https://api.github.com/users/hanno-arm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":772797329,"node_id":"MDU6TGFiZWw3NzI3OTczMjk=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"DF013A","default":false},{"id":937148743,"node_id":"MDU6TGFiZWw5MzcxNDg3NDM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Crypto","name":"component: Crypto","color":"F5F6CE","default":false},{"id":937149694,"node_id":"MDU6TGFiZWw5MzcxNDk2OTQ=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Platform","name":"component: Platform","color":"F6CED8","default":false},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":685773676,"node_id":"MDU6TGFiZWw2ODU3NzM2NzY=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20design%20approval","name":"needs design approval","color":"5319e7","default":false},{"id":435765575,"node_id":"MDU6TGFiZWw0MzU3NjU1NzU=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2146/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/0d8221bda361bc3ce90d35810809aa256166a584","head":{"label":"Patater:dev/Patater/use-crypto-submodule","ref":"dev/Patater/use-crypto-submodule","sha":"0d8221bda361bc3ce90d35810809aa256166a584","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"repo":{"id":104342405,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzNDI0MDU=","name":"mbedtls","full_name":"Patater/mbedtls","private":false,"owner":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Patater/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/Patater/mbedtls","forks_url":"https://api.github.com/repos/Patater/mbedtls/forks","keys_url":"https://api.github.com/repos/Patater/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Patater/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Patater/mbedtls/teams","hooks_url":"https://api.github.com/repos/Patater/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/Patater/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/Patater/mbedtls/events","assignees_url":"https://api.github.com/repos/Patater/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/Patater/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/Patater/mbedtls/tags","blobs_url":"https://api.github.com/repos/Patater/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Patater/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Patater/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/Patater/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Patater/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/Patater/mbedtls/languages","stargazers_url":"https://api.github.com/repos/Patater/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/Patater/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/Patater/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/Patater/mbedtls/subscription","commits_url":"https://api.github.com/repos/Patater/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/Patater/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/Patater/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/Patater/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/Patater/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/Patater/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Patater/mbedtls/merges","archive_url":"https://api.github.com/repos/Patater/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Patater/mbedtls/downloads","issues_url":"https://api.github.com/repos/Patater/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/Patater/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/Patater/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/Patater/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Patater/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/Patater/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/Patater/mbedtls/deployments","created_at":"2017-09-21T11:58:06Z","updated_at":"2018-08-17T15:18:23Z","pushed_at":"2018-11-12T13:36:17Z","git_url":"git://github.com/Patater/mbedtls.git","ssh_url":"git@github.com:Patater/mbedtls.git","clone_url":"https://github.com/Patater/mbedtls.git","svn_url":"https://github.com/Patater/mbedtls","homepage":"https://tls.mbed.org","size":31592,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"06f88e9c422a06571b6169ec02892f1217e845e6","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"node_id":"MDEwOlJlcG9zaXRvcnk2Njg3OTM2","name":"mbedtls","full_name":"ARMmbed/mbedtls","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-11-12T11:57:07Z","pushed_at":"2018-11-12T13:36:20Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":32671,"stargazers_count":1633,"watchers_count":1633,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":968,"mirror_url":null,"archived":false,"open_issues_count":570,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":968,"open_issues":570,"watchers":1633,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/2146"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2146"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2146/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2146/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/0d8221bda361bc3ce90d35810809aa256166a584"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Patater"}}