{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/202785629","pull_request_review_id":137544643,"id":202785629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc4NTYyOQ==","diff_hunk":"@@ -0,0 +1,179 @@\n+#pragma once\n+\n+#include \"caffe2/core/operator.h\"\n+\n+namespace caffe2 {\n+\n+template <typename Context>\n+void adadelta_update(\n+    int N,\n+    const float* w,\n+    const float* g,\n+    const float* h,\n+    const float* d,\n+    float* nw,\n+    float* nh,\n+    float* nd,\n+    float epsilon,\n+    float decay,\n+    const float* lr,\n+    Context* /*context*/) {\n+  for (auto i = 0; i < N; ++i) {\n+    float gi = g[i];\n+    float di = d[i];\n+    float hi = nh[i] = decay * h[i] + (1.0f - decay) * gi * gi;","path":"caffe2/sgd/adadelta_op.h","position":24,"original_position":24,"commit_id":"92f3b6d535fcadf55a7e60c862887e0309906883","original_commit_id":"92f3b6d535fcadf55a7e60c862887e0309906883","user":{"login":"BIT-silence","id":3357667,"node_id":"MDQ6VXNlcjMzNTc2Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/3357667?v=4","gravatar_id":"","url":"https://api.github.com/users/BIT-silence","html_url":"https://github.com/BIT-silence","followers_url":"https://api.github.com/users/BIT-silence/followers","following_url":"https://api.github.com/users/BIT-silence/following{/other_user}","gists_url":"https://api.github.com/users/BIT-silence/gists{/gist_id}","starred_url":"https://api.github.com/users/BIT-silence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BIT-silence/subscriptions","organizations_url":"https://api.github.com/users/BIT-silence/orgs","repos_url":"https://api.github.com/users/BIT-silence/repos","events_url":"https://api.github.com/users/BIT-silence/events{/privacy}","received_events_url":"https://api.github.com/users/BIT-silence/received_events","type":"User","site_admin":false},"body":"Split it into two separate lines.","created_at":"2018-07-16T18:51:10Z","updated_at":"2018-07-16T18:56:52Z","html_url":"https://github.com/pytorch/pytorch/pull/9088#discussion_r202785629","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9088","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/202785629"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9088#discussion_r202785629"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9088"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/9088","id":198559321,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTU5MzIx","html_url":"https://github.com/pytorch/pytorch/pull/9088","diff_url":"https://github.com/pytorch/pytorch/pull/9088.diff","patch_url":"https://github.com/pytorch/pytorch/pull/9088.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/9088","number":9088,"state":"open","locked":false,"title":"Add Adadelta optimizer to caffe2","user":{"login":"sidgoyal78","id":6762570,"node_id":"MDQ6VXNlcjY3NjI1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6762570?v=4","gravatar_id":"","url":"https://api.github.com/users/sidgoyal78","html_url":"https://github.com/sidgoyal78","followers_url":"https://api.github.com/users/sidgoyal78/followers","following_url":"https://api.github.com/users/sidgoyal78/following{/other_user}","gists_url":"https://api.github.com/users/sidgoyal78/gists{/gist_id}","starred_url":"https://api.github.com/users/sidgoyal78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidgoyal78/subscriptions","organizations_url":"https://api.github.com/users/sidgoyal78/orgs","repos_url":"https://api.github.com/users/sidgoyal78/repos","events_url":"https://api.github.com/users/sidgoyal78/events{/privacy}","received_events_url":"https://api.github.com/users/sidgoyal78/received_events","type":"User","site_admin":false},"body":"Summary:\n- Added CPU/GPU implementations of Adadelta and SparseAdadelta.\n- Added corresponding Python unittests\n\nDifferential Revision: D8712169\n","created_at":"2018-07-02T02:30:04Z","updated_at":"2018-07-16T18:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f9d5a6ae335f830a7d284068c676d662f3845c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":890282107,"node_id":"MDU6TGFiZWw4OTAyODIxMDc=","url":"https://api.github.com/repos/pytorch/pytorch/labels/caffe2","name":"caffe2","color":"210aa8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9088/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9088/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/9088/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/92f3b6d535fcadf55a7e60c862887e0309906883","head":{"label":"sidgoyal78:export-D8712169","ref":"export-D8712169","sha":"92f3b6d535fcadf55a7e60c862887e0309906883","user":{"login":"sidgoyal78","id":6762570,"node_id":"MDQ6VXNlcjY3NjI1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6762570?v=4","gravatar_id":"","url":"https://api.github.com/users/sidgoyal78","html_url":"https://github.com/sidgoyal78","followers_url":"https://api.github.com/users/sidgoyal78/followers","following_url":"https://api.github.com/users/sidgoyal78/following{/other_user}","gists_url":"https://api.github.com/users/sidgoyal78/gists{/gist_id}","starred_url":"https://api.github.com/users/sidgoyal78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidgoyal78/subscriptions","organizations_url":"https://api.github.com/users/sidgoyal78/orgs","repos_url":"https://api.github.com/users/sidgoyal78/repos","events_url":"https://api.github.com/users/sidgoyal78/events{/privacy}","received_events_url":"https://api.github.com/users/sidgoyal78/received_events","type":"User","site_admin":false},"repo":{"id":137324891,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMjQ4OTE=","name":"pytorch","full_name":"sidgoyal78/pytorch","owner":{"login":"sidgoyal78","id":6762570,"node_id":"MDQ6VXNlcjY3NjI1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6762570?v=4","gravatar_id":"","url":"https://api.github.com/users/sidgoyal78","html_url":"https://github.com/sidgoyal78","followers_url":"https://api.github.com/users/sidgoyal78/followers","following_url":"https://api.github.com/users/sidgoyal78/following{/other_user}","gists_url":"https://api.github.com/users/sidgoyal78/gists{/gist_id}","starred_url":"https://api.github.com/users/sidgoyal78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidgoyal78/subscriptions","organizations_url":"https://api.github.com/users/sidgoyal78/orgs","repos_url":"https://api.github.com/users/sidgoyal78/repos","events_url":"https://api.github.com/users/sidgoyal78/events{/privacy}","received_events_url":"https://api.github.com/users/sidgoyal78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sidgoyal78/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/sidgoyal78/pytorch","forks_url":"https://api.github.com/repos/sidgoyal78/pytorch/forks","keys_url":"https://api.github.com/repos/sidgoyal78/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sidgoyal78/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sidgoyal78/pytorch/teams","hooks_url":"https://api.github.com/repos/sidgoyal78/pytorch/hooks","issue_events_url":"https://api.github.com/repos/sidgoyal78/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/sidgoyal78/pytorch/events","assignees_url":"https://api.github.com/repos/sidgoyal78/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/sidgoyal78/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/sidgoyal78/pytorch/tags","blobs_url":"https://api.github.com/repos/sidgoyal78/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sidgoyal78/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sidgoyal78/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/sidgoyal78/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sidgoyal78/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/sidgoyal78/pytorch/languages","stargazers_url":"https://api.github.com/repos/sidgoyal78/pytorch/stargazers","contributors_url":"https://api.github.com/repos/sidgoyal78/pytorch/contributors","subscribers_url":"https://api.github.com/repos/sidgoyal78/pytorch/subscribers","subscription_url":"https://api.github.com/repos/sidgoyal78/pytorch/subscription","commits_url":"https://api.github.com/repos/sidgoyal78/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/sidgoyal78/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/sidgoyal78/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/sidgoyal78/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/sidgoyal78/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/sidgoyal78/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sidgoyal78/pytorch/merges","archive_url":"https://api.github.com/repos/sidgoyal78/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sidgoyal78/pytorch/downloads","issues_url":"https://api.github.com/repos/sidgoyal78/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/sidgoyal78/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/sidgoyal78/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/sidgoyal78/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sidgoyal78/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/sidgoyal78/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/sidgoyal78/pytorch/deployments","created_at":"2018-06-14T07:51:50Z","updated_at":"2018-06-14T07:52:02Z","pushed_at":"2018-07-11T23:22:45Z","git_url":"git://github.com/sidgoyal78/pytorch.git","ssh_url":"git@github.com:sidgoyal78/pytorch.git","clone_url":"https://github.com/sidgoyal78/pytorch.git","svn_url":"https://github.com/sidgoyal78/pytorch","homepage":"http://pytorch.org","size":62512,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"94bc4c6091ed3ef0a8ac7548179045f624504841","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-07-16T18:43:22Z","pushed_at":"2018-07-16T18:55:46Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":63071,"stargazers_count":17137,"watchers_count":17137,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3981,"mirror_url":null,"archived":false,"open_issues_count":1436,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3981,"open_issues":1436,"watchers":17137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9088"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9088"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9088"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9088/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9088/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9088/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/92f3b6d535fcadf55a7e60c862887e0309906883"}},"author_association":"NONE"}}
{"actor":{"display_login":"BIT-silence"}}