{"action":"created","issue":{"url":"https://api.github.com/repos/withspectrum/spectrum/issues/3382","repository_url":"https://api.github.com/repos/withspectrum/spectrum","labels_url":"https://api.github.com/repos/withspectrum/spectrum/issues/3382/labels{/name}","comments_url":"https://api.github.com/repos/withspectrum/spectrum/issues/3382/comments","events_url":"https://api.github.com/repos/withspectrum/spectrum/issues/3382/events","html_url":"https://github.com/withspectrum/spectrum/pull/3382","id":335091245,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODk2MjEx","number":3382,"title":"Maybe fix ?t param","user":{"login":"mxstbr","id":7525670,"node_id":"MDQ6VXNlcjc1MjU2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7525670?v=4","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"labels":[{"id":737428259,"node_id":"MDU6TGFiZWw3Mzc0MjgyNTk=","url":"https://api.github.com/repos/withspectrum/spectrum/labels/Ready%20for%20Review","name":"Ready for Review","color":"00b88b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-23T11:05:52Z","updated_at":"2018-06-25T09:31:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/withspectrum/spectrum/pulls/3382","html_url":"https://github.com/withspectrum/spectrum/pull/3382","diff_url":"https://github.com/withspectrum/spectrum/pull/3382.diff","patch_url":"https://github.com/withspectrum/spectrum/pull/3382.patch"},"body":"<!-- FILL OUT THE BELOW FORM OR YOUR PR WILL BE AUTOMATICALLY CLOSED -->\n**Status**\n- [ ] WIP\n- [x] Ready for review\n- [ ] Needs testing\n\n**Deploy after merge (delete what needn't be deployed)**\n- api\n- hyperion (frontend)\n\n**Related issues (delete if you don't know of any)**\nRef #3303\n\n@brianlovin 63ad628db _should_ fix the `?t` query param even when SSR'ing I think? I haven't been able to verify because I can't seem to log into the SSR'd site locally anymore. (not sure why) Further down below we check `(hasThreadsButNoneSelected || loadedNewThreads)` before selecting the first thread, which means even if one was selected as soon as new ones load in it would select the first one, right? So this new condition should make sure that doesn't happen if we mounted with that thread."},"comment":{"url":"https://api.github.com/repos/withspectrum/spectrum/issues/comments/399890687","html_url":"https://github.com/withspectrum/spectrum/pull/3382#issuecomment-399890687","issue_url":"https://api.github.com/repos/withspectrum/spectrum/issues/3382","id":399890687,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTg5MDY4Nw==","user":{"login":"mxstbr","id":7525670,"node_id":"MDQ6VXNlcjc1MjU2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7525670?v=4","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T09:31:14Z","updated_at":"2018-06-25T09:31:14Z","author_association":"MEMBER","body":"Working on one last problem: the loading state in the thread feed after SSR is finished.\r\n\r\n![](https://i.imgur.com/M5dRTLB.gif)\r\n\r\nNote how it shows the loading state even though all the threads are already loaded—it should just be doing that in the background. "}}
{"actor":{"display_login":"mxstbr"}}