{"action":"created","issue":{"url":"https://api.github.com/repos/scionproto/scion/issues/1447","repository_url":"https://api.github.com/repos/scionproto/scion","labels_url":"https://api.github.com/repos/scionproto/scion/issues/1447/labels{/name}","comments_url":"https://api.github.com/repos/scionproto/scion/issues/1447/comments","events_url":"https://api.github.com/repos/scionproto/scion/issues/1447/events","html_url":"https://github.com/scionproto/scion/pull/1447","id":303904900,"number":1447,"title":"SCIOND and e2etest skeleton","user":{"login":"scrye","id":3823299,"avatar_url":"https://avatars3.githubusercontent.com/u/3823299?v=4","gravatar_id":"","url":"https://api.github.com/users/scrye","html_url":"https://github.com/scrye","followers_url":"https://api.github.com/users/scrye/followers","following_url":"https://api.github.com/users/scrye/following{/other_user}","gists_url":"https://api.github.com/users/scrye/gists{/gist_id}","starred_url":"https://api.github.com/users/scrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrye/subscriptions","organizations_url":"https://api.github.com/users/scrye/orgs","repos_url":"https://api.github.com/users/scrye/repos","events_url":"https://api.github.com/users/scrye/events{/privacy}","received_events_url":"https://api.github.com/users/scrye/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"scrye","id":3823299,"avatar_url":"https://avatars3.githubusercontent.com/u/3823299?v=4","gravatar_id":"","url":"https://api.github.com/users/scrye","html_url":"https://github.com/scrye","followers_url":"https://api.github.com/users/scrye/followers","following_url":"https://api.github.com/users/scrye/following{/other_user}","gists_url":"https://api.github.com/users/scrye/gists{/gist_id}","starred_url":"https://api.github.com/users/scrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrye/subscriptions","organizations_url":"https://api.github.com/users/scrye/orgs","repos_url":"https://api.github.com/users/scrye/repos","events_url":"https://api.github.com/users/scrye/events{/privacy}","received_events_url":"https://api.github.com/users/scrye/received_events","type":"User","site_admin":false},"assignees":[{"login":"scrye","id":3823299,"avatar_url":"https://avatars3.githubusercontent.com/u/3823299?v=4","gravatar_id":"","url":"https://api.github.com/users/scrye","html_url":"https://github.com/scrye","followers_url":"https://api.github.com/users/scrye/followers","following_url":"https://api.github.com/users/scrye/following{/other_user}","gists_url":"https://api.github.com/users/scrye/gists{/gist_id}","starred_url":"https://api.github.com/users/scrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrye/subscriptions","organizations_url":"https://api.github.com/users/scrye/orgs","repos_url":"https://api.github.com/users/scrye/repos","events_url":"https://api.github.com/users/scrye/events{/privacy}","received_events_url":"https://api.github.com/users/scrye/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-03-09T16:46:23Z","updated_at":"2018-04-25T16:13:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scionproto/scion/pulls/1447","html_url":"https://github.com/scionproto/scion/pull/1447","diff_url":"https://github.com/scionproto/scion/pull/1447.diff","patch_url":"https://github.com/scionproto/scion/pull/1447.patch"},"body":"Very rough around the edges for now, basically just a proposal draft for how services can be tested and be built to share as much code as possible.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scionproto/scion/1447)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/scionproto/scion/issues/comments/384344394","html_url":"https://github.com/scionproto/scion/pull/1447#issuecomment-384344394","issue_url":"https://api.github.com/repos/scionproto/scion/issues/1447","id":384344394,"user":{"login":"scrye","id":3823299,"avatar_url":"https://avatars3.githubusercontent.com/u/3823299?v=4","gravatar_id":"","url":"https://api.github.com/users/scrye","html_url":"https://github.com/scrye","followers_url":"https://api.github.com/users/scrye/followers","following_url":"https://api.github.com/users/scrye/following{/other_user}","gists_url":"https://api.github.com/users/scrye/gists{/gist_id}","starred_url":"https://api.github.com/users/scrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrye/subscriptions","organizations_url":"https://api.github.com/users/scrye/orgs","repos_url":"https://api.github.com/users/scrye/repos","events_url":"https://api.github.com/users/scrye/events{/privacy}","received_events_url":"https://api.github.com/users/scrye/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T16:13:08Z","updated_at":"2018-04-25T16:13:08Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[go/sciond/internal/servers/unix.go, line 49 at r3](https://reviewable.io/reviews/scionproto/scion/1447#-LArNhE12QKTSjfjQNF5:-LAxXfOS5iGbW8qdYlmV:b-l7awzr) ([raw file](https://github.com/scionproto/scion/blob/39fc12e22e6da11f3602e9573fce5c607a663d4c/go/sciond/internal/servers/unix.go#L49)):*\nThe dispatcher is a different beast, and there `SOCK_SEQPACKET` makes perfect sense. I don't think having the same socket type helps though. For example, in Go the only difference is changing `unixgram` to `unixpacket`, and not running the connect and accept loop. It leads to much cleaner code for sciond.\n\n>  don't think this works. sciond would need to remove the socket file on shutdown (or if it was unclean, systemd etc would need to remove the socket file on start), otherwise bind() fails (as bind creates the file, and fails if it already exists).\n\nsciond doesn't need to remove the socket on shutdown. As you point out, both not having the file and nobody listening on it yields the same error, \"connection refused\". Most apps just delete the socket before trying to bind (e.g., `syslogd` does this). I tested this out and it works ok.\n\nGo toy example here: https://gist.github.com/scrye/dda0565722d88bdbc9dbde29812c553b. Server can restart multiple times, and the client can just keeps sending.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/scionproto/scion/1447)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"scrye"}}