{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/8517","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/8517/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/8517/comments","events_url":"https://api.github.com/repos/helm/charts/issues/8517/events","html_url":"https://github.com/helm/charts/pull/8517","id":370861574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDQyNjM2","number":8517,"title":"stable/kibana: Fix logic on JSON test, clarify log messages","user":{"login":"zdw","id":60856,"node_id":"MDQ6VXNlcjYwODU2","avatar_url":"https://avatars0.githubusercontent.com/u/60856?v=4","gravatar_id":"","url":"https://api.github.com/users/zdw","html_url":"https://github.com/zdw","followers_url":"https://api.github.com/users/zdw/followers","following_url":"https://api.github.com/users/zdw/following{/other_user}","gists_url":"https://api.github.com/users/zdw/gists{/gist_id}","starred_url":"https://api.github.com/users/zdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdw/subscriptions","organizations_url":"https://api.github.com/users/zdw/orgs","repos_url":"https://api.github.com/users/zdw/repos","events_url":"https://api.github.com/users/zdw/events{/privacy}","received_events_url":"https://api.github.com/users/zdw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-17T01:28:11Z","updated_at":"2018-10-17T01:28:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/8517","html_url":"https://github.com/helm/charts/pull/8517","diff_url":"https://github.com/helm/charts/pull/8517.diff","patch_url":"https://github.com/helm/charts/pull/8517.patch"},"body":"#### What this PR does / why we need it:\r\n\r\nThe test for correct JSON in a kibana dashboard that runs as a part of the init container isn't working, as the test subshell is wrapped in quotes, and a non-empty string is always `true` in shell.\r\n\r\nThis patchset fixes the JSON validity check.\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/430457077","html_url":"https://github.com/helm/charts/pull/8517#issuecomment-430457077","issue_url":"https://api.github.com/repos/helm/charts/issues/8517","id":430457077,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDQ1NzA3Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T01:28:19Z","updated_at":"2018-10-17T01:28:19Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/8517#\" title=\"Author self-approved\">zdw</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **compleatang**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @compleatang` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[stable/kibana/OWNERS](https://github.com/helm/charts/blob/master/stable/kibana/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"compleatang\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}