{"action":"created","comment":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/204205133","pull_request_review_id":139251950,"id":204205133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIwNTEzMw==","diff_hunk":"@@ -37,7 +38,7 @@ public ComParameter(ITypeInfo info, ELEMDESC elemDesc, string name, int index) :\n             var paramDesc = elemDesc.desc.paramdesc;\n             IsOptional = paramDesc.wParamFlags.HasFlag(PARAMFLAG.PARAMFLAG_FOPT);\n             IsReturnValue = paramDesc.wParamFlags.HasFlag(PARAMFLAG.PARAMFLAG_FRETVAL);\n-            IsByRef = (VarEnum) elemDesc.tdesc.vt == VarEnum.VT_PTR;\n+            IsByRef = Convert.ToBoolean(elemDesc.tdesc.vt & (int)VarEnum.VT_PTR);","path":"Rubberduck.Parsing/ComReflection/ComParameter.cs","position":null,"original_position":12,"commit_id":"e7e2593aa392beb57f0a1548bff99105b590c3a0","original_commit_id":"e7e2593aa392beb57f0a1548bff99105b590c3a0","user":{"login":"WaynePhillipsEA","id":25738109,"node_id":"MDQ6VXNlcjI1NzM4MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/25738109?v=4","gravatar_id":"","url":"https://api.github.com/users/WaynePhillipsEA","html_url":"https://github.com/WaynePhillipsEA","followers_url":"https://api.github.com/users/WaynePhillipsEA/followers","following_url":"https://api.github.com/users/WaynePhillipsEA/following{/other_user}","gists_url":"https://api.github.com/users/WaynePhillipsEA/gists{/gist_id}","starred_url":"https://api.github.com/users/WaynePhillipsEA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WaynePhillipsEA/subscriptions","organizations_url":"https://api.github.com/users/WaynePhillipsEA/orgs","repos_url":"https://api.github.com/users/WaynePhillipsEA/repos","events_url":"https://api.github.com/users/WaynePhillipsEA/events{/privacy}","received_events_url":"https://api.github.com/users/WaynePhillipsEA/received_events","type":"User","site_admin":false},"body":"I believe this test should be more like:   vt & VT_TYPEMASK == VT_PTR","created_at":"2018-07-21T07:46:43Z","updated_at":"2018-07-21T07:51:41Z","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4211#discussion_r204205133","pull_request_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/204205133"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4211#discussion_r204205133"},"pull_request":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211"}}},"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211","id":202449450,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDQ5NDUw","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4211","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4211.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4211.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4211","number":4211,"state":"open","locked":false,"title":"Clean up COM Collector","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"body":"Getting ready to address some more type naming issues - see #2775 and #1328. Also did some small (but surprisingly effective) performance tweaks.","created_at":"2018-07-19T05:35:19Z","updated_at":"2018-07-21T07:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"492730d58b2c0dc667f6e33f561d0d4087433611","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":765543834,"node_id":"MDU6TGFiZWw3NjU1NDM4MzQ=","url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels/PR-Status:%20WIP","name":"PR-Status: WIP","color":"584daf","default":false},{"id":997780241,"node_id":"MDU6TGFiZWw5OTc3ODAyNDE=","url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels/typeinfo-processing","name":"typeinfo-processing","color":"dfdfdf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4211/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/e7e2593aa392beb57f0a1548bff99105b590c3a0","head":{"label":"comintern:next","ref":"next","sha":"e7e2593aa392beb57f0a1548bff99105b590c3a0","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"repo":{"id":55346398,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM0NjM5OA==","name":"Rubberduck","full_name":"comintern/Rubberduck","owner":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comintern/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/comintern/Rubberduck","forks_url":"https://api.github.com/repos/comintern/Rubberduck/forks","keys_url":"https://api.github.com/repos/comintern/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comintern/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comintern/Rubberduck/teams","hooks_url":"https://api.github.com/repos/comintern/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/comintern/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/comintern/Rubberduck/events","assignees_url":"https://api.github.com/repos/comintern/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/comintern/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/comintern/Rubberduck/tags","blobs_url":"https://api.github.com/repos/comintern/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comintern/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comintern/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/comintern/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comintern/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/comintern/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/comintern/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/comintern/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/comintern/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/comintern/Rubberduck/subscription","commits_url":"https://api.github.com/repos/comintern/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/comintern/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/comintern/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/comintern/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/comintern/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/comintern/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comintern/Rubberduck/merges","archive_url":"https://api.github.com/repos/comintern/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comintern/Rubberduck/downloads","issues_url":"https://api.github.com/repos/comintern/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/comintern/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/comintern/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/comintern/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comintern/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/comintern/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/comintern/Rubberduck/deployments","created_at":"2016-04-03T12:57:26Z","updated_at":"2018-07-21T05:54:37Z","pushed_at":"2018-07-21T05:54:28Z","git_url":"git://github.com/comintern/Rubberduck.git","ssh_url":"git@github.com:comintern/Rubberduck.git","clone_url":"https://github.com/comintern/Rubberduck.git","svn_url":"https://github.com/comintern/Rubberduck","homepage":"","size":65288,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"9d5f49a5e60e66eed77236da94402087a9dd86c0","user":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgwMDEyOA==","name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","owner":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2018-07-19T02:26:57Z","pushed_at":"2018-07-21T05:54:30Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":64939,"stargazers_count":616,"watchers_count":616,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":730,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":156,"open_issues":730,"watchers":616,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4211"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4211"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4211/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4211/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/e7e2593aa392beb57f0a1548bff99105b590c3a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"WaynePhillipsEA"}}