{"action":"created","issue":{"url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1150","repository_url":"https://api.github.com/repos/drwetter/testssl.sh","labels_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1150/labels{/name}","comments_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1150/comments","events_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1150/events","html_url":"https://github.com/drwetter/testssl.sh/issues/1150","id":375733223,"node_id":"MDU6SXNzdWUzNzU3MzMyMjM=","number":1150,"title":"Nice to have: equiv of JSON property \"target host\" w/ no spaces","user":{"login":"bitsofinfo","id":1743646,"node_id":"MDQ6VXNlcjE3NDM2NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1743646?v=4","gravatar_id":"","url":"https://api.github.com/users/bitsofinfo","html_url":"https://github.com/bitsofinfo","followers_url":"https://api.github.com/users/bitsofinfo/followers","following_url":"https://api.github.com/users/bitsofinfo/following{/other_user}","gists_url":"https://api.github.com/users/bitsofinfo/gists{/gist_id}","starred_url":"https://api.github.com/users/bitsofinfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitsofinfo/subscriptions","organizations_url":"https://api.github.com/users/bitsofinfo/orgs","repos_url":"https://api.github.com/users/bitsofinfo/repos","events_url":"https://api.github.com/users/bitsofinfo/events{/privacy}","received_events_url":"https://api.github.com/users/bitsofinfo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T23:13:51Z","updated_at":"2018-11-06T09:20:00Z","closed_at":null,"author_association":"NONE","body":"With `--json*` arguments the resulting JSON's `\"target host\"` property is not parseable by certain libraries tools due to the space in it.\r\n\r\n```{\r\n          \"Invocation\"  : \"testssl.sh --logfile .........\",\r\n          \"at\"          : \"ABCD.........\",\r\n          \"version\"     : \"3.0rc2 7adc1b6 from 2018-10-29\",\r\n          \"openssl\"     : \"OpenSSL 1.0.2-chacha from Sep  7 19:34:54 2016\",\r\n          \"startTime\"   : \"1540838810\",\r\n          \"scanResult\"  : [\r\n          {\r\n                    \"target host\"     : \"whatever.com\",\r\n                    \"ip\"              : \"192.168.0.1\",\r\n                    \"port\"            : \"443\",\r\n                    ....\r\n```\r\n\r\n3. what did you expect instead?\r\n\r\nWould be nice to see something like this instead: (retaining existing name for back compat)\r\n\r\n```{\r\n          \"Invocation\"  : \"testssl.sh --logfile .........\",\r\n          \"at\"          : \"ABCD.........\",\r\n          \"version\"     : \"3.0rc2 7adc1b6 from 2018-10-29\",\r\n          \"openssl\"     : \"OpenSSL 1.0.2-chacha from Sep  7 19:34:54 2016\",\r\n          \"startTime\"   : \"1540838810\",\r\n          \"scanResult\"  : [\r\n          {\r\n                    \"targetHost\"     : \"whatever.com\",\r\n                    \"target host\"     : \"whatever.com\",\r\n                    \"ip\"              : \"192.168.0.1\",\r\n                    \"port\"            : \"443\",\r\n                    ....\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/drwetter/testssl.sh/issues/comments/436183953","html_url":"https://github.com/drwetter/testssl.sh/issues/1150#issuecomment-436183953","issue_url":"https://api.github.com/repos/drwetter/testssl.sh/issues/1150","id":436183953,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjE4Mzk1Mw==","user":{"login":"drwetter","id":8036727,"node_id":"MDQ6VXNlcjgwMzY3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8036727?v=4","gravatar_id":"","url":"https://api.github.com/users/drwetter","html_url":"https://github.com/drwetter","followers_url":"https://api.github.com/users/drwetter/followers","following_url":"https://api.github.com/users/drwetter/following{/other_user}","gists_url":"https://api.github.com/users/drwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/drwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwetter/subscriptions","organizations_url":"https://api.github.com/users/drwetter/orgs","repos_url":"https://api.github.com/users/drwetter/repos","events_url":"https://api.github.com/users/drwetter/events{/privacy}","received_events_url":"https://api.github.com/users/drwetter/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T09:20:00Z","updated_at":"2018-11-06T09:20:00Z","author_association":"OWNER","body":"a) Seems your JSON parser is broken  ;-)\r\nb) But you're right, looks more consequently changing this. :-) \r\n\r\nI would rather like to remove the legacy target name then too. It has been introduced not a long time ago\r\n\r\n@ all: heads up. This is a warning for a possible breaking change..``target host`` will be changed ~today  to ``targetHost``"}}
{"actor":{"display_login":"drwetter"}}