{"push_id":2399262344,"size":83,"distinct_size":83,"ref":"refs/heads/master","head":"1435f32a0830addbd4b2e818037d44541437645a","before":"3855f8bb64109042b76deb4d907956f910fbd45c","commits":[{"sha":"d38414a7ddfc619a9299fe8f4626d7c275cb12b5","author":{"name":"Sergey Balabanov","email":"eab24c0c41d5f6a3c755695c596dc478158c0dc8@fb.com"},"message":"Move ExitCode down the stack for builds\n\nSummary: Currently on user interrupt, build command responds with status code 1 (build failure). With this change it will report with proper exit code 130 (SIGNAL_INTERRUPT).\n\nTest Plan: tests, run locally\n\nReviewed By: ruibm, ttsugriy\n\nfbshipit-source-id: 80043d9","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/d38414a7ddfc619a9299fe8f4626d7c275cb12b5"},{"sha":"203f4c402f553a905de1a0c96e29b6f8ee926cef","author":{"name":"J.J. Montgomery","email":"619425a0960223f559134e24d41484b6f4d562cc@uber.com"},"message":"Fixing Machos file scrubbers to correctly handle cgo binaries\n\nSummary:\nThis addresses the bug logged in https://github.com/facebook/buck/issues/1717.\n\nWhen a FileScrubberStep fails, it currently causes the entire build to fail. This shouldn't be critical behavior as the scrubber merely increases the effectiveness of the cache between builds.\n\nThis is a problem because the scrubbing methods used in com.facebook.buck.cxx.toolchain.objectfile.Machos currently do not work on Mach-O object files created from cgo files. You can see the behavior by running the test binaryWithCgo in com.facebook.buck.go.GoBinaryIntegrationTest on Mac.\n\nI'll create another issue about the scrubbers not handling cgo object files.\nCloses https://github.com/facebook/buck/pull/1787\n\nReviewed By: ttsugriy\n\nPulled By: ttsugriy\n\nfbshipit-source-id: c87ff8b","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/203f4c402f553a905de1a0c96e29b6f8ee926cef"},{"sha":"4b41fcd02b19a7eab283f70dbeb352036ab6a198","author":{"name":"Taras Tsugrii","email":"b25e393874d158f01b37820ee135abb404ef5073@fb.com"},"message":"[buck][PR] [TravisCI] Run google-java-format for all files affected by every PR …\n\nSummary:\nCurrently google format only runs for files that were modified by the very last PR commit, which does not work well when PR has many commits.\nCloses https://github.com/facebook/buck/pull/1796\n\nReviewed By: ttsugriy\n\nPulled By: ttsugriy\n\nfbshipit-source-id: 2d42f20","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/4b41fcd02b19a7eab283f70dbeb352036ab6a198"},{"sha":"cde91aefb07ca4827fc1b4988c6d70db25af1c2a","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"cxx: add config flag to set additional independent shlib interface ldflags\n\nSummary:\nThis adds a config flag to pass in additional linker flags (e.g. `-Wl,-S`) to\nbe used when linking independent shared library interfaces.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 9d57a48","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/cde91aefb07ca4827fc1b4988c6d70db25af1c2a"},{"sha":"36529b1c98e2d5c81ba9ca2e39f809281b646f15","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Simplify DistBuildChromeTrace generation to get rid of Intermediate and helper classes.\n\nSummary: The current structure and naming are hard to understand and develop on.\n\nTest Plan: CI\n\nReviewed By: michsien\n\nfbshipit-source-id: 098d198","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/36529b1c98e2d5c81ba9ca2e39f809281b646f15"},{"sha":"e15c11da2fa1b09d2abb9d35210c26906b01a769","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Sort buildrule events by start time before trying to assign them to threads.\n\nSummary: By default the events come sorted by the finish time, and the thread assignment logic doesn't quite work with that. We can sometimes infer that the slave used more threads than it actually did, as illustrated in the test case enabled by this diff.\n\nTest Plan: CI\n\nReviewed By: alisdair04\n\nfbshipit-source-id: f540559","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/e15c11da2fa1b09d2abb9d35210c26906b01a769"},{"sha":"206fc5c845fe9bc681ec8541c30146644255c3bd","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Document native_library_merge_map\n\nSummary: Just a pointer to the article.\n\nTest Plan: Viewed docs.\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: bb2c266","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/206fc5c845fe9bc681ec8541c30146644255c3bd"},{"sha":"05e3e0e0240a4003dae61deb12aaf76cfcb909aa","author":{"name":"Keegan Parker","email":"3a29528a5997e5bf12b1b2910513efa4a2c44d6e@fb.com"},"message":"Create way of running a built result within E2E tests (for tests running build commands)\n\nSummary: Exposed by the Workspace\n\nTest Plan: Allows running the built output of a build command, given that output's target. Allows checking for \"frankenbuilds\".\n\nReviewed By: bobyangyf\n\nfbshipit-source-id: ec69a12","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/05e3e0e0240a4003dae61deb12aaf76cfcb909aa"},{"sha":"97c755ed89010cdd8b06ce4c29a5422390a5cefd","author":{"name":"Taras Tsugrii","email":"b25e393874d158f01b37820ee135abb404ef5073@fb.com"},"message":"Warn about wrong Java version used for running Buck.\n\nSummary:\nBuck is not guaranteed to work with any Java version other than 8,\nso to avoid wasted time investigating failures due to Java version mismatch\nwe should let users know that they should updat their environment.\n\nWe should also turn this into an error after we get feedback about this.\n\nTest Plan:\n```\n2018-03-03 23:32:57,301 [WARNING][buck.py:68] You're using Java 7, but Buck requires Java 8.\nPlease follow https://buckbuild.com/setup/getting_started.html to properly setup your local enviroment and avoid build issues.\n```\n\nReviewed By: bobyangyf\n\nfbshipit-source-id: 1e0d0f0","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/97c755ed89010cdd8b06ce4c29a5422390a5cefd"},{"sha":"848c66aa235090e9ef75dfbf69e4787218802730","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Remove message_ipc\n\nSummary: Dead code\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: cfc699f","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/848c66aa235090e9ef75dfbf69e4787218802730"},{"sha":"bc059fca5ed8cff373cde60e1b76b7a204f6c414","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Remove leftovers after autodeps\n\nSummary: Dead code\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: a2c12da","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/bc059fca5ed8cff373cde60e1b76b7a204f6c414"},{"sha":"876b68c5cd29a10d6d703901d95d5b1d7f18498a","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Trim rules:types dependencies\n\nSummary: These unnecessary dependencies form a cycle in the following changes.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 7e957c0","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/876b68c5cd29a10d6d703901d95d5b1d7f18498a"},{"sha":"9999145e9f0906ae20ac07c71bdbfb13f3fd7fae","author":{"name":"Sergey Balabanov","email":"eab24c0c41d5f6a3c755695c596dc478158c0dc8@fb.com"},"message":"Rename CloseableWrapper to ThrowingCloseableWrapper\n\nTest Plan: build and test\n\nReviewed By: bobyangyf, ttsugriy\n\nfbshipit-source-id: 465c8e6","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/9999145e9f0906ae20ac07c71bdbfb13f3fd7fae"},{"sha":"b3d11e1758a4e122bcad65df1509fc331b5737b9","author":{"name":"Sergey Balabanov","email":"eab24c0c41d5f6a3c755695c596dc478158c0dc8@fb.com"},"message":"Add CloseableWrapper that does not throw\n\nTest Plan: build and test\n\nReviewed By: bobyangyf\n\nfbshipit-source-id: c7679d9","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/b3d11e1758a4e122bcad65df1509fc331b5737b9"},{"sha":"82648d54d77ddc8536bf28d687d92a73b6cc82bd","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Cache upload thread pool to be initiated in explicit distributed builds in addition to auto-conversions.\n\nTest Plan: None yet.\n\nReviewed By: michsien\n\nfbshipit-source-id: 0e9a22c","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/82648d54d77ddc8536bf28d687d92a73b6cc82bd"},{"sha":"ef3abcae41297532a0faa3e4cd8a85e413a6885e","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Disable stampede superconsole until racing build is cancelled.\n\nSummary: Additionally, print the local build thread status console whenever available.\n\nTest Plan: CI, manual.\n\nReviewed By: aiked\n\nfbshipit-source-id: a8fe1c5","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/ef3abcae41297532a0faa3e4cd8a85e413a6885e"},{"sha":"9b8d8a779a04fd2fbc5cfefa90707c3cfe87bf4d","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Fix stampede ExitCode usage to not intermix with buck.util.ExitCode.\n\nSummary: DistBuildController fills in the distributed build `ExitCode` with a value from `buck.distributed.ExitCode`. We then take that value as integer and try to re-map it into `buck.util.ExitCode`. This diff fixes this mess-up.\n\nTest Plan: CI\n\nReviewed By: alisdair04\n\nfbshipit-source-id: 6a47ada","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/9b8d8a779a04fd2fbc5cfefa90707c3cfe87bf4d"},{"sha":"45d04de10a34a914af81a9c2d7baac5bedc7e3c1","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Publish DistBuildFinished event early to shut the stampede SuperConsole faster.\n\nSummary: Must not waste time showing inactive stuff on the console.\n\nTest Plan:\nCI and -\neyes\n\nReviewed By: alisdair04\n\nfbshipit-source-id: 6ea48cf","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/45d04de10a34a914af81a9c2d7baac5bedc7e3c1"},{"sha":"dd123db1bd4861bf114cdc08bb8b2cfbbb393727","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Sort slaves by number of active jobs.\n\nSummary: This diff sorts the slaves by the number of active jobs, and hides the idle slaves from the console. Buck does not print idle or even downloading threads in the console for local build, and that is appreciated by devs. We should keep the behavior consistent.\n\nTest Plan:\nCI and -\neyes\n\nReviewed By: aiked\n\nfbshipit-source-id: 3292dbf","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/dd123db1bd4861bf114cdc08bb8b2cfbbb393727"},{"sha":"72e0647f09b9055d938beaf7b926522f06a0fdcf","author":{"name":"Shivanker Goel","email":"021ba300550c779da079f6b73c42c1ac2b6ea6ef@fb.com"},"message":"Reduce clutter from the SuperConsole.\n\nSummary:\nThis diff:\n- hides the remote build status when it is \"building\",\n- prints local build status after remote,\n- gets rid of local percentage completion (we now print the whole thread console),\n- renames local build status line to \"local steps\" (unless it's a fallback build),\n- sets local build status to \"finished\" rather than \"successful\" to avoid confusion.\n\nTest Plan:\nCI and -\neyes\n\nReviewed By: alisdair04\n\nfbshipit-source-id: dd6ca9b","distinct":true,"url":"https://api.github.com/repos/monty-uber/buck/commits/72e0647f09b9055d938beaf7b926522f06a0fdcf"}]}
{"actor":{"display_login":"monty-uber"}}