{"action":"created","issue":{"url":"https://api.github.com/repos/bioFAM/MOFA/issues/14","repository_url":"https://api.github.com/repos/bioFAM/MOFA","labels_url":"https://api.github.com/repos/bioFAM/MOFA/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/bioFAM/MOFA/issues/14/comments","events_url":"https://api.github.com/repos/bioFAM/MOFA/issues/14/events","html_url":"https://github.com/bioFAM/MOFA/issues/14","id":315125445,"number":14,"title":"Error creating vignettes during R CMD build","user":{"login":"kcha","id":194053,"avatar_url":"https://avatars3.githubusercontent.com/u/194053?v=4","gravatar_id":"","url":"https://api.github.com/users/kcha","html_url":"https://github.com/kcha","followers_url":"https://api.github.com/users/kcha/followers","following_url":"https://api.github.com/users/kcha/following{/other_user}","gists_url":"https://api.github.com/users/kcha/gists{/gist_id}","starred_url":"https://api.github.com/users/kcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcha/subscriptions","organizations_url":"https://api.github.com/users/kcha/orgs","repos_url":"https://api.github.com/users/kcha/repos","events_url":"https://api.github.com/users/kcha/events{/privacy}","received_events_url":"https://api.github.com/users/kcha/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-17T15:56:16Z","updated_at":"2018-04-19T13:55:08Z","closed_at":"2018-04-19T13:55:08Z","author_association":"NONE","body":"Hi, \r\n\r\nI'm getting the following error when trying to build MOFAtools:\r\n\r\n```\r\n> R CMD build MOFAtools\r\n* checking for file ‘MOFAtools/DESCRIPTION’ ... OK\r\n* preparing ‘MOFAtools’:\r\n* checking DESCRIPTION meta-information ... OK\r\n* installing the package to build vignettes\r\n* creating vignettes ... ERROR\r\n\r\nAttaching package: 'MOFAtools'\r\n\r\nThe following object is masked from 'package:stats':\r\n\r\n    predict\r\n\r\nQuitting from lines 114-118 (MOFA_example_CLL.Rmd)\r\nError: processing vignette 'MOFA_example_CLL.Rmd' failed with diagnostics:\r\n'x' must be an array of at least two dimensions\r\nExecution halted\r\n```\r\n\r\nDigging a little deeper, it seems that the issue is in the `detectPassengers()` step of `loadModel()`. I think during the check for NULL `r2_threshold` in line 124, the example `CLL_model.hdf5` is missing the `object@TrainOptions$drop_by_r2` attribute and still returns NULL.\r\n\r\nThanks! \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bioFAM/MOFA/issues/comments/382744962","html_url":"https://github.com/bioFAM/MOFA/issues/14#issuecomment-382744962","issue_url":"https://api.github.com/repos/bioFAM/MOFA/issues/14","id":382744962,"user":{"login":"kcha","id":194053,"avatar_url":"https://avatars3.githubusercontent.com/u/194053?v=4","gravatar_id":"","url":"https://api.github.com/users/kcha","html_url":"https://github.com/kcha","followers_url":"https://api.github.com/users/kcha/followers","following_url":"https://api.github.com/users/kcha/following{/other_user}","gists_url":"https://api.github.com/users/kcha/gists{/gist_id}","starred_url":"https://api.github.com/users/kcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcha/subscriptions","organizations_url":"https://api.github.com/users/kcha/orgs","repos_url":"https://api.github.com/users/kcha/repos","events_url":"https://api.github.com/users/kcha/events{/privacy}","received_events_url":"https://api.github.com/users/kcha/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T13:55:08Z","updated_at":"2018-04-19T13:55:08Z","author_association":"NONE","body":"Thanks for the fix!"}}
{"actor":{"display_login":"kcha"}}