{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/21304","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21304/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21304/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21304/events","html_url":"https://github.com/joomla/joomla-cms/issues/21304","id":345729885,"node_id":"MDU6SXNzdWUzNDU3Mjk4ODU=","number":21304,"title":"[4.0] Factory class conflict in Joomla/CMS/Document namespace","user":{"login":"aaron-harding","id":897997,"node_id":"MDQ6VXNlcjg5Nzk5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/897997?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-harding","html_url":"https://github.com/aaron-harding","followers_url":"https://api.github.com/users/aaron-harding/followers","following_url":"https://api.github.com/users/aaron-harding/following{/other_user}","gists_url":"https://api.github.com/users/aaron-harding/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-harding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-harding/subscriptions","organizations_url":"https://api.github.com/users/aaron-harding/orgs","repos_url":"https://api.github.com/users/aaron-harding/repos","events_url":"https://api.github.com/users/aaron-harding/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-harding/received_events","type":"User","site_admin":false},"labels":[{"id":878880830,"node_id":"MDU6TGFiZWw4Nzg4ODA4MzA=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/J4%20Issue","name":"J4 Issue","color":"f4d524","default":false},{"id":138443932,"node_id":"MDU6TGFiZWwxMzg0NDM5MzI=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/No%20Code%20Attached%20Yet","name":"No Code Attached Yet","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T12:07:09Z","updated_at":"2018-08-01T09:55:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Steps to reproduce the issue\r\n\r\nAttempt to Install latest branch of Joomla after `composer install` and `npm install`\r\n\r\n### Expected result\r\n\r\nGo to Joomla install process\r\n\r\n### Actual result\r\n\r\nFatal error: Cannot use Joomla\\CMS\\Factory as Factory because the name is already in use in C:\\xxx\\joomla-cms\\libraries\\src\\Document\\HtmlDocument.php on line 18\r\n\r\n### System information (as much as possible)\r\n\r\nPHP 7.1.20\r\n\r\n### Additional comments\r\n\r\nEach Document class uses Joomla\\CMS\\Factory, Factory is already assigned to Joomla\\CMS\\Document\\Factory.\r\n\r\nI updated the use statement to `use Joomla\\CMS\\Factory as FactoryCMS` and updated each reference to FactoryCMS in each of the Document classes which seems to fix it. I'm not sure if making this change has caused other side effects?"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/409520535","html_url":"https://github.com/joomla/joomla-cms/issues/21304#issuecomment-409520535","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21304","id":409520535,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUyMDUzNQ==","user":{"login":"wilsonge","id":1986000,"node_id":"MDQ6VXNlcjE5ODYwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1986000?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T09:55:27Z","updated_at":"2018-08-01T09:55:27Z","author_association":"CONTRIBUTOR","body":"> I updated the use statement to use Joomla\\CMS\\Factory as FactoryCMS and updated each reference to FactoryCMS in each of the Document classes which seems to fix it. I'm not sure if making this change has caused other side effects?\r\n\r\nThat's a good fix - can you make that as a pull request please?"}}
{"actor":{"display_login":"wilsonge"}}