{"action":"created","issue":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/1330","repository_url":"https://api.github.com/repos/all-of-us/workbench","labels_url":"https://api.github.com/repos/all-of-us/workbench/issues/1330/labels{/name}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/1330/comments","events_url":"https://api.github.com/repos/all-of-us/workbench/issues/1330/events","html_url":"https://github.com/all-of-us/workbench/pull/1330","id":369321463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjkyNDE1","number":1330,"title":"[RW-1438] Make concept search, counting use new synonyms index.","user":{"login":"danqrodney","id":12536316,"node_id":"MDQ6VXNlcjEyNTM2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-11T21:59:51Z","updated_at":"2018-10-12T16:59:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/1330","html_url":"https://github.com/all-of-us/workbench/pull/1330","diff_url":"https://github.com/all-of-us/workbench/pull/1330.diff","patch_url":"https://github.com/all-of-us/workbench/pull/1330.patch"},"body":"(This speeds everything up dramatically.)\r\n\r\nI'm currently working on parsing synonyms out of synonyms column instead of having to do a second query to fetch those in ConceptService. (Though even with that second query things are still pretty snappy.)"},"comment":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/comments/429392700","html_url":"https://github.com/all-of-us/workbench/pull/1330#issuecomment-429392700","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/1330","id":429392700,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM5MjcwMA==","user":{"login":"calbach","id":822298,"node_id":"MDQ6VXNlcjgyMjI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T16:59:38Z","updated_at":"2018-10-12T16:59:38Z","author_association":"COLLABORATOR","body":"I had to stare at this for a while and dig through old PRs but I think I get it now, please check my understanding:\r\n- Previously (and currently, I guess) synonyms are stored in the concept_synonym table\r\n- A recent PR also added a column `concept.synonym` which will instead contain a `|` concatenated list of synonyms\r\n- This PR changes synonym queries to use that column rather than joining against the concept_synonym table.\r\n\r\n-> The concept_synonym table may be removed in the future(?)"}}
{"actor":{"display_login":"calbach"}}