{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/3384","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/3384/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/3384/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/3384/events","html_url":"https://github.com/Azure/acs-engine/pull/3384","id":336764163,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTQwNTc5","number":3384,"title":"Add new flag to use built-in API model","user":{"login":"cpuguy83","id":799078,"node_id":"MDQ6VXNlcjc5OTA3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"labels":[{"id":936451056,"node_id":"MDU6TGFiZWw5MzY0NTEwNTY=","url":"https://api.github.com/repos/Azure/acs-engine/labels/size/L","name":"size/L","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-06-28T20:14:41Z","updated_at":"2018-07-16T23:29:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/3384","html_url":"https://github.com/Azure/acs-engine/pull/3384","diff_url":"https://github.com/Azure/acs-engine/pull/3384.diff","patch_url":"https://github.com/Azure/acs-engine/pull/3384.patch"},"body":"\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis allows users to use a pre-configured API model which follows best\r\npractices.\r\nFor now this is mutually exclusive with `--api-model`, but in the future\r\nthis may support merging so users can provide their own overrides but\r\nstill use the defined best practices.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #3378\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**If applicable**:\r\n- [ ] documentation\r\n- [x] unit tests\r\n- [ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nAdd `--use-builtin-model` which uses a preconfigured Kubernetes API model following best practices.\r\n```"},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/405411883","html_url":"https://github.com/Azure/acs-engine/pull/3384#issuecomment-405411883","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/3384","id":405411883,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTQxMTg4Mw==","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T23:29:44Z","updated_at":"2018-07-16T23:29:44Z","author_association":"MEMBER","body":"Thanks for your patience on this @cpuguy83. My skepticism thus far is due to a hesitancy to introduce anything new, as it seems like we *should* be able to re-use the existing interface(s) to do this.\r\n\r\nHow about if we introduced these patterns:\r\n\r\n`./acs-engine generate --api-model https://raw.githubusercontent.com/Azure/acs-engine/77bd48385ba12314f1d7df36b4e0b4d53ceac0a2/examples/kubernetes.json --set <overrides> ...`\r\n\r\n`./acs-engine deploy --api-model https://raw.githubusercontent.com/Azure/acs-engine/77bd48385ba12314f1d7df36b4e0b4d53ceac0a2/examples/kubernetes.json ...`\r\n\r\nBasically, if we pass a URI value to `--api-model`, then we are implementing \"immutable/versioned api models\" as an HTTP/HTTPS endpoint. The existing `--set` option would allow for custom configurations on top of the blessed api models approach.\r\n\r\nThoughts? @CecileRobertMichon @khenidak as well"}}
{"actor":{"display_login":"jackfrancis"}}