{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/24768","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/24768/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24768/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/24768/events","html_url":"https://github.com/ceph/ceph/pull/24768","id":374271243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDA5Nzg2","number":24768,"title":"[RFC] ceph-volume: initial propose plugin","user":{"login":"jan--f","id":458501,"node_id":"MDQ6VXNlcjQ1ODUwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false},"labels":[{"id":647438941,"node_id":"MDU6TGFiZWw2NDc0Mzg5NDE=","url":"https://api.github.com/repos/ceph/ceph/labels/DNM","name":"DNM","color":"ff0000","default":false},{"id":656485990,"node_id":"MDU6TGFiZWw2NTY0ODU5OTA=","url":"https://api.github.com/repos/ceph/ceph/labels/ceph-volume","name":"ceph-volume","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-10-26T08:05:23Z","updated_at":"2018-11-02T15:57:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24768","html_url":"https://github.com/ceph/ceph/pull/24768","diff_url":"https://github.com/ceph/ceph/pull/24768.diff","patch_url":"https://github.com/ceph/ceph/pull/24768.patch"},"body":"Signed-off-by: Jan Fajerski <jfajerski@suse.com>\r\n\r\nThis ceph-volume plugin implements a simple node device inventory and can propose (for now trivial) Drive Groups. This hopefully advances the Drive Group discussion and the orchestrator work.\r\n\r\nThis plugin adds two commands ```ceph-volume propose inventory``` and ```ceph-volume propose drive_groups```. See both commands help for details.\r\n\r\n##### ```ceph-volume propose drive_groups```\r\nThis will print a Drive Group structure with rotating drives as data devices and non-rotating drives as shared devices (to be used to wal/db/journals) unless there are no rotating drives. the ```--standalone``` flag will propose all drives as data devices.\r\n\r\nIf this PR receives positive feedback more command line flags and arguments would be added to give more control about the Drive Group proposal. This proposal could then be used as input to another layer that does drive formatting or LVM management (could be ```ceph-volume``` itself, orchestrator implementations or other deployment tools).\r\n\r\nThe first thing to add would a to filter devices by regex on drive attributes (model name, size, ...) for example.\r\n\r\nI'm interested in the communities feedback regarding the Drive Groups structure itself (see also the [previous discussion](https://docs.google.com/document/d/1iwTnQc8d9W3BpQHgGYTMZSKvN6J7s0z8kQaYNxYvLho/edit#heading=h.70ln4hrkito3)), the implementation as a ```ceph-volume``` plugin and how that would fit into the various workflows of existing deployment tools and the orchestrator work (not limited to this of course).\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/435427055","html_url":"https://github.com/ceph/ceph/pull/24768#issuecomment-435427055","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24768","id":435427055,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQyNzA1NQ==","user":{"login":"alfredodeza","id":317847,"node_id":"MDQ6VXNlcjMxNzg0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/317847?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T15:57:38Z","updated_at":"2018-11-02T15:57:38Z","author_association":"CONTRIBUTOR","body":"@jan--f I see what you are describing with the drive groups as something that could perhaps be accomplished with filtering. Tools like LVM and `blkid` allow this with one or more options. For example: show me all devices that have `PARTLABEL=\"ceph data\"`. \r\n\r\nThat type of grouping/filtering can be hard to make it right (quite a bit of work for sure), so I think that your initial work should concentrate on the rough internals to produce the listing, while keeping in mind that grouping/ordering is the next step. \r\n\r\nI agree in that the grouping would be nice for interactions that are not meant to be tied to the mgr or the orchestrators, while keeping things needed for the mgr/orchestrators functional enough so that they can make decisions based on that information."}}
{"actor":{"display_login":"alfredodeza"}}