{"action":"closed","number":120,"pull_request":{"url":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120","id":230671077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjcxMDc3","html_url":"https://github.com/Azure/aad-pod-identity/pull/120","diff_url":"https://github.com/Azure/aad-pod-identity/pull/120.diff","patch_url":"https://github.com/Azure/aad-pod-identity/pull/120.patch","issue_url":"https://api.github.com/repos/Azure/aad-pod-identity/issues/120","number":120,"state":"closed","locked":false,"title":"Add support for vmss","user":{"login":"cpuguy83","id":799078,"node_id":"MDQ6VXNlcjc5OTA3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"This adds support for assigning identities to a VMSS when the underlying\r\ncluster is using VMSS.\r\n\r\nNote that identities get assigned to the entire VMSS.\r\n\r\nThis introduces a dependency on being able to list nodes from k8s so we can get the provider I, which allows us to determine (per node) if it is VMSS and what the real name of the resource we need to assign to is. This has the additional benefit in that it should be more robust than relying on the node names from k8s to match node names in Azure.\r\n\r\nCloses #63","created_at":"2018-11-14T00:24:40Z","updated_at":"2018-11-29T19:56:31Z","closed_at":"2018-11-29T19:56:31Z","merged_at":"2018-11-29T19:56:31Z","merge_commit_sha":"9de34f333538fab171268ea6b8e75319e9b4742f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120/commits","review_comments_url":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120/comments","review_comment_url":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/aad-pod-identity/issues/120/comments","statuses_url":"https://api.github.com/repos/Azure/aad-pod-identity/statuses/589909292806eb00f1f38b1c2d98ccc10fa86cb7","head":{"label":"cpuguy83:support_vmss","ref":"support_vmss","sha":"589909292806eb00f1f38b1c2d98ccc10fa86cb7","user":{"login":"cpuguy83","id":799078,"node_id":"MDQ6VXNlcjc5OTA3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"repo":{"id":157299571,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyOTk1NzE=","name":"aad-pod-identity","full_name":"cpuguy83/aad-pod-identity","private":false,"owner":{"login":"cpuguy83","id":799078,"node_id":"MDQ6VXNlcjc5OTA3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cpuguy83/aad-pod-identity","description":"Assign Azure Active Directory Identities to kubernetes applications. ","fork":true,"url":"https://api.github.com/repos/cpuguy83/aad-pod-identity","forks_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/forks","keys_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/teams","hooks_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/hooks","issue_events_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/issues/events{/number}","events_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/events","assignees_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/assignees{/user}","branches_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/branches{/branch}","tags_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/tags","blobs_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/languages","stargazers_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/stargazers","contributors_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/contributors","subscribers_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/subscribers","subscription_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/subscription","commits_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/contents/{+path}","compare_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/merges","archive_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/downloads","issues_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/issues{/number}","pulls_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/labels{/name}","releases_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/releases{/id}","deployments_url":"https://api.github.com/repos/cpuguy83/aad-pod-identity/deployments","created_at":"2018-11-13T01:06:41Z","updated_at":"2018-11-13T01:06:43Z","pushed_at":"2018-11-28T21:11:56Z","git_url":"git://github.com/cpuguy83/aad-pod-identity.git","ssh_url":"git@github.com:cpuguy83/aad-pod-identity.git","clone_url":"https://github.com/cpuguy83/aad-pod-identity.git","svn_url":"https://github.com/cpuguy83/aad-pod-identity","homepage":"","size":6069,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fd7991d186c180c772866e627a285f451e0b8472","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":128431578,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MzE1Nzg=","name":"aad-pod-identity","full_name":"Azure/aad-pod-identity","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/aad-pod-identity","description":"Assign Azure Active Directory Identities to kubernetes applications. ","fork":false,"url":"https://api.github.com/repos/Azure/aad-pod-identity","forks_url":"https://api.github.com/repos/Azure/aad-pod-identity/forks","keys_url":"https://api.github.com/repos/Azure/aad-pod-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/aad-pod-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/aad-pod-identity/teams","hooks_url":"https://api.github.com/repos/Azure/aad-pod-identity/hooks","issue_events_url":"https://api.github.com/repos/Azure/aad-pod-identity/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/aad-pod-identity/events","assignees_url":"https://api.github.com/repos/Azure/aad-pod-identity/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/aad-pod-identity/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/aad-pod-identity/tags","blobs_url":"https://api.github.com/repos/Azure/aad-pod-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/aad-pod-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/aad-pod-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/aad-pod-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/aad-pod-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/aad-pod-identity/languages","stargazers_url":"https://api.github.com/repos/Azure/aad-pod-identity/stargazers","contributors_url":"https://api.github.com/repos/Azure/aad-pod-identity/contributors","subscribers_url":"https://api.github.com/repos/Azure/aad-pod-identity/subscribers","subscription_url":"https://api.github.com/repos/Azure/aad-pod-identity/subscription","commits_url":"https://api.github.com/repos/Azure/aad-pod-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/aad-pod-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/aad-pod-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/aad-pod-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/aad-pod-identity/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/aad-pod-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/aad-pod-identity/merges","archive_url":"https://api.github.com/repos/Azure/aad-pod-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/aad-pod-identity/downloads","issues_url":"https://api.github.com/repos/Azure/aad-pod-identity/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/aad-pod-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/aad-pod-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/aad-pod-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/aad-pod-identity/labels{/name}","releases_url":"https://api.github.com/repos/Azure/aad-pod-identity/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/aad-pod-identity/deployments","created_at":"2018-04-06T18:12:16Z","updated_at":"2018-11-28T23:52:41Z","pushed_at":"2018-11-29T19:56:31Z","git_url":"git://github.com/Azure/aad-pod-identity.git","ssh_url":"git@github.com:Azure/aad-pod-identity.git","clone_url":"https://github.com/Azure/aad-pod-identity.git","svn_url":"https://github.com/Azure/aad-pod-identity","homepage":"","size":6058,"stargazers_count":67,"watchers_count":67,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":32,"open_issues":25,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120"},"html":{"href":"https://github.com/Azure/aad-pod-identity/pull/120"},"issue":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/issues/120"},"comments":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/aad-pod-identity/statuses/589909292806eb00f1f38b1c2d98ccc10fa86cb7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kkmsft","id":29471693,"node_id":"MDQ6VXNlcjI5NDcxNjkz","avatar_url":"https://avatars1.githubusercontent.com/u/29471693?v=4","gravatar_id":"","url":"https://api.github.com/users/kkmsft","html_url":"https://github.com/kkmsft","followers_url":"https://api.github.com/users/kkmsft/followers","following_url":"https://api.github.com/users/kkmsft/following{/other_user}","gists_url":"https://api.github.com/users/kkmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/kkmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkmsft/subscriptions","organizations_url":"https://api.github.com/users/kkmsft/orgs","repos_url":"https://api.github.com/users/kkmsft/repos","events_url":"https://api.github.com/users/kkmsft/events{/privacy}","received_events_url":"https://api.github.com/users/kkmsft/received_events","type":"User","site_admin":false},"comments":3,"review_comments":13,"maintainer_can_modify":false,"commits":3,"additions":796,"deletions":174,"changed_files":16}}
{"actor":{"display_login":"kkmsft"}}