{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/7129","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/7129/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/7129/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/7129/events","html_url":"https://github.com/openssl/openssl/pull/7129","id":357493166,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDkyOTMx","number":7129,"title":"Limit the number of AES-GCM keys allowed in TLS.","user":{"login":"paulidale","id":17916609,"node_id":"MDQ6VXNlcjE3OTE2NjA5","avatar_url":"https://avatars1.githubusercontent.com/u/17916609?v=4","gravatar_id":"","url":"https://api.github.com/users/paulidale","html_url":"https://github.com/paulidale","followers_url":"https://api.github.com/users/paulidale/followers","following_url":"https://api.github.com/users/paulidale/following{/other_user}","gists_url":"https://api.github.com/users/paulidale/gists{/gist_id}","starred_url":"https://api.github.com/users/paulidale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulidale/subscriptions","organizations_url":"https://api.github.com/users/paulidale/orgs","repos_url":"https://api.github.com/users/paulidale/repos","events_url":"https://api.github.com/users/paulidale/events{/privacy}","received_events_url":"https://api.github.com/users/paulidale/received_events","type":"User","site_admin":false},"labels":[{"id":673605928,"node_id":"MDU6TGFiZWw2NzM2MDU5Mjg=","url":"https://api.github.com/repos/openssl/openssl/labels/FIPS","name":"FIPS","color":"bfdadc","default":false},{"id":482066405,"node_id":"MDU6TGFiZWw0ODIwNjY0MDU=","url":"https://api.github.com/repos/openssl/openssl/labels/after%201.1.1","name":"after 1.1.1","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/11","html_url":"https://github.com/openssl/openssl/milestone/11","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/11/labels","id":3024154,"node_id":"MDk6TWlsZXN0b25lMzAyNDE1NA==","number":11,"title":"Post 1.1.1","description":"","creator":{"login":"kaduk","id":1894506,"node_id":"MDQ6VXNlcjE4OTQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1894506?v=4","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"open_issues":243,"closed_issues":46,"state":"open","created_at":"2018-01-09T21:08:23Z","updated_at":"2018-09-11T15:49:45Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-09-06T04:35:08Z","updated_at":"2018-09-11T22:39:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/7129","html_url":"https://github.com/openssl/openssl/pull/7129","diff_url":"https://github.com/openssl/openssl/pull/7129.diff","patch_url":"https://github.com/openssl/openssl/pull/7129.patch"},"body":"This is a FIPS 140-2 requirement from [IG A.5](https://csrc.nist.gov/CSRC/media/Projects/Cryptographic-Module-Validation-Program/documents/fips140-2/FIPS1402IG.pdf) _Key/IV Pair Uniqueness Requirements from SP 800-38D_.\r\n\r\nThe limit will not be reached due to TLS catching it earlier, however the test is mandatory for FIPS.  The test only needs to happen on one side of the session, here the encrypting side keeps count and raises an error if the limit is exceeded.  Unsigned integer overflow back to zero on increment is relied on.  The C standard defines unsigned integral types as operating modulo 2<sup>bit width</sup> so this is safe.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/420450059","html_url":"https://github.com/openssl/openssl/pull/7129#issuecomment-420450059","issue_url":"https://api.github.com/repos/openssl/openssl/issues/7129","id":420450059,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDQ1MDA1OQ==","user":{"login":"paulidale","id":17916609,"node_id":"MDQ6VXNlcjE3OTE2NjA5","avatar_url":"https://avatars1.githubusercontent.com/u/17916609?v=4","gravatar_id":"","url":"https://api.github.com/users/paulidale","html_url":"https://github.com/paulidale","followers_url":"https://api.github.com/users/paulidale/followers","following_url":"https://api.github.com/users/paulidale/following{/other_user}","gists_url":"https://api.github.com/users/paulidale/gists{/gist_id}","starred_url":"https://api.github.com/users/paulidale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulidale/subscriptions","organizations_url":"https://api.github.com/users/paulidale/orgs","repos_url":"https://api.github.com/users/paulidale/repos","events_url":"https://api.github.com/users/paulidale/events{/privacy}","received_events_url":"https://api.github.com/users/paulidale/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T22:39:26Z","updated_at":"2018-09-11T22:39:26Z","author_association":"CONTRIBUTOR","body":"I've added an error as a second commit.\r\n\r\nI'll leave the include/exclude decision up to the reviewers -- I don't see the need for it, @richsalz wants it.  Anyone else?"}}
{"actor":{"display_login":"paulidale"}}