{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/215484110","pull_request_review_id":152758827,"id":215484110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ4NDExMA==","diff_hunk":"@@ -447,6 +447,9 @@ func checkJobMaxInterval(job *model.Job) time.Duration {\n \tif job.Type == model.ActionAddIndex {\n \t\treturn 3 * time.Second\n \t}\n+\tif job.Type == model.ActionCreateTable {","path":"ddl/ddl.go","position":4,"original_position":4,"commit_id":"f529324a89edbe038713b14b276a91af41815c02","original_commit_id":"f529324a89edbe038713b14b276a91af41815c02","user":{"login":"zhexuany","id":13320708,"node_id":"MDQ6VXNlcjEzMzIwNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/13320708?v=4","gravatar_id":"","url":"https://api.github.com/users/zhexuany","html_url":"https://github.com/zhexuany","followers_url":"https://api.github.com/users/zhexuany/followers","following_url":"https://api.github.com/users/zhexuany/following{/other_user}","gists_url":"https://api.github.com/users/zhexuany/gists{/gist_id}","starred_url":"https://api.github.com/users/zhexuany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhexuany/subscriptions","organizations_url":"https://api.github.com/users/zhexuany/orgs","repos_url":"https://api.github.com/users/zhexuany/repos","events_url":"https://api.github.com/users/zhexuany/events{/privacy}","received_events_url":"https://api.github.com/users/zhexuany/received_events","type":"User","site_admin":false},"body":"I am confused by the context. Anyone help me out? \r\n\r\n> request add a TODO.\r\nTODO for what? \r\n> Why not consider CreateDatabase/DropTable....? \r\nyou mean we reduce tick of `CreateDatabase/DropTable` to 500ms? \r\n\r\n","created_at":"2018-09-06T03:14:13Z","updated_at":"2018-09-06T03:14:13Z","html_url":"https://github.com/pingcap/tidb/pull/7608#discussion_r215484110","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/7608","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/215484110"},"html":{"href":"https://github.com/pingcap/tidb/pull/7608#discussion_r215484110"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7608"}},"in_reply_to_id":214908417},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7608","id":212946568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTQ2NTY4","html_url":"https://github.com/pingcap/tidb/pull/7608","diff_url":"https://github.com/pingcap/tidb/pull/7608.diff","patch_url":"https://github.com/pingcap/tidb/pull/7608.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7608","number":7608,"state":"open","locked":false,"title":"ddl: reduce the interval for checking \"create table\"","user":{"login":"zimulala","id":4242506,"node_id":"MDQ6VXNlcjQyNDI1MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\nAfter we put the DDL job into the job queue, the owner will handle the job in the background.  We check every \"tick\" if the current job is completed. Handling the operation of \"create table\" will be faster.\r\n\r\n### What is changed and how it works?\r\nI changed the interval of \"create table\"  to 500ms.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\n","created_at":"2018-09-04T11:40:48Z","updated_at":"2018-09-06T03:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e7410f835ad4be4a4ffdf9836c80b3741aa955","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":745133021,"node_id":"MDU6TGFiZWw3NDUxMzMwMjE=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/DDL-need-LGT3","name":"component/DDL-need-LGT3","color":"00bff4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7608/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7608/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7608/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/f529324a89edbe038713b14b276a91af41815c02","head":{"label":"zimulala:create-table-interval","ref":"create-table-interval","sha":"f529324a89edbe038713b14b276a91af41815c02","user":{"login":"zimulala","id":4242506,"node_id":"MDQ6VXNlcjQyNDI1MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"repo":{"id":41986662,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjY2Mg==","name":"tidb","full_name":"zimulala/tidb","owner":{"login":"zimulala","id":4242506,"node_id":"MDQ6VXNlcjQyNDI1MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimulala/tidb","description":"TiDB is a distributed SQL database.","fork":true,"url":"https://api.github.com/repos/zimulala/tidb","forks_url":"https://api.github.com/repos/zimulala/tidb/forks","keys_url":"https://api.github.com/repos/zimulala/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimulala/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimulala/tidb/teams","hooks_url":"https://api.github.com/repos/zimulala/tidb/hooks","issue_events_url":"https://api.github.com/repos/zimulala/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/zimulala/tidb/events","assignees_url":"https://api.github.com/repos/zimulala/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/zimulala/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/zimulala/tidb/tags","blobs_url":"https://api.github.com/repos/zimulala/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimulala/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimulala/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimulala/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimulala/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/zimulala/tidb/languages","stargazers_url":"https://api.github.com/repos/zimulala/tidb/stargazers","contributors_url":"https://api.github.com/repos/zimulala/tidb/contributors","subscribers_url":"https://api.github.com/repos/zimulala/tidb/subscribers","subscription_url":"https://api.github.com/repos/zimulala/tidb/subscription","commits_url":"https://api.github.com/repos/zimulala/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimulala/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimulala/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimulala/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimulala/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/zimulala/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimulala/tidb/merges","archive_url":"https://api.github.com/repos/zimulala/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimulala/tidb/downloads","issues_url":"https://api.github.com/repos/zimulala/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/zimulala/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/zimulala/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/zimulala/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimulala/tidb/labels{/name}","releases_url":"https://api.github.com/repos/zimulala/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/zimulala/tidb/deployments","created_at":"2015-09-06T04:16:07Z","updated_at":"2017-10-19T09:16:15Z","pushed_at":"2018-09-04T12:06:37Z","git_url":"git://github.com/zimulala/tidb.git","ssh_url":"git@github.com:zimulala/tidb.git","clone_url":"https://github.com/zimulala/tidb.git","svn_url":"https://github.com/zimulala/tidb","homepage":"","size":54910,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"55ca8512fc922ecedc764e8586f3293a32adb884","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-09-06T03:04:01Z","pushed_at":"2018-09-06T03:04:02Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":81128,"stargazers_count":14705,"watchers_count":14705,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2053,"mirror_url":null,"archived":false,"open_issues_count":545,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2053,"open_issues":545,"watchers":14705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7608"},"html":{"href":"https://github.com/pingcap/tidb/pull/7608"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7608"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7608/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7608/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7608/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/f529324a89edbe038713b14b276a91af41815c02"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zhexuany"}}