{"action":"created","issue":{"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/220","repository_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental","labels_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/220/comments","events_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/220/events","html_url":"https://github.com/dnadesign/silverstripe-elemental/issues/220","id":314447943,"node_id":"MDU6SXNzdWUzMTQ0NDc5NDM=","number":220,"title":"Duplication of `cascade_duplicates` setting via `DataExtension` will duplicate the duplication process","user":{"login":"mfendeksilverstripe","id":26395487,"node_id":"MDQ6VXNlcjI2Mzk1NDg3","avatar_url":"https://avatars2.githubusercontent.com/u/26395487?v=4","gravatar_id":"","url":"https://api.github.com/users/mfendeksilverstripe","html_url":"https://github.com/mfendeksilverstripe","followers_url":"https://api.github.com/users/mfendeksilverstripe/followers","following_url":"https://api.github.com/users/mfendeksilverstripe/following{/other_user}","gists_url":"https://api.github.com/users/mfendeksilverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/mfendeksilverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfendeksilverstripe/subscriptions","organizations_url":"https://api.github.com/users/mfendeksilverstripe/orgs","repos_url":"https://api.github.com/users/mfendeksilverstripe/repos","events_url":"https://api.github.com/users/mfendeksilverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/mfendeksilverstripe/received_events","type":"User","site_admin":false},"labels":[{"id":730187402,"node_id":"MDU6TGFiZWw3MzAxODc0MDI=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/affects/v4","name":"affects/v4","color":"5319e7","default":false},{"id":730187460,"node_id":"MDU6TGFiZWw3MzAxODc0NjA=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/change/patch","name":"change/patch","color":"fef2c0","default":false},{"id":730187469,"node_id":"MDU6TGFiZWw3MzAxODc0Njk=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/effort/easy","name":"effort/easy","color":"c2e0c6","default":false},{"id":730187549,"node_id":"MDU6TGFiZWw3MzAxODc1NDk=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/impact/medium","name":"impact/medium","color":"f7c6c7","default":false},{"id":124574431,"node_id":"MDU6TGFiZWwxMjQ1NzQ0MzE=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/type/bug","name":"type/bug","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-15T20:15:56Z","updated_at":"2018-07-16T00:54:48Z","closed_at":"2018-07-16T00:54:48Z","author_association":"CONTRIBUTOR","body":"`ElementalArea` currently has following setting:\r\n\r\n```\r\nprivate static $cascade_duplicates = [\r\n    'Elements',\r\n];\r\n```\r\n\r\nThis is absolutely fine, however in case that I apply the same setting via `DataExtension` on `ElementalArea` the result will be the duplication process running twice which I believe should not be the case.\r\n\r\nExample:\r\n```\r\nBlockPage\r\n->LayoutBlock\r\n-->TextBlock\r\n```\r\n\r\nAfter duplication expected:\r\n\r\n```\r\nBlockPage\r\n->LayoutBlock\r\n-->TextBlock\r\n\r\nBlockPage\r\n->LayoutBlock\r\n-->TextBlock\r\n```\r\n\r\nAfter duplication actual:\r\n\r\n```\r\nBlockPage\r\n->LayoutBlock\r\n-->TextBlock\r\n\r\nBlockPage\r\n->LayoutBlock\r\n-->TextBlock\r\n-->TextBlock\r\n->LayoutBlock\r\n-->TextBlock\r\n-->TextBlock\r\n```\r\n\r\nIt's probably not a super critical issue as you shouldn't need to apply the duplication config twice on the same class, but I don't think we should have the ability to run the duplication process twice."},"comment":{"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/comments/405131033","html_url":"https://github.com/dnadesign/silverstripe-elemental/issues/220#issuecomment-405131033","issue_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/220","id":405131033,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEzMTAzMw==","user":{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T00:54:48Z","updated_at":"2018-07-16T00:54:48Z","author_association":"CONTRIBUTOR","body":"Fixed in core (4.1)"}}
{"actor":{"display_login":"robbieaverill"}}