{"action":"created","issue":{"url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1120","repository_url":"https://api.github.com/repos/webtorrent/webtorrent","labels_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1120/labels{/name}","comments_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1120/comments","events_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1120/events","html_url":"https://github.com/webtorrent/webtorrent/issues/1120","id":225924619,"number":1120,"title":"WebSeed memory hog causing crash (chrome)","user":{"login":"kocoten1992","id":7130705,"avatar_url":"https://avatars1.githubusercontent.com/u/7130705?v=4","gravatar_id":"","url":"https://api.github.com/users/kocoten1992","html_url":"https://github.com/kocoten1992","followers_url":"https://api.github.com/users/kocoten1992/followers","following_url":"https://api.github.com/users/kocoten1992/following{/other_user}","gists_url":"https://api.github.com/users/kocoten1992/gists{/gist_id}","starred_url":"https://api.github.com/users/kocoten1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocoten1992/subscriptions","organizations_url":"https://api.github.com/users/kocoten1992/orgs","repos_url":"https://api.github.com/users/kocoten1992/repos","events_url":"https://api.github.com/users/kocoten1992/events{/privacy}","received_events_url":"https://api.github.com/users/kocoten1992/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-03T09:12:56Z","updated_at":"2018-03-01T07:11:48Z","closed_at":"2018-02-05T05:53:43Z","author_association":"CONTRIBUTOR","body":"**What version of WebTorrent?**\r\n0.98.18\r\n**What operating system and Node.js version?**\r\nUbuntu 17.04, v7.3.0\r\n**What browser and version? (if using WebTorrent in the browser)**\r\nChrome 57.0\r\n\r\nIt crash wasn't because of file too big for memory, I was using idb-chunk-store and chrome-chunk-store\r\n\r\nWhen just webRTC connection, it went well, but when add webseed it causing crash, my speculation is that, when forEach loop https://github.com/webtorrent/webtorrent/blob/master/lib/webconn.js#L111, \r\n\r\nDuring the loop, memory wasn't release until the end, that what cause the hog (sorry if I'm wrong), might be fix if we split it into smaller forEach.\r\n\r\nThought, boss ?\r\n"},"comment":{"url":"https://api.github.com/repos/webtorrent/webtorrent/issues/comments/369498121","html_url":"https://github.com/webtorrent/webtorrent/issues/1120#issuecomment-369498121","issue_url":"https://api.github.com/repos/webtorrent/webtorrent/issues/1120","id":369498121,"user":{"login":"kocoten1992","id":7130705,"avatar_url":"https://avatars1.githubusercontent.com/u/7130705?v=4","gravatar_id":"","url":"https://api.github.com/users/kocoten1992","html_url":"https://github.com/kocoten1992","followers_url":"https://api.github.com/users/kocoten1992/followers","following_url":"https://api.github.com/users/kocoten1992/following{/other_user}","gists_url":"https://api.github.com/users/kocoten1992/gists{/gist_id}","starred_url":"https://api.github.com/users/kocoten1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocoten1992/subscriptions","organizations_url":"https://api.github.com/users/kocoten1992/orgs","repos_url":"https://api.github.com/users/kocoten1992/repos","events_url":"https://api.github.com/users/kocoten1992/events{/privacy}","received_events_url":"https://api.github.com/users/kocoten1992/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T07:11:48Z","updated_at":"2018-03-01T07:11:48Z","author_association":"CONTRIBUTOR","body":"@SilentBot1 hey\r\n\r\nThe file should larger than 2GB and we will see the effect.\r\n\r\nOn side note: when doing with big file, don't open f12 (or open and must close it periodically), the console log or the network tab will keep the memory from being collect by garbage collection."}}
{"actor":{"display_login":"kocoten1992"}}