{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/stripes-components/pulls/comments/235522113","pull_request_review_id":177408480,"id":235522113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTUyMjExMw==","diff_hunk":"@@ -1,5 +1,10 @@\n @import '../variables.css';\n \n+:root {\n+  --button-default-vertical-padding: 0.125rem;\n+  --button-default-horizontal-padding: var(--gutter);\n+}","path":"lib/Button/Button.css","position":6,"original_position":6,"commit_id":"a518f4ff240f4d4e016077d641c6134064723cc0","original_commit_id":"a518f4ff240f4d4e016077d641c6134064723cc0","user":{"login":"cherewaty","id":230597,"node_id":"MDQ6VXNlcjIzMDU5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/230597?v=4","gravatar_id":"","url":"https://api.github.com/users/cherewaty","html_url":"https://github.com/cherewaty","followers_url":"https://api.github.com/users/cherewaty/followers","following_url":"https://api.github.com/users/cherewaty/following{/other_user}","gists_url":"https://api.github.com/users/cherewaty/gists{/gist_id}","starred_url":"https://api.github.com/users/cherewaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherewaty/subscriptions","organizations_url":"https://api.github.com/users/cherewaty/orgs","repos_url":"https://api.github.com/users/cherewaty/repos","events_url":"https://api.github.com/users/cherewaty/events{/privacy}","received_events_url":"https://api.github.com/users/cherewaty/received_events","type":"User","site_admin":false},"body":"We should probably only define global variables in `variables.css`.","created_at":"2018-11-21T19:55:58Z","updated_at":"2018-11-21T19:59:04Z","html_url":"https://github.com/folio-org/stripes-components/pull/723#discussion_r235522113","pull_request_url":"https://api.github.com/repos/folio-org/stripes-components/pulls/723","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/comments/235522113"},"html":{"href":"https://github.com/folio-org/stripes-components/pull/723#discussion_r235522113"},"pull_request":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/folio-org/stripes-components/pulls/723","id":232353723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzUzNzIz","html_url":"https://github.com/folio-org/stripes-components/pull/723","diff_url":"https://github.com/folio-org/stripes-components/pull/723.diff","patch_url":"https://github.com/folio-org/stripes-components/pull/723.patch","issue_url":"https://api.github.com/repos/folio-org/stripes-components/issues/723","number":723,"state":"open","locked":false,"title":"STCOM-389: Add <MenuSection> component","user":{"login":"rasmuswoelk","id":640976,"node_id":"MDQ6VXNlcjY0MDk3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/640976?v=4","gravatar_id":"","url":"https://api.github.com/users/rasmuswoelk","html_url":"https://github.com/rasmuswoelk","followers_url":"https://api.github.com/users/rasmuswoelk/followers","following_url":"https://api.github.com/users/rasmuswoelk/following{/other_user}","gists_url":"https://api.github.com/users/rasmuswoelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmuswoelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmuswoelk/subscriptions","organizations_url":"https://api.github.com/users/rasmuswoelk/orgs","repos_url":"https://api.github.com/users/rasmuswoelk/repos","events_url":"https://api.github.com/users/rasmuswoelk/events{/privacy}","received_events_url":"https://api.github.com/users/rasmuswoelk/received_events","type":"User","site_admin":false},"body":"**Issue:** https://issues.folio.org/browse/STCOM-389\r\n\r\nThis PR adds a new component called `<MenuSection>`. \r\n\r\nThis component is useful for creating multisectioned dropdown menu's (which is the current use-case but it can, of course, be used in other parts of the UI as well).\r\n\r\nIt basically renders a section with a label. When stacking MenuSections it will automatically apply the appropriate margins.\r\n\r\nI also updated the styles for the `dropdownItem` buttonStyle as well as updated the `<Button>` examples/readme.\r\n\r\n## Changes:\r\n- Added MenuSection component\r\n- Added examples, readme, and tests for MenuSection\r\n- Updated dropdownItem styles and updated Button example/readme\r\n\r\n## Test results\r\n![image](https://user-images.githubusercontent.com/640976/48782791-3e301200-ecdf-11e8-9dde-4bd73f35d44b.png)\r\n\r\n## Example of MenuSection's inside a Dropdown\r\n![image](https://user-images.githubusercontent.com/640976/48782703-117bfa80-ecdf-11e8-81bc-339bcba73594.png)\r\n\r\n**Note:** In an upcoming PR I will adjust the margins/paddings of various components to make sure that they align properly when stacked like the above example.\r\n\r\n## Next up:\r\n- [ ] Update app's using the `actionMenuItems`-prop to use `actionMenu`-prop instead\r\n- [ ] Update documentation regarding Pane Action Menu's to include an example of MenuSection and Button w. buttonStyle \"dropdownItem\"","created_at":"2018-11-20T15:15:34Z","updated_at":"2018-11-21T19:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44fd9b2d71c218fbe46298a12d3b14cfdd6f4edb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JohnC-80","id":20704067,"node_id":"MDQ6VXNlcjIwNzA0MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/20704067?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnC-80","html_url":"https://github.com/JohnC-80","followers_url":"https://api.github.com/users/JohnC-80/followers","following_url":"https://api.github.com/users/JohnC-80/following{/other_user}","gists_url":"https://api.github.com/users/JohnC-80/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnC-80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnC-80/subscriptions","organizations_url":"https://api.github.com/users/JohnC-80/orgs","repos_url":"https://api.github.com/users/JohnC-80/repos","events_url":"https://api.github.com/users/JohnC-80/events{/privacy}","received_events_url":"https://api.github.com/users/JohnC-80/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/stripes-components/pulls/723/commits","review_comments_url":"https://api.github.com/repos/folio-org/stripes-components/pulls/723/comments","review_comment_url":"https://api.github.com/repos/folio-org/stripes-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/stripes-components/issues/723/comments","statuses_url":"https://api.github.com/repos/folio-org/stripes-components/statuses/a518f4ff240f4d4e016077d641c6134064723cc0","head":{"label":"samhaeng:STCOM-389-add-menu-section-component","ref":"STCOM-389-add-menu-section-component","sha":"a518f4ff240f4d4e016077d641c6134064723cc0","user":{"login":"samhaeng","id":29634212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjM0MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/29634212?v=4","gravatar_id":"","url":"https://api.github.com/users/samhaeng","html_url":"https://github.com/samhaeng","followers_url":"https://api.github.com/users/samhaeng/followers","following_url":"https://api.github.com/users/samhaeng/following{/other_user}","gists_url":"https://api.github.com/users/samhaeng/gists{/gist_id}","starred_url":"https://api.github.com/users/samhaeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhaeng/subscriptions","organizations_url":"https://api.github.com/users/samhaeng/orgs","repos_url":"https://api.github.com/users/samhaeng/repos","events_url":"https://api.github.com/users/samhaeng/events{/privacy}","received_events_url":"https://api.github.com/users/samhaeng/received_events","type":"Organization","site_admin":false},"repo":{"id":111699704,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2OTk3MDQ=","name":"stripes-components","full_name":"samhaeng/stripes-components","private":false,"owner":{"login":"samhaeng","id":29634212,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjM0MjEy","avatar_url":"https://avatars2.githubusercontent.com/u/29634212?v=4","gravatar_id":"","url":"https://api.github.com/users/samhaeng","html_url":"https://github.com/samhaeng","followers_url":"https://api.github.com/users/samhaeng/followers","following_url":"https://api.github.com/users/samhaeng/following{/other_user}","gists_url":"https://api.github.com/users/samhaeng/gists{/gist_id}","starred_url":"https://api.github.com/users/samhaeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhaeng/subscriptions","organizations_url":"https://api.github.com/users/samhaeng/orgs","repos_url":"https://api.github.com/users/samhaeng/repos","events_url":"https://api.github.com/users/samhaeng/events{/privacy}","received_events_url":"https://api.github.com/users/samhaeng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samhaeng/stripes-components","description":"A component library for Stripes","fork":true,"url":"https://api.github.com/repos/samhaeng/stripes-components","forks_url":"https://api.github.com/repos/samhaeng/stripes-components/forks","keys_url":"https://api.github.com/repos/samhaeng/stripes-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samhaeng/stripes-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samhaeng/stripes-components/teams","hooks_url":"https://api.github.com/repos/samhaeng/stripes-components/hooks","issue_events_url":"https://api.github.com/repos/samhaeng/stripes-components/issues/events{/number}","events_url":"https://api.github.com/repos/samhaeng/stripes-components/events","assignees_url":"https://api.github.com/repos/samhaeng/stripes-components/assignees{/user}","branches_url":"https://api.github.com/repos/samhaeng/stripes-components/branches{/branch}","tags_url":"https://api.github.com/repos/samhaeng/stripes-components/tags","blobs_url":"https://api.github.com/repos/samhaeng/stripes-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samhaeng/stripes-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samhaeng/stripes-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/samhaeng/stripes-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samhaeng/stripes-components/statuses/{sha}","languages_url":"https://api.github.com/repos/samhaeng/stripes-components/languages","stargazers_url":"https://api.github.com/repos/samhaeng/stripes-components/stargazers","contributors_url":"https://api.github.com/repos/samhaeng/stripes-components/contributors","subscribers_url":"https://api.github.com/repos/samhaeng/stripes-components/subscribers","subscription_url":"https://api.github.com/repos/samhaeng/stripes-components/subscription","commits_url":"https://api.github.com/repos/samhaeng/stripes-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/samhaeng/stripes-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/samhaeng/stripes-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/samhaeng/stripes-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/samhaeng/stripes-components/contents/{+path}","compare_url":"https://api.github.com/repos/samhaeng/stripes-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samhaeng/stripes-components/merges","archive_url":"https://api.github.com/repos/samhaeng/stripes-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samhaeng/stripes-components/downloads","issues_url":"https://api.github.com/repos/samhaeng/stripes-components/issues{/number}","pulls_url":"https://api.github.com/repos/samhaeng/stripes-components/pulls{/number}","milestones_url":"https://api.github.com/repos/samhaeng/stripes-components/milestones{/number}","notifications_url":"https://api.github.com/repos/samhaeng/stripes-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samhaeng/stripes-components/labels{/name}","releases_url":"https://api.github.com/repos/samhaeng/stripes-components/releases{/id}","deployments_url":"https://api.github.com/repos/samhaeng/stripes-components/deployments","created_at":"2017-11-22T15:15:17Z","updated_at":"2018-11-21T12:10:00Z","pushed_at":"2018-11-21T12:09:59Z","git_url":"git://github.com/samhaeng/stripes-components.git","ssh_url":"git@github.com:samhaeng/stripes-components.git","clone_url":"https://github.com/samhaeng/stripes-components.git","svn_url":"https://github.com/samhaeng/stripes-components","homepage":null,"size":3710,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"b8c03c5146a5a112e26c24289bb3ad3a504846b4","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":71479583,"node_id":"MDEwOlJlcG9zaXRvcnk3MTQ3OTU4Mw==","name":"stripes-components","full_name":"folio-org/stripes-components","private":false,"owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/folio-org/stripes-components","description":"A component library for Stripes","fork":false,"url":"https://api.github.com/repos/folio-org/stripes-components","forks_url":"https://api.github.com/repos/folio-org/stripes-components/forks","keys_url":"https://api.github.com/repos/folio-org/stripes-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/stripes-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/stripes-components/teams","hooks_url":"https://api.github.com/repos/folio-org/stripes-components/hooks","issue_events_url":"https://api.github.com/repos/folio-org/stripes-components/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/stripes-components/events","assignees_url":"https://api.github.com/repos/folio-org/stripes-components/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/stripes-components/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/stripes-components/tags","blobs_url":"https://api.github.com/repos/folio-org/stripes-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/stripes-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/stripes-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/stripes-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/stripes-components/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/stripes-components/languages","stargazers_url":"https://api.github.com/repos/folio-org/stripes-components/stargazers","contributors_url":"https://api.github.com/repos/folio-org/stripes-components/contributors","subscribers_url":"https://api.github.com/repos/folio-org/stripes-components/subscribers","subscription_url":"https://api.github.com/repos/folio-org/stripes-components/subscription","commits_url":"https://api.github.com/repos/folio-org/stripes-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/stripes-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/stripes-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/stripes-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/stripes-components/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/stripes-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/stripes-components/merges","archive_url":"https://api.github.com/repos/folio-org/stripes-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/stripes-components/downloads","issues_url":"https://api.github.com/repos/folio-org/stripes-components/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/stripes-components/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/stripes-components/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/stripes-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/stripes-components/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/stripes-components/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/stripes-components/deployments","created_at":"2016-10-20T15:55:46Z","updated_at":"2018-11-21T19:47:21Z","pushed_at":"2018-11-21T19:47:18Z","git_url":"git://github.com/folio-org/stripes-components.git","ssh_url":"git@github.com:folio-org/stripes-components.git","clone_url":"https://github.com/folio-org/stripes-components.git","svn_url":"https://github.com/folio-org/stripes-components","homepage":null,"size":3524,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/723"},"html":{"href":"https://github.com/folio-org/stripes-components/pull/723"},"issue":{"href":"https://api.github.com/repos/folio-org/stripes-components/issues/723"},"comments":{"href":"https://api.github.com/repos/folio-org/stripes-components/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/stripes-components/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/stripes-components/statuses/a518f4ff240f4d4e016077d641c6134064723cc0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cherewaty"}}