{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1990","repository_url":"https://api.github.com/repos/kubernetes-sigs/cri-o","labels_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1990/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1990/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1990/events","html_url":"https://github.com/kubernetes-sigs/cri-o/pull/1990","id":395276395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzY4ODky","number":1990,"title":"oci: Abstract Runtime structure as a Go interface","user":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"labels":[{"id":484626496,"node_id":"MDU6TGFiZWw0ODQ2MjY0OTY=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":699272716,"node_id":"MDU6TGFiZWw2OTkyNzI3MTY=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":679128061,"node_id":"MDU6TGFiZWw2NzkxMjgwNjE=","url":"https://api.github.com/repos/kubernetes-sigs/cri-o/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-01-02T15:06:51Z","updated_at":"2019-01-02T15:07:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cri-o/pulls/1990","html_url":"https://github.com/kubernetes-sigs/cri-o/pull/1990","diff_url":"https://github.com/kubernetes-sigs/cri-o/pull/1990.diff","patch_url":"https://github.com/kubernetes-sigs/cri-o/pull/1990.patch"},"body":"oci: Abstract Runtime structure as a Go interface\r\n\r\nThis is the second step in making a clear separation between different\r\nimplementations of the runtime. This commit takes care of defining a\r\nnew Go interface RuntimeImpl that can be implemented depending on the\r\nruntime version.\r\n\r\nOne technical detail is that we had to maintain Runtime as a Go\r\nstructure embedding this new Go interface, since there are a few\r\nfields that are common to every implementations. Those common\r\nfields are gathered beneath the new structure RuntimeBase.\r\n\r\nOnce the abstraction is clearly defined, this patch reuses the\r\nformer runtime implementation as the RuntimeV1 implementation.\r\n\r\nFixes #1989\r\n\r\nSigned-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/comments/450887202","html_url":"https://github.com/kubernetes-sigs/cri-o/pull/1990#issuecomment-450887202","issue_url":"https://api.github.com/repos/kubernetes-sigs/cri-o/issues/1990","id":450887202,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDg4NzIwMg==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T15:07:21Z","updated_at":"2019-01-02T15:07:21Z","author_association":"COLLABORATOR","body":"Hi @sboeuf. Thanks for your PR.\n\nI'm waiting for a [kubernetes-sigs](https://github.com/orgs/kubernetes-sigs/people) or [openshift](https://github.com/orgs/openshift/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/openshift/people) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"openshift-ci-robot"}}