{"action":"created","issue":{"url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/646","repository_url":"https://api.github.com/repos/matrix-org/matrix-js-sdk","labels_url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/646/comments","events_url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/646/events","html_url":"https://github.com/matrix-org/matrix-js-sdk/pull/646","id":325128340,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NTM4Nzcw","number":646,"title":"emit oldEventId on \"updatePendingEvent\"","user":{"login":"leonlianght","id":7112003,"node_id":"MDQ6VXNlcjcxMTIwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7112003?v=4","gravatar_id":"","url":"https://api.github.com/users/leonlianght","html_url":"https://github.com/leonlianght","followers_url":"https://api.github.com/users/leonlianght/followers","following_url":"https://api.github.com/users/leonlianght/following{/other_user}","gists_url":"https://api.github.com/users/leonlianght/gists{/gist_id}","starred_url":"https://api.github.com/users/leonlianght/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonlianght/subscriptions","organizations_url":"https://api.github.com/users/leonlianght/orgs","repos_url":"https://api.github.com/users/leonlianght/repos","events_url":"https://api.github.com/users/leonlianght/events{/privacy}","received_events_url":"https://api.github.com/users/leonlianght/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T03:28:01Z","updated_at":"2018-06-08T14:48:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/pulls/646","html_url":"https://github.com/matrix-org/matrix-js-sdk/pull/646","diff_url":"https://github.com/matrix-org/matrix-js-sdk/pull/646.diff","patch_url":"https://github.com/matrix-org/matrix-js-sdk/pull/646.patch"},"body":"It should fire `Room.localEchoUpdated` event and returns the oldEventId\r\n\r\n#645 "},"comment":{"url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/comments/395784631","html_url":"https://github.com/matrix-org/matrix-js-sdk/pull/646#issuecomment-395784631","issue_url":"https://api.github.com/repos/matrix-org/matrix-js-sdk/issues/646","id":395784631,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTc4NDYzMQ==","user":{"login":"dbkr","id":986903,"node_id":"MDQ6VXNlcjk4NjkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/986903?v=4","gravatar_id":"","url":"https://api.github.com/users/dbkr","html_url":"https://github.com/dbkr","followers_url":"https://api.github.com/users/dbkr/followers","following_url":"https://api.github.com/users/dbkr/following{/other_user}","gists_url":"https://api.github.com/users/dbkr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkr/subscriptions","organizations_url":"https://api.github.com/users/dbkr/orgs","repos_url":"https://api.github.com/users/dbkr/repos","events_url":"https://api.github.com/users/dbkr/events{/privacy}","received_events_url":"https://api.github.com/users/dbkr/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T14:48:37Z","updated_at":"2018-06-08T14:48:37Z","author_association":"MEMBER","body":"This looks correct and sensible. Even though it changes the API to match the docs, people could be relying on the old behaviour, so this is probably worth a breaking change in the changelog.\r\n\r\nAlso, you forgot the DCO signoff: https://github.com/matrix-org/matrix-js-sdk/blob/master/CONTRIBUTING.rst"}}
{"actor":{"display_login":"dbkr"}}