{"action":"created","issue":{"url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/68","repository_url":"https://api.github.com/repos/jlblancoc/nanoflann","labels_url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/68/comments","events_url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/68/events","html_url":"https://github.com/jlblancoc/nanoflann/issues/68","id":291988776,"number":68,"title":"flann submodule","user":{"login":"patrikhuber","id":4967343,"avatar_url":"https://avatars3.githubusercontent.com/u/4967343?v=4","gravatar_id":"","url":"https://api.github.com/users/patrikhuber","html_url":"https://github.com/patrikhuber","followers_url":"https://api.github.com/users/patrikhuber/followers","following_url":"https://api.github.com/users/patrikhuber/following{/other_user}","gists_url":"https://api.github.com/users/patrikhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/patrikhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrikhuber/subscriptions","organizations_url":"https://api.github.com/users/patrikhuber/orgs","repos_url":"https://api.github.com/users/patrikhuber/repos","events_url":"https://api.github.com/users/patrikhuber/events{/privacy}","received_events_url":"https://api.github.com/users/patrikhuber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-01-26T18:22:31Z","updated_at":"2018-02-01T11:50:19Z","closed_at":null,"author_association":"NONE","body":"Hi!\r\n\r\nIt seems like recently, flann was added as a submodule to this repo. It's not used in the `nanoflann.hpp` header, but I found some uses of flann headers in the benchmark folders.\r\nNow as a user of just the nanoflann header, included via submodule in my own repo, it's quite annoying that now with every clone, the flann submodule is fetched through nanoflann. Even more so since it's completely unnecessary for the nanoflann library. I know that repositories can be cloned without `--recursive` and then transitive submodules will not be fetched but unfortunately this is very often not an option as other repos actually do need the submodules that they include.\r\n\r\nI would like to propose to move the benchmark (or whichever part uses flann) to a different repo (it can be linked in the README.md here), so that users including the nanoflann repo into their repos via submodule, aren't fetching the flann code too. After all, the main reason to use nanoflann, is not to have to use flann.\r\nFor me, this is currently a reason not to upgrade nanoflann."},"comment":{"url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/comments/362242756","html_url":"https://github.com/jlblancoc/nanoflann/issues/68#issuecomment-362242756","issue_url":"https://api.github.com/repos/jlblancoc/nanoflann/issues/68","id":362242756,"user":{"login":"jlblancoc","id":5497818,"avatar_url":"https://avatars2.githubusercontent.com/u/5497818?v=4","gravatar_id":"","url":"https://api.github.com/users/jlblancoc","html_url":"https://github.com/jlblancoc","followers_url":"https://api.github.com/users/jlblancoc/followers","following_url":"https://api.github.com/users/jlblancoc/following{/other_user}","gists_url":"https://api.github.com/users/jlblancoc/gists{/gist_id}","starred_url":"https://api.github.com/users/jlblancoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlblancoc/subscriptions","organizations_url":"https://api.github.com/users/jlblancoc/orgs","repos_url":"https://api.github.com/users/jlblancoc/repos","events_url":"https://api.github.com/users/jlblancoc/events{/privacy}","received_events_url":"https://api.github.com/users/jlblancoc/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T11:50:19Z","updated_at":"2018-02-01T11:50:19Z","author_association":"OWNER","body":"👍 I have to change my mind... working all day with @MRPT I forget small repositories still exist! XD"}}
{"actor":{"display_login":"jlblancoc"}}