{"action":"created","issue":{"url":"https://api.github.com/repos/USGS-R/geoknife/issues/366","repository_url":"https://api.github.com/repos/USGS-R/geoknife","labels_url":"https://api.github.com/repos/USGS-R/geoknife/issues/366/labels{/name}","comments_url":"https://api.github.com/repos/USGS-R/geoknife/issues/366/comments","events_url":"https://api.github.com/repos/USGS-R/geoknife/issues/366/events","html_url":"https://github.com/USGS-R/geoknife/issues/366","id":289050712,"node_id":"MDU6SXNzdWUyODkwNTA3MTI=","number":366,"title":"> 100% complete values from the GDP break the progress bar","user":{"login":"wdwatkins","id":13987349,"node_id":"MDQ6VXNlcjEzOTg3MzQ5","avatar_url":"https://avatars3.githubusercontent.com/u/13987349?v=4","gravatar_id":"","url":"https://api.github.com/users/wdwatkins","html_url":"https://github.com/wdwatkins","followers_url":"https://api.github.com/users/wdwatkins/followers","following_url":"https://api.github.com/users/wdwatkins/following{/other_user}","gists_url":"https://api.github.com/users/wdwatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/wdwatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdwatkins/subscriptions","organizations_url":"https://api.github.com/users/wdwatkins/orgs","repos_url":"https://api.github.com/users/wdwatkins/repos","events_url":"https://api.github.com/users/wdwatkins/events{/privacy}","received_events_url":"https://api.github.com/users/wdwatkins/received_events","type":"User","site_admin":false},"labels":[{"id":320081207,"node_id":"MDU6TGFiZWwzMjAwODEyMDc=","url":"https://api.github.com/repos/USGS-R/geoknife/labels/low%20priority","name":"low priority","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-16T20:47:22Z","updated_at":"2018-09-19T17:52:57Z","closed_at":null,"author_association":"COLLABORATOR","body":"```\r\nstencil <- geoknife::simplegeom(c(-88.6, 45.2))\r\nfabric <- geoknife::webdata(url = 'https://cida.usgs.gov/thredds/dodsC/stageiv_combined', \r\n                            variables = \"Total_precipitation_surface_1_Hour_Accumulation\", \r\n                            times = c(\"2008-06-02\", \"2008-06-13\"))\r\nknife <- geoknife::webprocess(\"unweighted summary\")\r\njob <- geoknife::geoknife(stencil, fabric, knife, wait = TRUE, \r\n                          REQUIRE_FULL_COVERAGE=FALSE)\r\n```\r\n\r\nThe progress bar function (from `progress` package) contains an assertion that the percent complete ratio is < 1, which fails.  We could pre-empt this to give a nicer error message, but this only happens with the unweighted algorithm which generally shouldn't be used anyways.\r\n\r\nThere is something in the GDP itself that is actually causing the wild percent complete values."},"comment":{"url":"https://api.github.com/repos/USGS-R/geoknife/issues/comments/422898131","html_url":"https://github.com/USGS-R/geoknife/issues/366#issuecomment-422898131","issue_url":"https://api.github.com/repos/USGS-R/geoknife/issues/366","id":422898131,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjg5ODEzMQ==","user":{"login":"jread-usgs","id":2349007,"node_id":"MDQ6VXNlcjIzNDkwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2349007?v=4","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T17:52:57Z","updated_at":"2018-09-19T17:52:57Z","author_association":"MEMBER","body":"I think we need to catch some of the issues w/ `progress`\r\ne.g.,\r\n```\r\nError in pb_update(self, private, ratio, tokens):\r\n!self$finished is not TRUE\r\n```"}}
{"actor":{"display_login":"jread-usgs"}}