{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/176640045","pull_request_review_id":106379502,"id":176640045,"diff_hunk":"@@ -29,6 +29,17 @@ spec:\n       imagePullSecrets:\n       - name: {{ .Values.imagePullSecrets }}\n     {{- end }}\n+      initContainers:","path":"stable/artifactory-ha/templates/nginx-deployment.yaml","position":9,"original_position":4,"commit_id":"1aee94ddda4cec83c4848330043e037a0475c36a","original_commit_id":"1aee94ddda4cec83c4848330043e037a0475c36a","user":{"login":"eldada","id":19947530,"avatar_url":"https://avatars0.githubusercontent.com/u/19947530?v=4","gravatar_id":"","url":"https://api.github.com/users/eldada","html_url":"https://github.com/eldada","followers_url":"https://api.github.com/users/eldada/followers","following_url":"https://api.github.com/users/eldada/following{/other_user}","gists_url":"https://api.github.com/users/eldada/gists{/gist_id}","starred_url":"https://api.github.com/users/eldada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldada/subscriptions","organizations_url":"https://api.github.com/users/eldada/orgs","repos_url":"https://api.github.com/users/eldada/repos","events_url":"https://api.github.com/users/eldada/events{/privacy}","received_events_url":"https://api.github.com/users/eldada/received_events","type":"User","site_admin":false},"body":"This initContainer needs to be wrapped with `{{- if .Values.nginx.persistence.enabled }}` ","created_at":"2018-03-23T05:06:29Z","updated_at":"2018-03-23T05:07:56Z","html_url":"https://github.com/kubernetes/charts/pull/4396#discussion_r176640045","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/4396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/176640045"},"html":{"href":"https://github.com/kubernetes/charts/pull/4396#discussion_r176640045"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4396"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/4396","id":176595888,"html_url":"https://github.com/kubernetes/charts/pull/4396","diff_url":"https://github.com/kubernetes/charts/pull/4396.diff","patch_url":"https://github.com/kubernetes/charts/pull/4396.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/4396","number":4396,"state":"open","locked":false,"title":"[stable/artifactory-ha] Added support for ingress in artifactory-ha","user":{"login":"jainishshah17","id":7799465,"avatar_url":"https://avatars3.githubusercontent.com/u/7799465?v=4","gravatar_id":"","url":"https://api.github.com/users/jainishshah17","html_url":"https://github.com/jainishshah17","followers_url":"https://api.github.com/users/jainishshah17/followers","following_url":"https://api.github.com/users/jainishshah17/following{/other_user}","gists_url":"https://api.github.com/users/jainishshah17/gists{/gist_id}","starred_url":"https://api.github.com/users/jainishshah17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainishshah17/subscriptions","organizations_url":"https://api.github.com/users/jainishshah17/orgs","repos_url":"https://api.github.com/users/jainishshah17/repos","events_url":"https://api.github.com/users/jainishshah17/events{/privacy}","received_events_url":"https://api.github.com/users/jainishshah17/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-03-21T20:09:47Z","updated_at":"2018-03-23T05:07:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b8ecfb7611593fb3064bf4a2f03dc456507dd1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676596499,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/4396/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/4396/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/4396/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/1aee94ddda4cec83c4848330043e037a0475c36a","head":{"label":"jainishshah17:artifactory-ha-ingress","ref":"artifactory-ha-ingress","sha":"1aee94ddda4cec83c4848330043e037a0475c36a","user":{"login":"jainishshah17","id":7799465,"avatar_url":"https://avatars3.githubusercontent.com/u/7799465?v=4","gravatar_id":"","url":"https://api.github.com/users/jainishshah17","html_url":"https://github.com/jainishshah17","followers_url":"https://api.github.com/users/jainishshah17/followers","following_url":"https://api.github.com/users/jainishshah17/following{/other_user}","gists_url":"https://api.github.com/users/jainishshah17/gists{/gist_id}","starred_url":"https://api.github.com/users/jainishshah17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainishshah17/subscriptions","organizations_url":"https://api.github.com/users/jainishshah17/orgs","repos_url":"https://api.github.com/users/jainishshah17/repos","events_url":"https://api.github.com/users/jainishshah17/events{/privacy}","received_events_url":"https://api.github.com/users/jainishshah17/received_events","type":"User","site_admin":false},"repo":{"id":71382258,"name":"charts","full_name":"jainishshah17/charts","owner":{"login":"jainishshah17","id":7799465,"avatar_url":"https://avatars3.githubusercontent.com/u/7799465?v=4","gravatar_id":"","url":"https://api.github.com/users/jainishshah17","html_url":"https://github.com/jainishshah17","followers_url":"https://api.github.com/users/jainishshah17/followers","following_url":"https://api.github.com/users/jainishshah17/following{/other_user}","gists_url":"https://api.github.com/users/jainishshah17/gists{/gist_id}","starred_url":"https://api.github.com/users/jainishshah17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainishshah17/subscriptions","organizations_url":"https://api.github.com/users/jainishshah17/orgs","repos_url":"https://api.github.com/users/jainishshah17/repos","events_url":"https://api.github.com/users/jainishshah17/events{/privacy}","received_events_url":"https://api.github.com/users/jainishshah17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jainishshah17/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/jainishshah17/charts","forks_url":"https://api.github.com/repos/jainishshah17/charts/forks","keys_url":"https://api.github.com/repos/jainishshah17/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jainishshah17/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jainishshah17/charts/teams","hooks_url":"https://api.github.com/repos/jainishshah17/charts/hooks","issue_events_url":"https://api.github.com/repos/jainishshah17/charts/issues/events{/number}","events_url":"https://api.github.com/repos/jainishshah17/charts/events","assignees_url":"https://api.github.com/repos/jainishshah17/charts/assignees{/user}","branches_url":"https://api.github.com/repos/jainishshah17/charts/branches{/branch}","tags_url":"https://api.github.com/repos/jainishshah17/charts/tags","blobs_url":"https://api.github.com/repos/jainishshah17/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jainishshah17/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jainishshah17/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jainishshah17/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jainishshah17/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/jainishshah17/charts/languages","stargazers_url":"https://api.github.com/repos/jainishshah17/charts/stargazers","contributors_url":"https://api.github.com/repos/jainishshah17/charts/contributors","subscribers_url":"https://api.github.com/repos/jainishshah17/charts/subscribers","subscription_url":"https://api.github.com/repos/jainishshah17/charts/subscription","commits_url":"https://api.github.com/repos/jainishshah17/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jainishshah17/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jainishshah17/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jainishshah17/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jainishshah17/charts/contents/{+path}","compare_url":"https://api.github.com/repos/jainishshah17/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jainishshah17/charts/merges","archive_url":"https://api.github.com/repos/jainishshah17/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jainishshah17/charts/downloads","issues_url":"https://api.github.com/repos/jainishshah17/charts/issues{/number}","pulls_url":"https://api.github.com/repos/jainishshah17/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/jainishshah17/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/jainishshah17/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jainishshah17/charts/labels{/name}","releases_url":"https://api.github.com/repos/jainishshah17/charts/releases{/id}","deployments_url":"https://api.github.com/repos/jainishshah17/charts/deployments","created_at":"2016-10-19T17:24:41Z","updated_at":"2018-03-21T17:06:30Z","pushed_at":"2018-03-22T23:33:28Z","git_url":"git://github.com/jainishshah17/charts.git","ssh_url":"git@github.com:jainishshah17/charts.git","clone_url":"https://github.com/jainishshah17/charts.git","svn_url":"https://github.com/jainishshah17/charts","homepage":"","size":4896,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"97feacc3b59a8bea3ccaedd119d107a694bd36ef","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-03-23T01:13:21Z","pushed_at":"2018-03-23T04:14:34Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":4889,"stargazers_count":2556,"watchers_count":2556,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2133,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2133,"open_issues":523,"watchers":2556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4396"},"html":{"href":"https://github.com/kubernetes/charts/pull/4396"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/4396"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/4396/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4396/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/4396/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/1aee94ddda4cec83c4848330043e037a0475c36a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eldada"}}