{"action":"created","issue":{"url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/22","repository_url":"https://api.github.com/repos/rherwig/template-react-16-ssr","labels_url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/22/comments","events_url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/22/events","html_url":"https://github.com/rherwig/template-react-16-ssr/issues/22","id":330132048,"node_id":"MDU6SXNzdWUzMzAxMzIwNDg=","number":22,"title":"curious to know why the webpack optimization has not been used","user":{"login":"dagda1","id":118328,"node_id":"MDQ6VXNlcjExODMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/118328?v=4","gravatar_id":"","url":"https://api.github.com/users/dagda1","html_url":"https://github.com/dagda1","followers_url":"https://api.github.com/users/dagda1/followers","following_url":"https://api.github.com/users/dagda1/following{/other_user}","gists_url":"https://api.github.com/users/dagda1/gists{/gist_id}","starred_url":"https://api.github.com/users/dagda1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagda1/subscriptions","organizations_url":"https://api.github.com/users/dagda1/orgs","repos_url":"https://api.github.com/users/dagda1/repos","events_url":"https://api.github.com/users/dagda1/events{/privacy}","received_events_url":"https://api.github.com/users/dagda1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-07T06:20:39Z","updated_at":"2018-06-07T16:01:34Z","closed_at":null,"author_association":"NONE","body":"This project has been a great help to me to get up to speed with react ssr so many thanks for that.\r\n\r\nI've recently upgraded to webpack 4 and the latest `extract-css-chunks-webpack-plugin`.\r\n\r\nIn the README for `extract-css-chunks-webpack-plugin`, it states that you should the webpack `optimization ` config as a replacement for the now gone CommonsChunkPlugin.\r\n\r\ne.g.\r\n```\r\noptimization: {\r\n      runtimeChunk: {\r\n        name: 'bootstrap'\r\n      },\r\n      splitChunks: {\r\n        chunks: 'initial', // <-- The key to this\r\n        cacheGroups: {\r\n          vendors: {\r\n            test: /[\\\\/]node_modules[\\\\/]/,\r\n            name: 'vendor'\r\n          }\r\n        }\r\n      }\r\n    };\r\n```\r\nI'm curious to know if there is a reason why you are not using this?\r\n\r\nIs not needed in this case?"},"comment":{"url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/comments/395474838","html_url":"https://github.com/rherwig/template-react-16-ssr/issues/22#issuecomment-395474838","issue_url":"https://api.github.com/repos/rherwig/template-react-16-ssr/issues/22","id":395474838,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTQ3NDgzOA==","user":{"login":"rherwig","id":12065150,"node_id":"MDQ6VXNlcjEyMDY1MTUw","avatar_url":"https://avatars3.githubusercontent.com/u/12065150?v=4","gravatar_id":"","url":"https://api.github.com/users/rherwig","html_url":"https://github.com/rherwig","followers_url":"https://api.github.com/users/rherwig/followers","following_url":"https://api.github.com/users/rherwig/following{/other_user}","gists_url":"https://api.github.com/users/rherwig/gists{/gist_id}","starred_url":"https://api.github.com/users/rherwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rherwig/subscriptions","organizations_url":"https://api.github.com/users/rherwig/orgs","repos_url":"https://api.github.com/users/rherwig/repos","events_url":"https://api.github.com/users/rherwig/events{/privacy}","received_events_url":"https://api.github.com/users/rherwig/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T16:01:34Z","updated_at":"2018-06-07T16:01:34Z","author_association":"OWNER","body":"Thanks for the kind words :-)\r\n\r\nAs far as the optimization goes, I am just starting to implement css chunks again, after CommonsChunkPlugin has been removed and I am still looking into the webpack 4 chunking options.\r\n\r\nI am going to implement the css chunks in the upcoming days and am gonna take a look at the docs again. Thanks for providing a hint!"}}
{"actor":{"display_login":"rherwig"}}