{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/176903375","pull_request_review_id":106692787,"id":176903375,"diff_hunk":"@@ -113,6 +113,17 @@ _py_log_message_setattr(PyObject *o, PyObject *key, PyObject *value)\n   PyObject *value_as_strobj = PyObject_Str(value);\n   if (value_as_strobj)\n     {\n+      if(log_msg_is_write_protected(py_msg->msg))\n+        {\n+          msg_debug(\"Error while modifying\",\n+                    evt_tag_printf(\"msg\", \"%p\", py_msg),\n+                    evt_tag_str(\"name\", name),\n+                    evt_tag_str(\"value\", py_object_as_string(value_as_strobj)));\n+\n+          PyErr_SetString(PyExc_RuntimeError, \"msg is write protected\");\n+          return -1;","path":"modules/python/python-logmsg.c","position":null,"original_position":12,"commit_id":"877c2eea10c38b971faa36dbe0e5faf3fdd5ff3a","original_commit_id":"768af455bf41682af077cdd51133da79222772e2","user":{"login":"ketankr9","id":15634055,"avatar_url":"https://avatars2.githubusercontent.com/u/15634055?v=4","gravatar_id":"","url":"https://api.github.com/users/ketankr9","html_url":"https://github.com/ketankr9","followers_url":"https://api.github.com/users/ketankr9/followers","following_url":"https://api.github.com/users/ketankr9/following{/other_user}","gists_url":"https://api.github.com/users/ketankr9/gists{/gist_id}","starred_url":"https://api.github.com/users/ketankr9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketankr9/subscriptions","organizations_url":"https://api.github.com/users/ketankr9/orgs","repos_url":"https://api.github.com/users/ketankr9/repos","events_url":"https://api.github.com/users/ketankr9/events{/privacy}","received_events_url":"https://api.github.com/users/ketankr9/received_events","type":"User","site_admin":false},"body":"fixed\r\n```Py_DECREF(value_as_strobj);```","created_at":"2018-03-24T08:12:20Z","updated_at":"2018-03-24T08:12:20Z","html_url":"https://github.com/balabit/syslog-ng/pull/1920#discussion_r176903375","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/176903375"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1920#discussion_r176903375"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920"}},"in_reply_to_id":176788100},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920","id":173769813,"html_url":"https://github.com/balabit/syslog-ng/pull/1920","diff_url":"https://github.com/balabit/syslog-ng/pull/1920.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/1920.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1920","number":1920,"state":"open","locked":false,"title":"python: bug fix, report RutimeError when msg modified instead of crashing.","user":{"login":"ketankr9","id":15634055,"avatar_url":"https://avatars2.githubusercontent.com/u/15634055?v=4","gravatar_id":"","url":"https://api.github.com/users/ketankr9","html_url":"https://github.com/ketankr9","followers_url":"https://api.github.com/users/ketankr9/followers","following_url":"https://api.github.com/users/ketankr9/following{/other_user}","gists_url":"https://api.github.com/users/ketankr9/gists{/gist_id}","starred_url":"https://api.github.com/users/ketankr9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketankr9/subscriptions","organizations_url":"https://api.github.com/users/ketankr9/orgs","repos_url":"https://api.github.com/users/ketankr9/repos","events_url":"https://api.github.com/users/ketankr9/events{/privacy}","received_events_url":"https://api.github.com/users/ketankr9/received_events","type":"User","site_admin":false},"body":"fixes #1755 \r\nif message is modified in python destination then ```_py_log_message_setattr``` returns -1 and python RuntimeError is reported.\r\nCrashing solved.\r\nIn case value-pair is not given.\r\nSigned-off-by: Utsav Krishnan <utsav.krishnan.cse15@iitbhu.ac.in>","created_at":"2018-03-08T15:40:23Z","updated_at":"2018-03-24T08:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e46c2fc84be0a04ac7c0e9a798423fc236ba74c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":208670777,"url":"https://api.github.com/repos/balabit/syslog-ng/labels/community-driven-merge","name":"community-driven-merge","color":"006b75","default":false},{"id":122658708,"url":"https://api.github.com/repos/balabit/syslog-ng/labels/needs-review","name":"needs-review","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1920/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/877c2eea10c38b971faa36dbe0e5faf3fdd5ff3a","head":{"label":"ketankr9:modifycrash","ref":"modifycrash","sha":"877c2eea10c38b971faa36dbe0e5faf3fdd5ff3a","user":{"login":"ketankr9","id":15634055,"avatar_url":"https://avatars2.githubusercontent.com/u/15634055?v=4","gravatar_id":"","url":"https://api.github.com/users/ketankr9","html_url":"https://github.com/ketankr9","followers_url":"https://api.github.com/users/ketankr9/followers","following_url":"https://api.github.com/users/ketankr9/following{/other_user}","gists_url":"https://api.github.com/users/ketankr9/gists{/gist_id}","starred_url":"https://api.github.com/users/ketankr9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketankr9/subscriptions","organizations_url":"https://api.github.com/users/ketankr9/orgs","repos_url":"https://api.github.com/users/ketankr9/repos","events_url":"https://api.github.com/users/ketankr9/events{/privacy}","received_events_url":"https://api.github.com/users/ketankr9/received_events","type":"User","site_admin":false},"repo":{"id":123556581,"name":"syslog-ng","full_name":"ketankr9/syslog-ng","owner":{"login":"ketankr9","id":15634055,"avatar_url":"https://avatars2.githubusercontent.com/u/15634055?v=4","gravatar_id":"","url":"https://api.github.com/users/ketankr9","html_url":"https://github.com/ketankr9","followers_url":"https://api.github.com/users/ketankr9/followers","following_url":"https://api.github.com/users/ketankr9/following{/other_user}","gists_url":"https://api.github.com/users/ketankr9/gists{/gist_id}","starred_url":"https://api.github.com/users/ketankr9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketankr9/subscriptions","organizations_url":"https://api.github.com/users/ketankr9/orgs","repos_url":"https://api.github.com/users/ketankr9/repos","events_url":"https://api.github.com/users/ketankr9/events{/privacy}","received_events_url":"https://api.github.com/users/ketankr9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ketankr9/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/ketankr9/syslog-ng","forks_url":"https://api.github.com/repos/ketankr9/syslog-ng/forks","keys_url":"https://api.github.com/repos/ketankr9/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ketankr9/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ketankr9/syslog-ng/teams","hooks_url":"https://api.github.com/repos/ketankr9/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/ketankr9/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/ketankr9/syslog-ng/events","assignees_url":"https://api.github.com/repos/ketankr9/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/ketankr9/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/ketankr9/syslog-ng/tags","blobs_url":"https://api.github.com/repos/ketankr9/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ketankr9/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ketankr9/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/ketankr9/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ketankr9/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/ketankr9/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/ketankr9/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/ketankr9/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/ketankr9/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/ketankr9/syslog-ng/subscription","commits_url":"https://api.github.com/repos/ketankr9/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/ketankr9/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/ketankr9/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/ketankr9/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/ketankr9/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/ketankr9/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ketankr9/syslog-ng/merges","archive_url":"https://api.github.com/repos/ketankr9/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ketankr9/syslog-ng/downloads","issues_url":"https://api.github.com/repos/ketankr9/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/ketankr9/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/ketankr9/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/ketankr9/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ketankr9/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/ketankr9/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/ketankr9/syslog-ng/deployments","created_at":"2018-03-02T09:04:36Z","updated_at":"2018-03-02T09:04:42Z","pushed_at":"2018-03-24T08:00:34Z","git_url":"git://github.com/ketankr9/syslog-ng.git","ssh_url":"git@github.com:ketankr9/syslog-ng.git","clone_url":"https://github.com/ketankr9/syslog-ng.git","svn_url":"https://github.com/ketankr9/syslog-ng","homepage":"http://www.syslog-ng.org/","size":22753,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"2cf32b9fd1d6a3c0b7cdca65c849bdd4e2c94605","user":{"login":"balabit","id":986981,"avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"name":"syslog-ng","full_name":"balabit/syslog-ng","owner":{"login":"balabit","id":986981,"avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2018-03-23T13:54:39Z","pushed_at":"2018-03-24T08:00:36Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":23017,"stargazers_count":766,"watchers_count":766,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":184,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":211,"open_issues":184,"watchers":766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1920"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1920"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1920/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1920/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/877c2eea10c38b971faa36dbe0e5faf3fdd5ff3a"}},"author_association":"NONE"}}
{"actor":{"display_login":"ketankr9"}}