{"push_id":2519056173,"size":290,"distinct_size":2,"ref":"refs/heads/protobuf_v2_docs","head":"4ee65b4920c7d9bec95d83cd708285752c4e843d","before":"634a4c1372e6d98bfa9d12094adbc83a2457517f","commits":[{"sha":"014ca7dfaaff9c44ecbb7c84e6ef469db540edf9","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Protobuf uses its own event class\n\nand protobuf generated class is only passed as Data !\n\nthis should make serialization for background jobs and networking easier.\n\nIssue: #228","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/014ca7dfaaff9c44ecbb7c84e6ef469db540edf9"},{"sha":"b00583858209b66ca743db8690730ea910840c9b","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Use descriptor name instead of class name\n\nres_testing.OrderCreated instead of ResTesting::OrderCreated,\nthis is less ruby-related and more protobuf oriented. If that descriptor\nname is used throught many apps, it should be easier to handle it\ncompared to ruby classes.\n\nIssue: #228","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/b00583858209b66ca743db8690730ea910840c9b"},{"sha":"b36a5ab1406611a6a6548f4c16ca361d359b6700","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Workaround YAML serialization issues with protobuf\n\nby handling it on Proto wrapper level.\n\nSeriously approaching this would require having a :mapper exposed\nin :dispatcher which would require having it exposed in :broker but it\nis already used in :repository.\n\nSo either we move the dependency higher and pass it down through many\nlayers, or make it a responsibility of :repository which can delegate to\n:mapper if it wants to but then we would need to pass :repository around\nto :dispatcher so it could call #event_to_serialized_record when enquing\na job and #serialized_record_to_event when dequeing.\n\nI am not yet convinced about it.\n\nTwo additional thoughts:\n\n* maybe repository should return RubyEventStore::SerializedRecord\n  and then the migher layer (Client) would use the :mapper to transform\n  it to the right event object.\n\n* similarly when saving we could do the same, the other way, Client\n  would already use mapper to serialize the event and repository would\n  receive RubyEventStore::SerializedRecord.\n\n* The benefit would be that we could get RAW data from repository, not\n  transform it to domain events and stream over network.\n\n  Current solution require getting domain events (which are\n  deserialized) and then serializing them again to send over wire.\n\nIssue: #228 #255","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/b36a5ab1406611a6a6548f4c16ca361d359b6700"},{"sha":"4505c93f5ab5e39f8e75931dedcca7c2158fd7d4","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Proto wrapper for events with protobuf class as data\n\nRationale explained in b36a5ab1406611a6a6548f4c16ca361d359b6700\n\nIssue: #228 #255 #257","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/4505c93f5ab5e39f8e75931dedcca7c2158fd7d4"},{"sha":"dabf1edd1bdb84436b7b7c2b56062a92d53b1ebf","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Confirm protobuf working with async handlers\n\nby using Proto wrapper and implementing YAML serialization which\ndelegates for proto serialization in case of event's :data field.\n\nIssue: #228 #255 #257","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/dabf1edd1bdb84436b7b7c2b56062a92d53b1ebf"},{"sha":"54929496946763c60afcbfc2ddbffc323c1131b9","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"One more test","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/54929496946763c60afcbfc2ddbffc323c1131b9"},{"sha":"4d13a6e0eaf5ab6eb1461ba6cf25c9e39fcfc281","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Simplify implementation\n\nIssue: #228 #255 #257","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/4d13a6e0eaf5ab6eb1461ba6cf25c9e39fcfc281"},{"sha":"5afecfd189ef10364001c23b3be31def191051c4","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Reimplement == operator in Proto class\n\nbecuase of eql? behavior/bug from google-protobuf:\nhttps://github.com/google/protobuf/issues/4455\n\nand bring back the original implementation to RubyEventStore::Event\nwhich uses eql? instead of ==.\n\nIssue: #228 #255 #257","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/5afecfd189ef10364001c23b3be31def191051c4"},{"sha":"a6b547049b820c12fbec9fa4f1ac00c149c00202","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Remove #add_metadata leftovers\n\nIssue: #228 #255","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/a6b547049b820c12fbec9fa4f1ac00c149c00202"},{"sha":"08961bbf0bdc99c301c09601ab6dfc349ab836e9","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Update protobuf&mappers documentation\n\nIssue: #228 #255","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/08961bbf0bdc99c301c09601ab6dfc349ab836e9"},{"sha":"e6d3b0f44c84b99ef01d6e347345db3974101ce1","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Merge remote-tracking branch 'origin/master' into protobuf_v2","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/e6d3b0f44c84b99ef01d6e347345db3974101ce1"},{"sha":"f67794ba53fc9dc4a036a0eb9e0e9318be26929c","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Merge remote-tracking branch 'origin/master' into protobuf_v2","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/f67794ba53fc9dc4a036a0eb9e0e9318be26929c"},{"sha":"2cb50ff266fdc310ff02bfb98a7a3e56344390a0","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Bring back original docs from master\n\ndocs will be merged from separate PR\n\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/2cb50ff266fdc310ff02bfb98a7a3e56344390a0"},{"sha":"1b584ed4c9790289da0904f94a174d2be05ada56","author":{"name":"Robert Pankowecki","email":"9068babab6c3b2533cc9a8854c61be57cdbd7609@gmail.com"},"message":"Merge pull request #255 from RailsEventStore/protobuf_v2\n\nWIP: Protobuf v2","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/1b584ed4c9790289da0904f94a174d2be05ada56"},{"sha":"d9a98bede32c16ffac9a1a82a0438da95c0bb8b2","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Created initial ROM SQL adapter to decouple from ActiveRecord and Rails","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/d9a98bede32c16ffac9a1a82a0438da95c0bb8b2"},{"sha":"0e4246e412b8183ca404d5e364602ef44b9cb48b","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Use ROM mapping DSL and removed unused Entities","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/0e4246e412b8183ca404d5e364602ef44b9cb48b"},{"sha":"2c7841f36640db0c87b7313485c34bb95e1d44c7","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Move read methods","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/2c7841f36640db0c87b7313485c34bb95e1d44c7"},{"sha":"0176ac0c1c893bbafccc8545d540747b986f2046","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Rename ROM repository methods for simpler naming","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/0176ac0c1c893bbafccc8545d540747b986f2046"},{"sha":"e7801bd857b48c58da9d53c6fa9e4ed8ecac9dfc","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Refactored to remove helper methods on read repository","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/e7801bd857b48c58da9d53c6fa9e4ed8ecac9dfc"},{"sha":"13e36889429a2b7526b01605a9586c6d59c56e4c","author":{"name":"Joel Van Horn","email":"4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@joelvanhorn.com"},"message":"Remove `created_at` argument","distinct":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits/13e36889429a2b7526b01605a9586c6d59c56e4c"}]}
{"actor":{"display_login":"paneq"}}