{"action":"created","comment":{"url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/comments/219692562","pull_request_review_id":157933187,"id":219692562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY5MjU2Mg==","diff_hunk":"@@ -136,11 +136,11 @@ def __init__(self, txxd):\n         # # #\n \n         if txxd is not None:\n-            count = Signal(max=max(txxd+1, 2))\n+            count = Signal(max=max(txxd, 2))","path":"litedram/core/multiplexer.py","position":5,"original_position":5,"commit_id":"8447d69326af686bdc7db5daf54067cedf0ef12b","original_commit_id":"8447d69326af686bdc7db5daf54067cedf0ef12b","user":{"login":"JohnSully","id":3894786,"node_id":"MDQ6VXNlcjM4OTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/3894786?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnSully","html_url":"https://github.com/JohnSully","followers_url":"https://api.github.com/users/JohnSully/followers","following_url":"https://api.github.com/users/JohnSully/following{/other_user}","gists_url":"https://api.github.com/users/JohnSully/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnSully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnSully/subscriptions","organizations_url":"https://api.github.com/users/JohnSully/orgs","repos_url":"https://api.github.com/users/JohnSully/repos","events_url":"https://api.github.com/users/JohnSully/events{/privacy}","received_events_url":"https://api.github.com/users/JohnSully/received_events","type":"User","site_admin":false},"body":"You are correct, but then the fix stops working so I think the bug is more complex.  Getting closer to a solution.","created_at":"2018-09-23T08:59:49Z","updated_at":"2018-09-23T08:59:49Z","html_url":"https://github.com/enjoy-digital/litedram/pull/42#discussion_r219692562","pull_request_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/comments/219692562"},"html":{"href":"https://github.com/enjoy-digital/litedram/pull/42#discussion_r219692562"},"pull_request":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42"}},"in_reply_to_id":219691123},"pull_request":{"url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42","id":217483803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDgzODAz","html_url":"https://github.com/enjoy-digital/litedram/pull/42","diff_url":"https://github.com/enjoy-digital/litedram/pull/42.diff","patch_url":"https://github.com/enjoy-digital/litedram/pull/42.patch","issue_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/42","number":42,"state":"open","locked":false,"title":"We wait an extra cycle for no reason","user":{"login":"JohnSully","id":3894786,"node_id":"MDQ6VXNlcjM4OTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/3894786?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnSully","html_url":"https://github.com/JohnSully","followers_url":"https://api.github.com/users/JohnSully/followers","following_url":"https://api.github.com/users/JohnSully/following{/other_user}","gists_url":"https://api.github.com/users/JohnSully/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnSully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnSully/subscriptions","organizations_url":"https://api.github.com/users/JohnSully/orgs","repos_url":"https://api.github.com/users/JohnSully/repos","events_url":"https://api.github.com/users/JohnSully/events{/privacy}","received_events_url":"https://api.github.com/users/JohnSully/received_events","type":"User","site_admin":false},"body":"I know I broke this and insisted it was right... To be fair there were a lot of other timing errors back then so perhaps it was confusion with one of those.  Anyways the extra cycle in tCCD is what capped 1:2 @ 66% peak performance.  This affects other timings but they don't have the same magnitude of effect.\r\n\r\nIssue #40 ","created_at":"2018-09-22T23:31:11Z","updated_at":"2018-09-23T08:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd2a904987923d5a964acddcbb43d493cc1eae5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42/commits","review_comments_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42/comments","review_comment_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/42/comments","statuses_url":"https://api.github.com/repos/enjoy-digital/litedram/statuses/8447d69326af686bdc7db5daf54067cedf0ef12b","head":{"label":"enjoy-digital:HalfRateSequentialFix","ref":"HalfRateSequentialFix","sha":"8447d69326af686bdc7db5daf54067cedf0ef12b","user":{"login":"enjoy-digital","id":1450143,"node_id":"MDQ6VXNlcjE0NTAxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"repo":{"id":31147284,"node_id":"MDEwOlJlcG9zaXRvcnkzMTE0NzI4NA==","name":"litedram","full_name":"enjoy-digital/litedram","private":false,"owner":{"login":"enjoy-digital","id":1450143,"node_id":"MDQ6VXNlcjE0NTAxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"html_url":"https://github.com/enjoy-digital/litedram","description":"Small footprint and configurable DRAM core","fork":false,"url":"https://api.github.com/repos/enjoy-digital/litedram","forks_url":"https://api.github.com/repos/enjoy-digital/litedram/forks","keys_url":"https://api.github.com/repos/enjoy-digital/litedram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enjoy-digital/litedram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enjoy-digital/litedram/teams","hooks_url":"https://api.github.com/repos/enjoy-digital/litedram/hooks","issue_events_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/events{/number}","events_url":"https://api.github.com/repos/enjoy-digital/litedram/events","assignees_url":"https://api.github.com/repos/enjoy-digital/litedram/assignees{/user}","branches_url":"https://api.github.com/repos/enjoy-digital/litedram/branches{/branch}","tags_url":"https://api.github.com/repos/enjoy-digital/litedram/tags","blobs_url":"https://api.github.com/repos/enjoy-digital/litedram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enjoy-digital/litedram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enjoy-digital/litedram/git/refs{/sha}","trees_url":"https://api.github.com/repos/enjoy-digital/litedram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enjoy-digital/litedram/statuses/{sha}","languages_url":"https://api.github.com/repos/enjoy-digital/litedram/languages","stargazers_url":"https://api.github.com/repos/enjoy-digital/litedram/stargazers","contributors_url":"https://api.github.com/repos/enjoy-digital/litedram/contributors","subscribers_url":"https://api.github.com/repos/enjoy-digital/litedram/subscribers","subscription_url":"https://api.github.com/repos/enjoy-digital/litedram/subscription","commits_url":"https://api.github.com/repos/enjoy-digital/litedram/commits{/sha}","git_commits_url":"https://api.github.com/repos/enjoy-digital/litedram/git/commits{/sha}","comments_url":"https://api.github.com/repos/enjoy-digital/litedram/comments{/number}","issue_comment_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/comments{/number}","contents_url":"https://api.github.com/repos/enjoy-digital/litedram/contents/{+path}","compare_url":"https://api.github.com/repos/enjoy-digital/litedram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enjoy-digital/litedram/merges","archive_url":"https://api.github.com/repos/enjoy-digital/litedram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enjoy-digital/litedram/downloads","issues_url":"https://api.github.com/repos/enjoy-digital/litedram/issues{/number}","pulls_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls{/number}","milestones_url":"https://api.github.com/repos/enjoy-digital/litedram/milestones{/number}","notifications_url":"https://api.github.com/repos/enjoy-digital/litedram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enjoy-digital/litedram/labels{/name}","releases_url":"https://api.github.com/repos/enjoy-digital/litedram/releases{/id}","deployments_url":"https://api.github.com/repos/enjoy-digital/litedram/deployments","created_at":"2015-02-22T00:43:35Z","updated_at":"2018-09-22T16:37:01Z","pushed_at":"2018-09-23T07:40:15Z","git_url":"git://github.com/enjoy-digital/litedram.git","ssh_url":"git@github.com:enjoy-digital/litedram.git","clone_url":"https://github.com/enjoy-digital/litedram.git","svn_url":"https://github.com/enjoy-digital/litedram","homepage":"","size":547,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":6,"watchers":24,"default_branch":"master"}},"base":{"label":"enjoy-digital:master","ref":"master","sha":"c12404e00c2021860db18e3d9b59fa0b8ecad677","user":{"login":"enjoy-digital","id":1450143,"node_id":"MDQ6VXNlcjE0NTAxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"repo":{"id":31147284,"node_id":"MDEwOlJlcG9zaXRvcnkzMTE0NzI4NA==","name":"litedram","full_name":"enjoy-digital/litedram","private":false,"owner":{"login":"enjoy-digital","id":1450143,"node_id":"MDQ6VXNlcjE0NTAxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"html_url":"https://github.com/enjoy-digital/litedram","description":"Small footprint and configurable DRAM core","fork":false,"url":"https://api.github.com/repos/enjoy-digital/litedram","forks_url":"https://api.github.com/repos/enjoy-digital/litedram/forks","keys_url":"https://api.github.com/repos/enjoy-digital/litedram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enjoy-digital/litedram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enjoy-digital/litedram/teams","hooks_url":"https://api.github.com/repos/enjoy-digital/litedram/hooks","issue_events_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/events{/number}","events_url":"https://api.github.com/repos/enjoy-digital/litedram/events","assignees_url":"https://api.github.com/repos/enjoy-digital/litedram/assignees{/user}","branches_url":"https://api.github.com/repos/enjoy-digital/litedram/branches{/branch}","tags_url":"https://api.github.com/repos/enjoy-digital/litedram/tags","blobs_url":"https://api.github.com/repos/enjoy-digital/litedram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enjoy-digital/litedram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enjoy-digital/litedram/git/refs{/sha}","trees_url":"https://api.github.com/repos/enjoy-digital/litedram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enjoy-digital/litedram/statuses/{sha}","languages_url":"https://api.github.com/repos/enjoy-digital/litedram/languages","stargazers_url":"https://api.github.com/repos/enjoy-digital/litedram/stargazers","contributors_url":"https://api.github.com/repos/enjoy-digital/litedram/contributors","subscribers_url":"https://api.github.com/repos/enjoy-digital/litedram/subscribers","subscription_url":"https://api.github.com/repos/enjoy-digital/litedram/subscription","commits_url":"https://api.github.com/repos/enjoy-digital/litedram/commits{/sha}","git_commits_url":"https://api.github.com/repos/enjoy-digital/litedram/git/commits{/sha}","comments_url":"https://api.github.com/repos/enjoy-digital/litedram/comments{/number}","issue_comment_url":"https://api.github.com/repos/enjoy-digital/litedram/issues/comments{/number}","contents_url":"https://api.github.com/repos/enjoy-digital/litedram/contents/{+path}","compare_url":"https://api.github.com/repos/enjoy-digital/litedram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enjoy-digital/litedram/merges","archive_url":"https://api.github.com/repos/enjoy-digital/litedram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enjoy-digital/litedram/downloads","issues_url":"https://api.github.com/repos/enjoy-digital/litedram/issues{/number}","pulls_url":"https://api.github.com/repos/enjoy-digital/litedram/pulls{/number}","milestones_url":"https://api.github.com/repos/enjoy-digital/litedram/milestones{/number}","notifications_url":"https://api.github.com/repos/enjoy-digital/litedram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enjoy-digital/litedram/labels{/name}","releases_url":"https://api.github.com/repos/enjoy-digital/litedram/releases{/id}","deployments_url":"https://api.github.com/repos/enjoy-digital/litedram/deployments","created_at":"2015-02-22T00:43:35Z","updated_at":"2018-09-22T16:37:01Z","pushed_at":"2018-09-23T07:40:15Z","git_url":"git://github.com/enjoy-digital/litedram.git","ssh_url":"git@github.com:enjoy-digital/litedram.git","clone_url":"https://github.com/enjoy-digital/litedram.git","svn_url":"https://github.com/enjoy-digital/litedram","homepage":"","size":547,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":6,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42"},"html":{"href":"https://github.com/enjoy-digital/litedram/pull/42"},"issue":{"href":"https://api.github.com/repos/enjoy-digital/litedram/issues/42"},"comments":{"href":"https://api.github.com/repos/enjoy-digital/litedram/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enjoy-digital/litedram/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/enjoy-digital/litedram/statuses/8447d69326af686bdc7db5daf54067cedf0ef12b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"JohnSully"}}