{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/192576579","pull_request_review_id":125382941,"id":192576579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU3NjU3OQ==","diff_hunk":"@@ -387,6 +390,12 @@ function nnz(lu::UmfpackLU)\n     return Int(lnz + unz)\n end\n \n+function LinearAlgebra.issuccess(lu::UmfpackLU)\n+    U, status = umfpack_numeric!(lu, false)\n+    return status == UMFPACK_OK\n+end","path":"stdlib/SuiteSparse/src/umfpack.jl","position":132,"original_position":133,"commit_id":"30b7db2193d231b4ae1efe31fc2d96f1bf6fbcbe","original_commit_id":"e970dd61723ea13fa14835bce205366b47cb3754","user":{"login":"fredrikekre","id":11698744,"node_id":"MDQ6VXNlcjExNjk4NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/11698744?v=4","gravatar_id":"","url":"https://api.github.com/users/fredrikekre","html_url":"https://github.com/fredrikekre","followers_url":"https://api.github.com/users/fredrikekre/followers","following_url":"https://api.github.com/users/fredrikekre/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekre/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekre/subscriptions","organizations_url":"https://api.github.com/users/fredrikekre/orgs","repos_url":"https://api.github.com/users/fredrikekre/repos","events_url":"https://api.github.com/users/fredrikekre/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekre/received_events","type":"User","site_admin":false},"body":"I was wondering the same when I wrote this, my tests suggested it was an quick return, but I tried again now (with larger matrices) and that does not seem to be the case... Might have to store `status` in the struct after all!","created_at":"2018-06-03T04:11:26Z","updated_at":"2018-06-03T04:11:26Z","html_url":"https://github.com/JuliaLang/julia/pull/27336#discussion_r192576579","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27336","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/192576579"},"html":{"href":"https://github.com/JuliaLang/julia/pull/27336#discussion_r192576579"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27336"}},"in_reply_to_id":192575367},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/27336","id":191612974,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjEyOTc0","html_url":"https://github.com/JuliaLang/julia/pull/27336","diff_url":"https://github.com/JuliaLang/julia/pull/27336.diff","patch_url":"https://github.com/JuliaLang/julia/pull/27336.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/27336","number":27336,"state":"open","locked":false,"title":"check kwarg for factorizations","user":{"login":"fredrikekre","id":11698744,"node_id":"MDQ6VXNlcjExNjk4NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/11698744?v=4","gravatar_id":"","url":"https://api.github.com/users/fredrikekre","html_url":"https://github.com/fredrikekre","followers_url":"https://api.github.com/users/fredrikekre/followers","following_url":"https://api.github.com/users/fredrikekre/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekre/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekre/subscriptions","organizations_url":"https://api.github.com/users/fredrikekre/orgs","repos_url":"https://api.github.com/users/fredrikekre/repos","events_url":"https://api.github.com/users/fredrikekre/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekre/received_events","type":"User","site_admin":false},"body":"Still some cleanup to do.","created_at":"2018-05-31T00:11:31Z","updated_at":"2018-06-03T04:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ebfef11723a17bad5c5757707b9a6f2e787450e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbauman","id":154641,"node_id":"MDQ6VXNlcjE1NDY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/154641?v=4","gravatar_id":"","url":"https://api.github.com/users/mbauman","html_url":"https://github.com/mbauman","followers_url":"https://api.github.com/users/mbauman/followers","following_url":"https://api.github.com/users/mbauman/following{/other_user}","gists_url":"https://api.github.com/users/mbauman/gists{/gist_id}","starred_url":"https://api.github.com/users/mbauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbauman/subscriptions","organizations_url":"https://api.github.com/users/mbauman/orgs","repos_url":"https://api.github.com/users/mbauman/repos","events_url":"https://api.github.com/users/mbauman/events{/privacy}","received_events_url":"https://api.github.com/users/mbauman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":61807486,"node_id":"MDU6TGFiZWw2MTgwNzQ4Ng==","url":"https://api.github.com/repos/JuliaLang/julia/labels/linear%20algebra","name":"linear algebra","color":"f2b3db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27336/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/27336/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/27336/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/30b7db2193d231b4ae1efe31fc2d96f1bf6fbcbe","head":{"label":"JuliaLang:fe/check-or-not-to-check-that-is-the-question","ref":"fe/check-or-not-to-check-that-is-the-question","sha":"30b7db2193d231b4ae1efe31fc2d96f1bf6fbcbe","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-06-02T22:15:00Z","pushed_at":"2018-06-03T04:01:32Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":406818,"stargazers_count":11146,"watchers_count":11146,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2365,"mirror_url":null,"archived":false,"open_issues_count":2562,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2365,"open_issues":2562,"watchers":11146,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"c8ce43ad173a9126e902dda246b74cb6e83eaded","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-06-02T22:15:00Z","pushed_at":"2018-06-03T04:01:32Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":406818,"stargazers_count":11146,"watchers_count":11146,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2365,"mirror_url":null,"archived":false,"open_issues_count":2562,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2365,"open_issues":2562,"watchers":11146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27336"},"html":{"href":"https://github.com/JuliaLang/julia/pull/27336"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/27336"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/27336/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27336/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/27336/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/30b7db2193d231b4ae1efe31fc2d96f1bf6fbcbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fredrikekre"}}