{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52/events","html_url":"https://github.com/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52","id":328436786,"node_id":"MDU6SXNzdWUzMjg0MzY3ODY=","number":52,"title":"Support partitionKeyExpression","user":{"login":"jihlee","id":1914264,"node_id":"MDQ6VXNlcjE5MTQyNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1914264?v=4","gravatar_id":"","url":"https://api.github.com/users/jihlee","html_url":"https://github.com/jihlee","followers_url":"https://api.github.com/users/jihlee/followers","following_url":"https://api.github.com/users/jihlee/following{/other_user}","gists_url":"https://api.github.com/users/jihlee/gists{/gist_id}","starred_url":"https://api.github.com/users/jihlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihlee/subscriptions","organizations_url":"https://api.github.com/users/jihlee/orgs","repos_url":"https://api.github.com/users/jihlee/repos","events_url":"https://api.github.com/users/jihlee/events{/privacy}","received_events_url":"https://api.github.com/users/jihlee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-01T09:00:31Z","updated_at":"2018-06-01T15:35:41Z","closed_at":null,"author_association":"NONE","body":"**kinesis binder version**: 1.0.0.M2\r\n\r\nI found out that Kinesis binder does not support configuration of partition currently.\r\nI set up spring.cloud.stream.bindings.output.producer.partitionKeyExpression properties, but partition key sent to Kinesis was not changed but it was like \"partitionKey-0\".\r\n\r\nIt seems that Kinesis binder does not use partitionKeyExpression properties and set partitionKeyExpression as 'partitionKey-headers[\"scst_partition\"]' \r\n\r\nKinesis's message sequence number monotonically increases only in shard; the missing feature could be potentially dangerous to application whose the order of messages should be guaranteed.\r\n\r\nIs there any issue or suggestion among this?\r\n\r\n**References**\r\nhttps://docs.spring.io/spring-cloud-stream/docs/current/reference/htmlsingle/#_partitioning\r\nhttps://docs.aws.amazon.com/streams/latest/dev/key-concepts.html#shard\r\nhttps://forums.aws.amazon.com/thread.jspa?threadID=216870 \r\nhttps://github.com/spring-cloud/spring-cloud-stream-binder-aws-kinesis/blob/ea8d5652f5ab1091179fa0556f616ab13d4d3cdf/spring-cloud-stream-binder-kinesis/src/main/java/org/springframework/cloud/stream/binder/kinesis/KinesisMessageChannelBinder.java#L121"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/comments/393918535","html_url":"https://github.com/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52#issuecomment-393918535","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-binder-aws-kinesis/issues/52","id":393918535,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzkxODUzNQ==","user":{"login":"artembilan","id":1071590,"node_id":"MDQ6VXNlcjEwNzE1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1071590?v=4","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T15:35:41Z","updated_at":"2018-06-01T15:35:41Z","author_association":"CONTRIBUTOR","body":"@sobychacko ,\r\n\r\nWould you mind to help here to explain how partitioning works in Spring Cloud Stream?\r\nI some how lost in all that hard logic around `PartitionHandler` and `BinderHeaders.PARTITION_HEADER` & `BinderHeaders.PARTITION_OVERRIDE`.\r\n\r\nThanks"}}
{"actor":{"display_login":"artembilan"}}