{"action":"closed","number":878,"pull_request":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/878","id":239542812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTQyODEy","html_url":"https://github.com/contiamo/operational-ui/pull/878","diff_url":"https://github.com/contiamo/operational-ui/pull/878.diff","patch_url":"https://github.com/contiamo/operational-ui/pull/878.patch","issue_url":"https://api.github.com/repos/contiamo/operational-ui/issues/878","number":878,"state":"closed","locked":false,"title":"**Feature:** Add sortable feature to Table","user":{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false},"body":"<!-- \r\n  ❗️IMPORTANT ❗️\r\n  Please prefix the title of this PR with _one_ of the following.\r\n\r\n  **Breaking:**\r\n    For when we break a public API.\r\n\r\n  **Feature:** \r\n    For when we add something NEW that doesn't\r\n    break the public API.\r\n      \r\n  **Fix:**\r\n    For when we fix something that previously\r\n    did not look or work correctly.\r\n    \r\n  Leaving off this prefix will prevent the PR from being\r\n  included in a release. A good case to omit the prefix\r\n  is when proposing infrastructural changes to the repo\r\n  that do not affect the library.\r\n-->\r\n# Summary\r\n\r\nAdd sortable feature to Table. Simply add `onSortClick` and `sortBy` in each column to handle any custom sorting logic.\r\n\r\n![b69a2ecb-4823-4354-9a17-9dea39667a64](https://user-images.githubusercontent.com/1761469/50166103-9d854000-02e6-11e9-9f99-dc5634c7849c.gif)\r\n\r\n\r\n# Related issue\r\n\r\nhttps://trello.com/c/H6uFjzZN\r\n\r\n# To be tested\r\n\r\nMe\r\n- [x] No error or warning in the console on `localhost:6060`\r\n\r\nTester 1\r\n\r\n- [ ] Things look good on the demo.\r\n- [ ] I can sort a table\r\n  <!-- Put here everything that the reviewer 1 should test to be sure that everything is working properly -->\r\n\r\nTester 2\r\n\r\n- [ ] Things look good on the demo.\r\n- [ ] I can sort a table\r\n  <!-- Put here everything that the reviewer 2 should test to be sure that everything is working properly -->\r\n","created_at":"2018-12-18T16:03:16Z","updated_at":"2018-12-20T11:14:32Z","closed_at":"2018-12-20T11:14:32Z","merged_at":"2018-12-20T11:14:32Z","merge_commit_sha":"45339f6fddfbf749c2b75b5796404d709cea0d8d","assignee":{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/878/commits","review_comments_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/878/comments","review_comment_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/issues/878/comments","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/73841872d095395358613057eb2b335f8cb0f99c","head":{"label":"contiamo:feat-sortable-table","ref":"feat-sortable-table","sha":"73841872d095395358613057eb2b335f8cb0f99c","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","private":false,"owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-12-20T11:14:08Z","pushed_at":"2018-12-20T11:14:32Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org","size":45380,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":17,"watchers":41,"default_branch":"master"}},"base":{"label":"contiamo:master","ref":"master","sha":"2b3e79d7baaeb6b02921e34a2e6024b5ab0a81a5","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","private":false,"owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-12-20T11:14:08Z","pushed_at":"2018-12-20T11:14:32Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org","size":45380,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":17,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/878"},"html":{"href":"https://github.com/contiamo/operational-ui/pull/878"},"issue":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/878"},"comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/contiamo/operational-ui/statuses/73841872d095395358613057eb2b335f8cb0f99c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false},"comments":14,"review_comments":1,"maintainer_can_modify":false,"commits":5,"additions":121,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"fabien0102"}}