{"action":"closed","issue":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2685","repository_url":"https://api.github.com/repos/varnishcache/varnish-cache","labels_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2685/labels{/name}","comments_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2685/comments","events_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2685/events","html_url":"https://github.com/varnishcache/varnish-cache/issues/2685","id":324848338,"number":2685,"title":"VCC missing to emit VRT_CollectString if last string segment is functioncall","user":{"login":"nigoroll","id":1528104,"avatar_url":"https://avatars0.githubusercontent.com/u/1528104?v=4","gravatar_id":"","url":"https://api.github.com/users/nigoroll","html_url":"https://github.com/nigoroll","followers_url":"https://api.github.com/users/nigoroll/followers","following_url":"https://api.github.com/users/nigoroll/following{/other_user}","gists_url":"https://api.github.com/users/nigoroll/gists{/gist_id}","starred_url":"https://api.github.com/users/nigoroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigoroll/subscriptions","organizations_url":"https://api.github.com/users/nigoroll/orgs","repos_url":"https://api.github.com/users/nigoroll/repos","events_url":"https://api.github.com/users/nigoroll/events{/privacy}","received_events_url":"https://api.github.com/users/nigoroll/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"bsdphk","id":567236,"avatar_url":"https://avatars3.githubusercontent.com/u/567236?v=4","gravatar_id":"","url":"https://api.github.com/users/bsdphk","html_url":"https://github.com/bsdphk","followers_url":"https://api.github.com/users/bsdphk/followers","following_url":"https://api.github.com/users/bsdphk/following{/other_user}","gists_url":"https://api.github.com/users/bsdphk/gists{/gist_id}","starred_url":"https://api.github.com/users/bsdphk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsdphk/subscriptions","organizations_url":"https://api.github.com/users/bsdphk/orgs","repos_url":"https://api.github.com/users/bsdphk/repos","events_url":"https://api.github.com/users/bsdphk/events{/privacy}","received_events_url":"https://api.github.com/users/bsdphk/received_events","type":"User","site_admin":false},"assignees":[{"login":"bsdphk","id":567236,"avatar_url":"https://avatars3.githubusercontent.com/u/567236?v=4","gravatar_id":"","url":"https://api.github.com/users/bsdphk","html_url":"https://github.com/bsdphk","followers_url":"https://api.github.com/users/bsdphk/followers","following_url":"https://api.github.com/users/bsdphk/following{/other_user}","gists_url":"https://api.github.com/users/bsdphk/gists{/gist_id}","starred_url":"https://api.github.com/users/bsdphk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsdphk/subscriptions","organizations_url":"https://api.github.com/users/bsdphk/orgs","repos_url":"https://api.github.com/users/bsdphk/repos","events_url":"https://api.github.com/users/bsdphk/events{/privacy}","received_events_url":"https://api.github.com/users/bsdphk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-21T09:28:46Z","updated_at":"2018-05-22T14:27:56Z","closed_at":"2018-05-22T14:27:56Z","author_association":"CONTRIBUTOR","body":"to reproduce:\r\n\r\n```\r\ndiff --git a/bin/varnishtest/tests/c00068.vtc b/bin/varnishtest/tests/c00068.vtc\r\nindex 88a47b631..5fb3b48f9 100644\r\n--- a/bin/varnishtest/tests/c00068.vtc\r\n+++ b/bin/varnishtest/tests/c00068.vtc\r\n@@ -10,6 +10,8 @@ server s1 {\r\n } -start\r\n \r\n varnish v1 -vcl+backend {\r\n+       import std;\r\n+\r\n        sub vcl_backend_response {\r\n                if (bereq.url == \"/333\") {\r\n                        set beresp.status = 333;\r\n@@ -18,7 +20,7 @@ varnish v1 -vcl+backend {\r\n        }\r\n        sub vcl_deliver {\r\n                if (req.url == \"/332\") {\r\n-                       return (synth(332, \"FOO\"));\r\n+                       return (synth(332, \"F\" + \"OO\" + std.tolower(\"FOO\")));\r\n                } else if (req.url == \"/333\") {\r\n                        return (synth(resp.status + 1000,\r\n                                resp.reason));\r\n@@ -64,6 +66,7 @@ client c2 {\r\n        txreq -url /332\r\n        rxresp\r\n        expect resp.status == 332\r\n+       expect resp.reason == \"FOOfoo\"\r\n        expect resp.http.restarts == 1\r\n        expect resp.bodylen == 1\r\n } -run\r\n```\r\n\r\n```\r\n**** v1    0.2 CLI RX|Message from C-compiler:\r\n**** v1    0.2 CLI RX|vgc.c: In function \\342\\200\\230VGC_function_vcl_deliver\\342\\200\\231:\r\n**** v1    0.2 CLI RX|vgc.c:1676:11: error: too many arguments to function \\342\\200\\230VRT_synth\\342\\200\\231\r\n**** v1    0.2 CLI RX|           VRT_synth(ctx,\r\n**** v1    0.2 CLI RX|           ^~~~~~~~~\r\n**** v1    0.2 CLI RX|vgc.c:562:10: note: declared here\r\n**** v1    0.2 CLI RX| VCL_VOID VRT_synth(VRT_CTX, VCL_INT, VCL_STRING);\r\n**** v1    0.2 CLI RX|          ^~~~~~~~~\r\n**** v1    0.2 CLI RX|Running C-compiler failed, exited with 1\r\n```\r\n\r\nworkaround: add another `+ \"\" after the function call`"}}
{"actor":{"display_login":"bsdphk"}}