{"action":"created","comment":{"url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/comments/199788547","pull_request_review_id":133973983,"id":199788547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc4ODU0Nw==","diff_hunk":"@@ -0,0 +1,35 @@\n+# frozen_string_literal: true\n+\n+module RuboCop\n+  module Cop\n+    module Ezcater\n+      # Enforce use of HTTP status code matchers rather than asserting on on random numbers.\n+      #\n+      # @example\n+      #\n+      #   # good\n+      #   expect(response).to be_created\n+      #   expect(response).to be_bad_request\n+      #\n+      #   # bad\n+      #   expect(response).to have_http_status 201\n+      #   expect(response).to have_http_status 400\n+      class RspecRequireHttpStatusMatcher < Cop\n+        MSG = \"Use the `have_http_status` matcher, like `expect(response).to have_http_status :bad_request`, \"\\","path":"lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb","position":18,"original_position":18,"commit_id":"7776a1cc6947cc4998ab3c3410a1b969477e5f02","original_commit_id":"7776a1cc6947cc4998ab3c3410a1b969477e5f02","user":{"login":"tjwp","id":1476506,"node_id":"MDQ6VXNlcjE0NzY1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1476506?v=4","gravatar_id":"","url":"https://api.github.com/users/tjwp","html_url":"https://github.com/tjwp","followers_url":"https://api.github.com/users/tjwp/followers","following_url":"https://api.github.com/users/tjwp/following{/other_user}","gists_url":"https://api.github.com/users/tjwp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwp/subscriptions","organizations_url":"https://api.github.com/users/tjwp/orgs","repos_url":"https://api.github.com/users/tjwp/repos","events_url":"https://api.github.com/users/tjwp/events{/privacy}","received_events_url":"https://api.github.com/users/tjwp/received_events","type":"User","site_admin":false},"body":"Are the good and bad examples above reversed? This is recommended what is listed as \"bad\" above?","created_at":"2018-07-03T12:32:28Z","updated_at":"2018-07-03T12:36:16Z","html_url":"https://github.com/ezcater/ezcater_rubocop/pull/44#discussion_r199788547","pull_request_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/comments/199788547"},"html":{"href":"https://github.com/ezcater/ezcater_rubocop/pull/44#discussion_r199788547"},"pull_request":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44","id":198781675,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzgxNjc1","html_url":"https://github.com/ezcater/ezcater_rubocop/pull/44","diff_url":"https://github.com/ezcater/ezcater_rubocop/pull/44.diff","patch_url":"https://github.com/ezcater/ezcater_rubocop/pull/44.patch","issue_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/44","number":44,"state":"open","locked":false,"title":"Add a cop to enforce response status assertion style","user":{"login":"BrentWheeldon","id":764206,"node_id":"MDQ6VXNlcjc2NDIwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/764206?v=4","gravatar_id":"","url":"https://api.github.com/users/BrentWheeldon","html_url":"https://github.com/BrentWheeldon","followers_url":"https://api.github.com/users/BrentWheeldon/followers","following_url":"https://api.github.com/users/BrentWheeldon/following{/other_user}","gists_url":"https://api.github.com/users/BrentWheeldon/gists{/gist_id}","starred_url":"https://api.github.com/users/BrentWheeldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrentWheeldon/subscriptions","organizations_url":"https://api.github.com/users/BrentWheeldon/orgs","repos_url":"https://api.github.com/users/BrentWheeldon/repos","events_url":"https://api.github.com/users/BrentWheeldon/events{/privacy}","received_events_url":"https://api.github.com/users/BrentWheeldon/received_events","type":"User","site_admin":false},"body":"## What did we change?\r\n\r\n- Add a cop to enforce response status assertion style\r\n- Enable an existing cop to enforce response status assertion style\r\n\r\n## Why are we doing this?\r\n\r\nWe decided that we'd like consistency here, and think the enforced style provides more clarity.\r\n\r\n## How was it tested?\r\n- [X] Specs\r\n- [X] Locally\r\n","created_at":"2018-07-02T20:29:55Z","updated_at":"2018-07-03T12:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c7968608de8bf5031bf2d72f2f1a1aaf971a8df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44/commits","review_comments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44/comments","review_comment_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/44/comments","statuses_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/statuses/7776a1cc6947cc4998ab3c3410a1b969477e5f02","head":{"label":"ezcater:bmw-response-predicate-matchers","ref":"bmw-response-predicate-matchers","sha":"7776a1cc6947cc4998ab3c3410a1b969477e5f02","user":{"login":"ezcater","id":11320730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzIwNzMw","avatar_url":"https://avatars2.githubusercontent.com/u/11320730?v=4","gravatar_id":"","url":"https://api.github.com/users/ezcater","html_url":"https://github.com/ezcater","followers_url":"https://api.github.com/users/ezcater/followers","following_url":"https://api.github.com/users/ezcater/following{/other_user}","gists_url":"https://api.github.com/users/ezcater/gists{/gist_id}","starred_url":"https://api.github.com/users/ezcater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezcater/subscriptions","organizations_url":"https://api.github.com/users/ezcater/orgs","repos_url":"https://api.github.com/users/ezcater/repos","events_url":"https://api.github.com/users/ezcater/events{/privacy}","received_events_url":"https://api.github.com/users/ezcater/received_events","type":"Organization","site_admin":false},"repo":{"id":105277916,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyNzc5MTY=","name":"ezcater_rubocop","full_name":"ezcater/ezcater_rubocop","owner":{"login":"ezcater","id":11320730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzIwNzMw","avatar_url":"https://avatars2.githubusercontent.com/u/11320730?v=4","gravatar_id":"","url":"https://api.github.com/users/ezcater","html_url":"https://github.com/ezcater","followers_url":"https://api.github.com/users/ezcater/followers","following_url":"https://api.github.com/users/ezcater/following{/other_user}","gists_url":"https://api.github.com/users/ezcater/gists{/gist_id}","starred_url":"https://api.github.com/users/ezcater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezcater/subscriptions","organizations_url":"https://api.github.com/users/ezcater/orgs","repos_url":"https://api.github.com/users/ezcater/repos","events_url":"https://api.github.com/users/ezcater/events{/privacy}","received_events_url":"https://api.github.com/users/ezcater/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezcater/ezcater_rubocop","description":"ezCater custom cops and shared configuration","fork":false,"url":"https://api.github.com/repos/ezcater/ezcater_rubocop","forks_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/forks","keys_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/teams","hooks_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/hooks","issue_events_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/events","assignees_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/tags","blobs_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/languages","stargazers_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/stargazers","contributors_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/contributors","subscribers_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/subscribers","subscription_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/subscription","commits_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/merges","archive_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/downloads","issues_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/labels{/name}","releases_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/deployments","created_at":"2017-09-29T13:53:24Z","updated_at":"2018-06-22T13:14:34Z","pushed_at":"2018-07-02T20:29:56Z","git_url":"git://github.com/ezcater/ezcater_rubocop.git","ssh_url":"git@github.com:ezcater/ezcater_rubocop.git","clone_url":"https://github.com/ezcater/ezcater_rubocop.git","svn_url":"https://github.com/ezcater/ezcater_rubocop","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ezcater:master","ref":"master","sha":"bdf612552dcf4b28ec00c7f764a96c685b83f9bc","user":{"login":"ezcater","id":11320730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzIwNzMw","avatar_url":"https://avatars2.githubusercontent.com/u/11320730?v=4","gravatar_id":"","url":"https://api.github.com/users/ezcater","html_url":"https://github.com/ezcater","followers_url":"https://api.github.com/users/ezcater/followers","following_url":"https://api.github.com/users/ezcater/following{/other_user}","gists_url":"https://api.github.com/users/ezcater/gists{/gist_id}","starred_url":"https://api.github.com/users/ezcater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezcater/subscriptions","organizations_url":"https://api.github.com/users/ezcater/orgs","repos_url":"https://api.github.com/users/ezcater/repos","events_url":"https://api.github.com/users/ezcater/events{/privacy}","received_events_url":"https://api.github.com/users/ezcater/received_events","type":"Organization","site_admin":false},"repo":{"id":105277916,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyNzc5MTY=","name":"ezcater_rubocop","full_name":"ezcater/ezcater_rubocop","owner":{"login":"ezcater","id":11320730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzIwNzMw","avatar_url":"https://avatars2.githubusercontent.com/u/11320730?v=4","gravatar_id":"","url":"https://api.github.com/users/ezcater","html_url":"https://github.com/ezcater","followers_url":"https://api.github.com/users/ezcater/followers","following_url":"https://api.github.com/users/ezcater/following{/other_user}","gists_url":"https://api.github.com/users/ezcater/gists{/gist_id}","starred_url":"https://api.github.com/users/ezcater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezcater/subscriptions","organizations_url":"https://api.github.com/users/ezcater/orgs","repos_url":"https://api.github.com/users/ezcater/repos","events_url":"https://api.github.com/users/ezcater/events{/privacy}","received_events_url":"https://api.github.com/users/ezcater/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezcater/ezcater_rubocop","description":"ezCater custom cops and shared configuration","fork":false,"url":"https://api.github.com/repos/ezcater/ezcater_rubocop","forks_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/forks","keys_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/teams","hooks_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/hooks","issue_events_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/events","assignees_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/tags","blobs_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/languages","stargazers_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/stargazers","contributors_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/contributors","subscribers_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/subscribers","subscription_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/subscription","commits_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/merges","archive_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/downloads","issues_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/labels{/name}","releases_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/ezcater/ezcater_rubocop/deployments","created_at":"2017-09-29T13:53:24Z","updated_at":"2018-06-22T13:14:34Z","pushed_at":"2018-07-02T20:29:56Z","git_url":"git://github.com/ezcater/ezcater_rubocop.git","ssh_url":"git@github.com:ezcater/ezcater_rubocop.git","clone_url":"https://github.com/ezcater/ezcater_rubocop.git","svn_url":"https://github.com/ezcater/ezcater_rubocop","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44"},"html":{"href":"https://github.com/ezcater/ezcater_rubocop/pull/44"},"issue":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/44"},"comments":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/ezcater/ezcater_rubocop/statuses/7776a1cc6947cc4998ab3c3410a1b969477e5f02"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tjwp"}}