{"action":"created","comment":{"url":"https://api.github.com/repos/contao/contao/pulls/comments/223611123","pull_request_review_id":162777550,"id":223611123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzYxMTEyMw==","diff_hunk":"@@ -56,6 +56,12 @@ services:\n         tags:\n             - { name: kernel.event_listener, event: kernel.terminate, method: onKernelTerminate }\n \n+    contao.listener.data_container.layout_assets:\n+        class: Contao\\CoreBundle\\EventListener\\DataContainer\\LayoutAssets\n+        public: true # TODO tag the service as DCA callback","path":"core-bundle/src/Resources/config/listener.yml","position":6,"original_position":6,"commit_id":"1ba5f25f72a0343804fdf5dab1a823227dcb1298","original_commit_id":"1ba5f25f72a0343804fdf5dab1a823227dcb1298","user":{"login":"leofeyer","id":1192057,"node_id":"MDQ6VXNlcjExOTIwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"body":"Feel free to do this now (see https://github.com/contao/contao/pull/39). 😉 ","created_at":"2018-10-09T08:51:37Z","updated_at":"2018-10-09T08:51:37Z","html_url":"https://github.com/contao/contao/pull/104#discussion_r223611123","pull_request_url":"https://api.github.com/repos/contao/contao/pulls/104","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/contao/contao/pulls/comments/223611123"},"html":{"href":"https://github.com/contao/contao/pull/104#discussion_r223611123"},"pull_request":{"href":"https://api.github.com/repos/contao/contao/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/contao/contao/pulls/104","id":218674458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Njc0NDU4","html_url":"https://github.com/contao/contao/pull/104","diff_url":"https://github.com/contao/contao/pull/104.diff","patch_url":"https://github.com/contao/contao/pull/104.patch","issue_url":"https://api.github.com/repos/contao/contao/issues/104","number":104,"state":"open","locked":false,"title":"[RFC] Allow to select assets in the layout","user":{"login":"aschempp","id":1073273,"node_id":"MDQ6VXNlcjEwNzMyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"body":"Since I switched to [Symfony Encore](https://symfony.com/doc/current/frontend.html), I always need to add my CSS and JS files using custom HTML tags in the page layout.\r\n\r\nWith this PR I can select JS and CSS files from my `manifest.json` in the page layout.","created_at":"2018-09-27T14:29:25Z","updated_at":"2018-10-09T08:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b9097801012a4fe932b87a7c5d533da69be42b5","assignee":{"login":"aschempp","id":1073273,"node_id":"MDQ6VXNlcjEwNzMyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"assignees":[{"login":"aschempp","id":1073273,"node_id":"MDQ6VXNlcjEwNzMyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1028270366,"node_id":"MDU6TGFiZWwxMDI4MjcwMzY2","url":"https://api.github.com/repos/contao/contao/labels/feature","name":"feature","color":"3364b7","default":false},{"id":1028270390,"node_id":"MDU6TGFiZWwxMDI4MjcwMzkw","url":"https://api.github.com/repos/contao/contao/labels/up%20for%20discussion","name":"up for discussion","color":"2a982a","default":false}],"milestone":{"url":"https://api.github.com/repos/contao/contao/milestones/2","html_url":"https://github.com/contao/contao/milestone/2","labels_url":"https://api.github.com/repos/contao/contao/milestones/2/labels","id":3583777,"node_id":"MDk6TWlsZXN0b25lMzU4Mzc3Nw==","number":2,"title":"4.7.0","description":"","creator":{"login":"leofeyer","id":1192057,"node_id":"MDQ6VXNlcjExOTIwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":4,"state":"open","created_at":"2018-08-20T14:28:40Z","updated_at":"2018-10-09T08:46:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/contao/contao/pulls/104/commits","review_comments_url":"https://api.github.com/repos/contao/contao/pulls/104/comments","review_comment_url":"https://api.github.com/repos/contao/contao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/contao/issues/104/comments","statuses_url":"https://api.github.com/repos/contao/contao/statuses/1ba5f25f72a0343804fdf5dab1a823227dcb1298","head":{"label":"aschempp:feature/layout-assets","ref":"feature/layout-assets","sha":"1ba5f25f72a0343804fdf5dab1a823227dcb1298","user":{"login":"aschempp","id":1073273,"node_id":"MDQ6VXNlcjEwNzMyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"repo":{"id":146729394,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3MjkzOTQ=","name":"contao","full_name":"aschempp/contao","private":false,"owner":{"login":"aschempp","id":1073273,"node_id":"MDQ6VXNlcjEwNzMyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aschempp/contao","description":"Contao 4 bundles","fork":true,"url":"https://api.github.com/repos/aschempp/contao","forks_url":"https://api.github.com/repos/aschempp/contao/forks","keys_url":"https://api.github.com/repos/aschempp/contao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschempp/contao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschempp/contao/teams","hooks_url":"https://api.github.com/repos/aschempp/contao/hooks","issue_events_url":"https://api.github.com/repos/aschempp/contao/issues/events{/number}","events_url":"https://api.github.com/repos/aschempp/contao/events","assignees_url":"https://api.github.com/repos/aschempp/contao/assignees{/user}","branches_url":"https://api.github.com/repos/aschempp/contao/branches{/branch}","tags_url":"https://api.github.com/repos/aschempp/contao/tags","blobs_url":"https://api.github.com/repos/aschempp/contao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschempp/contao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschempp/contao/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschempp/contao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschempp/contao/statuses/{sha}","languages_url":"https://api.github.com/repos/aschempp/contao/languages","stargazers_url":"https://api.github.com/repos/aschempp/contao/stargazers","contributors_url":"https://api.github.com/repos/aschempp/contao/contributors","subscribers_url":"https://api.github.com/repos/aschempp/contao/subscribers","subscription_url":"https://api.github.com/repos/aschempp/contao/subscription","commits_url":"https://api.github.com/repos/aschempp/contao/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschempp/contao/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschempp/contao/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschempp/contao/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschempp/contao/contents/{+path}","compare_url":"https://api.github.com/repos/aschempp/contao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschempp/contao/merges","archive_url":"https://api.github.com/repos/aschempp/contao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschempp/contao/downloads","issues_url":"https://api.github.com/repos/aschempp/contao/issues{/number}","pulls_url":"https://api.github.com/repos/aschempp/contao/pulls{/number}","milestones_url":"https://api.github.com/repos/aschempp/contao/milestones{/number}","notifications_url":"https://api.github.com/repos/aschempp/contao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschempp/contao/labels{/name}","releases_url":"https://api.github.com/repos/aschempp/contao/releases{/id}","deployments_url":"https://api.github.com/repos/aschempp/contao/deployments","created_at":"2018-08-30T09:48:24Z","updated_at":"2018-09-27T14:39:18Z","pushed_at":"2018-10-09T08:44:44Z","git_url":"git://github.com/aschempp/contao.git","ssh_url":"git@github.com:aschempp/contao.git","clone_url":"https://github.com/aschempp/contao.git","svn_url":"https://github.com/aschempp/contao","homepage":"","size":60505,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contao:master","ref":"master","sha":"96e6fe1513dbd3043f5639e19bd001dd46095630","user":{"login":"contao","id":1206136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDYxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1206136?v=4","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":144819408,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MTk0MDg=","name":"contao","full_name":"contao/contao","private":false,"owner":{"login":"contao","id":1206136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDYxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1206136?v=4","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contao/contao","description":"Contao 4 bundles","fork":false,"url":"https://api.github.com/repos/contao/contao","forks_url":"https://api.github.com/repos/contao/contao/forks","keys_url":"https://api.github.com/repos/contao/contao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/contao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/contao/teams","hooks_url":"https://api.github.com/repos/contao/contao/hooks","issue_events_url":"https://api.github.com/repos/contao/contao/issues/events{/number}","events_url":"https://api.github.com/repos/contao/contao/events","assignees_url":"https://api.github.com/repos/contao/contao/assignees{/user}","branches_url":"https://api.github.com/repos/contao/contao/branches{/branch}","tags_url":"https://api.github.com/repos/contao/contao/tags","blobs_url":"https://api.github.com/repos/contao/contao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/contao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/contao/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/contao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/contao/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/contao/languages","stargazers_url":"https://api.github.com/repos/contao/contao/stargazers","contributors_url":"https://api.github.com/repos/contao/contao/contributors","subscribers_url":"https://api.github.com/repos/contao/contao/subscribers","subscription_url":"https://api.github.com/repos/contao/contao/subscription","commits_url":"https://api.github.com/repos/contao/contao/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/contao/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/contao/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/contao/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/contao/contents/{+path}","compare_url":"https://api.github.com/repos/contao/contao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/contao/merges","archive_url":"https://api.github.com/repos/contao/contao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/contao/downloads","issues_url":"https://api.github.com/repos/contao/contao/issues{/number}","pulls_url":"https://api.github.com/repos/contao/contao/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/contao/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/contao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/contao/labels{/name}","releases_url":"https://api.github.com/repos/contao/contao/releases{/id}","deployments_url":"https://api.github.com/repos/contao/contao/deployments","created_at":"2018-08-15T07:18:30Z","updated_at":"2018-10-09T08:46:11Z","pushed_at":"2018-10-09T08:46:08Z","git_url":"git://github.com/contao/contao.git","ssh_url":"git@github.com:contao/contao.git","clone_url":"https://github.com/contao/contao.git","svn_url":"https://github.com/contao/contao","homepage":"","size":60521,"stargazers_count":21,"watchers_count":21,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":16,"open_issues":34,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/contao/pulls/104"},"html":{"href":"https://github.com/contao/contao/pull/104"},"issue":{"href":"https://api.github.com/repos/contao/contao/issues/104"},"comments":{"href":"https://api.github.com/repos/contao/contao/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/contao/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/contao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/contao/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/contao/contao/statuses/1ba5f25f72a0343804fdf5dab1a823227dcb1298"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leofeyer"}}