{"action":"created","comment":{"url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/comments/244161247","pull_request_review_id":188098778,"id":244161247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDE2MTI0Nw==","diff_hunk":"@@ -0,0 +1,69 @@\n+=== Common Tags\n+\n+inspectIT OCE provides a map of common tag keys and values that are used when recording all metrics.\n+This features enables to \"label\" metrics collected with inspectIT OCE and share common information about a process or an environment where the process runs.\n+The map can be <<User Defined Tags Provider,extended or overwritten by the user>> when this is required.\n+\n+Tags providers are responsible for extracting information from a specific source and provide a map of key value pairs that are then combined into the common tag context.\n+Each provider specifies a priority and if same tag keys are provided by two providers, then the tag value from a provider with higher priority will be used.\n+\n+inspectIT OCE current supports the following tags providers:\n+\n+[cols=\"2,2,1,1,1\",options=\"header\"]\n+|===\n+|Provider |Tags provided |Supports run-time updates |Enabled by default |Priority\n+|<<User Defined Tags>>\n+|-\n+|Yes\n+|No\n+|HIGH\n+|<<Environment Tags>>\n+|`service-name`, `host`, `host-address`\n+|Yes\n+|Yes\n+|LOW\n+|===\n+\n+WARNING: Run-time updates currently only support changing of a tag value, but not adding or removing tags.\n+\n+==== User Defined Tags\n+\n+User defined tags can be added to the common tag context by defining the `inspectit.tags.extra` property.\n+\n+.Setting the user defined tags using properties\n+[source,properties]\n+----\n+inspectit.tags.extra.region=us-west-1\n+inspectit.tags.extra.stage=preprod\n+----\n+\n+.Setting the user defined tags using YAML file\n+[source,YAML]\n+----\n+inspectit:\n+  tags:\n+    extra:\n+      region: us-west-1\n+      stage: preprod\n+----\n+\n+==== Environment Tags\n+The environment tags provider extends the common tag context by supplying information about the service name and a host.\n+The service name is resolved from the `inspectit.service-name` property, while host information is extracted using `InetAddress.getLocalHost()`.","path":"inspectit-oce-documentation/src/docs/asciidoc/_includes/monitoring-environment/common-tags.adoc","position":52,"original_position":52,"commit_id":"9abe0af4f1ef330d9ef3cdf909dc07833d100580","original_commit_id":"9abe0af4f1ef330d9ef3cdf909dc07833d100580","user":{"login":"JonasKunz","id":6066661,"node_id":"MDQ6VXNlcjYwNjY2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6066661?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasKunz","html_url":"https://github.com/JonasKunz","followers_url":"https://api.github.com/users/JonasKunz/followers","following_url":"https://api.github.com/users/JonasKunz/following{/other_user}","gists_url":"https://api.github.com/users/JonasKunz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasKunz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasKunz/subscriptions","organizations_url":"https://api.github.com/users/JonasKunz/orgs","repos_url":"https://api.github.com/users/JonasKunz/repos","events_url":"https://api.github.com/users/JonasKunz/events{/privacy}","received_events_url":"https://api.github.com/users/JonasKunz/received_events","type":"User","site_admin":false},"body":", while **the** host information","created_at":"2018-12-27T14:19:08Z","updated_at":"2018-12-27T14:19:57Z","html_url":"https://github.com/inspectIT/inspectit-oce/pull/29#discussion_r244161247","pull_request_url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/comments/244161247"},"html":{"href":"https://github.com/inspectIT/inspectit-oce/pull/29#discussion_r244161247"},"pull_request":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29","id":240975821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTc1ODIx","html_url":"https://github.com/inspectIT/inspectit-oce/pull/29","diff_url":"https://github.com/inspectIT/inspectit-oce/pull/29.diff","patch_url":"https://github.com/inspectIT/inspectit-oce/pull/29.patch","issue_url":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/29","number":29,"state":"open","locked":false,"title":"closes #8: support for common tags and tag providers","user":{"login":"ivansenic","id":10600041,"node_id":"MDQ6VXNlcjEwNjAwMDQx","avatar_url":"https://avatars2.githubusercontent.com/u/10600041?v=4","gravatar_id":"","url":"https://api.github.com/users/ivansenic","html_url":"https://github.com/ivansenic","followers_url":"https://api.github.com/users/ivansenic/followers","following_url":"https://api.github.com/users/ivansenic/following{/other_user}","gists_url":"https://api.github.com/users/ivansenic/gists{/gist_id}","starred_url":"https://api.github.com/users/ivansenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivansenic/subscriptions","organizations_url":"https://api.github.com/users/ivansenic/orgs","repos_url":"https://api.github.com/users/ivansenic/repos","events_url":"https://api.github.com/users/ivansenic/events{/privacy}","received_events_url":"https://api.github.com/users/ivansenic/received_events","type":"User","site_admin":false},"body":"Example usages:\r\n* creating view\r\n ```\r\n        View.create(View.Name.create(\"some/name\"), \"some desc\", someMeasure, someAggregation, tagsProvider.getCommonTagKeys())\r\n ```\r\n* recording metrics view\r\n ```\r\n        try (Scope scope = tagsProvider.withCommonTagScope()) {\r\n            Stats.getStatsRecorder().newMeasureMap().put(someMeasure, 1L).record();\r\n        }\r\n ```\r\n\r\n@JonasKunz let's disucss how should we document this\r\n\r\n**Main challendge: How can common tags be included in metrics collected by the user using instrumentation lib?**\r\nAs OpenCensus does not provide any mechanism to set common tags, we would need to allow user to access them.. Maybe we can provide some bootstrap interface for this, that user could use to get it, but this way the bootstrap must be a compile depdency for  users as well. We would need to provide NoOp impl as well. I had idea to instrument all threads and add  `try (Scope scope = tagsProvider.withCommonTagScope())` as the first statemetnt on the `run()`, but this would work only for recording, not for view registration.","created_at":"2018-12-26T12:49:26Z","updated_at":"2018-12-27T14:19:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa95b3b894c952b565cdce326352e5b4ce9fbc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29/commits","review_comments_url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29/comments","review_comment_url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/29/comments","statuses_url":"https://api.github.com/repos/inspectIT/inspectit-oce/statuses/9abe0af4f1ef330d9ef3cdf909dc07833d100580","head":{"label":"ivansenic:ise-8-tags","ref":"ise-8-tags","sha":"9abe0af4f1ef330d9ef3cdf909dc07833d100580","user":{"login":"ivansenic","id":10600041,"node_id":"MDQ6VXNlcjEwNjAwMDQx","avatar_url":"https://avatars2.githubusercontent.com/u/10600041?v=4","gravatar_id":"","url":"https://api.github.com/users/ivansenic","html_url":"https://github.com/ivansenic","followers_url":"https://api.github.com/users/ivansenic/followers","following_url":"https://api.github.com/users/ivansenic/following{/other_user}","gists_url":"https://api.github.com/users/ivansenic/gists{/gist_id}","starred_url":"https://api.github.com/users/ivansenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivansenic/subscriptions","organizations_url":"https://api.github.com/users/ivansenic/orgs","repos_url":"https://api.github.com/users/ivansenic/repos","events_url":"https://api.github.com/users/ivansenic/events{/privacy}","received_events_url":"https://api.github.com/users/ivansenic/received_events","type":"User","site_admin":false},"repo":{"id":160363780,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzNjM3ODA=","name":"inspectit-oce","full_name":"ivansenic/inspectit-oce","private":false,"owner":{"login":"ivansenic","id":10600041,"node_id":"MDQ6VXNlcjEwNjAwMDQx","avatar_url":"https://avatars2.githubusercontent.com/u/10600041?v=4","gravatar_id":"","url":"https://api.github.com/users/ivansenic","html_url":"https://github.com/ivansenic","followers_url":"https://api.github.com/users/ivansenic/followers","following_url":"https://api.github.com/users/ivansenic/following{/other_user}","gists_url":"https://api.github.com/users/ivansenic/gists{/gist_id}","starred_url":"https://api.github.com/users/ivansenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivansenic/subscriptions","organizations_url":"https://api.github.com/users/ivansenic/orgs","repos_url":"https://api.github.com/users/ivansenic/repos","events_url":"https://api.github.com/users/ivansenic/events{/privacy}","received_events_url":"https://api.github.com/users/ivansenic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivansenic/inspectit-oce","description":"inspectIT Open Census Edition","fork":true,"url":"https://api.github.com/repos/ivansenic/inspectit-oce","forks_url":"https://api.github.com/repos/ivansenic/inspectit-oce/forks","keys_url":"https://api.github.com/repos/ivansenic/inspectit-oce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivansenic/inspectit-oce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivansenic/inspectit-oce/teams","hooks_url":"https://api.github.com/repos/ivansenic/inspectit-oce/hooks","issue_events_url":"https://api.github.com/repos/ivansenic/inspectit-oce/issues/events{/number}","events_url":"https://api.github.com/repos/ivansenic/inspectit-oce/events","assignees_url":"https://api.github.com/repos/ivansenic/inspectit-oce/assignees{/user}","branches_url":"https://api.github.com/repos/ivansenic/inspectit-oce/branches{/branch}","tags_url":"https://api.github.com/repos/ivansenic/inspectit-oce/tags","blobs_url":"https://api.github.com/repos/ivansenic/inspectit-oce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivansenic/inspectit-oce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivansenic/inspectit-oce/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivansenic/inspectit-oce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivansenic/inspectit-oce/statuses/{sha}","languages_url":"https://api.github.com/repos/ivansenic/inspectit-oce/languages","stargazers_url":"https://api.github.com/repos/ivansenic/inspectit-oce/stargazers","contributors_url":"https://api.github.com/repos/ivansenic/inspectit-oce/contributors","subscribers_url":"https://api.github.com/repos/ivansenic/inspectit-oce/subscribers","subscription_url":"https://api.github.com/repos/ivansenic/inspectit-oce/subscription","commits_url":"https://api.github.com/repos/ivansenic/inspectit-oce/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivansenic/inspectit-oce/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivansenic/inspectit-oce/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivansenic/inspectit-oce/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivansenic/inspectit-oce/contents/{+path}","compare_url":"https://api.github.com/repos/ivansenic/inspectit-oce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivansenic/inspectit-oce/merges","archive_url":"https://api.github.com/repos/ivansenic/inspectit-oce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivansenic/inspectit-oce/downloads","issues_url":"https://api.github.com/repos/ivansenic/inspectit-oce/issues{/number}","pulls_url":"https://api.github.com/repos/ivansenic/inspectit-oce/pulls{/number}","milestones_url":"https://api.github.com/repos/ivansenic/inspectit-oce/milestones{/number}","notifications_url":"https://api.github.com/repos/ivansenic/inspectit-oce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivansenic/inspectit-oce/labels{/name}","releases_url":"https://api.github.com/repos/ivansenic/inspectit-oce/releases{/id}","deployments_url":"https://api.github.com/repos/ivansenic/inspectit-oce/deployments","created_at":"2018-12-04T13:43:05Z","updated_at":"2018-12-21T14:59:27Z","pushed_at":"2018-12-27T14:04:41Z","git_url":"git://github.com/ivansenic/inspectit-oce.git","ssh_url":"git@github.com:ivansenic/inspectit-oce.git","clone_url":"https://github.com/ivansenic/inspectit-oce.git","svn_url":"https://github.com/ivansenic/inspectit-oce","homepage":null,"size":176,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspectIT:master","ref":"master","sha":"c6557fcb3d91f2a7470e49b4c4740272e06bce2b","user":{"login":"inspectIT","id":10599821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTk5ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/10599821?v=4","gravatar_id":"","url":"https://api.github.com/users/inspectIT","html_url":"https://github.com/inspectIT","followers_url":"https://api.github.com/users/inspectIT/followers","following_url":"https://api.github.com/users/inspectIT/following{/other_user}","gists_url":"https://api.github.com/users/inspectIT/gists{/gist_id}","starred_url":"https://api.github.com/users/inspectIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspectIT/subscriptions","organizations_url":"https://api.github.com/users/inspectIT/orgs","repos_url":"https://api.github.com/users/inspectIT/repos","events_url":"https://api.github.com/users/inspectIT/events{/privacy}","received_events_url":"https://api.github.com/users/inspectIT/received_events","type":"Organization","site_admin":false},"repo":{"id":160148747,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAxNDg3NDc=","name":"inspectit-oce","full_name":"inspectIT/inspectit-oce","private":false,"owner":{"login":"inspectIT","id":10599821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTk5ODIx","avatar_url":"https://avatars3.githubusercontent.com/u/10599821?v=4","gravatar_id":"","url":"https://api.github.com/users/inspectIT","html_url":"https://github.com/inspectIT","followers_url":"https://api.github.com/users/inspectIT/followers","following_url":"https://api.github.com/users/inspectIT/following{/other_user}","gists_url":"https://api.github.com/users/inspectIT/gists{/gist_id}","starred_url":"https://api.github.com/users/inspectIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspectIT/subscriptions","organizations_url":"https://api.github.com/users/inspectIT/orgs","repos_url":"https://api.github.com/users/inspectIT/repos","events_url":"https://api.github.com/users/inspectIT/events{/privacy}","received_events_url":"https://api.github.com/users/inspectIT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inspectIT/inspectit-oce","description":"inspectIT Open Census Edition","fork":false,"url":"https://api.github.com/repos/inspectIT/inspectit-oce","forks_url":"https://api.github.com/repos/inspectIT/inspectit-oce/forks","keys_url":"https://api.github.com/repos/inspectIT/inspectit-oce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspectIT/inspectit-oce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspectIT/inspectit-oce/teams","hooks_url":"https://api.github.com/repos/inspectIT/inspectit-oce/hooks","issue_events_url":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/events{/number}","events_url":"https://api.github.com/repos/inspectIT/inspectit-oce/events","assignees_url":"https://api.github.com/repos/inspectIT/inspectit-oce/assignees{/user}","branches_url":"https://api.github.com/repos/inspectIT/inspectit-oce/branches{/branch}","tags_url":"https://api.github.com/repos/inspectIT/inspectit-oce/tags","blobs_url":"https://api.github.com/repos/inspectIT/inspectit-oce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspectIT/inspectit-oce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspectIT/inspectit-oce/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspectIT/inspectit-oce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspectIT/inspectit-oce/statuses/{sha}","languages_url":"https://api.github.com/repos/inspectIT/inspectit-oce/languages","stargazers_url":"https://api.github.com/repos/inspectIT/inspectit-oce/stargazers","contributors_url":"https://api.github.com/repos/inspectIT/inspectit-oce/contributors","subscribers_url":"https://api.github.com/repos/inspectIT/inspectit-oce/subscribers","subscription_url":"https://api.github.com/repos/inspectIT/inspectit-oce/subscription","commits_url":"https://api.github.com/repos/inspectIT/inspectit-oce/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspectIT/inspectit-oce/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspectIT/inspectit-oce/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspectIT/inspectit-oce/contents/{+path}","compare_url":"https://api.github.com/repos/inspectIT/inspectit-oce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspectIT/inspectit-oce/merges","archive_url":"https://api.github.com/repos/inspectIT/inspectit-oce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspectIT/inspectit-oce/downloads","issues_url":"https://api.github.com/repos/inspectIT/inspectit-oce/issues{/number}","pulls_url":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls{/number}","milestones_url":"https://api.github.com/repos/inspectIT/inspectit-oce/milestones{/number}","notifications_url":"https://api.github.com/repos/inspectIT/inspectit-oce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspectIT/inspectit-oce/labels{/name}","releases_url":"https://api.github.com/repos/inspectIT/inspectit-oce/releases{/id}","deployments_url":"https://api.github.com/repos/inspectIT/inspectit-oce/deployments","created_at":"2018-12-03T07:19:51Z","updated_at":"2018-12-27T11:14:09Z","pushed_at":"2018-12-27T14:04:42Z","git_url":"git://github.com/inspectIT/inspectit-oce.git","ssh_url":"git@github.com:inspectIT/inspectit-oce.git","clone_url":"https://github.com/inspectIT/inspectit-oce.git","svn_url":"https://github.com/inspectIT/inspectit-oce","homepage":null,"size":168,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29"},"html":{"href":"https://github.com/inspectIT/inspectit-oce/pull/29"},"issue":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/29"},"comments":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/inspectIT/inspectit-oce/statuses/9abe0af4f1ef330d9ef3cdf909dc07833d100580"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JonasKunz"}}