{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubectl/pulls/comments/167733211","pull_request_review_id":95995588,"id":167733211,"diff_hunk":"@@ -43,39 +43,32 @@ func NewOverlayTransformer(overlay types.KObject) (Transformer, error) {\n // Transform apply the overlay on top of the base resources.\n func (o *OverlayTransformer) Transform(baseResourceMap types.KObject) error {\n \t// Strategic merge the resources exist in both base and overlay.\n-\tfor gvkn, base := range baseResourceMap {\n+\tfor gvkn, overlay := range o.overlay {","path":"pkg/kinflate/transformers/overlay.go","position":5,"original_position":5,"commit_id":"316d259564c1d2888640079e1779e7a54709179a","original_commit_id":"316d259564c1d2888640079e1779e7a54709179a","user":{"login":"droot","id":172029,"avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"body":"+1 it should speed things up :)","created_at":"2018-02-13T00:51:47Z","updated_at":"2018-02-13T01:03:45Z","html_url":"https://github.com/kubernetes/kubectl/pull/279#discussion_r167733211","pull_request_url":"https://api.github.com/repos/kubernetes/kubectl/pulls/279","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/comments/167733211"},"html":{"href":"https://github.com/kubernetes/kubectl/pull/279#discussion_r167733211"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubectl/pulls/279","id":168722130,"html_url":"https://github.com/kubernetes/kubectl/pull/279","diff_url":"https://github.com/kubernetes/kubectl/pull/279.diff","patch_url":"https://github.com/kubernetes/kubectl/pull/279.patch","issue_url":"https://api.github.com/repos/kubernetes/kubectl/issues/279","number":279,"state":"open","locked":false,"title":"error out when a patch has not matching object","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"body":"Address some comments from https://github.com/kubernetes/kubectl/pull/274:\r\n- error out when a patch has not matching object\r\n- it stop deleting the object from the overlay KObject.","created_at":"2018-02-13T00:08:43Z","updated_at":"2018-02-13T01:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27004ec12a02cbc2c8593008765f09b02aea3ea5","assignee":{"login":"droot","id":172029,"avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"assignees":[{"login":"droot","id":172029,"avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":573132968,"url":"https://api.github.com/repos/kubernetes/kubectl/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":631708869,"url":"https://api.github.com/repos/kubernetes/kubectl/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubectl/pulls/279/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubectl/pulls/279/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubectl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubectl/issues/279/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubectl/statuses/316d259564c1d2888640079e1779e7a54709179a","head":{"label":"mengqiy:overlay_transformer","ref":"overlay_transformer","sha":"316d259564c1d2888640079e1779e7a54709179a","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"repo":{"id":105154535,"name":"kubectl","full_name":"mengqiy/kubectl","owner":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mengqiy/kubectl","description":"Issue tracker and mirror of kubectl code","fork":true,"url":"https://api.github.com/repos/mengqiy/kubectl","forks_url":"https://api.github.com/repos/mengqiy/kubectl/forks","keys_url":"https://api.github.com/repos/mengqiy/kubectl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mengqiy/kubectl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mengqiy/kubectl/teams","hooks_url":"https://api.github.com/repos/mengqiy/kubectl/hooks","issue_events_url":"https://api.github.com/repos/mengqiy/kubectl/issues/events{/number}","events_url":"https://api.github.com/repos/mengqiy/kubectl/events","assignees_url":"https://api.github.com/repos/mengqiy/kubectl/assignees{/user}","branches_url":"https://api.github.com/repos/mengqiy/kubectl/branches{/branch}","tags_url":"https://api.github.com/repos/mengqiy/kubectl/tags","blobs_url":"https://api.github.com/repos/mengqiy/kubectl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mengqiy/kubectl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mengqiy/kubectl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mengqiy/kubectl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mengqiy/kubectl/statuses/{sha}","languages_url":"https://api.github.com/repos/mengqiy/kubectl/languages","stargazers_url":"https://api.github.com/repos/mengqiy/kubectl/stargazers","contributors_url":"https://api.github.com/repos/mengqiy/kubectl/contributors","subscribers_url":"https://api.github.com/repos/mengqiy/kubectl/subscribers","subscription_url":"https://api.github.com/repos/mengqiy/kubectl/subscription","commits_url":"https://api.github.com/repos/mengqiy/kubectl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mengqiy/kubectl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mengqiy/kubectl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mengqiy/kubectl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mengqiy/kubectl/contents/{+path}","compare_url":"https://api.github.com/repos/mengqiy/kubectl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mengqiy/kubectl/merges","archive_url":"https://api.github.com/repos/mengqiy/kubectl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mengqiy/kubectl/downloads","issues_url":"https://api.github.com/repos/mengqiy/kubectl/issues{/number}","pulls_url":"https://api.github.com/repos/mengqiy/kubectl/pulls{/number}","milestones_url":"https://api.github.com/repos/mengqiy/kubectl/milestones{/number}","notifications_url":"https://api.github.com/repos/mengqiy/kubectl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mengqiy/kubectl/labels{/name}","releases_url":"https://api.github.com/repos/mengqiy/kubectl/releases{/id}","deployments_url":"https://api.github.com/repos/mengqiy/kubectl/deployments","created_at":"2017-09-28T13:51:54Z","updated_at":"2017-11-17T18:54:13Z","pushed_at":"2018-02-13T00:59:46Z","git_url":"git://github.com/mengqiy/kubectl.git","ssh_url":"git@github.com:mengqiy/kubectl.git","clone_url":"https://github.com/mengqiy/kubectl.git","svn_url":"https://github.com/mengqiy/kubectl","homepage":null,"size":25514,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f6db52a33723bb132022e69c1aa429df8b7cf608","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":86742497,"name":"kubectl","full_name":"kubernetes/kubectl","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubectl","description":"Issue tracker and mirror of kubectl code","fork":false,"url":"https://api.github.com/repos/kubernetes/kubectl","forks_url":"https://api.github.com/repos/kubernetes/kubectl/forks","keys_url":"https://api.github.com/repos/kubernetes/kubectl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubectl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubectl/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubectl/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubectl/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubectl/events","assignees_url":"https://api.github.com/repos/kubernetes/kubectl/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubectl/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubectl/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubectl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubectl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubectl/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubectl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubectl/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubectl/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubectl/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubectl/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubectl/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubectl/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubectl/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubectl/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubectl/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubectl/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubectl/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubectl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubectl/merges","archive_url":"https://api.github.com/repos/kubernetes/kubectl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubectl/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubectl/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubectl/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubectl/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubectl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubectl/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubectl/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubectl/deployments","created_at":"2017-03-30T19:50:22Z","updated_at":"2018-02-12T19:45:21Z","pushed_at":"2018-02-13T01:00:10Z","git_url":"git://github.com/kubernetes/kubectl.git","ssh_url":"git@github.com:kubernetes/kubectl.git","clone_url":"https://github.com/kubernetes/kubectl.git","svn_url":"https://github.com/kubernetes/kubectl","homepage":null,"size":25060,"stargazers_count":85,"watchers_count":85,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":60,"open_issues":92,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/279"},"html":{"href":"https://github.com/kubernetes/kubectl/pull/279"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubectl/issues/279"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubectl/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubectl/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubectl/statuses/316d259564c1d2888640079e1779e7a54709179a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"droot"}}