{"action":"created","issue":{"url":"https://api.github.com/repos/mono/mono/issues/8815","repository_url":"https://api.github.com/repos/mono/mono","labels_url":"https://api.github.com/repos/mono/mono/issues/8815/labels{/name}","comments_url":"https://api.github.com/repos/mono/mono/issues/8815/comments","events_url":"https://api.github.com/repos/mono/mono/issues/8815/events","html_url":"https://github.com/mono/mono/issues/8815","id":325244057,"number":8815,"title":"System.Native does not build on Master with compiler without static_assert and _Static_assert","user":{"login":"rjvdboon","id":1241158,"avatar_url":"https://avatars2.githubusercontent.com/u/1241158?v=4","gravatar_id":"","url":"https://api.github.com/users/rjvdboon","html_url":"https://github.com/rjvdboon","followers_url":"https://api.github.com/users/rjvdboon/followers","following_url":"https://api.github.com/users/rjvdboon/following{/other_user}","gists_url":"https://api.github.com/users/rjvdboon/gists{/gist_id}","starred_url":"https://api.github.com/users/rjvdboon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjvdboon/subscriptions","organizations_url":"https://api.github.com/users/rjvdboon/orgs","repos_url":"https://api.github.com/users/rjvdboon/repos","events_url":"https://api.github.com/users/rjvdboon/events{/privacy}","received_events_url":"https://api.github.com/users/rjvdboon/received_events","type":"User","site_admin":false},"labels":[{"id":837240304,"url":"https://api.github.com/repos/mono/mono/labels/area-Build","name":"area-Build","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false},"assignees":[{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-05-22T11:03:00Z","updated_at":"2018-05-28T09:06:40Z","closed_at":"2018-05-25T15:40:35Z","author_association":"CONTRIBUTOR","body":"## Steps to Reproduce\r\n\r\n1. Clone Master on a system with an old GCC (Centos6 with gcc 4.4.7 will do)\r\n2. ./autoconf\r\n3. make\r\n\r\n<!--\r\nYou may drag & drop the attachment (repro code/solution, screenshot, etc.) onto the issue.\r\n-->\r\n\r\n### Current Behavior\r\n\r\nmake fails with:\r\n```\r\n../../doltlibtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../../mono -I../../libgc/include -I../../mono/eglib -I../../mono/eglib -fvisibility=hidden -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes  -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-cast-qual -Wwrite-strings -Wno-switch -Wno-switch-enum -Wno-unused-value -Wno-attributes -Wno-format-zero-length  -DGC_LINUX_THREADS -D_GNU_SOURCE -D_REENTRANT -DUSE_MMAP -DUSE_MUNMAP -g -DLARGE_CONFIG  -DUSE_COMPILER_TLS -I/glb/home/nlrvmp/scratch/mono/mono-git/external/corefx/src/Native/Unix/Common -I/glb/home/nlrvmp/scratch/mono/mono-git/external/corefx/src/Native/Unix/System.Native -Wno-typedef-redefinition -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes  -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-cast-qual -Wwrite-strings -Wno-switch -Wno-switch-enum -Wno-unused-value -Wno-attributes -Wno-format-zero-length -g -O2 -std=gnu99 -fno-strict-aliasing -fwrapv -DMONO_DLL_EXPORT -Wno-unused-but-set-variable -g -mno-tls-direct-seg-refs -Werror-implicit-function-declaration -MT ../../external/corefx/src/Native/Unix/System.Native/libmono_system_native_la-pal_io.lo -MD -MP -MF ../../external/corefx/src/Native/Unix/System.Native/.deps/libmono_system_native_la-pal_io.Tpo -c -o ../../external/corefx/src/Native/Unix/System.Native/libmono_system_native_la-pal_io.lo `test -f '../../external/corefx/src/Native/Unix/System.Native/pal_io.c' || echo './'`../../external/corefx/src/Native/Unix/System.Native/pal_io.c\r\n../../external/corefx/src/Native/Unix/System.Native/pal_io.c:53: error: redefinition of typedef ‘__c_static_assert__’\r\n../../external/corefx/src/Native/Unix/System.Native/pal_io.c:52: note: previous declaration of ‘__c_static_assert__’ was here\r\n[snipped lots of similar errors....]\r\n../../external/corefx/src/Native/Unix/System.Native/pal_io.c:142: error: redefinition of typedef ‘__c_static_assert__’\r\n../../external/corefx/src/Native/Unix/System.Native/pal_io.c:138: note: previous declaration of ‘__c_static_assert__’ was here\r\ncc1: warning: unrecognized command line option \"-Wno-typedef-redefinition\"\r\nmake[3]: *** [../../external/corefx/src/Native/Unix/System.Native/libmono_system_native_la-pal_io.lo] Error 1\r\n```\r\n<!--\r\nWhat is the current behavior?\r\n-->\r\n\r\n### Expected Behavior\r\n\r\nBuild succeeds _or_ configure errors on a too old GCC.\r\n<!--\r\nPlease describe the behavior you are expecting\r\n-->\r\n\r\n## On which platforms did you notice this\r\n\r\n[ ] macOS\r\n[ x ] Linux\r\n[ ] Windows\r\n\r\n**Version Used**:\r\n\r\n```\r\n$ gcc --version|head -1\r\ngcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-17)\r\n$ cat /etc/redhat-release\r\nRed Hat Enterprise Linux Server release 6.8 (Santiago)\r\n```\r\n\r\n## Additional info\r\n\r\nIt is probably caused by line 25 in [pal_compiler.h](https://github.com/dotnet/corefx/blob/a5eb6c3a3a6678906a15e70701ce1ffaa2846fea/src/Native/Unix/Common/pal_compiler.h#L25) combined with the `-Wno-typedef-redefinition` compiler flag.\r\n\r\nInstead of fixing the code or makefiles to compile, it might make more sense to drop support for old compilers.\r\n\r\n<!--\r\n\r\nYou can join us at https://gitter.im/mono/mono to discuss your reported issue\r\n\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/mono/mono/issues/comments/392467826","html_url":"https://github.com/mono/mono/issues/8815#issuecomment-392467826","issue_url":"https://api.github.com/repos/mono/mono/issues/8815","id":392467826,"user":{"login":"rjvdboon","id":1241158,"avatar_url":"https://avatars2.githubusercontent.com/u/1241158?v=4","gravatar_id":"","url":"https://api.github.com/users/rjvdboon","html_url":"https://github.com/rjvdboon","followers_url":"https://api.github.com/users/rjvdboon/followers","following_url":"https://api.github.com/users/rjvdboon/following{/other_user}","gists_url":"https://api.github.com/users/rjvdboon/gists{/gist_id}","starred_url":"https://api.github.com/users/rjvdboon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjvdboon/subscriptions","organizations_url":"https://api.github.com/users/rjvdboon/orgs","repos_url":"https://api.github.com/users/rjvdboon/repos","events_url":"https://api.github.com/users/rjvdboon/events{/privacy}","received_events_url":"https://api.github.com/users/rjvdboon/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T09:06:40Z","updated_at":"2018-05-28T09:06:40Z","author_association":"CONTRIBUTOR","body":"Works like a charm, mono/master@a1bb39504fa builds correctly. Thanks!"}}
{"actor":{"display_login":"rjvdboon"}}