{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28090","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28090/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28090/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28090/events","html_url":"https://github.com/Automattic/wp-calypso/pull/28090","id":373917439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzM1Mzg0","number":28090,"title":"Gutenberg: Fixes for the Text Settings styles","user":{"login":"mmtr","id":1233880,"node_id":"MDQ6VXNlcjEyMzM4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1233880?v=4","gravatar_id":"","url":"https://api.github.com/users/mmtr","html_url":"https://github.com/mmtr","followers_url":"https://api.github.com/users/mmtr/followers","following_url":"https://api.github.com/users/mmtr/following{/other_user}","gists_url":"https://api.github.com/users/mmtr/gists{/gist_id}","starred_url":"https://api.github.com/users/mmtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmtr/subscriptions","organizations_url":"https://api.github.com/users/mmtr/orgs","repos_url":"https://api.github.com/users/mmtr/repos","events_url":"https://api.github.com/users/mmtr/events{/privacy}","received_events_url":"https://api.github.com/users/mmtr/received_events","type":"User","site_admin":false},"labels":[{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":285010030,"node_id":"MDU6TGFiZWwyODUwMTAwMzA=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Ready%20to%20Merge","name":"[Status] Ready to Merge","color":"d4fb79","default":false},{"id":285009975,"node_id":"MDU6TGFiZWwyODUwMDk5NzU=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Bug","name":"[Type] Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"mmtr","id":1233880,"node_id":"MDQ6VXNlcjEyMzM4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1233880?v=4","gravatar_id":"","url":"https://api.github.com/users/mmtr","html_url":"https://github.com/mmtr","followers_url":"https://api.github.com/users/mmtr/followers","following_url":"https://api.github.com/users/mmtr/following{/other_user}","gists_url":"https://api.github.com/users/mmtr/gists{/gist_id}","starred_url":"https://api.github.com/users/mmtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmtr/subscriptions","organizations_url":"https://api.github.com/users/mmtr/orgs","repos_url":"https://api.github.com/users/mmtr/repos","events_url":"https://api.github.com/users/mmtr/events{/privacy}","received_events_url":"https://api.github.com/users/mmtr/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmtr","id":1233880,"node_id":"MDQ6VXNlcjEyMzM4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1233880?v=4","gravatar_id":"","url":"https://api.github.com/users/mmtr","html_url":"https://github.com/mmtr","followers_url":"https://api.github.com/users/mmtr/followers","following_url":"https://api.github.com/users/mmtr/following{/other_user}","gists_url":"https://api.github.com/users/mmtr/gists{/gist_id}","starred_url":"https://api.github.com/users/mmtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmtr/subscriptions","organizations_url":"https://api.github.com/users/mmtr/orgs","repos_url":"https://api.github.com/users/mmtr/repos","events_url":"https://api.github.com/users/mmtr/events{/privacy}","received_events_url":"https://api.github.com/users/mmtr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-25T12:15:19Z","updated_at":"2018-10-25T14:34:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28090","html_url":"https://github.com/Automattic/wp-calypso/pull/28090","diff_url":"https://github.com/Automattic/wp-calypso/pull/28090.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/28090.patch"},"body":"#### Changes proposed in this Pull Request\r\n\r\nFixes #28087.\r\n\r\nThe Text Settings box in the Calypso Gutenberg editor has some styling issues caused by:\r\n* Styles in the `edit-post` folder are not updated with latest changes added in Core.\r\n* Calypso default styles for the form elements.\r\n\r\nThis PR updates the `edit-post/components/sidebar/block-sidebar` styles with the most recent version from Core and adds the needed CSS rules for unsetting the Calypso defaults styles that breaks the styles.\r\n\r\n*Note*: This fix depends on #28000, so don't merge this before #28000 is merged.\r\n\r\n#### Testing instructions\r\n\r\n* While changes applied in #28000 are not published, we need to manually build the Gutenberg packages and copy/paste the build in the `node_modules` folder before building Calypso:\r\n  - In Gutenberg, run `npm run build:packages`\r\n  - Copy `<GUTENBERG_DIR>/components/build-style/build-styles.css` to `<CALYPSO_DIR>/node_modules/@wordpress/components/build-style/build-styles.css`\r\n  - Copy `<GUTENBERG_DIR>/components/build-module/toggle-control/index.js` to `<CALYPSO_DIR>/node_modules/@wordpress/components/build-module/toggle-control/index.js`\r\n* Start Calypso with `npm run start` and start creating a new post using Gutenberg\r\n* Add a paragraph block\r\n* Check on the sidebar that the Text Settings looks like the After screenshot below.\r\n\r\n#### Screenshots\r\nBefore\r\n<img width=\"276\" alt=\"screen shot 2018-10-25 at 13 00 04\" src=\"https://user-images.githubusercontent.com/1233880/47496004-f5a74500-d855-11e8-963a-06295615aafb.png\">\r\n\r\nAfter\r\n<img width=\"276\" alt=\"screen shot 2018-10-25 at 14 01 24\" src=\"https://user-images.githubusercontent.com/1233880/47499300-eb8a4400-d85f-11e8-90ab-425d516d863e.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/433075468","html_url":"https://github.com/Automattic/wp-calypso/pull/28090#issuecomment-433075468","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28090","id":433075468,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzA3NTQ2OA==","user":{"login":"mmtr","id":1233880,"node_id":"MDQ6VXNlcjEyMzM4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1233880?v=4","gravatar_id":"","url":"https://api.github.com/users/mmtr","html_url":"https://github.com/mmtr","followers_url":"https://api.github.com/users/mmtr/followers","following_url":"https://api.github.com/users/mmtr/following{/other_user}","gists_url":"https://api.github.com/users/mmtr/gists{/gist_id}","starred_url":"https://api.github.com/users/mmtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmtr/subscriptions","organizations_url":"https://api.github.com/users/mmtr/orgs","repos_url":"https://api.github.com/users/mmtr/repos","events_url":"https://api.github.com/users/mmtr/events{/privacy}","received_events_url":"https://api.github.com/users/mmtr/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T14:34:15Z","updated_at":"2018-10-25T14:34:15Z","author_association":"MEMBER","body":"> Tested this in calypso.live and it looks like the results seem to match the ones from After section.\r\nIn any case it looks a lot better than what we currently have and probably doesn't depend on #28000.\r\n\r\nThe latest version of `@wordpress/components` places the toggle on the left, so that's why I suggested to wait for #28000. But yeah, we can ship this before and once #28000 is landed, the toggle will be placed correctly."}}
{"actor":{"display_login":"mmtr"}}