{"action":"created","comment":{"url":"https://api.github.com/repos/pywr/pywr/pulls/comments/174947931","pull_request_review_id":104398591,"id":174947931,"diff_hunk":"@@ -802,6 +847,8 @@ cdef class AnnualHarmonicSeriesParameter(Parameter):\n         self._phase_lower_bounds = np.ones(n)*kwargs.pop('phase_lower_bounds', 0.0)\n         self._phase_upper_bounds = np.ones(n)*kwargs.pop('phase_upper_bounds', np.pi*2)\n         super(AnnualHarmonicSeriesParameter, self).__init__(model, *args, **kwargs)\n+        # Size must be set after call to super.\n+        self.size = 1 + 2*n","path":"pywr/parameters/_parameters.pyx","position":179,"original_position":179,"commit_id":"83655729a8df8cfab7c495db6ba7a4abb8c42745","original_commit_id":"83655729a8df8cfab7c495db6ba7a4abb8c42745","user":{"login":"snorfalorpagus","id":3883947,"avatar_url":"https://avatars0.githubusercontent.com/u/3883947?v=4","gravatar_id":"","url":"https://api.github.com/users/snorfalorpagus","html_url":"https://github.com/snorfalorpagus","followers_url":"https://api.github.com/users/snorfalorpagus/followers","following_url":"https://api.github.com/users/snorfalorpagus/following{/other_user}","gists_url":"https://api.github.com/users/snorfalorpagus/gists{/gist_id}","starred_url":"https://api.github.com/users/snorfalorpagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snorfalorpagus/subscriptions","organizations_url":"https://api.github.com/users/snorfalorpagus/orgs","repos_url":"https://api.github.com/users/snorfalorpagus/repos","events_url":"https://api.github.com/users/snorfalorpagus/events{/privacy}","received_events_url":"https://api.github.com/users/snorfalorpagus/received_events","type":"User","site_admin":false},"body":"Should this be using self.double_size?","created_at":"2018-03-15T22:09:22Z","updated_at":"2018-03-15T22:09:23Z","html_url":"https://github.com/pywr/pywr/pull/601#discussion_r174947931","pull_request_url":"https://api.github.com/repos/pywr/pywr/pulls/601","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pywr/pywr/pulls/comments/174947931"},"html":{"href":"https://github.com/pywr/pywr/pull/601#discussion_r174947931"},"pull_request":{"href":"https://api.github.com/repos/pywr/pywr/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/pywr/pywr/pulls/601","id":173162551,"html_url":"https://github.com/pywr/pywr/pull/601","diff_url":"https://github.com/pywr/pywr/pull/601.diff","patch_url":"https://github.com/pywr/pywr/pull/601.patch","issue_url":"https://api.github.com/repos/pywr/pywr/issues/601","number":601,"state":"open","locked":false,"title":"New and improved variable API for Parameters.","user":{"login":"jetuk","id":4604654,"avatar_url":"https://avatars1.githubusercontent.com/u/4604654?v=4","gravatar_id":"","url":"https://api.github.com/users/jetuk","html_url":"https://github.com/jetuk","followers_url":"https://api.github.com/users/jetuk/followers","following_url":"https://api.github.com/users/jetuk/following{/other_user}","gists_url":"https://api.github.com/users/jetuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jetuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetuk/subscriptions","organizations_url":"https://api.github.com/users/jetuk/orgs","repos_url":"https://api.github.com/users/jetuk/repos","events_url":"https://api.github.com/users/jetuk/events{/privacy}","received_events_url":"https://api.github.com/users/jetuk/received_events","type":"User","site_admin":false},"body":"This commit changes the API for getting and setting Parameter variables. It implements the changes discussed in #258. The changes have been made to all existing Parameters that supported the old API.","created_at":"2018-03-06T13:48:00Z","updated_at":"2018-03-15T22:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2ec34a7a40d399712da6eb88889bff8ba3b73b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pywr/pywr/pulls/601/commits","review_comments_url":"https://api.github.com/repos/pywr/pywr/pulls/601/comments","review_comment_url":"https://api.github.com/repos/pywr/pywr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pywr/pywr/issues/601/comments","statuses_url":"https://api.github.com/repos/pywr/pywr/statuses/83655729a8df8cfab7c495db6ba7a4abb8c42745","head":{"label":"pywr:variable_api","ref":"variable_api","sha":"83655729a8df8cfab7c495db6ba7a4abb8c42745","user":{"login":"pywr","id":15239563,"avatar_url":"https://avatars0.githubusercontent.com/u/15239563?v=4","gravatar_id":"","url":"https://api.github.com/users/pywr","html_url":"https://github.com/pywr","followers_url":"https://api.github.com/users/pywr/followers","following_url":"https://api.github.com/users/pywr/following{/other_user}","gists_url":"https://api.github.com/users/pywr/gists{/gist_id}","starred_url":"https://api.github.com/users/pywr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywr/subscriptions","organizations_url":"https://api.github.com/users/pywr/orgs","repos_url":"https://api.github.com/users/pywr/repos","events_url":"https://api.github.com/users/pywr/events{/privacy}","received_events_url":"https://api.github.com/users/pywr/received_events","type":"Organization","site_admin":false},"repo":{"id":29560246,"name":"pywr","full_name":"pywr/pywr","owner":{"login":"pywr","id":15239563,"avatar_url":"https://avatars0.githubusercontent.com/u/15239563?v=4","gravatar_id":"","url":"https://api.github.com/users/pywr","html_url":"https://github.com/pywr","followers_url":"https://api.github.com/users/pywr/followers","following_url":"https://api.github.com/users/pywr/following{/other_user}","gists_url":"https://api.github.com/users/pywr/gists{/gist_id}","starred_url":"https://api.github.com/users/pywr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywr/subscriptions","organizations_url":"https://api.github.com/users/pywr/orgs","repos_url":"https://api.github.com/users/pywr/repos","events_url":"https://api.github.com/users/pywr/events{/privacy}","received_events_url":"https://api.github.com/users/pywr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywr/pywr","description":"Pywr is a generalised network resource allocation model written in Python.","fork":false,"url":"https://api.github.com/repos/pywr/pywr","forks_url":"https://api.github.com/repos/pywr/pywr/forks","keys_url":"https://api.github.com/repos/pywr/pywr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywr/pywr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywr/pywr/teams","hooks_url":"https://api.github.com/repos/pywr/pywr/hooks","issue_events_url":"https://api.github.com/repos/pywr/pywr/issues/events{/number}","events_url":"https://api.github.com/repos/pywr/pywr/events","assignees_url":"https://api.github.com/repos/pywr/pywr/assignees{/user}","branches_url":"https://api.github.com/repos/pywr/pywr/branches{/branch}","tags_url":"https://api.github.com/repos/pywr/pywr/tags","blobs_url":"https://api.github.com/repos/pywr/pywr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywr/pywr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywr/pywr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywr/pywr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywr/pywr/statuses/{sha}","languages_url":"https://api.github.com/repos/pywr/pywr/languages","stargazers_url":"https://api.github.com/repos/pywr/pywr/stargazers","contributors_url":"https://api.github.com/repos/pywr/pywr/contributors","subscribers_url":"https://api.github.com/repos/pywr/pywr/subscribers","subscription_url":"https://api.github.com/repos/pywr/pywr/subscription","commits_url":"https://api.github.com/repos/pywr/pywr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywr/pywr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywr/pywr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywr/pywr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywr/pywr/contents/{+path}","compare_url":"https://api.github.com/repos/pywr/pywr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywr/pywr/merges","archive_url":"https://api.github.com/repos/pywr/pywr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywr/pywr/downloads","issues_url":"https://api.github.com/repos/pywr/pywr/issues{/number}","pulls_url":"https://api.github.com/repos/pywr/pywr/pulls{/number}","milestones_url":"https://api.github.com/repos/pywr/pywr/milestones{/number}","notifications_url":"https://api.github.com/repos/pywr/pywr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywr/pywr/labels{/name}","releases_url":"https://api.github.com/repos/pywr/pywr/releases{/id}","deployments_url":"https://api.github.com/repos/pywr/pywr/deployments","created_at":"2015-01-20T23:13:55Z","updated_at":"2018-03-15T21:47:42Z","pushed_at":"2018-03-15T21:47:40Z","git_url":"git://github.com/pywr/pywr.git","ssh_url":"git@github.com:pywr/pywr.git","clone_url":"https://github.com/pywr/pywr.git","svn_url":"https://github.com/pywr/pywr","homepage":"","size":3314,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6,"open_issues":96,"watchers":9,"default_branch":"master"}},"base":{"label":"pywr:master","ref":"master","sha":"9742a88d6c2d7eb6992205bd496e6bdb8814bde0","user":{"login":"pywr","id":15239563,"avatar_url":"https://avatars0.githubusercontent.com/u/15239563?v=4","gravatar_id":"","url":"https://api.github.com/users/pywr","html_url":"https://github.com/pywr","followers_url":"https://api.github.com/users/pywr/followers","following_url":"https://api.github.com/users/pywr/following{/other_user}","gists_url":"https://api.github.com/users/pywr/gists{/gist_id}","starred_url":"https://api.github.com/users/pywr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywr/subscriptions","organizations_url":"https://api.github.com/users/pywr/orgs","repos_url":"https://api.github.com/users/pywr/repos","events_url":"https://api.github.com/users/pywr/events{/privacy}","received_events_url":"https://api.github.com/users/pywr/received_events","type":"Organization","site_admin":false},"repo":{"id":29560246,"name":"pywr","full_name":"pywr/pywr","owner":{"login":"pywr","id":15239563,"avatar_url":"https://avatars0.githubusercontent.com/u/15239563?v=4","gravatar_id":"","url":"https://api.github.com/users/pywr","html_url":"https://github.com/pywr","followers_url":"https://api.github.com/users/pywr/followers","following_url":"https://api.github.com/users/pywr/following{/other_user}","gists_url":"https://api.github.com/users/pywr/gists{/gist_id}","starred_url":"https://api.github.com/users/pywr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywr/subscriptions","organizations_url":"https://api.github.com/users/pywr/orgs","repos_url":"https://api.github.com/users/pywr/repos","events_url":"https://api.github.com/users/pywr/events{/privacy}","received_events_url":"https://api.github.com/users/pywr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywr/pywr","description":"Pywr is a generalised network resource allocation model written in Python.","fork":false,"url":"https://api.github.com/repos/pywr/pywr","forks_url":"https://api.github.com/repos/pywr/pywr/forks","keys_url":"https://api.github.com/repos/pywr/pywr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywr/pywr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywr/pywr/teams","hooks_url":"https://api.github.com/repos/pywr/pywr/hooks","issue_events_url":"https://api.github.com/repos/pywr/pywr/issues/events{/number}","events_url":"https://api.github.com/repos/pywr/pywr/events","assignees_url":"https://api.github.com/repos/pywr/pywr/assignees{/user}","branches_url":"https://api.github.com/repos/pywr/pywr/branches{/branch}","tags_url":"https://api.github.com/repos/pywr/pywr/tags","blobs_url":"https://api.github.com/repos/pywr/pywr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywr/pywr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywr/pywr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywr/pywr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywr/pywr/statuses/{sha}","languages_url":"https://api.github.com/repos/pywr/pywr/languages","stargazers_url":"https://api.github.com/repos/pywr/pywr/stargazers","contributors_url":"https://api.github.com/repos/pywr/pywr/contributors","subscribers_url":"https://api.github.com/repos/pywr/pywr/subscribers","subscription_url":"https://api.github.com/repos/pywr/pywr/subscription","commits_url":"https://api.github.com/repos/pywr/pywr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywr/pywr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywr/pywr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywr/pywr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywr/pywr/contents/{+path}","compare_url":"https://api.github.com/repos/pywr/pywr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywr/pywr/merges","archive_url":"https://api.github.com/repos/pywr/pywr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywr/pywr/downloads","issues_url":"https://api.github.com/repos/pywr/pywr/issues{/number}","pulls_url":"https://api.github.com/repos/pywr/pywr/pulls{/number}","milestones_url":"https://api.github.com/repos/pywr/pywr/milestones{/number}","notifications_url":"https://api.github.com/repos/pywr/pywr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywr/pywr/labels{/name}","releases_url":"https://api.github.com/repos/pywr/pywr/releases{/id}","deployments_url":"https://api.github.com/repos/pywr/pywr/deployments","created_at":"2015-01-20T23:13:55Z","updated_at":"2018-03-15T21:47:42Z","pushed_at":"2018-03-15T21:47:40Z","git_url":"git://github.com/pywr/pywr.git","ssh_url":"git@github.com:pywr/pywr.git","clone_url":"https://github.com/pywr/pywr.git","svn_url":"https://github.com/pywr/pywr","homepage":"","size":3314,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6,"open_issues":96,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pywr/pywr/pulls/601"},"html":{"href":"https://github.com/pywr/pywr/pull/601"},"issue":{"href":"https://api.github.com/repos/pywr/pywr/issues/601"},"comments":{"href":"https://api.github.com/repos/pywr/pywr/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/pywr/pywr/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/pywr/pywr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pywr/pywr/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/pywr/pywr/statuses/83655729a8df8cfab7c495db6ba7a4abb8c42745"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"snorfalorpagus"}}