{"action":"created","issue":{"url":"https://api.github.com/repos/docker/machine/issues/4550","repository_url":"https://api.github.com/repos/docker/machine","labels_url":"https://api.github.com/repos/docker/machine/issues/4550/labels{/name}","comments_url":"https://api.github.com/repos/docker/machine/issues/4550/comments","events_url":"https://api.github.com/repos/docker/machine/issues/4550/events","html_url":"https://github.com/docker/machine/pull/4550","id":347371986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDExNDY1","number":4550,"title":"Return error of command exec in SSH NativeClient","user":{"login":"ukinau","id":1475951,"node_id":"MDQ6VXNlcjE0NzU5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1475951?v=4","gravatar_id":"","url":"https://api.github.com/users/ukinau","html_url":"https://github.com/ukinau","followers_url":"https://api.github.com/users/ukinau/followers","following_url":"https://api.github.com/users/ukinau/following{/other_user}","gists_url":"https://api.github.com/users/ukinau/gists{/gist_id}","starred_url":"https://api.github.com/users/ukinau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukinau/subscriptions","organizations_url":"https://api.github.com/users/ukinau/orgs","repos_url":"https://api.github.com/users/ukinau/repos","events_url":"https://api.github.com/users/ukinau/events{/privacy}","received_events_url":"https://api.github.com/users/ukinau/received_events","type":"User","site_admin":false},"labels":[{"id":242606763,"node_id":"MDU6TGFiZWwyNDI2MDY3NjM=","url":"https://api.github.com/repos/docker/machine/labels/dco/no","name":"dco/no","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-03T12:09:52Z","updated_at":"2018-08-03T12:09:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/4550","html_url":"https://github.com/docker/machine/pull/4550","diff_url":"https://github.com/docker/machine/pull/4550.diff","patch_url":"https://github.com/docker/machine/pull/4550.patch"},"body":"## Description\r\nPreviously SSH NativeClient grasp error about session.Wait(),  session.Run() and always return nil indicating succeeded even if command execution on the destination was failed.\r\nBut the error of  session.Wait, Run is that definitely we need to feedback to user. so this PR changed the code to return error if session.Wait, Run failed in Shell func which is used by `docker-machine ssh`.\r\n\r\n## Related issue(s)\r\nhttps://github.com/docker/machine/issues/4549"},"comment":{"url":"https://api.github.com/repos/docker/machine/issues/comments/410234446","html_url":"https://github.com/docker/machine/pull/4550#issuecomment-410234446","issue_url":"https://api.github.com/repos/docker/machine/issues/4550","id":410234446,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDIzNDQ0Ng==","user":{"login":"GordonTheTurtle","id":10620046,"node_id":"MDQ6VXNlcjEwNjIwMDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/10620046?v=4","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T12:09:54Z","updated_at":"2018-08-03T12:09:54Z","author_association":"NONE","body":"<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following these rules:\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work\nThe easiest way to do this is to amend the last commit:\n~~~console\n$ git clone -b \"fix-#4549\" git@github.com:ukinau/machine.git somewhere\n$ cd somewhere\n$ git commit --amend -s --no-edit\n$ git push -f\n~~~\n\nAmending updates the existing PR. You **DO NOT** need to open a new one.\n"}}
{"actor":{"display_login":"GordonTheTurtle"}}