{"action":"closed","number":1753,"pull_request":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/1753","id":185092015,"html_url":"https://github.com/uber/deck.gl/pull/1753","diff_url":"https://github.com/uber/deck.gl/pull/1753.diff","patch_url":"https://github.com/uber/deck.gl/pull/1753.patch","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/1753","number":1753,"state":"closed","locked":false,"title":"use baseline:hanging if advanced text metrics is not supported","user":{"login":"Pessimistress","id":2059298,"avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false},"body":"#### Background\r\nSome browsers see letters cut off when using the TextLayer\r\n\r\nThis was introduced in https://github.com/uber/deck.gl/pull/1698, by changing baseline from `hanging` to `top`.\r\n\r\n#### Change List\r\n- If advanced TextMetrics is not supported, switch baseline back to `hanging`.\r\n- Revert golden image\r\n\r\nTested in layer-browser\r\n","created_at":"2018-04-30T23:43:02Z","updated_at":"2018-05-01T00:49:41Z","closed_at":"2018-05-01T00:49:41Z","merged_at":"2018-05-01T00:49:41Z","merge_commit_sha":"848c820ed7ba0507a1f193597f1f59236df13aa8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jianhuang01","id":15093546,"avatar_url":"https://avatars0.githubusercontent.com/u/15093546?v=4","gravatar_id":"","url":"https://api.github.com/users/jianhuang01","html_url":"https://github.com/jianhuang01","followers_url":"https://api.github.com/users/jianhuang01/followers","following_url":"https://api.github.com/users/jianhuang01/following{/other_user}","gists_url":"https://api.github.com/users/jianhuang01/gists{/gist_id}","starred_url":"https://api.github.com/users/jianhuang01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianhuang01/subscriptions","organizations_url":"https://api.github.com/users/jianhuang01/orgs","repos_url":"https://api.github.com/users/jianhuang01/repos","events_url":"https://api.github.com/users/jianhuang01/events{/privacy}","received_events_url":"https://api.github.com/users/jianhuang01/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/deck.gl/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/uber/deck.gl/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/1753/comments","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/885c161975d26d72511bfb7f75094cfa981639f2","head":{"label":"Pessimistress:text-fix","ref":"text-fix","sha":"885c161975d26d72511bfb7f75094cfa981639f2","user":{"login":"Pessimistress","id":2059298,"avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false},"repo":{"id":123166387,"name":"deck.gl","full_name":"Pessimistress/deck.gl","owner":{"login":"Pessimistress","id":2059298,"avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pessimistress/deck.gl","description":"WebGL2 powered geospatial visualization layers","fork":true,"url":"https://api.github.com/repos/Pessimistress/deck.gl","forks_url":"https://api.github.com/repos/Pessimistress/deck.gl/forks","keys_url":"https://api.github.com/repos/Pessimistress/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pessimistress/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pessimistress/deck.gl/teams","hooks_url":"https://api.github.com/repos/Pessimistress/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/Pessimistress/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/Pessimistress/deck.gl/events","assignees_url":"https://api.github.com/repos/Pessimistress/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/Pessimistress/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/Pessimistress/deck.gl/tags","blobs_url":"https://api.github.com/repos/Pessimistress/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pessimistress/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pessimistress/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pessimistress/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pessimistress/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/Pessimistress/deck.gl/languages","stargazers_url":"https://api.github.com/repos/Pessimistress/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/Pessimistress/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/Pessimistress/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/Pessimistress/deck.gl/subscription","commits_url":"https://api.github.com/repos/Pessimistress/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pessimistress/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pessimistress/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pessimistress/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pessimistress/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/Pessimistress/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pessimistress/deck.gl/merges","archive_url":"https://api.github.com/repos/Pessimistress/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pessimistress/deck.gl/downloads","issues_url":"https://api.github.com/repos/Pessimistress/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/Pessimistress/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/Pessimistress/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/Pessimistress/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pessimistress/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/Pessimistress/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/Pessimistress/deck.gl/deployments","created_at":"2018-02-27T17:49:27Z","updated_at":"2018-02-27T17:49:31Z","pushed_at":"2018-05-01T00:33:01Z","git_url":"git://github.com/Pessimistress/deck.gl.git","ssh_url":"git@github.com:Pessimistress/deck.gl.git","clone_url":"https://github.com/Pessimistress/deck.gl.git","svn_url":"https://github.com/Pessimistress/deck.gl","homepage":"http://uber.github.io/deck.gl","size":114570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"d77bb0fcea5d465d318c79ecdb83d88adf24010c","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"WebGL2 powered geospatial visualization layers","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2018-04-30T19:29:32Z","pushed_at":"2018-05-01T00:49:41Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"http://uber.github.io/deck.gl","size":115242,"stargazers_count":4364,"watchers_count":4364,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":583,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":583,"open_issues":81,"watchers":4364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1753"},"html":{"href":"https://github.com/uber/deck.gl/pull/1753"},"issue":{"href":"https://api.github.com/repos/uber/deck.gl/issues/1753"},"comments":{"href":"https://api.github.com/repos/uber/deck.gl/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/uber/deck.gl/statuses/885c161975d26d72511bfb7f75094cfa981639f2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Pessimistress","id":2059298,"avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"Pessimistress"}}