{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23583","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23583/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23583/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23583/events","html_url":"https://github.com/Automattic/wp-calypso/pull/23583","id":308007421,"number":23583,"title":"Pages: fix wrong paths in page view analytics","user":{"login":"vindl","id":1182160,"avatar_url":"https://avatars1.githubusercontent.com/u/1182160?v=4","gravatar_id":"","url":"https://api.github.com/users/vindl","html_url":"https://github.com/vindl","followers_url":"https://api.github.com/users/vindl/followers","following_url":"https://api.github.com/users/vindl/following{/other_user}","gists_url":"https://api.github.com/users/vindl/gists{/gist_id}","starred_url":"https://api.github.com/users/vindl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindl/subscriptions","organizations_url":"https://api.github.com/users/vindl/orgs","repos_url":"https://api.github.com/users/vindl/repos","events_url":"https://api.github.com/users/vindl/events{/privacy}","received_events_url":"https://api.github.com/users/vindl/received_events","type":"User","site_admin":false},"labels":[{"id":285010036,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Analytics","name":"Analytics","color":"006b75","default":false},{"id":285009978,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Pages","name":"Pages","color":"006b75","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285009975,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Bug","name":"[Type] Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"vindl","id":1182160,"avatar_url":"https://avatars1.githubusercontent.com/u/1182160?v=4","gravatar_id":"","url":"https://api.github.com/users/vindl","html_url":"https://github.com/vindl","followers_url":"https://api.github.com/users/vindl/followers","following_url":"https://api.github.com/users/vindl/following{/other_user}","gists_url":"https://api.github.com/users/vindl/gists{/gist_id}","starred_url":"https://api.github.com/users/vindl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindl/subscriptions","organizations_url":"https://api.github.com/users/vindl/orgs","repos_url":"https://api.github.com/users/vindl/repos","events_url":"https://api.github.com/users/vindl/events{/privacy}","received_events_url":"https://api.github.com/users/vindl/received_events","type":"User","site_admin":false},"assignees":[{"login":"vindl","id":1182160,"avatar_url":"https://avatars1.githubusercontent.com/u/1182160?v=4","gravatar_id":"","url":"https://api.github.com/users/vindl","html_url":"https://github.com/vindl","followers_url":"https://api.github.com/users/vindl/followers","following_url":"https://api.github.com/users/vindl/following{/other_user}","gists_url":"https://api.github.com/users/vindl/gists{/gist_id}","starred_url":"https://api.github.com/users/vindl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindl/subscriptions","organizations_url":"https://api.github.com/users/vindl/orgs","repos_url":"https://api.github.com/users/vindl/repos","events_url":"https://api.github.com/users/vindl/events{/privacy}","received_events_url":"https://api.github.com/users/vindl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-23T12:14:58Z","updated_at":"2018-03-25T21:33:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/23583","html_url":"https://github.com/Automattic/wp-calypso/pull/23583","diff_url":"https://github.com/Automattic/wp-calypso/pull/23583.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/23583.patch"},"body":"Resolves: https://github.com/Automattic/wp-calypso/issues/23580\r\n\r\nAccording to internal logs, some calypso_page_view paths coming from Pages\r\nwere reported without replacing passed parameters with corresponding variables,\r\nor removing wrong entries from the route. This was resolved by adding more\r\nrestrictive route matching for status.\r\n\r\n### Testing instructions\r\n\r\n1. Set `localStorage.setItem( 'debug', 'calypso:analytics:tracks' )` in the browser console to enable the debug.\r\n2. To reproduce the issue, navigate to `/pages/randomtext/{site_url}` or `/pages/randomtext` and observe the `calypso_page_view` recorded paths in log.\r\n3. Apply this branch and verify that `randomtext` is no longer accepted as valid page status and recorded as such.\r\n4. Check that there are no other valid page statuses that we should be matching here.\r\n5. Try to break it with various paths that start with `/pages/`. \r\n\r\nYou can also use this query to see the currently recorded events: 1d6cf-pb (they have much lower counts than legitimate page views). After this patch lands, we should be seeing only valid paths recorded here."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/376005333","html_url":"https://github.com/Automattic/wp-calypso/pull/23583#issuecomment-376005333","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23583","id":376005333,"user":{"login":"yanirs","id":3952615,"avatar_url":"https://avatars1.githubusercontent.com/u/3952615?v=4","gravatar_id":"","url":"https://api.github.com/users/yanirs","html_url":"https://github.com/yanirs","followers_url":"https://api.github.com/users/yanirs/followers","following_url":"https://api.github.com/users/yanirs/following{/other_user}","gists_url":"https://api.github.com/users/yanirs/gists{/gist_id}","starred_url":"https://api.github.com/users/yanirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanirs/subscriptions","organizations_url":"https://api.github.com/users/yanirs/orgs","repos_url":"https://api.github.com/users/yanirs/repos","events_url":"https://api.github.com/users/yanirs/events{/privacy}","received_events_url":"https://api.github.com/users/yanirs/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T21:33:17Z","updated_at":"2018-03-25T21:33:17Z","author_association":"NONE","body":"Thanks @vindl! Just tested it and it looks good."}}
{"actor":{"display_login":"yanirs"}}