{"action":"closed","number":895,"pull_request":{"url":"https://api.github.com/repos/fastify/fastify/pulls/895","id":183097473,"html_url":"https://github.com/fastify/fastify/pull/895","diff_url":"https://github.com/fastify/fastify/pull/895.diff","patch_url":"https://github.com/fastify/fastify/pull/895.patch","issue_url":"https://api.github.com/repos/fastify/fastify/issues/895","number":895,"state":"closed","locked":false,"title":"Allow parsing empty request bodies","user":{"login":"nwoltman","id":5128013,"avatar_url":"https://avatars1.githubusercontent.com/u/5128013?v=4","gravatar_id":"","url":"https://api.github.com/users/nwoltman","html_url":"https://github.com/nwoltman","followers_url":"https://api.github.com/users/nwoltman/followers","following_url":"https://api.github.com/users/nwoltman/following{/other_user}","gists_url":"https://api.github.com/users/nwoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/nwoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwoltman/subscriptions","organizations_url":"https://api.github.com/users/nwoltman/orgs","repos_url":"https://api.github.com/users/nwoltman/repos","events_url":"https://api.github.com/users/nwoltman/events{/privacy}","received_events_url":"https://api.github.com/users/nwoltman/received_events","type":"User","site_admin":false},"body":"Disallowing empty bodies was an optimization for parsing `application/json` requests (since JSON bodies are not valid if they are empty). However, now that the ContentTypeParser can be used to parse other content types, this has become a bug.\r\n\r\nFixes #894\r\n\r\n#### Checklist\r\n\r\n- [x] run `npm run test` and `npm run benchmark`\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)\r\n","created_at":"2018-04-20T15:32:00Z","updated_at":"2018-04-21T22:09:00Z","closed_at":"2018-04-21T22:09:00Z","merged_at":"2018-04-21T22:09:00Z","merge_commit_sha":"8c5e732f2e9b5f4c435589f8c5f0f5950bba9cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":750220462,"url":"https://api.github.com/repos/fastify/fastify/labels/bugfix","name":"bugfix","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastify/fastify/pulls/895/commits","review_comments_url":"https://api.github.com/repos/fastify/fastify/pulls/895/comments","review_comment_url":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastify/fastify/issues/895/comments","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/334c7a006c4c2690fb531d361f04f84e5399df2a","head":{"label":"nwoltman:fix-empty-body","ref":"fix-empty-body","sha":"334c7a006c4c2690fb531d361f04f84e5399df2a","user":{"login":"nwoltman","id":5128013,"avatar_url":"https://avatars1.githubusercontent.com/u/5128013?v=4","gravatar_id":"","url":"https://api.github.com/users/nwoltman","html_url":"https://github.com/nwoltman","followers_url":"https://api.github.com/users/nwoltman/followers","following_url":"https://api.github.com/users/nwoltman/following{/other_user}","gists_url":"https://api.github.com/users/nwoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/nwoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwoltman/subscriptions","organizations_url":"https://api.github.com/users/nwoltman/orgs","repos_url":"https://api.github.com/users/nwoltman/repos","events_url":"https://api.github.com/users/nwoltman/events{/privacy}","received_events_url":"https://api.github.com/users/nwoltman/received_events","type":"User","site_admin":false},"repo":{"id":114557749,"name":"fastify","full_name":"nwoltman/fastify","owner":{"login":"nwoltman","id":5128013,"avatar_url":"https://avatars1.githubusercontent.com/u/5128013?v=4","gravatar_id":"","url":"https://api.github.com/users/nwoltman","html_url":"https://github.com/nwoltman","followers_url":"https://api.github.com/users/nwoltman/followers","following_url":"https://api.github.com/users/nwoltman/following{/other_user}","gists_url":"https://api.github.com/users/nwoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/nwoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwoltman/subscriptions","organizations_url":"https://api.github.com/users/nwoltman/orgs","repos_url":"https://api.github.com/users/nwoltman/repos","events_url":"https://api.github.com/users/nwoltman/events{/privacy}","received_events_url":"https://api.github.com/users/nwoltman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwoltman/fastify","description":"Fast and low overhead web framework, for Node.js","fork":true,"url":"https://api.github.com/repos/nwoltman/fastify","forks_url":"https://api.github.com/repos/nwoltman/fastify/forks","keys_url":"https://api.github.com/repos/nwoltman/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwoltman/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwoltman/fastify/teams","hooks_url":"https://api.github.com/repos/nwoltman/fastify/hooks","issue_events_url":"https://api.github.com/repos/nwoltman/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/nwoltman/fastify/events","assignees_url":"https://api.github.com/repos/nwoltman/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/nwoltman/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/nwoltman/fastify/tags","blobs_url":"https://api.github.com/repos/nwoltman/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwoltman/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwoltman/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwoltman/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwoltman/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/nwoltman/fastify/languages","stargazers_url":"https://api.github.com/repos/nwoltman/fastify/stargazers","contributors_url":"https://api.github.com/repos/nwoltman/fastify/contributors","subscribers_url":"https://api.github.com/repos/nwoltman/fastify/subscribers","subscription_url":"https://api.github.com/repos/nwoltman/fastify/subscription","commits_url":"https://api.github.com/repos/nwoltman/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwoltman/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwoltman/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwoltman/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwoltman/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/nwoltman/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwoltman/fastify/merges","archive_url":"https://api.github.com/repos/nwoltman/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwoltman/fastify/downloads","issues_url":"https://api.github.com/repos/nwoltman/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/nwoltman/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/nwoltman/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/nwoltman/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwoltman/fastify/labels{/name}","releases_url":"https://api.github.com/repos/nwoltman/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/nwoltman/fastify/deployments","created_at":"2017-12-17T18:06:01Z","updated_at":"2018-03-24T21:35:46Z","pushed_at":"2018-04-20T16:45:58Z","git_url":"git://github.com/nwoltman/fastify.git","ssh_url":"git@github.com:nwoltman/fastify.git","clone_url":"https://github.com/nwoltman/fastify.git","svn_url":"https://github.com/nwoltman/fastify","homepage":"https://www.fastify.io","size":1462,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastify:master","ref":"master","sha":"320871e1e80f830f217647b57916f280944e7100","user":{"login":"fastify","id":24939410,"avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"repo":{"id":69495170,"name":"fastify","full_name":"fastify/fastify","owner":{"login":"fastify","id":24939410,"avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastify/fastify","description":"Fast and low overhead web framework, for Node.js","fork":false,"url":"https://api.github.com/repos/fastify/fastify","forks_url":"https://api.github.com/repos/fastify/fastify/forks","keys_url":"https://api.github.com/repos/fastify/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastify/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastify/fastify/teams","hooks_url":"https://api.github.com/repos/fastify/fastify/hooks","issue_events_url":"https://api.github.com/repos/fastify/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/fastify/fastify/events","assignees_url":"https://api.github.com/repos/fastify/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/fastify/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/fastify/fastify/tags","blobs_url":"https://api.github.com/repos/fastify/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastify/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastify/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastify/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/fastify/fastify/languages","stargazers_url":"https://api.github.com/repos/fastify/fastify/stargazers","contributors_url":"https://api.github.com/repos/fastify/fastify/contributors","subscribers_url":"https://api.github.com/repos/fastify/fastify/subscribers","subscription_url":"https://api.github.com/repos/fastify/fastify/subscription","commits_url":"https://api.github.com/repos/fastify/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastify/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastify/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastify/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastify/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/fastify/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastify/fastify/merges","archive_url":"https://api.github.com/repos/fastify/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastify/fastify/downloads","issues_url":"https://api.github.com/repos/fastify/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/fastify/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/fastify/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/fastify/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastify/fastify/labels{/name}","releases_url":"https://api.github.com/repos/fastify/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/fastify/fastify/deployments","created_at":"2016-09-28T19:10:14Z","updated_at":"2018-04-21T21:29:59Z","pushed_at":"2018-04-21T22:09:00Z","git_url":"git://github.com/fastify/fastify.git","ssh_url":"git@github.com:fastify/fastify.git","clone_url":"https://github.com/fastify/fastify.git","svn_url":"https://github.com/fastify/fastify","homepage":"https://www.fastify.io","size":1444,"stargazers_count":6797,"watchers_count":6797,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":364,"open_issues":31,"watchers":6797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/895"},"html":{"href":"https://github.com/fastify/fastify/pull/895"},"issue":{"href":"https://api.github.com/repos/fastify/fastify/issues/895"},"comments":{"href":"https://api.github.com/repos/fastify/fastify/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/fastify/fastify/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastify/fastify/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/fastify/fastify/statuses/334c7a006c4c2690fb531d361f04f84e5399df2a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nwoltman","id":5128013,"avatar_url":"https://avatars1.githubusercontent.com/u/5128013?v=4","gravatar_id":"","url":"https://api.github.com/users/nwoltman","html_url":"https://github.com/nwoltman","followers_url":"https://api.github.com/users/nwoltman/followers","following_url":"https://api.github.com/users/nwoltman/following{/other_user}","gists_url":"https://api.github.com/users/nwoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/nwoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwoltman/subscriptions","organizations_url":"https://api.github.com/users/nwoltman/orgs","repos_url":"https://api.github.com/users/nwoltman/repos","events_url":"https://api.github.com/users/nwoltman/events{/privacy}","received_events_url":"https://api.github.com/users/nwoltman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":82,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"nwoltman"}}