{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23808","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23808/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23808/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23808/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23808","id":298779517,"number":23808,"title":"Overhaul Vega typings","user":{"login":"pelotom","id":128019,"avatar_url":"https://avatars2.githubusercontent.com/u/128019?v=4","gravatar_id":"","url":"https://api.github.com/users/pelotom","html_url":"https://github.com/pelotom","followers_url":"https://api.github.com/users/pelotom/followers","following_url":"https://api.github.com/users/pelotom/following{/other_user}","gists_url":"https://api.github.com/users/pelotom/gists{/gist_id}","starred_url":"https://api.github.com/users/pelotom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelotom/subscriptions","organizations_url":"https://api.github.com/users/pelotom/orgs","repos_url":"https://api.github.com/users/pelotom/repos","events_url":"https://api.github.com/users/pelotom/events{/privacy}","received_events_url":"https://api.github.com/users/pelotom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-02-20T22:53:00Z","updated_at":"2018-02-21T19:19:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23808","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23808","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23808.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23808.patch"},"body":"Based on:\r\n- https://github.com/vega/vega-parser/tree/as/typings\r\n- https://github.com/vega/vega-lite/blob/master/typings/vega.d.ts\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://vega.github.io/vega/docs/\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/367439382","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23808#issuecomment-367439382","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23808","id":367439382,"user":{"login":"pelotom","id":128019,"avatar_url":"https://avatars2.githubusercontent.com/u/128019?v=4","gravatar_id":"","url":"https://api.github.com/users/pelotom","html_url":"https://github.com/pelotom","followers_url":"https://api.github.com/users/pelotom/followers","following_url":"https://api.github.com/users/pelotom/following{/other_user}","gists_url":"https://api.github.com/users/pelotom/gists{/gist_id}","starred_url":"https://api.github.com/users/pelotom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelotom/subscriptions","organizations_url":"https://api.github.com/users/pelotom/orgs","repos_url":"https://api.github.com/users/pelotom/repos","events_url":"https://api.github.com/users/pelotom/events{/privacy}","received_events_url":"https://api.github.com/users/pelotom/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T19:19:56Z","updated_at":"2018-02-21T19:19:56Z","author_association":"CONTRIBUTOR","body":"> This looks good to me for now. We can refine it (e.g. transforms) in a follow-up PR.\r\n\r\nUnfortunately now we need to wait for a DefinitelyTyped maintainer to sign off on this, which can take on the order of a week. Is there interest in maintaining these typings within vega itself? The upside is that the vega maintainers can control the rate of updates to the typings. The downside is that the release cycle of the typings is tied to that of vega. A possible middle route would be to make a dedicated package `vega-typings` (whose types could be reexported by `vega` (and `vega-lib`?)) and then people could update that package independently."}}
{"actor":{"display_login":"pelotom"}}