{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/232680194","pull_request_review_id":173928154,"id":232680194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjY4MDE5NA==","diff_hunk":"@@ -35,7 +36,8 @@ class vehicle_part_iterator\n             return range_.get();\n         }\n         void skip_to_next_valid( size_t i ) {\n-            while( i < range().part_count() && !range().contained( i ) ) {\n+            while( i < range().part_count() &&\n+                   !range().matches( i, static_cast<part_status_flag>( 0 ) ) ) {","path":"src/vpart_range.h","position":14,"original_position":14,"commit_id":"1c7c83181ef5d1a51d382f154fd1f1796021b209","original_commit_id":"1c7c83181ef5d1a51d382f154fd1f1796021b209","user":{"login":"BevapDin","id":5095435,"node_id":"MDQ6VXNlcjUwOTU0MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5095435?v=4","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"Why are you using a fixed value 0 here? If the parameter is always the same, why have it at all? The ranges should store their own `part_status_flag` value (and already do so when needed).","created_at":"2018-11-12T14:36:16Z","updated_at":"2018-11-12T14:36:16Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499#discussion_r232680194","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/232680194"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499#discussion_r232680194"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499","id":228047378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQ3Mzc4","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26499","number":26499,"state":"open","locked":false,"title":"Fix bugs with bikeracks by making racked parts unavailable","user":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n```SUMMARY: Bugfixes \"Fix bugs with bikeracks by making racked parts unavailable\"```\r\n\r\n#### Purpose of change\r\nFixes #26366\r\nFixes #26365\r\n\r\nMost vehicle parts on a bike rack are supposed to be unavailable to the carrying vehicle.  I went back\r\nthrough the code and added some checks to some parts that were missing them, and then cleaned up\r\nsome code references to remove duplicate or redundant code.\r\n\r\n#### Describe the solution\r\nThe existing carried flag is supposed to keep parts on a bike rack from affecting the parent vehicle,\r\nbut it wasn't be honored in a lot of cases.  Adding checks for it resolves those issues.","created_at":"2018-11-02T20:13:20Z","updated_at":"2018-11-12T14:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"115190dba7e48c189e6cbaf160eef22e959dc0ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":887828902,"node_id":"MDU6TGFiZWw4ODc4Mjg5MDI=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/%3CBugfix%3E","name":"<Bugfix>","color":"29fc29","default":false},{"id":479118825,"node_id":"MDU6TGFiZWw0NzkxMTg4MjU=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Vehicles","name":"Vehicles","color":"243b61","default":false},{"id":659366627,"node_id":"MDU6TGFiZWw2NTkzNjY2Mjc=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[C++]","name":"[C++]","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26499/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/1c7c83181ef5d1a51d382f154fd1f1796021b209","head":{"label":"mlangsdorf:bikerack_fixes","ref":"bikerack_fixes","sha":"1c7c83181ef5d1a51d382f154fd1f1796021b209","user":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"repo":{"id":60530185,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzMDE4NQ==","name":"Cataclysm-DDA","full_name":"mlangsdorf/Cataclysm-DDA","private":false,"owner":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mlangsdorf/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA","forks_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/mlangsdorf/Cataclysm-DDA/deployments","created_at":"2016-06-06T13:30:49Z","updated_at":"2018-11-11T20:46:16Z","pushed_at":"2018-11-12T01:54:23Z","git_url":"git://github.com/mlangsdorf/Cataclysm-DDA.git","ssh_url":"git@github.com:mlangsdorf/Cataclysm-DDA.git","clone_url":"https://github.com/mlangsdorf/Cataclysm-DDA.git","svn_url":"https://github.com/mlangsdorf/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1384401,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"003d91bd6b1b58c53ccc42854eb28ddf347b24c1","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-11-12T10:42:46Z","pushed_at":"2018-11-12T13:56:49Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1386172,"stargazers_count":2241,"watchers_count":2241,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1496,"mirror_url":null,"archived":false,"open_issues_count":1043,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1496,"open_issues":1043,"watchers":2241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26499"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26499"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26499/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26499/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/1c7c83181ef5d1a51d382f154fd1f1796021b209"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BevapDin"}}