{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/19213","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/19213/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19213/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/19213/events","html_url":"https://github.com/dotnet/coreclr/pull/19213","id":346264976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTcxNzU3","number":19213,"title":"[Unix|Windows|x64] Unify exclusion list and enable runtest.py","user":{"login":"jashook","id":2723327,"node_id":"MDQ6VXNlcjI3MjMzMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2723327?v=4","gravatar_id":"","url":"https://api.github.com/users/jashook","html_url":"https://github.com/jashook","followers_url":"https://api.github.com/users/jashook/followers","following_url":"https://api.github.com/users/jashook/following{/other_user}","gists_url":"https://api.github.com/users/jashook/gists{/gist_id}","starred_url":"https://api.github.com/users/jashook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashook/subscriptions","organizations_url":"https://api.github.com/users/jashook/orgs","repos_url":"https://api.github.com/users/jashook/repos","events_url":"https://api.github.com/users/jashook/events{/privacy}","received_events_url":"https://api.github.com/users/jashook/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-31T16:30:48Z","updated_at":"2018-07-31T19:45:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19213","html_url":"https://github.com/dotnet/coreclr/pull/19213","diff_url":"https://github.com/dotnet/coreclr/pull/19213.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19213.patch"},"body":"The change has a few different pieces. I have kept the commit history in an effort to potentially help review the change. The change includes, but is not limited to:\r\n\r\n1. Changing build-test.sh to always build the xunit wrappers. Before it would drop a token and check the existence of the token.\r\n2. Unify x64 linux/OSX/Windows excludes into one file, issues.targets. I have added different locations in the file which show where to put excludes.\r\n3. Remove all target specific aspects of issues.targets, all tests are excluded now via wildcard, this allows expanding to .cmd and .sh based on the build platform\r\n4. Unify path separators to forward slash(/) in issues.targets to support both platforms\r\n5. Clean up issues.targets by removing long standing exclude tests, specifically tests that have been excluded due to missing features like rva_statics\r\n6. Add DisableProjectBuild  to tests which have been removed from issues.targets\r\n7. Conditionally add DisableProjectBuild  to tests which have been marked as unsupported on unix. This is mostly a port of the unsupportedOnUnix.txt list. Instead of excluding the tests, unix will simply not build them. **Note that this refcount dependency on running tests on the same platform as where they were built**\r\n8. All exclusions ported to issues.targets for linux targets.\r\n9. Expand runtest.py, this includes simple issues that made it past the original CR. In addition it adds more optional features to help with inner loop dev work such as: creating a repro folder under bin/repro/<Host>.<Arch>.<BuildType> which sets up the env and calls the failing test. In addition a launch.json will now be created under bin/repro/<Host>.<Arch>.<BuildType> which can be used to easily debug using vscode. More logging, such as printing failures, longest running tests ect.\r\n10. Initial excludes ported for arm64 windows\r\n\r\nWhat this PR does not include:\r\n\r\nArm and arm64, both windows and unix, support for runtest.py. This is currently blocked on tools acquisition using init-tools.cmd/init-tools.sh, these scripts will currently pull down the x64 tools and we are unable to run msbuild on those platforms.\r\n\r\n**Notes**\r\n\r\nIn order to support different return codes used by runtest.sh and the xunit console runner. I have conditionally included different return codes for the test bash wrappers. **This means that for our ci jobs which build bash targets on windows, unix testing will continue to succeed using runtest.sh. However, this will break all tests run using runtest.sh using a test build that is built on unix. Basically runtest.sh will be deprecated with this change, and runtest.py will be the only supported use case.**"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/409344614","html_url":"https://github.com/dotnet/coreclr/pull/19213#issuecomment-409344614","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19213","id":409344614,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTM0NDYxNA==","user":{"login":"jashook","id":2723327,"node_id":"MDQ6VXNlcjI3MjMzMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/2723327?v=4","gravatar_id":"","url":"https://api.github.com/users/jashook","html_url":"https://github.com/jashook","followers_url":"https://api.github.com/users/jashook/followers","following_url":"https://api.github.com/users/jashook/following{/other_user}","gists_url":"https://api.github.com/users/jashook/gists{/gist_id}","starred_url":"https://api.github.com/users/jashook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashook/subscriptions","organizations_url":"https://api.github.com/users/jashook/orgs","repos_url":"https://api.github.com/users/jashook/repos","events_url":"https://api.github.com/users/jashook/events{/privacy}","received_events_url":"https://api.github.com/users/jashook/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T19:45:39Z","updated_at":"2018-07-31T19:45:39Z","author_association":"CONTRIBUTOR","body":"Based on suggestions, I will change runtest.sh to use runtest.py if on x64. Will work on that change later tonight."}}
{"actor":{"display_login":"jashook"}}