{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/166950904","pull_request_review_id":95093016,"id":166950904,"diff_hunk":"@@ -114,6 +114,8 @@ describe(\"Package Detail Tab\", function() {\n         .get(\".page-body-content .package-action-buttons button\")\n         .contains(\"Review & Run\")\n         .click();\n+\n+      cy.get(\".modal .modal-header button\").contains(\"Review & Run\").click();","path":"tests/pages/catalog/packages/package/PackageTab-cy.js","position":5,"original_position":5,"commit_id":"4b659d4b9606e01c708d7234e807d2756f701390","original_commit_id":"4b659d4b9606e01c708d7234e807d2756f701390","user":{"login":"juliangieseke","id":530632,"avatar_url":"https://avatars2.githubusercontent.com/u/530632?v=4","gravatar_id":"","url":"https://api.github.com/users/juliangieseke","html_url":"https://github.com/juliangieseke","followers_url":"https://api.github.com/users/juliangieseke/followers","following_url":"https://api.github.com/users/juliangieseke/following{/other_user}","gists_url":"https://api.github.com/users/juliangieseke/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangieseke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangieseke/subscriptions","organizations_url":"https://api.github.com/users/juliangieseke/orgs","repos_url":"https://api.github.com/users/juliangieseke/repos","events_url":"https://api.github.com/users/juliangieseke/events{/privacy}","received_events_url":"https://api.github.com/users/juliangieseke/received_events","type":"User","site_admin":false},"body":"hm, one moment… this file is integration tests. forget it","created_at":"2018-02-08T14:34:53Z","updated_at":"2018-02-08T14:34:53Z","html_url":"https://github.com/dcos/dcos-ui/pull/2698#discussion_r166950904","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/166950904"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/2698#discussion_r166950904"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698"}},"in_reply_to_id":166950682},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698","id":166466888,"html_url":"https://github.com/dcos/dcos-ui/pull/2698","diff_url":"https://github.com/dcos/dcos-ui/pull/2698.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/2698.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2698","number":2698,"state":"open","locked":false,"title":"feat(FrameworkConfiguration): open to form when deploying","user":{"login":"ahoskins","id":1527504,"avatar_url":"https://avatars3.githubusercontent.com/u/1527504?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoskins","html_url":"https://github.com/ahoskins","followers_url":"https://api.github.com/users/ahoskins/followers","following_url":"https://api.github.com/users/ahoskins/following{/other_user}","gists_url":"https://api.github.com/users/ahoskins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoskins/subscriptions","organizations_url":"https://api.github.com/users/ahoskins/orgs","repos_url":"https://api.github.com/users/ahoskins/repos","events_url":"https://api.github.com/users/ahoskins/events{/privacy}","received_events_url":"https://api.github.com/users/ahoskins/received_events","type":"User","site_admin":false},"body":"Based on feedback from users, we want to open the service to the form when deploying. This also makes it the same as when editing a running framework.\r\n\r\n![screen recording 2018-02-01 at 03 56 pm](https://user-images.githubusercontent.com/1527504/35667438-9df60fbc-0768-11e8-9621-9c8627cc45e9.gif)\r\n\r\nCloses DCOS-19301\r\n\r\n**Checklist**\r\n- [ ] Did you add a JIRA issue in a commit message or as part of the branch name?\r\n- [ ] Did you add new unit tests?\r\n- [ ] Did you add new integration tests?\r\n- [ ] If this is a regression, did you write a test to catch this in the future?\r\n\r\n<!-- More info can be found by clicking the \"guidelines for contributing\" link above. -->\r\n","created_at":"2018-02-01T07:57:44Z","updated_at":"2018-02-08T14:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d7c7bd62df0e1a23dbe2913c454b8100c544de5","assignee":{"login":"Fabs","id":10524,"avatar_url":"https://avatars1.githubusercontent.com/u/10524?v=4","gravatar_id":"","url":"https://api.github.com/users/Fabs","html_url":"https://github.com/Fabs","followers_url":"https://api.github.com/users/Fabs/followers","following_url":"https://api.github.com/users/Fabs/following{/other_user}","gists_url":"https://api.github.com/users/Fabs/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabs/subscriptions","organizations_url":"https://api.github.com/users/Fabs/orgs","repos_url":"https://api.github.com/users/Fabs/repos","events_url":"https://api.github.com/users/Fabs/events{/privacy}","received_events_url":"https://api.github.com/users/Fabs/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fabs","id":10524,"avatar_url":"https://avatars1.githubusercontent.com/u/10524?v=4","gravatar_id":"","url":"https://api.github.com/users/Fabs","html_url":"https://github.com/Fabs","followers_url":"https://api.github.com/users/Fabs/followers","following_url":"https://api.github.com/users/Fabs/following{/other_user}","gists_url":"https://api.github.com/users/Fabs/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabs/subscriptions","organizations_url":"https://api.github.com/users/Fabs/orgs","repos_url":"https://api.github.com/users/Fabs/repos","events_url":"https://api.github.com/users/Fabs/events{/privacy}","received_events_url":"https://api.github.com/users/Fabs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2698/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/4b659d4b9606e01c708d7234e807d2756f701390","head":{"label":"dcos:ahoskins/feat/DCOS-19301-package-review-and-run","ref":"ahoskins/feat/DCOS-19301-package-review-and-run","sha":"4b659d4b9606e01c708d7234e807d2756f701390","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-02-06T01:29:19Z","pushed_at":"2018-02-08T14:10:29Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":41991,"stargazers_count":169,"watchers_count":169,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":63,"open_issues":24,"watchers":169,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"e7d133dd148eb0d407edff4e570425db99e0e82a","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-02-06T01:29:19Z","pushed_at":"2018-02-08T14:10:29Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":41991,"stargazers_count":169,"watchers_count":169,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":63,"open_issues":24,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/2698"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/2698"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/2698/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/2698/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/4b659d4b9606e01c708d7234e807d2756f701390"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"juliangieseke"}}