{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/180113993","pull_request_review_id":110473860,"id":180113993,"diff_hunk":"@@ -1385,6 +1389,41 @@ namespace\n         }\n         else\n         {\n+            asr::AOVContainer aovs;\n+\n+            IRenderElementMgr* re_manager = GetCOREInterface()->GetCurRenderElementMgr();\n+            re_manager->SetDisplayElements(false);\n+            for (size_t i = 0, e = re_manager->NumRenderElements(); i < e; ++i)\n+            {\n+                const asr::AOVFactoryRegistrar factory_registrar;","path":"src/appleseed-max-impl/appleseedrenderer/projectbuilder.cpp","position":35,"original_position":35,"commit_id":"33c51017d178c2bee000ecb7b07d29d7e0b3fc0e","original_commit_id":"33c51017d178c2bee000ecb7b07d29d7e0b3fc0e","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Move the creation of the factory registrar out of the loop: creating a factory registrar is an extremely expensive operation as it will scan search paths for plugins, load DLLs, etc. In fact we might want to create the registrar once when the plugin is loaded rather than everytime a project is built.","created_at":"2018-04-09T14:32:26Z","updated_at":"2018-04-09T14:42:29Z","html_url":"https://github.com/appleseedhq/appleseed-max/pull/154#discussion_r180113993","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments/180113993"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/154#discussion_r180113993"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154","id":180053528,"html_url":"https://github.com/appleseedhq/appleseed-max/pull/154","diff_url":"https://github.com/appleseedhq/appleseed-max/pull/154.diff","patch_url":"https://github.com/appleseedhq/appleseed-max/pull/154.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/154","number":154,"state":"open","locked":false,"title":"Add RenderElement plugin to support appleseed's AOV-s","user":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"body":"Hi @dictoon \r\nThis is render element plugin that allows users to render appleseed AOVs.\r\nPlugin basically used to store AOV type and output filename.\r\nI could not find a way to copy AOV image from appliseed image to 3ds max render element bitmap, and for that reason at some stage render elements are turned off and files are saved with appleseed's function `project->get_frame()->write_main_and_aov_images();`\r\n\r\nThanks for review,\r\nSergo.","created_at":"2018-04-06T21:02:08Z","updated_at":"2018-04-09T14:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3709e89bc12f74fbdf1847a9c890651681470ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/154/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/33c51017d178c2bee000ecb7b07d29d7e0b3fc0e","head":{"label":"usakhelo:aov_elements_pr","ref":"aov_elements_pr","sha":"33c51017d178c2bee000ecb7b07d29d7e0b3fc0e","user":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"repo":{"id":88937196,"name":"appleseed-max","full_name":"usakhelo/appleseed-max","owner":{"login":"usakhelo","id":1850877,"avatar_url":"https://avatars3.githubusercontent.com/u/1850877?v=4","gravatar_id":"","url":"https://api.github.com/users/usakhelo","html_url":"https://github.com/usakhelo","followers_url":"https://api.github.com/users/usakhelo/followers","following_url":"https://api.github.com/users/usakhelo/following{/other_user}","gists_url":"https://api.github.com/users/usakhelo/gists{/gist_id}","starred_url":"https://api.github.com/users/usakhelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usakhelo/subscriptions","organizations_url":"https://api.github.com/users/usakhelo/orgs","repos_url":"https://api.github.com/users/usakhelo/repos","events_url":"https://api.github.com/users/usakhelo/events{/privacy}","received_events_url":"https://api.github.com/users/usakhelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usakhelo/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":true,"url":"https://api.github.com/repos/usakhelo/appleseed-max","forks_url":"https://api.github.com/repos/usakhelo/appleseed-max/forks","keys_url":"https://api.github.com/repos/usakhelo/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usakhelo/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usakhelo/appleseed-max/teams","hooks_url":"https://api.github.com/repos/usakhelo/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/usakhelo/appleseed-max/events","assignees_url":"https://api.github.com/repos/usakhelo/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/usakhelo/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/usakhelo/appleseed-max/tags","blobs_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usakhelo/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/usakhelo/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/usakhelo/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/usakhelo/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/usakhelo/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/usakhelo/appleseed-max/subscription","commits_url":"https://api.github.com/repos/usakhelo/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/usakhelo/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/usakhelo/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/usakhelo/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/usakhelo/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usakhelo/appleseed-max/merges","archive_url":"https://api.github.com/repos/usakhelo/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usakhelo/appleseed-max/downloads","issues_url":"https://api.github.com/repos/usakhelo/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/usakhelo/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/usakhelo/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/usakhelo/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usakhelo/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/usakhelo/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/usakhelo/appleseed-max/deployments","created_at":"2017-04-21T03:48:17Z","updated_at":"2017-04-21T03:48:19Z","pushed_at":"2018-04-08T03:12:07Z","git_url":"git://github.com/usakhelo/appleseed-max.git","ssh_url":"git@github.com:usakhelo/appleseed-max.git","clone_url":"https://github.com/usakhelo/appleseed-max.git","svn_url":"https://github.com/usakhelo/appleseed-max","homepage":"","size":2292,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"feed73d75bb1d6ebc875670a2a5d849c89afcb5d","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":45906123,"name":"appleseed-max","full_name":"appleseedhq/appleseed-max","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed-max","description":"appleseed plugin for Autodesk® 3ds Max®","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed-max","forks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed-max/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed-max/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed-max/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed-max/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed-max/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed-max/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed-max/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed-max/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed-max/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed-max/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed-max/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed-max/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed-max/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed-max/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed-max/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed-max/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed-max/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed-max/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed-max/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed-max/deployments","created_at":"2015-11-10T10:57:32Z","updated_at":"2018-04-07T15:52:01Z","pushed_at":"2018-04-08T03:12:08Z","git_url":"git://github.com/appleseedhq/appleseed-max.git","ssh_url":"git@github.com:appleseedhq/appleseed-max.git","clone_url":"https://github.com/appleseedhq/appleseed-max.git","svn_url":"https://github.com/appleseedhq/appleseed-max","homepage":"https://appleseedhq.net/","size":1849,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":28,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154"},"html":{"href":"https://github.com/appleseedhq/appleseed-max/pull/154"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/154"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed-max/statuses/33c51017d178c2bee000ecb7b07d29d7e0b3fc0e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dictoon"}}