{"action":"closed","number":147,"pull_request":{"url":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147","id":198082910,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDgyOTEw","html_url":"https://github.com/xiaokaike/vue-color/pull/147","diff_url":"https://github.com/xiaokaike/vue-color/pull/147.diff","patch_url":"https://github.com/xiaokaike/vue-color/pull/147.patch","issue_url":"https://api.github.com/repos/xiaokaike/vue-color/issues/147","number":147,"state":"closed","locked":false,"title":" Changes to Saturation/Hue.vue to isolate X/Y Events and Fix #113","user":{"login":"paulm17","id":387463,"node_id":"MDQ6VXNlcjM4NzQ2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/387463?v=4","gravatar_id":"","url":"https://api.github.com/users/paulm17","html_url":"https://github.com/paulm17","followers_url":"https://api.github.com/users/paulm17/followers","following_url":"https://api.github.com/users/paulm17/following{/other_user}","gists_url":"https://api.github.com/users/paulm17/gists{/gist_id}","starred_url":"https://api.github.com/users/paulm17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulm17/subscriptions","organizations_url":"https://api.github.com/users/paulm17/orgs","repos_url":"https://api.github.com/users/paulm17/repos","events_url":"https://api.github.com/users/paulm17/events{/privacy}","received_events_url":"https://api.github.com/users/paulm17/received_events","type":"User","site_admin":false},"body":"This PR is to fix the issues in https://github.com/xiaokaike/vue-color/issues/113.\r\n\r\nWhat I have done for both Saturation and Hue X/Y elements is to make them separate from the global colors variable and to use a local data variable.\r\n\r\nWith this change, the issue of the Hue slider shunting to the left when the pointer goes to the bottom AND the effect that I have seen.  Is when the pointer goes near to the bottom, it sometimes itself shunts to the left or right.\r\n\r\nNow this is not the case.\r\n\r\nFinally, I've only had a limited amount of time to work on this.  I'm sure the code could be refactored better.  Maybe for 3.0?\r\n\r\nAlso please test and ensure this does not degrade the color data in anyway!","created_at":"2018-06-28T16:17:43Z","updated_at":"2018-08-12T08:46:48Z","closed_at":"2018-08-12T08:46:48Z","merged_at":"2018-08-12T08:46:48Z","merge_commit_sha":"7c63f0382602d97efbfdc9bcdba10abd993d464c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147/commits","review_comments_url":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147/comments","review_comment_url":"https://api.github.com/repos/xiaokaike/vue-color/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xiaokaike/vue-color/issues/147/comments","statuses_url":"https://api.github.com/repos/xiaokaike/vue-color/statuses/75ce15fc28d6166bdca3ed540a2073c60dd4f623","head":{"label":"paulm17:master","ref":"master","sha":"75ce15fc28d6166bdca3ed540a2073c60dd4f623","user":{"login":"paulm17","id":387463,"node_id":"MDQ6VXNlcjM4NzQ2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/387463?v=4","gravatar_id":"","url":"https://api.github.com/users/paulm17","html_url":"https://github.com/paulm17","followers_url":"https://api.github.com/users/paulm17/followers","following_url":"https://api.github.com/users/paulm17/following{/other_user}","gists_url":"https://api.github.com/users/paulm17/gists{/gist_id}","starred_url":"https://api.github.com/users/paulm17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulm17/subscriptions","organizations_url":"https://api.github.com/users/paulm17/orgs","repos_url":"https://api.github.com/users/paulm17/repos","events_url":"https://api.github.com/users/paulm17/events{/privacy}","received_events_url":"https://api.github.com/users/paulm17/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"xiaokaike:fix/#113","ref":"fix/#113","sha":"904a7f0af71f199cfcbca4eccc813321b288a7fc","user":{"login":"xiaokaike","id":4251499,"node_id":"MDQ6VXNlcjQyNTE0OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4251499?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaokaike","html_url":"https://github.com/xiaokaike","followers_url":"https://api.github.com/users/xiaokaike/followers","following_url":"https://api.github.com/users/xiaokaike/following{/other_user}","gists_url":"https://api.github.com/users/xiaokaike/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaokaike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaokaike/subscriptions","organizations_url":"https://api.github.com/users/xiaokaike/orgs","repos_url":"https://api.github.com/users/xiaokaike/repos","events_url":"https://api.github.com/users/xiaokaike/events{/privacy}","received_events_url":"https://api.github.com/users/xiaokaike/received_events","type":"User","site_admin":false},"repo":{"id":56842017,"node_id":"MDEwOlJlcG9zaXRvcnk1Njg0MjAxNw==","name":"vue-color","full_name":"xiaokaike/vue-color","owner":{"login":"xiaokaike","id":4251499,"node_id":"MDQ6VXNlcjQyNTE0OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4251499?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaokaike","html_url":"https://github.com/xiaokaike","followers_url":"https://api.github.com/users/xiaokaike/followers","following_url":"https://api.github.com/users/xiaokaike/following{/other_user}","gists_url":"https://api.github.com/users/xiaokaike/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaokaike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaokaike/subscriptions","organizations_url":"https://api.github.com/users/xiaokaike/orgs","repos_url":"https://api.github.com/users/xiaokaike/repos","events_url":"https://api.github.com/users/xiaokaike/events{/privacy}","received_events_url":"https://api.github.com/users/xiaokaike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiaokaike/vue-color","description":":art: Vue Color Pickers for Sketch, Photoshop, Chrome & more   http://vue-color.surge.sh","fork":false,"url":"https://api.github.com/repos/xiaokaike/vue-color","forks_url":"https://api.github.com/repos/xiaokaike/vue-color/forks","keys_url":"https://api.github.com/repos/xiaokaike/vue-color/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaokaike/vue-color/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaokaike/vue-color/teams","hooks_url":"https://api.github.com/repos/xiaokaike/vue-color/hooks","issue_events_url":"https://api.github.com/repos/xiaokaike/vue-color/issues/events{/number}","events_url":"https://api.github.com/repos/xiaokaike/vue-color/events","assignees_url":"https://api.github.com/repos/xiaokaike/vue-color/assignees{/user}","branches_url":"https://api.github.com/repos/xiaokaike/vue-color/branches{/branch}","tags_url":"https://api.github.com/repos/xiaokaike/vue-color/tags","blobs_url":"https://api.github.com/repos/xiaokaike/vue-color/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaokaike/vue-color/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaokaike/vue-color/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaokaike/vue-color/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaokaike/vue-color/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaokaike/vue-color/languages","stargazers_url":"https://api.github.com/repos/xiaokaike/vue-color/stargazers","contributors_url":"https://api.github.com/repos/xiaokaike/vue-color/contributors","subscribers_url":"https://api.github.com/repos/xiaokaike/vue-color/subscribers","subscription_url":"https://api.github.com/repos/xiaokaike/vue-color/subscription","commits_url":"https://api.github.com/repos/xiaokaike/vue-color/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaokaike/vue-color/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaokaike/vue-color/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaokaike/vue-color/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaokaike/vue-color/contents/{+path}","compare_url":"https://api.github.com/repos/xiaokaike/vue-color/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaokaike/vue-color/merges","archive_url":"https://api.github.com/repos/xiaokaike/vue-color/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaokaike/vue-color/downloads","issues_url":"https://api.github.com/repos/xiaokaike/vue-color/issues{/number}","pulls_url":"https://api.github.com/repos/xiaokaike/vue-color/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaokaike/vue-color/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaokaike/vue-color/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaokaike/vue-color/labels{/name}","releases_url":"https://api.github.com/repos/xiaokaike/vue-color/releases{/id}","deployments_url":"https://api.github.com/repos/xiaokaike/vue-color/deployments","created_at":"2016-04-22T09:02:18Z","updated_at":"2018-08-11T16:02:50Z","pushed_at":"2018-08-12T08:46:48Z","git_url":"git://github.com/xiaokaike/vue-color.git","ssh_url":"git@github.com:xiaokaike/vue-color.git","clone_url":"https://github.com/xiaokaike/vue-color.git","svn_url":"https://github.com/xiaokaike/vue-color","homepage":"https://xiaokaike.github.io/vue-color/","size":5115,"stargazers_count":1083,"watchers_count":1083,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":173,"open_issues":13,"watchers":1083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147"},"html":{"href":"https://github.com/xiaokaike/vue-color/pull/147"},"issue":{"href":"https://api.github.com/repos/xiaokaike/vue-color/issues/147"},"comments":{"href":"https://api.github.com/repos/xiaokaike/vue-color/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/xiaokaike/vue-color/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xiaokaike/vue-color/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/xiaokaike/vue-color/statuses/75ce15fc28d6166bdca3ed540a2073c60dd4f623"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"linx4200","id":3954517,"node_id":"MDQ6VXNlcjM5NTQ1MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3954517?v=4","gravatar_id":"","url":"https://api.github.com/users/linx4200","html_url":"https://github.com/linx4200","followers_url":"https://api.github.com/users/linx4200/followers","following_url":"https://api.github.com/users/linx4200/following{/other_user}","gists_url":"https://api.github.com/users/linx4200/gists{/gist_id}","starred_url":"https://api.github.com/users/linx4200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linx4200/subscriptions","organizations_url":"https://api.github.com/users/linx4200/orgs","repos_url":"https://api.github.com/users/linx4200/repos","events_url":"https://api.github.com/users/linx4200/events{/privacy}","received_events_url":"https://api.github.com/users/linx4200/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"linx4200"}}