{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/202401223","pull_request_review_id":137093505,"id":202401223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQwMTIyMw==","diff_hunk":"@@ -72,6 +62,41 @@ protected void after() {\n     }\n   }\n \n+  private void startServer() {\n+    try {\n+      server = null;\n+      ClassLoader classLoader = Thread.currentThread().getContextClassLoader();\n+      String jmxPropertiesFile = classLoader.getResource(\"test.properties\").getPath();\n+      int jmxPort = AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);\n+      System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_PORT, Integer.toString(jmxPort));\n+      server = Server.createServer(jmxPort, jmxPropertiesFile, jsonAuthFile);\n+      server.start();\n+    } catch (Exception e) {\n+      throw new Error(e);\n+    }\n+  }\n+\n+  private void startJetty() throws Throwable {\n+    try {\n+      System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_HOST, LOCALHOST);\n+      System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED,\n+          String.valueOf(Boolean.TRUE));\n+\n+      int httpPort = AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);\n+      jetty = JettyHelper.initJetty(LOCALHOST, httpPort, new SSLConfig());\n+      JettyHelper.addWebApplication(jetty, PULSE_CONTEXT, getPulseWarPath(), null, null);\n+      pulseURL = \"http://\" + LOCALHOST + \":\" + httpPort + PULSE_CONTEXT;\n+      System.out.println(\"Pulse started at \" + pulseURL);\n+\n+      if (jetty != null) {\n+        jetty.start();\n+      }\n+    } catch (Exception e) {\n+      throw new Error(e);\n+    }\n+  }\n+\n+  // Until we straighten out the Server Code properly, this should be commented out.","path":"geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java","position":83,"original_position":83,"commit_id":"cc50f16d1866cd6a0bd5e7723d50efcf6faea194","original_commit_id":"cc50f16d1866cd6a0bd5e7723d50efcf6faea194","user":{"login":"mcmellawatt","id":1082688,"node_id":"MDQ6VXNlcjEwODI2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1082688?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmellawatt","html_url":"https://github.com/mcmellawatt","followers_url":"https://api.github.com/users/mcmellawatt/followers","following_url":"https://api.github.com/users/mcmellawatt/following{/other_user}","gists_url":"https://api.github.com/users/mcmellawatt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmellawatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmellawatt/subscriptions","organizations_url":"https://api.github.com/users/mcmellawatt/orgs","repos_url":"https://api.github.com/users/mcmellawatt/repos","events_url":"https://api.github.com/users/mcmellawatt/events{/privacy}","received_events_url":"https://api.github.com/users/mcmellawatt/received_events","type":"User","site_admin":false},"body":"Not sure I understand this comment.  What should be commented out?  I don't see anything commented out","created_at":"2018-07-13T16:11:16Z","updated_at":"2018-07-13T16:36:59Z","html_url":"https://github.com/apache/geode/pull/2136#discussion_r202401223","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/2136","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/202401223"},"html":{"href":"https://github.com/apache/geode/pull/2136#discussion_r202401223"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/2136"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2136","id":201127261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTI3MjYx","html_url":"https://github.com/apache/geode/pull/2136","diff_url":"https://github.com/apache/geode/pull/2136.diff","patch_url":"https://github.com/apache/geode/pull/2136.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2136","number":2136,"state":"open","locked":false,"title":"GEODE-5396: A bit of restructuring and a bit of cleanup to isolate fa…","user":{"login":"mhansonp","id":26558973,"node_id":"MDQ6VXNlcjI2NTU4OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/26558973?v=4","gravatar_id":"","url":"https://api.github.com/users/mhansonp","html_url":"https://github.com/mhansonp","followers_url":"https://api.github.com/users/mhansonp/followers","following_url":"https://api.github.com/users/mhansonp/following{/other_user}","gists_url":"https://api.github.com/users/mhansonp/gists{/gist_id}","starred_url":"https://api.github.com/users/mhansonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhansonp/subscriptions","organizations_url":"https://api.github.com/users/mhansonp/orgs","repos_url":"https://api.github.com/users/mhansonp/repos","events_url":"https://api.github.com/users/mhansonp/events{/privacy}","received_events_url":"https://api.github.com/users/mhansonp/received_events","type":"User","site_admin":false},"body":"…ilures better\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2018-07-12T21:12:22Z","updated_at":"2018-07-13T16:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe8a19928f3bad539fcb3909c30ed02e0b12e26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2136/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2136/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2136/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/cc50f16d1866cd6a0bd5e7723d50efcf6faea194","head":{"label":"mhansonp:pulseTestImprovements","ref":"pulseTestImprovements","sha":"cc50f16d1866cd6a0bd5e7723d50efcf6faea194","user":{"login":"mhansonp","id":26558973,"node_id":"MDQ6VXNlcjI2NTU4OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/26558973?v=4","gravatar_id":"","url":"https://api.github.com/users/mhansonp","html_url":"https://github.com/mhansonp","followers_url":"https://api.github.com/users/mhansonp/followers","following_url":"https://api.github.com/users/mhansonp/following{/other_user}","gists_url":"https://api.github.com/users/mhansonp/gists{/gist_id}","starred_url":"https://api.github.com/users/mhansonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhansonp/subscriptions","organizations_url":"https://api.github.com/users/mhansonp/orgs","repos_url":"https://api.github.com/users/mhansonp/repos","events_url":"https://api.github.com/users/mhansonp/events{/privacy}","received_events_url":"https://api.github.com/users/mhansonp/received_events","type":"User","site_admin":false},"repo":{"id":134621698,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MjE2OTg=","name":"geode","full_name":"mhansonp/geode","owner":{"login":"mhansonp","id":26558973,"node_id":"MDQ6VXNlcjI2NTU4OTcz","avatar_url":"https://avatars1.githubusercontent.com/u/26558973?v=4","gravatar_id":"","url":"https://api.github.com/users/mhansonp","html_url":"https://github.com/mhansonp","followers_url":"https://api.github.com/users/mhansonp/followers","following_url":"https://api.github.com/users/mhansonp/following{/other_user}","gists_url":"https://api.github.com/users/mhansonp/gists{/gist_id}","starred_url":"https://api.github.com/users/mhansonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhansonp/subscriptions","organizations_url":"https://api.github.com/users/mhansonp/orgs","repos_url":"https://api.github.com/users/mhansonp/repos","events_url":"https://api.github.com/users/mhansonp/events{/privacy}","received_events_url":"https://api.github.com/users/mhansonp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhansonp/geode","description":"Apache Geode","fork":true,"url":"https://api.github.com/repos/mhansonp/geode","forks_url":"https://api.github.com/repos/mhansonp/geode/forks","keys_url":"https://api.github.com/repos/mhansonp/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhansonp/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhansonp/geode/teams","hooks_url":"https://api.github.com/repos/mhansonp/geode/hooks","issue_events_url":"https://api.github.com/repos/mhansonp/geode/issues/events{/number}","events_url":"https://api.github.com/repos/mhansonp/geode/events","assignees_url":"https://api.github.com/repos/mhansonp/geode/assignees{/user}","branches_url":"https://api.github.com/repos/mhansonp/geode/branches{/branch}","tags_url":"https://api.github.com/repos/mhansonp/geode/tags","blobs_url":"https://api.github.com/repos/mhansonp/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhansonp/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhansonp/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhansonp/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhansonp/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/mhansonp/geode/languages","stargazers_url":"https://api.github.com/repos/mhansonp/geode/stargazers","contributors_url":"https://api.github.com/repos/mhansonp/geode/contributors","subscribers_url":"https://api.github.com/repos/mhansonp/geode/subscribers","subscription_url":"https://api.github.com/repos/mhansonp/geode/subscription","commits_url":"https://api.github.com/repos/mhansonp/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhansonp/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhansonp/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhansonp/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhansonp/geode/contents/{+path}","compare_url":"https://api.github.com/repos/mhansonp/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhansonp/geode/merges","archive_url":"https://api.github.com/repos/mhansonp/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhansonp/geode/downloads","issues_url":"https://api.github.com/repos/mhansonp/geode/issues{/number}","pulls_url":"https://api.github.com/repos/mhansonp/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/mhansonp/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/mhansonp/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhansonp/geode/labels{/name}","releases_url":"https://api.github.com/repos/mhansonp/geode/releases{/id}","deployments_url":"https://api.github.com/repos/mhansonp/geode/deployments","created_at":"2018-05-23T20:24:18Z","updated_at":"2018-05-23T20:24:36Z","pushed_at":"2018-07-12T21:11:38Z","git_url":"git://github.com/mhansonp/geode.git","ssh_url":"git@github.com:mhansonp/geode.git","clone_url":"https://github.com/mhansonp/geode.git","svn_url":"https://github.com/mhansonp/geode","homepage":"","size":153976,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"84e911cb22097319aa1130fdd02a57d0354c9cc4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-07-13T16:05:37Z","pushed_at":"2018-07-13T16:05:31Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":154244,"stargazers_count":1281,"watchers_count":1281,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":447,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":447,"open_issues":31,"watchers":1281,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2136"},"html":{"href":"https://github.com/apache/geode/pull/2136"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2136"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2136/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2136/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2136/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/cc50f16d1866cd6a0bd5e7723d50efcf6faea194"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcmellawatt"}}