{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/226835757","pull_request_review_id":166758125,"id":226835757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjgzNTc1Nw==","diff_hunk":"@@ -1,5 +1,6 @@\n \n import os\n+import subprocess","path":"build/osx/otool.py","position":3,"original_position":3,"commit_id":"1622db8140235b0253ecaf47cec2634336de168d","original_commit_id":"1622db8140235b0253ecaf47cec2634336de168d","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Consider possible security implications associated with subprocess module.](https://app.codacy.com/app/mixxxdj/mixxx/pullRequest?prid=2401276)","created_at":"2018-10-20T18:32:57Z","updated_at":"2018-10-20T18:32:57Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1854#discussion_r226835757","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/226835757"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1854#discussion_r226835757"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854","id":224491933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDkxOTMz","html_url":"https://github.com/mixxxdj/mixxx/pull/1854","diff_url":"https://github.com/mixxxdj/mixxx/pull/1854.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1854.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1854","number":1854,"state":"open","locked":false,"title":"Only create a QGLWidget if safeMode is not enabled.","user":{"login":"sgielen","id":328769,"node_id":"MDQ6VXNlcjMyODc2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/328769?v=4","gravatar_id":"","url":"https://api.github.com/users/sgielen","html_url":"https://github.com/sgielen","followers_url":"https://api.github.com/users/sgielen/followers","following_url":"https://api.github.com/users/sgielen/following{/other_user}","gists_url":"https://api.github.com/users/sgielen/gists{/gist_id}","starred_url":"https://api.github.com/users/sgielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgielen/subscriptions","organizations_url":"https://api.github.com/users/sgielen/orgs","repos_url":"https://api.github.com/users/sgielen/repos","events_url":"https://api.github.com/users/sgielen/events{/privacy}","received_events_url":"https://api.github.com/users/sgielen/received_events","type":"User","site_admin":false},"body":"safeMode is intended to start Mixxx even when there are problems with OpenGL.\r\nSo, if safeMode is enabled, a QGLWidget should not be created, because it\r\ninitializes OpenGL.","created_at":"2018-10-20T18:18:04Z","updated_at":"2018-10-20T18:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"024f51366afbb6606c3c27cab6a9306eae09a963","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1854/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/1622db8140235b0253ecaf47cec2634336de168d","head":{"label":"sgielen:safemode-opengl","ref":"safemode-opengl","sha":"1622db8140235b0253ecaf47cec2634336de168d","user":{"login":"sgielen","id":328769,"node_id":"MDQ6VXNlcjMyODc2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/328769?v=4","gravatar_id":"","url":"https://api.github.com/users/sgielen","html_url":"https://github.com/sgielen","followers_url":"https://api.github.com/users/sgielen/followers","following_url":"https://api.github.com/users/sgielen/following{/other_user}","gists_url":"https://api.github.com/users/sgielen/gists{/gist_id}","starred_url":"https://api.github.com/users/sgielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgielen/subscriptions","organizations_url":"https://api.github.com/users/sgielen/orgs","repos_url":"https://api.github.com/users/sgielen/repos","events_url":"https://api.github.com/users/sgielen/events{/privacy}","received_events_url":"https://api.github.com/users/sgielen/received_events","type":"User","site_admin":false},"repo":{"id":153934447,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5MzQ0NDc=","name":"mixxx","full_name":"sgielen/mixxx","private":false,"owner":{"login":"sgielen","id":328769,"node_id":"MDQ6VXNlcjMyODc2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/328769?v=4","gravatar_id":"","url":"https://api.github.com/users/sgielen","html_url":"https://github.com/sgielen","followers_url":"https://api.github.com/users/sgielen/followers","following_url":"https://api.github.com/users/sgielen/following{/other_user}","gists_url":"https://api.github.com/users/sgielen/gists{/gist_id}","starred_url":"https://api.github.com/users/sgielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgielen/subscriptions","organizations_url":"https://api.github.com/users/sgielen/orgs","repos_url":"https://api.github.com/users/sgielen/repos","events_url":"https://api.github.com/users/sgielen/events{/privacy}","received_events_url":"https://api.github.com/users/sgielen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sgielen/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/sgielen/mixxx","forks_url":"https://api.github.com/repos/sgielen/mixxx/forks","keys_url":"https://api.github.com/repos/sgielen/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgielen/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgielen/mixxx/teams","hooks_url":"https://api.github.com/repos/sgielen/mixxx/hooks","issue_events_url":"https://api.github.com/repos/sgielen/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/sgielen/mixxx/events","assignees_url":"https://api.github.com/repos/sgielen/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/sgielen/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/sgielen/mixxx/tags","blobs_url":"https://api.github.com/repos/sgielen/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgielen/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgielen/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgielen/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgielen/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/sgielen/mixxx/languages","stargazers_url":"https://api.github.com/repos/sgielen/mixxx/stargazers","contributors_url":"https://api.github.com/repos/sgielen/mixxx/contributors","subscribers_url":"https://api.github.com/repos/sgielen/mixxx/subscribers","subscription_url":"https://api.github.com/repos/sgielen/mixxx/subscription","commits_url":"https://api.github.com/repos/sgielen/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgielen/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgielen/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgielen/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgielen/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/sgielen/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgielen/mixxx/merges","archive_url":"https://api.github.com/repos/sgielen/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgielen/mixxx/downloads","issues_url":"https://api.github.com/repos/sgielen/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/sgielen/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/sgielen/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/sgielen/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgielen/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/sgielen/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/sgielen/mixxx/deployments","created_at":"2018-10-20T18:11:20Z","updated_at":"2018-10-20T18:11:34Z","pushed_at":"2018-10-20T18:17:52Z","git_url":"git://github.com/sgielen/mixxx.git","ssh_url":"git@github.com:sgielen/mixxx.git","clone_url":"https://github.com/sgielen/mixxx.git","svn_url":"https://github.com/sgielen/mixxx","homepage":"http://mixxx.org","size":296974,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:2.2","ref":"2.2","sha":"1cac3e05fcac92deab101532daef83be252841fc","user":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjAzMQ==","name":"mixxx","full_name":"mixxxdj/mixxx","private":false,"owner":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-10-20T12:59:46Z","pushed_at":"2018-10-20T18:26:39Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":296974,"stargazers_count":1142,"watchers_count":1142,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":536,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":536,"open_issues":92,"watchers":1142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1854"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1854"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1854/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1854/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/1622db8140235b0253ecaf47cec2634336de168d"}},"author_association":"NONE"}}
{"actor":{"display_login":"codacy-bot"}}