{"action":"closed","number":4189,"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189","id":201523985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTIzOTg1","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4189","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4189.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4189.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4189","number":4189,"state":"closed","locked":false,"title":"Fix type name resolution and implement short form properties in COM collector.","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"body":"Closes #3326\r\nPartially addresses #4096\r\n\r\n**IMPORTANT:**   This PR does _not_ update the serialized declarations used by the unit tests. At some point these apparently became stale, so 34 tests are failing with the new declarations. I will PR the new declarations when #4182 is resolved.\r\n\r\n@Future: If you make any changes that effect the behavior of the COM collection, you **HAVE TO** update the serialized declarations files for the unit tests. If you don't, it basically invalidates the tests and potentially masks bugs.","created_at":"2018-07-16T00:40:17Z","updated_at":"2018-07-16T03:06:38Z","closed_at":"2018-07-16T03:06:38Z","merged_at":"2018-07-16T03:06:38Z","merge_commit_sha":"f05357f2653a25c3faacf79c5c33408770f6525b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4189/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/aa7bfdbea4e33fc3660b43073d52a6dd3cdd4e11","head":{"label":"comintern:next","ref":"next","sha":"aa7bfdbea4e33fc3660b43073d52a6dd3cdd4e11","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"repo":{"id":55346398,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM0NjM5OA==","name":"Rubberduck","full_name":"comintern/Rubberduck","owner":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comintern/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/comintern/Rubberduck","forks_url":"https://api.github.com/repos/comintern/Rubberduck/forks","keys_url":"https://api.github.com/repos/comintern/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comintern/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comintern/Rubberduck/teams","hooks_url":"https://api.github.com/repos/comintern/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/comintern/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/comintern/Rubberduck/events","assignees_url":"https://api.github.com/repos/comintern/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/comintern/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/comintern/Rubberduck/tags","blobs_url":"https://api.github.com/repos/comintern/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comintern/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comintern/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/comintern/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comintern/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/comintern/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/comintern/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/comintern/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/comintern/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/comintern/Rubberduck/subscription","commits_url":"https://api.github.com/repos/comintern/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/comintern/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/comintern/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/comintern/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/comintern/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/comintern/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comintern/Rubberduck/merges","archive_url":"https://api.github.com/repos/comintern/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comintern/Rubberduck/downloads","issues_url":"https://api.github.com/repos/comintern/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/comintern/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/comintern/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/comintern/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comintern/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/comintern/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/comintern/Rubberduck/deployments","created_at":"2016-04-03T12:57:26Z","updated_at":"2018-07-16T02:32:18Z","pushed_at":"2018-07-16T02:32:15Z","git_url":"git://github.com/comintern/Rubberduck.git","ssh_url":"git@github.com:comintern/Rubberduck.git","clone_url":"https://github.com/comintern/Rubberduck.git","svn_url":"https://github.com/comintern/Rubberduck","homepage":"","size":65208,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"93f51434821ddf0f6ab13ee3f1e30f1003690bad","user":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgwMDEyOA==","name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","owner":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2018-07-16T03:03:36Z","pushed_at":"2018-07-16T03:06:38Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":63884,"stargazers_count":615,"watchers_count":615,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":737,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":156,"open_issues":737,"watchers":615,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4189"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4189"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4189/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4189/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/aa7bfdbea4e33fc3660b43073d52a6dd3cdd4e11"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"retailcoder","id":5751684,"node_id":"MDQ6VXNlcjU3NTE2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5751684?v=4","gravatar_id":"","url":"https://api.github.com/users/retailcoder","html_url":"https://github.com/retailcoder","followers_url":"https://api.github.com/users/retailcoder/followers","following_url":"https://api.github.com/users/retailcoder/following{/other_user}","gists_url":"https://api.github.com/users/retailcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/retailcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retailcoder/subscriptions","organizations_url":"https://api.github.com/users/retailcoder/orgs","repos_url":"https://api.github.com/users/retailcoder/repos","events_url":"https://api.github.com/users/retailcoder/events{/privacy}","received_events_url":"https://api.github.com/users/retailcoder/received_events","type":"User","site_admin":false},"comments":3,"review_comments":9,"maintainer_can_modify":false,"commits":7,"additions":391,"deletions":138,"changed_files":15}}
{"actor":{"display_login":"retailcoder"}}