{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/comments/173465262","pull_request_review_id":102664844,"id":173465262,"diff_hunk":"@@ -18,24 +18,36 @@ public class LogValuesFormatter\n         private const string NullValue = \"(null)\";\n         private static readonly object[] EmptyArray = new object[0];\n         private static readonly char[] FormatDelimiters = {',', ':'};\n-        private readonly string _format;\n+        private readonly Lazy<string> _format;\n         private readonly List<string> _valueNames = new List<string>();\n \n         public LogValuesFormatter(string format)\n         {\n             OriginalFormat = format;\n+            _format = new Lazy<string>(() => FormatInput(format), true);\n+        }\n+\n+        public string OriginalFormat { get; private set; }\n+        public List<string> ValueNames => _valueNames;","path":"src/Microsoft.Extensions.Logging.Abstractions/Internal/LogValuesFormatter.cs","position":null,"original_position":15,"commit_id":"d4fc812c8abe2f3fc5bd03a56876c6362f679bcb","original_commit_id":"ed2c3d30af68e0b4396772608409fb87667d12da","user":{"login":"d-saravanan","id":20381669,"avatar_url":"https://avatars0.githubusercontent.com/u/20381669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-saravanan","html_url":"https://github.com/d-saravanan","followers_url":"https://api.github.com/users/d-saravanan/followers","following_url":"https://api.github.com/users/d-saravanan/following{/other_user}","gists_url":"https://api.github.com/users/d-saravanan/gists{/gist_id}","starred_url":"https://api.github.com/users/d-saravanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-saravanan/subscriptions","organizations_url":"https://api.github.com/users/d-saravanan/orgs","repos_url":"https://api.github.com/users/d-saravanan/repos","events_url":"https://api.github.com/users/d-saravanan/events{/privacy}","received_events_url":"https://api.github.com/users/d-saravanan/received_events","type":"User","site_admin":false},"body":"refactored and checked-in. Please review the latest check-in and share review comments.","created_at":"2018-03-09T14:33:28Z","updated_at":"2018-03-09T14:33:28Z","html_url":"https://github.com/aspnet/Logging/pull/771#discussion_r173465262","pull_request_url":"https://api.github.com/repos/aspnet/Logging/pulls/771","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments/173465262"},"html":{"href":"https://github.com/aspnet/Logging/pull/771#discussion_r173465262"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/771"}},"in_reply_to_id":172252079},"pull_request":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/771","id":172665828,"html_url":"https://github.com/aspnet/Logging/pull/771","diff_url":"https://github.com/aspnet/Logging/pull/771.diff","patch_url":"https://github.com/aspnet/Logging/pull/771.patch","issue_url":"https://api.github.com/repos/aspnet/Logging/issues/771","number":771,"state":"open","locked":false,"title":"Constructor logic is refactored for the delayed execution of the placeholder refactoring algorithm","user":{"login":"d-saravanan","id":20381669,"avatar_url":"https://avatars0.githubusercontent.com/u/20381669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-saravanan","html_url":"https://github.com/d-saravanan","followers_url":"https://api.github.com/users/d-saravanan/followers","following_url":"https://api.github.com/users/d-saravanan/following{/other_user}","gists_url":"https://api.github.com/users/d-saravanan/gists{/gist_id}","starred_url":"https://api.github.com/users/d-saravanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-saravanan/subscriptions","organizations_url":"https://api.github.com/users/d-saravanan/orgs","repos_url":"https://api.github.com/users/d-saravanan/repos","events_url":"https://api.github.com/users/d-saravanan/events{/privacy}","received_events_url":"https://api.github.com/users/d-saravanan/received_events","type":"User","site_admin":false},"body":"**Summary**\r\nThis pull-request has the logic that will lazy initialize the `_format`  field so that when the `Format`  method is invoked with the arguments, the string is processed and then used for transformation. \r\nHence, there will be faster object construction and similar to that of the existing implementation..\r\n\r\nKindly review this and share your review comments. \r\n\r\nAddresses #763 ","created_at":"2018-03-03T12:46:05Z","updated_at":"2018-03-09T14:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eb3cd442b3ec4b0dc33a65f570d90ba90d428d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Logging/pulls/771/commits","review_comments_url":"https://api.github.com/repos/aspnet/Logging/pulls/771/comments","review_comment_url":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Logging/issues/771/comments","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/d4fc812c8abe2f3fc5bd03a56876c6362f679bcb","head":{"label":"d-saravanan:dev","ref":"dev","sha":"d4fc812c8abe2f3fc5bd03a56876c6362f679bcb","user":{"login":"d-saravanan","id":20381669,"avatar_url":"https://avatars0.githubusercontent.com/u/20381669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-saravanan","html_url":"https://github.com/d-saravanan","followers_url":"https://api.github.com/users/d-saravanan/followers","following_url":"https://api.github.com/users/d-saravanan/following{/other_user}","gists_url":"https://api.github.com/users/d-saravanan/gists{/gist_id}","starred_url":"https://api.github.com/users/d-saravanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-saravanan/subscriptions","organizations_url":"https://api.github.com/users/d-saravanan/orgs","repos_url":"https://api.github.com/users/d-saravanan/repos","events_url":"https://api.github.com/users/d-saravanan/events{/privacy}","received_events_url":"https://api.github.com/users/d-saravanan/received_events","type":"User","site_admin":false},"repo":{"id":123687523,"name":"Logging","full_name":"d-saravanan/Logging","owner":{"login":"d-saravanan","id":20381669,"avatar_url":"https://avatars0.githubusercontent.com/u/20381669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-saravanan","html_url":"https://github.com/d-saravanan","followers_url":"https://api.github.com/users/d-saravanan/followers","following_url":"https://api.github.com/users/d-saravanan/following{/other_user}","gists_url":"https://api.github.com/users/d-saravanan/gists{/gist_id}","starred_url":"https://api.github.com/users/d-saravanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-saravanan/subscriptions","organizations_url":"https://api.github.com/users/d-saravanan/orgs","repos_url":"https://api.github.com/users/d-saravanan/repos","events_url":"https://api.github.com/users/d-saravanan/events{/privacy}","received_events_url":"https://api.github.com/users/d-saravanan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-saravanan/Logging","description":"Common logging abstractions and a few implementations","fork":true,"url":"https://api.github.com/repos/d-saravanan/Logging","forks_url":"https://api.github.com/repos/d-saravanan/Logging/forks","keys_url":"https://api.github.com/repos/d-saravanan/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-saravanan/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-saravanan/Logging/teams","hooks_url":"https://api.github.com/repos/d-saravanan/Logging/hooks","issue_events_url":"https://api.github.com/repos/d-saravanan/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/d-saravanan/Logging/events","assignees_url":"https://api.github.com/repos/d-saravanan/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/d-saravanan/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/d-saravanan/Logging/tags","blobs_url":"https://api.github.com/repos/d-saravanan/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-saravanan/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-saravanan/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-saravanan/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-saravanan/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/d-saravanan/Logging/languages","stargazers_url":"https://api.github.com/repos/d-saravanan/Logging/stargazers","contributors_url":"https://api.github.com/repos/d-saravanan/Logging/contributors","subscribers_url":"https://api.github.com/repos/d-saravanan/Logging/subscribers","subscription_url":"https://api.github.com/repos/d-saravanan/Logging/subscription","commits_url":"https://api.github.com/repos/d-saravanan/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-saravanan/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-saravanan/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-saravanan/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-saravanan/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/d-saravanan/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-saravanan/Logging/merges","archive_url":"https://api.github.com/repos/d-saravanan/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-saravanan/Logging/downloads","issues_url":"https://api.github.com/repos/d-saravanan/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/d-saravanan/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/d-saravanan/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/d-saravanan/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-saravanan/Logging/labels{/name}","releases_url":"https://api.github.com/repos/d-saravanan/Logging/releases{/id}","deployments_url":"https://api.github.com/repos/d-saravanan/Logging/deployments","created_at":"2018-03-03T11:54:52Z","updated_at":"2018-03-03T11:54:54Z","pushed_at":"2018-03-09T14:28:43Z","git_url":"git://github.com/d-saravanan/Logging.git","ssh_url":"git@github.com:d-saravanan/Logging.git","clone_url":"https://github.com/d-saravanan/Logging.git","svn_url":"https://github.com/d-saravanan/Logging","homepage":"","size":1517,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"c85eb0fb4f080b804db5cd5f24de3cf1f20176e0","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15836601,"name":"Logging","full_name":"aspnet/Logging","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Logging","description":"Common logging abstractions and a few implementations","fork":false,"url":"https://api.github.com/repos/aspnet/Logging","forks_url":"https://api.github.com/repos/aspnet/Logging/forks","keys_url":"https://api.github.com/repos/aspnet/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Logging/teams","hooks_url":"https://api.github.com/repos/aspnet/Logging/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Logging/events","assignees_url":"https://api.github.com/repos/aspnet/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Logging/tags","blobs_url":"https://api.github.com/repos/aspnet/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Logging/languages","stargazers_url":"https://api.github.com/repos/aspnet/Logging/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Logging/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Logging/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Logging/subscription","commits_url":"https://api.github.com/repos/aspnet/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Logging/merges","archive_url":"https://api.github.com/repos/aspnet/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Logging/downloads","issues_url":"https://api.github.com/repos/aspnet/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Logging/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Logging/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Logging/deployments","created_at":"2014-01-12T04:46:28Z","updated_at":"2018-03-05T03:42:07Z","pushed_at":"2018-03-09T14:28:45Z","git_url":"git://github.com/aspnet/Logging.git","ssh_url":"git@github.com:aspnet/Logging.git","clone_url":"https://github.com/aspnet/Logging.git","svn_url":"https://github.com/aspnet/Logging","homepage":"","size":1520,"stargazers_count":412,"watchers_count":412,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":202,"open_issues":102,"watchers":412,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/771"},"html":{"href":"https://github.com/aspnet/Logging/pull/771"},"issue":{"href":"https://api.github.com/repos/aspnet/Logging/issues/771"},"comments":{"href":"https://api.github.com/repos/aspnet/Logging/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Logging/statuses/d4fc812c8abe2f3fc5bd03a56876c6362f679bcb"}},"author_association":"NONE"}}
{"actor":{"display_login":"d-saravanan"}}