{"action":"closed","number":2743,"pull_request":{"url":"https://api.github.com/repos/espressif/esp-idf/pulls/2743","id":233392802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzkyODAy","html_url":"https://github.com/espressif/esp-idf/pull/2743","diff_url":"https://github.com/espressif/esp-idf/pull/2743.diff","patch_url":"https://github.com/espressif/esp-idf/pull/2743.patch","issue_url":"https://api.github.com/repos/espressif/esp-idf/issues/2743","number":2743,"state":"closed","locked":false,"title":"Feature/pthread enhancement","user":{"login":"PerMalmberg","id":2729388,"node_id":"MDQ6VXNlcjI3MjkzODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2729388?v=4","gravatar_id":"","url":"https://api.github.com/users/PerMalmberg","html_url":"https://github.com/PerMalmberg","followers_url":"https://api.github.com/users/PerMalmberg/followers","following_url":"https://api.github.com/users/PerMalmberg/following{/other_user}","gists_url":"https://api.github.com/users/PerMalmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/PerMalmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerMalmberg/subscriptions","organizations_url":"https://api.github.com/users/PerMalmberg/orgs","repos_url":"https://api.github.com/users/PerMalmberg/repos","events_url":"https://api.github.com/users/PerMalmberg/events{/privacy}","received_events_url":"https://api.github.com/users/PerMalmberg/received_events","type":"User","site_admin":false},"body":"I had some time over while waiting for hardware to arrive so I implemented the ability to set the name and core affinity on pthreads and thus _std::thread_ as I originally [originally asked for](https://www.esp32.com/viewtopic.php?f=13&t=7919) on the forums.\r\n\r\nI'm sure @projectgus or @igrr will have something to say about default values etc.\r\n\r\nRe. `thread_name` member in `esp_pthread_cfg_t`: it had to be an array and thus taking up extra space. I see no other way to implement it without introducing a real risk of dangling pointers when `inherit_cfg` is used. I'm also not sure if `configMAX_TASK_NAME_LEN` includes the terminating null, i.e. if the +1 in `thread_name` declaration is needed or not.\r\n\r\nPerhaps the name shouldn't be part of the `esp_pthread_cfg_t` at all and another way of naming phreads should be used? I'm open to suggestions.","created_at":"2018-11-25T18:46:54Z","updated_at":"2018-12-05T14:04:50Z","closed_at":"2018-12-05T14:04:50Z","merged_at":"2018-12-05T14:04:50Z","merge_commit_sha":"71f57931bd41edcccb5f5fc1f82ce100e89c5dc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":505197532,"node_id":"MDU6TGFiZWw1MDUxOTc1MzI=","url":"https://api.github.com/repos/espressif/esp-idf/labels/merge%20pending","name":"merge pending","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/espressif/esp-idf/pulls/2743/commits","review_comments_url":"https://api.github.com/repos/espressif/esp-idf/pulls/2743/comments","review_comment_url":"https://api.github.com/repos/espressif/esp-idf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressif/esp-idf/issues/2743/comments","statuses_url":"https://api.github.com/repos/espressif/esp-idf/statuses/71f57931bd41edcccb5f5fc1f82ce100e89c5dc6","head":{"label":"PerMalmberg:feature/pthread-enhancement","ref":"feature/pthread-enhancement","sha":"71f57931bd41edcccb5f5fc1f82ce100e89c5dc6","user":{"login":"PerMalmberg","id":2729388,"node_id":"MDQ6VXNlcjI3MjkzODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2729388?v=4","gravatar_id":"","url":"https://api.github.com/users/PerMalmberg","html_url":"https://github.com/PerMalmberg","followers_url":"https://api.github.com/users/PerMalmberg/followers","following_url":"https://api.github.com/users/PerMalmberg/following{/other_user}","gists_url":"https://api.github.com/users/PerMalmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/PerMalmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerMalmberg/subscriptions","organizations_url":"https://api.github.com/users/PerMalmberg/orgs","repos_url":"https://api.github.com/users/PerMalmberg/repos","events_url":"https://api.github.com/users/PerMalmberg/events{/privacy}","received_events_url":"https://api.github.com/users/PerMalmberg/received_events","type":"User","site_admin":false},"repo":{"id":154010662,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMTA2NjI=","name":"esp-idf","full_name":"PerMalmberg/esp-idf","private":false,"owner":{"login":"PerMalmberg","id":2729388,"node_id":"MDQ6VXNlcjI3MjkzODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2729388?v=4","gravatar_id":"","url":"https://api.github.com/users/PerMalmberg","html_url":"https://github.com/PerMalmberg","followers_url":"https://api.github.com/users/PerMalmberg/followers","following_url":"https://api.github.com/users/PerMalmberg/following{/other_user}","gists_url":"https://api.github.com/users/PerMalmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/PerMalmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerMalmberg/subscriptions","organizations_url":"https://api.github.com/users/PerMalmberg/orgs","repos_url":"https://api.github.com/users/PerMalmberg/repos","events_url":"https://api.github.com/users/PerMalmberg/events{/privacy}","received_events_url":"https://api.github.com/users/PerMalmberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PerMalmberg/esp-idf","description":"Espressif IoT Development Framework. Official development framework for ESP32.","fork":true,"url":"https://api.github.com/repos/PerMalmberg/esp-idf","forks_url":"https://api.github.com/repos/PerMalmberg/esp-idf/forks","keys_url":"https://api.github.com/repos/PerMalmberg/esp-idf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerMalmberg/esp-idf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerMalmberg/esp-idf/teams","hooks_url":"https://api.github.com/repos/PerMalmberg/esp-idf/hooks","issue_events_url":"https://api.github.com/repos/PerMalmberg/esp-idf/issues/events{/number}","events_url":"https://api.github.com/repos/PerMalmberg/esp-idf/events","assignees_url":"https://api.github.com/repos/PerMalmberg/esp-idf/assignees{/user}","branches_url":"https://api.github.com/repos/PerMalmberg/esp-idf/branches{/branch}","tags_url":"https://api.github.com/repos/PerMalmberg/esp-idf/tags","blobs_url":"https://api.github.com/repos/PerMalmberg/esp-idf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerMalmberg/esp-idf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerMalmberg/esp-idf/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerMalmberg/esp-idf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerMalmberg/esp-idf/statuses/{sha}","languages_url":"https://api.github.com/repos/PerMalmberg/esp-idf/languages","stargazers_url":"https://api.github.com/repos/PerMalmberg/esp-idf/stargazers","contributors_url":"https://api.github.com/repos/PerMalmberg/esp-idf/contributors","subscribers_url":"https://api.github.com/repos/PerMalmberg/esp-idf/subscribers","subscription_url":"https://api.github.com/repos/PerMalmberg/esp-idf/subscription","commits_url":"https://api.github.com/repos/PerMalmberg/esp-idf/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerMalmberg/esp-idf/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerMalmberg/esp-idf/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerMalmberg/esp-idf/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerMalmberg/esp-idf/contents/{+path}","compare_url":"https://api.github.com/repos/PerMalmberg/esp-idf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerMalmberg/esp-idf/merges","archive_url":"https://api.github.com/repos/PerMalmberg/esp-idf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerMalmberg/esp-idf/downloads","issues_url":"https://api.github.com/repos/PerMalmberg/esp-idf/issues{/number}","pulls_url":"https://api.github.com/repos/PerMalmberg/esp-idf/pulls{/number}","milestones_url":"https://api.github.com/repos/PerMalmberg/esp-idf/milestones{/number}","notifications_url":"https://api.github.com/repos/PerMalmberg/esp-idf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerMalmberg/esp-idf/labels{/name}","releases_url":"https://api.github.com/repos/PerMalmberg/esp-idf/releases{/id}","deployments_url":"https://api.github.com/repos/PerMalmberg/esp-idf/deployments","created_at":"2018-10-21T13:21:34Z","updated_at":"2018-11-24T12:09:20Z","pushed_at":"2018-11-28T19:45:14Z","git_url":"git://github.com/PerMalmberg/esp-idf.git","ssh_url":"git@github.com:PerMalmberg/esp-idf.git","clone_url":"https://github.com/PerMalmberg/esp-idf.git","svn_url":"https://github.com/PerMalmberg/esp-idf","homepage":"","size":67934,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressif:master","ref":"master","sha":"cc5673435be92c4beceb7108c738d6741ea7230f","user":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"repo":{"id":65899476,"node_id":"MDEwOlJlcG9zaXRvcnk2NTg5OTQ3Ng==","name":"esp-idf","full_name":"espressif/esp-idf","private":false,"owner":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espressif/esp-idf","description":"Espressif IoT Development Framework. Official development framework for ESP32.","fork":false,"url":"https://api.github.com/repos/espressif/esp-idf","forks_url":"https://api.github.com/repos/espressif/esp-idf/forks","keys_url":"https://api.github.com/repos/espressif/esp-idf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressif/esp-idf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressif/esp-idf/teams","hooks_url":"https://api.github.com/repos/espressif/esp-idf/hooks","issue_events_url":"https://api.github.com/repos/espressif/esp-idf/issues/events{/number}","events_url":"https://api.github.com/repos/espressif/esp-idf/events","assignees_url":"https://api.github.com/repos/espressif/esp-idf/assignees{/user}","branches_url":"https://api.github.com/repos/espressif/esp-idf/branches{/branch}","tags_url":"https://api.github.com/repos/espressif/esp-idf/tags","blobs_url":"https://api.github.com/repos/espressif/esp-idf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressif/esp-idf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressif/esp-idf/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressif/esp-idf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressif/esp-idf/statuses/{sha}","languages_url":"https://api.github.com/repos/espressif/esp-idf/languages","stargazers_url":"https://api.github.com/repos/espressif/esp-idf/stargazers","contributors_url":"https://api.github.com/repos/espressif/esp-idf/contributors","subscribers_url":"https://api.github.com/repos/espressif/esp-idf/subscribers","subscription_url":"https://api.github.com/repos/espressif/esp-idf/subscription","commits_url":"https://api.github.com/repos/espressif/esp-idf/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressif/esp-idf/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressif/esp-idf/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressif/esp-idf/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressif/esp-idf/contents/{+path}","compare_url":"https://api.github.com/repos/espressif/esp-idf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressif/esp-idf/merges","archive_url":"https://api.github.com/repos/espressif/esp-idf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressif/esp-idf/downloads","issues_url":"https://api.github.com/repos/espressif/esp-idf/issues{/number}","pulls_url":"https://api.github.com/repos/espressif/esp-idf/pulls{/number}","milestones_url":"https://api.github.com/repos/espressif/esp-idf/milestones{/number}","notifications_url":"https://api.github.com/repos/espressif/esp-idf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressif/esp-idf/labels{/name}","releases_url":"https://api.github.com/repos/espressif/esp-idf/releases{/id}","deployments_url":"https://api.github.com/repos/espressif/esp-idf/deployments","created_at":"2016-08-17T10:40:35Z","updated_at":"2018-12-05T13:53:23Z","pushed_at":"2018-12-05T14:04:36Z","git_url":"git://github.com/espressif/esp-idf.git","ssh_url":"git@github.com:espressif/esp-idf.git","clone_url":"https://github.com/espressif/esp-idf.git","svn_url":"https://github.com/espressif/esp-idf","homepage":"","size":68667,"stargazers_count":2615,"watchers_count":2615,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1411,"mirror_url":null,"archived":false,"open_issues_count":461,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1411,"open_issues":461,"watchers":2615,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/2743"},"html":{"href":"https://github.com/espressif/esp-idf/pull/2743"},"issue":{"href":"https://api.github.com/repos/espressif/esp-idf/issues/2743"},"comments":{"href":"https://api.github.com/repos/espressif/esp-idf/issues/2743/comments"},"review_comments":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/2743/comments"},"review_comment":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/2743/commits"},"statuses":{"href":"https://api.github.com/repos/espressif/esp-idf/statuses/71f57931bd41edcccb5f5fc1f82ce100e89c5dc6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"igrr","id":4349050,"node_id":"MDQ6VXNlcjQzNDkwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4349050?v=4","gravatar_id":"","url":"https://api.github.com/users/igrr","html_url":"https://github.com/igrr","followers_url":"https://api.github.com/users/igrr/followers","following_url":"https://api.github.com/users/igrr/following{/other_user}","gists_url":"https://api.github.com/users/igrr/gists{/gist_id}","starred_url":"https://api.github.com/users/igrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrr/subscriptions","organizations_url":"https://api.github.com/users/igrr/orgs","repos_url":"https://api.github.com/users/igrr/repos","events_url":"https://api.github.com/users/igrr/events{/privacy}","received_events_url":"https://api.github.com/users/igrr/received_events","type":"User","site_admin":false},"comments":5,"review_comments":28,"maintainer_can_modify":false,"commits":1,"additions":242,"deletions":11,"changed_files":10}}
{"actor":{"display_login":"igrr"}}