{"action":"created","issue":{"url":"https://api.github.com/repos/varvet/pundit/issues/473","repository_url":"https://api.github.com/repos/varvet/pundit","labels_url":"https://api.github.com/repos/varvet/pundit/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/varvet/pundit/issues/473/comments","events_url":"https://api.github.com/repos/varvet/pundit/issues/473/events","html_url":"https://github.com/varvet/pundit/pull/473","id":243265494,"number":473,"title":"Refactor policy generator","user":{"login":"yhirano55","id":15371677,"avatar_url":"https://avatars3.githubusercontent.com/u/15371677?v=4","gravatar_id":"","url":"https://api.github.com/users/yhirano55","html_url":"https://github.com/yhirano55","followers_url":"https://api.github.com/users/yhirano55/followers","following_url":"https://api.github.com/users/yhirano55/following{/other_user}","gists_url":"https://api.github.com/users/yhirano55/gists{/gist_id}","starred_url":"https://api.github.com/users/yhirano55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhirano55/subscriptions","organizations_url":"https://api.github.com/users/yhirano55/orgs","repos_url":"https://api.github.com/users/yhirano55/repos","events_url":"https://api.github.com/users/yhirano55/events{/privacy}","received_events_url":"https://api.github.com/users/yhirano55/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-16T20:50:34Z","updated_at":"2018-05-15T11:15:47Z","closed_at":"2018-05-15T11:15:47Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/varvet/pundit/pulls/473","html_url":"https://github.com/varvet/pundit/pull/473","diff_url":"https://github.com/varvet/pundit/pull/473.diff","patch_url":"https://github.com/varvet/pundit/pull/473.patch"},"body":"I've refactored policy generators:\r\n\r\n- Changed generator namespace from `rails g pundit:policy something` to `rails g policy something`. Because I think that Policy is custom layer for Rails application same as Decorator ([active_decorator](https://github.com/amatsuda/active_decorator#usage), [draper](https://github.com/drapergem/draper#generators)). How about it?\r\n- Refactored source_root\r\n- chmod -x\r\n- Updated `README`\r\n\r\nPlease let me know if you have advice or questions. Thanks a lot!"},"comment":{"url":"https://api.github.com/repos/varvet/pundit/issues/comments/389130829","html_url":"https://github.com/varvet/pundit/pull/473#issuecomment-389130829","issue_url":"https://api.github.com/repos/varvet/pundit/issues/473","id":389130829,"user":{"login":"Linuus","id":379823,"avatar_url":"https://avatars2.githubusercontent.com/u/379823?v=4","gravatar_id":"","url":"https://api.github.com/users/Linuus","html_url":"https://github.com/Linuus","followers_url":"https://api.github.com/users/Linuus/followers","following_url":"https://api.github.com/users/Linuus/following{/other_user}","gists_url":"https://api.github.com/users/Linuus/gists{/gist_id}","starred_url":"https://api.github.com/users/Linuus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linuus/subscriptions","organizations_url":"https://api.github.com/users/Linuus/orgs","repos_url":"https://api.github.com/users/Linuus/repos","events_url":"https://api.github.com/users/Linuus/events{/privacy}","received_events_url":"https://api.github.com/users/Linuus/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T11:15:47Z","updated_at":"2018-05-15T11:15:47Z","author_association":"MEMBER","body":"@yhirano55 Thank you for your contribution!\r\n\r\nI agree with @dgmstuart that this should be split in two PRs. I'm 👍  on the `source_route` refactoring but not sure on the namespace change. I like that it's clear that the generator is related to pundit.\r\n\r\nIf you make it a separate PR we can discuss it there though.\r\n\r\nI'll close this and look forward to a new PR (or two ;) )."}}
{"actor":{"display_login":"Linuus"}}