{"action":"created","comment":{"url":"https://api.github.com/repos/uptick/react-object-list/pulls/comments/195268160","pull_request_review_id":128601161,"id":195268160,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI2ODE2MA==","diff_hunk":"@@ -93,36 +93,144 @@ exports[`Choice Snapshots renders with options 1`] = `\n   }\n   placeholder=\"Any value\"\n   value={44}\n-  valueKey=\"value\"\n />\n `;\n \n exports[`Choice Snapshots renders with placeholder 1`] = `\n <Select\n   className=\"objectlist-current-filter__active-status\"\n-  labelKey=\"label\"\n+  getOptionLabel={[Function]}\n+  getOptionValue={[Function]}\n+  isMulti={false}\n   loadOptions={undefined}\n-  multi={false}\n   onChange={[Function]}\n-  optionRenderer={null}\n   options={Array []}\n   placeholder=\"Testing testing\"\n   value={44}\n-  valueKey=\"value\"\n />\n `;\n \n exports[`Choice Snapshots renders with remote options 1`] = `\n-<Select.Async\n-  className=\"objectlist-current-filter__active-status\"\n-  labelKey=\"label\"\n-  loadOptions={[MockFunction]}\n-  multi={false}\n-  onChange={[Function]}\n-  optionRenderer={null}\n-  options={Array []}\n-  placeholder=\"Any value\"\n-  value={44}\n-  valueKey=\"value\"\n-/>\n+<div","path":"src/filters/types/__tests__/__snapshots__/Choice.test.js.snap","position":149,"original_position":149,"commit_id":"35d3e11f0aa0a2257bedb17150e81f9556a1966e","original_commit_id":"35d3e11f0aa0a2257bedb17150e81f9556a1966e","user":{"login":"scaredcat","id":19770543,"node_id":"MDQ6VXNlcjE5NzcwNTQz","avatar_url":"https://avatars3.githubusercontent.com/u/19770543?v=4","gravatar_id":"","url":"https://api.github.com/users/scaredcat","html_url":"https://github.com/scaredcat","followers_url":"https://api.github.com/users/scaredcat/followers","following_url":"https://api.github.com/users/scaredcat/following{/other_user}","gists_url":"https://api.github.com/users/scaredcat/gists{/gist_id}","starred_url":"https://api.github.com/users/scaredcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaredcat/subscriptions","organizations_url":"https://api.github.com/users/scaredcat/orgs","repos_url":"https://api.github.com/users/scaredcat/repos","events_url":"https://api.github.com/users/scaredcat/events{/privacy}","received_events_url":"https://api.github.com/users/scaredcat/received_events","type":"User","site_admin":false},"body":"Yup. Can create a mock for the new `Select.js` component as well to cover this case, similar to:\r\nhttps://github.com/uptick/react-object-list/blob/master/__mocks__/react-select.js","created_at":"2018-06-13T23:44:02Z","updated_at":"2018-06-13T23:44:15Z","html_url":"https://github.com/uptick/react-object-list/pull/58#discussion_r195268160","pull_request_url":"https://api.github.com/repos/uptick/react-object-list/pulls/58","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/comments/195268160"},"html":{"href":"https://github.com/uptick/react-object-list/pull/58#discussion_r195268160"},"pull_request":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/58"}},"in_reply_to_id":194923942},"pull_request":{"url":"https://api.github.com/repos/uptick/react-object-list/pulls/58","id":193174613,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTc0NjEz","html_url":"https://github.com/uptick/react-object-list/pull/58","diff_url":"https://github.com/uptick/react-object-list/pull/58.diff","patch_url":"https://github.com/uptick/react-object-list/pull/58.patch","issue_url":"https://api.github.com/repos/uptick/react-object-list/issues/58","number":58,"state":"open","locked":false,"title":"Upgrade to react-select v2","user":{"login":"furious-luke","id":561722,"node_id":"MDQ6VXNlcjU2MTcyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/561722?v=4","gravatar_id":"","url":"https://api.github.com/users/furious-luke","html_url":"https://github.com/furious-luke","followers_url":"https://api.github.com/users/furious-luke/followers","following_url":"https://api.github.com/users/furious-luke/following{/other_user}","gists_url":"https://api.github.com/users/furious-luke/gists{/gist_id}","starred_url":"https://api.github.com/users/furious-luke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furious-luke/subscriptions","organizations_url":"https://api.github.com/users/furious-luke/orgs","repos_url":"https://api.github.com/users/furious-luke/repos","events_url":"https://api.github.com/users/furious-luke/events{/privacy}","received_events_url":"https://api.github.com/users/furious-luke/received_events","type":"User","site_admin":false},"body":"Workforce is upgrading to `react-select` v2, and so we need to bump `react-object-list` too. I've used the same approach as for Workforce; create a thin wrapper that manages converting the API from v1 to v2 for us, so we don't have to change each usage of `react-select`.\r\n\r\nI've noticed that a couple of strange warnings appear in the console as a result of prop types:\r\n\r\n![image](https://user-images.githubusercontent.com/561722/41071689-cb79ad18-6a3c-11e8-802c-e79bbf1779f4.png)\r\n\r\n![image](https://user-images.githubusercontent.com/561722/41071698-dc16e3c0-6a3c-11e8-9dd9-9242f3e316ef.png)\r\n\r\nIt looks like we're passing undefined to a prop type definition somewhere, but that seems pretty strange to me. Probably need someone more familiar with how this package works to take a look.\r\n\r\nThere were a lot of snapshot tests that needed updating, I went through them and couldn't spot anything wrong.","created_at":"2018-06-07T00:24:23Z","updated_at":"2018-06-13T23:44:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"484e009656f27942fc3ba7a9510c010a01338d28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":957036658,"node_id":"MDU6TGFiZWw5NTcwMzY2NTg=","url":"https://api.github.com/repos/uptick/react-object-list/labels/tech%20debt","name":"tech debt","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uptick/react-object-list/pulls/58/commits","review_comments_url":"https://api.github.com/repos/uptick/react-object-list/pulls/58/comments","review_comment_url":"https://api.github.com/repos/uptick/react-object-list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uptick/react-object-list/issues/58/comments","statuses_url":"https://api.github.com/repos/uptick/react-object-list/statuses/35d3e11f0aa0a2257bedb17150e81f9556a1966e","head":{"label":"uptick:techdebt/react-select-v2","ref":"techdebt/react-select-v2","sha":"35d3e11f0aa0a2257bedb17150e81f9556a1966e","user":{"login":"uptick","id":10147530,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTQ3NTMw","avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/uptick","html_url":"https://github.com/uptick","followers_url":"https://api.github.com/users/uptick/followers","following_url":"https://api.github.com/users/uptick/following{/other_user}","gists_url":"https://api.github.com/users/uptick/gists{/gist_id}","starred_url":"https://api.github.com/users/uptick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uptick/subscriptions","organizations_url":"https://api.github.com/users/uptick/orgs","repos_url":"https://api.github.com/users/uptick/repos","events_url":"https://api.github.com/users/uptick/events{/privacy}","received_events_url":"https://api.github.com/users/uptick/received_events","type":"Organization","site_admin":false},"repo":{"id":124351735,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzNTE3MzU=","name":"react-object-list","full_name":"uptick/react-object-list","owner":{"login":"uptick","id":10147530,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTQ3NTMw","avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/uptick","html_url":"https://github.com/uptick","followers_url":"https://api.github.com/users/uptick/followers","following_url":"https://api.github.com/users/uptick/following{/other_user}","gists_url":"https://api.github.com/users/uptick/gists{/gist_id}","starred_url":"https://api.github.com/users/uptick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uptick/subscriptions","organizations_url":"https://api.github.com/users/uptick/orgs","repos_url":"https://api.github.com/users/uptick/repos","events_url":"https://api.github.com/users/uptick/events{/privacy}","received_events_url":"https://api.github.com/users/uptick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uptick/react-object-list","description":"Neat table/list views with filtering and pagination support; powered by React.","fork":false,"url":"https://api.github.com/repos/uptick/react-object-list","forks_url":"https://api.github.com/repos/uptick/react-object-list/forks","keys_url":"https://api.github.com/repos/uptick/react-object-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uptick/react-object-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uptick/react-object-list/teams","hooks_url":"https://api.github.com/repos/uptick/react-object-list/hooks","issue_events_url":"https://api.github.com/repos/uptick/react-object-list/issues/events{/number}","events_url":"https://api.github.com/repos/uptick/react-object-list/events","assignees_url":"https://api.github.com/repos/uptick/react-object-list/assignees{/user}","branches_url":"https://api.github.com/repos/uptick/react-object-list/branches{/branch}","tags_url":"https://api.github.com/repos/uptick/react-object-list/tags","blobs_url":"https://api.github.com/repos/uptick/react-object-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uptick/react-object-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uptick/react-object-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/uptick/react-object-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uptick/react-object-list/statuses/{sha}","languages_url":"https://api.github.com/repos/uptick/react-object-list/languages","stargazers_url":"https://api.github.com/repos/uptick/react-object-list/stargazers","contributors_url":"https://api.github.com/repos/uptick/react-object-list/contributors","subscribers_url":"https://api.github.com/repos/uptick/react-object-list/subscribers","subscription_url":"https://api.github.com/repos/uptick/react-object-list/subscription","commits_url":"https://api.github.com/repos/uptick/react-object-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/uptick/react-object-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/uptick/react-object-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/uptick/react-object-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/uptick/react-object-list/contents/{+path}","compare_url":"https://api.github.com/repos/uptick/react-object-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uptick/react-object-list/merges","archive_url":"https://api.github.com/repos/uptick/react-object-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uptick/react-object-list/downloads","issues_url":"https://api.github.com/repos/uptick/react-object-list/issues{/number}","pulls_url":"https://api.github.com/repos/uptick/react-object-list/pulls{/number}","milestones_url":"https://api.github.com/repos/uptick/react-object-list/milestones{/number}","notifications_url":"https://api.github.com/repos/uptick/react-object-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uptick/react-object-list/labels{/name}","releases_url":"https://api.github.com/repos/uptick/react-object-list/releases{/id}","deployments_url":"https://api.github.com/repos/uptick/react-object-list/deployments","created_at":"2018-03-08T07:09:18Z","updated_at":"2018-06-12T04:58:18Z","pushed_at":"2018-06-12T23:33:12Z","git_url":"git://github.com/uptick/react-object-list.git","ssh_url":"git@github.com:uptick/react-object-list.git","clone_url":"https://github.com/uptick/react-object-list.git","svn_url":"https://github.com/uptick/react-object-list","homepage":"","size":1358,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"uptick:master","ref":"master","sha":"d58b3fee695ade8ca6832fa4ef492fbf391e00aa","user":{"login":"uptick","id":10147530,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTQ3NTMw","avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/uptick","html_url":"https://github.com/uptick","followers_url":"https://api.github.com/users/uptick/followers","following_url":"https://api.github.com/users/uptick/following{/other_user}","gists_url":"https://api.github.com/users/uptick/gists{/gist_id}","starred_url":"https://api.github.com/users/uptick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uptick/subscriptions","organizations_url":"https://api.github.com/users/uptick/orgs","repos_url":"https://api.github.com/users/uptick/repos","events_url":"https://api.github.com/users/uptick/events{/privacy}","received_events_url":"https://api.github.com/users/uptick/received_events","type":"Organization","site_admin":false},"repo":{"id":124351735,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzNTE3MzU=","name":"react-object-list","full_name":"uptick/react-object-list","owner":{"login":"uptick","id":10147530,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTQ3NTMw","avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/uptick","html_url":"https://github.com/uptick","followers_url":"https://api.github.com/users/uptick/followers","following_url":"https://api.github.com/users/uptick/following{/other_user}","gists_url":"https://api.github.com/users/uptick/gists{/gist_id}","starred_url":"https://api.github.com/users/uptick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uptick/subscriptions","organizations_url":"https://api.github.com/users/uptick/orgs","repos_url":"https://api.github.com/users/uptick/repos","events_url":"https://api.github.com/users/uptick/events{/privacy}","received_events_url":"https://api.github.com/users/uptick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uptick/react-object-list","description":"Neat table/list views with filtering and pagination support; powered by React.","fork":false,"url":"https://api.github.com/repos/uptick/react-object-list","forks_url":"https://api.github.com/repos/uptick/react-object-list/forks","keys_url":"https://api.github.com/repos/uptick/react-object-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uptick/react-object-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uptick/react-object-list/teams","hooks_url":"https://api.github.com/repos/uptick/react-object-list/hooks","issue_events_url":"https://api.github.com/repos/uptick/react-object-list/issues/events{/number}","events_url":"https://api.github.com/repos/uptick/react-object-list/events","assignees_url":"https://api.github.com/repos/uptick/react-object-list/assignees{/user}","branches_url":"https://api.github.com/repos/uptick/react-object-list/branches{/branch}","tags_url":"https://api.github.com/repos/uptick/react-object-list/tags","blobs_url":"https://api.github.com/repos/uptick/react-object-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uptick/react-object-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uptick/react-object-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/uptick/react-object-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uptick/react-object-list/statuses/{sha}","languages_url":"https://api.github.com/repos/uptick/react-object-list/languages","stargazers_url":"https://api.github.com/repos/uptick/react-object-list/stargazers","contributors_url":"https://api.github.com/repos/uptick/react-object-list/contributors","subscribers_url":"https://api.github.com/repos/uptick/react-object-list/subscribers","subscription_url":"https://api.github.com/repos/uptick/react-object-list/subscription","commits_url":"https://api.github.com/repos/uptick/react-object-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/uptick/react-object-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/uptick/react-object-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/uptick/react-object-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/uptick/react-object-list/contents/{+path}","compare_url":"https://api.github.com/repos/uptick/react-object-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uptick/react-object-list/merges","archive_url":"https://api.github.com/repos/uptick/react-object-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uptick/react-object-list/downloads","issues_url":"https://api.github.com/repos/uptick/react-object-list/issues{/number}","pulls_url":"https://api.github.com/repos/uptick/react-object-list/pulls{/number}","milestones_url":"https://api.github.com/repos/uptick/react-object-list/milestones{/number}","notifications_url":"https://api.github.com/repos/uptick/react-object-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uptick/react-object-list/labels{/name}","releases_url":"https://api.github.com/repos/uptick/react-object-list/releases{/id}","deployments_url":"https://api.github.com/repos/uptick/react-object-list/deployments","created_at":"2018-03-08T07:09:18Z","updated_at":"2018-06-12T04:58:18Z","pushed_at":"2018-06-12T23:33:12Z","git_url":"git://github.com/uptick/react-object-list.git","ssh_url":"git@github.com:uptick/react-object-list.git","clone_url":"https://github.com/uptick/react-object-list.git","svn_url":"https://github.com/uptick/react-object-list","homepage":"","size":1358,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/58"},"html":{"href":"https://github.com/uptick/react-object-list/pull/58"},"issue":{"href":"https://api.github.com/repos/uptick/react-object-list/issues/58"},"comments":{"href":"https://api.github.com/repos/uptick/react-object-list/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uptick/react-object-list/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/uptick/react-object-list/statuses/35d3e11f0aa0a2257bedb17150e81f9556a1966e"}},"author_association":"NONE"}}
{"actor":{"display_login":"scaredcat"}}