{"action":"created","issue":{"url":"https://api.github.com/repos/rook/rook/issues/2318","repository_url":"https://api.github.com/repos/rook/rook","labels_url":"https://api.github.com/repos/rook/rook/issues/2318/labels{/name}","comments_url":"https://api.github.com/repos/rook/rook/issues/2318/comments","events_url":"https://api.github.com/repos/rook/rook/issues/2318/events","html_url":"https://github.com/rook/rook/pull/2318","id":386220176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDEzMjY5","number":2318,"title":"Cockroachdb + Minio: Use PersistentVolumeClaimTemplates storage","user":{"login":"galexrt","id":3718398,"node_id":"MDQ6VXNlcjM3MTgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false},"labels":[{"id":915291772,"node_id":"MDU6TGFiZWw5MTUyOTE3NzI=","url":"https://api.github.com/repos/rook/rook/labels/cockroachdb","name":"cockroachdb","color":"7cf41a","default":false},{"id":915296814,"node_id":"MDU6TGFiZWw5MTUyOTY4MTQ=","url":"https://api.github.com/repos/rook/rook/labels/minio","name":"minio","color":"bce2f4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-30T14:55:13Z","updated_at":"2018-12-07T09:45:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2318","html_url":"https://github.com/rook/rook/pull/2318","diff_url":"https://github.com/rook/rook/pull/2318.diff","patch_url":"https://github.com/rook/rook/pull/2318.patch"},"body":"```\r\nselection field.\r\n\r\nSigned-off-by: Alexander Trost <galexrt@googlemail.com>\r\n```\r\n\r\n**Description of your changes:**\r\nThis PR enables enables the CockroachDB and Minio operator to use the newly added Rook Storage Selection field `volumeClaimTemplates` to use for storage.\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nPartly _resolves_ #919.\r\n\r\n**Checklist:**\r\n- [x] Documentation has been updated, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [x] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [x] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md#comments)"},"comment":{"url":"https://api.github.com/repos/rook/rook/issues/comments/445178156","html_url":"https://github.com/rook/rook/pull/2318#issuecomment-445178156","issue_url":"https://api.github.com/repos/rook/rook/issues/2318","id":445178156,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTE3ODE1Ng==","user":{"login":"galexrt","id":3718398,"node_id":"MDQ6VXNlcjM3MTgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T09:45:22Z","updated_at":"2018-12-07T09:45:22Z","author_association":"MEMBER","body":"@jbw976 I think I'll split up the CockroachDB part and just put the Minio changes in this PR today.\r\nThe Minio changes are working fine (creating a new Minio works, haven't tested yet with existing Minio, but we don't do \"anything\" when `onUpdate()` is called so there should be no problems for existing instances).\r\n\r\nI'm not going to merge this till I got your, @jbw976, \"new\" okay for the Minio changes."}}
{"actor":{"display_login":"galexrt"}}