{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29495","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29495/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29495/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29495/events","html_url":"https://github.com/Automattic/wp-calypso/issues/29495","id":391699597,"node_id":"MDU6SXNzdWUzOTE2OTk1OTc=","number":29495,"title":"Tiled gallery block: photonize image URLs","user":{"login":"simison","id":87168,"node_id":"MDQ6VXNlcjg3MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/87168?v=4","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"labels":[{"id":1141886007,"node_id":"MDU6TGFiZWwxMTQxODg2MDA3","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Tiled%20Galleries","name":"Tiled Galleries","color":"006b75","default":false},{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":285010007,"node_id":"MDU6TGFiZWwyODUwMTAwMDc=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Pri]%20High","name":"[Pri] High","color":"ec9a71","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-17T12:54:44Z","updated_at":"2018-12-20T06:38:22Z","closed_at":null,"author_association":"MEMBER","body":"By using Photon, some shape calculations might be more straightforward and we could save bytes by serving actual square images for square layout, instead of cropping them out.\r\n\r\nThat said, we'll need to ensure experience stays smooth by using \"stepped\" Photonized image sizes. \r\n\r\nImagine if you uploaded an image or resized the gallery by opening Gutenberg sidebar; each image would now be slightly different size and start loading a new Photon image. We need to ensure that we don't load new photon image too often, especially in the editor.\r\n\r\nSituations that we should test:\r\n\r\n- Adding new images to the gallery\r\n- Toggling Gutenberg sidebar hidden/visible\r\n- Changing alignment\r\n- Resizing the browser window\r\n- In future, we might have drag'n'drop feature (#28950), how will that be affected?\r\n\r\nSuppose in the editor view, we should grab the total width of the gallery and use the same size for each image that we Photonize: that way even if images are shuffled around, they always have an image already loaded.\r\n\r\nIn the view, we can be a little bit more aggressive with image sizes to save bandwidth.\r\n\r\nA bit of code for this already in: https://github.com/Automattic/wp-calypso/pull/29465/files#diff-64399d2ba5e2912315cb18d8cc16dafbR140\r\n\r\nRelated \"use large images\" (#29544)"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/448890729","html_url":"https://github.com/Automattic/wp-calypso/issues/29495#issuecomment-448890729","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29495","id":448890729,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODg5MDcyOQ==","user":{"login":"simison","id":87168,"node_id":"MDQ6VXNlcjg3MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/87168?v=4","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T06:38:22Z","updated_at":"2018-12-20T06:38:22Z","author_association":"MEMBER","body":"> > Are there concerns about privacy or the other reasons sites may disable photon?\r\n>\r\n> cc: @jeherve I think photon is pretty much a requirement for tile galleries. No?\r\n\r\nThey are for the module; they don't technically have to be for the block."}}
{"actor":{"display_login":"simison"}}