{"action":"created","issue":{"url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/22","repository_url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine","labels_url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/22/comments","events_url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/22/events","html_url":"https://github.com/huaweicloud/terraform-provider-flexibleengine/issues/22","id":318983965,"number":22,"title":"Initial Provider Review","user":{"login":"bill-rich","id":3035677,"avatar_url":"https://avatars1.githubusercontent.com/u/3035677?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-rich","html_url":"https://github.com/bill-rich","followers_url":"https://api.github.com/users/bill-rich/followers","following_url":"https://api.github.com/users/bill-rich/following{/other_user}","gists_url":"https://api.github.com/users/bill-rich/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-rich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-rich/subscriptions","organizations_url":"https://api.github.com/users/bill-rich/orgs","repos_url":"https://api.github.com/users/bill-rich/repos","events_url":"https://api.github.com/users/bill-rich/events{/privacy}","received_events_url":"https://api.github.com/users/bill-rich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"niuzhenguo","id":3840030,"avatar_url":"https://avatars0.githubusercontent.com/u/3840030?v=4","gravatar_id":"","url":"https://api.github.com/users/niuzhenguo","html_url":"https://github.com/niuzhenguo","followers_url":"https://api.github.com/users/niuzhenguo/followers","following_url":"https://api.github.com/users/niuzhenguo/following{/other_user}","gists_url":"https://api.github.com/users/niuzhenguo/gists{/gist_id}","starred_url":"https://api.github.com/users/niuzhenguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niuzhenguo/subscriptions","organizations_url":"https://api.github.com/users/niuzhenguo/orgs","repos_url":"https://api.github.com/users/niuzhenguo/repos","events_url":"https://api.github.com/users/niuzhenguo/events{/privacy}","received_events_url":"https://api.github.com/users/niuzhenguo/received_events","type":"User","site_admin":false},"assignees":[{"login":"niuzhenguo","id":3840030,"avatar_url":"https://avatars0.githubusercontent.com/u/3840030?v=4","gravatar_id":"","url":"https://api.github.com/users/niuzhenguo","html_url":"https://github.com/niuzhenguo","followers_url":"https://api.github.com/users/niuzhenguo/followers","following_url":"https://api.github.com/users/niuzhenguo/following{/other_user}","gists_url":"https://api.github.com/users/niuzhenguo/gists{/gist_id}","starred_url":"https://api.github.com/users/niuzhenguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niuzhenguo/subscriptions","organizations_url":"https://api.github.com/users/niuzhenguo/orgs","repos_url":"https://api.github.com/users/niuzhenguo/repos","events_url":"https://api.github.com/users/niuzhenguo/events{/privacy}","received_events_url":"https://api.github.com/users/niuzhenguo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-30T18:14:20Z","updated_at":"2018-05-25T23:15:40Z","closed_at":null,"author_association":"NONE","body":"Hello! \r\n\r\nMy name is Bill, I'm a member of the Terraform team @ HashiCorp.\r\n\r\nI’ve taken a look at the provider here and would like to say great work so far! I do have feedback outlined below that I’d like to see addressed before we move on to the next steps. I’m opening this issues as a sort of checklist for tracking remaining items and discussion. The review was done on the git commit ab16332.\r\n\r\n- [x] There are many sections of code that have been commented out. If they are not needed, it would probably be best to remove them to keep things clean. Here are a few examples.\r\n  * `force_delete` commented out at https://github.com/huaweicloud/terraform-provider-flexibleengine/blob/master/flexibleengine/resource_flexibleengine_compute_instance_v2.go#L799-L805\r\n  * Setting of `security_group` is at https://github.com/huaweicloud/terraform-provider-flexibleengine/blob/master/flexibleengine/resource_flexibleengine_compute_instance_v2.go#L547-L553\r\n  * `certificates` is commented out at https://github.com/huaweicloud/terraform-provider-flexibleengine/blob/master/flexibleengine/resource_flexibleengine_elb_listener.go#L131-L135\r\n  * Setting tags is commented at https://github.com/huaweicloud/terraform-provider-flexibleengine/blob/master/flexibleengine/resource_flexibleengine_s3_bucket.go#L774-L786\r\n- [x] In some places the cloud is referred to as FlexibleEngine and in others it is OrangeCloud. Are these the same? If so, can the instances of OrangeCloud be changed to FlexibleEngine?\r\n- [ ] Why are AWS resources included (list s3_bucket)? Could AWS provider be used instead of duplicating this work?\r\n- [x] What is build_param_util.go used for? It doesn’t seem to be used anywhere. If it isn’t needed, can we remove it?\r\n- [x] Can .zuul.yaml be deleted? We usually try to keep it to just travis.yml for CI.\r\n- [ ] CHANGELOG.md needs to be filled in.\r\n\r\nThe provider is looking great. It looks like its mostly just a matter of getting a few items cleaned up.\r\n\r\nThanks,\r\nBill"},"comment":{"url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/comments/392211142","html_url":"https://github.com/huaweicloud/terraform-provider-flexibleengine/issues/22#issuecomment-392211142","issue_url":"https://api.github.com/repos/huaweicloud/terraform-provider-flexibleengine/issues/22","id":392211142,"user":{"login":"bill-rich","id":3035677,"avatar_url":"https://avatars1.githubusercontent.com/u/3035677?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-rich","html_url":"https://github.com/bill-rich","followers_url":"https://api.github.com/users/bill-rich/followers","following_url":"https://api.github.com/users/bill-rich/following{/other_user}","gists_url":"https://api.github.com/users/bill-rich/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-rich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-rich/subscriptions","organizations_url":"https://api.github.com/users/bill-rich/orgs","repos_url":"https://api.github.com/users/bill-rich/repos","events_url":"https://api.github.com/users/bill-rich/events{/privacy}","received_events_url":"https://api.github.com/users/bill-rich/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T23:15:40Z","updated_at":"2018-05-25T23:15:40Z","author_association":"NONE","body":"@niuzhenguo Looks good! Thank you for getting those items addressed! \r\n\r\nThe AWS resources seem fine. That makes sense to have resources to cover the object storage service. I'd say that as long as the resource names match the names as they're used on the cloud, it would be good to keep them as is.\r\n\r\nFor the CHANGELOG, I think it makes sense to not worry about backfilling it with all the previous changes, but I'd like to get a snapshot of where things are at before the provider gets pulled into terraform-providers. That way we've got a reference for the initial version. Something like [this](https://github.com/terraform-providers/terraform-provider-oraclepaas/blob/master/CHANGELOG.md) would be good. "}}
{"actor":{"display_login":"bill-rich"}}