{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/fili/pulls/comments/205906235","pull_request_review_id":141277366,"id":205906235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkwNjIzNQ==","diff_hunk":"@@ -0,0 +1,204 @@\n+// Copyright 2018 Yahoo Inc.\n+// Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms.\n+package com.yahoo.luthier.webservice.data.config.table;\n+\n+import com.fasterxml.jackson.databind.ObjectMapper;\n+import com.fasterxml.jackson.datatype.joda.JodaModule;\n+import com.yahoo.bard.webservice.data.config.ResourceDictionaries;\n+import com.yahoo.bard.webservice.data.config.dimension.DimensionConfig;\n+import com.yahoo.bard.webservice.data.config.names.ApiMetricName;\n+import com.yahoo.bard.webservice.data.config.names.FieldName;\n+import com.yahoo.bard.webservice.data.config.names.TableName;\n+import com.yahoo.bard.webservice.data.config.table.BaseTableLoader;\n+import com.yahoo.bard.webservice.data.config.table.ConcretePhysicalTableDefinition;\n+import com.yahoo.bard.webservice.data.config.table.PhysicalTableDefinition;\n+import com.yahoo.bard.webservice.data.time.Granularity;\n+import com.yahoo.bard.webservice.metadata.DataSourceMetadataService;\n+import com.yahoo.bard.webservice.table.TableGroup;\n+import com.yahoo.luthier.webservice.data.config.ExternalConfigLoader;\n+import com.yahoo.luthier.webservice.data.config.dimension.ExternalDimensionsLoader;\n+import org.joda.time.DateTimeZone;\n+\n+import java.util.*;\n+import java.util.stream.Collectors;\n+\n+/**\n+ * Load the Wikipedia-specific table configuration.\n+ */\n+public class ExternalTableLoader extends BaseTableLoader {\n+\n+    private final Map<TableName, Set<Granularity>> validGrains =\n+            new HashMap<>();\n+\n+    // Set up the metrics\n+    private final Map<TableName, Set<FieldName>> druidMetricNames =\n+            new HashMap<>();\n+    private final Map<TableName, Set<ApiMetricName>> apiMetricNames =\n+            new HashMap<>();\n+\n+    // Set up the table definitions\n+    private final Map<TableName, Set<PhysicalTableDefinition>> tableDefinitions =\n+            new HashMap<>();\n+\n+    private final Map<String, PhysicalTableInfoTemplate> physicalTableDictionary = new HashMap<>();\n+\n+    private ExternalConfigLoader tableConfigLoader;\n+    private String externalConfigFilePath;\n+    private ExternalDimensionsLoader externalDimensionsLoader;","path":"luthier/src/main/java/com/yahoo/luthier/webservice/data/config/table/ExternalTableLoader.java","position":47,"original_position":47,"commit_id":"c70e0099ed8a59ac5665c7e705be85dfd35d26f7","original_commit_id":"c70e0099ed8a59ac5665c7e705be85dfd35d26f7","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Private field 'externalDimensionsLoader' could be made final; it is only initialized in the declaration or constructor.](https://app.codacy.com/app/Fili/fili/pullRequest?prid=1800136)","created_at":"2018-07-27T21:40:08Z","updated_at":"2018-07-27T21:40:09Z","html_url":"https://github.com/yahoo/fili/pull/719#discussion_r205906235","pull_request_url":"https://api.github.com/repos/yahoo/fili/pulls/719","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments/205906235"},"html":{"href":"https://github.com/yahoo/fili/pull/719#discussion_r205906235"},"pull_request":{"href":"https://api.github.com/repos/yahoo/fili/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/fili/pulls/719","id":195929270,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTI5Mjcw","html_url":"https://github.com/yahoo/fili/pull/719","diff_url":"https://github.com/yahoo/fili/pull/719.diff","patch_url":"https://github.com/yahoo/fili/pull/719.patch","issue_url":"https://api.github.com/repos/yahoo/fili/issues/719","number":719,"state":"open","locked":false,"title":"Luthier-draft-1","user":{"login":"ForestCold","id":15013380,"node_id":"MDQ6VXNlcjE1MDEzMzgw","avatar_url":"https://avatars1.githubusercontent.com/u/15013380?v=4","gravatar_id":"","url":"https://api.github.com/users/ForestCold","html_url":"https://github.com/ForestCold","followers_url":"https://api.github.com/users/ForestCold/followers","following_url":"https://api.github.com/users/ForestCold/following{/other_user}","gists_url":"https://api.github.com/users/ForestCold/gists{/gist_id}","starred_url":"https://api.github.com/users/ForestCold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForestCold/subscriptions","organizations_url":"https://api.github.com/users/ForestCold/orgs","repos_url":"https://api.github.com/users/ForestCold/repos","events_url":"https://api.github.com/users/ForestCold/events{/privacy}","received_events_url":"https://api.github.com/users/ForestCold/received_events","type":"User","site_admin":false},"body":"https://github.com/yahoo/fili/issues/708","created_at":"2018-06-19T19:12:09Z","updated_at":"2018-07-27T21:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38e47b0c084ebae7669d103f2b2823d8ce2e3f39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":465544253,"node_id":"MDU6TGFiZWw0NjU1NDQyNTM=","url":"https://api.github.com/repos/yahoo/fili/labels/CONFIG","name":"CONFIG","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fili/pulls/719/commits","review_comments_url":"https://api.github.com/repos/yahoo/fili/pulls/719/comments","review_comment_url":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fili/issues/719/comments","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/c70e0099ed8a59ac5665c7e705be85dfd35d26f7","head":{"label":"yahoo:wiki-test","ref":"wiki-test","sha":"c70e0099ed8a59ac5665c7e705be85dfd35d26f7","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg3OTYzNg==","name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2018-07-25T18:43:50Z","pushed_at":"2018-07-27T21:37:03Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":"http://fili.io","size":10166,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":231,"watchers":88,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"d743cc790b2be87432b3231eea4ee36f979be8a4","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":60879636,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg3OTYzNg==","name":"fili","full_name":"yahoo/fili","owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fili","description":"Easily make RESTful web services for time series reporting with Big Data analytics engines like Druid and Hive.","fork":false,"url":"https://api.github.com/repos/yahoo/fili","forks_url":"https://api.github.com/repos/yahoo/fili/forks","keys_url":"https://api.github.com/repos/yahoo/fili/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fili/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fili/teams","hooks_url":"https://api.github.com/repos/yahoo/fili/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fili/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fili/events","assignees_url":"https://api.github.com/repos/yahoo/fili/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fili/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fili/tags","blobs_url":"https://api.github.com/repos/yahoo/fili/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fili/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fili/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fili/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fili/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fili/languages","stargazers_url":"https://api.github.com/repos/yahoo/fili/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fili/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fili/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fili/subscription","commits_url":"https://api.github.com/repos/yahoo/fili/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fili/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fili/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fili/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fili/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fili/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fili/merges","archive_url":"https://api.github.com/repos/yahoo/fili/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fili/downloads","issues_url":"https://api.github.com/repos/yahoo/fili/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fili/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fili/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fili/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fili/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fili/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fili/deployments","created_at":"2016-06-10T22:07:59Z","updated_at":"2018-07-25T18:43:50Z","pushed_at":"2018-07-27T21:37:03Z","git_url":"git://github.com/yahoo/fili.git","ssh_url":"git@github.com:yahoo/fili.git","clone_url":"https://github.com/yahoo/fili.git","svn_url":"https://github.com/yahoo/fili","homepage":"http://fili.io","size":10166,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":51,"open_issues":231,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fili/pulls/719"},"html":{"href":"https://github.com/yahoo/fili/pull/719"},"issue":{"href":"https://api.github.com/repos/yahoo/fili/issues/719"},"comments":{"href":"https://api.github.com/repos/yahoo/fili/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fili/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fili/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fili/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fili/statuses/c70e0099ed8a59ac5665c7e705be85dfd35d26f7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codacy-bot"}}