{"action":"created","comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/189126588","pull_request_review_id":121246751,"id":189126588,"diff_hunk":"@@ -1578,52 +1537,31 @@ int PrestressMembraneElement::Check(const ProcessInfo& rCurrentProcessInfo)\n         KRATOS_CHECK_DOF_IN_NODE(DISPLACEMENT_Z, r_node)\n     }\n \n-    /* @Anna please use these checks\n     // Verify that the constitutive law exists\n     KRATOS_ERROR_IF_NOT(this->GetProperties().Has( CONSTITUTIVE_LAW )) << \"Constitutive law not provided for property \" << this->GetProperties().Id() << std::endl;\n \n     // Verify that the constitutive law has the correct dimension\n     const unsigned int strain_size = this->GetProperties().GetValue( CONSTITUTIVE_LAW )->GetStrainSize();\n-    if ( dimension == 2 ) {\n-        KRATOS_ERROR_IF( strain_size < 3 || strain_size > 4) << \"Wrong constitutive law used. This is a 2D element! expected strain size is 3 or 4 (el id = ) \" << this->Id() << std::endl;\n-    } else {\n-        KRATOS_ERROR_IF_NOT(strain_size == 6) << \"Wrong constitutive law used. This is a 3D element! expected strain size is 6 (el id = ) \"<<  this->Id() << std::endl;\n-    }\n-\n-    // Check constitutive law\n-    if ( mConstitutiveLawVector.size() > 0 ) {\n-        return mConstitutiveLawVector[0]->Check( GetProperties(), GetGeometry(), rCurrentProcessInfo );\n-    }\n-    */\n-\n-    //verify that the constitutive law exists\n-    /*if (this->GetProperties().Has(CONSTITUTIVE_LAW) == false)\n-    {\n-        KRATOS_THROW_ERROR(std::logic_error, \"constitutive law not provided for property \", this->GetProperties().Id())\n-    }\n-\n-\n-    //verify that the constitutive law has the correct dimension\n-    if (this->GetProperties().GetValue(CONSTITUTIVE_LAW)->GetStrainSize() != 3)\n-        KRATOS_THROW_ERROR(std::logic_error, \"wrong constitutive law used. This is a 3D element with expected strain size is 3 (el id = ) \", this->Id())\n+    KRATOS_ERROR_IF( strain_size != 3) << \"Wrong constitutive law used. This is a membrane element! expected strain size is 3 (el id = ) \" << this->Id() << std::endl;\n \n     //check constitutive law\n-    for (unsigned int i = 0; i < mConstitutiveLawVector.size(); i++)\n-    {\n-        mConstitutiveLawVector[i]->Check(GetProperties(), GetGeometry(), rCurrentProcessInfo);\n+    if(GetValue(IS_FORMFINDING)== false){\n+        for (unsigned int i = 0; i < mConstitutiveLawVector.size(); i++)\n+        {\n+            mConstitutiveLawVector[i]->Check(GetProperties(), GetGeometry(), rCurrentProcessInfo);\n \n-        ConstitutiveLaw::Features LawFeatures;\n-        mConstitutiveLawVector[i]->GetLawFeatures(LawFeatures);\n+            ConstitutiveLaw::Features LawFeatures;\n+            mConstitutiveLawVector[i]->GetLawFeatures(LawFeatures);\n \n-        if (LawFeatures.mOptions.IsNot(ConstitutiveLaw::PLANE_STRESS_LAW))\n-            KRATOS_THROW_ERROR(std::logic_error, \"Constitutive law is compatible only with a plane stress 2D law for membrane element with Id\", this->Id())\n+            if (LawFeatures.mOptions.IsNot(ConstitutiveLaw::PLANE_STRESS_LAW))\n+                KRATOS_THROW_ERROR(std::logic_error, \"Constitutive law is compatible only with a plane stress 2D law for membrane element with Id\", this->Id())","path":"applications/StructuralMechanicsApplication/custom_elements/prestress_membrane_element.cpp","position":1706,"original_position":1706,"commit_id":"433da152aa32cb1daea8ad0480f877f62ffdec29","original_commit_id":"433da152aa32cb1daea8ad0480f877f62ffdec29","user":{"login":"annasophie91","id":28961195,"avatar_url":"https://avatars0.githubusercontent.com/u/28961195?v=4","gravatar_id":"","url":"https://api.github.com/users/annasophie91","html_url":"https://github.com/annasophie91","followers_url":"https://api.github.com/users/annasophie91/followers","following_url":"https://api.github.com/users/annasophie91/following{/other_user}","gists_url":"https://api.github.com/users/annasophie91/gists{/gist_id}","starred_url":"https://api.github.com/users/annasophie91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annasophie91/subscriptions","organizations_url":"https://api.github.com/users/annasophie91/orgs","repos_url":"https://api.github.com/users/annasophie91/repos","events_url":"https://api.github.com/users/annasophie91/events{/privacy}","received_events_url":"https://api.github.com/users/annasophie91/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-17T23:09:14Z","updated_at":"2018-05-17T23:09:14Z","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2101#discussion_r189126588","pull_request_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/189126588"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/2101#discussion_r189126588"},"pull_request":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101"}},"in_reply_to_id":188848064},"pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101","id":188585598,"html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2101","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/2101.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/2101.patch","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2101","number":2101,"state":"open","locked":false,"title":"Membrane analysis","user":{"login":"annasophie91","id":28961195,"avatar_url":"https://avatars0.githubusercontent.com/u/28961195?v=4","gravatar_id":"","url":"https://api.github.com/users/annasophie91","html_url":"https://github.com/annasophie91","followers_url":"https://api.github.com/users/annasophie91/followers","following_url":"https://api.github.com/users/annasophie91/following{/other_user}","gists_url":"https://api.github.com/users/annasophie91/gists{/gist_id}","starred_url":"https://api.github.com/users/annasophie91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annasophie91/subscriptions","organizations_url":"https://api.github.com/users/annasophie91/orgs","repos_url":"https://api.github.com/users/annasophie91/repos","events_url":"https://api.github.com/users/annasophie91/events{/privacy}","received_events_url":"https://api.github.com/users/annasophie91/received_events","type":"User","site_admin":false},"body":" ","created_at":"2018-05-16T23:14:25Z","updated_at":"2018-05-17T23:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87f29fbd3dda9c124968beff6d8321bc42d5cedd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101/commits","review_comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101/comments","review_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2101/comments","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/433da152aa32cb1daea8ad0480f877f62ffdec29","head":{"label":"KratosMultiphysics:membrane_analysis","ref":"membrane_analysis","sha":"433da152aa32cb1daea8ad0480f877f62ffdec29","user":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-05-17T19:56:50Z","pushed_at":"2018-05-17T21:36:17Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1100262,"stargazers_count":140,"watchers_count":140,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":32,"open_issues":106,"watchers":140,"default_branch":"master"}},"base":{"label":"KratosMultiphysics:master","ref":"master","sha":"5cfb348eedd8d6fac56e8de65ac4bf69cbd8242b","user":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-05-17T19:56:50Z","pushed_at":"2018-05-17T21:36:17Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1100262,"stargazers_count":140,"watchers_count":140,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":32,"open_issues":106,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/2101"},"issue":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2101"},"comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2101/comments"},"review_comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101/comments"},"review_comment":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2101/commits"},"statuses":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/433da152aa32cb1daea8ad0480f877f62ffdec29"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"annasophie91"}}