{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12","id":172651652,"html_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM/pull/12","diff_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM/pull/12.diff","patch_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM/pull/12.patch","issue_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/12","number":12,"state":"closed","locked":false,"title":"Remove Identifier from the completion handler for find(id:)","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars2.githubusercontent.com/u/11974522?v=4","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"body":"The function signatures for `find(id:)` and `update(id:)` are currently:\r\n```swift\r\nfind<I: Identifier>(id: I, using db: Database? = nil, onCompletion: @escaping (I?, Self?, RequestError?) -> Void)\r\nupdate<I: Identifier>(id: I, using db: Database?, _ onCompletion: @escaping (Identifier?, Self?, RequestError?) -> Void)\r\n```\r\nThe `Identifier` in the completion handler is superfluous  - the calling code knows what it is already - and it additionally doesn't match the equivalent handler that you'd use with the Codable Routing API in Kitura, e.g.:\r\n```swift\r\nloadOneHandler(id: Int, completion: @escaping (Meal?, RequestError?) -> Void)\r\nupdateOneHandler(id: Int, meal: Meal, completion: @escaping (Meal?, RequestError?) -> Void)\r\n```\r\n\r\nThis PR removes the Identifier from the completion handler so we can pass the one from the Codable Routing handler straight through.","created_at":"2018-03-03T05:28:44Z","updated_at":"2018-03-05T10:24:47Z","closed_at":"2018-03-05T10:24:47Z","merged_at":"2018-03-05T10:24:47Z","merge_commit_sha":"853a173705964c69afc922addcf726ce70ba9773","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12/commits","review_comments_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12/comments","review_comment_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/12/comments","statuses_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/statuses/a999ed03c5f3a3bb37f032aee8f7c3879ea2c343","head":{"label":"seabaylea:find-id","ref":"find-id","sha":"a999ed03c5f3a3bb37f032aee8f7c3879ea2c343","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars2.githubusercontent.com/u/11974522?v=4","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"repo":{"id":123660270,"name":"Swift-Kuery-ORM","full_name":"seabaylea/Swift-Kuery-ORM","owner":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars2.githubusercontent.com/u/11974522?v=4","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seabaylea/Swift-Kuery-ORM","description":"An ORM for Swift, built on Codable","fork":true,"url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM","forks_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/forks","keys_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/teams","hooks_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/hooks","issue_events_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/issues/events{/number}","events_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/events","assignees_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/assignees{/user}","branches_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/branches{/branch}","tags_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/tags","blobs_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/git/refs{/sha}","trees_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/statuses/{sha}","languages_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/languages","stargazers_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/stargazers","contributors_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/contributors","subscribers_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/subscribers","subscription_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/subscription","commits_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/commits{/sha}","git_commits_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/git/commits{/sha}","comments_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/comments{/number}","issue_comment_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/issues/comments{/number}","contents_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/contents/{+path}","compare_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/merges","archive_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/downloads","issues_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/issues{/number}","pulls_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/pulls{/number}","milestones_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/milestones{/number}","notifications_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/labels{/name}","releases_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/releases{/id}","deployments_url":"https://api.github.com/repos/seabaylea/Swift-Kuery-ORM/deployments","created_at":"2018-03-03T04:53:54Z","updated_at":"2018-03-03T04:53:56Z","pushed_at":"2018-03-03T06:07:07Z","git_url":"git://github.com/seabaylea/Swift-Kuery-ORM.git","ssh_url":"git@github.com:seabaylea/Swift-Kuery-ORM.git","clone_url":"https://github.com/seabaylea/Swift-Kuery-ORM.git","svn_url":"https://github.com/seabaylea/Swift-Kuery-ORM","homepage":"","size":54,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IBM-Swift:master","ref":"master","sha":"dea2cf7fb03fa8d72f87d00f5048b6e2583ed682","user":{"login":"IBM-Swift","id":16882981,"avatar_url":"https://avatars3.githubusercontent.com/u/16882981?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Swift","html_url":"https://github.com/IBM-Swift","followers_url":"https://api.github.com/users/IBM-Swift/followers","following_url":"https://api.github.com/users/IBM-Swift/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Swift/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Swift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Swift/subscriptions","organizations_url":"https://api.github.com/users/IBM-Swift/orgs","repos_url":"https://api.github.com/users/IBM-Swift/repos","events_url":"https://api.github.com/users/IBM-Swift/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Swift/received_events","type":"Organization","site_admin":false},"repo":{"id":122077639,"name":"Swift-Kuery-ORM","full_name":"IBM-Swift/Swift-Kuery-ORM","owner":{"login":"IBM-Swift","id":16882981,"avatar_url":"https://avatars3.githubusercontent.com/u/16882981?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Swift","html_url":"https://github.com/IBM-Swift","followers_url":"https://api.github.com/users/IBM-Swift/followers","following_url":"https://api.github.com/users/IBM-Swift/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Swift/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Swift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Swift/subscriptions","organizations_url":"https://api.github.com/users/IBM-Swift/orgs","repos_url":"https://api.github.com/users/IBM-Swift/repos","events_url":"https://api.github.com/users/IBM-Swift/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Swift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM","description":"An ORM for Swift, built on Codable","fork":false,"url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM","forks_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/forks","keys_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/teams","hooks_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/hooks","issue_events_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/events{/number}","events_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/events","assignees_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/assignees{/user}","branches_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/branches{/branch}","tags_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/tags","blobs_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/languages","stargazers_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/stargazers","contributors_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/contributors","subscribers_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/subscribers","subscription_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/subscription","commits_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/contents/{+path}","compare_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/merges","archive_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/downloads","issues_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues{/number}","pulls_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/labels{/name}","releases_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/releases{/id}","deployments_url":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/deployments","created_at":"2018-02-19T14:55:27Z","updated_at":"2018-03-05T09:30:16Z","pushed_at":"2018-03-05T10:24:47Z","git_url":"git://github.com/IBM-Swift/Swift-Kuery-ORM.git","ssh_url":"git@github.com:IBM-Swift/Swift-Kuery-ORM.git","clone_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM.git","svn_url":"https://github.com/IBM-Swift/Swift-Kuery-ORM","homepage":"","size":52,"stargazers_count":79,"watchers_count":79,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":2,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12"},"html":{"href":"https://github.com/IBM-Swift/Swift-Kuery-ORM/pull/12"},"issue":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/12"},"comments":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/IBM-Swift/Swift-Kuery-ORM/statuses/a999ed03c5f3a3bb37f032aee8f7c3879ea2c343"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"EnriqueL8","id":30461857,"avatar_url":"https://avatars2.githubusercontent.com/u/30461857?v=4","gravatar_id":"","url":"https://api.github.com/users/EnriqueL8","html_url":"https://github.com/EnriqueL8","followers_url":"https://api.github.com/users/EnriqueL8/followers","following_url":"https://api.github.com/users/EnriqueL8/following{/other_user}","gists_url":"https://api.github.com/users/EnriqueL8/gists{/gist_id}","starred_url":"https://api.github.com/users/EnriqueL8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnriqueL8/subscriptions","organizations_url":"https://api.github.com/users/EnriqueL8/orgs","repos_url":"https://api.github.com/users/EnriqueL8/repos","events_url":"https://api.github.com/users/EnriqueL8/events{/privacy}","received_events_url":"https://api.github.com/users/EnriqueL8/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":26,"deletions":26,"changed_files":2}}
{"actor":{"display_login":"EnriqueL8"}}