{"action":"created","comment":{"url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/comments/194910142","pull_request_review_id":128174539,"id":194910142,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDkxMDE0Mg==","diff_hunk":"@@ -4,28 +4,27 @@\n     <NetCoreAppVersion>netcoreapp2.0</NetCoreAppVersion>\n     <NetStandardVersion>netstandard2.0</NetStandardVersion>\n \n-    <AspNetCoreVersion>2.0.1</AspNetCoreVersion>\n+    <AspNetCoreVersion>2.1.0</AspNetCoreVersion>","path":"Directory.Build.props","position":5,"original_position":5,"commit_id":"ad39fd74d693546b5fb064e8b789953ede3d7813","original_commit_id":"ad39fd74d693546b5fb064e8b789953ede3d7813","user":{"login":"jaredcnance","id":13851721,"node_id":"MDQ6VXNlcjEzODUxNzIx","avatar_url":"https://avatars2.githubusercontent.com/u/13851721?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredcnance","html_url":"https://github.com/jaredcnance","followers_url":"https://api.github.com/users/jaredcnance/followers","following_url":"https://api.github.com/users/jaredcnance/following{/other_user}","gists_url":"https://api.github.com/users/jaredcnance/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredcnance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredcnance/subscriptions","organizations_url":"https://api.github.com/users/jaredcnance/orgs","repos_url":"https://api.github.com/users/jaredcnance/repos","events_url":"https://api.github.com/users/jaredcnance/events{/privacy}","received_events_url":"https://api.github.com/users/jaredcnance/received_events","type":"User","site_admin":false},"body":"fyi - I've started this work over in #302 , should have it done tonight or tomorrow....the fix for the failing tests here will be the same as in that PR.","created_at":"2018-06-12T22:39:46Z","updated_at":"2018-06-12T22:39:46Z","html_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300#discussion_r194910142","pull_request_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/comments/194910142"},"html":{"href":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300#discussion_r194910142"},"pull_request":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300"}},"in_reply_to_id":194707215},"pull_request":{"url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300","id":194155445,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTU1NDQ1","html_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300","diff_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300.diff","patch_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300.patch","issue_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/300","number":300,"state":"open","locked":false,"title":"Use `Mvc.Core` instead of `Mvc`","user":{"login":"btecu","id":7517745,"node_id":"MDQ6VXNlcjc1MTc3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7517745?v=4","gravatar_id":"","url":"https://api.github.com/users/btecu","html_url":"https://github.com/btecu","followers_url":"https://api.github.com/users/btecu/followers","following_url":"https://api.github.com/users/btecu/following{/other_user}","gists_url":"https://api.github.com/users/btecu/gists{/gist_id}","starred_url":"https://api.github.com/users/btecu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btecu/subscriptions","organizations_url":"https://api.github.com/users/btecu/orgs","repos_url":"https://api.github.com/users/btecu/repos","events_url":"https://api.github.com/users/btecu/events{/privacy}","received_events_url":"https://api.github.com/users/btecu/received_events","type":"User","site_admin":false},"body":"I wanted to add the package to my project and it asked to install a lot of dependencies. First step to reduce that is to use `Mvc.Core` instead of `Mvc`. `Mvc` has a lot of extra unneeded packages, such as Razor (template support).\r\n<img width=\"559\" alt=\"install\" src=\"https://user-images.githubusercontent.com/7517745/41268299-687f8694-6dcd-11e8-8477-4b8e85de1b3b.PNG\">\r\n\r\n\r\nI also updated all other packages.\r\n\r\nI noticed a lot of warnings related to `xunit`. Probably existing, but I fixed those as well.","created_at":"2018-06-12T03:13:15Z","updated_at":"2018-06-12T22:39:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5f0149a82b5beb6de794163d93fe4a1381b6989","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300/commits","review_comments_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300/comments","review_comment_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/300/comments","statuses_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/statuses/ad39fd74d693546b5fb064e8b789953ede3d7813","head":{"label":"btecu:updates","ref":"updates","sha":"ad39fd74d693546b5fb064e8b789953ede3d7813","user":{"login":"btecu","id":7517745,"node_id":"MDQ6VXNlcjc1MTc3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7517745?v=4","gravatar_id":"","url":"https://api.github.com/users/btecu","html_url":"https://github.com/btecu","followers_url":"https://api.github.com/users/btecu/followers","following_url":"https://api.github.com/users/btecu/following{/other_user}","gists_url":"https://api.github.com/users/btecu/gists{/gist_id}","starred_url":"https://api.github.com/users/btecu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btecu/subscriptions","organizations_url":"https://api.github.com/users/btecu/orgs","repos_url":"https://api.github.com/users/btecu/repos","events_url":"https://api.github.com/users/btecu/events{/privacy}","received_events_url":"https://api.github.com/users/btecu/received_events","type":"User","site_admin":false},"repo":{"id":136996778,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5OTY3Nzg=","name":"JsonApiDotNetCore","full_name":"btecu/JsonApiDotNetCore","owner":{"login":"btecu","id":7517745,"node_id":"MDQ6VXNlcjc1MTc3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7517745?v=4","gravatar_id":"","url":"https://api.github.com/users/btecu","html_url":"https://github.com/btecu","followers_url":"https://api.github.com/users/btecu/followers","following_url":"https://api.github.com/users/btecu/following{/other_user}","gists_url":"https://api.github.com/users/btecu/gists{/gist_id}","starred_url":"https://api.github.com/users/btecu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btecu/subscriptions","organizations_url":"https://api.github.com/users/btecu/orgs","repos_url":"https://api.github.com/users/btecu/repos","events_url":"https://api.github.com/users/btecu/events{/privacy}","received_events_url":"https://api.github.com/users/btecu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btecu/JsonApiDotNetCore","description":"JSONAPI Framework for ASP.Net Core","fork":true,"url":"https://api.github.com/repos/btecu/JsonApiDotNetCore","forks_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/forks","keys_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/teams","hooks_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/hooks","issue_events_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/events","assignees_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/tags","blobs_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/languages","stargazers_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/stargazers","contributors_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/contributors","subscribers_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/subscribers","subscription_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/subscription","commits_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/merges","archive_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/downloads","issues_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/labels{/name}","releases_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/btecu/JsonApiDotNetCore/deployments","created_at":"2018-06-12T00:43:49Z","updated_at":"2018-06-12T00:43:51Z","pushed_at":"2018-06-12T03:35:39Z","git_url":"git://github.com/btecu/JsonApiDotNetCore.git","ssh_url":"git@github.com:btecu/JsonApiDotNetCore.git","clone_url":"https://github.com/btecu/JsonApiDotNetCore.git","svn_url":"https://github.com/btecu/JsonApiDotNetCore","homepage":"https://json-api-dotnet.github.io/#/","size":2083,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"json-api-dotnet:master","ref":"master","sha":"3fc1099e15257e55573178b3dd19edd0ae6f7f16","user":{"login":"json-api-dotnet","id":30737291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzM3Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/30737291?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api-dotnet","html_url":"https://github.com/json-api-dotnet","followers_url":"https://api.github.com/users/json-api-dotnet/followers","following_url":"https://api.github.com/users/json-api-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/json-api-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api-dotnet/subscriptions","organizations_url":"https://api.github.com/users/json-api-dotnet/orgs","repos_url":"https://api.github.com/users/json-api-dotnet/repos","events_url":"https://api.github.com/users/json-api-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/json-api-dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":66287660,"node_id":"MDEwOlJlcG9zaXRvcnk2NjI4NzY2MA==","name":"JsonApiDotNetCore","full_name":"json-api-dotnet/JsonApiDotNetCore","owner":{"login":"json-api-dotnet","id":30737291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzM3Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/30737291?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api-dotnet","html_url":"https://github.com/json-api-dotnet","followers_url":"https://api.github.com/users/json-api-dotnet/followers","following_url":"https://api.github.com/users/json-api-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/json-api-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api-dotnet/subscriptions","organizations_url":"https://api.github.com/users/json-api-dotnet/orgs","repos_url":"https://api.github.com/users/json-api-dotnet/repos","events_url":"https://api.github.com/users/json-api-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/json-api-dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore","description":"JSONAPI Framework for ASP.Net Core","fork":false,"url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore","forks_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/forks","keys_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/teams","hooks_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/hooks","issue_events_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/events","assignees_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/tags","blobs_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/languages","stargazers_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/stargazers","contributors_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/contributors","subscribers_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/subscribers","subscription_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/subscription","commits_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/merges","archive_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/downloads","issues_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/labels{/name}","releases_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/deployments","created_at":"2016-08-22T16:08:10Z","updated_at":"2018-06-12T12:10:02Z","pushed_at":"2018-06-12T22:31:34Z","git_url":"git://github.com/json-api-dotnet/JsonApiDotNetCore.git","ssh_url":"git@github.com:json-api-dotnet/JsonApiDotNetCore.git","clone_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore.git","svn_url":"https://github.com/json-api-dotnet/JsonApiDotNetCore","homepage":"https://json-api-dotnet.github.io/#/","size":2071,"stargazers_count":165,"watchers_count":165,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":40,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300"},"html":{"href":"https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/300"},"issue":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/300"},"comments":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/json-api-dotnet/JsonApiDotNetCore/statuses/ad39fd74d693546b5fb064e8b789953ede3d7813"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaredcnance"}}