{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/43","repository_url":"https://api.github.com/repos/vaadin/vaadin-list-box","labels_url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/43/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/43/events","html_url":"https://github.com/vaadin/vaadin-list-box/pull/43","id":347908957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mzg3NDg1","number":43,"title":"Workaround selected item icon not shown in IE11","user":{"login":"web-padawan","id":10589913,"node_id":"MDQ6VXNlcjEwNTg5OTEz","avatar_url":"https://avatars2.githubusercontent.com/u/10589913?v=4","gravatar_id":"","url":"https://api.github.com/users/web-padawan","html_url":"https://github.com/web-padawan","followers_url":"https://api.github.com/users/web-padawan/followers","following_url":"https://api.github.com/users/web-padawan/following{/other_user}","gists_url":"https://api.github.com/users/web-padawan/gists{/gist_id}","starred_url":"https://api.github.com/users/web-padawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-padawan/subscriptions","organizations_url":"https://api.github.com/users/web-padawan/orgs","repos_url":"https://api.github.com/users/web-padawan/repos","events_url":"https://api.github.com/users/web-padawan/events{/privacy}","received_events_url":"https://api.github.com/users/web-padawan/received_events","type":"User","site_admin":false},"labels":[{"id":723783081,"node_id":"MDU6TGFiZWw3MjM3ODMwODE=","url":"https://api.github.com/repos/vaadin/vaadin-list-box/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-06T12:47:20Z","updated_at":"2018-08-08T13:56:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-list-box/pulls/43","html_url":"https://github.com/vaadin/vaadin-list-box/pull/43","diff_url":"https://github.com/vaadin/vaadin-list-box/pull/43.diff","patch_url":"https://github.com/vaadin/vaadin-list-box/pull/43.patch"},"body":"Fixes #38 \r\n\r\nDepends on vaadin/vaadin-list-mixin#42\r\n\r\nFor some reason, in IE11 items do not pick up the CSS custom property defined on the list-box element. This change workarounds that, without it `::before` pseudo elements never appear.\r\n\r\nNote that this also needs calling `updateStyles()`: without that, the original issue on the GIF happens IE11 (`::before` pseudo elements only appear on hover).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-list-box/43)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/comments/411414472","html_url":"https://github.com/vaadin/vaadin-list-box/pull/43#issuecomment-411414472","issue_url":"https://api.github.com/repos/vaadin/vaadin-list-box/issues/43","id":411414472,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTQxNDQ3Mg==","user":{"login":"sohrabtaee","id":8332863,"node_id":"MDQ6VXNlcjgzMzI4NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8332863?v=4","gravatar_id":"","url":"https://api.github.com/users/sohrabtaee","html_url":"https://github.com/sohrabtaee","followers_url":"https://api.github.com/users/sohrabtaee/followers","following_url":"https://api.github.com/users/sohrabtaee/following{/other_user}","gists_url":"https://api.github.com/users/sohrabtaee/gists{/gist_id}","starred_url":"https://api.github.com/users/sohrabtaee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohrabtaee/subscriptions","organizations_url":"https://api.github.com/users/sohrabtaee/orgs","repos_url":"https://api.github.com/users/sohrabtaee/repos","events_url":"https://api.github.com/users/sohrabtaee/events{/privacy}","received_events_url":"https://api.github.com/users/sohrabtaee/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T13:56:31Z","updated_at":"2018-08-08T13:56:31Z","author_association":"CONTRIBUTOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n\n\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"sohrabtaee"}}