{"action":"created","comment":{"url":"https://api.github.com/repos/Bixal/move.mil/pulls/comments/204451326","pull_request_review_id":139534683,"id":204451326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDQ1MTMyNg==","diff_hunk":"@@ -0,0 +1,176 @@\n+'use strict';\n+\n+const autoprefixer = require('autoprefixer');\n+const webpack = require('webpack');\n+const ExtractTextPlugin = require('extract-text-webpack-plugin');\n+const ManifestPlugin = require('webpack-manifest-plugin');\n+const InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');\n+const eslintFormatter = require('react-dev-utils/eslintFormatter');\n+const paths = require('./paths');\n+const getClientEnvironment = require('./env');\n+const apps = require('./apps');\n+\n+const publicPath = paths.servedPath;\n+const shouldUseRelativeAssetPaths = publicPath === './';\n+const shouldUseSourceMap = false;\n+const publicUrl = publicPath.slice(0, -1);\n+const env = getClientEnvironment(publicUrl);\n+\n+if (env.stringified['process.env'].NODE_ENV !== '\"production\"') {\n+  throw new Error('Production builds must have NODE_ENV=production.');\n+}\n+\n+const cssFilename = 'static/css/[name].min.css';\n+const extractTextPluginOptions = shouldUseRelativeAssetPaths\n+  ? // Making sure that the publicPath goes back to to build folder.\n+    { publicPath: Array(cssFilename.split('/').length).join('../') }\n+  : {};\n+\n+module.exports = {\n+  bail: true,\n+  devtool: shouldUseSourceMap ? 'source-map' : false,\n+  entry: apps.entryPoints,\n+  output: {\n+    path: paths.appBuild,\n+    filename: 'static/js/[name].min.js',\n+    chunkFilename: 'static/js/[name].chunk.js',\n+    publicPath: publicPath\n+  },\n+  resolve: {\n+    modules: ['node_modules'],\n+    extensions: ['.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],\n+    alias: {\n+      'react-native': 'react-native-web',\n+    }\n+  },\n+  module: {\n+    strictExportPresence: true,\n+    rules: [\n+      // TODO: Disable require.ensure as it's not a standard language feature.\n+      {\n+        test: /\\.(js|jsx|mjs)$/,","path":"web/modules/custom/react_tools/tools/config/webpack.config.prod.js","position":51,"original_position":51,"commit_id":"e47fa69cc43b65c276edb9b0f63f76087f7d105f","original_commit_id":"e47fa69cc43b65c276edb9b0f63f76087f7d105f","user":{"login":"ivonne-gov","id":37001835,"node_id":"MDQ6VXNlcjM3MDAxODM1","avatar_url":"https://avatars0.githubusercontent.com/u/37001835?v=4","gravatar_id":"","url":"https://api.github.com/users/ivonne-gov","html_url":"https://github.com/ivonne-gov","followers_url":"https://api.github.com/users/ivonne-gov/followers","following_url":"https://api.github.com/users/ivonne-gov/following{/other_user}","gists_url":"https://api.github.com/users/ivonne-gov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonne-gov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonne-gov/subscriptions","organizations_url":"https://api.github.com/users/ivonne-gov/orgs","repos_url":"https://api.github.com/users/ivonne-gov/repos","events_url":"https://api.github.com/users/ivonne-gov/events{/privacy}","received_events_url":"https://api.github.com/users/ivonne-gov/received_events","type":"User","site_admin":false},"body":"should we add this exclude line? \"exclude: /node_modules/,\", as far as I understand, this rule is for the linter only. I could be wrong.","created_at":"2018-07-23T15:42:41Z","updated_at":"2018-07-23T15:42:41Z","html_url":"https://github.com/Bixal/move.mil/pull/230#discussion_r204451326","pull_request_url":"https://api.github.com/repos/Bixal/move.mil/pulls/230","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/comments/204451326"},"html":{"href":"https://github.com/Bixal/move.mil/pull/230#discussion_r204451326"},"pull_request":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/Bixal/move.mil/pulls/230","id":203190742,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTkwNzQy","html_url":"https://github.com/Bixal/move.mil/pull/230","diff_url":"https://github.com/Bixal/move.mil/pull/230.diff","patch_url":"https://github.com/Bixal/move.mil/pull/230.patch","issue_url":"https://api.github.com/repos/Bixal/move.mil/issues/230","number":230,"state":"open","locked":false,"title":"Reducing docker image size by refactoring react webpack to share depenencies.","user":{"login":"rich-allen-gov","id":37082765,"node_id":"MDQ6VXNlcjM3MDgyNzY1","avatar_url":"https://avatars1.githubusercontent.com/u/37082765?v=4","gravatar_id":"","url":"https://api.github.com/users/rich-allen-gov","html_url":"https://github.com/rich-allen-gov","followers_url":"https://api.github.com/users/rich-allen-gov/followers","following_url":"https://api.github.com/users/rich-allen-gov/following{/other_user}","gists_url":"https://api.github.com/users/rich-allen-gov/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-allen-gov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-allen-gov/subscriptions","organizations_url":"https://api.github.com/users/rich-allen-gov/orgs","repos_url":"https://api.github.com/users/rich-allen-gov/repos","events_url":"https://api.github.com/users/rich-allen-gov/events{/privacy}","received_events_url":"https://api.github.com/users/rich-allen-gov/received_events","type":"User","site_admin":false},"body":"## Checklist\r\n\r\nI have…\r\n\r\n- [x] run the application locally (`make up`) and verified that my changes behave as expected.\r\n- [x] run static behat test suite (`circleci build --job behat`) against my changes.\r\n- [x] run the code sniffer (`circleci build --job code-sniffer`) against my changes.\r\n- [x] run the code coverage tool (`circleci build --job code-coverage`) \r\n      against my changes\r\n- [x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.\r\n- [x] thoroughly outlined below the steps necessary to test my changes.\r\n- [ ] attached screenshots illustrating relevant behavior before and after my changes.\r\n- [x] read, understand, and agree to the terms described in [CONTRIBUTING.md](https://github.com/Bixal/move.mil/blob/master/CONTRIBUTING.md).\r\n- [x] added my name, email address, and copyright date to [CONTRIBUTORS.md](https://github.com/Bixal/move.mil/blob/master/CONTRIBUTORS.md).\r\n\r\n## Summary of Changes\r\n\r\n- Alters the webpack of the react applications so they share dependencies.\r\n- Updates the dockerfile to reflect the changes.\r\n\r\n## Testing\r\n\r\n1. Build image and run locally, or deploy to an environment using the movemil:latest tag.\r\n1. Review react applications for errors.\r\n\r\nI tagged half the project here so that we can all understand what is going on. It's a substantial change from the previous build.","created_at":"2018-07-23T11:34:58Z","updated_at":"2018-07-23T15:42:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc512fdd1e25d826456c80980a3523d5496ffa0a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jkoulish-bixal","id":29130580,"node_id":"MDQ6VXNlcjI5MTMwNTgw","avatar_url":"https://avatars3.githubusercontent.com/u/29130580?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoulish-bixal","html_url":"https://github.com/jkoulish-bixal","followers_url":"https://api.github.com/users/jkoulish-bixal/followers","following_url":"https://api.github.com/users/jkoulish-bixal/following{/other_user}","gists_url":"https://api.github.com/users/jkoulish-bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoulish-bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoulish-bixal/subscriptions","organizations_url":"https://api.github.com/users/jkoulish-bixal/orgs","repos_url":"https://api.github.com/users/jkoulish-bixal/repos","events_url":"https://api.github.com/users/jkoulish-bixal/events{/privacy}","received_events_url":"https://api.github.com/users/jkoulish-bixal/received_events","type":"User","site_admin":false},{"login":"gerardo-gov","id":38885219,"node_id":"MDQ6VXNlcjM4ODg1MjE5","avatar_url":"https://avatars0.githubusercontent.com/u/38885219?v=4","gravatar_id":"","url":"https://api.github.com/users/gerardo-gov","html_url":"https://github.com/gerardo-gov","followers_url":"https://api.github.com/users/gerardo-gov/followers","following_url":"https://api.github.com/users/gerardo-gov/following{/other_user}","gists_url":"https://api.github.com/users/gerardo-gov/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardo-gov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardo-gov/subscriptions","organizations_url":"https://api.github.com/users/gerardo-gov/orgs","repos_url":"https://api.github.com/users/gerardo-gov/repos","events_url":"https://api.github.com/users/gerardo-gov/events{/privacy}","received_events_url":"https://api.github.com/users/gerardo-gov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bixal/move.mil/pulls/230/commits","review_comments_url":"https://api.github.com/repos/Bixal/move.mil/pulls/230/comments","review_comment_url":"https://api.github.com/repos/Bixal/move.mil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bixal/move.mil/issues/230/comments","statuses_url":"https://api.github.com/repos/Bixal/move.mil/statuses/e47fa69cc43b65c276edb9b0f63f76087f7d105f","head":{"label":"Bixal:custom-webpacking","ref":"custom-webpacking","sha":"e47fa69cc43b65c276edb9b0f63f76087f7d105f","user":{"login":"Bixal","id":36738597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzM4NTk3","avatar_url":"https://avatars1.githubusercontent.com/u/36738597?v=4","gravatar_id":"","url":"https://api.github.com/users/Bixal","html_url":"https://github.com/Bixal","followers_url":"https://api.github.com/users/Bixal/followers","following_url":"https://api.github.com/users/Bixal/following{/other_user}","gists_url":"https://api.github.com/users/Bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/Bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bixal/subscriptions","organizations_url":"https://api.github.com/users/Bixal/orgs","repos_url":"https://api.github.com/users/Bixal/repos","events_url":"https://api.github.com/users/Bixal/events{/privacy}","received_events_url":"https://api.github.com/users/Bixal/received_events","type":"Organization","site_admin":false},"repo":{"id":125930349,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5MzAzNDk=","name":"move.mil","full_name":"Bixal/move.mil","owner":{"login":"Bixal","id":36738597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzM4NTk3","avatar_url":"https://avatars1.githubusercontent.com/u/36738597?v=4","gravatar_id":"","url":"https://api.github.com/users/Bixal","html_url":"https://github.com/Bixal","followers_url":"https://api.github.com/users/Bixal/followers","following_url":"https://api.github.com/users/Bixal/following{/other_user}","gists_url":"https://api.github.com/users/Bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/Bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bixal/subscriptions","organizations_url":"https://api.github.com/users/Bixal/orgs","repos_url":"https://api.github.com/users/Bixal/repos","events_url":"https://api.github.com/users/Bixal/events{/privacy}","received_events_url":"https://api.github.com/users/Bixal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bixal/move.mil","description":null,"fork":false,"url":"https://api.github.com/repos/Bixal/move.mil","forks_url":"https://api.github.com/repos/Bixal/move.mil/forks","keys_url":"https://api.github.com/repos/Bixal/move.mil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bixal/move.mil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bixal/move.mil/teams","hooks_url":"https://api.github.com/repos/Bixal/move.mil/hooks","issue_events_url":"https://api.github.com/repos/Bixal/move.mil/issues/events{/number}","events_url":"https://api.github.com/repos/Bixal/move.mil/events","assignees_url":"https://api.github.com/repos/Bixal/move.mil/assignees{/user}","branches_url":"https://api.github.com/repos/Bixal/move.mil/branches{/branch}","tags_url":"https://api.github.com/repos/Bixal/move.mil/tags","blobs_url":"https://api.github.com/repos/Bixal/move.mil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bixal/move.mil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bixal/move.mil/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bixal/move.mil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bixal/move.mil/statuses/{sha}","languages_url":"https://api.github.com/repos/Bixal/move.mil/languages","stargazers_url":"https://api.github.com/repos/Bixal/move.mil/stargazers","contributors_url":"https://api.github.com/repos/Bixal/move.mil/contributors","subscribers_url":"https://api.github.com/repos/Bixal/move.mil/subscribers","subscription_url":"https://api.github.com/repos/Bixal/move.mil/subscription","commits_url":"https://api.github.com/repos/Bixal/move.mil/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bixal/move.mil/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bixal/move.mil/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bixal/move.mil/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bixal/move.mil/contents/{+path}","compare_url":"https://api.github.com/repos/Bixal/move.mil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bixal/move.mil/merges","archive_url":"https://api.github.com/repos/Bixal/move.mil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bixal/move.mil/downloads","issues_url":"https://api.github.com/repos/Bixal/move.mil/issues{/number}","pulls_url":"https://api.github.com/repos/Bixal/move.mil/pulls{/number}","milestones_url":"https://api.github.com/repos/Bixal/move.mil/milestones{/number}","notifications_url":"https://api.github.com/repos/Bixal/move.mil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bixal/move.mil/labels{/name}","releases_url":"https://api.github.com/repos/Bixal/move.mil/releases{/id}","deployments_url":"https://api.github.com/repos/Bixal/move.mil/deployments","created_at":"2018-03-19T22:50:16Z","updated_at":"2018-07-19T12:33:15Z","pushed_at":"2018-07-23T15:12:51Z","git_url":"git://github.com/Bixal/move.mil.git","ssh_url":"git@github.com:Bixal/move.mil.git","clone_url":"https://github.com/Bixal/move.mil.git","svn_url":"https://github.com/Bixal/move.mil","homepage":null,"size":11136,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"1.x-dev"}},"base":{"label":"Bixal:1.x-dev","ref":"1.x-dev","sha":"787b33ceae2ad55dadc2678b17f78f5cd6700aa6","user":{"login":"Bixal","id":36738597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzM4NTk3","avatar_url":"https://avatars1.githubusercontent.com/u/36738597?v=4","gravatar_id":"","url":"https://api.github.com/users/Bixal","html_url":"https://github.com/Bixal","followers_url":"https://api.github.com/users/Bixal/followers","following_url":"https://api.github.com/users/Bixal/following{/other_user}","gists_url":"https://api.github.com/users/Bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/Bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bixal/subscriptions","organizations_url":"https://api.github.com/users/Bixal/orgs","repos_url":"https://api.github.com/users/Bixal/repos","events_url":"https://api.github.com/users/Bixal/events{/privacy}","received_events_url":"https://api.github.com/users/Bixal/received_events","type":"Organization","site_admin":false},"repo":{"id":125930349,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5MzAzNDk=","name":"move.mil","full_name":"Bixal/move.mil","owner":{"login":"Bixal","id":36738597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzM4NTk3","avatar_url":"https://avatars1.githubusercontent.com/u/36738597?v=4","gravatar_id":"","url":"https://api.github.com/users/Bixal","html_url":"https://github.com/Bixal","followers_url":"https://api.github.com/users/Bixal/followers","following_url":"https://api.github.com/users/Bixal/following{/other_user}","gists_url":"https://api.github.com/users/Bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/Bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bixal/subscriptions","organizations_url":"https://api.github.com/users/Bixal/orgs","repos_url":"https://api.github.com/users/Bixal/repos","events_url":"https://api.github.com/users/Bixal/events{/privacy}","received_events_url":"https://api.github.com/users/Bixal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bixal/move.mil","description":null,"fork":false,"url":"https://api.github.com/repos/Bixal/move.mil","forks_url":"https://api.github.com/repos/Bixal/move.mil/forks","keys_url":"https://api.github.com/repos/Bixal/move.mil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bixal/move.mil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bixal/move.mil/teams","hooks_url":"https://api.github.com/repos/Bixal/move.mil/hooks","issue_events_url":"https://api.github.com/repos/Bixal/move.mil/issues/events{/number}","events_url":"https://api.github.com/repos/Bixal/move.mil/events","assignees_url":"https://api.github.com/repos/Bixal/move.mil/assignees{/user}","branches_url":"https://api.github.com/repos/Bixal/move.mil/branches{/branch}","tags_url":"https://api.github.com/repos/Bixal/move.mil/tags","blobs_url":"https://api.github.com/repos/Bixal/move.mil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bixal/move.mil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bixal/move.mil/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bixal/move.mil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bixal/move.mil/statuses/{sha}","languages_url":"https://api.github.com/repos/Bixal/move.mil/languages","stargazers_url":"https://api.github.com/repos/Bixal/move.mil/stargazers","contributors_url":"https://api.github.com/repos/Bixal/move.mil/contributors","subscribers_url":"https://api.github.com/repos/Bixal/move.mil/subscribers","subscription_url":"https://api.github.com/repos/Bixal/move.mil/subscription","commits_url":"https://api.github.com/repos/Bixal/move.mil/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bixal/move.mil/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bixal/move.mil/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bixal/move.mil/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bixal/move.mil/contents/{+path}","compare_url":"https://api.github.com/repos/Bixal/move.mil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bixal/move.mil/merges","archive_url":"https://api.github.com/repos/Bixal/move.mil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bixal/move.mil/downloads","issues_url":"https://api.github.com/repos/Bixal/move.mil/issues{/number}","pulls_url":"https://api.github.com/repos/Bixal/move.mil/pulls{/number}","milestones_url":"https://api.github.com/repos/Bixal/move.mil/milestones{/number}","notifications_url":"https://api.github.com/repos/Bixal/move.mil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bixal/move.mil/labels{/name}","releases_url":"https://api.github.com/repos/Bixal/move.mil/releases{/id}","deployments_url":"https://api.github.com/repos/Bixal/move.mil/deployments","created_at":"2018-03-19T22:50:16Z","updated_at":"2018-07-19T12:33:15Z","pushed_at":"2018-07-23T15:12:51Z","git_url":"git://github.com/Bixal/move.mil.git","ssh_url":"git@github.com:Bixal/move.mil.git","clone_url":"https://github.com/Bixal/move.mil.git","svn_url":"https://github.com/Bixal/move.mil","homepage":null,"size":11136,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"1.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/230"},"html":{"href":"https://github.com/Bixal/move.mil/pull/230"},"issue":{"href":"https://api.github.com/repos/Bixal/move.mil/issues/230"},"comments":{"href":"https://api.github.com/repos/Bixal/move.mil/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bixal/move.mil/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/Bixal/move.mil/statuses/e47fa69cc43b65c276edb9b0f63f76087f7d105f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ivonne-gov"}}