{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/172978123","pull_request_review_id":102089563,"id":172978123,"diff_hunk":"@@ -37,7 +37,7 @@ export namespace LocalizedFontFamilies {\n   export const Selawik = `'${LocalizedFontNames.Selawik}'`;\n   export const Thai = `'Leelawadee UI Web', 'Kmer UI'`;\n   export const Vietnamese = `'${LocalizedFontNames.Vietnamese}'`;\n-  export const WestEuropean = `'${LocalizedFontNames.WestEuropean}'`;\n+  export const WestEuropean = `'Segoe UI', '${LocalizedFontNames.WestEuropean}'`;","path":"packages/styling/src/styles/fonts.ts","position":5,"original_position":5,"commit_id":"9f31b327134c390e577fb1b86e6b421c32b20fb3","original_commit_id":"9f31b327134c390e577fb1b86e6b421c32b20fb3","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars2.githubusercontent.com/u/1581488?v=4","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"body":"Hmm, this probably breaks things, let me look into the local() option instead for the default font","created_at":"2018-03-07T20:42:56Z","updated_at":"2018-03-07T20:42:57Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206#discussion_r172978123","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/172978123"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206#discussion_r172978123"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206","id":173558241,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4206","number":4206,"state":"open","locked":false,"title":"Try to use the system Segoe UI by default instead of downloading a web font","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars2.githubusercontent.com/u/1581488?v=4","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\nRight now the default styles set for fabric text is \"'Segoe UI Web (West European)', 'Segoe UI'\". Since the web font is first, we always will download the web font. This is a waste of ~100K (even more on browsers that don't support woff2) if the user already has that font installed:\r\n\r\n![image](https://user-images.githubusercontent.com/1581488/37114808-313ffd1e-21fe-11e8-98b7-73a317bd9f90.png)\r\n\r\nWith this change, we will make the default font \"'Segoe UI', 'Segoe UI Web (West European)'\", which by default will try to use the system font, otherwise it will fall back to the webfont. With this change we won't download any web fonts by default for Chrome and FF. \r\n\r\nUnfortunately, Edge and IE still download the fonts in this case. To make this work in Edge/IE, we'd have to change the definition of the Segoe UI Web (West European) font face to include `local(\"Segoe UI\")`. I'd be glad to explore that as well, but it is a slightly more involved PR with that change.\r\n\r\nI'm not changing anything with the localized fonts, since those are intentionally not using Segoe UI.\r\n\r\n#### Focus areas to test\r\nVerified that things look correct in IE, Edge, FF, Chrome.\r\n","created_at":"2018-03-07T20:00:22Z","updated_at":"2018-03-07T20:42:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74c4cf52a84305c16a92390eba098ff108389652","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dzearing","id":1110944,"avatar_url":"https://avatars3.githubusercontent.com/u/1110944?v=4","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},{"login":"phkuo","id":20691641,"avatar_url":"https://avatars1.githubusercontent.com/u/20691641?v=4","gravatar_id":"","url":"https://api.github.com/users/phkuo","html_url":"https://github.com/phkuo","followers_url":"https://api.github.com/users/phkuo/followers","following_url":"https://api.github.com/users/phkuo/following{/other_user}","gists_url":"https://api.github.com/users/phkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/phkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phkuo/subscriptions","organizations_url":"https://api.github.com/users/phkuo/orgs","repos_url":"https://api.github.com/users/phkuo/repos","events_url":"https://api.github.com/users/phkuo/events{/privacy}","received_events_url":"https://api.github.com/users/phkuo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4206/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/9f31b327134c390e577fb1b86e6b421c32b20fb3","head":{"label":"christiango:chrisgo/system-font-default","ref":"chrisgo/system-font-default","sha":"9f31b327134c390e577fb1b86e6b421c32b20fb3","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars2.githubusercontent.com/u/1581488?v=4","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"repo":{"id":84107423,"name":"office-ui-fabric-react","full_name":"christiango/office-ui-fabric-react","owner":{"login":"christiango","id":1581488,"avatar_url":"https://avatars2.githubusercontent.com/u/1581488?v=4","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christiango/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/christiango/office-ui-fabric-react","forks_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/deployments","created_at":"2017-03-06T18:35:50Z","updated_at":"2017-03-06T18:35:53Z","pushed_at":"2018-03-07T19:59:29Z","git_url":"git://github.com/christiango/office-ui-fabric-react.git","ssh_url":"git@github.com:christiango/office-ui-fabric-react.git","clone_url":"https://github.com/christiango/office-ui-fabric-react.git","svn_url":"https://github.com/christiango/office-ui-fabric-react","homepage":"http://dev.office.com/fabric#/components","size":21585,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"bde921d87d3b6c75c0886409a38a2f7a5200fcff","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-03-07T18:39:51Z","pushed_at":"2018-03-07T20:00:23Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":24474,"stargazers_count":2338,"watchers_count":2338,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":490,"mirror_url":null,"archived":false,"open_issues_count":490,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":490,"open_issues":490,"watchers":2338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4206"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4206"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4206/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4206/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/9f31b327134c390e577fb1b86e6b421c32b20fb3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"christiango"}}