{"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/comments/214908308","pull_request_review_id":152058434,"id":214908308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDkwODMwOA==","diff_hunk":"@@ -231,10 +226,18 @@ def _get_trace_context(self, execution_id):\n         return None\n \n     def _post_generic_trigger(self, liveaction_db=None, execution_db=None):\n-        if not ACTION_SENSOR_ENABLED:\n+        if not cfg.CONF.action_sensor.enable:\n             LOG.debug('Action trigger is disabled, skipping trigger dispatch...')\n             return\n \n+        target_statuses = cfg.CONF.action_sensor.emit_when","path":"st2actions/st2actions/notifier/notifier.py","position":48,"original_position":48,"commit_id":"aa6157c77fc8604307bf35992bd7782d6a1ff7bd","original_commit_id":"233055a947a5e8493597b1ca1977acba71581f05","user":{"login":"shusugmt","id":463529,"node_id":"MDQ6VXNlcjQ2MzUyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/463529?v=4","gravatar_id":"","url":"https://api.github.com/users/shusugmt","html_url":"https://github.com/shusugmt","followers_url":"https://api.github.com/users/shusugmt/followers","following_url":"https://api.github.com/users/shusugmt/following{/other_user}","gists_url":"https://api.github.com/users/shusugmt/gists{/gist_id}","starred_url":"https://api.github.com/users/shusugmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shusugmt/subscriptions","organizations_url":"https://api.github.com/users/shusugmt/orgs","repos_url":"https://api.github.com/users/shusugmt/repos","events_url":"https://api.github.com/users/shusugmt/events{/privacy}","received_events_url":"https://api.github.com/users/shusugmt/received_events","type":"User","site_admin":false},"body":"Will do. Thanks for the comments!","created_at":"2018-09-04T13:14:56Z","updated_at":"2018-09-04T13:14:56Z","html_url":"https://github.com/StackStorm/st2/pull/4315#discussion_r214908308","pull_request_url":"https://api.github.com/repos/StackStorm/st2/pulls/4315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments/214908308"},"html":{"href":"https://github.com/StackStorm/st2/pull/4315#discussion_r214908308"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4315"}},"in_reply_to_id":214699235},"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/4315","id":210795196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzk1MTk2","html_url":"https://github.com/StackStorm/st2/pull/4315","diff_url":"https://github.com/StackStorm/st2/pull/4315.diff","patch_url":"https://github.com/StackStorm/st2/pull/4315.patch","issue_url":"https://api.github.com/repos/StackStorm/st2/issues/4315","number":4315,"state":"open","locked":false,"title":"Add option to specify when to emit st2.generic.actiontrigger","user":{"login":"shusugmt","id":463529,"node_id":"MDQ6VXNlcjQ2MzUyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/463529?v=4","gravatar_id":"","url":"https://api.github.com/users/shusugmt","html_url":"https://github.com/shusugmt","followers_url":"https://api.github.com/users/shusugmt/followers","following_url":"https://api.github.com/users/shusugmt/following{/other_user}","gists_url":"https://api.github.com/users/shusugmt/gists{/gist_id}","starred_url":"https://api.github.com/users/shusugmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shusugmt/subscriptions","organizations_url":"https://api.github.com/users/shusugmt/orgs","repos_url":"https://api.github.com/users/shusugmt/repos","events_url":"https://api.github.com/users/shusugmt/events{/privacy}","received_events_url":"https://api.github.com/users/shusugmt/received_events","type":"User","site_admin":false},"body":"As per motivation addressed in #4312 \r\n\r\n- Introduced new config parameter `action_sensor.emit_when` which specifies the states when to emit `st2.generic.actiontrigger`\r\n- If not specified, it defaults to `LIVEACTION_COMPLETED_STATES ` that is the exact same behavior as before. Meaning this change will not affect any existing deployments.\r\n- If any state is given, it overrides the default. So users can even choose only to make actiontrigger emitted at for e.g. cancelled. If users want to completely disable this trigger then they can use existing `action_sensor.enable` parameter set to False.\r\n- This PR also includes a bug fix that `action_sensor.enable` parameter was not honored at all.","created_at":"2018-08-24T16:56:30Z","updated_at":"2018-09-04T13:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b80b8418d2969a45f52a603771fa2c07cf4a056","assignee":{"login":"Kami","id":125088,"node_id":"MDQ6VXNlcjEyNTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/125088?v=4","gravatar_id":"","url":"https://api.github.com/users/Kami","html_url":"https://github.com/Kami","followers_url":"https://api.github.com/users/Kami/followers","following_url":"https://api.github.com/users/Kami/following{/other_user}","gists_url":"https://api.github.com/users/Kami/gists{/gist_id}","starred_url":"https://api.github.com/users/Kami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kami/subscriptions","organizations_url":"https://api.github.com/users/Kami/orgs","repos_url":"https://api.github.com/users/Kami/repos","events_url":"https://api.github.com/users/Kami/events{/privacy}","received_events_url":"https://api.github.com/users/Kami/received_events","type":"User","site_admin":false},"assignees":[{"login":"Kami","id":125088,"node_id":"MDQ6VXNlcjEyNTA4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/125088?v=4","gravatar_id":"","url":"https://api.github.com/users/Kami","html_url":"https://github.com/Kami","followers_url":"https://api.github.com/users/Kami/followers","following_url":"https://api.github.com/users/Kami/following{/other_user}","gists_url":"https://api.github.com/users/Kami/gists{/gist_id}","starred_url":"https://api.github.com/users/Kami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kami/subscriptions","organizations_url":"https://api.github.com/users/Kami/orgs","repos_url":"https://api.github.com/users/Kami/repos","events_url":"https://api.github.com/users/Kami/events{/privacy}","received_events_url":"https://api.github.com/users/Kami/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/StackStorm/st2/milestones/22","html_url":"https://github.com/StackStorm/st2/milestone/22","labels_url":"https://api.github.com/repos/StackStorm/st2/milestones/22/labels","id":3423267,"node_id":"MDk6TWlsZXN0b25lMzQyMzI2Nw==","number":22,"title":"2.9.0","description":null,"creator":{"login":"lakshmi-kannan","id":1839421,"node_id":"MDQ6VXNlcjE4Mzk0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839421?v=4","gravatar_id":"","url":"https://api.github.com/users/lakshmi-kannan","html_url":"https://github.com/lakshmi-kannan","followers_url":"https://api.github.com/users/lakshmi-kannan/followers","following_url":"https://api.github.com/users/lakshmi-kannan/following{/other_user}","gists_url":"https://api.github.com/users/lakshmi-kannan/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmi-kannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmi-kannan/subscriptions","organizations_url":"https://api.github.com/users/lakshmi-kannan/orgs","repos_url":"https://api.github.com/users/lakshmi-kannan/repos","events_url":"https://api.github.com/users/lakshmi-kannan/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmi-kannan/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":55,"state":"open","created_at":"2018-06-13T20:46:54Z","updated_at":"2018-09-04T11:24:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/StackStorm/st2/pulls/4315/commits","review_comments_url":"https://api.github.com/repos/StackStorm/st2/pulls/4315/comments","review_comment_url":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/st2/issues/4315/comments","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/aa6157c77fc8604307bf35992bd7782d6a1ff7bd","head":{"label":"shusugmt:selectable-actiontrigger","ref":"selectable-actiontrigger","sha":"aa6157c77fc8604307bf35992bd7782d6a1ff7bd","user":{"login":"shusugmt","id":463529,"node_id":"MDQ6VXNlcjQ2MzUyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/463529?v=4","gravatar_id":"","url":"https://api.github.com/users/shusugmt","html_url":"https://github.com/shusugmt","followers_url":"https://api.github.com/users/shusugmt/followers","following_url":"https://api.github.com/users/shusugmt/following{/other_user}","gists_url":"https://api.github.com/users/shusugmt/gists{/gist_id}","starred_url":"https://api.github.com/users/shusugmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shusugmt/subscriptions","organizations_url":"https://api.github.com/users/shusugmt/orgs","repos_url":"https://api.github.com/users/shusugmt/repos","events_url":"https://api.github.com/users/shusugmt/events{/privacy}","received_events_url":"https://api.github.com/users/shusugmt/received_events","type":"User","site_admin":false},"repo":{"id":66457600,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ1NzYwMA==","name":"st2","full_name":"shusugmt/st2","owner":{"login":"shusugmt","id":463529,"node_id":"MDQ6VXNlcjQ2MzUyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/463529?v=4","gravatar_id":"","url":"https://api.github.com/users/shusugmt","html_url":"https://github.com/shusugmt","followers_url":"https://api.github.com/users/shusugmt/followers","following_url":"https://api.github.com/users/shusugmt/following{/other_user}","gists_url":"https://api.github.com/users/shusugmt/gists{/gist_id}","starred_url":"https://api.github.com/users/shusugmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shusugmt/subscriptions","organizations_url":"https://api.github.com/users/shusugmt/orgs","repos_url":"https://api.github.com/users/shusugmt/repos","events_url":"https://api.github.com/users/shusugmt/events{/privacy}","received_events_url":"https://api.github.com/users/shusugmt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shusugmt/st2","description":"StackStorm (aka \"IFTTT for Ops\") is event-driven automation commonly used for auto-remediation, security responses, facilitated troubleshooting, complex deployments, and more. Includes rules engine, workflow,1800+ integrations (see /st2contrib), native ChatOps and so forth.  Installer available at http://docs.stackstorm.com/install/index.html. Ping us on slack - https://stackstorm-community.slack.com/. ","fork":true,"url":"https://api.github.com/repos/shusugmt/st2","forks_url":"https://api.github.com/repos/shusugmt/st2/forks","keys_url":"https://api.github.com/repos/shusugmt/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shusugmt/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shusugmt/st2/teams","hooks_url":"https://api.github.com/repos/shusugmt/st2/hooks","issue_events_url":"https://api.github.com/repos/shusugmt/st2/issues/events{/number}","events_url":"https://api.github.com/repos/shusugmt/st2/events","assignees_url":"https://api.github.com/repos/shusugmt/st2/assignees{/user}","branches_url":"https://api.github.com/repos/shusugmt/st2/branches{/branch}","tags_url":"https://api.github.com/repos/shusugmt/st2/tags","blobs_url":"https://api.github.com/repos/shusugmt/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shusugmt/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shusugmt/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/shusugmt/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shusugmt/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/shusugmt/st2/languages","stargazers_url":"https://api.github.com/repos/shusugmt/st2/stargazers","contributors_url":"https://api.github.com/repos/shusugmt/st2/contributors","subscribers_url":"https://api.github.com/repos/shusugmt/st2/subscribers","subscription_url":"https://api.github.com/repos/shusugmt/st2/subscription","commits_url":"https://api.github.com/repos/shusugmt/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/shusugmt/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/shusugmt/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/shusugmt/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/shusugmt/st2/contents/{+path}","compare_url":"https://api.github.com/repos/shusugmt/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shusugmt/st2/merges","archive_url":"https://api.github.com/repos/shusugmt/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shusugmt/st2/downloads","issues_url":"https://api.github.com/repos/shusugmt/st2/issues{/number}","pulls_url":"https://api.github.com/repos/shusugmt/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/shusugmt/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/shusugmt/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shusugmt/st2/labels{/name}","releases_url":"https://api.github.com/repos/shusugmt/st2/releases{/id}","deployments_url":"https://api.github.com/repos/shusugmt/st2/deployments","created_at":"2016-08-24T11:14:48Z","updated_at":"2018-08-24T08:34:13Z","pushed_at":"2018-09-04T11:26:58Z","git_url":"git://github.com/shusugmt/st2.git","ssh_url":"git@github.com:shusugmt/st2.git","clone_url":"https://github.com/shusugmt/st2.git","svn_url":"https://github.com/shusugmt/st2","homepage":"http://www.stackstorm.com/","size":24896,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"65c1ac79646508b68dfc8d75b325c241fa5a0f73","user":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":19051806,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA1MTgwNg==","name":"st2","full_name":"StackStorm/st2","owner":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2","description":"StackStorm (aka \"IFTTT for Ops\") is event-driven automation for auto-remediation, security responses, troubleshooting, deployments, and more. Includes rules engine, workflow, 2000+ integrations (see https://exchange.stackstorm.org), ChatOps, etc. Installer at https://docs.stackstorm.com/install/index.html. Questions? https://forum.stackstorm.com/.","fork":false,"url":"https://api.github.com/repos/StackStorm/st2","forks_url":"https://api.github.com/repos/StackStorm/st2/forks","keys_url":"https://api.github.com/repos/StackStorm/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2/events","assignees_url":"https://api.github.com/repos/StackStorm/st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2/merges","archive_url":"https://api.github.com/repos/StackStorm/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2/deployments","created_at":"2014-04-23T00:51:34Z","updated_at":"2018-09-04T11:24:26Z","pushed_at":"2018-09-04T13:14:41Z","git_url":"git://github.com/StackStorm/st2.git","ssh_url":"git@github.com:StackStorm/st2.git","clone_url":"https://github.com/StackStorm/st2.git","svn_url":"https://github.com/StackStorm/st2","homepage":"http://www.stackstorm.com/","size":25563,"stargazers_count":2770,"watchers_count":2770,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":347,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":368,"open_issues":347,"watchers":2770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4315"},"html":{"href":"https://github.com/StackStorm/st2/pull/4315"},"issue":{"href":"https://api.github.com/repos/StackStorm/st2/issues/4315"},"comments":{"href":"https://api.github.com/repos/StackStorm/st2/issues/4315/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4315/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4315/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/st2/statuses/aa6157c77fc8604307bf35992bd7782d6a1ff7bd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shusugmt"}}