{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44233","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44233/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44233/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44233/events","html_url":"https://github.com/NixOS/nixpkgs/pull/44233","id":345829986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODU3NTI1","number":44233,"title":"nixos/networkd: add missing options","user":{"login":"jfrankenau","id":2736480,"node_id":"MDQ6VXNlcjI3MzY0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2736480?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrankenau","html_url":"https://github.com/jfrankenau","followers_url":"https://api.github.com/users/jfrankenau/followers","following_url":"https://api.github.com/users/jfrankenau/following{/other_user}","gists_url":"https://api.github.com/users/jfrankenau/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrankenau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrankenau/subscriptions","organizations_url":"https://api.github.com/users/jfrankenau/orgs","repos_url":"https://api.github.com/users/jfrankenau/repos","events_url":"https://api.github.com/users/jfrankenau/events{/privacy}","received_events_url":"https://api.github.com/users/jfrankenau/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-30T16:17:54Z","updated_at":"2018-08-13T11:09:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44233","html_url":"https://github.com/NixOS/nixpkgs/pull/44233","diff_url":"https://github.com/NixOS/nixpkgs/pull/44233.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44233.patch"},"body":"###### Motivation for this change\r\n\r\nThe networkd module misses quite a few options which I'd like to use.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/412483952","html_url":"https://github.com/NixOS/nixpkgs/pull/44233#issuecomment-412483952","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44233","id":412483952,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQ4Mzk1Mg==","user":{"login":"flokli","id":183879,"node_id":"MDQ6VXNlcjE4Mzg3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/183879?v=4","gravatar_id":"","url":"https://api.github.com/users/flokli","html_url":"https://github.com/flokli","followers_url":"https://api.github.com/users/flokli/followers","following_url":"https://api.github.com/users/flokli/following{/other_user}","gists_url":"https://api.github.com/users/flokli/gists{/gist_id}","starred_url":"https://api.github.com/users/flokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flokli/subscriptions","organizations_url":"https://api.github.com/users/flokli/orgs","repos_url":"https://api.github.com/users/flokli/repos","events_url":"https://api.github.com/users/flokli/events{/privacy}","received_events_url":"https://api.github.com/users/flokli/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T11:09:41Z","updated_at":"2018-08-13T11:09:41Z","author_association":"CONTRIBUTOR","body":"yes, of course - github autocompletion gone wrong, sorry :-)"}}
{"actor":{"display_login":"flokli"}}