{"action":"opened","issue":{"url":"https://api.github.com/repos/amberframework/amber/issues/759","repository_url":"https://api.github.com/repos/amberframework/amber","labels_url":"https://api.github.com/repos/amberframework/amber/issues/759/labels{/name}","comments_url":"https://api.github.com/repos/amberframework/amber/issues/759/comments","events_url":"https://api.github.com/repos/amberframework/amber/issues/759/events","html_url":"https://github.com/amberframework/amber/issues/759","id":314907241,"number":759,"title":"Remove commented branch masted line from generated projects","user":{"login":"faustinoaq","id":3067335,"avatar_url":"https://avatars2.githubusercontent.com/u/3067335?v=4","gravatar_id":"","url":"https://api.github.com/users/faustinoaq","html_url":"https://github.com/faustinoaq","followers_url":"https://api.github.com/users/faustinoaq/followers","following_url":"https://api.github.com/users/faustinoaq/following{/other_user}","gists_url":"https://api.github.com/users/faustinoaq/gists{/gist_id}","starred_url":"https://api.github.com/users/faustinoaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustinoaq/subscriptions","organizations_url":"https://api.github.com/users/faustinoaq/orgs","repos_url":"https://api.github.com/users/faustinoaq/repos","events_url":"https://api.github.com/users/faustinoaq/events{/privacy}","received_events_url":"https://api.github.com/users/faustinoaq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-17T05:10:08Z","updated_at":"2018-04-17T05:10:08Z","closed_at":null,"author_association":"MEMBER","body":"### Description\r\n\r\nCurrently, the `shard.yml` file in projects generated by `amber new` has this:\r\n\r\n```yaml\r\ndependencies:\r\n  amber:\r\n    github: amberframework/amber\r\n    version: 0.7.2\r\n    #branch: master\r\n``` \r\n\r\n\r\nWhy we are using this line `#branch: master`, well, I guess is because tests, right?\r\n\r\nBecause we, need to have `branch: master` in our master branch to execute tests successfully:\r\n\r\nhttps://github.com/amberframework/amber/blob/bea1063f640e0c7466989fd50cd0453b812d7a39/src/amber/cli/templates/app/shard.yml.ecr#L18-L22\r\n\r\nSo, then I think we can avoid that by using this code:\r\n\r\n```yaml\r\ndependencies:\r\n  amber:\r\n    github: amberframework/amber\r\n    <%- if ENV[\"AMBER_ENV\"]? == \"test\" -%>\r\n    branch: master\r\n    <%- else -%>\r\n    version: <%= Amber::VERSION %>\r\n    <%- end -%>\r\n``` \r\n\r\nWe are already using `AMBER_ENV=test` in for the specs, so I think this would work well (tested locally)\r\n\r\n### Steps to Reproduce\r\n\r\n1. Generate new project\r\n2. Open `shard.yml`\r\n\r\n**Expected behavior:** See:\r\n\r\n```yaml\r\ndependencies:\r\n  amber:\r\n    github: amberframework/amber\r\n    version: 0.7.2\r\n``` \r\n\r\n**Actual behavior:** [What actually happens]\r\n\r\n```yaml\r\ndependencies:\r\n  amber:\r\n    github: amberframework/amber\r\n    version: 0.7.2\r\n    #branch: master\r\n``` \r\n\r\n**Reproduces how often:** 100%\r\n\r\n### Versions\r\n\r\n0.7.2\r\n\r\n### Additional Information\r\n\r\nAlready @robacarp tried to fix something similar in https://github.com/amberframework/amber/pull/727, although I think this would be a better approach. I will open a PR about this soon\r\n\r\nBTW, I think if we do this we don't need to use the @elorest script anymore to change comment/comment lines, before every release, so the steps before releasing will be easier:\r\n\r\n0. Testing, testing and more testing (no to believe just in Travis :stuck_out_tongue_winking_eye: )\r\n1 Change versions on `shard.yml` and `version.cr`\r\n2. Create the  proper tag\r\n3. Publishing a new release.\r\n\r\nWDYT?\r\n"}}
{"actor":{"display_login":"faustinoaq"}}