{"action":"created","comment":{"url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/comments/231052105","pull_request_review_id":171928437,"id":231052105,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA1MjEwNQ==","diff_hunk":"@@ -59,4 +60,25 @@ public void swap(int from, int to) {\n   private boolean isAccessible(int from) {\n     return from >= 0 && from < size();\n   }\n+\n+  @Override\n+  public boolean equals(Object o) {\n+    if (this == o) {\n+      return true;\n+    }\n+    if (o.getClass() != this.getClass()) {","path":"src/main/java/org/tron/common/runtime/vm/program/Stack.java","position":26,"original_position":26,"commit_id":"a6ecf1c0b8988ab3e4f94bae8723c4939bbd95b6","original_commit_id":"a6ecf1c0b8988ab3e4f94bae8723c4939bbd95b6","user":{"login":"hongz","id":1274944,"node_id":"MDQ6VXNlcjEyNzQ5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1274944?v=4","gravatar_id":"","url":"https://api.github.com/users/hongz","html_url":"https://github.com/hongz","followers_url":"https://api.github.com/users/hongz/followers","following_url":"https://api.github.com/users/hongz/following{/other_user}","gists_url":"https://api.github.com/users/hongz/gists{/gist_id}","starred_url":"https://api.github.com/users/hongz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongz/subscriptions","organizations_url":"https://api.github.com/users/hongz/orgs","repos_url":"https://api.github.com/users/hongz/repos","events_url":"https://api.github.com/users/hongz/events{/privacy}","received_events_url":"https://api.github.com/users/hongz/received_events","type":"User","site_admin":false},"body":"![Bug](https://sonarsource.github.io/sonar-github/bug.png 'Bug') Bug: A \"NullPointerException\" could be thrown; \"o\" is nullable here. ([squid:S2259](https://sonarcloud.io/organizations/tron-zhaohong/rules#rule_key=squid%3AS2259))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=java-tron&pullRequest=1681&issues=AWboX3TKLpqqSUlc8eNB&open=AWboX3TKLpqqSUlc8eNB)\n\n[ISSUE_KEY]: AWboX3TKLpqqSUlc8eNB","created_at":"2018-11-06T09:34:26Z","updated_at":"2018-11-06T09:34:27Z","html_url":"https://github.com/tronprotocol/java-tron/pull/1681#discussion_r231052105","pull_request_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/comments/231052105"},"html":{"href":"https://github.com/tronprotocol/java-tron/pull/1681#discussion_r231052105"},"pull_request":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681"}}},"pull_request":{"url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681","id":228563089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTYzMDg5","html_url":"https://github.com/tronprotocol/java-tron/pull/1681","diff_url":"https://github.com/tronprotocol/java-tron/pull/1681.diff","patch_url":"https://github.com/tronprotocol/java-tron/pull/1681.patch","issue_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/1681","number":1681,"state":"open","locked":false,"title":"Vm code smell","user":{"login":"ithinker1991","id":5145021,"node_id":"MDQ6VXNlcjUxNDUwMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5145021?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinker1991","html_url":"https://github.com/ithinker1991","followers_url":"https://api.github.com/users/ithinker1991/followers","following_url":"https://api.github.com/users/ithinker1991/following{/other_user}","gists_url":"https://api.github.com/users/ithinker1991/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinker1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinker1991/subscriptions","organizations_url":"https://api.github.com/users/ithinker1991/orgs","repos_url":"https://api.github.com/users/ithinker1991/repos","events_url":"https://api.github.com/users/ithinker1991/events{/privacy}","received_events_url":"https://api.github.com/users/ithinker1991/received_events","type":"User","site_admin":false},"body":"**What does this PR do?**\r\nfix vm code smell\r\n\r\n**Why are these changes required?**\r\n\r\n**This PR has been tested by:**\r\n- Unit Tests\r\n- Manual Testing\r\n\r\n**Follow up**\r\n\r\n**Extra details**\r\n\r\n","created_at":"2018-11-06T03:23:30Z","updated_at":"2018-11-06T09:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd4a654ae716ea4d82b2fbb6c9acbf3364f05faa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681/commits","review_comments_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681/comments","review_comment_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/1681/comments","statuses_url":"https://api.github.com/repos/tronprotocol/java-tron/statuses/a6ecf1c0b8988ab3e4f94bae8723c4939bbd95b6","head":{"label":"tronprotocol:vm_code_smell","ref":"vm_code_smell","sha":"a6ecf1c0b8988ab3e4f94bae8723c4939bbd95b6","user":{"login":"tronprotocol","id":34857411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODU3NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/34857411?v=4","gravatar_id":"","url":"https://api.github.com/users/tronprotocol","html_url":"https://github.com/tronprotocol","followers_url":"https://api.github.com/users/tronprotocol/followers","following_url":"https://api.github.com/users/tronprotocol/following{/other_user}","gists_url":"https://api.github.com/users/tronprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/tronprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tronprotocol/subscriptions","organizations_url":"https://api.github.com/users/tronprotocol/orgs","repos_url":"https://api.github.com/users/tronprotocol/repos","events_url":"https://api.github.com/users/tronprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/tronprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":115411826,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MTE4MjY=","name":"java-tron","full_name":"tronprotocol/java-tron","private":false,"owner":{"login":"tronprotocol","id":34857411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODU3NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/34857411?v=4","gravatar_id":"","url":"https://api.github.com/users/tronprotocol","html_url":"https://github.com/tronprotocol","followers_url":"https://api.github.com/users/tronprotocol/followers","following_url":"https://api.github.com/users/tronprotocol/following{/other_user}","gists_url":"https://api.github.com/users/tronprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/tronprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tronprotocol/subscriptions","organizations_url":"https://api.github.com/users/tronprotocol/orgs","repos_url":"https://api.github.com/users/tronprotocol/repos","events_url":"https://api.github.com/users/tronprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/tronprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tronprotocol/java-tron","description":"Java implementation of the Tron whitepaper","fork":false,"url":"https://api.github.com/repos/tronprotocol/java-tron","forks_url":"https://api.github.com/repos/tronprotocol/java-tron/forks","keys_url":"https://api.github.com/repos/tronprotocol/java-tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tronprotocol/java-tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tronprotocol/java-tron/teams","hooks_url":"https://api.github.com/repos/tronprotocol/java-tron/hooks","issue_events_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/events{/number}","events_url":"https://api.github.com/repos/tronprotocol/java-tron/events","assignees_url":"https://api.github.com/repos/tronprotocol/java-tron/assignees{/user}","branches_url":"https://api.github.com/repos/tronprotocol/java-tron/branches{/branch}","tags_url":"https://api.github.com/repos/tronprotocol/java-tron/tags","blobs_url":"https://api.github.com/repos/tronprotocol/java-tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tronprotocol/java-tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tronprotocol/java-tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/tronprotocol/java-tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tronprotocol/java-tron/statuses/{sha}","languages_url":"https://api.github.com/repos/tronprotocol/java-tron/languages","stargazers_url":"https://api.github.com/repos/tronprotocol/java-tron/stargazers","contributors_url":"https://api.github.com/repos/tronprotocol/java-tron/contributors","subscribers_url":"https://api.github.com/repos/tronprotocol/java-tron/subscribers","subscription_url":"https://api.github.com/repos/tronprotocol/java-tron/subscription","commits_url":"https://api.github.com/repos/tronprotocol/java-tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/tronprotocol/java-tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/tronprotocol/java-tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/tronprotocol/java-tron/contents/{+path}","compare_url":"https://api.github.com/repos/tronprotocol/java-tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tronprotocol/java-tron/merges","archive_url":"https://api.github.com/repos/tronprotocol/java-tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tronprotocol/java-tron/downloads","issues_url":"https://api.github.com/repos/tronprotocol/java-tron/issues{/number}","pulls_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls{/number}","milestones_url":"https://api.github.com/repos/tronprotocol/java-tron/milestones{/number}","notifications_url":"https://api.github.com/repos/tronprotocol/java-tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tronprotocol/java-tron/labels{/name}","releases_url":"https://api.github.com/repos/tronprotocol/java-tron/releases{/id}","deployments_url":"https://api.github.com/repos/tronprotocol/java-tron/deployments","created_at":"2017-12-26T10:20:38Z","updated_at":"2018-11-06T03:07:43Z","pushed_at":"2018-11-06T09:26:14Z","git_url":"git://github.com/tronprotocol/java-tron.git","ssh_url":"git@github.com:tronprotocol/java-tron.git","clone_url":"https://github.com/tronprotocol/java-tron.git","svn_url":"https://github.com/tronprotocol/java-tron","homepage":"","size":15425,"stargazers_count":2019,"watchers_count":2019,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":464,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":464,"open_issues":47,"watchers":2019,"default_branch":"develop"}},"base":{"label":"tronprotocol:Odyssey_v3.2","ref":"Odyssey_v3.2","sha":"990e1ec3d00b4c894a56de170672966c4210ef9e","user":{"login":"tronprotocol","id":34857411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODU3NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/34857411?v=4","gravatar_id":"","url":"https://api.github.com/users/tronprotocol","html_url":"https://github.com/tronprotocol","followers_url":"https://api.github.com/users/tronprotocol/followers","following_url":"https://api.github.com/users/tronprotocol/following{/other_user}","gists_url":"https://api.github.com/users/tronprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/tronprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tronprotocol/subscriptions","organizations_url":"https://api.github.com/users/tronprotocol/orgs","repos_url":"https://api.github.com/users/tronprotocol/repos","events_url":"https://api.github.com/users/tronprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/tronprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":115411826,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MTE4MjY=","name":"java-tron","full_name":"tronprotocol/java-tron","private":false,"owner":{"login":"tronprotocol","id":34857411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODU3NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/34857411?v=4","gravatar_id":"","url":"https://api.github.com/users/tronprotocol","html_url":"https://github.com/tronprotocol","followers_url":"https://api.github.com/users/tronprotocol/followers","following_url":"https://api.github.com/users/tronprotocol/following{/other_user}","gists_url":"https://api.github.com/users/tronprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/tronprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tronprotocol/subscriptions","organizations_url":"https://api.github.com/users/tronprotocol/orgs","repos_url":"https://api.github.com/users/tronprotocol/repos","events_url":"https://api.github.com/users/tronprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/tronprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tronprotocol/java-tron","description":"Java implementation of the Tron whitepaper","fork":false,"url":"https://api.github.com/repos/tronprotocol/java-tron","forks_url":"https://api.github.com/repos/tronprotocol/java-tron/forks","keys_url":"https://api.github.com/repos/tronprotocol/java-tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tronprotocol/java-tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tronprotocol/java-tron/teams","hooks_url":"https://api.github.com/repos/tronprotocol/java-tron/hooks","issue_events_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/events{/number}","events_url":"https://api.github.com/repos/tronprotocol/java-tron/events","assignees_url":"https://api.github.com/repos/tronprotocol/java-tron/assignees{/user}","branches_url":"https://api.github.com/repos/tronprotocol/java-tron/branches{/branch}","tags_url":"https://api.github.com/repos/tronprotocol/java-tron/tags","blobs_url":"https://api.github.com/repos/tronprotocol/java-tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tronprotocol/java-tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tronprotocol/java-tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/tronprotocol/java-tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tronprotocol/java-tron/statuses/{sha}","languages_url":"https://api.github.com/repos/tronprotocol/java-tron/languages","stargazers_url":"https://api.github.com/repos/tronprotocol/java-tron/stargazers","contributors_url":"https://api.github.com/repos/tronprotocol/java-tron/contributors","subscribers_url":"https://api.github.com/repos/tronprotocol/java-tron/subscribers","subscription_url":"https://api.github.com/repos/tronprotocol/java-tron/subscription","commits_url":"https://api.github.com/repos/tronprotocol/java-tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/tronprotocol/java-tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/tronprotocol/java-tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/tronprotocol/java-tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/tronprotocol/java-tron/contents/{+path}","compare_url":"https://api.github.com/repos/tronprotocol/java-tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tronprotocol/java-tron/merges","archive_url":"https://api.github.com/repos/tronprotocol/java-tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tronprotocol/java-tron/downloads","issues_url":"https://api.github.com/repos/tronprotocol/java-tron/issues{/number}","pulls_url":"https://api.github.com/repos/tronprotocol/java-tron/pulls{/number}","milestones_url":"https://api.github.com/repos/tronprotocol/java-tron/milestones{/number}","notifications_url":"https://api.github.com/repos/tronprotocol/java-tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tronprotocol/java-tron/labels{/name}","releases_url":"https://api.github.com/repos/tronprotocol/java-tron/releases{/id}","deployments_url":"https://api.github.com/repos/tronprotocol/java-tron/deployments","created_at":"2017-12-26T10:20:38Z","updated_at":"2018-11-06T03:07:43Z","pushed_at":"2018-11-06T09:26:14Z","git_url":"git://github.com/tronprotocol/java-tron.git","ssh_url":"git@github.com:tronprotocol/java-tron.git","clone_url":"https://github.com/tronprotocol/java-tron.git","svn_url":"https://github.com/tronprotocol/java-tron","homepage":"","size":15425,"stargazers_count":2019,"watchers_count":2019,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":464,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":464,"open_issues":47,"watchers":2019,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681"},"html":{"href":"https://github.com/tronprotocol/java-tron/pull/1681"},"issue":{"href":"https://api.github.com/repos/tronprotocol/java-tron/issues/1681"},"comments":{"href":"https://api.github.com/repos/tronprotocol/java-tron/issues/1681/comments"},"review_comments":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681/comments"},"review_comment":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tronprotocol/java-tron/pulls/1681/commits"},"statuses":{"href":"https://api.github.com/repos/tronprotocol/java-tron/statuses/a6ecf1c0b8988ab3e4f94bae8723c4939bbd95b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hongz"}}