{"action":"opened","number":542,"pull_request":{"url":"https://api.github.com/repos/sbt/zinc/pulls/542","id":187449756,"html_url":"https://github.com/sbt/zinc/pull/542","diff_url":"https://github.com/sbt/zinc/pull/542.diff","patch_url":"https://github.com/sbt/zinc/pull/542.patch","issue_url":"https://api.github.com/repos/sbt/zinc/issues/542","number":542,"state":"open","locked":false,"title":"Detect changes in private trait definitions [WIP]","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"This pull request builds upon @Duhemm's work in\nhttps://github.com/sbt/sbt/pull/2441, but changes slightly the way it's\nsolved. It instead adds a specific api change that only invalidates\nchanges via inheritance (both global and local) and doesn't invalidate\nmember references, which gives us more correctness and precision.\n\nAs explained in https://github.com/sbt/sbt/issues/2490, the previous fix\nviolated some of the invariants of the incremental algorithm. As such,\nwe introduce the notion of an extra api hash which is independent of the\nnormal one. This extra hash, in the case of traits, is computed from the\nprivate definitions found whose encoding produces wrong compilation issues, and\notherwise it's the same as the normal hash. As a result, we can tell apart the\ncases where there are changes in the normal public API hash and the extra one,\nand act accordingly.\n\nI've called it extra instead of \"privateHash\" or something similar so that it\ncould accommodate other fixes in the future that have nothing to do with\naccessibility of definitions. We cannot afford adding a new hash per\n`AnalyzedClass` every time we need to have `HashAPI` be special cased for a\nparticular encoding.\n\nFixes:\n\n1. `source-dependencies/trait-private-val`\n1. `source-dependencies/trait-private-var`\n1. `source-dependencies/trait-private-object`\n1. `source-dependencies/trait-super`\n\nAnd it also adds another two tests to complement\n`source-dependencies/trait-member-modified` in checking that member\nreferences to private trait definitions do not trigger unnecessary\ncompilations and that local inheritance does trigger an extra compile.\n\nThis is still *work in progress* as more unit tests need to be added. I'm open\nto changing some details of the implementation since I'm not still 100% sure\nthat the `apiExtraHash` route is the best choice. Maybe we should go for\nsomething more explicit in name?","created_at":"2018-05-11T12:26:36Z","updated_at":"2018-05-11T12:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sbt/zinc/pulls/542/commits","review_comments_url":"https://api.github.com/repos/sbt/zinc/pulls/542/comments","review_comment_url":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/zinc/issues/542/comments","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/197d133e216a61a0ee4e99bdffa28a3f66b54241","head":{"label":"scalacenter:topic/fix-private","ref":"topic/fix-private","sha":"197d133e216a61a0ee4e99bdffa28a3f66b54241","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":80068441,"name":"zinc","full_name":"scalacenter/zinc","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":true,"url":"https://api.github.com/repos/scalacenter/zinc","forks_url":"https://api.github.com/repos/scalacenter/zinc/forks","keys_url":"https://api.github.com/repos/scalacenter/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/zinc/teams","hooks_url":"https://api.github.com/repos/scalacenter/zinc/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/zinc/events","assignees_url":"https://api.github.com/repos/scalacenter/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/zinc/tags","blobs_url":"https://api.github.com/repos/scalacenter/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/zinc/languages","stargazers_url":"https://api.github.com/repos/scalacenter/zinc/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/zinc/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/zinc/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/zinc/subscription","commits_url":"https://api.github.com/repos/scalacenter/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/zinc/merges","archive_url":"https://api.github.com/repos/scalacenter/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/zinc/downloads","issues_url":"https://api.github.com/repos/scalacenter/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/zinc/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/zinc/deployments","created_at":"2017-01-25T23:28:29Z","updated_at":"2017-11-15T02:13:47Z","pushed_at":"2018-05-11T12:23:50Z","git_url":"git://github.com/scalacenter/zinc.git","ssh_url":"git@github.com:scalacenter/zinc.git","clone_url":"https://github.com/scalacenter/zinc.git","svn_url":"https://github.com/scalacenter/zinc","homepage":"","size":12290,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":5,"default_branch":"scala-center"}},"base":{"label":"sbt:1.x","ref":"1.x","sha":"42d8f8fddb6a6773d7f0c71862c9ff3823739505","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"zinc","full_name":"sbt/zinc","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":false,"url":"https://api.github.com/repos/sbt/zinc","forks_url":"https://api.github.com/repos/sbt/zinc/forks","keys_url":"https://api.github.com/repos/sbt/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/zinc/teams","hooks_url":"https://api.github.com/repos/sbt/zinc/hooks","issue_events_url":"https://api.github.com/repos/sbt/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/zinc/events","assignees_url":"https://api.github.com/repos/sbt/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/zinc/tags","blobs_url":"https://api.github.com/repos/sbt/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/zinc/languages","stargazers_url":"https://api.github.com/repos/sbt/zinc/stargazers","contributors_url":"https://api.github.com/repos/sbt/zinc/contributors","subscribers_url":"https://api.github.com/repos/sbt/zinc/subscribers","subscription_url":"https://api.github.com/repos/sbt/zinc/subscription","commits_url":"https://api.github.com/repos/sbt/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/zinc/merges","archive_url":"https://api.github.com/repos/sbt/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/zinc/downloads","issues_url":"https://api.github.com/repos/sbt/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/zinc/labels{/name}","releases_url":"https://api.github.com/repos/sbt/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/sbt/zinc/deployments","created_at":"2015-08-04T21:32:58Z","updated_at":"2018-05-08T18:33:18Z","pushed_at":"2018-05-08T18:33:11Z","git_url":"git://github.com/sbt/zinc.git","ssh_url":"git@github.com:sbt/zinc.git","clone_url":"https://github.com/sbt/zinc.git","svn_url":"https://github.com/sbt/zinc","homepage":"","size":11205,"stargazers_count":149,"watchers_count":149,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":75,"watchers":149,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/542"},"html":{"href":"https://github.com/sbt/zinc/pull/542"},"issue":{"href":"https://api.github.com/repos/sbt/zinc/issues/542"},"comments":{"href":"https://api.github.com/repos/sbt/zinc/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/zinc/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/zinc/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/zinc/statuses/197d133e216a61a0ee4e99bdffa28a3f66b54241"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":202,"deletions":59,"changed_files":27}}
{"actor":{"display_login":"jvican"}}