{"action":"created","issue":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4875","repository_url":"https://api.github.com/repos/SimpleMachines/SMF2.1","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4875/labels{/name}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4875/comments","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4875/events","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4875","id":345382628,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTUyNTIx","number":4875,"title":"Assign the array to saveTriggers function fixes #4867","user":{"login":"albertlast","id":1782906,"node_id":"MDQ6VXNlcjE3ODI5MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1782906?v=4","gravatar_id":"","url":"https://api.github.com/users/albertlast","html_url":"https://github.com/albertlast","followers_url":"https://api.github.com/users/albertlast/followers","following_url":"https://api.github.com/users/albertlast/following{/other_user}","gists_url":"https://api.github.com/users/albertlast/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlast/subscriptions","organizations_url":"https://api.github.com/users/albertlast/orgs","repos_url":"https://api.github.com/users/albertlast/repos","events_url":"https://api.github.com/users/albertlast/events{/privacy}","received_events_url":"https://api.github.com/users/albertlast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-27T22:21:26Z","updated_at":"2018-09-08T00:15:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/4875","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4875","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/4875.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/4875.patch"},"body":"In my test with this changes,\r\nthe logic run fine.\r\n\r\n@Arantor please test this pr\r\n\r\nIssue #4867 \r\n"},"comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments/419597021","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4875#issuecomment-419597021","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4875","id":419597021,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU5NzAyMQ==","user":{"login":"Sesquipedalian","id":191731,"node_id":"MDQ6VXNlcjE5MTczMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/191731?v=4","gravatar_id":"","url":"https://api.github.com/users/Sesquipedalian","html_url":"https://github.com/Sesquipedalian","followers_url":"https://api.github.com/users/Sesquipedalian/followers","following_url":"https://api.github.com/users/Sesquipedalian/following{/other_user}","gists_url":"https://api.github.com/users/Sesquipedalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Sesquipedalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sesquipedalian/subscriptions","organizations_url":"https://api.github.com/users/Sesquipedalian/orgs","repos_url":"https://api.github.com/users/Sesquipedalian/repos","events_url":"https://api.github.com/users/Sesquipedalian/events{/privacy}","received_events_url":"https://api.github.com/users/Sesquipedalian/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T00:15:02Z","updated_at":"2018-09-08T00:15:02Z","author_association":"MEMBER","body":"My honest opinion is that the current way of editing ban triggers is needlessly overcomplicated. The \"Add new ban\" and \"Edit ban\" forms should be identical except for the title text and the fact that the values of \"Edit ban\" start with the current values instead of being empty. Then when the admin edits the ban as a whole, she could edit the ban triggers right there on the same form instead of being forced to go to these unnecessary extra forms.\r\n\r\nHowever, the faster and easier fix would be to simplify the logic in the problematic part of `BanEditTrigger()` so that if `$_REQUEST['bi']` is not empty, we only modify the specified ban trigger and don't try to do anything clever to create new ones. Then the \"Edit ban trigger\" template should be changed so that it only shows a field for the existing trigger type of the trigger being edited. So for example, if the admin goes to `\r\n?action=admin;area=ban;sa=edittrigger;bg=1;bi=2` and ban item 2 is a hostname ban, then the form should only show an input field for a hostname ban."}}
{"actor":{"display_login":"Sesquipedalian"}}