{"action":"opened","number":487,"pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487","id":221515448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTE1NDQ4","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/487","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/487.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/487.patch","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/487","number":487,"state":"open","locked":false,"title":"TEST upgrade to latest react-modal (but too big)","user":{"login":"rfreitas","id":651348,"node_id":"MDQ6VXNlcjY1MTM0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/651348?v=4","gravatar_id":"","url":"https://api.github.com/users/rfreitas","html_url":"https://github.com/rfreitas","followers_url":"https://api.github.com/users/rfreitas/followers","following_url":"https://api.github.com/users/rfreitas/following{/other_user}","gists_url":"https://api.github.com/users/rfreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/rfreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfreitas/subscriptions","organizations_url":"https://api.github.com/users/rfreitas/orgs","repos_url":"https://api.github.com/users/rfreitas/repos","events_url":"https://api.github.com/users/rfreitas/events{/privacy}","received_events_url":"https://api.github.com/users/rfreitas/received_events","type":"User","site_admin":false},"body":"# Problem\r\n\r\nWe are on old version (our fork) of react modal.\r\n\r\n# Solution\r\n\r\nTried updating since the latest version seemed to have two functions we needed:\r\n1. no lodash\r\n2. custom class names\r\n\r\nThe problem is that the module is twice as big as the current one.\r\nDO NOT MERGE\r\n\r\n## Checklist\r\n_put `n/a` if item is not relevant to PR changes_\r\n\r\n- [ ] Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?\r\n- [ ] Have new automated tests been implemented?\r\n- [ ] Have new manual tests been written down?\r\n- [ ] Have tests passed locally?\r\n- [ ] Have any new strings been translated?\r\n","created_at":"2018-10-09T17:01:35Z","updated_at":"2018-10-09T17:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487/commits","review_comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487/comments","review_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/487/comments","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/6dd344f4bc93cf54f96e8f10b67167561f715aee","head":{"label":"onfido:fix/react-modal","ref":"fix/react-modal","sha":"6dd344f4bc93cf54f96e8f10b67167561f715aee","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","private":false,"owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-10-02T17:51:13Z","pushed_at":"2018-10-09T15:32:47Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":8563,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":15,"watchers":59,"default_branch":"master"}},"base":{"label":"onfido:development","ref":"development","sha":"1c4a72ba705a3bd4f3e0b6993743e41653f1db62","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","private":false,"owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2018-10-02T17:51:13Z","pushed_at":"2018-10-09T15:32:47Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":8563,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":15,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/487"},"issue":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/487"},"comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/6dd344f4bc93cf54f96e8f10b67167561f715aee"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":84,"deletions":47,"changed_files":5}}
{"actor":{"display_login":"rfreitas"}}