{"action":"opened","number":7593,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593","id":192140946,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTQwOTQ2","html_url":"https://github.com/zfsonlinux/zfs/pull/7593","diff_url":"https://github.com/zfsonlinux/zfs/pull/7593.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/7593.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7593","number":7593,"state":"open","locked":false,"title":"Update the correct abd in l2arc_read_done()","user":{"login":"tcaputi","id":1920053,"node_id":"MDQ6VXNlcjE5MjAwNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1920053?v=4","gravatar_id":"","url":"https://api.github.com/users/tcaputi","html_url":"https://github.com/tcaputi","followers_url":"https://api.github.com/users/tcaputi/followers","following_url":"https://api.github.com/users/tcaputi/following{/other_user}","gists_url":"https://api.github.com/users/tcaputi/gists{/gist_id}","starred_url":"https://api.github.com/users/tcaputi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcaputi/subscriptions","organizations_url":"https://api.github.com/users/tcaputi/orgs","repos_url":"https://api.github.com/users/tcaputi/repos","events_url":"https://api.github.com/users/tcaputi/events{/privacy}","received_events_url":"https://api.github.com/users/tcaputi/received_events","type":"User","site_admin":false},"body":"This patch fixes an issue where l2arc_read_done() would always\r\nwrite data to b_pabd, even if raw encrypted data was requested.\r\nThis only occured in cases where the L2ARC device had a different\r\nashift than the main pool.\r\n\r\nFixes: #7586\r\n\r\nSigned-off-by: Tom Caputi <tcaputi@datto.com>\r\n\r\n### How Has This Been Tested?\r\nI will try to test this soon. It's a bit tricky since it requires having a L2ARc device with a different ashift from the rest of the pool. I'll probably hack some temporary test into the code, but I'm not sure about a long-term solution.\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Performance enhancement (non-breaking change which improves efficiency)\r\n- [ ] Code cleanup (non-breaking change which makes code smaller or more readable)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation (a change to man pages or other documentation)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the ZFS on Linux [code style requirements](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#coding-conventions).\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**contributing** document](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I have added [tests](https://github.com/zfsonlinux/zfs/tree/master/tests) to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] All commit messages are properly formatted and contain [`Signed-off-by`](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#signed-off-by).\r\n- [ ] Change has been approved by a ZFS on Linux member.\r\n","created_at":"2018-06-01T20:57:30Z","updated_at":"2018-06-01T20:57:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7593/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/187dd291243b9d397953b82168ca8658b3e05697","head":{"label":"datto:l2arc_read_done_fix","ref":"l2arc_read_done_fix","sha":"187dd291243b9d397953b82168ca8658b3e05697","user":{"login":"datto","id":7149907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDk5MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7149907?v=4","gravatar_id":"","url":"https://api.github.com/users/datto","html_url":"https://github.com/datto","followers_url":"https://api.github.com/users/datto/followers","following_url":"https://api.github.com/users/datto/following{/other_user}","gists_url":"https://api.github.com/users/datto/gists{/gist_id}","starred_url":"https://api.github.com/users/datto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datto/subscriptions","organizations_url":"https://api.github.com/users/datto/orgs","repos_url":"https://api.github.com/users/datto/repos","events_url":"https://api.github.com/users/datto/events{/privacy}","received_events_url":"https://api.github.com/users/datto/received_events","type":"Organization","site_admin":false},"repo":{"id":87125208,"node_id":"MDEwOlJlcG9zaXRvcnk4NzEyNTIwOA==","name":"zfs","full_name":"datto/zfs","owner":{"login":"datto","id":7149907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNDk5MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7149907?v=4","gravatar_id":"","url":"https://api.github.com/users/datto","html_url":"https://github.com/datto","followers_url":"https://api.github.com/users/datto/followers","following_url":"https://api.github.com/users/datto/following{/other_user}","gists_url":"https://api.github.com/users/datto/gists{/gist_id}","starred_url":"https://api.github.com/users/datto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datto/subscriptions","organizations_url":"https://api.github.com/users/datto/orgs","repos_url":"https://api.github.com/users/datto/repos","events_url":"https://api.github.com/users/datto/events{/privacy}","received_events_url":"https://api.github.com/users/datto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datto/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/datto/zfs","forks_url":"https://api.github.com/repos/datto/zfs/forks","keys_url":"https://api.github.com/repos/datto/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datto/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datto/zfs/teams","hooks_url":"https://api.github.com/repos/datto/zfs/hooks","issue_events_url":"https://api.github.com/repos/datto/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/datto/zfs/events","assignees_url":"https://api.github.com/repos/datto/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/datto/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/datto/zfs/tags","blobs_url":"https://api.github.com/repos/datto/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datto/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datto/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/datto/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datto/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/datto/zfs/languages","stargazers_url":"https://api.github.com/repos/datto/zfs/stargazers","contributors_url":"https://api.github.com/repos/datto/zfs/contributors","subscribers_url":"https://api.github.com/repos/datto/zfs/subscribers","subscription_url":"https://api.github.com/repos/datto/zfs/subscription","commits_url":"https://api.github.com/repos/datto/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/datto/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/datto/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/datto/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/datto/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/datto/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datto/zfs/merges","archive_url":"https://api.github.com/repos/datto/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datto/zfs/downloads","issues_url":"https://api.github.com/repos/datto/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/datto/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/datto/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/datto/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datto/zfs/labels{/name}","releases_url":"https://api.github.com/repos/datto/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/datto/zfs/deployments","created_at":"2017-04-03T22:04:14Z","updated_at":"2018-06-01T15:04:23Z","pushed_at":"2018-06-01T20:55:35Z","git_url":"git://github.com/datto/zfs.git","ssh_url":"git@github.com:datto/zfs.git","clone_url":"https://github.com/datto/zfs.git","svn_url":"https://github.com/datto/zfs","homepage":"http://zfsonlinux.org/","size":49530,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"1a5b96b8ee66da5dfdfbedcb6bc462f454b4a25d","user":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwMTE=","name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2018-05-31T17:55:05Z","pushed_at":"2018-06-01T20:52:12Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":49432,"stargazers_count":3309,"watchers_count":3309,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":767,"mirror_url":null,"archived":false,"open_issues_count":956,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":767,"open_issues":956,"watchers":3309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/7593"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/7593"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/7593/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7593/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/187dd291243b9d397953b82168ca8658b3e05697"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tcaputi"}}