{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/165548866","pull_request_review_id":93508396,"id":165548866,"diff_hunk":"@@ -281,6 +281,7 @@ func (n *NetworkHarness) ConnectNodes(ctx context.Context, a, b *HarnessNode) er\n \t\t\tPubkey: bobInfo.IdentityPubkey,\n \t\t\tHost:   b.cfg.P2PAddr(),\n \t\t},\n+\t\tPerm: true,","path":"lntest/harness.go","position":4,"original_position":4,"commit_id":"435e0f90eb13e448033067777f8f1d442f044fea","original_commit_id":"435e0f90eb13e448033067777f8f1d442f044fea","user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"body":"I mainly added this to be sure this doesn't get us stuck in any weird states, the itests seem to handle it just fine. Will revert.","created_at":"2018-02-02T03:02:49Z","updated_at":"2018-02-02T03:02:49Z","html_url":"https://github.com/lightningnetwork/lnd/pull/715#discussion_r165548866","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/165548866"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/715#discussion_r165548866"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715"}},"in_reply_to_id":165527330},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715","id":166491917,"html_url":"https://github.com/lightningnetwork/lnd/pull/715","diff_url":"https://github.com/lightningnetwork/lnd/pull/715.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/715.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/715","number":715,"state":"open","locked":false,"title":"server: adds truncated exponential backoff + rand for retry","user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"body":"This commit adds a backoff policy to the peer termination watcher to avoid getting stuck in tight connection loops with failing peers. The maximum backoff is currently set to 128s, and each backoff is randomized so that two instances using the same algorithm have some hope of desynchronizing. Note, a peer's backoff will only be reset if we manually disconnect via `DisconnectPeer` or restart the server.","created_at":"2018-02-01T10:04:26Z","updated_at":"2018-02-02T03:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ff436f0d34f8ccb413394ad645086935e3cb481","assignee":{"login":"aakselrod","id":1268625,"avatar_url":"https://avatars0.githubusercontent.com/u/1268625?v=4","gravatar_id":"","url":"https://api.github.com/users/aakselrod","html_url":"https://github.com/aakselrod","followers_url":"https://api.github.com/users/aakselrod/followers","following_url":"https://api.github.com/users/aakselrod/following{/other_user}","gists_url":"https://api.github.com/users/aakselrod/gists{/gist_id}","starred_url":"https://api.github.com/users/aakselrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aakselrod/subscriptions","organizations_url":"https://api.github.com/users/aakselrod/orgs","repos_url":"https://api.github.com/users/aakselrod/repos","events_url":"https://api.github.com/users/aakselrod/events{/privacy}","received_events_url":"https://api.github.com/users/aakselrod/received_events","type":"User","site_admin":false},"assignees":[{"login":"aakselrod","id":1268625,"avatar_url":"https://avatars0.githubusercontent.com/u/1268625?v=4","gravatar_id":"","url":"https://api.github.com/users/aakselrod","html_url":"https://github.com/aakselrod","followers_url":"https://api.github.com/users/aakselrod/followers","following_url":"https://api.github.com/users/aakselrod/following{/other_user}","gists_url":"https://api.github.com/users/aakselrod/gists{/gist_id}","starred_url":"https://api.github.com/users/aakselrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aakselrod/subscriptions","organizations_url":"https://api.github.com/users/aakselrod/orgs","repos_url":"https://api.github.com/users/aakselrod/repos","events_url":"https://api.github.com/users/aakselrod/events{/privacy}","received_events_url":"https://api.github.com/users/aakselrod/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/715/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/435e0f90eb13e448033067777f8f1d442f044fea","head":{"label":"cfromknecht:reconnect-backoff","ref":"reconnect-backoff","sha":"435e0f90eb13e448033067777f8f1d442f044fea","user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"repo":{"id":98245639,"name":"lnd","full_name":"cfromknecht/lnd","owner":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cfromknecht/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/cfromknecht/lnd","forks_url":"https://api.github.com/repos/cfromknecht/lnd/forks","keys_url":"https://api.github.com/repos/cfromknecht/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfromknecht/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfromknecht/lnd/teams","hooks_url":"https://api.github.com/repos/cfromknecht/lnd/hooks","issue_events_url":"https://api.github.com/repos/cfromknecht/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/cfromknecht/lnd/events","assignees_url":"https://api.github.com/repos/cfromknecht/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/cfromknecht/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/cfromknecht/lnd/tags","blobs_url":"https://api.github.com/repos/cfromknecht/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfromknecht/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfromknecht/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfromknecht/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfromknecht/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/cfromknecht/lnd/languages","stargazers_url":"https://api.github.com/repos/cfromknecht/lnd/stargazers","contributors_url":"https://api.github.com/repos/cfromknecht/lnd/contributors","subscribers_url":"https://api.github.com/repos/cfromknecht/lnd/subscribers","subscription_url":"https://api.github.com/repos/cfromknecht/lnd/subscription","commits_url":"https://api.github.com/repos/cfromknecht/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfromknecht/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfromknecht/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfromknecht/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfromknecht/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/cfromknecht/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfromknecht/lnd/merges","archive_url":"https://api.github.com/repos/cfromknecht/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfromknecht/lnd/downloads","issues_url":"https://api.github.com/repos/cfromknecht/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/cfromknecht/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/cfromknecht/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/cfromknecht/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfromknecht/lnd/labels{/name}","releases_url":"https://api.github.com/repos/cfromknecht/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/cfromknecht/lnd/deployments","created_at":"2017-07-25T00:12:12Z","updated_at":"2018-01-21T00:45:08Z","pushed_at":"2018-02-01T10:06:38Z","git_url":"git://github.com/cfromknecht/lnd.git","ssh_url":"git@github.com:cfromknecht/lnd.git","clone_url":"https://github.com/cfromknecht/lnd.git","svn_url":"https://github.com/cfromknecht/lnd","homepage":"","size":11465,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":0,"watchers":22,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"db7d902bbbb4394288eb4da37251717c6ff152da","user":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"name":"lnd","full_name":"lightningnetwork/lnd","owner":{"login":"lightningnetwork","id":13424735,"avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2018-02-02T01:56:14Z","pushed_at":"2018-02-02T02:51:35Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":10995,"stargazers_count":1881,"watchers_count":1881,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":377,"open_issues":137,"watchers":1881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/715"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/715"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/435e0f90eb13e448033067777f8f1d442f044fea"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cfromknecht"}}