{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/206380004","pull_request_review_id":141783259,"id":206380004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjM4MDAwNA==","diff_hunk":"@@ -75,6 +81,38 @@\n             .addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)\n             .build();\n \n+    public static final PropertyDescriptor QUERY_TIMEOUT = new PropertyDescriptor.Builder()\n+            .name(\"hive-query-timeout\")\n+            .displayName(\"Query timeout\")\n+            .description(\"Sets the number of seconds the driver will wait for a query to execute. \"\n+                    + \"A value of 0 means no timeout. NOTE: Non-zero values may not be supported by the driver.\")\n+            .defaultValue(\"0\")\n+            .required(true)\n+            .addValidator(StandardValidators.INTEGER_VALIDATOR)\n+            .expressionLanguageSupported(true)\n+            .build();\n+\n+    @Override\n+    protected Collection<ValidationResult> customValidate(ValidationContext validationContext) {\n+        final List<ValidationResult> problems = new ArrayList<>(1);\n+\n+        if(validationContext.getProperty(QUERY_TIMEOUT).isSet()\n+                && !validationContext.getProperty(QUERY_TIMEOUT).isExpressionLanguagePresent()\n+                && validationContext.getProperty(QUERY_TIMEOUT).asInteger() != 0) {\n+            try(HiveStatement stmt = new HiveStatement(null, null, null)) {\n+                stmt.setQueryTimeout(0);","path":"nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java","position":58,"original_position":44,"commit_id":"033251508588b7de09188cbc83f7be9f329e07d4","original_commit_id":"04dfde7c2f6c89beaa11968d0c2a629f3a19bcc0","user":{"login":"mattyb149","id":2124747,"node_id":"MDQ6VXNlcjIxMjQ3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2124747?v=4","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"body":"Also I think yes, the idea is to catch the \"not supported\" thing during customValidate() where we can, but we also have to add it to the runtime checking because of EL","created_at":"2018-07-31T02:39:25Z","updated_at":"2018-07-31T02:39:25Z","html_url":"https://github.com/apache/nifi/pull/2138#discussion_r206380004","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/2138","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/206380004"},"html":{"href":"https://github.com/apache/nifi/pull/2138#discussion_r206380004"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/2138"}},"in_reply_to_id":165940928},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2138","id":140176797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQwMTc2Nzk3","html_url":"https://github.com/apache/nifi/pull/2138","diff_url":"https://github.com/apache/nifi/pull/2138.diff","patch_url":"https://github.com/apache/nifi/pull/2138.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/2138","number":2138,"state":"open","locked":false,"title":"NIFI-4371 - add support for query timeout in Hive processors","user":{"login":"pvillard31","id":11541012,"node_id":"MDQ6VXNlcjExNTQxMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"body":"Thank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2017-09-09T16:58:18Z","updated_at":"2018-07-31T02:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a60ab3fd33664f66da37ff0d43f3f087bfecb2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/2138/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/2138/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2138/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/033251508588b7de09188cbc83f7be9f329e07d4","head":{"label":"pvillard31:NIFI-4371","ref":"NIFI-4371","sha":"033251508588b7de09188cbc83f7be9f329e07d4","user":{"login":"pvillard31","id":11541012,"node_id":"MDQ6VXNlcjExNTQxMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"repo":{"id":51175123,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE3NTEyMw==","name":"nifi","full_name":"pvillard31/nifi","owner":{"login":"pvillard31","id":11541012,"node_id":"MDQ6VXNlcjExNTQxMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/11541012?v=4","gravatar_id":"","url":"https://api.github.com/users/pvillard31","html_url":"https://github.com/pvillard31","followers_url":"https://api.github.com/users/pvillard31/followers","following_url":"https://api.github.com/users/pvillard31/following{/other_user}","gists_url":"https://api.github.com/users/pvillard31/gists{/gist_id}","starred_url":"https://api.github.com/users/pvillard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvillard31/subscriptions","organizations_url":"https://api.github.com/users/pvillard31/orgs","repos_url":"https://api.github.com/users/pvillard31/repos","events_url":"https://api.github.com/users/pvillard31/events{/privacy}","received_events_url":"https://api.github.com/users/pvillard31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvillard31/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/pvillard31/nifi","forks_url":"https://api.github.com/repos/pvillard31/nifi/forks","keys_url":"https://api.github.com/repos/pvillard31/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvillard31/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvillard31/nifi/teams","hooks_url":"https://api.github.com/repos/pvillard31/nifi/hooks","issue_events_url":"https://api.github.com/repos/pvillard31/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/pvillard31/nifi/events","assignees_url":"https://api.github.com/repos/pvillard31/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/pvillard31/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/pvillard31/nifi/tags","blobs_url":"https://api.github.com/repos/pvillard31/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvillard31/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvillard31/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvillard31/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvillard31/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/pvillard31/nifi/languages","stargazers_url":"https://api.github.com/repos/pvillard31/nifi/stargazers","contributors_url":"https://api.github.com/repos/pvillard31/nifi/contributors","subscribers_url":"https://api.github.com/repos/pvillard31/nifi/subscribers","subscription_url":"https://api.github.com/repos/pvillard31/nifi/subscription","commits_url":"https://api.github.com/repos/pvillard31/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvillard31/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvillard31/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvillard31/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvillard31/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/pvillard31/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvillard31/nifi/merges","archive_url":"https://api.github.com/repos/pvillard31/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvillard31/nifi/downloads","issues_url":"https://api.github.com/repos/pvillard31/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/pvillard31/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/pvillard31/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/pvillard31/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvillard31/nifi/labels{/name}","releases_url":"https://api.github.com/repos/pvillard31/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/pvillard31/nifi/deployments","created_at":"2016-02-05T21:27:44Z","updated_at":"2018-07-30T21:39:32Z","pushed_at":"2018-07-30T21:59:07Z","git_url":"git://github.com/pvillard31/nifi.git","ssh_url":"git@github.com:pvillard31/nifi.git","clone_url":"https://github.com/pvillard31/nifi.git","svn_url":"https://github.com/pvillard31/nifi","homepage":"","size":122846,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"44face10bf9837308587dc1d46326e4a5764435f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"node_id":"MDEwOlJlcG9zaXRvcnkyNzkxMTA4OA==","name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2018-07-30T23:05:59Z","pushed_at":"2018-07-30T23:31:36Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":124565,"stargazers_count":1029,"watchers_count":1029,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":969,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":969,"open_issues":138,"watchers":1029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/2138"},"html":{"href":"https://github.com/apache/nifi/pull/2138"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/2138"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/2138/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/2138/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/2138/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/033251508588b7de09188cbc83f7be9f329e07d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattyb149"}}