{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments/242348496","pull_request_review_id":185838042,"id":242348496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM0ODQ5Ng==","diff_hunk":"@@ -1,8 +1,8 @@\n (function() {\n   'use strict';\n \n-  angular.module('ui.grid').directive('uiGridHeaderCell', ['$compile', '$timeout', '$window', '$document', 'gridUtil', 'uiGridConstants', 'ScrollEvent', 'i18nService',\n-  function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, ScrollEvent, i18nService) {\n+  angular.module('ui.grid').directive('uiGridHeaderCell', ['$compile', '$timeout', '$window', '$document', 'gridUtil', 'uiGridConstants', 'ScrollEvent', 'i18nService', '$rootScope',\n+  function ($compile, $timeout, $window, $document, gridUtil, uiGridConstants, ScrollEvent, i18nService, $rootScope) {","path":"src/js/core/directives/ui-grid-header-cell.js","position":7,"original_position":7,"commit_id":"eb0f3d21fd5edea9949d1c9f0897fdcf85b06d54","original_commit_id":"eb0f3d21fd5edea9949d1c9f0897fdcf85b06d54","user":{"login":"mportuga","id":6733275,"node_id":"MDQ6VXNlcjY3MzMyNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6733275?v=4","gravatar_id":"","url":"https://api.github.com/users/mportuga","html_url":"https://github.com/mportuga","followers_url":"https://api.github.com/users/mportuga/followers","following_url":"https://api.github.com/users/mportuga/following{/other_user}","gists_url":"https://api.github.com/users/mportuga/gists{/gist_id}","starred_url":"https://api.github.com/users/mportuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mportuga/subscriptions","organizations_url":"https://api.github.com/users/mportuga/orgs","repos_url":"https://api.github.com/users/mportuga/repos","events_url":"https://api.github.com/users/mportuga/events{/privacy}","received_events_url":"https://api.github.com/users/mportuga/received_events","type":"User","site_admin":false},"body":"Could you move rootScope to the start? It is more of a personal preference, but I like having all of the $ variables grouped together.\r\n```suggestion\r\n  function ($compile, $timeout, $window, $document, $rootScope, gridUtil, uiGridConstants, ScrollEvent, i18nService) {\r\n```","created_at":"2018-12-17T22:54:57Z","updated_at":"2018-12-17T22:54:57Z","html_url":"https://github.com/angular-ui/ui-grid/pull/6901#discussion_r242348496","pull_request_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments/242348496"},"html":{"href":"https://github.com/angular-ui/ui-grid/pull/6901#discussion_r242348496"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901","id":235609697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjA5Njk3","html_url":"https://github.com/angular-ui/ui-grid/pull/6901","diff_url":"https://github.com/angular-ui/ui-grid/pull/6901.diff","patch_url":"https://github.com/angular-ui/ui-grid/pull/6901.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/6901","number":6901,"state":"open","locked":false,"title":"feat(filter): add filterContainer option to allow a column filter to be placed in column menu","user":{"login":"caseyjhol","id":2874325,"node_id":"MDQ6VXNlcjI4NzQzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2874325?v=4","gravatar_id":"","url":"https://api.github.com/users/caseyjhol","html_url":"https://github.com/caseyjhol","followers_url":"https://api.github.com/users/caseyjhol/followers","following_url":"https://api.github.com/users/caseyjhol/following{/other_user}","gists_url":"https://api.github.com/users/caseyjhol/gists{/gist_id}","starred_url":"https://api.github.com/users/caseyjhol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseyjhol/subscriptions","organizations_url":"https://api.github.com/users/caseyjhol/orgs","repos_url":"https://api.github.com/users/caseyjhol/repos","events_url":"https://api.github.com/users/caseyjhol/events{/privacy}","received_events_url":"https://api.github.com/users/caseyjhol/received_events","type":"User","site_admin":false},"body":"New behavior: http://next.plnkr.co/edit/nJbWFbLy7qutQslTQovF?preview\r\n\r\nfilterContainer has a default value of \"headerCell\" which is the same as existing behavior. A filterContainer value of \"columnMenu\" moves the filter into the column menu. This improves the appearance of the filter in situations where there are multiple filters for a single column (preventing the header from simply getting taller and taller) and offers a streamlined alternative to placing the filter directly in the header cell.\r\n\r\nFixes #3989.","created_at":"2018-12-03T22:09:10Z","updated_at":"2018-12-17T22:54:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9636aac1ca57e9e54bd0ccd4d3f9eec870a3757","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/6901/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/eb0f3d21fd5edea9949d1c9f0897fdcf85b06d54","head":{"label":"snapappointments:filter-in-menu","ref":"filter-in-menu","sha":"eb0f3d21fd5edea9949d1c9f0897fdcf85b06d54","user":{"login":"snapappointments","id":3484250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODQyNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3484250?v=4","gravatar_id":"","url":"https://api.github.com/users/snapappointments","html_url":"https://github.com/snapappointments","followers_url":"https://api.github.com/users/snapappointments/followers","following_url":"https://api.github.com/users/snapappointments/following{/other_user}","gists_url":"https://api.github.com/users/snapappointments/gists{/gist_id}","starred_url":"https://api.github.com/users/snapappointments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapappointments/subscriptions","organizations_url":"https://api.github.com/users/snapappointments/orgs","repos_url":"https://api.github.com/users/snapappointments/repos","events_url":"https://api.github.com/users/snapappointments/events{/privacy}","received_events_url":"https://api.github.com/users/snapappointments/received_events","type":"Organization","site_admin":false},"repo":{"id":123500397,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1MDAzOTc=","name":"ui-grid","full_name":"snapappointments/ui-grid","private":false,"owner":{"login":"snapappointments","id":3484250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODQyNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3484250?v=4","gravatar_id":"","url":"https://api.github.com/users/snapappointments","html_url":"https://github.com/snapappointments","followers_url":"https://api.github.com/users/snapappointments/followers","following_url":"https://api.github.com/users/snapappointments/following{/other_user}","gists_url":"https://api.github.com/users/snapappointments/gists{/gist_id}","starred_url":"https://api.github.com/users/snapappointments/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapappointments/subscriptions","organizations_url":"https://api.github.com/users/snapappointments/orgs","repos_url":"https://api.github.com/users/snapappointments/repos","events_url":"https://api.github.com/users/snapappointments/events{/privacy}","received_events_url":"https://api.github.com/users/snapappointments/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapappointments/ui-grid","description":"UI Grid: an Angular Data Grid","fork":true,"url":"https://api.github.com/repos/snapappointments/ui-grid","forks_url":"https://api.github.com/repos/snapappointments/ui-grid/forks","keys_url":"https://api.github.com/repos/snapappointments/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapappointments/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapappointments/ui-grid/teams","hooks_url":"https://api.github.com/repos/snapappointments/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/snapappointments/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/snapappointments/ui-grid/events","assignees_url":"https://api.github.com/repos/snapappointments/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/snapappointments/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/snapappointments/ui-grid/tags","blobs_url":"https://api.github.com/repos/snapappointments/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapappointments/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapappointments/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapappointments/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapappointments/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/snapappointments/ui-grid/languages","stargazers_url":"https://api.github.com/repos/snapappointments/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/snapappointments/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/snapappointments/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/snapappointments/ui-grid/subscription","commits_url":"https://api.github.com/repos/snapappointments/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapappointments/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapappointments/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapappointments/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapappointments/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/snapappointments/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapappointments/ui-grid/merges","archive_url":"https://api.github.com/repos/snapappointments/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapappointments/ui-grid/downloads","issues_url":"https://api.github.com/repos/snapappointments/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/snapappointments/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/snapappointments/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/snapappointments/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapappointments/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/snapappointments/ui-grid/releases{/id}","deployments_url":"https://api.github.com/repos/snapappointments/ui-grid/deployments","created_at":"2018-03-01T22:37:02Z","updated_at":"2018-11-13T22:47:38Z","pushed_at":"2018-12-04T21:58:06Z","git_url":"git://github.com/snapappointments/ui-grid.git","ssh_url":"git@github.com:snapappointments/ui-grid.git","clone_url":"https://github.com/snapappointments/ui-grid.git","svn_url":"https://github.com/snapappointments/ui-grid","homepage":"http://ui-grid.info","size":16401,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"f275aa2c60422a9fba1b40f56c410f6931e1e6f6","user":{"login":"angular-ui","id":1530011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzAwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1530011?v=4","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6198699,"node_id":"MDEwOlJlcG9zaXRvcnk2MTk4Njk5","name":"ui-grid","full_name":"angular-ui/ui-grid","private":false,"owner":{"login":"angular-ui","id":1530011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzAwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1530011?v=4","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular-ui/ui-grid","description":"UI Grid: an Angular Data Grid","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-grid","forks_url":"https://api.github.com/repos/angular-ui/ui-grid/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-grid/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-grid/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-grid/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-grid/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-grid/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-grid/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-grid/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-grid/releases{/id}","deployments_url":"https://api.github.com/repos/angular-ui/ui-grid/deployments","created_at":"2012-10-13T01:39:25Z","updated_at":"2018-12-17T15:03:55Z","pushed_at":"2018-12-10T09:46:21Z","git_url":"git://github.com/angular-ui/ui-grid.git","ssh_url":"git@github.com:angular-ui/ui-grid.git","clone_url":"https://github.com/angular-ui/ui-grid.git","svn_url":"https://github.com/angular-ui/ui-grid","homepage":"http://ui-grid.info","size":17422,"stargazers_count":5233,"watchers_count":5233,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2592,"mirror_url":null,"archived":false,"open_issues_count":696,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2592,"open_issues":696,"watchers":5233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901"},"html":{"href":"https://github.com/angular-ui/ui-grid/pull/6901"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/6901"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/6901/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/6901/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-grid/statuses/eb0f3d21fd5edea9949d1c9f0897fdcf85b06d54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mportuga"}}