{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/174485899","pull_request_review_id":103850842,"id":174485899,"diff_hunk":"@@ -26,18 +26,17 @@\n \n #include \"em_msc.h\"\n \n-void flashpage_write(int page, void *data)\n+void flashpage_write(int page, const void *data)\n {\n     assert(page < (int)FLASHPAGE_NUMOF);\n \n     uint32_t *page_addr = (uint32_t *)flashpage_addr(page);\n-    uint32_t *data_addr = (uint32_t *)data;","path":"cpu/efm32/periph/flashpage.c","position":10,"original_position":10,"commit_id":"6c27e75a2ca7bd6b0c7e9374a4cf581e810536a6","original_commit_id":"6c27e75a2ca7bd6b0c7e9374a4cf581e810536a6","user":{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false},"body":"I re-checked all the changes and my bad, I generalized this line as if you did the same to the other files.\r\n\r\nFor the other ones you just removed the cast part, which is true does not help at all. Keeping only the assignement to an `uint32_t *` variable is enough I agree. So you can keep them as you changed now as murdock does not issue warnings.\r\n\r\nHere however you also removed the `uint32_t *data_addr` instead of only defining it const.\r\nAnd from the `MSC_WriteWordI` implementation, it also cast the pointer to `uint32_t` somewhere, so I would prefer keeping this `data_addr` intermediate variable.","created_at":"2018-03-14T14:50:28Z","updated_at":"2018-03-14T14:50:28Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8773#discussion_r174485899","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/174485899"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8773#discussion_r174485899"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773"}},"in_reply_to_id":174452863},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773","id":174705983,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8773","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8773.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8773.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8773","number":8773,"state":"open","locked":false,"title":"drivers/flashpage: use const pointers for write and verify","user":{"login":"vincent-d","id":713601,"avatar_url":"https://avatars0.githubusercontent.com/u/713601?v=4","gravatar_id":"","url":"https://api.github.com/users/vincent-d","html_url":"https://github.com/vincent-d","followers_url":"https://api.github.com/users/vincent-d/followers","following_url":"https://api.github.com/users/vincent-d/following{/other_user}","gists_url":"https://api.github.com/users/vincent-d/gists{/gist_id}","starred_url":"https://api.github.com/users/vincent-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincent-d/subscriptions","organizations_url":"https://api.github.com/users/vincent-d/orgs","repos_url":"https://api.github.com/users/vincent-d/repos","events_url":"https://api.github.com/users/vincent-d/events{/privacy}","received_events_url":"https://api.github.com/users/vincent-d/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\n\r\nThis update the periph_flashpage interface to use const pointer for writes and verify operations.\r\n\r\n### Issues/PRs references\r\n\r\nBased on #8768 ","created_at":"2018-03-13T15:55:48Z","updated_at":"2018-03-14T14:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2fa168864213338a4abb07ab9eab1ffcb70d112","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kYc0o","id":5419775,"avatar_url":"https://avatars1.githubusercontent.com/u/5419775?v=4","gravatar_id":"","url":"https://api.github.com/users/kYc0o","html_url":"https://github.com/kYc0o","followers_url":"https://api.github.com/users/kYc0o/followers","following_url":"https://api.github.com/users/kYc0o/following{/other_user}","gists_url":"https://api.github.com/users/kYc0o/gists{/gist_id}","starred_url":"https://api.github.com/users/kYc0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kYc0o/subscriptions","organizations_url":"https://api.github.com/users/kYc0o/orgs","repos_url":"https://api.github.com/users/kYc0o/repos","events_url":"https://api.github.com/users/kYc0o/events{/privacy}","received_events_url":"https://api.github.com/users/kYc0o/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":122032371,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c","default":false},{"id":135467271,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/driver","name":"driver","color":"aaffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8773/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/6c27e75a2ca7bd6b0c7e9374a4cf581e810536a6","head":{"label":"OTAkeys:pr/flashpage_const_ptr","ref":"pr/flashpage_const_ptr","sha":"6c27e75a2ca7bd6b0c7e9374a4cf581e810536a6","user":{"login":"OTAkeys","id":17931198,"avatar_url":"https://avatars0.githubusercontent.com/u/17931198?v=4","gravatar_id":"","url":"https://api.github.com/users/OTAkeys","html_url":"https://github.com/OTAkeys","followers_url":"https://api.github.com/users/OTAkeys/followers","following_url":"https://api.github.com/users/OTAkeys/following{/other_user}","gists_url":"https://api.github.com/users/OTAkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/OTAkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTAkeys/subscriptions","organizations_url":"https://api.github.com/users/OTAkeys/orgs","repos_url":"https://api.github.com/users/OTAkeys/repos","events_url":"https://api.github.com/users/OTAkeys/events{/privacy}","received_events_url":"https://api.github.com/users/OTAkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":54651566,"name":"RIOT","full_name":"OTAkeys/RIOT","owner":{"login":"OTAkeys","id":17931198,"avatar_url":"https://avatars0.githubusercontent.com/u/17931198?v=4","gravatar_id":"","url":"https://api.github.com/users/OTAkeys","html_url":"https://github.com/OTAkeys","followers_url":"https://api.github.com/users/OTAkeys/followers","following_url":"https://api.github.com/users/OTAkeys/following{/other_user}","gists_url":"https://api.github.com/users/OTAkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/OTAkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTAkeys/subscriptions","organizations_url":"https://api.github.com/users/OTAkeys/orgs","repos_url":"https://api.github.com/users/OTAkeys/repos","events_url":"https://api.github.com/users/OTAkeys/events{/privacy}","received_events_url":"https://api.github.com/users/OTAkeys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OTAkeys/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/OTAkeys/RIOT","forks_url":"https://api.github.com/repos/OTAkeys/RIOT/forks","keys_url":"https://api.github.com/repos/OTAkeys/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OTAkeys/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OTAkeys/RIOT/teams","hooks_url":"https://api.github.com/repos/OTAkeys/RIOT/hooks","issue_events_url":"https://api.github.com/repos/OTAkeys/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/OTAkeys/RIOT/events","assignees_url":"https://api.github.com/repos/OTAkeys/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/OTAkeys/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/OTAkeys/RIOT/tags","blobs_url":"https://api.github.com/repos/OTAkeys/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OTAkeys/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OTAkeys/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/OTAkeys/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OTAkeys/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/OTAkeys/RIOT/languages","stargazers_url":"https://api.github.com/repos/OTAkeys/RIOT/stargazers","contributors_url":"https://api.github.com/repos/OTAkeys/RIOT/contributors","subscribers_url":"https://api.github.com/repos/OTAkeys/RIOT/subscribers","subscription_url":"https://api.github.com/repos/OTAkeys/RIOT/subscription","commits_url":"https://api.github.com/repos/OTAkeys/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/OTAkeys/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/OTAkeys/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/OTAkeys/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/OTAkeys/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/OTAkeys/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OTAkeys/RIOT/merges","archive_url":"https://api.github.com/repos/OTAkeys/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OTAkeys/RIOT/downloads","issues_url":"https://api.github.com/repos/OTAkeys/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/OTAkeys/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/OTAkeys/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/OTAkeys/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OTAkeys/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/OTAkeys/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/OTAkeys/RIOT/deployments","created_at":"2016-03-24T15:12:29Z","updated_at":"2016-11-15T13:59:16Z","pushed_at":"2018-03-14T10:36:25Z","git_url":"git://github.com/OTAkeys/RIOT.git","ssh_url":"git@github.com:OTAkeys/RIOT.git","clone_url":"https://github.com/OTAkeys/RIOT.git","svn_url":"https://github.com/OTAkeys/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":50616,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"078104223a35722deb4953c73bc1141294378744","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-03-14T14:23:20Z","pushed_at":"2018-03-14T13:51:27Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":50084,"stargazers_count":1682,"watchers_count":1682,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":986,"mirror_url":null,"archived":false,"open_issues_count":711,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":986,"open_issues":711,"watchers":1682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8773"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8773"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8773/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8773/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/6c27e75a2ca7bd6b0c7e9374a4cf581e810536a6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cladmi"}}