{"action":"created","comment":{"url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/comments/197027903","pull_request_review_id":130686763,"id":197027903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzAyNzkwMw==","diff_hunk":"@@ -159,10 +151,18 @@ public TestObjectAppiumSuite(Class<?> clazz) throws InitializationError {\n \t\t\tSet<DataCenterSuite> dataCenterSuites = getDataCenterSuites();\n \n \t\t\tthis.perDeviceRunners = toRunners(clazz, dataCenterSuites);\n+\t\t}\n+\t\trunAllDevicesAtOnce(config);\n+\t}\n \n-\t\t\tthis.setScheduler(new ThreadPoolScheduler(perDeviceRunners.size(), testObjectTimeout, config.timeoutUnit()));\n+\tprivate void runAllDevicesAtOnce(TestObject config) {\n+\t\tint numRunners = perDeviceRunners.size();\n+\t\tint timeout = Env.getTimeout()","path":"src/main/java/org/testobject/appium/junit/TestObjectAppiumSuite.java","position":40,"original_position":40,"commit_id":"1e605e929782a9a6c1f511c90203f3f8f00e4d2e","original_commit_id":"1e605e929782a9a6c1f511c90203f3f8f00e4d2e","user":{"login":"stefanbirkner","id":711349,"node_id":"MDQ6VXNlcjcxMTM0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"body":"The annotation `TestObject` provides the default timeout of 60 minutes.","created_at":"2018-06-21T06:55:54Z","updated_at":"2018-06-21T06:55:54Z","html_url":"https://github.com/saucelabs/testobject-appium-java-api/pull/26#discussion_r197027903","pull_request_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/comments/197027903"},"html":{"href":"https://github.com/saucelabs/testobject-appium-java-api/pull/26#discussion_r197027903"},"pull_request":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26"}},"in_reply_to_id":196730883},"pull_request":{"url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26","id":195109290,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTA5Mjkw","html_url":"https://github.com/saucelabs/testobject-appium-java-api/pull/26","diff_url":"https://github.com/saucelabs/testobject-appium-java-api/pull/26.diff","patch_url":"https://github.com/saucelabs/testobject-appium-java-api/pull/26.patch","issue_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/26","number":26,"state":"open","locked":false,"title":"Run local tests with specified timeout settings","user":{"login":"stefanbirkner","id":711349,"node_id":"MDQ6VXNlcjcxMTM0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"body":"Principle of Least Surprise. It is not obvious that local tests don't consider the specified timeout.","created_at":"2018-06-15T08:33:52Z","updated_at":"2018-06-21T06:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46aa93497a6c6140079faffbf9d8176ac4cef4d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26/commits","review_comments_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26/comments","review_comment_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/26/comments","statuses_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/statuses/1e605e929782a9a6c1f511c90203f3f8f00e4d2e","head":{"label":"stefanbirkner:same-timeout","ref":"same-timeout","sha":"1e605e929782a9a6c1f511c90203f3f8f00e4d2e","user":{"login":"stefanbirkner","id":711349,"node_id":"MDQ6VXNlcjcxMTM0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"repo":{"id":134576996,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1NzY5OTY=","name":"testobject-appium-java-api","full_name":"stefanbirkner/testobject-appium-java-api","owner":{"login":"stefanbirkner","id":711349,"node_id":"MDQ6VXNlcjcxMTM0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanbirkner/testobject-appium-java-api","description":"Utility classes to provide a better experience when running Appium tests in the TestObject cloud.","fork":true,"url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api","forks_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/forks","keys_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/teams","hooks_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/hooks","issue_events_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/events","assignees_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/tags","blobs_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/languages","stargazers_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/stargazers","contributors_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/contributors","subscribers_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/subscribers","subscription_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/subscription","commits_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/merges","archive_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/downloads","issues_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/labels{/name}","releases_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/releases{/id}","deployments_url":"https://api.github.com/repos/stefanbirkner/testobject-appium-java-api/deployments","created_at":"2018-05-23T13:52:38Z","updated_at":"2018-06-15T07:40:25Z","pushed_at":"2018-06-15T08:18:03Z","git_url":"git://github.com/stefanbirkner/testobject-appium-java-api.git","ssh_url":"git@github.com:stefanbirkner/testobject-appium-java-api.git","clone_url":"https://github.com/stefanbirkner/testobject-appium-java-api.git","svn_url":"https://github.com/stefanbirkner/testobject-appium-java-api","homepage":"","size":179,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saucelabs:master","ref":"master","sha":"b17abf7f9c7cf2ac11ac3913c0f5799b72aa23eb","user":{"login":"saucelabs","id":88837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/88837?v=4","gravatar_id":"","url":"https://api.github.com/users/saucelabs","html_url":"https://github.com/saucelabs","followers_url":"https://api.github.com/users/saucelabs/followers","following_url":"https://api.github.com/users/saucelabs/following{/other_user}","gists_url":"https://api.github.com/users/saucelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/saucelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saucelabs/subscriptions","organizations_url":"https://api.github.com/users/saucelabs/orgs","repos_url":"https://api.github.com/users/saucelabs/repos","events_url":"https://api.github.com/users/saucelabs/events{/privacy}","received_events_url":"https://api.github.com/users/saucelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":32348648,"node_id":"MDEwOlJlcG9zaXRvcnkzMjM0ODY0OA==","name":"testobject-appium-java-api","full_name":"saucelabs/testobject-appium-java-api","owner":{"login":"saucelabs","id":88837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4ODM3","avatar_url":"https://avatars2.githubusercontent.com/u/88837?v=4","gravatar_id":"","url":"https://api.github.com/users/saucelabs","html_url":"https://github.com/saucelabs","followers_url":"https://api.github.com/users/saucelabs/followers","following_url":"https://api.github.com/users/saucelabs/following{/other_user}","gists_url":"https://api.github.com/users/saucelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/saucelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saucelabs/subscriptions","organizations_url":"https://api.github.com/users/saucelabs/orgs","repos_url":"https://api.github.com/users/saucelabs/repos","events_url":"https://api.github.com/users/saucelabs/events{/privacy}","received_events_url":"https://api.github.com/users/saucelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saucelabs/testobject-appium-java-api","description":"Utility classes to provide a better experience when running Appium tests in the TestObject cloud.","fork":false,"url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api","forks_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/forks","keys_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/teams","hooks_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/hooks","issue_events_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/events","assignees_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/tags","blobs_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/languages","stargazers_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/stargazers","contributors_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/contributors","subscribers_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/subscribers","subscription_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/subscription","commits_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/merges","archive_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/downloads","issues_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/labels{/name}","releases_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/releases{/id}","deployments_url":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/deployments","created_at":"2015-03-16T19:44:16Z","updated_at":"2018-06-13T16:10:54Z","pushed_at":"2018-06-15T08:33:53Z","git_url":"git://github.com/saucelabs/testobject-appium-java-api.git","ssh_url":"git@github.com:saucelabs/testobject-appium-java-api.git","clone_url":"https://github.com/saucelabs/testobject-appium-java-api.git","svn_url":"https://github.com/saucelabs/testobject-appium-java-api","homepage":"","size":186,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":7,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26"},"html":{"href":"https://github.com/saucelabs/testobject-appium-java-api/pull/26"},"issue":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/26"},"comments":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/saucelabs/testobject-appium-java-api/statuses/1e605e929782a9a6c1f511c90203f3f8f00e4d2e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stefanbirkner"}}