{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/sam/pulls/comments/173861953","pull_request_review_id":103120501,"id":173861953,"diff_hunk":"@@ -19,12 +19,14 @@ class ManagedGroupService(private val resourceService: ResourceService, private\n   def managedGroupType: ResourceType = resourceTypes.getOrElse(ManagedGroupService.managedGroupTypeName, throw new WorkbenchException(s\"resource type ${ManagedGroupService.managedGroupTypeName.value} not found\"))\n   def memberRole = managedGroupType.roles.find(_.roleName == ManagedGroupService.memberRoleName).getOrElse(throw new WorkbenchException(s\"${ManagedGroupService.memberRoleName} role does not exist in $managedGroupType\"))\n \n+  // TODO: What should be returned here?  Just a Resource object?  The report generated from the sync with Google?  Both?","path":"src/main/scala/org/broadinstitute/dsde/workbench/sam/service/ManagedGroupService.scala","position":4,"original_position":4,"commit_id":"40d3d93b90562e3d997f2db5877acb06c05b09ef","original_commit_id":"40d3d93b90562e3d997f2db5877acb06c05b09ef","user":{"login":"dvoet","id":1521333,"avatar_url":"https://avatars0.githubusercontent.com/u/1521333?v=4","gravatar_id":"","url":"https://api.github.com/users/dvoet","html_url":"https://github.com/dvoet","followers_url":"https://api.github.com/users/dvoet/followers","following_url":"https://api.github.com/users/dvoet/following{/other_user}","gists_url":"https://api.github.com/users/dvoet/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoet/subscriptions","organizations_url":"https://api.github.com/users/dvoet/orgs","repos_url":"https://api.github.com/users/dvoet/repos","events_url":"https://api.github.com/users/dvoet/events{/privacy}","received_events_url":"https://api.github.com/users/dvoet/received_events","type":"User","site_admin":false},"body":"I don't think we want the google stuff","created_at":"2018-03-12T16:33:42Z","updated_at":"2018-03-12T16:34:49Z","html_url":"https://github.com/broadinstitute/sam/pull/118#discussion_r173861953","pull_request_url":"https://api.github.com/repos/broadinstitute/sam/pulls/118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/comments/173861953"},"html":{"href":"https://github.com/broadinstitute/sam/pull/118#discussion_r173861953"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/sam/pulls/118","id":174185031,"html_url":"https://github.com/broadinstitute/sam/pull/118","diff_url":"https://github.com/broadinstitute/sam/pull/118.diff","patch_url":"https://github.com/broadinstitute/sam/pull/118.patch","issue_url":"https://api.github.com/repos/broadinstitute/sam/issues/118","number":118,"state":"open","locked":false,"title":"GAWB-2526 Automatically sync Managed Group with Google on Create","user":{"login":"gpolumbo-broad","id":36171087,"avatar_url":"https://avatars3.githubusercontent.com/u/36171087?v=4","gravatar_id":"","url":"https://api.github.com/users/gpolumbo-broad","html_url":"https://github.com/gpolumbo-broad","followers_url":"https://api.github.com/users/gpolumbo-broad/followers","following_url":"https://api.github.com/users/gpolumbo-broad/following{/other_user}","gists_url":"https://api.github.com/users/gpolumbo-broad/gists{/gist_id}","starred_url":"https://api.github.com/users/gpolumbo-broad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpolumbo-broad/subscriptions","organizations_url":"https://api.github.com/users/gpolumbo-broad/orgs","repos_url":"https://api.github.com/users/gpolumbo-broad/repos","events_url":"https://api.github.com/users/gpolumbo-broad/events{/privacy}","received_events_url":"https://api.github.com/users/gpolumbo-broad/received_events","type":"User","site_admin":false},"body":"I made a separate PR for this because I have questions that will most likely result in some additional commits. and PR https://github.com/broadinstitute/sam/pull/108 is already quite large.  \r\n\r\nIn particular, I need answers to a couple of questions, these are also marked as TODO's in the branch.\r\n\r\n1.  When creating a Google Group, should we also trigger `GoogleExtensions.onGroupUpdate`? \r\n2. What should be in the BODY of the response to `POST /api/group/{groupName}`?  Since we're doing the Google Sync as part of the creation, it seems reasonable to me to put the \"update report\" in the body.\r\n\r\nHave you read [CONTRIBUTING.md](../CONTRIBUTING.md) lately? If not, do that first.\r\n\r\nI, the developer opening this PR, do solemnly pinky swear that:\r\n\r\n- [ ] I've followed [the instructions](https://github.com/broadinstitute/sam/blob/develop/CONTRIBUTING.md#api-changes) if I've made any changes to the API, _especially_ if they're breaking changes\r\n- [ ] I've updated the RC_XXX release ticket with any manual steps required to release this change\r\n- [ ] I've updated the [FISMA documentation](https://github.com/broadinstitute/sam/blob/develop/CONTRIBUTING.md#fisma-documentation-changes) if I've made any security-related changes, including auth, encryption, or auditing\r\n\r\nIn all cases:\r\n\r\n- [ ] Get two thumbsworth of review and PO signoff if necessary\r\n- [ ] Verify all tests go green\r\n- [ ] Squash and merge; you can delete your branch after this **unless it's for a hotfix**. In that case, don't delete it!\r\n- [ ] Test this change deployed correctly and works on dev environment after deployment\r\n","created_at":"2018-03-10T19:16:36Z","updated_at":"2018-03-12T16:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba5c9a06d96e516e2f308ddae49b1122eedb7b98","assignee":null,"assignees":[],"requested_reviewers":[{"login":"breilly2","id":19228696,"avatar_url":"https://avatars2.githubusercontent.com/u/19228696?v=4","gravatar_id":"","url":"https://api.github.com/users/breilly2","html_url":"https://github.com/breilly2","followers_url":"https://api.github.com/users/breilly2/followers","following_url":"https://api.github.com/users/breilly2/following{/other_user}","gists_url":"https://api.github.com/users/breilly2/gists{/gist_id}","starred_url":"https://api.github.com/users/breilly2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breilly2/subscriptions","organizations_url":"https://api.github.com/users/breilly2/orgs","repos_url":"https://api.github.com/users/breilly2/repos","events_url":"https://api.github.com/users/breilly2/events{/privacy}","received_events_url":"https://api.github.com/users/breilly2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/sam/pulls/118/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/sam/pulls/118/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/sam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/sam/issues/118/comments","statuses_url":"https://api.github.com/repos/broadinstitute/sam/statuses/40d3d93b90562e3d997f2db5877acb06c05b09ef","head":{"label":"broadinstitute:gpolumbo-GAWB-2526-group-sync-oncreate","ref":"gpolumbo-GAWB-2526-group-sync-oncreate","sha":"40d3d93b90562e3d997f2db5877acb06c05b09ef","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":91372329,"name":"sam","full_name":"broadinstitute/sam","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/sam","description":"workbench identity and access management","fork":false,"url":"https://api.github.com/repos/broadinstitute/sam","forks_url":"https://api.github.com/repos/broadinstitute/sam/forks","keys_url":"https://api.github.com/repos/broadinstitute/sam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/sam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/sam/teams","hooks_url":"https://api.github.com/repos/broadinstitute/sam/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/sam/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/sam/events","assignees_url":"https://api.github.com/repos/broadinstitute/sam/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/sam/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/sam/tags","blobs_url":"https://api.github.com/repos/broadinstitute/sam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/sam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/sam/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/sam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/sam/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/sam/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/sam/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/sam/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/sam/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/sam/subscription","commits_url":"https://api.github.com/repos/broadinstitute/sam/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/sam/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/sam/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/sam/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/sam/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/sam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/sam/merges","archive_url":"https://api.github.com/repos/broadinstitute/sam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/sam/downloads","issues_url":"https://api.github.com/repos/broadinstitute/sam/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/sam/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/sam/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/sam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/sam/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/sam/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/sam/deployments","created_at":"2017-05-15T18:42:46Z","updated_at":"2018-03-12T15:27:15Z","pushed_at":"2018-03-12T14:31:41Z","git_url":"git://github.com/broadinstitute/sam.git","ssh_url":"git@github.com:broadinstitute/sam.git","clone_url":"https://github.com/broadinstitute/sam.git","svn_url":"https://github.com/broadinstitute/sam","homepage":null,"size":12990,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":7,"watchers":4,"default_branch":"develop"}},"base":{"label":"broadinstitute:gpolumbo-GAWB-2526","ref":"gpolumbo-GAWB-2526","sha":"ecdcb382f3386c661eda6ca3120179834b57105a","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":91372329,"name":"sam","full_name":"broadinstitute/sam","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/sam","description":"workbench identity and access management","fork":false,"url":"https://api.github.com/repos/broadinstitute/sam","forks_url":"https://api.github.com/repos/broadinstitute/sam/forks","keys_url":"https://api.github.com/repos/broadinstitute/sam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/sam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/sam/teams","hooks_url":"https://api.github.com/repos/broadinstitute/sam/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/sam/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/sam/events","assignees_url":"https://api.github.com/repos/broadinstitute/sam/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/sam/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/sam/tags","blobs_url":"https://api.github.com/repos/broadinstitute/sam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/sam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/sam/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/sam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/sam/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/sam/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/sam/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/sam/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/sam/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/sam/subscription","commits_url":"https://api.github.com/repos/broadinstitute/sam/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/sam/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/sam/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/sam/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/sam/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/sam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/sam/merges","archive_url":"https://api.github.com/repos/broadinstitute/sam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/sam/downloads","issues_url":"https://api.github.com/repos/broadinstitute/sam/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/sam/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/sam/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/sam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/sam/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/sam/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/sam/deployments","created_at":"2017-05-15T18:42:46Z","updated_at":"2018-03-12T15:27:15Z","pushed_at":"2018-03-12T14:31:41Z","git_url":"git://github.com/broadinstitute/sam.git","ssh_url":"git@github.com:broadinstitute/sam.git","clone_url":"https://github.com/broadinstitute/sam.git","svn_url":"https://github.com/broadinstitute/sam","homepage":null,"size":12990,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":7,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/118"},"html":{"href":"https://github.com/broadinstitute/sam/pull/118"},"issue":{"href":"https://api.github.com/repos/broadinstitute/sam/issues/118"},"comments":{"href":"https://api.github.com/repos/broadinstitute/sam/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/sam/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/sam/statuses/40d3d93b90562e3d997f2db5877acb06c05b09ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dvoet"}}