{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments/188894691","pull_request_review_id":120946497,"id":188894691,"diff_hunk":"@@ -409,11 +412,14 @@ public void onSuccess(List<Pair<byte[], byte[]>> result) {\n                         try {\n                             synchronized (FastSyncManager.this) {\n                                 logger.trace(\"Received \" + result.size() + \" nodes (of \" + hashes.size() + \") from peer: \" + idle);\n+                                idle.getNodeStatistics().eth63NodesRequested.add(hashes.size());\n+                                idle.getNodeStatistics().eth63NodesRetrieveTime.add(System.currentTimeMillis() - reqTime);\n                                 for (Pair<byte[], byte[]> pair : result) {\n                                     TrieNodeRequest request = pendingNodes.get(pair.getKey());\n                                     if (request == null) {\n                                         long t = System.currentTimeMillis();\n                                         logger.debug(\"Received node which was not requested: \" + toHexString(pair.getKey()) + \" from \" + idle);\n+                                        idle.disconnect(ReasonCode.USELESS_PEER);","path":"ethereumj-core/src/main/java/org/ethereum/sync/FastSyncManager.java","position":21,"original_position":21,"commit_id":"9bb6d67a73f782d0c3a992fd5fe535224b484cbd","original_commit_id":"9bb6d67a73f782d0c3a992fd5fe535224b484cbd","user":{"login":"mkalinin","id":1892772,"avatar_url":"https://avatars3.githubusercontent.com/u/1892772?v=4","gravatar_id":"","url":"https://api.github.com/users/mkalinin","html_url":"https://github.com/mkalinin","followers_url":"https://api.github.com/users/mkalinin/followers","following_url":"https://api.github.com/users/mkalinin/following{/other_user}","gists_url":"https://api.github.com/users/mkalinin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkalinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkalinin/subscriptions","organizations_url":"https://api.github.com/users/mkalinin/orgs","repos_url":"https://api.github.com/users/mkalinin/repos","events_url":"https://api.github.com/users/mkalinin/events{/privacy}","received_events_url":"https://api.github.com/users/mkalinin/received_events","type":"User","site_admin":false},"body":"This case could not be related to the meaning of log message standing above. It may be a result of  `pendingNodes` purging due to `REQUEST_TIMEOUT`. Isn't it too rude to disconnect peer with `USELESS_PEER` reason in that case? Btw, log message could also be fixed to avoid misunderstanding in the future.","created_at":"2018-05-17T09:31:15Z","updated_at":"2018-05-17T09:33:01Z","html_url":"https://github.com/ethereum/ethereumj/pull/1074#discussion_r188894691","pull_request_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments/188894691"},"html":{"href":"https://github.com/ethereum/ethereumj/pull/1074#discussion_r188894691"},"pull_request":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074","id":187476606,"html_url":"https://github.com/ethereum/ethereumj/pull/1074","diff_url":"https://github.com/ethereum/ethereumj/pull/1074.diff","patch_url":"https://github.com/ethereum/ethereumj/pull/1074.patch","issue_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1074","number":1074,"state":"open","locked":false,"title":"Several fixes for FastSync","user":{"login":"zilm13","id":6196452,"avatar_url":"https://avatars2.githubusercontent.com/u/6196452?v=4","gravatar_id":"","url":"https://api.github.com/users/zilm13","html_url":"https://github.com/zilm13","followers_url":"https://api.github.com/users/zilm13/followers","following_url":"https://api.github.com/users/zilm13/following{/other_user}","gists_url":"https://api.github.com/users/zilm13/gists{/gist_id}","starred_url":"https://api.github.com/users/zilm13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilm13/subscriptions","organizations_url":"https://api.github.com/users/zilm13/orgs","repos_url":"https://api.github.com/users/zilm13/repos","events_url":"https://api.github.com/users/zilm13/events{/privacy}","received_events_url":"https://api.github.com/users/zilm13/received_events","type":"User","site_admin":false},"body":"- Headers DB removed after fast sync is over if \"skipHistory\" option was not enabled. No restart is required\r\n- Fixed bug in `SyncQueueReverseImpl` which could force Fast sync to stall for a long time when it needs only to download 256 blocks\r\n- More aggressive sync pool strategy is used during syncing: other peers are dropped if they are not used and we need more peers for sync while other peers are not suitable for our needs","created_at":"2018-05-11T14:15:40Z","updated_at":"2018-05-17T09:33:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33c9e763aa843a8b3d2e16b0139597a670a466a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074/commits","review_comments_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074/comments","review_comment_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1074/comments","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/9bb6d67a73f782d0c3a992fd5fe535224b484cbd","head":{"label":"ethereum:fix/remove-headers-db","ref":"fix/remove-headers-db","sha":"9bb6d67a73f782d0c3a992fd5fe535224b484cbd","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":19730456,"name":"ethereumj","full_name":"ethereum/ethereumj","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":false,"url":"https://api.github.com/repos/ethereum/ethereumj","forks_url":"https://api.github.com/repos/ethereum/ethereumj/forks","keys_url":"https://api.github.com/repos/ethereum/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethereumj/teams","hooks_url":"https://api.github.com/repos/ethereum/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethereumj/events","assignees_url":"https://api.github.com/repos/ethereum/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethereumj/tags","blobs_url":"https://api.github.com/repos/ethereum/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethereumj/subscription","commits_url":"https://api.github.com/repos/ethereum/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethereumj/merges","archive_url":"https://api.github.com/repos/ethereum/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethereumj/downloads","issues_url":"https://api.github.com/repos/ethereum/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/ethereumj/deployments","created_at":"2014-05-13T07:50:14Z","updated_at":"2018-05-17T07:53:06Z","pushed_at":"2018-05-17T07:08:32Z","git_url":"git://github.com/ethereum/ethereumj.git","ssh_url":"git@github.com:ethereum/ethereumj.git","clone_url":"https://github.com/ethereum/ethereumj.git","svn_url":"https://github.com/ethereum/ethereumj","homepage":"","size":46374,"stargazers_count":1542,"watchers_count":1542,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":791,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":791,"open_issues":83,"watchers":1542,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"e6a5dd6bb6e319ce536b1778bd5c036ba55aa8c6","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":19730456,"name":"ethereumj","full_name":"ethereum/ethereumj","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":false,"url":"https://api.github.com/repos/ethereum/ethereumj","forks_url":"https://api.github.com/repos/ethereum/ethereumj/forks","keys_url":"https://api.github.com/repos/ethereum/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethereumj/teams","hooks_url":"https://api.github.com/repos/ethereum/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethereumj/events","assignees_url":"https://api.github.com/repos/ethereum/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethereumj/tags","blobs_url":"https://api.github.com/repos/ethereum/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethereumj/subscription","commits_url":"https://api.github.com/repos/ethereum/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethereumj/merges","archive_url":"https://api.github.com/repos/ethereum/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethereumj/downloads","issues_url":"https://api.github.com/repos/ethereum/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/ethereumj/deployments","created_at":"2014-05-13T07:50:14Z","updated_at":"2018-05-17T07:53:06Z","pushed_at":"2018-05-17T07:08:32Z","git_url":"git://github.com/ethereum/ethereumj.git","ssh_url":"git@github.com:ethereum/ethereumj.git","clone_url":"https://github.com/ethereum/ethereumj.git","svn_url":"https://github.com/ethereum/ethereumj","homepage":"","size":46374,"stargazers_count":1542,"watchers_count":1542,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":791,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":791,"open_issues":83,"watchers":1542,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074"},"html":{"href":"https://github.com/ethereum/ethereumj/pull/1074"},"issue":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1074"},"comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1074/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1074/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/ethereumj/statuses/9bb6d67a73f782d0c3a992fd5fe535224b484cbd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mkalinin"}}