{"action":"created","comment":{"url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/comments/230469475","pull_request_review_id":171222165,"id":230469475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ2OTQ3NQ==","diff_hunk":"@@ -625,19 +748,21 @@ func (a *Operator) crdOwnerConflicts(in *v1alpha1.ClusterServiceVersion, csvsInN\n \treturn nil\n }\n \n-// annotateNamespace is the method that gets called when we see a namespace event in the cluster\n-func (a *Operator) annotateNamespace(obj interface{}) (syncError error) {\n+// syncNamespace is the method that gets called when we see a namespace event in the cluster\n+func (a *Operator) syncNamespace(obj interface{}) (syncError error) {\n \tnamespace, ok := obj.(*corev1.Namespace)\n+\tnamespaceName := namespace.GetName()","path":"pkg/controller/operators/olm/operator.go","position":285,"original_position":285,"commit_id":"5b7d1407047d07823fdfc72d4069a7784ade1e92","original_commit_id":"5b7d1407047d07823fdfc72d4069a7784ade1e92","user":{"login":"ecordell","id":58055,"node_id":"MDQ6VXNlcjU4MDU1","avatar_url":"https://avatars3.githubusercontent.com/u/58055?v=4","gravatar_id":"","url":"https://api.github.com/users/ecordell","html_url":"https://github.com/ecordell","followers_url":"https://api.github.com/users/ecordell/followers","following_url":"https://api.github.com/users/ecordell/following{/other_user}","gists_url":"https://api.github.com/users/ecordell/gists{/gist_id}","starred_url":"https://api.github.com/users/ecordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecordell/subscriptions","organizations_url":"https://api.github.com/users/ecordell/orgs","repos_url":"https://api.github.com/users/ecordell/repos","events_url":"https://api.github.com/users/ecordell/events{/privacy}","received_events_url":"https://api.github.com/users/ecordell/received_events","type":"User","site_admin":false},"body":"this should move below the `ok` check","created_at":"2018-11-02T18:34:08Z","updated_at":"2018-11-02T18:39:19Z","html_url":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480#discussion_r230469475","pull_request_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/comments/230469475"},"html":{"href":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480#discussion_r230469475"},"pull_request":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480"}}},"pull_request":{"url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480","id":217795198,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Nzk1MTk4","html_url":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480","diff_url":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480.diff","patch_url":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480.patch","issue_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/480","number":480,"state":"open","locked":false,"title":"add OperatorGroup","user":{"login":"jpeeler","id":834161,"node_id":"MDQ6VXNlcjgzNDE2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/834161?v=4","gravatar_id":"","url":"https://api.github.com/users/jpeeler","html_url":"https://github.com/jpeeler","followers_url":"https://api.github.com/users/jpeeler/followers","following_url":"https://api.github.com/users/jpeeler/following{/other_user}","gists_url":"https://api.github.com/users/jpeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeeler/subscriptions","organizations_url":"https://api.github.com/users/jpeeler/orgs","repos_url":"https://api.github.com/users/jpeeler/repos","events_url":"https://api.github.com/users/jpeeler/events{/privacy}","received_events_url":"https://api.github.com/users/jpeeler/received_events","type":"User","site_admin":false},"body":"So far the reconcile loop only looks at the namespace selector and writes the results to the status and an annotation on each deployment.","created_at":"2018-09-24T21:34:12Z","updated_at":"2018-11-02T18:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0302f724c87cb683cbb44b22d85912fa28806223","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1061354095,"node_id":"MDU6TGFiZWwxMDYxMzU0MDk1","url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480/commits","review_comments_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480/comments","review_comment_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/480/comments","statuses_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/statuses/5b7d1407047d07823fdfc72d4069a7784ade1e92","head":{"label":"jpeeler:add-operator-group","ref":"add-operator-group","sha":"5b7d1407047d07823fdfc72d4069a7784ade1e92","user":{"login":"jpeeler","id":834161,"node_id":"MDQ6VXNlcjgzNDE2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/834161?v=4","gravatar_id":"","url":"https://api.github.com/users/jpeeler","html_url":"https://github.com/jpeeler","followers_url":"https://api.github.com/users/jpeeler/followers","following_url":"https://api.github.com/users/jpeeler/following{/other_user}","gists_url":"https://api.github.com/users/jpeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeeler/subscriptions","organizations_url":"https://api.github.com/users/jpeeler/orgs","repos_url":"https://api.github.com/users/jpeeler/repos","events_url":"https://api.github.com/users/jpeeler/events{/privacy}","received_events_url":"https://api.github.com/users/jpeeler/received_events","type":"User","site_admin":false},"repo":{"id":146619894,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MTk4OTQ=","name":"operator-lifecycle-manager","full_name":"jpeeler/operator-lifecycle-manager","private":false,"owner":{"login":"jpeeler","id":834161,"node_id":"MDQ6VXNlcjgzNDE2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/834161?v=4","gravatar_id":"","url":"https://api.github.com/users/jpeeler","html_url":"https://github.com/jpeeler","followers_url":"https://api.github.com/users/jpeeler/followers","following_url":"https://api.github.com/users/jpeeler/following{/other_user}","gists_url":"https://api.github.com/users/jpeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeeler/subscriptions","organizations_url":"https://api.github.com/users/jpeeler/orgs","repos_url":"https://api.github.com/users/jpeeler/repos","events_url":"https://api.github.com/users/jpeeler/events{/privacy}","received_events_url":"https://api.github.com/users/jpeeler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jpeeler/operator-lifecycle-manager","description":"Automated updates for Kubernetes Operators","fork":true,"url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager","forks_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/forks","keys_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/teams","hooks_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/hooks","issue_events_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/events","assignees_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/tags","blobs_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/languages","stargazers_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/stargazers","contributors_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/contributors","subscribers_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/subscribers","subscription_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/subscription","commits_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/merges","archive_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/downloads","issues_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/labels{/name}","releases_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jpeeler/operator-lifecycle-manager/deployments","created_at":"2018-08-29T15:22:39Z","updated_at":"2018-08-29T15:22:40Z","pushed_at":"2018-11-02T18:01:59Z","git_url":"git://github.com/jpeeler/operator-lifecycle-manager.git","ssh_url":"git@github.com:jpeeler/operator-lifecycle-manager.git","clone_url":"https://github.com/jpeeler/operator-lifecycle-manager.git","svn_url":"https://github.com/jpeeler/operator-lifecycle-manager","homepage":"","size":12032,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"operator-framework:master","ref":"master","sha":"d7ee48190073e8d8908a151b29584f5dbedd0c87","user":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":100052573,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNTI1NzM=","name":"operator-lifecycle-manager","full_name":"operator-framework/operator-lifecycle-manager","private":false,"owner":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/operator-framework/operator-lifecycle-manager","description":"A management framework for extending Kubernetes with Operators","fork":false,"url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager","forks_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/forks","keys_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/teams","hooks_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/hooks","issue_events_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/events{/number}","events_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/events","assignees_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/assignees{/user}","branches_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/branches{/branch}","tags_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/tags","blobs_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/languages","stargazers_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/stargazers","contributors_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/contributors","subscribers_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/subscribers","subscription_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/subscription","commits_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/contents/{+path}","compare_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/merges","archive_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/downloads","issues_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues{/number}","pulls_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/labels{/name}","releases_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/releases{/id}","deployments_url":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/deployments","created_at":"2017-08-11T16:47:06Z","updated_at":"2018-11-02T18:32:19Z","pushed_at":"2018-11-02T18:35:08Z","git_url":"git://github.com/operator-framework/operator-lifecycle-manager.git","ssh_url":"git@github.com:operator-framework/operator-lifecycle-manager.git","clone_url":"https://github.com/operator-framework/operator-lifecycle-manager.git","svn_url":"https://github.com/operator-framework/operator-lifecycle-manager","homepage":"","size":11975,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":17,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480"},"html":{"href":"https://github.com/operator-framework/operator-lifecycle-manager/pull/480"},"issue":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/480"},"comments":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/operator-framework/operator-lifecycle-manager/statuses/5b7d1407047d07823fdfc72d4069a7784ade1e92"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ecordell"}}