{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/data-access/pulls/comments/222685431","pull_request_review_id":161631326,"id":222685431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjY4NTQzMQ==","diff_hunk":"@@ -579,13 +581,8 @@ public DatasourceDTO deSerializeModelState( String dtoStr ) throws DatasourceSer\n       component.validate( PentahoSessionHolder.getSession(), null );\n       component.setAction( PMDUIComponent.ACTION_LIST_MODELS );\n       Document document = component.getXmlContent();\n-      List<DefaultElement> modelElements = document.selectNodes( \"//model_name\" ); //$NON-NLS-1$\n \n-      ArrayList<String> datasourceNames = new ArrayList<String>();\n-      for ( DefaultElement element : modelElements ) {\n-        datasourceNames.add( element.getText() );\n-      }\n-      return datasourceNames;\n+      return ( (List<Node>) document.selectNodes( \"//model_name\" ) ).stream().map( x -> x.getText() ).collect( toList() );","path":"core/src/main/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/DSWDatasourceServiceImpl.java","position":29,"original_position":29,"commit_id":"6842f09e8cec0a51710070c12d2ad0f917619a64","original_commit_id":"6842f09e8cec0a51710070c12d2ad0f917619a64","user":{"login":"mbatchelor","id":1135544,"node_id":"MDQ6VXNlcjExMzU1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1135544?v=4","gravatar_id":"","url":"https://api.github.com/users/mbatchelor","html_url":"https://github.com/mbatchelor","followers_url":"https://api.github.com/users/mbatchelor/followers","following_url":"https://api.github.com/users/mbatchelor/following{/other_user}","gists_url":"https://api.github.com/users/mbatchelor/gists{/gist_id}","starred_url":"https://api.github.com/users/mbatchelor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbatchelor/subscriptions","organizations_url":"https://api.github.com/users/mbatchelor/orgs","repos_url":"https://api.github.com/users/mbatchelor/repos","events_url":"https://api.github.com/users/mbatchelor/events{/privacy}","received_events_url":"https://api.github.com/users/mbatchelor/received_events","type":"User","site_admin":false},"body":"While correct, this diminishes readability. Not sure this was warranted.","created_at":"2018-10-04T14:12:32Z","updated_at":"2018-10-04T14:12:36Z","html_url":"https://github.com/pentaho/data-access/pull/1019#discussion_r222685431","pull_request_url":"https://api.github.com/repos/pentaho/data-access/pulls/1019","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/comments/222685431"},"html":{"href":"https://github.com/pentaho/data-access/pull/1019#discussion_r222685431"},"pull_request":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/1019"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/data-access/pulls/1019","id":213381388,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzgxMzg4","html_url":"https://github.com/pentaho/data-access/pull/1019","diff_url":"https://github.com/pentaho/data-access/pull/1019.diff","patch_url":"https://github.com/pentaho/data-access/pull/1019.patch","issue_url":"https://api.github.com/repos/pentaho/data-access/issues/1019","number":1019,"state":"open","locked":false,"title":"[PPP-4182] Use of vulnerable component dom4j-1.6.1.jar  CVE-2018-1000632","user":{"login":"pentaho-lmartins","id":33635091,"node_id":"MDQ6VXNlcjMzNjM1MDkx","avatar_url":"https://avatars3.githubusercontent.com/u/33635091?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho-lmartins","html_url":"https://github.com/pentaho-lmartins","followers_url":"https://api.github.com/users/pentaho-lmartins/followers","following_url":"https://api.github.com/users/pentaho-lmartins/following{/other_user}","gists_url":"https://api.github.com/users/pentaho-lmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho-lmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho-lmartins/subscriptions","organizations_url":"https://api.github.com/users/pentaho-lmartins/orgs","repos_url":"https://api.github.com/users/pentaho-lmartins/repos","events_url":"https://api.github.com/users/pentaho-lmartins/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho-lmartins/received_events","type":"User","site_admin":false},"body":"This is one of a series of PRs. See pentaho/maven-parent-poms#70 for the complete list and more details. **Do not merge until further notice!**\r\n\r\n@graimundo","created_at":"2018-09-05T18:06:29Z","updated_at":"2018-10-04T14:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66f673d250f327f8507a6e640c24457544274a43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/data-access/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/pentaho/data-access/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/pentaho/data-access/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/data-access/issues/1019/comments","statuses_url":"https://api.github.com/repos/pentaho/data-access/statuses/6842f09e8cec0a51710070c12d2ad0f917619a64","head":{"label":"pentaho-lmartins:PPP-4182","ref":"PPP-4182","sha":"6842f09e8cec0a51710070c12d2ad0f917619a64","user":{"login":"pentaho-lmartins","id":33635091,"node_id":"MDQ6VXNlcjMzNjM1MDkx","avatar_url":"https://avatars3.githubusercontent.com/u/33635091?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho-lmartins","html_url":"https://github.com/pentaho-lmartins","followers_url":"https://api.github.com/users/pentaho-lmartins/followers","following_url":"https://api.github.com/users/pentaho-lmartins/following{/other_user}","gists_url":"https://api.github.com/users/pentaho-lmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho-lmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho-lmartins/subscriptions","organizations_url":"https://api.github.com/users/pentaho-lmartins/orgs","repos_url":"https://api.github.com/users/pentaho-lmartins/repos","events_url":"https://api.github.com/users/pentaho-lmartins/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho-lmartins/received_events","type":"User","site_admin":false},"repo":{"id":114647549,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2NDc1NDk=","name":"data-access","full_name":"pentaho-lmartins/data-access","private":false,"owner":{"login":"pentaho-lmartins","id":33635091,"node_id":"MDQ6VXNlcjMzNjM1MDkx","avatar_url":"https://avatars3.githubusercontent.com/u/33635091?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho-lmartins","html_url":"https://github.com/pentaho-lmartins","followers_url":"https://api.github.com/users/pentaho-lmartins/followers","following_url":"https://api.github.com/users/pentaho-lmartins/following{/other_user}","gists_url":"https://api.github.com/users/pentaho-lmartins/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho-lmartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho-lmartins/subscriptions","organizations_url":"https://api.github.com/users/pentaho-lmartins/orgs","repos_url":"https://api.github.com/users/pentaho-lmartins/repos","events_url":"https://api.github.com/users/pentaho-lmartins/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho-lmartins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pentaho-lmartins/data-access","description":"Pentaho Data Access Wizard","fork":true,"url":"https://api.github.com/repos/pentaho-lmartins/data-access","forks_url":"https://api.github.com/repos/pentaho-lmartins/data-access/forks","keys_url":"https://api.github.com/repos/pentaho-lmartins/data-access/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho-lmartins/data-access/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho-lmartins/data-access/teams","hooks_url":"https://api.github.com/repos/pentaho-lmartins/data-access/hooks","issue_events_url":"https://api.github.com/repos/pentaho-lmartins/data-access/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho-lmartins/data-access/events","assignees_url":"https://api.github.com/repos/pentaho-lmartins/data-access/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho-lmartins/data-access/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho-lmartins/data-access/tags","blobs_url":"https://api.github.com/repos/pentaho-lmartins/data-access/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho-lmartins/data-access/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho-lmartins/data-access/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho-lmartins/data-access/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho-lmartins/data-access/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho-lmartins/data-access/languages","stargazers_url":"https://api.github.com/repos/pentaho-lmartins/data-access/stargazers","contributors_url":"https://api.github.com/repos/pentaho-lmartins/data-access/contributors","subscribers_url":"https://api.github.com/repos/pentaho-lmartins/data-access/subscribers","subscription_url":"https://api.github.com/repos/pentaho-lmartins/data-access/subscription","commits_url":"https://api.github.com/repos/pentaho-lmartins/data-access/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho-lmartins/data-access/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho-lmartins/data-access/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho-lmartins/data-access/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho-lmartins/data-access/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho-lmartins/data-access/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho-lmartins/data-access/merges","archive_url":"https://api.github.com/repos/pentaho-lmartins/data-access/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho-lmartins/data-access/downloads","issues_url":"https://api.github.com/repos/pentaho-lmartins/data-access/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho-lmartins/data-access/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho-lmartins/data-access/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho-lmartins/data-access/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho-lmartins/data-access/labels{/name}","releases_url":"https://api.github.com/repos/pentaho-lmartins/data-access/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho-lmartins/data-access/deployments","created_at":"2017-12-18T13:59:53Z","updated_at":"2018-09-22T23:21:40Z","pushed_at":"2018-09-22T23:22:11Z","git_url":"git://github.com/pentaho-lmartins/data-access.git","ssh_url":"git@github.com:pentaho-lmartins/data-access.git","clone_url":"https://github.com/pentaho-lmartins/data-access.git","svn_url":"https://github.com/pentaho-lmartins/data-access","homepage":"www.pentaho.com","size":6872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"3da48249b8d06c136c4bc0b0efa8f376e50e4686","user":{"login":"pentaho","id":1022787,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjI3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":2316191,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE2MTkx","name":"data-access","full_name":"pentaho/data-access","private":false,"owner":{"login":"pentaho","id":1022787,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjI3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1022787?v=4","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pentaho/data-access","description":"Pentaho Data Access Wizard","fork":false,"url":"https://api.github.com/repos/pentaho/data-access","forks_url":"https://api.github.com/repos/pentaho/data-access/forks","keys_url":"https://api.github.com/repos/pentaho/data-access/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/data-access/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/data-access/teams","hooks_url":"https://api.github.com/repos/pentaho/data-access/hooks","issue_events_url":"https://api.github.com/repos/pentaho/data-access/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/data-access/events","assignees_url":"https://api.github.com/repos/pentaho/data-access/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/data-access/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/data-access/tags","blobs_url":"https://api.github.com/repos/pentaho/data-access/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/data-access/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/data-access/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/data-access/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/data-access/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/data-access/languages","stargazers_url":"https://api.github.com/repos/pentaho/data-access/stargazers","contributors_url":"https://api.github.com/repos/pentaho/data-access/contributors","subscribers_url":"https://api.github.com/repos/pentaho/data-access/subscribers","subscription_url":"https://api.github.com/repos/pentaho/data-access/subscription","commits_url":"https://api.github.com/repos/pentaho/data-access/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/data-access/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/data-access/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/data-access/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/data-access/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/data-access/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/data-access/merges","archive_url":"https://api.github.com/repos/pentaho/data-access/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/data-access/downloads","issues_url":"https://api.github.com/repos/pentaho/data-access/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/data-access/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/data-access/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/data-access/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/data-access/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/data-access/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/data-access/deployments","created_at":"2011-09-02T20:11:11Z","updated_at":"2018-10-02T16:58:09Z","pushed_at":"2018-10-03T21:31:06Z","git_url":"git://github.com/pentaho/data-access.git","ssh_url":"git@github.com:pentaho/data-access.git","clone_url":"https://github.com/pentaho/data-access.git","svn_url":"https://github.com/pentaho/data-access","homepage":"www.pentaho.com","size":6968,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":120,"open_issues":9,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/1019"},"html":{"href":"https://github.com/pentaho/data-access/pull/1019"},"issue":{"href":"https://api.github.com/repos/pentaho/data-access/issues/1019"},"comments":{"href":"https://api.github.com/repos/pentaho/data-access/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/data-access/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/data-access/statuses/6842f09e8cec0a51710070c12d2ad0f917619a64"}},"author_association":"NONE"}}
{"actor":{"display_login":"mbatchelor"}}