{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hive/pulls/comments/238342955","pull_request_review_id":180861029,"id":238342955,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODM0Mjk1NQ==","diff_hunk":"@@ -229,12 +229,12 @@ private void addPartition(boolean hasMorePartitions, AddPartitionDesc addPartiti\n \n     // if move optimization is enabled, copy the files directly to the target path. No need to create the staging dir.\n     LoadFileType loadFileType;\n-    if (event.replicationSpec().isInReplicationScope() &&\n+    if (event.replicationSpec().isInReplicationScope() && !event.replicationSpec().isDoingMigration() &&\n             context.hiveConf.getBoolVar(REPL_ENABLE_MOVE_OPTIMIZATION)) {\n       loadFileType = LoadFileType.IGNORE;\n     } else {\n-      loadFileType =\n-              event.replicationSpec().isReplace() ? LoadFileType.REPLACE_ALL : LoadFileType.OVERWRITE_EXISTING;\n+      loadFileType = event.replicationSpec().isReplace() ? LoadFileType.REPLACE_ALL :\n+              event.replicationSpec().isDoingMigration() ? LoadFileType.KEEP_EXISTING : LoadFileType.OVERWRITE_EXISTING;","path":"ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java","position":12,"original_position":12,"commit_id":"c561ea22b03badeee9f223179e9199cbcb456e63","original_commit_id":"c561ea22b03badeee9f223179e9199cbcb456e63","user":{"login":"maheshk114","id":19660171,"node_id":"MDQ6VXNlcjE5NjYwMTcx","avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"body":"in case of acid tables OVERWRITE_EXISTING throws error in load partition flow","created_at":"2018-12-03T16:36:48Z","updated_at":"2018-12-03T16:36:49Z","html_url":"https://github.com/apache/hive/pull/500#discussion_r238342955","pull_request_url":"https://api.github.com/repos/apache/hive/pulls/500","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/comments/238342955"},"html":{"href":"https://github.com/apache/hive/pull/500#discussion_r238342955"},"pull_request":{"href":"https://api.github.com/repos/apache/hive/pulls/500"}},"in_reply_to_id":238228176},"pull_request":{"url":"https://api.github.com/repos/apache/hive/pulls/500","id":235365575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzY1NTc1","html_url":"https://github.com/apache/hive/pull/500","diff_url":"https://github.com/apache/hive/pull/500.diff","patch_url":"https://github.com/apache/hive/pull/500.patch","issue_url":"https://api.github.com/repos/apache/hive/issues/500","number":500,"state":"open","locked":false,"title":"Hive 20966 : Support incremental / bootstrap replication to a target cluster with hive.strict.managed.tables enabled","user":{"login":"maheshk114","id":19660171,"node_id":"MDQ6VXNlcjE5NjYwMTcx","avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T08:43:10Z","updated_at":"2018-12-03T16:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"755616ceb84374638c8e96d033159cf06129f522","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hive/pulls/500/commits","review_comments_url":"https://api.github.com/repos/apache/hive/pulls/500/comments","review_comment_url":"https://api.github.com/repos/apache/hive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hive/issues/500/comments","statuses_url":"https://api.github.com/repos/apache/hive/statuses/c561ea22b03badeee9f223179e9199cbcb456e63","head":{"label":"maheshk114:HIVE-20966","ref":"HIVE-20966","sha":"c561ea22b03badeee9f223179e9199cbcb456e63","user":{"login":"maheshk114","id":19660171,"node_id":"MDQ6VXNlcjE5NjYwMTcx","avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"repo":{"id":118883759,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4ODM3NTk=","name":"hive","full_name":"maheshk114/hive","private":false,"owner":{"login":"maheshk114","id":19660171,"node_id":"MDQ6VXNlcjE5NjYwMTcx","avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maheshk114/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/maheshk114/hive","forks_url":"https://api.github.com/repos/maheshk114/hive/forks","keys_url":"https://api.github.com/repos/maheshk114/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maheshk114/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maheshk114/hive/teams","hooks_url":"https://api.github.com/repos/maheshk114/hive/hooks","issue_events_url":"https://api.github.com/repos/maheshk114/hive/issues/events{/number}","events_url":"https://api.github.com/repos/maheshk114/hive/events","assignees_url":"https://api.github.com/repos/maheshk114/hive/assignees{/user}","branches_url":"https://api.github.com/repos/maheshk114/hive/branches{/branch}","tags_url":"https://api.github.com/repos/maheshk114/hive/tags","blobs_url":"https://api.github.com/repos/maheshk114/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maheshk114/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maheshk114/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/maheshk114/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maheshk114/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/maheshk114/hive/languages","stargazers_url":"https://api.github.com/repos/maheshk114/hive/stargazers","contributors_url":"https://api.github.com/repos/maheshk114/hive/contributors","subscribers_url":"https://api.github.com/repos/maheshk114/hive/subscribers","subscription_url":"https://api.github.com/repos/maheshk114/hive/subscription","commits_url":"https://api.github.com/repos/maheshk114/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/maheshk114/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/maheshk114/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/maheshk114/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/maheshk114/hive/contents/{+path}","compare_url":"https://api.github.com/repos/maheshk114/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maheshk114/hive/merges","archive_url":"https://api.github.com/repos/maheshk114/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maheshk114/hive/downloads","issues_url":"https://api.github.com/repos/maheshk114/hive/issues{/number}","pulls_url":"https://api.github.com/repos/maheshk114/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/maheshk114/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/maheshk114/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maheshk114/hive/labels{/name}","releases_url":"https://api.github.com/repos/maheshk114/hive/releases{/id}","deployments_url":"https://api.github.com/repos/maheshk114/hive/deployments","created_at":"2018-01-25T08:17:10Z","updated_at":"2018-01-25T08:17:57Z","pushed_at":"2018-12-03T08:42:06Z","git_url":"git://github.com/maheshk114/hive.git","ssh_url":"git@github.com:maheshk114/hive.git","clone_url":"https://github.com/maheshk114/hive.git","svn_url":"https://github.com/maheshk114/hive","homepage":null,"size":452282,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c1048e2951c741a9d6342d62f7c0406ce85387b9","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206444,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0NDQ=","name":"hive","full_name":"apache/hive","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/hive","description":"Mirror of Apache Hive","fork":false,"url":"https://api.github.com/repos/apache/hive","forks_url":"https://api.github.com/repos/apache/hive/forks","keys_url":"https://api.github.com/repos/apache/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hive/teams","hooks_url":"https://api.github.com/repos/apache/hive/hooks","issue_events_url":"https://api.github.com/repos/apache/hive/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hive/events","assignees_url":"https://api.github.com/repos/apache/hive/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hive/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hive/tags","blobs_url":"https://api.github.com/repos/apache/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hive/languages","stargazers_url":"https://api.github.com/repos/apache/hive/stargazers","contributors_url":"https://api.github.com/repos/apache/hive/contributors","subscribers_url":"https://api.github.com/repos/apache/hive/subscribers","subscription_url":"https://api.github.com/repos/apache/hive/subscription","commits_url":"https://api.github.com/repos/apache/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hive/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hive/merges","archive_url":"https://api.github.com/repos/apache/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hive/downloads","issues_url":"https://api.github.com/repos/apache/hive/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hive/labels{/name}","releases_url":"https://api.github.com/repos/apache/hive/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hive/deployments","created_at":"2009-05-21T02:31:01Z","updated_at":"2018-12-03T12:02:19Z","pushed_at":"2018-12-03T16:05:24Z","git_url":"git://github.com/apache/hive.git","ssh_url":"git@github.com:apache/hive.git","clone_url":"https://github.com/apache/hive.git","svn_url":"https://github.com/apache/hive","homepage":null,"size":453339,"stargazers_count":2228,"watchers_count":2228,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2244,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2244,"open_issues":211,"watchers":2228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/500"},"html":{"href":"https://github.com/apache/hive/pull/500"},"issue":{"href":"https://api.github.com/repos/apache/hive/issues/500"},"comments":{"href":"https://api.github.com/repos/apache/hive/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hive/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hive/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hive/statuses/c561ea22b03badeee9f223179e9199cbcb456e63"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maheshk114"}}