{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/171978525","pull_request_review_id":100932472,"id":171978525,"diff_hunk":"@@ -0,0 +1,29 @@\n+'use strict';\n+\n+const stringUtil = require('ember-cli-string-utils');\n+const date = new Date();\n+\n+module.exports = {\n+  description: 'Generates an Ember addon with a module unification layout.',\n+\n+  locals(options) {\n+    let entity = options.entity;\n+    let rawName = entity.name;\n+    let name = stringUtil.dasherize(rawName);\n+    let namespace = stringUtil.classify(rawName);\n+    let addonName = stringUtil.dasherize(rawName);\n+\n+    return {\n+      name,\n+      modulePrefix: name,\n+      namespace,\n+      addonName,\n+      // addonModulePrefix: addonName,","path":"blueprints/module-unification-addon/index.js","position":21,"original_position":21,"commit_id":"7a276ee34573c52e4082a5ce20a2d13ed5ccc185","original_commit_id":"7a276ee34573c52e4082a5ce20a2d13ed5ccc185","user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars1.githubusercontent.com/u/8752?v=4","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"body":"I don't see `addonModulePrefix` used anywhere in these files.","created_at":"2018-03-02T22:22:19Z","updated_at":"2018-03-02T22:22:19Z","html_url":"https://github.com/ember-cli/ember-cli/pull/7658#discussion_r171978525","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/171978525"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/7658#discussion_r171978525"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658"}},"in_reply_to_id":171900016},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658","id":172550232,"html_url":"https://github.com/ember-cli/ember-cli/pull/7658","diff_url":"https://github.com/ember-cli/ember-cli/pull/7658.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/7658.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/7658","number":7658,"state":"open","locked":false,"title":"Module Unification Addon blueprint","user":{"login":"cibernox","id":265339,"avatar_url":"https://avatars2.githubusercontent.com/u/265339?v=4","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"body":"This adds the ability of generating addons using the module unification layout.\r\n\r\nMODULE_UNIFICATION=true ember addon my-addon\r\nMODULE_UNIFICATION=true ember addon my-addon --yarn\r\n\r\n@GavinJoyce @mixonic ","created_at":"2018-03-02T16:46:39Z","updated_at":"2018-03-02T22:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5610715c628a23fe9a1bb846a3bc89ccf0a690d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/7658/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/7a276ee34573c52e4082a5ce20a2d13ed5ccc185","head":{"label":"cibernox:add-module-unification-addon","ref":"add-module-unification-addon","sha":"7a276ee34573c52e4082a5ce20a2d13ed5ccc185","user":{"login":"cibernox","id":265339,"avatar_url":"https://avatars2.githubusercontent.com/u/265339?v=4","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"repo":{"id":19222155,"name":"ember-cli","full_name":"cibernox/ember-cli","owner":{"login":"cibernox","id":265339,"avatar_url":"https://avatars2.githubusercontent.com/u/265339?v=4","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cibernox/ember-cli","description":null,"fork":true,"url":"https://api.github.com/repos/cibernox/ember-cli","forks_url":"https://api.github.com/repos/cibernox/ember-cli/forks","keys_url":"https://api.github.com/repos/cibernox/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cibernox/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cibernox/ember-cli/teams","hooks_url":"https://api.github.com/repos/cibernox/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/cibernox/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/cibernox/ember-cli/events","assignees_url":"https://api.github.com/repos/cibernox/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/cibernox/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/cibernox/ember-cli/tags","blobs_url":"https://api.github.com/repos/cibernox/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cibernox/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cibernox/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/cibernox/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cibernox/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/cibernox/ember-cli/languages","stargazers_url":"https://api.github.com/repos/cibernox/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/cibernox/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/cibernox/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/cibernox/ember-cli/subscription","commits_url":"https://api.github.com/repos/cibernox/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/cibernox/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/cibernox/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/cibernox/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/cibernox/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/cibernox/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cibernox/ember-cli/merges","archive_url":"https://api.github.com/repos/cibernox/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cibernox/ember-cli/downloads","issues_url":"https://api.github.com/repos/cibernox/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/cibernox/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/cibernox/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/cibernox/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cibernox/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/cibernox/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/cibernox/ember-cli/deployments","created_at":"2014-04-28T00:15:25Z","updated_at":"2016-02-23T00:15:01Z","pushed_at":"2018-03-02T16:45:43Z","git_url":"git://github.com/cibernox/ember-cli.git","ssh_url":"git@github.com:cibernox/ember-cli.git","clone_url":"https://github.com/cibernox/ember-cli.git","svn_url":"https://github.com/cibernox/ember-cli","homepage":null,"size":12388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"d51f2894664034042831237bba3fa13d5f322037","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"ember-cli/ember-cli","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli","description":"The Ember.js command line utility","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli","forks_url":"https://api.github.com/repos/ember-cli/ember-cli/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli/deployments","created_at":"2013-11-03T17:34:43Z","updated_at":"2018-02-28T08:26:29Z","pushed_at":"2018-03-02T22:19:34Z","git_url":"git://github.com/ember-cli/ember-cli.git","ssh_url":"git@github.com:ember-cli/ember-cli.git","clone_url":"https://github.com/ember-cli/ember-cli.git","svn_url":"https://github.com/ember-cli/ember-cli","homepage":"http://ember-cli.com/","size":12230,"stargazers_count":3196,"watchers_count":3196,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1028,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1028,"open_issues":245,"watchers":3196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/7658"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/7658"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/7658/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/7658/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli/statuses/7a276ee34573c52e4082a5ce20a2d13ed5ccc185"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mixonic"}}