{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/239522435","pull_request_review_id":182329904,"id":239522435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUyMjQzNQ==","diff_hunk":"@@ -0,0 +1,46 @@\n+################################################################################\n+# Copyright (c) 2018, 2018 IBM Corp. and others\n+#\n+# This program and the accompanying materials are made available under\n+# the terms of the Eclipse Public License 2.0 which accompanies this\n+# distribution and is available at https://www.eclipse.org/legal/epl-2.0/\n+# or the Apache License, Version 2.0 which accompanies this distribution and\n+# is available at https://www.apache.org/licenses/LICENSE-2.0.\n+#\n+# This Source Code may also be made available under the following\n+# Secondary Licenses when the conditions for such availability set\n+# forth in the Eclipse Public License, v. 2.0 are satisfied: GNU\n+# General Public License, version 2 with the GNU Classpath\n+# Exception [1] and GNU General Public License, version 2 with the\n+# OpenJDK Assembly Exception [2].\n+#\n+# [1] https://www.gnu.org/software/classpath/license.html\n+# [2] http://openjdk.java.net/legal/assembly-exception.html\n+#\n+# SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception\n+################################################################################\n+\n+cmake_minimum_required(VERSION 3.4 FATAL_ERROR)\n+\n+project(openj9)\n+\n+if(NOT $ENV{BOOT_JDK} STREQUAL \"\")\n+    set(JAVA_HOME $ENV{BOOT_JDK})\n+\n+    # These variables are consumed when the \"Java\" language is enabled\n+    set(CMAKE_Java_COMPILER ${JAVA_HOME}/bin/javac)\n+    set(CMAKE_Java_RUNTIME ${JAVA_HOME}/bin/java)\n+    set(CMAKE_Java_AR ${JAVA_HOME}/bin/jar)\n+\n+    set(Java_JAVA_EXECUTABLE ${JAVA_HOME}/bin/java)\n+else()\n+    message(STATUS \"BOOT_JDK is not set, default jdk will be used\")\n+    include(FindJava)","path":"CMakeLists.txt","position":38,"original_position":38,"commit_id":"35d36a23fd0efd5c1f19f69377cf85da237b7caa","original_commit_id":"64cb8fce250da0305f9980c7433ea85f5f4118cc","user":{"login":"dnakamura","id":12418336,"node_id":"MDQ6VXNlcjEyNDE4MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"body":"@DanHeidinga  How would you feel about wrapping this behavior up in a flag? ie J9VM_FORCE_JDK_SEARCH or something. I'm thinking of the case of the jit linter. To run properly it needs to generate all the various header files. The easiest way to do that is to just run cmake outside of the full openjdk build. Its not clear what the proper value of BOOT_JDK should be","created_at":"2018-12-06T16:33:57Z","updated_at":"2018-12-06T16:33:57Z","html_url":"https://github.com/eclipse/openj9/pull/3675#discussion_r239522435","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/3675","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/239522435"},"html":{"href":"https://github.com/eclipse/openj9/pull/3675#discussion_r239522435"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3675"}},"in_reply_to_id":236017909},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3675","id":230891119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODkxMTE5","html_url":"https://github.com/eclipse/openj9/pull/3675","diff_url":"https://github.com/eclipse/openj9/pull/3675.diff","patch_url":"https://github.com/eclipse/openj9/pull/3675.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3675","number":3675,"state":"open","locked":false,"title":"CMake: Add support for NLS and CP tools","user":{"login":"dnakamura","id":12418336,"node_id":"MDQ6VXNlcjEyNDE4MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>","created_at":"2018-11-14T16:07:35Z","updated_at":"2018-12-06T16:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6942844dcec1f404fdef15c2ff53c9347c4b8173","assignee":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":698092752,"node_id":"MDU6TGFiZWw2OTgwOTI3NTI=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:build","name":"comp:build","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3675/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3675/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3675/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/35d36a23fd0efd5c1f19f69377cf85da237b7caa","head":{"label":"dnakamura:cmake_tooling","ref":"cmake_tooling","sha":"35d36a23fd0efd5c1f19f69377cf85da237b7caa","user":{"login":"dnakamura","id":12418336,"node_id":"MDQ6VXNlcjEyNDE4MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"repo":{"id":103568235,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1NjgyMzU=","name":"openj9","full_name":"dnakamura/openj9","private":false,"owner":{"login":"dnakamura","id":12418336,"node_id":"MDQ6VXNlcjEyNDE4MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dnakamura/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/dnakamura/openj9","forks_url":"https://api.github.com/repos/dnakamura/openj9/forks","keys_url":"https://api.github.com/repos/dnakamura/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnakamura/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnakamura/openj9/teams","hooks_url":"https://api.github.com/repos/dnakamura/openj9/hooks","issue_events_url":"https://api.github.com/repos/dnakamura/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/dnakamura/openj9/events","assignees_url":"https://api.github.com/repos/dnakamura/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/dnakamura/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/dnakamura/openj9/tags","blobs_url":"https://api.github.com/repos/dnakamura/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnakamura/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnakamura/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnakamura/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnakamura/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/dnakamura/openj9/languages","stargazers_url":"https://api.github.com/repos/dnakamura/openj9/stargazers","contributors_url":"https://api.github.com/repos/dnakamura/openj9/contributors","subscribers_url":"https://api.github.com/repos/dnakamura/openj9/subscribers","subscription_url":"https://api.github.com/repos/dnakamura/openj9/subscription","commits_url":"https://api.github.com/repos/dnakamura/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnakamura/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnakamura/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnakamura/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnakamura/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/dnakamura/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnakamura/openj9/merges","archive_url":"https://api.github.com/repos/dnakamura/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnakamura/openj9/downloads","issues_url":"https://api.github.com/repos/dnakamura/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/dnakamura/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/dnakamura/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/dnakamura/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnakamura/openj9/labels{/name}","releases_url":"https://api.github.com/repos/dnakamura/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/dnakamura/openj9/deployments","created_at":"2017-09-14T18:36:30Z","updated_at":"2018-11-28T23:33:45Z","pushed_at":"2018-11-28T23:33:43Z","git_url":"git://github.com/dnakamura/openj9.git","ssh_url":"git@github.com:dnakamura/openj9.git","clone_url":"https://github.com/dnakamura/openj9.git","svn_url":"https://github.com/dnakamura/openj9","homepage":null,"size":37772,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":28,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"01f3a1c977a8fc5b06de4b0dcc4b4745f1796e8b","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-12-06T15:55:01Z","pushed_at":"2018-12-06T16:30:52Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":39617,"stargazers_count":1546,"watchers_count":1546,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"archived":false,"open_issues_count":628,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":302,"open_issues":628,"watchers":1546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3675"},"html":{"href":"https://github.com/eclipse/openj9/pull/3675"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3675"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3675/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3675/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3675/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/35d36a23fd0efd5c1f19f69377cf85da237b7caa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dnakamura"}}