{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/202493202","pull_request_review_id":137214614,"id":202493202,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ5MzIwMg==","diff_hunk":"@@ -0,0 +1,13 @@\n+<Project ToolsVersion=\"14.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+  <PropertyGroup>\n+    <MicrosoftDotNetSignToolTaskAssembly Condition=\" '$(MSBuildRuntimeType)' == 'Core' \">$(MSBuildThisFileDirectory)netcoreapp2.0\\Microsoft.DotNet.SignTool.dll</MicrosoftDotNetSignToolTaskAssembly>\n+    <MicrosoftDotNetSignToolTaskAssembly Condition=\" '$(MSBuildRuntimeType)' != 'Core' \">$(MSBuildThisFileDirectory)net461\\Microsoft.DotNet.SignTool.exe</MicrosoftDotNetSignToolTaskAssembly>\n+  </PropertyGroup>\n+\n+  <PropertyGroup>\n+    <IsTest>false</IsTest>\n+    <TestSign>true</TestSign>","path":"src/Microsoft.DotNet.SignTool/build/Microsoft.DotNet.SignTool.props","position":9,"original_position":9,"commit_id":"0cb4ee9908393339de080e9a06e1795d45ceb939","original_commit_id":"0cb4ee9908393339de080e9a06e1795d45ceb939","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Let's remove these. We already have global variables determining the signing kind. We don't need more of them.","created_at":"2018-07-13T23:18:12Z","updated_at":"2018-07-13T23:18:12Z","html_url":"https://github.com/dotnet/arcade/pull/303#discussion_r202493202","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/303","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/202493202"},"html":{"href":"https://github.com/dotnet/arcade/pull/303#discussion_r202493202"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/303","id":200228796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjI4Nzk2","html_url":"https://github.com/dotnet/arcade/pull/303","diff_url":"https://github.com/dotnet/arcade/pull/303.diff","patch_url":"https://github.com/dotnet/arcade/pull/303.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/303","number":303,"state":"open","locked":false,"title":"Add MSBuild Task wrapping SignTool","user":{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false},"body":"- Some refactoring around parameter handling\r\n- Adding new class \"SignToolTask\"\r\n- Adding .props/.targets files","created_at":"2018-07-09T21:46:48Z","updated_at":"2018-07-13T23:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f99f9b5bdec411b7e83a04fd336a25448786f05","assignee":{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false},"assignees":[{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jaredpar","id":146967,"node_id":"MDQ6VXNlcjE0Njk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/146967?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/303/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/303/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/303/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/0cb4ee9908393339de080e9a06e1795d45ceb939","head":{"label":"JohnTortugo:SignToolAsTask","ref":"SignToolAsTask","sha":"0cb4ee9908393339de080e9a06e1795d45ceb939","user":{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false},"repo":{"id":128424206,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MjQyMDY=","name":"arcade","full_name":"JohnTortugo/arcade","owner":{"login":"JohnTortugo","id":2249648,"node_id":"MDQ6VXNlcjIyNDk2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2249648?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnTortugo","html_url":"https://github.com/JohnTortugo","followers_url":"https://api.github.com/users/JohnTortugo/followers","following_url":"https://api.github.com/users/JohnTortugo/following{/other_user}","gists_url":"https://api.github.com/users/JohnTortugo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnTortugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnTortugo/subscriptions","organizations_url":"https://api.github.com/users/JohnTortugo/orgs","repos_url":"https://api.github.com/users/JohnTortugo/repos","events_url":"https://api.github.com/users/JohnTortugo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnTortugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnTortugo/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/JohnTortugo/arcade","forks_url":"https://api.github.com/repos/JohnTortugo/arcade/forks","keys_url":"https://api.github.com/repos/JohnTortugo/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnTortugo/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnTortugo/arcade/teams","hooks_url":"https://api.github.com/repos/JohnTortugo/arcade/hooks","issue_events_url":"https://api.github.com/repos/JohnTortugo/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/JohnTortugo/arcade/events","assignees_url":"https://api.github.com/repos/JohnTortugo/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/JohnTortugo/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/JohnTortugo/arcade/tags","blobs_url":"https://api.github.com/repos/JohnTortugo/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnTortugo/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnTortugo/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnTortugo/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnTortugo/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnTortugo/arcade/languages","stargazers_url":"https://api.github.com/repos/JohnTortugo/arcade/stargazers","contributors_url":"https://api.github.com/repos/JohnTortugo/arcade/contributors","subscribers_url":"https://api.github.com/repos/JohnTortugo/arcade/subscribers","subscription_url":"https://api.github.com/repos/JohnTortugo/arcade/subscription","commits_url":"https://api.github.com/repos/JohnTortugo/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnTortugo/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnTortugo/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnTortugo/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnTortugo/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/JohnTortugo/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnTortugo/arcade/merges","archive_url":"https://api.github.com/repos/JohnTortugo/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnTortugo/arcade/downloads","issues_url":"https://api.github.com/repos/JohnTortugo/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/JohnTortugo/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnTortugo/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnTortugo/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnTortugo/arcade/labels{/name}","releases_url":"https://api.github.com/repos/JohnTortugo/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/JohnTortugo/arcade/deployments","created_at":"2018-04-06T17:19:32Z","updated_at":"2018-07-09T23:46:37Z","pushed_at":"2018-07-13T21:11:44Z","git_url":"git://github.com/JohnTortugo/arcade.git","ssh_url":"git@github.com:JohnTortugo/arcade.git","clone_url":"https://github.com/JohnTortugo/arcade.git","svn_url":"https://github.com/JohnTortugo/arcade","homepage":"","size":1459,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"37e4690c6b3e64630364d9030864424260649039","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2018-07-13T19:42:25Z","pushed_at":"2018-07-13T22:13:27Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":1466,"stargazers_count":10,"watchers_count":10,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":137,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/303"},"html":{"href":"https://github.com/dotnet/arcade/pull/303"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/303"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/0cb4ee9908393339de080e9a06e1795d45ceb939"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tmat"}}