{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/887","repository_url":"https://api.github.com/repos/facebook/Docusaurus","labels_url":"https://api.github.com/repos/facebook/Docusaurus/issues/887/labels{/name}","comments_url":"https://api.github.com/repos/facebook/Docusaurus/issues/887/comments","events_url":"https://api.github.com/repos/facebook/Docusaurus/issues/887/events","html_url":"https://github.com/facebook/Docusaurus/pull/887","id":347613340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTg5MzI0","number":887,"title":"fix: copy static image as it is if image compression fail","user":{"login":"endiliey","id":17883920,"node_id":"MDQ6VXNlcjE3ODgzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/17883920?v=4","gravatar_id":"","url":"https://api.github.com/users/endiliey","html_url":"https://github.com/endiliey","followers_url":"https://api.github.com/users/endiliey/followers","following_url":"https://api.github.com/users/endiliey/following{/other_user}","gists_url":"https://api.github.com/users/endiliey/gists{/gist_id}","starred_url":"https://api.github.com/users/endiliey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endiliey/subscriptions","organizations_url":"https://api.github.com/users/endiliey/orgs","repos_url":"https://api.github.com/users/endiliey/repos","events_url":"https://api.github.com/users/endiliey/events{/privacy}","received_events_url":"https://api.github.com/users/endiliey/received_events","type":"User","site_admin":false},"labels":[{"id":630651545,"node_id":"MDU6TGFiZWw2MzA2NTE1NDU=","url":"https://api.github.com/repos/facebook/Docusaurus/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-04T11:52:27Z","updated_at":"2018-08-04T11:54:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/facebook/Docusaurus/pulls/887","html_url":"https://github.com/facebook/Docusaurus/pull/887","diff_url":"https://github.com/facebook/Docusaurus/pull/887.diff","patch_url":"https://github.com/facebook/Docusaurus/pull/887.patch"},"body":"## Motivation\r\n\r\nFix #701 \r\n\r\nThere is no error handling on https://github.com/facebook/Docusaurus/blob/ef80581e8ef950a0865fc7851407c672c4bbd510/lib/server/generate.js#L255-L264\r\n\r\nIf the image compression fails, it will cause the image to be missing.\r\n\r\nExample: \r\nhttps://circleci.com/gh/facebook/Docusaurus/2846\r\n\r\nThe build succeed but along the line there is an unhandled promise. Causing `christopher-chedeau.jpg` and `ricky-vetter.jpg` to be missing.\r\n\r\n<img width=\"940\" alt=\"missing image\" src=\"https://user-images.githubusercontent.com/17883920/43673726-46d0ef68-97fa-11e8-8826-841fc8ff70f1.PNG\">\r\n\r\nThis PR add a fallback functionality to copy the image as it is if the image compression fail\r\n\r\n### Have you read the [Contributing Guidelines on pull requests](https://github.com/facebook/Docusaurus/blob/master/CONTRIBUTING.md#pull-requests)?\r\n\r\nYes\r\n\r\n## Test Plan\r\n\r\nNetlify preview works\r\n\r\n## Related PRs\r\n\r\n#654 \r\n"},"comment":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/comments/410444371","html_url":"https://github.com/facebook/Docusaurus/pull/887#issuecomment-410444371","issue_url":"https://api.github.com/repos/facebook/Docusaurus/issues/887","id":410444371,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ0NDM3MQ==","user":{"login":"docusaurus-bot","id":33666575,"node_id":"MDQ6VXNlcjMzNjY2NTc1","avatar_url":"https://avatars0.githubusercontent.com/u/33666575?v=4","gravatar_id":"","url":"https://api.github.com/users/docusaurus-bot","html_url":"https://github.com/docusaurus-bot","followers_url":"https://api.github.com/users/docusaurus-bot/followers","following_url":"https://api.github.com/users/docusaurus-bot/following{/other_user}","gists_url":"https://api.github.com/users/docusaurus-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/docusaurus-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docusaurus-bot/subscriptions","organizations_url":"https://api.github.com/users/docusaurus-bot/orgs","repos_url":"https://api.github.com/users/docusaurus-bot/repos","events_url":"https://api.github.com/users/docusaurus-bot/events{/privacy}","received_events_url":"https://api.github.com/users/docusaurus-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-04T11:54:36Z","updated_at":"2018-08-04T11:54:36Z","author_association":"COLLABORATOR","body":"Deploy preview for *docusaurus-preview* ready!\n\nBuilt with commit 19153feb7390709563557952be53b9d9153dba90\n\nhttps://deploy-preview-887--docusaurus-preview.netlify.com"}}
{"actor":{"display_login":"docusaurus-bot"}}