{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/241855952","pull_request_review_id":185240980,"id":241855952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTg1NTk1Mg==","diff_hunk":"@@ -129,4 +133,19 @@ class ArrayLoadImpl : public BaseArrayImpl<elem_required, elem_size, elem_align>\n   }\n };\n \n+struct HailFatalError: public std::exception {\n+  private:\n+    static constexpr int max_error_len = 512;\n+    char error_msg[max_error_len];\n+  public:\n+    virtual const char * what() const throw() { return error_msg; }\n+    virtual ~HailFatalError() throw() {};\n+    explicit HailFatalError(const char * fmtstring, ...) : std::exception() {","path":"hail/src/main/resources/include/hail/Utils.h","position":22,"original_position":22,"commit_id":"5e1c57c448d273c576e69ba2f1bb3fdc6d0c7ae6","original_commit_id":"5e1c57c448d273c576e69ba2f1bb3fdc6d0c7ae6","user":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"body":"hmm... When I'm looking for the error in the (non-generated) source code, I typically just search for the error string, which I feel like should aim to be descriptive and unique enough to find it. (On top of that, I find it hard to keep track of what numbers have been used for error codes so far.)\r\n\r\nI think there's something to be said for having unique error IDs in the generated source code, so that we can figure out where in the generated source it comes from if e.g. there's two separate ArrayRefs---does that seem appropriate?","created_at":"2018-12-14T18:57:47Z","updated_at":"2018-12-14T18:57:48Z","html_url":"https://github.com/hail-is/hail/pull/4955#discussion_r241855952","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/4955","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/241855952"},"html":{"href":"https://github.com/hail-is/hail/pull/4955#discussion_r241855952"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4955"}},"in_reply_to_id":241797077},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/4955","id":238180799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTgwNzk5","html_url":"https://github.com/hail-is/hail/pull/4955","diff_url":"https://github.com/hail-is/hail/pull/4955.diff","patch_url":"https://github.com/hail-is/hail/pull/4955.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/4955","number":4955,"state":"open","locked":false,"title":"throw exceptions in generated code","user":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"body":"Basically what it says on the box. NativeStatus is now only used in the generated code in the wrapper function signature; internally, we just throw a HailFatalError object that's caught in the wrapper.","created_at":"2018-12-12T21:01:04Z","updated_at":"2018-12-14T18:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"402ba993db6f44d22871e73d185e57e2e6f75e65","assignee":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"assignees":[{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/4955/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/4955/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/4955/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/5e1c57c448d273c576e69ba2f1bb3fdc6d0c7ae6","head":{"label":"catoverdrive:throw-exceptions","ref":"throw-exceptions","sha":"5e1c57c448d273c576e69ba2f1bb3fdc6d0c7ae6","user":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"repo":{"id":103584239,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1ODQyMzk=","name":"hail","full_name":"catoverdrive/hail","private":false,"owner":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"html_url":"https://github.com/catoverdrive/hail","description":"Scalable genomic data analysis.","fork":true,"url":"https://api.github.com/repos/catoverdrive/hail","forks_url":"https://api.github.com/repos/catoverdrive/hail/forks","keys_url":"https://api.github.com/repos/catoverdrive/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catoverdrive/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catoverdrive/hail/teams","hooks_url":"https://api.github.com/repos/catoverdrive/hail/hooks","issue_events_url":"https://api.github.com/repos/catoverdrive/hail/issues/events{/number}","events_url":"https://api.github.com/repos/catoverdrive/hail/events","assignees_url":"https://api.github.com/repos/catoverdrive/hail/assignees{/user}","branches_url":"https://api.github.com/repos/catoverdrive/hail/branches{/branch}","tags_url":"https://api.github.com/repos/catoverdrive/hail/tags","blobs_url":"https://api.github.com/repos/catoverdrive/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catoverdrive/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catoverdrive/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/catoverdrive/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catoverdrive/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/catoverdrive/hail/languages","stargazers_url":"https://api.github.com/repos/catoverdrive/hail/stargazers","contributors_url":"https://api.github.com/repos/catoverdrive/hail/contributors","subscribers_url":"https://api.github.com/repos/catoverdrive/hail/subscribers","subscription_url":"https://api.github.com/repos/catoverdrive/hail/subscription","commits_url":"https://api.github.com/repos/catoverdrive/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/catoverdrive/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/catoverdrive/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/catoverdrive/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/catoverdrive/hail/contents/{+path}","compare_url":"https://api.github.com/repos/catoverdrive/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catoverdrive/hail/merges","archive_url":"https://api.github.com/repos/catoverdrive/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catoverdrive/hail/downloads","issues_url":"https://api.github.com/repos/catoverdrive/hail/issues{/number}","pulls_url":"https://api.github.com/repos/catoverdrive/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/catoverdrive/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/catoverdrive/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catoverdrive/hail/labels{/name}","releases_url":"https://api.github.com/repos/catoverdrive/hail/releases{/id}","deployments_url":"https://api.github.com/repos/catoverdrive/hail/deployments","created_at":"2017-09-14T21:38:37Z","updated_at":"2018-07-09T21:05:28Z","pushed_at":"2018-12-14T18:52:29Z","git_url":"git://github.com/catoverdrive/hail.git","ssh_url":"git@github.com:catoverdrive/hail.git","clone_url":"https://github.com/catoverdrive/hail.git","svn_url":"https://github.com/catoverdrive/hail","homepage":"https://hail.is","size":67706,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"2a1c7e194120d962cb2fc6cb4c740a4a2038bc84","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-12-14T18:51:11Z","pushed_at":"2018-12-14T18:52:31Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":57860,"stargazers_count":415,"watchers_count":415,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":116,"open_issues":153,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4955"},"html":{"href":"https://github.com/hail-is/hail/pull/4955"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/4955"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/4955/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4955/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4955/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/5e1c57c448d273c576e69ba2f1bb3fdc6d0c7ae6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"catoverdrive"}}