{"action":"created","comment":{"url":"https://api.github.com/repos/google/oss-fuzz/pulls/comments/197012034","pull_request_review_id":130667319,"id":197012034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzAxMjAzNA==","diff_hunk":"@@ -70,10 +71,13 @@ rm *.profraw\n # TODO(mmoroz): add script from Chromium for rendering directory view reports.\n \n # Generate HTML report.\n-llvm-cov show -format=html -output-dir=report -path-equivalence=\"/,$OUT\" \\\n+llvm-cov show -format=html -output-dir=$REPORT_DIR -path-equivalence=\"/,$OUT\" \\\n \t\t-instr-profile merged.profdata $objects\n \n-# Serve the report locally.\n-echo \"Serving the report on http://127.0.0.1:$HTTP_PORT/\"\n-cd report\n-python3 -m http.server $HTTP_PORT\n+# Even though it is possible to serve at 0 port, use it to disable HTTP server.\n+if (( $HTTP_PORT != 0 )); then","path":"infra/base-images/base-runner/coverage","position":30,"original_position":30,"commit_id":"aefc1cd1f74d5f81105a168ca913585333d474bc","original_commit_id":"aefc1cd1f74d5f81105a168ca913585333d474bc","user":{"login":"oliverchang","id":759062,"node_id":"MDQ6VXNlcjc1OTA2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/759062?v=4","gravatar_id":"","url":"https://api.github.com/users/oliverchang","html_url":"https://github.com/oliverchang","followers_url":"https://api.github.com/users/oliverchang/followers","following_url":"https://api.github.com/users/oliverchang/following{/other_user}","gists_url":"https://api.github.com/users/oliverchang/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverchang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverchang/subscriptions","organizations_url":"https://api.github.com/users/oliverchang/orgs","repos_url":"https://api.github.com/users/oliverchang/repos","events_url":"https://api.github.com/users/oliverchang/events{/privacy}","received_events_url":"https://api.github.com/users/oliverchang/received_events","type":"User","site_admin":false},"body":"why not use `[[ -n $HTTP_PORT ]]` ?","created_at":"2018-06-21T05:06:49Z","updated_at":"2018-06-21T05:15:21Z","html_url":"https://github.com/google/oss-fuzz/pull/1547#discussion_r197012034","pull_request_url":"https://api.github.com/repos/google/oss-fuzz/pulls/1547","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/comments/197012034"},"html":{"href":"https://github.com/google/oss-fuzz/pull/1547#discussion_r197012034"},"pull_request":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/1547"}}},"pull_request":{"url":"https://api.github.com/repos/google/oss-fuzz/pulls/1547","id":196328190,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzI4MTkw","html_url":"https://github.com/google/oss-fuzz/pull/1547","diff_url":"https://github.com/google/oss-fuzz/pull/1547.diff","patch_url":"https://github.com/google/oss-fuzz/pull/1547.patch","issue_url":"https://api.github.com/repos/google/oss-fuzz/issues/1547","number":1547,"state":"open","locked":false,"title":"[infra] Add the build configuration and other pieces for clang code coverage.","user":{"login":"Dor1s","id":3372458,"node_id":"MDQ6VXNlcjMzNzI0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3372458?v=4","gravatar_id":"","url":"https://api.github.com/users/Dor1s","html_url":"https://github.com/Dor1s","followers_url":"https://api.github.com/users/Dor1s/followers","following_url":"https://api.github.com/users/Dor1s/following{/other_user}","gists_url":"https://api.github.com/users/Dor1s/gists{/gist_id}","starred_url":"https://api.github.com/users/Dor1s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dor1s/subscriptions","organizations_url":"https://api.github.com/users/Dor1s/orgs","repos_url":"https://api.github.com/users/Dor1s/repos","events_url":"https://api.github.com/users/Dor1s/events{/privacy}","received_events_url":"https://api.github.com/users/Dor1s/received_events","type":"User","site_admin":false},"body":"Hey @oliverchang, it's a quick draft of how the code coverage build & run process may look like. It's pretty raw yet, but it would be great to get your feedback while you're still online today :) Thanks a lot!\r\n","created_at":"2018-06-21T03:43:33Z","updated_at":"2018-06-21T05:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c0233f1abbc8f284ad208e594cd6252953be159","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/oss-fuzz/pulls/1547/commits","review_comments_url":"https://api.github.com/repos/google/oss-fuzz/pulls/1547/comments","review_comment_url":"https://api.github.com/repos/google/oss-fuzz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/oss-fuzz/issues/1547/comments","statuses_url":"https://api.github.com/repos/google/oss-fuzz/statuses/aefc1cd1f74d5f81105a168ca913585333d474bc","head":{"label":"google:coverage","ref":"coverage","sha":"aefc1cd1f74d5f81105a168ca913585333d474bc","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":63809205,"node_id":"MDEwOlJlcG9zaXRvcnk2MzgwOTIwNQ==","name":"oss-fuzz","full_name":"google/oss-fuzz","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oss-fuzz","description":"OSS-Fuzz - continuous fuzzing of open source software","fork":false,"url":"https://api.github.com/repos/google/oss-fuzz","forks_url":"https://api.github.com/repos/google/oss-fuzz/forks","keys_url":"https://api.github.com/repos/google/oss-fuzz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oss-fuzz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oss-fuzz/teams","hooks_url":"https://api.github.com/repos/google/oss-fuzz/hooks","issue_events_url":"https://api.github.com/repos/google/oss-fuzz/issues/events{/number}","events_url":"https://api.github.com/repos/google/oss-fuzz/events","assignees_url":"https://api.github.com/repos/google/oss-fuzz/assignees{/user}","branches_url":"https://api.github.com/repos/google/oss-fuzz/branches{/branch}","tags_url":"https://api.github.com/repos/google/oss-fuzz/tags","blobs_url":"https://api.github.com/repos/google/oss-fuzz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oss-fuzz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oss-fuzz/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oss-fuzz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oss-fuzz/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oss-fuzz/languages","stargazers_url":"https://api.github.com/repos/google/oss-fuzz/stargazers","contributors_url":"https://api.github.com/repos/google/oss-fuzz/contributors","subscribers_url":"https://api.github.com/repos/google/oss-fuzz/subscribers","subscription_url":"https://api.github.com/repos/google/oss-fuzz/subscription","commits_url":"https://api.github.com/repos/google/oss-fuzz/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oss-fuzz/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oss-fuzz/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oss-fuzz/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oss-fuzz/contents/{+path}","compare_url":"https://api.github.com/repos/google/oss-fuzz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oss-fuzz/merges","archive_url":"https://api.github.com/repos/google/oss-fuzz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oss-fuzz/downloads","issues_url":"https://api.github.com/repos/google/oss-fuzz/issues{/number}","pulls_url":"https://api.github.com/repos/google/oss-fuzz/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oss-fuzz/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oss-fuzz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oss-fuzz/labels{/name}","releases_url":"https://api.github.com/repos/google/oss-fuzz/releases{/id}","deployments_url":"https://api.github.com/repos/google/oss-fuzz/deployments","created_at":"2016-07-20T19:39:50Z","updated_at":"2018-06-20T15:02:23Z","pushed_at":"2018-06-21T03:43:34Z","git_url":"git://github.com/google/oss-fuzz.git","ssh_url":"git@github.com:google/oss-fuzz.git","clone_url":"https://github.com/google/oss-fuzz.git","svn_url":"https://github.com/google/oss-fuzz","homepage":"","size":9892,"stargazers_count":2846,"watchers_count":2846,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":483,"open_issues":86,"watchers":2846,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"24c78072d0df473f7b1b8dc76b6c880e4f5224c4","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":63809205,"node_id":"MDEwOlJlcG9zaXRvcnk2MzgwOTIwNQ==","name":"oss-fuzz","full_name":"google/oss-fuzz","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oss-fuzz","description":"OSS-Fuzz - continuous fuzzing of open source software","fork":false,"url":"https://api.github.com/repos/google/oss-fuzz","forks_url":"https://api.github.com/repos/google/oss-fuzz/forks","keys_url":"https://api.github.com/repos/google/oss-fuzz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oss-fuzz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oss-fuzz/teams","hooks_url":"https://api.github.com/repos/google/oss-fuzz/hooks","issue_events_url":"https://api.github.com/repos/google/oss-fuzz/issues/events{/number}","events_url":"https://api.github.com/repos/google/oss-fuzz/events","assignees_url":"https://api.github.com/repos/google/oss-fuzz/assignees{/user}","branches_url":"https://api.github.com/repos/google/oss-fuzz/branches{/branch}","tags_url":"https://api.github.com/repos/google/oss-fuzz/tags","blobs_url":"https://api.github.com/repos/google/oss-fuzz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oss-fuzz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oss-fuzz/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oss-fuzz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oss-fuzz/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oss-fuzz/languages","stargazers_url":"https://api.github.com/repos/google/oss-fuzz/stargazers","contributors_url":"https://api.github.com/repos/google/oss-fuzz/contributors","subscribers_url":"https://api.github.com/repos/google/oss-fuzz/subscribers","subscription_url":"https://api.github.com/repos/google/oss-fuzz/subscription","commits_url":"https://api.github.com/repos/google/oss-fuzz/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oss-fuzz/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oss-fuzz/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oss-fuzz/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oss-fuzz/contents/{+path}","compare_url":"https://api.github.com/repos/google/oss-fuzz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oss-fuzz/merges","archive_url":"https://api.github.com/repos/google/oss-fuzz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oss-fuzz/downloads","issues_url":"https://api.github.com/repos/google/oss-fuzz/issues{/number}","pulls_url":"https://api.github.com/repos/google/oss-fuzz/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oss-fuzz/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oss-fuzz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oss-fuzz/labels{/name}","releases_url":"https://api.github.com/repos/google/oss-fuzz/releases{/id}","deployments_url":"https://api.github.com/repos/google/oss-fuzz/deployments","created_at":"2016-07-20T19:39:50Z","updated_at":"2018-06-20T15:02:23Z","pushed_at":"2018-06-21T03:43:34Z","git_url":"git://github.com/google/oss-fuzz.git","ssh_url":"git@github.com:google/oss-fuzz.git","clone_url":"https://github.com/google/oss-fuzz.git","svn_url":"https://github.com/google/oss-fuzz","homepage":"","size":9892,"stargazers_count":2846,"watchers_count":2846,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":483,"open_issues":86,"watchers":2846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/1547"},"html":{"href":"https://github.com/google/oss-fuzz/pull/1547"},"issue":{"href":"https://api.github.com/repos/google/oss-fuzz/issues/1547"},"comments":{"href":"https://api.github.com/repos/google/oss-fuzz/issues/1547/comments"},"review_comments":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/1547/comments"},"review_comment":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/oss-fuzz/pulls/1547/commits"},"statuses":{"href":"https://api.github.com/repos/google/oss-fuzz/statuses/aefc1cd1f74d5f81105a168ca913585333d474bc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oliverchang"}}