{"action":"created","comment":{"url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/comments/207818242","pull_request_review_id":143504832,"id":207818242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgxODI0Mg==","diff_hunk":"@@ -49,34 +49,12 @@ function mapToFunctions(_, {\n   return {\n     ...baseProps,\n     async onMerge(sessionId) {\n-      const session = webphone._sessions.get(sessionId);\n-      if (webphone.isCallRecording(session)) {\n-        return;\n-      }\n-      routerInteraction.replace('/calls/active');\n-      conferenceCall.setMergeParty({ toSessionId: sessionId });\n-      const sessionToMergeWith = webphone._sessions.get(conferenceCall.mergingPair.fromSessionId);\n-      const isCurrentOnhold = sessionToMergeWith && sessionToMergeWith.isOnHold().local;\n-      const webphoneSessions = sessionToMergeWith\n-        ? [sessionToMergeWith, session]\n-        : [session];\n-      await conferenceCall.mergeToConference(webphoneSessions);\n-      const conferenceData = Object.values(conferenceCall.conferences)[0];\n-      const conferenceSession = webphone._sessions.get(conferenceData.sessionId);\n-      const isConferenceOnhold = conferenceSession.isOnHold().local;\n-\n-      if (conferenceData && isCurrentOnhold) {\n-        webphone.hold(conferenceData.sessionId);\n-        return;\n-      }\n-\n-      if (conferenceData && isConferenceOnhold) {\n-        /**\n-         * because session termination operation in conferenceCall._mergeToConference,\n-         * need to wait for webphone.getActiveSessionIdReducer to update\n-         */\n-        webphone.resume(conferenceData.sessionId);\n-      }\n+      await conferenceCall.onMergeOnhold({\n+        sessionId,\n+        beforeMerge() {\n+          routerInteraction.replace('/calls/active');\n+        }","path":"packages/ringcentral-widgets/containers/CallsOnholdPage/index.js","position":null,"original_position":36,"commit_id":"865a35b921ade7fe395f27931a091b16ed063a21","original_commit_id":"6685f1ca2c2e23134a92a28fbcd666cf37d76d3b","user":{"login":"ele828","id":8534639,"node_id":"MDQ6VXNlcjg1MzQ2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8534639?v=4","gravatar_id":"","url":"https://api.github.com/users/ele828","html_url":"https://github.com/ele828","followers_url":"https://api.github.com/users/ele828/followers","following_url":"https://api.github.com/users/ele828/following{/other_user}","gists_url":"https://api.github.com/users/ele828/gists{/gist_id}","starred_url":"https://api.github.com/users/ele828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ele828/subscriptions","organizations_url":"https://api.github.com/users/ele828/orgs","repos_url":"https://api.github.com/users/ele828/repos","events_url":"https://api.github.com/users/ele828/events{/privacy}","received_events_url":"https://api.github.com/users/ele828/received_events","type":"User","site_admin":false},"body":"It's removed and it looks good without `beforeMerge` func","created_at":"2018-08-06T08:57:23Z","updated_at":"2018-08-06T08:57:23Z","html_url":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016#discussion_r207818242","pull_request_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/comments/207818242"},"html":{"href":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016#discussion_r207818242"},"pull_request":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016"}},"in_reply_to_id":207809021},"pull_request":{"url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016","id":206321560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzIxNTYw","html_url":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016","diff_url":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016.diff","patch_url":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016.patch","issue_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/1016","number":1016,"state":"open","locked":false,"title":"move merge function to conference call module to support proxify mech…","user":{"login":"ele828","id":8534639,"node_id":"MDQ6VXNlcjg1MzQ2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8534639?v=4","gravatar_id":"","url":"https://api.github.com/users/ele828","html_url":"https://github.com/ele828","followers_url":"https://api.github.com/users/ele828/followers","following_url":"https://api.github.com/users/ele828/following{/other_user}","gists_url":"https://api.github.com/users/ele828/gists{/gist_id}","starred_url":"https://api.github.com/users/ele828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ele828/subscriptions","organizations_url":"https://api.github.com/users/ele828/orgs","repos_url":"https://api.github.com/users/ele828/repos","events_url":"https://api.github.com/users/ele828/events{/privacy}","received_events_url":"https://api.github.com/users/ele828/received_events","type":"User","site_admin":false},"body":"…anism","created_at":"2018-08-06T08:16:44Z","updated_at":"2018-08-06T08:57:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"014a84c3ec8a210801f840668590b5998e8674e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016/commits","review_comments_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016/comments","review_comment_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/1016/comments","statuses_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/statuses/865a35b921ade7fe395f27931a091b16ed063a21","head":{"label":"ele828:proxify-conference-call","ref":"proxify-conference-call","sha":"865a35b921ade7fe395f27931a091b16ed063a21","user":{"login":"ele828","id":8534639,"node_id":"MDQ6VXNlcjg1MzQ2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8534639?v=4","gravatar_id":"","url":"https://api.github.com/users/ele828","html_url":"https://github.com/ele828","followers_url":"https://api.github.com/users/ele828/followers","following_url":"https://api.github.com/users/ele828/following{/other_user}","gists_url":"https://api.github.com/users/ele828/gists{/gist_id}","starred_url":"https://api.github.com/users/ele828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ele828/subscriptions","organizations_url":"https://api.github.com/users/ele828/orgs","repos_url":"https://api.github.com/users/ele828/repos","events_url":"https://api.github.com/users/ele828/events{/privacy}","received_events_url":"https://api.github.com/users/ele828/received_events","type":"User","site_admin":false},"repo":{"id":96950896,"node_id":"MDEwOlJlcG9zaXRvcnk5Njk1MDg5Ng==","name":"ringcentral-js-widgets","full_name":"ele828/ringcentral-js-widgets","owner":{"login":"ele828","id":8534639,"node_id":"MDQ6VXNlcjg1MzQ2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8534639?v=4","gravatar_id":"","url":"https://api.github.com/users/ele828","html_url":"https://github.com/ele828","followers_url":"https://api.github.com/users/ele828/followers","following_url":"https://api.github.com/users/ele828/following{/other_user}","gists_url":"https://api.github.com/users/ele828/gists{/gist_id}","starred_url":"https://api.github.com/users/ele828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ele828/subscriptions","organizations_url":"https://api.github.com/users/ele828/orgs","repos_url":"https://api.github.com/users/ele828/repos","events_url":"https://api.github.com/users/ele828/events{/privacy}","received_events_url":"https://api.github.com/users/ele828/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ele828/ringcentral-js-widgets","description":"RingCentral Integration Widget Library","fork":true,"url":"https://api.github.com/repos/ele828/ringcentral-js-widgets","forks_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/forks","keys_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/teams","hooks_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/hooks","issue_events_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/events","assignees_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/tags","blobs_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/languages","stargazers_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/stargazers","contributors_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/contributors","subscribers_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/subscribers","subscription_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/subscription","commits_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/merges","archive_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/downloads","issues_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/labels{/name}","releases_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/ele828/ringcentral-js-widgets/deployments","created_at":"2017-07-12T01:10:00Z","updated_at":"2018-08-02T14:33:37Z","pushed_at":"2018-08-06T08:56:36Z","git_url":"git://github.com/ele828/ringcentral-js-widgets.git","ssh_url":"git@github.com:ele828/ringcentral-js-widgets.git","clone_url":"https://github.com/ele828/ringcentral-js-widgets.git","svn_url":"https://github.com/ele828/ringcentral-js-widgets","homepage":"https://ringcentral.github.io/ringcentral-js-widget/","size":19223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ringcentral:master","ref":"master","sha":"090a9e1b51e1b5c2d02af2b0f4f22c91b6aeb28e","user":{"login":"ringcentral","id":6549285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NDkyODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6549285?v=4","gravatar_id":"","url":"https://api.github.com/users/ringcentral","html_url":"https://github.com/ringcentral","followers_url":"https://api.github.com/users/ringcentral/followers","following_url":"https://api.github.com/users/ringcentral/following{/other_user}","gists_url":"https://api.github.com/users/ringcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/ringcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringcentral/subscriptions","organizations_url":"https://api.github.com/users/ringcentral/orgs","repos_url":"https://api.github.com/users/ringcentral/repos","events_url":"https://api.github.com/users/ringcentral/events{/privacy}","received_events_url":"https://api.github.com/users/ringcentral/received_events","type":"Organization","site_admin":false},"repo":{"id":58172287,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE3MjI4Nw==","name":"ringcentral-js-widgets","full_name":"ringcentral/ringcentral-js-widgets","owner":{"login":"ringcentral","id":6549285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NDkyODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6549285?v=4","gravatar_id":"","url":"https://api.github.com/users/ringcentral","html_url":"https://github.com/ringcentral","followers_url":"https://api.github.com/users/ringcentral/followers","following_url":"https://api.github.com/users/ringcentral/following{/other_user}","gists_url":"https://api.github.com/users/ringcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/ringcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringcentral/subscriptions","organizations_url":"https://api.github.com/users/ringcentral/orgs","repos_url":"https://api.github.com/users/ringcentral/repos","events_url":"https://api.github.com/users/ringcentral/events{/privacy}","received_events_url":"https://api.github.com/users/ringcentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ringcentral/ringcentral-js-widgets","description":"RingCentral Integration Widget Library","fork":false,"url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets","forks_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/forks","keys_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/teams","hooks_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/hooks","issue_events_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/events","assignees_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/tags","blobs_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/languages","stargazers_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/stargazers","contributors_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/contributors","subscribers_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/subscribers","subscription_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/subscription","commits_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/merges","archive_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/downloads","issues_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/labels{/name}","releases_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/deployments","created_at":"2016-05-06T01:45:07Z","updated_at":"2018-08-06T08:37:21Z","pushed_at":"2018-08-06T08:56:38Z","git_url":"git://github.com/ringcentral/ringcentral-js-widgets.git","ssh_url":"git@github.com:ringcentral/ringcentral-js-widgets.git","clone_url":"https://github.com/ringcentral/ringcentral-js-widgets.git","svn_url":"https://github.com/ringcentral/ringcentral-js-widgets","homepage":"https://ringcentral.github.io/ringcentral-js-widgets/","size":26184,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":31,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016"},"html":{"href":"https://github.com/ringcentral/ringcentral-js-widgets/pull/1016"},"issue":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/1016"},"comments":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/issues/1016/comments"},"review_comments":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016/comments"},"review_comment":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/pulls/1016/commits"},"statuses":{"href":"https://api.github.com/repos/ringcentral/ringcentral-js-widgets/statuses/865a35b921ade7fe395f27931a091b16ed063a21"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ele828"}}