{"action":"created","comment":{"url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/187212519","pull_request_review_id":118945270,"id":187212519,"diff_hunk":"@@ -59,17 +96,98 @@ GhostReplayInfoDialog::GhostReplayInfoDialog(unsigned int replay_id)\n     }\n \n     m_record_widget->setState(false);\n-    m_watch_widget->setState(false);\n+    m_watch_widget->setState(m_compare_ghost);\n+    m_compare_widget->setState(m_compare_ghost);\n+\n+    if (m_compare_ghost)\n+    {\n+        m_watch_only = true;\n+        m_record_race = false;\n+        m_record_widget->setState(false);\n+        m_record_widget->setVisible(!m_watch_only);\n+        getWidget<LabelWidget>(\"record-race-text\")->setVisible(!m_watch_only);\n+    }\n+\n+    // Display this checkbox only if there is another replay file to compare with\n+    getWidget<LabelWidget>(\"compare-ghost-text\")->setVisible(m_compare_ghost);\n+    m_compare_widget->setVisible(m_compare_ghost);\n+\n \n     m_action_widget->setFocusForPlayer(PLAYER_ID_GAME_MASTER);\n     m_action_widget->select(\"start\", PLAYER_ID_GAME_MASTER);\n }   // GhostReplayInfoDialog\n-\n // -----------------------------------------------------------------------------\n GhostReplayInfoDialog::~GhostReplayInfoDialog()\n {\n }   // ~GhostReplayInfoDialog\n \n+// -----------------------------------------------------------------------------\n+void GhostReplayInfoDialog::updateReplayDisplayedInfo()\n+{\n+    m_replay_info_widget->clear();\n+\n+    int n=2;","path":"src/states_screens/dialogs/ghost_replay_info_dialog.cpp","position":110,"original_position":110,"commit_id":"69c1ac8e6cc49149bd31ad7257565f410a6830ff","original_commit_id":"69c1ac8e6cc49149bd31ad7257565f410a6830ff","user":{"login":"auriamg","id":4296971,"avatar_url":"https://avatars3.githubusercontent.com/u/4296971?v=4","gravatar_id":"","url":"https://api.github.com/users/auriamg","html_url":"https://github.com/auriamg","followers_url":"https://api.github.com/users/auriamg/followers","following_url":"https://api.github.com/users/auriamg/following{/other_user}","gists_url":"https://api.github.com/users/auriamg/gists{/gist_id}","starred_url":"https://api.github.com/users/auriamg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auriamg/subscriptions","organizations_url":"https://api.github.com/users/auriamg/orgs","repos_url":"https://api.github.com/users/auriamg/repos","events_url":"https://api.github.com/users/auriamg/events{/privacy}","received_events_url":"https://api.github.com/users/auriamg/received_events","type":"User","site_admin":false},"body":"Can you maybe find a more descriptive name that \"n\" so it's easier to understand what it is?","created_at":"2018-05-10T00:28:01Z","updated_at":"2018-05-10T00:34:01Z","html_url":"https://github.com/supertuxkart/stk-code/pull/3244#discussion_r187212519","pull_request_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments/187212519"},"html":{"href":"https://github.com/supertuxkart/stk-code/pull/3244#discussion_r187212519"},"pull_request":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244"}}},"pull_request":{"url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244","id":186234942,"html_url":"https://github.com/supertuxkart/stk-code/pull/3244","diff_url":"https://github.com/supertuxkart/stk-code/pull/3244.diff","patch_url":"https://github.com/supertuxkart/stk-code/pull/3244.patch","issue_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/3244","number":3244,"state":"open","locked":false,"title":"Numerous improvements related to ghost replays","user":{"login":"Alayan-stk-2","id":25536748,"avatar_url":"https://avatars2.githubusercontent.com/u/25536748?v=4","gravatar_id":"","url":"https://api.github.com/users/Alayan-stk-2","html_url":"https://github.com/Alayan-stk-2","followers_url":"https://api.github.com/users/Alayan-stk-2/followers","following_url":"https://api.github.com/users/Alayan-stk-2/following{/other_user}","gists_url":"https://api.github.com/users/Alayan-stk-2/gists{/gist_id}","starred_url":"https://api.github.com/users/Alayan-stk-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alayan-stk-2/subscriptions","organizations_url":"https://api.github.com/users/Alayan-stk-2/orgs","repos_url":"https://api.github.com/users/Alayan-stk-2/repos","events_url":"https://api.github.com/users/Alayan-stk-2/events{/privacy}","received_events_url":"https://api.github.com/users/Alayan-stk-2/received_events","type":"User","site_admin":false},"body":"Too numerous to write them all here. See the full list here : https://github.com/supertuxkart/stk-code/issues/3156 (all checked checkboxes correspond to something this PR fixes)\r\n\r\nAlso fixes #3153\r\n\r\nDemo here : https://www.youtube.com/watch?v=srKezXy8d98","created_at":"2018-05-07T00:28:01Z","updated_at":"2018-05-10T00:34:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e9f29decf299567e65ce23f8ceb95c7ad5138ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244/commits","review_comments_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244/comments","review_comment_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/3244/comments","statuses_url":"https://api.github.com/repos/supertuxkart/stk-code/statuses/69c1ac8e6cc49149bd31ad7257565f410a6830ff","head":{"label":"STK-helper:GhostFix","ref":"GhostFix","sha":"69c1ac8e6cc49149bd31ad7257565f410a6830ff","user":{"login":"STK-helper","id":25570433,"avatar_url":"https://avatars1.githubusercontent.com/u/25570433?v=4","gravatar_id":"","url":"https://api.github.com/users/STK-helper","html_url":"https://github.com/STK-helper","followers_url":"https://api.github.com/users/STK-helper/followers","following_url":"https://api.github.com/users/STK-helper/following{/other_user}","gists_url":"https://api.github.com/users/STK-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/STK-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STK-helper/subscriptions","organizations_url":"https://api.github.com/users/STK-helper/orgs","repos_url":"https://api.github.com/users/STK-helper/repos","events_url":"https://api.github.com/users/STK-helper/events{/privacy}","received_events_url":"https://api.github.com/users/STK-helper/received_events","type":"Organization","site_admin":false},"repo":{"id":126043687,"name":"stk-code","full_name":"STK-helper/stk-code","owner":{"login":"STK-helper","id":25570433,"avatar_url":"https://avatars1.githubusercontent.com/u/25570433?v=4","gravatar_id":"","url":"https://api.github.com/users/STK-helper","html_url":"https://github.com/STK-helper","followers_url":"https://api.github.com/users/STK-helper/followers","following_url":"https://api.github.com/users/STK-helper/following{/other_user}","gists_url":"https://api.github.com/users/STK-helper/gists{/gist_id}","starred_url":"https://api.github.com/users/STK-helper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STK-helper/subscriptions","organizations_url":"https://api.github.com/users/STK-helper/orgs","repos_url":"https://api.github.com/users/STK-helper/repos","events_url":"https://api.github.com/users/STK-helper/events{/privacy}","received_events_url":"https://api.github.com/users/STK-helper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STK-helper/stk-code","description":"The code base of supertuxkart","fork":true,"url":"https://api.github.com/repos/STK-helper/stk-code","forks_url":"https://api.github.com/repos/STK-helper/stk-code/forks","keys_url":"https://api.github.com/repos/STK-helper/stk-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STK-helper/stk-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STK-helper/stk-code/teams","hooks_url":"https://api.github.com/repos/STK-helper/stk-code/hooks","issue_events_url":"https://api.github.com/repos/STK-helper/stk-code/issues/events{/number}","events_url":"https://api.github.com/repos/STK-helper/stk-code/events","assignees_url":"https://api.github.com/repos/STK-helper/stk-code/assignees{/user}","branches_url":"https://api.github.com/repos/STK-helper/stk-code/branches{/branch}","tags_url":"https://api.github.com/repos/STK-helper/stk-code/tags","blobs_url":"https://api.github.com/repos/STK-helper/stk-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STK-helper/stk-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STK-helper/stk-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/STK-helper/stk-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STK-helper/stk-code/statuses/{sha}","languages_url":"https://api.github.com/repos/STK-helper/stk-code/languages","stargazers_url":"https://api.github.com/repos/STK-helper/stk-code/stargazers","contributors_url":"https://api.github.com/repos/STK-helper/stk-code/contributors","subscribers_url":"https://api.github.com/repos/STK-helper/stk-code/subscribers","subscription_url":"https://api.github.com/repos/STK-helper/stk-code/subscription","commits_url":"https://api.github.com/repos/STK-helper/stk-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/STK-helper/stk-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/STK-helper/stk-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/STK-helper/stk-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/STK-helper/stk-code/contents/{+path}","compare_url":"https://api.github.com/repos/STK-helper/stk-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STK-helper/stk-code/merges","archive_url":"https://api.github.com/repos/STK-helper/stk-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STK-helper/stk-code/downloads","issues_url":"https://api.github.com/repos/STK-helper/stk-code/issues{/number}","pulls_url":"https://api.github.com/repos/STK-helper/stk-code/pulls{/number}","milestones_url":"https://api.github.com/repos/STK-helper/stk-code/milestones{/number}","notifications_url":"https://api.github.com/repos/STK-helper/stk-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STK-helper/stk-code/labels{/name}","releases_url":"https://api.github.com/repos/STK-helper/stk-code/releases{/id}","deployments_url":"https://api.github.com/repos/STK-helper/stk-code/deployments","created_at":"2018-03-20T15:54:09Z","updated_at":"2018-05-07T04:31:32Z","pushed_at":"2018-05-09T17:43:59Z","git_url":"git://github.com/STK-helper/stk-code.git","ssh_url":"git@github.com:STK-helper/stk-code.git","clone_url":"https://github.com/STK-helper/stk-code.git","svn_url":"https://github.com/STK-helper/stk-code","homepage":null,"size":247505,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"supertuxkart:master","ref":"master","sha":"85eb59c6af9cfa7f9e55761c5598424ae3af23cd","user":{"login":"supertuxkart","id":6138677,"avatar_url":"https://avatars0.githubusercontent.com/u/6138677?v=4","gravatar_id":"","url":"https://api.github.com/users/supertuxkart","html_url":"https://github.com/supertuxkart","followers_url":"https://api.github.com/users/supertuxkart/followers","following_url":"https://api.github.com/users/supertuxkart/following{/other_user}","gists_url":"https://api.github.com/users/supertuxkart/gists{/gist_id}","starred_url":"https://api.github.com/users/supertuxkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supertuxkart/subscriptions","organizations_url":"https://api.github.com/users/supertuxkart/orgs","repos_url":"https://api.github.com/users/supertuxkart/repos","events_url":"https://api.github.com/users/supertuxkart/events{/privacy}","received_events_url":"https://api.github.com/users/supertuxkart/received_events","type":"Organization","site_admin":false},"repo":{"id":15920273,"name":"stk-code","full_name":"supertuxkart/stk-code","owner":{"login":"supertuxkart","id":6138677,"avatar_url":"https://avatars0.githubusercontent.com/u/6138677?v=4","gravatar_id":"","url":"https://api.github.com/users/supertuxkart","html_url":"https://github.com/supertuxkart","followers_url":"https://api.github.com/users/supertuxkart/followers","following_url":"https://api.github.com/users/supertuxkart/following{/other_user}","gists_url":"https://api.github.com/users/supertuxkart/gists{/gist_id}","starred_url":"https://api.github.com/users/supertuxkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supertuxkart/subscriptions","organizations_url":"https://api.github.com/users/supertuxkart/orgs","repos_url":"https://api.github.com/users/supertuxkart/repos","events_url":"https://api.github.com/users/supertuxkart/events{/privacy}","received_events_url":"https://api.github.com/users/supertuxkart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/supertuxkart/stk-code","description":"The code base of supertuxkart","fork":false,"url":"https://api.github.com/repos/supertuxkart/stk-code","forks_url":"https://api.github.com/repos/supertuxkart/stk-code/forks","keys_url":"https://api.github.com/repos/supertuxkart/stk-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supertuxkart/stk-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supertuxkart/stk-code/teams","hooks_url":"https://api.github.com/repos/supertuxkart/stk-code/hooks","issue_events_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/events{/number}","events_url":"https://api.github.com/repos/supertuxkart/stk-code/events","assignees_url":"https://api.github.com/repos/supertuxkart/stk-code/assignees{/user}","branches_url":"https://api.github.com/repos/supertuxkart/stk-code/branches{/branch}","tags_url":"https://api.github.com/repos/supertuxkart/stk-code/tags","blobs_url":"https://api.github.com/repos/supertuxkart/stk-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supertuxkart/stk-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supertuxkart/stk-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/supertuxkart/stk-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supertuxkart/stk-code/statuses/{sha}","languages_url":"https://api.github.com/repos/supertuxkart/stk-code/languages","stargazers_url":"https://api.github.com/repos/supertuxkart/stk-code/stargazers","contributors_url":"https://api.github.com/repos/supertuxkart/stk-code/contributors","subscribers_url":"https://api.github.com/repos/supertuxkart/stk-code/subscribers","subscription_url":"https://api.github.com/repos/supertuxkart/stk-code/subscription","commits_url":"https://api.github.com/repos/supertuxkart/stk-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/supertuxkart/stk-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/supertuxkart/stk-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/supertuxkart/stk-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/supertuxkart/stk-code/contents/{+path}","compare_url":"https://api.github.com/repos/supertuxkart/stk-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supertuxkart/stk-code/merges","archive_url":"https://api.github.com/repos/supertuxkart/stk-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supertuxkart/stk-code/downloads","issues_url":"https://api.github.com/repos/supertuxkart/stk-code/issues{/number}","pulls_url":"https://api.github.com/repos/supertuxkart/stk-code/pulls{/number}","milestones_url":"https://api.github.com/repos/supertuxkart/stk-code/milestones{/number}","notifications_url":"https://api.github.com/repos/supertuxkart/stk-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supertuxkart/stk-code/labels{/name}","releases_url":"https://api.github.com/repos/supertuxkart/stk-code/releases{/id}","deployments_url":"https://api.github.com/repos/supertuxkart/stk-code/deployments","created_at":"2014-01-15T00:28:54Z","updated_at":"2018-05-09T21:10:23Z","pushed_at":"2018-05-09T21:45:51Z","git_url":"git://github.com/supertuxkart/stk-code.git","ssh_url":"git@github.com:supertuxkart/stk-code.git","clone_url":"https://github.com/supertuxkart/stk-code.git","svn_url":"https://github.com/supertuxkart/stk-code","homepage":null,"size":246501,"stargazers_count":516,"watchers_count":516,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"archived":false,"open_issues_count":287,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":218,"open_issues":287,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244"},"html":{"href":"https://github.com/supertuxkart/stk-code/pull/3244"},"issue":{"href":"https://api.github.com/repos/supertuxkart/stk-code/issues/3244"},"comments":{"href":"https://api.github.com/repos/supertuxkart/stk-code/issues/3244/comments"},"review_comments":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244/comments"},"review_comment":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/supertuxkart/stk-code/pulls/3244/commits"},"statuses":{"href":"https://api.github.com/repos/supertuxkart/stk-code/statuses/69c1ac8e6cc49149bd31ad7257565f410a6830ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"auriamg"}}