{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/180758005","pull_request_review_id":111231533,"id":180758005,"diff_hunk":"@@ -0,0 +1,165 @@\n+// +build k8srequired\n+\n+package nodeconfig\n+\n+import (\n+\t\"time\"\n+\n+\t\"github.com/giantswarm/apiextensions/pkg/apis/core/v1alpha1\"\n+\t\"github.com/giantswarm/apiextensions/pkg/clientset/versioned\"\n+\t\"github.com/giantswarm/e2e-harness/pkg/harness\"\n+\t\"github.com/giantswarm/microerror\"\n+\t\"github.com/giantswarm/micrologger\"\n+\tcorev1 \"k8s.io/api/core/v1\"\n+\t\"k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset\"\n+\t\"k8s.io/apimachinery/pkg/api/errors\"\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\t\"k8s.io/client-go/kubernetes\"\n+\t\"k8s.io/client-go/tools/clientcmd\"\n+\n+\t\"github.com/giantswarm/operatorkit/client/k8scrdclient\"\n+\t\"github.com/giantswarm/operatorkit/framework\"\n+\t\"github.com/giantswarm/operatorkit/framework/integration/client\"\n+\t\"github.com/giantswarm/operatorkit/framework/integration/testresourceset\"\n+\t\"github.com/giantswarm/operatorkit/informer\"\n+)\n+\n+type Client struct {","path":"framework/integration/client/nodeconfig/client.go","position":27,"original_position":27,"commit_id":"50c7f689b0a12a01b70c77f1d19375ce7947516d","original_commit_id":"50c7f689b0a12a01b70c77f1d19375ce7947516d","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars3.githubusercontent.com/u/552769?v=4","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"Uncertain. Wrapper could work for me. ","created_at":"2018-04-11T13:43:08Z","updated_at":"2018-04-11T13:44:06Z","html_url":"https://github.com/giantswarm/operatorkit/pull/188#discussion_r180758005","pull_request_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments/180758005"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/188#discussion_r180758005"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188"}},"in_reply_to_id":180746302},"pull_request":{"url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188","id":180896304,"html_url":"https://github.com/giantswarm/operatorkit/pull/188","diff_url":"https://github.com/giantswarm/operatorkit/pull/188.diff","patch_url":"https://github.com/giantswarm/operatorkit/pull/188.patch","issue_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/188","number":188,"state":"open","locked":false,"title":"Add nodeconfig as a test CR and restructure test setup","user":{"login":"MarcelMue","id":9303709,"avatar_url":"https://avatars1.githubusercontent.com/u/9303709?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelMue","html_url":"https://github.com/MarcelMue","followers_url":"https://api.github.com/users/MarcelMue/followers","following_url":"https://api.github.com/users/MarcelMue/following{/other_user}","gists_url":"https://api.github.com/users/MarcelMue/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelMue/subscriptions","organizations_url":"https://api.github.com/users/MarcelMue/orgs","repos_url":"https://api.github.com/users/MarcelMue/repos","events_url":"https://api.github.com/users/MarcelMue/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelMue/received_events","type":"User","site_admin":false},"body":"This PR got way bigger than I intended, I can close here and try to redo this with smaller PRs if this doesn't work for you.\r\n\r\nGoal of this PR: I want to run our tests against both standard k8s objects and CRs. \r\n\r\nFor this I decided to create an interface which handles the CRUD functions of an object and also offers a framework which is configured for the object. This should allow us to run the same test code with different inputs against both CRs and standard objects.\r\n\r\nTowards https://github.com/giantswarm/giantswarm/issues/1595","created_at":"2018-04-11T13:03:51Z","updated_at":"2018-04-11T13:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b09be0f2320930848034488daf00edc5544bff","assignee":{"login":"MarcelMue","id":9303709,"avatar_url":"https://avatars1.githubusercontent.com/u/9303709?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelMue","html_url":"https://github.com/MarcelMue","followers_url":"https://api.github.com/users/MarcelMue/followers","following_url":"https://api.github.com/users/MarcelMue/following{/other_user}","gists_url":"https://api.github.com/users/MarcelMue/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelMue/subscriptions","organizations_url":"https://api.github.com/users/MarcelMue/orgs","repos_url":"https://api.github.com/users/MarcelMue/repos","events_url":"https://api.github.com/users/MarcelMue/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelMue/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarcelMue","id":9303709,"avatar_url":"https://avatars1.githubusercontent.com/u/9303709?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelMue","html_url":"https://github.com/MarcelMue","followers_url":"https://api.github.com/users/MarcelMue/followers","following_url":"https://api.github.com/users/MarcelMue/following{/other_user}","gists_url":"https://api.github.com/users/MarcelMue/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelMue/subscriptions","organizations_url":"https://api.github.com/users/MarcelMue/orgs","repos_url":"https://api.github.com/users/MarcelMue/repos","events_url":"https://api.github.com/users/MarcelMue/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelMue/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188/commits","review_comments_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188/comments","review_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/188/comments","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/50c7f689b0a12a01b70c77f1d19375ce7947516d","head":{"label":"giantswarm:add-nodeconfig-test-cr","ref":"add-nodeconfig-test-cr","sha":"50c7f689b0a12a01b70c77f1d19375ce7947516d","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"name":"operatorkit","full_name":"giantswarm/operatorkit","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/operatorkit","description":"The operatorkit package implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2018-04-10T12:25:03Z","pushed_at":"2018-04-11T13:03:52Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"git@github.com:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"https://godoc.org/github.com/giantswarm/operatorkit","size":32881,"stargazers_count":78,"watchers_count":78,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":6,"watchers":78,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"c656522a5b6cf0c811f4d4ba408306b49121c298","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":87818870,"name":"operatorkit","full_name":"giantswarm/operatorkit","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/operatorkit","description":"The operatorkit package implements an opinionated framework for developing Kubernetes operators.","fork":false,"url":"https://api.github.com/repos/giantswarm/operatorkit","forks_url":"https://api.github.com/repos/giantswarm/operatorkit/forks","keys_url":"https://api.github.com/repos/giantswarm/operatorkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/operatorkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/operatorkit/teams","hooks_url":"https://api.github.com/repos/giantswarm/operatorkit/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/operatorkit/events","assignees_url":"https://api.github.com/repos/giantswarm/operatorkit/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/operatorkit/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/operatorkit/tags","blobs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/operatorkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/operatorkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/operatorkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/operatorkit/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/operatorkit/languages","stargazers_url":"https://api.github.com/repos/giantswarm/operatorkit/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/operatorkit/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/operatorkit/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/operatorkit/subscription","commits_url":"https://api.github.com/repos/giantswarm/operatorkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/operatorkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/operatorkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/operatorkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/operatorkit/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/operatorkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/operatorkit/merges","archive_url":"https://api.github.com/repos/giantswarm/operatorkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/operatorkit/downloads","issues_url":"https://api.github.com/repos/giantswarm/operatorkit/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/operatorkit/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/operatorkit/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/operatorkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/operatorkit/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/operatorkit/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/operatorkit/deployments","created_at":"2017-04-10T14:12:58Z","updated_at":"2018-04-10T12:25:03Z","pushed_at":"2018-04-11T13:03:52Z","git_url":"git://github.com/giantswarm/operatorkit.git","ssh_url":"git@github.com:giantswarm/operatorkit.git","clone_url":"https://github.com/giantswarm/operatorkit.git","svn_url":"https://github.com/giantswarm/operatorkit","homepage":"https://godoc.org/github.com/giantswarm/operatorkit","size":32881,"stargazers_count":78,"watchers_count":78,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":6,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188"},"html":{"href":"https://github.com/giantswarm/operatorkit/pull/188"},"issue":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/188"},"comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/operatorkit/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/operatorkit/statuses/50c7f689b0a12a01b70c77f1d19375ce7947516d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xh3b4sd"}}