{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/174050030","pull_request_review_id":103335464,"id":174050030,"diff_hunk":"@@ -93,7 +93,7 @@ def split_shlib_to_parts(self, fname):\n     # The default behavior is this, override in MSVC\n     def build_rpath_args(self, build_dir, from_dir, rpath_paths, build_rpath, install_rpath):\n         if self.id == 'clang' and self.clang_type == compilers.CLANG_OSX:\n-            return self.build_osx_rpath_args(build_dir, rpath_paths, build_rpath)\n+            return [] # no rpath on macOS!","path":"mesonbuild/compilers/c.py","position":14,"original_position":14,"commit_id":"4e1e986d117214656782ef45f92d9c8039a10ad0","original_commit_id":"4e1e986d117214656782ef45f92d9c8039a10ad0","user":{"login":"ePirat","id":323210,"avatar_url":"https://avatars1.githubusercontent.com/u/323210?v=4","gravatar_id":"","url":"https://api.github.com/users/ePirat","html_url":"https://github.com/ePirat","followers_url":"https://api.github.com/users/ePirat/followers","following_url":"https://api.github.com/users/ePirat/following{/other_user}","gists_url":"https://api.github.com/users/ePirat/gists{/gist_id}","starred_url":"https://api.github.com/users/ePirat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ePirat/subscriptions","organizations_url":"https://api.github.com/users/ePirat/orgs","repos_url":"https://api.github.com/users/ePirat/repos","events_url":"https://api.github.com/users/ePirat/events{/privacy}","received_events_url":"https://api.github.com/users/ePirat/received_events","type":"User","site_admin":false},"body":">  But even then, the recommended way is to use @executable_path and @loader_path instead of @rpath.\r\n\r\nWhy? Afaik from what I found, the recommended way on modern macOS versions is to go with the rpath approach and it works fine, better than what we had before and does not require us to use `install_name_tool` on all libraries, but only on the executable when bundling (to set the rpath correctly), making bundling much easier and less error-prone.\r\n\r\n> I would be happy to change the title of the PR to something like \"Fix macOS dylibs and GObject introspection bindings\" if you would like me to widen the scope\r\n\r\nIt should not be done in this PR at all, I would argue. Just split up the commit and make a new PR with the rpath change? That way at least the library version stuff could be merged soon, hopefully? And we can continue the discussion about rpath on a dedicated PR about it and evaluate the solutions.","created_at":"2018-03-13T08:43:59Z","updated_at":"2018-03-13T08:43:59Z","html_url":"https://github.com/mesonbuild/meson/pull/2577#discussion_r174050030","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/2577","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/174050030"},"html":{"href":"https://github.com/mesonbuild/meson/pull/2577#discussion_r174050030"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/2577"}},"in_reply_to_id":174039832},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/2577","id":150531782,"html_url":"https://github.com/mesonbuild/meson/pull/2577","diff_url":"https://github.com/mesonbuild/meson/pull/2577.diff","patch_url":"https://github.com/mesonbuild/meson/pull/2577.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/2577","number":2577,"state":"open","locked":false,"title":"Add macOS linker versioning information","user":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars0.githubusercontent.com/u/65736?v=4","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"body":"This patch exploits the information residing in ltversion to set the\n-compatibility_version and -current_version flags that are passed to the\nlinker on macOS.\n\nSee #1445, #1446, #1451","created_at":"2017-11-03T13:48:24Z","updated_at":"2018-03-13T08:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91c39368921348a21e42aaa06411e407fef03ba5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/mesonbuild/meson/milestones/22","html_url":"https://github.com/mesonbuild/meson/milestone/22","labels_url":"https://api.github.com/repos/mesonbuild/meson/milestones/22/labels","id":2742877,"number":22,"title":"meson-next","description":"The next features/bugs we should be working on. To prevent clutter, please only add issues that you intend to work on yourself.","creator":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars0.githubusercontent.com/u/75801?v=4","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":4,"state":"open","created_at":"2017-09-04T11:37:52Z","updated_at":"2018-02-27T23:43:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/2577/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/2577/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/2577/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/4e1e986d117214656782ef45f92d9c8039a10ad0","head":{"label":"tschoonj:macos-versioning-fix","ref":"macos-versioning-fix","sha":"4e1e986d117214656782ef45f92d9c8039a10ad0","user":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars0.githubusercontent.com/u/65736?v=4","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"repo":{"id":109370511,"name":"meson","full_name":"tschoonj/meson","owner":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars0.githubusercontent.com/u/65736?v=4","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschoonj/meson","description":"The Meson Build System","fork":true,"url":"https://api.github.com/repos/tschoonj/meson","forks_url":"https://api.github.com/repos/tschoonj/meson/forks","keys_url":"https://api.github.com/repos/tschoonj/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschoonj/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschoonj/meson/teams","hooks_url":"https://api.github.com/repos/tschoonj/meson/hooks","issue_events_url":"https://api.github.com/repos/tschoonj/meson/issues/events{/number}","events_url":"https://api.github.com/repos/tschoonj/meson/events","assignees_url":"https://api.github.com/repos/tschoonj/meson/assignees{/user}","branches_url":"https://api.github.com/repos/tschoonj/meson/branches{/branch}","tags_url":"https://api.github.com/repos/tschoonj/meson/tags","blobs_url":"https://api.github.com/repos/tschoonj/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschoonj/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschoonj/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschoonj/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschoonj/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/tschoonj/meson/languages","stargazers_url":"https://api.github.com/repos/tschoonj/meson/stargazers","contributors_url":"https://api.github.com/repos/tschoonj/meson/contributors","subscribers_url":"https://api.github.com/repos/tschoonj/meson/subscribers","subscription_url":"https://api.github.com/repos/tschoonj/meson/subscription","commits_url":"https://api.github.com/repos/tschoonj/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschoonj/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschoonj/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschoonj/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschoonj/meson/contents/{+path}","compare_url":"https://api.github.com/repos/tschoonj/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschoonj/meson/merges","archive_url":"https://api.github.com/repos/tschoonj/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschoonj/meson/downloads","issues_url":"https://api.github.com/repos/tschoonj/meson/issues{/number}","pulls_url":"https://api.github.com/repos/tschoonj/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/tschoonj/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/tschoonj/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschoonj/meson/labels{/name}","releases_url":"https://api.github.com/repos/tschoonj/meson/releases{/id}","deployments_url":"https://api.github.com/repos/tschoonj/meson/deployments","created_at":"2017-11-03T08:21:29Z","updated_at":"2017-11-03T08:21:32Z","pushed_at":"2018-02-12T08:58:24Z","git_url":"git://github.com/tschoonj/meson.git","ssh_url":"git@github.com:tschoonj/meson.git","clone_url":"https://github.com/tschoonj/meson.git","svn_url":"https://github.com/tschoonj/meson","homepage":"http://mesonbuild.com","size":12630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"1b7b7fedb91f52b6ff35db461f6412a4ad5f7c7f","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2018-03-12T22:06:30Z","pushed_at":"2018-03-13T07:32:16Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":"http://mesonbuild.com","size":13387,"stargazers_count":1337,"watchers_count":1337,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":629,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":347,"open_issues":629,"watchers":1337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/2577"},"html":{"href":"https://github.com/mesonbuild/meson/pull/2577"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/2577"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/2577/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/2577/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/2577/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/4e1e986d117214656782ef45f92d9c8039a10ad0"}},"author_association":"NONE"}}
{"actor":{"display_login":"ePirat"}}