{"action":"created","issue":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/5","repository_url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy","labels_url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/5/comments","events_url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/5/events","html_url":"https://github.com/htmlacademy-htmlcss/554131-gllacy/pull/5","id":307770760,"number":5,"title":"Сетка личного проекта на флексах","user":{"login":"MrBunny194","id":29162621,"avatar_url":"https://avatars2.githubusercontent.com/u/29162621?v=4","gravatar_id":"","url":"https://api.github.com/users/MrBunny194","html_url":"https://github.com/MrBunny194","followers_url":"https://api.github.com/users/MrBunny194/followers","following_url":"https://api.github.com/users/MrBunny194/following{/other_user}","gists_url":"https://api.github.com/users/MrBunny194/gists{/gist_id}","starred_url":"https://api.github.com/users/MrBunny194/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrBunny194/subscriptions","organizations_url":"https://api.github.com/users/MrBunny194/orgs","repos_url":"https://api.github.com/users/MrBunny194/repos","events_url":"https://api.github.com/users/MrBunny194/events{/privacy}","received_events_url":"https://api.github.com/users/MrBunny194/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"GoshaEgorian","id":8870929,"avatar_url":"https://avatars2.githubusercontent.com/u/8870929?v=4","gravatar_id":"","url":"https://api.github.com/users/GoshaEgorian","html_url":"https://github.com/GoshaEgorian","followers_url":"https://api.github.com/users/GoshaEgorian/followers","following_url":"https://api.github.com/users/GoshaEgorian/following{/other_user}","gists_url":"https://api.github.com/users/GoshaEgorian/gists{/gist_id}","starred_url":"https://api.github.com/users/GoshaEgorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoshaEgorian/subscriptions","organizations_url":"https://api.github.com/users/GoshaEgorian/orgs","repos_url":"https://api.github.com/users/GoshaEgorian/repos","events_url":"https://api.github.com/users/GoshaEgorian/events{/privacy}","received_events_url":"https://api.github.com/users/GoshaEgorian/received_events","type":"User","site_admin":false},"assignees":[{"login":"GoshaEgorian","id":8870929,"avatar_url":"https://avatars2.githubusercontent.com/u/8870929?v=4","gravatar_id":"","url":"https://api.github.com/users/GoshaEgorian","html_url":"https://github.com/GoshaEgorian","followers_url":"https://api.github.com/users/GoshaEgorian/followers","following_url":"https://api.github.com/users/GoshaEgorian/following{/other_user}","gists_url":"https://api.github.com/users/GoshaEgorian/gists{/gist_id}","starred_url":"https://api.github.com/users/GoshaEgorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoshaEgorian/subscriptions","organizations_url":"https://api.github.com/users/GoshaEgorian/orgs","repos_url":"https://api.github.com/users/GoshaEgorian/repos","events_url":"https://api.github.com/users/GoshaEgorian/events{/privacy}","received_events_url":"https://api.github.com/users/GoshaEgorian/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2018-03-22T18:49:08Z","updated_at":"2018-03-30T00:43:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/pulls/5","html_url":"https://github.com/htmlacademy-htmlcss/554131-gllacy/pull/5","diff_url":"https://github.com/htmlacademy-htmlcss/554131-gllacy/pull/5.diff","patch_url":"https://github.com/htmlacademy-htmlcss/554131-gllacy/pull/5.patch"},"body":"\n\n---\n:mortar_board: [Сетка личного проекта на флексах](https://up.htmlacademy.ru/htmlcss/20/user/554131/tasks/42)\n\n:boom: https://htmlacademy-htmlcss.github.io/554131-gllacy/5/\n\n---\n:mortar_board: [Базовая стилизация личного проекта](https://up.htmlacademy.ru/htmlcss/20/user/554131/tasks/35)"},"comment":{"url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/comments/377413680","html_url":"https://github.com/htmlacademy-htmlcss/554131-gllacy/pull/5#issuecomment-377413680","issue_url":"https://api.github.com/repos/htmlacademy-htmlcss/554131-gllacy/issues/5","id":377413680,"user":{"login":"GoshaEgorian","id":8870929,"avatar_url":"https://avatars2.githubusercontent.com/u/8870929?v=4","gravatar_id":"","url":"https://api.github.com/users/GoshaEgorian","html_url":"https://github.com/GoshaEgorian","followers_url":"https://api.github.com/users/GoshaEgorian/followers","following_url":"https://api.github.com/users/GoshaEgorian/following{/other_user}","gists_url":"https://api.github.com/users/GoshaEgorian/gists{/gist_id}","starred_url":"https://api.github.com/users/GoshaEgorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoshaEgorian/subscriptions","organizations_url":"https://api.github.com/users/GoshaEgorian/orgs","repos_url":"https://api.github.com/users/GoshaEgorian/repos","events_url":"https://api.github.com/users/GoshaEgorian/events{/privacy}","received_events_url":"https://api.github.com/users/GoshaEgorian/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T00:43:28Z","updated_at":"2018-03-30T00:43:28Z","author_association":"COLLABORATOR","body":"# Базовые критерии\r\n\r\n1. PixelPerfect\r\nНемножко отклоняются кнопки переключения слайдов на главной\r\n![image](https://user-images.githubusercontent.com/8870929/38118955-24ca8880-33c7-11e8-8894-05e6a78f5ce8.png)\r\n\r\nСильно не совпадает блок с описанием магазина\r\n![image](https://user-images.githubusercontent.com/8870929/38118977-3e7809c4-33c7-11e8-849e-e2aafa46637b.png)\r\n\r\nСелект: стрелочка почему-то слева, виден текст только пункта по наведению\r\n![image](https://user-images.githubusercontent.com/8870929/38119046-984f3c74-33c7-11e8-85dc-141ca00d9840.png)\r\n\r\nРадио оформлены, чекбоксы - нет. Специально или не успел просто?\r\n![image](https://user-images.githubusercontent.com/8870929/38119061-ac5696b8-33c7-11e8-9466-654dbe7b6c0e.png)\r\n\r\nНе до конца выровнен сам каталог, карточки относительно друг друга и их содержимое\r\n![image](https://user-images.githubusercontent.com/8870929/38119116-fcb335f8-33c7-11e8-8045-24c3d3cfe34b.png)\r\n\r\nОтступы между каталогом, пагинатором и футером не подобраны\r\n![image](https://user-images.githubusercontent.com/8870929/38119138-1fa0398a-33c8-11e8-851b-81babe888f49.png)\r\n\r\n2. Разная разметка для меню на разных страницах. В целом различия допустимы, но есть парочка плохих нюансов: на странице каталога \"доставка\" и \"о компании\" не имеют `href`. Что страшнее, на той же странице при наведении на \"каталог\" и попытке перевести курсор на подменю оно исчезает, выбрать подпункт не получается (Chrome, Opera). Аналогично с поиском, входом и корзиной. Особенно хорошо заметно, если вести мышкой медленно.\r\n3. По поводу уголков у блока на главной с формой для подписки по email смотри решение [здесь](https://stackoverflow.com/questions/5706963/possible-to-use-border-radius-together-with-a-border-image-which-has-a-gradient#answer-29223812).\r\n4. Согласно [странице](https://up.htmlacademy.ru/htmlcss/20/examples_br), во всём проекте Глейси можно обойтись без тега `br`. Советую удалить, т.к. очень часто засчитывается за нарушение критерия Б4.\r\n5. Валидность. Проверь html файлы в [валидаторе](http://validator.w3.org/nu/).\r\n![image](https://user-images.githubusercontent.com/8870929/38119409-3d60893c-33ca-11e8-801c-35f63dd59efa.png)\r\n6. Кроссбраузерность\r\nFirefox:\r\n![image](https://user-images.githubusercontent.com/8870929/38119506-e8fdb3c8-33ca-11e8-8ec4-51e1961fed8f.png)\r\nIE11:\r\n![image](https://user-images.githubusercontent.com/8870929/38119543-39123186-33cb-11e8-828f-058340a1bf22.png)\r\n7. Минимальная ширина сайта не задана, сайт можно сжать в узкую колонку. См. критерий Б13 и разверни его подробно - там описаны точные ширины.\r\n\r\nПо базовым всё."}}
{"actor":{"display_login":"GoshaEgorian"}}