{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/244034313","pull_request_review_id":187943169,"id":244034313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDAzNDMxMw==","diff_hunk":"@@ -64,7 +65,8 @@ checkDemoConfig(){\n         echo \" This port is needed by the Standby Database instance. \"\n         echo \">>> Edit Makefile to correct the port number (STANDBY_PORT). <<<\"\n         echo -n \" Check to see if the port is free by using : \"","path":"gpAux/gpdemo/demo_cluster.sh","position":13,"original_position":13,"commit_id":"33b0e96b966ff2bf1d202f4035730a7a7fd984f8","original_commit_id":"33b0e96b966ff2bf1d202f4035730a7a7fd984f8","user":{"login":"ashwinstar","id":11396815,"node_id":"MDQ6VXNlcjExMzk2ODE1","avatar_url":"https://avatars2.githubusercontent.com/u/11396815?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"body":"While at it might be better to pull this `PORT_FILE` check out into a separate function. That way logic can be modified in single place.","created_at":"2018-12-26T18:49:16Z","updated_at":"2018-12-26T18:49:24Z","html_url":"https://github.com/greenplum-db/gpdb/pull/6558#discussion_r244034313","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/244034313"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6558#discussion_r244034313"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558","id":240826637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODI2NjM3","html_url":"https://github.com/greenplum-db/gpdb/pull/6558","diff_url":"https://github.com/greenplum-db/gpdb/pull/6558.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/6558.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6558","number":6558,"state":"open","locked":false,"title":"Provide more accurate debugging information for demo create failure.","user":{"login":"paul-guo-","id":7485836,"node_id":"MDQ6VXNlcjc0ODU4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7485836?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-guo-","html_url":"https://github.com/paul-guo-","followers_url":"https://api.github.com/users/paul-guo-/followers","following_url":"https://api.github.com/users/paul-guo-/following{/other_user}","gists_url":"https://api.github.com/users/paul-guo-/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-guo-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-guo-/subscriptions","organizations_url":"https://api.github.com/users/paul-guo-/orgs","repos_url":"https://api.github.com/users/paul-guo-/repos","events_url":"https://api.github.com/users/paul-guo-/events{/privacy}","received_events_url":"https://api.github.com/users/paul-guo-/received_events","type":"User","site_admin":false},"body":"There is a case that a postmaster process is killed-by-9 and then the\r\nprocess has no chance to remove its temporary files /tmp/.s.PGSQL.${PORT}*,\r\nwhich are used by the demo create script to check the port usability.\r\nFor the above case re-creating demo cluster will fail but the error\r\nmessage information as below is misleading since apparently the\r\nport is not used.\r\n\r\n  Check to see if the port is free by using: 'netstat -an | grep 16432'.\r\n","created_at":"2018-12-25T03:19:41Z","updated_at":"2018-12-26T18:49:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0abfdf0dfc5cf386bc5f8843b068364aa72abcb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6558/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/33b0e96b966ff2bf1d202f4035730a7a7fd984f8","head":{"label":"paul-guo-:gpdemo","ref":"gpdemo","sha":"33b0e96b966ff2bf1d202f4035730a7a7fd984f8","user":{"login":"paul-guo-","id":7485836,"node_id":"MDQ6VXNlcjc0ODU4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7485836?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-guo-","html_url":"https://github.com/paul-guo-","followers_url":"https://api.github.com/users/paul-guo-/followers","following_url":"https://api.github.com/users/paul-guo-/following{/other_user}","gists_url":"https://api.github.com/users/paul-guo-/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-guo-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-guo-/subscriptions","organizations_url":"https://api.github.com/users/paul-guo-/orgs","repos_url":"https://api.github.com/users/paul-guo-/repos","events_url":"https://api.github.com/users/paul-guo-/events{/privacy}","received_events_url":"https://api.github.com/users/paul-guo-/received_events","type":"User","site_admin":false},"repo":{"id":77195162,"node_id":"MDEwOlJlcG9zaXRvcnk3NzE5NTE2Mg==","name":"gpdb","full_name":"paul-guo-/gpdb","private":false,"owner":{"login":"paul-guo-","id":7485836,"node_id":"MDQ6VXNlcjc0ODU4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7485836?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-guo-","html_url":"https://github.com/paul-guo-","followers_url":"https://api.github.com/users/paul-guo-/followers","following_url":"https://api.github.com/users/paul-guo-/following{/other_user}","gists_url":"https://api.github.com/users/paul-guo-/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-guo-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-guo-/subscriptions","organizations_url":"https://api.github.com/users/paul-guo-/orgs","repos_url":"https://api.github.com/users/paul-guo-/repos","events_url":"https://api.github.com/users/paul-guo-/events{/privacy}","received_events_url":"https://api.github.com/users/paul-guo-/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paul-guo-/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/paul-guo-/gpdb","forks_url":"https://api.github.com/repos/paul-guo-/gpdb/forks","keys_url":"https://api.github.com/repos/paul-guo-/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul-guo-/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul-guo-/gpdb/teams","hooks_url":"https://api.github.com/repos/paul-guo-/gpdb/hooks","issue_events_url":"https://api.github.com/repos/paul-guo-/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/paul-guo-/gpdb/events","assignees_url":"https://api.github.com/repos/paul-guo-/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/paul-guo-/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/paul-guo-/gpdb/tags","blobs_url":"https://api.github.com/repos/paul-guo-/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul-guo-/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul-guo-/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul-guo-/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul-guo-/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/paul-guo-/gpdb/languages","stargazers_url":"https://api.github.com/repos/paul-guo-/gpdb/stargazers","contributors_url":"https://api.github.com/repos/paul-guo-/gpdb/contributors","subscribers_url":"https://api.github.com/repos/paul-guo-/gpdb/subscribers","subscription_url":"https://api.github.com/repos/paul-guo-/gpdb/subscription","commits_url":"https://api.github.com/repos/paul-guo-/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul-guo-/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul-guo-/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul-guo-/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul-guo-/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/paul-guo-/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul-guo-/gpdb/merges","archive_url":"https://api.github.com/repos/paul-guo-/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul-guo-/gpdb/downloads","issues_url":"https://api.github.com/repos/paul-guo-/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/paul-guo-/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/paul-guo-/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/paul-guo-/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul-guo-/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/paul-guo-/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/paul-guo-/gpdb/deployments","created_at":"2016-12-23T03:38:23Z","updated_at":"2018-09-27T03:54:10Z","pushed_at":"2018-12-26T03:14:52Z","git_url":"git://github.com/paul-guo-/gpdb.git","ssh_url":"git@github.com:paul-guo-/gpdb.git","clone_url":"https://github.com/paul-guo-/gpdb.git","svn_url":"https://github.com/paul-guo-/gpdb","homepage":"http://greenplum.org","size":325872,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"bf5e3d5d1b631b243701b9c4e4fb5d121c5c7e24","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-12-26T07:50:45Z","pushed_at":"2018-12-26T15:03:03Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":334863,"stargazers_count":2875,"watchers_count":2875,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":872,"mirror_url":null,"archived":false,"open_issues_count":274,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":872,"open_issues":274,"watchers":2875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6558"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6558"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6558/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6558/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/33b0e96b966ff2bf1d202f4035730a7a7fd984f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ashwinstar"}}