{"action":"created","comment":{"url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/comments/166429451","pull_request_review_id":94490024,"id":166429451,"diff_hunk":"@@ -107,18 +108,19 @@ class __Conn : dpq2.Connection\n     {\n         import vibe.core.core;\n \n-        auto sock = this.socket();\n-\n-        sock.blocking = false;\n+        scope sock = this.socket();\n+        auto triggerMode = FileDescriptorEvent.Trigger.any;\n+        debug version(Have_vibe_core) triggerMode = FileDescriptorEvent.Trigger.read;","path":"source/vibe/db/postgresql/package.d","position":17,"original_position":17,"commit_id":"14564b7bcbc55cf2dcb2a5d958ee2ccd6726ec80","original_commit_id":"14564b7bcbc55cf2dcb2a5d958ee2ccd6726ec80","user":{"login":"Kozzi11","id":1239642,"avatar_url":"https://avatars0.githubusercontent.com/u/1239642?v=4","gravatar_id":"","url":"https://api.github.com/users/Kozzi11","html_url":"https://github.com/Kozzi11","followers_url":"https://api.github.com/users/Kozzi11/followers","following_url":"https://api.github.com/users/Kozzi11/following{/other_user}","gists_url":"https://api.github.com/users/Kozzi11/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozzi11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozzi11/subscriptions","organizations_url":"https://api.github.com/users/Kozzi11/orgs","repos_url":"https://api.github.com/users/Kozzi11/repos","events_url":"https://api.github.com/users/Kozzi11/events{/privacy}","received_events_url":"https://api.github.com/users/Kozzi11/received_events","type":"User","site_admin":false},"body":"Yes, it is neede only for debug build, with release build it will somehow works because asserts are eliminated","created_at":"2018-02-06T20:14:06Z","updated_at":"2018-02-06T20:14:07Z","html_url":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14#discussion_r166429451","pull_request_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/comments/166429451"},"html":{"href":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14#discussion_r166429451"},"pull_request":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14"}},"in_reply_to_id":166427230},"pull_request":{"url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14","id":167512840,"html_url":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14","diff_url":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14.diff","patch_url":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14.patch","issue_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/14","number":14,"state":"open","locked":false,"title":"Add support for new vibe-core vibed driver v2","user":{"login":"Kozzi11","id":1239642,"avatar_url":"https://avatars0.githubusercontent.com/u/1239642?v=4","gravatar_id":"","url":"https://api.github.com/users/Kozzi11","html_url":"https://github.com/Kozzi11","followers_url":"https://api.github.com/users/Kozzi11/followers","following_url":"https://api.github.com/users/Kozzi11/following{/other_user}","gists_url":"https://api.github.com/users/Kozzi11/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozzi11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozzi11/subscriptions","organizations_url":"https://api.github.com/users/Kozzi11/orgs","repos_url":"https://api.github.com/users/Kozzi11/repos","events_url":"https://api.github.com/users/Kozzi11/events{/privacy}","received_events_url":"https://api.github.com/users/Kozzi11/received_events","type":"User","site_admin":false},"body":"This one takes another aproach, so it still uses default soucket type","created_at":"2018-02-06T19:50:34Z","updated_at":"2018-02-06T20:14:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3565571d621d0906e71de6cb4b80f9604477a901","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14/commits","review_comments_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14/comments","review_comment_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/14/comments","statuses_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/statuses/14564b7bcbc55cf2dcb2a5d958ee2ccd6726ec80","head":{"label":"Kozzi11:vibe_core_support_2","ref":"vibe_core_support_2","sha":"14564b7bcbc55cf2dcb2a5d958ee2ccd6726ec80","user":{"login":"Kozzi11","id":1239642,"avatar_url":"https://avatars0.githubusercontent.com/u/1239642?v=4","gravatar_id":"","url":"https://api.github.com/users/Kozzi11","html_url":"https://github.com/Kozzi11","followers_url":"https://api.github.com/users/Kozzi11/followers","following_url":"https://api.github.com/users/Kozzi11/following{/other_user}","gists_url":"https://api.github.com/users/Kozzi11/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozzi11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozzi11/subscriptions","organizations_url":"https://api.github.com/users/Kozzi11/orgs","repos_url":"https://api.github.com/users/Kozzi11/repos","events_url":"https://api.github.com/users/Kozzi11/events{/privacy}","received_events_url":"https://api.github.com/users/Kozzi11/received_events","type":"User","site_admin":false},"repo":{"id":116582258,"name":"vibe.d.db.postgresql","full_name":"Kozzi11/vibe.d.db.postgresql","owner":{"login":"Kozzi11","id":1239642,"avatar_url":"https://avatars0.githubusercontent.com/u/1239642?v=4","gravatar_id":"","url":"https://api.github.com/users/Kozzi11","html_url":"https://github.com/Kozzi11","followers_url":"https://api.github.com/users/Kozzi11/followers","following_url":"https://api.github.com/users/Kozzi11/following{/other_user}","gists_url":"https://api.github.com/users/Kozzi11/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozzi11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozzi11/subscriptions","organizations_url":"https://api.github.com/users/Kozzi11/orgs","repos_url":"https://api.github.com/users/Kozzi11/repos","events_url":"https://api.github.com/users/Kozzi11/events{/privacy}","received_events_url":"https://api.github.com/users/Kozzi11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kozzi11/vibe.d.db.postgresql","description":"PostgreSQL support for Vibe.d","fork":true,"url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql","forks_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/forks","keys_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/teams","hooks_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/hooks","issue_events_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/issues/events{/number}","events_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/events","assignees_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/assignees{/user}","branches_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/branches{/branch}","tags_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/tags","blobs_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/statuses/{sha}","languages_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/languages","stargazers_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/stargazers","contributors_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/contributors","subscribers_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/subscribers","subscription_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/subscription","commits_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/contents/{+path}","compare_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/merges","archive_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/downloads","issues_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/issues{/number}","pulls_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/pulls{/number}","milestones_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/milestones{/number}","notifications_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/labels{/name}","releases_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/releases{/id}","deployments_url":"https://api.github.com/repos/Kozzi11/vibe.d.db.postgresql/deployments","created_at":"2018-01-07T16:47:45Z","updated_at":"2018-01-07T16:47:47Z","pushed_at":"2018-02-06T19:49:15Z","git_url":"git://github.com/Kozzi11/vibe.d.db.postgresql.git","ssh_url":"git@github.com:Kozzi11/vibe.d.db.postgresql.git","clone_url":"https://github.com/Kozzi11/vibe.d.db.postgresql.git","svn_url":"https://github.com/Kozzi11/vibe.d.db.postgresql","homepage":"","size":125,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"denizzzka:master","ref":"master","sha":"63568d3e80581486d6f59c6962e459b5d59ddd95","user":{"login":"denizzzka","id":974632,"avatar_url":"https://avatars2.githubusercontent.com/u/974632?v=4","gravatar_id":"","url":"https://api.github.com/users/denizzzka","html_url":"https://github.com/denizzzka","followers_url":"https://api.github.com/users/denizzzka/followers","following_url":"https://api.github.com/users/denizzzka/following{/other_user}","gists_url":"https://api.github.com/users/denizzzka/gists{/gist_id}","starred_url":"https://api.github.com/users/denizzzka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denizzzka/subscriptions","organizations_url":"https://api.github.com/users/denizzzka/orgs","repos_url":"https://api.github.com/users/denizzzka/repos","events_url":"https://api.github.com/users/denizzzka/events{/privacy}","received_events_url":"https://api.github.com/users/denizzzka/received_events","type":"User","site_admin":false},"repo":{"id":51613141,"name":"vibe.d.db.postgresql","full_name":"denizzzka/vibe.d.db.postgresql","owner":{"login":"denizzzka","id":974632,"avatar_url":"https://avatars2.githubusercontent.com/u/974632?v=4","gravatar_id":"","url":"https://api.github.com/users/denizzzka","html_url":"https://github.com/denizzzka","followers_url":"https://api.github.com/users/denizzzka/followers","following_url":"https://api.github.com/users/denizzzka/following{/other_user}","gists_url":"https://api.github.com/users/denizzzka/gists{/gist_id}","starred_url":"https://api.github.com/users/denizzzka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denizzzka/subscriptions","organizations_url":"https://api.github.com/users/denizzzka/orgs","repos_url":"https://api.github.com/users/denizzzka/repos","events_url":"https://api.github.com/users/denizzzka/events{/privacy}","received_events_url":"https://api.github.com/users/denizzzka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denizzzka/vibe.d.db.postgresql","description":"PostgreSQL support for Vibe.d","fork":false,"url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql","forks_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/forks","keys_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/teams","hooks_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/hooks","issue_events_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/events{/number}","events_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/events","assignees_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/assignees{/user}","branches_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/branches{/branch}","tags_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/tags","blobs_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/git/refs{/sha}","trees_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/statuses/{sha}","languages_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/languages","stargazers_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/stargazers","contributors_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/contributors","subscribers_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/subscribers","subscription_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/subscription","commits_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/commits{/sha}","git_commits_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/git/commits{/sha}","comments_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/comments{/number}","issue_comment_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/comments{/number}","contents_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/contents/{+path}","compare_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/merges","archive_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/downloads","issues_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues{/number}","pulls_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls{/number}","milestones_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/milestones{/number}","notifications_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/labels{/name}","releases_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/releases{/id}","deployments_url":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/deployments","created_at":"2016-02-12T20:03:09Z","updated_at":"2017-09-01T01:14:16Z","pushed_at":"2018-02-06T19:50:35Z","git_url":"git://github.com/denizzzka/vibe.d.db.postgresql.git","ssh_url":"git@github.com:denizzzka/vibe.d.db.postgresql.git","clone_url":"https://github.com/denizzzka/vibe.d.db.postgresql.git","svn_url":"https://github.com/denizzzka/vibe.d.db.postgresql","homepage":"","size":125,"stargazers_count":10,"watchers_count":10,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14"},"html":{"href":"https://github.com/denizzzka/vibe.d.db.postgresql/pull/14"},"issue":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/14"},"comments":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/denizzzka/vibe.d.db.postgresql/statuses/14564b7bcbc55cf2dcb2a5d958ee2ccd6726ec80"}},"author_association":"NONE"}}
{"actor":{"display_login":"Kozzi11"}}