{"action":"opened","number":367,"pull_request":{"url":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367","id":216387004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Mzg3MDA0","html_url":"https://github.com/great-expectations/great_expectations/pull/367","diff_url":"https://github.com/great-expectations/great_expectations/pull/367.diff","patch_url":"https://github.com/great-expectations/great_expectations/pull/367.patch","issue_url":"https://api.github.com/repos/great-expectations/great_expectations/issues/367","number":367,"state":"open","locked":false,"title":"Ensure that map expectations can be run on categorical columns","user":{"login":"eugmandel","id":80363,"node_id":"MDQ6VXNlcjgwMzYz","avatar_url":"https://avatars2.githubusercontent.com/u/80363?v=4","gravatar_id":"","url":"https://api.github.com/users/eugmandel","html_url":"https://github.com/eugmandel","followers_url":"https://api.github.com/users/eugmandel/followers","following_url":"https://api.github.com/users/eugmandel/following{/other_user}","gists_url":"https://api.github.com/users/eugmandel/gists{/gist_id}","starred_url":"https://api.github.com/users/eugmandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugmandel/subscriptions","organizations_url":"https://api.github.com/users/eugmandel/orgs","repos_url":"https://api.github.com/users/eugmandel/repos","events_url":"https://api.github.com/users/eugmandel/events{/privacy}","received_events_url":"https://api.github.com/users/eugmandel/received_events","type":"User","site_admin":false},"body":"Converting object columns to categorical in Pandas dataframes(when possible) shrinks the dataframe's memory footprint and somewhat speeds us operations on these columns.\r\n\r\nWithout this fix validation on dataframes with categorical columns throws an exception in column_map_expectation method of pandas_dataset.py when computing success_count, since numpy refuses to perform sum on a categorical column.\r\n\r\nThis change is just one line - changing the way success_count is computed in a way that works with categorical columns.\r\n","created_at":"2018-09-18T17:33:52Z","updated_at":"2018-09-18T17:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367/commits","review_comments_url":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367/comments","review_comment_url":"https://api.github.com/repos/great-expectations/great_expectations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/great-expectations/great_expectations/issues/367/comments","statuses_url":"https://api.github.com/repos/great-expectations/great_expectations/statuses/9a5aa9f917adb853fe1adcdfdb53d3b08542dbb8","head":{"label":"eugmandel:develop","ref":"develop","sha":"9a5aa9f917adb853fe1adcdfdb53d3b08542dbb8","user":{"login":"eugmandel","id":80363,"node_id":"MDQ6VXNlcjgwMzYz","avatar_url":"https://avatars2.githubusercontent.com/u/80363?v=4","gravatar_id":"","url":"https://api.github.com/users/eugmandel","html_url":"https://github.com/eugmandel","followers_url":"https://api.github.com/users/eugmandel/followers","following_url":"https://api.github.com/users/eugmandel/following{/other_user}","gists_url":"https://api.github.com/users/eugmandel/gists{/gist_id}","starred_url":"https://api.github.com/users/eugmandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugmandel/subscriptions","organizations_url":"https://api.github.com/users/eugmandel/orgs","repos_url":"https://api.github.com/users/eugmandel/repos","events_url":"https://api.github.com/users/eugmandel/events{/privacy}","received_events_url":"https://api.github.com/users/eugmandel/received_events","type":"User","site_admin":false},"repo":{"id":149314635,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzMTQ2MzU=","name":"great_expectations","full_name":"eugmandel/great_expectations","private":false,"owner":{"login":"eugmandel","id":80363,"node_id":"MDQ6VXNlcjgwMzYz","avatar_url":"https://avatars2.githubusercontent.com/u/80363?v=4","gravatar_id":"","url":"https://api.github.com/users/eugmandel","html_url":"https://github.com/eugmandel","followers_url":"https://api.github.com/users/eugmandel/followers","following_url":"https://api.github.com/users/eugmandel/following{/other_user}","gists_url":"https://api.github.com/users/eugmandel/gists{/gist_id}","starred_url":"https://api.github.com/users/eugmandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugmandel/subscriptions","organizations_url":"https://api.github.com/users/eugmandel/orgs","repos_url":"https://api.github.com/users/eugmandel/repos","events_url":"https://api.github.com/users/eugmandel/events{/privacy}","received_events_url":"https://api.github.com/users/eugmandel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eugmandel/great_expectations","description":"Always know what to expect from your data.","fork":true,"url":"https://api.github.com/repos/eugmandel/great_expectations","forks_url":"https://api.github.com/repos/eugmandel/great_expectations/forks","keys_url":"https://api.github.com/repos/eugmandel/great_expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eugmandel/great_expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eugmandel/great_expectations/teams","hooks_url":"https://api.github.com/repos/eugmandel/great_expectations/hooks","issue_events_url":"https://api.github.com/repos/eugmandel/great_expectations/issues/events{/number}","events_url":"https://api.github.com/repos/eugmandel/great_expectations/events","assignees_url":"https://api.github.com/repos/eugmandel/great_expectations/assignees{/user}","branches_url":"https://api.github.com/repos/eugmandel/great_expectations/branches{/branch}","tags_url":"https://api.github.com/repos/eugmandel/great_expectations/tags","blobs_url":"https://api.github.com/repos/eugmandel/great_expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eugmandel/great_expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eugmandel/great_expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/eugmandel/great_expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eugmandel/great_expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/eugmandel/great_expectations/languages","stargazers_url":"https://api.github.com/repos/eugmandel/great_expectations/stargazers","contributors_url":"https://api.github.com/repos/eugmandel/great_expectations/contributors","subscribers_url":"https://api.github.com/repos/eugmandel/great_expectations/subscribers","subscription_url":"https://api.github.com/repos/eugmandel/great_expectations/subscription","commits_url":"https://api.github.com/repos/eugmandel/great_expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/eugmandel/great_expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/eugmandel/great_expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/eugmandel/great_expectations/issues/comments{/number}","contents_url":"https://api.github.com/repos/eugmandel/great_expectations/contents/{+path}","compare_url":"https://api.github.com/repos/eugmandel/great_expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eugmandel/great_expectations/merges","archive_url":"https://api.github.com/repos/eugmandel/great_expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eugmandel/great_expectations/downloads","issues_url":"https://api.github.com/repos/eugmandel/great_expectations/issues{/number}","pulls_url":"https://api.github.com/repos/eugmandel/great_expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/eugmandel/great_expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/eugmandel/great_expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eugmandel/great_expectations/labels{/name}","releases_url":"https://api.github.com/repos/eugmandel/great_expectations/releases{/id}","deployments_url":"https://api.github.com/repos/eugmandel/great_expectations/deployments","created_at":"2018-09-18T15:54:07Z","updated_at":"2018-09-18T17:26:38Z","pushed_at":"2018-09-18T17:26:37Z","git_url":"git://github.com/eugmandel/great_expectations.git","ssh_url":"git@github.com:eugmandel/great_expectations.git","clone_url":"https://github.com/eugmandel/great_expectations.git","svn_url":"https://github.com/eugmandel/great_expectations","homepage":"http://readthedocs.org/projects/great-expectations/","size":5951,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"great-expectations:develop","ref":"develop","sha":"09825981550220bfc7229bd66e347703ce8744c3","user":{"login":"great-expectations","id":31670619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjcwNjE5","avatar_url":"https://avatars0.githubusercontent.com/u/31670619?v=4","gravatar_id":"","url":"https://api.github.com/users/great-expectations","html_url":"https://github.com/great-expectations","followers_url":"https://api.github.com/users/great-expectations/followers","following_url":"https://api.github.com/users/great-expectations/following{/other_user}","gists_url":"https://api.github.com/users/great-expectations/gists{/gist_id}","starred_url":"https://api.github.com/users/great-expectations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/great-expectations/subscriptions","organizations_url":"https://api.github.com/users/great-expectations/orgs","repos_url":"https://api.github.com/users/great-expectations/repos","events_url":"https://api.github.com/users/great-expectations/events{/privacy}","received_events_url":"https://api.github.com/users/great-expectations/received_events","type":"Organization","site_admin":false},"repo":{"id":103071520,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMwNzE1MjA=","name":"great_expectations","full_name":"great-expectations/great_expectations","private":false,"owner":{"login":"great-expectations","id":31670619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjcwNjE5","avatar_url":"https://avatars0.githubusercontent.com/u/31670619?v=4","gravatar_id":"","url":"https://api.github.com/users/great-expectations","html_url":"https://github.com/great-expectations","followers_url":"https://api.github.com/users/great-expectations/followers","following_url":"https://api.github.com/users/great-expectations/following{/other_user}","gists_url":"https://api.github.com/users/great-expectations/gists{/gist_id}","starred_url":"https://api.github.com/users/great-expectations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/great-expectations/subscriptions","organizations_url":"https://api.github.com/users/great-expectations/orgs","repos_url":"https://api.github.com/users/great-expectations/repos","events_url":"https://api.github.com/users/great-expectations/events{/privacy}","received_events_url":"https://api.github.com/users/great-expectations/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/great-expectations/great_expectations","description":"Always know what to expect from your data.","fork":false,"url":"https://api.github.com/repos/great-expectations/great_expectations","forks_url":"https://api.github.com/repos/great-expectations/great_expectations/forks","keys_url":"https://api.github.com/repos/great-expectations/great_expectations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/great-expectations/great_expectations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/great-expectations/great_expectations/teams","hooks_url":"https://api.github.com/repos/great-expectations/great_expectations/hooks","issue_events_url":"https://api.github.com/repos/great-expectations/great_expectations/issues/events{/number}","events_url":"https://api.github.com/repos/great-expectations/great_expectations/events","assignees_url":"https://api.github.com/repos/great-expectations/great_expectations/assignees{/user}","branches_url":"https://api.github.com/repos/great-expectations/great_expectations/branches{/branch}","tags_url":"https://api.github.com/repos/great-expectations/great_expectations/tags","blobs_url":"https://api.github.com/repos/great-expectations/great_expectations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/great-expectations/great_expectations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/great-expectations/great_expectations/git/refs{/sha}","trees_url":"https://api.github.com/repos/great-expectations/great_expectations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/great-expectations/great_expectations/statuses/{sha}","languages_url":"https://api.github.com/repos/great-expectations/great_expectations/languages","stargazers_url":"https://api.github.com/repos/great-expectations/great_expectations/stargazers","contributors_url":"https://api.github.com/repos/great-expectations/great_expectations/contributors","subscribers_url":"https://api.github.com/repos/great-expectations/great_expectations/subscribers","subscription_url":"https://api.github.com/repos/great-expectations/great_expectations/subscription","commits_url":"https://api.github.com/repos/great-expectations/great_expectations/commits{/sha}","git_commits_url":"https://api.github.com/repos/great-expectations/great_expectations/git/commits{/sha}","comments_url":"https://api.github.com/repos/great-expectations/great_expectations/comments{/number}","issue_comment_url":"https://api.github.com/repos/great-expectations/great_expectations/issues/comments{/number}","contents_url":"https://api.github.com/repos/great-expectations/great_expectations/contents/{+path}","compare_url":"https://api.github.com/repos/great-expectations/great_expectations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/great-expectations/great_expectations/merges","archive_url":"https://api.github.com/repos/great-expectations/great_expectations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/great-expectations/great_expectations/downloads","issues_url":"https://api.github.com/repos/great-expectations/great_expectations/issues{/number}","pulls_url":"https://api.github.com/repos/great-expectations/great_expectations/pulls{/number}","milestones_url":"https://api.github.com/repos/great-expectations/great_expectations/milestones{/number}","notifications_url":"https://api.github.com/repos/great-expectations/great_expectations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/great-expectations/great_expectations/labels{/name}","releases_url":"https://api.github.com/repos/great-expectations/great_expectations/releases{/id}","deployments_url":"https://api.github.com/repos/great-expectations/great_expectations/deployments","created_at":"2017-09-11T00:18:46Z","updated_at":"2018-09-18T15:29:52Z","pushed_at":"2018-09-18T16:32:01Z","git_url":"git://github.com/great-expectations/great_expectations.git","ssh_url":"git@github.com:great-expectations/great_expectations.git","clone_url":"https://github.com/great-expectations/great_expectations.git","svn_url":"https://github.com/great-expectations/great_expectations","homepage":"http://readthedocs.org/projects/great-expectations/","size":5979,"stargazers_count":313,"watchers_count":313,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":47,"watchers":313,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367"},"html":{"href":"https://github.com/great-expectations/great_expectations/pull/367"},"issue":{"href":"https://api.github.com/repos/great-expectations/great_expectations/issues/367"},"comments":{"href":"https://api.github.com/repos/great-expectations/great_expectations/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/great-expectations/great_expectations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/great-expectations/great_expectations/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/great-expectations/great_expectations/statuses/9a5aa9f917adb853fe1adcdfdb53d3b08542dbb8"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"eugmandel"}}