{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/221887770","pull_request_review_id":160642411,"id":221887770,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg4Nzc3MA==","diff_hunk":"@@ -57,17 +61,27 @@\n import java.util.concurrent.atomic.AtomicReference;\n import java.util.stream.Collectors;\n \n+import static junit.framework.TestCase.assertEquals;\n+import static junit.framework.TestCase.fail;\n+\n /**\n  * Tests for the parameter handling of the {@link JarRunHandler}.\n  */\n public class JarRunHandlerParameterTest extends TestLogger {","path":"flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java","position":35,"original_position":35,"commit_id":"639b03cc4526ec9b9db7eba706fe3c9819499220","original_commit_id":"639b03cc4526ec9b9db7eba706fe3c9819499220","user":{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"A similar test is required for the `JarPlanHandler`.","created_at":"2018-10-02T09:47:49Z","updated_at":"2018-10-02T09:54:02Z","html_url":"https://github.com/apache/flink/pull/6754#discussion_r221887770","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/221887770"},"html":{"href":"https://github.com/apache/flink/pull/6754#discussion_r221887770"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6754"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6754","id":217721479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzIxNDc5","html_url":"https://github.com/apache/flink/pull/6754","diff_url":"https://github.com/apache/flink/pull/6754.diff","patch_url":"https://github.com/apache/flink/pull/6754.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6754","number":6754,"state":"open","locked":false,"title":"[FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API","user":{"login":"azagrebin","id":10573485,"node_id":"MDQ6VXNlcjEwNTczNDg1","avatar_url":"https://avatars3.githubusercontent.com/u/10573485?v=4","gravatar_id":"","url":"https://api.github.com/users/azagrebin","html_url":"https://github.com/azagrebin","followers_url":"https://api.github.com/users/azagrebin/followers","following_url":"https://api.github.com/users/azagrebin/following{/other_user}","gists_url":"https://api.github.com/users/azagrebin/gists{/gist_id}","starred_url":"https://api.github.com/users/azagrebin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azagrebin/subscriptions","organizations_url":"https://api.github.com/users/azagrebin/orgs","repos_url":"https://api.github.com/users/azagrebin/repos","events_url":"https://api.github.com/users/azagrebin/events{/privacy}","received_events_url":"https://api.github.com/users/azagrebin/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR add one more option to specify jar program arguments in REST API calls (run and get plan). Users can specify arguments as one string or additionally mow as a list of a separate strings.\r\n\r\n## Brief change log\r\n\r\n  - add JarRequestBody as a base for JarRunRequestBody and JarPlanRequestBody\r\n  - add programArgsList to JarRequestBody\r\n  - add JarHandlerUtils.getProgramArgs to resolve program args from programArgs and programArgsList from query path or json body in JarRunHandler or JarPlanHandler\r\n  - user can use programArgs or programArgsList but not both, add test for it\r\n\r\n## Verifying this change\r\n\r\nUnit tests\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes)\r\n  - If yes, how is the feature documented? (docs)\r\n","created_at":"2018-09-24T16:51:34Z","updated_at":"2018-10-02T09:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c88a2915cc9ff32db5c602d966111af53830e406","assignee":{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"assignees":[{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6754/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6754/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6754/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/639b03cc4526ec9b9db7eba706fe3c9819499220","head":{"label":"azagrebin:FLINK-10295","ref":"FLINK-10295","sha":"639b03cc4526ec9b9db7eba706fe3c9819499220","user":{"login":"azagrebin","id":10573485,"node_id":"MDQ6VXNlcjEwNTczNDg1","avatar_url":"https://avatars3.githubusercontent.com/u/10573485?v=4","gravatar_id":"","url":"https://api.github.com/users/azagrebin","html_url":"https://github.com/azagrebin","followers_url":"https://api.github.com/users/azagrebin/followers","following_url":"https://api.github.com/users/azagrebin/following{/other_user}","gists_url":"https://api.github.com/users/azagrebin/gists{/gist_id}","starred_url":"https://api.github.com/users/azagrebin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azagrebin/subscriptions","organizations_url":"https://api.github.com/users/azagrebin/orgs","repos_url":"https://api.github.com/users/azagrebin/repos","events_url":"https://api.github.com/users/azagrebin/events{/privacy}","received_events_url":"https://api.github.com/users/azagrebin/received_events","type":"User","site_admin":false},"repo":{"id":127914721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5MTQ3MjE=","name":"flink","full_name":"azagrebin/flink","private":false,"owner":{"login":"azagrebin","id":10573485,"node_id":"MDQ6VXNlcjEwNTczNDg1","avatar_url":"https://avatars3.githubusercontent.com/u/10573485?v=4","gravatar_id":"","url":"https://api.github.com/users/azagrebin","html_url":"https://github.com/azagrebin","followers_url":"https://api.github.com/users/azagrebin/followers","following_url":"https://api.github.com/users/azagrebin/following{/other_user}","gists_url":"https://api.github.com/users/azagrebin/gists{/gist_id}","starred_url":"https://api.github.com/users/azagrebin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azagrebin/subscriptions","organizations_url":"https://api.github.com/users/azagrebin/orgs","repos_url":"https://api.github.com/users/azagrebin/repos","events_url":"https://api.github.com/users/azagrebin/events{/privacy}","received_events_url":"https://api.github.com/users/azagrebin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/azagrebin/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/azagrebin/flink","forks_url":"https://api.github.com/repos/azagrebin/flink/forks","keys_url":"https://api.github.com/repos/azagrebin/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azagrebin/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azagrebin/flink/teams","hooks_url":"https://api.github.com/repos/azagrebin/flink/hooks","issue_events_url":"https://api.github.com/repos/azagrebin/flink/issues/events{/number}","events_url":"https://api.github.com/repos/azagrebin/flink/events","assignees_url":"https://api.github.com/repos/azagrebin/flink/assignees{/user}","branches_url":"https://api.github.com/repos/azagrebin/flink/branches{/branch}","tags_url":"https://api.github.com/repos/azagrebin/flink/tags","blobs_url":"https://api.github.com/repos/azagrebin/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azagrebin/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azagrebin/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/azagrebin/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azagrebin/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/azagrebin/flink/languages","stargazers_url":"https://api.github.com/repos/azagrebin/flink/stargazers","contributors_url":"https://api.github.com/repos/azagrebin/flink/contributors","subscribers_url":"https://api.github.com/repos/azagrebin/flink/subscribers","subscription_url":"https://api.github.com/repos/azagrebin/flink/subscription","commits_url":"https://api.github.com/repos/azagrebin/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/azagrebin/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/azagrebin/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/azagrebin/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/azagrebin/flink/contents/{+path}","compare_url":"https://api.github.com/repos/azagrebin/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azagrebin/flink/merges","archive_url":"https://api.github.com/repos/azagrebin/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azagrebin/flink/downloads","issues_url":"https://api.github.com/repos/azagrebin/flink/issues{/number}","pulls_url":"https://api.github.com/repos/azagrebin/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/azagrebin/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/azagrebin/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azagrebin/flink/labels{/name}","releases_url":"https://api.github.com/repos/azagrebin/flink/releases{/id}","deployments_url":"https://api.github.com/repos/azagrebin/flink/deployments","created_at":"2018-04-03T13:44:01Z","updated_at":"2018-05-08T13:09:18Z","pushed_at":"2018-10-02T09:12:10Z","git_url":"git://github.com/azagrebin/flink.git","ssh_url":"git@github.com:azagrebin/flink.git","clone_url":"https://github.com/azagrebin/flink.git","svn_url":"https://github.com/azagrebin/flink","homepage":null,"size":163857,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c6b83772f070761fc9c0b69d6d82961a515772c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-10-02T09:38:42Z","pushed_at":"2018-10-02T09:52:43Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":166026,"stargazers_count":4520,"watchers_count":4520,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2935,"mirror_url":null,"archived":false,"open_issues_count":397,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2935,"open_issues":397,"watchers":4520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6754"},"html":{"href":"https://github.com/apache/flink/pull/6754"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6754"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6754/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6754/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6754/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/639b03cc4526ec9b9db7eba706fe3c9819499220"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zentol"}}