{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/198588485","pull_request_review_id":132544823,"id":198588485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODU4ODQ4NQ==","diff_hunk":"@@ -341,6 +359,12 @@ int net_context_put(struct net_context *context)\n \t\treturn 0;\n \t}\n \n+#if defined(CONFIG_NET_TLS) || defined(CONFIG_NET_DTLS)\n+\tif (context->tls) {","path":"subsys/net/ip/net_context.c","position":44,"original_position":44,"commit_id":"18e80dac32cb90a6c32669d2a3583dd209f0af60","original_commit_id":"18e80dac32cb90a6c32669d2a3583dd209f0af60","user":{"login":"pfalcon","id":500451,"node_id":"MDQ6VXNlcjUwMDQ1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"What will finalize TLS structures for normally-closed TCP connection (one for which net_tcp_put() returns 0)?\r\n\r\nThis looks like a serious mistake (worth -1 on its own).\r\n","created_at":"2018-06-27T18:00:56Z","updated_at":"2018-06-27T18:00:57Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7118#discussion_r198588485","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/198588485"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/7118#discussion_r198588485"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118","id":182695855,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNjk1ODU1","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7118","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7118.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/7118.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7118","number":7118,"state":"open","locked":false,"title":"Zephyr TLS socket options","user":{"login":"pfl","id":1098363,"node_id":"MDQ6VXNlcjEwOTgzNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1098363?v=4","gravatar_id":"","url":"https://api.github.com/users/pfl","html_url":"https://github.com/pfl","followers_url":"https://api.github.com/users/pfl/followers","following_url":"https://api.github.com/users/pfl/following{/other_user}","gists_url":"https://api.github.com/users/pfl/gists{/gist_id}","starred_url":"https://api.github.com/users/pfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfl/subscriptions","organizations_url":"https://api.github.com/users/pfl/orgs","repos_url":"https://api.github.com/users/pfl/repos","events_url":"https://api.github.com/users/pfl/events{/privacy}","received_events_url":"https://api.github.com/users/pfl/received_events","type":"User","site_admin":false},"body":"Initial idea of an TLS setsockopt for Zephyr sockets. See #5985.\r\n\r\nThis pull request is not to be taken literally as mbedTLS is not connected to the implementation yet, but the test case (function call that succeeds) is what I had in mind initially.","created_at":"2018-04-19T08:05:44Z","updated_at":"2018-06-27T18:00:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8514afadc2baeff28cec9e6ca921cfc36b7e392f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"tbursztyka","id":1608406,"node_id":"MDQ6VXNlcjE2MDg0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":700751655,"node_id":"MDU6TGFiZWw3MDA3NTE2NTU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Networking","name":"area: Networking","color":"c5def5","default":false},{"id":593979877,"node_id":"MDU6TGFiZWw1OTM5Nzk4Nzc=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/in%20progress","name":"in progress","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7118/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/18e80dac32cb90a6c32669d2a3583dd209f0af60","head":{"label":"pfl:sockopt","ref":"sockopt","sha":"18e80dac32cb90a6c32669d2a3583dd209f0af60","user":{"login":"pfl","id":1098363,"node_id":"MDQ6VXNlcjEwOTgzNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1098363?v=4","gravatar_id":"","url":"https://api.github.com/users/pfl","html_url":"https://github.com/pfl","followers_url":"https://api.github.com/users/pfl/followers","following_url":"https://api.github.com/users/pfl/following{/other_user}","gists_url":"https://api.github.com/users/pfl/gists{/gist_id}","starred_url":"https://api.github.com/users/pfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfl/subscriptions","organizations_url":"https://api.github.com/users/pfl/orgs","repos_url":"https://api.github.com/users/pfl/repos","events_url":"https://api.github.com/users/pfl/events{/privacy}","received_events_url":"https://api.github.com/users/pfl/received_events","type":"User","site_admin":false},"repo":{"id":92043109,"node_id":"MDEwOlJlcG9zaXRvcnk5MjA0MzEwOQ==","name":"zephyr","full_name":"pfl/zephyr","owner":{"login":"pfl","id":1098363,"node_id":"MDQ6VXNlcjEwOTgzNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1098363?v=4","gravatar_id":"","url":"https://api.github.com/users/pfl","html_url":"https://github.com/pfl","followers_url":"https://api.github.com/users/pfl/followers","following_url":"https://api.github.com/users/pfl/following{/other_user}","gists_url":"https://api.github.com/users/pfl/gists{/gist_id}","starred_url":"https://api.github.com/users/pfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfl/subscriptions","organizations_url":"https://api.github.com/users/pfl/orgs","repos_url":"https://api.github.com/users/pfl/repos","events_url":"https://api.github.com/users/pfl/events{/privacy}","received_events_url":"https://api.github.com/users/pfl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfl/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/pfl/zephyr","forks_url":"https://api.github.com/repos/pfl/zephyr/forks","keys_url":"https://api.github.com/repos/pfl/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfl/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfl/zephyr/teams","hooks_url":"https://api.github.com/repos/pfl/zephyr/hooks","issue_events_url":"https://api.github.com/repos/pfl/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/pfl/zephyr/events","assignees_url":"https://api.github.com/repos/pfl/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/pfl/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/pfl/zephyr/tags","blobs_url":"https://api.github.com/repos/pfl/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfl/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfl/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfl/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfl/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/pfl/zephyr/languages","stargazers_url":"https://api.github.com/repos/pfl/zephyr/stargazers","contributors_url":"https://api.github.com/repos/pfl/zephyr/contributors","subscribers_url":"https://api.github.com/repos/pfl/zephyr/subscribers","subscription_url":"https://api.github.com/repos/pfl/zephyr/subscription","commits_url":"https://api.github.com/repos/pfl/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfl/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfl/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfl/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfl/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/pfl/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfl/zephyr/merges","archive_url":"https://api.github.com/repos/pfl/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfl/zephyr/downloads","issues_url":"https://api.github.com/repos/pfl/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/pfl/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/pfl/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/pfl/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfl/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/pfl/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/pfl/zephyr/deployments","created_at":"2017-05-22T10:49:47Z","updated_at":"2017-05-22T10:50:22Z","pushed_at":"2018-06-20T06:07:46Z","git_url":"git://github.com/pfl/zephyr.git","ssh_url":"git@github.com:pfl/zephyr.git","clone_url":"https://github.com/pfl/zephyr.git","svn_url":"https://github.com/pfl/zephyr","homepage":"http://zephyrproject.org/doc","size":112907,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"6f61f098037b9b8b88a80d33814ecec26f112d51","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-06-27T17:36:08Z","pushed_at":"2018-06-27T17:37:48Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":117830,"stargazers_count":920,"watchers_count":920,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":661,"mirror_url":null,"archived":false,"open_issues_count":936,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":661,"open_issues":936,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/7118"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7118"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/7118/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/7118/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/18e80dac32cb90a6c32669d2a3583dd209f0af60"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pfalcon"}}