{"action":"created","comment":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/212059796","pull_request_review_id":148605736,"id":212059796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA1OTc5Ng==","diff_hunk":"@@ -0,0 +1,12 @@\n+.CodeMirror pre.CodeMirror-line {\n+  box-shadow: inset 0 0 0 0px rgba(16, 22, 26, 0.4);\n+  -webkit-box-shadow: inset 0 0 0 0px rgba(16, 22, 26, 0.4);","path":"desktop/cmp/form/JsonField.scss","position":3,"original_position":3,"commit_id":"7038f6aebe42c5a236d159f8fddf22bb87bbeba2","original_commit_id":"7038f6aebe42c5a236d159f8fddf22bb87bbeba2","user":{"login":"amcclain","id":225806,"node_id":"MDQ6VXNlcjIyNTgwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/225806?v=4","gravatar_id":"","url":"https://api.github.com/users/amcclain","html_url":"https://github.com/amcclain","followers_url":"https://api.github.com/users/amcclain/followers","following_url":"https://api.github.com/users/amcclain/following{/other_user}","gists_url":"https://api.github.com/users/amcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/amcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcclain/subscriptions","organizations_url":"https://api.github.com/users/amcclain/orgs","repos_url":"https://api.github.com/users/amcclain/repos","events_url":"https://api.github.com/users/amcclain/events{/privacy}","received_events_url":"https://api.github.com/users/amcclain/received_events","type":"User","site_admin":false},"body":"I know you didn't add these - but what *are* they?","created_at":"2018-08-22T18:26:43Z","updated_at":"2018-08-22T18:31:40Z","html_url":"https://github.com/exhi/hoist-react/pull/552#discussion_r212059796","pull_request_url":"https://api.github.com/repos/exhi/hoist-react/pulls/552","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/212059796"},"html":{"href":"https://github.com/exhi/hoist-react/pull/552#discussion_r212059796"},"pull_request":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/552"}}},"pull_request":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/552","id":209949296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTQ5Mjk2","html_url":"https://github.com/exhi/hoist-react/pull/552","diff_url":"https://github.com/exhi/hoist-react/pull/552.diff","patch_url":"https://github.com/exhi/hoist-react/pull/552.patch","issue_url":"https://api.github.com/repos/exhi/hoist-react/issues/552","number":552,"state":"open","locked":false,"title":"Validation","user":{"login":"haynesjm42","id":9619538,"node_id":"MDQ6VXNlcjk2MTk1Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9619538?v=4","gravatar_id":"","url":"https://api.github.com/users/haynesjm42","html_url":"https://github.com/haynesjm42","followers_url":"https://api.github.com/users/haynesjm42/followers","following_url":"https://api.github.com/users/haynesjm42/following{/other_user}","gists_url":"https://api.github.com/users/haynesjm42/gists{/gist_id}","starred_url":"https://api.github.com/users/haynesjm42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haynesjm42/subscriptions","organizations_url":"https://api.github.com/users/haynesjm42/orgs","repos_url":"https://api.github.com/users/haynesjm42/repos","events_url":"https://api.github.com/users/haynesjm42/events{/privacy}","received_events_url":"https://api.github.com/users/haynesjm42/received_events","type":"User","site_admin":false},"body":"#317 \r\n\r\nSee https://github.com/exhi/toolbox/compare/validation for example usage. It needs some TLC before it can be merged, not very pretty right now and the validations don't all make sense, but useful for testing and demonstrating the usage.\r\n\r\nOne thing I didn't realize at first was that the last commit to the [validate.js repo ](https://github.com/ansman/validate.js) was 9 months ago... not sure if it is completely dead or not, I couldn't find anything saying that it wasn't being maintained any longer. That being said, I think the approach the library takes is very solid and the source looks easily extendable, so a fork is always an option if we need bugs fixed or features added.\r\n\r\nA couple notes on the changes:\r\n* For the invalid styling I added scss files for various HoistField components as needed, though I did consider just adding everything to HoistField.scss to keep things in one place. Happy to change that if we think it's cleaner.\r\n* I added `ValidationService` which handles some necessary init for the date validator so it knows how to parse and format dates. This is also where I would see us adding something like a `registerValidator()` method for apps (or us) to add custom validators, and potentially adding additional wrappers around the validate.js apis.","created_at":"2018-08-21T20:39:43Z","updated_at":"2018-08-22T18:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f4ea2bbb467ff86cf9204a3d5a524a1cdbd98da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exhi/hoist-react/pulls/552/commits","review_comments_url":"https://api.github.com/repos/exhi/hoist-react/pulls/552/comments","review_comment_url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exhi/hoist-react/issues/552/comments","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/7038f6aebe42c5a236d159f8fddf22bb87bbeba2","head":{"label":"exhi:validation","ref":"validation","sha":"7038f6aebe42c5a236d159f8fddf22bb87bbeba2","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-08-22T16:18:06Z","pushed_at":"2018-08-22T16:52:40Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":1834,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":31,"watchers":3,"default_branch":"develop"}},"base":{"label":"exhi:develop","ref":"develop","sha":"f1129b0672a7050432a65aa8037a4e9742d83f52","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-08-22T16:18:06Z","pushed_at":"2018-08-22T16:52:40Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":1834,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":31,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/552"},"html":{"href":"https://github.com/exhi/hoist-react/pull/552"},"issue":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/552"},"comments":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/exhi/hoist-react/statuses/7038f6aebe42c5a236d159f8fddf22bb87bbeba2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amcclain"}}