{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity/pulls/comments/186256996","pull_request_review_id":117808451,"id":186256996,"diff_hunk":"@@ -478,7 +484,8 @@ impl Account {\n \n \t\tlet trie = TrieDB::new(db, &self.storage_root)?;\n \t\tlet item: U256 = {\n-\t\t\tlet query = (&mut recorder, ::rlp::decode);\n+\t\t\tlet unwrapping_decoder = |bytes:&[u8]| ::rlp::decode(bytes).unwrap_or_else(|_| U256::zero() );","path":"ethcore/src/state/account.rs","position":33,"original_position":33,"commit_id":"ea4a6d2a7c42599430b9c9ad2860bef26f2d22f4","original_commit_id":"ea4a6d2a7c42599430b9c9ad2860bef26f2d22f4","user":{"login":"debris","id":2613714,"avatar_url":"https://avatars2.githubusercontent.com/u/2613714?v=4","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"body":"same here :)","created_at":"2018-05-05T08:55:47Z","updated_at":"2018-05-05T09:00:10Z","html_url":"https://github.com/paritytech/parity/pull/8527#discussion_r186256996","pull_request_url":"https://api.github.com/repos/paritytech/parity/pulls/8527","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments/186256996"},"html":{"href":"https://github.com/paritytech/parity/pull/8527#discussion_r186256996"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity/pulls/8527"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity/pulls/8527","id":185364630,"html_url":"https://github.com/paritytech/parity/pull/8527","diff_url":"https://github.com/paritytech/parity/pull/8527.diff","patch_url":"https://github.com/paritytech/parity/pull/8527.patch","issue_url":"https://api.github.com/repos/paritytech/parity/issues/8527","number":8527,"state":"open","locked":false,"title":"Rlp decode returns Result","user":{"login":"dvdplm","id":18515,"avatar_url":"https://avatars2.githubusercontent.com/u/18515?v=4","gravatar_id":"","url":"https://api.github.com/users/dvdplm","html_url":"https://github.com/dvdplm","followers_url":"https://api.github.com/users/dvdplm/followers","following_url":"https://api.github.com/users/dvdplm/following{/other_user}","gists_url":"https://api.github.com/users/dvdplm/gists{/gist_id}","starred_url":"https://api.github.com/users/dvdplm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvdplm/subscriptions","organizations_url":"https://api.github.com/users/dvdplm/orgs","repos_url":"https://api.github.com/users/dvdplm/repos","events_url":"https://api.github.com/users/dvdplm/events{/privacy}","received_events_url":"https://api.github.com/users/dvdplm/received_events","type":"User","site_admin":false},"body":"Part of the fix for issue #8033. The change of return types have a great many consequences on a lot of code and sometimes it is difficult to know what the right thing to do is when decoding fails, so careful review is important here. This is also my first PR on the code base, so pushing this early to collect feedback: is this roughly the right direction?","created_at":"2018-05-02T08:13:32Z","updated_at":"2018-05-05T09:00:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4159735e51a231a675f86931f780c93fd93c1a2","assignee":{"login":"dvdplm","id":18515,"avatar_url":"https://avatars2.githubusercontent.com/u/18515?v=4","gravatar_id":"","url":"https://api.github.com/users/dvdplm","html_url":"https://github.com/dvdplm","followers_url":"https://api.github.com/users/dvdplm/followers","following_url":"https://api.github.com/users/dvdplm/following{/other_user}","gists_url":"https://api.github.com/users/dvdplm/gists{/gist_id}","starred_url":"https://api.github.com/users/dvdplm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvdplm/subscriptions","organizations_url":"https://api.github.com/users/dvdplm/orgs","repos_url":"https://api.github.com/users/dvdplm/repos","events_url":"https://api.github.com/users/dvdplm/events{/privacy}","received_events_url":"https://api.github.com/users/dvdplm/received_events","type":"User","site_admin":false},"assignees":[{"login":"dvdplm","id":18515,"avatar_url":"https://avatars2.githubusercontent.com/u/18515?v=4","gravatar_id":"","url":"https://api.github.com/users/dvdplm","html_url":"https://github.com/dvdplm","followers_url":"https://api.github.com/users/dvdplm/followers","following_url":"https://api.github.com/users/dvdplm/following{/other_user}","gists_url":"https://api.github.com/users/dvdplm/gists{/gist_id}","starred_url":"https://api.github.com/users/dvdplm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvdplm/subscriptions","organizations_url":"https://api.github.com/users/dvdplm/orgs","repos_url":"https://api.github.com/users/dvdplm/repos","events_url":"https://api.github.com/users/dvdplm/events{/privacy}","received_events_url":"https://api.github.com/users/dvdplm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":309708284,"url":"https://api.github.com/repos/paritytech/parity/labels/A4-gotissues","name":"A4-gotissues","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity/pulls/8527/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity/pulls/8527/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity/issues/8527/comments","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/ea4a6d2a7c42599430b9c9ad2860bef26f2d22f4","head":{"label":"paritytech:fix/rlp-decode-returns-result-issue-8033","ref":"fix/rlp-decode-returns-result-issue-8033","sha":"ea4a6d2a7c42599430b9c9ad2860bef26f2d22f4","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation.","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-05-05T08:23:59Z","pushed_at":"2018-05-05T08:23:52Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"https://parity.io","size":50776,"stargazers_count":4155,"watchers_count":4155,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":822,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":822,"open_issues":317,"watchers":4155,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"b10094508f3a149830199ed35ea5ad7850a43603","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation.","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-05-05T08:23:59Z","pushed_at":"2018-05-05T08:23:52Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"https://parity.io","size":50776,"stargazers_count":4155,"watchers_count":4155,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":822,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":822,"open_issues":317,"watchers":4155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/8527"},"html":{"href":"https://github.com/paritytech/parity/pull/8527"},"issue":{"href":"https://api.github.com/repos/paritytech/parity/issues/8527"},"comments":{"href":"https://api.github.com/repos/paritytech/parity/issues/8527/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity/pulls/8527/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity/pulls/8527/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity/statuses/ea4a6d2a7c42599430b9c9ad2860bef26f2d22f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"debris"}}