{"action":"created","issue":{"url":"https://api.github.com/repos/c-ares/c-ares/issues/233","repository_url":"https://api.github.com/repos/c-ares/c-ares","labels_url":"https://api.github.com/repos/c-ares/c-ares/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/c-ares/c-ares/issues/233/comments","events_url":"https://api.github.com/repos/c-ares/c-ares/issues/233/events","html_url":"https://github.com/c-ares/c-ares/pull/233","id":379333729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODI4NjU5","number":233,"title":"Adding unit tests for `ares_getaddrinfo`","user":{"login":"ChristianAmmer","id":26253519,"node_id":"MDQ6VXNlcjI2MjUzNTE5","avatar_url":"https://avatars2.githubusercontent.com/u/26253519?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianAmmer","html_url":"https://github.com/ChristianAmmer","followers_url":"https://api.github.com/users/ChristianAmmer/followers","following_url":"https://api.github.com/users/ChristianAmmer/following{/other_user}","gists_url":"https://api.github.com/users/ChristianAmmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianAmmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianAmmer/subscriptions","organizations_url":"https://api.github.com/users/ChristianAmmer/orgs","repos_url":"https://api.github.com/users/ChristianAmmer/repos","events_url":"https://api.github.com/users/ChristianAmmer/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianAmmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-09T21:48:58Z","updated_at":"2018-11-11T02:15:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/c-ares/c-ares/pulls/233","html_url":"https://github.com/c-ares/c-ares/pull/233","diff_url":"https://github.com/c-ares/c-ares/pull/233.diff","patch_url":"https://github.com/c-ares/c-ares/pull/233.patch"},"body":"This Pull Request adds new tests for `ares_getaddrinfo`. The tests are alike the tests for `get_hostbyname`. The intention is to test similar scenarios. The new tests are:\r\n- `TEST_P(MockUDPChannelTestAI, ParallelLookups)`\r\n- `TEST_P(MockChannelTestAI, SearchDomains)`\r\n- `TEST_P(MockChannelTestAI, SearchDomainsServFailOnAAAA)`\r\n\r\nThis PR also fixes a problem of the `hquery->remaining` counter variable, without this fix these tests would fail. More tests will follow.\r\n\r\nFYI @bradh352, @ki11roy"},"comment":{"url":"https://api.github.com/repos/c-ares/c-ares/issues/comments/437637714","html_url":"https://github.com/c-ares/c-ares/pull/233#issuecomment-437637714","issue_url":"https://api.github.com/repos/c-ares/c-ares/issues/233","id":437637714,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzYzNzcxNA==","user":{"login":"bradh352","id":19732188,"node_id":"MDQ6VXNlcjE5NzMyMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/19732188?v=4","gravatar_id":"","url":"https://api.github.com/users/bradh352","html_url":"https://github.com/bradh352","followers_url":"https://api.github.com/users/bradh352/followers","following_url":"https://api.github.com/users/bradh352/following{/other_user}","gists_url":"https://api.github.com/users/bradh352/gists{/gist_id}","starred_url":"https://api.github.com/users/bradh352/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradh352/subscriptions","organizations_url":"https://api.github.com/users/bradh352/orgs","repos_url":"https://api.github.com/users/bradh352/repos","events_url":"https://api.github.com/users/bradh352/events{/privacy}","received_events_url":"https://api.github.com/users/bradh352/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T02:15:38Z","updated_at":"2018-11-11T02:15:38Z","author_association":"MEMBER","body":"looks reasonable to me.  Ready to merge or were you planning on adding more to this PR?"}}
{"actor":{"display_login":"bradh352"}}