{"action":"created","issue":{"url":"https://api.github.com/repos/cristim/autospotting/issues/210","repository_url":"https://api.github.com/repos/cristim/autospotting","labels_url":"https://api.github.com/repos/cristim/autospotting/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/cristim/autospotting/issues/210/comments","events_url":"https://api.github.com/repos/cristim/autospotting/issues/210/events","html_url":"https://github.com/cristim/autospotting/pull/210","id":293053238,"number":210,"title":"remove 25% cap on allowedinstancetypes","user":{"login":"JaveriaK","id":7893417,"avatar_url":"https://avatars2.githubusercontent.com/u/7893417?v=4","gravatar_id":"","url":"https://api.github.com/users/JaveriaK","html_url":"https://github.com/JaveriaK","followers_url":"https://api.github.com/users/JaveriaK/followers","following_url":"https://api.github.com/users/JaveriaK/following{/other_user}","gists_url":"https://api.github.com/users/JaveriaK/gists{/gist_id}","starred_url":"https://api.github.com/users/JaveriaK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaveriaK/subscriptions","organizations_url":"https://api.github.com/users/JaveriaK/orgs","repos_url":"https://api.github.com/users/JaveriaK/repos","events_url":"https://api.github.com/users/JaveriaK/events{/privacy}","received_events_url":"https://api.github.com/users/JaveriaK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-01-31T07:12:50Z","updated_at":"2018-02-10T21:42:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cristim/autospotting/pulls/210","html_url":"https://github.com/cristim/autospotting/pull/210","diff_url":"https://github.com/cristim/autospotting/pull/210.diff","patch_url":"https://github.com/cristim/autospotting/pull/210.patch"},"body":"Signed-off-by: Javeria Khan <jkhan@branch.io>\r\n\r\n# Issue Type\r\n\r\n- Bugfix Pull Request\r\n\r\n## Summary\r\nWhen choosing to run autospotting with AllowedInstanceTypes; the goal is to stick to a few specific types (even one); and have all of the on-demands in an ASG converted to those types. \r\n\r\nAt the moment the code caps the number of spots in an ASG to stay below 25% for any particular type. This changeset skips that capping check when AllowedInstanceTypes has been defined.\r\n\r\n## Code contribution checklist\r\nI tested this in a custom build running in CloudFormation. Where previously, using AllowedInstanceTypes would stop converting On-Demands after a few instances (25% according to code); this changeset now allows all of the on-demands to be converted. \r\n\r\n1. [ ] The contribution fixes a single existing github issue, and it is linked\r\n   to it.\r\n1. [ ] The code is as simple as possible, readable and follows the idiomatic Go\r\n  [guidelines](https://golang.org/doc/effective_go.html).\r\n1. [ ] All new functionality is covered by automated test cases so the overall\r\n  test coverage doesn't decrease.\r\n1. [ ] No issues are reported when running `make full-test`.\r\n1. [ ] Functionality not applicable to all users should be configurable.\r\n1. [ ] Configurations should be exposed through Lambda function environment\r\n   variables which are also passed as parameters to the\r\n   [CloudFormation](https://github.com/cristim/autospotting/blob/master/cloudformation/stacks/AutoSpotting/template.json)\r\n   and\r\n   [Terraform](https://github.com/cristim/autospotting/blob/master/terraform/autospotting.tf)\r\n   stacks defined as infrastructure code.\r\n1. [ ] Global configurations set from the infrastructure stack level should also\r\n   support per-group overrides using tags.\r\n1. [ ] Tags names and expected values should be similar to the other existing\r\n   configurations.\r\n1. [ ] Both global and tag-based configuration mechanisms should be tested and\r\n  proven to work using log output from various test runs.\r\n1. [ ] The logs should be kept as clean as possible (use log levels as\r\n  appropriate) and formatted consistently to the existing log output.\r\n1. [ ] The documentation is updated to cover the new behavior, as well as the\r\n   new configuration options for both stack parameters and tag overrides.\r\n1. [ ] A code reviewer reproduced the problem and can confirm the code\r\n  contribution actually resolves it.\r\n"},"comment":{"url":"https://api.github.com/repos/cristim/autospotting/issues/comments/364696100","html_url":"https://github.com/cristim/autospotting/pull/210#issuecomment-364696100","issue_url":"https://api.github.com/repos/cristim/autospotting/issues/210","id":364696100,"user":{"login":"cristim","id":95209,"avatar_url":"https://avatars1.githubusercontent.com/u/95209?v=4","gravatar_id":"","url":"https://api.github.com/users/cristim","html_url":"https://github.com/cristim","followers_url":"https://api.github.com/users/cristim/followers","following_url":"https://api.github.com/users/cristim/following{/other_user}","gists_url":"https://api.github.com/users/cristim/gists{/gist_id}","starred_url":"https://api.github.com/users/cristim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristim/subscriptions","organizations_url":"https://api.github.com/users/cristim/orgs","repos_url":"https://api.github.com/users/cristim/repos","events_url":"https://api.github.com/users/cristim/events{/privacy}","received_events_url":"https://api.github.com/users/cristim/received_events","type":"User","site_admin":false},"created_at":"2018-02-10T21:42:07Z","updated_at":"2018-02-10T21:42:07Z","author_association":"OWNER","body":"@JaveriaK let's get rid of the cap entirely."}}
{"actor":{"display_login":"cristim"}}