{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18205","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18205/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18205/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18205/events","html_url":"https://github.com/home-assistant/home-assistant/issues/18205","id":377191141,"node_id":"MDU6SXNzdWUzNzcxOTExNDE=","number":18205,"title":"RFC: Dark Sky current conditions are mixed up","user":{"login":"leppa","id":857627,"node_id":"MDQ6VXNlcjg1NzYyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/857627?v=4","gravatar_id":"","url":"https://api.github.com/users/leppa","html_url":"https://github.com/leppa","followers_url":"https://api.github.com/users/leppa/followers","following_url":"https://api.github.com/users/leppa/following{/other_user}","gists_url":"https://api.github.com/users/leppa/gists{/gist_id}","starred_url":"https://api.github.com/users/leppa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leppa/subscriptions","organizations_url":"https://api.github.com/users/leppa/orgs","repos_url":"https://api.github.com/users/leppa/repos","events_url":"https://api.github.com/users/leppa/events{/privacy}","received_events_url":"https://api.github.com/users/leppa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-11-04T20:28:24Z","updated_at":"2018-11-05T12:56:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!-- READ THIS FIRST:\r\n- If you need additional help with this template please refer to https://www.home-assistant.io/help/reporting_issues/\r\n- Make sure you are running the latest version of Home Assistant before reporting an issue: https://github.com/home-assistant/home-assistant/releases\r\n- Do not report issues for components if you are using custom components: files in <config-dir>/custom_components\r\n- This is for bugs only. Feature and enhancement requests should go in our community forum: https://community.home-assistant.io/c/feature-requests\r\n- Provide as many details as possible. Paste logs, configuration sample and code into the backticks. Do not delete any text from this template!\r\n-->\r\n\r\n**Home Assistant release with the issue:** 0.81.4\r\n<!--\r\n- Frontend -> Developer tools -> Info\r\n- Or use this command: hass --version\r\n-->\r\n\r\n\r\n**Last working Home Assistant release (if known):** N/A\r\n\r\n\r\n**Operating environment (Hass.io/Docker/Windows/etc.):** N/A\r\n<!--\r\nPlease provide details about your environment.\r\n-->\r\n\r\n**Component/platform:** [Dark Sky Sensor](https://www.home-assistant.io/components/sensor.darksky/)\r\n<!--\r\nPlease add the link to the documentation at https://www.home-assistant.io/components/ of the component/platform in question.\r\n-->\r\n\r\n\r\n**Description of problem:**\r\n\r\nThere seems to be a bit of a mix in Dark Sky, with some `monitored_conditions` being taken from current weather (`currently`) and some from today forecast (`daily[0].data`). See https://darksky.net/dev/docs for reference.\r\n\r\nHere are all `monitored_conditions`, and their source in the component:\r\n\r\n| Condition | Currently (`currently`) | Today Forecast (`daily[0].data`) | Day `x` forecast (`daily[x].data`, exposed as `<property>_x`) |\r\n| - |:-:|:-:|:-:|\r\n| `summary` | X | ? | X |\r\n| `precip_type` | X | ? | X |\r\n| `precip_intensity` | X | ? | X |\r\n| `precip_probability` | X | ? | X |\r\n| `precip_accumulation ` | - | X | X |\r\n| `temperature` | X | - | - |\r\n| `apparent_temperature` | X | - | - |\r\n| `dew_point` | X | ? | X |\r\n| `wind_speed` | X | ? | X |\r\n| `wind_gust`* | X | ? | X |\r\n| `wind_bearing` | X | ? | X |\r\n| `cloud_cover` | X | ? | X |\r\n| `humidity` | X | ? | X |\r\n| `pressure` | X | ? | X |\r\n| `visibility` | X | ? | X |\r\n| `ozone` | X | ? | X |\r\n| `temperature_high` | - | X | X |\r\n| `temperature_low` | - | X | X |\r\n| `apparent_temperature_high` | - | X | X |\r\n| `apparent_temperature_low` | - | X | X |\r\n| `precip_intensity_max` | - | X | X |\r\n| `uv_index` | X | ? | X |\r\n| `moon_phase` | - | X | X |\r\n| `nearest_storm_distance`^ | X | - | - |\r\n| `nearest_storm_bearing`^ | X | - | - |\r\n\r\nX - property exposed in HA  \r\n\\- - property unavailable for this source  \r\n? - property available for this source, but not exposed in HA  \r\n\\* - not released yet\r\n^- seems to be missing from the [docs](https://www.home-assistant.io/components/sensor.darksky/)\r\n\r\nSo, those `monitored_conditions` without `_x` suffix are a mix of data from two sources. That's a bit confusing. And a lot of useful conditions from today forecast are not exposed at all.\r\n\r\nI'd like to suggest two possible solutions. Both will minimize handling of special cases, but will be breaking changes.\r\n\r\n1. Leave all properties in column \"Current\" as-is and expose all properties in column \"Today Forecast\" (including renaming those that are already exposed) as `<property>_0` (alternatively, `<property>_today`). Also add `0` to the list of allowed values of `forecast` configuration key. I prefer this one.\r\n\r\n2. Rename all properties in column \"Current\" to `<property>_current` and expose all properties from column \"Today Forecast\" as `<property>`.\r\n\r\nWhich one would people prefer?\r\n\r\n\r\n**Problem-relevant `configuration.yaml` entries and (fill out even if it seems unimportant):**\r\n```yaml\r\nsensor:\r\n  - platform: darksky\r\n    api_key: YOUR_API_KEY\r\n    monitored_conditions:\r\n      - <all available>\r\n```\r\n\r\n**Traceback (if applicable):**\r\n```\r\n\r\n```\r\n\r\n**Additional information:**\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/435863945","html_url":"https://github.com/home-assistant/home-assistant/issues/18205#issuecomment-435863945","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18205","id":435863945,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTg2Mzk0NQ==","user":{"login":"Molodax","id":22867988,"node_id":"MDQ6VXNlcjIyODY3OTg4","avatar_url":"https://avatars2.githubusercontent.com/u/22867988?v=4","gravatar_id":"","url":"https://api.github.com/users/Molodax","html_url":"https://github.com/Molodax","followers_url":"https://api.github.com/users/Molodax/followers","following_url":"https://api.github.com/users/Molodax/following{/other_user}","gists_url":"https://api.github.com/users/Molodax/gists{/gist_id}","starred_url":"https://api.github.com/users/Molodax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Molodax/subscriptions","organizations_url":"https://api.github.com/users/Molodax/orgs","repos_url":"https://api.github.com/users/Molodax/repos","events_url":"https://api.github.com/users/Molodax/events{/privacy}","received_events_url":"https://api.github.com/users/Molodax/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T12:56:19Z","updated_at":"2018-11-05T12:56:19Z","author_association":"NONE","body":"> @Molodax, current state is current. It's what happening right now. Forecasted values come from minutely, hourly, and daily forecasts.\r\n\r\nYou can read it as a currents forecast if you want. I'm also interested in the rain probability for today as you but I want to know the current temperature and forecasted high temperature for today at the same time. Therefore, I don't like your proposal #1."}}
{"actor":{"display_login":"Molodax"}}