{"action":"closed","number":9048,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048","id":179670827,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9048","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9048.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9048.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9048","number":9048,"state":"closed","locked":false,"title":"Remove Jetpack Signup feature flag","user":{"login":"elibud","id":5558824,"avatar_url":"https://avatars3.githubusercontent.com/u/5558824?v=4","gravatar_id":"","url":"https://api.github.com/users/elibud","html_url":"https://github.com/elibud","followers_url":"https://api.github.com/users/elibud/followers","following_url":"https://api.github.com/users/elibud/following{/other_user}","gists_url":"https://api.github.com/users/elibud/gists{/gist_id}","starred_url":"https://api.github.com/users/elibud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibud/subscriptions","organizations_url":"https://api.github.com/users/elibud/orgs","repos_url":"https://api.github.com/users/elibud/repos","events_url":"https://api.github.com/users/elibud/events{/privacy}","received_events_url":"https://api.github.com/users/elibud/received_events","type":"User","site_admin":false},"body":"**Fixes** #8949 \r\n\r\n**To test:**\r\n\r\nCheck that in a production build Jetpack sign up is enabled.\r\n\r\nNote: @nheagy while working on this I noticed two things:\r\n\r\n- Social signup is not enabled from the Jetpack flow (I'm fine shipping a v1 without this)\r\n- There's no option to update the username in this flow\r\n\r\nIs there any particular reason for that or just that it's another step we haven't implemented yet?","created_at":"2018-04-05T13:09:36Z","updated_at":"2018-04-20T17:51:31Z","closed_at":"2018-04-20T17:51:31Z","merged_at":null,"merge_commit_sha":"3a66625938e797816bf3602304493d4eb6a94f7c","assignee":{"login":"elibud","id":5558824,"avatar_url":"https://avatars3.githubusercontent.com/u/5558824?v=4","gravatar_id":"","url":"https://api.github.com/users/elibud","html_url":"https://github.com/elibud","followers_url":"https://api.github.com/users/elibud/followers","following_url":"https://api.github.com/users/elibud/following{/other_user}","gists_url":"https://api.github.com/users/elibud/gists{/gist_id}","starred_url":"https://api.github.com/users/elibud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibud/subscriptions","organizations_url":"https://api.github.com/users/elibud/orgs","repos_url":"https://api.github.com/users/elibud/repos","events_url":"https://api.github.com/users/elibud/events{/privacy}","received_events_url":"https://api.github.com/users/elibud/received_events","type":"User","site_admin":false},"assignees":[{"login":"elibud","id":5558824,"avatar_url":"https://avatars3.githubusercontent.com/u/5558824?v=4","gravatar_id":"","url":"https://api.github.com/users/elibud","html_url":"https://github.com/elibud","followers_url":"https://api.github.com/users/elibud/followers","following_url":"https://api.github.com/users/elibud/following{/other_user}","gists_url":"https://api.github.com/users/elibud/gists{/gist_id}","starred_url":"https://api.github.com/users/elibud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibud/subscriptions","organizations_url":"https://api.github.com/users/elibud/orgs","repos_url":"https://api.github.com/users/elibud/repos","events_url":"https://api.github.com/users/elibud/events{/privacy}","received_events_url":"https://api.github.com/users/elibud/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":87459300,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/Jetpack","name":"Jetpack","color":"006b75","default":false},{"id":64316683,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/NUX","name":"NUX","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/101","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestone/101","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/101/labels","id":3242824,"number":101,"title":"9.9","description":"Code freeze: April 23th, 2018 App Store submission: May 7th, 2018","creator":{"login":"elibud","id":5558824,"avatar_url":"https://avatars3.githubusercontent.com/u/5558824?v=4","gravatar_id":"","url":"https://api.github.com/users/elibud","html_url":"https://github.com/elibud","followers_url":"https://api.github.com/users/elibud/followers","following_url":"https://api.github.com/users/elibud/following{/other_user}","gists_url":"https://api.github.com/users/elibud/gists{/gist_id}","starred_url":"https://api.github.com/users/elibud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibud/subscriptions","organizations_url":"https://api.github.com/users/elibud/orgs","repos_url":"https://api.github.com/users/elibud/repos","events_url":"https://api.github.com/users/elibud/events{/privacy}","received_events_url":"https://api.github.com/users/elibud/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":30,"state":"open","created_at":"2018-04-04T17:21:04Z","updated_at":"2018-04-20T17:51:31Z","due_on":"2018-04-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9048/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/0d6f6a80f84cfa0347e38499ec11dac19fd9fcaf","head":{"label":"wordpress-mobile:feature/8949-enable-signup-from-jetpack","ref":"feature/8949-enable-signup-from-jetpack","sha":"0d6f6a80f84cfa0347e38499ec11dac19fd9fcaf","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":8859285,"name":"WordPress-iOS","full_name":"wordpress-mobile/WordPress-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS","description":"WordPress for iOS - Official repository","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/deployments","created_at":"2013-03-18T16:59:33Z","updated_at":"2018-04-20T16:55:16Z","pushed_at":"2018-04-20T17:48:46Z","git_url":"git://github.com/wordpress-mobile/WordPress-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPress-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPress-iOS","homepage":"http://ios.wordpress.org/","size":427143,"stargazers_count":2249,"watchers_count":2249,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":791,"mirror_url":null,"archived":false,"open_issues_count":519,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":791,"open_issues":519,"watchers":2249,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"0aaade75f75db888bc3fd63410fc1bd477feaf9e","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":8859285,"name":"WordPress-iOS","full_name":"wordpress-mobile/WordPress-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS","description":"WordPress for iOS - Official repository","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/deployments","created_at":"2013-03-18T16:59:33Z","updated_at":"2018-04-20T16:55:16Z","pushed_at":"2018-04-20T17:48:46Z","git_url":"git://github.com/wordpress-mobile/WordPress-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPress-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPress-iOS","homepage":"http://ios.wordpress.org/","size":427143,"stargazers_count":2249,"watchers_count":2249,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":791,"mirror_url":null,"archived":false,"open_issues_count":519,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":791,"open_issues":519,"watchers":2249,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9048"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9048"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9048/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9048/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/0d6f6a80f84cfa0347e38499ec11dac19fd9fcaf"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":0,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"elibud"}}