{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/218332694","pull_request_review_id":156244804,"id":218332694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODMzMjY5NA==","diff_hunk":"@@ -84,11 +84,13 @@ public void signalStop() {\n     public void processRecord(ComputationContext context, String inputStreamName, Record record) {\n         work = deserialize(record.getData());\n         try {\n-            if (work.isIdempotent() && workIds.contains(work.getId())) {\n-                log.warn(\"Duplicate work id: \" + work.getId() + \" skipping\");\n+            if (work.isCoalescing() && WorkStateHelper.getLastOffset(work.getId()) > context.getLastOffset().offset()) {\n+                log.debug(\"Coalescing work id with new instance scheduled: \" + work.getId() + \", skipping\");\n+            } else if (work.isIdempotent() && workIds.contains(work.getId())) {\n+                log.debug(\"Duplicate work id: \" + work.getId() + \" skipping\");","path":"nuxeo-core/nuxeo-core-event/src/main/java/org/nuxeo/ecm/core/work/WorkComputation.java","position":9,"original_position":9,"commit_id":"7a413960ba13e1e6e583fbe4b586c7b165cdd05e","original_commit_id":"7a413960ba13e1e6e583fbe4b586c7b165cdd05e","user":{"login":"bdelbosc","id":589079,"node_id":"MDQ6VXNlcjU4OTA3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/589079?v=4","gravatar_id":"","url":"https://api.github.com/users/bdelbosc","html_url":"https://github.com/bdelbosc","followers_url":"https://api.github.com/users/bdelbosc/followers","following_url":"https://api.github.com/users/bdelbosc/following{/other_user}","gists_url":"https://api.github.com/users/bdelbosc/gists{/gist_id}","starred_url":"https://api.github.com/users/bdelbosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdelbosc/subscriptions","organizations_url":"https://api.github.com/users/bdelbosc/orgs","repos_url":"https://api.github.com/users/bdelbosc/repos","events_url":"https://api.github.com/users/bdelbosc/events{/privacy}","received_events_url":"https://api.github.com/users/bdelbosc/received_events","type":"User","site_admin":false},"body":"Here also: \"Skipping duplicate of idempotent work id: \" ","created_at":"2018-09-18T08:02:19Z","updated_at":"2018-09-18T08:02:19Z","html_url":"https://github.com/nuxeo/nuxeo/pull/2350#discussion_r218332694","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/218332694"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/2350#discussion_r218332694"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350","id":215948217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTQ4MjE3","html_url":"https://github.com/nuxeo/nuxeo/pull/2350","diff_url":"https://github.com/nuxeo/nuxeo/pull/2350.diff","patch_url":"https://github.com/nuxeo/nuxeo/pull/2350.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/2350","number":2350,"state":"open","locked":false,"title":"task-NXP-25619-coalescing-work-swm","user":{"login":"nuxeojenkins","id":925456,"node_id":"MDQ6VXNlcjkyNTQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/925456?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeojenkins","html_url":"https://github.com/nuxeojenkins","followers_url":"https://api.github.com/users/nuxeojenkins/followers","following_url":"https://api.github.com/users/nuxeojenkins/following{/other_user}","gists_url":"https://api.github.com/users/nuxeojenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeojenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeojenkins/subscriptions","organizations_url":"https://api.github.com/users/nuxeojenkins/orgs","repos_url":"https://api.github.com/users/nuxeojenkins/repos","events_url":"https://api.github.com/users/nuxeojenkins/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeojenkins/received_events","type":"User","site_admin":false},"body":"PR created from https://qa.nuxeo.org/jenkins/job/TestAndPush/job/ondemand-testandpush-pierregautier2/26/","created_at":"2018-09-17T11:22:19Z","updated_at":"2018-09-18T08:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9053887c7713a4e84643cb8b9255f9af5f271923","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/2350/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/7a413960ba13e1e6e583fbe4b586c7b165cdd05e","head":{"label":"nuxeo:task-NXP-25619-coalescing-work-swm","ref":"task-NXP-25619-coalescing-work-swm","sha":"7a413960ba13e1e6e583fbe4b586c7b165cdd05e","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MTAx","name":"nuxeo","full_name":"nuxeo/nuxeo","private":false,"owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2018-09-17T14:00:24Z","pushed_at":"2018-09-18T06:24:34Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":233857,"stargazers_count":244,"watchers_count":244,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":163,"open_issues":23,"watchers":244,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"16cf0bf48cbcdb6ae617087c0cbd618a56a0fbf4","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MTAx","name":"nuxeo","full_name":"nuxeo/nuxeo","private":false,"owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2018-09-17T14:00:24Z","pushed_at":"2018-09-18T06:24:34Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":233857,"stargazers_count":244,"watchers_count":244,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":163,"open_issues":23,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/2350"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/2350"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/2350/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2350/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo/statuses/7a413960ba13e1e6e583fbe4b586c7b165cdd05e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bdelbosc"}}