{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/53","repository_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/53/comments","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/53/events","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/53","id":339186483,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTE5ODAw","number":53,"title":"Kubelet node labels","user":{"login":"bshelton229","id":169958,"node_id":"MDQ6VXNlcjE2OTk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/169958?v=4","gravatar_id":"","url":"https://api.github.com/users/bshelton229","html_url":"https://github.com/bshelton229","followers_url":"https://api.github.com/users/bshelton229/followers","following_url":"https://api.github.com/users/bshelton229/following{/other_user}","gists_url":"https://api.github.com/users/bshelton229/gists{/gist_id}","starred_url":"https://api.github.com/users/bshelton229/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bshelton229/subscriptions","organizations_url":"https://api.github.com/users/bshelton229/orgs","repos_url":"https://api.github.com/users/bshelton229/repos","events_url":"https://api.github.com/users/bshelton229/events{/privacy}","received_events_url":"https://api.github.com/users/bshelton229/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-08T00:50:35Z","updated_at":"2018-07-09T19:57:25Z","closed_at":"2018-07-09T08:26:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/53","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/53","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/53.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/53.patch"},"body":"# PR o'clock\r\n\r\n## Description\r\n\r\nHello, thank you so much for creating this module. It's been invaluable for learning how EKS works. Being able to pass node labels to kubelet in a worker configuration option seemed like a nice interface over us doing this in `pre_userdata`.\r\n\r\nTested by passing this:\r\n\r\n```\r\n  worker_groups = [\r\n    {\r\n      name                = \"default\"\r\n      instance_type       = \"t2.small\"\r\n      kubelet_node_labels = \"node-role.kubernetes.io/node=\"\r\n    },\r\n    {\r\n      name                = \"btest\"\r\n      instance_type       = \"t2.small\"\r\n      kubelet_node_labels = \"node-role.kubernetes.io/btest=\"\r\n    },\r\n    {\r\n      name          = \"no-role-passed\"\r\n      instance_type = \"t2.small\"\r\n    },\r\n  ]\r\n```\r\n\r\nWhich created the expected nodes:\r\n\r\n```\r\nNAME                                        STATUS    ROLES     AGE       VERSION\r\nip-10-10-110-4.us-west-2.compute.internal   Ready     node      55m       v1.10.3\r\nip-10-10-54-81.us-west-2.compute.internal   Ready     <none>    45m       v1.10.3\r\nip-10-10-98-2.us-west-2.compute.internal    Ready     btest     51m       v1.10.3\r\n```\r\n\r\n### Checklist\r\n\r\n- [x] `terraform fmt` and `terraform validate` both work from the root and `examples/eks_test_fixture` directories (look in CI for an example)\r\n- [ ] Tests for the changes have been added and passing (for bug fixes/features)\r\n- [ ] Test results are pasted in this PR (in lieu of CI)\r\n- [ ] Docs have been updated using `terraform-docs` per `README.md` instructions\r\n- [x] I've added my change to CHANGELOG.md\r\n- [x] Any breaking changes are highlighted above\r\n"},"comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/comments/403600966","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/53#issuecomment-403600966","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/53","id":403600966,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYwMDk2Ng==","user":{"login":"bshelton229","id":169958,"node_id":"MDQ6VXNlcjE2OTk1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/169958?v=4","gravatar_id":"","url":"https://api.github.com/users/bshelton229","html_url":"https://github.com/bshelton229","followers_url":"https://api.github.com/users/bshelton229/followers","following_url":"https://api.github.com/users/bshelton229/following{/other_user}","gists_url":"https://api.github.com/users/bshelton229/gists{/gist_id}","starred_url":"https://api.github.com/users/bshelton229/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bshelton229/subscriptions","organizations_url":"https://api.github.com/users/bshelton229/orgs","repos_url":"https://api.github.com/users/bshelton229/repos","events_url":"https://api.github.com/users/bshelton229/events{/privacy}","received_events_url":"https://api.github.com/users/bshelton229/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T19:57:25Z","updated_at":"2018-07-09T19:57:25Z","author_association":"CONTRIBUTOR","body":"@brandoconnor Lars is my manager, and says hi back!"}}
{"actor":{"display_login":"bshelton229"}}