{"action":"created","comment":{"url":"https://api.github.com/repos/rpush/rpush/pulls/comments/169969009","pull_request_review_id":98581046,"id":169969009,"diff_hunk":"@@ -100,14 +100,15 @@ def handle_errors(failures)\n         end\n \n         def create_new_notification(response, unavailable_idxs)\n-          attrs = { 'app_id' => @notification.app_id, 'collapse_key' => @notification.collapse_key, 'delay_while_idle' => @notification.delay_while_idle }\n+          attrs = { 'app_id' => @notification.app_id, 'collapse_key' => @notification.collapse_key }\n           registration_ids = @notification.registration_ids.values_at(*unavailable_idxs)\n           Rpush::Daemon.store.create_gcm_notification(attrs, @notification.data,\n                                                       registration_ids, deliver_after_header(response), @notification.app)\n         end\n \n-        def bad_request\n-          fail Rpush::DeliveryError.new(400, @notification.id, 'GCM failed to parse the JSON request. Possibly an Rpush bug, please open an issue.')\n+        def bad_request(response)\n+          # due to gcm > fcm update\n+          fail Rpush::DeliveryError.new(400, @notification.id, response.inspect)","path":"lib/rpush/daemon/gcm/delivery.rb","position":24,"original_position":24,"commit_id":"e42fd7b95ca49e323de728145042deffc18d7c31","original_commit_id":"e42fd7b95ca49e323de728145042deffc18d7c31","user":{"login":"aried3r","id":1301152,"avatar_url":"https://avatars1.githubusercontent.com/u/1301152?v=4","gravatar_id":"","url":"https://api.github.com/users/aried3r","html_url":"https://github.com/aried3r","followers_url":"https://api.github.com/users/aried3r/followers","following_url":"https://api.github.com/users/aried3r/following{/other_user}","gists_url":"https://api.github.com/users/aried3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aried3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aried3r/subscriptions","organizations_url":"https://api.github.com/users/aried3r/orgs","repos_url":"https://api.github.com/users/aried3r/repos","events_url":"https://api.github.com/users/aried3r/events{/privacy}","received_events_url":"https://api.github.com/users/aried3r/received_events","type":"User","site_admin":false},"body":"Could you elaborate this change a bit more?","created_at":"2018-02-22T14:23:36Z","updated_at":"2018-02-22T14:23:36Z","html_url":"https://github.com/rpush/rpush/pull/403#discussion_r169969009","pull_request_url":"https://api.github.com/repos/rpush/rpush/pulls/403","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rpush/rpush/pulls/comments/169969009"},"html":{"href":"https://github.com/rpush/rpush/pull/403#discussion_r169969009"},"pull_request":{"href":"https://api.github.com/repos/rpush/rpush/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/rpush/rpush/pulls/403","id":163370453,"html_url":"https://github.com/rpush/rpush/pull/403","diff_url":"https://github.com/rpush/rpush/pull/403.diff","patch_url":"https://github.com/rpush/rpush/pull/403.patch","issue_url":"https://api.github.com/repos/rpush/rpush/issues/403","number":403,"state":"open","locked":false,"title":"reflect gcm deprecation","user":{"login":"sthkindacrazy","id":26075586,"avatar_url":"https://avatars3.githubusercontent.com/u/26075586?v=4","gravatar_id":"","url":"https://api.github.com/users/sthkindacrazy","html_url":"https://github.com/sthkindacrazy","followers_url":"https://api.github.com/users/sthkindacrazy/followers","following_url":"https://api.github.com/users/sthkindacrazy/following{/other_user}","gists_url":"https://api.github.com/users/sthkindacrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/sthkindacrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthkindacrazy/subscriptions","organizations_url":"https://api.github.com/users/sthkindacrazy/orgs","repos_url":"https://api.github.com/users/sthkindacrazy/repos","events_url":"https://api.github.com/users/sthkindacrazy/events{/privacy}","received_events_url":"https://api.github.com/users/sthkindacrazy/received_events","type":"User","site_admin":false},"body":"Due to update of gcm to fcm, delay_while_idle is not supported anymore (2016.11.15)\r\nCausing JSON parse error for rpush notifications. Deleted related portions.","created_at":"2018-01-17T07:44:32Z","updated_at":"2018-02-22T14:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"441d659ff285f354b2be62e8c25920f7ff8ba6af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpush/rpush/pulls/403/commits","review_comments_url":"https://api.github.com/repos/rpush/rpush/pulls/403/comments","review_comment_url":"https://api.github.com/repos/rpush/rpush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpush/rpush/issues/403/comments","statuses_url":"https://api.github.com/repos/rpush/rpush/statuses/e42fd7b95ca49e323de728145042deffc18d7c31","head":{"label":"sthkindacrazy:master","ref":"master","sha":"e42fd7b95ca49e323de728145042deffc18d7c31","user":{"login":"sthkindacrazy","id":26075586,"avatar_url":"https://avatars3.githubusercontent.com/u/26075586?v=4","gravatar_id":"","url":"https://api.github.com/users/sthkindacrazy","html_url":"https://github.com/sthkindacrazy","followers_url":"https://api.github.com/users/sthkindacrazy/followers","following_url":"https://api.github.com/users/sthkindacrazy/following{/other_user}","gists_url":"https://api.github.com/users/sthkindacrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/sthkindacrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthkindacrazy/subscriptions","organizations_url":"https://api.github.com/users/sthkindacrazy/orgs","repos_url":"https://api.github.com/users/sthkindacrazy/repos","events_url":"https://api.github.com/users/sthkindacrazy/events{/privacy}","received_events_url":"https://api.github.com/users/sthkindacrazy/received_events","type":"User","site_admin":false},"repo":{"id":117802287,"name":"rpush","full_name":"sthkindacrazy/rpush","owner":{"login":"sthkindacrazy","id":26075586,"avatar_url":"https://avatars3.githubusercontent.com/u/26075586?v=4","gravatar_id":"","url":"https://api.github.com/users/sthkindacrazy","html_url":"https://github.com/sthkindacrazy","followers_url":"https://api.github.com/users/sthkindacrazy/followers","following_url":"https://api.github.com/users/sthkindacrazy/following{/other_user}","gists_url":"https://api.github.com/users/sthkindacrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/sthkindacrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthkindacrazy/subscriptions","organizations_url":"https://api.github.com/users/sthkindacrazy/orgs","repos_url":"https://api.github.com/users/sthkindacrazy/repos","events_url":"https://api.github.com/users/sthkindacrazy/events{/privacy}","received_events_url":"https://api.github.com/users/sthkindacrazy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sthkindacrazy/rpush","description":"The push notification service for Ruby.","fork":true,"url":"https://api.github.com/repos/sthkindacrazy/rpush","forks_url":"https://api.github.com/repos/sthkindacrazy/rpush/forks","keys_url":"https://api.github.com/repos/sthkindacrazy/rpush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sthkindacrazy/rpush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sthkindacrazy/rpush/teams","hooks_url":"https://api.github.com/repos/sthkindacrazy/rpush/hooks","issue_events_url":"https://api.github.com/repos/sthkindacrazy/rpush/issues/events{/number}","events_url":"https://api.github.com/repos/sthkindacrazy/rpush/events","assignees_url":"https://api.github.com/repos/sthkindacrazy/rpush/assignees{/user}","branches_url":"https://api.github.com/repos/sthkindacrazy/rpush/branches{/branch}","tags_url":"https://api.github.com/repos/sthkindacrazy/rpush/tags","blobs_url":"https://api.github.com/repos/sthkindacrazy/rpush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sthkindacrazy/rpush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sthkindacrazy/rpush/git/refs{/sha}","trees_url":"https://api.github.com/repos/sthkindacrazy/rpush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sthkindacrazy/rpush/statuses/{sha}","languages_url":"https://api.github.com/repos/sthkindacrazy/rpush/languages","stargazers_url":"https://api.github.com/repos/sthkindacrazy/rpush/stargazers","contributors_url":"https://api.github.com/repos/sthkindacrazy/rpush/contributors","subscribers_url":"https://api.github.com/repos/sthkindacrazy/rpush/subscribers","subscription_url":"https://api.github.com/repos/sthkindacrazy/rpush/subscription","commits_url":"https://api.github.com/repos/sthkindacrazy/rpush/commits{/sha}","git_commits_url":"https://api.github.com/repos/sthkindacrazy/rpush/git/commits{/sha}","comments_url":"https://api.github.com/repos/sthkindacrazy/rpush/comments{/number}","issue_comment_url":"https://api.github.com/repos/sthkindacrazy/rpush/issues/comments{/number}","contents_url":"https://api.github.com/repos/sthkindacrazy/rpush/contents/{+path}","compare_url":"https://api.github.com/repos/sthkindacrazy/rpush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sthkindacrazy/rpush/merges","archive_url":"https://api.github.com/repos/sthkindacrazy/rpush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sthkindacrazy/rpush/downloads","issues_url":"https://api.github.com/repos/sthkindacrazy/rpush/issues{/number}","pulls_url":"https://api.github.com/repos/sthkindacrazy/rpush/pulls{/number}","milestones_url":"https://api.github.com/repos/sthkindacrazy/rpush/milestones{/number}","notifications_url":"https://api.github.com/repos/sthkindacrazy/rpush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sthkindacrazy/rpush/labels{/name}","releases_url":"https://api.github.com/repos/sthkindacrazy/rpush/releases{/id}","deployments_url":"https://api.github.com/repos/sthkindacrazy/rpush/deployments","created_at":"2018-01-17T07:41:22Z","updated_at":"2018-01-17T07:41:24Z","pushed_at":"2018-01-17T03:53:37Z","git_url":"git://github.com/sthkindacrazy/rpush.git","ssh_url":"git@github.com:sthkindacrazy/rpush.git","clone_url":"https://github.com/sthkindacrazy/rpush.git","svn_url":"https://github.com/sthkindacrazy/rpush","homepage":"","size":27247,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpush:master","ref":"master","sha":"54f28a67f7fa2bc86b07b7b3e36d2042dd20329e","user":{"login":"rpush","id":3169839,"avatar_url":"https://avatars1.githubusercontent.com/u/3169839?v=4","gravatar_id":"","url":"https://api.github.com/users/rpush","html_url":"https://github.com/rpush","followers_url":"https://api.github.com/users/rpush/followers","following_url":"https://api.github.com/users/rpush/following{/other_user}","gists_url":"https://api.github.com/users/rpush/gists{/gist_id}","starred_url":"https://api.github.com/users/rpush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpush/subscriptions","organizations_url":"https://api.github.com/users/rpush/orgs","repos_url":"https://api.github.com/users/rpush/repos","events_url":"https://api.github.com/users/rpush/events{/privacy}","received_events_url":"https://api.github.com/users/rpush/received_events","type":"Organization","site_admin":false},"repo":{"id":7408076,"name":"rpush","full_name":"rpush/rpush","owner":{"login":"rpush","id":3169839,"avatar_url":"https://avatars1.githubusercontent.com/u/3169839?v=4","gravatar_id":"","url":"https://api.github.com/users/rpush","html_url":"https://github.com/rpush","followers_url":"https://api.github.com/users/rpush/followers","following_url":"https://api.github.com/users/rpush/following{/other_user}","gists_url":"https://api.github.com/users/rpush/gists{/gist_id}","starred_url":"https://api.github.com/users/rpush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpush/subscriptions","organizations_url":"https://api.github.com/users/rpush/orgs","repos_url":"https://api.github.com/users/rpush/repos","events_url":"https://api.github.com/users/rpush/events{/privacy}","received_events_url":"https://api.github.com/users/rpush/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpush/rpush","description":"The push notification service for Ruby.","fork":false,"url":"https://api.github.com/repos/rpush/rpush","forks_url":"https://api.github.com/repos/rpush/rpush/forks","keys_url":"https://api.github.com/repos/rpush/rpush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpush/rpush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpush/rpush/teams","hooks_url":"https://api.github.com/repos/rpush/rpush/hooks","issue_events_url":"https://api.github.com/repos/rpush/rpush/issues/events{/number}","events_url":"https://api.github.com/repos/rpush/rpush/events","assignees_url":"https://api.github.com/repos/rpush/rpush/assignees{/user}","branches_url":"https://api.github.com/repos/rpush/rpush/branches{/branch}","tags_url":"https://api.github.com/repos/rpush/rpush/tags","blobs_url":"https://api.github.com/repos/rpush/rpush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpush/rpush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpush/rpush/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpush/rpush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpush/rpush/statuses/{sha}","languages_url":"https://api.github.com/repos/rpush/rpush/languages","stargazers_url":"https://api.github.com/repos/rpush/rpush/stargazers","contributors_url":"https://api.github.com/repos/rpush/rpush/contributors","subscribers_url":"https://api.github.com/repos/rpush/rpush/subscribers","subscription_url":"https://api.github.com/repos/rpush/rpush/subscription","commits_url":"https://api.github.com/repos/rpush/rpush/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpush/rpush/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpush/rpush/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpush/rpush/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpush/rpush/contents/{+path}","compare_url":"https://api.github.com/repos/rpush/rpush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpush/rpush/merges","archive_url":"https://api.github.com/repos/rpush/rpush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpush/rpush/downloads","issues_url":"https://api.github.com/repos/rpush/rpush/issues{/number}","pulls_url":"https://api.github.com/repos/rpush/rpush/pulls{/number}","milestones_url":"https://api.github.com/repos/rpush/rpush/milestones{/number}","notifications_url":"https://api.github.com/repos/rpush/rpush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpush/rpush/labels{/name}","releases_url":"https://api.github.com/repos/rpush/rpush/releases{/id}","deployments_url":"https://api.github.com/repos/rpush/rpush/deployments","created_at":"2013-01-02T14:46:47Z","updated_at":"2018-02-22T14:11:56Z","pushed_at":"2018-02-22T14:03:17Z","git_url":"git://github.com/rpush/rpush.git","ssh_url":"git@github.com:rpush/rpush.git","clone_url":"https://github.com/rpush/rpush.git","svn_url":"https://github.com/rpush/rpush","homepage":"","size":27244,"stargazers_count":1184,"watchers_count":1184,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":210,"open_issues":106,"watchers":1184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpush/rpush/pulls/403"},"html":{"href":"https://github.com/rpush/rpush/pull/403"},"issue":{"href":"https://api.github.com/repos/rpush/rpush/issues/403"},"comments":{"href":"https://api.github.com/repos/rpush/rpush/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/rpush/rpush/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/rpush/rpush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpush/rpush/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/rpush/rpush/statuses/e42fd7b95ca49e323de728145042deffc18d7c31"}},"author_association":"NONE"}}
{"actor":{"display_login":"aried3r"}}