{"action":"created","comment":{"url":"https://api.github.com/repos/vitkon/form-container/pulls/comments/176373160","pull_request_review_id":106061229,"id":176373160,"diff_hunk":"@@ -36,6 +44,7 @@ export interface IFormProps<T = any> {\n         inputs: any;\n         isValid?: boolean;\n         validationErrors: { [key: string]: string };\n+        validationWarnings: { [key: string]: string };","path":"src/interfaces.ts","position":30,"original_position":30,"commit_id":"ab531396648ec489c8ba28daecf6f40f697da500","original_commit_id":"3f15be734db788083fba5537ce1ea6e1a2604b0b","user":{"login":"mattdell","id":2536442,"avatar_url":"https://avatars1.githubusercontent.com/u/2536442?v=4","gravatar_id":"","url":"https://api.github.com/users/mattdell","html_url":"https://github.com/mattdell","followers_url":"https://api.github.com/users/mattdell/followers","following_url":"https://api.github.com/users/mattdell/following{/other_user}","gists_url":"https://api.github.com/users/mattdell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdell/subscriptions","organizations_url":"https://api.github.com/users/mattdell/orgs","repos_url":"https://api.github.com/users/mattdell/repos","events_url":"https://api.github.com/users/mattdell/events{/privacy}","received_events_url":"https://api.github.com/users/mattdell/received_events","type":"User","site_admin":false},"body":"Yep 👍🏻","created_at":"2018-03-22T10:37:29Z","updated_at":"2018-03-22T10:37:29Z","html_url":"https://github.com/vitkon/form-container/pull/39#discussion_r176373160","pull_request_url":"https://api.github.com/repos/vitkon/form-container/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/comments/176373160"},"html":{"href":"https://github.com/vitkon/form-container/pull/39#discussion_r176373160"},"pull_request":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/39"}},"in_reply_to_id":176335865},"pull_request":{"url":"https://api.github.com/repos/vitkon/form-container/pulls/39","id":176616496,"html_url":"https://github.com/vitkon/form-container/pull/39","diff_url":"https://github.com/vitkon/form-container/pull/39.diff","patch_url":"https://github.com/vitkon/form-container/pull/39.patch","issue_url":"https://api.github.com/repos/vitkon/form-container/issues/39","number":39,"state":"open","locked":false,"title":"Add warnings","user":{"login":"mattdell","id":2536442,"avatar_url":"https://avatars1.githubusercontent.com/u/2536442?v=4","gravatar_id":"","url":"https://api.github.com/users/mattdell","html_url":"https://github.com/mattdell","followers_url":"https://api.github.com/users/mattdell/followers","following_url":"https://api.github.com/users/mattdell/following{/other_user}","gists_url":"https://api.github.com/users/mattdell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdell/subscriptions","organizations_url":"https://api.github.com/users/mattdell/orgs","repos_url":"https://api.github.com/users/mattdell/repos","events_url":"https://api.github.com/users/mattdell/events{/privacy}","received_events_url":"https://api.github.com/users/mattdell/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nThis PR adds the concept of warnings to the project without causing a breaking change. The interface of `formContainer` now simply takes in a type option, like so\r\n\r\n```\r\nisRequired('username', 'please enter your username'), // error by default\r\nisRequired('username', 'you might want to enter a username', ValidationType.Warning),\r\nisRequired('password', 'please enter your password', ValidationType.Error)\r\n```\r\n\r\nWhich generates `validationErrors` _and_ `validationWarnings` in the validate wrapper.\r\n\r\n#### Where should the reviewer start?\r\nProbably\r\n* validate.ts\r\n* validators.ts\r\n\r\n#### How should this be manually tested?\r\nI've written a few extra tests, which should help. But on top of this I compiled the source and ran it in one of my projects and it seems to work well.\r\n\r\n#### What are the relevant tickets / issues?\r\n#33 \r\n","created_at":"2018-03-21T21:35:33Z","updated_at":"2018-03-22T10:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47da1bf1bd1397242a05a97441743eccd6dcb8ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitkon/form-container/pulls/39/commits","review_comments_url":"https://api.github.com/repos/vitkon/form-container/pulls/39/comments","review_comment_url":"https://api.github.com/repos/vitkon/form-container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitkon/form-container/issues/39/comments","statuses_url":"https://api.github.com/repos/vitkon/form-container/statuses/ab531396648ec489c8ba28daecf6f40f697da500","head":{"label":"vitkon:issue/33-add-warnings-no-breaking-change","ref":"issue/33-add-warnings-no-breaking-change","sha":"ab531396648ec489c8ba28daecf6f40f697da500","user":{"login":"vitkon","id":1713356,"avatar_url":"https://avatars0.githubusercontent.com/u/1713356?v=4","gravatar_id":"","url":"https://api.github.com/users/vitkon","html_url":"https://github.com/vitkon","followers_url":"https://api.github.com/users/vitkon/followers","following_url":"https://api.github.com/users/vitkon/following{/other_user}","gists_url":"https://api.github.com/users/vitkon/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkon/subscriptions","organizations_url":"https://api.github.com/users/vitkon/orgs","repos_url":"https://api.github.com/users/vitkon/repos","events_url":"https://api.github.com/users/vitkon/events{/privacy}","received_events_url":"https://api.github.com/users/vitkon/received_events","type":"User","site_admin":false},"repo":{"id":110903801,"name":"form-container","full_name":"vitkon/form-container","owner":{"login":"vitkon","id":1713356,"avatar_url":"https://avatars0.githubusercontent.com/u/1713356?v=4","gravatar_id":"","url":"https://api.github.com/users/vitkon","html_url":"https://github.com/vitkon","followers_url":"https://api.github.com/users/vitkon/followers","following_url":"https://api.github.com/users/vitkon/following{/other_user}","gists_url":"https://api.github.com/users/vitkon/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkon/subscriptions","organizations_url":"https://api.github.com/users/vitkon/orgs","repos_url":"https://api.github.com/users/vitkon/repos","events_url":"https://api.github.com/users/vitkon/events{/privacy}","received_events_url":"https://api.github.com/users/vitkon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitkon/form-container","description":"Lightweight React form container with validation (written in TypeScript)","fork":false,"url":"https://api.github.com/repos/vitkon/form-container","forks_url":"https://api.github.com/repos/vitkon/form-container/forks","keys_url":"https://api.github.com/repos/vitkon/form-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitkon/form-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitkon/form-container/teams","hooks_url":"https://api.github.com/repos/vitkon/form-container/hooks","issue_events_url":"https://api.github.com/repos/vitkon/form-container/issues/events{/number}","events_url":"https://api.github.com/repos/vitkon/form-container/events","assignees_url":"https://api.github.com/repos/vitkon/form-container/assignees{/user}","branches_url":"https://api.github.com/repos/vitkon/form-container/branches{/branch}","tags_url":"https://api.github.com/repos/vitkon/form-container/tags","blobs_url":"https://api.github.com/repos/vitkon/form-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitkon/form-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitkon/form-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitkon/form-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitkon/form-container/statuses/{sha}","languages_url":"https://api.github.com/repos/vitkon/form-container/languages","stargazers_url":"https://api.github.com/repos/vitkon/form-container/stargazers","contributors_url":"https://api.github.com/repos/vitkon/form-container/contributors","subscribers_url":"https://api.github.com/repos/vitkon/form-container/subscribers","subscription_url":"https://api.github.com/repos/vitkon/form-container/subscription","commits_url":"https://api.github.com/repos/vitkon/form-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitkon/form-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitkon/form-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitkon/form-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitkon/form-container/contents/{+path}","compare_url":"https://api.github.com/repos/vitkon/form-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitkon/form-container/merges","archive_url":"https://api.github.com/repos/vitkon/form-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitkon/form-container/downloads","issues_url":"https://api.github.com/repos/vitkon/form-container/issues{/number}","pulls_url":"https://api.github.com/repos/vitkon/form-container/pulls{/number}","milestones_url":"https://api.github.com/repos/vitkon/form-container/milestones{/number}","notifications_url":"https://api.github.com/repos/vitkon/form-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitkon/form-container/labels{/name}","releases_url":"https://api.github.com/repos/vitkon/form-container/releases{/id}","deployments_url":"https://api.github.com/repos/vitkon/form-container/deployments","created_at":"2017-11-16T00:45:25Z","updated_at":"2018-03-21T08:57:53Z","pushed_at":"2018-03-22T10:27:28Z","git_url":"git://github.com/vitkon/form-container.git","ssh_url":"git@github.com:vitkon/form-container.git","clone_url":"https://github.com/vitkon/form-container.git","svn_url":"https://github.com/vitkon/form-container","homepage":null,"size":240,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"vitkon:master","ref":"master","sha":"a966415e9fb9f90ff5645d4b68cacf87b7d4401b","user":{"login":"vitkon","id":1713356,"avatar_url":"https://avatars0.githubusercontent.com/u/1713356?v=4","gravatar_id":"","url":"https://api.github.com/users/vitkon","html_url":"https://github.com/vitkon","followers_url":"https://api.github.com/users/vitkon/followers","following_url":"https://api.github.com/users/vitkon/following{/other_user}","gists_url":"https://api.github.com/users/vitkon/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkon/subscriptions","organizations_url":"https://api.github.com/users/vitkon/orgs","repos_url":"https://api.github.com/users/vitkon/repos","events_url":"https://api.github.com/users/vitkon/events{/privacy}","received_events_url":"https://api.github.com/users/vitkon/received_events","type":"User","site_admin":false},"repo":{"id":110903801,"name":"form-container","full_name":"vitkon/form-container","owner":{"login":"vitkon","id":1713356,"avatar_url":"https://avatars0.githubusercontent.com/u/1713356?v=4","gravatar_id":"","url":"https://api.github.com/users/vitkon","html_url":"https://github.com/vitkon","followers_url":"https://api.github.com/users/vitkon/followers","following_url":"https://api.github.com/users/vitkon/following{/other_user}","gists_url":"https://api.github.com/users/vitkon/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkon/subscriptions","organizations_url":"https://api.github.com/users/vitkon/orgs","repos_url":"https://api.github.com/users/vitkon/repos","events_url":"https://api.github.com/users/vitkon/events{/privacy}","received_events_url":"https://api.github.com/users/vitkon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitkon/form-container","description":"Lightweight React form container with validation (written in TypeScript)","fork":false,"url":"https://api.github.com/repos/vitkon/form-container","forks_url":"https://api.github.com/repos/vitkon/form-container/forks","keys_url":"https://api.github.com/repos/vitkon/form-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitkon/form-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitkon/form-container/teams","hooks_url":"https://api.github.com/repos/vitkon/form-container/hooks","issue_events_url":"https://api.github.com/repos/vitkon/form-container/issues/events{/number}","events_url":"https://api.github.com/repos/vitkon/form-container/events","assignees_url":"https://api.github.com/repos/vitkon/form-container/assignees{/user}","branches_url":"https://api.github.com/repos/vitkon/form-container/branches{/branch}","tags_url":"https://api.github.com/repos/vitkon/form-container/tags","blobs_url":"https://api.github.com/repos/vitkon/form-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitkon/form-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitkon/form-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitkon/form-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitkon/form-container/statuses/{sha}","languages_url":"https://api.github.com/repos/vitkon/form-container/languages","stargazers_url":"https://api.github.com/repos/vitkon/form-container/stargazers","contributors_url":"https://api.github.com/repos/vitkon/form-container/contributors","subscribers_url":"https://api.github.com/repos/vitkon/form-container/subscribers","subscription_url":"https://api.github.com/repos/vitkon/form-container/subscription","commits_url":"https://api.github.com/repos/vitkon/form-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitkon/form-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitkon/form-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitkon/form-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitkon/form-container/contents/{+path}","compare_url":"https://api.github.com/repos/vitkon/form-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitkon/form-container/merges","archive_url":"https://api.github.com/repos/vitkon/form-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitkon/form-container/downloads","issues_url":"https://api.github.com/repos/vitkon/form-container/issues{/number}","pulls_url":"https://api.github.com/repos/vitkon/form-container/pulls{/number}","milestones_url":"https://api.github.com/repos/vitkon/form-container/milestones{/number}","notifications_url":"https://api.github.com/repos/vitkon/form-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitkon/form-container/labels{/name}","releases_url":"https://api.github.com/repos/vitkon/form-container/releases{/id}","deployments_url":"https://api.github.com/repos/vitkon/form-container/deployments","created_at":"2017-11-16T00:45:25Z","updated_at":"2018-03-21T08:57:53Z","pushed_at":"2018-03-22T10:27:28Z","git_url":"git://github.com/vitkon/form-container.git","ssh_url":"git@github.com:vitkon/form-container.git","clone_url":"https://github.com/vitkon/form-container.git","svn_url":"https://github.com/vitkon/form-container","homepage":null,"size":240,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/39"},"html":{"href":"https://github.com/vitkon/form-container/pull/39"},"issue":{"href":"https://api.github.com/repos/vitkon/form-container/issues/39"},"comments":{"href":"https://api.github.com/repos/vitkon/form-container/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitkon/form-container/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/vitkon/form-container/statuses/ab531396648ec489c8ba28daecf6f40f697da500"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mattdell"}}