{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4","id":70392708,"html_url":"https://github.com/skogsbaer/xmlgen/pull/4","diff_url":"https://github.com/skogsbaer/xmlgen/pull/4.diff","patch_url":"https://github.com/skogsbaer/xmlgen/pull/4.patch","issue_url":"https://api.github.com/repos/skogsbaer/xmlgen/issues/4","number":4,"state":"closed","locked":false,"title":"Make benchmarks compile with modern criterion","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars2.githubusercontent.com/u/2364661?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"body":"Currently, the benchmarks fail to build:\n\n```\nPreprocessing library xmlgen-0.6.2.1...\n[1 of 1] Compiling Text.XML.Generator ( src/Text/XML/Generator.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.5.0/build/Text/XML/Generator.o )\nIn-place registering xmlgen-0.6.2.1...\nPreprocessing benchmark 'xmlgen-bench' for xmlgen-0.6.2.1...\n[1 of 1] Compiling Main             ( test/GeneratorBenchmarks.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.5.0/build/xmlgen-bench/xmlgen-bench-tmp/Main.o )\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:10:25:\n    Couldn't match type ‘[Char]’ with ‘T.Text’\n    Expected type: Name\n      Actual type: [Char]\n    In the first argument of ‘xelem’, namely ‘\"root\"’\n    In the expression: xelem \"root\"\n    In the expression:\n      xelem \"root\"\n      $ xelems\n        $ map\n            (\\ s -> xelem \"foo\" (xattr \"key\" s, xtext s))\n            (map (\\ i -> T.pack (show i)) [1 .. numberOfElems])\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:10:60:\n    Couldn't match type ‘[Char]’ with ‘T.Text’\n    Expected type: Name\n      Actual type: [Char]\n    In the first argument of ‘xelem’, namely ‘\"foo\"’\n    In the expression: xelem \"foo\" (xattr \"key\" s, xtext s)\n    In the first argument of ‘map’, namely\n      ‘(\\ s -> xelem \"foo\" (xattr \"key\" s, xtext s))’\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:10:73:\n    Couldn't match type ‘[Char]’ with ‘T.Text’\n    Expected type: Name\n      Actual type: [Char]\n    In the first argument of ‘xattr’, namely ‘\"key\"’\n    In the expression: xattr \"key\" s\n    In the second argument of ‘xelem’, namely\n      ‘(xattr \"key\" s, xtext s)’\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:14:25:\n    Couldn't match type ‘[Char]’ with ‘T.Text’\n    Expected type: Name\n      Actual type: [Char]\n    In the first argument of ‘xelem’, namely ‘\"root\"’\n    In the expression: xelem \"root\"\n    In the expression:\n      xelem \"root\"\n      $ xattrs\n        $ map\n            (\\ s -> xattr (\"key-\" ++ s) (T.pack s))\n            (map (\\ i -> show i) [1 .. numberOfElems])\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:14:61:\n    Couldn't match type ‘[Char]’ with ‘T.Text’\n    Expected type: Name\n      Actual type: [Char]\n    In the first argument of ‘xattr’, namely ‘(\"key-\" ++ s)’\n    In the expression: xattr (\"key-\" ++ s) (T.pack s)\n    In the first argument of ‘map’, namely\n      ‘(\\ s -> xattr (\"key-\" ++ s) (T.pack s))’\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:21:74:\n    Couldn't match expected type ‘Benchmarkable’\n                with actual type ‘IO ()’\n    In the second argument of ‘bench’, namely ‘(benchElems i)’\n    In the expression: bench (show i ++ \" elems\") (benchElems i)\n\n/nfs/home/crest-team/jenkins_workspaces/cutter/workspace/benchmark_stackage/label/CREST_cutter/.bench-build/lts-5.16/xmlgen-0.6.2.1/test/GeneratorBenchmarks.hs:22:74:\n    Couldn't match expected type ‘Benchmarkable’\n                with actual type ‘IO ()’\n    In the second argument of ‘bench’, namely ‘(benchAttrs i)’\n    In the expression: bench (show i ++ \" attrs\") (benchAttrs i)\n```\n\nI made some small tweaks to get things working again:\n- Use `whnfIO` from `criterion >= 1`\n- Account for the existence of `Text` in more places\n\nSee also https://github.com/iu-parfunc/sc-haskell/issues/7\n","created_at":"2016-05-17T16:56:17Z","updated_at":"2018-03-12T20:42:25Z","closed_at":"2018-03-12T20:42:25Z","merged_at":null,"merge_commit_sha":"66af87b241534c4e94794218141a883ad725eb96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4/commits","review_comments_url":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4/comments","review_comment_url":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skogsbaer/xmlgen/issues/4/comments","statuses_url":"https://api.github.com/repos/skogsbaer/xmlgen/statuses/e10a8c590608420f1f463cef2595583aa48514f0","head":{"label":"RyanGlScott:master","ref":"master","sha":"e10a8c590608420f1f463cef2595583aa48514f0","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars2.githubusercontent.com/u/2364661?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"skogsbaer:master","ref":"master","sha":"0c2dc63f2c325dcc425ba90f470c41055faf1bc2","user":{"login":"skogsbaer","id":567524,"avatar_url":"https://avatars0.githubusercontent.com/u/567524?v=4","gravatar_id":"","url":"https://api.github.com/users/skogsbaer","html_url":"https://github.com/skogsbaer","followers_url":"https://api.github.com/users/skogsbaer/followers","following_url":"https://api.github.com/users/skogsbaer/following{/other_user}","gists_url":"https://api.github.com/users/skogsbaer/gists{/gist_id}","starred_url":"https://api.github.com/users/skogsbaer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skogsbaer/subscriptions","organizations_url":"https://api.github.com/users/skogsbaer/orgs","repos_url":"https://api.github.com/users/skogsbaer/repos","events_url":"https://api.github.com/users/skogsbaer/events{/privacy}","received_events_url":"https://api.github.com/users/skogsbaer/received_events","type":"User","site_admin":false},"repo":{"id":1260659,"name":"xmlgen","full_name":"skogsbaer/xmlgen","owner":{"login":"skogsbaer","id":567524,"avatar_url":"https://avatars0.githubusercontent.com/u/567524?v=4","gravatar_id":"","url":"https://api.github.com/users/skogsbaer","html_url":"https://github.com/skogsbaer","followers_url":"https://api.github.com/users/skogsbaer/followers","following_url":"https://api.github.com/users/skogsbaer/following{/other_user}","gists_url":"https://api.github.com/users/skogsbaer/gists{/gist_id}","starred_url":"https://api.github.com/users/skogsbaer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skogsbaer/subscriptions","organizations_url":"https://api.github.com/users/skogsbaer/orgs","repos_url":"https://api.github.com/users/skogsbaer/repos","events_url":"https://api.github.com/users/skogsbaer/events{/privacy}","received_events_url":"https://api.github.com/users/skogsbaer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skogsbaer/xmlgen","description":"XML generator library for Haskell","fork":false,"url":"https://api.github.com/repos/skogsbaer/xmlgen","forks_url":"https://api.github.com/repos/skogsbaer/xmlgen/forks","keys_url":"https://api.github.com/repos/skogsbaer/xmlgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skogsbaer/xmlgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skogsbaer/xmlgen/teams","hooks_url":"https://api.github.com/repos/skogsbaer/xmlgen/hooks","issue_events_url":"https://api.github.com/repos/skogsbaer/xmlgen/issues/events{/number}","events_url":"https://api.github.com/repos/skogsbaer/xmlgen/events","assignees_url":"https://api.github.com/repos/skogsbaer/xmlgen/assignees{/user}","branches_url":"https://api.github.com/repos/skogsbaer/xmlgen/branches{/branch}","tags_url":"https://api.github.com/repos/skogsbaer/xmlgen/tags","blobs_url":"https://api.github.com/repos/skogsbaer/xmlgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skogsbaer/xmlgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skogsbaer/xmlgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/skogsbaer/xmlgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skogsbaer/xmlgen/statuses/{sha}","languages_url":"https://api.github.com/repos/skogsbaer/xmlgen/languages","stargazers_url":"https://api.github.com/repos/skogsbaer/xmlgen/stargazers","contributors_url":"https://api.github.com/repos/skogsbaer/xmlgen/contributors","subscribers_url":"https://api.github.com/repos/skogsbaer/xmlgen/subscribers","subscription_url":"https://api.github.com/repos/skogsbaer/xmlgen/subscription","commits_url":"https://api.github.com/repos/skogsbaer/xmlgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/skogsbaer/xmlgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/skogsbaer/xmlgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/skogsbaer/xmlgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/skogsbaer/xmlgen/contents/{+path}","compare_url":"https://api.github.com/repos/skogsbaer/xmlgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skogsbaer/xmlgen/merges","archive_url":"https://api.github.com/repos/skogsbaer/xmlgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skogsbaer/xmlgen/downloads","issues_url":"https://api.github.com/repos/skogsbaer/xmlgen/issues{/number}","pulls_url":"https://api.github.com/repos/skogsbaer/xmlgen/pulls{/number}","milestones_url":"https://api.github.com/repos/skogsbaer/xmlgen/milestones{/number}","notifications_url":"https://api.github.com/repos/skogsbaer/xmlgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skogsbaer/xmlgen/labels{/name}","releases_url":"https://api.github.com/repos/skogsbaer/xmlgen/releases{/id}","deployments_url":"https://api.github.com/repos/skogsbaer/xmlgen/deployments","created_at":"2011-01-16T16:02:11Z","updated_at":"2016-10-03T01:04:48Z","pushed_at":"2016-05-17T16:56:19Z","git_url":"git://github.com/skogsbaer/xmlgen.git","ssh_url":"git@github.com:skogsbaer/xmlgen.git","clone_url":"https://github.com/skogsbaer/xmlgen.git","svn_url":"https://github.com/skogsbaer/xmlgen","homepage":"","size":185,"stargazers_count":13,"watchers_count":13,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4"},"html":{"href":"https://github.com/skogsbaer/xmlgen/pull/4"},"issue":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/issues/4"},"comments":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/skogsbaer/xmlgen/statuses/e10a8c590608420f1f463cef2595583aa48514f0"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"RyanGlScott"}}