{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/comments/217708772","pull_request_review_id":155489814,"id":217708772,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcwODc3Mg==","diff_hunk":"@@ -30,12 +30,12 @@\n #   Remark displayed on Website\n #\n define smokeping::target (\n-  String $pagetitle,\n-  String $menu,\n-  String $hierarchy_parent,\n-  String $probe,\n-  String $host,\n-  String $remark,\n+  Optional[String] $pagetitle        = undef,","path":"manifests/target.pp","position":10,"original_position":10,"commit_id":"02a2f294b5a0a664617963083b7d9dbbc6ad54a9","original_commit_id":"02a2f294b5a0a664617963083b7d9dbbc6ad54a9","user":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"Should these be `String[1]` so it doesn't accept empty strings? Given empty strings are true since Puppet 4.","created_at":"2018-09-14T13:17:21Z","updated_at":"2018-09-14T13:17:21Z","html_url":"https://github.com/voxpupuli/puppet-smokeping/pull/99#discussion_r217708772","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/comments/217708772"},"html":{"href":"https://github.com/voxpupuli/puppet-smokeping/pull/99#discussion_r217708772"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99","id":215590424,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTkwNDI0","html_url":"https://github.com/voxpupuli/puppet-smokeping/pull/99","diff_url":"https://github.com/voxpupuli/puppet-smokeping/pull/99.diff","patch_url":"https://github.com/voxpupuli/puppet-smokeping/pull/99.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/99","number":99,"state":"open","locked":false,"title":"WIP: Fix smokeping::target type","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"body":"fixes #74\r\n\r\nhttps://github.com/voxpupuli/puppet-smokeping/pull/70 introduced a\r\nregression.  Several parameters were made mandatory (previously they\r\ndefaulted to an empty string.)\r\n\r\nThey are now `Optional` and default to `undef`.","created_at":"2018-09-14T13:14:16Z","updated_at":"2018-09-14T13:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d01d41871af016c6122524a517692bb1dee47585","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/99/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/statuses/02a2f294b5a0a664617963083b7d9dbbc6ad54a9","head":{"label":"alexjfisher:fix_target_type","ref":"fix_target_type","sha":"02a2f294b5a0a664617963083b7d9dbbc6ad54a9","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"repo":{"id":74033373,"node_id":"MDEwOlJlcG9zaXRvcnk3NDAzMzM3Mw==","name":"puppet-smokeping","full_name":"alexjfisher/puppet-smokeping","owner":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexjfisher/puppet-smokeping","description":"Puppet module to install and configure smokeping. Including target and slave definition","fork":true,"url":"https://api.github.com/repos/alexjfisher/puppet-smokeping","forks_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/forks","keys_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/teams","hooks_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/hooks","issue_events_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/issues/events{/number}","events_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/events","assignees_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/assignees{/user}","branches_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/branches{/branch}","tags_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/tags","blobs_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/statuses/{sha}","languages_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/languages","stargazers_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/stargazers","contributors_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/contributors","subscribers_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/subscribers","subscription_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/subscription","commits_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/contents/{+path}","compare_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/merges","archive_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/downloads","issues_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/issues{/number}","pulls_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/pulls{/number}","milestones_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/milestones{/number}","notifications_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/labels{/name}","releases_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/releases{/id}","deployments_url":"https://api.github.com/repos/alexjfisher/puppet-smokeping/deployments","created_at":"2016-11-17T14:13:44Z","updated_at":"2016-11-17T14:13:45Z","pushed_at":"2018-09-14T13:13:35Z","git_url":"git://github.com/alexjfisher/puppet-smokeping.git","ssh_url":"git@github.com:alexjfisher/puppet-smokeping.git","clone_url":"https://github.com/alexjfisher/puppet-smokeping.git","svn_url":"https://github.com/alexjfisher/puppet-smokeping","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"f190083e9a9cf2dc73d1610bdd5e524c0e495d9b","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":7918737,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE4NzM3","name":"puppet-smokeping","full_name":"voxpupuli/puppet-smokeping","owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-smokeping","description":"Puppet module to install and configure smokeping. Including target and slave definition","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-smokeping","forks_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-smokeping/deployments","created_at":"2013-01-30T16:41:04Z","updated_at":"2018-09-05T18:35:52Z","pushed_at":"2018-09-14T13:14:17Z","git_url":"git://github.com/voxpupuli/puppet-smokeping.git","ssh_url":"git@github.com:voxpupuli/puppet-smokeping.git","clone_url":"https://github.com/voxpupuli/puppet-smokeping.git","svn_url":"https://github.com/voxpupuli/puppet-smokeping","homepage":null,"size":255,"stargazers_count":12,"watchers_count":12,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99"},"html":{"href":"https://github.com/voxpupuli/puppet-smokeping/pull/99"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/99"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-smokeping/statuses/02a2f294b5a0a664617963083b7d9dbbc6ad54a9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ekohl"}}