{"action":"created","comment":{"url":"https://api.github.com/repos/dask/s3fs/pulls/comments/182404173","pull_request_review_id":113191014,"id":182404173,"diff_hunk":"@@ -938,13 +956,16 @@ class S3File(object):\n         S3 bucket/key to access\n     block_size : int\n         read-ahead size for finding delimiters\n-    fill_cache: bool\n+    fill_cache : bool\n         If seeking to new a part of the file beyond the current buffer,\n         with this True, the buffer will be filled between the sections to\n         best support random access. When reading only a few specific chunks\n         out of a file, performance may be better if False.\n     acl: str\n         Canned ACL to apply\n+    version_id : str\n+        Optional version to read the file at.  If not specified this will default to the current","path":"s3fs/core.py","position":105,"original_position":78,"commit_id":"54d44aa0ae0fe3ca31a3dbf3ad54977e7ac72bad","original_commit_id":"78912f00dd22b4179a1877edbf0dd31ca26eda94","user":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"body":"in a real s3 bucket its basically a big base64ish looking hash.  under moto its something like '0'","created_at":"2018-04-18T12:15:35Z","updated_at":"2018-04-18T12:15:35Z","html_url":"https://github.com/dask/s3fs/pull/121#discussion_r182404173","pull_request_url":"https://api.github.com/repos/dask/s3fs/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dask/s3fs/pulls/comments/182404173"},"html":{"href":"https://github.com/dask/s3fs/pull/121#discussion_r182404173"},"pull_request":{"href":"https://api.github.com/repos/dask/s3fs/pulls/121"}},"in_reply_to_id":175929431},"pull_request":{"url":"https://api.github.com/repos/dask/s3fs/pulls/121","id":176074035,"html_url":"https://github.com/dask/s3fs/pull/121","diff_url":"https://github.com/dask/s3fs/pull/121.diff","patch_url":"https://github.com/dask/s3fs/pull/121.patch","issue_url":"https://api.github.com/repos/dask/s3fs/issues/121","number":121,"state":"open","locked":false,"title":"Add support for bucket versioning","user":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"body":"When s3 is used with bucket versioning this adds additional safely to reading objects preventing potential inconsistent state when reading an object whilst something else writes to it.\r\n\r\nThis also adds a utility to specifically open a given version of the file.\r\n\r\nFor non-version enabled buckets this should have no change.","created_at":"2018-03-20T02:32:11Z","updated_at":"2018-04-18T12:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23a414c01718121001b5d6b3cc6000c1b4596e6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/s3fs/pulls/121/commits","review_comments_url":"https://api.github.com/repos/dask/s3fs/pulls/121/comments","review_comment_url":"https://api.github.com/repos/dask/s3fs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/s3fs/issues/121/comments","statuses_url":"https://api.github.com/repos/dask/s3fs/statuses/54d44aa0ae0fe3ca31a3dbf3ad54977e7ac72bad","head":{"label":"mariusvniekerk:versioned","ref":"versioned","sha":"54d44aa0ae0fe3ca31a3dbf3ad54977e7ac72bad","user":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"repo":{"id":89610526,"name":"s3fs","full_name":"mariusvniekerk/s3fs","owner":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariusvniekerk/s3fs","description":"S3 Filesystem ","fork":true,"url":"https://api.github.com/repos/mariusvniekerk/s3fs","forks_url":"https://api.github.com/repos/mariusvniekerk/s3fs/forks","keys_url":"https://api.github.com/repos/mariusvniekerk/s3fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariusvniekerk/s3fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariusvniekerk/s3fs/teams","hooks_url":"https://api.github.com/repos/mariusvniekerk/s3fs/hooks","issue_events_url":"https://api.github.com/repos/mariusvniekerk/s3fs/issues/events{/number}","events_url":"https://api.github.com/repos/mariusvniekerk/s3fs/events","assignees_url":"https://api.github.com/repos/mariusvniekerk/s3fs/assignees{/user}","branches_url":"https://api.github.com/repos/mariusvniekerk/s3fs/branches{/branch}","tags_url":"https://api.github.com/repos/mariusvniekerk/s3fs/tags","blobs_url":"https://api.github.com/repos/mariusvniekerk/s3fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariusvniekerk/s3fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariusvniekerk/s3fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariusvniekerk/s3fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariusvniekerk/s3fs/statuses/{sha}","languages_url":"https://api.github.com/repos/mariusvniekerk/s3fs/languages","stargazers_url":"https://api.github.com/repos/mariusvniekerk/s3fs/stargazers","contributors_url":"https://api.github.com/repos/mariusvniekerk/s3fs/contributors","subscribers_url":"https://api.github.com/repos/mariusvniekerk/s3fs/subscribers","subscription_url":"https://api.github.com/repos/mariusvniekerk/s3fs/subscription","commits_url":"https://api.github.com/repos/mariusvniekerk/s3fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariusvniekerk/s3fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariusvniekerk/s3fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariusvniekerk/s3fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariusvniekerk/s3fs/contents/{+path}","compare_url":"https://api.github.com/repos/mariusvniekerk/s3fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariusvniekerk/s3fs/merges","archive_url":"https://api.github.com/repos/mariusvniekerk/s3fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariusvniekerk/s3fs/downloads","issues_url":"https://api.github.com/repos/mariusvniekerk/s3fs/issues{/number}","pulls_url":"https://api.github.com/repos/mariusvniekerk/s3fs/pulls{/number}","milestones_url":"https://api.github.com/repos/mariusvniekerk/s3fs/milestones{/number}","notifications_url":"https://api.github.com/repos/mariusvniekerk/s3fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariusvniekerk/s3fs/labels{/name}","releases_url":"https://api.github.com/repos/mariusvniekerk/s3fs/releases{/id}","deployments_url":"https://api.github.com/repos/mariusvniekerk/s3fs/deployments","created_at":"2017-04-27T15:07:15Z","updated_at":"2017-04-27T15:07:16Z","pushed_at":"2018-03-20T14:04:10Z","git_url":"git://github.com/mariusvniekerk/s3fs.git","ssh_url":"git@github.com:mariusvniekerk/s3fs.git","clone_url":"https://github.com/mariusvniekerk/s3fs.git","svn_url":"https://github.com/mariusvniekerk/s3fs","homepage":"http://s3fs.readthedocs.io/en/latest/","size":301,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"c5a4863d11e69200630d9c937e6e49dedaf5108f","user":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":53987953,"name":"s3fs","full_name":"dask/s3fs","owner":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dask/s3fs","description":"S3 Filesystem ","fork":false,"url":"https://api.github.com/repos/dask/s3fs","forks_url":"https://api.github.com/repos/dask/s3fs/forks","keys_url":"https://api.github.com/repos/dask/s3fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/s3fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/s3fs/teams","hooks_url":"https://api.github.com/repos/dask/s3fs/hooks","issue_events_url":"https://api.github.com/repos/dask/s3fs/issues/events{/number}","events_url":"https://api.github.com/repos/dask/s3fs/events","assignees_url":"https://api.github.com/repos/dask/s3fs/assignees{/user}","branches_url":"https://api.github.com/repos/dask/s3fs/branches{/branch}","tags_url":"https://api.github.com/repos/dask/s3fs/tags","blobs_url":"https://api.github.com/repos/dask/s3fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/s3fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/s3fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/s3fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/s3fs/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/s3fs/languages","stargazers_url":"https://api.github.com/repos/dask/s3fs/stargazers","contributors_url":"https://api.github.com/repos/dask/s3fs/contributors","subscribers_url":"https://api.github.com/repos/dask/s3fs/subscribers","subscription_url":"https://api.github.com/repos/dask/s3fs/subscription","commits_url":"https://api.github.com/repos/dask/s3fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/s3fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/s3fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/s3fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/s3fs/contents/{+path}","compare_url":"https://api.github.com/repos/dask/s3fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/s3fs/merges","archive_url":"https://api.github.com/repos/dask/s3fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/s3fs/downloads","issues_url":"https://api.github.com/repos/dask/s3fs/issues{/number}","pulls_url":"https://api.github.com/repos/dask/s3fs/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/s3fs/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/s3fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/s3fs/labels{/name}","releases_url":"https://api.github.com/repos/dask/s3fs/releases{/id}","deployments_url":"https://api.github.com/repos/dask/s3fs/deployments","created_at":"2016-03-16T00:19:32Z","updated_at":"2018-04-12T08:18:15Z","pushed_at":"2018-04-03T13:08:56Z","git_url":"git://github.com/dask/s3fs.git","ssh_url":"git@github.com:dask/s3fs.git","clone_url":"https://github.com/dask/s3fs.git","svn_url":"https://github.com/dask/s3fs","homepage":"http://s3fs.readthedocs.io/en/latest/","size":304,"stargazers_count":81,"watchers_count":81,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":14,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/s3fs/pulls/121"},"html":{"href":"https://github.com/dask/s3fs/pull/121"},"issue":{"href":"https://api.github.com/repos/dask/s3fs/issues/121"},"comments":{"href":"https://api.github.com/repos/dask/s3fs/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/s3fs/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/s3fs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/s3fs/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/dask/s3fs/statuses/54d44aa0ae0fe3ca31a3dbf3ad54977e7ac72bad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mariusvniekerk"}}