{"action":"closed","number":1723,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723","id":240812759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODEyNzU5","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/1723","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/1723.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/1723.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/1723","number":1723,"state":"closed","locked":false,"title":"Use StatusOr<T> to return errors.","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"Most of the code was using `std::pair<Status, T>`, but now that we have a\r\n`StatusOr<T>` template class this is a much better representation. There is\r\nno impact to the public API in this PR, as all functions affected are\r\neither in `storage::internal`, or they were private functions.\r\n\r\nSorry for the monster PR, I cannot figure out a way to break this down without\r\ncreating a lot of busy work.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/googlecloudplatform/google-cloud-cpp/1723)\n<!-- Reviewable:end -->\n","created_at":"2018-12-24T21:42:55Z","updated_at":"2018-12-27T13:18:47Z","closed_at":"2018-12-27T13:18:47Z","merged_at":"2018-12-27T13:18:47Z","merge_commit_sha":"2c63872d2932a5df70c998358f16890ac4c3c575","assignee":null,"assignees":[],"requested_reviewers":[{"login":"devjgm","id":9447643,"node_id":"MDQ6VXNlcjk0NDc2NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/9447643?v=4","gravatar_id":"","url":"https://api.github.com/users/devjgm","html_url":"https://github.com/devjgm","followers_url":"https://api.github.com/users/devjgm/followers","following_url":"https://api.github.com/users/devjgm/following{/other_user}","gists_url":"https://api.github.com/users/devjgm/gists{/gist_id}","starred_url":"https://api.github.com/users/devjgm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devjgm/subscriptions","organizations_url":"https://api.github.com/users/devjgm/orgs","repos_url":"https://api.github.com/users/devjgm/repos","events_url":"https://api.github.com/users/devjgm/events{/privacy}","received_events_url":"https://api.github.com/users/devjgm/received_events","type":"User","site_admin":false},{"login":"houglum","id":14894525,"node_id":"MDQ6VXNlcjE0ODk0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/14894525?v=4","gravatar_id":"","url":"https://api.github.com/users/houglum","html_url":"https://github.com/houglum","followers_url":"https://api.github.com/users/houglum/followers","following_url":"https://api.github.com/users/houglum/following{/other_user}","gists_url":"https://api.github.com/users/houglum/gists{/gist_id}","starred_url":"https://api.github.com/users/houglum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houglum/subscriptions","organizations_url":"https://api.github.com/users/houglum/orgs","repos_url":"https://api.github.com/users/houglum/repos","events_url":"https://api.github.com/users/houglum/events{/privacy}","received_events_url":"https://api.github.com/users/houglum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":921026962,"node_id":"MDU6TGFiZWw5MjEwMjY5NjI=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/api:%20storage","name":"api: storage","color":"d4c5f9","default":false},{"id":760104389,"node_id":"MDU6TGFiZWw3NjAxMDQzODk=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/1723/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/6818d498f9094d5b78b4dad43cb83e6833627f04","head":{"label":"coryan:use-status-or-in-raw-client","ref":"use-status-or-in-raw-client","sha":"6818d498f9094d5b78b4dad43cb83e6833627f04","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"repo":{"id":111937615,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5Mzc2MTU=","name":"google-cloud-cpp","full_name":"coryan/google-cloud-cpp","private":false,"owner":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coryan/google-cloud-cpp","description":"Google Cloud Platform C++ client libraries","fork":true,"url":"https://api.github.com/repos/coryan/google-cloud-cpp","forks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/coryan/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coryan/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coryan/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/coryan/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coryan/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/coryan/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/coryan/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coryan/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/coryan/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coryan/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/coryan/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/coryan/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/coryan/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coryan/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/coryan/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/deployments","created_at":"2017-11-24T16:28:07Z","updated_at":"2018-12-22T13:20:55Z","pushed_at":"2018-12-27T04:18:54Z","git_url":"git://github.com/coryan/google-cloud-cpp.git","ssh_url":"git@github.com:coryan/google-cloud-cpp.git","clone_url":"https://github.com/coryan/google-cloud-cpp.git","svn_url":"https://github.com/coryan/google-cloud-cpp","homepage":"https://cloud.google.com/","size":100496,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"776bfeed8160b0012ff54c15f1dde976da156ed9","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":111860063,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjAwNjM=","name":"google-cloud-cpp","full_name":"GoogleCloudPlatform/google-cloud-cpp","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","description":"Google Cloud Client Library for C++","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/deployments","created_at":"2017-11-24T00:19:31Z","updated_at":"2018-12-27T03:13:14Z","pushed_at":"2018-12-27T13:18:47Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-cpp.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-cpp.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","homepage":"https://cloud.google.com/","size":96129,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":223,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":223,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/1723"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/1723"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/1723/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/1723/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/6818d498f9094d5b78b4dad43cb83e6833627f04"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"comments":2,"review_comments":14,"maintainer_can_modify":false,"commits":2,"additions":1131,"deletions":1363,"changed_files":55}}
{"actor":{"display_login":"coryan"}}