{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/performance-timeline/pulls/comments/241823573","pull_request_review_id":185199044,"id":241823573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTgyMzU3Mw==","diff_hunk":"@@ -139,14 +139,31 @@ <h2>Introduction</h2>\n         // Display them to the console.\n         .forEach(console.log);\n       // Disconnect after processing the events.\n-      observer.disconnect();\n+      userTimingObserver.disconnect();\n     });\n-    // Retrieve buffered events and subscribe to new events\n-    // for Resource-Timing and User-Timing\n-    observer.observe({\n-      entryTypes: [\"resource\", \"mark\", \"measure\"],\n-      buffered: true\n+    // Subscribe to new events for User-Timing.\n+    userTimingObserver.observe({entryTypes: [\"mark\", \"measure\"]});\n+    const resourceObserver = new PerformanceObserver(list =&gt; {\n+      list\n+        .getEntries()\n+        // Get the values we are interested in\n+        .map(({ name, startTime, fetchStart, responseStart, responseEnd }) =&gt; {\n+          const obj = {\n+            \"Name\": name,\n+            \"Start Time\": startTime,\n+            \"Fetch Start\": fetchStart,\n+            \"Response Start\": responseStart,\n+            \"Response End\": responseEnd,\n+          };\n+          return JSON.stringify(obj, null, 2);\n+        })\n+        // Display them to the console.\n+        .forEach(console.log);\n+      // Disconnect after processing the events.\n+      resourceObserver.disconnect();\n     });\n+    // Retrieve buffered events and subscribe to never events for Resource Timing.","path":"index.html","position":42,"original_position":42,"commit_id":"5ceb3addcba031245ac06a50a82626c79b19b4c7","original_commit_id":"5ceb3addcba031245ac06a50a82626c79b19b4c7","user":{"login":"yoavweiss","id":786187,"node_id":"MDQ6VXNlcjc4NjE4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/786187?v=4","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"body":"s/never/newer/","created_at":"2018-12-14T17:01:50Z","updated_at":"2018-12-14T17:01:50Z","html_url":"https://github.com/w3c/performance-timeline/pull/112#discussion_r241823573","pull_request_url":"https://api.github.com/repos/w3c/performance-timeline/pulls/112","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/comments/241823573"},"html":{"href":"https://github.com/w3c/performance-timeline/pull/112#discussion_r241823573"},"pull_request":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/performance-timeline/pulls/112","id":236922174,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTIyMTc0","html_url":"https://github.com/w3c/performance-timeline/pull/112","diff_url":"https://github.com/w3c/performance-timeline/pull/112.diff","patch_url":"https://github.com/w3c/performance-timeline/pull/112.patch","issue_url":"https://api.github.com/repos/w3c/performance-timeline/issues/112","number":112,"state":"open","locked":false,"title":"Add |type| to PerformanceObserverInit","user":{"login":"npm1","id":25042744,"node_id":"MDQ6VXNlcjI1MDQyNzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/25042744?v=4","gravatar_id":"","url":"https://api.github.com/users/npm1","html_url":"https://github.com/npm1","followers_url":"https://api.github.com/users/npm1/followers","following_url":"https://api.github.com/users/npm1/following{/other_user}","gists_url":"https://api.github.com/users/npm1/gists{/gist_id}","starred_url":"https://api.github.com/users/npm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm1/subscriptions","organizations_url":"https://api.github.com/users/npm1/orgs","repos_url":"https://api.github.com/users/npm1/repos","events_url":"https://api.github.com/users/npm1/events{/privacy}","received_events_url":"https://api.github.com/users/npm1/received_events","type":"User","site_admin":false},"body":"This change introduces a DOMString type in PerformanceObserverInit to support observing a single entryType with other parameters from the dictionary. The change modifies the observe() method so that:\n* observe({entryTypes:...}) is still supported but not with any other member of the PerformanceObserverInit dictionary.\n* observe({type: ...}) is now supported, and multiple calls stack.\n* Both ways to call observe() cannot be mixed. That is, an observer has to stick to one of the ways, and 'observer type' is introduced to enforce this.\n\nIn addition, some nits are fixed along the way, such as using <var> and <a> appropriately throughout.\nSolves https://github.com/w3c/performance-timeline/issues/103\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/npm1/performance-timeline/pull/112.html\" title=\"Last updated on Dec 12, 2018, 4:38 PM GMT (5ceb3ad)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/performance-timeline/112/520de3e...npm1:5ceb3ad.html\" title=\"Last updated on Dec 12, 2018, 4:38 PM GMT (5ceb3ad)\">Diff</a>","created_at":"2018-12-07T16:25:17Z","updated_at":"2018-12-14T17:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13fbc9c376575173a847945315a7a9643cbdfae0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/performance-timeline/pulls/112/commits","review_comments_url":"https://api.github.com/repos/w3c/performance-timeline/pulls/112/comments","review_comment_url":"https://api.github.com/repos/w3c/performance-timeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/performance-timeline/issues/112/comments","statuses_url":"https://api.github.com/repos/w3c/performance-timeline/statuses/5ceb3addcba031245ac06a50a82626c79b19b4c7","head":{"label":"npm1:patch-6","ref":"patch-6","sha":"5ceb3addcba031245ac06a50a82626c79b19b4c7","user":{"login":"npm1","id":25042744,"node_id":"MDQ6VXNlcjI1MDQyNzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/25042744?v=4","gravatar_id":"","url":"https://api.github.com/users/npm1","html_url":"https://github.com/npm1","followers_url":"https://api.github.com/users/npm1/followers","following_url":"https://api.github.com/users/npm1/following{/other_user}","gists_url":"https://api.github.com/users/npm1/gists{/gist_id}","starred_url":"https://api.github.com/users/npm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm1/subscriptions","organizations_url":"https://api.github.com/users/npm1/orgs","repos_url":"https://api.github.com/users/npm1/repos","events_url":"https://api.github.com/users/npm1/events{/privacy}","received_events_url":"https://api.github.com/users/npm1/received_events","type":"User","site_admin":false},"repo":{"id":112365763,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNjU3NjM=","name":"performance-timeline","full_name":"npm1/performance-timeline","private":false,"owner":{"login":"npm1","id":25042744,"node_id":"MDQ6VXNlcjI1MDQyNzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/25042744?v=4","gravatar_id":"","url":"https://api.github.com/users/npm1","html_url":"https://github.com/npm1","followers_url":"https://api.github.com/users/npm1/followers","following_url":"https://api.github.com/users/npm1/following{/other_user}","gists_url":"https://api.github.com/users/npm1/gists{/gist_id}","starred_url":"https://api.github.com/users/npm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm1/subscriptions","organizations_url":"https://api.github.com/users/npm1/orgs","repos_url":"https://api.github.com/users/npm1/repos","events_url":"https://api.github.com/users/npm1/events{/privacy}","received_events_url":"https://api.github.com/users/npm1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/npm1/performance-timeline","description":"Performance timeline spec from webperf","fork":true,"url":"https://api.github.com/repos/npm1/performance-timeline","forks_url":"https://api.github.com/repos/npm1/performance-timeline/forks","keys_url":"https://api.github.com/repos/npm1/performance-timeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm1/performance-timeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm1/performance-timeline/teams","hooks_url":"https://api.github.com/repos/npm1/performance-timeline/hooks","issue_events_url":"https://api.github.com/repos/npm1/performance-timeline/issues/events{/number}","events_url":"https://api.github.com/repos/npm1/performance-timeline/events","assignees_url":"https://api.github.com/repos/npm1/performance-timeline/assignees{/user}","branches_url":"https://api.github.com/repos/npm1/performance-timeline/branches{/branch}","tags_url":"https://api.github.com/repos/npm1/performance-timeline/tags","blobs_url":"https://api.github.com/repos/npm1/performance-timeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm1/performance-timeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm1/performance-timeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm1/performance-timeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm1/performance-timeline/statuses/{sha}","languages_url":"https://api.github.com/repos/npm1/performance-timeline/languages","stargazers_url":"https://api.github.com/repos/npm1/performance-timeline/stargazers","contributors_url":"https://api.github.com/repos/npm1/performance-timeline/contributors","subscribers_url":"https://api.github.com/repos/npm1/performance-timeline/subscribers","subscription_url":"https://api.github.com/repos/npm1/performance-timeline/subscription","commits_url":"https://api.github.com/repos/npm1/performance-timeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm1/performance-timeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm1/performance-timeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm1/performance-timeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm1/performance-timeline/contents/{+path}","compare_url":"https://api.github.com/repos/npm1/performance-timeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm1/performance-timeline/merges","archive_url":"https://api.github.com/repos/npm1/performance-timeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm1/performance-timeline/downloads","issues_url":"https://api.github.com/repos/npm1/performance-timeline/issues{/number}","pulls_url":"https://api.github.com/repos/npm1/performance-timeline/pulls{/number}","milestones_url":"https://api.github.com/repos/npm1/performance-timeline/milestones{/number}","notifications_url":"https://api.github.com/repos/npm1/performance-timeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm1/performance-timeline/labels{/name}","releases_url":"https://api.github.com/repos/npm1/performance-timeline/releases{/id}","deployments_url":"https://api.github.com/repos/npm1/performance-timeline/deployments","created_at":"2017-11-28T17:18:42Z","updated_at":"2018-10-10T17:27:00Z","pushed_at":"2018-12-12T16:38:14Z","git_url":"git://github.com/npm1/performance-timeline.git","ssh_url":"git@github.com:npm1/performance-timeline.git","clone_url":"https://github.com/npm1/performance-timeline.git","svn_url":"https://github.com/npm1/performance-timeline","homepage":"https://w3c.github.io/performance-timeline/","size":299,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"520de3e441177d029cd847dddf8c210533b0e7a0","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":24511341,"node_id":"MDEwOlJlcG9zaXRvcnkyNDUxMTM0MQ==","name":"performance-timeline","full_name":"w3c/performance-timeline","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/performance-timeline","description":"Performance timeline spec from webperf","fork":false,"url":"https://api.github.com/repos/w3c/performance-timeline","forks_url":"https://api.github.com/repos/w3c/performance-timeline/forks","keys_url":"https://api.github.com/repos/w3c/performance-timeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/performance-timeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/performance-timeline/teams","hooks_url":"https://api.github.com/repos/w3c/performance-timeline/hooks","issue_events_url":"https://api.github.com/repos/w3c/performance-timeline/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/performance-timeline/events","assignees_url":"https://api.github.com/repos/w3c/performance-timeline/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/performance-timeline/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/performance-timeline/tags","blobs_url":"https://api.github.com/repos/w3c/performance-timeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/performance-timeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/performance-timeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/performance-timeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/performance-timeline/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/performance-timeline/languages","stargazers_url":"https://api.github.com/repos/w3c/performance-timeline/stargazers","contributors_url":"https://api.github.com/repos/w3c/performance-timeline/contributors","subscribers_url":"https://api.github.com/repos/w3c/performance-timeline/subscribers","subscription_url":"https://api.github.com/repos/w3c/performance-timeline/subscription","commits_url":"https://api.github.com/repos/w3c/performance-timeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/performance-timeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/performance-timeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/performance-timeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/performance-timeline/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/performance-timeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/performance-timeline/merges","archive_url":"https://api.github.com/repos/w3c/performance-timeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/performance-timeline/downloads","issues_url":"https://api.github.com/repos/w3c/performance-timeline/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/performance-timeline/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/performance-timeline/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/performance-timeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/performance-timeline/labels{/name}","releases_url":"https://api.github.com/repos/w3c/performance-timeline/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/performance-timeline/deployments","created_at":"2014-09-26T18:48:58Z","updated_at":"2018-12-12T20:38:38Z","pushed_at":"2018-12-12T16:38:15Z","git_url":"git://github.com/w3c/performance-timeline.git","ssh_url":"git@github.com:w3c/performance-timeline.git","clone_url":"https://github.com/w3c/performance-timeline.git","svn_url":"https://github.com/w3c/performance-timeline","homepage":"https://w3c.github.io/performance-timeline/","size":258,"stargazers_count":58,"watchers_count":58,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":9,"watchers":58,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/112"},"html":{"href":"https://github.com/w3c/performance-timeline/pull/112"},"issue":{"href":"https://api.github.com/repos/w3c/performance-timeline/issues/112"},"comments":{"href":"https://api.github.com/repos/w3c/performance-timeline/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/performance-timeline/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/performance-timeline/statuses/5ceb3addcba031245ac06a50a82626c79b19b4c7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yoavweiss"}}