{"action":"opened","number":5008,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/5008","id":195207916,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjA3OTE2","html_url":"https://github.com/syncthing/syncthing/pull/5008","diff_url":"https://github.com/syncthing/syncthing/pull/5008.diff","patch_url":"https://github.com/syncthing/syncthing/pull/5008.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/5008","number":5008,"state":"open","locked":false,"title":"lib/db: Remove updated invalid files from need bucket (fixes #5007)","user":{"login":"imsodin","id":15955093,"node_id":"MDQ6VXNlcjE1OTU1MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/15955093?v=4","gravatar_id":"","url":"https://api.github.com/users/imsodin","html_url":"https://github.com/imsodin","followers_url":"https://api.github.com/users/imsodin/followers","following_url":"https://api.github.com/users/imsodin/following{/other_user}","gists_url":"https://api.github.com/users/imsodin/gists{/gist_id}","starred_url":"https://api.github.com/users/imsodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsodin/subscriptions","organizations_url":"https://api.github.com/users/imsodin/orgs","repos_url":"https://api.github.com/users/imsodin/repos","events_url":"https://api.github.com/users/imsodin/events{/privacy}","received_events_url":"https://api.github.com/users/imsodin/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nFixes #5007, Also in the puller updating invalid files wasn't considered a change, so in the logs it looks like everything works fine in the puller, while it doesn't.\r\n\r\nAn additional problem is, that for RC users that had an update to ignored files while using the newest rc the need bucket is out of sync with reality. That requires either manual db backup/rest by the user or a db transition just for DBs exactly at version 4 (?). I can do that, just not today anymore.\r\n\r\n### Testing\r\n\r\nUnit test.","created_at":"2018-06-15T15:22:07Z","updated_at":"2018-06-15T15:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syncthing/syncthing/pulls/5008/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing/pulls/5008/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/5008/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/437f4b1971dcb6d769d288dafdd99e0b4fbe7871","head":{"label":"imsodin:needFix","ref":"needFix","sha":"437f4b1971dcb6d769d288dafdd99e0b4fbe7871","user":{"login":"imsodin","id":15955093,"node_id":"MDQ6VXNlcjE1OTU1MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/15955093?v=4","gravatar_id":"","url":"https://api.github.com/users/imsodin","html_url":"https://github.com/imsodin","followers_url":"https://api.github.com/users/imsodin/followers","following_url":"https://api.github.com/users/imsodin/following{/other_user}","gists_url":"https://api.github.com/users/imsodin/gists{/gist_id}","starred_url":"https://api.github.com/users/imsodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsodin/subscriptions","organizations_url":"https://api.github.com/users/imsodin/orgs","repos_url":"https://api.github.com/users/imsodin/repos","events_url":"https://api.github.com/users/imsodin/events{/privacy}","received_events_url":"https://api.github.com/users/imsodin/received_events","type":"User","site_admin":false},"repo":{"id":71178615,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE3ODYxNQ==","name":"syncthing","full_name":"imsodin/syncthing","owner":{"login":"imsodin","id":15955093,"node_id":"MDQ6VXNlcjE1OTU1MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/15955093?v=4","gravatar_id":"","url":"https://api.github.com/users/imsodin","html_url":"https://github.com/imsodin","followers_url":"https://api.github.com/users/imsodin/followers","following_url":"https://api.github.com/users/imsodin/following{/other_user}","gists_url":"https://api.github.com/users/imsodin/gists{/gist_id}","starred_url":"https://api.github.com/users/imsodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsodin/subscriptions","organizations_url":"https://api.github.com/users/imsodin/orgs","repos_url":"https://api.github.com/users/imsodin/repos","events_url":"https://api.github.com/users/imsodin/events{/privacy}","received_events_url":"https://api.github.com/users/imsodin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imsodin/syncthing","description":"Open Source Continuous File Synchronization","fork":true,"url":"https://api.github.com/repos/imsodin/syncthing","forks_url":"https://api.github.com/repos/imsodin/syncthing/forks","keys_url":"https://api.github.com/repos/imsodin/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imsodin/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imsodin/syncthing/teams","hooks_url":"https://api.github.com/repos/imsodin/syncthing/hooks","issue_events_url":"https://api.github.com/repos/imsodin/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/imsodin/syncthing/events","assignees_url":"https://api.github.com/repos/imsodin/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/imsodin/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/imsodin/syncthing/tags","blobs_url":"https://api.github.com/repos/imsodin/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imsodin/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imsodin/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/imsodin/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imsodin/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/imsodin/syncthing/languages","stargazers_url":"https://api.github.com/repos/imsodin/syncthing/stargazers","contributors_url":"https://api.github.com/repos/imsodin/syncthing/contributors","subscribers_url":"https://api.github.com/repos/imsodin/syncthing/subscribers","subscription_url":"https://api.github.com/repos/imsodin/syncthing/subscription","commits_url":"https://api.github.com/repos/imsodin/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/imsodin/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/imsodin/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/imsodin/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/imsodin/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/imsodin/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imsodin/syncthing/merges","archive_url":"https://api.github.com/repos/imsodin/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imsodin/syncthing/downloads","issues_url":"https://api.github.com/repos/imsodin/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/imsodin/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/imsodin/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/imsodin/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imsodin/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/imsodin/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/imsodin/syncthing/deployments","created_at":"2016-10-17T20:31:36Z","updated_at":"2018-06-10T10:04:15Z","pushed_at":"2018-06-15T15:18:29Z","git_url":"git://github.com/imsodin/syncthing.git","ssh_url":"git@github.com:imsodin/syncthing.git","clone_url":"https://github.com/imsodin/syncthing.git","svn_url":"https://github.com/imsodin/syncthing","homepage":"http://forum.syncthing.net/","size":98012,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"793b86e6040299778c245c525d7f4720a6998d0f","user":{"login":"syncthing","id":7628018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MjgwMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7628018?v=4","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":14712850,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMjg1MA==","name":"syncthing","full_name":"syncthing/syncthing","owner":{"login":"syncthing","id":7628018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MjgwMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7628018?v=4","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing","description":"Open Source Continuous File Synchronization","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing","forks_url":"https://api.github.com/repos/syncthing/syncthing/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/syncthing/syncthing/deployments","created_at":"2013-11-26T09:48:21Z","updated_at":"2018-06-15T14:46:22Z","pushed_at":"2018-06-15T12:37:46Z","git_url":"git://github.com/syncthing/syncthing.git","ssh_url":"git@github.com:syncthing/syncthing.git","clone_url":"https://github.com/syncthing/syncthing.git","svn_url":"https://github.com/syncthing/syncthing","homepage":"https://forum.syncthing.net/","size":96392,"stargazers_count":20916,"watchers_count":20916,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1782,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1782,"open_issues":238,"watchers":20916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5008"},"html":{"href":"https://github.com/syncthing/syncthing/pull/5008"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/5008"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/5008/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5008/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5008/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing/statuses/437f4b1971dcb6d769d288dafdd99e0b4fbe7871"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":33,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"imsodin"}}