{"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/211326878","pull_request_review_id":147723666,"id":211326878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTMyNjg3OA==","diff_hunk":"@@ -45,45 +45,44 @@ uint32_t GarbageCollector::Unlink() {\n \n   // Get the completed transactions from the TransactionManager\n   std::queue<transaction::TransactionContext *> from_txn_manager = txn_manager_->CompletedTransactions();\n-\n   // Append to our local unlink queue\n   while (!from_txn_manager.empty()) {\n     txn = from_txn_manager.front();\n     from_txn_manager.pop();\n     txns_to_unlink_.push(txn);\n   }\n \n-  uint32_t txns_cleared = 0;\n+  uint32_t txns_unlinked = 0;","path":"src/storage/garbage_collector.cpp","position":13,"original_position":13,"commit_id":"de74296ee908f26e2a40b6a84ce3ef4551f55a04","original_commit_id":"de74296ee908f26e2a40b6a84ce3ef4551f55a04","user":{"login":"mbutrovich","id":6855576,"node_id":"MDQ6VXNlcjY4NTU1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6855576?v=4","gravatar_id":"","url":"https://api.github.com/users/mbutrovich","html_url":"https://github.com/mbutrovich","followers_url":"https://api.github.com/users/mbutrovich/followers","following_url":"https://api.github.com/users/mbutrovich/following{/other_user}","gists_url":"https://api.github.com/users/mbutrovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mbutrovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbutrovich/subscriptions","organizations_url":"https://api.github.com/users/mbutrovich/orgs","repos_url":"https://api.github.com/users/mbutrovich/repos","events_url":"https://api.github.com/users/mbutrovich/events{/privacy}","received_events_url":"https://api.github.com/users/mbutrovich/received_events","type":"User","site_admin":false},"body":"Good rename","created_at":"2018-08-20T16:31:01Z","updated_at":"2018-08-20T16:33:26Z","html_url":"https://github.com/cmu-db/terrier/pull/116#discussion_r211326878","pull_request_url":"https://api.github.com/repos/cmu-db/terrier/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments/211326878"},"html":{"href":"https://github.com/cmu-db/terrier/pull/116#discussion_r211326878"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/terrier/pulls/116","id":209332421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzMyNDIx","html_url":"https://github.com/cmu-db/terrier/pull/116","diff_url":"https://github.com/cmu-db/terrier/pull/116.diff","patch_url":"https://github.com/cmu-db/terrier/pull/116.patch","issue_url":"https://api.github.com/repos/cmu-db/terrier/issues/116","number":116,"state":"open","locked":false,"title":"LargeTransactionTest framework refactor + large randomized GC tests","user":{"login":"tli2","id":12805799,"node_id":"MDQ6VXNlcjEyODA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12805799?v=4","gravatar_id":"","url":"https://api.github.com/users/tli2","html_url":"https://github.com/tli2","followers_url":"https://api.github.com/users/tli2/followers","following_url":"https://api.github.com/users/tli2/following{/other_user}","gists_url":"https://api.github.com/users/tli2/gists{/gist_id}","starred_url":"https://api.github.com/users/tli2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tli2/subscriptions","organizations_url":"https://api.github.com/users/tli2/orgs","repos_url":"https://api.github.com/users/tli2/repos","events_url":"https://api.github.com/users/tli2/events{/privacy}","received_events_url":"https://api.github.com/users/tli2/received_events","type":"User","site_admin":false},"body":"The framework we used to test concurrency control is adpated for GC tests as well.\r\n\r\nCaveat: It is too expensive to test GC for a long period in the current framework because of the extra book-keeping we do for correctness checks. We don't have to check correctness only at the end though, so I could technically put in a producer-consumer model and fix that.\r\n\r\nWill probably fix that in a different PR. When that is done, this thing can in theory run forever.","created_at":"2018-08-18T22:01:07Z","updated_at":"2018-08-20T16:33:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e7e7f3848b08bff94343db83a7d77e260d64362","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010451271,"node_id":"MDU6TGFiZWwxMDEwNDUxMjcx","url":"https://api.github.com/repos/cmu-db/terrier/labels/ready-for-review","name":"ready-for-review","color":"76b726","default":false},{"id":1017333805,"node_id":"MDU6TGFiZWwxMDE3MzMzODA1","url":"https://api.github.com/repos/cmu-db/terrier/labels/tests","name":"tests","color":"d9ffa0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/terrier/pulls/116/commits","review_comments_url":"https://api.github.com/repos/cmu-db/terrier/pulls/116/comments","review_comment_url":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/terrier/issues/116/comments","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/de74296ee908f26e2a40b6a84ce3ef4551f55a04","head":{"label":"cmu-db:tianyu-gc-tests","ref":"tianyu-gc-tests","sha":"de74296ee908f26e2a40b6a84ce3ef4551f55a04","user":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":140325970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzA=","name":"terrier","full_name":"cmu-db/terrier","owner":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/terrier","description":"You know what this is...","fork":false,"url":"https://api.github.com/repos/cmu-db/terrier","forks_url":"https://api.github.com/repos/cmu-db/terrier/forks","keys_url":"https://api.github.com/repos/cmu-db/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/terrier/teams","hooks_url":"https://api.github.com/repos/cmu-db/terrier/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/terrier/events","assignees_url":"https://api.github.com/repos/cmu-db/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/terrier/tags","blobs_url":"https://api.github.com/repos/cmu-db/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/terrier/languages","stargazers_url":"https://api.github.com/repos/cmu-db/terrier/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/terrier/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/terrier/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/terrier/subscription","commits_url":"https://api.github.com/repos/cmu-db/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/terrier/merges","archive_url":"https://api.github.com/repos/cmu-db/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/terrier/downloads","issues_url":"https://api.github.com/repos/cmu-db/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/terrier/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/terrier/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2018-08-18T18:39:34Z","pushed_at":"2018-08-20T16:27:56Z","git_url":"git://github.com/cmu-db/terrier.git","ssh_url":"git@github.com:cmu-db/terrier.git","clone_url":"https://github.com/cmu-db/terrier.git","svn_url":"https://github.com/cmu-db/terrier","homepage":null,"size":1051,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":18,"watchers":2,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"d017f4d189ede45b85f1274482608014f27c6554","user":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":140325970,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzA=","name":"terrier","full_name":"cmu-db/terrier","owner":{"login":"cmu-db","id":6220241,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/terrier","description":"You know what this is...","fork":false,"url":"https://api.github.com/repos/cmu-db/terrier","forks_url":"https://api.github.com/repos/cmu-db/terrier/forks","keys_url":"https://api.github.com/repos/cmu-db/terrier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/terrier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/terrier/teams","hooks_url":"https://api.github.com/repos/cmu-db/terrier/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/terrier/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/terrier/events","assignees_url":"https://api.github.com/repos/cmu-db/terrier/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/terrier/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/terrier/tags","blobs_url":"https://api.github.com/repos/cmu-db/terrier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/terrier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/terrier/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/terrier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/terrier/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/terrier/languages","stargazers_url":"https://api.github.com/repos/cmu-db/terrier/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/terrier/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/terrier/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/terrier/subscription","commits_url":"https://api.github.com/repos/cmu-db/terrier/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/terrier/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/terrier/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/terrier/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/terrier/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/terrier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/terrier/merges","archive_url":"https://api.github.com/repos/cmu-db/terrier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/terrier/downloads","issues_url":"https://api.github.com/repos/cmu-db/terrier/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/terrier/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/terrier/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/terrier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/terrier/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/terrier/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/terrier/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2018-08-18T18:39:34Z","pushed_at":"2018-08-20T16:27:56Z","git_url":"git://github.com/cmu-db/terrier.git","ssh_url":"git@github.com:cmu-db/terrier.git","clone_url":"https://github.com/cmu-db/terrier.git","svn_url":"https://github.com/cmu-db/terrier","homepage":null,"size":1051,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/116"},"html":{"href":"https://github.com/cmu-db/terrier/pull/116"},"issue":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/116"},"comments":{"href":"https://api.github.com/repos/cmu-db/terrier/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/terrier/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/terrier/statuses/de74296ee908f26e2a40b6a84ce3ef4551f55a04"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mbutrovich"}}