{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/188090995","pull_request_review_id":120001082,"id":188090995,"diff_hunk":"@@ -1,21 +1,22 @@\n 'use strict';\n \n-require('../common');","path":"test/parallel/test-async-wrap-pop-id-during-load.js","position":null,"original_position":3,"commit_id":"5cc7f932b923f1ea67c3cce5553c48611edd3d15","original_commit_id":"0cce1f2f086feec93e331dcd27a4104d17b8f300","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"> I do not want to spend much more energy into this but I really think we should start questioning some old decisions way more often.\r\n\r\n:100: to that. I think that's what we're doing here right now. We're just not (yet, at least) agreeing on what the correct answer to that questioning is. And you raise excellent points. I'm not convinced it outweighs the benefits, but it would be interesting to know what others think. AFACT, it's just you, me, @jasnell, and @TimothyGu that have weighed on in the specific issue.  Might be interesting to see what others think. This is a significant enough issue that I can see reconstituting the Testing WG if there are one or two other similar issues like this that need to be hashed out.","created_at":"2018-05-14T20:40:52Z","updated_at":"2018-05-14T20:40:52Z","html_url":"https://github.com/nodejs/node/pull/20688#discussion_r188090995","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/20688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/188090995"},"html":{"href":"https://github.com/nodejs/node/pull/20688#discussion_r188090995"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/20688"}},"in_reply_to_id":187778652},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20688","id":187629367,"html_url":"https://github.com/nodejs/node/pull/20688","diff_url":"https://github.com/nodejs/node/pull/20688.diff","patch_url":"https://github.com/nodejs/node/pull/20688.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20688","number":20688,"state":"open","locked":false,"title":"tests: reduce runtime","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"This refactors some tests to reduce the runtime of those.\r\n\r\nI looked at the first five tests from #20128 but the other two did not seem to be\r\npossible to improve (CPU bound + a necessary timeout of 1 second).\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-05-12T16:40:46Z","updated_at":"2018-05-14T20:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f4509bde2e3b867d97853451453aa85f6aadd96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20688/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20688/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20688/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/5cc7f932b923f1ea67c3cce5553c48611edd3d15","head":{"label":"BridgeAR:improve-tests","ref":"improve-tests","sha":"5cc7f932b923f1ea67c3cce5553c48611edd3d15","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":51107611,"name":"node","full_name":"BridgeAR/node","owner":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BridgeAR/node","forks_url":"https://api.github.com/repos/BridgeAR/node/forks","keys_url":"https://api.github.com/repos/BridgeAR/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/node/teams","hooks_url":"https://api.github.com/repos/BridgeAR/node/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/node/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/node/events","assignees_url":"https://api.github.com/repos/BridgeAR/node/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/node/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/node/tags","blobs_url":"https://api.github.com/repos/BridgeAR/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/node/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/node/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/node/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/node/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/node/subscription","commits_url":"https://api.github.com/repos/BridgeAR/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/node/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/node/merges","archive_url":"https://api.github.com/repos/BridgeAR/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/node/downloads","issues_url":"https://api.github.com/repos/BridgeAR/node/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/node/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/node/releases{/id}","deployments_url":"https://api.github.com/repos/BridgeAR/node/deployments","created_at":"2016-02-04T21:41:27Z","updated_at":"2018-05-11T15:48:18Z","pushed_at":"2018-05-14T19:31:32Z","git_url":"git://github.com/BridgeAR/node.git","ssh_url":"git@github.com:BridgeAR/node.git","clone_url":"https://github.com/BridgeAR/node.git","svn_url":"https://github.com/BridgeAR/node","homepage":"https://nodejs.org","size":358060,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ffb503be5f07a26d73a2b3b59955636452948ba7","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-05-14T20:38:01Z","pushed_at":"2018-05-14T20:18:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":376533,"stargazers_count":48762,"watchers_count":48762,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10286,"mirror_url":null,"archived":false,"open_issues_count":758,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10286,"open_issues":758,"watchers":48762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20688"},"html":{"href":"https://github.com/nodejs/node/pull/20688"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20688"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20688/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20688/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20688/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/5cc7f932b923f1ea67c3cce5553c48611edd3d15"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Trott"}}