{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/2567","repository_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/2567/labels{/name}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/2567/comments","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/2567/events","html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/2567","id":387069535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjQyMzI3","number":2567,"title":"Cherry-picks to support 1.20.0 release.","user":{"login":"ndmckinley","id":605324,"node_id":"MDQ6VXNlcjYwNTMyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"labels":[{"id":737832352,"node_id":"MDU6TGFiZWw3Mzc4MzIzNTI=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/labels/size/XXL","name":"size/XXL","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/milestones/4","html_url":"https://github.com/terraform-providers/terraform-provider-google/milestone/4","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/milestones/4/labels","id":3862249,"node_id":"MDk6TWlsZXN0b25lMzg2MjI0OQ==","number":4,"title":"1.20.0","description":"","creator":{"login":"rileykarson","id":2080520,"node_id":"MDQ6VXNlcjIwODA1MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2080520?v=4","gravatar_id":"","url":"https://api.github.com/users/rileykarson","html_url":"https://github.com/rileykarson","followers_url":"https://api.github.com/users/rileykarson/followers","following_url":"https://api.github.com/users/rileykarson/following{/other_user}","gists_url":"https://api.github.com/users/rileykarson/gists{/gist_id}","starred_url":"https://api.github.com/users/rileykarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rileykarson/subscriptions","organizations_url":"https://api.github.com/users/rileykarson/orgs","repos_url":"https://api.github.com/users/rileykarson/repos","events_url":"https://api.github.com/users/rileykarson/events{/privacy}","received_events_url":"https://api.github.com/users/rileykarson/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2018-11-30T21:54:16Z","updated_at":"2018-12-10T15:49:59Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-12-04T00:45:27Z","updated_at":"2018-12-12T18:19:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/2567","html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/2567","diff_url":"https://github.com/terraform-providers/terraform-provider-google/pull/2567.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-google/pull/2567.patch"},"body":"This is a branch made up of every cherrypick I could easily include in this release (and some that weren't super easy... but it all compiles now and I'll be running CI tests ASAP).\r\n\r\nHere's what we should do:\r\n* merge this into master.\r\n* release 1.20.0\r\n* do a giant revert commit - everything since e64502a0b5e22a40a6bce850a064480f2e0694da.\r\n* merge `2.0.0` into `master`.\r\n\r\n=====\r\n(we had an old plan - it's here for reference)\r\n\r\n* ~merge this into master~\r\n* ~release 1.20.0~\r\n* ~wait for tf 0.12, revendor core libraries and etc on the 2.0.0 branch.~\r\n* ~shudder, grit our teeth, and `git fetch; git checkout tpg/2.0.0; git branch master -f; git push tpg master -f`.~\r\n\r\n~This will have the effect of throwing everything since~\r\n```sh\r\n$ git merge-base master 2.0.0\r\ne64502a0b5e22a40a6bce850a064480f2e0694da\r\n$ git show e64502a0b5e22a40a6bce850a064480f2e0694da\r\ncommit e64502a0b5e22a40a6bce850a064480f2e0694da\r\nAuthor: tf-release-bot <terraform@hashicorp.com>\r\nDate:   Fri Oct 12 18:45:52 2018 +0000\r\n\r\n    Cleanup after v1.19.1 release\r\n```\r\n~away.  That is _100% correct_ - this history is wrong and as far as I know, everything after that commit is also correctly merged into `2.0.0`.  A ping @rileykarson to confirm that 8a62911016a743e329206d325146b10cc4036a4c is correctly merged into 2.0.0.~\r\n\r\n~The only other commits between e64502a0b5e22a40a6bce850a064480f2e0694da (the point of divergence between `master` and `2.0.0`) and 2f6b39ee219e80a88f6bddf53139ed769ad1f28a (`master`, before this PR) are two reverts (which we can safely remove) and a typo fix (77a449712e6ae3043c56fc6575052117ed6e3de6) which was added accidentally.~"},"comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/comments/446689788","html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/2567#issuecomment-446689788","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/2567","id":446689788,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjY4OTc4OA==","user":{"login":"ndmckinley","id":605324,"node_id":"MDQ6VXNlcjYwNTMyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/605324?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmckinley","html_url":"https://github.com/ndmckinley","followers_url":"https://api.github.com/users/ndmckinley/followers","following_url":"https://api.github.com/users/ndmckinley/following{/other_user}","gists_url":"https://api.github.com/users/ndmckinley/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmckinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmckinley/subscriptions","organizations_url":"https://api.github.com/users/ndmckinley/orgs","repos_url":"https://api.github.com/users/ndmckinley/repos","events_url":"https://api.github.com/users/ndmckinley/events{/privacy}","received_events_url":"https://api.github.com/users/ndmckinley/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T18:19:45Z","updated_at":"2018-12-12T18:19:45Z","author_association":"COLLABORATOR","body":"What!  I accepted Riley's suggestion and now it told me I've dismissed your stale approvals!  Man, I'm never clicking that button again."}}
{"actor":{"display_login":"ndmckinley"}}