{"action":"created","issue":{"url":"https://api.github.com/repos/superzanti/ServerSync/issues/108","repository_url":"https://api.github.com/repos/superzanti/ServerSync","labels_url":"https://api.github.com/repos/superzanti/ServerSync/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/superzanti/ServerSync/issues/108/comments","events_url":"https://api.github.com/repos/superzanti/ServerSync/issues/108/events","html_url":"https://github.com/superzanti/ServerSync/issues/108","id":332137754,"node_id":"MDU6SXNzdWUzMzIxMzc3NTQ=","number":108,"title":"ServerSync is vulnerable to server spoofing","user":{"login":"Hexawolf","id":33767394,"node_id":"MDQ6VXNlcjMzNzY3Mzk0","avatar_url":"https://avatars2.githubusercontent.com/u/33767394?v=4","gravatar_id":"","url":"https://api.github.com/users/Hexawolf","html_url":"https://github.com/Hexawolf","followers_url":"https://api.github.com/users/Hexawolf/followers","following_url":"https://api.github.com/users/Hexawolf/following{/other_user}","gists_url":"https://api.github.com/users/Hexawolf/gists{/gist_id}","starred_url":"https://api.github.com/users/Hexawolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hexawolf/subscriptions","organizations_url":"https://api.github.com/users/Hexawolf/orgs","repos_url":"https://api.github.com/users/Hexawolf/repos","events_url":"https://api.github.com/users/Hexawolf/events{/privacy}","received_events_url":"https://api.github.com/users/Hexawolf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-13T19:48:00Z","updated_at":"2018-06-14T03:39:34Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Thought, it does not seems like you had any plans for this, I'd like to suggest implementing something fairly simple. Just generate a keypair and allow administrators to include public key with clients, and make a simple SSH-like challenge-response system.\r\n\r\n1. Client initiates connection, sending challenge for server;\r\n2. Server gets challenge, completes it and generates a response signed with private key;\r\n3. Client receives response and checks it. If everything is OK, then everything is OK :D "},"comment":{"url":"https://api.github.com/repos/superzanti/ServerSync/issues/comments/397160292","html_url":"https://github.com/superzanti/ServerSync/issues/108#issuecomment-397160292","issue_url":"https://api.github.com/repos/superzanti/ServerSync/issues/108","id":397160292,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzE2MDI5Mg==","user":{"login":"rheimus","id":12557419,"node_id":"MDQ6VXNlcjEyNTU3NDE5","avatar_url":"https://avatars3.githubusercontent.com/u/12557419?v=4","gravatar_id":"","url":"https://api.github.com/users/rheimus","html_url":"https://github.com/rheimus","followers_url":"https://api.github.com/users/rheimus/followers","following_url":"https://api.github.com/users/rheimus/following{/other_user}","gists_url":"https://api.github.com/users/rheimus/gists{/gist_id}","starred_url":"https://api.github.com/users/rheimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rheimus/subscriptions","organizations_url":"https://api.github.com/users/rheimus/orgs","repos_url":"https://api.github.com/users/rheimus/repos","events_url":"https://api.github.com/users/rheimus/events{/privacy}","received_events_url":"https://api.github.com/users/rheimus/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T03:39:34Z","updated_at":"2018-06-14T03:39:34Z","author_association":"COLLABORATOR","body":"To clarify the problem statement (correct me if I am wrong of course):\r\n- An attacker could pretend to be a legit server and serve malicious files to a client who may or may not have established trust with the server in question."}}
{"actor":{"display_login":"rheimus"}}