{"action":"created","issue":{"url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/376","repository_url":"https://api.github.com/repos/HERA-Team/hera_cal","labels_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/376/comments","events_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/376/events","html_url":"https://github.com/HERA-Team/hera_cal/pull/376","id":372466138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjM5MjE2","number":376,"title":"added reflections.py for reflection modeling","user":{"login":"nkern","id":4307358,"node_id":"MDQ6VXNlcjQzMDczNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4307358?v=4","gravatar_id":"","url":"https://api.github.com/users/nkern","html_url":"https://github.com/nkern","followers_url":"https://api.github.com/users/nkern/followers","following_url":"https://api.github.com/users/nkern/following{/other_user}","gists_url":"https://api.github.com/users/nkern/gists{/gist_id}","starred_url":"https://api.github.com/users/nkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkern/subscriptions","organizations_url":"https://api.github.com/users/nkern/orgs","repos_url":"https://api.github.com/users/nkern/repos","events_url":"https://api.github.com/users/nkern/events{/privacy}","received_events_url":"https://api.github.com/users/nkern/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-22T10:22:36Z","updated_at":"2018-10-23T00:39:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/HERA-Team/hera_cal/pulls/376","html_url":"https://github.com/HERA-Team/hera_cal/pull/376","diff_url":"https://github.com/HERA-Team/hera_cal/pull/376.diff","patch_url":"https://github.com/HERA-Team/hera_cal/pull/376.patch"},"body":"This code models reflections in the autocorrelation data and creates the appropriate gain solutions needed to correct for the reflections in the data.\r\n\r\nTests are added using simulated data to ensure the correct reflection delays, amplitudes and phases are solved for in the module.\r\n\r\nHere is an example of the simulated cable reflection auto-correlation data, before and after reflection modeling + removal. \r\n\r\n![simulated_cable_reflections](https://user-images.githubusercontent.com/4307358/47288266-fb1f4800-d627-11e8-80d5-4d56574e6442.png)\r\n\r\n[Top] Autocorrelation with a cable reflection at 1200 nanoseconds. [Below] Same data having modeled the reflection and removed it with `reflections.py`."},"comment":{"url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/comments/432041058","html_url":"https://github.com/HERA-Team/hera_cal/pull/376#issuecomment-432041058","issue_url":"https://api.github.com/repos/HERA-Team/hera_cal/issues/376","id":432041058,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjA0MTA1OA==","user":{"login":"nkern","id":4307358,"node_id":"MDQ6VXNlcjQzMDczNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4307358?v=4","gravatar_id":"","url":"https://api.github.com/users/nkern","html_url":"https://github.com/nkern","followers_url":"https://api.github.com/users/nkern/followers","following_url":"https://api.github.com/users/nkern/following{/other_user}","gists_url":"https://api.github.com/users/nkern/gists{/gist_id}","starred_url":"https://api.github.com/users/nkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkern/subscriptions","organizations_url":"https://api.github.com/users/nkern/orgs","repos_url":"https://api.github.com/users/nkern/repos","events_url":"https://api.github.com/users/nkern/events{/privacy}","received_events_url":"https://api.github.com/users/nkern/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T00:39:53Z","updated_at":"2018-10-23T00:39:53Z","author_association":"MEMBER","body":"Sure. Here are some more simulated-data and real-data plots.\r\n\r\n![simulated_cable_refs](https://user-images.githubusercontent.com/4307358/47327196-d0bca180-d69e-11e8-9721-087f00bad1aa.png)\r\n[Top] Visibility delay transform amplitude with cable reflections. [Bottom] Visibility delay transform after reflection removal. X-axis is delay in nanoseconds. Y-axis is arbitrary but is proportional to temperature (not temp squared). This is _simulated auto-correlation data_.\r\n\r\n![real_cable_refs](https://user-images.githubusercontent.com/4307358/47327249-0e212f00-d69f-11e8-9e3a-39eafed86873.png)\r\n[Top] Visibility delay transform amplitude with cable reflections. [Bottom] Delay transform after reflection modeling and removal. X-axis is delay in nanoseconds, Y-axis is also arbitrary but is proportional to temperature (this is raw data actually!). This is _real auto-correlation data_.\r\n"}}
{"actor":{"display_login":"nkern"}}