{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/234308755","pull_request_review_id":175930753,"id":234308755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMwODc1NQ==","diff_hunk":"@@ -30,6 +30,8 @@ const (\n \thostPort                  = \"host-port\"","path":"cmd/agent/app/reporter/tchannel/flags.go","position":1,"original_position":1,"commit_id":"15476e058924252b539e472b0c06dc8f809730fc","original_commit_id":"15476e058924252b539e472b0c06dc8f809730fc","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"`collector` was removed only from the new flags - `reporter.grpc.collector.host-port`","created_at":"2018-11-16T18:42:14Z","updated_at":"2018-11-16T18:42:14Z","html_url":"https://github.com/jaegertracing/jaeger/pull/1034#discussion_r234308755","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/234308755"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1034#discussion_r234308755"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034"}},"in_reply_to_id":234306911},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034","id":212085124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDg1MTI0","html_url":"https://github.com/jaegertracing/jaeger/pull/1034","diff_url":"https://github.com/jaegertracing/jaeger/pull/1034.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/1034.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1034","number":1034,"state":"open","locked":false,"title":"[agent] Make timeout for reporting configurable","user":{"login":"gouthamve","id":7354143,"node_id":"MDQ6VXNlcjczNTQxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7354143?v=4","gravatar_id":"","url":"https://api.github.com/users/gouthamve","html_url":"https://github.com/gouthamve","followers_url":"https://api.github.com/users/gouthamve/followers","following_url":"https://api.github.com/users/gouthamve/following{/other_user}","gists_url":"https://api.github.com/users/gouthamve/gists{/gist_id}","starred_url":"https://api.github.com/users/gouthamve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouthamve/subscriptions","organizations_url":"https://api.github.com/users/gouthamve/orgs","repos_url":"https://api.github.com/users/gouthamve/repos","events_url":"https://api.github.com/users/gouthamve/events{/privacy}","received_events_url":"https://api.github.com/users/gouthamve/received_events","type":"User","site_admin":false},"body":"So, this is less a fix for #1026 but more to kick off the discussion around: https://github.com/jaegertracing/jaeger/issues/927\r\n\r\nWhile the original proposal has:\r\n```\r\nreporters:\r\n    - kind: tchannel\r\n      # tchannel-specific parameters, e.g.\r\n      collector:\r\n        hostPort: ...\r\n      discovery:\r\n        minPeers: 10\r\n    - kind: grps\r\n      # grpc-specific parameters\r\n```\r\n\r\nI kind of like:\r\n```\r\ntchannel:\r\n# tchannel-config\r\n\r\ngrpc:\r\n# grpc-config\r\n```\r\n\r\nI took a stab at implementing my version and turns out it's super straight forward and is very little changed code. But if the preference is to have the originally proposed format, I'll make the changes. But now I'm curious, can we 2 different `tchannel` reporters?\r\n\r\nNote: This will be a breaking change.","created_at":"2018-08-30T13:45:48Z","updated_at":"2018-11-16T18:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc8255d46e6733be0f5df71e7939cac152f2cb27","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},{"login":"black-adder","id":791791,"node_id":"MDQ6VXNlcjc5MTc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},{"login":"vprithvi","id":833009,"node_id":"MDQ6VXNlcjgzMzAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/833009?v=4","gravatar_id":"","url":"https://api.github.com/users/vprithvi","html_url":"https://github.com/vprithvi","followers_url":"https://api.github.com/users/vprithvi/followers","following_url":"https://api.github.com/users/vprithvi/following{/other_user}","gists_url":"https://api.github.com/users/vprithvi/gists{/gist_id}","starred_url":"https://api.github.com/users/vprithvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vprithvi/subscriptions","organizations_url":"https://api.github.com/users/vprithvi/orgs","repos_url":"https://api.github.com/users/vprithvi/repos","events_url":"https://api.github.com/users/vprithvi/events{/privacy}","received_events_url":"https://api.github.com/users/vprithvi/received_events","type":"User","site_admin":false},{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1034/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/15476e058924252b539e472b0c06dc8f809730fc","head":{"label":"gouthamve:add-agent-timeout","ref":"add-agent-timeout","sha":"15476e058924252b539e472b0c06dc8f809730fc","user":{"login":"gouthamve","id":7354143,"node_id":"MDQ6VXNlcjczNTQxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7354143?v=4","gravatar_id":"","url":"https://api.github.com/users/gouthamve","html_url":"https://github.com/gouthamve","followers_url":"https://api.github.com/users/gouthamve/followers","following_url":"https://api.github.com/users/gouthamve/following{/other_user}","gists_url":"https://api.github.com/users/gouthamve/gists{/gist_id}","starred_url":"https://api.github.com/users/gouthamve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouthamve/subscriptions","organizations_url":"https://api.github.com/users/gouthamve/orgs","repos_url":"https://api.github.com/users/gouthamve/repos","events_url":"https://api.github.com/users/gouthamve/events{/privacy}","received_events_url":"https://api.github.com/users/gouthamve/received_events","type":"User","site_admin":false},"repo":{"id":146755203,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3NTUyMDM=","name":"jaeger","full_name":"gouthamve/jaeger","private":false,"owner":{"login":"gouthamve","id":7354143,"node_id":"MDQ6VXNlcjczNTQxNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7354143?v=4","gravatar_id":"","url":"https://api.github.com/users/gouthamve","html_url":"https://github.com/gouthamve","followers_url":"https://api.github.com/users/gouthamve/followers","following_url":"https://api.github.com/users/gouthamve/following{/other_user}","gists_url":"https://api.github.com/users/gouthamve/gists{/gist_id}","starred_url":"https://api.github.com/users/gouthamve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouthamve/subscriptions","organizations_url":"https://api.github.com/users/gouthamve/orgs","repos_url":"https://api.github.com/users/gouthamve/repos","events_url":"https://api.github.com/users/gouthamve/events{/privacy}","received_events_url":"https://api.github.com/users/gouthamve/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gouthamve/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/gouthamve/jaeger","forks_url":"https://api.github.com/repos/gouthamve/jaeger/forks","keys_url":"https://api.github.com/repos/gouthamve/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gouthamve/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gouthamve/jaeger/teams","hooks_url":"https://api.github.com/repos/gouthamve/jaeger/hooks","issue_events_url":"https://api.github.com/repos/gouthamve/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/gouthamve/jaeger/events","assignees_url":"https://api.github.com/repos/gouthamve/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/gouthamve/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/gouthamve/jaeger/tags","blobs_url":"https://api.github.com/repos/gouthamve/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gouthamve/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gouthamve/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/gouthamve/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gouthamve/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/gouthamve/jaeger/languages","stargazers_url":"https://api.github.com/repos/gouthamve/jaeger/stargazers","contributors_url":"https://api.github.com/repos/gouthamve/jaeger/contributors","subscribers_url":"https://api.github.com/repos/gouthamve/jaeger/subscribers","subscription_url":"https://api.github.com/repos/gouthamve/jaeger/subscription","commits_url":"https://api.github.com/repos/gouthamve/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/gouthamve/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/gouthamve/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/gouthamve/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/gouthamve/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/gouthamve/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gouthamve/jaeger/merges","archive_url":"https://api.github.com/repos/gouthamve/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gouthamve/jaeger/downloads","issues_url":"https://api.github.com/repos/gouthamve/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/gouthamve/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/gouthamve/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/gouthamve/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gouthamve/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/gouthamve/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/gouthamve/jaeger/deployments","created_at":"2018-08-30T13:39:46Z","updated_at":"2018-08-30T13:39:49Z","pushed_at":"2018-11-16T10:55:14Z","git_url":"git://github.com/gouthamve/jaeger.git","ssh_url":"git@github.com:gouthamve/jaeger.git","clone_url":"https://github.com/gouthamve/jaeger.git","svn_url":"https://github.com/gouthamve/jaeger","homepage":"https://jaegertracing.io/","size":17407,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"c7da0b469efe456e993ae282b55efd1d6faeb711","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0MjUwOA==","name":"jaeger","full_name":"jaegertracing/jaeger","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-11-16T18:04:55Z","pushed_at":"2018-11-16T14:37:51Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":17237,"stargazers_count":6384,"watchers_count":6384,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":569,"open_issues":252,"watchers":6384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1034"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1034"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1034/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1034/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/15476e058924252b539e472b0c06dc8f809730fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"pavolloffay"}}