{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/1762","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/1762/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/1762/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/1762/events","html_url":"https://github.com/status-im/status-react/issues/1762","id":255460555,"node_id":"MDU6SXNzdWUyNTU0NjA1NTU=","number":1762,"title":"Wallet - Use web3 to fetch wallet transactions","user":{"login":"yenda","id":1181225,"node_id":"MDQ6VXNlcjExODEyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false},"labels":[{"id":513859144,"node_id":"MDU6TGFiZWw1MTM4NTkxNDQ=","url":"https://api.github.com/repos/status-im/status-react/labels/advanced","name":"advanced","color":"d93f0b","default":false},{"id":523025415,"node_id":"MDU6TGFiZWw1MjMwMjU0MTU=","url":"https://api.github.com/repos/status-im/status-react/labels/bounty","name":"bounty","color":"FAFAD2","default":false},{"id":755561276,"node_id":"MDU6TGFiZWw3NTU1NjEyNzY=","url":"https://api.github.com/repos/status-im/status-react/labels/bounty-m","name":"bounty-m","color":"89cbe5","default":false},{"id":330296933,"node_id":"MDU6TGFiZWwzMzAyOTY5MzM=","url":"https://api.github.com/repos/status-im/status-react/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":933023569,"node_id":"MDU6TGFiZWw5MzMwMjM1Njk=","url":"https://api.github.com/repos/status-im/status-react/labels/feature","name":"feature","color":"172b9e","default":false},{"id":691030971,"node_id":"MDU6TGFiZWw2OTEwMzA5NzE=","url":"https://api.github.com/repos/status-im/status-react/labels/wallet","name":"wallet","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/status-im/status-react/milestones/17","html_url":"https://github.com/status-im/status-react/milestone/17","labels_url":"https://api.github.com/repos/status-im/status-react/milestones/17/labels","id":2850056,"node_id":"MDk6TWlsZXN0b25lMjg1MDA1Ng==","number":17,"title":"0.9.13","description":"","creator":{"login":"oskarth","id":1552237,"node_id":"MDQ6VXNlcjE1NTIyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1552237?v=4","gravatar_id":"","url":"https://api.github.com/users/oskarth","html_url":"https://github.com/oskarth","followers_url":"https://api.github.com/users/oskarth/followers","following_url":"https://api.github.com/users/oskarth/following{/other_user}","gists_url":"https://api.github.com/users/oskarth/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarth/subscriptions","organizations_url":"https://api.github.com/users/oskarth/orgs","repos_url":"https://api.github.com/users/oskarth/repos","events_url":"https://api.github.com/users/oskarth/events{/privacy}","received_events_url":"https://api.github.com/users/oskarth/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":139,"state":"closed","created_at":"2017-10-19T08:51:49Z","updated_at":"2018-08-31T10:34:21Z","due_on":null,"closed_at":"2018-05-17T18:15:11Z"},"comments":4,"created_at":"2017-09-06T02:18:57Z","updated_at":"2018-09-11T00:01:49Z","closed_at":null,"author_association":"MEMBER","body":"[comment]: # (Please replace ... with your information. Remove < and >)\r\n\r\n### User Story\r\n\r\nAs a developper, I want to to use web3 to fetch transactions so that Status does not depends on a centralized api (etherscan) for wallet transactions history.\r\n\r\n### Description\r\n\r\n[comment]: # (Feature or Bug? i.e Type: Bug)\r\n*Type*: Feature\r\n\r\n[comment]: # (Describe the feature you would like, or briefly summarise the bug and what you did, what you expected to happen, and what actually happens. Sections below)\r\n*Summary*: \r\nTo reach MVP of the new wallet we used etherscan to fetch the transaction history of the wallet. This task will consist of implementing a new version of the transaction fetching logic using web3.\r\n\r\n#### Expected behavior\r\n[comment]: # (Describe what you expected to happen.)\r\nTransactions are fetched using web3\r\n#### Actual behavior\r\n[comment]: # (Describe what actually happened.)\r\nTransactions are fetched using etherscan and are limited to the 20 last transactions\r\n### Solution\r\n[comment]: # (Please summarise the solution and provide a task list on what needs to be fixed.)\r\n*Summary*: \r\n\r\n- [ ] implement and adapt this script in clojurescript https://ethereum.stackexchange.com/questions/2531/common-useful-javascript-snippets-for-geth/3478#3478 to get transactions for a given address from block X to Z in utils/transactions.cljs\r\n- [ ] create an event that recursively calls the function for block n to n-step until the block when the wallet has been created is reached in ui.screens.wallet.events\r\n\r\nDepending on the performance cost of this solution it might be worth it to keep the etherscan api call for the 20 first transactions, but use web3 as fallback in case it fails and fetch the rest of the transactions with web3.\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/420100511","html_url":"https://github.com/status-im/status-react/issues/1762#issuecomment-420100511","issue_url":"https://api.github.com/repos/status-im/status-react/issues/1762","id":420100511,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDEwMDUxMQ==","user":{"login":"pablanopete","id":18363825,"node_id":"MDQ6VXNlcjE4MzYzODI1","avatar_url":"https://avatars0.githubusercontent.com/u/18363825?v=4","gravatar_id":"","url":"https://api.github.com/users/pablanopete","html_url":"https://github.com/pablanopete","followers_url":"https://api.github.com/users/pablanopete/followers","following_url":"https://api.github.com/users/pablanopete/following{/other_user}","gists_url":"https://api.github.com/users/pablanopete/gists{/gist_id}","starred_url":"https://api.github.com/users/pablanopete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablanopete/subscriptions","organizations_url":"https://api.github.com/users/pablanopete/orgs","repos_url":"https://api.github.com/users/pablanopete/repos","events_url":"https://api.github.com/users/pablanopete/events{/privacy}","received_events_url":"https://api.github.com/users/pablanopete/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T00:01:49Z","updated_at":"2018-09-11T00:01:49Z","author_association":"MEMBER","body":"@yenda would this be appropriate for a new bounty still? "}}
{"actor":{"display_login":"pablanopete"}}