{"action":"created","comment":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/comments/245446441","pull_request_review_id":189561284,"id":245446441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ0NjQ0MQ==","diff_hunk":"@@ -25,6 +25,8 @@\n #include \"engine/GameWorld.hpp\"\n #include \"loaders/LoaderIFP.hpp\"\n #include \"objects/VehicleObject.hpp\"\n+#include \"CharacterObject.hpp\"","path":"rwengine/src/objects/CharacterObject.cpp","position":4,"original_position":4,"commit_id":"30e057a4042af319b87c48ffed10ae62bf5f0924","original_commit_id":"30e057a4042af319b87c48ffed10ae62bf5f0924","user":{"login":"danhedron","id":418211,"node_id":"MDQ6VXNlcjQxODIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/418211?v=4","gravatar_id":"","url":"https://api.github.com/users/danhedron","html_url":"https://github.com/danhedron","followers_url":"https://api.github.com/users/danhedron/followers","following_url":"https://api.github.com/users/danhedron/following{/other_user}","gists_url":"https://api.github.com/users/danhedron/gists{/gist_id}","starred_url":"https://api.github.com/users/danhedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhedron/subscriptions","organizations_url":"https://api.github.com/users/danhedron/orgs","repos_url":"https://api.github.com/users/danhedron/repos","events_url":"https://api.github.com/users/danhedron/events{/privacy}","received_events_url":"https://api.github.com/users/danhedron/received_events","type":"User","site_admin":false},"body":"Ah damn I missed that. CLion does this whenever I use the `add implementation` shortcut.","created_at":"2019-01-04T23:11:19Z","updated_at":"2019-01-04T23:11:19Z","html_url":"https://github.com/rwengine/openrw/pull/683#discussion_r245446441","pull_request_url":"https://api.github.com/repos/rwengine/openrw/pulls/683","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments/245446441"},"html":{"href":"https://github.com/rwengine/openrw/pull/683#discussion_r245446441"},"pull_request":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/683"}},"in_reply_to_id":245441700},"pull_request":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/683","id":242388733,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzg4NzMz","html_url":"https://github.com/rwengine/openrw/pull/683","diff_url":"https://github.com/rwengine/openrw/pull/683.diff","patch_url":"https://github.com/rwengine/openrw/pull/683.patch","issue_url":"https://api.github.com/repos/rwengine/openrw/issues/683","number":683,"state":"open","locked":false,"title":"Melee Weapon implementation","user":{"login":"danhedron","id":418211,"node_id":"MDQ6VXNlcjQxODIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/418211?v=4","gravatar_id":"","url":"https://api.github.com/users/danhedron","html_url":"https://github.com/danhedron","followers_url":"https://api.github.com/users/danhedron/followers","following_url":"https://api.github.com/users/danhedron/following{/other_user}","gists_url":"https://api.github.com/users/danhedron/gists{/gist_id}","starred_url":"https://api.github.com/users/danhedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhedron/subscriptions","organizations_url":"https://api.github.com/users/danhedron/orgs","repos_url":"https://api.github.com/users/danhedron/repos","events_url":"https://api.github.com/users/danhedron/events{/privacy}","received_events_url":"https://api.github.com/users/danhedron/received_events","type":"User","site_admin":false},"body":"Provide a basic implementation of melee attacks. This enables attacking while unarmed and with the bat. The alternate ground attack animation is selected if there is anyone on the ground. Currently only dead NPCs fall the ground however so this isn't all that useful yet.","created_at":"2019-01-04T22:25:18Z","updated_at":"2019-01-04T23:11:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78654bf33983936db9358b11844df4eadc0bbb0d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rwengine/openrw/pulls/683/commits","review_comments_url":"https://api.github.com/repos/rwengine/openrw/pulls/683/comments","review_comment_url":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwengine/openrw/issues/683/comments","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/30e057a4042af319b87c48ffed10ae62bf5f0924","head":{"label":"danhedron:feat/melee","ref":"feat/melee","sha":"30e057a4042af319b87c48ffed10ae62bf5f0924","user":{"login":"danhedron","id":418211,"node_id":"MDQ6VXNlcjQxODIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/418211?v=4","gravatar_id":"","url":"https://api.github.com/users/danhedron","html_url":"https://github.com/danhedron","followers_url":"https://api.github.com/users/danhedron/followers","following_url":"https://api.github.com/users/danhedron/following{/other_user}","gists_url":"https://api.github.com/users/danhedron/gists{/gist_id}","starred_url":"https://api.github.com/users/danhedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhedron/subscriptions","organizations_url":"https://api.github.com/users/danhedron/orgs","repos_url":"https://api.github.com/users/danhedron/repos","events_url":"https://api.github.com/users/danhedron/events{/privacy}","received_events_url":"https://api.github.com/users/danhedron/received_events","type":"User","site_admin":false},"repo":{"id":60128563,"node_id":"MDEwOlJlcG9zaXRvcnk2MDEyODU2Mw==","name":"openrw","full_name":"danhedron/openrw","private":false,"owner":{"login":"danhedron","id":418211,"node_id":"MDQ6VXNlcjQxODIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/418211?v=4","gravatar_id":"","url":"https://api.github.com/users/danhedron","html_url":"https://github.com/danhedron","followers_url":"https://api.github.com/users/danhedron/followers","following_url":"https://api.github.com/users/danhedron/following{/other_user}","gists_url":"https://api.github.com/users/danhedron/gists{/gist_id}","starred_url":"https://api.github.com/users/danhedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhedron/subscriptions","organizations_url":"https://api.github.com/users/danhedron/orgs","repos_url":"https://api.github.com/users/danhedron/repos","events_url":"https://api.github.com/users/danhedron/events{/privacy}","received_events_url":"https://api.github.com/users/danhedron/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danhedron/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":true,"url":"https://api.github.com/repos/danhedron/openrw","forks_url":"https://api.github.com/repos/danhedron/openrw/forks","keys_url":"https://api.github.com/repos/danhedron/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danhedron/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danhedron/openrw/teams","hooks_url":"https://api.github.com/repos/danhedron/openrw/hooks","issue_events_url":"https://api.github.com/repos/danhedron/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/danhedron/openrw/events","assignees_url":"https://api.github.com/repos/danhedron/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/danhedron/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/danhedron/openrw/tags","blobs_url":"https://api.github.com/repos/danhedron/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danhedron/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danhedron/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/danhedron/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danhedron/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/danhedron/openrw/languages","stargazers_url":"https://api.github.com/repos/danhedron/openrw/stargazers","contributors_url":"https://api.github.com/repos/danhedron/openrw/contributors","subscribers_url":"https://api.github.com/repos/danhedron/openrw/subscribers","subscription_url":"https://api.github.com/repos/danhedron/openrw/subscription","commits_url":"https://api.github.com/repos/danhedron/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/danhedron/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/danhedron/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/danhedron/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/danhedron/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/danhedron/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danhedron/openrw/merges","archive_url":"https://api.github.com/repos/danhedron/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danhedron/openrw/downloads","issues_url":"https://api.github.com/repos/danhedron/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/danhedron/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/danhedron/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/danhedron/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danhedron/openrw/labels{/name}","releases_url":"https://api.github.com/repos/danhedron/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/danhedron/openrw/deployments","created_at":"2016-05-31T22:42:25Z","updated_at":"2018-12-09T08:43:19Z","pushed_at":"2019-01-04T01:11:57Z","git_url":"git://github.com/danhedron/openrw.git","ssh_url":"git@github.com:danhedron/openrw.git","clone_url":"https://github.com/danhedron/openrw.git","svn_url":"https://github.com/danhedron/openrw","homepage":"https://github.com/rwengine/openrw","size":5121,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5,"open_issues":0,"watchers":43,"default_branch":"master"}},"base":{"label":"rwengine:master","ref":"master","sha":"ba913e51541bebad8b7f903dc2633a6811be591e","user":{"login":"rwengine","id":19520421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTIwNDIx","avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"repo":{"id":34529275,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyOTI3NQ==","name":"openrw","full_name":"rwengine/openrw","private":false,"owner":{"login":"rwengine","id":19520421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTIwNDIx","avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rwengine/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":false,"url":"https://api.github.com/repos/rwengine/openrw","forks_url":"https://api.github.com/repos/rwengine/openrw/forks","keys_url":"https://api.github.com/repos/rwengine/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwengine/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwengine/openrw/teams","hooks_url":"https://api.github.com/repos/rwengine/openrw/hooks","issue_events_url":"https://api.github.com/repos/rwengine/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/rwengine/openrw/events","assignees_url":"https://api.github.com/repos/rwengine/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/rwengine/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/rwengine/openrw/tags","blobs_url":"https://api.github.com/repos/rwengine/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwengine/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwengine/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwengine/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/rwengine/openrw/languages","stargazers_url":"https://api.github.com/repos/rwengine/openrw/stargazers","contributors_url":"https://api.github.com/repos/rwengine/openrw/contributors","subscribers_url":"https://api.github.com/repos/rwengine/openrw/subscribers","subscription_url":"https://api.github.com/repos/rwengine/openrw/subscription","commits_url":"https://api.github.com/repos/rwengine/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwengine/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwengine/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwengine/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwengine/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/rwengine/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwengine/openrw/merges","archive_url":"https://api.github.com/repos/rwengine/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwengine/openrw/downloads","issues_url":"https://api.github.com/repos/rwengine/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/rwengine/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/rwengine/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/rwengine/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwengine/openrw/labels{/name}","releases_url":"https://api.github.com/repos/rwengine/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/rwengine/openrw/deployments","created_at":"2015-04-24T16:26:12Z","updated_at":"2019-01-03T18:36:27Z","pushed_at":"2019-01-04T22:25:18Z","git_url":"git://github.com/rwengine/openrw.git","ssh_url":"git@github.com:rwengine/openrw.git","clone_url":"https://github.com/rwengine/openrw.git","svn_url":"https://github.com/rwengine/openrw","homepage":"http://openrw.org","size":4552,"stargazers_count":769,"watchers_count":769,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":93,"open_issues":111,"watchers":769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/683"},"html":{"href":"https://github.com/rwengine/openrw/pull/683"},"issue":{"href":"https://api.github.com/repos/rwengine/openrw/issues/683"},"comments":{"href":"https://api.github.com/repos/rwengine/openrw/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/rwengine/openrw/statuses/30e057a4042af319b87c48ffed10ae62bf5f0924"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"danhedron"}}