{"action":"created","comment":{"url":"https://api.github.com/repos/getpelican/pelican/pulls/comments/229898835","pull_request_review_id":170509290,"id":229898835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg5ODgzNQ==","diff_hunk":"@@ -67,8 +67,11 @@ def _get_page_range(self):\n \n class Page(object):\n     def __init__(self, name, url, object_list, number, paginator, settings):\n+        self.full_name = name\n         self.name, self.extension = os.path.splitext(name)\n-        self.base_url = url\n+        dirname, filename = os.path.split(name)\n+        self.base_name = dirname if filename == 'index.html' else self.name\n+        self.full_url = url","path":"pelican/paginator.py","position":null,"original_position":9,"commit_id":"a78950bce7a2c220f0ee25d617562852a6eba180","original_commit_id":"2a8fc20cee9e58c9dbf1569dc0071084056b5c33","user":{"login":"oulenz","id":13745168,"node_id":"MDQ6VXNlcjEzNzQ1MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/13745168?v=4","gravatar_id":"","url":"https://api.github.com/users/oulenz","html_url":"https://github.com/oulenz","followers_url":"https://api.github.com/users/oulenz/followers","following_url":"https://api.github.com/users/oulenz/following{/other_user}","gists_url":"https://api.github.com/users/oulenz/gists{/gist_id}","starred_url":"https://api.github.com/users/oulenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulenz/subscriptions","organizations_url":"https://api.github.com/users/oulenz/orgs","repos_url":"https://api.github.com/users/oulenz/repos","events_url":"https://api.github.com/users/oulenz/events{/privacy}","received_events_url":"https://api.github.com/users/oulenz/received_events","type":"User","site_admin":false},"body":"Ah ok! I think the `base_` part is misleading, but I guess we're stuck with it. I've reverted to `base_url`.","created_at":"2018-10-31T23:17:43Z","updated_at":"2018-10-31T23:17:43Z","html_url":"https://github.com/getpelican/pelican/pull/2375#discussion_r229898835","pull_request_url":"https://api.github.com/repos/getpelican/pelican/pulls/2375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/comments/229898835"},"html":{"href":"https://github.com/getpelican/pelican/pull/2375#discussion_r229898835"},"pull_request":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/2375"}},"in_reply_to_id":229315382},"pull_request":{"url":"https://api.github.com/repos/getpelican/pelican/pulls/2375","id":199529760,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTI5NzYw","html_url":"https://github.com/getpelican/pelican/pull/2375","diff_url":"https://github.com/getpelican/pelican/pull/2375.diff","patch_url":"https://github.com/getpelican/pelican/pull/2375.patch","issue_url":"https://api.github.com/repos/getpelican/pelican/issues/2375","number":2375,"state":"open","locked":false,"title":"tweak paginator to accomodate {slug}.html patterns","user":{"login":"oulenz","id":13745168,"node_id":"MDQ6VXNlcjEzNzQ1MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/13745168?v=4","gravatar_id":"","url":"https://api.github.com/users/oulenz","html_url":"https://github.com/oulenz","followers_url":"https://api.github.com/users/oulenz/followers","following_url":"https://api.github.com/users/oulenz/following{/other_user}","gists_url":"https://api.github.com/users/oulenz/gists{/gist_id}","starred_url":"https://api.github.com/users/oulenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulenz/subscriptions","organizations_url":"https://api.github.com/users/oulenz/orgs","repos_url":"https://api.github.com/users/oulenz/repos","events_url":"https://api.github.com/users/oulenz/events{/privacy}","received_events_url":"https://api.github.com/users/oulenz/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/getpelican/pelican/issues/1137, fixes https://github.com/getpelican/pelican/issues/1615, fixes https://github.com/getpelican/pelican/issues/2155, fixes .\r\nMakes pr https://github.com/getpelican/pelican/pull/1956 redundant.\r\n\r\nAt present, pagination produces critical errors with the default `*_SAVE_AS` settings for authors, categories and tags, because the `{base_name}` variable strips `{slug}.html` from `foo/{slug}.html`. This fixes that by ensuring that `{base_name}` only strips `.html` and `/index.html`","created_at":"2018-07-05T16:49:04Z","updated_at":"2018-10-31T23:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eddb4dd595f0b81e717c392c85ba5ced1174bbdb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mosra","id":344828,"node_id":"MDQ6VXNlcjM0NDgyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/344828?v=4","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":17451359,"node_id":"MDU6TGFiZWwxNzQ1MTM1OQ==","url":"https://api.github.com/repos/getpelican/pelican/labels/awaiting%20review","name":"awaiting review","color":"e10c02","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/getpelican/pelican/pulls/2375/commits","review_comments_url":"https://api.github.com/repos/getpelican/pelican/pulls/2375/comments","review_comment_url":"https://api.github.com/repos/getpelican/pelican/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getpelican/pelican/issues/2375/comments","statuses_url":"https://api.github.com/repos/getpelican/pelican/statuses/a78950bce7a2c220f0ee25d617562852a6eba180","head":{"label":"oulenz:page_save_as","ref":"page_save_as","sha":"a78950bce7a2c220f0ee25d617562852a6eba180","user":{"login":"oulenz","id":13745168,"node_id":"MDQ6VXNlcjEzNzQ1MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/13745168?v=4","gravatar_id":"","url":"https://api.github.com/users/oulenz","html_url":"https://github.com/oulenz","followers_url":"https://api.github.com/users/oulenz/followers","following_url":"https://api.github.com/users/oulenz/following{/other_user}","gists_url":"https://api.github.com/users/oulenz/gists{/gist_id}","starred_url":"https://api.github.com/users/oulenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulenz/subscriptions","organizations_url":"https://api.github.com/users/oulenz/orgs","repos_url":"https://api.github.com/users/oulenz/repos","events_url":"https://api.github.com/users/oulenz/events{/privacy}","received_events_url":"https://api.github.com/users/oulenz/received_events","type":"User","site_admin":false},"repo":{"id":121686537,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2ODY1Mzc=","name":"pelican","full_name":"oulenz/pelican","private":false,"owner":{"login":"oulenz","id":13745168,"node_id":"MDQ6VXNlcjEzNzQ1MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/13745168?v=4","gravatar_id":"","url":"https://api.github.com/users/oulenz","html_url":"https://github.com/oulenz","followers_url":"https://api.github.com/users/oulenz/followers","following_url":"https://api.github.com/users/oulenz/following{/other_user}","gists_url":"https://api.github.com/users/oulenz/gists{/gist_id}","starred_url":"https://api.github.com/users/oulenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulenz/subscriptions","organizations_url":"https://api.github.com/users/oulenz/orgs","repos_url":"https://api.github.com/users/oulenz/repos","events_url":"https://api.github.com/users/oulenz/events{/privacy}","received_events_url":"https://api.github.com/users/oulenz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oulenz/pelican","description":"Static site generator that supports Markdown and reST syntax. Powered by Python.","fork":true,"url":"https://api.github.com/repos/oulenz/pelican","forks_url":"https://api.github.com/repos/oulenz/pelican/forks","keys_url":"https://api.github.com/repos/oulenz/pelican/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oulenz/pelican/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oulenz/pelican/teams","hooks_url":"https://api.github.com/repos/oulenz/pelican/hooks","issue_events_url":"https://api.github.com/repos/oulenz/pelican/issues/events{/number}","events_url":"https://api.github.com/repos/oulenz/pelican/events","assignees_url":"https://api.github.com/repos/oulenz/pelican/assignees{/user}","branches_url":"https://api.github.com/repos/oulenz/pelican/branches{/branch}","tags_url":"https://api.github.com/repos/oulenz/pelican/tags","blobs_url":"https://api.github.com/repos/oulenz/pelican/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oulenz/pelican/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oulenz/pelican/git/refs{/sha}","trees_url":"https://api.github.com/repos/oulenz/pelican/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oulenz/pelican/statuses/{sha}","languages_url":"https://api.github.com/repos/oulenz/pelican/languages","stargazers_url":"https://api.github.com/repos/oulenz/pelican/stargazers","contributors_url":"https://api.github.com/repos/oulenz/pelican/contributors","subscribers_url":"https://api.github.com/repos/oulenz/pelican/subscribers","subscription_url":"https://api.github.com/repos/oulenz/pelican/subscription","commits_url":"https://api.github.com/repos/oulenz/pelican/commits{/sha}","git_commits_url":"https://api.github.com/repos/oulenz/pelican/git/commits{/sha}","comments_url":"https://api.github.com/repos/oulenz/pelican/comments{/number}","issue_comment_url":"https://api.github.com/repos/oulenz/pelican/issues/comments{/number}","contents_url":"https://api.github.com/repos/oulenz/pelican/contents/{+path}","compare_url":"https://api.github.com/repos/oulenz/pelican/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oulenz/pelican/merges","archive_url":"https://api.github.com/repos/oulenz/pelican/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oulenz/pelican/downloads","issues_url":"https://api.github.com/repos/oulenz/pelican/issues{/number}","pulls_url":"https://api.github.com/repos/oulenz/pelican/pulls{/number}","milestones_url":"https://api.github.com/repos/oulenz/pelican/milestones{/number}","notifications_url":"https://api.github.com/repos/oulenz/pelican/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oulenz/pelican/labels{/name}","releases_url":"https://api.github.com/repos/oulenz/pelican/releases{/id}","deployments_url":"https://api.github.com/repos/oulenz/pelican/deployments","created_at":"2018-02-15T21:44:55Z","updated_at":"2018-10-31T18:28:31Z","pushed_at":"2018-10-31T23:14:39Z","git_url":"git://github.com/oulenz/pelican.git","ssh_url":"git@github.com:oulenz/pelican.git","clone_url":"https://github.com/oulenz/pelican.git","svn_url":"https://github.com/oulenz/pelican","homepage":"https://getpelican.com/","size":5569,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getpelican:master","ref":"master","sha":"461f535d04c9f00099b4262f166aaa52530f5e94","user":{"login":"getpelican","id":2043492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDM0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2043492?v=4","gravatar_id":"","url":"https://api.github.com/users/getpelican","html_url":"https://github.com/getpelican","followers_url":"https://api.github.com/users/getpelican/followers","following_url":"https://api.github.com/users/getpelican/following{/other_user}","gists_url":"https://api.github.com/users/getpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/getpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getpelican/subscriptions","organizations_url":"https://api.github.com/users/getpelican/orgs","repos_url":"https://api.github.com/users/getpelican/repos","events_url":"https://api.github.com/users/getpelican/events{/privacy}","received_events_url":"https://api.github.com/users/getpelican/received_events","type":"Organization","site_admin":false},"repo":{"id":993110,"node_id":"MDEwOlJlcG9zaXRvcnk5OTMxMTA=","name":"pelican","full_name":"getpelican/pelican","private":false,"owner":{"login":"getpelican","id":2043492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDM0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2043492?v=4","gravatar_id":"","url":"https://api.github.com/users/getpelican","html_url":"https://github.com/getpelican","followers_url":"https://api.github.com/users/getpelican/followers","following_url":"https://api.github.com/users/getpelican/following{/other_user}","gists_url":"https://api.github.com/users/getpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/getpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getpelican/subscriptions","organizations_url":"https://api.github.com/users/getpelican/orgs","repos_url":"https://api.github.com/users/getpelican/repos","events_url":"https://api.github.com/users/getpelican/events{/privacy}","received_events_url":"https://api.github.com/users/getpelican/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getpelican/pelican","description":"Static site generator that supports Markdown and reST syntax. Powered by Python.","fork":false,"url":"https://api.github.com/repos/getpelican/pelican","forks_url":"https://api.github.com/repos/getpelican/pelican/forks","keys_url":"https://api.github.com/repos/getpelican/pelican/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getpelican/pelican/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getpelican/pelican/teams","hooks_url":"https://api.github.com/repos/getpelican/pelican/hooks","issue_events_url":"https://api.github.com/repos/getpelican/pelican/issues/events{/number}","events_url":"https://api.github.com/repos/getpelican/pelican/events","assignees_url":"https://api.github.com/repos/getpelican/pelican/assignees{/user}","branches_url":"https://api.github.com/repos/getpelican/pelican/branches{/branch}","tags_url":"https://api.github.com/repos/getpelican/pelican/tags","blobs_url":"https://api.github.com/repos/getpelican/pelican/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getpelican/pelican/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getpelican/pelican/git/refs{/sha}","trees_url":"https://api.github.com/repos/getpelican/pelican/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getpelican/pelican/statuses/{sha}","languages_url":"https://api.github.com/repos/getpelican/pelican/languages","stargazers_url":"https://api.github.com/repos/getpelican/pelican/stargazers","contributors_url":"https://api.github.com/repos/getpelican/pelican/contributors","subscribers_url":"https://api.github.com/repos/getpelican/pelican/subscribers","subscription_url":"https://api.github.com/repos/getpelican/pelican/subscription","commits_url":"https://api.github.com/repos/getpelican/pelican/commits{/sha}","git_commits_url":"https://api.github.com/repos/getpelican/pelican/git/commits{/sha}","comments_url":"https://api.github.com/repos/getpelican/pelican/comments{/number}","issue_comment_url":"https://api.github.com/repos/getpelican/pelican/issues/comments{/number}","contents_url":"https://api.github.com/repos/getpelican/pelican/contents/{+path}","compare_url":"https://api.github.com/repos/getpelican/pelican/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getpelican/pelican/merges","archive_url":"https://api.github.com/repos/getpelican/pelican/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getpelican/pelican/downloads","issues_url":"https://api.github.com/repos/getpelican/pelican/issues{/number}","pulls_url":"https://api.github.com/repos/getpelican/pelican/pulls{/number}","milestones_url":"https://api.github.com/repos/getpelican/pelican/milestones{/number}","notifications_url":"https://api.github.com/repos/getpelican/pelican/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getpelican/pelican/labels{/name}","releases_url":"https://api.github.com/repos/getpelican/pelican/releases{/id}","deployments_url":"https://api.github.com/repos/getpelican/pelican/deployments","created_at":"2010-10-16T18:57:40Z","updated_at":"2018-10-31T19:08:19Z","pushed_at":"2018-10-31T23:14:41Z","git_url":"git://github.com/getpelican/pelican.git","ssh_url":"git@github.com:getpelican/pelican.git","clone_url":"https://github.com/getpelican/pelican.git","svn_url":"https://github.com/getpelican/pelican","homepage":"https://getpelican.com/","size":5535,"stargazers_count":8288,"watchers_count":8288,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1528,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1528,"open_issues":149,"watchers":8288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/2375"},"html":{"href":"https://github.com/getpelican/pelican/pull/2375"},"issue":{"href":"https://api.github.com/repos/getpelican/pelican/issues/2375"},"comments":{"href":"https://api.github.com/repos/getpelican/pelican/issues/2375/comments"},"review_comments":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/2375/comments"},"review_comment":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/2375/commits"},"statuses":{"href":"https://api.github.com/repos/getpelican/pelican/statuses/a78950bce7a2c220f0ee25d617562852a6eba180"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oulenz"}}