{"action":"created","comment":{"url":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments/192563638","pull_request_review_id":125370229,"id":192563638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU2MzYzOA==","diff_hunk":"@@ -126,6 +126,13 @@ def test_fiat_convert_get_price(mocker):\n     assert fiat_convert._pairs[0]._expiration is not expiration\n \n \n+def test_fiat_convert_same_currencies(mocker):","path":"freqtrade/tests/test_fiat_convert.py","position":4,"original_position":4,"commit_id":"051e97797f18f19b5d219a9e2b1046bd74c216bc","original_commit_id":"051e97797f18f19b5d219a9e2b1046bd74c216bc","user":{"login":"glonlas","id":1137839,"node_id":"MDQ6VXNlcjExMzc4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1137839?v=4","gravatar_id":"","url":"https://api.github.com/users/glonlas","html_url":"https://github.com/glonlas","followers_url":"https://api.github.com/users/glonlas/followers","following_url":"https://api.github.com/users/glonlas/following{/other_user}","gists_url":"https://api.github.com/users/glonlas/gists{/gist_id}","starred_url":"https://api.github.com/users/glonlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glonlas/subscriptions","organizations_url":"https://api.github.com/users/glonlas/orgs","repos_url":"https://api.github.com/users/glonlas/repos","events_url":"https://api.github.com/users/glonlas/events{/privacy}","received_events_url":"https://api.github.com/users/glonlas/received_events","type":"User","site_admin":false},"body":"I will add the test, but it will fall in the next exception that returns 0.0.","created_at":"2018-06-02T16:18:10Z","updated_at":"2018-06-02T16:18:10Z","html_url":"https://github.com/gcarq/freqtrade/pull/817#discussion_r192563638","pull_request_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/817","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments/192563638"},"html":{"href":"https://github.com/gcarq/freqtrade/pull/817#discussion_r192563638"},"pull_request":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/817"}},"in_reply_to_id":192553204},"pull_request":{"url":"https://api.github.com/repos/gcarq/freqtrade/pulls/817","id":191948717,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTQ4NzE3","html_url":"https://github.com/gcarq/freqtrade/pull/817","diff_url":"https://github.com/gcarq/freqtrade/pull/817.diff","patch_url":"https://github.com/gcarq/freqtrade/pull/817.patch","issue_url":"https://api.github.com/repos/gcarq/freqtrade/issues/817","number":817,"state":"open","locked":false,"title":"Enable Backtesting with GDAX and allow trading with EUR/USD","user":{"login":"glonlas","id":1137839,"node_id":"MDQ6VXNlcjExMzc4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1137839?v=4","gravatar_id":"","url":"https://api.github.com/users/glonlas","html_url":"https://github.com/glonlas","followers_url":"https://api.github.com/users/glonlas/followers","following_url":"https://api.github.com/users/glonlas/following{/other_user}","gists_url":"https://api.github.com/users/glonlas/gists{/gist_id}","starred_url":"https://api.github.com/users/glonlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glonlas/subscriptions","organizations_url":"https://api.github.com/users/glonlas/orgs","repos_url":"https://api.github.com/users/glonlas/repos","events_url":"https://api.github.com/users/glonlas/events{/privacy}","received_events_url":"https://api.github.com/users/glonlas/received_events","type":"User","site_admin":false},"body":"## Summary\r\nThis PR fix `get_ticker_history()` that does not work with GDAX/Coinbase. \r\nThe issue is the ticker history received from GDAX is ordered DESC when Bittrex/Binance is ordered ASC. Because of that the get_ticker_history() fall in a very long loop when the tickers are sorted DESC. Means it downloads more ticker than needed and you could get throttle by GDAX.\r\n\r\nIn addition, this PR allows the usage of EUR and USD as `stake_currency` Means you can try trading with FIAT on exhange that support it\r\n\r\n## Quick changelog\r\n\r\n- Allow using EUR or USD as `stake_currency`. \r\n- Fix backtesting with GDAX and certainly more exchanges\r\n- First phase to make the bot compatible with GDAX\r\n\r\n## What's new?\r\nProvide the ability to backtest with GDAX and even more testing trading with EUR or USD.\r\n\r\n## Disclaimer\r\nI have not tested trading on GDAX yet. Only running Backtesting.\r\n","created_at":"2018-06-01T06:54:23Z","updated_at":"2018-06-02T16:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13dc64b9befec49c605b4ee3a02ee940b1f23e59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/817/commits","review_comments_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/817/comments","review_comment_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/issues/817/comments","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/051e97797f18f19b5d219a9e2b1046bd74c216bc","head":{"label":"gcarq:feature/gdax","ref":"feature/gdax","sha":"051e97797f18f19b5d219a9e2b1046bd74c216bc","user":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"repo":{"id":91629816,"node_id":"MDEwOlJlcG9zaXRvcnk5MTYyOTgxNg==","name":"freqtrade","full_name":"gcarq/freqtrade","owner":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcarq/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/gcarq/freqtrade","forks_url":"https://api.github.com/repos/gcarq/freqtrade/forks","keys_url":"https://api.github.com/repos/gcarq/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcarq/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcarq/freqtrade/teams","hooks_url":"https://api.github.com/repos/gcarq/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/gcarq/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/gcarq/freqtrade/events","assignees_url":"https://api.github.com/repos/gcarq/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/gcarq/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/gcarq/freqtrade/tags","blobs_url":"https://api.github.com/repos/gcarq/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcarq/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcarq/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcarq/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/gcarq/freqtrade/languages","stargazers_url":"https://api.github.com/repos/gcarq/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/gcarq/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/gcarq/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/gcarq/freqtrade/subscription","commits_url":"https://api.github.com/repos/gcarq/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcarq/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcarq/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcarq/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/gcarq/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcarq/freqtrade/merges","archive_url":"https://api.github.com/repos/gcarq/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcarq/freqtrade/downloads","issues_url":"https://api.github.com/repos/gcarq/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/gcarq/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/gcarq/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/gcarq/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcarq/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/gcarq/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/gcarq/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-06-02T16:08:25Z","pushed_at":"2018-06-02T14:45:10Z","git_url":"git://github.com/gcarq/freqtrade.git","ssh_url":"git@github.com:gcarq/freqtrade.git","clone_url":"https://github.com/gcarq/freqtrade.git","svn_url":"https://github.com/gcarq/freqtrade","homepage":null,"size":30114,"stargazers_count":778,"watchers_count":778,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":267,"open_issues":63,"watchers":778,"default_branch":"develop"}},"base":{"label":"gcarq:develop","ref":"develop","sha":"52386d81537048c0063582ff5f2aa120e0406c02","user":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"repo":{"id":91629816,"node_id":"MDEwOlJlcG9zaXRvcnk5MTYyOTgxNg==","name":"freqtrade","full_name":"gcarq/freqtrade","owner":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcarq/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/gcarq/freqtrade","forks_url":"https://api.github.com/repos/gcarq/freqtrade/forks","keys_url":"https://api.github.com/repos/gcarq/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcarq/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcarq/freqtrade/teams","hooks_url":"https://api.github.com/repos/gcarq/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/gcarq/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/gcarq/freqtrade/events","assignees_url":"https://api.github.com/repos/gcarq/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/gcarq/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/gcarq/freqtrade/tags","blobs_url":"https://api.github.com/repos/gcarq/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcarq/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcarq/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcarq/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/gcarq/freqtrade/languages","stargazers_url":"https://api.github.com/repos/gcarq/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/gcarq/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/gcarq/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/gcarq/freqtrade/subscription","commits_url":"https://api.github.com/repos/gcarq/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcarq/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcarq/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcarq/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/gcarq/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcarq/freqtrade/merges","archive_url":"https://api.github.com/repos/gcarq/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcarq/freqtrade/downloads","issues_url":"https://api.github.com/repos/gcarq/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/gcarq/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/gcarq/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/gcarq/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcarq/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/gcarq/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/gcarq/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-06-02T16:08:25Z","pushed_at":"2018-06-02T14:45:10Z","git_url":"git://github.com/gcarq/freqtrade.git","ssh_url":"git@github.com:gcarq/freqtrade.git","clone_url":"https://github.com/gcarq/freqtrade.git","svn_url":"https://github.com/gcarq/freqtrade","homepage":null,"size":30114,"stargazers_count":778,"watchers_count":778,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":267,"open_issues":63,"watchers":778,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/817"},"html":{"href":"https://github.com/gcarq/freqtrade/pull/817"},"issue":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/817"},"comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/817/comments"},"review_comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/817/comments"},"review_comment":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/817/commits"},"statuses":{"href":"https://api.github.com/repos/gcarq/freqtrade/statuses/051e97797f18f19b5d219a9e2b1046bd74c216bc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"glonlas"}}