{"action":"created","issue":{"url":"https://api.github.com/repos/bakape/meguca/issues/597","repository_url":"https://api.github.com/repos/bakape/meguca","labels_url":"https://api.github.com/repos/bakape/meguca/issues/597/labels{/name}","comments_url":"https://api.github.com/repos/bakape/meguca/issues/597/comments","events_url":"https://api.github.com/repos/bakape/meguca/issues/597/events","html_url":"https://github.com/bakape/meguca/issues/597","id":264628526,"number":597,"title":"Per page board cache","user":{"login":"Kagami","id":533383,"avatar_url":"https://avatars1.githubusercontent.com/u/533383?v=4","gravatar_id":"","url":"https://api.github.com/users/Kagami","html_url":"https://github.com/Kagami","followers_url":"https://api.github.com/users/Kagami/followers","following_url":"https://api.github.com/users/Kagami/following{/other_user}","gists_url":"https://api.github.com/users/Kagami/gists{/gist_id}","starred_url":"https://api.github.com/users/Kagami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kagami/subscriptions","organizations_url":"https://api.github.com/users/Kagami/orgs","repos_url":"https://api.github.com/users/Kagami/repos","events_url":"https://api.github.com/users/Kagami/events{/privacy}","received_events_url":"https://api.github.com/users/Kagami/received_events","type":"User","site_admin":false},"labels":[{"id":169844374,"url":"https://api.github.com/repos/bakape/meguca/labels/optimisation","name":"optimisation","color":"0e8a16","default":false},{"id":582798175,"url":"https://api.github.com/repos/bakape/meguca/labels/server","name":"server","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-10-11T15:17:51Z","updated_at":"2018-05-02T13:30:10Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently when client requests some board page after server restart, all threads of this board will be queried and placed to the cache: https://github.com/bakape/meguca/blob/3fc8f53d3fca47b7d6b7361a5c209fc990cf7129/go/src/meguca/server/cache.go#L108-L120\r\nThis might be huge amount of data and SQL requests if you have a lot of long-lived threads, e.g. 100+ pages.\r\n\r\nI think it would be better to query data only for the page client currently requested and request more as soon as they are needed."},"comment":{"url":"https://api.github.com/repos/bakape/meguca/issues/comments/385977910","html_url":"https://github.com/bakape/meguca/issues/597#issuecomment-385977910","issue_url":"https://api.github.com/repos/bakape/meguca/issues/597","id":385977910,"user":{"login":"bakape","id":7851952,"avatar_url":"https://avatars1.githubusercontent.com/u/7851952?v=4","gravatar_id":"","url":"https://api.github.com/users/bakape","html_url":"https://github.com/bakape","followers_url":"https://api.github.com/users/bakape/followers","following_url":"https://api.github.com/users/bakape/following{/other_user}","gists_url":"https://api.github.com/users/bakape/gists{/gist_id}","starred_url":"https://api.github.com/users/bakape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakape/subscriptions","organizations_url":"https://api.github.com/users/bakape/orgs","repos_url":"https://api.github.com/users/bakape/repos","events_url":"https://api.github.com/users/bakape/events{/privacy}","received_events_url":"https://api.github.com/users/bakape/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T13:30:09Z","updated_at":"2018-05-02T13:30:09Z","author_association":"OWNER","body":">What are interval calculations?\nAnything that has to be done between dumping changes to the DOM. In\nmeguca's case it is a fair amount of parsing and diffing, that happens\nalmost on every keypress + state management/updates.\n\n>t would be interesting to see benchmarks\nRemind me in 6 months or so.\n>first-time render of served HTML will be faster than WASM + data\nTrue.\n\nOn 2 May 2018 at 15:55, Kagami Hiiragi <notifications@github.com> wrote:\n\n> What are interval calculations?\n>\n> It would be interesting to see benchmarks but I suppose first-time render\n> of served HTML will be faster than WASM + data. The former is much more\n> optimized by the browser itself, the latter will have to go through several\n> additional abstraction layers.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bakape/meguca/issues/597#issuecomment-385967921>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AHfPsESqtXvgjTL7VTmUG_v2Ak_Geru6ks5tuay9gaJpZM4P1qGQ>\n> .\n>\n"}}
{"actor":{"display_login":"bakape"}}