{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/218419134","pull_request_review_id":156350268,"id":218419134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODQxOTEzNA==","diff_hunk":"@@ -0,0 +1,368 @@\n+package api\n+\n+// TODO: needs unit tests\n+\n+// Notes: shortcomings of the Azure-style API include:\n+// 1. There is no mechanism to delete an item from a slice or map without\n+// implementing a separate CRUD endpoint.\n+// 2. There is no way to set a plain value to its zero value (e.g. bool to\n+// false, int to 0, string to \"\") without storing it as a pointer in the API.\n+\n+// At the moment Config isn't merged.  Perhaps what we actually need is a\n+// merging converter f(*ext, *int) *int.  Perhaps this would mean we could get\n+// rid of some pointers in our internal type.\n+\n+func Merge(complete, partial *OpenShiftManagedCluster) *OpenShiftManagedCluster {\n+\tcomplete = complete.DeepCopy() // required because Config isn't merged\n+\n+\treturn mergeOpenShiftManagedCluster(complete, partial)\n+}\n+\n+func mergeOpenShiftManagedCluster(complete, partial *OpenShiftManagedCluster) *OpenShiftManagedCluster {\n+\tswitch {\n+\tcase complete == nil && partial == nil:\n+\t\treturn nil\n+\tcase complete == nil:","path":"pkg/api/merge.go","position":25,"original_position":25,"commit_id":"a688956e9ed48b041801219de8585651db282fd6","original_commit_id":"a688956e9ed48b041801219de8585651db282fd6","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"I think the DeepCopy() just needs to be guarded with an `if complete != nil`.  Thanks, will fix.","created_at":"2018-09-18T12:54:31Z","updated_at":"2018-09-18T12:54:31Z","html_url":"https://github.com/openshift/openshift-azure/pull/471#discussion_r218419134","pull_request_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/471","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/218419134"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/471#discussion_r218419134"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/471"}},"in_reply_to_id":218409374},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/471","id":216166364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTY2MzY0","html_url":"https://github.com/openshift/openshift-azure/pull/471","diff_url":"https://github.com/openshift/openshift-azure/pull/471.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/471.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/471","number":471,"state":"open","locked":false,"title":"Implement merge","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"Builds on #470 \r\n\r\nfixes #434","created_at":"2018-09-18T02:34:28Z","updated_at":"2018-09-18T12:54:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d62c5b6f17dac02f1b8f11f651dffff262976872","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":984233114,"node_id":"MDU6TGFiZWw5ODQyMzMxMTQ=","url":"https://api.github.com/repos/openshift/openshift-azure/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":1006545045,"node_id":"MDU6TGFiZWwxMDA2NTQ1MDQ1","url":"https://api.github.com/repos/openshift/openshift-azure/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1044383642,"node_id":"MDU6TGFiZWwxMDQ0MzgzNjQy","url":"https://api.github.com/repos/openshift/openshift-azure/labels/private-preview","name":"private-preview","color":"4ef93e","default":false},{"id":1006544214,"node_id":"MDU6TGFiZWwxMDA2NTQ0MjE0","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/471/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/471/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/471/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/a688956e9ed48b041801219de8585651db282fd6","head":{"label":"jim-minter:merge","ref":"merge","sha":"a688956e9ed48b041801219de8585651db282fd6","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":142488214,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODgyMTQ=","name":"openshift-azure","full_name":"jim-minter/openshift-azure","private":false,"owner":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jim-minter/openshift-azure","description":null,"fork":true,"url":"https://api.github.com/repos/jim-minter/openshift-azure","forks_url":"https://api.github.com/repos/jim-minter/openshift-azure/forks","keys_url":"https://api.github.com/repos/jim-minter/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/openshift-azure/teams","hooks_url":"https://api.github.com/repos/jim-minter/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/openshift-azure/events","assignees_url":"https://api.github.com/repos/jim-minter/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/tags","blobs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/jim-minter/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscription","commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/openshift-azure/merges","archive_url":"https://api.github.com/repos/jim-minter/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/openshift-azure/downloads","issues_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/openshift-azure/deployments","created_at":"2018-07-26T19:59:36Z","updated_at":"2018-09-06T18:05:41Z","pushed_at":"2018-09-18T03:16:27Z","git_url":"git://github.com/jim-minter/openshift-azure.git","ssh_url":"git@github.com:jim-minter/openshift-azure.git","clone_url":"https://github.com/jim-minter/openshift-azure.git","svn_url":"https://github.com/jim-minter/openshift-azure","homepage":null,"size":27882,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e9800af3c124e4559b6d385474234493c9938bb7","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-09-18T11:42:31Z","pushed_at":"2018-09-18T12:36:59Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":27772,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":81,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/471"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/471"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/471"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/a688956e9ed48b041801219de8585651db282fd6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jim-minter"}}