{"action":"created","comment":{"url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/comments/188249406","pull_request_review_id":120186087,"id":188249406,"diff_hunk":"@@ -11,13 +11,19 @@ if test $# -eq 0; then\n     exit 1\n fi\n \n-fabmanager list-users --app superset # Run this to report any config errors visibly. https://github.com/dpgaspar/Flask-AppBuilder/issues/742\n-user_count=\"$(fabmanager list-users --app superset | sed -n '/^username/p' | wc -l)\"\n-if test \"${user_count}\" = 0; then\n-    stderr \"No users exist. Creating admin user.\"\n-    fabmanager create-admin --app superset --username admin --password admin \\\n-        --firstname Admin --lastname Admin --email admin@localhost\n+SUPERSET_ADMIN_USERNAME=\"${SUPERSET_ADMIN_USERNAME-admin}\"\n+SUPERSET_ADMIN_PASSWORD=\"${SUPERSET_ADMIN_PASSWORD:-admin}\"\n+if test ! -z \"${SUPERSET_ADMIN_USERNAME}\"; then","path":"docker-entrypoint.sh","position":12,"original_position":12,"commit_id":"f7e6f6097601357486c2e3efac751520ffb8d419","original_commit_id":"f7e6f6097601357486c2e3efac751520ffb8d419","user":{"login":"sopel39","id":5989165,"avatar_url":"https://avatars1.githubusercontent.com/u/5989165?v=4","gravatar_id":"","url":"https://api.github.com/users/sopel39","html_url":"https://github.com/sopel39","followers_url":"https://api.github.com/users/sopel39/followers","following_url":"https://api.github.com/users/sopel39/following{/other_user}","gists_url":"https://api.github.com/users/sopel39/gists{/gist_id}","starred_url":"https://api.github.com/users/sopel39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sopel39/subscriptions","organizations_url":"https://api.github.com/users/sopel39/orgs","repos_url":"https://api.github.com/users/sopel39/repos","events_url":"https://api.github.com/users/sopel39/events{/privacy}","received_events_url":"https://api.github.com/users/sopel39/received_events","type":"User","site_admin":false},"body":"Can `SUPERSET_ADMIN_USERNAME` be unset? Can it be empty? Maybe fail if it is empty.","created_at":"2018-05-15T11:15:49Z","updated_at":"2018-05-15T11:18:02Z","html_url":"https://github.com/starburstdata/superset-docker/pull/6#discussion_r188249406","pull_request_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/comments/188249406"},"html":{"href":"https://github.com/starburstdata/superset-docker/pull/6#discussion_r188249406"},"pull_request":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6","id":188083748,"html_url":"https://github.com/starburstdata/superset-docker/pull/6","diff_url":"https://github.com/starburstdata/superset-docker/pull/6.diff","patch_url":"https://github.com/starburstdata/superset-docker/pull/6.patch","issue_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/6","number":6,"state":"open","locked":false,"title":" Make admin user creation configurable","user":{"login":"findepi","id":144328,"avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-15T10:34:46Z","updated_at":"2018-05-15T11:18:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1682f8bffe7770c86974df8326b7bc1af0808bac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6/commits","review_comments_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6/comments","review_comment_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/6/comments","statuses_url":"https://api.github.com/repos/starburstdata/superset-docker/statuses/f7e6f6097601357486c2e3efac751520ffb8d419","head":{"label":"starburstdata:findepi/configurable-admin","ref":"findepi/configurable-admin","sha":"f7e6f6097601357486c2e3efac751520ffb8d419","user":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"repo":{"id":130985689,"name":"superset-docker","full_name":"starburstdata/superset-docker","owner":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/starburstdata/superset-docker","description":null,"fork":false,"url":"https://api.github.com/repos/starburstdata/superset-docker","forks_url":"https://api.github.com/repos/starburstdata/superset-docker/forks","keys_url":"https://api.github.com/repos/starburstdata/superset-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starburstdata/superset-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starburstdata/superset-docker/teams","hooks_url":"https://api.github.com/repos/starburstdata/superset-docker/hooks","issue_events_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/events{/number}","events_url":"https://api.github.com/repos/starburstdata/superset-docker/events","assignees_url":"https://api.github.com/repos/starburstdata/superset-docker/assignees{/user}","branches_url":"https://api.github.com/repos/starburstdata/superset-docker/branches{/branch}","tags_url":"https://api.github.com/repos/starburstdata/superset-docker/tags","blobs_url":"https://api.github.com/repos/starburstdata/superset-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starburstdata/superset-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starburstdata/superset-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/starburstdata/superset-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starburstdata/superset-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/starburstdata/superset-docker/languages","stargazers_url":"https://api.github.com/repos/starburstdata/superset-docker/stargazers","contributors_url":"https://api.github.com/repos/starburstdata/superset-docker/contributors","subscribers_url":"https://api.github.com/repos/starburstdata/superset-docker/subscribers","subscription_url":"https://api.github.com/repos/starburstdata/superset-docker/subscription","commits_url":"https://api.github.com/repos/starburstdata/superset-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/starburstdata/superset-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/starburstdata/superset-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/starburstdata/superset-docker/contents/{+path}","compare_url":"https://api.github.com/repos/starburstdata/superset-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starburstdata/superset-docker/merges","archive_url":"https://api.github.com/repos/starburstdata/superset-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starburstdata/superset-docker/downloads","issues_url":"https://api.github.com/repos/starburstdata/superset-docker/issues{/number}","pulls_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/starburstdata/superset-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/starburstdata/superset-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starburstdata/superset-docker/labels{/name}","releases_url":"https://api.github.com/repos/starburstdata/superset-docker/releases{/id}","deployments_url":"https://api.github.com/repos/starburstdata/superset-docker/deployments","created_at":"2018-04-25T09:51:53Z","updated_at":"2018-05-15T09:19:40Z","pushed_at":"2018-05-15T10:52:08Z","git_url":"git://github.com/starburstdata/superset-docker.git","ssh_url":"git@github.com:starburstdata/superset-docker.git","clone_url":"https://github.com/starburstdata/superset-docker.git","svn_url":"https://github.com/starburstdata/superset-docker","homepage":null,"size":7,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"starburstdata:master","ref":"master","sha":"7746e23c1dc0e18929f90673695568edbc973a5b","user":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"repo":{"id":130985689,"name":"superset-docker","full_name":"starburstdata/superset-docker","owner":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/starburstdata/superset-docker","description":null,"fork":false,"url":"https://api.github.com/repos/starburstdata/superset-docker","forks_url":"https://api.github.com/repos/starburstdata/superset-docker/forks","keys_url":"https://api.github.com/repos/starburstdata/superset-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starburstdata/superset-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starburstdata/superset-docker/teams","hooks_url":"https://api.github.com/repos/starburstdata/superset-docker/hooks","issue_events_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/events{/number}","events_url":"https://api.github.com/repos/starburstdata/superset-docker/events","assignees_url":"https://api.github.com/repos/starburstdata/superset-docker/assignees{/user}","branches_url":"https://api.github.com/repos/starburstdata/superset-docker/branches{/branch}","tags_url":"https://api.github.com/repos/starburstdata/superset-docker/tags","blobs_url":"https://api.github.com/repos/starburstdata/superset-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starburstdata/superset-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starburstdata/superset-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/starburstdata/superset-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starburstdata/superset-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/starburstdata/superset-docker/languages","stargazers_url":"https://api.github.com/repos/starburstdata/superset-docker/stargazers","contributors_url":"https://api.github.com/repos/starburstdata/superset-docker/contributors","subscribers_url":"https://api.github.com/repos/starburstdata/superset-docker/subscribers","subscription_url":"https://api.github.com/repos/starburstdata/superset-docker/subscription","commits_url":"https://api.github.com/repos/starburstdata/superset-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/starburstdata/superset-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/starburstdata/superset-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/starburstdata/superset-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/starburstdata/superset-docker/contents/{+path}","compare_url":"https://api.github.com/repos/starburstdata/superset-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starburstdata/superset-docker/merges","archive_url":"https://api.github.com/repos/starburstdata/superset-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starburstdata/superset-docker/downloads","issues_url":"https://api.github.com/repos/starburstdata/superset-docker/issues{/number}","pulls_url":"https://api.github.com/repos/starburstdata/superset-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/starburstdata/superset-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/starburstdata/superset-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starburstdata/superset-docker/labels{/name}","releases_url":"https://api.github.com/repos/starburstdata/superset-docker/releases{/id}","deployments_url":"https://api.github.com/repos/starburstdata/superset-docker/deployments","created_at":"2018-04-25T09:51:53Z","updated_at":"2018-05-15T09:19:40Z","pushed_at":"2018-05-15T10:52:08Z","git_url":"git://github.com/starburstdata/superset-docker.git","ssh_url":"git@github.com:starburstdata/superset-docker.git","clone_url":"https://github.com/starburstdata/superset-docker.git","svn_url":"https://github.com/starburstdata/superset-docker","homepage":null,"size":7,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6"},"html":{"href":"https://github.com/starburstdata/superset-docker/pull/6"},"issue":{"href":"https://api.github.com/repos/starburstdata/superset-docker/issues/6"},"comments":{"href":"https://api.github.com/repos/starburstdata/superset-docker/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/starburstdata/superset-docker/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/starburstdata/superset-docker/statuses/f7e6f6097601357486c2e3efac751520ffb8d419"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sopel39"}}