{"action":"created","issue":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/2320","repository_url":"https://api.github.com/repos/awesomeWM/awesome","labels_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2320/labels{/name}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2320/comments","events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2320/events","html_url":"https://github.com/awesomeWM/awesome/pull/2320","id":344228885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjc0NTg1","number":2320,"title":"build: Add all warnings.","user":{"login":"Elv13","id":340384,"node_id":"MDQ6VXNlcjM0MDM4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/340384?v=4","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-24T22:39:23Z","updated_at":"2018-07-28T02:18:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2320","html_url":"https://github.com/awesomeWM/awesome/pull/2320","diff_url":"https://github.com/awesomeWM/awesome/pull/2320.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/2320.patch"},"body":"So the CI can catch them and potential contributor see them.\r\n\r\nImported from the generic cmake files I add to my C++ projects. The list is not extensive. Clang has -Weverything, but GCC devs keep refusing to add it. `-Wpedantic` is not set because Awesome codebase doesn't comply with it at all.\r\n\r\nNote that I also fix the CMakeLists.txt so we dont get the wraning from liblua and stdlib/posix.\r\n\r\nThe next step would be to merge @blueyed Docker work so we can have the modern `scanbuild` and sanitizer warnings. Last time I ran them locally there was some minor memory leaks and undefined behaviors."},"comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments/408576121","html_url":"https://github.com/awesomeWM/awesome/pull/2320#issuecomment-408576121","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2320","id":408576121,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODU3NjEyMQ==","user":{"login":"blueyed","id":9766,"node_id":"MDQ6VXNlcjk3NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9766?v=4","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T02:18:12Z","updated_at":"2018-07-28T02:18:12Z","author_association":"MEMBER","body":"> mb comment them out and uncomment one by one as soon as the check fixed? it will be easier to track the progress on that\r\n\r\nBut then it would also be better to have a separate PR for each of them in the first placce, making this PR then an empy merge / something to just close in the end."}}
{"actor":{"display_login":"blueyed"}}