{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/31","repository_url":"https://api.github.com/repos/mapbox/geojson-mapnikify","labels_url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/31/comments","events_url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/31/events","html_url":"https://github.com/mapbox/geojson-mapnikify/pull/31","id":313075488,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwNzE3MDIz","number":31,"title":"Allow customizing request() options","user":{"login":"agius","id":162151,"node_id":"MDQ6VXNlcjE2MjE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/162151?v=4","gravatar_id":"","url":"https://api.github.com/users/agius","html_url":"https://github.com/agius","followers_url":"https://api.github.com/users/agius/followers","following_url":"https://api.github.com/users/agius/following{/other_user}","gists_url":"https://api.github.com/users/agius/gists{/gist_id}","starred_url":"https://api.github.com/users/agius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agius/subscriptions","organizations_url":"https://api.github.com/users/agius/orgs","repos_url":"https://api.github.com/users/agius/repos","events_url":"https://api.github.com/users/agius/events{/privacy}","received_events_url":"https://api.github.com/users/agius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-10T20:22:45Z","updated_at":"2018-06-04T21:35:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mapbox/geojson-mapnikify/pulls/31","html_url":"https://github.com/mapbox/geojson-mapnikify/pull/31","diff_url":"https://github.com/mapbox/geojson-mapnikify/pull/31.diff","patch_url":"https://github.com/mapbox/geojson-mapnikify/pull/31.patch"},"body":"Currently, there is no way to customize the options used for fetching url-based image markers. This can be a problem if a parent library or application wants to set a longer or shorter timeout, specify a proxy server, or other special use cases. This PR allows setting a custom `request()` client, where these options can be specified using `request.defaults()` .\r\n\r\nAlso noticed that tests were hitting Flickr urls which could disappear at some point - fixed that by mocking those requests with [nock](https://www.npmjs.com/package/nock)"},"comment":{"url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/comments/394507416","html_url":"https://github.com/mapbox/geojson-mapnikify/pull/31#issuecomment-394507416","issue_url":"https://api.github.com/repos/mapbox/geojson-mapnikify/issues/31","id":394507416,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDUwNzQxNg==","user":{"login":"agius","id":162151,"node_id":"MDQ6VXNlcjE2MjE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/162151?v=4","gravatar_id":"","url":"https://api.github.com/users/agius","html_url":"https://github.com/agius","followers_url":"https://api.github.com/users/agius/followers","following_url":"https://api.github.com/users/agius/following{/other_user}","gists_url":"https://api.github.com/users/agius/gists{/gist_id}","starred_url":"https://api.github.com/users/agius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agius/subscriptions","organizations_url":"https://api.github.com/users/agius/orgs","repos_url":"https://api.github.com/users/agius/repos","events_url":"https://api.github.com/users/agius/events{/privacy}","received_events_url":"https://api.github.com/users/agius/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T21:35:32Z","updated_at":"2018-06-04T21:35:32Z","author_association":"NONE","body":"@GretaCB thanks for the review! I've incorporated y'all's feedback. QQ: should I bump the package version in this PR, or merge and make a separate bump PR? Nothing backwards-breaking, so this'd prob be a patch or minor release?"}}
{"actor":{"display_login":"agius"}}