{"action":"opened","number":2472,"pull_request":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472","id":241162339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTYyMzM5","html_url":"https://github.com/parcel-bundler/parcel/pull/2472","diff_url":"https://github.com/parcel-bundler/parcel/pull/2472.diff","patch_url":"https://github.com/parcel-bundler/parcel/pull/2472.patch","issue_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/2472","number":2472,"state":"open","locked":false,"title":"Generate source map files with long extentions (e.g. .js.map)","user":{"login":"kirillrogovoy","id":4512269,"node_id":"MDQ6VXNlcjQ1MTIyNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/4512269?v=4","gravatar_id":"","url":"https://api.github.com/users/kirillrogovoy","html_url":"https://github.com/kirillrogovoy","followers_url":"https://api.github.com/users/kirillrogovoy/followers","following_url":"https://api.github.com/users/kirillrogovoy/following{/other_user}","gists_url":"https://api.github.com/users/kirillrogovoy/gists{/gist_id}","starred_url":"https://api.github.com/users/kirillrogovoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirillrogovoy/subscriptions","organizations_url":"https://api.github.com/users/kirillrogovoy/orgs","repos_url":"https://api.github.com/users/kirillrogovoy/repos","events_url":"https://api.github.com/users/kirillrogovoy/events{/privacy}","received_events_url":"https://api.github.com/users/kirillrogovoy/received_events","type":"User","site_admin":false},"body":"<!---\r\nThanks for filing a pull request 😄 ! Before you submit, please read the following:\r\n\r\nSearch open/closed issues before submitting since someone might have pushed the same thing before!\r\n-->\r\n\r\n# ↪️ Pull Request\r\n\r\nCloses #2460.\r\n\r\nWhat I do here is preserve the original file extension before appending `.map` to the source map files.\r\n\r\nInstead of `index.map` it would generate `index.js.map`. According to the [spec](https://sourcemaps.info/spec.html) it's the recommended convention. It also solves a real issue for debugging Javascript in VSCode.\r\n\r\nWhile it solves the issue, I don't like the tech debt I introduce. Specifically, I don't like the conditionals about specific types of bundles in the otherwise abstract code.\r\n\r\n@DeMoorJasper please, take a look and let me know if you can think of a more pleasing solution architecture-wise. This is my first peek at the internals of Parcel, so I don't have the whole context yet.\r\n\r\n## ✔️ PR Todo\r\n\r\n- [x] Added/updated unit tests for this change\r\n- [x] Filled out test instructions (In case there aren't any unit tests)\r\n- [x] Included links to related issues/PRs\r\n\r\n<!--\r\nLove parcel? Please consider supporting our collective:\r\n👉  https://opencollective.com/parcel/donate\r\n-->","created_at":"2018-12-27T14:18:43Z","updated_at":"2018-12-27T14:18:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472/commits","review_comments_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472/comments","review_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/2472/comments","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/b9a869346293316ed40d8515dfdeb0fd98b13030","head":{"label":"kirillrogovoy:master","ref":"master","sha":"b9a869346293316ed40d8515dfdeb0fd98b13030","user":{"login":"kirillrogovoy","id":4512269,"node_id":"MDQ6VXNlcjQ1MTIyNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/4512269?v=4","gravatar_id":"","url":"https://api.github.com/users/kirillrogovoy","html_url":"https://github.com/kirillrogovoy","followers_url":"https://api.github.com/users/kirillrogovoy/followers","following_url":"https://api.github.com/users/kirillrogovoy/following{/other_user}","gists_url":"https://api.github.com/users/kirillrogovoy/gists{/gist_id}","starred_url":"https://api.github.com/users/kirillrogovoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirillrogovoy/subscriptions","organizations_url":"https://api.github.com/users/kirillrogovoy/orgs","repos_url":"https://api.github.com/users/kirillrogovoy/repos","events_url":"https://api.github.com/users/kirillrogovoy/events{/privacy}","received_events_url":"https://api.github.com/users/kirillrogovoy/received_events","type":"User","site_admin":false},"repo":{"id":163269307,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMyNjkzMDc=","name":"parcel","full_name":"kirillrogovoy/parcel","private":false,"owner":{"login":"kirillrogovoy","id":4512269,"node_id":"MDQ6VXNlcjQ1MTIyNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/4512269?v=4","gravatar_id":"","url":"https://api.github.com/users/kirillrogovoy","html_url":"https://github.com/kirillrogovoy","followers_url":"https://api.github.com/users/kirillrogovoy/followers","following_url":"https://api.github.com/users/kirillrogovoy/following{/other_user}","gists_url":"https://api.github.com/users/kirillrogovoy/gists{/gist_id}","starred_url":"https://api.github.com/users/kirillrogovoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirillrogovoy/subscriptions","organizations_url":"https://api.github.com/users/kirillrogovoy/orgs","repos_url":"https://api.github.com/users/kirillrogovoy/repos","events_url":"https://api.github.com/users/kirillrogovoy/events{/privacy}","received_events_url":"https://api.github.com/users/kirillrogovoy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kirillrogovoy/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":true,"url":"https://api.github.com/repos/kirillrogovoy/parcel","forks_url":"https://api.github.com/repos/kirillrogovoy/parcel/forks","keys_url":"https://api.github.com/repos/kirillrogovoy/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirillrogovoy/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirillrogovoy/parcel/teams","hooks_url":"https://api.github.com/repos/kirillrogovoy/parcel/hooks","issue_events_url":"https://api.github.com/repos/kirillrogovoy/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/kirillrogovoy/parcel/events","assignees_url":"https://api.github.com/repos/kirillrogovoy/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/kirillrogovoy/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/kirillrogovoy/parcel/tags","blobs_url":"https://api.github.com/repos/kirillrogovoy/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirillrogovoy/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirillrogovoy/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirillrogovoy/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirillrogovoy/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/kirillrogovoy/parcel/languages","stargazers_url":"https://api.github.com/repos/kirillrogovoy/parcel/stargazers","contributors_url":"https://api.github.com/repos/kirillrogovoy/parcel/contributors","subscribers_url":"https://api.github.com/repos/kirillrogovoy/parcel/subscribers","subscription_url":"https://api.github.com/repos/kirillrogovoy/parcel/subscription","commits_url":"https://api.github.com/repos/kirillrogovoy/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirillrogovoy/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirillrogovoy/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirillrogovoy/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirillrogovoy/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/kirillrogovoy/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirillrogovoy/parcel/merges","archive_url":"https://api.github.com/repos/kirillrogovoy/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirillrogovoy/parcel/downloads","issues_url":"https://api.github.com/repos/kirillrogovoy/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/kirillrogovoy/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/kirillrogovoy/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/kirillrogovoy/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirillrogovoy/parcel/labels{/name}","releases_url":"https://api.github.com/repos/kirillrogovoy/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/kirillrogovoy/parcel/deployments","created_at":"2018-12-27T08:36:02Z","updated_at":"2018-12-27T14:08:30Z","pushed_at":"2018-12-27T14:08:28Z","git_url":"git://github.com/kirillrogovoy/parcel.git","ssh_url":"git@github.com:kirillrogovoy/parcel.git","clone_url":"https://github.com/kirillrogovoy/parcel.git","svn_url":"https://github.com/kirillrogovoy/parcel","homepage":"https://parceljs.org","size":3981,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"parcel-bundler:master","ref":"master","sha":"0fac29efd7a60cd982eb26ba026ac4b8ad715e91","user":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":99598595,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5ODU5NQ==","name":"parcel","full_name":"parcel-bundler/parcel","private":false,"owner":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/parcel-bundler/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":false,"url":"https://api.github.com/repos/parcel-bundler/parcel","forks_url":"https://api.github.com/repos/parcel-bundler/parcel/forks","keys_url":"https://api.github.com/repos/parcel-bundler/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parcel-bundler/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parcel-bundler/parcel/teams","hooks_url":"https://api.github.com/repos/parcel-bundler/parcel/hooks","issue_events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/parcel-bundler/parcel/events","assignees_url":"https://api.github.com/repos/parcel-bundler/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/parcel-bundler/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/parcel-bundler/parcel/tags","blobs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parcel-bundler/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/parcel-bundler/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/parcel-bundler/parcel/languages","stargazers_url":"https://api.github.com/repos/parcel-bundler/parcel/stargazers","contributors_url":"https://api.github.com/repos/parcel-bundler/parcel/contributors","subscribers_url":"https://api.github.com/repos/parcel-bundler/parcel/subscribers","subscription_url":"https://api.github.com/repos/parcel-bundler/parcel/subscription","commits_url":"https://api.github.com/repos/parcel-bundler/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/parcel-bundler/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/parcel-bundler/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/parcel-bundler/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parcel-bundler/parcel/merges","archive_url":"https://api.github.com/repos/parcel-bundler/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parcel-bundler/parcel/downloads","issues_url":"https://api.github.com/repos/parcel-bundler/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/parcel-bundler/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/parcel-bundler/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/labels{/name}","releases_url":"https://api.github.com/repos/parcel-bundler/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/parcel-bundler/parcel/deployments","created_at":"2017-08-07T16:36:47Z","updated_at":"2018-12-27T13:32:53Z","pushed_at":"2018-12-27T01:16:06Z","git_url":"git://github.com/parcel-bundler/parcel.git","ssh_url":"git@github.com:parcel-bundler/parcel.git","clone_url":"https://github.com/parcel-bundler/parcel.git","svn_url":"https://github.com/parcel-bundler/parcel","homepage":"https://parceljs.org","size":3981,"stargazers_count":28762,"watchers_count":28762,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1275,"mirror_url":null,"archived":false,"open_issues_count":602,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1275,"open_issues":602,"watchers":28762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472"},"html":{"href":"https://github.com/parcel-bundler/parcel/pull/2472"},"issue":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/2472"},"comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/2472/comments"},"review_comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472/comments"},"review_comment":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/2472/commits"},"statuses":{"href":"https://api.github.com/repos/parcel-bundler/parcel/statuses/b9a869346293316ed40d8515dfdeb0fd98b13030"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":25,"deletions":14,"changed_files":3}}
{"actor":{"display_login":"kirillrogovoy"}}