{"action":"created","comment":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/comments/211808217","pull_request_review_id":148308555,"id":211808217,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTgwODIxNw==","diff_hunk":"@@ -888,7 +888,7 @@ def synthetic_stack(\n             tile_extras_provider = cls._default_tile_extras_provider\n \n         img = TileSet(\n-            {Coordinates.X, Coordinates.Y, Indices.ROUND, Indices.CH, Indices.Z},\n+            {Indices.X, Indices.Y, Indices.ROUND, Indices.CH, Indices.Z},","path":"starfish/stack.py","position":23,"original_position":49,"commit_id":"5fc0f0148cab7485ef34413b9fd13586f6a6fdee","original_commit_id":"76a347a7e184aaa0d5481f9bacd724edf75daca2","user":{"login":"ambrosejcarr","id":5239152,"node_id":"MDQ6VXNlcjUyMzkxNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5239152?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrosejcarr","html_url":"https://github.com/ambrosejcarr","followers_url":"https://api.github.com/users/ambrosejcarr/followers","following_url":"https://api.github.com/users/ambrosejcarr/following{/other_user}","gists_url":"https://api.github.com/users/ambrosejcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrosejcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrosejcarr/subscriptions","organizations_url":"https://api.github.com/users/ambrosejcarr/orgs","repos_url":"https://api.github.com/users/ambrosejcarr/repos","events_url":"https://api.github.com/users/ambrosejcarr/events{/privacy}","received_events_url":"https://api.github.com/users/ambrosejcarr/received_events","type":"User","site_admin":false},"body":"This is the same as the one that tony confirmed was supposed to be Indices. I've changed the two instances of coordinates that you correctly identified were wrong. 👍 ","created_at":"2018-08-22T01:39:43Z","updated_at":"2018-08-22T01:39:43Z","html_url":"https://github.com/spacetx/starfish/pull/446#discussion_r211808217","pull_request_url":"https://api.github.com/repos/spacetx/starfish/pulls/446","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments/211808217"},"html":{"href":"https://github.com/spacetx/starfish/pull/446#discussion_r211808217"},"pull_request":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/446"}},"in_reply_to_id":211341684},"pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/446","id":209321956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzIxOTU2","html_url":"https://github.com/spacetx/starfish/pull/446","diff_url":"https://github.com/spacetx/starfish/pull/446.diff","patch_url":"https://github.com/spacetx/starfish/pull/446.patch","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/446","number":446,"state":"open","locked":false,"title":"ENH: replace Coordinates.X,Y & Features.X,Y with Indices.X,Y","user":{"login":"ambrosejcarr","id":5239152,"node_id":"MDQ6VXNlcjUyMzkxNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5239152?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrosejcarr","html_url":"https://github.com/ambrosejcarr","followers_url":"https://api.github.com/users/ambrosejcarr/followers","following_url":"https://api.github.com/users/ambrosejcarr/following{/other_user}","gists_url":"https://api.github.com/users/ambrosejcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrosejcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrosejcarr/subscriptions","organizations_url":"https://api.github.com/users/ambrosejcarr/orgs","repos_url":"https://api.github.com/users/ambrosejcarr/repos","events_url":"https://api.github.com/users/ambrosejcarr/events{/privacy}","received_events_url":"https://api.github.com/users/ambrosejcarr/received_events","type":"User","site_admin":false},"body":"This is a longstanding issue wherein we agree that `Indices` should gain `X, Y`, `Features` should Lose `X, Y` and `Coordinates.X, .Y` and `.Z` should be used only when referring to coordinates. \r\n\r\nThis PR makes those changes. ","created_at":"2018-08-18T17:22:13Z","updated_at":"2018-08-22T01:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d32571d613e5be669fa5e29563d48c32d472ca8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ttung","id":280924,"node_id":"MDQ6VXNlcjI4MDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/280924?v=4","gravatar_id":"","url":"https://api.github.com/users/ttung","html_url":"https://github.com/ttung","followers_url":"https://api.github.com/users/ttung/followers","following_url":"https://api.github.com/users/ttung/following{/other_user}","gists_url":"https://api.github.com/users/ttung/gists{/gist_id}","starred_url":"https://api.github.com/users/ttung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttung/subscriptions","organizations_url":"https://api.github.com/users/ttung/orgs","repos_url":"https://api.github.com/users/ttung/repos","events_url":"https://api.github.com/users/ttung/events{/privacy}","received_events_url":"https://api.github.com/users/ttung/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetx/starfish/pulls/446/commits","review_comments_url":"https://api.github.com/repos/spacetx/starfish/pulls/446/comments","review_comment_url":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/446/comments","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/5fc0f0148cab7485ef34413b9fd13586f6a6fdee","head":{"label":"spacetx:ajc-fix-coordinates-xy","ref":"ajc-fix-coordinates-xy","sha":"5fc0f0148cab7485ef34413b9fd13586f6a6fdee","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spacetx/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-08-20T23:42:29Z","pushed_at":"2018-08-22T00:07:18Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":53442,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":84,"watchers":38,"default_branch":"master"}},"base":{"label":"spacetx:master","ref":"master","sha":"5699415846379178041627ec2f72fa215ee8c307","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spacetx/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-08-20T23:42:29Z","pushed_at":"2018-08-22T00:07:18Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":53442,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":84,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/446"},"html":{"href":"https://github.com/spacetx/starfish/pull/446"},"issue":{"href":"https://api.github.com/repos/spacetx/starfish/issues/446"},"comments":{"href":"https://api.github.com/repos/spacetx/starfish/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/spacetx/starfish/statuses/5fc0f0148cab7485ef34413b9fd13586f6a6fdee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ambrosejcarr"}}