{"action":"created","comment":{"url":"https://api.github.com/repos/scalameta/scalameta/pulls/comments/170346324","pull_request_review_id":99018587,"id":170346324,"diff_hunk":"@@ -0,0 +1,270 @@\n+package scala.meta.internal.metacp.asm\n+\n+import scala.tools.asm.signature.SignatureReader\n+\n+/** Translation of \"Signature\" section from the JVM spec to Scala.\n+  *\n+  * @see https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.9.1\n+  */\n+sealed trait JavaTypeSignature extends JavaTypeSignature.Printable\n+object JavaTypeSignature {","path":"semanticdb/metacp/src/main/scala/scala/meta/internal/metacp/asm/JavaTypeSignature.scala","position":10,"original_position":10,"commit_id":"c50f2dfd3ba79941d68f2f10086bd76203460f87","original_commit_id":"c50f2dfd3ba79941d68f2f10086bd76203460f87","user":{"login":"xeno-by","id":609152,"avatar_url":"https://avatars0.githubusercontent.com/u/609152?v=4","gravatar_id":"","url":"https://api.github.com/users/xeno-by","html_url":"https://github.com/xeno-by","followers_url":"https://api.github.com/users/xeno-by/followers","following_url":"https://api.github.com/users/xeno-by/following{/other_user}","gists_url":"https://api.github.com/users/xeno-by/gists{/gist_id}","starred_url":"https://api.github.com/users/xeno-by/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeno-by/subscriptions","organizations_url":"https://api.github.com/users/xeno-by/orgs","repos_url":"https://api.github.com/users/xeno-by/repos","events_url":"https://api.github.com/users/xeno-by/events{/privacy}","received_events_url":"https://api.github.com/users/xeno-by/received_events","type":"User","site_admin":false},"body":"I really like the idea to model these concepts as proper ADTs!","created_at":"2018-02-23T19:33:51Z","updated_at":"2018-02-23T19:43:47Z","html_url":"https://github.com/scalameta/scalameta/pull/1359#discussion_r170346324","pull_request_url":"https://api.github.com/repos/scalameta/scalameta/pulls/1359","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/comments/170346324"},"html":{"href":"https://github.com/scalameta/scalameta/pull/1359#discussion_r170346324"},"pull_request":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/1359"}}},"pull_request":{"url":"https://api.github.com/repos/scalameta/scalameta/pulls/1359","id":171052319,"html_url":"https://github.com/scalameta/scalameta/pull/1359","diff_url":"https://github.com/scalameta/scalameta/pull/1359.diff","patch_url":"https://github.com/scalameta/scalameta/pull/1359.patch","issue_url":"https://api.github.com/repos/scalameta/scalameta/issues/1359","number":1359,"state":"open","locked":false,"title":"WIP - Add Java support for metacp","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"body":"This PR extends metacp to support Java class files. Opening PR now to get feedback on the diff (which should be mostly polished) but still need to clean up the commit history.\r\n\r\n","created_at":"2018-02-23T16:06:07Z","updated_at":"2018-02-23T19:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf7fa13ced5593f2be59ebb953d45f1ae0fe68f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalameta/scalameta/pulls/1359/commits","review_comments_url":"https://api.github.com/repos/scalameta/scalameta/pulls/1359/comments","review_comment_url":"https://api.github.com/repos/scalameta/scalameta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalameta/scalameta/issues/1359/comments","statuses_url":"https://api.github.com/repos/scalameta/scalameta/statuses/c50f2dfd3ba79941d68f2f10086bd76203460f87","head":{"label":"olafurpg:javap","ref":"javap","sha":"c50f2dfd3ba79941d68f2f10086bd76203460f87","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"repo":{"id":51755729,"name":"scalameta","full_name":"olafurpg/scalameta","owner":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olafurpg/scalameta","description":"Simple, robust and portable metaprogramming toolkit for Scala","fork":true,"url":"https://api.github.com/repos/olafurpg/scalameta","forks_url":"https://api.github.com/repos/olafurpg/scalameta/forks","keys_url":"https://api.github.com/repos/olafurpg/scalameta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olafurpg/scalameta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olafurpg/scalameta/teams","hooks_url":"https://api.github.com/repos/olafurpg/scalameta/hooks","issue_events_url":"https://api.github.com/repos/olafurpg/scalameta/issues/events{/number}","events_url":"https://api.github.com/repos/olafurpg/scalameta/events","assignees_url":"https://api.github.com/repos/olafurpg/scalameta/assignees{/user}","branches_url":"https://api.github.com/repos/olafurpg/scalameta/branches{/branch}","tags_url":"https://api.github.com/repos/olafurpg/scalameta/tags","blobs_url":"https://api.github.com/repos/olafurpg/scalameta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olafurpg/scalameta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olafurpg/scalameta/git/refs{/sha}","trees_url":"https://api.github.com/repos/olafurpg/scalameta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olafurpg/scalameta/statuses/{sha}","languages_url":"https://api.github.com/repos/olafurpg/scalameta/languages","stargazers_url":"https://api.github.com/repos/olafurpg/scalameta/stargazers","contributors_url":"https://api.github.com/repos/olafurpg/scalameta/contributors","subscribers_url":"https://api.github.com/repos/olafurpg/scalameta/subscribers","subscription_url":"https://api.github.com/repos/olafurpg/scalameta/subscription","commits_url":"https://api.github.com/repos/olafurpg/scalameta/commits{/sha}","git_commits_url":"https://api.github.com/repos/olafurpg/scalameta/git/commits{/sha}","comments_url":"https://api.github.com/repos/olafurpg/scalameta/comments{/number}","issue_comment_url":"https://api.github.com/repos/olafurpg/scalameta/issues/comments{/number}","contents_url":"https://api.github.com/repos/olafurpg/scalameta/contents/{+path}","compare_url":"https://api.github.com/repos/olafurpg/scalameta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olafurpg/scalameta/merges","archive_url":"https://api.github.com/repos/olafurpg/scalameta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olafurpg/scalameta/downloads","issues_url":"https://api.github.com/repos/olafurpg/scalameta/issues{/number}","pulls_url":"https://api.github.com/repos/olafurpg/scalameta/pulls{/number}","milestones_url":"https://api.github.com/repos/olafurpg/scalameta/milestones{/number}","notifications_url":"https://api.github.com/repos/olafurpg/scalameta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olafurpg/scalameta/labels{/name}","releases_url":"https://api.github.com/repos/olafurpg/scalameta/releases{/id}","deployments_url":"https://api.github.com/repos/olafurpg/scalameta/deployments","created_at":"2016-02-15T13:01:38Z","updated_at":"2016-02-15T13:01:39Z","pushed_at":"2018-02-23T19:18:48Z","git_url":"git://github.com/olafurpg/scalameta.git","ssh_url":"git@github.com:olafurpg/scalameta.git","clone_url":"https://github.com/olafurpg/scalameta.git","svn_url":"https://github.com/olafurpg/scalameta","homepage":null,"size":13059,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalameta:master","ref":"master","sha":"e138a00f2696ee26561b6a7519d5ed6a67785286","user":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars1.githubusercontent.com/u/7526438?v=4","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"repo":{"id":20903383,"name":"scalameta","full_name":"scalameta/scalameta","owner":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars1.githubusercontent.com/u/7526438?v=4","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalameta/scalameta","description":"Library to read, analyze, transform and generate Scala programs","fork":false,"url":"https://api.github.com/repos/scalameta/scalameta","forks_url":"https://api.github.com/repos/scalameta/scalameta/forks","keys_url":"https://api.github.com/repos/scalameta/scalameta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalameta/scalameta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalameta/scalameta/teams","hooks_url":"https://api.github.com/repos/scalameta/scalameta/hooks","issue_events_url":"https://api.github.com/repos/scalameta/scalameta/issues/events{/number}","events_url":"https://api.github.com/repos/scalameta/scalameta/events","assignees_url":"https://api.github.com/repos/scalameta/scalameta/assignees{/user}","branches_url":"https://api.github.com/repos/scalameta/scalameta/branches{/branch}","tags_url":"https://api.github.com/repos/scalameta/scalameta/tags","blobs_url":"https://api.github.com/repos/scalameta/scalameta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalameta/scalameta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalameta/scalameta/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalameta/scalameta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalameta/scalameta/statuses/{sha}","languages_url":"https://api.github.com/repos/scalameta/scalameta/languages","stargazers_url":"https://api.github.com/repos/scalameta/scalameta/stargazers","contributors_url":"https://api.github.com/repos/scalameta/scalameta/contributors","subscribers_url":"https://api.github.com/repos/scalameta/scalameta/subscribers","subscription_url":"https://api.github.com/repos/scalameta/scalameta/subscription","commits_url":"https://api.github.com/repos/scalameta/scalameta/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalameta/scalameta/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalameta/scalameta/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalameta/scalameta/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalameta/scalameta/contents/{+path}","compare_url":"https://api.github.com/repos/scalameta/scalameta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalameta/scalameta/merges","archive_url":"https://api.github.com/repos/scalameta/scalameta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalameta/scalameta/downloads","issues_url":"https://api.github.com/repos/scalameta/scalameta/issues{/number}","pulls_url":"https://api.github.com/repos/scalameta/scalameta/pulls{/number}","milestones_url":"https://api.github.com/repos/scalameta/scalameta/milestones{/number}","notifications_url":"https://api.github.com/repos/scalameta/scalameta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalameta/scalameta/labels{/name}","releases_url":"https://api.github.com/repos/scalameta/scalameta/releases{/id}","deployments_url":"https://api.github.com/repos/scalameta/scalameta/deployments","created_at":"2014-06-16T23:00:32Z","updated_at":"2018-02-22T14:24:31Z","pushed_at":"2018-02-23T19:18:50Z","git_url":"git://github.com/scalameta/scalameta.git","ssh_url":"git@github.com:scalameta/scalameta.git","clone_url":"https://github.com/scalameta/scalameta.git","svn_url":"https://github.com/scalameta/scalameta","homepage":"http://scalameta.org/","size":12235,"stargazers_count":588,"watchers_count":588,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":123,"open_issues":126,"watchers":588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/1359"},"html":{"href":"https://github.com/scalameta/scalameta/pull/1359"},"issue":{"href":"https://api.github.com/repos/scalameta/scalameta/issues/1359"},"comments":{"href":"https://api.github.com/repos/scalameta/scalameta/issues/1359/comments"},"review_comments":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/1359/comments"},"review_comment":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/1359/commits"},"statuses":{"href":"https://api.github.com/repos/scalameta/scalameta/statuses/c50f2dfd3ba79941d68f2f10086bd76203460f87"}},"author_association":"OWNER"}}
{"actor":{"display_login":"xeno-by"}}