{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/244682461","pull_request_review_id":188609737,"id":244682461,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY4MjQ2MQ==","diff_hunk":"@@ -139,6 +178,7 @@ def plot_by_id(run_id: int,\n \n         if len(data) == 2:  # 1D PLOTTING\n             log.debug('Plotting by id, doing a 1D plot')\n+            log.debug(f\"kwargs are {kwargs}\")","path":"qcodes/dataset/plotting.py","position":57,"original_position":57,"commit_id":"7a7eabc654d6ca9ab518136e214c66b3223d1e8b","original_commit_id":"7a7eabc654d6ca9ab518136e214c66b3223d1e8b","user":{"login":"jenshnielsen","id":548266,"node_id":"MDQ6VXNlcjU0ODI2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/548266?v=4","gravatar_id":"","url":"https://api.github.com/users/jenshnielsen","html_url":"https://github.com/jenshnielsen","followers_url":"https://api.github.com/users/jenshnielsen/followers","following_url":"https://api.github.com/users/jenshnielsen/following{/other_user}","gists_url":"https://api.github.com/users/jenshnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jenshnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenshnielsen/subscriptions","organizations_url":"https://api.github.com/users/jenshnielsen/orgs","repos_url":"https://api.github.com/users/jenshnielsen/repos","events_url":"https://api.github.com/users/jenshnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/jenshnielsen/received_events","type":"User","site_admin":false},"body":"I think it might be slightly more performant to just do one log message?","created_at":"2019-01-02T08:50:38Z","updated_at":"2019-01-02T08:54:09Z","html_url":"https://github.com/QCoDeS/Qcodes/pull/1427#discussion_r244682461","pull_request_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/244682461"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1427#discussion_r244682461"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427"}}},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427","id":241313574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzEzNTc0","html_url":"https://github.com/QCoDeS/Qcodes/pull/1427","diff_url":"https://github.com/QCoDeS/Qcodes/pull/1427.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/1427.patch","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1427","number":1427,"state":"open","locked":false,"title":"Fix / plot by id cmap kwarg","user":{"login":"WilliamHPNielsen","id":23165537,"node_id":"MDQ6VXNlcjIzMTY1NTM3","avatar_url":"https://avatars3.githubusercontent.com/u/23165537?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamHPNielsen","html_url":"https://github.com/WilliamHPNielsen","followers_url":"https://api.github.com/users/WilliamHPNielsen/followers","following_url":"https://api.github.com/users/WilliamHPNielsen/following{/other_user}","gists_url":"https://api.github.com/users/WilliamHPNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamHPNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamHPNielsen/subscriptions","organizations_url":"https://api.github.com/users/WilliamHPNielsen/orgs","repos_url":"https://api.github.com/users/WilliamHPNielsen/repos","events_url":"https://api.github.com/users/WilliamHPNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamHPNielsen/received_events","type":"User","site_admin":false},"body":"Fixes #1426 \r\n\r\nThe problem in #1426 arose because of the way the `kwargs` to different plots were handled. It may well be that one call to `plot_by_id` produces several different plot types (heatmaps, line plots, etc.). They do not all consume the same `kwargs`, e.g. `'cmap'` is unknown to a line plot.  \r\n\r\nChanges proposed in this pull request:\r\n- Introduce a context manager to handle passing on only the relevant `kwargs` to each plot.\r\n\r\n@QCoDeS/core \r\n","created_at":"2018-12-28T11:05:33Z","updated_at":"2019-01-02T08:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"159e146df794d08c97139da00e0c79d6f8a5d4f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1427/comments","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/7a7eabc654d6ca9ab518136e214c66b3223d1e8b","head":{"label":"WilliamHPNielsen:fix/plot_by_id_cmap_kwarg","ref":"fix/plot_by_id_cmap_kwarg","sha":"7a7eabc654d6ca9ab518136e214c66b3223d1e8b","user":{"login":"WilliamHPNielsen","id":23165537,"node_id":"MDQ6VXNlcjIzMTY1NTM3","avatar_url":"https://avatars3.githubusercontent.com/u/23165537?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamHPNielsen","html_url":"https://github.com/WilliamHPNielsen","followers_url":"https://api.github.com/users/WilliamHPNielsen/followers","following_url":"https://api.github.com/users/WilliamHPNielsen/following{/other_user}","gists_url":"https://api.github.com/users/WilliamHPNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamHPNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamHPNielsen/subscriptions","organizations_url":"https://api.github.com/users/WilliamHPNielsen/orgs","repos_url":"https://api.github.com/users/WilliamHPNielsen/repos","events_url":"https://api.github.com/users/WilliamHPNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamHPNielsen/received_events","type":"User","site_admin":false},"repo":{"id":74138117,"node_id":"MDEwOlJlcG9zaXRvcnk3NDEzODExNw==","name":"Qcodes","full_name":"WilliamHPNielsen/Qcodes","private":false,"owner":{"login":"WilliamHPNielsen","id":23165537,"node_id":"MDQ6VXNlcjIzMTY1NTM3","avatar_url":"https://avatars3.githubusercontent.com/u/23165537?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamHPNielsen","html_url":"https://github.com/WilliamHPNielsen","followers_url":"https://api.github.com/users/WilliamHPNielsen/followers","following_url":"https://api.github.com/users/WilliamHPNielsen/following{/other_user}","gists_url":"https://api.github.com/users/WilliamHPNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamHPNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamHPNielsen/subscriptions","organizations_url":"https://api.github.com/users/WilliamHPNielsen/orgs","repos_url":"https://api.github.com/users/WilliamHPNielsen/repos","events_url":"https://api.github.com/users/WilliamHPNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamHPNielsen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WilliamHPNielsen/Qcodes","description":"Modular data acquisition and analysis framework","fork":true,"url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes","forks_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/forks","keys_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/teams","hooks_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/events","assignees_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/tags","blobs_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/languages","stargazers_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/subscription","commits_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/merges","archive_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/downloads","issues_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/WilliamHPNielsen/Qcodes/deployments","created_at":"2016-11-18T14:44:52Z","updated_at":"2018-08-15T07:43:20Z","pushed_at":"2018-12-28T11:03:14Z","git_url":"git://github.com/WilliamHPNielsen/Qcodes.git","ssh_url":"git@github.com:WilliamHPNielsen/Qcodes.git","clone_url":"https://github.com/WilliamHPNielsen/Qcodes.git","svn_url":"https://github.com/WilliamHPNielsen/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":45643,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"023d4189fbe762d6532c18b95447171a5ab3569f","user":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"node_id":"MDEwOlJlcG9zaXRvcnkzNzEzNzg3OQ==","name":"Qcodes","full_name":"QCoDeS/Qcodes","private":false,"owner":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2018-12-29T21:21:23Z","pushed_at":"2018-12-28T11:05:34Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":96209,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":223,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":90,"open_issues":223,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1427"},"issue":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1427"},"comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1427/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1427/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/7a7eabc654d6ca9ab518136e214c66b3223d1e8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jenshnielsen"}}