{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/225523550","pull_request_review_id":165139494,"id":225523550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUyMzU1MA==","diff_hunk":"@@ -666,6 +667,33 @@ public void SerializationTest(string filePath)\n                 serializationTestUtils.SaveWorkspaceComparisonData);\n         }\n \n+        /// <summary>\n+        /// This parameterized test finds all .dyn files in directories within\n+        /// the test directory, opens them and executes, then converts them to\n+        /// json and executes again, comparing the values from the two runs\n+        /// while being in a different culture.\n+        /// </summary>\n+        /// <param name=\"filePath\">The path to a .dyn file. This parameter is supplied\n+        /// by the test framework.</param>\n+        [Test, TestCaseSource(\"FindWorkspaces\"), Category(\"JsonTestExclude\")]\n+        public void SerializationTestInDifferentCulture(string filePath)","path":"test/DynamoCoreTests/SerializationTests.cs","position":21,"original_position":21,"commit_id":"054b2627f6726d951a7694bfb36c1bcc46dd696c","original_commit_id":"054b2627f6726d951a7694bfb36c1bcc46dd696c","user":{"login":"sm6srw","id":7033002,"node_id":"MDQ6VXNlcjcwMzMwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7033002?v=4","gravatar_id":"","url":"https://api.github.com/users/sm6srw","html_url":"https://github.com/sm6srw","followers_url":"https://api.github.com/users/sm6srw/followers","following_url":"https://api.github.com/users/sm6srw/following{/other_user}","gists_url":"https://api.github.com/users/sm6srw/gists{/gist_id}","starred_url":"https://api.github.com/users/sm6srw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm6srw/subscriptions","organizations_url":"https://api.github.com/users/sm6srw/orgs","repos_url":"https://api.github.com/users/sm6srw/repos","events_url":"https://api.github.com/users/sm6srw/events{/privacy}","received_events_url":"https://api.github.com/users/sm6srw/received_events","type":"User","site_admin":false},"body":"Thanks, I wasn't aware of the directory. I will use a new directory for this test.","created_at":"2018-10-16T12:49:15Z","updated_at":"2018-10-16T12:49:16Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/9178#discussion_r225523550","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/225523550"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9178#discussion_r225523550"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178"}},"in_reply_to_id":225290021},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178","id":222947950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTQ3OTUw","html_url":"https://github.com/DynamoDS/Dynamo/pull/9178","diff_url":"https://github.com/DynamoDS/Dynamo/pull/9178.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/9178.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9178","number":9178,"state":"open","locked":false,"title":"QNTM-5568 Refinery needs to support culture invariance for number fmt, part Deux","user":{"login":"sm6srw","id":7033002,"node_id":"MDQ6VXNlcjcwMzMwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7033002?v=4","gravatar_id":"","url":"https://api.github.com/users/sm6srw","html_url":"https://github.com/sm6srw","followers_url":"https://api.github.com/users/sm6srw/followers","following_url":"https://api.github.com/users/sm6srw/following{/other_user}","gists_url":"https://api.github.com/users/sm6srw/gists{/gist_id}","starred_url":"https://api.github.com/users/sm6srw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm6srw/subscriptions","organizations_url":"https://api.github.com/users/sm6srw/orgs","repos_url":"https://api.github.com/users/sm6srw/repos","events_url":"https://api.github.com/users/sm6srw/events{/privacy}","received_events_url":"https://api.github.com/users/sm6srw/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThis pull request addresses JIRA task [QNTM-5568](https://jira.autodesk.com/browse/QNTM-5568).\r\n\r\n#### This pull request does\r\n- format the value string in output nodes using the  `InvariantCulture` format\r\n- use the `InvariantCulture` format when converting the value string in input and output nodes to `double`\r\n\r\nStill need to run all tests...\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [X] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [X] The level of testing this PR includes is appropriate\r\n- [X] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [X] Snapshot of UI changes, if any.\r\n- [X] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n\r\n@longc @mjkkirschner \r\n\r\n### FYIs\r\n\r\n","created_at":"2018-10-15T15:27:54Z","updated_at":"2018-10-16T12:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f2804ae9f3866e18c8b964e9354a0132452fe07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9178/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/054b2627f6726d951a7694bfb36c1bcc46dd696c","head":{"label":"sm6srw:QNTM-5568","ref":"QNTM-5568","sha":"054b2627f6726d951a7694bfb36c1bcc46dd696c","user":{"login":"sm6srw","id":7033002,"node_id":"MDQ6VXNlcjcwMzMwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7033002?v=4","gravatar_id":"","url":"https://api.github.com/users/sm6srw","html_url":"https://github.com/sm6srw","followers_url":"https://api.github.com/users/sm6srw/followers","following_url":"https://api.github.com/users/sm6srw/following{/other_user}","gists_url":"https://api.github.com/users/sm6srw/gists{/gist_id}","starred_url":"https://api.github.com/users/sm6srw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm6srw/subscriptions","organizations_url":"https://api.github.com/users/sm6srw/orgs","repos_url":"https://api.github.com/users/sm6srw/repos","events_url":"https://api.github.com/users/sm6srw/events{/privacy}","received_events_url":"https://api.github.com/users/sm6srw/received_events","type":"User","site_admin":false},"repo":{"id":51018030,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxODAzMA==","name":"Dynamo","full_name":"sm6srw/Dynamo","private":false,"owner":{"login":"sm6srw","id":7033002,"node_id":"MDQ6VXNlcjcwMzMwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7033002?v=4","gravatar_id":"","url":"https://api.github.com/users/sm6srw","html_url":"https://github.com/sm6srw","followers_url":"https://api.github.com/users/sm6srw/followers","following_url":"https://api.github.com/users/sm6srw/following{/other_user}","gists_url":"https://api.github.com/users/sm6srw/gists{/gist_id}","starred_url":"https://api.github.com/users/sm6srw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm6srw/subscriptions","organizations_url":"https://api.github.com/users/sm6srw/orgs","repos_url":"https://api.github.com/users/sm6srw/repos","events_url":"https://api.github.com/users/sm6srw/events{/privacy}","received_events_url":"https://api.github.com/users/sm6srw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sm6srw/Dynamo","description":"Visual Programming","fork":true,"url":"https://api.github.com/repos/sm6srw/Dynamo","forks_url":"https://api.github.com/repos/sm6srw/Dynamo/forks","keys_url":"https://api.github.com/repos/sm6srw/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sm6srw/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sm6srw/Dynamo/teams","hooks_url":"https://api.github.com/repos/sm6srw/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/sm6srw/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/sm6srw/Dynamo/events","assignees_url":"https://api.github.com/repos/sm6srw/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/sm6srw/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/sm6srw/Dynamo/tags","blobs_url":"https://api.github.com/repos/sm6srw/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sm6srw/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sm6srw/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sm6srw/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sm6srw/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/sm6srw/Dynamo/languages","stargazers_url":"https://api.github.com/repos/sm6srw/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/sm6srw/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/sm6srw/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/sm6srw/Dynamo/subscription","commits_url":"https://api.github.com/repos/sm6srw/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sm6srw/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sm6srw/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sm6srw/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sm6srw/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/sm6srw/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sm6srw/Dynamo/merges","archive_url":"https://api.github.com/repos/sm6srw/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sm6srw/Dynamo/downloads","issues_url":"https://api.github.com/repos/sm6srw/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/sm6srw/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/sm6srw/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/sm6srw/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sm6srw/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/sm6srw/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/sm6srw/Dynamo/deployments","created_at":"2016-02-03T17:41:35Z","updated_at":"2018-10-08T13:34:38Z","pushed_at":"2018-10-15T18:42:16Z","git_url":"git://github.com/sm6srw/Dynamo.git","ssh_url":"git@github.com:sm6srw/Dynamo.git","clone_url":"https://github.com/sm6srw/Dynamo.git","svn_url":"https://github.com/sm6srw/Dynamo","homepage":"http://dynamobim.org","size":1039919,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"507c402abef8e30a698874686027d62becbbebab","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk1MTc5","name":"Dynamo","full_name":"DynamoDS/Dynamo","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/Dynamo","description":"Open Source Graphical Programming for Design","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2018-10-15T16:59:36Z","pushed_at":"2018-10-15T23:59:38Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1381475,"stargazers_count":642,"watchers_count":642,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":370,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":370,"open_issues":501,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9178"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9178"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9178/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9178/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/054b2627f6726d951a7694bfb36c1bcc46dd696c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sm6srw"}}