{"action":"opened","number":51,"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51","id":207148187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTQ4MTg3","html_url":"https://github.com/NuGet/NuGet.Services.EndToEnd/pull/51","diff_url":"https://github.com/NuGet/NuGet.Services.EndToEnd/pull/51.diff","patch_url":"https://github.com/NuGet/NuGet.Services.EndToEnd/pull/51.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/51","number":51,"state":"open","locked":false,"title":"Add retry around V2V3SearchClient polling and Azure Management API calls","user":{"login":"joelverhagen","id":94054,"node_id":"MDQ6VXNlcjk0MDU0","avatar_url":"https://avatars0.githubusercontent.com/u/94054?v=4","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"body":"I took a \"data driven\" approach to adding retries to E2E tests. I looked at all E2E test failures available in VSTS's history and analyzed the failure types. Transient errors fell into two categories:\r\n\r\n1. Transient issues encountered while polling the search service, waiting for a package appear.\r\n    - `SocketException`\r\n    - `TaskCanceledException`\r\n1. Azure Management API being down\r\n    - `AzureManagementException`\r\n\r\nTo avoid retries potentially hiding bugs, I took this minimal approach and only added retries to these exception types and code paths.\r\n\r\nWe can easily extend the retries in the future as needed.","created_at":"2018-08-08T21:52:04Z","updated_at":"2018-08-08T21:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/51/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/statuses/8399ab49191ecafa4b0018a42f8ed42dd8078dbe","head":{"label":"NuGet:jver-retry","ref":"jver-retry","sha":"8399ab49191ecafa4b0018a42f8ed42dd8078dbe","user":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":88656118,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY1NjExOA==","name":"NuGet.Services.EndToEnd","full_name":"NuGet/NuGet.Services.EndToEnd","owner":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Services.EndToEnd","description":null,"fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd","forks_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/deployments","created_at":"2017-04-18T18:13:15Z","updated_at":"2018-08-02T21:46:00Z","pushed_at":"2018-08-08T21:44:31Z","git_url":"git://github.com/NuGet/NuGet.Services.EndToEnd.git","ssh_url":"git@github.com:NuGet/NuGet.Services.EndToEnd.git","clone_url":"https://github.com/NuGet/NuGet.Services.EndToEnd.git","svn_url":"https://github.com/NuGet/NuGet.Services.EndToEnd","homepage":null,"size":6287,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"3ca423d6608573d1f929632cba8813ec8ba1b3e4","user":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":88656118,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY1NjExOA==","name":"NuGet.Services.EndToEnd","full_name":"NuGet/NuGet.Services.EndToEnd","owner":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Services.EndToEnd","description":null,"fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd","forks_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/deployments","created_at":"2017-04-18T18:13:15Z","updated_at":"2018-08-02T21:46:00Z","pushed_at":"2018-08-08T21:44:31Z","git_url":"git://github.com/NuGet/NuGet.Services.EndToEnd.git","ssh_url":"git@github.com:NuGet/NuGet.Services.EndToEnd.git","clone_url":"https://github.com/NuGet/NuGet.Services.EndToEnd.git","svn_url":"https://github.com/NuGet/NuGet.Services.EndToEnd","homepage":null,"size":6287,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51"},"html":{"href":"https://github.com/NuGet/NuGet.Services.EndToEnd/pull/51"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/51"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.EndToEnd/statuses/8399ab49191ecafa4b0018a42f8ed42dd8078dbe"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":588,"deletions":32,"changed_files":12}}
{"actor":{"display_login":"joelverhagen"}}