{"action":"created","issue":{"url":"https://api.github.com/repos/versatica/mediasoup-client/issues/54","repository_url":"https://api.github.com/repos/versatica/mediasoup-client","labels_url":"https://api.github.com/repos/versatica/mediasoup-client/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/versatica/mediasoup-client/issues/54/comments","events_url":"https://api.github.com/repos/versatica/mediasoup-client/issues/54/events","html_url":"https://github.com/versatica/mediasoup-client/pull/54","id":377889867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzI0NDQ2","number":54,"title":"Make mediasoup-client compatible with react-native-webrtc","user":{"login":"Sharcoux","id":797545,"node_id":"MDQ6VXNlcjc5NzU0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/797545?v=4","gravatar_id":"","url":"https://api.github.com/users/Sharcoux","html_url":"https://github.com/Sharcoux","followers_url":"https://api.github.com/users/Sharcoux/followers","following_url":"https://api.github.com/users/Sharcoux/following{/other_user}","gists_url":"https://api.github.com/users/Sharcoux/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharcoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharcoux/subscriptions","organizations_url":"https://api.github.com/users/Sharcoux/orgs","repos_url":"https://api.github.com/users/Sharcoux/repos","events_url":"https://api.github.com/users/Sharcoux/events{/privacy}","received_events_url":"https://api.github.com/users/Sharcoux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-06T15:09:39Z","updated_at":"2018-11-06T15:50:34Z","closed_at":"2018-11-06T15:50:34Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/versatica/mediasoup-client/pulls/54","html_url":"https://github.com/versatica/mediasoup-client/pull/54","diff_url":"https://github.com/versatica/mediasoup-client/pull/54.diff","patch_url":"https://github.com/versatica/mediasoup-client/pull/54.patch"},"body":"extends MediaStream to make mediasoup-client fully and immediately compatible with react-native-webrtc"},"comment":{"url":"https://api.github.com/repos/versatica/mediasoup-client/issues/comments/436301708","html_url":"https://github.com/versatica/mediasoup-client/pull/54#issuecomment-436301708","issue_url":"https://api.github.com/repos/versatica/mediasoup-client/issues/54","id":436301708,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjMwMTcwOA==","user":{"login":"ibc","id":16191,"node_id":"MDQ6VXNlcjE2MTkx","avatar_url":"https://avatars2.githubusercontent.com/u/16191?v=4","gravatar_id":"","url":"https://api.github.com/users/ibc","html_url":"https://github.com/ibc","followers_url":"https://api.github.com/users/ibc/followers","following_url":"https://api.github.com/users/ibc/following{/other_user}","gists_url":"https://api.github.com/users/ibc/gists{/gist_id}","starred_url":"https://api.github.com/users/ibc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibc/subscriptions","organizations_url":"https://api.github.com/users/ibc/orgs","repos_url":"https://api.github.com/users/ibc/repos","events_url":"https://api.github.com/users/ibc/events{/privacy}","received_events_url":"https://api.github.com/users/ibc/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T15:50:34Z","updated_at":"2018-11-06T15:50:34Z","author_association":"MEMBER","body":"Sorry, I cannot accept this PR:\r\n\r\n* It does not follow the coding style of mediasoup-client (`gulp lint` does not pass).\r\n* It pollutes `window` object, so it's intrusive.\r\n* This issue must be fixed in `react-native-webrtc` project, which obviously implements a super outdated and limited WebRTC API (still stream based), and makes wrong assumptions such as assuming that the only MediaStreams that the app must use are those generated by the `react-native-webrtc`.\r\n\r\nI plan to work on this in the future, but I've no time/resources right now."}}
{"actor":{"display_login":"ibc"}}