{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments/165958813","pull_request_review_id":93973582,"id":165958813,"diff_hunk":"@@ -312,6 +308,17 @@ class XCUITestDriver extends BaseDriver {\n       await this.opts.device.clearCaches('com.apple.mobile.installd.staging');\n \n       await this.startSim();\n+\n+      if (this.opts.customSSLCert) {\n+        log.info(`Installing ssl cert ${_.truncate(this.opts.customSSLCert, 20)}`);\n+        log.warn(`If a certificate from this domain was already installed this test may fail and can be fixed by\n+          erasing the contents of the Simulator (Simulator > Hardware > Erase All Content and Settings) and running the tests again`);\n+        await installSSLCert(this.opts.customSSLCert, this.opts.udid);\n+        await this.opts.device.shutdown();","path":"lib/driver.js","position":21,"original_position":21,"commit_id":"f6fcd938066ea7e0745f33cbe09c7c10a8309a83","original_commit_id":"f6fcd938066ea7e0745f33cbe09c7c10a8309a83","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"Simulator restart is an expensive operation. We should not restart it every time when the corresponding capability matches, but rather do it once, change the necessary stuff and start it when all the changes are completed.","created_at":"2018-02-05T12:31:37Z","updated_at":"2018-02-05T12:31:37Z","html_url":"https://github.com/appium/appium-xcuitest-driver/pull/620#discussion_r165958813","pull_request_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments/165958813"},"html":{"href":"https://github.com/appium/appium-xcuitest-driver/pull/620#discussion_r165958813"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620","id":166932987,"html_url":"https://github.com/appium/appium-xcuitest-driver/pull/620","diff_url":"https://github.com/appium/appium-xcuitest-driver/pull/620.diff","patch_url":"https://github.com/appium/appium-xcuitest-driver/pull/620.patch","issue_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/620","number":620,"state":"open","locked":false,"title":"Reboot Simulator when install cert","user":{"login":"dpgraham","id":852574,"avatar_url":"https://avatars2.githubusercontent.com/u/852574?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgraham","html_url":"https://github.com/dpgraham","followers_url":"https://api.github.com/users/dpgraham/followers","following_url":"https://api.github.com/users/dpgraham/following{/other_user}","gists_url":"https://api.github.com/users/dpgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgraham/subscriptions","organizations_url":"https://api.github.com/users/dpgraham/orgs","repos_url":"https://api.github.com/users/dpgraham/repos","events_url":"https://api.github.com/users/dpgraham/events{/privacy}","received_events_url":"https://api.github.com/users/dpgraham/received_events","type":"User","site_admin":false},"body":"* Since iOS 10.3 SQLite certificate installation stopped working in XCUITestDriver\r\n* To make it work, the order of events has to be as follows:\r\n  * Start a simulator\r\n  * Install the SSL certificate\r\n  * Restart the simulator\r\n* Moved the installSSLCert function to _after_ the simulator is started and then restart the the Simulator so that the certificate will take effect\r\n\r\n(related to https://github.com/appium/appium/issues#boards?milestones=Robot%2021%232018-02-02&repos=7530570)","created_at":"2018-02-03T00:24:48Z","updated_at":"2018-02-05T12:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4f07c37965a7ccccc7ae1f3c7946b011ebe282a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jlipps","id":605053,"avatar_url":"https://avatars3.githubusercontent.com/u/605053?v=4","gravatar_id":"","url":"https://api.github.com/users/jlipps","html_url":"https://github.com/jlipps","followers_url":"https://api.github.com/users/jlipps/followers","following_url":"https://api.github.com/users/jlipps/following{/other_user}","gists_url":"https://api.github.com/users/jlipps/gists{/gist_id}","starred_url":"https://api.github.com/users/jlipps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlipps/subscriptions","organizations_url":"https://api.github.com/users/jlipps/orgs","repos_url":"https://api.github.com/users/jlipps/repos","events_url":"https://api.github.com/users/jlipps/events{/privacy}","received_events_url":"https://api.github.com/users/jlipps/received_events","type":"User","site_admin":false},{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620/commits","review_comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620/comments","review_comment_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/620/comments","statuses_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/f6fcd938066ea7e0745f33cbe09c7c10a8309a83","head":{"label":"appium:dpgraham-ssl-cert-fix","ref":"dpgraham-ssl-cert-fix","sha":"f6fcd938066ea7e0745f33cbe09c7c10a8309a83","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":47652761,"name":"appium-xcuitest-driver","full_name":"appium/appium-xcuitest-driver","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-xcuitest-driver","description":"Appium iOS driver, backed by Apple XCUITest ","fork":false,"url":"https://api.github.com/repos/appium/appium-xcuitest-driver","forks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/deployments","created_at":"2015-12-08T22:11:37Z","updated_at":"2018-02-01T08:33:46Z","pushed_at":"2018-02-05T11:12:57Z","git_url":"git://github.com/appium/appium-xcuitest-driver.git","ssh_url":"git@github.com:appium/appium-xcuitest-driver.git","clone_url":"https://github.com/appium/appium-xcuitest-driver.git","svn_url":"https://github.com/appium/appium-xcuitest-driver","homepage":null,"size":25476,"stargazers_count":180,"watchers_count":180,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":128,"open_issues":6,"watchers":180,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"23c7b2f6efe4424633f3e7fa899d6b9969655325","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":47652761,"name":"appium-xcuitest-driver","full_name":"appium/appium-xcuitest-driver","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-xcuitest-driver","description":"Appium iOS driver, backed by Apple XCUITest ","fork":false,"url":"https://api.github.com/repos/appium/appium-xcuitest-driver","forks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/deployments","created_at":"2015-12-08T22:11:37Z","updated_at":"2018-02-01T08:33:46Z","pushed_at":"2018-02-05T11:12:57Z","git_url":"git://github.com/appium/appium-xcuitest-driver.git","ssh_url":"git@github.com:appium/appium-xcuitest-driver.git","clone_url":"https://github.com/appium/appium-xcuitest-driver.git","svn_url":"https://github.com/appium/appium-xcuitest-driver","homepage":null,"size":25476,"stargazers_count":180,"watchers_count":180,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":128,"open_issues":6,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620"},"html":{"href":"https://github.com/appium/appium-xcuitest-driver/pull/620"},"issue":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/620"},"comments":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/f6fcd938066ea7e0745f33cbe09c7c10a8309a83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mykola-mokhnach"}}