{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/6659","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6659/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6659/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6659/events","html_url":"https://github.com/WordPress/gutenberg/issues/6659","id":321553354,"number":6659,"title":"Is the Gutenberg plugin not deactivated on WordPress 5.0?","user":{"login":"SeanDS","id":5225190,"avatar_url":"https://avatars2.githubusercontent.com/u/5225190?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanDS","html_url":"https://github.com/SeanDS","followers_url":"https://api.github.com/users/SeanDS/followers","following_url":"https://api.github.com/users/SeanDS/following{/other_user}","gists_url":"https://api.github.com/users/SeanDS/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanDS/subscriptions","organizations_url":"https://api.github.com/users/SeanDS/orgs","repos_url":"https://api.github.com/users/SeanDS/repos","events_url":"https://api.github.com/users/SeanDS/events{/privacy}","received_events_url":"https://api.github.com/users/SeanDS/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-09T12:38:15Z","updated_at":"2018-05-10T18:58:08Z","closed_at":"2018-05-10T18:58:08Z","author_association":"NONE","body":"<!--\r\nBEFORE POSTING YOUR ISSUE:\r\n- These comments won't show up when you submit the issue.\r\n- Try to add as much detail as possible. Be specific!\r\n- Please add the version of Gutenberg you are using in the description.\r\n- If you're requesting a new feature, explain why you'd like it to be added.\r\n- Search this repository for issues and pull requests and whether it has been fixed or reported already.\r\n- Ensure you are using the latest code before logging bugs.\r\n- Disable all plugins to ensure it's not a plugin conflict issue.\r\n- To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.\r\n-->\r\n\r\n## Issue Overview\r\nScanning the `gutenberg_pre_init` function, the current WordPress version is [only checked to see if it is older than 4.9](https://github.com/WordPress/gutenberg/blob/16d6a0117171be37dc03ec2535cbbdccecbe29f7/gutenberg.php#L123), in which case the plugin deactivates due to incompatibility. Should there not also be a check for versions >= 5.0, since by that point Gutenberg will have been merged into WordPress Core? I can imagine lots of people will have installed an early version of the Gutenberg plugin which doesn't detect version 5.0, and won't have updated it by the time WordPress 5.0 is released, potentially creating a huge mess with two almost identical sets of code hooking into the same parts of the code trying to provide the same tools.\r\n\r\nApologies if this is something that the developers are already aware of, or is already covered somehow in the code. I thought I'd report it anyway just to be safe.\r\n\r\n## Steps to Reproduce (for bugs)\r\nI don't think this is causing problems yet, because (as far as I am aware) Gutenberg has not been merged into the WordPress 5.0 development branch yet.\r\n\r\n## Expected Behavior\r\n<!-- If you're describing a bug, tell us what should happen -->\r\n<!-- If you're suggesting a change/improvement, tell us how it should work -->\r\nGutenberg plugin will deactivate itself if it detects WordPress 5.0 is being run, since WordPress 5.0 will have had the plugin code merged into the core and so this plugin will no longer be necessary.\r\n\r\n## Current Behavior\r\nThis will probably not be a problem until Gutenberg is merged into WordPress 5.0, but it's worth getting the check in early so that most users who have the plugin installed won't have any problems later.\r\n\r\n## Possible Solution\r\nCheck not only for versions < 4.9, but also for version >= 5.0, and if true, deactivate the plugin. It might also be useful to check for the presence of some flag to determine if someone is testing this plugin against the current 5.0 branch **without** the Gutenberg code merged in."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/388151558","html_url":"https://github.com/WordPress/gutenberg/issues/6659#issuecomment-388151558","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6659","id":388151558,"user":{"login":"karmatosed","id":253067,"avatar_url":"https://avatars3.githubusercontent.com/u/253067?v=4","gravatar_id":"","url":"https://api.github.com/users/karmatosed","html_url":"https://github.com/karmatosed","followers_url":"https://api.github.com/users/karmatosed/followers","following_url":"https://api.github.com/users/karmatosed/following{/other_user}","gists_url":"https://api.github.com/users/karmatosed/gists{/gist_id}","starred_url":"https://api.github.com/users/karmatosed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmatosed/subscriptions","organizations_url":"https://api.github.com/users/karmatosed/orgs","repos_url":"https://api.github.com/users/karmatosed/repos","events_url":"https://api.github.com/users/karmatosed/events{/privacy}","received_events_url":"https://api.github.com/users/karmatosed/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T18:58:08Z","updated_at":"2018-05-10T18:58:08Z","author_association":"MEMBER","body":"Hi @SeanDS what happens in 5.0 hasn't been decided, so thank you for suggesting here. As you say there are no issues right now because of the current way this is setup. That all said during the merge and path to 5.0 things will be worked out and discussed. It will absolutely have a lot of work done on not having clashes though.\r\n\r\nFor now, I am going to close this as it's not something we need to do and the path to 5.0 may take many different routes. Thanks for being observant and looking forward."}}
{"actor":{"display_login":"karmatosed"}}