{"action":"closed","number":224,"pull_request":{"url":"https://api.github.com/repos/mostjs/core/pulls/224","id":181274966,"html_url":"https://github.com/mostjs/core/pull/224","diff_url":"https://github.com/mostjs/core/pull/224.diff","patch_url":"https://github.com/mostjs/core/pull/224.patch","issue_url":"https://api.github.com/repos/mostjs/core/issues/224","number":224,"state":"closed","locked":false,"title":"Allow merge to produce union","user":{"login":"briancavalier","id":90518,"avatar_url":"https://avatars2.githubusercontent.com/u/90518?v=4","gravatar_id":"","url":"https://api.github.com/users/briancavalier","html_url":"https://github.com/briancavalier","followers_url":"https://api.github.com/users/briancavalier/followers","following_url":"https://api.github.com/users/briancavalier/following{/other_user}","gists_url":"https://api.github.com/users/briancavalier/gists{/gist_id}","starred_url":"https://api.github.com/users/briancavalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancavalier/subscriptions","organizations_url":"https://api.github.com/users/briancavalier/orgs","repos_url":"https://api.github.com/users/briancavalier/repos","events_url":"https://api.github.com/users/briancavalier/events{/privacy}","received_events_url":"https://api.github.com/users/briancavalier/received_events","type":"User","site_admin":false},"body":"As per recent discussion, this loosens the type of the 2-stream `merge` to accept streams of different types and produce a stream of the union.\r\n\r\nAt first, this might seem unsafe because you might accidentally call merge with different types, say `A` and `B` when you didn't mean to.  However, since the resulting stream has a union type, `A | B`, when you try to use it, for example by mapping it with a function `A => C`, the type checker will prevent it.  Thus, I believe this is entirely safe, while adding some flexibility for situations where you might actually want to construct a union. ","created_at":"2018-04-12T17:32:15Z","updated_at":"2018-05-10T21:34:13Z","closed_at":"2018-05-10T21:34:13Z","merged_at":"2018-05-10T21:34:13Z","merge_commit_sha":"c2548589dd00356a53a92cb55244f1e546713e8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":506095470,"url":"https://api.github.com/repos/mostjs/core/labels/:hammer_and_wrench:%20Type:%20Feature","name":":hammer_and_wrench: Type: Feature","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mostjs/core/pulls/224/commits","review_comments_url":"https://api.github.com/repos/mostjs/core/pulls/224/comments","review_comment_url":"https://api.github.com/repos/mostjs/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mostjs/core/issues/224/comments","statuses_url":"https://api.github.com/repos/mostjs/core/statuses/2b68746905633c7e128254890d8c238041a91a4e","head":{"label":"mostjs:allow-merge-union","ref":"allow-merge-union","sha":"2b68746905633c7e128254890d8c238041a91a4e","user":{"login":"mostjs","id":15834413,"avatar_url":"https://avatars0.githubusercontent.com/u/15834413?v=4","gravatar_id":"","url":"https://api.github.com/users/mostjs","html_url":"https://github.com/mostjs","followers_url":"https://api.github.com/users/mostjs/followers","following_url":"https://api.github.com/users/mostjs/following{/other_user}","gists_url":"https://api.github.com/users/mostjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mostjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mostjs/subscriptions","organizations_url":"https://api.github.com/users/mostjs/orgs","repos_url":"https://api.github.com/users/mostjs/repos","events_url":"https://api.github.com/users/mostjs/events{/privacy}","received_events_url":"https://api.github.com/users/mostjs/received_events","type":"Organization","site_admin":false},"repo":{"id":77230382,"name":"core","full_name":"mostjs/core","owner":{"login":"mostjs","id":15834413,"avatar_url":"https://avatars0.githubusercontent.com/u/15834413?v=4","gravatar_id":"","url":"https://api.github.com/users/mostjs","html_url":"https://github.com/mostjs","followers_url":"https://api.github.com/users/mostjs/followers","following_url":"https://api.github.com/users/mostjs/following{/other_user}","gists_url":"https://api.github.com/users/mostjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mostjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mostjs/subscriptions","organizations_url":"https://api.github.com/users/mostjs/orgs","repos_url":"https://api.github.com/users/mostjs/repos","events_url":"https://api.github.com/users/mostjs/events{/privacy}","received_events_url":"https://api.github.com/users/mostjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mostjs/core","description":"Most.js core event stream","fork":false,"url":"https://api.github.com/repos/mostjs/core","forks_url":"https://api.github.com/repos/mostjs/core/forks","keys_url":"https://api.github.com/repos/mostjs/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mostjs/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mostjs/core/teams","hooks_url":"https://api.github.com/repos/mostjs/core/hooks","issue_events_url":"https://api.github.com/repos/mostjs/core/issues/events{/number}","events_url":"https://api.github.com/repos/mostjs/core/events","assignees_url":"https://api.github.com/repos/mostjs/core/assignees{/user}","branches_url":"https://api.github.com/repos/mostjs/core/branches{/branch}","tags_url":"https://api.github.com/repos/mostjs/core/tags","blobs_url":"https://api.github.com/repos/mostjs/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mostjs/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mostjs/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mostjs/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mostjs/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mostjs/core/languages","stargazers_url":"https://api.github.com/repos/mostjs/core/stargazers","contributors_url":"https://api.github.com/repos/mostjs/core/contributors","subscribers_url":"https://api.github.com/repos/mostjs/core/subscribers","subscription_url":"https://api.github.com/repos/mostjs/core/subscription","commits_url":"https://api.github.com/repos/mostjs/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mostjs/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mostjs/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mostjs/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mostjs/core/contents/{+path}","compare_url":"https://api.github.com/repos/mostjs/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mostjs/core/merges","archive_url":"https://api.github.com/repos/mostjs/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mostjs/core/downloads","issues_url":"https://api.github.com/repos/mostjs/core/issues{/number}","pulls_url":"https://api.github.com/repos/mostjs/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mostjs/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mostjs/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mostjs/core/labels{/name}","releases_url":"https://api.github.com/repos/mostjs/core/releases{/id}","deployments_url":"https://api.github.com/repos/mostjs/core/deployments","created_at":"2016-12-23T14:27:44Z","updated_at":"2018-05-10T21:07:49Z","pushed_at":"2018-05-10T21:34:13Z","git_url":"git://github.com/mostjs/core.git","ssh_url":"git@github.com:mostjs/core.git","clone_url":"https://github.com/mostjs/core.git","svn_url":"https://github.com/mostjs/core","homepage":"http://mostcore.rtfd.io","size":1651,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":17,"watchers":99,"default_branch":"master"}},"base":{"label":"mostjs:master","ref":"master","sha":"08f2b48efa0ccce59e1997e1f2e5e3a8b56c14be","user":{"login":"mostjs","id":15834413,"avatar_url":"https://avatars0.githubusercontent.com/u/15834413?v=4","gravatar_id":"","url":"https://api.github.com/users/mostjs","html_url":"https://github.com/mostjs","followers_url":"https://api.github.com/users/mostjs/followers","following_url":"https://api.github.com/users/mostjs/following{/other_user}","gists_url":"https://api.github.com/users/mostjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mostjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mostjs/subscriptions","organizations_url":"https://api.github.com/users/mostjs/orgs","repos_url":"https://api.github.com/users/mostjs/repos","events_url":"https://api.github.com/users/mostjs/events{/privacy}","received_events_url":"https://api.github.com/users/mostjs/received_events","type":"Organization","site_admin":false},"repo":{"id":77230382,"name":"core","full_name":"mostjs/core","owner":{"login":"mostjs","id":15834413,"avatar_url":"https://avatars0.githubusercontent.com/u/15834413?v=4","gravatar_id":"","url":"https://api.github.com/users/mostjs","html_url":"https://github.com/mostjs","followers_url":"https://api.github.com/users/mostjs/followers","following_url":"https://api.github.com/users/mostjs/following{/other_user}","gists_url":"https://api.github.com/users/mostjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mostjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mostjs/subscriptions","organizations_url":"https://api.github.com/users/mostjs/orgs","repos_url":"https://api.github.com/users/mostjs/repos","events_url":"https://api.github.com/users/mostjs/events{/privacy}","received_events_url":"https://api.github.com/users/mostjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mostjs/core","description":"Most.js core event stream","fork":false,"url":"https://api.github.com/repos/mostjs/core","forks_url":"https://api.github.com/repos/mostjs/core/forks","keys_url":"https://api.github.com/repos/mostjs/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mostjs/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mostjs/core/teams","hooks_url":"https://api.github.com/repos/mostjs/core/hooks","issue_events_url":"https://api.github.com/repos/mostjs/core/issues/events{/number}","events_url":"https://api.github.com/repos/mostjs/core/events","assignees_url":"https://api.github.com/repos/mostjs/core/assignees{/user}","branches_url":"https://api.github.com/repos/mostjs/core/branches{/branch}","tags_url":"https://api.github.com/repos/mostjs/core/tags","blobs_url":"https://api.github.com/repos/mostjs/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mostjs/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mostjs/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mostjs/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mostjs/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mostjs/core/languages","stargazers_url":"https://api.github.com/repos/mostjs/core/stargazers","contributors_url":"https://api.github.com/repos/mostjs/core/contributors","subscribers_url":"https://api.github.com/repos/mostjs/core/subscribers","subscription_url":"https://api.github.com/repos/mostjs/core/subscription","commits_url":"https://api.github.com/repos/mostjs/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mostjs/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mostjs/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mostjs/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mostjs/core/contents/{+path}","compare_url":"https://api.github.com/repos/mostjs/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mostjs/core/merges","archive_url":"https://api.github.com/repos/mostjs/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mostjs/core/downloads","issues_url":"https://api.github.com/repos/mostjs/core/issues{/number}","pulls_url":"https://api.github.com/repos/mostjs/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mostjs/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mostjs/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mostjs/core/labels{/name}","releases_url":"https://api.github.com/repos/mostjs/core/releases{/id}","deployments_url":"https://api.github.com/repos/mostjs/core/deployments","created_at":"2016-12-23T14:27:44Z","updated_at":"2018-05-10T21:07:49Z","pushed_at":"2018-05-10T21:34:13Z","git_url":"git://github.com/mostjs/core.git","ssh_url":"git@github.com:mostjs/core.git","clone_url":"https://github.com/mostjs/core.git","svn_url":"https://github.com/mostjs/core","homepage":"http://mostcore.rtfd.io","size":1651,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":17,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mostjs/core/pulls/224"},"html":{"href":"https://github.com/mostjs/core/pull/224"},"issue":{"href":"https://api.github.com/repos/mostjs/core/issues/224"},"comments":{"href":"https://api.github.com/repos/mostjs/core/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/mostjs/core/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/mostjs/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mostjs/core/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/mostjs/core/statuses/2b68746905633c7e128254890d8c238041a91a4e"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"briancavalier","id":90518,"avatar_url":"https://avatars2.githubusercontent.com/u/90518?v=4","gravatar_id":"","url":"https://api.github.com/users/briancavalier","html_url":"https://github.com/briancavalier","followers_url":"https://api.github.com/users/briancavalier/followers","following_url":"https://api.github.com/users/briancavalier/following{/other_user}","gists_url":"https://api.github.com/users/briancavalier/gists{/gist_id}","starred_url":"https://api.github.com/users/briancavalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancavalier/subscriptions","organizations_url":"https://api.github.com/users/briancavalier/orgs","repos_url":"https://api.github.com/users/briancavalier/repos","events_url":"https://api.github.com/users/briancavalier/events{/privacy}","received_events_url":"https://api.github.com/users/briancavalier/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"briancavalier"}}