{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/18817","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/18817/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/18817/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/18817/events","html_url":"https://github.com/ampproject/amphtml/issues/18817","id":371684799,"node_id":"MDU6SXNzdWUzNzE2ODQ3OTk=","number":18817,"title":"hidden placeholder in `layout=container` takes unnecessary space.","user":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"labels":[{"id":530198214,"node_id":"MDU6TGFiZWw1MzAxOTgyMTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Presentation","name":"Category: Presentation","color":"1d76db","default":false},{"id":284525369,"node_id":"MDU6TGFiZWwyODQ1MjUzNjk=","url":"https://api.github.com/repos/ampproject/amphtml/labels/P1:%20High%20Priority","name":"P1: High Priority","color":"e99695","default":false},{"id":255304066,"node_id":"MDU6TGFiZWwyNTUzMDQwNjY=","url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Bug","name":"Type: Bug","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"assignees":[{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/75","html_url":"https://github.com/ampproject/amphtml/milestone/75","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/75/labels","id":3743970,"node_id":"MDk6TWlsZXN0b25lMzc0Mzk3MA==","number":75,"title":"Sprint H2 October 2018","description":null,"creator":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2018-10-16T18:20:14Z","updated_at":"2018-10-18T20:22:30Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-10-18T19:50:01Z","updated_at":"2018-10-18T21:42:39Z","closed_at":null,"author_association":"MEMBER","body":"This bugs happens when a component with `layout=container` has a `placeholder`.\r\nFor instance `amp-mathml` or when `amp-list` resizes to container via `auto-resize` attribute.\r\n\r\nSample repro with `amp-list auto-resize`:  https://codepen.io/aghassemi/pen/ePrYwW?editors=1000\r\nSample repro `with amp-mathml`: https://codepen.io/aghassemi/pen/bmMGzG \r\n\r\nIssue is:\r\n- `placeholder` is only make position absolute when `i-amphtml-layout-size-defined`. This makes sense initially since `placeholder` needs to expand the `container` when `layout=container`\r\n- we hide placeholders using `visibility:hidden`, this only makes sense if `i-amphtml-layout-size-defined`. For `layout=container`, hiding the placeholder with `visibility` will keep the space there causing this bug.\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/431174121","html_url":"https://github.com/ampproject/amphtml/issues/18817#issuecomment-431174121","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/18817","id":431174121,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTE3NDEyMQ==","user":{"login":"jaygray0919","id":11330577,"node_id":"MDQ6VXNlcjExMzMwNTc3","avatar_url":"https://avatars2.githubusercontent.com/u/11330577?v=4","gravatar_id":"","url":"https://api.github.com/users/jaygray0919","html_url":"https://github.com/jaygray0919","followers_url":"https://api.github.com/users/jaygray0919/followers","following_url":"https://api.github.com/users/jaygray0919/following{/other_user}","gists_url":"https://api.github.com/users/jaygray0919/gists{/gist_id}","starred_url":"https://api.github.com/users/jaygray0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaygray0919/subscriptions","organizations_url":"https://api.github.com/users/jaygray0919/orgs","repos_url":"https://api.github.com/users/jaygray0919/repos","events_url":"https://api.github.com/users/jaygray0919/events{/privacy}","received_events_url":"https://api.github.com/users/jaygray0919/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T21:42:39Z","updated_at":"2018-10-18T21:42:39Z","author_association":"NONE","body":"There is a similar problem with `amp-list`.\r\n\r\nWhen using `amp-mustache` with `amp-list`, a `{{term}}` in `<span>` forces a line-break. Have tried various CSS methods to `keep-together` but all fail. The consequence is that we cannot create a `<p>` using multiple `<span>` for different URLs loaded from `amp-list`.\r\n\r\nHave shared examples with @choumx.\r\n\r\nOur request is that `amp-list` generate an inline `span block` rather than a `div block` which forces the new-line-break.\r\n"}}
{"actor":{"display_login":"jaygray0919"}}