{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/236168061","pull_request_review_id":178185008,"id":236168061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjE2ODA2MQ==","diff_hunk":"@@ -39,7 +39,7 @@ func makeKubeConfig(clientKey *rsa.PrivateKey, clientCert, caCert *x509.Certific\n \t\t\t{\n \t\t\t\tName: clustername,\n \t\t\t\tCluster: v1.Cluster{\n-\t\t\t\t\tServer: \"https://\" + endpoint,\n+\t\t\t\t\tServer:                   \"https://\" + endpoint,","path":"pkg/config/util.go","position":20,"original_position":20,"commit_id":"7686d5a51ba3a1a8b949e4ffb5ffd06e47c3032b","original_commit_id":"7686d5a51ba3a1a8b949e4ffb5ffd06e47c3032b","user":{"login":"mjudeikis","id":3225744,"node_id":"MDQ6VXNlcjMyMjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"body":"?","created_at":"2018-11-26T09:05:13Z","updated_at":"2018-11-26T09:05:13Z","html_url":"https://github.com/openshift/openshift-azure/pull/780#discussion_r236168061","pull_request_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/780","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/236168061"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/780#discussion_r236168061"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/780","id":233293093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjkzMDkz","html_url":"https://github.com/openshift/openshift-azure/pull/780","diff_url":"https://github.com/openshift/openshift-azure/pull/780.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/780.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/780","number":780,"state":"open","locked":false,"title":"[WIP] e2e test refactor take 2","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"Building on @charlesakalugwu 's work in #762.\r\n\r\n* merge test/e2erp into test/e2e\r\n* move tests into 1 suite and 3 packages for now:\r\n  - test/e2e/specs (general sanity checking)\r\n  - test/e2e/specs/fakerp (stuff which needs system:admin and hence can't yet work in prod)\r\n  - test/e2e/specs/realrp (stuff which needs prod RP RBAC and hence can't work with the plugin)\r\n* add login functionality to remove KUBECONFIG and oc login hacks in e2e.sh (see test/clients/openshift/login.go)\r\n* put all standard `func() (bool, error)` functions used for readiness checking into single package pkg/util/ready (TODO: more test cases)\r\n* remove random name generator copy/pasted from k8s and generalise config code to pkg/util/randomstring\r\n* grudgingly add an official combined azure test client and combined openshift test client (test/clients/{azure,openshift}) with as few helper functions as I think I can get away with\r\n* quite a lot of test clean-up and simplification\r\n\r\n@charlesakalugwu @kargakis @mjudeikis @asalkeld ptal.","created_at":"2018-11-24T00:46:55Z","updated_at":"2018-11-26T09:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e04ceacaf45e76b6f86973c3aa76cc8cbdd68d78","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},{"login":"charlesakalugwu","id":5978370,"node_id":"MDQ6VXNlcjU5NzgzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5978370?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesakalugwu","html_url":"https://github.com/charlesakalugwu","followers_url":"https://api.github.com/users/charlesakalugwu/followers","following_url":"https://api.github.com/users/charlesakalugwu/following{/other_user}","gists_url":"https://api.github.com/users/charlesakalugwu/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesakalugwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesakalugwu/subscriptions","organizations_url":"https://api.github.com/users/charlesakalugwu/orgs","repos_url":"https://api.github.com/users/charlesakalugwu/repos","events_url":"https://api.github.com/users/charlesakalugwu/events{/privacy}","received_events_url":"https://api.github.com/users/charlesakalugwu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":984232984,"node_id":"MDU6TGFiZWw5ODQyMzI5ODQ=","url":"https://api.github.com/repos/openshift/openshift-azure/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":1006543190,"node_id":"MDU6TGFiZWwxMDA2NTQzMTkw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/780/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/780/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/780/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/7686d5a51ba3a1a8b949e4ffb5ffd06e47c3032b","head":{"label":"jim-minter:testrefactor","ref":"testrefactor","sha":"7686d5a51ba3a1a8b949e4ffb5ffd06e47c3032b","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":142488214,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODgyMTQ=","name":"openshift-azure","full_name":"jim-minter/openshift-azure","private":false,"owner":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jim-minter/openshift-azure","description":null,"fork":true,"url":"https://api.github.com/repos/jim-minter/openshift-azure","forks_url":"https://api.github.com/repos/jim-minter/openshift-azure/forks","keys_url":"https://api.github.com/repos/jim-minter/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/openshift-azure/teams","hooks_url":"https://api.github.com/repos/jim-minter/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/openshift-azure/events","assignees_url":"https://api.github.com/repos/jim-minter/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/tags","blobs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/jim-minter/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscription","commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/openshift-azure/merges","archive_url":"https://api.github.com/repos/jim-minter/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/openshift-azure/downloads","issues_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/openshift-azure/deployments","created_at":"2018-07-26T19:59:36Z","updated_at":"2018-11-23T14:17:13Z","pushed_at":"2018-11-24T00:38:37Z","git_url":"git://github.com/jim-minter/openshift-azure.git","ssh_url":"git@github.com:jim-minter/openshift-azure.git","clone_url":"https://github.com/jim-minter/openshift-azure.git","svn_url":"https://github.com/jim-minter/openshift-azure","homepage":null,"size":38062,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c53a305b06f33be7b9ed7b08bb94574a90a196dd","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-11-26T08:38:43Z","pushed_at":"2018-11-26T08:38:39Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":37888,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":70,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/780"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/780"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/780"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/7686d5a51ba3a1a8b949e4ffb5ffd06e47c3032b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjudeikis"}}