{"action":"created","comment":{"url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/comments/205303913","pull_request_review_id":140548419,"id":205303913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTMwMzkxMw==","diff_hunk":"@@ -2,26 +2,31 @@\n from numba import jit, njit","path":"quantecon/optimize/root_finding.py","position":1,"original_position":1,"commit_id":"1b179405245bc7d7d6157528bd64e2b399491090","original_commit_id":"1b179405245bc7d7d6157528bd64e2b399491090","user":{"login":"oyamad","id":7353083,"node_id":"MDQ6VXNlcjczNTMwODM=","avatar_url":"https://avatars2.githubusercontent.com/u/7353083?v=4","gravatar_id":"","url":"https://api.github.com/users/oyamad","html_url":"https://github.com/oyamad","followers_url":"https://api.github.com/users/oyamad/followers","following_url":"https://api.github.com/users/oyamad/following{/other_user}","gists_url":"https://api.github.com/users/oyamad/gists{/gist_id}","starred_url":"https://api.github.com/users/oyamad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyamad/subscriptions","organizations_url":"https://api.github.com/users/oyamad/orgs","repos_url":"https://api.github.com/users/oyamad/repos","events_url":"https://api.github.com/users/oyamad/events{/privacy}","received_events_url":"https://api.github.com/users/oyamad/received_events","type":"User","site_admin":false},"body":"`jit` seems not to be used in this file.","created_at":"2018-07-26T00:53:57Z","updated_at":"2018-07-26T00:56:41Z","html_url":"https://github.com/QuantEcon/QuantEcon.py/pull/424#discussion_r205303913","pull_request_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/comments/205303913"},"html":{"href":"https://github.com/QuantEcon/QuantEcon.py/pull/424#discussion_r205303913"},"pull_request":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424","id":203720182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzIwMTgy","html_url":"https://github.com/QuantEcon/QuantEcon.py/pull/424","diff_url":"https://github.com/QuantEcon/QuantEcon.py/pull/424.diff","patch_url":"https://github.com/QuantEcon/QuantEcon.py/pull/424.patch","issue_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/424","number":424,"state":"open","locked":false,"title":"Add bisection and brent's method for root finding","user":{"login":"spvdchachan","id":29576539,"node_id":"MDQ6VXNlcjI5NTc2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/29576539?v=4","gravatar_id":"","url":"https://api.github.com/users/spvdchachan","html_url":"https://github.com/spvdchachan","followers_url":"https://api.github.com/users/spvdchachan/followers","following_url":"https://api.github.com/users/spvdchachan/following{/other_user}","gists_url":"https://api.github.com/users/spvdchachan/gists{/gist_id}","starred_url":"https://api.github.com/users/spvdchachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spvdchachan/subscriptions","organizations_url":"https://api.github.com/users/spvdchachan/orgs","repos_url":"https://api.github.com/users/spvdchachan/repos","events_url":"https://api.github.com/users/spvdchachan/events{/privacy}","received_events_url":"https://api.github.com/users/spvdchachan/received_events","type":"User","site_admin":false},"body":"Hi @jstac and @mmcky \r\n\r\nI would like to resolve #422 in this PR.\r\n\r\nI've added two new robust root finding methods `bisect` and `brentq` which are based on Scipy's version.\r\nThese procedures were written in C originally and I rewrote them in Python to jit compile.","created_at":"2018-07-25T04:46:19Z","updated_at":"2018-07-26T00:56:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e740f8dd70823b8183d5fce7c57c4768b81f920e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":32902413,"node_id":"MDU6TGFiZWwzMjkwMjQxMw==","url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":660875746,"node_id":"MDU6TGFiZWw2NjA4NzU3NDY=","url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/labels/ready","name":"ready","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424/commits","review_comments_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424/comments","review_comment_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/424/comments","statuses_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/statuses/1b179405245bc7d7d6157528bd64e2b399491090","head":{"label":"spvdchachan:robust-root-finding","ref":"robust-root-finding","sha":"1b179405245bc7d7d6157528bd64e2b399491090","user":{"login":"spvdchachan","id":29576539,"node_id":"MDQ6VXNlcjI5NTc2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/29576539?v=4","gravatar_id":"","url":"https://api.github.com/users/spvdchachan","html_url":"https://github.com/spvdchachan","followers_url":"https://api.github.com/users/spvdchachan/followers","following_url":"https://api.github.com/users/spvdchachan/following{/other_user}","gists_url":"https://api.github.com/users/spvdchachan/gists{/gist_id}","starred_url":"https://api.github.com/users/spvdchachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spvdchachan/subscriptions","organizations_url":"https://api.github.com/users/spvdchachan/orgs","repos_url":"https://api.github.com/users/spvdchachan/repos","events_url":"https://api.github.com/users/spvdchachan/events{/privacy}","received_events_url":"https://api.github.com/users/spvdchachan/received_events","type":"User","site_admin":false},"repo":{"id":142243338,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyNDMzMzg=","name":"QuantEcon.py","full_name":"spvdchachan/QuantEcon.py","owner":{"login":"spvdchachan","id":29576539,"node_id":"MDQ6VXNlcjI5NTc2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/29576539?v=4","gravatar_id":"","url":"https://api.github.com/users/spvdchachan","html_url":"https://github.com/spvdchachan","followers_url":"https://api.github.com/users/spvdchachan/followers","following_url":"https://api.github.com/users/spvdchachan/following{/other_user}","gists_url":"https://api.github.com/users/spvdchachan/gists{/gist_id}","starred_url":"https://api.github.com/users/spvdchachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spvdchachan/subscriptions","organizations_url":"https://api.github.com/users/spvdchachan/orgs","repos_url":"https://api.github.com/users/spvdchachan/repos","events_url":"https://api.github.com/users/spvdchachan/events{/privacy}","received_events_url":"https://api.github.com/users/spvdchachan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spvdchachan/QuantEcon.py","description":"A community based Python library for quantitative economics","fork":true,"url":"https://api.github.com/repos/spvdchachan/QuantEcon.py","forks_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/forks","keys_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/teams","hooks_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/hooks","issue_events_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/issues/events{/number}","events_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/events","assignees_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/assignees{/user}","branches_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/branches{/branch}","tags_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/tags","blobs_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/statuses/{sha}","languages_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/languages","stargazers_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/stargazers","contributors_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/contributors","subscribers_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/subscribers","subscription_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/subscription","commits_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/contents/{+path}","compare_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/merges","archive_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/downloads","issues_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/issues{/number}","pulls_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/pulls{/number}","milestones_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/milestones{/number}","notifications_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/labels{/name}","releases_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/releases{/id}","deployments_url":"https://api.github.com/repos/spvdchachan/QuantEcon.py/deployments","created_at":"2018-07-25T03:36:57Z","updated_at":"2018-07-25T03:36:59Z","pushed_at":"2018-07-25T05:47:23Z","git_url":"git://github.com/spvdchachan/QuantEcon.py.git","ssh_url":"git@github.com:spvdchachan/QuantEcon.py.git","clone_url":"https://github.com/spvdchachan/QuantEcon.py.git","svn_url":"https://github.com/spvdchachan/QuantEcon.py","homepage":"http://quantecon.org/python_index.html","size":18497,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QuantEcon:master","ref":"master","sha":"1155267e3529bc7062d0f088b7011bfbe47ad153","user":{"login":"QuantEcon","id":8703060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDMwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8703060?v=4","gravatar_id":"","url":"https://api.github.com/users/QuantEcon","html_url":"https://github.com/QuantEcon","followers_url":"https://api.github.com/users/QuantEcon/followers","following_url":"https://api.github.com/users/QuantEcon/following{/other_user}","gists_url":"https://api.github.com/users/QuantEcon/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantEcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantEcon/subscriptions","organizations_url":"https://api.github.com/users/QuantEcon/orgs","repos_url":"https://api.github.com/users/QuantEcon/repos","events_url":"https://api.github.com/users/QuantEcon/events{/privacy}","received_events_url":"https://api.github.com/users/QuantEcon/received_events","type":"Organization","site_admin":false},"repo":{"id":8941695,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQxNjk1","name":"QuantEcon.py","full_name":"QuantEcon/QuantEcon.py","owner":{"login":"QuantEcon","id":8703060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDMwNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8703060?v=4","gravatar_id":"","url":"https://api.github.com/users/QuantEcon","html_url":"https://github.com/QuantEcon","followers_url":"https://api.github.com/users/QuantEcon/followers","following_url":"https://api.github.com/users/QuantEcon/following{/other_user}","gists_url":"https://api.github.com/users/QuantEcon/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantEcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantEcon/subscriptions","organizations_url":"https://api.github.com/users/QuantEcon/orgs","repos_url":"https://api.github.com/users/QuantEcon/repos","events_url":"https://api.github.com/users/QuantEcon/events{/privacy}","received_events_url":"https://api.github.com/users/QuantEcon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuantEcon/QuantEcon.py","description":"A community based Python library for quantitative economics","fork":false,"url":"https://api.github.com/repos/QuantEcon/QuantEcon.py","forks_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/forks","keys_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/teams","hooks_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/hooks","issue_events_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/events{/number}","events_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/events","assignees_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/assignees{/user}","branches_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/branches{/branch}","tags_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/tags","blobs_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/statuses/{sha}","languages_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/languages","stargazers_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/stargazers","contributors_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/contributors","subscribers_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/subscribers","subscription_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/subscription","commits_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/contents/{+path}","compare_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/merges","archive_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/downloads","issues_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues{/number}","pulls_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls{/number}","milestones_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/milestones{/number}","notifications_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/labels{/name}","releases_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/releases{/id}","deployments_url":"https://api.github.com/repos/QuantEcon/QuantEcon.py/deployments","created_at":"2013-03-22T00:27:36Z","updated_at":"2018-07-25T16:03:28Z","pushed_at":"2018-07-25T05:47:24Z","git_url":"git://github.com/QuantEcon/QuantEcon.py.git","ssh_url":"git@github.com:QuantEcon/QuantEcon.py.git","clone_url":"https://github.com/QuantEcon/QuantEcon.py.git","svn_url":"https://github.com/QuantEcon/QuantEcon.py","homepage":"http://quantecon.org/python_index.html","size":18493,"stargazers_count":654,"watchers_count":654,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":844,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":844,"open_issues":68,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424"},"html":{"href":"https://github.com/QuantEcon/QuantEcon.py/pull/424"},"issue":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/424"},"comments":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/QuantEcon/QuantEcon.py/statuses/1b179405245bc7d7d6157528bd64e2b399491090"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oyamad"}}