{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/28862","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/28862/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/28862/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/28862/events","html_url":"https://github.com/dotnet/corefx/pull/28862","id":311717326,"number":28862,"title":"[WIP] *NO MERGE* Mitigate the known case of missing SSL error clean up","user":{"login":"pjanotti","id":5600755,"avatar_url":"https://avatars3.githubusercontent.com/u/5600755?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanotti","html_url":"https://github.com/pjanotti","followers_url":"https://api.github.com/users/pjanotti/followers","following_url":"https://api.github.com/users/pjanotti/following{/other_user}","gists_url":"https://api.github.com/users/pjanotti/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanotti/subscriptions","organizations_url":"https://api.github.com/users/pjanotti/orgs","repos_url":"https://api.github.com/users/pjanotti/repos","events_url":"https://api.github.com/users/pjanotti/events{/privacy}","received_events_url":"https://api.github.com/users/pjanotti/received_events","type":"User","site_admin":false},"labels":[{"id":284076100,"url":"https://api.github.com/repos/dotnet/corefx/labels/*%20NO%20MERGE%20*","name":"* NO MERGE *","color":"e11d21","default":false},{"id":163633782,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Security","name":"area-System.Security","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"pjanotti","id":5600755,"avatar_url":"https://avatars3.githubusercontent.com/u/5600755?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanotti","html_url":"https://github.com/pjanotti","followers_url":"https://api.github.com/users/pjanotti/followers","following_url":"https://api.github.com/users/pjanotti/following{/other_user}","gists_url":"https://api.github.com/users/pjanotti/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanotti/subscriptions","organizations_url":"https://api.github.com/users/pjanotti/orgs","repos_url":"https://api.github.com/users/pjanotti/repos","events_url":"https://api.github.com/users/pjanotti/events{/privacy}","received_events_url":"https://api.github.com/users/pjanotti/received_events","type":"User","site_admin":false},"assignees":[{"login":"pjanotti","id":5600755,"avatar_url":"https://avatars3.githubusercontent.com/u/5600755?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanotti","html_url":"https://github.com/pjanotti","followers_url":"https://api.github.com/users/pjanotti/followers","following_url":"https://api.github.com/users/pjanotti/following{/other_user}","gists_url":"https://api.github.com/users/pjanotti/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanotti/subscriptions","organizations_url":"https://api.github.com/users/pjanotti/orgs","repos_url":"https://api.github.com/users/pjanotti/repos","events_url":"https://api.github.com/users/pjanotti/events{/privacy}","received_events_url":"https://api.github.com/users/pjanotti/received_events","type":"User","site_admin":false}],"milestone":null,"comments":32,"created_at":"2018-04-05T18:19:04Z","updated_at":"2018-04-13T14:34:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/28862","html_url":"https://github.com/dotnet/corefx/pull/28862","diff_url":"https://github.com/dotnet/corefx/pull/28862.diff","patch_url":"https://github.com/dotnet/corefx/pull/28862.patch"},"body":"[EDIT to reflect current content of PR]\r\n\r\n*NO MERGE* I will be using this PR to run CI but will separate the product changes on their own PR.\r\n\r\nThis PR covers the following:\r\n\r\n1. Fixes locations that were leaving errors on the SSL error queue:\r\n  1.1. Calls to SslShutdown in [src/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs](https://github.com/dotnet/corefx/pull/28862/files#diff-f0513c093f14a9bf143efbacf9e57c47)\r\n  1.2. Calls to X509StoreAddCrl in [src/System.Security.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.Unix/CrlCache.cs](https://github.com/dotnet/corefx/pull/28862/files#diff-b5488457ea972ce8d66f60d2e319d9b9)\r\n  1.3. Calls to MultiDestroy and MultiRemoveHandle for CurlHandler were calling SSL_shutdown, cleaned up the SSL error queue after those calls\r\n2. Separate the tests of PlatformHandler and SocketsHttpHandler because there is some indication that the former can leave errors in the SSL error queue, this is also in line with what our customers will be using (either PlatformHandler or SocketsHttpHandler, not both on the same process). There is no actual change to test sources.\r\n3. Add custom build variable to help find other issues in which the SSL error queue is not being cleared. This is to be used locally at this point.\r\n\r\nSome follow-up still required that are not part of this review yet:\r\n* Add a config setting to turn the optimization on/off\r\n* Keep investigating the possible workarounds (e.g.: [interpret error](https://github.com/dotnet/corefx/pull/28862/commits/f565614ce0d9f3cb76b99d2d64b5211ce8063585#diff-8e59f86b12ee01ddf687a1e3c5c34dbdR248))\r\n\r\nFixes #25676"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/381154877","html_url":"https://github.com/dotnet/corefx/pull/28862#issuecomment-381154877","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/28862","id":381154877,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T14:34:15Z","updated_at":"2018-04-13T14:34:15Z","author_association":"MEMBER","body":"Digging more is good, but I'm not clear on why this PR is useful for that."}}
{"actor":{"display_login":"stephentoub"}}