{"action":"created","comment":{"url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments/215695128","pull_request_review_id":153017899,"id":215695128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTY5NTEyOA==","diff_hunk":"@@ -48,10 +47,28 @@ export class ViewpointsService {\n \t */\n \tpublic reset() {\n \t\tthis.state = {\n-\t\t\tviewpoints : []\n+\t\t\tviewpoints: []\n \t\t};\n \t}\n \n+\t// Helper  for searching strings\n+\tpublic stringSearch(superString, subString) {\n+\t\tif (!superString) {\n+\t\t\treturn false;\n+\t\t}\n+\n+\t\treturn (superString.toLowerCase().indexOf(subString.toLowerCase()) !== -1);\n+\t}\n+\n+\tpublic filterViewpoints(searchQuery: string): any[] {\n+\n+\t\tconst viewpointSearchResults = this.state.viewpoints.filter((view) => {","path":"frontend/components/viewpoints/js/viewpoints.service.ts","position":28,"original_position":28,"commit_id":"601127b0fb7798cfde9cf74ad864116f6a44044d","original_commit_id":"601127b0fb7798cfde9cf74ad864116f6a44044d","user":{"login":"carmenfan","id":11945337,"node_id":"MDQ6VXNlcjExOTQ1MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11945337?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenfan","html_url":"https://github.com/carmenfan","followers_url":"https://api.github.com/users/carmenfan/followers","following_url":"https://api.github.com/users/carmenfan/following{/other_user}","gists_url":"https://api.github.com/users/carmenfan/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenfan/subscriptions","organizations_url":"https://api.github.com/users/carmenfan/orgs","repos_url":"https://api.github.com/users/carmenfan/repos","events_url":"https://api.github.com/users/carmenfan/events{/privacy}","received_events_url":"https://api.github.com/users/carmenfan/received_events","type":"User","site_admin":false},"body":"again with the variable thing","created_at":"2018-09-06T16:35:37Z","updated_at":"2018-09-06T16:36:09Z","html_url":"https://github.com/3drepo/3drepo.io/pull/1133#discussion_r215695128","pull_request_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments/215695128"},"html":{"href":"https://github.com/3drepo/3drepo.io/pull/1133#discussion_r215695128"},"pull_request":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133"}}},"pull_request":{"url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133","id":213571822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTcxODIy","html_url":"https://github.com/3drepo/3drepo.io/pull/1133","diff_url":"https://github.com/3drepo/3drepo.io/pull/1133.diff","patch_url":"https://github.com/3drepo/3drepo.io/pull/1133.patch","issue_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1133","number":1133,"state":"open","locked":false,"title":"Issue 1124 - Filter on groups and views","user":{"login":"niblux","id":6556019,"node_id":"MDQ6VXNlcjY1NTYwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6556019?v=4","gravatar_id":"","url":"https://api.github.com/users/niblux","html_url":"https://github.com/niblux","followers_url":"https://api.github.com/users/niblux/followers","following_url":"https://api.github.com/users/niblux/following{/other_user}","gists_url":"https://api.github.com/users/niblux/gists{/gist_id}","starred_url":"https://api.github.com/users/niblux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niblux/subscriptions","organizations_url":"https://api.github.com/users/niblux/orgs","repos_url":"https://api.github.com/users/niblux/repos","events_url":"https://api.github.com/users/niblux/events{/privacy}","received_events_url":"https://api.github.com/users/niblux/received_events","type":"User","site_admin":false},"body":"This fixes #1124 \r\n\r\n#### Description\r\n- Add a search filter to the groups panel, to allow groups to be filtered by \"Name\" and \"Description\".\r\n- Add a search filter to the views panel, to allow views to be filtered by \"Name\".\r\n\r\n\r\n#### Test cases\r\n<!-- Test cases that this pull request expect to pass -->\r\n- Except lowercase and uppercase input for the search query.\r\n- Display the original list of items ie: views or groups after clearing filter field\r\n- OR By clicking the 'x' icon to clear the text and revert back to the original display.\r\n","created_at":"2018-09-06T10:37:57Z","updated_at":"2018-09-06T16:36:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcaa8b46e18a83a42e07f323eadc8bc9f9da8cd1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133/commits","review_comments_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133/comments","review_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1133/comments","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/601127b0fb7798cfde9cf74ad864116f6a44044d","head":{"label":"3drepo:ISSUE_1124","ref":"ISSUE_1124","sha":"601127b0fb7798cfde9cf74ad864116f6a44044d","user":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"repo":{"id":23537557,"node_id":"MDEwOlJlcG9zaXRvcnkyMzUzNzU1Nw==","name":"3drepo.io","full_name":"3drepo/3drepo.io","owner":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3drepo/3drepo.io","description":"3D Repo web server","fork":false,"url":"https://api.github.com/repos/3drepo/3drepo.io","forks_url":"https://api.github.com/repos/3drepo/3drepo.io/forks","keys_url":"https://api.github.com/repos/3drepo/3drepo.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3drepo/3drepo.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3drepo/3drepo.io/teams","hooks_url":"https://api.github.com/repos/3drepo/3drepo.io/hooks","issue_events_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/events{/number}","events_url":"https://api.github.com/repos/3drepo/3drepo.io/events","assignees_url":"https://api.github.com/repos/3drepo/3drepo.io/assignees{/user}","branches_url":"https://api.github.com/repos/3drepo/3drepo.io/branches{/branch}","tags_url":"https://api.github.com/repos/3drepo/3drepo.io/tags","blobs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3drepo/3drepo.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/3drepo/3drepo.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/{sha}","languages_url":"https://api.github.com/repos/3drepo/3drepo.io/languages","stargazers_url":"https://api.github.com/repos/3drepo/3drepo.io/stargazers","contributors_url":"https://api.github.com/repos/3drepo/3drepo.io/contributors","subscribers_url":"https://api.github.com/repos/3drepo/3drepo.io/subscribers","subscription_url":"https://api.github.com/repos/3drepo/3drepo.io/subscription","commits_url":"https://api.github.com/repos/3drepo/3drepo.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/3drepo/3drepo.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/3drepo/3drepo.io/contents/{+path}","compare_url":"https://api.github.com/repos/3drepo/3drepo.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3drepo/3drepo.io/merges","archive_url":"https://api.github.com/repos/3drepo/3drepo.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3drepo/3drepo.io/downloads","issues_url":"https://api.github.com/repos/3drepo/3drepo.io/issues{/number}","pulls_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls{/number}","milestones_url":"https://api.github.com/repos/3drepo/3drepo.io/milestones{/number}","notifications_url":"https://api.github.com/repos/3drepo/3drepo.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3drepo/3drepo.io/labels{/name}","releases_url":"https://api.github.com/repos/3drepo/3drepo.io/releases{/id}","deployments_url":"https://api.github.com/repos/3drepo/3drepo.io/deployments","created_at":"2014-09-01T09:31:56Z","updated_at":"2018-08-31T14:54:59Z","pushed_at":"2018-09-06T14:45:49Z","git_url":"git://github.com/3drepo/3drepo.io.git","ssh_url":"git@github.com:3drepo/3drepo.io.git","clone_url":"https://github.com/3drepo/3drepo.io.git","svn_url":"https://github.com/3drepo/3drepo.io","homepage":"http://www.3drepo.io","size":598666,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":30,"open_issues":82,"watchers":56,"default_branch":"master"}},"base":{"label":"3drepo:staging","ref":"staging","sha":"25ac43bf44150379896efd9c7d38d58694b9bf73","user":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"repo":{"id":23537557,"node_id":"MDEwOlJlcG9zaXRvcnkyMzUzNzU1Nw==","name":"3drepo.io","full_name":"3drepo/3drepo.io","owner":{"login":"3drepo","id":6910070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTAwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6910070?v=4","gravatar_id":"","url":"https://api.github.com/users/3drepo","html_url":"https://github.com/3drepo","followers_url":"https://api.github.com/users/3drepo/followers","following_url":"https://api.github.com/users/3drepo/following{/other_user}","gists_url":"https://api.github.com/users/3drepo/gists{/gist_id}","starred_url":"https://api.github.com/users/3drepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3drepo/subscriptions","organizations_url":"https://api.github.com/users/3drepo/orgs","repos_url":"https://api.github.com/users/3drepo/repos","events_url":"https://api.github.com/users/3drepo/events{/privacy}","received_events_url":"https://api.github.com/users/3drepo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3drepo/3drepo.io","description":"3D Repo web server","fork":false,"url":"https://api.github.com/repos/3drepo/3drepo.io","forks_url":"https://api.github.com/repos/3drepo/3drepo.io/forks","keys_url":"https://api.github.com/repos/3drepo/3drepo.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3drepo/3drepo.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3drepo/3drepo.io/teams","hooks_url":"https://api.github.com/repos/3drepo/3drepo.io/hooks","issue_events_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/events{/number}","events_url":"https://api.github.com/repos/3drepo/3drepo.io/events","assignees_url":"https://api.github.com/repos/3drepo/3drepo.io/assignees{/user}","branches_url":"https://api.github.com/repos/3drepo/3drepo.io/branches{/branch}","tags_url":"https://api.github.com/repos/3drepo/3drepo.io/tags","blobs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3drepo/3drepo.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3drepo/3drepo.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/3drepo/3drepo.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3drepo/3drepo.io/statuses/{sha}","languages_url":"https://api.github.com/repos/3drepo/3drepo.io/languages","stargazers_url":"https://api.github.com/repos/3drepo/3drepo.io/stargazers","contributors_url":"https://api.github.com/repos/3drepo/3drepo.io/contributors","subscribers_url":"https://api.github.com/repos/3drepo/3drepo.io/subscribers","subscription_url":"https://api.github.com/repos/3drepo/3drepo.io/subscription","commits_url":"https://api.github.com/repos/3drepo/3drepo.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/3drepo/3drepo.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/3drepo/3drepo.io/contents/{+path}","compare_url":"https://api.github.com/repos/3drepo/3drepo.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3drepo/3drepo.io/merges","archive_url":"https://api.github.com/repos/3drepo/3drepo.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3drepo/3drepo.io/downloads","issues_url":"https://api.github.com/repos/3drepo/3drepo.io/issues{/number}","pulls_url":"https://api.github.com/repos/3drepo/3drepo.io/pulls{/number}","milestones_url":"https://api.github.com/repos/3drepo/3drepo.io/milestones{/number}","notifications_url":"https://api.github.com/repos/3drepo/3drepo.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3drepo/3drepo.io/labels{/name}","releases_url":"https://api.github.com/repos/3drepo/3drepo.io/releases{/id}","deployments_url":"https://api.github.com/repos/3drepo/3drepo.io/deployments","created_at":"2014-09-01T09:31:56Z","updated_at":"2018-08-31T14:54:59Z","pushed_at":"2018-09-06T14:45:49Z","git_url":"git://github.com/3drepo/3drepo.io.git","ssh_url":"git@github.com:3drepo/3drepo.io.git","clone_url":"https://github.com/3drepo/3drepo.io.git","svn_url":"https://github.com/3drepo/3drepo.io","homepage":"http://www.3drepo.io","size":598666,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":30,"open_issues":82,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133"},"html":{"href":"https://github.com/3drepo/3drepo.io/pull/1133"},"issue":{"href":"https://api.github.com/repos/3drepo/3drepo.io/issues/1133"},"comments":{"href":"https://api.github.com/repos/3drepo/3drepo.io/issues/1133/comments"},"review_comments":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133/comments"},"review_comment":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1133/commits"},"statuses":{"href":"https://api.github.com/repos/3drepo/3drepo.io/statuses/601127b0fb7798cfde9cf74ad864116f6a44044d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carmenfan"}}