{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/184403397","pull_request_review_id":115592042,"id":184403397,"diff_hunk":"@@ -226,9 +243,14 @@ class ServiceMetrics extends React.Component<ServiceId, ServiceMetricsState> {\n   dismissAlert = () => this.setState({ alertDetails: undefined });\n \n   render() {\n+    const { store } = this.context;\n+    store.subscribe(() => {","path":"src/pages/ServiceDetails/ServiceMetrics.tsx","position":48,"original_position":48,"commit_id":"80d579a019ef97c48968c55181d8cffde0fe7dac","original_commit_id":"80d579a019ef97c48968c55181d8cffde0fe7dac","user":{"login":"aljesusg","id":3019213,"avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"body":"I don't know ^^ I am new in redux, This is one of my questions to @mtho11 and @vnugent how to handle with the subscribe(), I don't like to have them in the render, but They should be in each component that we wanna update if the store change","created_at":"2018-04-26T14:10:06Z","updated_at":"2018-04-26T14:10:06Z","html_url":"https://github.com/kiali/kiali-ui/pull/288#discussion_r184403397","pull_request_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/184403397"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/288#discussion_r184403397"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/288"}},"in_reply_to_id":184401447},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/288","id":184296212,"html_url":"https://github.com/kiali/kiali-ui/pull/288","diff_url":"https://github.com/kiali/kiali-ui/pull/288.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/288.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/288","number":288,"state":"open","locked":false,"title":"[WIP][KIALI-610] Merge Toolbars with Redux","user":{"login":"aljesusg","id":3019213,"avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"body":"I started to work  in [KIALI-610](https://issues.jboss.org/browse/KIALI-610).\r\nNow you can use the kialitoolbar in the graph view less the namespace selector with Redux.\r\n\r\n- [ ] GraphFilter\r\n  - [ ] Namespace Slelector\r\n  - [X] Duration\r\n  - [X] Layout\r\n  - [X] Refresh\r\n- [ ] ServiceList\r\n  - [ ] Group by\r\n  - [X] Duration\r\n  - [ ] Interval\r\n- [ ] MetricOptions\r\n  - [ ] Filters\r\n  - [ ] Finder\r\n  - [ ] Selector Services\r\n\r\nI need some feedback about what do you think? @mtho11  @vnugent \r\n\r\n- GraphFilter. Should we add the Namespace selector of @vnugent  with this toolbar?\r\n- GraphFilter. How to handle with subscribers.\r\n\r\n```js\r\nstatic contextTypes = {\r\n    store: PropTypes.object.isRequired\r\n  };\r\n...\r\n  render() {\r\n    const { store } = this.context;\r\n    store.subscribe(() => {\r\n      this.updateGraph(store.getState().toolbar);\r\n    });\r\n```\r\n- Configuration toolbar. I added a new object in the configuration file to configure with kind of option we need in each toolbar. What do you think?\r\n\r\n```json\r\nexport const config = () => {\r\n  return {\r\n    version: '0.1',\r\n    backend: {\r\n      user: 'jdoe',\r\n      password: 'password'\r\n    },\r\n    toolbars: {\r\n      graph: ['duration', 'layout', 'refresh'],\r\n      metrics: ['duration']\r\n    }\r\n  };\r\n};\r\n```\r\n\r\n- MetricsOptions. This toolbar is so huge I'll need more time and maube an a masterclass of @jotak . Should we merge all the logic in the \"main toolbar\"  or create a subcomponents? ([metricOptionsBar](https://github.com/kiali/kiali-ui/blob/master/src/components/MetricsOptions/MetricsOptionsBar.tsx))","created_at":"2018-04-26T10:34:44Z","updated_at":"2018-04-26T14:10:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":843835097,"url":"https://api.github.com/repos/kiali/kiali-ui/labels/Do%20NOT%20Merge%20(yet)","name":"Do NOT Merge (yet)","color":"5ed694","default":false},{"id":882182274,"url":"https://api.github.com/repos/kiali/kiali-ui/labels/Refactor","name":"Refactor","color":"9193d8","default":false},{"id":827510438,"url":"https://api.github.com/repos/kiali/kiali-ui/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/288/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/288/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/288/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/80d579a019ef97c48968c55181d8cffde0fe7dac","head":{"label":"aljesusg:merge_toolbars","ref":"merge_toolbars","sha":"80d579a019ef97c48968c55181d8cffde0fe7dac","user":{"login":"aljesusg","id":3019213,"avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"repo":{"id":120960280,"name":"kiali-ui","full_name":"aljesusg/kiali-ui","owner":{"login":"aljesusg","id":3019213,"avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aljesusg/kiali-ui","description":null,"fork":true,"url":"https://api.github.com/repos/aljesusg/kiali-ui","forks_url":"https://api.github.com/repos/aljesusg/kiali-ui/forks","keys_url":"https://api.github.com/repos/aljesusg/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aljesusg/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aljesusg/kiali-ui/teams","hooks_url":"https://api.github.com/repos/aljesusg/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/aljesusg/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/aljesusg/kiali-ui/events","assignees_url":"https://api.github.com/repos/aljesusg/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/aljesusg/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/aljesusg/kiali-ui/tags","blobs_url":"https://api.github.com/repos/aljesusg/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aljesusg/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aljesusg/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/aljesusg/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aljesusg/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/aljesusg/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/aljesusg/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/aljesusg/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/aljesusg/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/aljesusg/kiali-ui/subscription","commits_url":"https://api.github.com/repos/aljesusg/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/aljesusg/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/aljesusg/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/aljesusg/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/aljesusg/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/aljesusg/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aljesusg/kiali-ui/merges","archive_url":"https://api.github.com/repos/aljesusg/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aljesusg/kiali-ui/downloads","issues_url":"https://api.github.com/repos/aljesusg/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/aljesusg/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/aljesusg/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/aljesusg/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aljesusg/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/aljesusg/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/aljesusg/kiali-ui/deployments","created_at":"2018-02-09T22:00:25Z","updated_at":"2018-04-26T13:28:16Z","pushed_at":"2018-04-26T14:04:23Z","git_url":"git://github.com/aljesusg/kiali-ui.git","ssh_url":"git@github.com:aljesusg/kiali-ui.git","clone_url":"https://github.com/aljesusg/kiali-ui.git","svn_url":"https://github.com/aljesusg/kiali-ui","homepage":null,"size":1284,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"f7a6e3b78ee21db5c1c889c0d88dbda77812ef67","user":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-04-26T13:51:16Z","pushed_at":"2018-04-26T14:06:24Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"","size":1285,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":13,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/288"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/288"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/288"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/80d579a019ef97c48968c55181d8cffde0fe7dac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aljesusg"}}