{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/comments/228247193","pull_request_review_id":168476289,"id":228247193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI0NzE5Mw==","diff_hunk":"@@ -395,64 +395,40 @@ function tovrep(P::HPoly{N};\n end\n \n \"\"\"\n-    vertices_list(P::HPoly{N};\n-                  [backend]=default_polyhedra_backend(P, N),\n-                  [prunefunc]=removevredundancy!)::Vector{Vector{N}} where\n-                  {N<:Real}\n+    vertices_list(P::HPolyhedron{N}) where {N<:Real}\n \n-Return the list of vertices of a polytope in constraint representation.\n+Return the list of vertices of a polyhedron in constraint representation.\n \n ### Input\n \n-- `P`         -- polytope in constraint representation\n-- `backend`   -- (optional, default: `default_polyhedra_backend(P, N)`)\n-                  the polyhedral computations backend\n-- `prunefunc` -- (optional, default: `removevredundancy!`) function to\n-                 post-process the output of `vreps`\n+- `P` -- polyhedron in constraint representation\n \n ### Output\n \n-List of vertices.\n-\n-### Notes\n-\n-For further information on the supported backends see\n-[Polyhedra's documentation](https://juliapolyhedra.github.io/Polyhedra.jl/).\n-\n-### Examples\n+This function returns an error because the polyhedron is possibly unbounded.\n+If `P` is known to be bounded, try converting to `HPolytope` first:\n \n ```jldoctest\n-julia> using Polyhedra\n+julia> P = HPolyhedron([HalfSpace([1.0, 0.0], 1.0),\n+                        HalfSpace([0.0, 1.0], 1.0),\n+                        HalfSpace([-1.0, 0.0], 1.0),\n+                        HalfSpace([0.0, -1.0], 1.0)])\n \n-julia> P = HPolytope([1.0 0.0; 0.0 1.0; -1.0 0.0; 0.0 -1.0], fill(1., 4));\n+julia> P_as_polytope = convert(HPolytope, P);\n \n-julia> constraints_list(P)\n-4-element Array{HalfSpace{Float64},1}:\n- HalfSpace{Float64}([1.0, 0.0], 1.0)\n- HalfSpace{Float64}([0.0, 1.0], 1.0)\n- HalfSpace{Float64}([-1.0, 0.0], 1.0)\n- HalfSpace{Float64}([0.0, -1.0], 1.0)\n+julia> using Polyhedra # needed to compute the dual representation\n \n-julia> vertices_list(P)\n+julia> vertices_list(P_as_polytope)\n 4-element Array{Array{Float64,1},1}:\n  [1.0, 1.0]\n  [-1.0, 1.0]\n  [1.0, -1.0]\n  [-1.0, -1.0]\n ```\n \"\"\"\n-function vertices_list(P::HPoly{N};\n-                       backend=default_polyhedra_backend(P, N),\n-                       prunefunc=removevredundancy!\n-                      )::Vector{Vector{N}} where {N<:Real}\n-    if length(P.constraints) == 0\n-        return Vector{N}(undef, Vector{N}(undef, 0))\n-    end\n-    @assert isdefined(Main, :Polyhedra) \"the function `vertices_list` needs \" *\n-                                        \"the package 'Polyhedra' to be loaded\"\n-    P = polyhedron(P, backend)\n-    prunefunc(P)\n-    return collect(points(P))\n+function vertices_list(P::HPolyhedron{N}) where {N<:Real}\n+    error(\"the list of vertices of a (possibly unbounded) polyhedron is not defined;\" *\n+          \"if the polyhedron is bounded try converting to `HPolytope` first\")","path":"src/HPolyhedron.jl","position":76,"original_position":76,"commit_id":"0a4a29b66cc44a52e9a1efed8ae4947efd2e6b1a","original_commit_id":"0a4a29b66cc44a52e9a1efed8ae4947efd2e6b1a","user":{"login":"schillic","id":9656686,"node_id":"MDQ6VXNlcjk2NTY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/9656686?v=4","gravatar_id":"","url":"https://api.github.com/users/schillic","html_url":"https://github.com/schillic","followers_url":"https://api.github.com/users/schillic/followers","following_url":"https://api.github.com/users/schillic/following{/other_user}","gists_url":"https://api.github.com/users/schillic/gists{/gist_id}","starred_url":"https://api.github.com/users/schillic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schillic/subscriptions","organizations_url":"https://api.github.com/users/schillic/orgs","repos_url":"https://api.github.com/users/schillic/repos","events_url":"https://api.github.com/users/schillic/events{/privacy}","received_events_url":"https://api.github.com/users/schillic/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n          \"if the polyhedron is bounded, try converting to `HPolytope` first\")\r\n```","created_at":"2018-10-25T16:33:24Z","updated_at":"2018-10-25T16:36:03Z","html_url":"https://github.com/JuliaReach/LazySets.jl/pull/854#discussion_r228247193","pull_request_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/comments/228247193"},"html":{"href":"https://github.com/JuliaReach/LazySets.jl/pull/854#discussion_r228247193"},"pull_request":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854","id":225821439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODIxNDM5","html_url":"https://github.com/JuliaReach/LazySets.jl/pull/854","diff_url":"https://github.com/JuliaReach/LazySets.jl/pull/854.diff","patch_url":"https://github.com/JuliaReach/LazySets.jl/pull/854.patch","issue_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/854","number":854,"state":"open","locked":false,"title":"#820 - Vertices list of polyhedron","user":{"login":"mforets","id":12424594,"node_id":"MDQ6VXNlcjEyNDI0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/12424594?v=4","gravatar_id":"","url":"https://api.github.com/users/mforets","html_url":"https://github.com/mforets","followers_url":"https://api.github.com/users/mforets/followers","following_url":"https://api.github.com/users/mforets/following{/other_user}","gists_url":"https://api.github.com/users/mforets/gists{/gist_id}","starred_url":"https://api.github.com/users/mforets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mforets/subscriptions","organizations_url":"https://api.github.com/users/mforets/orgs","repos_url":"https://api.github.com/users/mforets/repos","events_url":"https://api.github.com/users/mforets/events{/privacy}","received_events_url":"https://api.github.com/users/mforets/received_events","type":"User","site_admin":false},"body":"Closes #820.","created_at":"2018-10-25T16:15:16Z","updated_at":"2018-10-25T16:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536444e2c6aabfc7b0593b99d57021e6611923d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854/commits","review_comments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854/comments","review_comment_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/854/comments","statuses_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/statuses/0a4a29b66cc44a52e9a1efed8ae4947efd2e6b1a","head":{"label":"JuliaReach:mforets/820","ref":"mforets/820","sha":"0a4a29b66cc44a52e9a1efed8ae4947efd2e6b1a","user":{"login":"JuliaReach","id":33028082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDI4MDgy","avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"repo":{"id":105701832,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3MDE4MzI=","name":"LazySets.jl","full_name":"JuliaReach/LazySets.jl","private":false,"owner":{"login":"JuliaReach","id":33028082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDI4MDgy","avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaReach/LazySets.jl","description":"A Julia package for calculus with convex sets","fork":false,"url":"https://api.github.com/repos/JuliaReach/LazySets.jl","forks_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/forks","keys_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/teams","hooks_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/events","assignees_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/tags","blobs_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/subscription","commits_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/merges","archive_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/downloads","issues_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/deployments","created_at":"2017-10-03T20:50:18Z","updated_at":"2018-10-25T15:13:04Z","pushed_at":"2018-10-25T16:15:16Z","git_url":"git://github.com/JuliaReach/LazySets.jl.git","ssh_url":"git@github.com:JuliaReach/LazySets.jl.git","clone_url":"https://github.com/JuliaReach/LazySets.jl.git","svn_url":"https://github.com/JuliaReach/LazySets.jl","homepage":"","size":18830,"stargazers_count":23,"watchers_count":23,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":179,"watchers":23,"default_branch":"master"}},"base":{"label":"JuliaReach:master","ref":"master","sha":"a0962bd633a6b4fc7cfae9a4747bc4ad8a2f2542","user":{"login":"JuliaReach","id":33028082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDI4MDgy","avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"repo":{"id":105701832,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3MDE4MzI=","name":"LazySets.jl","full_name":"JuliaReach/LazySets.jl","private":false,"owner":{"login":"JuliaReach","id":33028082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDI4MDgy","avatar_url":"https://avatars3.githubusercontent.com/u/33028082?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaReach","html_url":"https://github.com/JuliaReach","followers_url":"https://api.github.com/users/JuliaReach/followers","following_url":"https://api.github.com/users/JuliaReach/following{/other_user}","gists_url":"https://api.github.com/users/JuliaReach/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaReach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaReach/subscriptions","organizations_url":"https://api.github.com/users/JuliaReach/orgs","repos_url":"https://api.github.com/users/JuliaReach/repos","events_url":"https://api.github.com/users/JuliaReach/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaReach/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaReach/LazySets.jl","description":"A Julia package for calculus with convex sets","fork":false,"url":"https://api.github.com/repos/JuliaReach/LazySets.jl","forks_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/forks","keys_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/teams","hooks_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/events","assignees_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/tags","blobs_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/subscription","commits_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/merges","archive_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/downloads","issues_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/deployments","created_at":"2017-10-03T20:50:18Z","updated_at":"2018-10-25T15:13:04Z","pushed_at":"2018-10-25T16:15:16Z","git_url":"git://github.com/JuliaReach/LazySets.jl.git","ssh_url":"git@github.com:JuliaReach/LazySets.jl.git","clone_url":"https://github.com/JuliaReach/LazySets.jl.git","svn_url":"https://github.com/JuliaReach/LazySets.jl","homepage":"","size":18830,"stargazers_count":23,"watchers_count":23,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":179,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854"},"html":{"href":"https://github.com/JuliaReach/LazySets.jl/pull/854"},"issue":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/854"},"comments":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/854/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/pulls/854/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaReach/LazySets.jl/statuses/0a4a29b66cc44a52e9a1efed8ae4947efd2e6b1a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"schillic"}}