{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments/211629656","pull_request_review_id":148090809,"id":211629656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTYyOTY1Ng==","diff_hunk":"@@ -35,10 +35,26 @@ data:\n     runmode=${runmode:-normal}\n     if [[ X${runmode} == Xdebug ]]\n     then\n-    \techo \"entering debug mode.\"\n-    \ttail -f /dev/null\n+        echo \"entering debug mode.\"\n+        tail -f /dev/null\n     fi\n \n+    elapseTime=0\n+    period=1\n+    threshold=30\n+    while true;do\n+        nslookup ${HOSTNAME}.${PEER_SERVICE_NAME}.${NAMESPACE}.svc 2>/dev/null\n+        [[ $? -eq 0 ]] && break\n+        echo \"nslookup domain ${HOSTNAME}.${PEER_SERVICE_NAME}.${NAMESPACE}.svc failed\"\n+        sleep ${period}\n+        elapseTime=$(( elapseTime+period ))\n+        if [[ ${elapseTime} -ge ${threshold} ]];then\n+            echo \"nslookup domain ${HOSTNAME}.${PEER_SERVICE_NAME}.${NAMESPACE}.svc timeout\"\n+            break","path":"charts/tidb-cluster/templates/pd-configmap.yaml","position":30,"original_position":30,"commit_id":"8a2150cd262c2cdf0089cabc315f99f3f96d30f8","original_commit_id":"b113e327b27a8a7fbab1384000cd26ebd6b9bf5b","user":{"login":"gregwebs","id":1183,"node_id":"MDQ6VXNlcjExODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1183?v=4","gravatar_id":"","url":"https://api.github.com/users/gregwebs","html_url":"https://github.com/gregwebs","followers_url":"https://api.github.com/users/gregwebs/followers","following_url":"https://api.github.com/users/gregwebs/following{/other_user}","gists_url":"https://api.github.com/users/gregwebs/gists{/gist_id}","starred_url":"https://api.github.com/users/gregwebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregwebs/subscriptions","organizations_url":"https://api.github.com/users/gregwebs/orgs","repos_url":"https://api.github.com/users/gregwebs/repos","events_url":"https://api.github.com/users/gregwebs/events{/privacy}","received_events_url":"https://api.github.com/users/gregwebs/received_events","type":"User","site_admin":false},"body":"echo should also be to stderr","created_at":"2018-08-21T14:34:49Z","updated_at":"2018-08-21T14:34:49Z","html_url":"https://github.com/pingcap/tidb-operator/pull/38#discussion_r211629656","pull_request_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments/211629656"},"html":{"href":"https://github.com/pingcap/tidb-operator/pull/38#discussion_r211629656"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38"}},"in_reply_to_id":211621992},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38","id":209839218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODM5MjE4","html_url":"https://github.com/pingcap/tidb-operator/pull/38","diff_url":"https://github.com/pingcap/tidb-operator/pull/38.diff","patch_url":"https://github.com/pingcap/tidb-operator/pull/38.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/38","number":38,"state":"open","locked":false,"title":"Fix the issue that failed to enter PD/TiKV/TiDB's debug mode","user":{"login":"onlymellb","id":8480893,"node_id":"MDQ6VXNlcjg0ODA4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8480893?v=4","gravatar_id":"","url":"https://api.github.com/users/onlymellb","html_url":"https://github.com/onlymellb","followers_url":"https://api.github.com/users/onlymellb/followers","following_url":"https://api.github.com/users/onlymellb/following{/other_user}","gists_url":"https://api.github.com/users/onlymellb/gists{/gist_id}","starred_url":"https://api.github.com/users/onlymellb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlymellb/subscriptions","organizations_url":"https://api.github.com/users/onlymellb/orgs","repos_url":"https://api.github.com/users/onlymellb/repos","events_url":"https://api.github.com/users/onlymellb/events{/privacy}","received_events_url":"https://api.github.com/users/onlymellb/received_events","type":"User","site_admin":false},"body":"This PR cancels the setting of the `errexit` option in a shell script in order to avoid  `source /etc/podinfo/annotations` failure, and also adds the logic of pd's domain name resolution.\r\n\r\nPTAL @tennix @weekface @xiaojingchen @gregwebs \r\n","created_at":"2018-08-21T14:08:38Z","updated_at":"2018-08-21T14:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21166a060e698206f14d52884bc17278cc8dbd60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/38/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/8a2150cd262c2cdf0089cabc315f99f3f96d30f8","head":{"label":"onlymellb:onlymellb/fix-debug-mode","ref":"onlymellb/fix-debug-mode","sha":"8a2150cd262c2cdf0089cabc315f99f3f96d30f8","user":{"login":"onlymellb","id":8480893,"node_id":"MDQ6VXNlcjg0ODA4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8480893?v=4","gravatar_id":"","url":"https://api.github.com/users/onlymellb","html_url":"https://github.com/onlymellb","followers_url":"https://api.github.com/users/onlymellb/followers","following_url":"https://api.github.com/users/onlymellb/following{/other_user}","gists_url":"https://api.github.com/users/onlymellb/gists{/gist_id}","starred_url":"https://api.github.com/users/onlymellb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlymellb/subscriptions","organizations_url":"https://api.github.com/users/onlymellb/orgs","repos_url":"https://api.github.com/users/onlymellb/repos","events_url":"https://api.github.com/users/onlymellb/events{/privacy}","received_events_url":"https://api.github.com/users/onlymellb/received_events","type":"User","site_admin":false},"repo":{"id":145279254,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUyNzkyNTQ=","name":"tidb-operator","full_name":"onlymellb/tidb-operator","owner":{"login":"onlymellb","id":8480893,"node_id":"MDQ6VXNlcjg0ODA4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8480893?v=4","gravatar_id":"","url":"https://api.github.com/users/onlymellb","html_url":"https://github.com/onlymellb","followers_url":"https://api.github.com/users/onlymellb/followers","following_url":"https://api.github.com/users/onlymellb/following{/other_user}","gists_url":"https://api.github.com/users/onlymellb/gists{/gist_id}","starred_url":"https://api.github.com/users/onlymellb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlymellb/subscriptions","organizations_url":"https://api.github.com/users/onlymellb/orgs","repos_url":"https://api.github.com/users/onlymellb/repos","events_url":"https://api.github.com/users/onlymellb/events{/privacy}","received_events_url":"https://api.github.com/users/onlymellb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onlymellb/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":true,"url":"https://api.github.com/repos/onlymellb/tidb-operator","forks_url":"https://api.github.com/repos/onlymellb/tidb-operator/forks","keys_url":"https://api.github.com/repos/onlymellb/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onlymellb/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onlymellb/tidb-operator/teams","hooks_url":"https://api.github.com/repos/onlymellb/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/onlymellb/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/onlymellb/tidb-operator/events","assignees_url":"https://api.github.com/repos/onlymellb/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/onlymellb/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/onlymellb/tidb-operator/tags","blobs_url":"https://api.github.com/repos/onlymellb/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onlymellb/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onlymellb/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/onlymellb/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onlymellb/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/onlymellb/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/onlymellb/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/onlymellb/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/onlymellb/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/onlymellb/tidb-operator/subscription","commits_url":"https://api.github.com/repos/onlymellb/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/onlymellb/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/onlymellb/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/onlymellb/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/onlymellb/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/onlymellb/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onlymellb/tidb-operator/merges","archive_url":"https://api.github.com/repos/onlymellb/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onlymellb/tidb-operator/downloads","issues_url":"https://api.github.com/repos/onlymellb/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/onlymellb/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/onlymellb/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/onlymellb/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onlymellb/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/onlymellb/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/onlymellb/tidb-operator/deployments","created_at":"2018-08-19T06:32:01Z","updated_at":"2018-08-21T12:03:26Z","pushed_at":"2018-08-21T14:26:18Z","git_url":"git://github.com/onlymellb/tidb-operator.git","ssh_url":"git@github.com:onlymellb/tidb-operator.git","clone_url":"https://github.com/onlymellb/tidb-operator.git","svn_url":"https://github.com/onlymellb/tidb-operator","homepage":"","size":48211,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"31797213b2e4da4df322cdb48a450f094bb23a85","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":143867478,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4Njc0Nzg=","name":"tidb-operator","full_name":"pingcap/tidb-operator","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":false,"url":"https://api.github.com/repos/pingcap/tidb-operator","forks_url":"https://api.github.com/repos/pingcap/tidb-operator/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-operator/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-operator/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-operator/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-operator/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-operator/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-operator/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-operator/deployments","created_at":"2018-08-07T12:04:33Z","updated_at":"2018-08-21T14:26:01Z","pushed_at":"2018-08-21T14:28:13Z","git_url":"git://github.com/pingcap/tidb-operator.git","ssh_url":"git@github.com:pingcap/tidb-operator.git","clone_url":"https://github.com/pingcap/tidb-operator.git","svn_url":"https://github.com/pingcap/tidb-operator","homepage":"","size":48222,"stargazers_count":90,"watchers_count":90,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":4,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38"},"html":{"href":"https://github.com/pingcap/tidb-operator/pull/38"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/38"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-operator/statuses/8a2150cd262c2cdf0089cabc315f99f3f96d30f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gregwebs"}}