{"comment":{"url":"https://api.github.com/repos/siteshwar/ast/comments/29759956","html_url":"https://github.com/siteshwar/ast/commit/bc9572a8535c3454bee7d7375c9594d41a593f47#commitcomment-29759956","id":29759956,"node_id":"MDEzOkNvbW1pdENvbW1lbnQyOTc1OTk1Ng==","user":{"login":"krader1961","id":7545917,"node_id":"MDQ6VXNlcjc1NDU5MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7545917?v=4","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"position":17,"line":63,"path":".travis.yml","commit_id":"bc9572a8535c3454bee7d7375c9594d41a593f47","created_at":"2018-07-19T06:57:05Z","updated_at":"2018-07-19T06:57:05Z","author_association":"NONE","body":"This is the wrong way to do this. Even assuming we did agree incorporating `csbuild` is desirable the csbuild specific bits (i.e., the `sudo...` portion)  should be embedded in the *scripts/build-on-docker.sh* script rather than this config file. In no small part because if we did make this standard behavior the other Linux test environments should leverage it without having to do anything other than add the `SCAN_TYPE=csbuild` var. And, not too surprisingly, incorporating `csbuild` breaks the build because it apparently does not play well with Meson. Too, I don't see how it can add value without significant cost in the context of the Travis CI environment. Which, given we are using it without recompense, seems rather uncivil.\r\n\r\n@kdudka wrote:\r\n\r\n> You can configure csbuild to invoke full build just once and then rebuild only files changed by the commits in question.\r\n\r\nThat is not true for using it in Travis AFAICT as it requires remembering build state between invocations. Which is definitely not true for our Travis CI use.\r\n\r\n@siteshwar, I understand that you need to be sensitive to the demands made by your boss. But incorporating `csbuild` into this project, outside of Red Hat's internal build system, seems to add far more cost than benefit."}}
{"actor":{"display_login":"krader1961"}}