{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/184895568","pull_request_review_id":116179151,"id":184895568,"diff_hunk":"@@ -2,6 +2,9 @@ PLATFORM_FLAVOR ?= hikey\n \n include core/arch/arm/cpu/cortex-armv8-0.mk\n \n+CFG_TEE_CORE_NB_CORE = 8\n+","path":"core/arch/arm/plat-hikey/conf.mk","position":5,"original_position":5,"commit_id":"c7c72b65b83b8ba499042560b3258e591bc7c1e4","original_commit_id":"35a0daf4e846be4dc6f4216deb0f0a8850781ee9","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"addressed. remaining empty line is ok.","created_at":"2018-04-29T21:27:26Z","updated_at":"2018-04-29T21:28:32Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2280#discussion_r184895568","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/184895568"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2280#discussion_r184895568"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280"}},"in_reply_to_id":184181520},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280","id":184119544,"html_url":"https://github.com/OP-TEE/optee_os/pull/2280","diff_url":"https://github.com/OP-TEE/optee_os/pull/2280.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2280.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2280","number":2280,"state":"open","locked":false,"title":"Remove CFG_ from vexpress and various platforms","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"This P-R removes CFG_ definitions from platform_config.h files for the\r\nplatforms vexpress, dl02, hikey, marvell, mediatek, poplar, rcar, rpi3, sam,\r\nsprd, zynqmp. \r\n\r\nFor vexpress, there is a specific commit linaro can ack. All others aggregated \r\nlinaro can ack the as obvious changes without asking maintainers.\r\n\r\n","created_at":"2018-04-25T18:09:58Z","updated_at":"2018-04-29T21:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb2c4de991f022fbd5dc7e8990d052ba76be8ccc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2280/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/c7c72b65b83b8ba499042560b3258e591bc7c1e4","head":{"label":"etienne-lms:cfg1","ref":"cfg1","sha":"c7c72b65b83b8ba499042560b3258e591bc7c1e4","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"repo":{"id":62886797,"name":"optee_os","full_name":"etienne-lms/optee_os","owner":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etienne-lms/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/etienne-lms/optee_os","forks_url":"https://api.github.com/repos/etienne-lms/optee_os/forks","keys_url":"https://api.github.com/repos/etienne-lms/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etienne-lms/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etienne-lms/optee_os/teams","hooks_url":"https://api.github.com/repos/etienne-lms/optee_os/hooks","issue_events_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/etienne-lms/optee_os/events","assignees_url":"https://api.github.com/repos/etienne-lms/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/etienne-lms/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/etienne-lms/optee_os/tags","blobs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etienne-lms/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/etienne-lms/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etienne-lms/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/etienne-lms/optee_os/languages","stargazers_url":"https://api.github.com/repos/etienne-lms/optee_os/stargazers","contributors_url":"https://api.github.com/repos/etienne-lms/optee_os/contributors","subscribers_url":"https://api.github.com/repos/etienne-lms/optee_os/subscribers","subscription_url":"https://api.github.com/repos/etienne-lms/optee_os/subscription","commits_url":"https://api.github.com/repos/etienne-lms/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/etienne-lms/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/etienne-lms/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/etienne-lms/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/etienne-lms/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etienne-lms/optee_os/merges","archive_url":"https://api.github.com/repos/etienne-lms/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etienne-lms/optee_os/downloads","issues_url":"https://api.github.com/repos/etienne-lms/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/etienne-lms/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/etienne-lms/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/etienne-lms/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etienne-lms/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/etienne-lms/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/etienne-lms/optee_os/deployments","created_at":"2016-07-08T12:24:05Z","updated_at":"2018-04-27T15:20:12Z","pushed_at":"2018-04-29T21:24:30Z","git_url":"git://github.com/etienne-lms/optee_os.git","ssh_url":"git@github.com:etienne-lms/optee_os.git","clone_url":"https://github.com/etienne-lms/optee_os.git","svn_url":"https://github.com/etienne-lms/optee_os","homepage":null,"size":13307,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"94cfc3ed9ece4f512d8aac4fef42d7093b3dd64b","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-04-27T08:32:11Z","pushed_at":"2018-04-29T21:24:32Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":12975,"stargazers_count":382,"watchers_count":382,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":333,"open_issues":175,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2280"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2280"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2280/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2280/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/c7c72b65b83b8ba499042560b3258e591bc7c1e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"etienne-lms"}}