{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/213372592","pull_request_review_id":150194827,"id":213372592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzM3MjU5Mg==","diff_hunk":"@@ -65,13 +65,15 @@ private void GenerateComponentGroups()\n                     GetComponentGroup(gameObjectComponentDispatcher.ComponentAddedComponentTypes);\n                 gameObjectComponentDispatcher.ComponentRemovedComponentGroup =\n                     GetComponentGroup(gameObjectComponentDispatcher.ComponentRemovedComponentTypes);\n-                gameObjectComponentDispatcher.AuthoritiesChangedComponentGroup =\n-                    GetComponentGroup(gameObjectComponentDispatcher.AuthoritiesChangedComponentTypes);\n-                if (gameObjectComponentDispatcher.ComponentsUpdatedComponentTypes.Length > 0)\n-                {\n-                    gameObjectComponentDispatcher.ComponentsUpdatedComponentGroup =\n-                        GetComponentGroup(gameObjectComponentDispatcher.ComponentsUpdatedComponentTypes);\n-                }\n+                gameObjectComponentDispatcher.AuthorityGainedComponentGroup =\n+                    GetComponentGroup(gameObjectComponentDispatcher.AuthorityGainedComponentTypes);\n+                gameObjectComponentDispatcher.AuthorityLostComponentGroup =\n+                    GetComponentGroup(gameObjectComponentDispatcher.AuthorityLostComponentTypes);\n+                gameObjectComponentDispatcher.AuthorityLossImminentComponentGroup =\n+                    GetComponentGroup(gameObjectComponentDispatcher.AuthorityLossImminentComponentTypes);\n+                gameObjectComponentDispatcher.ComponentsUpdatedComponentGroup =","path":"workers/unity/Packages/com.improbable.gdk.core/GameObjectRepresentation/GameObjectDispatcherSystem.cs","position":17,"original_position":17,"commit_id":"051f99be001e3cdaaa09f1a9341bdc19f8b69876","original_commit_id":"051f99be001e3cdaaa09f1a9341bdc19f8b69876","user":{"login":"JonasImprobable","id":17834448,"node_id":"MDQ6VXNlcjE3ODM0NDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/17834448?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasImprobable","html_url":"https://github.com/JonasImprobable","followers_url":"https://api.github.com/users/JonasImprobable/followers","following_url":"https://api.github.com/users/JonasImprobable/following{/other_user}","gists_url":"https://api.github.com/users/JonasImprobable/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasImprobable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasImprobable/subscriptions","organizations_url":"https://api.github.com/users/JonasImprobable/orgs","repos_url":"https://api.github.com/users/JonasImprobable/repos","events_url":"https://api.github.com/users/JonasImprobable/events{/privacy}","received_events_url":"https://api.github.com/users/JonasImprobable/received_events","type":"User","site_admin":false},"body":"It looks like the previous `if (gameObjectComponentDispatcher.ComponentsUpdatedComponentTypes.Length > 0)` part has been removed. Is that intentional?","created_at":"2018-08-28T15:54:20Z","updated_at":"2018-08-28T15:54:20Z","html_url":"https://github.com/spatialos/UnityGDK/pull/244#discussion_r213372592","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/213372592"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/244#discussion_r213372592"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244","id":210188612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTg4NjEy","html_url":"https://github.com/spatialos/UnityGDK/pull/244","diff_url":"https://github.com/spatialos/UnityGDK/pull/244.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/244.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/244","number":244,"state":"open","locked":false,"title":"UTY-830: Rework GameObjectDispatcherSystem ops ordering","user":{"login":"MPeti01","id":25401316,"node_id":"MDQ6VXNlcjI1NDAxMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/25401316?v=4","gravatar_id":"","url":"https://api.github.com/users/MPeti01","html_url":"https://github.com/MPeti01","followers_url":"https://api.github.com/users/MPeti01/followers","following_url":"https://api.github.com/users/MPeti01/following{/other_user}","gists_url":"https://api.github.com/users/MPeti01/gists{/gist_id}","starred_url":"https://api.github.com/users/MPeti01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPeti01/subscriptions","organizations_url":"https://api.github.com/users/MPeti01/orgs","repos_url":"https://api.github.com/users/MPeti01/repos","events_url":"https://api.github.com/users/MPeti01/events{/privacy}","received_events_url":"https://api.github.com/users/MPeti01/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nReworked order of enabling MonoBehaviours and calling user callbacks based on discussions with @samiwh \r\n\r\nBasic goals: Writers should not get authority change callbacks, Writers should not receive updates from different workers. Simple compromise we made to do this without lots of weird edge cases that could end up surprising users: Readers/Writers don't get update callbacks on the tick when they are enabled.\r\n\r\n#### Tests\r\nNo additional tests, Playground still works\r\n#### Documentation\r\nN/A\r\n#### Primary reviewers\r\n@samiwh @JonasImprobable ","created_at":"2018-08-22T16:14:25Z","updated_at":"2018-08-28T15:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d78ab1805702518d0430e691a47854b8338b9bef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1002053376,"node_id":"MDU6TGFiZWwxMDAyMDUzMzc2","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/244/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/051f99be001e3cdaaa09f1a9341bdc19f8b69876","head":{"label":"spatialos:feature/UTY-830/gameobject-dispatcher-ops-order","ref":"feature/UTY-830/gameobject-dispatcher-ops-order","sha":"051f99be001e3cdaaa09f1a9341bdc19f8b69876","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-28T14:34:40Z","pushed_at":"2018-08-28T15:51:39Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":149144,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":13,"watchers":82,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"640e8ffee0bc6d88a5c2a6fa17b9bf018ddb6886","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-28T14:34:40Z","pushed_at":"2018-08-28T15:51:39Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":149144,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":13,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/244"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/244"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/051f99be001e3cdaaa09f1a9341bdc19f8b69876"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JonasImprobable"}}