{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/30729","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/30729/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30729/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/30729/events","html_url":"https://github.com/dotnet/corefx/issues/30729","id":336675640,"node_id":"MDU6SXNzdWUzMzY2NzU2NDA=","number":30729,"title":"NETStandard test suite","user":{"login":"ericstj","id":8918108,"node_id":"MDQ6VXNlcjg5MTgxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8918108?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"labels":[{"id":174888041,"node_id":"MDU6TGFiZWwxNzQ4ODgwNDE=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-Infrastructure","name":"area-Infrastructure","color":"d4c5f9","default":false},{"id":443855532,"node_id":"MDU6TGFiZWw0NDM4NTU1MzI=","url":"https://api.github.com/repos/dotnet/corefx/labels/test%20enhancement","name":"test enhancement","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/5","html_url":"https://github.com/dotnet/corefx/milestone/5","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/5/labels","id":1328080,"node_id":"MDk6TWlsZXN0b25lMTMyODA4MA==","number":5,"title":"Future","description":"Milestone tracking issues not triaged to a planned release. Work in this milestone may happen, or may not: it is not committed.","creator":{"login":"joshfree","id":1302850,"node_id":"MDQ6VXNlcjEzMDI4NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1302850?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":1907,"closed_issues":220,"state":"open","created_at":"2015-09-29T00:25:45Z","updated_at":"2018-06-29T22:13:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-28T15:40:30Z","updated_at":"2018-06-29T22:48:10Z","closed_at":null,"author_association":"MEMBER","body":"I know we've discussed this before, but I don't recall an issue ever being filed.  We have a lot of tests for things that are part of .NETStandard but don't necessarily build netstandard versions of the test library that represent the netstandard surface area, nor package up a suite of netstandard tests.  I can see this being useful for other folks frameworks claiming NETStandard support (eg: mono, xamarin, unity).\r\n\r\n/cc @bartonjs @weshaggard @terrajobst "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/401492386","html_url":"https://github.com/dotnet/corefx/issues/30729#issuecomment-401492386","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30729","id":401492386,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ5MjM4Ng==","user":{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T22:48:10Z","updated_at":"2018-06-29T22:48:10Z","author_association":"MEMBER","body":"Got it. Here's a start at a breakdown of issues to solve - none seem blocking\r\n\r\n1.\tMake build adjustments to be able to build only netstandard from the root and put it in a flat folder. You can currently build platform specific configurations (netfx,  uap, netcoreapp) but this may mean some netstandard test configurations are never built at all currently because there is always a more specific configuration.\r\n\r\n2.\tMake a pass through netcoreapp tests to move into netstandard configuration as possible. When we made a pass through the build some months ago, we did make test libraries build against netstandard where we could. When not possible, we split netcoreapp and netstandard configurations -- most of our test libraries (119 of 155) have a netstandard configuration, 51 of those also have a netcoreapp configuration. However this division was not done fine grained, there will be files that mix netcoreapp and netstandard tests, either from before or after this work, and files in netcoreapp that need to be in netstandard, and maybe test libraries that should have netstandard configuration but don't.\r\n\r\n3.\tFix tests that do build against netstandard API that themselves make platform assumptions eg that it is .NET Core. Easy to discover and either fix or add conditions.\r\n\r\n4.\tIdentify tests that require netcoreapp API may be themselves adding important coverage of netstandard API. Not sure how we would find that - unless there's a way to measure code coverage of the API surface itself.\r\n\r\n@weshaggard anything to add?\r\n\r\n Assumption: for this purpose, everyone would consume test binaries built out of CoreFX. Is that reasonable @marek-safar ?"}}
{"actor":{"display_login":"danmosemsft"}}