{"action":"created","comment":{"url":"https://api.github.com/repos/google/turbinia/pulls/comments/238940469","pull_request_review_id":181595285,"id":238940469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODk0MDQ2OQ==","diff_hunk":"@@ -77,6 +78,8 @@ class Evidence(object):\n         processing this evidence.\n     cloud_only: Set to True for evidence types that can only be processed in a\n         cloud environment, e.g. GoogleCloudDisk.\n+    context_dependant: Whethere this evidence required to be built upon the\n+        context of a parent evidence.","path":"turbinia/evidence.py","position":22,"original_position":22,"commit_id":"fab2731abe62ae45b2cefbdbc204b8c2dc680004","original_commit_id":"fab2731abe62ae45b2cefbdbc204b8c2dc680004","user":{"login":"aarontp","id":2667195,"node_id":"MDQ6VXNlcjI2NjcxOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2667195?v=4","gravatar_id":"","url":"https://api.github.com/users/aarontp","html_url":"https://github.com/aarontp","followers_url":"https://api.github.com/users/aarontp/followers","following_url":"https://api.github.com/users/aarontp/following{/other_user}","gists_url":"https://api.github.com/users/aarontp/gists{/gist_id}","starred_url":"https://api.github.com/users/aarontp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarontp/subscriptions","organizations_url":"https://api.github.com/users/aarontp/orgs","repos_url":"https://api.github.com/users/aarontp/repos","events_url":"https://api.github.com/users/aarontp/events{/privacy}","received_events_url":"https://api.github.com/users/aarontp/received_events","type":"User","site_admin":false},"body":" Don't we need to set some of the other evidence types as context dependent then?  Or does that get done in the next PR when we actually move around the pre/post-processors?","created_at":"2018-12-05T06:08:04Z","updated_at":"2018-12-05T06:09:19Z","html_url":"https://github.com/google/turbinia/pull/296#discussion_r238940469","pull_request_url":"https://api.github.com/repos/google/turbinia/pulls/296","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/turbinia/pulls/comments/238940469"},"html":{"href":"https://github.com/google/turbinia/pull/296#discussion_r238940469"},"pull_request":{"href":"https://api.github.com/repos/google/turbinia/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/google/turbinia/pulls/296","id":227960485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTYwNDg1","html_url":"https://github.com/google/turbinia/pull/296","diff_url":"https://github.com/google/turbinia/pull/296.diff","patch_url":"https://github.com/google/turbinia/pull/296.patch","issue_url":"https://api.github.com/repos/google/turbinia/issues/296","number":296,"state":"open","locked":false,"title":"Use a link to a \"parent Evidence\" instead of subclassing","user":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"body":"Instread of stacking evidence types, as shown in  #261, we just implement a link from an Evidence object to a parent Evidence object.\r\nWhen this parent exists, we'll preprocess before our preprocess (same for postprocess).\r\n\r\nWhen we need to generate new evidences from a context Evidence, which will be processed by all the other Jobs, this new evidence type (ie DockerContainerEvidence) can just extend Evidence, and require that a parent evidence is provided.","created_at":"2018-11-02T14:48:51Z","updated_at":"2018-12-05T06:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eda291183eed498d8eddc8964123001030d34277","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/turbinia/pulls/296/commits","review_comments_url":"https://api.github.com/repos/google/turbinia/pulls/296/comments","review_comment_url":"https://api.github.com/repos/google/turbinia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/turbinia/issues/296/comments","statuses_url":"https://api.github.com/repos/google/turbinia/statuses/fab2731abe62ae45b2cefbdbc204b8c2dc680004","head":{"label":"rgayon:dont-stack-really","ref":"dont-stack-really","sha":"fab2731abe62ae45b2cefbdbc204b8c2dc680004","user":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"repo":{"id":146625122,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MjUxMjI=","name":"turbinia","full_name":"rgayon/turbinia","private":false,"owner":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rgayon/turbinia","description":"Automation and Scaling of Digital Forensics Tools","fork":true,"url":"https://api.github.com/repos/rgayon/turbinia","forks_url":"https://api.github.com/repos/rgayon/turbinia/forks","keys_url":"https://api.github.com/repos/rgayon/turbinia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgayon/turbinia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgayon/turbinia/teams","hooks_url":"https://api.github.com/repos/rgayon/turbinia/hooks","issue_events_url":"https://api.github.com/repos/rgayon/turbinia/issues/events{/number}","events_url":"https://api.github.com/repos/rgayon/turbinia/events","assignees_url":"https://api.github.com/repos/rgayon/turbinia/assignees{/user}","branches_url":"https://api.github.com/repos/rgayon/turbinia/branches{/branch}","tags_url":"https://api.github.com/repos/rgayon/turbinia/tags","blobs_url":"https://api.github.com/repos/rgayon/turbinia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgayon/turbinia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgayon/turbinia/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgayon/turbinia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgayon/turbinia/statuses/{sha}","languages_url":"https://api.github.com/repos/rgayon/turbinia/languages","stargazers_url":"https://api.github.com/repos/rgayon/turbinia/stargazers","contributors_url":"https://api.github.com/repos/rgayon/turbinia/contributors","subscribers_url":"https://api.github.com/repos/rgayon/turbinia/subscribers","subscription_url":"https://api.github.com/repos/rgayon/turbinia/subscription","commits_url":"https://api.github.com/repos/rgayon/turbinia/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgayon/turbinia/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgayon/turbinia/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgayon/turbinia/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgayon/turbinia/contents/{+path}","compare_url":"https://api.github.com/repos/rgayon/turbinia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgayon/turbinia/merges","archive_url":"https://api.github.com/repos/rgayon/turbinia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgayon/turbinia/downloads","issues_url":"https://api.github.com/repos/rgayon/turbinia/issues{/number}","pulls_url":"https://api.github.com/repos/rgayon/turbinia/pulls{/number}","milestones_url":"https://api.github.com/repos/rgayon/turbinia/milestones{/number}","notifications_url":"https://api.github.com/repos/rgayon/turbinia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgayon/turbinia/labels{/name}","releases_url":"https://api.github.com/repos/rgayon/turbinia/releases{/id}","deployments_url":"https://api.github.com/repos/rgayon/turbinia/deployments","created_at":"2018-08-29T16:03:21Z","updated_at":"2018-10-30T15:01:44Z","pushed_at":"2018-11-27T18:48:02Z","git_url":"git://github.com/rgayon/turbinia.git","ssh_url":"git@github.com:rgayon/turbinia.git","clone_url":"https://github.com/rgayon/turbinia.git","svn_url":"https://github.com/rgayon/turbinia","homepage":"","size":1358,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"267dffddad326f2bf441f6345ce4bb098244caab","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":42533053,"node_id":"MDEwOlJlcG9zaXRvcnk0MjUzMzA1Mw==","name":"turbinia","full_name":"google/turbinia","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/turbinia","description":"Automation and Scaling of Digital Forensics Tools","fork":false,"url":"https://api.github.com/repos/google/turbinia","forks_url":"https://api.github.com/repos/google/turbinia/forks","keys_url":"https://api.github.com/repos/google/turbinia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/turbinia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/turbinia/teams","hooks_url":"https://api.github.com/repos/google/turbinia/hooks","issue_events_url":"https://api.github.com/repos/google/turbinia/issues/events{/number}","events_url":"https://api.github.com/repos/google/turbinia/events","assignees_url":"https://api.github.com/repos/google/turbinia/assignees{/user}","branches_url":"https://api.github.com/repos/google/turbinia/branches{/branch}","tags_url":"https://api.github.com/repos/google/turbinia/tags","blobs_url":"https://api.github.com/repos/google/turbinia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/turbinia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/turbinia/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/turbinia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/turbinia/statuses/{sha}","languages_url":"https://api.github.com/repos/google/turbinia/languages","stargazers_url":"https://api.github.com/repos/google/turbinia/stargazers","contributors_url":"https://api.github.com/repos/google/turbinia/contributors","subscribers_url":"https://api.github.com/repos/google/turbinia/subscribers","subscription_url":"https://api.github.com/repos/google/turbinia/subscription","commits_url":"https://api.github.com/repos/google/turbinia/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/turbinia/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/turbinia/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/turbinia/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/turbinia/contents/{+path}","compare_url":"https://api.github.com/repos/google/turbinia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/turbinia/merges","archive_url":"https://api.github.com/repos/google/turbinia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/turbinia/downloads","issues_url":"https://api.github.com/repos/google/turbinia/issues{/number}","pulls_url":"https://api.github.com/repos/google/turbinia/pulls{/number}","milestones_url":"https://api.github.com/repos/google/turbinia/milestones{/number}","notifications_url":"https://api.github.com/repos/google/turbinia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/turbinia/labels{/name}","releases_url":"https://api.github.com/repos/google/turbinia/releases{/id}","deployments_url":"https://api.github.com/repos/google/turbinia/deployments","created_at":"2015-09-15T16:50:40Z","updated_at":"2018-12-05T01:13:11Z","pushed_at":"2018-12-05T01:13:09Z","git_url":"git://github.com/google/turbinia.git","ssh_url":"git@github.com:google/turbinia.git","clone_url":"https://github.com/google/turbinia.git","svn_url":"https://github.com/google/turbinia","homepage":"","size":1283,"stargazers_count":168,"watchers_count":168,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":69,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/turbinia/pulls/296"},"html":{"href":"https://github.com/google/turbinia/pull/296"},"issue":{"href":"https://api.github.com/repos/google/turbinia/issues/296"},"comments":{"href":"https://api.github.com/repos/google/turbinia/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/google/turbinia/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/google/turbinia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/turbinia/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/google/turbinia/statuses/fab2731abe62ae45b2cefbdbc204b8c2dc680004"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aarontp"}}