{"action":"created","issue":{"url":"https://api.github.com/repos/mvdan/sh/issues/241","repository_url":"https://api.github.com/repos/mvdan/sh","labels_url":"https://api.github.com/repos/mvdan/sh/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/mvdan/sh/issues/241/comments","events_url":"https://api.github.com/repos/mvdan/sh/issues/241/events","html_url":"https://github.com/mvdan/sh/issues/241","id":323524249,"number":241,"title":"Latest shfmt seems to have issues with the file in this issue","user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mvdan/sh/milestones/6","html_url":"https://github.com/mvdan/sh/milestone/6","labels_url":"https://api.github.com/repos/mvdan/sh/milestones/6/labels","id":3180717,"number":6,"title":"2.4","description":"","creator":{"login":"mvdan","id":3576549,"avatar_url":"https://avatars0.githubusercontent.com/u/3576549?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdan","html_url":"https://github.com/mvdan","followers_url":"https://api.github.com/users/mvdan/followers","following_url":"https://api.github.com/users/mvdan/following{/other_user}","gists_url":"https://api.github.com/users/mvdan/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdan/subscriptions","organizations_url":"https://api.github.com/users/mvdan/orgs","repos_url":"https://api.github.com/users/mvdan/repos","events_url":"https://api.github.com/users/mvdan/events{/privacy}","received_events_url":"https://api.github.com/users/mvdan/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2018-03-12T15:30:02Z","updated_at":"2018-05-16T10:44:16Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-05-16T08:47:11Z","updated_at":"2018-05-16T10:44:53Z","closed_at":"2018-05-16T10:44:16Z","author_association":"NONE","body":"This file in our project https://github.com/kubevirt/kubevirt/blob/5dceffde3bb24d7401931e235ca9a72e66865278/cluster/vagrant-openshift/setup_master.sh is reformatted if we use latest master (https://github.com/mvdan/sh/commit/f2ae3bece7944c04dc315ce767e09490bf277f87).\r\n\r\nThe diff after the format looks like this:\r\n\r\n```diff\r\ndiff --git a/cluster/vagrant-openshift/setup_master.sh b/cluster/vagrant-openshift/setup_master.sh\r\nindex 24479769..0e2c48bc 100644\r\n--- a/cluster/vagrant-openshift/setup_master.sh\r\n+++ b/cluster/vagrant-openshift/setup_master.sh\r\n@@ -29,9 +29,9 @@ sed -i '/host_key_checking/s/^#//g' /etc/ansible/ansible.cfg\r\n inv_nodes=\"\"\r\n IFS=. read ip1 ip2 ip3 ip4 <<<\"$master_ip\"\r\n for node in $(seq 0 $(($nodes - 1))); do\r\n-    node_ip=\"$ip1.$ip2.$ip3.$(($ip4 + node + 1))\"\r\n-    node_hostname=\"node$node openshift_node_labels=\\\"{'region': 'infra','zone': 'default'}\\\" openshift_ip=$node_ip\"\r\n-    inv_nodes=\"$inv_nodes$node_hostname\\n\"\r\n+       node_ip=\"$ip1.$ip2.$ip3.$(($ip4 + node + 1))\"\r\n+       node_hostname=\"node$node openshift_node_labels=\\\"{'region': 'infra','zone': 'default'}\\\" openshift_ip=$node_ip\"\r\n+       inv_nodes=\"$inv_nodes$node_hostname\\n\"\r\n done\r\n \r\n openshift_ansible_dir=\"/root/openshift-ansible\"\r\n@@ -43,6 +43,8 @@ git clone https://github.com/openshift/openshift-ansible.git $openshift_ansible_\r\n \r\n # Create ansible inventory file\r\n cat >$inventory_file <<EOF\r\n+\r\n+# Run OpenShift ansible playbook\r\n [OSEv3:children]\r\n masters\r\n nodes\r\n@@ -71,7 +73,6 @@ master openshift_node_labels=\"{'region': 'infra','zone': 'default'}\" openshift_s\r\n $inv_nodes\r\n EOF\r\n \r\n-# Run OpenShift ansible playbook\r\n ansible-playbook -i $inventory_file $openshift_ansible_dir/playbooks/deploy_cluster.yml\r\n \r\n # Create OpenShift user\r\n```\r\n\r\nEspecially that it moves  the comment around looks strange. Maybe it has issues with `<< EOF`?\r\n\r\nMoved back to `v2.3.0` and everything looks fine there."},"comment":{"url":"https://api.github.com/repos/mvdan/sh/issues/comments/389475809","html_url":"https://github.com/mvdan/sh/issues/241#issuecomment-389475809","issue_url":"https://api.github.com/repos/mvdan/sh/issues/241","id":389475809,"user":{"login":"mvdan","id":3576549,"avatar_url":"https://avatars0.githubusercontent.com/u/3576549?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdan","html_url":"https://github.com/mvdan","followers_url":"https://api.github.com/users/mvdan/followers","following_url":"https://api.github.com/users/mvdan/following{/other_user}","gists_url":"https://api.github.com/users/mvdan/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdan/subscriptions","organizations_url":"https://api.github.com/users/mvdan/orgs","repos_url":"https://api.github.com/users/mvdan/repos","events_url":"https://api.github.com/users/mvdan/events{/privacy}","received_events_url":"https://api.github.com/users/mvdan/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T10:44:53Z","updated_at":"2018-05-16T10:44:53Z","author_association":"OWNER","body":"The fix is live, so if you guys are happy with master, simply restarting CI should fix things."}}
{"actor":{"display_login":"mvdan"}}