{"action":"created","issue":{"url":"https://api.github.com/repos/vinyldns/vinyldns/issues/144","repository_url":"https://api.github.com/repos/vinyldns/vinyldns","labels_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/144/comments","events_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/144/events","html_url":"https://github.com/vinyldns/vinyldns/issues/144","id":354385417,"node_id":"MDU6SXNzdWUzNTQzODU0MTc=","number":144,"title":"Cleanup syntax and helpers in unit and integration tests","user":{"login":"pauljamescleary","id":17361753,"node_id":"MDQ6VXNlcjE3MzYxNzUz","avatar_url":"https://avatars2.githubusercontent.com/u/17361753?v=4","gravatar_id":"","url":"https://api.github.com/users/pauljamescleary","html_url":"https://github.com/pauljamescleary","followers_url":"https://api.github.com/users/pauljamescleary/followers","following_url":"https://api.github.com/users/pauljamescleary/following{/other_user}","gists_url":"https://api.github.com/users/pauljamescleary/gists{/gist_id}","starred_url":"https://api.github.com/users/pauljamescleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauljamescleary/subscriptions","organizations_url":"https://api.github.com/users/pauljamescleary/orgs","repos_url":"https://api.github.com/users/pauljamescleary/repos","events_url":"https://api.github.com/users/pauljamescleary/events{/privacy}","received_events_url":"https://api.github.com/users/pauljamescleary/received_events","type":"User","site_admin":false},"labels":[{"id":1005945218,"node_id":"MDU6TGFiZWwxMDA1OTQ1MjE4","url":"https://api.github.com/repos/vinyldns/vinyldns/labels/help%20wanted","name":"help wanted","color":"008672","default":true},{"id":1007605612,"node_id":"MDU6TGFiZWwxMDA3NjA1NjEy","url":"https://api.github.com/repos/vinyldns/vinyldns/labels/maintenance","name":"maintenance","color":"186ace","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-27T16:22:48Z","updated_at":"2018-09-12T14:29:31Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Motivation**\r\nThe unit and integration tests heavily use `whenReady`, `CatsHelpers`, and `AkkaTestJawn`.  `CatsHelpers` and `AkkaTestJawn` overlap in functionality.  `whenReady` is no longer useful since we are using `IO` instead of `Future`.\r\n\r\n**Scope of change**\r\nMost of these can use `EitherMatchers` and `EitherValues`.  In addition, we should create our own custom scalatest matchers around `IO`, and delete the `AkkaTestJawn` and `CatsHelpers`.\r\n\r\nLook at https://github.com/IronCoreLabs/cats-scalatest\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/vinyldns/vinyldns/issues/comments/420669544","html_url":"https://github.com/vinyldns/vinyldns/issues/144#issuecomment-420669544","issue_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/144","id":420669544,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDY2OTU0NA==","user":{"login":"rebstar6","id":4467125,"node_id":"MDQ6VXNlcjQ0NjcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4467125?v=4","gravatar_id":"","url":"https://api.github.com/users/rebstar6","html_url":"https://github.com/rebstar6","followers_url":"https://api.github.com/users/rebstar6/followers","following_url":"https://api.github.com/users/rebstar6/following{/other_user}","gists_url":"https://api.github.com/users/rebstar6/gists{/gist_id}","starred_url":"https://api.github.com/users/rebstar6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebstar6/subscriptions","organizations_url":"https://api.github.com/users/rebstar6/orgs","repos_url":"https://api.github.com/users/rebstar6/repos","events_url":"https://api.github.com/users/rebstar6/events{/privacy}","received_events_url":"https://api.github.com/users/rebstar6/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T14:29:31Z","updated_at":"2018-09-12T14:29:31Z","author_association":"CONTRIBUTOR","body":"note also, in a lot of cases, we are doing something like:\r\n```\r\nval result = IO[something].unsafeToFuture()\r\nwhenReady(result, timeout) { x => x shouldBe y }\r\n```\r\nWe can cut out ^^ (and remove the reliance on ScalaFutures) and just make this\r\n```\r\nval result = IO[something].unsafeRunSync()\r\nresult shouldBe y \r\n```"}}
{"actor":{"display_login":"rebstar6"}}