{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/178361210","pull_request_review_id":108414810,"id":178361210,"diff_hunk":"@@ -272,17 +272,26 @@ func (vm *VirtualMachine) DeleteExceptDisks(ctx context.Context) (*types.TaskInf\n \n \top := trace.FromContext(ctx, \"DeleteExceptDisks\")\n \n+\top.Debugf(\"Getting list of the devices for VM %s\", vm)\n \tdevices, err := vm.Device(op)\n \tif err != nil {\n \t\treturn nil, err\n \t}\n \n \tdisks := devices.SelectByType(&types.VirtualDisk{})\n-\terr = vm.RemoveDevice(op, true, disks...)\n+\top.Debug(\"Removing devices for VM\")\n+\n+\terr = retry.Do(func() error {\n+\t\treturn vm.RemoveDevice(op, true, disks...)\n+\t}, func(err error) bool {\n+\t\treturn tasks.IsRetryError(op, err)","path":"pkg/vsphere/vm/vm.go","position":17,"original_position":17,"commit_id":"efef590afc59661ccc82a68c55b633060a8ad105","original_commit_id":"efef590afc59661ccc82a68c55b633060a8ad105","user":{"login":"zjs","id":408880,"avatar_url":"https://avatars2.githubusercontent.com/u/408880?v=4","gravatar_id":"","url":"https://api.github.com/users/zjs","html_url":"https://github.com/zjs","followers_url":"https://api.github.com/users/zjs/followers","following_url":"https://api.github.com/users/zjs/following{/other_user}","gists_url":"https://api.github.com/users/zjs/gists{/gist_id}","starred_url":"https://api.github.com/users/zjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjs/subscriptions","organizations_url":"https://api.github.com/users/zjs/orgs","repos_url":"https://api.github.com/users/zjs/repos","events_url":"https://api.github.com/users/zjs/events{/privacy}","received_events_url":"https://api.github.com/users/zjs/received_events","type":"User","site_admin":false},"body":"Are we confident that we actually want to retry in all of these cases? Do we want to put any sort of bounding on this retry porcess? `tasks.IsRetryError` is really aggressive, in ways I'm not sure it should be (e.g., it retries things like `InvalidArgument` errors).","created_at":"2018-03-30T19:40:45Z","updated_at":"2018-03-30T19:47:14Z","html_url":"https://github.com/vmware/vic/pull/7615#discussion_r178361210","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/7615","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/178361210"},"html":{"href":"https://github.com/vmware/vic/pull/7615#discussion_r178361210"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/7615"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/7615","id":178619775,"html_url":"https://github.com/vmware/vic/pull/7615","diff_url":"https://github.com/vmware/vic/pull/7615.diff","patch_url":"https://github.com/vmware/vic/pull/7615.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/7615","number":7615,"state":"open","locked":false,"title":"Added more logs and retry operation for VM config change.","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars2.githubusercontent.com/u/4350891?v=4","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"body":"Might resolve #7569\r\nBug will be closed individually if problem is actually solved.\r\n","created_at":"2018-03-30T19:23:52Z","updated_at":"2018-03-30T19:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23d37f7e0a844c2a5cfb3c1906d13c2427b44e09","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hickeng","id":3923729,"avatar_url":"https://avatars1.githubusercontent.com/u/3923729?v=4","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":353174341,"url":"https://api.github.com/repos/vmware/vic/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/7615/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/7615/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/7615/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/efef590afc59661ccc82a68c55b633060a8ad105","head":{"label":"vburenin:7569-logs","ref":"7569-logs","sha":"efef590afc59661ccc82a68c55b633060a8ad105","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars2.githubusercontent.com/u/4350891?v=4","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"repo":{"id":70089932,"name":"vic","full_name":"vburenin/vic","owner":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars2.githubusercontent.com/u/4350891?v=4","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vburenin/vic","description":"Integrated containers engine on vSphere","fork":true,"url":"https://api.github.com/repos/vburenin/vic","forks_url":"https://api.github.com/repos/vburenin/vic/forks","keys_url":"https://api.github.com/repos/vburenin/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vburenin/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vburenin/vic/teams","hooks_url":"https://api.github.com/repos/vburenin/vic/hooks","issue_events_url":"https://api.github.com/repos/vburenin/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vburenin/vic/events","assignees_url":"https://api.github.com/repos/vburenin/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vburenin/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vburenin/vic/tags","blobs_url":"https://api.github.com/repos/vburenin/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vburenin/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vburenin/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vburenin/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vburenin/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vburenin/vic/languages","stargazers_url":"https://api.github.com/repos/vburenin/vic/stargazers","contributors_url":"https://api.github.com/repos/vburenin/vic/contributors","subscribers_url":"https://api.github.com/repos/vburenin/vic/subscribers","subscription_url":"https://api.github.com/repos/vburenin/vic/subscription","commits_url":"https://api.github.com/repos/vburenin/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vburenin/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vburenin/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vburenin/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vburenin/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vburenin/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vburenin/vic/merges","archive_url":"https://api.github.com/repos/vburenin/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vburenin/vic/downloads","issues_url":"https://api.github.com/repos/vburenin/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vburenin/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vburenin/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vburenin/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vburenin/vic/labels{/name}","releases_url":"https://api.github.com/repos/vburenin/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vburenin/vic/deployments","created_at":"2016-10-05T18:59:46Z","updated_at":"2016-10-05T18:59:49Z","pushed_at":"2018-03-30T19:19:57Z","git_url":"git://github.com/vburenin/vic.git","ssh_url":"git@github.com:vburenin/vic.git","clone_url":"https://github.com/vburenin/vic.git","svn_url":"https://github.com/vburenin/vic","homepage":"","size":91683,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"02a2fff885c020d925b29668ba9a5b46060714ab","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2018-03-30T17:22:30Z","pushed_at":"2018-03-30T19:28:23Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":96381,"stargazers_count":315,"watchers_count":315,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":1013,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":125,"open_issues":1013,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/7615"},"html":{"href":"https://github.com/vmware/vic/pull/7615"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/7615"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/7615/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/7615/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/7615/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/efef590afc59661ccc82a68c55b633060a8ad105"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zjs"}}