{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/utils/pulls/comments/183965202","pull_request_review_id":115063659,"id":183965202,"diff_hunk":"@@ -107,20 +108,18 @@ BOOST_FIXTURE_TEST_CASE(should_not_copy_value_object_when_queried, MapFindFixtur\n         const string str;\n         NonCopyable(const string & str): str(str) {};\n \n-        /// We remove the copy semantic to make sure objects are not duplicated along the way\n-        NonCopyable(const NonCopyable &) = delete;\n-        NonCopyable& operator=(const NonCopyable &) = delete;\n-\n         /// we only keep the move construction semantic to emplace into the map\n         NonCopyable(NonCopyable && rhs): str(std::move(rhs.str)) {};\n         NonCopyable& operator=(NonCopyable && rhs) = delete;\n \n+    private:\n+        BOOST_MOVABLE_BUT_NOT_COPYABLE(NonCopyable)\n     };\n \n     std::map<int, NonCopyable> non_cop_map;\n-    non_cop_map.emplace( 1, string(\"one\"));\n-    non_cop_map.emplace( 2, string(\"two\"));\n-    non_cop_map.emplace( 3, string(\"three\"));\n+    non_cop_map.insert( std::make_pair(1, NonCopyable(\"one\")) );\n+    non_cop_map.insert( std::make_pair(2, NonCopyable(\"two\")) );\n+    non_cop_map.insert( std::make_pair(3, NonCopyable(\"three\")) );","path":"tests/map_find_test.cpp","position":13,"original_position":30,"commit_id":"0f571a922018a3c0b1edd8d8400f1c5583a9c50f","original_commit_id":"5ea585225f9d29419e18a882d8820bff9f0b359e","user":{"login":"benoit-bst","id":32099204,"avatar_url":"https://avatars0.githubusercontent.com/u/32099204?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-bst","html_url":"https://github.com/benoit-bst","followers_url":"https://api.github.com/users/benoit-bst/followers","following_url":"https://api.github.com/users/benoit-bst/following{/other_user}","gists_url":"https://api.github.com/users/benoit-bst/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-bst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-bst/subscriptions","organizations_url":"https://api.github.com/users/benoit-bst/orgs","repos_url":"https://api.github.com/users/benoit-bst/repos","events_url":"https://api.github.com/users/benoit-bst/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-bst/received_events","type":"User","site_admin":false},"body":":smiley: ","created_at":"2018-04-25T07:40:53Z","updated_at":"2018-04-25T07:40:53Z","html_url":"https://github.com/CanalTP/utils/pull/61#discussion_r183965202","pull_request_url":"https://api.github.com/repos/CanalTP/utils/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/comments/183965202"},"html":{"href":"https://github.com/CanalTP/utils/pull/61#discussion_r183965202"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/61"}},"in_reply_to_id":183762422},"pull_request":{"url":"https://api.github.com/repos/CanalTP/utils/pulls/61","id":183759659,"html_url":"https://github.com/CanalTP/utils/pull/61","diff_url":"https://github.com/CanalTP/utils/pull/61.diff","patch_url":"https://github.com/CanalTP/utils/pull/61.patch","issue_url":"https://api.github.com/repos/CanalTP/utils/issues/61","number":61,"state":"closed","locked":false,"title":"Fix MapFind for Debian 7","user":{"login":"nonifier","id":13467895,"avatar_url":"https://avatars0.githubusercontent.com/u/13467895?v=4","gravatar_id":"","url":"https://api.github.com/users/nonifier","html_url":"https://github.com/nonifier","followers_url":"https://api.github.com/users/nonifier/followers","following_url":"https://api.github.com/users/nonifier/following{/other_user}","gists_url":"https://api.github.com/users/nonifier/gists{/gist_id}","starred_url":"https://api.github.com/users/nonifier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonifier/subscriptions","organizations_url":"https://api.github.com/users/nonifier/orgs","repos_url":"https://api.github.com/users/nonifier/repos","events_url":"https://api.github.com/users/nonifier/events{/privacy}","received_events_url":"https://api.github.com/users/nonifier/received_events","type":"User","site_admin":false},"body":"Replace map::emplace() not supported on Debian 7  with insert+move semantic","created_at":"2018-04-24T14:39:35Z","updated_at":"2018-04-25T07:40:53Z","closed_at":"2018-04-24T16:29:42Z","merged_at":"2018-04-24T16:29:42Z","merge_commit_sha":"bc579a704b1951585382b627df3bc918184622bc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xlqian","id":6093486,"avatar_url":"https://avatars2.githubusercontent.com/u/6093486?v=4","gravatar_id":"","url":"https://api.github.com/users/xlqian","html_url":"https://github.com/xlqian","followers_url":"https://api.github.com/users/xlqian/followers","following_url":"https://api.github.com/users/xlqian/following{/other_user}","gists_url":"https://api.github.com/users/xlqian/gists{/gist_id}","starred_url":"https://api.github.com/users/xlqian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlqian/subscriptions","organizations_url":"https://api.github.com/users/xlqian/orgs","repos_url":"https://api.github.com/users/xlqian/repos","events_url":"https://api.github.com/users/xlqian/events{/privacy}","received_events_url":"https://api.github.com/users/xlqian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/utils/pulls/61/commits","review_comments_url":"https://api.github.com/repos/CanalTP/utils/pulls/61/comments","review_comment_url":"https://api.github.com/repos/CanalTP/utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/utils/issues/61/comments","statuses_url":"https://api.github.com/repos/CanalTP/utils/statuses/0f571a922018a3c0b1edd8d8400f1c5583a9c50f","head":{"label":"CanalTP:fix_MapFind_debian7","ref":"fix_MapFind_debian7","sha":"0f571a922018a3c0b1edd8d8400f1c5583a9c50f","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797373,"name":"utils","full_name":"CanalTP/utils","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/utils","description":null,"fork":false,"url":"https://api.github.com/repos/CanalTP/utils","forks_url":"https://api.github.com/repos/CanalTP/utils/forks","keys_url":"https://api.github.com/repos/CanalTP/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/utils/teams","hooks_url":"https://api.github.com/repos/CanalTP/utils/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/utils/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/utils/events","assignees_url":"https://api.github.com/repos/CanalTP/utils/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/utils/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/utils/tags","blobs_url":"https://api.github.com/repos/CanalTP/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/utils/languages","stargazers_url":"https://api.github.com/repos/CanalTP/utils/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/utils/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/utils/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/utils/subscription","commits_url":"https://api.github.com/repos/CanalTP/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/utils/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/utils/merges","archive_url":"https://api.github.com/repos/CanalTP/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/utils/downloads","issues_url":"https://api.github.com/repos/CanalTP/utils/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/utils/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/utils/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/utils/deployments","created_at":"2013-06-19T15:35:44Z","updated_at":"2018-04-24T16:29:44Z","pushed_at":"2018-04-24T16:29:43Z","git_url":"git://github.com/CanalTP/utils.git","ssh_url":"git@github.com:CanalTP/utils.git","clone_url":"https://github.com/CanalTP/utils.git","svn_url":"https://github.com/CanalTP/utils","homepage":null,"size":235,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":7,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CanalTP:master","ref":"master","sha":"f41a4878fd9968e28045146f3742260be08dd60a","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797373,"name":"utils","full_name":"CanalTP/utils","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/utils","description":null,"fork":false,"url":"https://api.github.com/repos/CanalTP/utils","forks_url":"https://api.github.com/repos/CanalTP/utils/forks","keys_url":"https://api.github.com/repos/CanalTP/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/utils/teams","hooks_url":"https://api.github.com/repos/CanalTP/utils/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/utils/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/utils/events","assignees_url":"https://api.github.com/repos/CanalTP/utils/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/utils/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/utils/tags","blobs_url":"https://api.github.com/repos/CanalTP/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/utils/languages","stargazers_url":"https://api.github.com/repos/CanalTP/utils/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/utils/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/utils/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/utils/subscription","commits_url":"https://api.github.com/repos/CanalTP/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/utils/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/utils/merges","archive_url":"https://api.github.com/repos/CanalTP/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/utils/downloads","issues_url":"https://api.github.com/repos/CanalTP/utils/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/utils/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/utils/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/utils/deployments","created_at":"2013-06-19T15:35:44Z","updated_at":"2018-04-24T16:29:44Z","pushed_at":"2018-04-24T16:29:43Z","git_url":"git://github.com/CanalTP/utils.git","ssh_url":"git@github.com:CanalTP/utils.git","clone_url":"https://github.com/CanalTP/utils.git","svn_url":"https://github.com/CanalTP/utils","homepage":null,"size":235,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":7,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/61"},"html":{"href":"https://github.com/CanalTP/utils/pull/61"},"issue":{"href":"https://api.github.com/repos/CanalTP/utils/issues/61"},"comments":{"href":"https://api.github.com/repos/CanalTP/utils/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/utils/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/utils/statuses/0f571a922018a3c0b1edd8d8400f1c5583a9c50f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benoit-bst"}}