{"action":"created","comment":{"url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/comments/226243273","pull_request_review_id":166014757,"id":226243273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI0MzI3Mw==","diff_hunk":"@@ -196,7 +196,7 @@ public function getAllQueues()\n     private function getVisitorIdFromRequest(Tracker\\Request $request)\n     {\n         try {\n-            $visitorId = $request->getVisitorId();\n+            $visitorId = $request->getVisitorIdForThirdPartyCookie();","path":"Queue/Manager.php","position":5,"original_position":5,"commit_id":"e0b56c87f3bb6a18d04a7ba133528fd2a338c91e","original_commit_id":"e0b56c87f3bb6a18d04a7ba133528fd2a338c91e","user":{"login":"MichaelHeerklotz","id":609117,"node_id":"MDQ6VXNlcjYwOTExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/609117?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelHeerklotz","html_url":"https://github.com/MichaelHeerklotz","followers_url":"https://api.github.com/users/MichaelHeerklotz/followers","following_url":"https://api.github.com/users/MichaelHeerklotz/following{/other_user}","gists_url":"https://api.github.com/users/MichaelHeerklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelHeerklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelHeerklotz/subscriptions","organizations_url":"https://api.github.com/users/MichaelHeerklotz/orgs","repos_url":"https://api.github.com/users/MichaelHeerklotz/repos","events_url":"https://api.github.com/users/MichaelHeerklotz/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelHeerklotz/received_events","type":"User","site_admin":false},"body":"good point, however, we already call it here\r\nhttps://github.com/matomo-org/plugin-QueuedTracking/blob/50df72a1fb3fbf4ccdc53fb0cfd9deb1cfdc969a/Tracker/Handler.php#L47\r\nso it should make no difference, I think","created_at":"2018-10-18T09:57:49Z","updated_at":"2018-10-18T09:57:50Z","html_url":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87#discussion_r226243273","pull_request_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/comments/226243273"},"html":{"href":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87#discussion_r226243273"},"pull_request":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87"}},"in_reply_to_id":226059964},"pull_request":{"url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87","id":223481142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDgxMTQy","html_url":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87","diff_url":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87.diff","patch_url":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87.patch","issue_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/87","number":87,"state":"open","locked":false,"title":"Replaced getVisitorId() with getVisitorIdForThirdPartyCookie()","user":{"login":"MichaelHeerklotz","id":609117,"node_id":"MDQ6VXNlcjYwOTExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/609117?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelHeerklotz","html_url":"https://github.com/MichaelHeerklotz","followers_url":"https://api.github.com/users/MichaelHeerklotz/followers","following_url":"https://api.github.com/users/MichaelHeerklotz/following{/other_user}","gists_url":"https://api.github.com/users/MichaelHeerklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelHeerklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelHeerklotz/subscriptions","organizations_url":"https://api.github.com/users/MichaelHeerklotz/orgs","repos_url":"https://api.github.com/users/MichaelHeerklotz/repos","events_url":"https://api.github.com/users/MichaelHeerklotz/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelHeerklotz/received_events","type":"User","site_admin":false},"body":"getVisitorId() may cause (sometimes) a db connection if my pull request gets accepted ( https://github.com/matomo-org/matomo/pull/13620 ).\r\n\r\nTo avoid this db connection when using QueuedTracking, this pr replaces the call to getVisitorId() with getVisitorIdForThirdPartyCookie(). The visitiorId is only used to determine into which queue the request gets inserted, so it does not really matter \"which\" idVisitor value we use. The call to getVisitorIdForThirdPartyCookie() will never cause a db connection.","created_at":"2018-10-17T06:21:32Z","updated_at":"2018-10-18T09:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975a1ffb6767ea5d3694731cd89c5788706b6ce9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87/commits","review_comments_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87/comments","review_comment_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/87/comments","statuses_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/statuses/e0b56c87f3bb6a18d04a7ba133528fd2a338c91e","head":{"label":"MichaelHeerklotz:add_link_userid_to_visitorid_site_setting","ref":"add_link_userid_to_visitorid_site_setting","sha":"e0b56c87f3bb6a18d04a7ba133528fd2a338c91e","user":{"login":"MichaelHeerklotz","id":609117,"node_id":"MDQ6VXNlcjYwOTExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/609117?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelHeerklotz","html_url":"https://github.com/MichaelHeerklotz","followers_url":"https://api.github.com/users/MichaelHeerklotz/followers","following_url":"https://api.github.com/users/MichaelHeerklotz/following{/other_user}","gists_url":"https://api.github.com/users/MichaelHeerklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelHeerklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelHeerklotz/subscriptions","organizations_url":"https://api.github.com/users/MichaelHeerklotz/orgs","repos_url":"https://api.github.com/users/MichaelHeerklotz/repos","events_url":"https://api.github.com/users/MichaelHeerklotz/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelHeerklotz/received_events","type":"User","site_admin":false},"repo":{"id":93511399,"node_id":"MDEwOlJlcG9zaXRvcnk5MzUxMTM5OQ==","name":"plugin-QueuedTracking","full_name":"MichaelHeerklotz/plugin-QueuedTracking","private":false,"owner":{"login":"MichaelHeerklotz","id":609117,"node_id":"MDQ6VXNlcjYwOTExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/609117?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelHeerklotz","html_url":"https://github.com/MichaelHeerklotz","followers_url":"https://api.github.com/users/MichaelHeerklotz/followers","following_url":"https://api.github.com/users/MichaelHeerklotz/following{/other_user}","gists_url":"https://api.github.com/users/MichaelHeerklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelHeerklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelHeerklotz/subscriptions","organizations_url":"https://api.github.com/users/MichaelHeerklotz/orgs","repos_url":"https://api.github.com/users/MichaelHeerklotz/repos","events_url":"https://api.github.com/users/MichaelHeerklotz/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelHeerklotz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MichaelHeerklotz/plugin-QueuedTracking","description":"Scale your large traffic Piwik service by queuing tracking requests in Redis for better performance.","fork":true,"url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking","forks_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/forks","keys_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/teams","hooks_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/hooks","issue_events_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/issues/events{/number}","events_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/events","assignees_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/assignees{/user}","branches_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/branches{/branch}","tags_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/tags","blobs_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/statuses/{sha}","languages_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/languages","stargazers_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/stargazers","contributors_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/contributors","subscribers_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/subscribers","subscription_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/subscription","commits_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/contents/{+path}","compare_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/merges","archive_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/downloads","issues_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/issues{/number}","pulls_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/pulls{/number}","milestones_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/milestones{/number}","notifications_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/labels{/name}","releases_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/releases{/id}","deployments_url":"https://api.github.com/repos/MichaelHeerklotz/plugin-QueuedTracking/deployments","created_at":"2017-06-06T11:35:53Z","updated_at":"2017-06-06T11:35:54Z","pushed_at":"2018-10-17T06:18:11Z","git_url":"git://github.com/MichaelHeerklotz/plugin-QueuedTracking.git","ssh_url":"git@github.com:MichaelHeerklotz/plugin-QueuedTracking.git","clone_url":"https://github.com/MichaelHeerklotz/plugin-QueuedTracking.git","svn_url":"https://github.com/MichaelHeerklotz/plugin-QueuedTracking","homepage":"http://piwik.org","size":4749,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matomo-org:master","ref":"master","sha":"413a23e2a4378e6445c3c14698bab8e2e921905c","user":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"repo":{"id":27516641,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUxNjY0MQ==","name":"plugin-QueuedTracking","full_name":"matomo-org/plugin-QueuedTracking","private":false,"owner":{"login":"matomo-org","id":698038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5ODAzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698038?v=4","gravatar_id":"","url":"https://api.github.com/users/matomo-org","html_url":"https://github.com/matomo-org","followers_url":"https://api.github.com/users/matomo-org/followers","following_url":"https://api.github.com/users/matomo-org/following{/other_user}","gists_url":"https://api.github.com/users/matomo-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matomo-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matomo-org/subscriptions","organizations_url":"https://api.github.com/users/matomo-org/orgs","repos_url":"https://api.github.com/users/matomo-org/repos","events_url":"https://api.github.com/users/matomo-org/events{/privacy}","received_events_url":"https://api.github.com/users/matomo-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matomo-org/plugin-QueuedTracking","description":"Scale your large traffic Matomo service by queuing tracking requests (in Redis or MySQL) for better performance.","fork":false,"url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking","forks_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/forks","keys_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/teams","hooks_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/hooks","issue_events_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/events{/number}","events_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/events","assignees_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/assignees{/user}","branches_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/branches{/branch}","tags_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/tags","blobs_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/git/refs{/sha}","trees_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/statuses/{sha}","languages_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/languages","stargazers_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/stargazers","contributors_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/contributors","subscribers_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/subscribers","subscription_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/subscription","commits_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/commits{/sha}","git_commits_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/git/commits{/sha}","comments_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/comments{/number}","issue_comment_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/comments{/number}","contents_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/contents/{+path}","compare_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/merges","archive_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/downloads","issues_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues{/number}","pulls_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls{/number}","milestones_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/milestones{/number}","notifications_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/labels{/name}","releases_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/releases{/id}","deployments_url":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/deployments","created_at":"2014-12-04T01:20:05Z","updated_at":"2018-10-09T08:40:50Z","pushed_at":"2018-10-17T06:21:33Z","git_url":"git://github.com/matomo-org/plugin-QueuedTracking.git","ssh_url":"git@github.com:matomo-org/plugin-QueuedTracking.git","clone_url":"https://github.com/matomo-org/plugin-QueuedTracking.git","svn_url":"https://github.com/matomo-org/plugin-QueuedTracking","homepage":"https://matomo.org","size":5340,"stargazers_count":43,"watchers_count":43,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":17,"open_issues":16,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87"},"html":{"href":"https://github.com/matomo-org/plugin-QueuedTracking/pull/87"},"issue":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/87"},"comments":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/matomo-org/plugin-QueuedTracking/statuses/e0b56c87f3bb6a18d04a7ba133528fd2a338c91e"}},"author_association":"NONE"}}
{"actor":{"display_login":"MichaelHeerklotz"}}