{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/229619983","pull_request_review_id":170152333,"id":229619983,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTYxOTk4Mw==","diff_hunk":"@@ -0,0 +1,75 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.tests;\n+\n+import com.facebook.presto.testing.MaterializedResult;\n+import org.testng.annotations.Test;\n+\n+import java.sql.SQLException;\n+\n+import static com.facebook.presto.testing.assertions.Assert.assertEquals;\n+import static org.testng.Assert.assertNotNull;\n+\n+public abstract class AbstractTestIntegrationJdbcSmokeTest\n+        extends AbstractTestIntegrationSmokeTest\n+{\n+    protected AbstractTestIntegrationJdbcSmokeTest(QueryRunnerSupplier supplier)\n+    {\n+        super(supplier);\n+    }\n+\n+    @Test\n+    public void testShowCreateTable()\n+            throws SQLException\n+    {\n+        try {\n+            String catalog = getSession().getCatalog().get();\n+            assertUpdate(\"CREATE TABLE test_show_create (\" +\n+                    \"column_a DATE,\" +\n+                    \"column_b DATE NOT NULL\" +\n+                    \")\");\n+            MaterializedResult materializedRows = computeActual(\"SHOW CREATE TABLE tpch.test_show_create\");","path":"presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestIntegrationJdbcSmokeTest.java","position":42,"original_position":42,"commit_id":"d5a42ee6e91b0b2ca5ce860f2958371a653f7c8d","original_commit_id":"d5a42ee6e91b0b2ca5ce860f2958371a653f7c8d","user":{"login":"kokosing","id":7569403,"node_id":"MDQ6VXNlcjc1Njk0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"body":"can you use `assertQuery(\"SHOW...\", \"VALUES 'CREATE TABLE...\")`?","created_at":"2018-10-31T09:36:55Z","updated_at":"2018-10-31T09:38:38Z","html_url":"https://github.com/prestodb/presto/pull/11561#discussion_r229619983","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11561","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/229619983"},"html":{"href":"https://github.com/prestodb/presto/pull/11561#discussion_r229619983"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11561"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11561","id":217714570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzE0NTcw","html_url":"https://github.com/prestodb/presto/pull/11561","diff_url":"https://github.com/prestodb/presto/pull/11561.diff","patch_url":"https://github.com/prestodb/presto/pull/11561.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11561","number":11561,"state":"open","locked":false,"title":"Adding support for NOT NULL in DDL","user":{"login":"tdcmeehan","id":7980573,"node_id":"MDQ6VXNlcjc5ODA1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7980573?v=4","gravatar_id":"","url":"https://api.github.com/users/tdcmeehan","html_url":"https://github.com/tdcmeehan","followers_url":"https://api.github.com/users/tdcmeehan/followers","following_url":"https://api.github.com/users/tdcmeehan/following{/other_user}","gists_url":"https://api.github.com/users/tdcmeehan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdcmeehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdcmeehan/subscriptions","organizations_url":"https://api.github.com/users/tdcmeehan/orgs","repos_url":"https://api.github.com/users/tdcmeehan/repos","events_url":"https://api.github.com/users/tdcmeehan/events{/privacy}","received_events_url":"https://api.github.com/users/tdcmeehan/received_events","type":"User","site_admin":false},"body":"Split out from #11490\r\n\r\n* Introduce support for `NOT NULL` in DDL.  Connectors can opt-in to this by turning on `ConnectorMetadata#supportsNotNullColumns`.\r\n* Add support for CREATE TABLE in JDBC connectors\r\n* Enable `NOT NULL` for JDBC connectors\r\n\r\n","created_at":"2018-09-24T16:26:43Z","updated_at":"2018-10-31T09:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24ce07e26a23702fb8b51359f73a51fd8dbc8a1c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"findepi","id":144328,"node_id":"MDQ6VXNlcjE0NDMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11561/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11561/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11561/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/d5a42ee6e91b0b2ca5ce860f2958371a653f7c8d","head":{"label":"tdcmeehan:nonnull","ref":"nonnull","sha":"d5a42ee6e91b0b2ca5ce860f2958371a653f7c8d","user":{"login":"tdcmeehan","id":7980573,"node_id":"MDQ6VXNlcjc5ODA1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7980573?v=4","gravatar_id":"","url":"https://api.github.com/users/tdcmeehan","html_url":"https://github.com/tdcmeehan","followers_url":"https://api.github.com/users/tdcmeehan/followers","following_url":"https://api.github.com/users/tdcmeehan/following{/other_user}","gists_url":"https://api.github.com/users/tdcmeehan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdcmeehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdcmeehan/subscriptions","organizations_url":"https://api.github.com/users/tdcmeehan/orgs","repos_url":"https://api.github.com/users/tdcmeehan/repos","events_url":"https://api.github.com/users/tdcmeehan/events{/privacy}","received_events_url":"https://api.github.com/users/tdcmeehan/received_events","type":"User","site_admin":false},"repo":{"id":142369435,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNjk0MzU=","name":"presto","full_name":"tdcmeehan/presto","private":false,"owner":{"login":"tdcmeehan","id":7980573,"node_id":"MDQ6VXNlcjc5ODA1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7980573?v=4","gravatar_id":"","url":"https://api.github.com/users/tdcmeehan","html_url":"https://github.com/tdcmeehan","followers_url":"https://api.github.com/users/tdcmeehan/followers","following_url":"https://api.github.com/users/tdcmeehan/following{/other_user}","gists_url":"https://api.github.com/users/tdcmeehan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdcmeehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdcmeehan/subscriptions","organizations_url":"https://api.github.com/users/tdcmeehan/orgs","repos_url":"https://api.github.com/users/tdcmeehan/repos","events_url":"https://api.github.com/users/tdcmeehan/events{/privacy}","received_events_url":"https://api.github.com/users/tdcmeehan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tdcmeehan/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/tdcmeehan/presto","forks_url":"https://api.github.com/repos/tdcmeehan/presto/forks","keys_url":"https://api.github.com/repos/tdcmeehan/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdcmeehan/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdcmeehan/presto/teams","hooks_url":"https://api.github.com/repos/tdcmeehan/presto/hooks","issue_events_url":"https://api.github.com/repos/tdcmeehan/presto/issues/events{/number}","events_url":"https://api.github.com/repos/tdcmeehan/presto/events","assignees_url":"https://api.github.com/repos/tdcmeehan/presto/assignees{/user}","branches_url":"https://api.github.com/repos/tdcmeehan/presto/branches{/branch}","tags_url":"https://api.github.com/repos/tdcmeehan/presto/tags","blobs_url":"https://api.github.com/repos/tdcmeehan/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdcmeehan/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdcmeehan/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdcmeehan/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdcmeehan/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/tdcmeehan/presto/languages","stargazers_url":"https://api.github.com/repos/tdcmeehan/presto/stargazers","contributors_url":"https://api.github.com/repos/tdcmeehan/presto/contributors","subscribers_url":"https://api.github.com/repos/tdcmeehan/presto/subscribers","subscription_url":"https://api.github.com/repos/tdcmeehan/presto/subscription","commits_url":"https://api.github.com/repos/tdcmeehan/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdcmeehan/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdcmeehan/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdcmeehan/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdcmeehan/presto/contents/{+path}","compare_url":"https://api.github.com/repos/tdcmeehan/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdcmeehan/presto/merges","archive_url":"https://api.github.com/repos/tdcmeehan/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdcmeehan/presto/downloads","issues_url":"https://api.github.com/repos/tdcmeehan/presto/issues{/number}","pulls_url":"https://api.github.com/repos/tdcmeehan/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/tdcmeehan/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/tdcmeehan/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdcmeehan/presto/labels{/name}","releases_url":"https://api.github.com/repos/tdcmeehan/presto/releases{/id}","deployments_url":"https://api.github.com/repos/tdcmeehan/presto/deployments","created_at":"2018-07-26T00:56:20Z","updated_at":"2018-09-06T16:33:49Z","pushed_at":"2018-10-26T22:39:33Z","git_url":"git://github.com/tdcmeehan/presto.git","ssh_url":"git@github.com:tdcmeehan/presto.git","clone_url":"https://github.com/tdcmeehan/presto.git","svn_url":"https://github.com/tdcmeehan/presto","homepage":"https://prestodb.io","size":100633,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"e7b4b41b46fa55fbfca1d14130f4dc886de65319","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-10-31T07:21:43Z","pushed_at":"2018-10-31T09:02:42Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":100922,"stargazers_count":8242,"watchers_count":8242,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2798,"mirror_url":null,"archived":false,"open_issues_count":1422,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2798,"open_issues":1422,"watchers":8242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11561"},"html":{"href":"https://github.com/prestodb/presto/pull/11561"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11561"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11561/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11561/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11561/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/d5a42ee6e91b0b2ca5ce860f2958371a653f7c8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kokosing"}}