{"action":"closed","issue":{"url":"https://api.github.com/repos/OmniSharp/csharp-language-server-protocol/issues/80","repository_url":"https://api.github.com/repos/OmniSharp/csharp-language-server-protocol","labels_url":"https://api.github.com/repos/OmniSharp/csharp-language-server-protocol/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/OmniSharp/csharp-language-server-protocol/issues/80/comments","events_url":"https://api.github.com/repos/OmniSharp/csharp-language-server-protocol/issues/80/events","html_url":"https://github.com/OmniSharp/csharp-language-server-protocol/issues/80","id":301741847,"number":80,"title":"Confused about handlers and registrations","user":{"login":"kalbj","id":36740299,"avatar_url":"https://avatars2.githubusercontent.com/u/36740299?v=4","gravatar_id":"","url":"https://api.github.com/users/kalbj","html_url":"https://github.com/kalbj","followers_url":"https://api.github.com/users/kalbj/followers","following_url":"https://api.github.com/users/kalbj/following{/other_user}","gists_url":"https://api.github.com/users/kalbj/gists{/gist_id}","starred_url":"https://api.github.com/users/kalbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalbj/subscriptions","organizations_url":"https://api.github.com/users/kalbj/orgs","repos_url":"https://api.github.com/users/kalbj/repos","events_url":"https://api.github.com/users/kalbj/events{/privacy}","received_events_url":"https://api.github.com/users/kalbj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-02T11:51:00Z","updated_at":"2018-05-18T16:15:17Z","closed_at":"2018-05-18T16:15:17Z","author_association":"NONE","body":"I'm trying to implement a prototype `IWorkspaceSymbolsHandler` in the sample server.\r\nThis interface implements `IRequestHandler` and `ICapability`, but unlike some of the other handlers, it doesn't implement `IRegistration`.\r\n\r\nWhen `LanguageServer.DynamicallyRegisterHandlers` runs, it ends up attempting to call `RegisterCapability` with a null registration for this handler, which causes an exception and the server to disconnect and shutdown.\r\n\r\nClearly i'm doing something wrong - any advice appreciated.\r\n\r\nThe `HandlerDescriptor` has `AllowsDynamicRegistration=true` and `HasRegistration=false`\r\n\r\nShould `DynamicallyRegisterHandlers` also be checking for `HasRegistration` to protect against this?\r\nhttps://github.com/OmniSharp/csharp-language-server-protocol/blob/fae86e0112914c43d279385114260792efd613b2/src/Server/LanguageServer.cs#L305-L308"}}
{"actor":{"display_login":"david-driscoll"}}