{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/202016540","pull_request_review_id":136627934,"id":202016540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjAxNjU0MA==","diff_hunk":"@@ -191,6 +191,9 @@ - (void)commonMDCBottomNavigationBarInit {\n                                      UIViewAutoresizingFlexibleRightMargin);\n   _containerView.clipsToBounds = YES;\n   [self addSubview:_containerView];\n+#if defined(__IPHONE_10_0) && (__IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_10_0)\n+  _containerView.accessibilityTraits = UIAccessibilityTraitTabBar;","path":"components/BottomNavigation/src/MDCBottomNavigationBar.m","position":5,"original_position":5,"commit_id":"caa6b9dd9e262efedd322137d69fcb6f175d9545","original_commit_id":"caa6b9dd9e262efedd322137d69fcb6f175d9545","user":{"login":"romoore","id":1753199,"node_id":"MDQ6VXNlcjE3NTMxOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"body":"I think we should allow this to be used on iOS 10+ today instead of waiting to drop iOS 9 support in Xcode.   Could we switch to something like this?\r\n\r\n```objc\r\n#if defined(__IPHONE_10_0) && (__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0)\r\nif (&UIAccessibilityTraitTabBar != NULL) {\r\n  _containerView.accessibilityTraits = UIAccessibilityTraitTabBar;\r\n}\r\n#endif\r\n```","created_at":"2018-07-12T12:32:01Z","updated_at":"2018-07-12T12:53:18Z","html_url":"https://github.com/material-components/material-components-ios/pull/4510#discussion_r202016540","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/202016540"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4510#discussion_r202016540"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510","id":200831973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODMxOTcz","html_url":"https://github.com/material-components/material-components-ios/pull/4510","diff_url":"https://github.com/material-components/material-components-ios/pull/4510.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/4510.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4510","number":4510,"state":"open","locked":false,"title":"[BottomNavigation] Give MDCBottomNavigationBar a TabBar accessibilityTrait","user":{"login":"andrewoverton","id":8020010,"node_id":"MDQ6VXNlcjgwMjAwMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8020010?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewoverton","html_url":"https://github.com/andrewoverton","followers_url":"https://api.github.com/users/andrewoverton/followers","following_url":"https://api.github.com/users/andrewoverton/following{/other_user}","gists_url":"https://api.github.com/users/andrewoverton/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewoverton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewoverton/subscriptions","organizations_url":"https://api.github.com/users/andrewoverton/orgs","repos_url":"https://api.github.com/users/andrewoverton/repos","events_url":"https://api.github.com/users/andrewoverton/events{/privacy}","received_events_url":"https://api.github.com/users/andrewoverton/received_events","type":"User","site_admin":false},"body":"Closes #4499 ","created_at":"2018-07-11T21:34:15Z","updated_at":"2018-07-12T12:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb65b40f0721da498794f24f353bfee0e1df1f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722853370,"node_id":"MDU6TGFiZWw3MjI4NTMzNzA=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[BottomNavigation]","name":"[BottomNavigation]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4510/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/caa6b9dd9e262efedd322137d69fcb6f175d9545","head":{"label":"andrewoverton:issue-4499","ref":"issue-4499","sha":"caa6b9dd9e262efedd322137d69fcb6f175d9545","user":{"login":"andrewoverton","id":8020010,"node_id":"MDQ6VXNlcjgwMjAwMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8020010?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewoverton","html_url":"https://github.com/andrewoverton","followers_url":"https://api.github.com/users/andrewoverton/followers","following_url":"https://api.github.com/users/andrewoverton/following{/other_user}","gists_url":"https://api.github.com/users/andrewoverton/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewoverton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewoverton/subscriptions","organizations_url":"https://api.github.com/users/andrewoverton/orgs","repos_url":"https://api.github.com/users/andrewoverton/repos","events_url":"https://api.github.com/users/andrewoverton/events{/privacy}","received_events_url":"https://api.github.com/users/andrewoverton/received_events","type":"User","site_admin":false},"repo":{"id":133371696,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNzE2OTY=","name":"material-components-ios","full_name":"andrewoverton/material-components-ios","owner":{"login":"andrewoverton","id":8020010,"node_id":"MDQ6VXNlcjgwMjAwMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/8020010?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewoverton","html_url":"https://github.com/andrewoverton","followers_url":"https://api.github.com/users/andrewoverton/followers","following_url":"https://api.github.com/users/andrewoverton/following{/other_user}","gists_url":"https://api.github.com/users/andrewoverton/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewoverton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewoverton/subscriptions","organizations_url":"https://api.github.com/users/andrewoverton/orgs","repos_url":"https://api.github.com/users/andrewoverton/repos","events_url":"https://api.github.com/users/andrewoverton/events{/privacy}","received_events_url":"https://api.github.com/users/andrewoverton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewoverton/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/andrewoverton/material-components-ios","forks_url":"https://api.github.com/repos/andrewoverton/material-components-ios/forks","keys_url":"https://api.github.com/repos/andrewoverton/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewoverton/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewoverton/material-components-ios/teams","hooks_url":"https://api.github.com/repos/andrewoverton/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/andrewoverton/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/andrewoverton/material-components-ios/events","assignees_url":"https://api.github.com/repos/andrewoverton/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/andrewoverton/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/andrewoverton/material-components-ios/tags","blobs_url":"https://api.github.com/repos/andrewoverton/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewoverton/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewoverton/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewoverton/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewoverton/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewoverton/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/andrewoverton/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/andrewoverton/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/andrewoverton/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/andrewoverton/material-components-ios/subscription","commits_url":"https://api.github.com/repos/andrewoverton/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewoverton/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewoverton/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewoverton/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewoverton/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/andrewoverton/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewoverton/material-components-ios/merges","archive_url":"https://api.github.com/repos/andrewoverton/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewoverton/material-components-ios/downloads","issues_url":"https://api.github.com/repos/andrewoverton/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/andrewoverton/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewoverton/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewoverton/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewoverton/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/andrewoverton/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/andrewoverton/material-components-ios/deployments","created_at":"2018-05-14T14:15:27Z","updated_at":"2018-07-11T17:30:39Z","pushed_at":"2018-07-11T21:50:46Z","git_url":"git://github.com/andrewoverton/material-components-ios.git","ssh_url":"git@github.com:andrewoverton/material-components-ios.git","clone_url":"https://github.com/andrewoverton/material-components-ios.git","svn_url":"https://github.com/andrewoverton/material-components-ios","homepage":"","size":114876,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"20445a5d8565070ac3f836363edcf6f41380066a","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-07-12T08:49:56Z","pushed_at":"2018-07-11T21:50:47Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":114773,"stargazers_count":2555,"watchers_count":2555,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":372,"mirror_url":null,"archived":false,"open_issues_count":993,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":372,"open_issues":993,"watchers":2555,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4510"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4510"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4510/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4510/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/caa6b9dd9e262efedd322137d69fcb6f175d9545"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"romoore"}}