{"action":"created","issue":{"url":"https://api.github.com/repos/alipay/sofa-mosn/issues/29","repository_url":"https://api.github.com/repos/alipay/sofa-mosn","labels_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/29/comments","events_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/29/events","html_url":"https://github.com/alipay/sofa-mosn/pull/29","id":342171916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTM0ODg4","number":29,"title":"fix style: move return statement from final else block","user":{"login":"Lingtaonju","id":19946268,"node_id":"MDQ6VXNlcjE5OTQ2MjY4","avatar_url":"https://avatars2.githubusercontent.com/u/19946268?v=4","gravatar_id":"","url":"https://api.github.com/users/Lingtaonju","html_url":"https://github.com/Lingtaonju","followers_url":"https://api.github.com/users/Lingtaonju/followers","following_url":"https://api.github.com/users/Lingtaonju/following{/other_user}","gists_url":"https://api.github.com/users/Lingtaonju/gists{/gist_id}","starred_url":"https://api.github.com/users/Lingtaonju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lingtaonju/subscriptions","organizations_url":"https://api.github.com/users/Lingtaonju/orgs","repos_url":"https://api.github.com/users/Lingtaonju/repos","events_url":"https://api.github.com/users/Lingtaonju/events{/privacy}","received_events_url":"https://api.github.com/users/Lingtaonju/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-18T04:24:26Z","updated_at":"2018-07-18T04:35:04Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/alipay/sofa-mosn/pulls/29","html_url":"https://github.com/alipay/sofa-mosn/pull/29","diff_url":"https://github.com/alipay/sofa-mosn/pull/29.diff","patch_url":"https://github.com/alipay/sofa-mosn/pull/29.patch"},"body":"修复\r\n\r\n4.if block ends with a return statement, so drop this else and outdent its block\r\n结尾的 else 中 有 return 的话单独提出来\r\n\r\n，不标准写法：\r\nfunc xxxx() xxx {\r\nif f.intercept {\r\nreturn types.FilterHeadersStatusStopIteration\r\n} else {\r\nreturn types.FilterHeadersStatusContinue\r\n}\r\n}\r\n// -> 标准写法\r\n\r\nfunc xxxx() xxx {\r\nif f.intercept {\r\nreturn types.FilterHeadersStatusStopIteration\r\n}\r\nreturn types.FilterHeadersStatusContinue\r\n}"},"comment":{"url":"https://api.github.com/repos/alipay/sofa-mosn/issues/comments/405805955","html_url":"https://github.com/alipay/sofa-mosn/pull/29#issuecomment-405805955","issue_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/29","id":405805955,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTgwNTk1NQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T04:35:04Z","updated_at":"2018-07-18T04:35:04Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=h1) Report\n> Merging [#29](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=desc) into [master](https://codecov.io/gh/alipay/sofa-mosn/commit/d4ace285cf5a7edfe313ae6f2154f7f2122bec2a?src=pr&el=desc) will **increase** coverage by `0.09%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/alipay/sofa-mosn/pull/29/graphs/tree.svg?src=pr&token=o0ua4ib09v&width=650&height=150)](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #29      +/-   ##\n==========================================\n+ Coverage   17.56%   17.66%   +0.09%     \n==========================================\n  Files          41       41              \n  Lines        3575     3555      -20     \n==========================================\n  Hits          628      628              \n+ Misses       2918     2899      -19     \n+ Partials       29       28       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pkg/router/configutility.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL3JvdXRlci9jb25maWd1dGlsaXR5Lmdv) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/upstream/healthcheck/healthchecker.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL3Vwc3RyZWFtL2hlYWx0aGNoZWNrL2hlYWx0aGNoZWNrZXIuZ28=) | `78.03% <0%> (+0.58%)` | :arrow_up: |\n| [pkg/config/convertxds.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb252ZXJ0eGRzLmdv) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/config/config.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `12% <0%> (+0.46%)` | :arrow_up: |\n| [pkg/router/routeruleimpl.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL3JvdXRlci9yb3V0ZXJ1bGVpbXBsLmdv) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/router/factory.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL3JvdXRlci9mYWN0b3J5Lmdv) | `55.55% <0%> (+5.55%)` | :arrow_up: |\n| [pkg/upstream/cluster/clustermanager.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL3Vwc3RyZWFtL2NsdXN0ZXIvY2x1c3Rlcm1hbmFnZXIuZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/network/buffer/iobuffer.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL25ldHdvcmsvYnVmZmVyL2lvYnVmZmVyLmdv) | `4.18% <0%> (+0.04%)` | :arrow_up: |\n| [pkg/config/parser.go](https://codecov.io/gh/alipay/sofa-mosn/pull/29/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9wYXJzZXIuZ28=) | `3.32% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=footer). Last update [d4ace28...708ae14](https://codecov.io/gh/alipay/sofa-mosn/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}