{"action":"created","issue":{"url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/75","repository_url":"https://api.github.com/repos/queryverse/IterableTables.jl","labels_url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/75/comments","events_url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/75/events","html_url":"https://github.com/queryverse/IterableTables.jl/issues/75","id":315722780,"node_id":"MDU6SXNzdWUzMTU3MjI3ODA=","number":75,"title":"Avoid type piracy","user":{"login":"quinnj","id":2896623,"node_id":"MDQ6VXNlcjI4OTY2MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2896623?v=4","gravatar_id":"","url":"https://api.github.com/users/quinnj","html_url":"https://github.com/quinnj","followers_url":"https://api.github.com/users/quinnj/followers","following_url":"https://api.github.com/users/quinnj/following{/other_user}","gists_url":"https://api.github.com/users/quinnj/gists{/gist_id}","starred_url":"https://api.github.com/users/quinnj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinnj/subscriptions","organizations_url":"https://api.github.com/users/quinnj/orgs","repos_url":"https://api.github.com/users/quinnj/repos","events_url":"https://api.github.com/users/quinnj/events{/privacy}","received_events_url":"https://api.github.com/users/quinnj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T04:20:36Z","updated_at":"2018-10-30T20:58:46Z","closed_at":"2018-10-30T20:58:46Z","author_association":"NONE","body":"I think it would be a little more kosher for types like DataFrame to implement `collect(e::Enumerable, ::Type{DataFrame})` (which would be a more specific method than the [default fallback](https://github.com/davidanthoff/Query.jl/blob/63bb596765516947c43257221f2dc57e68e61320/src/sinks/sink_type.jl#L1)) instead of stealing the `DataFrame(x::Any)` [definition](https://github.com/davidanthoff/IterableTables.jl/blob/646977c047bf9d0d3898187fd61663dcab2bfcf2/src/integrations/dataframes-missing.jl#L127). "},"comment":{"url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/comments/434467176","html_url":"https://github.com/queryverse/IterableTables.jl/issues/75#issuecomment-434467176","issue_url":"https://api.github.com/repos/queryverse/IterableTables.jl/issues/75","id":434467176,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQ2NzE3Ng==","user":{"login":"davidanthoff","id":1036561,"node_id":"MDQ6VXNlcjEwMzY1NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1036561?v=4","gravatar_id":"","url":"https://api.github.com/users/davidanthoff","html_url":"https://github.com/davidanthoff","followers_url":"https://api.github.com/users/davidanthoff/followers","following_url":"https://api.github.com/users/davidanthoff/following{/other_user}","gists_url":"https://api.github.com/users/davidanthoff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidanthoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidanthoff/subscriptions","organizations_url":"https://api.github.com/users/davidanthoff/orgs","repos_url":"https://api.github.com/users/davidanthoff/repos","events_url":"https://api.github.com/users/davidanthoff/events{/privacy}","received_events_url":"https://api.github.com/users/davidanthoff/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T20:58:46Z","updated_at":"2018-10-30T20:58:46Z","author_association":"MEMBER","body":"Closing as the constructor approach now seems widely accepted, plus the code for DataFrames.jl now lives in DataFrames.jl itself, so no more type piracy there."}}
{"actor":{"display_login":"davidanthoff"}}