{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/193","repository_url":"https://api.github.com/repos/ros2/rmw_fastrtps","labels_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/193/comments","events_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/193/events","html_url":"https://github.com/ros2/rmw_fastrtps/issues/193","id":310338933,"number":193,"title":"After update of ros2 workspace -> introduces build error - UnicodeDecodeError","user":{"login":"firesurfer","id":8481806,"avatar_url":"https://avatars1.githubusercontent.com/u/8481806?v=4","gravatar_id":"","url":"https://api.github.com/users/firesurfer","html_url":"https://github.com/firesurfer","followers_url":"https://api.github.com/users/firesurfer/followers","following_url":"https://api.github.com/users/firesurfer/following{/other_user}","gists_url":"https://api.github.com/users/firesurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/firesurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firesurfer/subscriptions","organizations_url":"https://api.github.com/users/firesurfer/orgs","repos_url":"https://api.github.com/users/firesurfer/repos","events_url":"https://api.github.com/users/firesurfer/events{/privacy}","received_events_url":"https://api.github.com/users/firesurfer/received_events","type":"User","site_admin":false},"labels":[{"id":608107942,"url":"https://api.github.com/repos/ros2/rmw_fastrtps/labels/more-information-needed","name":"more-information-needed","color":"159818","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-01T17:15:01Z","updated_at":"2018-04-09T17:57:34Z","closed_at":null,"author_association":"NONE","body":"After updating the ros2 workspace (I'm going with the master branches) the rmw_fastrtps_cpp package fails to build with the error:\r\n\r\n  File \"/usr/lib/python3.6/encodings/ascii.py\", line 26, in decode\r\n    return codecs.ascii_decode(input, self.errors)[0]\r\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 409: ordinal not in range(128)\r\n\r\nOperatingsystem: Debian testing\r\nCompiler: clang 5.0.1\r\nBuildsystem: Ninja\r\nPython Version: Python 3.6.5rc1\r\n\r\nIt also happens when using GCC 7.3 and make\r\n\r\nAccording to stackoverflow that might be a unicode problem with python, but I couldn't figure out where exactly to fix it in ament: \r\nhttps://stackoverflow.com/questions/18649512/unicodedecodeerror-ascii-codec-cant-decode-byte-0xe2-in-position-13-ordinal\r\n\r\nEDIT:\r\nI guess it is due to a python3 or python3 package upgrade. \r\nIn the last few days I had the following package upgrade regarding python:\r\n\r\n python3-scour:amd64 (0.36-2, 0.36-3)\r\npython3-pkg-resources:amd64 (38.5.2-1, 39.0.1-1)\r\npython3-setuptools:amd64 (38.5.2-1, 39.0.1-1)\r\n python3-gi-cairo:amd64 (3.26.1-2, 3.28.1-1)\r\n python3-gi:amd64 (3.26.1-2, 3.28.1-1)\r\n python3-nose:amd64 (1.3.7-3, 1.3.7-4)\r\npython3-apt:amd64 (1.4.0~beta3+b1, 1.6.0~rc2)\r\n\r\nThe complete build log for that package is:\r\n--------------------------------------------------------------------------------\r\n+++ Building 'rmw_fastrtps_cpp'\r\n==> '. /home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp/cmake__build.sh && /usr/bin/cmake -DBUILD_TESTING=0 -DAMENT_CMAKE_SYMLINK_INSTALL=1 -DCMAKE_CXX_FLAGS=-fuse-ld=gold -DCMAKE_BUILD_TYPE=Debug -G Ninja -DCMAKE_INSTALL_PREFIX=/home/firesurfer/workspace/ros2_ws/install /home/firesurfer/workspace/ros2_ws/src/ros2/rmw_fastrtps/rmw_fastrtps_cpp' in '/home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp'\r\n-- Found ament_cmake_ros: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_ros/cmake)\r\n-- Using PYTHON_EXECUTABLE: /usr/bin/python3\r\n-- Override CMake install command with custom implementation using symlinks instead of copying resources\r\n-- Found rcutils: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/rcutils/cmake)\r\n-- Found fastrtps_cmake_module: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/fastrtps_cmake_module/cmake)\r\n-- Found rmw: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/rmw/cmake)\r\n-- Found rosidl_typesupport_introspection_c: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/rosidl_typesupport_introspection_c/cmake)\r\n-- Found rosidl_typesupport_introspection_cpp: 0.4.0 (/home/firesurfer/workspace/ros2_ws/install/share/rosidl_typesupport_introspection_cpp/cmake)\r\nError parsing '/home/firesurfer/workspace/ros2_ws/src/ros2/rmw_fastrtps/rmw_fastrtps_cpp/package.xml':\r\nTraceback (most recent call last):\r\n  File \"/home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py\", line 145, in <module>\r\n    main()\r\n  File \"/home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py\", line 56, in main\r\n    raise e\r\n  File \"/home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py\", line 53, in main\r\n    package = parse_package_string(args.package_xml.read())\r\n  File \"/usr/lib/python3.6/encodings/ascii.py\", line 26, in decode\r\n    return codecs.ascii_decode(input, self.errors)[0]\r\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 409: ordinal not in range(128)\r\nCMake Error at /home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:94 (message):\r\n  execute_process(/usr/bin/python3\r\n  /home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py\r\n  /home/firesurfer/workspace/ros2_ws/src/ros2/rmw_fastrtps/rmw_fastrtps_cpp/package.xml\r\n  /home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp/ament_cmake_core/package.cmake)\r\n  returned error code 1\r\nCall Stack (most recent call first):\r\n  /home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:49 (_ament_package_xml)\r\n  /home/firesurfer/workspace/ros2_ws/install/share/ament_cmake_core/cmake/core/ament_package.cmake:63 (ament_package_xml)\r\n  CMakeLists.txt:119 (ament_package)\r\n\r\n\r\n-- Configuring incomplete, errors occurred!\r\nSee also \"/home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp/CMakeFiles/CMakeOutput.log\".\r\n\r\n<== Command '. /home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp/cmake__build.sh && /usr/bin/cmake -DBUILD_TESTING=0 -DAMENT_CMAKE_SYMLINK_INSTALL=1 -DCMAKE_CXX_FLAGS=-fuse-ld=gold -DCMAKE_BUILD_TYPE=Debug -G Ninja -DCMAKE_INSTALL_PREFIX=/home/firesurfer/workspace/ros2_ws/install /home/firesurfer/workspace/ros2_ws/src/ros2/rmw_fastrtps/rmw_fastrtps_cpp' failed in '/home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp' with exit code '1'\r\n<== Command '. /home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp/cmake__build.sh && /usr/bin/cmake -DBUILD_TESTING=0 -DAMENT_CMAKE_SYMLINK_INSTALL=1 -DCMAKE_CXX_FLAGS=-fuse-ld=gold -DCMAKE_BUILD_TYPE=Debug -G Ninja -DCMAKE_INSTALL_PREFIX=/home/firesurfer/workspace/ros2_ws/install /home/firesurfer/workspace/ros2_ws/src/ros2/rmw_fastrtps/rmw_fastrtps_cpp' failed in '/home/firesurfer/workspace/ros2_ws/build/rmw_fastrtps_cpp' with exit code '1'\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/comments/379839259","html_url":"https://github.com/ros2/rmw_fastrtps/issues/193#issuecomment-379839259","issue_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/193","id":379839259,"user":{"login":"mikaelarguedas","id":6644208,"avatar_url":"https://avatars1.githubusercontent.com/u/6644208?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelarguedas","html_url":"https://github.com/mikaelarguedas","followers_url":"https://api.github.com/users/mikaelarguedas/followers","following_url":"https://api.github.com/users/mikaelarguedas/following{/other_user}","gists_url":"https://api.github.com/users/mikaelarguedas/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelarguedas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelarguedas/subscriptions","organizations_url":"https://api.github.com/users/mikaelarguedas/orgs","repos_url":"https://api.github.com/users/mikaelarguedas/repos","events_url":"https://api.github.com/users/mikaelarguedas/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelarguedas/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T17:57:34Z","updated_at":"2018-04-09T17:57:34Z","author_association":"CONTRIBUTOR","body":"> Maybe it is better to remove it.\r\n\r\nWhile this would be a temporary workaround, many ROS users have unicode characters in their names so asking them to change their name in the package.xml is not a desired outcome.\r\n\r\n> `LANG=de_DE.UTF-8`\r\nthe LC_ALL variable isn't set by default. If I set it by hand to LC_ALL=de_DE.UTF-8 the build works fine.\r\n\r\nThanks @firesurfer for the additional information. Mine was set as per the [ROS 2 installation instructions](https://github.com/ros2/ros2/wiki/Linux-Development-Setup), I guess that's why I couldnt reproduce. In the meantime it looks like this was a known problem that motivated adding the override to the installation instructions.\r\n\r\nUnsetting it locally doesn't allow me to get the build to fail either. I'll try in a fresh environment with `LC_ALL` not set (not sure when I'll get around it though). If you happen to have a fix or time to investigate I'm more than happy to review / test it as it may allow a quicker resolution of this issue.\r\n\r\n"}}
{"actor":{"display_login":"mikaelarguedas"}}