{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/comments/222034187","pull_request_review_id":160826152,"id":222034187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjAzNDE4Nw==","diff_hunk":"@@ -53,40 +53,38 @@ func (oci *OCInterceptor) Config(tcs agenttracepb.TraceService_ConfigServer) err\n \treturn errUnimplemented\n }\n \n+type nodeSpansPair struct {","path":"interceptor/opencensus/opencensus.go","position":4,"original_position":4,"commit_id":"d71d1944e63aa107c25044f9f1d5d816d9f9b293","original_commit_id":"d71d1944e63aa107c25044f9f1d5d816d9f9b293","user":{"login":"odeke-em","id":4898263,"node_id":"MDQ6VXNlcjQ4OTgyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4898263?v=4","gravatar_id":"","url":"https://api.github.com/users/odeke-em","html_url":"https://github.com/odeke-em","followers_url":"https://api.github.com/users/odeke-em/followers","following_url":"https://api.github.com/users/odeke-em/following{/other_user}","gists_url":"https://api.github.com/users/odeke-em/gists{/gist_id}","starred_url":"https://api.github.com/users/odeke-em/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeke-em/subscriptions","organizations_url":"https://api.github.com/users/odeke-em/orgs","repos_url":"https://api.github.com/users/odeke-em/repos","events_url":"https://api.github.com/users/odeke-em/events{/privacy}","received_events_url":"https://api.github.com/users/odeke-em/received_events","type":"User","site_admin":false},"body":"It is a pair though that is node->spans :) but sure I'll make that change to `spansWithNode`.","created_at":"2018-10-02T17:04:44Z","updated_at":"2018-10-02T17:04:44Z","html_url":"https://github.com/census-instrumentation/opencensus-service/pull/50#discussion_r222034187","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/comments/222034187"},"html":{"href":"https://github.com/census-instrumentation/opencensus-service/pull/50#discussion_r222034187"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50"}},"in_reply_to_id":222032626},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50","id":219583887,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTgzODg3","html_url":"https://github.com/census-instrumentation/opencensus-service/pull/50","diff_url":"https://github.com/census-instrumentation/opencensus-service/pull/50.diff","patch_url":"https://github.com/census-instrumentation/opencensus-service/pull/50.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/50","number":50,"state":"open","locked":false,"title":"interceptor/opencensus: support multiplexing in Export","user":{"login":"odeke-em","id":4898263,"node_id":"MDQ6VXNlcjQ4OTgyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4898263?v=4","gravatar_id":"","url":"https://api.github.com/users/odeke-em","html_url":"https://github.com/odeke-em","followers_url":"https://api.github.com/users/odeke-em/followers","following_url":"https://api.github.com/users/odeke-em/following{/other_user}","gists_url":"https://api.github.com/users/odeke-em/gists{/gist_id}","starred_url":"https://api.github.com/users/odeke-em/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeke-em/subscriptions","organizations_url":"https://api.github.com/users/odeke-em/orgs","repos_url":"https://api.github.com/users/odeke-em/repos","events_url":"https://api.github.com/users/odeke-em/events{/privacy}","received_events_url":"https://api.github.com/users/odeke-em/received_events","type":"User","site_admin":false},"body":"Add multiplexing/\"pass through\" mode where spans from\r\nsources other than the initiating node can be sent\r\nand they should be properly proxied to their final\r\ndestination. This change also adds in tests to ensure\r\nthis behavior and to avoid regressions in the future.\r\n\r\nFixes #43","created_at":"2018-10-02T04:40:15Z","updated_at":"2018-10-02T17:04:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d26c51dc9d5df6a4cf1cc3c5f89625b5b218a96","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1066954593,"node_id":"MDU6TGFiZWwxMDY2OTU0NTkz","url":"https://api.github.com/repos/census-instrumentation/opencensus-service/labels/cla:%20yes","name":"cla: yes","color":"25d175","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/50/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/statuses/d71d1944e63aa107c25044f9f1d5d816d9f9b293","head":{"label":"census-instrumentation:ocinterceptor-can-multiplex","ref":"ocinterceptor-can-multiplex","sha":"d71d1944e63aa107c25044f9f1d5d816d9f9b293","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":135354123,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNTQxMjM=","name":"opencensus-service","full_name":"census-instrumentation/opencensus-service","private":false,"owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/census-instrumentation/opencensus-service","description":"OpenCensus service allows OpenCensus libraries to export to an exporter service rather than having to link vendor-specific exports.","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-service","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/deployments","created_at":"2018-05-29T21:19:37Z","updated_at":"2018-10-01T23:11:12Z","pushed_at":"2018-10-02T04:40:16Z","git_url":"git://github.com/census-instrumentation/opencensus-service.git","ssh_url":"git@github.com:census-instrumentation/opencensus-service.git","clone_url":"https://github.com/census-instrumentation/opencensus-service.git","svn_url":"https://github.com/census-instrumentation/opencensus-service","homepage":null,"size":3866,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":15,"watchers":19,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"e939042488a2fe395203c32612a90f208e2476a7","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":135354123,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNTQxMjM=","name":"opencensus-service","full_name":"census-instrumentation/opencensus-service","private":false,"owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/census-instrumentation/opencensus-service","description":"OpenCensus service allows OpenCensus libraries to export to an exporter service rather than having to link vendor-specific exports.","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-service","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-service/deployments","created_at":"2018-05-29T21:19:37Z","updated_at":"2018-10-01T23:11:12Z","pushed_at":"2018-10-02T04:40:16Z","git_url":"git://github.com/census-instrumentation/opencensus-service.git","ssh_url":"git@github.com:census-instrumentation/opencensus-service.git","clone_url":"https://github.com/census-instrumentation/opencensus-service.git","svn_url":"https://github.com/census-instrumentation/opencensus-service","homepage":null,"size":3866,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50"},"html":{"href":"https://github.com/census-instrumentation/opencensus-service/pull/50"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/50"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-service/statuses/d71d1944e63aa107c25044f9f1d5d816d9f9b293"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"odeke-em"}}