{"action":"created","comment":{"url":"https://api.github.com/repos/j2kan/ta-works/pulls/comments/172723513","pull_request_review_id":101788604,"id":172723513,"diff_hunk":"@@ -234,13 +245,15 @@ <h2>Confirmation</h2>\n <p>To submit your application you must agree to the above terms.</p>\n \n <p>Please note you will not be able to make changes to your application once you submit.</p>\n-<input name=\"confirm\" type=\"submit\" class=\"submitButton\" id =\"btn\" value=\"Submit\" disabled>\n-</form>\n \n-<div id=\"dialog\">\n-    <p>Are you sure you want to submit this application? Please ensure all information is correct.</p>\n+<div id=\"app-confirm\" title=\"Confirm Action\">\n+    <p class=\"appButtonPopupText\">Are you sure you want to submit this application? Please ensure all information is correct.</p>","path":"taworks/taform/templates/taform/application.html","position":51,"original_position":51,"commit_id":"e77f4777192b573515fcfb25f189eb454e7132fa","original_commit_id":"e77f4777192b573515fcfb25f189eb454e7132fa","user":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"body":"Do we want to not put \"please ensure all information is correct.\"?\r\n\r\nwe don't really give them a chance to ensure by showing what's been filled out / summary","created_at":"2018-03-07T02:17:30Z","updated_at":"2018-03-07T02:19:09Z","html_url":"https://github.com/j2kan/ta-works/pull/104#discussion_r172723513","pull_request_url":"https://api.github.com/repos/j2kan/ta-works/pulls/104","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/comments/172723513"},"html":{"href":"https://github.com/j2kan/ta-works/pull/104#discussion_r172723513"},"pull_request":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/j2kan/ta-works/pulls/104","id":173334658,"html_url":"https://github.com/j2kan/ta-works/pull/104","diff_url":"https://github.com/j2kan/ta-works/pull/104.diff","patch_url":"https://github.com/j2kan/ta-works/pull/104.patch","issue_url":"https://api.github.com/repos/j2kan/ta-works/issues/104","number":104,"state":"open","locked":false,"title":"push for potential error message solution on app - Opinions please!","user":{"login":"amyleblond","id":22120696,"avatar_url":"https://avatars0.githubusercontent.com/u/22120696?v=4","gravatar_id":"","url":"https://api.github.com/users/amyleblond","html_url":"https://github.com/amyleblond","followers_url":"https://api.github.com/users/amyleblond/followers","following_url":"https://api.github.com/users/amyleblond/following{/other_user}","gists_url":"https://api.github.com/users/amyleblond/gists{/gist_id}","starred_url":"https://api.github.com/users/amyleblond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyleblond/subscriptions","organizations_url":"https://api.github.com/users/amyleblond/orgs","repos_url":"https://api.github.com/users/amyleblond/repos","events_url":"https://api.github.com/users/amyleblond/events{/privacy}","received_events_url":"https://api.github.com/users/amyleblond/received_events","type":"User","site_admin":false},"body":"basically found that we aren't using the built in form.errors widget the way that we can! \r\nBenefits to this: display all of the form errors at once, regardless of browser. \r\n\r\nchanges:\r\n**models.py**:  added built in error messaging so we can identify the field\r\n**style.css**: adding the new popup to css\r\n**app-jquery.js**: using same methodology as on ranking and algo page for app page\r\n**application.html**: adding in display of form errors\r\n**views.py**: removing student ID check (covered in error messaging) but adding student visa expiration date as it is conditional\r\n\r\nhappy to explain this further -- think it's a good alternative!\r\n\r\n","created_at":"2018-03-07T02:10:27Z","updated_at":"2018-03-07T02:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"lauradobson","id":22123056,"avatar_url":"https://avatars2.githubusercontent.com/u/22123056?v=4","gravatar_id":"","url":"https://api.github.com/users/lauradobson","html_url":"https://github.com/lauradobson","followers_url":"https://api.github.com/users/lauradobson/followers","following_url":"https://api.github.com/users/lauradobson/following{/other_user}","gists_url":"https://api.github.com/users/lauradobson/gists{/gist_id}","starred_url":"https://api.github.com/users/lauradobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauradobson/subscriptions","organizations_url":"https://api.github.com/users/lauradobson/orgs","repos_url":"https://api.github.com/users/lauradobson/repos","events_url":"https://api.github.com/users/lauradobson/events{/privacy}","received_events_url":"https://api.github.com/users/lauradobson/received_events","type":"User","site_admin":false},{"login":"smwatts","id":22134649,"avatar_url":"https://avatars2.githubusercontent.com/u/22134649?v=4","gravatar_id":"","url":"https://api.github.com/users/smwatts","html_url":"https://github.com/smwatts","followers_url":"https://api.github.com/users/smwatts/followers","following_url":"https://api.github.com/users/smwatts/following{/other_user}","gists_url":"https://api.github.com/users/smwatts/gists{/gist_id}","starred_url":"https://api.github.com/users/smwatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smwatts/subscriptions","organizations_url":"https://api.github.com/users/smwatts/orgs","repos_url":"https://api.github.com/users/smwatts/repos","events_url":"https://api.github.com/users/smwatts/events{/privacy}","received_events_url":"https://api.github.com/users/smwatts/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/j2kan/ta-works/pulls/104/commits","review_comments_url":"https://api.github.com/repos/j2kan/ta-works/pulls/104/comments","review_comment_url":"https://api.github.com/repos/j2kan/ta-works/pulls/comments{/number}","comments_url":"https://api.github.com/repos/j2kan/ta-works/issues/104/comments","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/e77f4777192b573515fcfb25f189eb454e7132fa","head":{"label":"j2kan:appConfirm_test","ref":"appConfirm_test","sha":"e77f4777192b573515fcfb25f189eb454e7132fa","user":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"repo":{"id":95298493,"name":"ta-works","full_name":"j2kan/ta-works","owner":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j2kan/ta-works","description":"A web application that has a matching algorithm to assign teaching assistants to courses.","fork":false,"url":"https://api.github.com/repos/j2kan/ta-works","forks_url":"https://api.github.com/repos/j2kan/ta-works/forks","keys_url":"https://api.github.com/repos/j2kan/ta-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j2kan/ta-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j2kan/ta-works/teams","hooks_url":"https://api.github.com/repos/j2kan/ta-works/hooks","issue_events_url":"https://api.github.com/repos/j2kan/ta-works/issues/events{/number}","events_url":"https://api.github.com/repos/j2kan/ta-works/events","assignees_url":"https://api.github.com/repos/j2kan/ta-works/assignees{/user}","branches_url":"https://api.github.com/repos/j2kan/ta-works/branches{/branch}","tags_url":"https://api.github.com/repos/j2kan/ta-works/tags","blobs_url":"https://api.github.com/repos/j2kan/ta-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j2kan/ta-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j2kan/ta-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/j2kan/ta-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/{sha}","languages_url":"https://api.github.com/repos/j2kan/ta-works/languages","stargazers_url":"https://api.github.com/repos/j2kan/ta-works/stargazers","contributors_url":"https://api.github.com/repos/j2kan/ta-works/contributors","subscribers_url":"https://api.github.com/repos/j2kan/ta-works/subscribers","subscription_url":"https://api.github.com/repos/j2kan/ta-works/subscription","commits_url":"https://api.github.com/repos/j2kan/ta-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/j2kan/ta-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/j2kan/ta-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/j2kan/ta-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/j2kan/ta-works/contents/{+path}","compare_url":"https://api.github.com/repos/j2kan/ta-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j2kan/ta-works/merges","archive_url":"https://api.github.com/repos/j2kan/ta-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j2kan/ta-works/downloads","issues_url":"https://api.github.com/repos/j2kan/ta-works/issues{/number}","pulls_url":"https://api.github.com/repos/j2kan/ta-works/pulls{/number}","milestones_url":"https://api.github.com/repos/j2kan/ta-works/milestones{/number}","notifications_url":"https://api.github.com/repos/j2kan/ta-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j2kan/ta-works/labels{/name}","releases_url":"https://api.github.com/repos/j2kan/ta-works/releases{/id}","deployments_url":"https://api.github.com/repos/j2kan/ta-works/deployments","created_at":"2017-06-24T13:14:12Z","updated_at":"2017-07-10T19:47:12Z","pushed_at":"2018-03-07T02:10:28Z","git_url":"git://github.com/j2kan/ta-works.git","ssh_url":"git@github.com:j2kan/ta-works.git","clone_url":"https://github.com/j2kan/ta-works.git","svn_url":"https://github.com/j2kan/ta-works","homepage":null,"size":2136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"j2kan:master","ref":"master","sha":"563a82f8807a36f0b1ff53558d17e57c5fd87fa2","user":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"repo":{"id":95298493,"name":"ta-works","full_name":"j2kan/ta-works","owner":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j2kan/ta-works","description":"A web application that has a matching algorithm to assign teaching assistants to courses.","fork":false,"url":"https://api.github.com/repos/j2kan/ta-works","forks_url":"https://api.github.com/repos/j2kan/ta-works/forks","keys_url":"https://api.github.com/repos/j2kan/ta-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j2kan/ta-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j2kan/ta-works/teams","hooks_url":"https://api.github.com/repos/j2kan/ta-works/hooks","issue_events_url":"https://api.github.com/repos/j2kan/ta-works/issues/events{/number}","events_url":"https://api.github.com/repos/j2kan/ta-works/events","assignees_url":"https://api.github.com/repos/j2kan/ta-works/assignees{/user}","branches_url":"https://api.github.com/repos/j2kan/ta-works/branches{/branch}","tags_url":"https://api.github.com/repos/j2kan/ta-works/tags","blobs_url":"https://api.github.com/repos/j2kan/ta-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j2kan/ta-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j2kan/ta-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/j2kan/ta-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/{sha}","languages_url":"https://api.github.com/repos/j2kan/ta-works/languages","stargazers_url":"https://api.github.com/repos/j2kan/ta-works/stargazers","contributors_url":"https://api.github.com/repos/j2kan/ta-works/contributors","subscribers_url":"https://api.github.com/repos/j2kan/ta-works/subscribers","subscription_url":"https://api.github.com/repos/j2kan/ta-works/subscription","commits_url":"https://api.github.com/repos/j2kan/ta-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/j2kan/ta-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/j2kan/ta-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/j2kan/ta-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/j2kan/ta-works/contents/{+path}","compare_url":"https://api.github.com/repos/j2kan/ta-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j2kan/ta-works/merges","archive_url":"https://api.github.com/repos/j2kan/ta-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j2kan/ta-works/downloads","issues_url":"https://api.github.com/repos/j2kan/ta-works/issues{/number}","pulls_url":"https://api.github.com/repos/j2kan/ta-works/pulls{/number}","milestones_url":"https://api.github.com/repos/j2kan/ta-works/milestones{/number}","notifications_url":"https://api.github.com/repos/j2kan/ta-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j2kan/ta-works/labels{/name}","releases_url":"https://api.github.com/repos/j2kan/ta-works/releases{/id}","deployments_url":"https://api.github.com/repos/j2kan/ta-works/deployments","created_at":"2017-06-24T13:14:12Z","updated_at":"2017-07-10T19:47:12Z","pushed_at":"2018-03-07T02:10:28Z","git_url":"git://github.com/j2kan/ta-works.git","ssh_url":"git@github.com:j2kan/ta-works.git","clone_url":"https://github.com/j2kan/ta-works.git","svn_url":"https://github.com/j2kan/ta-works","homepage":null,"size":2136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/104"},"html":{"href":"https://github.com/j2kan/ta-works/pull/104"},"issue":{"href":"https://api.github.com/repos/j2kan/ta-works/issues/104"},"comments":{"href":"https://api.github.com/repos/j2kan/ta-works/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/j2kan/ta-works/statuses/e77f4777192b573515fcfb25f189eb454e7132fa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"j2kan"}}