{"action":"created","comment":{"url":"https://api.github.com/repos/daos-stack/iof/pulls/comments/234188315","pull_request_review_id":175780153,"id":234188315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE4ODMxNQ==","diff_hunk":"@@ -2600,16 +2746,32 @@ static void iof_finish(void *arg)\n \t\tif (!group->crt_attached)\n \t\t\tcontinue;\n \n-\t\tret = crt_group_detach(group->grp.dest_grp);\n-\t\tif (ret)\n+\t\trc = crt_group_detach(group->grp.dest_grp);\n+\t\tif (rc != -DER_SUCCESS)\n \t\t\tIOF_TRACE_ERROR(iof_state, \"crt_group_detach failed \"\n-\t\t\t\t\t\"with ret = %d\", ret);\n+\t\t\t\t\t\"with rc = %d\", rc);\n \t}\n \n \t/* Stop progress thread */\n-\tiof_thread_stop(&iof_state->iof_ctx);\n+\trc = iof_thread_stop(&iof_state->iof_ctx);\n+\tif (rc != 0)\n+\t\tIOF_TRACE_ERROR(iof_state,\n+\t\t\t\t\"thread stop returned %d\", rc);\n+\n+\tif (iof_state->iof_ctx.crt_ctx) {\n+\n+\t\trc = iof_progress_drain(&iof_state->iof_ctx);\n+\t\tif (rc != 0)\n+\t\t\tIOF_TRACE_ERROR(iof_state,\n+\t\t\t\t\t\"could not drain context %d\", rc);\n+\n+\t\trc = crt_context_destroy(iof_state->iof_ctx.crt_ctx, false);\n+\t\tif (rc != -DER_SUCCESS)\n+\t\t\tIOF_TRACE_ERROR(iof_state, \"Could not destroy context %d\",","path":"src/ioc/ioc_main.c","position":1370,"original_position":1370,"commit_id":"b829eabb1adf7c1229f68ca22c02a8bfe01cbba5","original_commit_id":"b829eabb1adf7c1229f68ca22c02a8bfe01cbba5","user":{"login":"daos-jenkins","id":33733935,"node_id":"MDQ6VXNlcjMzNzMzOTM1","avatar_url":"https://avatars3.githubusercontent.com/u/33733935?v=4","gravatar_id":"","url":"https://api.github.com/users/daos-jenkins","html_url":"https://github.com/daos-jenkins","followers_url":"https://api.github.com/users/daos-jenkins/followers","following_url":"https://api.github.com/users/daos-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/daos-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/daos-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daos-jenkins/subscriptions","organizations_url":"https://api.github.com/users/daos-jenkins/orgs","repos_url":"https://api.github.com/users/daos-jenkins/repos","events_url":"https://api.github.com/users/daos-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/daos-jenkins/received_events","type":"User","site_admin":false},"body":"(style)  line over 80 characters\n","created_at":"2018-11-16T12:29:22Z","updated_at":"2018-11-16T12:29:25Z","html_url":"https://github.com/daos-stack/iof/pull/1#discussion_r234188315","pull_request_url":"https://api.github.com/repos/daos-stack/iof/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/comments/234188315"},"html":{"href":"https://github.com/daos-stack/iof/pull/1#discussion_r234188315"},"pull_request":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/daos-stack/iof/pulls/1","id":231331217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzMxMjE3","html_url":"https://github.com/daos-stack/iof/pull/1","diff_url":"https://github.com/daos-stack/iof/pull/1.diff","patch_url":"https://github.com/daos-stack/iof/pull/1.patch","issue_url":"https://api.github.com/repos/daos-stack/iof/issues/1","number":1,"state":"open","locked":false,"title":"Initial pipeline support","user":{"login":"brianjmurrell","id":559317,"node_id":"MDQ6VXNlcjU1OTMxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/559317?v=4","gravatar_id":"","url":"https://api.github.com/users/brianjmurrell","html_url":"https://github.com/brianjmurrell","followers_url":"https://api.github.com/users/brianjmurrell/followers","following_url":"https://api.github.com/users/brianjmurrell/following{/other_user}","gists_url":"https://api.github.com/users/brianjmurrell/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjmurrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjmurrell/subscriptions","organizations_url":"https://api.github.com/users/brianjmurrell/orgs","repos_url":"https://api.github.com/users/brianjmurrell/repos","events_url":"https://api.github.com/users/brianjmurrell/events{/privacy}","received_events_url":"https://api.github.com/users/brianjmurrell/received_events","type":"User","site_admin":false},"body":"Change-Id: Ia2b2b05176f306382928ae338eebe150e5edb4be\r\nSigned-off-by: Brian J. Murrell <brian.murrell@intel.com>","created_at":"2018-11-15T20:55:46Z","updated_at":"2018-11-16T12:29:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eed78a6d9fb9514250132881c0f5fe86722e1602","assignee":{"login":"brianjmurrell","id":559317,"node_id":"MDQ6VXNlcjU1OTMxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/559317?v=4","gravatar_id":"","url":"https://api.github.com/users/brianjmurrell","html_url":"https://github.com/brianjmurrell","followers_url":"https://api.github.com/users/brianjmurrell/followers","following_url":"https://api.github.com/users/brianjmurrell/following{/other_user}","gists_url":"https://api.github.com/users/brianjmurrell/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjmurrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjmurrell/subscriptions","organizations_url":"https://api.github.com/users/brianjmurrell/orgs","repos_url":"https://api.github.com/users/brianjmurrell/repos","events_url":"https://api.github.com/users/brianjmurrell/events{/privacy}","received_events_url":"https://api.github.com/users/brianjmurrell/received_events","type":"User","site_admin":false},"assignees":[{"login":"brianjmurrell","id":559317,"node_id":"MDQ6VXNlcjU1OTMxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/559317?v=4","gravatar_id":"","url":"https://api.github.com/users/brianjmurrell","html_url":"https://github.com/brianjmurrell","followers_url":"https://api.github.com/users/brianjmurrell/followers","following_url":"https://api.github.com/users/brianjmurrell/following{/other_user}","gists_url":"https://api.github.com/users/brianjmurrell/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjmurrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjmurrell/subscriptions","organizations_url":"https://api.github.com/users/brianjmurrell/orgs","repos_url":"https://api.github.com/users/brianjmurrell/repos","events_url":"https://api.github.com/users/brianjmurrell/events{/privacy}","received_events_url":"https://api.github.com/users/brianjmurrell/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/daos-stack/iof/pulls/1/commits","review_comments_url":"https://api.github.com/repos/daos-stack/iof/pulls/1/comments","review_comment_url":"https://api.github.com/repos/daos-stack/iof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daos-stack/iof/issues/1/comments","statuses_url":"https://api.github.com/repos/daos-stack/iof/statuses/b829eabb1adf7c1229f68ca22c02a8bfe01cbba5","head":{"label":"daos-stack:pipeline","ref":"pipeline","sha":"b829eabb1adf7c1229f68ca22c02a8bfe01cbba5","user":{"login":"daos-stack","id":20561043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTYxMDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20561043?v=4","gravatar_id":"","url":"https://api.github.com/users/daos-stack","html_url":"https://github.com/daos-stack","followers_url":"https://api.github.com/users/daos-stack/followers","following_url":"https://api.github.com/users/daos-stack/following{/other_user}","gists_url":"https://api.github.com/users/daos-stack/gists{/gist_id}","starred_url":"https://api.github.com/users/daos-stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daos-stack/subscriptions","organizations_url":"https://api.github.com/users/daos-stack/orgs","repos_url":"https://api.github.com/users/daos-stack/repos","events_url":"https://api.github.com/users/daos-stack/events{/privacy}","received_events_url":"https://api.github.com/users/daos-stack/received_events","type":"Organization","site_admin":false},"repo":{"id":143976333,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NzYzMzM=","name":"iof","full_name":"daos-stack/iof","private":false,"owner":{"login":"daos-stack","id":20561043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTYxMDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20561043?v=4","gravatar_id":"","url":"https://api.github.com/users/daos-stack","html_url":"https://github.com/daos-stack","followers_url":"https://api.github.com/users/daos-stack/followers","following_url":"https://api.github.com/users/daos-stack/following{/other_user}","gists_url":"https://api.github.com/users/daos-stack/gists{/gist_id}","starred_url":"https://api.github.com/users/daos-stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daos-stack/subscriptions","organizations_url":"https://api.github.com/users/daos-stack/orgs","repos_url":"https://api.github.com/users/daos-stack/repos","events_url":"https://api.github.com/users/daos-stack/events{/privacy}","received_events_url":"https://api.github.com/users/daos-stack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daos-stack/iof","description":"POSIX I/O Forwarding","fork":false,"url":"https://api.github.com/repos/daos-stack/iof","forks_url":"https://api.github.com/repos/daos-stack/iof/forks","keys_url":"https://api.github.com/repos/daos-stack/iof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daos-stack/iof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daos-stack/iof/teams","hooks_url":"https://api.github.com/repos/daos-stack/iof/hooks","issue_events_url":"https://api.github.com/repos/daos-stack/iof/issues/events{/number}","events_url":"https://api.github.com/repos/daos-stack/iof/events","assignees_url":"https://api.github.com/repos/daos-stack/iof/assignees{/user}","branches_url":"https://api.github.com/repos/daos-stack/iof/branches{/branch}","tags_url":"https://api.github.com/repos/daos-stack/iof/tags","blobs_url":"https://api.github.com/repos/daos-stack/iof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daos-stack/iof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daos-stack/iof/git/refs{/sha}","trees_url":"https://api.github.com/repos/daos-stack/iof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daos-stack/iof/statuses/{sha}","languages_url":"https://api.github.com/repos/daos-stack/iof/languages","stargazers_url":"https://api.github.com/repos/daos-stack/iof/stargazers","contributors_url":"https://api.github.com/repos/daos-stack/iof/contributors","subscribers_url":"https://api.github.com/repos/daos-stack/iof/subscribers","subscription_url":"https://api.github.com/repos/daos-stack/iof/subscription","commits_url":"https://api.github.com/repos/daos-stack/iof/commits{/sha}","git_commits_url":"https://api.github.com/repos/daos-stack/iof/git/commits{/sha}","comments_url":"https://api.github.com/repos/daos-stack/iof/comments{/number}","issue_comment_url":"https://api.github.com/repos/daos-stack/iof/issues/comments{/number}","contents_url":"https://api.github.com/repos/daos-stack/iof/contents/{+path}","compare_url":"https://api.github.com/repos/daos-stack/iof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daos-stack/iof/merges","archive_url":"https://api.github.com/repos/daos-stack/iof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daos-stack/iof/downloads","issues_url":"https://api.github.com/repos/daos-stack/iof/issues{/number}","pulls_url":"https://api.github.com/repos/daos-stack/iof/pulls{/number}","milestones_url":"https://api.github.com/repos/daos-stack/iof/milestones{/number}","notifications_url":"https://api.github.com/repos/daos-stack/iof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daos-stack/iof/labels{/name}","releases_url":"https://api.github.com/repos/daos-stack/iof/releases{/id}","deployments_url":"https://api.github.com/repos/daos-stack/iof/deployments","created_at":"2018-08-08T07:23:14Z","updated_at":"2018-08-22T13:29:03Z","pushed_at":"2018-11-16T12:28:46Z","git_url":"git://github.com/daos-stack/iof.git","ssh_url":"git@github.com:daos-stack/iof.git","clone_url":"https://github.com/daos-stack/iof.git","svn_url":"https://github.com/daos-stack/iof","homepage":null,"size":1715,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"daos-stack:master","ref":"master","sha":"4c9cea852f58daba07d5805681811a382d490c64","user":{"login":"daos-stack","id":20561043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTYxMDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20561043?v=4","gravatar_id":"","url":"https://api.github.com/users/daos-stack","html_url":"https://github.com/daos-stack","followers_url":"https://api.github.com/users/daos-stack/followers","following_url":"https://api.github.com/users/daos-stack/following{/other_user}","gists_url":"https://api.github.com/users/daos-stack/gists{/gist_id}","starred_url":"https://api.github.com/users/daos-stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daos-stack/subscriptions","organizations_url":"https://api.github.com/users/daos-stack/orgs","repos_url":"https://api.github.com/users/daos-stack/repos","events_url":"https://api.github.com/users/daos-stack/events{/privacy}","received_events_url":"https://api.github.com/users/daos-stack/received_events","type":"Organization","site_admin":false},"repo":{"id":143976333,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NzYzMzM=","name":"iof","full_name":"daos-stack/iof","private":false,"owner":{"login":"daos-stack","id":20561043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTYxMDQz","avatar_url":"https://avatars1.githubusercontent.com/u/20561043?v=4","gravatar_id":"","url":"https://api.github.com/users/daos-stack","html_url":"https://github.com/daos-stack","followers_url":"https://api.github.com/users/daos-stack/followers","following_url":"https://api.github.com/users/daos-stack/following{/other_user}","gists_url":"https://api.github.com/users/daos-stack/gists{/gist_id}","starred_url":"https://api.github.com/users/daos-stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daos-stack/subscriptions","organizations_url":"https://api.github.com/users/daos-stack/orgs","repos_url":"https://api.github.com/users/daos-stack/repos","events_url":"https://api.github.com/users/daos-stack/events{/privacy}","received_events_url":"https://api.github.com/users/daos-stack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daos-stack/iof","description":"POSIX I/O Forwarding","fork":false,"url":"https://api.github.com/repos/daos-stack/iof","forks_url":"https://api.github.com/repos/daos-stack/iof/forks","keys_url":"https://api.github.com/repos/daos-stack/iof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daos-stack/iof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daos-stack/iof/teams","hooks_url":"https://api.github.com/repos/daos-stack/iof/hooks","issue_events_url":"https://api.github.com/repos/daos-stack/iof/issues/events{/number}","events_url":"https://api.github.com/repos/daos-stack/iof/events","assignees_url":"https://api.github.com/repos/daos-stack/iof/assignees{/user}","branches_url":"https://api.github.com/repos/daos-stack/iof/branches{/branch}","tags_url":"https://api.github.com/repos/daos-stack/iof/tags","blobs_url":"https://api.github.com/repos/daos-stack/iof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daos-stack/iof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daos-stack/iof/git/refs{/sha}","trees_url":"https://api.github.com/repos/daos-stack/iof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daos-stack/iof/statuses/{sha}","languages_url":"https://api.github.com/repos/daos-stack/iof/languages","stargazers_url":"https://api.github.com/repos/daos-stack/iof/stargazers","contributors_url":"https://api.github.com/repos/daos-stack/iof/contributors","subscribers_url":"https://api.github.com/repos/daos-stack/iof/subscribers","subscription_url":"https://api.github.com/repos/daos-stack/iof/subscription","commits_url":"https://api.github.com/repos/daos-stack/iof/commits{/sha}","git_commits_url":"https://api.github.com/repos/daos-stack/iof/git/commits{/sha}","comments_url":"https://api.github.com/repos/daos-stack/iof/comments{/number}","issue_comment_url":"https://api.github.com/repos/daos-stack/iof/issues/comments{/number}","contents_url":"https://api.github.com/repos/daos-stack/iof/contents/{+path}","compare_url":"https://api.github.com/repos/daos-stack/iof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daos-stack/iof/merges","archive_url":"https://api.github.com/repos/daos-stack/iof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daos-stack/iof/downloads","issues_url":"https://api.github.com/repos/daos-stack/iof/issues{/number}","pulls_url":"https://api.github.com/repos/daos-stack/iof/pulls{/number}","milestones_url":"https://api.github.com/repos/daos-stack/iof/milestones{/number}","notifications_url":"https://api.github.com/repos/daos-stack/iof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daos-stack/iof/labels{/name}","releases_url":"https://api.github.com/repos/daos-stack/iof/releases{/id}","deployments_url":"https://api.github.com/repos/daos-stack/iof/deployments","created_at":"2018-08-08T07:23:14Z","updated_at":"2018-08-22T13:29:03Z","pushed_at":"2018-11-16T12:28:46Z","git_url":"git://github.com/daos-stack/iof.git","ssh_url":"git@github.com:daos-stack/iof.git","clone_url":"https://github.com/daos-stack/iof.git","svn_url":"https://github.com/daos-stack/iof","homepage":null,"size":1715,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/1"},"html":{"href":"https://github.com/daos-stack/iof/pull/1"},"issue":{"href":"https://api.github.com/repos/daos-stack/iof/issues/1"},"comments":{"href":"https://api.github.com/repos/daos-stack/iof/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daos-stack/iof/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/daos-stack/iof/statuses/b829eabb1adf7c1229f68ca22c02a8bfe01cbba5"}},"author_association":"NONE"}}
{"actor":{"display_login":"daos-jenkins"}}