{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/184127821","pull_request_review_id":115259651,"id":184127821,"diff_hunk":"@@ -12284,7 +12284,18 @@ msgctxt \"#20223\"\n msgid \"Artist information folder\"\n msgstr \"\"\n \n-#empty strings from id 20224 to 20239\n+#: system/settings/settings.xml\n+msgctxt \"#20224\"\n+msgid \"Prefer scraped album art\"\n+msgstr \"\"\n+\n+#. Description of setting with label #20224 \"Prefer scraped album art\"\n+#: system/settings/settings.xml\n+msgctxt \"#20225\"\n+msgid \"Downloaded album covers will be prefered over images extracted from embedded within a music file\"","path":"addons/resource.language.en_gb/resources/strings.po","position":13,"original_position":13,"commit_id":"38735f209007ed6bc5833885030cb0721e1aa0a0","original_commit_id":"38735f209007ed6bc5833885030cb0721e1aa0a0","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars2.githubusercontent.com/u/13371422?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"Ah yes, I see it now, what was I on?\r\n\"Downloaded album covers will be preferred over those embedded within the music files\"","created_at":"2018-04-25T16:36:35Z","updated_at":"2018-04-25T16:36:35Z","html_url":"https://github.com/xbmc/xbmc/pull/13812#discussion_r184127821","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13812","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/184127821"},"html":{"href":"https://github.com/xbmc/xbmc/pull/13812#discussion_r184127821"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13812"}},"in_reply_to_id":184017670},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/13812","id":183629247,"html_url":"https://github.com/xbmc/xbmc/pull/13812","diff_url":"https://github.com/xbmc/xbmc/pull/13812.diff","patch_url":"https://github.com/xbmc/xbmc/pull/13812.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/13812","number":13812,"state":"open","locked":false,"title":"[Music]Prefer scraped album covers to embedded images","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars2.githubusercontent.com/u/13371422?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"Add an option to prefer scraped album covers over any images embedded in music files.\r\n\r\nThis is a long wanted feature that will help users automatically get the album art they want. While many users embed high resolution album covers their music files, and would not want the scraper to replace them, others have old poor quality art in there and would rather have any new pretty art that the scraper can fetch automatically appear. Previously avoiding using the embedded art meant selecting the album art from the list of scraped possibilities manually for each individual album (or of course re-tagging the music files)\r\n___\r\nDescribed in detail https://forum.kodi.tv/showthread.php?tid=331191\r\n\r\nBy default the album thumb (cover) art is automatically allocated in the following priority:\r\n1) folder art, \r\n2) 1st embedded in music file, \r\n3) scraped\r\n This means that the scraped art only gets uses automatically when there is neither local folder art, nor art embedded in any of the music files.\r\n\r\nIt is right that local folder art, when it exists, always takes precedence, and this will continue to be the case. However with the new setting \"Prefer scraped album art\" enabled, the embedded art will only be used for album thumb when the scraper does not find art for that album.  When scraping remote sites, either when adding a music source,on library update or when clicking the \"Refresh\" button on the album information dialog, the first art found will replace any use of embedded art for the album.","created_at":"2018-04-24T06:07:04Z","updated_at":"2018-04-25T16:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187a95b9f147dae3d1d10d7f6bc5a0506824d209","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":13087449,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1","default":false},{"id":276934948,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Music","name":"Music","color":"009800","default":false},{"id":400751192,"url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/108","html_url":"https://github.com/xbmc/xbmc/milestone/108","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/108/labels","id":3158033,"number":108,"title":"Leia 18.0-alpha2","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars1.githubusercontent.com/u/907436?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":175,"state":"open","created_at":"2018-03-03T07:09:50Z","updated_at":"2018-04-25T12:33:19Z","due_on":"2018-04-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13812/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/13812/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/13812/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/38735f209007ed6bc5833885030cb0721e1aa0a0","head":{"label":"DaveTBlake:PreferScrapedAlbumArt","ref":"PreferScrapedAlbumArt","sha":"38735f209007ed6bc5833885030cb0721e1aa0a0","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars2.githubusercontent.com/u/13371422?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"repo":{"id":41623007,"name":"xbmc","full_name":"DaveTBlake/xbmc","owner":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars2.githubusercontent.com/u/13371422?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveTBlake/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/DaveTBlake/xbmc","forks_url":"https://api.github.com/repos/DaveTBlake/xbmc/forks","keys_url":"https://api.github.com/repos/DaveTBlake/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveTBlake/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveTBlake/xbmc/teams","hooks_url":"https://api.github.com/repos/DaveTBlake/xbmc/hooks","issue_events_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/DaveTBlake/xbmc/events","assignees_url":"https://api.github.com/repos/DaveTBlake/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/DaveTBlake/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/tags","blobs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveTBlake/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveTBlake/xbmc/languages","stargazers_url":"https://api.github.com/repos/DaveTBlake/xbmc/stargazers","contributors_url":"https://api.github.com/repos/DaveTBlake/xbmc/contributors","subscribers_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscribers","subscription_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscription","commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveTBlake/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveTBlake/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/DaveTBlake/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveTBlake/xbmc/merges","archive_url":"https://api.github.com/repos/DaveTBlake/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveTBlake/xbmc/downloads","issues_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/DaveTBlake/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveTBlake/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveTBlake/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveTBlake/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/DaveTBlake/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/DaveTBlake/xbmc/deployments","created_at":"2015-08-30T09:25:19Z","updated_at":"2018-04-23T21:35:40Z","pushed_at":"2018-04-24T05:34:49Z","git_url":"git://github.com/DaveTBlake/xbmc.git","ssh_url":"git@github.com:DaveTBlake/xbmc.git","clone_url":"https://github.com/DaveTBlake/xbmc.git","svn_url":"https://github.com/DaveTBlake/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":611270,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"d9f6b90154c33570183f6acc6aeabd330b14d9d7","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2018-04-25T10:23:42Z","pushed_at":"2018-04-25T14:47:23Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1446223,"stargazers_count":7006,"watchers_count":7006,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4610,"mirror_url":null,"archived":false,"open_issues_count":145,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4610,"open_issues":145,"watchers":7006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13812"},"html":{"href":"https://github.com/xbmc/xbmc/pull/13812"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/13812"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/13812/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13812/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/13812/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/38735f209007ed6bc5833885030cb0721e1aa0a0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DaveTBlake"}}