{"action":"created","issue":{"url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/414","repository_url":"https://api.github.com/repos/tempesta-tech/mariadb","labels_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/414/labels{/name}","comments_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/414/comments","events_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/414/events","html_url":"https://github.com/tempesta-tech/mariadb/issues/414","id":282675281,"node_id":"MDU6SXNzdWUyODI2NzUyODE=","number":414,"title":"IB: inplace for VERS_TIMESTAMP versioning","user":{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"labels":[{"id":388954542,"node_id":"MDU6TGFiZWwzODg5NTQ1NDI=","url":"https://api.github.com/repos/tempesta-tech/mariadb/labels/performance","name":"performance","color":"ffaad0","default":false},{"id":442030504,"node_id":"MDU6TGFiZWw0NDIwMzA1MDQ=","url":"https://api.github.com/repos/tempesta-tech/mariadb/labels/task","name":"task","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"assignees":[{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tempesta-tech/mariadb/milestones/17","html_url":"https://github.com/tempesta-tech/mariadb/milestone/17","labels_url":"https://api.github.com/repos/tempesta-tech/mariadb/milestones/17/labels","id":2919746,"node_id":"MDk6TWlsZXN0b25lMjkxOTc0Ng==","number":17,"title":"1.1: General bugfixes and priority tasks after initial MariaDB release","description":"The priority is now on MariaDB tasks specified in their [bugtracker](https://jira.mariadb.org/).","creator":{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":74,"state":"open","created_at":"2017-11-17T13:43:00Z","updated_at":"2018-09-28T08:13:52Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2017-12-17T07:12:02Z","updated_at":"2018-09-28T10:38:10Z","closed_at":null,"author_association":"NONE","body":"Related to #87, #209, #315, #348.\r\nSimilar to #491 (94466aa5b6a5065c9ac62b8b28f2012dbcdd65f4).\r\n\r\nSuch cases as\r\n\r\n```sql\r\ncreate or replace table t (a int) with system versioning engine=innodb;\r\ninsert into t values (1);\r\ndelete from t;\r\n--error ER_UNSUPPORTED_EXTENSION\r\nalter table t add b int auto_increment unique;\r\n```\r\n\r\nare not handled in IB as it is oriented on TRX_ID versioning (`row_merge_read_clustered_index()`):\r\n\r\n```c++\r\n\t\t\tif (new_table->versioned()) {\r\n\t\t\t\tif (historical_row) {\r\n\t\t\t\t\tif (dfield_get_type(dfield)->prtype & DATA_NOT_NULL) {\r\n\t\t\t\t\t\terr = DB_UNSUPPORTED;\r\n\t\t\t\t\t\tmy_error(ER_UNSUPPORTED_EXTENSION, MYF(0),\r\n\t\t\t\t\t\t\t old_table->name);\r\n\t\t\t\t\t\tgoto func_exit;\r\n\t\t\t\t\t}\r\n\t\t\t\t\tdfield_set_null(dfield);\r\n\t\t\t\t} else {\r\n\t\t\t\t\t// set not null\r\n\t\t\t\t\tulint len = dfield_get_type(dfield)->len;\r\n\t\t\t\t\tdfield_set_data(dfield, any_autoinc_data, len);\r\n\t\t\t\t}\r\n\t\t\t}\r\n``` \r\n\r\nCurrently it is disabled like this:\r\n\r\n```c++\r\n  if (altered_table->versioned(VERS_TIMESTAMP))\r\n    DBUG_RETURN(HA_ALTER_INPLACE_NOT_SUPPORTED);\r\n```\r\n\r\nMake more fine-grained `ha_innobase::check_if_supported_inplace_alter()` to check for such column additions. Update `handler::check_if_supported_inplace_alter()` to include same check."},"comment":{"url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/comments/425396044","html_url":"https://github.com/tempesta-tech/mariadb/issues/414#issuecomment-425396044","issue_url":"https://api.github.com/repos/tempesta-tech/mariadb/issues/414","id":425396044,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTM5NjA0NA==","user":{"login":"midenok","id":3307037,"node_id":"MDQ6VXNlcjMzMDcwMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/3307037?v=4","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T10:38:10Z","updated_at":"2018-09-28T10:38:10Z","author_association":"NONE","body":"## Good\r\n### 1. `Create_field` constructed\r\n```c++\r\n#0  Create_field::Create_field (this=0x7fff78013560) at /home/midenok/src/mariadb/trunk/src/sql/field.h:4682\r\n#1  0x0000000000af3aa9 in Create_field::clone (this=0x7fff78013430, mem_root=0x7fff78006240) at /home/midenok/src/mariadb/trunk/src/sql/field.cc:11076\r\n#2  0x0000000000960e16 in list_copy_and_replace_each_value<Create_field> (list=..., mem_root=0x7fff78006240) at /home/midenok/src/mariadb/trunk/src/sql/sql_list.h:802\r\n#3  0x000000000095f327 in Alter_info::Alter_info (this=0x7fffe4ece318, rhs=..., mem_root=0x7fff78006240) at /home/midenok/src/mariadb/trunk/src/sql/sql_alter.cc:49\r\n#4  0x0000000000960223 in Sql_cmd_alter_table::execute (this=0x7fff78013548, thd=0x7fff78000ce8) at /home/midenok/src/mariadb/trunk/src/sql/sql_alter.cc:370\r\n#5  0x00000000007c08fc in mysql_execute_command (thd=0x7fff78000ce8) at /home/midenok/src/mariadb/trunk/src/sql/sql_parse.cc:6285\r\n#6  0x00000000007b252f in mysql_parse (thd=0x7fff78000ce8, rawbuf=0x7fff78012c90 \"alter table t change column a a int without system versioning, lock=none\", length=72, parser_state=0x7fffe4ed1650, is_com_multi=false, is_next_command=false) at /home/midenok/src/mariadb/trunk/src/sql/sql_parse.cc:8089\r\n```"}}
{"actor":{"display_login":"midenok"}}