{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168739113","pull_request_review_id":97156564,"id":168739113,"diff_hunk":"@@ -16,10 +18,25 @@\n             + \": Displays all persons in the address book as a list with index numbers.\\n\"\n             + \"Example: \" + COMMAND_WORD;\n \n-\n     @Override\n     public CommandResult execute() {\n         List<ReadOnlyPerson> allPersons = addressBook.getAllPersons().immutableListView();\n-        return new CommandResult(getMessageForPersonListShownSummary(allPersons), allPersons);\n+        List<ReadOnlyPerson> sortPersons =  new ArrayList<ReadOnlyPerson>();\n+        for (int i = 0 ; i<allPersons.size() ; i++){\n+            sortPersons.add(allPersons.get(i));\n+        }\n+        int n = sortPersons.size();","path":"src/seedu/addressbook/commands/ListCommand.java","position":23,"original_position":23,"commit_id":"85a2deaf3d0bbdf915566155304d13b1dc01ac0b","original_commit_id":"85a2deaf3d0bbdf915566155304d13b1dc01ac0b","user":{"login":"asiddharth","id":23400124,"avatar_url":"https://avatars3.githubusercontent.com/u/23400124?v=4","gravatar_id":"","url":"https://api.github.com/users/asiddharth","html_url":"https://github.com/asiddharth","followers_url":"https://api.github.com/users/asiddharth/followers","following_url":"https://api.github.com/users/asiddharth/following{/other_user}","gists_url":"https://api.github.com/users/asiddharth/gists{/gist_id}","starred_url":"https://api.github.com/users/asiddharth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiddharth/subscriptions","organizations_url":"https://api.github.com/users/asiddharth/orgs","repos_url":"https://api.github.com/users/asiddharth/repos","events_url":"https://api.github.com/users/asiddharth/events{/privacy}","received_events_url":"https://api.github.com/users/asiddharth/received_events","type":"User","site_admin":false},"body":"Use a more meaningful variable name. It enhances the readability of the code","created_at":"2018-02-16T12:00:45Z","updated_at":"2018-02-16T12:06:46Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700#discussion_r168739113","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168739113"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700#discussion_r168739113"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700","id":169459703,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/700","number":700,"state":"open","locked":false,"title":"[W5.11][T16-A2]Victor Tardieu","user":{"login":"victortardieu","id":35592054,"avatar_url":"https://avatars3.githubusercontent.com/u/35592054?v=4","gravatar_id":"","url":"https://api.github.com/users/victortardieu","html_url":"https://github.com/victortardieu","followers_url":"https://api.github.com/users/victortardieu/followers","following_url":"https://api.github.com/users/victortardieu/following{/other_user}","gists_url":"https://api.github.com/users/victortardieu/gists{/gist_id}","starred_url":"https://api.github.com/users/victortardieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victortardieu/subscriptions","organizations_url":"https://api.github.com/users/victortardieu/orgs","repos_url":"https://api.github.com/users/victortardieu/repos","events_url":"https://api.github.com/users/victortardieu/events{/privacy}","received_events_url":"https://api.github.com/users/victortardieu/received_events","type":"User","site_admin":false},"body":"Modified the list function to sort and then print out the contact in order","created_at":"2018-02-15T19:13:07Z","updated_at":"2018-02-16T12:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"597886f2855fb262a4978a9710f5b6d1c81f977b","assignee":{"login":"sooyj","id":8551571,"avatar_url":"https://avatars0.githubusercontent.com/u/8551571?v=4","gravatar_id":"","url":"https://api.github.com/users/sooyj","html_url":"https://github.com/sooyj","followers_url":"https://api.github.com/users/sooyj/followers","following_url":"https://api.github.com/users/sooyj/following{/other_user}","gists_url":"https://api.github.com/users/sooyj/gists{/gist_id}","starred_url":"https://api.github.com/users/sooyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooyj/subscriptions","organizations_url":"https://api.github.com/users/sooyj/orgs","repos_url":"https://api.github.com/users/sooyj/repos","events_url":"https://api.github.com/users/sooyj/events{/privacy}","received_events_url":"https://api.github.com/users/sooyj/received_events","type":"User","site_admin":false},"assignees":[{"login":"sooyj","id":8551571,"avatar_url":"https://avatars0.githubusercontent.com/u/8551571?v=4","gravatar_id":"","url":"https://api.github.com/users/sooyj","html_url":"https://github.com/sooyj","followers_url":"https://api.github.com/users/sooyj/followers","following_url":"https://api.github.com/users/sooyj/following{/other_user}","gists_url":"https://api.github.com/users/sooyj/gists{/gist_id}","starred_url":"https://api.github.com/users/sooyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooyj/subscriptions","organizations_url":"https://api.github.com/users/sooyj/orgs","repos_url":"https://api.github.com/users/sooyj/repos","events_url":"https://api.github.com/users/sooyj/events{/privacy}","received_events_url":"https://api.github.com/users/sooyj/received_events","type":"User","site_admin":false},{"login":"asiddharth","id":23400124,"avatar_url":"https://avatars3.githubusercontent.com/u/23400124?v=4","gravatar_id":"","url":"https://api.github.com/users/asiddharth","html_url":"https://github.com/asiddharth","followers_url":"https://api.github.com/users/asiddharth/followers","following_url":"https://api.github.com/users/asiddharth/following{/other_user}","gists_url":"https://api.github.com/users/asiddharth/gists{/gist_id}","starred_url":"https://api.github.com/users/asiddharth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiddharth/subscriptions","organizations_url":"https://api.github.com/users/asiddharth/orgs","repos_url":"https://api.github.com/users/asiddharth/repos","events_url":"https://api.github.com/users/asiddharth/events{/privacy}","received_events_url":"https://api.github.com/users/asiddharth/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873038,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A2","name":"team.A2","color":"ededed","default":false},{"id":784873243,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.T16","name":"tutorial.T16","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/700/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/85a2deaf3d0bbdf915566155304d13b1dc01ac0b","head":{"label":"victortardieu:W5.11","ref":"W5.11","sha":"85a2deaf3d0bbdf915566155304d13b1dc01ac0b","user":{"login":"victortardieu","id":35592054,"avatar_url":"https://avatars3.githubusercontent.com/u/35592054?v=4","gravatar_id":"","url":"https://api.github.com/users/victortardieu","html_url":"https://github.com/victortardieu","followers_url":"https://api.github.com/users/victortardieu/followers","following_url":"https://api.github.com/users/victortardieu/following{/other_user}","gists_url":"https://api.github.com/users/victortardieu/gists{/gist_id}","starred_url":"https://api.github.com/users/victortardieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victortardieu/subscriptions","organizations_url":"https://api.github.com/users/victortardieu/orgs","repos_url":"https://api.github.com/users/victortardieu/repos","events_url":"https://api.github.com/users/victortardieu/events{/privacy}","received_events_url":"https://api.github.com/users/victortardieu/received_events","type":"User","site_admin":false},"repo":{"id":121388087,"name":"addressbook-level2","full_name":"victortardieu/addressbook-level2","owner":{"login":"victortardieu","id":35592054,"avatar_url":"https://avatars3.githubusercontent.com/u/35592054?v=4","gravatar_id":"","url":"https://api.github.com/users/victortardieu","html_url":"https://github.com/victortardieu","followers_url":"https://api.github.com/users/victortardieu/followers","following_url":"https://api.github.com/users/victortardieu/following{/other_user}","gists_url":"https://api.github.com/users/victortardieu/gists{/gist_id}","starred_url":"https://api.github.com/users/victortardieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victortardieu/subscriptions","organizations_url":"https://api.github.com/users/victortardieu/orgs","repos_url":"https://api.github.com/users/victortardieu/repos","events_url":"https://api.github.com/users/victortardieu/events{/privacy}","received_events_url":"https://api.github.com/users/victortardieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victortardieu/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/victortardieu/addressbook-level2","forks_url":"https://api.github.com/repos/victortardieu/addressbook-level2/forks","keys_url":"https://api.github.com/repos/victortardieu/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victortardieu/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victortardieu/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/victortardieu/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/victortardieu/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/victortardieu/addressbook-level2/events","assignees_url":"https://api.github.com/repos/victortardieu/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/victortardieu/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/victortardieu/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/victortardieu/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victortardieu/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victortardieu/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/victortardieu/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victortardieu/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/victortardieu/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/victortardieu/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/victortardieu/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/victortardieu/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/victortardieu/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/victortardieu/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/victortardieu/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/victortardieu/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/victortardieu/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/victortardieu/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/victortardieu/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victortardieu/addressbook-level2/merges","archive_url":"https://api.github.com/repos/victortardieu/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victortardieu/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/victortardieu/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/victortardieu/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/victortardieu/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/victortardieu/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victortardieu/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/victortardieu/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/victortardieu/addressbook-level2/deployments","created_at":"2018-02-13T13:51:09Z","updated_at":"2018-02-13T13:51:11Z","pushed_at":"2018-02-15T19:09:16Z","git_url":"git://github.com/victortardieu/addressbook-level2.git","ssh_url":"git@github.com:victortardieu/addressbook-level2.git","clone_url":"https://github.com/victortardieu/addressbook-level2.git","svn_url":"https://github.com/victortardieu/addressbook-level2","homepage":null,"size":3293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-10T03:00:19Z","pushed_at":"2018-02-16T11:30:32Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":544,"license":null,"forks":187,"open_issues":544,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/700"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/700"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/85a2deaf3d0bbdf915566155304d13b1dc01ac0b"}},"author_association":"NONE"}}
{"actor":{"display_login":"asiddharth"}}