{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/189259658","pull_request_review_id":121407598,"id":189259658,"diff_hunk":"@@ -10,7 +10,14 @@ stdenv.mkDerivation rec {\n     sha256 = \"0rp0r54z44is49c594qy7hr211nhb00aa5y7z74vsybbaxslg10z\";\n   };\n \n-  patches = ./debug-info-from-env.patch;\n+  patches = [\n+    ./debug-info-from-env.patch\n+    (fetchpatch {","path":"pkgs/development/tools/misc/elfutils/default.nix","position":13,"original_position":13,"commit_id":"8787699e4237821dda2de83bb9b574ad9fafabe7","original_commit_id":"8787699e4237821dda2de83bb9b574ad9fafabe7","user":{"login":"jtojnar","id":705123,"avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"body":"`fetchurl` should be enough here, it is just a static file.","created_at":"2018-05-18T12:58:20Z","updated_at":"2018-05-18T13:01:16Z","html_url":"https://github.com/NixOS/nixpkgs/pull/40705#discussion_r189259658","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/189259658"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40705#discussion_r189259658"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705","id":188865836,"html_url":"https://github.com/NixOS/nixpkgs/pull/40705","diff_url":"https://github.com/NixOS/nixpkgs/pull/40705.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/40705.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40705","number":40705,"state":"open","locked":false,"title":"elfutils: add patch that fixes compilation under gcc8","user":{"login":"Synthetica9","id":7075751,"avatar_url":"https://avatars0.githubusercontent.com/u/7075751?v=4","gravatar_id":"","url":"https://api.github.com/users/Synthetica9","html_url":"https://github.com/Synthetica9","followers_url":"https://api.github.com/users/Synthetica9/followers","following_url":"https://api.github.com/users/Synthetica9/following{/other_user}","gists_url":"https://api.github.com/users/Synthetica9/gists{/gist_id}","starred_url":"https://api.github.com/users/Synthetica9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synthetica9/subscriptions","organizations_url":"https://api.github.com/users/Synthetica9/orgs","repos_url":"https://api.github.com/users/Synthetica9/repos","events_url":"https://api.github.com/users/Synthetica9/events{/privacy}","received_events_url":"https://api.github.com/users/Synthetica9/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nWas failing: https://hydra.nixos.org/build/73828348/nixlog/2\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-05-17T21:26:16Z","updated_at":"2018-05-18T13:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6327cb360fdfca868f165c0abba54d2295f6421e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734374,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20101-500","name":"10.rebuild-linux: 101-500","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40705/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8787699e4237821dda2de83bb9b574ad9fafabe7","head":{"label":"Synthetica9:elfutils-gcc8-fix","ref":"elfutils-gcc8-fix","sha":"8787699e4237821dda2de83bb9b574ad9fafabe7","user":{"login":"Synthetica9","id":7075751,"avatar_url":"https://avatars0.githubusercontent.com/u/7075751?v=4","gravatar_id":"","url":"https://api.github.com/users/Synthetica9","html_url":"https://github.com/Synthetica9","followers_url":"https://api.github.com/users/Synthetica9/followers","following_url":"https://api.github.com/users/Synthetica9/following{/other_user}","gists_url":"https://api.github.com/users/Synthetica9/gists{/gist_id}","starred_url":"https://api.github.com/users/Synthetica9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synthetica9/subscriptions","organizations_url":"https://api.github.com/users/Synthetica9/orgs","repos_url":"https://api.github.com/users/Synthetica9/repos","events_url":"https://api.github.com/users/Synthetica9/events{/privacy}","received_events_url":"https://api.github.com/users/Synthetica9/received_events","type":"User","site_admin":false},"repo":{"id":114932160,"name":"nixpkgs","full_name":"Synthetica9/nixpkgs","owner":{"login":"Synthetica9","id":7075751,"avatar_url":"https://avatars0.githubusercontent.com/u/7075751?v=4","gravatar_id":"","url":"https://api.github.com/users/Synthetica9","html_url":"https://github.com/Synthetica9","followers_url":"https://api.github.com/users/Synthetica9/followers","following_url":"https://api.github.com/users/Synthetica9/following{/other_user}","gists_url":"https://api.github.com/users/Synthetica9/gists{/gist_id}","starred_url":"https://api.github.com/users/Synthetica9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synthetica9/subscriptions","organizations_url":"https://api.github.com/users/Synthetica9/orgs","repos_url":"https://api.github.com/users/Synthetica9/repos","events_url":"https://api.github.com/users/Synthetica9/events{/privacy}","received_events_url":"https://api.github.com/users/Synthetica9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Synthetica9/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Synthetica9/nixpkgs","forks_url":"https://api.github.com/repos/Synthetica9/nixpkgs/forks","keys_url":"https://api.github.com/repos/Synthetica9/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Synthetica9/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Synthetica9/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Synthetica9/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Synthetica9/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Synthetica9/nixpkgs/events","assignees_url":"https://api.github.com/repos/Synthetica9/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Synthetica9/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Synthetica9/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Synthetica9/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Synthetica9/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Synthetica9/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Synthetica9/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Synthetica9/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Synthetica9/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Synthetica9/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Synthetica9/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Synthetica9/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Synthetica9/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Synthetica9/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Synthetica9/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Synthetica9/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Synthetica9/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Synthetica9/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Synthetica9/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Synthetica9/nixpkgs/merges","archive_url":"https://api.github.com/repos/Synthetica9/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Synthetica9/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Synthetica9/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Synthetica9/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Synthetica9/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Synthetica9/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Synthetica9/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Synthetica9/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Synthetica9/nixpkgs/deployments","created_at":"2017-12-20T21:20:40Z","updated_at":"2018-05-03T11:20:48Z","pushed_at":"2018-05-17T23:23:50Z","git_url":"git://github.com/Synthetica9/nixpkgs.git","ssh_url":"git@github.com:Synthetica9/nixpkgs.git","clone_url":"https://github.com/Synthetica9/nixpkgs.git","svn_url":"https://github.com/Synthetica9/nixpkgs","homepage":null,"size":768797,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:gcc8","ref":"gcc8","sha":"456369f7e6ea0206b659377363f9c3c1d71b191a","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-05-18T12:30:08Z","pushed_at":"2018-05-18T12:53:42Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":790087,"stargazers_count":2428,"watchers_count":2428,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2776,"mirror_url":null,"archived":false,"open_issues_count":3120,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2776,"open_issues":3120,"watchers":2428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40705"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40705"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40705/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40705/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8787699e4237821dda2de83bb9b574ad9fafabe7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jtojnar"}}