{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/Ethr/issues/33","repository_url":"https://api.github.com/repos/Microsoft/Ethr","labels_url":"https://api.github.com/repos/Microsoft/Ethr/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/Ethr/issues/33/comments","events_url":"https://api.github.com/repos/Microsoft/Ethr/issues/33/events","html_url":"https://github.com/Microsoft/Ethr/issues/33","id":389619119,"node_id":"MDU6SXNzdWUzODk2MTkxMTk=","number":33,"title":"Lint the code and make it follow the golang conventions","user":{"login":"lylex","id":4638962,"node_id":"MDQ6VXNlcjQ2Mzg5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4638962?v=4","gravatar_id":"","url":"https://api.github.com/users/lylex","html_url":"https://github.com/lylex","followers_url":"https://api.github.com/users/lylex/followers","following_url":"https://api.github.com/users/lylex/following{/other_user}","gists_url":"https://api.github.com/users/lylex/gists{/gist_id}","starred_url":"https://api.github.com/users/lylex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylex/subscriptions","organizations_url":"https://api.github.com/users/lylex/orgs","repos_url":"https://api.github.com/users/lylex/repos","events_url":"https://api.github.com/users/lylex/events{/privacy}","received_events_url":"https://api.github.com/users/lylex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-11T06:48:01Z","updated_at":"2018-12-11T13:22:22Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"When I read the code, many warnings raises from my IDE. It looks like it is complaining about the golang naming/comment convention.\r\n\r\nIf you agree, I will fix them and add a Makefile to make it easy to find/fix."},"comment":{"url":"https://api.github.com/repos/Microsoft/Ethr/issues/comments/446200192","html_url":"https://github.com/Microsoft/Ethr/issues/33#issuecomment-446200192","issue_url":"https://api.github.com/repos/Microsoft/Ethr/issues/33","id":446200192,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjIwMDE5Mg==","user":{"login":"lylex","id":4638962,"node_id":"MDQ6VXNlcjQ2Mzg5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4638962?v=4","gravatar_id":"","url":"https://api.github.com/users/lylex","html_url":"https://github.com/lylex","followers_url":"https://api.github.com/users/lylex/followers","following_url":"https://api.github.com/users/lylex/following{/other_user}","gists_url":"https://api.github.com/users/lylex/gists{/gist_id}","starred_url":"https://api.github.com/users/lylex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylex/subscriptions","organizations_url":"https://api.github.com/users/lylex/orgs","repos_url":"https://api.github.com/users/lylex/repos","events_url":"https://api.github.com/users/lylex/events{/privacy}","received_events_url":"https://api.github.com/users/lylex/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T13:22:22Z","updated_at":"2018-12-11T13:22:22Z","author_association":"CONTRIBUTOR","body":"@pgmsft Here is some examples:\r\n\r\n- Indent\r\n\r\n```\r\n func (u *clientUi) printDbg(format string, a ...interface{}) {\r\n-    if logDebug {\r\n-        s := fmt.Sprintf(format, a...)\r\n-        logDbg(s)\r\n-        fmt.Println(s)\r\n-    }\r\n+       if logDebug {\r\n+               s := fmt.Sprintf(format, a...)\r\n+               logDbg(s)\r\n+               fmt.Println(s)\r\n+       }\r\n }\r\n```\r\n\r\n- Function return\r\n```\r\nclient.go:37:1: error should be the last type when returning multiple items\r\n```\r\n\r\n- Naming\r\n\r\n```\r\nclientui.go:14:6: type clientUi should be clientUI\r\n```\r\n```\r\nui.go:98:2: don't use underscores in Go names; var align_offset should be alignOffset\r\n```\r\n\r\n- Comment\r\n\r\n```\r\nutils.go:49:2: exported const UNO should have comment (or a comment on this block) or be unexported\r\n```"}}
{"actor":{"display_login":"lylex"}}