{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/208532501","pull_request_review_id":144357112,"id":208532501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUzMjUwMQ==","diff_hunk":"@@ -19,9 +19,7 @@ public class Bootstrap : MonoBehaviour\n \n         public const string LoggerName = \"Bootstrap\";\n \n-        private static readonly List<WorkerBase> Workers = new List<WorkerBase>();\n-\n-        private static ConnectionConfig connectionConfig;\n+        private static Dictionary<SpatialOSWorld, ConnectionConfig> WorldToConfig = new Dictionary<SpatialOSWorld, ConnectionConfig>();","path":"workers/unity/Assets/Playground/Scripts/Bootstrap.cs","position":7,"original_position":7,"commit_id":"8cad4c9334831465e16c6912195c36b2f6212308","original_commit_id":"8cad4c9334831465e16c6912195c36b2f6212308","user":{"login":"jamiebrynes7","id":13353733,"node_id":"MDQ6VXNlcjEzMzUzNzMz","avatar_url":"https://avatars1.githubusercontent.com/u/13353733?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiebrynes7","html_url":"https://github.com/jamiebrynes7","followers_url":"https://api.github.com/users/jamiebrynes7/followers","following_url":"https://api.github.com/users/jamiebrynes7/following{/other_user}","gists_url":"https://api.github.com/users/jamiebrynes7/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiebrynes7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiebrynes7/subscriptions","organizations_url":"https://api.github.com/users/jamiebrynes7/orgs","repos_url":"https://api.github.com/users/jamiebrynes7/repos","events_url":"https://api.github.com/users/jamiebrynes7/events{/privacy}","received_events_url":"https://api.github.com/users/jamiebrynes7/received_events","type":"User","site_admin":false},"body":"It feels weird to store the connection config here. \r\n\r\nIs there a reason the world/worker doesn't own it? ","created_at":"2018-08-08T10:32:01Z","updated_at":"2018-08-08T10:45:10Z","html_url":"https://github.com/spatialos/UnityGDK/pull/188#discussion_r208532501","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/208532501"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/188#discussion_r208532501"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188","id":206762429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzYyNDI5","html_url":"https://github.com/spatialos/UnityGDK/pull/188","diff_url":"https://github.com/spatialos/UnityGDK/pull/188.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/188.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/188","number":188,"state":"open","locked":false,"title":"[WIP] Creating the new worker abstraction","user":{"login":"jessicafalk","id":31853332,"node_id":"MDQ6VXNlcjMxODUzMzMy","avatar_url":"https://avatars3.githubusercontent.com/u/31853332?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicafalk","html_url":"https://github.com/jessicafalk","followers_url":"https://api.github.com/users/jessicafalk/followers","following_url":"https://api.github.com/users/jessicafalk/following{/other_user}","gists_url":"https://api.github.com/users/jessicafalk/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicafalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicafalk/subscriptions","organizations_url":"https://api.github.com/users/jessicafalk/orgs","repos_url":"https://api.github.com/users/jessicafalk/repos","events_url":"https://api.github.com/users/jessicafalk/events{/privacy}","received_events_url":"https://api.github.com/users/jessicafalk/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nripped everything  apart and created a new worker abstraction.\r\nshould be readable in commit order\r\n\r\n#### Tests\r\nit's a WIP pr. Testing still in progress\r\n\r\n#### Documentation\r\nwill be documented in the next pr\r\n\r\n#### Primary reviewers\r\n@jamiebrynes7 @samiwh ","created_at":"2018-08-07T16:51:26Z","updated_at":"2018-08-08T10:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99fcd50ada64398dc71eb34c9f8f182b720360d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zeroZshadow","id":3106728,"node_id":"MDQ6VXNlcjMxMDY3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/3106728?v=4","gravatar_id":"","url":"https://api.github.com/users/zeroZshadow","html_url":"https://github.com/zeroZshadow","followers_url":"https://api.github.com/users/zeroZshadow/followers","following_url":"https://api.github.com/users/zeroZshadow/following{/other_user}","gists_url":"https://api.github.com/users/zeroZshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroZshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroZshadow/subscriptions","organizations_url":"https://api.github.com/users/zeroZshadow/orgs","repos_url":"https://api.github.com/users/zeroZshadow/repos","events_url":"https://api.github.com/users/zeroZshadow/events{/privacy}","received_events_url":"https://api.github.com/users/zeroZshadow/received_events","type":"User","site_admin":false},{"login":"samiwh","id":14006669,"node_id":"MDQ6VXNlcjE0MDA2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/14006669?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwh","html_url":"https://github.com/samiwh","followers_url":"https://api.github.com/users/samiwh/followers","following_url":"https://api.github.com/users/samiwh/following{/other_user}","gists_url":"https://api.github.com/users/samiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwh/subscriptions","organizations_url":"https://api.github.com/users/samiwh/orgs","repos_url":"https://api.github.com/users/samiwh/repos","events_url":"https://api.github.com/users/samiwh/events{/privacy}","received_events_url":"https://api.github.com/users/samiwh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1017462251,"node_id":"MDU6TGFiZWwxMDE3NDYyMjUx","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"ededed","default":false},{"id":1002053376,"node_id":"MDU6TGFiZWwxMDAyMDUzMzc2","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/188/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/8cad4c9334831465e16c6912195c36b2f6212308","head":{"label":"spatialos:feature/clean-up-worker","ref":"feature/clean-up-worker","sha":"8cad4c9334831465e16c6912195c36b2f6212308","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-07T10:48:39Z","pushed_at":"2018-08-08T10:44:06Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":106007,"stargazers_count":74,"watchers_count":74,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":16,"watchers":74,"default_branch":"master"}},"base":{"label":"spatialos:experimental/worker-abstraction","ref":"experimental/worker-abstraction","sha":"c9dcadf6c9e20cf3469b02f992e91a7bd4b7f1e6","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-07T10:48:39Z","pushed_at":"2018-08-08T10:44:06Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":106007,"stargazers_count":74,"watchers_count":74,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":16,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/188"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/188"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/8cad4c9334831465e16c6912195c36b2f6212308"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jamiebrynes7"}}