{"action":"created","issue":{"url":"https://api.github.com/repos/systemed/tilemaker/issues/88","repository_url":"https://api.github.com/repos/systemed/tilemaker","labels_url":"https://api.github.com/repos/systemed/tilemaker/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/systemed/tilemaker/issues/88/comments","events_url":"https://api.github.com/repos/systemed/tilemaker/issues/88/events","html_url":"https://github.com/systemed/tilemaker/issues/88","id":244808387,"number":88,"title":"\"Vector tile source does not use vector tile spec v2 and therefore may have some rendering errors\"","user":{"login":"robhawkes","id":22612,"avatar_url":"https://avatars2.githubusercontent.com/u/22612?v=4","gravatar_id":"","url":"https://api.github.com/users/robhawkes","html_url":"https://github.com/robhawkes","followers_url":"https://api.github.com/users/robhawkes/followers","following_url":"https://api.github.com/users/robhawkes/following{/other_user}","gists_url":"https://api.github.com/users/robhawkes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhawkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhawkes/subscriptions","organizations_url":"https://api.github.com/users/robhawkes/orgs","repos_url":"https://api.github.com/users/robhawkes/repos","events_url":"https://api.github.com/users/robhawkes/events{/privacy}","received_events_url":"https://api.github.com/users/robhawkes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/systemed/tilemaker/milestones/1","html_url":"https://github.com/systemed/tilemaker/milestone/1","labels_url":"https://api.github.com/repos/systemed/tilemaker/milestones/1/labels","id":2682046,"number":1,"title":"1.5","description":"","creator":{"login":"systemed","id":694425,"avatar_url":"https://avatars1.githubusercontent.com/u/694425?v=4","gravatar_id":"","url":"https://api.github.com/users/systemed","html_url":"https://github.com/systemed","followers_url":"https://api.github.com/users/systemed/followers","following_url":"https://api.github.com/users/systemed/following{/other_user}","gists_url":"https://api.github.com/users/systemed/gists{/gist_id}","starred_url":"https://api.github.com/users/systemed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemed/subscriptions","organizations_url":"https://api.github.com/users/systemed/orgs","repos_url":"https://api.github.com/users/systemed/repos","events_url":"https://api.github.com/users/systemed/events{/privacy}","received_events_url":"https://api.github.com/users/systemed/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":4,"state":"open","created_at":"2017-08-04T19:16:05Z","updated_at":"2018-02-18T15:48:38Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2017-07-21T23:54:37Z","updated_at":"2018-02-18T15:48:38Z","closed_at":"2018-02-18T15:48:38Z","author_association":"NONE","body":"I'm currently serving the exported MBTiles from `tilemaker` using `tileserver-gl-light` and visualising everything in Mapbox GL JS. I noticed that Mapbox GL JS spits out warnings for each tile along the lines of `Vector tile source does not use vector tile spec v2 and therefore may have some rendering errors`.\r\n\r\nAfter digging around I found that this is because the tiles generated by `tilemaker` [have their spec version number hard-coded to `1`](https://github.com/systemed/tilemaker/blob/master/src/tilemaker.cpp#L289) causing Mapbox GL JS to get angry. If I change that hard-coded version number to `2` then the warnings disappear.\r\n\r\nNow this is enough for me as Mapbox GL JS seems to be happy that the tiles are using [version 2 of the Mapbox Vector Style Spec](https://www.mapbox.com/vector-tiles/specification/). However it's probably worth discussing how `tilemaker` can be officially brought inline to support version 2 of the spec.\r\n\r\nHas this been looked into yet?"},"comment":{"url":"https://api.github.com/repos/systemed/tilemaker/issues/comments/366525254","html_url":"https://github.com/systemed/tilemaker/issues/88#issuecomment-366525254","issue_url":"https://api.github.com/repos/systemed/tilemaker/issues/88","id":366525254,"user":{"login":"systemed","id":694425,"avatar_url":"https://avatars1.githubusercontent.com/u/694425?v=4","gravatar_id":"","url":"https://api.github.com/users/systemed","html_url":"https://github.com/systemed","followers_url":"https://api.github.com/users/systemed/followers","following_url":"https://api.github.com/users/systemed/following{/other_user}","gists_url":"https://api.github.com/users/systemed/gists{/gist_id}","starred_url":"https://api.github.com/users/systemed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemed/subscriptions","organizations_url":"https://api.github.com/users/systemed/orgs","repos_url":"https://api.github.com/users/systemed/repos","events_url":"https://api.github.com/users/systemed/events{/privacy}","received_events_url":"https://api.github.com/users/systemed/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T15:48:38Z","updated_at":"2018-02-18T15:48:38Z","author_association":"OWNER","body":"Closing as I believe this is fixed now, but let me know if not."}}
{"actor":{"display_login":"systemed"}}