{"action":"created","comment":{"url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/comments/202828359","pull_request_review_id":137601644,"id":202828359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjgyODM1OQ==","diff_hunk":"@@ -13,6 +13,13 @@\n     \"sourceType\": \"module\",\n     \"ecmaVersion\": 6\n   },\n+  \"overrides\": [\n+    {\n+      \"files\": [\"src/**/*.js\", \"src/**/*.vue\"],\n+      \"excludedFiles\": \"*.test.js\"","path":".eslintrc.json","position":7,"original_position":7,"commit_id":"f757b4d87e3afd2a5889167aa085ef16dba34a82","original_commit_id":"f757b4d87e3afd2a5889167aa085ef16dba34a82","user":{"login":"amycheng","id":1952460,"node_id":"MDQ6VXNlcjE5NTI0NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1952460?v=4","gravatar_id":"","url":"https://api.github.com/users/amycheng","html_url":"https://github.com/amycheng","followers_url":"https://api.github.com/users/amycheng/followers","following_url":"https://api.github.com/users/amycheng/following{/other_user}","gists_url":"https://api.github.com/users/amycheng/gists{/gist_id}","starred_url":"https://api.github.com/users/amycheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amycheng/subscriptions","organizations_url":"https://api.github.com/users/amycheng/orgs","repos_url":"https://api.github.com/users/amycheng/repos","events_url":"https://api.github.com/users/amycheng/events{/privacy}","received_events_url":"https://api.github.com/users/amycheng/received_events","type":"User","site_admin":false},"body":"I'm linting for `TODO` statements, but would like to leave them in tests as a breadcrumb for me or the next developer.","created_at":"2018-07-16T21:19:54Z","updated_at":"2018-07-16T21:19:54Z","html_url":"https://github.com/nymag/clay-space-edit/pull/109#discussion_r202828359","pull_request_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/comments/202828359"},"html":{"href":"https://github.com/nymag/clay-space-edit/pull/109#discussion_r202828359"},"pull_request":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109"}},"in_reply_to_id":202810489},"pull_request":{"url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109","id":201368181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzY4MTgx","html_url":"https://github.com/nymag/clay-space-edit/pull/109","diff_url":"https://github.com/nymag/clay-space-edit/pull/109.diff","patch_url":"https://github.com/nymag/clay-space-edit/pull/109.patch","issue_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/109","number":109,"state":"open","locked":false,"title":"Jest Test Suite Set-up and some tests","user":{"login":"amycheng","id":1952460,"node_id":"MDQ6VXNlcjE5NTI0NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1952460?v=4","gravatar_id":"","url":"https://api.github.com/users/amycheng","html_url":"https://github.com/amycheng","followers_url":"https://api.github.com/users/amycheng/followers","following_url":"https://api.github.com/users/amycheng/following{/other_user}","gists_url":"https://api.github.com/users/amycheng/gists{/gist_id}","starred_url":"https://api.github.com/users/amycheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amycheng/subscriptions","organizations_url":"https://api.github.com/users/amycheng/orgs","repos_url":"https://api.github.com/users/amycheng/repos","events_url":"https://api.github.com/users/amycheng/events{/privacy}","received_events_url":"https://api.github.com/users/amycheng/received_events","type":"User","site_admin":false},"body":"related https://github.com/nymag/clay-space-edit/issues/20\r\n\r\n**This PR includes**:\r\n- setting up the Jest test suite\r\n- upgrading CircleCI config to v. 2\r\n- tests for some services, specifically for the `add`, `create`, `remove`, `toggle` services\r\n\r\n**The kind of feedback I'm looking for**:\r\n- do the config files for Jest and CircleCI look correct? Could they be written better?\r\n- are we testing the correct things? Do the test names make sense? I am hoping that the tests serve as decent documentation as to what these services are doing.\r\n- is there a better way to mock dependencies?\r\n\r\n**Notes**:\r\nYou'll notice that a lot of tests are asserting if a `dispatch` object is being defined correctly. `clay-space-edit` is a plugin that hooks into Kiln's [Vuex](https://vuex.vuejs.org/) (the thing we're using do state management in Kiln) store and in order to trigger things that Kiln handles (like updating components), `clay-space-edit` sends a [dispatch](https://vuex.vuejs.org/guide/actions.html#dispatching-actions) to trigger actions. Instead of mocking all of Vuex, I'm just sending dispatches to an array, [here](https://github.com/nymag/clay-space-edit/blob/testing/test/utils.js#L21)","created_at":"2018-07-13T18:34:13Z","updated_at":"2018-07-16T21:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"287525660afaaf2ba3e125b7323c20c9fb6b9f00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109/commits","review_comments_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109/comments","review_comment_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/109/comments","statuses_url":"https://api.github.com/repos/nymag/clay-space-edit/statuses/f757b4d87e3afd2a5889167aa085ef16dba34a82","head":{"label":"nymag:testing","ref":"testing","sha":"f757b4d87e3afd2a5889167aa085ef16dba34a82","user":{"login":"nymag","id":1136688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY2ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1136688?v=4","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"repo":{"id":65501780,"node_id":"MDEwOlJlcG9zaXRvcnk2NTUwMTc4MA==","name":"clay-space-edit","full_name":"nymag/clay-space-edit","owner":{"login":"nymag","id":1136688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY2ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1136688?v=4","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nymag/clay-space-edit","description":"The editing experience behind the Clay Space component","fork":false,"url":"https://api.github.com/repos/nymag/clay-space-edit","forks_url":"https://api.github.com/repos/nymag/clay-space-edit/forks","keys_url":"https://api.github.com/repos/nymag/clay-space-edit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nymag/clay-space-edit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nymag/clay-space-edit/teams","hooks_url":"https://api.github.com/repos/nymag/clay-space-edit/hooks","issue_events_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/events{/number}","events_url":"https://api.github.com/repos/nymag/clay-space-edit/events","assignees_url":"https://api.github.com/repos/nymag/clay-space-edit/assignees{/user}","branches_url":"https://api.github.com/repos/nymag/clay-space-edit/branches{/branch}","tags_url":"https://api.github.com/repos/nymag/clay-space-edit/tags","blobs_url":"https://api.github.com/repos/nymag/clay-space-edit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nymag/clay-space-edit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nymag/clay-space-edit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nymag/clay-space-edit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nymag/clay-space-edit/statuses/{sha}","languages_url":"https://api.github.com/repos/nymag/clay-space-edit/languages","stargazers_url":"https://api.github.com/repos/nymag/clay-space-edit/stargazers","contributors_url":"https://api.github.com/repos/nymag/clay-space-edit/contributors","subscribers_url":"https://api.github.com/repos/nymag/clay-space-edit/subscribers","subscription_url":"https://api.github.com/repos/nymag/clay-space-edit/subscription","commits_url":"https://api.github.com/repos/nymag/clay-space-edit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nymag/clay-space-edit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nymag/clay-space-edit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nymag/clay-space-edit/contents/{+path}","compare_url":"https://api.github.com/repos/nymag/clay-space-edit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nymag/clay-space-edit/merges","archive_url":"https://api.github.com/repos/nymag/clay-space-edit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nymag/clay-space-edit/downloads","issues_url":"https://api.github.com/repos/nymag/clay-space-edit/issues{/number}","pulls_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls{/number}","milestones_url":"https://api.github.com/repos/nymag/clay-space-edit/milestones{/number}","notifications_url":"https://api.github.com/repos/nymag/clay-space-edit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nymag/clay-space-edit/labels{/name}","releases_url":"https://api.github.com/repos/nymag/clay-space-edit/releases{/id}","deployments_url":"https://api.github.com/repos/nymag/clay-space-edit/deployments","created_at":"2016-08-11T21:10:38Z","updated_at":"2018-07-10T19:13:29Z","pushed_at":"2018-07-16T19:29:43Z","git_url":"git://github.com/nymag/clay-space-edit.git","ssh_url":"git@github.com:nymag/clay-space-edit.git","clone_url":"https://github.com/nymag/clay-space-edit.git","svn_url":"https://github.com/nymag/clay-space-edit","homepage":"","size":656,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"nymag:master","ref":"master","sha":"ff082cba8e9626c60961e5e400658e50063b35ea","user":{"login":"nymag","id":1136688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY2ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1136688?v=4","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"repo":{"id":65501780,"node_id":"MDEwOlJlcG9zaXRvcnk2NTUwMTc4MA==","name":"clay-space-edit","full_name":"nymag/clay-space-edit","owner":{"login":"nymag","id":1136688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzY2ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1136688?v=4","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nymag/clay-space-edit","description":"The editing experience behind the Clay Space component","fork":false,"url":"https://api.github.com/repos/nymag/clay-space-edit","forks_url":"https://api.github.com/repos/nymag/clay-space-edit/forks","keys_url":"https://api.github.com/repos/nymag/clay-space-edit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nymag/clay-space-edit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nymag/clay-space-edit/teams","hooks_url":"https://api.github.com/repos/nymag/clay-space-edit/hooks","issue_events_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/events{/number}","events_url":"https://api.github.com/repos/nymag/clay-space-edit/events","assignees_url":"https://api.github.com/repos/nymag/clay-space-edit/assignees{/user}","branches_url":"https://api.github.com/repos/nymag/clay-space-edit/branches{/branch}","tags_url":"https://api.github.com/repos/nymag/clay-space-edit/tags","blobs_url":"https://api.github.com/repos/nymag/clay-space-edit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nymag/clay-space-edit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nymag/clay-space-edit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nymag/clay-space-edit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nymag/clay-space-edit/statuses/{sha}","languages_url":"https://api.github.com/repos/nymag/clay-space-edit/languages","stargazers_url":"https://api.github.com/repos/nymag/clay-space-edit/stargazers","contributors_url":"https://api.github.com/repos/nymag/clay-space-edit/contributors","subscribers_url":"https://api.github.com/repos/nymag/clay-space-edit/subscribers","subscription_url":"https://api.github.com/repos/nymag/clay-space-edit/subscription","commits_url":"https://api.github.com/repos/nymag/clay-space-edit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nymag/clay-space-edit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nymag/clay-space-edit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nymag/clay-space-edit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nymag/clay-space-edit/contents/{+path}","compare_url":"https://api.github.com/repos/nymag/clay-space-edit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nymag/clay-space-edit/merges","archive_url":"https://api.github.com/repos/nymag/clay-space-edit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nymag/clay-space-edit/downloads","issues_url":"https://api.github.com/repos/nymag/clay-space-edit/issues{/number}","pulls_url":"https://api.github.com/repos/nymag/clay-space-edit/pulls{/number}","milestones_url":"https://api.github.com/repos/nymag/clay-space-edit/milestones{/number}","notifications_url":"https://api.github.com/repos/nymag/clay-space-edit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nymag/clay-space-edit/labels{/name}","releases_url":"https://api.github.com/repos/nymag/clay-space-edit/releases{/id}","deployments_url":"https://api.github.com/repos/nymag/clay-space-edit/deployments","created_at":"2016-08-11T21:10:38Z","updated_at":"2018-07-10T19:13:29Z","pushed_at":"2018-07-16T19:29:43Z","git_url":"git://github.com/nymag/clay-space-edit.git","ssh_url":"git@github.com:nymag/clay-space-edit.git","clone_url":"https://github.com/nymag/clay-space-edit.git","svn_url":"https://github.com/nymag/clay-space-edit","homepage":"","size":656,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109"},"html":{"href":"https://github.com/nymag/clay-space-edit/pull/109"},"issue":{"href":"https://api.github.com/repos/nymag/clay-space-edit/issues/109"},"comments":{"href":"https://api.github.com/repos/nymag/clay-space-edit/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nymag/clay-space-edit/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/nymag/clay-space-edit/statuses/f757b4d87e3afd2a5889167aa085ef16dba34a82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amycheng"}}