{"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/datatable/pulls/comments/240021946","pull_request_review_id":182962647,"id":240021946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAyMTk0Ng==","diff_hunk":"@@ -24,60 +24,60 @@\n #include \"python/int.h\"\n #include \"python/tuple.h\"\n #include \"extras/py_ftrl.h\"\n-\n namespace py {\n \n+\n PKArgs Ftrl::Type::args___init__(1, 0, 7, false, false,\n                                  {\"params\", \"alpha\", \"beta\", \"lambda1\",\n                                  \"lambda2\", \"d\", \"n_epochs\", \"inter\"},\n                                  \"__init__\", nullptr);\n \n-std::vector<strpair> Ftrl::params_fields_info = {\n-  strpair(\"alpha\", \"`alpha` in per-coordinate FTRL-Proximal algorithm\"),\n-  strpair(\"beta\", \"`beta` in per-coordinate FTRL-Proximal algorithm\"),\n-  strpair(\"lambda1\", \"L1 regularization parameter\"),\n-  strpair(\"lambda2\", \"L1 regularization parameter\"),\n-  strpair(\"d\", \"Number of bins to be used for the hashing trick\"),\n-  strpair(\"n_epochs\", \"Number of epochs to train a model for\"),\n-  strpair(\"inter\", \"Parameter that controls if feature interactions to be used \"\n-                   \"or not\")\n-};\n-strpair Ftrl::params_info = strpair(\"Params\", \"FTRL model parameters\");\n-onamedtupletype Ftrl::params_nttype(Ftrl::params_info,\n-                                    Ftrl::params_fields_info);\n+static const char* doc_alpha    = \"`alpha` in per-coordinate FTRL-Proximal algorithm\";\n+static const char* doc_beta     = \"`beta` in per-coordinate FTRL-Proximal algorithm\";\n+static const char* doc_lambda1  = \"L1 regularization parameter\";\n+static const char* doc_lambda2  = \"L2 regularization parameter\";\n+static const char* doc_d        = \"Number of bins to be used for the hashing trick\";\n+static const char* doc_n_epochs = \"Number of epochs to train a model\";\n+static const char* doc_inter    = \"Parameter that controls if feature interactions to be used or not\";\n+","path":"c/extras/py_ftrl.cc","position":33,"original_position":33,"commit_id":"92e9f8df4d5258e59e4a6d9c632d06bcafbd6070","original_commit_id":"92e9f8df4d5258e59e4a6d9c632d06bcafbd6070","user":{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false},"body":"I'm not sure how this could work? Parameters have different types, different value constraints, tied to different fields in the Ftrl class, their getters/setters must each be separate functions, etc. If you do come up with an interesting approach here, it would be very quick to put the docstrings into an array.","created_at":"2018-12-09T02:11:30Z","updated_at":"2018-12-09T02:11:58Z","html_url":"https://github.com/h2oai/datatable/pull/1471#discussion_r240021946","pull_request_url":"https://api.github.com/repos/h2oai/datatable/pulls/1471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/comments/240021946"},"html":{"href":"https://github.com/h2oai/datatable/pull/1471#discussion_r240021946"},"pull_request":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1471"}},"in_reply_to_id":240020056},"pull_request":{"url":"https://api.github.com/repos/h2oai/datatable/pulls/1471","id":237091538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDkxNTM4","html_url":"https://github.com/h2oai/datatable/pull/1471","diff_url":"https://github.com/h2oai/datatable/pull/1471.diff","patch_url":"https://github.com/h2oai/datatable/pull/1471.patch","issue_url":"https://api.github.com/repos/h2oai/datatable/issues/1471","number":1471,"state":"open","locked":false,"title":"namedtuple API adjustments","user":{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false},"body":"- prefer C++ `using` instead of `typedef`;\r\n- fixed docstring of parameter `lambda2`;\r\n- use `std::string`s instead of `const char*` for namedtuple construction;\r\n- rename `Params` -> `FtrlParams`;\r\n- defer creation of `FtrlParams` named tuple type until it is actually needed;\r\n- add another constructor for `onamedtuple`, without the docstrings;\r\n- add copy/move constructor for `onamedtuple` and `onamedtupletype`.","created_at":"2018-12-08T21:09:00Z","updated_at":"2018-12-09T02:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae1a6b574beb8236ca9a9da0f9269a0a5457dfb8","assignee":{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false},"assignees":[{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/datatable/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/h2oai/datatable/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/h2oai/datatable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/datatable/issues/1471/comments","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/92e9f8df4d5258e59e4a6d9c632d06bcafbd6070","head":{"label":"h2oai:minor","ref":"minor","sha":"92e9f8df4d5258e59e4a6d9c632d06bcafbd6070","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":83748372,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzc0ODM3Mg==","name":"datatable","full_name":"h2oai/datatable","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/datatable","description":"data.table for Python","fork":false,"url":"https://api.github.com/repos/h2oai/datatable","forks_url":"https://api.github.com/repos/h2oai/datatable/forks","keys_url":"https://api.github.com/repos/h2oai/datatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/datatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/datatable/teams","hooks_url":"https://api.github.com/repos/h2oai/datatable/hooks","issue_events_url":"https://api.github.com/repos/h2oai/datatable/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/datatable/events","assignees_url":"https://api.github.com/repos/h2oai/datatable/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/datatable/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/datatable/tags","blobs_url":"https://api.github.com/repos/h2oai/datatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/datatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/datatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/datatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/datatable/languages","stargazers_url":"https://api.github.com/repos/h2oai/datatable/stargazers","contributors_url":"https://api.github.com/repos/h2oai/datatable/contributors","subscribers_url":"https://api.github.com/repos/h2oai/datatable/subscribers","subscription_url":"https://api.github.com/repos/h2oai/datatable/subscription","commits_url":"https://api.github.com/repos/h2oai/datatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/datatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/datatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/datatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/datatable/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/datatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/datatable/merges","archive_url":"https://api.github.com/repos/h2oai/datatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/datatable/downloads","issues_url":"https://api.github.com/repos/h2oai/datatable/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/datatable/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/datatable/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/datatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/datatable/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/datatable/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/datatable/deployments","created_at":"2017-03-03T02:32:59Z","updated_at":"2018-12-08T18:40:39Z","pushed_at":"2018-12-08T21:11:19Z","git_url":"git://github.com/h2oai/datatable.git","ssh_url":"git@github.com:h2oai/datatable.git","clone_url":"https://github.com/h2oai/datatable.git","svn_url":"https://github.com/h2oai/datatable","homepage":null,"size":4775,"stargazers_count":262,"watchers_count":262,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":17,"open_issues":73,"watchers":262,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"4e53a14cd53ebc58b49a3dab28f42f88329f1876","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":83748372,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzc0ODM3Mg==","name":"datatable","full_name":"h2oai/datatable","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/datatable","description":"data.table for Python","fork":false,"url":"https://api.github.com/repos/h2oai/datatable","forks_url":"https://api.github.com/repos/h2oai/datatable/forks","keys_url":"https://api.github.com/repos/h2oai/datatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/datatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/datatable/teams","hooks_url":"https://api.github.com/repos/h2oai/datatable/hooks","issue_events_url":"https://api.github.com/repos/h2oai/datatable/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/datatable/events","assignees_url":"https://api.github.com/repos/h2oai/datatable/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/datatable/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/datatable/tags","blobs_url":"https://api.github.com/repos/h2oai/datatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/datatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/datatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/datatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/datatable/languages","stargazers_url":"https://api.github.com/repos/h2oai/datatable/stargazers","contributors_url":"https://api.github.com/repos/h2oai/datatable/contributors","subscribers_url":"https://api.github.com/repos/h2oai/datatable/subscribers","subscription_url":"https://api.github.com/repos/h2oai/datatable/subscription","commits_url":"https://api.github.com/repos/h2oai/datatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/datatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/datatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/datatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/datatable/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/datatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/datatable/merges","archive_url":"https://api.github.com/repos/h2oai/datatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/datatable/downloads","issues_url":"https://api.github.com/repos/h2oai/datatable/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/datatable/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/datatable/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/datatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/datatable/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/datatable/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/datatable/deployments","created_at":"2017-03-03T02:32:59Z","updated_at":"2018-12-08T18:40:39Z","pushed_at":"2018-12-08T21:11:19Z","git_url":"git://github.com/h2oai/datatable.git","ssh_url":"git@github.com:h2oai/datatable.git","clone_url":"https://github.com/h2oai/datatable.git","svn_url":"https://github.com/h2oai/datatable","homepage":null,"size":4775,"stargazers_count":262,"watchers_count":262,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":17,"open_issues":73,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1471"},"html":{"href":"https://github.com/h2oai/datatable/pull/1471"},"issue":{"href":"https://api.github.com/repos/h2oai/datatable/issues/1471"},"comments":{"href":"https://api.github.com/repos/h2oai/datatable/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/datatable/statuses/92e9f8df4d5258e59e4a6d9c632d06bcafbd6070"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"st-pasha"}}