{"action":"closed","number":4614,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/4614","id":179923297,"html_url":"https://github.com/libgit2/libgit2/pull/4614","diff_url":"https://github.com/libgit2/libgit2/pull/4614.diff","patch_url":"https://github.com/libgit2/libgit2/pull/4614.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/4614","number":4614,"state":"closed","locked":false,"title":"attr_file: fix handling of directory patterns with trailing spaces","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars1.githubusercontent.com/u/4056630?v=4","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"When comparing whether a path matches a directory rule, we pass the\r\nboth the path and directory name to `fnmatch` with\r\n`GIT_ATTR_FNMATCH_DIRECTORY` being set. `fnmatch` expects the pattern to\r\ncontain no trailing directory '/', which is why we try to always strip\r\npatterns of trailing slashes. We do not handle that case correctly\r\nthough when the pattern itself has trailing spaces, causing the match to\r\nfail.\r\n\r\nFix the issue by stripping trailing spaces and tabs for a rule previous\r\nto checking whether the pattern is a directory pattern with a trailing\r\n'/'. Add a test to catch future breakage.","created_at":"2018-04-06T11:33:00Z","updated_at":"2018-04-16T14:19:38Z","closed_at":"2018-04-16T14:19:38Z","merged_at":"2018-04-16T14:19:38Z","merge_commit_sha":"69870a67f54aac39115d4822da4ab5f289174e81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":801638778,"url":"https://api.github.com/repos/libgit2/libgit2/labels/backport","name":"backport","color":"d16a53","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4614/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4614/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/4614/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/251d8771214e91f7118182aed166f649e3914e28","head":{"label":"pks-t:pks/gitignore-trailing-spaces","ref":"pks/gitignore-trailing-spaces","sha":"251d8771214e91f7118182aed166f649e3914e28","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars1.githubusercontent.com/u/4056630?v=4","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"repo":{"id":29849449,"name":"libgit2","full_name":"pks-t/libgit2","owner":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars1.githubusercontent.com/u/4056630?v=4","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pks-t/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/pks-t/libgit2","forks_url":"https://api.github.com/repos/pks-t/libgit2/forks","keys_url":"https://api.github.com/repos/pks-t/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pks-t/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pks-t/libgit2/teams","hooks_url":"https://api.github.com/repos/pks-t/libgit2/hooks","issue_events_url":"https://api.github.com/repos/pks-t/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/pks-t/libgit2/events","assignees_url":"https://api.github.com/repos/pks-t/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/pks-t/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/pks-t/libgit2/tags","blobs_url":"https://api.github.com/repos/pks-t/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pks-t/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pks-t/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pks-t/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pks-t/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/pks-t/libgit2/languages","stargazers_url":"https://api.github.com/repos/pks-t/libgit2/stargazers","contributors_url":"https://api.github.com/repos/pks-t/libgit2/contributors","subscribers_url":"https://api.github.com/repos/pks-t/libgit2/subscribers","subscription_url":"https://api.github.com/repos/pks-t/libgit2/subscription","commits_url":"https://api.github.com/repos/pks-t/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pks-t/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pks-t/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pks-t/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pks-t/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/pks-t/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pks-t/libgit2/merges","archive_url":"https://api.github.com/repos/pks-t/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pks-t/libgit2/downloads","issues_url":"https://api.github.com/repos/pks-t/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/pks-t/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/pks-t/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/pks-t/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pks-t/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/pks-t/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/pks-t/libgit2/deployments","created_at":"2015-01-26T07:12:59Z","updated_at":"2016-10-28T10:37:55Z","pushed_at":"2018-04-12T13:30:57Z","git_url":"git://github.com/pks-t/libgit2.git","ssh_url":"git@github.com:pks-t/libgit2.git","clone_url":"https://github.com/pks-t/libgit2.git","svn_url":"https://github.com/pks-t/libgit2","homepage":"http://libgit2.github.com","size":24197,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"0eca42304a10c9ad6170a38a440dfab8e354d38d","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"A cross-platform, linkable library implementation of Git that you can use in your application.","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2018-04-16T09:02:45Z","pushed_at":"2018-04-16T14:19:38Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"https://libgit2.org/","size":37727,"stargazers_count":6438,"watchers_count":6438,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1646,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1646,"open_issues":277,"watchers":6438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4614"},"html":{"href":"https://github.com/libgit2/libgit2/pull/4614"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4614"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4614/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4614/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4614/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/251d8771214e91f7118182aed166f649e3914e28"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars1.githubusercontent.com/u/1130014?v=4","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":21,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"ethomson"}}