{"action":"closed","number":2122,"pull_request":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/2122","id":203715818,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzE1ODE4","html_url":"https://github.com/uber/deck.gl/pull/2122","diff_url":"https://github.com/uber/deck.gl/pull/2122.diff","patch_url":"https://github.com/uber/deck.gl/pull/2122.patch","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/2122","number":2122,"state":"closed","locked":false,"title":"GPUAggregator: Set ONE uniform for fp64 module","user":{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false},"body":"<!-- For feature, feature enhancement or bug fix, create an issue first and finish To Do List there -->\r\n<!-- Anything doesn't work as expected is a bug, including code, doc and test -->\r\nFor #2121\r\n<!-- For other PRs without open issue -->\r\n#### Background\r\nOn Intel GPUs `fp64` shader module uses `LUMA_FP64_CODE_ELIMINATION_WORKAROUND`, which uses a const uniform `ONE` always. For all layers this is provided as part of base `Layer` class. Set this uniform explicitly for GPU Aggregation path. \r\n<!-- For all the PRs -->\r\n#### Change List\r\n- GPUAggregator: Set ONE uniform for fp64 module\r\n","created_at":"2018-07-25T04:06:26Z","updated_at":"2018-07-25T21:31:41Z","closed_at":"2018-07-25T21:31:41Z","merged_at":"2018-07-25T21:31:41Z","merge_commit_sha":"151e2ef87c29cbb807ee078cf48e5ed9b42d8085","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Pessimistress","id":2059298,"node_id":"MDQ6VXNlcjIwNTkyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/deck.gl/pulls/2122/commits","review_comments_url":"https://api.github.com/repos/uber/deck.gl/pulls/2122/comments","review_comment_url":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/2122/comments","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/4172156868c084c56b03cc30d11ca0d63e5e6e29","head":{"label":"uber:GPUAgg6.0","ref":"GPUAgg6.0","sha":"4172156868c084c56b03cc30d11ca0d63e5e6e29","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAzMDIwNA==","name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"WebGL2 powered geospatial visualization layers","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2018-07-25T17:13:10Z","pushed_at":"2018-07-25T21:31:41Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"http://uber.github.io/deck.gl","size":122841,"stargazers_count":4852,"watchers_count":4852,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":677,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":677,"open_issues":132,"watchers":4852,"default_branch":"master"}},"base":{"label":"uber:6.0-release","ref":"6.0-release","sha":"81de0ed884b8c23080a08f0d9e88f1039e516c27","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAzMDIwNA==","name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"WebGL2 powered geospatial visualization layers","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2018-07-25T17:13:10Z","pushed_at":"2018-07-25T21:31:41Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"http://uber.github.io/deck.gl","size":122841,"stargazers_count":4852,"watchers_count":4852,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":677,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":677,"open_issues":132,"watchers":4852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/2122"},"html":{"href":"https://github.com/uber/deck.gl/pull/2122"},"issue":{"href":"https://api.github.com/repos/uber/deck.gl/issues/2122"},"comments":{"href":"https://api.github.com/repos/uber/deck.gl/issues/2122/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/2122/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/2122/commits"},"statuses":{"href":"https://api.github.com/repos/uber/deck.gl/statuses/4172156868c084c56b03cc30d11ca0d63e5e6e29"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"1chandu"}}