{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27394","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27394/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27394/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27394/events","html_url":"https://github.com/Automattic/wp-calypso/pull/27394","id":363054724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTg2MDA1","number":27394,"title":"chore: update 'he' to 1.2.0","user":{"login":"flootr","id":9202899,"node_id":"MDQ6VXNlcjkyMDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9202899?v=4","gravatar_id":"","url":"https://api.github.com/users/flootr","html_url":"https://github.com/flootr","followers_url":"https://api.github.com/users/flootr/followers","following_url":"https://api.github.com/users/flootr/following{/other_user}","gists_url":"https://api.github.com/users/flootr/gists{/gist_id}","starred_url":"https://api.github.com/users/flootr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flootr/subscriptions","organizations_url":"https://api.github.com/users/flootr/orgs","repos_url":"https://api.github.com/users/flootr/repos","events_url":"https://api.github.com/users/flootr/events{/privacy}","received_events_url":"https://api.github.com/users/flootr/received_events","type":"User","site_admin":false},"labels":[{"id":285009988,"node_id":"MDU6TGFiZWwyODUwMDk5ODg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"c5def5","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":838866001,"node_id":"MDU6TGFiZWw4Mzg4NjYwMDE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20e2e%20Testing","name":"[Status] Needs e2e Testing","color":"ed74b2","default":false}],"state":"open","locked":false,"assignee":{"login":"flootr","id":9202899,"node_id":"MDQ6VXNlcjkyMDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9202899?v=4","gravatar_id":"","url":"https://api.github.com/users/flootr","html_url":"https://github.com/flootr","followers_url":"https://api.github.com/users/flootr/followers","following_url":"https://api.github.com/users/flootr/following{/other_user}","gists_url":"https://api.github.com/users/flootr/gists{/gist_id}","starred_url":"https://api.github.com/users/flootr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flootr/subscriptions","organizations_url":"https://api.github.com/users/flootr/orgs","repos_url":"https://api.github.com/users/flootr/repos","events_url":"https://api.github.com/users/flootr/events{/privacy}","received_events_url":"https://api.github.com/users/flootr/received_events","type":"User","site_admin":false},"assignees":[{"login":"flootr","id":9202899,"node_id":"MDQ6VXNlcjkyMDI4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9202899?v=4","gravatar_id":"","url":"https://api.github.com/users/flootr","html_url":"https://github.com/flootr","followers_url":"https://api.github.com/users/flootr/followers","following_url":"https://api.github.com/users/flootr/following{/other_user}","gists_url":"https://api.github.com/users/flootr/gists{/gist_id}","starred_url":"https://api.github.com/users/flootr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flootr/subscriptions","organizations_url":"https://api.github.com/users/flootr/orgs","repos_url":"https://api.github.com/users/flootr/repos","events_url":"https://api.github.com/users/flootr/events{/privacy}","received_events_url":"https://api.github.com/users/flootr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-09-24T08:36:24Z","updated_at":"2018-09-27T10:11:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/27394","html_url":"https://github.com/Automattic/wp-calypso/pull/27394","diff_url":"https://github.com/Automattic/wp-calypso/pull/27394.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/27394.patch"},"body":"I mistakenly removed the `he` dependency in #27389. This PR updates `he` to `1.2.0` which was the original purpose of 27389.\r\n\r\n### Testing instructions\r\n\r\nI'm not entirely sure what is the best way to test this. Basic functionality should be [covered through tests](https://github.com/Automattic/wp-calypso/blob/master/client/lib/formatting/test/index.js#L97). I'd need to trigger that function on the server side which I'm not sure how to do. I smoke tested Calypso (incl. SSR) and couldn't spot any obvious regressions.\r\n\r\nICFY result is clean as well:\r\n\r\n```\r\nDelta:\r\nno changes in production JS\r\n```"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/425035993","html_url":"https://github.com/Automattic/wp-calypso/pull/27394#issuecomment-425035993","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27394","id":425035993,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTAzNTk5Mw==","user":{"login":"ockham","id":96308,"node_id":"MDQ6VXNlcjk2MzA4","avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T10:11:25Z","updated_at":"2018-09-27T10:11:25Z","author_association":"CONTRIBUTOR","body":"Can we maybe change https://github.com/Automattic/wp-calypso/blob/02d21af3fb74af4fbfb6ad3ff7252b4585636f68/client/lib/formatting/decode-entities/node.js#L2 to\r\n\r\n```js\r\nexport { decode as default } from 'he';\r\n```\r\n\r\nwhile we're here? I guess that'll make it easier for posterity to grep `from 'he'` :wink: \r\n\r\n(Testing this locally, I've noticed that tests aren't really reliably covering functionality here. I think because of the `jsdom` pragma, they're really always looking for the client side code. I'll push a few commits to ensure we get this properly covered by tests.)"}}
{"actor":{"display_login":"ockham"}}